text stringlengths 0 1.8k |
|---|
[3084.26 --> 3085.20] And so, we've cut over to that. |
[3085.30 --> 3086.00] I have my branch. |
[3086.72 --> 3088.68] It's like, I said it was, what did I tell you? |
[3088.68 --> 3092.54] How many percentage points did I have done when I told you the other day, Gerhard? |
[3092.74 --> 3094.06] I think it was like 90%. |
[3094.06 --> 3095.80] Yeah, 90% is what I remember. |
[3096.46 --> 3096.64] Yeah. |
[3096.76 --> 3098.88] So, probably I'm at like 94% now. |
[3099.54 --> 3101.18] And then here comes an issue. |
[3101.42 --> 3102.68] Issue number 393. |
[3104.64 --> 3106.46] Hit our GitHub issues, which we'll link up. |
[3106.46 --> 3112.86] Newsletter links proxy encodes special URLs with HTML instead of percent based. |
[3113.50 --> 3117.92] This is a tiny little bug that was just interesting to me. |
[3117.98 --> 3132.60] So, what happened is, in our changelog weekly newsletter, which goes out every Sunday morning, includes all the shows from that week, every episode we put out, as well as all the news and the links and the repos and the commentary for the week. |
[3132.60 --> 3139.22] We linked to Chris Manson's post called It's All Gravy. |
[3140.68 --> 3152.64] And his website is chris.manson.ie, probably because he loves Internet Explorer, slash its-all-gravy. |
[3153.14 --> 3156.46] Only its is a contraction, right? |
[3156.54 --> 3158.36] So, it's I-T apostrophe S. |
[3159.26 --> 3161.32] And the son of a gun left the apostrophe in there. |
[3161.32 --> 3162.86] Now, I'm giving him a hard time because I know Chris. |
[3162.92 --> 3164.24] He's a JS Party listener. |
[3164.58 --> 3165.44] Hangs out in the chat. |
[3166.54 --> 3169.64] And he left that apostrophe in the URL. |
[3169.86 --> 3172.42] First of all, isn't that just like blasphemous right there? |
[3172.48 --> 3174.90] How can you throw an apostrophe in your URL? |
[3175.02 --> 3175.82] Clean URLs, people. |
[3175.82 --> 3176.78] Mm-hmm. |
[3177.42 --> 3195.26] But what happened with that apostrophe is the way that we encode that creates the HTML encoding instead of percent base, which you'd expect in the URL, which caused people that clicked on that link in our newsletter to go to a web page, which was a 404, because it was incorrect. |
[3195.26 --> 3202.00] Now, certain browsers actually manage it okay, and like the apostrophe looks fine in the address bar and everything, which I thought was kind of interesting. |
[3202.80 --> 3203.02] Mm-hmm. |
[3203.62 --> 3213.02] And so, I thought, here's a bug I should chase down while not working on this uploads to the cloud branch that I'm supposed to be working on. |
[3213.02 --> 3217.24] And so, I started to figure out, okay, mystery time. |
[3217.40 --> 3218.56] What is going on here? |
[3219.88 --> 3227.66] So, I dive into our code base, and I find the line of code in question, and everything looks legit to me. |
[3227.84 --> 3230.30] And then I realized, okay, I'm calling this Phoenix. |
[3230.48 --> 3233.98] So, we are an Elixir Phoenix application for those who haven't been following along the whole time. |
[3235.78 --> 3238.06] And at a certain point, we call into Phoenix. |
[3238.06 --> 3245.62] And Phoenix has an HTML library that generates HTML, and there's a function called link. |
[3245.84 --> 3250.08] So, this is, if you're familiar with, every web framework has like a link function. |
[3250.28 --> 3253.44] You know, link to was Rails' invention, which everybody's pretty much copied. |
[3253.92 --> 3255.54] Phoenix's link works very similarly. |
[3256.82 --> 3262.88] And so, all we're doing is calling that and just passing it the URL, which has the apostrophe in it. |
[3262.88 --> 3270.66] And so, I started digging a little deeper, and I started thinking, ah, it's like, whatever's happening is outside of my domain, right? |
[3270.72 --> 3273.06] It's a dependency that's doing it. |
[3274.02 --> 3276.14] So, I don't know, Gerhard, what do you do in this circumstance? |
[3276.68 --> 3279.20] You got a dependency that's not doing something totally right? |
[3279.62 --> 3280.66] What's your first move? |
[3282.24 --> 3284.18] I guess you're more of an ops guy. |
[3284.30 --> 3287.56] So, maybe you haven't, your developer chops are maybe rusty, but what's your interesting? |
[3287.58 --> 3288.18] No, not really. |
[3288.50 --> 3288.92] Not really. |
[3289.02 --> 3289.42] Okay, good. |
[3289.42 --> 3294.98] So, I would look at an issue to see if there is an issue in the repo for the dev. |
[3295.98 --> 3302.24] I would try and find the code, see what happened around it, like I would call a blame, see if that is different. |
[3303.10 --> 3313.72] And if I can't find anything, I would just open an issue on that repo, explain my problem, link to my code, and ask the developers, hey, how would you solve this? |
[3313.84 --> 3314.42] What do you think? |
[3314.68 --> 3315.22] Is it legit? |
[3315.86 --> 3316.88] Am I holding it wrong? |
[3317.60 --> 3318.04] Yeah, exactly. |
[3318.04 --> 3318.74] What's the problem here? |
[3319.42 --> 3325.24] Yeah, so, the interesting thing about this one is I'm not really savvy with these character encodings. |
[3325.58 --> 3330.06] And I'm not sure why it's doing the HTML encoding versus the URL encoding. |
[3330.54 --> 3333.28] But my first question is, like, is this even a bug? |
[3333.56 --> 3336.36] Or is this just like the way it would work if you pass it on an apostrophe? |
[3336.36 --> 3343.06] And so, when I start to have these questions, you laid out a very clear path to potential victory. |
[3344.06 --> 3345.24] But I'm lazier than you. |
[3345.30 --> 3347.72] So, my first thing is, like, am I running the latest version? |
[3347.98 --> 3349.22] Like, that's just what I ask myself. |
[3349.44 --> 3353.98] You know, like, maybe this was fixed between, you know, my version and now. |
[3353.98 --> 3357.02] And so, my first step is, well, let's just upgrade stuff. |
[3357.46 --> 3362.86] And I start to, even if it's like a procrastinate coding thing, I'm like, I'm going to go check out my depths tree and see how old everything is. |
[3363.18 --> 3364.56] And a bunch of stuff was out of date. |
[3364.56 --> 3366.60] So, this begins the yak shave. |
[3366.70 --> 3369.02] So, instead of fixing that, I'm like, here's what I'm going to do. |
[3369.10 --> 3370.32] I'm going to update all of our depths. |
[3370.50 --> 3370.94] Update everything. |
[3371.08 --> 3372.02] Oh, my goodness me. |
[3372.16 --> 3372.36] Okay. |
[3372.74 --> 3373.94] What can possibly go wrong? |
[3374.26 --> 3374.58] Exactly. |
[3375.22 --> 3377.48] So, we were on Phoenix 1.5. |
[3378.32 --> 3379.82] And 1.6 was out. |
[3380.62 --> 3385.34] Most Elixir packages do a pretty good job of following semantic versioning. |
[3385.44 --> 3386.86] So, I knew this was a minor upgrade. |
[3387.04 --> 3388.38] So, there are some breaking changes. |
[3388.68 --> 3391.16] But, or no, a major upgrade breaks changes. |
[3391.26 --> 3393.06] There shouldn't have been any API changes, right? |
[3393.76 --> 3394.06] Mm-hmm. |
[3394.52 --> 3394.80] Yeah. |
[3394.96 --> 3396.20] So, this one kind of bit me. |
[3396.26 --> 3397.72] So, there were API changes. |
[3397.98 --> 3398.24] Okay. |
[3398.50 --> 3400.30] So, I thought I could just safely upgrade. |
[3401.88 --> 3403.56] And I did all the auto upgrades. |
[3403.56 --> 3409.86] So, inside of Elixir's mix tool, if you have patch version upgrades, it'll just auto do those for you. |
[3409.94 --> 3410.50] Like, they're green. |
[3410.62 --> 3412.96] You can just upgrade those because they're assuming semantic versioning. |
[3413.06 --> 3414.80] So, I did all those, ran the tests. |
[3414.88 --> 3415.56] Everything was fine. |
[3416.14 --> 3420.30] Then I went to upgrade Phoenix, which was a minor version upgrade, 1.5 to 1.6. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.