text stringlengths 0 1.8k |
|---|
[3420.64 --> 3421.62] Got that done. |
[3421.72 --> 3424.04] While it was kind of doing its thing, I was like, well, I'm going to go. |
[3424.06 --> 3426.64] I'll read the change log and see what's going on. |
[3427.02 --> 3432.30] And I did notice that they made a breaking change, which I guess that's not Sember. |
[3432.38 --> 3433.34] So, they should have went to 2.0. |
[3433.34 --> 3433.52] No. |
[3433.72 --> 3436.40] They don't want to go to 2.0 because it's too major or whatever. |
[3437.06 --> 3438.14] But I did notice it. |
[3438.22 --> 3438.44] Okay. |
[3438.46 --> 3440.58] And I'm like, oh, man, this is something that I need to look at. |
[3440.58 --> 3444.16] So, I did the upgrade to Phoenix 1.6. |
[3444.80 --> 3446.40] Had some failing tests. |
[3446.56 --> 3447.32] So, I was like, all right, good. |
[3447.36 --> 3450.40] My tests are testing things and they changed the API. |
[3451.36 --> 3453.52] And so, I'm going to have that. |
[3453.66 --> 3454.62] But it's like two changes. |
[3454.84 --> 3456.28] So, what did they change? |
[3456.28 --> 3465.42] Well, the way Phoenix works is as it passes the request data from your controllers down |
[3465.42 --> 3470.50] into your views and to be used in the template, there's this bag of data called assigns. |
[3471.20 --> 3476.60] And in the assigns, there's a bunch of – it's literally a map or a struct or a dictionary |
[3476.60 --> 3478.90] or a hash depending on what your language choice is, right? |
[3478.90 --> 3480.58] And so, it's keys and values. |
[3480.94 --> 3487.28] And there were two keys that no longer exist, view module and view template. |
[3488.06 --> 3489.76] And what do these keys hold in them? |
[3489.82 --> 3496.32] Well, they hold in the information of what's the currently active or being used module that's |
[3496.32 --> 3499.10] handling this request and which template is going to be used to render. |
[3500.80 --> 3502.18] So, I did find those. |
[3502.30 --> 3503.96] There's like two places I was using those. |
[3504.68 --> 3505.74] And I changed them. |
[3506.22 --> 3507.40] And there's like a new way of doing it. |
[3507.46 --> 3507.62] Fine. |
[3507.62 --> 3509.68] And I upgrade. |
[3509.98 --> 3510.84] And all my tests pass. |
[3511.00 --> 3511.90] And so, what do I do? |
[3511.94 --> 3512.64] I ship it, baby. |
[3512.82 --> 3513.52] I send it out there. |
[3514.54 --> 3515.66] And it's all good. |
[3515.94 --> 3521.04] And then I start to realize via Twitter that our Twitter embed is broken. |
[3522.28 --> 3525.42] It's just showing like the default news and podcasts for developers thing. |
[3526.14 --> 3529.72] And like an old or like a stock share image. |
[3529.84 --> 3534.06] It's not doing – we actually have player embeds where you can click play right there |
[3534.06 --> 3535.68] in Twitter and start playing the episode. |
[3535.68 --> 3541.78] And so, that Phoenix upgrade, even though I thought I covered all my bases, broke all |
[3541.78 --> 3545.70] the metadata on all of our pages across the entire site. |
[3546.38 --> 3546.94] Wow. |
[3547.30 --> 3548.98] Which led to Twitter embeds breaking. |
[3548.98 --> 3554.28] All third-party integrations that are based on like the meta elements in your HTML. |
[3555.08 --> 3555.40] Busted. |
[3557.08 --> 3560.56] And so, that led to me refactoring our entire meta module. |
[3562.52 --> 3564.40] Because that data is gone. |
[3564.50 --> 3568.62] And the entire thing in that module is like, which view am I? |
[3568.92 --> 3570.02] And which template am I? |
[3570.08 --> 3570.34] Okay. |
[3570.48 --> 3571.48] Here's my meta information. |
[3571.48 --> 3574.92] And so, I refactored that entire meta module. |
[3575.44 --> 3576.32] Took me a few hours. |
[3576.92 --> 3578.58] I'm not even happy with the way it works now. |
[3578.62 --> 3579.48] I liked it better before. |
[3580.48 --> 3581.66] And I fixed it. |
[3582.44 --> 3585.04] And the yak was shoven or shaven. |
[3585.34 --> 3586.40] What's past tense for shave? |
[3586.54 --> 3586.90] Shaven. |
[3587.30 --> 3588.08] I shaved him. |
[3588.30 --> 3589.10] I shaved that sucker. |
[3589.78 --> 3591.94] But I did not get our cloud uploads done. |
[3592.06 --> 3592.98] So, that's my excuse. |
[3593.06 --> 3593.66] And I'm sticking with it. |
[3593.66 --> 3600.52] Well, first of all, you were very determined to shave this yak. |
[3602.64 --> 3603.34] Yes, I was. |
[3603.36 --> 3606.98] And I'm glad that you didn't give up until it was all done. |
[3607.28 --> 3608.10] Success, baby. |
[3609.22 --> 3609.66] Yes. |
[3610.00 --> 3615.70] Well, the question is, did the upgrade even shave or did it even fix the original URL issue? |
[3616.22 --> 3617.84] No, it's not a bug. |
[3618.00 --> 3619.08] It's a feature, I think. |
[3622.44 --> 3623.28] That's the best. |
[3623.28 --> 3625.28] By the way, the number is 394. |
[3625.34 --> 3625.76] I checked. |
[3625.86 --> 3626.78] It's not 393. |
[3627.10 --> 3627.50] Oh, sorry. |
[3628.58 --> 3629.00] That's okay. |
[3629.26 --> 3629.66] That's okay. |
[3630.60 --> 3634.24] Second of all, this reminds me of exactly what happened. |
[3634.38 --> 3636.44] Like, you said that you had to shave a yak. |
[3637.36 --> 3639.04] And we had to get together, right? |
[3639.08 --> 3639.88] Where I upgraded. |
[3640.18 --> 3643.72] I've set up the new version of, like, our Kubernetes deployment. |
[3644.80 --> 3649.70] And it's amazing how I was shaving a similar yak. |
[3650.18 --> 3650.48] Okay. |
[3650.48 --> 3654.06] You know how you do, like, an upgrade of Kubernetes, like, from 120 to 121? |
[3654.14 --> 3657.24] And then you think, hmm, maybe I should upgrade Ingress Nginx. |
[3657.90 --> 3659.86] Or, even better, I should replace it with traffic. |
[3660.26 --> 3660.52] Okay. |
[3660.76 --> 3661.12] Why? |
[3661.24 --> 3662.56] Because then we don't have cert manager. |
[3662.96 --> 3663.30] Excellent. |
[3663.52 --> 3665.64] So traffic can, you know, take care of all of that. |
[3666.12 --> 3666.38] Great. |
[3667.38 --> 3668.42] What about external DNS? |
[3668.84 --> 3669.78] Let's do that as well. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.