text stringlengths 0 2.35k |
|---|
**Angelica Hill:** What, doing a PR review? |
**Anderson Queiroz:** By poking people? |
**Natalie Pistunovich:** Yeah. With limiting this. This is a fun way to discuss this. And on the way you discuss error throwing, and correct errors, and also exceptions, and so on. |
**Angelica Hill:** Okay... |
**Natalie Pistunovich:** Goroutines, if you suddenly have to split into that... Yeah. |
**Anderson Queiroz:** \[34:04\] Talking about teaching Go in unusual ways... I was thinking today someone should write a Go program that simulates how the queue for the food works here, and then make a proper Go concurrent, good program for that... Because the queues are necessary here. You have a lot of contingence. I... |
**Natalie Pistunovich:** Because you have lots of food stations that people miss? |
**Anderson Queiroz:** That's the point, you have a lot of food stations. You can have a lot of concurrent access to that. But no, \[unintelligible 00:34:31.24\] A huge queue, and everyone goes to everything that they don't want. \[unintelligible 00:34:35.28\] |
**Natalie Pistunovich:** They didn't read the docs. They don't know what's the food. |
**Anderson Queiroz:** They didn't read the docs, exactly. |
**Natalie Pistunovich:** Everything can be explained with tech |
**Angelica Hill:** Lesson learned. Always read the docs first... And if they're bad docs, then... |
**Natalie Pistunovich:** Improve them. |
**Angelica Hill:** ...improve them! |
**Anderson Queiroz:** Open a pull request for the docs. |
**Angelica Hill:** Yes. \[laughs\] |
**Anderson Queiroz:** That's something that I love... If I'm reading documentation and it's easy to open a pull request, \[unintelligible 00:35:02.03\] fail or inconsistent something, I open a pull request. I think it's such a valuable contribution, and it's so easy most of the times... I love these docs that have the ... |
**Natalie Pistunovich:** Yeah. |
**Angelica Hill:** I feel like I get into a bit of a rabbit hole, and I have to stop myself editing documentation... Because it went from actually making it correct to actually just implying my personal stylistic choices when writing documentation, and phrasing... Like, "I like this adjective slightly better, actually.... |
**Anderson Queiroz:** Oh, yeah... |
**Angelica Hill:** So I had to pull back to be like "Okay, review for correctness, not for like "I want a comma here." |
**Anderson Queiroz:** I think that's so hard... For me, as a non-native speaker, sometimes I don't think this sentence is correct. I think it's missing a comma, I think it's missing an article. And it was like, "Honestly, you don't know English so much. I don't even know if you could do that in proper Portuguese, like ... |
My take is if I believe it's compromising their understanding, I'm gonna probably suggest something. And also, sometimes when the comment is there for a long time, I just make that change and suggest someone is gonna review it |
**Natalie Pistunovich:** I sometimes put into some AI, if I don't understand something, and I read it 2-3 times, and I keep staring at it... I'm like, "Just explain that to me in other words", and that helps. |
**Anderson Queiroz:** Good. AI... \[laughs\] |
**Natalie Pistunovich:** It's like pinging somebody... But yeah. But also make the changes, just like you, because I think if I as a non-native don't understand this, there must be another non-native that gets lost there... And clarity is important. |
**Anderson Queiroz:** Yeah. |
**Natalie Pistunovich:** Let's say you're interviewing, whether you are the candidate or you are the interviewing person. And part of the interview is reviewing a pull request from somebody from your team. What tips do you have for somebody to do this well? |
**Anderson Queiroz:** I've actually never been really in these shoes, on either side. I've been asked - in one of the codebases, any of the codebases, what would you change, or something? I think at the end of the day, a lot of the time, to interview for culture fit, and a person that's nice, and it's good to work with... |
Usually, in an interview you don't have so much time... So I would go for "Oh yeah, this name is not ideal. The effective goal - there is a section on name conventions that explains why it should be like that. So as it's in Go, it's better to be like that." |
\[38:03\] So try always to bring something to support your views. And when it's an opinion - and that's something that I really do in pull requests; when it's my opinion, I say "Look, this is my opinion. I believe that's better, because this, this and this. It's up to you, because I don't see a flaw here. I just think ... |
**Angelica Hill:** If you were interviewing someone and their task was to review a PR, what would be things that they did that would maybe have you like "Oh, no... I don't know about that..." |
**Anderson Queiroz:** A thing would be to be aggressive, and impolite. To just diminish the code and say the code is bad, or something... An even if they show that they don't know what they're doing. |
I think if you interview people, you know some people don't know what they're doing, or they're just trying to fool you. If it's such \[unintelligible 00:38:53.17\] |
**Natalie Pistunovich:** It's better to say you don't know. |
**Anderson Queiroz:** It's not like that... It's like, "Great! Just go!" And you know, I just go "Yeah. Mm-hm." I just incentivize. "Yeah, go. Go. Please." And at the end, "Ah yeah, thank you very much. We're gonna be in contact." |
**Natalie Pistunovich:** Yeah. And definitely staying honest is a lot better than making things up. |
**Anderson Queiroz:** Yeah. Please say "I don't know." I think if someone to me in an interview says "Look, I don't know. I don't remember." Or "I don't know, and I think in that place I can get the information" - you're always scoring a hundred points with me. If you're trying to just BS me through it... Nah. |
**Natalie Pistunovich:** That's fair. |
**Angelica Hill:** Anderson will not be having that. |
**Break:** \[39:34\] |
**Angelica Hill:** Okay, so we have touched on this a little earlier in the episode, but I wanna dig a little bit deeper... In fact, I will ask you a question first. Are you engaged in any kind of open source projects? I know you said that you contribute to Go a little, is that a world in which you feel like you have e... |
**Anderson Queiroz:** So I can cheat my answer, right? |
**Angelica Hill:** Okay. |
**Anderson Queiroz:** Yes, I'm involved in open source, because I work at Elastic, and the majority of the wrappers are open source, right? But as a 100% open source contribution that I'm not working for the company, no. It's something that I always wanted. As I said, I managed to get a commit too in Go, but I haven't ... |
**Angelica Hill:** Reignite that passion. |
**Anderson Queiroz:** Let's see if it's gonna happen. But no, I'm not really engaged on, let's say an external open source project, that's not part of my daily job. |
**Angelica Hill:** And when you have done it, is part of the reason why you think it's difficult to engage fully - is anything to do with the difficult or the different process to put in a PR when it is an open source project, as opposed to internal, like within work PR reviews and submission? |
**Anderson Queiroz:** I think to me what's always difficult is to find something meaningful to work. You don't know what you can do... There is a tag, "First good issue" and so on, but I think that's the point - we're lost, and we don't have someone to go "Oh, please help me." Or "I tried that." Or "Shall I do that?" B... |
\[44:12\] So I think that's a lot of \[unintelligible 00:44:12.29\] if you would have something -- not necessarily a mentor, but perhaps a channel to ask questions. And even say "Oh, I wanna take this issue." Because sometimes the good first issues - they opened one year ago. And it's like, "Dude, I don't know if it's ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.