text stringlengths 0 2.35k |
|---|
**Angelica Hill:** Yeah. Fair enough. And do you think there's a higher bar as to what you're willing to put in as a PR for an open source project? I speak about this from my own personal experience... When I was trying to get into like "Okay, I wanna contribute to open source." "Oh, you should just go in and do like a... |
**Anderson Queiroz:** I think -- and I talk for myself -- I always had the feeling to contribute to open source projects the bar is super-high. You have to be an expert developer, and everything... And the reality is no. The issue is there, the problem exists... I think this is the best advice I can do to any junior de... |
I was trying to submit pull requests for the Kubernetes code, just fixing linting issues. I understand a bit how that piece of code worked. And it was like "Oh, how they structured that. And look at the packages", because I had to read through the packages to fix linting issues. I think one PR got merged, the other one... |
**Natalie Pistunovich:** That is a popular opinion, I bet. It applies to many fields in life. |
**Anderson Queiroz:** That's true. |
**Angelica Hill:** Just do it. |
**Anderson Queiroz:** Yes. Try. |
**Natalie Pistunovich:** Yeah. Well then, alright... The fun part. Unpopular opinions. Before we started the recording, Anderson, you mentioned you have several unpopular opinions, and you were wondering whether you should go for the most -- how did you phrase that? I forgot. You used a good word. The most... |
**Anderson Queiroz:** Controversial? |
**Natalie Pistunovich:** Yeah, exactly. Or the least controversial. |
**Anderson Queiroz:** Yeah. I'll pick a controversial one... But I can explain. As I said on the PR, you can explain. You should not write more than 100 columns. Write your code; your code should not really pass 100 columns. |
**Natalie Pistunovich:** From width. |
**Anderson Queiroz:** Yeah. First things - there's no magical number like 100 cut. I would say 110 is okay, when it's really bad to cut. 120 is almost a hard limit; don't really go over that. Why? First things first. Do you read books on landscape? No. Right? Come on, I think everyone had that; we got this email, you'r... |
**Angelica Hill:** Like you're watching tennis. |
**Anderson Queiroz:** I feel like a typewriter that goes from side to side. So it's hard to read, because we don't read in landscape, we read in portrait. The second thing is not everyone has got a screen as big as yours. There are people coding in 14, in 13 inches. They want to have two tabs open, perhaps. So if you g... |
**Natalie Pistunovich:** \[48:14\] I want to disappoint you that I think I agree with you, and I even take this into writing emails. I try to keep it -- I don't know how many characters that is, but I sometimes break lines. Like, one sentence into 3-4 lines, just so it stays, so you don't have to scroll in case images,... |
**Angelica Hill:** I think you're unfortunately preaching to the choir with me and Natalie. We're both like, "Yes. Please! My neck will hurt." |
**Anderson Queiroz:** Perhaps in Go -- |
**Natalie Pistunovich:** A Chrome plugin that just truncates things for you. |
**Angelica Hill:** Yeah. |
**Anderson Queiroz:** Perhaps in Go. But I think if you go to Java, the things are long there. |
**Natalie Pistunovich:** Yeah, 100 characters is just the function name. |
**Angelica Hill:** Oh, my gosh... \[laughter\] I feel like that one was a good one... But if we have time, Natalie, I wanna hear another one. |
**Natalie Pistunovich:** Yeah. |
**Angelica Hill:** I want us to get an unpopular one from you. |
**Anderson Queiroz:** Oh, my God... |
**Angelica Hill:** What was the other one that you were thinking about saying, that you cheekily in your mind were like "No, I'm not gonna say that." |
**Anderson Queiroz:** No, I think this one's like the unpopular/kind of popular... |
**Angelica Hill:** Okay... |
**Anderson Queiroz:** I mean, I see a lot happening, so perhaps an unpopular... Return new is wrong. Period. You have to wrap the errors and add more context. Always. I cannot count how many times I had to go through the code and dig deep and deep and deep to discover where this error came from. You know, it's like whe... |
So return new is wrong, you have to wrap your errors. Now you don't have an excuse. You have error wrapping in the standard library. |
**Natalie Pistunovich:** So you think wrapping errors will be an unpopular opinion. |
**Anderson Queiroz:** Yeah. |
**Angelica Hill:** I feel like this second one is gonna probably be more unpopular. |
**Anderson Queiroz:** Yeah. Because a lot of people just return the error. |
**Angelica Hill:** Yeah. |
**Natalie Pistunovich:** Interesting. |
**Anderson Queiroz:** That's one of the things that I look in pull requests. Everyone's like "Dude, could you wrap that?" And then it goes back on that. If it's my repo, my code, I might say "No." Now, when I say "my", please, my team's, right? I don't have this possessive. I think code must be owned by a group, and it... |
**Angelica Hill:** I like that one. I'm also having so many more ideas. This always happens when me and you have an episode, Natalie. I'm like "So many more episode ideas..." |
**Natalie Pistunovich:** Write them all down! |
**Angelica Hill:** "Does your code belong to you, or to the world...?" |
**Anderson Queiroz:** I mean, in open source that's definitely a question, right? |
**Natalie Pistunovich:** Yeah, also with AI tools that are writing code, that's a question. |
**Angelica Hill:** Yeah. |
**Anderson Queiroz:** Oh God, yeah. |
**Angelica Hill:** Who is the true owner of code...? |
**Anderson Queiroz:** Yeah, that's a good one. |
**Natalie Pistunovich:** Yeah, licensing is interesting, for sure, within Copilot and friends. |
**Anderson Queiroz:** When the AI put the bug in production, who do you blame? Who ran the AI, who wrote the AI... |
**Natalie Pistunovich:** ...or who reviewed the PR? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.