text stringlengths 0 2.35k |
|---|
[454.86 --> 459.56] we like to generalize the industry say that the more senior you are, the less you're going |
[459.56 --> 461.62] to be writing PRs and the more you're going to be reviewing them? |
[462.00 --> 467.22] I think the more you're a senior, you're going to look for more things, right? |
[467.22 --> 471.54] So, because you're going to be able to evaluate, if you're good in the language, you can evaluate |
[471.54 --> 473.24] the language, the conventions, right? |
[473.28 --> 476.04] You can evaluate the general soft architecture, right? |
[476.38 --> 480.36] When you're in a role that as a senior, you are also a mentor, there is a lot of like |
[480.36 --> 481.68] mid and juniors in the team. |
[481.76 --> 485.52] I think we're reading a lot because you have this responsibility with the team, with the |
[485.52 --> 485.94] product. |
[485.94 --> 492.68] But if you're in a company where everyone's senior, senior, in Berlin, definitely the titles |
[492.68 --> 493.26] are inflated. |
[493.78 --> 499.10] So, you know, perhaps everyone doesn't need this level of attention and mentoring or teaching |
[499.10 --> 501.66] that happens a lot through PRs. |
[502.12 --> 503.12] That's an interesting question. |
[503.22 --> 503.32] Yeah. |
[503.36 --> 507.34] Because some time ago, they added this like graph of contributions that is no longer just |
[507.34 --> 510.90] the squares, but also what type do you read more? |
[510.98 --> 511.90] Do you make more issues? |
[512.06 --> 513.16] Do you review and so on? |
[513.16 --> 517.22] So if you can look at that, then you kind of know what people's roles are or see how |
[517.22 --> 518.68] it changes over time or something. |
[519.00 --> 522.82] If I showed you a load of graphs, would you be able to guess the seniority of that engineer? |
[523.30 --> 523.74] Perhaps. |
[524.12 --> 527.42] I think I looked quickly at mine and now it was 50-50. |
[527.76 --> 528.16] Nice. |
[528.38 --> 528.64] Okay. |
[528.70 --> 529.16] Pretty much. |
[529.48 --> 532.56] Do you think that that's the balance that most engineers would like? |
[533.16 --> 537.36] Or do you think that there is such thing as someone who prefers to be reviewing more than |
[537.36 --> 537.74] writing? |
[538.40 --> 542.86] I think when you think as a soft engineer that the passion is about writing, writing, |
[543.16 --> 545.12] right, they rather write code. |
[545.64 --> 551.38] I think at least either you want or you need to pass knowledge forward, right? |
[551.42 --> 554.10] So you're going to need to write, to read. |
[554.46 --> 557.06] I really like to review code for both reasons, right? |
[557.14 --> 562.02] One, because I have a passion for code and I am a quite methodic person. |
[562.02 --> 565.44] So I like to ensure that the code is good. |
[566.20 --> 567.84] The conventions are there. |
[568.22 --> 570.60] I'm super picky about proper error handling. |
[571.32 --> 575.72] So these are some things that if you're not handling the errors properly or you're really |
[575.72 --> 578.64] bad at the conventions, I'm going to be commenting there. |
[579.08 --> 584.58] But I have a special of commenting to ensure that I'm not overwhelming the other person or |
[584.58 --> 587.58] to feel like just complaining, saying that your job's bad. |
[587.58 --> 589.92] So you say you try to give feedback. |
[590.26 --> 592.04] You don't want to overwhelm the person. |
[592.62 --> 593.58] How do you do that? |
[593.66 --> 597.80] Like, is it that you limit yourself to, OK, I'm only going to put six comments? |
[598.04 --> 601.00] Is it the way in which you phrase your review? |
[601.12 --> 603.00] How do you make sure that you're not overwhelming? |
[603.96 --> 607.14] Yeah, I learn to experience any feedback. |
[607.32 --> 608.48] I put tags, right? |
[608.52 --> 613.74] So I start with PR with like suggestion or sometimes I put question, but a question is |
[613.74 --> 614.28] a question, right? |
[614.28 --> 619.62] You know, so it feels a bit redundant, but I put, and then I have blocker, right? |
[619.66 --> 622.56] And sometimes like suggestion slash go convention, right? |
[622.70 --> 628.56] Or depending on the repo, blocker slash go convention, you know? |
[628.64 --> 633.00] So I try to categorize suggestion, question, and blocker. |
[633.12 --> 634.34] I put blocker-ish. |
[634.48 --> 638.84] So basically blocker is either I see there is a problem in the code, right? |
[638.84 --> 644.96] So it needs a change or I believe there is a problem or I don't believe that this implementation |
[644.96 --> 645.64] is good. |
[645.76 --> 648.16] So at least you need to answer that, right? |
[648.20 --> 649.44] You can say like, it's agree with you. |
[649.82 --> 650.28] That's fine. |
[650.36 --> 652.46] But I need an explanation, right? |
[652.48 --> 653.66] So these are the blockers. |
[654.32 --> 655.48] Suggestion is exactly that. |
[655.54 --> 657.06] Like, I believe it can be better. |
[657.32 --> 662.14] If I were writing this code, I would do different, but you don't have to take it. |
[662.14 --> 664.60] Sometimes I put like a nit. |
[665.00 --> 669.78] It can be, you know, just erase this blank line between the function call and the error |
[669.78 --> 670.84] handling, right? |
[670.88 --> 671.78] This is a nit, right? |
[671.98 --> 672.82] Or typo. |
[673.28 --> 674.04] So these things. |
[674.24 --> 680.60] And then if I've never reviewed a PR from this person, or perhaps I see there's a lot |
[680.60 --> 685.78] of comments, I go to the person or even the PR, I put, look, there is this three categories. |
[685.90 --> 687.54] The only thing that's really important are the blockers. |
[687.54 --> 692.98] So the blockers, please comment or change the suggestions are suggestions. |
[693.30 --> 696.46] And as always, you're free to disagree a hundred percent, right? |
[697.02 --> 698.98] Just answer the blockers and talk to me. |
[699.28 --> 700.32] That's how I do. |
[700.76 --> 705.28] So you said that in some situations, it kind of makes sense to just speak in person instead |
[705.28 --> 708.14] of writing a lot, for example. |
[708.72 --> 709.56] Sometimes it's easier. |
[710.18 --> 712.36] I think sometimes speaking is better. |
[712.50 --> 714.42] Sometimes writing is better. |
[714.42 --> 719.04] And on pull requests, writing the pull requests is a lot slower, right? |
[719.08 --> 722.62] So sometimes it's worth jumping on a Slack chat. |
[722.78 --> 723.54] Is that right enough? |
[723.86 --> 724.82] Sometimes we talk. |
[725.46 --> 731.06] I think nowadays at Elastic, because we are distributed, it's a lot more through Slack |
[731.06 --> 733.00] rather than really a call. |
[733.66 --> 737.88] But sometimes I have jumped on a call for small things. |
[738.36 --> 741.48] And how do you decide when it's better to do this and when it's better to not? |
[741.48 --> 744.26] Do you have a thumb rule or is it all just feeling? |
[744.90 --> 748.98] If there is a lot of back and forth, it's easier to jump on a call or something that |
[748.98 --> 750.18] I really want to understand. |
[751.06 --> 755.72] But most of the times, I guess, I always could handle the chat. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.