Datasets:
willtheorangeguy
/
2022-Go-Time-Transcripts

Dataset card Data Studio Files
xet
 Community
text
stringlengths
0
2.35k
[756.18 --> 758.32] Now, Elastic is a distributed company, right?
[758.36 --> 760.42] So we write a lot more.
[760.96 --> 764.48] So it's a lot more common just to write than jump on a call.
[764.48 --> 766.98] I think jumping on a call is more personal.
[767.86 --> 771.58] So I feel if you're close to someone, it's easier.
[771.88 --> 773.92] You know, it feels more natural to jump on a call.
[774.12 --> 779.00] And if you don't know the person so well or something, you kind of end up just chatting.
[779.50 --> 783.10] So you say there's actually three types of kind of giving feedback.
[783.26 --> 785.28] One, writing in the pull request.
[785.72 --> 787.58] Two, writing on Slack.
[787.72 --> 789.28] And three, hopping on a call.
[789.90 --> 790.16] Yeah.
[790.66 --> 793.62] But on Slack, I use more to clarify.
[793.62 --> 794.74] Right?
[795.38 --> 798.16] Because it's specific about the code I'd rather have on the pull request.
[798.64 --> 800.60] It's kind of documented anyway, right?
[801.28 --> 801.64] It's right.
[801.70 --> 804.44] I was sure to explain why, what I'm saying.
[805.16 --> 811.08] Like, as I said, in my past company, I was really with this job to teach, to mentor and go.
[811.22 --> 813.52] I would link a lot of reference, right?
[814.08 --> 815.94] Also, because I learned in another company.
[816.26 --> 820.34] I remember my colleague and I would review a pull request of your new joiner.
[820.72 --> 822.48] You know, and say like, oh, yeah, this function is too long.
[822.48 --> 823.64] This function is too complex.
[824.04 --> 824.14] Right?
[824.16 --> 824.58] This happens.
[824.80 --> 827.58] And the guy was like, why?
[827.90 --> 829.56] Why did you butcher my pull request?
[829.74 --> 830.44] Are you guessing?
[830.58 --> 831.44] This is your opinion.
[832.00 --> 834.02] And I was like, that's true, right?
[834.04 --> 836.66] We don't have like a metric to say that.
[837.08 --> 839.58] But also it was a common sense between us.
[839.58 --> 841.62] So yeah, this is too big, you know, in the company.
[841.74 --> 843.08] But this guy was a new joiner.
[843.08 --> 844.28] So everything was different from him.
[845.06 --> 849.00] So I guess, yeah, clarifications, I can't do outside the pull request.
[849.14 --> 853.20] But I think it's important to document what's happening in the code there.
[853.20 --> 853.92] Mm-hmm.
[854.22 --> 857.30] In the code itself to kind of document, to make it self-explanatory.
[857.70 --> 858.10] Exactly.
[858.66 --> 862.38] So in terms of kind of, you talked about kind of giving feedback, not overwhelming.
[863.26 --> 868.44] Do you feel like PRs are also a good place to kind of, especially for more junior engineers,
[869.00 --> 871.24] give them like props on things they're doing well?
[871.44 --> 873.68] Like, oh, I really like the way you did this thing.
[873.84 --> 875.14] Or, oh, this is great.
[875.24 --> 877.36] Or this function is structured really well.
[877.84 --> 881.08] Do you feel like PRs are also a way to give positive feedback?
[881.08 --> 882.96] Yeah, I think it is.
[883.14 --> 884.10] It is important.
[884.90 --> 888.24] And it's something that I would like to do more as well.
[888.74 --> 893.22] I mean, I never go to a pull request to looking for errors or to try to diminish someone's job.
[893.54 --> 897.62] But at the same time, I go to a pull request looking for errors so they don't go to production.
[898.22 --> 898.40] Right?
[898.86 --> 904.94] At the end of the day, we are looking for problems and issues to prevent things bad going to production.
[905.04 --> 905.20] Right?
[905.24 --> 910.22] But I think it's super important to do the praise, to assert when someone does something nice.
[910.22 --> 914.26] Sometimes someone just fix something a bit random, but, you know, it's the same function.
[914.46 --> 917.24] It's not really going away from the aim of the pull request.
[917.38 --> 920.32] And then this is really good to praise, at least a thumbs up.
[920.66 --> 926.04] So we said that there are some stages that you escalate the communication to some way.
[926.42 --> 933.98] And definitely you want to include more like positive feedback that is not the correctness and so on or explain yourself.
[933.98 --> 941.14] What other changes would you make to the PR process based on pain points you have with the flow?
[941.48 --> 945.92] It's a really slow process because you write the code and then you submit the PR.
[946.76 --> 946.78] Right?
[946.88 --> 951.50] And then someone else's, sometimes more than WordPress, they have to stop and read it.
[951.80 --> 953.38] And how do you synchronize that?
[953.38 --> 956.54] And then I think it's going to depend a lot how companies do.
[956.76 --> 958.58] I've worked with a different process.
[959.22 --> 959.34] Right?
[959.38 --> 962.34] Some process, they ensure that the pull request would be reviewed.
[962.50 --> 963.44] Some not so often.
[964.12 --> 964.30] Right?
[964.82 --> 968.08] Now I'm definitely overwhelmed by GitHub notifications.
[969.20 --> 973.36] So sometimes it just, it slips through some PRs.
[973.42 --> 975.40] And then I get like days later, someone tag me.
[975.52 --> 977.58] And so can you give me a review?
[977.70 --> 978.68] Like, oh my God, sorry.
[979.24 --> 981.64] Because it's something that's kind of a bit of a ping pong?
[982.02 --> 984.38] Or does it happen more with new pull requests?
[984.70 --> 986.20] And that is when you have to re-review, right?
[986.24 --> 988.36] You do the first review and then you have to look again.
[988.64 --> 988.90] Yeah.
[989.24 --> 989.44] Right?
[989.48 --> 992.32] So to get the proper ping, it's hard.
[992.76 --> 995.40] And the other thing that, at least on GitHub, right?
[995.54 --> 998.32] I have used a bit of Bitbuck as well.
[998.78 --> 1002.52] I submit one, perhaps two PRs should go to the GoRepper.
[1002.52 --> 1003.80] So we've got it.
[1004.80 --> 1006.80] But on GitHub, it's really hard.
[1006.80 --> 1009.54] But when you do the first review, we ask you for changes.
[1009.78 --> 1014.48] And then if people do changes to see exactly what changed, right?
[1014.50 --> 1017.22] To get an MBA book, okay, I'm going to review just the changes.
[1017.48 --> 1018.34] Isn't this a new comment?
[1018.36 --> 1019.68] And if someone just forced.
[1019.70 --> 1020.50] Oh, forced push.
[1020.58 --> 1020.78] Okay.
[1021.26 --> 1023.48] If someone's a forced push, right?
[1023.98 --> 1029.00] So sometimes it's hard to get like just the bit that they have to re-review.
[1029.48 --> 1030.40] That's our main point.