Datasets:

---

Eathus

/

github-issues-negatives

Like 0

ERROR: type should be string, got "https://github.com/kubernetes/kubernetes/blob/76bad75c1e64e4b6af2c8aa1730b91ddbb0b2035/pkg/kubelet/pluginmanager/operationexecutor/operation_generator.go#L115\r\n\r\nI'm sorry, please forgive me, my English is not very good\r\n\r\nk8s version:\r\n1.25.3\r\n\r\nwhat happened:\r\nI deployed a csidriver on my k8s cluster, then I reboot the system.\r\nAfter reboot, I change some net config what make csidriver execute NodeGetInfo() failed.\r\nI back up the net config subsequently.\r\nHowever I can't get csidriver on my k8s cluster.\r\nI find some log \"Error calling CSI NodeGetInfo()\" in the kubelet log.\r\n\r\nexpect result:\r\nI hopo k8s can register the csidriver after install failed unless I unregister the csidriver.\r\n\r\nin this file: ``pkg/kubelet/pluginmanager/operationexecutor/operation_generator.go#L115``\r\nactualStateOfWorldUpdater update the cache before csi install \r\nwhich make ``reconcile`` don't unregister and register the csidriver after meet an install csi error\r\n\r\nI think it can be modified like this (experimental)\r\n```go\r\nfunc (og *operationGenerator) GenerateRegisterPluginFunc(\r\n\tsocketPath string,\r\n\ttimestamp time.Time,\r\n\tpluginHandlers map[string]cache.PluginHandler,\r\n\tactualStateOfWorldUpdater ActualStateOfWorldUpdater) func() error {\r\n\r\n\tregisterPluginFunc := func() error {\r\n\t\tclient, conn, err := dial(socketPath, dialTimeoutDuration)\r\n\t\tif err != nil {\r\n\t\t\treturn fmt.Errorf(\"RegisterPlugin error -- dial failed at socket %s, err: %v\", socketPath, err)\r\n\t\t}\r\n\t\tdefer conn.Close()\r\n\r\n\t\tctx, cancel := context.WithTimeout(context.Background(), time.Second)\r\n\t\tdefer cancel()\r\n\r\n\t\tinfoResp, err := client.GetInfo(ctx, &registerapi.InfoRequest{})\r\n\t\tif err != nil {\r\n\t\t\treturn fmt.Errorf(\"RegisterPlugin error -- failed to get plugin info using RPC GetInfo at socket %s, err: %v\", socketPath, err)\r\n\t\t}\r\n\r\n\t\thandler, ok := pluginHandlers[infoResp.Type]\r\n\t\tif !ok {\r\n\t\t\tif err := og.notifyPlugin(client, false, fmt.Sprintf(\"RegisterPlugin error -- no handler registered for plugin type: %s at socket %s\", infoResp.Type, socketPath)); err != nil {\r\n\t\t\t\treturn fmt.Errorf(\"RegisterPlugin error -- failed to send error at socket %s, err: %v\", socketPath, err)\r\n\t\t\t}\r\n\t\t\treturn fmt.Errorf(\"RegisterPlugin error -- no handler registered for plugin type: %s at socket %s\", infoResp.Type, socketPath)\r\n\t\t}\r\n\r\n\t\tif infoResp.Endpoint == \"\" {\r\n\t\t\tinfoResp.Endpoint = socketPath\r\n\t\t}\r\n\t\tif err := handler.ValidatePlugin(infoResp.Name, infoResp.Endpoint, infoResp.SupportedVersions); err != nil {\r\n\t\t\tif err = og.notifyPlugin(client, false, fmt.Sprintf(\"RegisterPlugin error -- plugin validation failed with err: %v\", err)); err != nil {\r\n\t\t\t\treturn fmt.Errorf(\"RegisterPlugin error -- failed to send error at socket %s, err: %v\", socketPath, err)\r\n\t\t\t}\r\n\t\t\treturn fmt.Errorf(\"RegisterPlugin error -- pluginHandler.ValidatePluginFunc failed\")\r\n\t\t}\r\n\r\n\t\tif err := handler.RegisterPlugin(infoResp.Name, infoResp.Endpoint, infoResp.SupportedVersions); err != nil {\r\n\t\t\treturn og.notifyPlugin(client, false, fmt.Sprintf(\"RegisterPlugin error -- plugin registration failed with err: %v\", err))\r\n\t\t}\r\n\r\n\t\tgo func() {\r\n\t\t\t_ = og.notifyPlugin(client, true, \"\")\r\n\t\t}()\r\n\r\n\t\terr = actualStateOfWorldUpdater.AddPlugin(cache.PluginInfo{\r\n\t\t\tSocketPath: socketPath,\r\n\t\t\tTimestamp: timestamp,\r\n\t\t\tHandler: handler,\r\n\t\t\tName: infoResp.Name,\r\n\t\t})\r\n\t\tif err != nil {\r\n\t\t\tklog.ErrorS(err, \"RegisterPlugin error -- failed to add plugin\", \"path\", socketPath)\r\n\t\t}\r\n\t\treturn nil\r\n\t}\r\n\treturn registerPluginFunc\r\n}\r\n```"