author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 26.04.2018 12:23:26 | 14,400 | 2dbbf895e7f788f08619e5d292f5dddec349b6b6 | [native] codeVersion -> 12
See below commits for why we're doing this | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 11\n- versionName \"0.0.11\"\n+ versionCode 12\n+ vers... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 12
See below commits for why we're doing this |
129,187 | 27.04.2018 15:05:09 | 14,400 | 51c5e95b84f54f5f25e4e0a3382d919bb9f2257f | [server] Reorder some statements in pingResponder to satisfy Flow | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -12,7 +12,6 @@ import invariant from 'invariant';\nimport { ServerError } from 'lib/utils/errors';\nimport { mostRecentMessageTimestamp } from 'lib/s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Reorder some statements in pingResponder to satisfy Flow |
129,187 | 01.05.2018 13:55:21 | 14,400 | 1d2a81858018d9322d64d545e054d38ab5eb0623 | [web] Remove react-helmet
(This wasn't being used) | [
{
"change_type": "DELETE",
"old_path": "web/flow-typed/npm/react-helmet_v5.x.x.js",
"new_path": null,
"diff": "-// flow-typed signature: c0fb6fa2ea9be0c11b3ced1f95a09e56\n-// flow-typed version: 5af8bb5901/react-helmet_v5.x.x/flow_>=v0.53.x\n-\n-declare module 'react-helmet' {\n- declare type Props ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove react-helmet
(This wasn't being used) |
129,187 | 04.05.2018 20:01:46 | 14,400 | 5d15baf954c5e1b642b35b8be4416a743e1c9df9 | [web] Unbreak log in and reset password
Frustrating combo of things to be broke at the same time... | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -182,9 +182,10 @@ async function logInResponder(\n): Promise<LogInResponse> {\nvalidateInput(logInRequestInputValidator, input);\nconst request: LogI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Unbreak log in and reset password
Frustrating combo of things to be broke at the same time... |
129,187 | 07.05.2018 13:35:41 | 14,400 | 667d0f1534fb371b6600a48d40c586a6fc90060a | [server] SQL backups | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/flow-typed/npm/dateformat_vx.x.x.js",
"diff": "+// flow-typed signature: d63e285272cb03960fc6ee354729a649\n+// flow-typed version: <<STUB>>/dateformat_v^3.0.3/flow_v0.64.0\n+\n+/**\n+ * This is an autogenerated libdef stub for:\n+ *\n+ * ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] SQL backups |
129,187 | 07.05.2018 14:30:05 | 14,400 | 0c61fb51ebf638ba8b30b932f897a3e0671d8b66 | [server] Delete oldest backup if no space left | [
{
"change_type": "MODIFY",
"old_path": "server/src/backups.js",
"new_path": "server/src/backups.js",
"diff": "@@ -8,9 +8,14 @@ import dateFormat from 'dateformat';\nimport dbConfig from '../secrets/db_config';\nimport backupConfig from '../facts/backups';\n-const backupDirectory = \"/Users/ashoat\";... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete oldest backup if no space left |
129,187 | 07.05.2018 14:37:20 | 14,400 | e7e05de2075914fbf2931c896dcd4853ab89ce7a | [server] Use denodeify from separate package
Apparently node only makes it available in `loader.mjs`??? | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/flow-typed/npm/denodeify_vx.x.x.js",
"diff": "+// flow-typed signature: 26ed4f6305aed1cfbce8ce001b7a00bd\n+// flow-typed version: <<STUB>>/denodeify_v^1.2.1/flow_v0.64.0\n+\n+/**\n+ * This is an autogenerated libdef stub for:\n+ *\n+ * 'd... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use denodeify from separate package
Apparently node only makes it available in `loader.mjs`??? |
129,187 | 10.05.2018 10:21:17 | 14,400 | 0be008bcd2a20f61685fd9004a281119dde4c5dd | [web] Style tweaks and fixes for filter panel | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -317,6 +317,8 @@ div.calendar-filters-container {\nbackground-image: url(../images/background.png);\nbackground-size: 3000px 2000px;\nbackground-attachment: fixed;\n+ display: flex;\n+ flex-direction: co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Style tweaks and fixes for filter panel |
129,187 | 10.05.2018 12:30:29 | 14,400 | c944cbfdda20a74b901a668b6111bc55fa2d68c0 | Moving chat-selectors.js into lib so we can access it from web | [
{
"change_type": "RENAME",
"old_path": "native/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "// @flow\n-import type { AppState } from '../redux-setup';\n-import { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n+import type { BaseAppState... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Moving chat-selectors.js into lib so we can access it from web |
129,187 | 11.05.2018 19:48:18 | 14,400 | ae6605972d5e61a1ce68278e44067486e03f7b98 | [web] Include currently selected thread in web chat thread list | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -40,21 +40,14 @@ const chatThreadItemPropType = PropTypes.shape({\nmostRecentMessageInfo: messageInfoPropType,\nlastUpdatedTime: PropTypes.number.isRequired,\n});\n-co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Include currently selected thread in web chat thread list |
129,187 | 11.05.2018 19:53:37 | 14,400 | af97a2e6569af48867d92b970f190161bb426d9d | [server] Verify activeChatThreadID before setting it in navInfo | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -34,7 +34,7 @@ import { navInfoFromURL } from 'web/url-utils';\nimport { Viewer } from '../session/viewer';\nimport { handleCodeVerificationReq... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Verify activeChatThreadID before setting it in navInfo |
129,187 | 14.05.2018 13:44:11 | 14,400 | f3dab9590d426d1c0659e56abc071daea19ebe5d | Use redux-utils everywhere instead of react-redux directly | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -35,13 +35,11 @@ import {\nimport invariant from 'invariant';\nimport Icon from 'react-native-vector-icons/FontAwesome';\nimport OnePassword from 're... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use redux-utils everywhere instead of react-redux directly |
129,187 | 14.05.2018 14:47:28 | 14,400 | 5a82b7678d412a7369d5e69f77ea792f31fc3cbd | [native] Fix some lodash uses and update libdef with my own changes | [
{
"change_type": "MODIFY",
"old_path": "lib/flow-typed/npm/lodash_v4.x.x.js",
"new_path": "lib/flow-typed/npm/lodash_v4.x.x.js",
"diff": "@@ -1636,17 +1636,17 @@ declare module \"lodash/fp\" {\narray: $ReadOnlyArray<T>\n): T[];\ndifferenceWith<T>(\n- values: $ReadOnly<T>\n- ): ((comparator: Comparat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix some lodash uses and update libdef with my own changes |
129,187 | 14.05.2018 14:52:39 | 14,400 | c9336f696bd6b78471caa305ed41ec20473b8b9f | [native] Fix up navigation param types | [
{
"change_type": "MODIFY",
"old_path": "native/account/verification-modal.react.js",
"new_path": "native/account/verification-modal.react.js",
"diff": "@@ -62,8 +62,9 @@ const forceInset = { top: 'always', bottom: 'always' };\ntype VerificationModalMode = \"simple-text\" | \"reset-password\";\ntype ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up navigation param types |
129,187 | 14.05.2018 15:17:08 | 14,400 | 357c3dd9c579ca0c316251d42780009818d2b910 | [native] Fix up CalendarItem -> CalendarItemWithHeight logic | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/entry-utils.js",
"new_path": "lib/shared/entry-utils.js",
"diff": "@@ -17,15 +17,15 @@ import {\nfilterExists,\n} from '../selectors/calendar-filter-selectors';\n-function entryKey(entryInfo: EntryInfo | RawEntryInfo): string {\n+type HasEntryIDs = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up CalendarItem -> CalendarItemWithHeight logic |
129,187 | 15.05.2018 14:11:17 | 14,400 | 8aba5cd3d48183b3faebcad50fa1ff9c9cdc1aa1 | Finish updating react-native
metro got weird, and now we need to use more packages to make things work. Sigh. | [
{
"change_type": "MODIFY",
"old_path": "lib/package.json",
"new_path": "lib/package.json",
"diff": "\"flow-bin\": \"^0.64.0\"\n},\n\"scripts\": {\n- \"postinstall\": \"cd ../; npx flow-mono create-symlinks lib/.flowconfig\",\n\"flow\": \"flow; test $? -eq 0 -o $? -eq 2\"\n},\n\"dependencies\": {\n"
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Finish updating react-native
metro got weird, and now we need to use more packages to make things work. Sigh. |
129,187 | 16.05.2018 11:44:14 | 14,400 | 189f76840ba5fbfe06f31c2619f27a44cb7718bc | [native] Use react-navigation@2.0's new "less pushy" navigate
We no longer have to check if the current route is active before `navigate`, as `react-navigation` will handle duplicates as long as we specify the correct `key`. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -16,7 +16,10 @@ import type {\nDispatchActionPromise,\n} from 'lib/utils/action-utils';\nimport type { LoadingStatus } from 'lib/types/loading-types';\n-import type { Na... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use react-navigation@2.0's new "less pushy" navigate
We no longer have to check if the current route is active before `navigate`, as `react-navigation` will handle duplicates as long as we specify the correct `key`. |
129,187 | 16.05.2018 21:54:49 | 14,400 | 7dd934599445bc04d0e8faed2b3079ba51e1beed | [native] Use createNavigationPropConstructor and initializeListeners from react-navigation-redux-helpers | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "import type {\nNavigationState,\nNavigationAction,\n- NavigationScreenProp,\n} from 'react-navigation';\nimport type { Dispatch } from 'lib/types/redux-types';\nimport type { AppState } from './... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use createNavigationPropConstructor and initializeListeners from react-navigation-redux-helpers |
129,187 | 21.05.2018 22:42:13 | 14,400 | bdae8f6365724e0f1bd29b9e0a17bc1a0c70e057 | [server] Include nav-selectors in server | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"description\": \"\",\n\"main\": \"dist/server\",\n\"scripts\": {\n- \"babel\": \"babel src/ --out-dir dist/ --ignore 'lib/flow-typed','lib/node_modules','lib/package.json','web/flow-typed','we... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include nav-selectors in server |
129,187 | 09.06.2018 15:31:29 | -25,200 | d2a4024f86341bd072727034eeb44dc1e6c9a562 | Version bumps and bugfixes | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react-native-segmented-control-tab\": \"^3.2.1\",\n\"react-native-splash-screen\": \"^3.0.6\",\n\"react-native-vector-icons\": \"^4.5.0\",\n- \"react-navigation\": \"^2.0.1\",\n+ \"react-navig... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Version bumps and bugfixes |
129,187 | 09.06.2018 15:32:32 | -25,200 | 8409744515c8ea7ce7038f399209a928efb9a3db | [server] Buffer mysqldump results in memory
mysqldump shouldn't hang when the file write stream runs out of space anymore, and we won't call mysqldump twice in that scenario anymore. | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"react-router\": \"^4.2.0\",\n\"redux\": \"^3.7.2\",\n\"sql-template-strings\": \"^2.2.2\",\n+ \"stream-cache\": \"^0.0.2\",\n\"tcomb\": \"^3.2.24\",\n\"twin-bcrypt\": \"^2.1.1\",\n\"uuid\": \"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Buffer mysqldump results in memory
mysqldump shouldn't hang when the file write stream runs out of space anymore, and we won't call mysqldump twice in that scenario anymore. |
129,187 | 15.06.2018 08:36:20 | -28,800 | bb9f3542a152e4667fb960f4b7850d2e5ccb6002 | [native] Update to the latest react-navigation and redux-helpers versions | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -50,10 +50,7 @@ import {\nAlert,\nDeviceInfo,\n} from 'react-native';\n-import {\n- createNavigationPropConstructor,\n- initializeListeners,\n-} from 'react-navigation-redux-helpers';\n+impor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to the latest react-navigation and redux-helpers versions |
129,187 | 18.06.2018 17:55:40 | -28,800 | 6cfb7481a4d730e3938e226d4206787ff7643361 | Move member filtering hack from ServerThreadInfo to RawThreadInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -95,6 +95,17 @@ function rawThreadInfoFromServerThreadInfo(\nconst members = [];\nlet currentUser;\nfor (let serverMember of serverThreadInfo.members) {\n+ // This is a hack, si... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move member filtering hack from ServerThreadInfo to RawThreadInfo |
129,187 | 18.06.2018 19:03:04 | -28,800 | 42807825142cbc2ffd5a2fc1789444f702a8bede | [server] Add updater_cookie column to updates table | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -12,6 +12,7 @@ import { dbQuery, SQL } from '../database';\nimport createIDs from './id-creator';\nasync function createUpdates(\n+ cookieID: string,\nupda... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add updater_cookie column to updates table |
129,187 | 18.06.2018 20:19:09 | -28,800 | 6b73310d73dbabe4e6e0a2412d9b72e4cc0d4cf8 | [server] Do permission check before any mutations in createEntry | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/entry-creator.js",
"new_path": "server/src/creators/entry-creator.js",
"diff": "@@ -20,17 +20,20 @@ async function createEntry(\nviewer: Viewer,\nrequest: CreateEntryRequest,\n): Promise<SaveEntryResult> {\n+ const hasPermission = await che... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Do permission check before any mutations in createEntry |
129,187 | 18.06.2018 11:55:46 | 25,200 | eee60fcf2938aa343207439dd51d7bc4a0084118 | [server] Make update_cookier column optional | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -12,8 +12,8 @@ import { dbQuery, SQL } from '../database';\nimport createIDs from './id-creator';\nasync function createUpdates(\n- cookieID: string,\nupda... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make update_cookier column optional |
129,187 | 18.06.2018 15:01:59 | 25,200 | 53a8003e6aa03de25f686deeeb676c42785d260b | [server] Introduce keys for merging updates | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -10,6 +10,7 @@ import { updateInfoFromUpdateData } from 'lib/shared/update-utils';\nimport { dbQuery, SQL } from '../database';\nimport createIDs from './i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce keys for merging updates |
129,187 | 18.06.2018 16:20:31 | 25,200 | 9e485d36878e9c72dbcca70e8fcfe00b00169dc6 | [server] Remaining updateTypes.UPDATE_THREAD update sites | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -21,8 +21,7 @@ import { verifyUserIDs } from '../fetchers/user-fetchers';\nimport {\nchangeRole,\nrecalculateAllPermissions,\n- saveMemberships,\n- deleteM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Remaining updateTypes.UPDATE_THREAD update sites |
129,187 | 19.06.2018 16:00:49 | 25,200 | 578a26abe4b538976ae797499ddca87e5cd8a0bc | [lib] Filter out relevant MemberInfos in reducer on updateTypes.DELETE_ACCOUNT | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -108,6 +108,7 @@ function pingPull(\nreturn newThreadInfos;\n}\n+// ... PUSH.\nfunction pingPush(\nstate: {[id: string]: RawThreadInfo},\npayload: PingResult,\n@@ -143,6... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Filter out relevant MemberInfos in reducer on updateTypes.DELETE_ACCOUNT |
129,187 | 19.06.2018 16:16:34 | 25,200 | e059dba3d657e3a7dbb88afdd104b5e2a1be2ce5 | [lib] Update subscription in reducer for updateSubscriptionActionTypes.success | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -18,7 +18,7 @@ import type {\n} from '../types/account-types';\nimport type {\nSubscriptionUpdateRequest,\n- ThreadSubscription,\n+ SubscriptionUpdateResult,\n} from '../types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update subscription in reducer for updateSubscriptionActionTypes.success |
129,187 | 19.06.2018 16:34:50 | 25,200 | 66e67456a774de9fe61e4c95cea96d93c6b609ea | [server] Send updateTypes.UPDATE_THREAD to user's other devices when ThreadSubscription changed | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/user-subscription-updaters.js",
"new_path": "server/src/updaters/user-subscription-updaters.js",
"diff": "@@ -5,28 +5,32 @@ import type {\nSubscriptionUpdateRequest,\n} from 'lib/types/subscription-types';\nimport type { Viewer } from '../s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Send updateTypes.UPDATE_THREAD to user's other devices when ThreadSubscription changed |
129,187 | 19.06.2018 18:09:17 | 25,200 | 430fd52f3fc204fdabb47fc50fdd0cf78395af5b | Synchronously return list of updates for viewer from thread mutators
Lists of updates returned on ping don't include updates created by the same cookie doing the ping. Instead, those updates will be returned synchronously by the server call that triggered the update. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -34,7 +34,11 @@ async function deleteThread(\nthreadID,\naccountPassword: currentAccountPassword,\n});\n- return { threadID, threadInfos: response.threadInfos };\n+ return... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Synchronously return list of updates for viewer from thread mutators
Lists of updates returned on ping don't include updates created by the same cookie doing the ping. Instead, those updates will be returned synchronously by the server call that triggered the update. |
129,187 | 20.06.2018 13:49:41 | 25,200 | 54db2f9a560940e4955e6639d202c67b095fcfe8 | [server] Thread "join" operation to commitMembershipChangeset
Having this info lets us be a bit smarter about subscription status on join/leave, and is necessary for deciding between `updateTypes.UPDATE_THREAD` and `updateTypes.JOIN_THREAD` (coming soon). | [
{
"change_type": "MODIFY",
"old_path": "server/.flowconfig",
"new_path": "server/.flowconfig",
"diff": "[options]\nmodule.name_mapper='^lib/(.*)$' -> '<PROJECT_ROOT>/../lib/\\1'\n+\n+module.file_ext=.js\n+module.file_ext=.json\n+module.file_ext=.build\n"
},
{
"change_type": "MODIFY",
"ol... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Thread "join" operation to commitMembershipChangeset
Having this info lets us be a bit smarter about subscription status on join/leave, and is necessary for deciding between `updateTypes.UPDATE_THREAD` and `updateTypes.JOIN_THREAD` (coming soon). |
129,187 | 20.06.2018 16:09:30 | 25,200 | 45d775d980eb974a6e869ee6cf0d493830574162 | Don't store ThreadInfo in updates table
Just store `threadID`, and query for the `RawThreadInfo` when delivering to the client. We'll use the same technique for fetching `RawEntryInfo`s and `RawMessageInfo`s for the upcoming `updateTypes.JOIN_THREAD`. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/update-utils.js",
"new_path": "lib/shared/update-utils.js",
"diff": "@@ -19,45 +19,6 @@ function mostRecentUpdateTimestamp(\nreturn _maxBy('time')(updateInfos).time;\n}\n-function updateInfoFromUpdateData(\n- updateData: UpdateData,\n- id: string,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't store ThreadInfo in updates table
Just store `threadID`, and query for the `RawThreadInfo` when delivering to the client. We'll use the same technique for fetching `RawEntryInfo`s and `RawMessageInfo`s for the upcoming `updateTypes.JOIN_THREAD`. |
129,187 | 21.06.2018 23:53:44 | 25,200 | 1c533611de45f5d86b0ee7afd2abdcf281d79fbf | [server] Use CalendarQuery from client for fetching EntryInfos for updates | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -49,6 +49,7 @@ export type ViewerInfo =\nviewer: Viewer,\nthreadInfos: {[id: string]: RawThreadInfo},\nuserInfos: {[id: string]: AccountUserInfo},\n+ calen... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use CalendarQuery from client for fetching EntryInfos for updates |
129,187 | 22.06.2018 12:55:12 | 25,200 | 77928b26a53dad1af6cee8324b209d1753a1f850 | viewerCanSeeThread -> threadInChatList | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -32,7 +32,7 @@ import _uniq from 'lodash/fp/uniq';\nimport { messageID, combineTruncationStatuses } from '../shared/message-utils';\nimport { setHighestLocalID } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | viewerCanSeeThread -> threadInChatList |
129,187 | 22.06.2018 12:59:26 | 25,200 | 0c47730c34fa24cc35ce305f12b10c81a477c796 | [server] Default fetchMessageInfosSince to messageTruncationStatus.UNCHANGED
This fixes a bug where a ping result that doesn't have any updated messages for a "watched" thread would make the client think that the start of that thread had been reached. | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/message-fetchers.js",
"new_path": "server/src/fetchers/message-fetchers.js",
"diff": "@@ -421,7 +421,7 @@ async function fetchMessageInfosSince(\nconst threadSelectionClause = threadSelectionCriteriaToSQLClause(criteria);\nconst truncationS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Default fetchMessageInfosSince to messageTruncationStatus.UNCHANGED
This fixes a bug where a ping result that doesn't have any updated messages for a "watched" thread would make the client think that the start of that thread had been reached. |
129,187 | 22.06.2018 13:36:56 | 25,200 | 4146e76bf0c1cd0ca3bb5efac08159b9a9adcabd | [server] Update thread-responder to accept CalendarQuery for joinThread | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/thread-responders.js",
"new_path": "server/src/responders/thread-responders.js",
"diff": "@@ -35,6 +35,10 @@ import {\njoinThread,\n} from '../updaters/thread-updaters';\nimport createThread from '../creators/thread-creator';\n+import {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update thread-responder to accept CalendarQuery for joinThread |
129,187 | 22.06.2018 13:40:00 | 25,200 | c65a6c78d6fbed32c965e7891383bf56aa1c9884 | Separate ClientThreadJoinRequest from ServerThreadJoinRequest | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -8,7 +8,7 @@ import type {\nUpdateThreadRequest,\nNewThreadRequest,\nNewThreadResult,\n- ThreadJoinRequest,\n+ ClientThreadJoinRequest,\nThreadJoinPayload,\n} from '../typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Separate ClientThreadJoinRequest from ServerThreadJoinRequest |
129,187 | 22.06.2018 16:57:05 | 25,200 | a5e5af7c70cc4c0228d37bd65750ec9451c59716 | Fix some edge cases regarding MessageTruncationStatus
Also simplifies and refactor `message-reducer` a little bit. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -11,7 +11,7 @@ import {\ndefaultNumberPerThread,\n} from '../types/message-types';\nimport type { BaseAction } from '../types/redux-types';\n-import type { RawThreadIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix some edge cases regarding MessageTruncationStatus
Also simplifies and refactor `message-reducer` a little bit. |
129,187 | 22.06.2018 18:35:26 | 25,200 | 09fdd83b08a0a61f6bf96e6e6dc37f64f3db4362 | [lib] Other reducers filter when ThreadInfo are removed from the Redux store
Update other reducers (and related selector updates) for handling situations where a `RawThreadInfo` is removed from the store, and other related objects need to be removed as well. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/calendar-filters-reducer.js",
"new_path": "lib/reducers/calendar-filters-reducer.js",
"diff": "@@ -18,18 +18,13 @@ import {\nresetPasswordActionTypes,\nregisterActionTypes,\n} from '../actions/user-actions';\n+import { setCookieActionType } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Other reducers filter when ThreadInfo are removed from the Redux store
Update other reducers (and related selector updates) for handling situations where a `RawThreadInfo` is removed from the store, and other related objects need to be removed as well. |
129,187 | 22.06.2018 18:43:02 | 25,200 | 1b3e6d0c17d34fa656f4e357bfaf0509e56102f0 | Only include threadInChatList threads in notif badge count | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -27,7 +27,7 @@ const _mapValuesWithKeys = _mapValues.convert({ cap: false });\nimport { dateString, dateFromString } from '../utils/date-utils';\nimport { createEn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only include threadInChatList threads in notif badge count |
129,187 | 23.06.2018 15:23:15 | 25,200 | e909bcd4a56c210fb031426b7a29c3964de15822 | Dedup MessageInfos/EntryInfos for main payload vs. UpdateInfos
When parsing an action payload to get the full list of `MessageInfo`s/`EntryInfo`s to merge, make sure to dedup the ones we get from `UpdateInfo`s from the ones we get from the main payload. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -527,10 +527,18 @@ function mergeUpdateEntryInfos(\nentryInfos: $ReadOnlyArray<RawEntryInfo>,\nnewUpdates: $ReadOnlyArray<UpdateInfo>,\n): RawEntryInfo[] {\n+ const entryI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Dedup MessageInfos/EntryInfos for main payload vs. UpdateInfos
When parsing an action payload to get the full list of `MessageInfo`s/`EntryInfo`s to merge, make sure to dedup the ones we get from `UpdateInfo`s from the ones we get from the main payload. |
129,187 | 23.06.2018 18:29:01 | 25,200 | 99e53948d7d4e445690a3d3521bda7041775fdfe | [server] Refine createUpdates to avoid unnecessary updates
Filter them out before they even get created. Also refines the deletion of existing updates due to new ones. | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -18,6 +18,8 @@ import type {\n} from 'lib/types/entry-types';\nimport invariant from 'invariant';\n+import _uniq from 'lodash/fp/uniq';\n+import _intersect... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Refine createUpdates to avoid unnecessary updates
Filter them out before they even get created. Also refines the deletion of existing updates due to new ones. |
129,187 | 24.06.2018 15:25:55 | 25,200 | b38c28e6ae62db38bb7a289b46d531e5acbc9831 | [server] Scope createUpdates deletions to timestamps before earliest new update | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -32,7 +32,7 @@ import {\nnonThreadCalendarFilters,\n} from 'lib/selectors/calendar-filter-selectors';\n-import { dbQuery, SQL } from '../database';\n+impor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Scope createUpdates deletions to timestamps before earliest new update |
129,187 | 24.06.2018 19:52:11 | 25,200 | 0c094cb655c574dd511f7ae7e183a06f535c014a | Introduce threadStore | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -26,7 +26,8 @@ export default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(\nstate: T,\naction: BaseAction,\n): T {\n- const threadInfos = reduceThreadInfos(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce threadStore |
129,187 | 25.06.2018 11:22:55 | 14,400 | 2f0862587a5ba6609e4bb5214eba7008f407d30f | serverRequestTypes.THREAD_POLL_PUSH_INCONSISTENCY
Inform the server when there is inconsistency between poll and push results for the `ThreadStore`. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "@@ -27,7 +27,7 @@ async function ping(\nclientResponses: actionInput.clientResponses,\nwatchedIDs,\n});\n- const result: PingResult = {\n+ return {\nthreadInfos: response.threadI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | serverRequestTypes.THREAD_POLL_PUSH_INCONSISTENCY
Inform the server when there is inconsistency between poll and push results for the `ThreadStore`. |
129,187 | 25.06.2018 13:42:40 | 14,400 | 52dbd5da95928bcce4cbfd6d5c6942ce37847b92 | Add platformDetails to registerConfig | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "@@ -8,7 +8,6 @@ import type {\n} from '../types/activity-types';\nimport threadWatcher from '../shared/thread-watcher';\n-import { getConfig } from '../utils/config';\nconst ping... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add platformDetails to registerConfig |
129,187 | 26.06.2018 13:33:30 | 14,400 | e3644a2a0b5146710952bb6ea4b4c3366bc47159 | Generate a report for thread push/poll inconsistency | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/report-actions.js",
"new_path": "lib/actions/report-actions.js",
"diff": "import type { FetchJSON } from '../utils/fetch-json';\nimport type {\n- ErrorReportCreationRequest,\n- ErrorReportCreationResponse,\n+ ReportCreationRequest,\n+ ReportCreatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Generate a report for thread push/poll inconsistency |
129,187 | 26.06.2018 14:04:51 | 14,400 | b15aba9f5b9de7da6e1f402a022eec17be7bbb44 | [server] Stop deleting all the entries in the ids table
Oops. At least this table doesn't actually currently matter... | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/thread-deleters.js",
"new_path": "server/src/deleters/thread-deleters.js",
"diff": "@@ -73,7 +73,7 @@ async function deleteThread(\nLEFT JOIN ids ire ON ire.id = re.id\nLEFT JOIN memberships mm ON mm.thread = t.id\nLEFT JOIN roles r ON r.th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Stop deleting all the entries in the ids table
Oops. At least this table doesn't actually currently matter... |
129,187 | 26.06.2018 15:10:52 | 14,400 | ec14aa5397fb2d7d5e1b1f6dc025674e521301b2 | Some bugfixes for the last several dozen commits | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -216,6 +216,10 @@ function mergeNewMessages(\nlastPruned: oldThread.lastPruned,\n};\n}\n+ const oldNotInNew = _difference(oldThread.messageIDs)(messageIDs);\n+ for (le... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Some bugfixes for the last several dozen commits |
129,187 | 26.06.2018 18:38:42 | 14,400 | 86f18aaf66cab664eb12fc22f2237d170749c90e | Introducing squadbot, who will send me messages when reports are created | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/facts/bots.json",
"diff": "+{\n+ \"squadbot\": {\n+ \"userID\": \"5\",\n+ \"ashoatThreadID\": \"83793\"\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/creators/report-creator.js",
"new_path": "server/src/cr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introducing squadbot, who will send me messages when reports are created |
129,187 | 03.07.2018 14:04:05 | 14,400 | aaecb86ad5e5d55a986693b6e77246f2ca5a83fb | [lib] Set threads to unread when notifs indicate new messages
Unrelatedly, handle legacy server response for `serverRequests` field on ping. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "@@ -45,7 +45,7 @@ async function ping(\nprevState: actionInput.prevState,\nupdatesResult: response.updatesResult,\nrequests: {\n- serverRequests: response.serverRequests,\n+ serv... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Set threads to unread when notifs indicate new messages
Unrelatedly, handle legacy server response for `serverRequests` field on ping. |
129,187 | 03.07.2018 15:23:16 | 14,400 | b6bb56f52eefddb11e3d25d5684754739cec8a51 | [server] Catch exceptions thrown by async calls
Make sure we try-catch the promises we set to run in the background, as exceptions from these will soon cause Node to crash the thread. | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -28,6 +28,7 @@ import {\nimport createIDs from './id-creator';\nimport { sendPushNotifs } from '../push/send';\nimport { createUpdates } from './update-c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Catch exceptions thrown by async calls
Make sure we try-catch the promises we set to run in the background, as exceptions from these will soon cause Node to crash the thread. |
129,187 | 04.07.2018 11:03:01 | 14,400 | 8095d17ab985914ffe9206a5cade85e8bbaa34c8 | Have server maintain all PlatformDetails for native clients
We want to know `codeVersion` and `stateVersion` for all applicable cookies. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -69,7 +69,7 @@ async function register(\n): Promise<RegisterResult> {\nconst response = await fetchJSON(\n'create_account',\n- { ...registerInfo, platform: getConfig().platfor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Have server maintain all PlatformDetails for native clients
We want to know `codeVersion` and `stateVersion` for all applicable cookies. |
129,187 | 04.07.2018 12:28:22 | 14,400 | d06ae81c0cb0006122d613f03db6ccab2254d712 | Bugfixes and optimizations for the last commit | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/ping-selectors.js",
"new_path": "lib/selectors/ping-selectors.js",
"diff": "@@ -66,9 +66,14 @@ const pingActionInput = createSelector(\nlastSuccess: number,\n): (startingPayload: PingStartingPayload) => PingActionInput => {\nconst clientResponses... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Bugfixes and optimizations for the last commit |
129,187 | 09.07.2018 10:32:11 | 14,400 | 73d51f6c229ae42769d07c0bc119b740ac6c756b | [web] Fix splash screen styling
It started breaking on Chrome so I had to rethink `div.splash-top-container` | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -1055,7 +1055,6 @@ div.splash-header-container {\ntop: 0;\nleft: 0;\nright: 0;\n- height: 790px;\nheight: 61px;\nz-index: 3;\nbackground-image: url(../images/background.png);\n@@ -1065,14 +1064,14 @@ div... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix splash screen styling
It started breaking on Chrome so I had to rethink `div.splash-top-container` |
129,187 | 09.07.2018 19:34:06 | 14,400 | 6878d9674e552c23836a4424a81694ed0c214264 | Assorted fixes after testing master | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/bots.json",
"new_path": "lib/facts/bots.json",
"diff": "{\n\"squadbot\": {\n\"userID\": \"5\",\n- \"ashoatThreadID\": \"83793\"\n+ \"ashoatThreadID\": \"83794\"\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/reducers/device-token... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Assorted fixes after testing master |
129,187 | 09.07.2018 22:26:52 | 14,400 | 99cbde4867f019de6625207f812aa7e1edab5f33 | [native] Fix Flow for React Native 0.56 | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "; \"node_modules/react-native\" but in the source repo it is in the root\n.*/Libraries/react-native/React.js\n+.*/node_modules/react-native/Libraries/react-native/react-native-implementation.js\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Flow for React Native 0.56 |
129,187 | 10.07.2018 10:43:19 | 14,400 | bfc4e67206b237895fe99ceb7512c0ee910179d5 | [server] Sanitize invalid input before logging
Namely, replace any plaintext passwords. | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/thread-responders.js",
"new_path": "server/src/responders/thread-responders.js",
"diff": "@@ -25,6 +25,7 @@ import {\ntShape,\ntNumEnum,\ntColor,\n+ tPassword,\n} from '../utils/validation-utils';\nimport { deleteThread } from '../deleter... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Sanitize invalid input before logging
Namely, replace any plaintext passwords. |
129,187 | 10.07.2018 11:49:40 | 14,400 | cf2286a4cd7eb655cbbf609e52c31bb838b06cf4 | [native] Update to | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react-native-notifications\": \"git+https://git@github.com/ashoat/react-native-notifications.git\",\n\"react-native-onepassword\": \"^1.0.6\",\n\"react-native-segmented-control-tab\": \"^3.2.1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to react-native-splash-screen@3.1.0 |
129,187 | 10.07.2018 14:35:44 | 14,400 | 997abace9ff1bcecb0806f6caac67839a8ba4fc1 | [native] codeVersion -> 13
First new release in over two months! | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 13
First new release in over two months! |
129,187 | 10.07.2018 15:12:13 | 14,400 | 4f3e6ab6c46b4332bab3d61f6fa75cda3c5579fa | [lib] Include all bots in isStaff | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/user-utils.js",
"new_path": "lib/shared/user-utils.js",
"diff": "@@ -5,6 +5,7 @@ import type { RelativeMemberInfo } from '../types/thread-types';\nimport ashoat from '../facts/ashoat';\nimport friends from '../facts/friends';\n+import bots from '../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include all bots in isStaff |
129,187 | 16.07.2018 10:36:30 | 14,400 | 19da21976a1b5ea35f81ca2614455712c89bd8f8 | [native] Don't attempt scrollToKey until listDataWithHeights is ready | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -446,6 +446,12 @@ class InnerCalendar extends React.PureComponent<Props, State> {\nif (newStartDate < lastStartDate || newEndDate > lastEndDate) {\nthis.loadingFro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't attempt scrollToKey until listDataWithHeights is ready |
129,187 | 17.07.2018 11:49:12 | 14,400 | 2f1b425ecf32e84eb357cc737381401727c259e0 | Fix network memory leak
The workaround is just to clone the result from the network request. Took me so long to figure this out. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -357,12 +357,11 @@ function bindCookieAndUtilsIntoFetchJSON(\nreturn attemptToResolveInvalidation(newAnonymousCookie);\n};\n- return (async (\n+ return (\nendpoint: Endpoint,\ndat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix network memory leak
The workaround is just to clone the result from the network request. Took me so long to figure this out. |
129,187 | 18.07.2018 15:07:45 | 14,400 | f5d2190041549dc4a8890043590dd63e4edf6e43 | [native] Update react-native-keychain
And also add Feather from `react-native-vector-icons` | [
{
"change_type": "ADD",
"old_path": "native/android/app/src/main/assets/fonts/Feather.ttf",
"new_path": "native/android/app/src/main/assets/fonts/Feather.ttf",
"diff": "Binary files /dev/null and b/native/android/app/src/main/assets/fonts/Feather.ttf differ\n"
},
{
"change_type": "MODIFY",
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update react-native-keychain
And also add Feather from `react-native-vector-icons` |
129,187 | 18.07.2018 15:07:52 | 14,400 | 6cb95260b58261e7408794249920c8269e77c0a2 | [server] Fix up loader.mjs for Node 10 | [
{
"change_type": "MODIFY",
"old_path": "server/loader.mjs",
"new_path": "server/loader.mjs",
"diff": "@@ -7,8 +7,13 @@ const builtins = Module.builtinModules;\nconst extensions = { js: 'esm', json: \"json\" };\nconst access = Promise.denodeify(fs.access);\nconst readFile = Promise.denodeify(fs.readF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix up loader.mjs for Node 10 |
129,187 | 18.07.2018 15:07:08 | 14,400 | 06f5399e35dadd239823263582309c32bdd81dea | [native] Fix Entry resizing on iOS
Height changes no longer get reported on a node with an explicit-height parent, so we have to remove the nodes we're using from the flow by absolute-positioning them. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -344,7 +344,10 @@ class InternalEntry extends React.Component<Props, State> {\n}\nconst textStyle = { color: textColor };\nconst linkStyle = darkColor ? styles.lightLink... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Entry resizing on iOS
Height changes no longer get reported on a node with an explicit-height parent, so we have to remove the nodes we're using from the flow by absolute-positioning them. |
129,187 | 18.07.2018 15:05:20 | 14,400 | d1f00d2667556e4339be37d9207f96d650b33400 | [native] Fix accidental log-out
`NAVIGATE_TO_APP` was getting triggered by `onInitialAppLoad` when `LoggedOutModal` gets instantiated for the first time. That should only happen when the app is started, and looks like that will get handled by `componentWillReceiveProps` anyways. | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -238,9 +238,6 @@ class InnerLoggedOutModal extends React.PureComponent<Props, State> {\nif (this.props.isForeground) {\nthis.onForeground();\n}\n- if... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix accidental log-out
`NAVIGATE_TO_APP` was getting triggered by `onInitialAppLoad` when `LoggedOutModal` gets instantiated for the first time. That should only happen when the app is started, and looks like that will get handled by `componentWillReceiveProps` anyways. |
129,187 | 18.07.2018 17:38:20 | 14,400 | cc9f5c942112ef19ffe76ee119ecbc9f09d4f1d3 | [native] codeVersion -> 14
I guess 13 is bad luck... | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 14
I guess 13 is bad luck... |
129,187 | 20.07.2018 16:18:00 | 14,400 | 033e37a7d0c5157b7a5ab74c9eca84b7dd8312f8 | [native] Update a couple packages | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react-native-floating-action\": \"^1.9.0\",\n\"react-native-hyperlink\": \"git+https://git@github.com/ashoat/react-native-hyperlink.git#both\",\n\"react-native-in-app-notification\": \"^2.1.0\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update a couple packages |
129,187 | 23.07.2018 20:00:48 | 14,400 | 1ff9e507a521e9dadb6345085a8fa94c886f05e8 | updateTypes.BAD_DEVICE_TOKEN
Now, the server will explicitly tell clients that their device token is invalid and they need to fetch a new one.
Fixes issue that only I experience where I'm switching between prod and dev mode and need to switch my cookie's device token every once in a while. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/device-token-reducer.js",
"new_path": "lib/reducers/device-token-reducer.js",
"diff": "// @flow\nimport type { BaseAction } from '../types/redux-types';\n+import { updateTypes } from '../types/update-types';\nimport { setDeviceTokenActionTypes } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | updateTypes.BAD_DEVICE_TOKEN
Now, the server will explicitly tell clients that their device token is invalid and they need to fetch a new one.
Fixes issue that only I experience where I'm switching between prod and dev mode and need to switch my cookie's device token every once in a while. |
129,187 | 23.07.2018 20:08:09 | 14,400 | a277394512c8c99b8873ae25d849be01ccaed4e0 | [server] Qualify URL use in Node loader.mjs | [
{
"change_type": "MODIFY",
"old_path": "server/loader.mjs",
"new_path": "server/loader.mjs",
"diff": "@@ -7,7 +7,7 @@ const builtins = Module.builtinModules;\nconst extensions = { js: 'esm', json: \"json\" };\nconst access = Promise.denodeify(fs.access);\nconst readFile = Promise.denodeify(fs.readFi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Qualify URL use in Node loader.mjs |
129,187 | 25.07.2018 14:20:54 | 14,400 | a527fcf7fa9114d381b4c275200146ecbd78f4cd | Always include CalendarQuery when logging in
(Or resetting password.)
This also refactors the extra params we need for log in to be in a type `LogInExtraInfo`, so we can easily add more if need be. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/selectors/account-selectors.js",
"diff": "+// @flow\n+\n+import type { BaseAppState } from '../types/redux-types';\n+import type { CalendarQuery } from '../types/entry-types';\n+import type { LogInExtraInfo } from '../types/account-types';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Always include CalendarQuery when logging in
(Or resetting password.)
This also refactors the extra params we need for log in to be in a type `LogInExtraInfo`, so we can easily add more if need be. |
129,187 | 25.07.2018 15:12:58 | 14,400 | 885aea0e0ffd2f4b17e7e61c349929929afe286c | Include CalendarQuery in RegisterRequest | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/nav-reducer.js",
"new_path": "lib/reducers/nav-reducer.js",
"diff": "@@ -11,6 +11,7 @@ import {\nimport {\nlogInActionTypes,\nresetPasswordActionTypes,\n+ registerActionTypes,\n} from '../actions/user-actions';\nimport { pingActionTypes } from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include CalendarQuery in RegisterRequest |
129,187 | 26.07.2018 11:12:24 | 14,400 | c344a20a6b399d23b1a86c4f7f581b693048c045 | [server] `filters` table to store CalendarQueries on a per-cookie basis | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -25,6 +25,7 @@ import { sendEmailAddressVerificationEmail } from '../emails/verification';\nimport createMessages from './message-creator';\nimport creat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] `filters` table to store CalendarQueries on a per-cookie basis |
129,187 | 26.07.2018 13:47:57 | 14,400 | eea0195da2f18bd5e385f985f54465693bb922b8 | [server] Only save new CalendarQuery if it's different from the old one | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/fetchers/filter-fetchers.js",
"diff": "+// @flow\n+\n+import type { Viewer } from '../session/viewer';\n+import type { CalendarQuery } from 'lib/types/entry-types';\n+\n+import { dbQuery, SQL } from '../database';\n+\n+// \"Filter\" h... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Only save new CalendarQuery if it's different from the old one |
129,187 | 26.07.2018 14:39:17 | 14,400 | bec4cd91d5c998ab8aaca4594a4e166055b953f0 | [native] Don't allow ping to log in except at app start
A `PING_SUCCESS` should only result in a log-in if the corresponding `PING_STARTED` occurred while the user was logged out. | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -526,6 +526,13 @@ function removeModalsIfPingIndicatesLoggedIn(\n// handling specific log ins that occur from LoggedOutModal.\nreturn state;\n}\n+ if (payload.loggedIn) {\n+ // ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't allow ping to log in except at app start
A `PING_SUCCESS` should only result in a log-in if the corresponding `PING_STARTED` occurred while the user was logged out. |
129,187 | 26.07.2018 15:18:19 | 14,400 | d934e32db0ab9edca1ea4cad3e67461c28eb5fa3 | [server] Fix subscription issues
All new threads were getting disabled push notifs, AND it was impossible to enable push notifs. Sigh... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -438,9 +438,7 @@ async function saveMemberships(toSave: $ReadOnlyArray<RowToSave>) {\nrowToSave.threadID,\nrowToSave.role,\ntime,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix subscription issues
All new threads were getting disabled push notifs, AND it was impossible to enable push notifs. Sigh... |
129,187 | 27.07.2018 20:34:25 | 14,400 | 0f692bf05a3de2b4c2b43e2a68fa09b9cc43ea77 | [lib] Prevent cookie invalidation recovery with native credentials while logged out
Also fixes a small bug where the options weren't being passed down to the rebound post-recovery `fetchJSON` function. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -234,7 +234,7 @@ async function fetchNewCookieFromNativeCredentials(\nconst boundFetchJSON = async (\nendpoint: Endpoint,\ndata: {[key: string]: mixed},\n- options?: FetchJSONOpti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Prevent cookie invalidation recovery with native credentials while logged out
Also fixes a small bug where the options weren't being passed down to the rebound post-recovery `fetchJSON` function. |
129,187 | 27.07.2018 20:35:27 | 14,400 | fd3f6c70c1863146cdc0cf93e34dbced8eac5c99 | [native] Remove native credentials before log out/delete account requests
Also, forgot to remove third parameter in call to `LoggedOutModal.dispatchPing` after I removed it from the definition. | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -345,7 +345,7 @@ class InnerLoggedOutModal extends React.PureComponent<Props, State> {\n// We are here either because the user cookie exists but Redu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove native credentials before log out/delete account requests
Also, forgot to remove third parameter in call to `LoggedOutModal.dispatchPing` after I removed it from the definition. |
129,187 | 27.07.2018 20:35:52 | 14,400 | 98c3044c363162f66811ab91f409098f890f02b4 | [server] Make setNewCookie set cookieInvalidated back to false | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/viewer.js",
"new_path": "server/src/session/viewer.js",
"diff": "@@ -55,13 +55,11 @@ class Viewer {\nsetNewCookie(data: ViewerData) {\nthis.data = data;\nthis.cookieChanged = true;\n- if (this.cookieName !== cookieType.ANONYMOUS) {\n- // A c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make setNewCookie set cookieInvalidated back to false |
129,187 | 27.07.2018 21:23:46 | 14,400 | 27b8a37a20d571e08e24eba07a64f7bf4b608955 | [lib] Explicitly set Error.message
V8 doesn't seem to set it with the `super(message)` call. Not sure about either JSC. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/errors.js",
"new_path": "lib/utils/errors.js",
"diff": "@@ -5,6 +5,7 @@ class ExtendableError extends Error {\nconstructor(message: string) {\nsuper(message);\nthis.name = this.constructor.name;\n+ this.message = message;\nif (typeof Error.captureSta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Explicitly set Error.message
V8 doesn't seem to set it with the `super(message)` call. Not sure about either JSC. |
129,187 | 30.07.2018 10:27:04 | 14,400 | 103155ac836e624907183323b56c474b51cb9b7b | [server] Delete cookie-specific updates after delivery | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/update-deleters.js",
"new_path": "server/src/deleters/update-deleters.js",
"diff": "// @flow\n+import type { Viewer } from '../session/viewer';\n+\nimport invariant from 'invariant';\nimport { dbQuery, SQL, SQLStatement, mergeOrConditions }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete cookie-specific updates after delivery |
129,187 | 31.07.2018 10:33:18 | 14,400 | cc9b83e156597eba3d7d044071175dd535ab83e1 | Check visibility of activeChatThreadID in websiteResponder
Also a bugfix in `message-creator` when there are messages from multiple creators (don't think this ever happens), and a bugfix in web's `ThreadSettingsModal` to avoid seeming like an empty password is specified when none is actually being specified. | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -94,7 +94,7 @@ async function createMessages(\nsubthread: undefined,\n};\n}\n- if (newThreadRestriction !== newThreadRestriction) {\n+ if (newThreadRestr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Check visibility of activeChatThreadID in websiteResponder
Also a bugfix in `message-creator` when there are messages from multiple creators (don't think this ever happens), and a bugfix in web's `ThreadSettingsModal` to avoid seeming like an empty password is specified when none is actually being specified. |
129,187 | 31.07.2018 11:00:33 | 14,400 | 01bc4e03c8bd7dd68dd8eef3009714d4042c8575 | Fix up handling of navInfo and URL when user is logged out on web
Also a type fix I forgot for the last commit. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -302,7 +302,7 @@ export type ThreadChanges = {\nexport type UpdateThreadRequest = {|\nthreadID: string,\nchanges: ThreadChanges,\n- accountPassword?: string,\n+ accountPassword?: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix up handling of navInfo and URL when user is logged out on web
Also a type fix I forgot for the last commit. |
129,187 | 31.07.2018 18:21:53 | 14,400 | 32b20c6ea5256e1b8f75241ca8241272fa9b793e | Include last twenty action types in thread inconsistency report | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -36,6 +36,7 @@ import {\n} from '../actions/ping-actions';\nimport { saveMessagesActionType } from '../actions/message-actions';\nimport { getConfig } from '../utils/con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include last twenty action types in thread inconsistency report |
129,187 | 01.08.2018 10:27:37 | 14,400 | 73f358b702303dec7b70c5f9370de7ee9e7c5bd8 | [server] Ignore the most common kind of thread inconsistency response
This one is a bug that results from a hack in `thread-reducer`. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/report-types.js",
"new_path": "lib/types/report-types.js",
"diff": "@@ -36,7 +36,7 @@ type ErrorReportCreationRequest = {|\ncurrentState: BaseAppState<*>,\nactions: $ReadOnlyArray<BaseAction>,\n|};\n-type ThreadPollPushInconsistencyReportCreationRequ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Ignore the most common kind of thread inconsistency response
This one is a bug that results from a hack in `thread-reducer`. |
129,187 | 01.08.2018 10:41:05 | 14,400 | 074b2170a0308f2bc63ea48a9ae3bc6d9f5e3396 | [server] Record as delivered only the ping timestamp passed by the client
Don't automatically assume the server-generated ping timestamp actually gets delivered. Also reduce one `await` step by combining some. | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -17,6 +17,7 @@ import _isEqual from 'lodash/fp/isEqual';\nimport { ServerError } from 'lib/utils/errors';\nimport { mostRecentMessageTimestamp } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Record as delivered only the ping timestamp passed by the client
Don't automatically assume the server-generated ping timestamp actually gets delivered. Also reduce one `await` step by combining some. |
129,187 | 01.08.2018 10:58:05 | 14,400 | 0d0019423ddbce6f423203e4810bf29855db0b6f | Don't ignore ping setting a thread to unread if backgrounded
The thread shouldn't count as "active" if the app/website is backgrounded. | [
{
"change_type": "MODIFY",
"old_path": "native/redux-setup.js",
"new_path": "native/redux-setup.js",
"diff": "@@ -34,6 +34,7 @@ import { NavigationActions, StackActions } from 'react-navigation';\nimport {\ncreateReactNavigationReduxMiddleware,\n} from 'react-navigation-redux-helpers';\n+import { Ap... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't ignore ping setting a thread to unread if backgrounded
The thread shouldn't count as "active" if the app/website is backgrounded. |
129,187 | 01.08.2018 11:52:52 | 14,400 | 6159faf2d30146d35dd2a45e9563ec4e01424579 | Include first activity update in first ping when foregrounding
This avoids a race condition between the activity update and the ping that has been causing poll/push inconsistency. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/ping-utils.js",
"new_path": "lib/shared/ping-utils.js",
"diff": "@@ -6,6 +6,7 @@ import type {\nPingResult,\n} from '../types/ping-types';\nimport type { DispatchActionPromise } from '../utils/action-utils';\n+import { serverRequestTypes } from '../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include first activity update in first ping when foregrounding
This avoids a race condition between the activity update and the ping that has been causing poll/push inconsistency. |
129,187 | 01.08.2018 14:02:04 | 14,400 | 3ccb72c5d40e2d9153f5c252dc8c2cf056bcb890 | [native] codeVersion -> 15 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 15 |
129,187 | 02.08.2018 11:44:11 | 14,400 | 2a53fcde91e8ec965479eb162b59c3d14c5c458b | [native] Delay SET_DEVICE_TOKEN until after REHYDRATE
Otherwise it gets sent with a `null` cookie, which triggers a non-invalidating `SET_COOKIE` post-`REHYDRATE`, which fucks everything up. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -200,6 +200,7 @@ class AppWithNavigationState extends React.PureComponent<Props> {\ninitialAndroidNotifHandled = false;\nopenThreadOnceReceived: Set<string> = new Set();\nupdateBadgeCountAfte... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delay SET_DEVICE_TOKEN until after REHYDRATE
Otherwise it gets sent with a `null` cookie, which triggers a non-invalidating `SET_COOKIE` post-`REHYDRATE`, which fucks everything up. |
129,187 | 02.08.2018 11:46:26 | 14,400 | e702a69ee7142f559583e91fc66cb9ed06fc636a | [native] codeVersion -> 16 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 16 |
129,187 | 02.08.2018 14:22:54 | 14,400 | f673a354f8278254459034e9e1df1e3e3373e58c | [server] Allow specification of target_cookie on a per-update basis
Sticking it into `UpdateData`. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/update-types.js",
"new_path": "lib/types/update-types.js",
"diff": "@@ -69,6 +69,7 @@ type BadDeviceTokenUpdateData = {|\nuserID: string,\ntime: number,\ndeviceToken: string,\n+ targetCookie: string,\n|};\nexport type UpdateData =\n| AccountDeletionU... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Allow specification of target_cookie on a per-update basis
Sticking it into `UpdateData`. |
129,187 | 03.08.2018 21:40:22 | 14,400 | 99b0f5c32e999d2a5d00882069670933980673b3 | Code to create new updateTypes.UPDATE_ENTRY updates | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "import type {\nRawEntryInfo,\nCalendarQuery,\n- SaveEntryRequest,\n+ SaveEntryInfo,\nSaveEntryResponse,\n- CreateEntryRequest,\n+ CreateEntryInfo,\nSaveEntryPayload,\n+ DeleteE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Code to create new updateTypes.UPDATE_ENTRY updates |
129,187 | 06.08.2018 11:08:15 | 14,400 | 42cc71f29df26dd19c025495b08b2fa5df5b3557 | Don't set thread to unread for expired SAVE_MESSAGES
Apparently, sometimes push notifs can get delivered after a ping delivers the corresponding updates, leading to update inconsistency.
With this commit we'll be checking to see if the message in the push notif has a timestamp that has already been passed by the update... | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -330,15 +330,20 @@ export default function reduceThreadInfos(\ninconsistencyResponses: state.inconsistencyResponses,\n};\n} else if (action.type === saveMessagesActionTy... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't set thread to unread for expired SAVE_MESSAGES
Apparently, sometimes push notifs can get delivered after a ping delivers the corresponding updates, leading to update inconsistency.
With this commit we'll be checking to see if the message in the push notif has a timestamp that has already been passed by the upda... |
129,187 | 07.08.2018 17:22:50 | 14,400 | e31dd3b28aa20e04380bb4ee11db4acd6ccb512d | [native] Use ... instead of manually listing every property in redux-setup
Thank for Flow for finally fixing this. | [
{
"change_type": "MODIFY",
"old_path": "native/redux-setup.js",
"new_path": "native/redux-setup.js",
"diff": "@@ -362,12 +362,9 @@ function validateState(oldState: AppState, state: AppState): AppState {\n) {\n// Makes sure a currently focused thread is never unread\nstate = {\n- navInfo: state.navIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use ... instead of manually listing every property in redux-setup
Thank for Flow for finally fixing this. |
129,187 | 07.08.2018 17:51:13 | 14,400 | 0639b7628833dd318f58fb7ed36538dac75336a4 | Fix behavior when first load of ChatMessageList has only one screen of items
Also keep `messageStore` from changing every ping.
Also properly center the notif badge text. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -355,6 +355,13 @@ function reduceMessageStore(\n);\n} else if (action.type === pingActionTypes.success) {\nlet messagesResult = action.payload.messagesResult;\n+ if (\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix behavior when first load of ChatMessageList has only one screen of items
Also keep `messageStore` from changing every ping.
Also properly center the notif badge text. |
129,187 | 07.08.2018 17:59:39 | 14,400 | 1297431e722eeca5403a7552f7ef63a6d824b763 | Actually fix single-screen-isnt-enough on web | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "@@ -70,6 +70,10 @@ class ChatMessageList extends React.PureComponent<Props, State> {\nloadingFromScroll = false;\ncomponentDidMount() {\n+ // In case we already h... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Actually fix single-screen-isnt-enough on web |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.