author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 07.08.2018 20:35:20 | 14,400 | 7f7ce057da52006500c0bd3d6d1530d77eeb3f3f | [native] Optimize reactotron usage | [
{
"change_type": "MODIFY",
"old_path": "native/reactotron.js",
"new_path": "native/reactotron.js",
"diff": "// @flow\n-import Reactotron, {\n- networking,\n- asyncStorage,\n- trackGlobalErrors,\n-} from 'reactotron-react-native';\n-import { reactotronRedux } from 'reactotron-redux';\n-\nlet reactotr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Optimize reactotron usage |
129,187 | 08.08.2018 12:59:32 | 14,400 | 0f2e2ed78cb26110aaaec4dcac1242eec80536f2 | [native] Never show in-app notification about activeThread
No need to pop up an in-app notification when we're already on the relevant thread. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -718,11 +718,7 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nthis.saveMessageInfos(messageInfos);\n}\nthis.pingNow();\n- invariant(this.inAppNotification, \"should be ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Never show in-app notification about activeThread
No need to pop up an in-app notification when we're already on the relevant thread. |
129,187 | 08.08.2018 13:06:11 | 14,400 | d31a358add8ea3cfa045595997fe880bc34e5355 | [native] Add no-op FOREGROUND and BACKGROUND actions
These are just for logging, so we can understand a chronological list of action types better. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -84,6 +84,8 @@ import {\nhandleURLActionType,\nRootNavigator,\nAppRouteName,\n+ backgroundActionType,\n+ foregroundActionType,\n} from './navigation-setup';\nimport { store } from './redux-se... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add no-op FOREGROUND and BACKGROUND actions
These are just for logging, so we can understand a chronological list of action types better. |
129,187 | 08.08.2018 13:34:19 | 14,400 | 70e09ae0101d7de0e9c533cace9a93eb14bb5080 | Avoid creating duplicate thread inconsistency reports | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -208,6 +208,7 @@ function findInconsistencies(\npollResult,\npushResult,\nlastActionTypes: reduxLogger.actions.map(action => action.type),\n+ time: Date.now(),\n}];\n}\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Avoid creating duplicate thread inconsistency reports |
129,187 | 09.08.2018 11:31:16 | 14,400 | fbc9fa1d70aea2d392537537204670e1aa90a5c3 | [native] Avoid notificationReceivedForeground on press-notif-while-closed
`notificationOpened` should cover this. this makes the behavior consistent with press-notif-while-backgrounded.
Also this commit updates `react-native-notications`. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -203,8 +203,10 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nopenThreadOnceReceived: Set<string> = new Set();\nupdateBadgeCountAfterNextPing = true;\nqueuedDeviceToken... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid notificationReceivedForeground on press-notif-while-closed
`notificationOpened` should cover this. this makes the behavior consistent with press-notif-while-backgrounded.
Also this commit updates `react-native-notications`. |
129,187 | 09.08.2018 15:21:33 | 14,400 | 577fa47dbbd5764d988c847be7cb9bc32582e3b4 | [native] Avoid activityUpdate on activeThread change with inactive NativeAppState
Inline comment explains the reasoning.
Also fixes error message when log in attempted with empty password. | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -197,6 +197,16 @@ class LogInPanel extends React.PureComponent<Props> {\n{ cancelable: false },\n);\nreturn;\n+ } else if (this.props.state.state.passwordInp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid activityUpdate on activeThread change with inactive NativeAppState
Inline comment explains the reasoning.
Also fixes error message when log in attempted with empty password. |
129,187 | 10.08.2018 10:09:18 | 14,400 | afaf90593606eef0fe80c5f3c3c16bf033c80466 | [server] Add code to delete rows from new filters table
Also adds some code to delete rows from `focused` that I forgot to add at the time.
Also a couple other things. | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -15,6 +15,7 @@ import { deleteOrphanedMessages } from './deleters/message-deleters';\nimport { deleteOrphanedFocused } from './deleters/activity-deleters';\nimport { deleteOrphanedNotifs } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add code to delete rows from new filters table
Also adds some code to delete rows from `focused` that I forgot to add at the time.
Also a couple other things. |
129,187 | 10.08.2018 10:25:27 | 14,400 | 9b4da8b5ac8d1d77f8684343dbd0e71c888c1a51 | Prevent empty message sends | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -456,7 +456,7 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nif (justLoggedIn) {\nthis.startTimeouts(nextProps, \"active\");\n} else if (nextProps.activeThread !== this... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prevent empty message sends |
129,187 | 10.08.2018 11:30:15 | 14,400 | f78802da253b80c574644cf4df7c299670157b9b | Update types since CalendarQuery is always included now
Also a fix where we weren't putting the `CalendarQuery` in `LOG_IN_STARTED` actions corresponding to recovery attempts. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -123,24 +123,18 @@ async function logIn(\nplatformDetails: getConfig().platformDetails,\n},\n);\n-\nconst userInfos = mergeUserInfos(\nresponse.userInfos,\nresponse.cookieChan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update types since CalendarQuery is always included now
Also a fix where we weren't putting the `CalendarQuery` in `LOG_IN_STARTED` actions corresponding to recovery attempts. |
129,187 | 10.08.2018 13:31:57 | 14,400 | 3054122ec0a6652edb9caba79936b4dbf9e3325f | [lib] PingResult always has updatesResult | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/device-token-reducer.js",
"new_path": "lib/reducers/device-token-reducer.js",
"diff": "@@ -13,7 +13,6 @@ export default function reduceDeviceToken(\nif (action.type === setDeviceTokenActionTypes.started) {\nreturn action.payload;\n} else if (actio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] PingResult always has updatesResult |
129,187 | 10.08.2018 13:32:32 | 14,400 | 576e371c8cb11a795234019b6f13663836632c01 | [lib] Use JOIN_THREAD and DELETE_THREAD to determine calendar filters changes
Instead of comparing and contrasing the list of threads before and after `threadReducer`. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/calendar-filters-reducer.js",
"new_path": "lib/reducers/calendar-filters-reducer.js",
"diff": "@@ -10,6 +10,7 @@ import {\n} from '../types/filter-types';\nimport type { BaseAction } from '../types/redux-types';\nimport type { RawThreadInfo } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use JOIN_THREAD and DELETE_THREAD to determine calendar filters changes
Instead of comparing and contrasing the list of threads before and after `threadReducer`. |
129,187 | 10.08.2018 13:36:10 | 14,400 | 93001bf6f15597632520b78b125df7f7cb5702b5 | [server] Fix use of updateFilterIfChanged versus createFilter | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -46,8 +46,7 @@ import {\n} from '../session/cookies';\nimport { deviceTokenUpdater } from '../updaters/device-token-updaters';\nimport createReport f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix use of updateFilterIfChanged versus createFilter |
129,187 | 10.08.2018 14:04:00 | 14,400 | ee6d1bc36e81b823d871cdb71a997dbc15e81034 | [lib] Get rid of unused fetchEntriesAndSetRangeActionTypes | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -39,11 +39,6 @@ async function fetchEntries(\n};\n}\n-const fetchEntriesAndSetRangeActionTypes = Object.freeze({\n- started: \"FETCH_ENTRIES_AND_SET_RANGE_STARTED\",\n- succ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of unused fetchEntriesAndSetRangeActionTypes |
129,187 | 13.08.2018 21:36:08 | 14,400 | 7518a57f375e3e200e44b04cedd16ad6d98f90b4 | web and lib updates for new UPDATE_CALENDAR_QUERY paradigm
Also unrelated reducer updates since I figured it'd be easier to do it in one go. | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -13,6 +13,7 @@ import type {\nRestoreEntryResponse,\nFetchEntryInfosResult,\nCalendarResult,\n+ CalendarQueryUpdateResult,\n} from '../types/entry-types';\nimport type { Fet... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | web and lib updates for new UPDATE_CALENDAR_QUERY paradigm
Also unrelated reducer updates since I figured it'd be easier to do it in one go. |
129,187 | 13.08.2018 21:50:13 | 14,400 | 1511c7a830316e5de7671f5df5870290818979a5 | [server] Introduce update_calendar_query endpoint | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/entry-responders.js",
"new_path": "server/src/responders/entry-responders.js",
"diff": "@@ -10,6 +10,7 @@ import type {\nRestoreEntryRequest,\nRestoreEntryResponse,\nFetchEntryInfosResponse,\n+ FetchEntryInfosResult,\nSaveEntryResult,\n} ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce update_calendar_query endpoint |
129,187 | 13.08.2018 23:45:10 | 14,400 | 005768511daeb30f4750ccd4f8a2dd52bd1bdafc | native and lib updates for new UPDATE_CALENDAR_QUERY paradigm | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -59,23 +59,6 @@ async function updateCalendarQuery(\n}\n}\n-const fetchEntriesAndAppendRangeActionTypes = Object.freeze({\n- started: \"FETCH_ENTRIES_AND_APPEND_RANGE_STARTE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | native and lib updates for new UPDATE_CALENDAR_QUERY paradigm |
129,187 | 13.08.2018 23:50:23 | 14,400 | 99c1376cc0c6d654165e070de6858637dfffa1ee | [server] Include userInfos from FetchUpdatesResult in ping response | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -243,12 +243,13 @@ async function pingResponder(\nconst { fetchUpdateResult } = await promiseAll(promises);\n- let updatesResult = null;\n+ let updat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include userInfos from FetchUpdatesResult in ping response |
129,187 | 14.08.2018 00:17:20 | 14,400 | 119f30a13bd6c55e6c13fd3bbbe53cb708585f92 | Get user-reducer looking at UserInfos in CreateUpdatesResponse on entry actions
Also made it `CreateUpdatesResponse` instead of `CreateUpdatesResult` (`UserInfos` in array instead of object). | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -12,6 +12,10 @@ import { setCookieActionType } from '../utils/action-utils';\nimport {\nfetchEntriesActionTypes,\nupdateCalendarQueryActionTypes,\n+ createEntryActionTypes,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get user-reducer looking at UserInfos in CreateUpdatesResponse on entry actions
Also made it `CreateUpdatesResponse` instead of `CreateUpdatesResult` (`UserInfos` in array instead of object). |
129,187 | 14.08.2018 13:21:18 | 14,400 | 9bb0a6bbaf584444ed26e85766e589615d9d4835 | Simplify session ID management
Session ID now represents a state initialization so we can use it for tracking updates. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -5,7 +5,6 @@ import type { BaseNavInfo } from '../types/nav-types';\nimport invariant from 'invariant';\n-import { sessionInactivityLimit } from '../selectors/session-se... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Simplify session ID management
Session ID now represents a state initialization so we can use it for tracking updates. |
129,187 | 15.08.2018 19:35:41 | 25,200 | 69acd6b9cd09fa8a8ff452456a917bd1c9dfa35c | Pass sessionID to the server on web
Server will have `sessionID` property on `Viewer` now to access the `sessionID` of web clients. This is necessary to uniquely identify different web sessions that are using the same cookie. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -224,6 +224,7 @@ async function fetchNewCookieFromNativeCredentials(\ndispatch: Dispatch,\ncookie: ?string,\nurlPrefix: string,\n+ sessionID: string,\nsource: LogInActionSource,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Pass sessionID to the server on web
Server will have `sessionID` property on `Viewer` now to access the `sessionID` of web clients. This is necessary to uniquely identify different web sessions that are using the same cookie. |
129,187 | 15.08.2018 22:31:49 | 25,200 | 3ac1e4abecdf22c7593c77ec2a5bca87013bf59d | [server] Use new "session" concept instead of cookies for filters and updates | [
{
"change_type": "MODIFY",
"old_path": "lib/types/update-types.js",
"new_path": "lib/types/update-types.js",
"diff": "@@ -79,7 +79,7 @@ type EntryUpdateData = {|\nuserID: string,\ntime: number,\nentryID: string,\n- targetCookie: string,\n+ targetSession: string,\n|};\nexport type UpdateData =\n| Acc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use new "session" concept instead of cookies for filters and updates |
129,187 | 15.08.2018 22:58:09 | 25,200 | b732ec82cabf85485c5cea40bfc2c1899e0bc3f4 | [server] deleteExpiredCookies should be using last_used, not last_update
The latter is for tracking update delivery, and is set to 0 for anonymous cookies, which means all of them are getting wiped every night. | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/cookie-deleters.js",
"new_path": "server/src/deleters/cookie-deleters.js",
"diff": "@@ -65,7 +65,7 @@ async function deleteExpiredCookies(): Promise<void> {\nLEFT JOIN filters fi ON fi.session = c.id\nLEFT JOIN updates u ON u.target = c.id\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] deleteExpiredCookies should be using last_used, not last_update
The latter is for tracking update delivery, and is set to 0 for anonymous cookies, which means all of them are getting wiped every night. |
129,187 | 15.08.2018 23:09:59 | 25,200 | 198038d74d58f4ff5078f02e9b3672f9a839eafd | [server] Call createFilter from websiteResponder | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -42,6 +42,7 @@ import { fetchThreadInfos } from '../fetchers/thread-fetchers';\nimport { fetchEntryInfos } from '../fetchers/entry-fetchers';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Call createFilter from websiteResponder |
129,187 | 13.09.2018 00:59:38 | 14,400 | fb736dc93a207dd66d2e3d12535dfd39343ee1f1 | Centralize Object.values $FlowFixMe | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -22,6 +22,7 @@ import type { RawMessageInfo } from '../types/message-types';\nimport { dateFromString } from '../utils/date-utils'\nimport { getNewLocalID } from '../utils/l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Centralize Object.values $FlowFixMe |
129,187 | 13.09.2018 13:33:56 | 14,400 | fb747142328792ba73f91cf68e8e98bf1f72b711 | setNewSession function that generates new sessionIDs | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -25,7 +25,7 @@ import { sendEmailAddressVerificationEmail } from '../emails/verification';\nimport createMessages from './message-creator';\nimport creat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | setNewSession function that generates new sessionIDs |
129,187 | 13.09.2018 14:21:08 | 14,400 | 2a027858f34ea753cea64469ab26b4ec1d2efafa | [server] filters -> sessions | [
{
"change_type": "RENAME",
"old_path": "server/src/creators/filter-creator.js",
"new_path": "server/src/creators/session-creator.js",
"diff": "@@ -5,20 +5,19 @@ import type { CalendarQuery } from 'lib/types/entry-types';\nimport { dbQuery, SQL } from '../database';\n-// \"Filter\" here refers to the... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] filters -> sessions |
129,187 | 13.09.2018 14:51:26 | 14,400 | 10aeeef2bb3283897e6a4c53f29ea3b2a539baf0 | [server] Update deleters for new cookies/sessions/focused table structures | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/account-deleters.js",
"new_path": "server/src/deleters/account-deleters.js",
"diff": "@@ -38,7 +38,7 @@ async function deleteAccount(\n// TODO: if this results in any orphaned orgs, convert them to chats\nconst deletedUserID = viewer.userID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update deleters for new cookies/sessions/focused table structures |
129,187 | 13.09.2018 14:52:36 | 14,400 | a6da417a22a215100eabfee84d7d798952037940 | [server] sessions table owns last_update now instead of cookies table | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -82,7 +82,7 @@ async function createAccount(\nVALUES ${[newUserRow]}\n`;\nconst [ userViewerData ] = await Promise.all([\n- createNewUserCookie(id, 0, re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] sessions table owns last_update now instead of cookies table |
129,187 | 13.09.2018 15:12:04 | 14,400 | c603407c8d1225057e06bcd9e5046b0c7b3c4ef6 | [server] Change focused table to be session-based instead of cookie-based | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -121,19 +121,19 @@ async function updateFocusedRows(\nif (threadIDs.length > 0) {\nconst focusedInsertRows = threadIDs.map(threadID => [\nviewer.user... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Change focused table to be session-based instead of cookie-based |
129,187 | 13.09.2018 15:22:17 | 14,400 | 4bb70cda347d26ebaea26de43fa0eab8ca595e1e | Use Viewer.session instead of separately passing up sessionID
Also updates the column in the `revisions` table to be called `session` instead of `session_id`. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/entry-types.js",
"new_path": "lib/types/entry-types.js",
"diff": "@@ -85,7 +85,6 @@ export type SaveEntryInfo = {|\nentryID: string,\ntext: string,\nprevText: string,\n- sessionID: string,\ntimestamp: number,\ncalendarQuery: CalendarQuery,\n|};\n@@ -... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use Viewer.session instead of separately passing up sessionID
Also updates the column in the `revisions` table to be called `session` instead of `session_id`. |
129,187 | 13.09.2018 21:45:27 | 14,400 | c1a9e5305ac3ba1c7ec464bc5761ea7df5a7beb6 | Forgot to enabled Flow in objects.js... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/objects.js",
"new_path": "lib/utils/objects.js",
"diff": "+// @flow\n+\nfunction findMaximumDepth(obj: Object): ?{ path: string, depth: number } {\nlet longestPath = null;\nlet longestDepth = null\n@@ -27,13 +29,13 @@ function findMaximumDepth(obj: O... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Forgot to enabled Flow in objects.js... |
129,187 | 13.09.2018 22:47:01 | 14,400 | e2dc9328824c74d1d0a294e1d62dd5388fd296ed | [server] Introducing scripts folder and first step of session migration script | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"scripts\": {\n\"babel\": \"babel src/ --out-dir dist/ --ignore 'lib/flow-typed','lib/node_modules','lib/package.json','web/flow-typed','web/node_modules','web/package.json','web/dist/hot','web... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introducing scripts folder and first step of session migration script |
129,187 | 13.09.2018 22:59:11 | 14,400 | 92e4e7f4914d38c3c164371c8e603a69614ace01 | [server] Initialize uninitialized sessions in pingResponder | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -9,6 +9,7 @@ import {\n} from 'lib/types/request-types';\nimport { isDeviceType, assertDeviceType } from 'lib/types/device-types';\nimport { reportTy... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Initialize uninitialized sessions in pingResponder |
129,187 | 14.09.2018 13:41:31 | 14,400 | c5e2ad82362fe76e7721671a40bdadd7a254e994 | [server] Completed session migration script | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/session-migration.js",
"new_path": "server/src/scripts/session-migration.js",
"diff": "@@ -5,7 +5,10 @@ import createIDs from '../creators/id-creator';\nasync function main() {\ntry {\n- await migrateFiltersToSessions();\n+ await migrateFilt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Completed session migration script |
129,187 | 14.09.2018 13:57:57 | 14,400 | 8dffd6e70c31af8efeee5c934ef74c61c09060df | [server] Avoid SQL keyword "is" | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/account-deleters.js",
"new_path": "server/src/deleters/account-deleters.js",
"diff": "@@ -38,7 +38,7 @@ async function deleteAccount(\n// TODO: if this results in any orphaned orgs, convert them to chats\nconst deletedUserID = viewer.userID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid SQL keyword "is" |
129,187 | 14.09.2018 14:11:46 | 14,400 | 44d2a52a4c00b6bd5b37513ca942779ca9d7a6e9 | [server] Minor final updates to session-migration | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/session-migration.js",
"new_path": "server/src/scripts/session-migration.js",
"diff": "@@ -8,7 +8,7 @@ async function main() {\nawait migrateFiltersTableToSessions();\nawait migrateSessionsRelatedColumns();\nawait migrateUpdatesTable();\n- /... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Minor final updates to session-migration |
129,187 | 14.09.2018 14:39:17 | 14,400 | f9dfd7e4f9fa803c60dee22c99518ba95c0e7e0c | [server] Force BODY_SESSION_ID on GET | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -209,6 +209,9 @@ function getSessionIDFromRequestBody(req: $Request): ?string {\nfunction getSessionIdentifierTypeFromRequestBody(\nreq: $Request,\n): SessionIdentifierTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Force BODY_SESSION_ID on GET |
129,187 | 14.09.2018 17:46:13 | 14,400 | d755fafa5d323567f58eb3297220c0787c49c4b8 | [server] Validate sessionID before setting it | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -80,7 +80,10 @@ async function fetchUserViewer(\nFROM cookies\nWHERE id = ${cookieID} AND user IS NOT NULL\n`;\n- const [ result ] = await dbQuery(query);\n+ const [ [ res... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Validate sessionID before setting it |
129,187 | 14.09.2018 18:41:13 | 14,400 | fca05784a4600a386783187900563a4e35404954 | [server] Refine session-updating before in pingResponder and calendarQueryUpdateResponder | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/session-creator.js",
"new_path": "server/src/creators/session-creator.js",
"diff": "@@ -21,7 +21,10 @@ async function createSession(\nconst query = SQL`\nINSERT INTO sessions (id, user, cookie, query, time, last_update)\nVALUES ${[row]}\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Refine session-updating before in pingResponder and calendarQueryUpdateResponder |
129,187 | 14.09.2018 19:16:00 | 14,400 | 680b00480041255286df8ba4c6fa568e0d310855 | [server] Assorted fixes to new session code | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -42,6 +42,7 @@ import {\nimport { fetchCurrentUserInfo } from '../fetchers/user-fetchers';\nimport { fetchUpdateInfos } from '../fetchers/update-fetc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Assorted fixes to new session code |
129,187 | 14.09.2018 19:37:09 | 14,400 | 961704122ff8167a289a9534dae074ac1dd9875c | [server] Return sessionContinued from initializeSession | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -317,26 +317,32 @@ async function recordThreadPollPushInconsistency(\nawait createReport(viewer, reportCreationRequest);\n}\n+type SessionInitializat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Return sessionContinued from initializeSession |
129,187 | 15.09.2018 13:58:04 | 14,400 | 39b1c9a4c81343044d3cd4f74ef7ded9d5f7751f | [server] Fix bug where valid body cookie was being ignored | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -306,7 +306,10 @@ async function fetchViewerFromRequestBody(\nasync function fetchViewerForJSONRequest(req: $Request): Promise<Viewer> {\nassertSecureRequest(req);\nlet re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix bug where valid body cookie was being ignored |
129,187 | 17.09.2018 11:07:04 | 14,400 | 232d4c6f2efde5914c513f1a9c101400d3c2ae72 | [server] Call activityUpdater from websiteResponder
If the user is loading a chat thread, immediately specify it as active. | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -33,6 +33,7 @@ import 'web/server-rendering';\nimport * as ReduxSetup from 'web/redux-setup';\nimport App from 'web/dist/app.build';\nimport { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Call activityUpdater from websiteResponder
If the user is loading a chat thread, immediately specify it as active. |
129,187 | 17.09.2018 11:14:17 | 14,400 | ab7a296c91e5bee8efbd664f4878062b785bc377 | [server] Delete expired rows from the focused table in the nightly cronjob | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/ping-utils.js",
"new_path": "lib/shared/ping-utils.js",
"diff": "@@ -15,10 +15,20 @@ import { pingActionTypes } from '../actions/ping-actions';\n// app is active and the user is logged in.\nconst pingFrequency = 3000; // in milliseconds\n+// If the ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete expired rows from the focused table in the nightly cronjob |
129,187 | 17.09.2018 11:21:42 | 14,400 | 1a9f5df7e61b0a2508c29a627db5774bccbde750 | [server] Delete session-targeted updates when the session is deleted
And also rows in the `focused` table pertaining to those sessions. | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/cookie-deleters.js",
"new_path": "server/src/deleters/cookie-deleters.js",
"diff": "@@ -7,14 +7,14 @@ import { fetchDeviceTokensForCookie } from '../fetchers/device-token-fetchers';\nasync function deleteCookie(cookieID: string): Promise<vo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete session-targeted updates when the session is deleted
And also rows in the `focused` table pertaining to those sessions. |
129,187 | 17.09.2018 11:26:33 | 14,400 | 534346bbc6387f45d80c3c7a12d25674c5de83b8 | [web] Give everyone web chat
I'm not actively working on this right now, but I don't want to block people from using it. It's not very good yet but it sorta works... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/user-utils.js",
"new_path": "lib/shared/user-utils.js",
"diff": "@@ -30,12 +30,7 @@ function isStaff(userID: string) {\nreturn false;\n}\n-function hasWebChat(userID: string) {\n- return isStaff(userID) || userID === friends.larry;\n-}\n-\nexport {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Give everyone web chat
I'm not actively working on this right now, but I don't want to block people from using it. It's not very good yet but it sorta works... |
129,187 | 17.09.2018 15:04:43 | 14,400 | 9fc38ffe8d4f6653a29b780513d511fb161f05af | [server] Introduce calendarQueryDifference
Subtracts one `CalendarQuery` from another, returning an array of `CalendarQueries`. Will be used to fetch only the `EntryInfo`s that are in the new and not the old. | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/update-deleters.js",
"new_path": "server/src/deleters/update-deleters.js",
"diff": "@@ -37,7 +37,7 @@ async function deleteExpiredUpdates(): Promise<void> {\n`);\n}\n-async function deleteUpdatesBeforeTimeTargettingCookie(\n+async function ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce calendarQueryDifference
Subtracts one `CalendarQuery` from another, returning an array of `CalendarQueries`. Will be used to fetch only the `EntryInfo`s that are in the new and not the old. |
129,187 | 18.09.2018 11:03:09 | 14,400 | c30ec7f01e9d448b713edd7d97344bc1831fce0d | [server] Support fetching entries for multiple CalendarQueries at once | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -361,7 +361,7 @@ async function fetchUpdateInfosWithUpdateDatas(\n};\npromises.calendarResult = fetchEntryInfos(\nviewerInfo.viewer,\n- threadCalendarQuery... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Support fetching entries for multiple CalendarQueries at once |
129,187 | 18.09.2018 11:12:29 | 14,400 | 155ca5682dc16ea63098eaff588bbcabd93a51db | Move calendarQueryDifference to lib | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/entry-utils.js",
"new_path": "lib/shared/entry-utils.js",
"diff": "@@ -13,8 +13,10 @@ import {\n} from '../types/filter-types';\nimport invariant from 'invariant';\n+import _isEqual from 'lodash/fp/isEqual';\nimport {\n+ dateString,\ngetDate,\ndateF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move calendarQueryDifference to lib |
129,187 | 18.09.2018 11:45:15 | 14,400 | 41ef25b90671b85069e4266d9c74ec089a280bd8 | [server] Return delta EntryInfos from calendarQueryUpdateResponder and pingResponder | [
{
"change_type": "MODIFY",
"old_path": "lib/types/ping-types.js",
"new_path": "lib/types/ping-types.js",
"diff": "@@ -38,6 +38,7 @@ export type PingResponse = {|\nuserInfos: $ReadOnlyArray<UserInfo>,\nupdatesResult?: UpdatesResult,\nserverRequests?: $ReadOnlyArray<ServerRequest>,\n+ deltaEntryInfos?... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Return delta EntryInfos from calendarQueryUpdateResponder and pingResponder |
129,187 | 18.09.2018 12:57:46 | 14,400 | 1eb54e634253bb39f0280b3a56cd99862d1f3282 | [server] Delete old web sessions | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -15,7 +15,10 @@ import { deleteOrphanedMessages } from './deleters/message-deleters';\nimport { deleteOrphanedFocused } from './deleters/activity-deleters';\nimport { deleteOrphanedNotifs } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete old web sessions |
129,187 | 18.09.2018 15:27:58 | 14,400 | dd7042249bceef2cd889001fc23efb84d3c3c173 | Check entry consistency on entry mutation actions | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -4,13 +4,13 @@ import type {\nRawEntryInfo,\nCalendarQuery,\nSaveEntryInfo,\n- SaveEntryResponse,\n+ SaveEntryResult,\nCreateEntryInfo,\nSaveEntryPayload,\nDeleteEntryInfo,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Check entry consistency on entry mutation actions |
129,187 | 19.09.2018 10:34:21 | 14,400 | c33c340be3daf166bf68b8fee0ce39a6e1c93b52 | [native] Update calendar reset mechanism
We can no longer rely on the `sessionID` to detect when `currentCalendarQuery` is reset. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -109,7 +109,6 @@ type Props = {\n// Redux state\nlistData: ?$ReadOnlyArray<CalendarItem>,\ntabActive: bool,\n- sessionID: string,\nstartDate: string,\nendDate: str... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update calendar reset mechanism
We can no longer rely on the `sessionID` to detect when `currentCalendarQuery` is reset. |
129,187 | 19.09.2018 10:48:33 | 14,400 | 73c8192f359fe9109ae5f52d983686cc6dafb7ea | [web] Fix chat loading on log in | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "@@ -70,10 +70,6 @@ class ChatMessageList extends React.PureComponent<Props, State> {\nloadingFromScroll = false;\ncomponentDidMount() {\n- // In case we already h... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix chat loading on log in |
129,187 | 19.09.2018 10:50:01 | 14,400 | 19593db23b8ade1d63b0e7419c4306f6b515658f | [native] codeVersion -> 17 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 17 |
129,187 | 19.09.2018 14:09:22 | 14,400 | 0a7aad4b280bac232142b77bb846c702b8c7570c | [server] Fix filtering logic for updateTypes.UPDATE_ENTRY | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/entry-creator.js",
"new_path": "server/src/creators/entry-creator.js",
"diff": "@@ -17,7 +17,7 @@ import createIDs from '../creators/id-creator';\nimport createMessages from '../creators/message-creator';\nimport { checkThreadPermission } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix filtering logic for updateTypes.UPDATE_ENTRY |
129,187 | 19.09.2018 14:26:48 | 14,400 | a03655aa7188577737f2457e7c1fc47bb1e81721 | [native] Fix paging behavior in calendar | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -295,7 +295,7 @@ function reduceEntryInfos(\nentryInfos,\ndaysToEntries,\nactualizedCalendarQuery: action.payload.calendarQuery,\n- lastUserInteractionCalendar,\n+ lastUse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix paging behavior in calendar |
129,187 | 19.09.2018 14:35:30 | 14,400 | 93fbd37471f650b4ba48efb7b1094b22fa131d26 | [native] codeVersion -> 18 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 18 |
129,187 | 20.09.2018 08:20:39 | 14,400 | 6787b5f3c118f7d5ee1ef1889d9b96c100d28711 | [server] Actually delete web sessions in cron, and do it after deleting updates | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -39,8 +39,9 @@ if (cluster.isMaster) {\nawait deleteOrphanedMessages();\nawait deleteOrphanedFocused();\nawait deleteOrphanedNotifs();\n- await deleteExpiredUpdates();\nawait deleteOrphanedSess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Actually delete web sessions in cron, and do it after deleting updates |
129,187 | 20.09.2018 14:11:20 | 14,400 | a0b475df97a6f9524f5122e716c23aeeffc4f9b9 | [server] Extract ServerRequest/ClientResponder logic in pingResponder | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -7,6 +7,8 @@ import {\nserverRequestTypes,\ntype ThreadPollPushInconsistencyClientResponse,\ntype EntryPollPushInconsistencyClientResponse,\n+ type C... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Extract ServerRequest/ClientResponder logic in pingResponder |
129,187 | 20.09.2018 14:48:29 | 14,400 | 12e1632eb98afdca461769bdaf57f06841363ecf | [server] Ping payload reduction step 1
Server support for only returning the delta. WebSockets coming soon... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -535,6 +535,11 @@ export type FetchMessageInfosPayload = {|\ntruncationStatus: MessageTruncationStatus,\nuserInfos: UserInfo[],\n|};\n+export type MessagesPingResponse = {|\n+ r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Ping payload reduction step 1
Server support for only returning the delta. WebSockets coming soon... |
129,187 | 20.09.2018 17:21:21 | 14,400 | d3d36448331cae94809989d501cc0a100cd4a8a2 | Client-side updates to handle ping payload reduction | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "// @flow\nimport type { FetchJSON } from '../utils/fetch-json';\n-import type { PingActionInput, PingResult } from '../types/ping-types';\n+import {\n+ type PingActionInput,\n+ t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Client-side updates to handle ping payload reduction |
129,187 | 20.09.2018 17:58:10 | 14,400 | 31513c659859689cf870473f7b1a3e5f77c50fff | [native] Stop using ping to resolve weird app start state | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -8,11 +8,6 @@ import type {\nimport type { Dispatch } from 'lib/types/redux-types';\nimport type { AppState } from '../redux-setup';\nimport type { A... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Stop using ping to resolve weird app start state |
129,187 | 20.09.2018 18:12:46 | 14,400 | 618999f440ba22b5af8ebaacd3d60e79cf8f960a | [lib] Don't include loggedIn in ping action payloads | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "@@ -31,6 +31,9 @@ async function ping(\nclientResponses: actionInput.clientResponses,\nwatchedIDs,\n});\n+ if (!response.updatesResult) {\n+ throw new Error(\"we have an anonymou... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Don't include loggedIn in ping action payloads |
129,187 | 20.09.2018 19:23:41 | 14,400 | 883aa5412adcd77b761b2e7fc967fdae7f95d895 | [native] Fix require loop | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -53,8 +53,10 @@ import LogInPanelContainer from './log-in-panel-container.react';\nimport RegisterPanel from './register-panel.react';\nimport Connec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix require loop |
129,187 | 20.09.2018 19:40:43 | 14,400 | e4b02ef6e412a7cd4a1ee71e66297b284b80b682 | Two fixes to things I broke in ping | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "@@ -34,12 +34,6 @@ async function ping(\nif (!response.updatesResult) {\nthrow new Error(\"we have an anonymous cookie but think we're logged in\");\n}\n- const messagesResult = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Two fixes to things I broke in ping |
129,187 | 20.09.2018 20:17:01 | 14,400 | 91b37e960945d4bf361f5ad6e09e5797e65e1baf | [server] Include UPDATE_ENTRY's targetSession in conditionKey
Also updates SQL delete logic to consider session when specified in `conditionKey`. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/update-utils.js",
"new_path": "lib/shared/update-utils.js",
"diff": "@@ -58,7 +58,13 @@ function keyForUpdateInfo(updateInfo: UpdateInfo): ?string {\nfunction conditionKeyForUpdateData(updateData: UpdateData): ?string {\nconst key = keyForUpdateData... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include UPDATE_ENTRY's targetSession in conditionKey
Also updates SQL delete logic to consider session when specified in `conditionKey`. |
129,187 | 20.09.2018 20:26:52 | 14,400 | 3e71606a5ae78c7407dd7dadf4703e0b80346eb1 | [native] Stop reseting calendar whenever tab is clicked
Only do this when it's clicked and the calendar view is already in focus. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -174,8 +174,7 @@ class InnerCalendar extends React.PureComponent<Props, State> {\n}) => {\nif (!navigation.isFocused()) {\ndefaultHandler();\n- }\n- if (currentCal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Stop reseting calendar whenever tab is clicked
Only do this when it's clicked and the calendar view is already in focus. |
129,187 | 24.09.2018 11:57:27 | 14,400 | ca8dd151ea6b8b648f02a928495a4b0541743dbd | [server] Introducing last_validated column on sessions table
Also changing `time` column to `creation_time`, since that's what it effectively is. | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/session-creator.js",
"new_path": "server/src/creators/session-creator.js",
"diff": "@@ -10,21 +10,24 @@ async function createSession(\ncalendarQuery: CalendarQuery,\ninitialLastUpdate: number,\n): Promise<void> {\n+ const time = Date.now();... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introducing last_validated column on sessions table
Also changing `time` column to `creation_time`, since that's what it effectively is. |
129,187 | 24.09.2018 14:39:13 | 14,400 | 15a40cdffffee41d73231d6d1b5c98a41d44dc06 | [server] Fetch SessionInfo in initial validation query | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/session-creator.js",
"new_path": "server/src/creators/session-creator.js",
"diff": "@@ -30,6 +30,10 @@ async function createSession(\nlast_validated = VALUES(last_validated)\n`;\nawait dbQuery(query);\n+ viewer.setSessionInfo({\n+ lastValid... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fetch SessionInfo in initial validation query |
129,187 | 25.09.2018 17:24:15 | 14,400 | 56859459e97d2878c47520c2eb4d9e093893d7e1 | PollPushInconsistency -> Inconsistency | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -10,7 +10,7 @@ import type {\nimport { type RawThreadInfo } from '../types/thread-types';\nimport { updateTypes, type UpdateInfo } from '../types/update-types';\nimport {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | PollPushInconsistency -> Inconsistency |
129,187 | 26.09.2018 10:38:58 | 14,400 | 860ea07280ffb8f4fa1ebe0111a4e3ed1c212154 | [server] Fix fetchSessionInfo to work with native | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -244,7 +244,7 @@ function getSessionIdentifierTypeFromRequestBody(\n}\ntype SessionInfo = {|\n- sessionID: string,\n+ sessionID: ?string,\nlastValidated: number,\ncalendar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix fetchSessionInfo to work with native |
129,187 | 26.09.2018 12:34:47 | 14,400 | e310ca0252bbb4af77e792f15be34c0031e91a39 | Remove a bunch of extant jQuery references | [
{
"change_type": "DELETE",
"old_path": "lib/flow-typed/npm/jquery-param_vx.x.x.js",
"new_path": null,
"diff": "-// flow-typed signature: 181bade05b2c56f353250053c4c4e917\n-// flow-typed version: <<STUB>>/jquery-param_v^0.2.0/flow_v0.64.0\n-\n-/**\n- * This is an autogenerated libdef stub for:\n- *\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove a bunch of extant jQuery references |
129,187 | 26.09.2018 12:55:34 | 14,400 | 14272e28ad7ef1c411f3844f53079e921171709b | [server] Avoid crashing due to lack of sessionInfo
This can happen if the user isn't logged in, or if their session isn't correctly initialized before the `sessionInfo` is accessed. | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -192,17 +192,21 @@ async function pingResponder(\nawait verifyCalendarQueryThreadIDs(calendarQuery);\nconst oldUpdatesCurrentAsOf = request.updatesCu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid crashing due to lack of sessionInfo
This can happen if the user isn't logged in, or if their session isn't correctly initialized before the `sessionInfo` is accessed. |
129,187 | 26.09.2018 12:59:27 | 14,400 | ca24e0cdef3be414e2d5f3d861e5716e313b3d27 | Constantly check state
Instead of doing this once every three hours, we're going to do it literally all the time.
Assuming the state is good, this is just three hashes per ping, and I got an inexplicable inconsistency this morning so I want to investigate it more. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/session-types.js",
"new_path": "lib/types/session-types.js",
"diff": "@@ -8,7 +8,8 @@ import type {\n} from './user-types';\nexport const cookieLifetime = 30*24*60*60*1000; // in milliseconds\n-export const sessionCheckFrequency = 3*60*60*1000; // in... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Constantly check state
Instead of doing this once every three hours, we're going to do it literally all the time.
Assuming the state is good, this is just three hashes per ping, and I got an inexplicable inconsistency this morning so I want to investigate it more. |
129,187 | 26.09.2018 13:04:29 | 14,400 | 6d8823f83cc5023d32eeb7f3978bb35c2e8f867d | [server] Use usersInRawEntryInfos in fetchEntriesForSession | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/entry-fetchers.js",
"new_path": "server/src/fetchers/entry-fetchers.js",
"diff": "@@ -21,7 +21,10 @@ import {\nfilteredThreadIDs,\nfilterExists,\n} from 'lib/selectors/calendar-filter-selectors';\n-import { rawEntryInfoWithinCalendarQuery }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use usersInRawEntryInfos in fetchEntriesForSession |
129,187 | 26.09.2018 16:34:38 | 14,400 | 5c07ad71955eb23b3e4a2b55932d33bd9fd4f168 | deltaEntryInfos only included in FULL when client requires FULL | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/ping-actions.js",
"new_path": "lib/actions/ping-actions.js",
"diff": "@@ -74,7 +74,6 @@ async function ping(\nprevState: actionInput.prevState,\nupdatesResult: response.updatesResult,\nrequests,\n- deltaEntryInfos: response.deltaEntryInfos,\n};\n}\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | deltaEntryInfos only included in FULL when client requires FULL |
129,187 | 26.09.2018 17:01:49 | 14,400 | 123d72af48b308737f2a7792def2aaf10b0443a8 | Support for integrating corrected state from server in reducers | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -26,7 +26,6 @@ import _mapKeys from 'lodash/fp/mapKeys';\nimport _groupBy from 'lodash/fp/groupBy';\nimport _isEqual from 'lodash/fp/isEqual';\nimport _isEmpty from 'lodas... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Support for integrating corrected state from server in reducers |
129,187 | 26.09.2018 17:58:18 | 14,400 | 9bfae551fdd7718ad1b4f94d2d11f7c4d72b5ffe | Client code to compare state hashes for state check | [
{
"change_type": "MODIFY",
"old_path": "lib/flow-typed/npm/color_vx.x.x.js",
"new_path": "lib/flow-typed/npm/color_vx.x.x.js",
"diff": "-// flow-typed signature: 602a4047914dc479daf79464738f1697\n-// flow-typed version: <<STUB>>/color_v^1.0.3/flow_v0.75.0\n+// flow-typed signature: 997311ffa0bc8ada9... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Client code to compare state hashes for state check |
129,187 | 26.09.2018 20:26:38 | 14,400 | 83d9bf072abd70798a796cb2f6750f6b4ec49d73 | Switch away from object-hash
It was giving inconsistent results | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/flow-typed/npm/fast-json-stable-stringify_vx.x.x.js",
"diff": "+// flow-typed signature: 26bd885ae6cc09f69cd5a0b3926f5aed\n+// flow-typed version: <<STUB>>/fast-json-stable-stringify_v^2.0.0/flow_v0.78.0\n+\n+/**\n+ * This is an autogenerate... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Switch away from object-hash
It was giving inconsistent results |
129,187 | 26.09.2018 21:22:31 | 14,400 | 9aba2a98cab087f742322c724aa1dae3faf57618 | [native] Avoid require loops with action types | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -56,7 +56,7 @@ import { createIsForegroundSelector } from '../selectors/nav-selectors';\nimport {\nnavigateToAppActionType,\nresetUserStateActionType... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid require loops with action types |
129,187 | 27.09.2018 14:48:48 | 14,400 | 49c18d09225d7700085bc5e68b632cfb124d0d23 | [server] Separate notification sends by client codeVersion
In preparation with `RawMessageInfo`s depending on client `codeVersion`, since we'll be mapping future message types to `messageType.UNSUPPORTED`. | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -292,7 +292,7 @@ async function sendPushNotifsForNewMessages(\nconst time = earliestTimeConsideredCurrent();\nconst visibleExtractString = `$.${threadPer... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Separate notification sends by client codeVersion
In preparation with `RawMessageInfo`s depending on client `codeVersion`, since we'll be mapping future message types to `messageType.UNSUPPORTED`. |
129,187 | 27.09.2018 17:48:26 | 14,400 | 95562a2a2dcf4fb8709bf8c53b5005a634a98125 | [server] Pass Viewer to createMessages | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -125,7 +125,7 @@ async function createAccount(\ntime: messageTime++,\ntext: message,\n}));\n- const ashoatMessageInfos = await createMessages(ashoatMessa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Pass Viewer to createMessages |
129,187 | 28.09.2018 00:32:25 | 14,400 | 6c88b5cd3dd9b38d0207c5bd7971ec41c6b407e7 | Way to handle future MessageTypes in older clients
shimUnsupportedRawMessageInfos | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -14,6 +14,7 @@ import {\nimport type { RelativeUserInfo } from '../types/user-types';\nimport type { UserInfo } from '../types/user-types';\nimport type { ThreadInfo } from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Way to handle future MessageTypes in older clients
shimUnsupportedRawMessageInfos |
129,187 | 28.09.2018 14:39:14 | 14,400 | 9293440b99df8ffc3ac626aa486bff60dafde1d6 | Every Saturday, bother monthly actives on old versions to update | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/facts/version.json",
"diff": "+{\n+ \"currentCodeVersion\": 18\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/persist.js",
"new_path": "native/persist.js",
"diff": "@@ -9,6 +9,7 @@ import { createMigrate } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Every Saturday, bother monthly actives on old versions to update |
129,187 | 28.09.2018 15:03:05 | 14,400 | 400f03727eb1eaecd347966d5de19064e60e1e17 | [server] Allow Viewer construction without cookie info | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/viewer.js",
"new_path": "server/src/session/viewer.js",
"diff": "@@ -59,15 +59,6 @@ class Viewer {\ninitialCookieName: string;\nconstructor(data: ViewerData) {\n- invariant(\n- data.cookieSource !== null && data.cookieSource !== undefined,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Allow Viewer construction without cookie info |
129,187 | 28.09.2018 15:20:03 | 14,400 | 42ee3b984f636671d1c53206cc82c329e65a5657 | [server] Fix threadID type in botherMonthlyActivesToUpdateAppVersion | [
{
"change_type": "MODIFY",
"old_path": "server/src/bots/app-version-update.js",
"new_path": "server/src/bots/app-version-update.js",
"diff": "@@ -49,11 +49,9 @@ async function botherMonthlyActivesToUpdateAppVersion(): Promise<void> {\nconst squadbotThreads = new Map();\nconst usersToSquadbotThreadPr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix threadID type in botherMonthlyActivesToUpdateAppVersion |
129,187 | 28.09.2018 18:23:14 | 14,400 | d14caf4dd6556de291bc5abc7bf9a4b96a81c734 | [server] Still include cookieChange when ServerError is thrown | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/handlers.js",
"new_path": "server/src/responders/handlers.js",
"diff": "@@ -19,8 +19,9 @@ export type HTMLResponder = (viewer: Viewer, url: string) => Promise<string>;\nfunction jsonHandler(responder: JSONResponder) {\nreturn async (req: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Still include cookieChange when ServerError is thrown |
129,187 | 28.09.2018 18:45:50 | 14,400 | d85864f6704c11016a8e88ebc46298a8ed37feff | Include error from server in SetSessionPayload | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/calendar-filters-reducer.js",
"new_path": "lib/reducers/calendar-filters-reducer.js",
"diff": "@@ -45,7 +45,7 @@ export default function reduceCalendarFilters(\naction.type === registerActionTypes.success ||\naction.type === resetPasswordActionTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include error from server in SetSessionPayload |
129,187 | 29.09.2018 16:52:44 | 14,400 | f64a2c8bc48e4802e91334dd3f80c56dd59da117 | [server] validateInput is async function and takes Viewer now | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/activity-responders.js",
"new_path": "server/src/responders/activity-responders.js",
"diff": "@@ -33,7 +33,7 @@ async function updateActivityResponder(\ninput: any,\n): Promise<UpdateActivityResult> {\nconst request: UpdateActivityRequest... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] validateInput is async function and takes Viewer now |
129,187 | 29.09.2018 19:56:49 | 14,400 | 86653b50e2c1af0326dd3576473cb20574d9bf15 | Logic to invalidate clients that are too old | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -622,7 +622,7 @@ function combineTruncationStatuses(\nfunction shimUnsupportedRawMessageInfos(\nrawMessageInfos: $ReadOnlyArray<RawMessageInfo>,\n- codeVersion: ?PlatformDetai... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Logic to invalidate clients that are too old |
129,187 | 29.09.2018 21:11:16 | 14,400 | daac3de1e4d52b24f0f58938cfa85195233c69fd | [native] codeVersion -> 19 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 18\n+ \"currentCodeVersion\": 19\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 19 |
129,187 | 03.10.2018 11:35:45 | 14,400 | 583c606d5e6e7781302228853dd814214dea2b00 | [native] Fix up KeyboardAvoidingModal | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -58,7 +58,6 @@ import {\n} from 'lib/actions/entry-actions';\nimport { connect } from 'lib/utils/redux-utils';\nimport { registerFetchKey } from 'lib/reducers/load... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up KeyboardAvoidingModal |
129,187 | 03.10.2018 17:03:09 | 14,400 | 7abc5cea10b2b5833a28a398d9089752131e3bff | [native] Specify isTransitioning when changing react-navigation state
Otherwise animations no longer work | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -46,7 +46,6 @@ import { pingActionTypes } from 'lib/actions/ping-actions';\nimport {\nleaveThreadActionTypes,\ndeleteThreadActionTypes,\n- joinThreadAction... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Specify isTransitioning when changing react-navigation state
Otherwise animations no longer work |
129,187 | 03.10.2018 20:01:32 | 14,400 | 1ee541df250b00fce4516c0039f4f1c39726a51c | [native] Use react-navigation-stack transparentCard | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -1095,6 +1095,7 @@ const styles = StyleSheet.create({\n},\ncontainer: {\nflex: 1,\n+ backgroundColor: '#E9E9EF',\n},\nflatList: {\nflex: 1,\n"
},
{
"change... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use react-navigation-stack transparentCard |
129,187 | 03.10.2018 20:06:21 | 14,400 | dcd83cd4ff2b41bc202dc94654c982bec9b5099a | [native] Refactor ThreadPicker
1. Introducing `Modal`, which uses `react-navigation` to replace `react-native-modal`
2. No longer need the hack to avoid `keyboardDismissMode="on-drag"` on Android | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -62,11 +62,13 @@ import { registerFetchKey } from 'lib/reducers/loading-reducer';\nimport { Entry, InternalEntry, entryStyles } from './entry.react';\nimport { con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Refactor ThreadPicker
1. Introducing `Modal`, which uses `react-navigation` to replace `react-native-modal`
2. No longer need the hack to avoid `keyboardDismissMode="on-drag"` on Android |
129,187 | 03.10.2018 20:11:47 | 14,400 | 97f0901b11d5952dcd1e7ce38ea7441ea8604377 | [native] Stop using iosKeyboardOffset in KeyboardAvoidingView
This hack doesn't seem to be necessary on the current version of things. | [
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -15,8 +15,6 @@ import {\nimport PropTypes from 'prop-types';\nimport _isEqual from 'lodash/fp/isEqual';\n-import { iosKeyboardOffse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Stop using iosKeyboardOffset in KeyboardAvoidingView
This hack doesn't seem to be necessary on the current version of things. |
129,187 | 03.10.2018 20:48:04 | 14,400 | 45928d7be9e28053741e30a24628d1abde21471c | [server] Fix Android back button behavior | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/thread-picker-modal.react.js",
"new_path": "native/calendar/thread-picker-modal.react.js",
"diff": "@@ -25,8 +25,9 @@ import { threadSearchIndex } from 'lib/selectors/nav-selectors';\nimport SearchIndex from 'lib/shared/search-index';\nimport {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix Android back button behavior |
129,187 | 04.10.2018 22:57:30 | 14,400 | 5c548c1f5e14ede379567e3489fc1f15798f9302 | [native] disableKeyboardHandling to avoid keyboard dismiss on navigation transition
Enables seamless transition between `ThreadPicker` and `Entry` focus. | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/react-navigation_v2.x.x.js",
"new_path": "native/flow-typed/npm/react-navigation_v2.x.x.js",
"diff": "@@ -406,6 +406,7 @@ declare module 'react-navigation' {\nonTransitionStart?: () => void,\nonTransitionEnd?: () => void,\ntransparentCard... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] disableKeyboardHandling to avoid keyboard dismiss on navigation transition
Enables seamless transition between `ThreadPicker` and `Entry` focus. |
129,187 | 04.10.2018 22:58:34 | 14,400 | c682ae878c545e16b898b4576e710e8a10258d78 | [native] Prevent CalendarInputBar showing when dismissing ThreadPicker | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar-input-bar.react.js",
"new_path": "native/calendar/calendar-input-bar.react.js",
"diff": "@@ -83,6 +83,7 @@ const styles = StyleSheet.create({\n},\ninactiveContainer: {\nheight: 0,\n+ opacity: 0,\n},\nsaveButtonText: {\ncolor: \"#036AFF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prevent CalendarInputBar showing when dismissing ThreadPicker |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.