author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 11.10.2018 11:25:55 | 14,400 | 5fb267826342c80c351104cfe4f331440ccdbad8 | [native] Update ComposeThread to use navigation.getParam
Did this in preparation for and to test it | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread.react.js",
"new_path": "native/chat/compose-thread.react.js",
"diff": "// @flow\n-import type { NavigationScreenProp, NavigationRoute } from 'react-navigation';\n+import type {\n+ NavigationScreenProp,\n+ NavigationLeafRoute,\n+} fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update ComposeThread to use navigation.getParam
Did this in preparation for https://github.com/react-navigation/react-navigation/pull/5074, and to test it |
129,187 | 11.10.2018 12:18:15 | 14,400 | b5be095983d050364eb47d07cfb1531209500eae | [native] Move AddUsersModal to use new React Navigation-based Modal | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/thread-picker-modal.react.js",
"new_path": "native/calendar/thread-picker-modal.react.js",
"diff": "@@ -29,10 +29,16 @@ import { createModal } from '../components/modal.react';\nimport ThreadList from '../components/thread-list.react';\nimport ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move AddUsersModal to use new React Navigation-based Modal |
129,187 | 11.10.2018 14:57:32 | 14,400 | bca96cc8394b60ad3589a8a6bd981d9a0032a97b | [native] Move CustomServerModal to use new React Navigation-based Modal | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/add-users-modal.react.js",
"new_path": "native/chat/settings/add-users-modal.react.js",
"diff": "@@ -100,6 +100,7 @@ class AddUsersModal extends React.PureComponent<Props, State> {\nthreadInfo: threadInfoPropType.isRequired,\n}).isRequired... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move CustomServerModal to use new React Navigation-based Modal |
129,187 | 11.10.2018 15:46:47 | 14,400 | 49aba34d24ebed94b66693c3db4830a98aeaec4e | [native] Move ColorPickerModal to use new React Navigation-based Modal | [
{
"change_type": "DELETE",
"old_path": "native/chat/color-picker-modal.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import React from 'react';\n-import PropTypes from 'prop-types';\n-import { View, TouchableHighlight, StyleSheet } from 'react-native';\n-import Modal from 'react-native-modal'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move ColorPickerModal to use new React Navigation-based Modal |
129,187 | 11.10.2018 16:05:21 | 14,400 | 4320e2667fc4ed8ed75f85e7d54b59bc3034e861 | [native] Move ComposeSubthreadModal to use new React Navigation-based Modal | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/compose-subthread-modal.react.js",
"new_path": "native/chat/settings/compose-subthread-modal.react.js",
"diff": "@@ -6,45 +6,55 @@ import {\nthreadTypes,\n} from 'lib/types/thread-types';\nimport type {\n- NavigationParams,\n- NavigationNa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move ComposeSubthreadModal to use new React Navigation-based Modal |
129,187 | 11.10.2018 16:53:02 | 14,400 | f9914a2cb26d87bf9a5297188e2094bff747a313 | [native] Fix ColorPicker crash on unmount | [
{
"change_type": "MODIFY",
"old_path": "native/components/color-picker.react.js",
"new_path": "native/components/color-picker.react.js",
"diff": "@@ -177,7 +177,9 @@ class ColorPicker extends React.PureComponent<Props, State> {\n// is double broken (#12591, #15290). Unfortunately, the only way to ge... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix ColorPicker crash on unmount |
129,187 | 12.10.2018 11:53:06 | 14,400 | 8bdec98d47657611c34899c3868a8fef114d4fde | [native] Use defaultInterpolation for all non-modal screens | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -247,7 +247,10 @@ const RootNavigator = createStackNavigator(\ndefaultConfig.screenInterpolator(sceneProps);\nconst { position, scene } = sceneProps;\ncons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use defaultInterpolation for all non-modal screens |
129,187 | 12.10.2018 12:13:09 | 14,400 | cb87d65d32dbc0753113b34a70742b1b19f4f0ce | [native] Dismiss the Keyboard on most top-level transitions | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -29,7 +29,7 @@ import {\nimport invariant from 'invariant';\nimport _findIndex from 'lodash/fp/findIndex';\nimport _includes from 'lodash/fp/includes';\n-i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Dismiss the Keyboard on most top-level transitions |
129,187 | 12.10.2018 14:00:07 | 14,400 | b6a6905d457e570db8b1ea91afda00de30bba9c3 | [server] Fix notifications
Ugh... such a dumb mistake. Why didn't Flow catch this? | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -138,7 +138,7 @@ async function sendPushNotifs(pushInfo: PushInfo) {\nconst iosVersionsToTokens = byDeviceType.get(\"ios\");\nif (iosVersionsToTokens) {\n- for (let [ codeVer, deviceT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix notifications
Ugh... such a dumb mistake. Why didn't Flow catch this? |
129,187 | 12.10.2018 14:01:22 | 14,400 | 09354cd2f0751b28a54902dbdb033b54ca1e524c | [server] session table has last_validated column, not last_verified | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/session-deleters.js",
"new_path": "server/src/deleters/session-deleters.js",
"diff": "@@ -28,7 +28,7 @@ async function deleteOldWebSessions(): Promise<void> {\nLEFT JOIN ids iup ON iup.id = up.id\nWHERE s.id != s.cookie\nAND s.last_update <... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] session table has last_validated column, not last_verified |
129,187 | 12.10.2018 14:10:02 | 14,400 | 8c544e7a3f5d46ef8d46ca2c68b2f191d2fe0a6c | [native] Make sure to only disable CalendarInputBar when threadPickerOpen changes | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -418,7 +418,11 @@ class InnerCalendar extends React.PureComponent<Props, State> {\nthis.lastEntryKeyActive = null;\n}\n- if (this.props.threadPickerOpen && !this.s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make sure to only disable CalendarInputBar when threadPickerOpen changes |
129,187 | 12.10.2018 17:02:12 | 14,400 | 214e937fdca3ffc47ec1e7df44dd4d65501a06b8 | [native] Fix Entry text height calculation issues | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -753,7 +753,7 @@ class InnerCalendar extends React.PureComponent<Props, State> {\n<TextHeightMeasurer\ntextToMeasure={this.state.textToMeasure}\nallHeightsMeasured... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Entry text height calculation issues |
129,187 | 12.10.2018 17:55:33 | 14,400 | 79e5104929703820d4fe2db1ab0fa7526ccfa750 | [native] codeVersion -> 20 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 19\n+ \"currentCodeVersion\": 20\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 20 |
129,187 | 15.10.2018 17:14:14 | 14,400 | cf6c90ed0146a3709a2f248fd81ec651be60fe7d | [server] Include stacktrace in error report
Probably won't be helpful since it'll be all symbolified, but might as well... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/report-types.js",
"new_path": "lib/types/report-types.js",
"diff": "@@ -28,6 +28,7 @@ export type ErrorInfo = { componentStack: string };\nexport type ErrorData = {| error: Error, info?: ErrorInfo |};\nexport type FlatErrorData = {|\nerrorMessage: st... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include stacktrace in error report
Probably won't be helpful since it'll be all symbolified, but might as well... |
129,187 | 15.10.2018 17:15:10 | 14,400 | ef79917933df8d3366e19e8d7906f27effc0e3cf | [server] Only avoid dismissing Keyboard in ThreadPickerModal -> App transition | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -236,7 +236,12 @@ const RootNavigator = createStackNavigator(\n) => {\nconst { scene } = transitionProps;\nconst { route } = scene;\n- if (route.routeName ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Only avoid dismissing Keyboard in ThreadPickerModal -> App transition |
129,187 | 15.10.2018 17:16:18 | 14,400 | f02307e6f3e7b1564af41eec2cacd36db6e67132 | [native] codeVersion -> 21 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 20\n+ \"currentCodeVersion\": 21\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 21 |
129,187 | 16.10.2018 13:46:33 | 14,400 | 48539ff48b92278c4e73b840a0bb2d4aab0853d0 | [native] Type fix for onTransitionStart | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-setup.js",
"new_path": "native/navigation/navigation-setup.js",
"diff": "@@ -234,6 +234,9 @@ const RootNavigator = createStackNavigator(\ntransitionProps: NavigationTransitionProps,\nprevTransitionProps: ?NavigationTransitionProps,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Type fix for onTransitionStart |
129,187 | 17.10.2018 11:04:21 | 14,400 | 4ce900481bbfd1681d568edc669b66b1ae9555f0 | [native] Fix appLoggedIn for new modal paradigm | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -93,7 +93,7 @@ import {\nimport ConnectedStatusBar from './connected-status-bar.react';\nimport {\nactiveThreadSelector,\n- createIsForegroundSelector,\n+ appLoggedInSelector,\n} from './sele... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix appLoggedIn for new modal paradigm |
129,187 | 17.10.2018 11:06:50 | 14,400 | 95fb6dc2d152428d4fcbf3b7adea965fe38e4bc4 | [native] codeVersion -> 22 | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/version.json",
"new_path": "lib/facts/version.json",
"diff": "{\n- \"currentCodeVersion\": 21\n+ \"currentCodeVersion\": 22\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 22 |
129,187 | 17.10.2018 19:30:42 | 14,400 | bd49f17d7c6eaf579d4db2a4adab300cf3c5e076 | Hash only the in-query entryInfos for state check | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/ping-selectors.js",
"new_path": "lib/selectors/ping-selectors.js",
"diff": "@@ -19,6 +19,7 @@ import { getConfig } from '../utils/config';\nimport {\nserverEntryInfo,\nserverEntryInfosObject,\n+ filterRawEntryInfosByCalendarQuery,\n} from '../sha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Hash only the in-query entryInfos for state check |
129,187 | 17.10.2018 20:12:20 | 14,400 | b2371d5e764ebc1434c1e07e7057756766b36994 | [server] Don't re-fetch cookie deviceToken | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/cookie-deleters.js",
"new_path": "server/src/deleters/cookie-deleters.js",
"diff": "import { cookieLifetime } from 'lib/types/session-types';\nimport { dbQuery, SQL, mergeOrConditions } from '../database';\n-import { fetchDeviceTokensForCoo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't re-fetch cookie deviceToken |
129,187 | 17.10.2018 22:47:28 | 14,400 | 0b1fd48f928edfb00f37b5617e23ad9d45fc195d | Simplify and improve device token lifecycle | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/account-selectors.js",
"new_path": "lib/selectors/account-selectors.js",
"diff": "@@ -20,8 +20,7 @@ const logInExtraInfoSelector = createSelector(\nlet deviceTokenUpdateRequest = null;\nconst platform = getConfig().platformDetails.platform;\nif (... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Simplify and improve device token lifecycle |
129,187 | 17.10.2018 23:20:20 | 14,400 | b1eabb18eb4afbba7d26fe62af56e33213e36865 | [native] Avoid sending notifs to logged out clients | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -189,7 +189,6 @@ class AppWithNavigationState extends React.PureComponent<Props> {\ninitialAndroidNotifHandled = false;\nopenThreadOnceReceived: Set<string> = new Set();\nupdateBadgeCountAfte... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Avoid sending notifs to logged out clients |
129,187 | 15.10.2018 14:15:34 | 14,400 | ddaea70e3a66d725545e6ab848ea9012c9151860 | [lib] Get rid of friends.json | [
{
"change_type": "DELETE",
"old_path": "lib/facts/friends.json",
"new_path": null,
"diff": "-{\n- \"larry\": \"15972\"\n-}\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/shared/user-utils.js",
"new_path": "lib/shared/user-utils.js",
"diff": "@@ -4,7 +4,6 @@ import type { Relat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of friends.json |
129,187 | 19.10.2018 15:07:29 | 14,400 | 2509497e2ed3e090f4a7ebc2f76eecc406806d78 | [server] Accept stack in reportResponder | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/report-responders.js",
"new_path": "server/src/responders/report-responders.js",
"diff": "@@ -39,6 +39,7 @@ const reportCreationRequestInputValidator = t.union([\nstateVersion: t.maybe(t.Number),\nerrors: t.list(tShape({\nerrorMessage: t.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Accept stack in reportResponder |
129,187 | 19.10.2018 15:41:03 | 14,400 | bb9c4da7e6e75cb408718721c8939dfd8956a0b8 | [native] Some fixes for inconsistencies
1. Allow `saveMessagesActionType` set an "active" thread to unread while the app is backgrounded.
2. Always call `saveMessageInfos` before `pingNow` in `native/app.react.js`. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -770,8 +770,8 @@ class AppWithNavigationState extends React.PureComponent<Props> {\n// We are here because notif was received, but hasn't been pressed yet. We\n// will preemptively dispatch a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Some fixes for inconsistencies
1. Allow `saveMessagesActionType` set an "active" thread to unread while the app is backgrounded.
2. Always call `saveMessageInfos` before `pingNow` in `native/app.react.js`. |
129,187 | 19.10.2018 16:17:09 | 14,400 | df021bf18d5f7dbff1fd1a0b0cc40eed685d52b3 | [native] Sanitize cookie password from reports | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -68,6 +68,7 @@ import { threadInFilterList } from '../shared/thread-utils';\nimport { getConfig } from '../utils/config';\nimport { reduxLogger } from '../utils/redux-logg... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Sanitize cookie password from reports |
129,187 | 20.10.2018 18:12:37 | 14,400 | 7212f5bde88ef251c8c7cdce5815fb75946da7ea | [server] Enable activityUpdater to handle focus and unfocus in the same request
If updates get queued by the client that have the user visiting and leaving a thread, we should still set the thread as read. | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -37,27 +37,34 @@ async function activityUpdater(\n}\nconst threadID = activityUpdate.threadID;\nunverifiedThreadIDs.add(threadID);\n- focusUpdatesByT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Enable activityUpdater to handle focus and unfocus in the same request
If updates get queued by the client that have the user visiting and leaving a thread, we should still set the thread as read. |
129,187 | 22.10.2018 01:10:51 | 14,400 | ca64d7ecc3d51eb709a84fbb1e360dd453159026 | [server] Fix typo in activityUpdater | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -40,7 +40,7 @@ async function activityUpdater(\nlet updatesForThreadID = focusUpdatesByThreadID.get(threadID);\nif (!updatesForThreadID) {\nupdatesFo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix typo in activityUpdater |
129,187 | 23.10.2018 10:44:10 | 14,400 | 7e1aa86948e06857d7d2d875b72ee4e6517a5d8d | Exclude SAVE_DRAFT from lastActionTypes in inconsistency reports | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -807,7 +807,7 @@ function findInconsistencies(\ncalendarQuery,\npollResult: oldResult,\npushResult: newResult,\n- lastActionTypes: reduxLogger.actions.map(action => action... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Exclude SAVE_DRAFT from lastActionTypes in inconsistency reports |
129,187 | 15.10.2018 14:20:36 | 14,400 | 8a15b2bcaffb7f8d9e21c6dfb08e957e09e99bda | [server] Move outdated client invalidation logic to handler
This allows us to customize the behavior depending on the handler, which matters because we can't change cookies from a socket context. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/errors.js",
"new_path": "lib/utils/errors.js",
"diff": "// @flow\n+import type { PlatformDetails } from '../types/device-types';\n+\nclass ExtendableError extends Error {\nconstructor(message: string) {\n@@ -18,6 +20,8 @@ class ExtendableError extend... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move outdated client invalidation logic to handler
This allows us to customize the behavior depending on the handler, which matters because we can't change cookies from a socket context. |
129,187 | 15.10.2018 14:30:30 | 14,400 | 317abb4ffec6d5d1aa6430be2757ab2788cf1996 | [server] Avoid specifying sanitizedInput as ServerError payload
`ServerError`'s `payload` gets passed down to the client, which we don't need to do for `sanitizedInput`. We just want it to go into the server log. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/errors.js",
"new_path": "lib/utils/errors.js",
"diff": "@@ -19,9 +19,13 @@ class ExtendableError extends Error {\nclass ServerError extends ExtendableError {\n+ // When specified on server side, will get passed down to client\n+ // Only used in updat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid specifying sanitizedInput as ServerError payload
`ServerError`'s `payload` gets passed down to the client, which we don't need to do for `sanitizedInput`. We just want it to go into the server log. |
129,187 | 16.10.2018 13:48:44 | 14,400 | 3decda32b00c4750167e9d11a98ddd6fa7dab233 | Server WebSocket initialization logic
Another overlarge commit. Hopefully I'll have better discipline going forward, but not like anyone's watching... | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -49,9 +49,12 @@ class Socket extends React.PureComponent<Props> {\nif (this.socket) {\nthis.socket.close();\n}\n- this.socket = this.props.openSocket();\n- this.socket.a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Server WebSocket initialization logic
Another overlarge commit. Hopefully I'll have better discipline going forward, but not like anyone's watching... |
129,187 | 16.10.2018 23:08:05 | 14,400 | 13122ed6e4be78527b25ba7d3d3e1535eb0620c1 | Get rid of threadInfos/userInfos from SessionChange | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -35,8 +35,6 @@ async function logOut(\n): Promise<LogOutResult> {\nconst response = await fetchJSON('log_out', {});\nreturn {\n- threadInfos: response.cookieChange.threadInfos... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of threadInfos/userInfos from SessionChange |
129,187 | 17.10.2018 13:28:24 | 14,400 | e993ac2b21b438a7d9eebfb0e467e5d65ab83d26 | Client WebSocket initialization logic | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -100,6 +100,8 @@ const appStartNativeCredentialsAutoLogIn =\n\"APP_START_NATIVE_CREDENTIALS_AUTO_LOG_IN\";\nconst appStartReduxLoggedInButInvalidCookie =\n\"APP_START_REDUX_LO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Client WebSocket initialization logic |
129,187 | 17.10.2018 23:43:42 | 14,400 | b258f145183d3993c026078ebdee66533315df75 | [server] Mutate Viewer to incorporate updated session/cookie data
`sessionInfo`, `deviceToken`, and `platformDetails` | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -391,7 +391,7 @@ async function processClientResponses(\n!clientSentPlatformDetails\n) {\npromises.push(setCookiePlatform(\n- viewer.cookieID,\n+ vie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Mutate Viewer to incorporate updated session/cookie data
`sessionInfo`, `deviceToken`, and `platformDetails` |
129,187 | 18.10.2018 01:34:58 | 14,400 | c5d5fb9ac9985518fc5c799fddc120cbc07f9288 | [lib] Reducer support for processServerRequestsActionType | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -11,8 +11,10 @@ import { type RawThreadInfo } from '../types/thread-types';\nimport { updateTypes, type UpdateInfo } from '../types/update-types';\nimport {\ntype EntryInc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Reducer support for processServerRequestsActionType |
129,187 | 18.10.2018 14:58:34 | 14,400 | 8f0c25ff8c066959b9d59381e7f4511bf125a258 | Replace ping reducers with socket reducers | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -18,6 +18,8 @@ import {\nserverSocketMessageTypes,\ntype ServerSocketMessage,\nstateSyncPayloadTypes,\n+ fullStateSyncActionPayload,\n+ incrementalStateSyncActionPayload... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Replace ping reducers with socket reducers |
129,187 | 18.10.2018 15:04:13 | 14,400 | 4711a9be6f840dc7fe1b4e7ba47d1dd58073e38a | Clear out some old ping stuff | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/actions/activity-actions.js",
"diff": "+// @flow\n+\n+import type { FetchJSON } from '../utils/fetch-json';\n+import type {\n+ ActivityUpdate,\n+ UpdateActivityResult,\n+} from '../types/activity-types';\n+\n+const updateActivityActionTypes ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clear out some old ping stuff |
129,187 | 19.10.2018 16:53:42 | 14,400 | e84b4ddb522a770d8079a0c5e4c1d03cf5fb60ed | [server] Sanitize cookie from input validation error logs
Using the same mechanism we used for sanitizing passwords | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -316,7 +316,7 @@ async function fetchViewerFromRequestBody(\nsessionIdentifierType: sessionParameterInfo.sessionIdentifierType,\n};\n}\n- if (!cookiePair || !(typeof cooki... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Sanitize cookie from input validation error logs
Using the same mechanism we used for sanitizing passwords |
129,187 | 19.10.2018 17:21:35 | 14,400 | 96a81e51124af7d19f90ea8f36d09d1c1b13d30a | [server] Delete all entries in focused table for session when closing socket | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -78,7 +78,7 @@ class Socket extends React.PureComponent<Props> {\nclientResponsesInTransit: SentClientResponse[] = [];\nopenSocket() {\n- if (this.socket) {\n+ if (this.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete all entries in focused table for session when closing socket |
129,187 | 20.10.2018 20:42:33 | 14,400 | 63cf65d2a6fe2d3f635428637f7a77fcd854bab9 | *StateSyncActionPayload -> *StateSyncActionType (typo fix) | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -18,8 +18,8 @@ import {\nserverSocketMessageTypes,\ntype ServerSocketMessage,\nstateSyncPayloadTypes,\n- fullStateSyncActionPayload,\n- incrementalStateSyncActionPayload... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | *StateSyncActionPayload -> *StateSyncActionType (typo fix) |
129,187 | 20.10.2018 20:49:53 | 14,400 | 34cedc0b27c585891b893c7b8c8be71b2f59e3b0 | [lib] Redux actions and reducer for connection status | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -20,6 +20,7 @@ import {\nstateSyncPayloadTypes,\nfullStateSyncActionType,\nincrementalStateSyncActionType,\n+ updateConnectionStatusActionType,\n} from '../types/socket-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Redux actions and reducer for connection status |
129,187 | 21.10.2018 15:56:35 | 14,400 | fd0f8ec680c908631d7ac8e25e87fb215adb9276 | Redux state for queuing activity updates | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/connection-reducer.js",
"new_path": "lib/reducers/connection-reducer.js",
"diff": "@@ -4,6 +4,8 @@ import type { BaseAction } from '../types/redux-types';\nimport {\ntype ConnectionInfo,\nupdateConnectionStatusActionType,\n+ queueActivityUpdateAct... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Redux state for queuing activity updates |
129,187 | 21.10.2018 21:16:46 | 14,400 | af3b7658886c1f787eff20c957f64fa52f42949b | Retry delivering client responses if it triggers an error | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -186,7 +186,7 @@ class Socket extends React.PureComponent<Props> {\nreturn;\n}\nif (message.type === serverSocketMessageTypes.STATE_SYNC) {\n- this.clearDeliveredClientR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Retry delivering client responses if it triggers an error |
129,187 | 21.10.2018 21:47:35 | 14,400 | 6efcf9769b69aa14d90cd0722be5e493e8579125 | Only retry delivery for each ClientResponse once
Otherwise we'll get an infinite loop. | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -38,7 +38,9 @@ import {\n} from '../utils/action-utils';\nimport { socketAuthErrorResolutionAttempt } from '../actions/user-actions';\n-type SentClientResponse = { clien... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only retry delivery for each ClientResponse once
Otherwise we'll get an infinite loop. |
129,187 | 22.10.2018 01:13:02 | 14,400 | 43cd1f67980816e85715e23a03bc8ff88c8cfe21 | [server] Store queuedActivityUpdates in Redux
Also introduces shared `TransitStatus` type to track inflight requests. | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -21,7 +21,12 @@ import {\nfullStateSyncActionType,\nincrementalStateSyncActionType,\nupdateConnectionStatusActionType,\n+ connectionInfoPropType,\n+ type ConnectionInfo,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Store queuedActivityUpdates in Redux
Also introduces shared `TransitStatus` type to track inflight requests. |
129,187 | 22.10.2018 13:43:46 | 14,400 | b62de8b74164a792dc80d6f0b2d94b1f53660c58 | Replace socketInitializedAndActive with Redux connection state | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -107,7 +107,6 @@ class Socket extends React.PureComponent<Props> {\nsocket: ?WebSocket;\ninitialPlatformDetailsSent = false;\nnextClientMessageID = 0;\n- socketInitializ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Replace socketInitializedAndActive with Redux connection state |
129,187 | 22.10.2018 14:09:36 | 14,400 | 31beed58dd051e321720f1c15de8c6495d97974f | Type DispatchActionPromise correctly | [
{
"change_type": "MODIFY",
"old_path": "lib/types/entry-types.js",
"new_path": "lib/types/entry-types.js",
"diff": "@@ -194,6 +194,9 @@ export type CalendarResult = {|\nuserInfos: $ReadOnlyArray<UserInfo>,\n|};\n+export type CalendarQueryUpdateStartingPayload = {|\n+ calendarQuery?: CalendarQuery,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Type DispatchActionPromise correctly |
129,187 | 22.10.2018 15:02:06 | 14,400 | 9a87282347775c16329e28ba4b6873114cc56523 | Queue ActivityUpdates when activeThread changes from within Socket component | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -78,6 +78,7 @@ type Props = {|\nactiveServerRequests?: $ReadOnlyArray<ServerRequest>,\n) => $ReadOnlyArray<ClientResponse>,\nactiveThread: ?string,\n+ activeThreadLatest... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Queue ActivityUpdates when activeThread changes from within Socket component |
129,187 | 22.10.2018 15:09:16 | 14,400 | 262f43221d33ff110bf69f8a2d9ba1524e2a2282 | [lib] Allowing queueing multiple ActivityUpdates at once | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -23,7 +23,7 @@ import {\nupdateConnectionStatusActionType,\nconnectionInfoPropType,\ntype ConnectionInfo,\n- queueActivityUpdateActionType,\n+ queueActivityUpdatesAction... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Allowing queueing multiple ActivityUpdates at once |
129,187 | 22.10.2018 15:22:01 | 14,400 | 2bdcea094f63e0dea783bbd3baba568579c8143c | [lib] Send activity updates once they are queued | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -188,14 +188,6 @@ class Socket extends React.PureComponent<Props> {\nthis.openSocket();\n}\n- if (\n- this.props.connection.status === \"connected\" &&\n- (prevProps.con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Send activity updates once they are queued |
129,187 | 22.10.2018 15:43:55 | 14,400 | 32cf8cac1372e9b79e5f4f73d7d00e26fd2ae84a | Server support for client ActivityUpdate socket message | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -24,7 +24,8 @@ import {\nconnectionInfoPropType,\ntype ConnectionInfo,\nqueueActivityUpdatesActionType,\n- clearQueuedActivityUpdatesActionType,\n+ activityUpdateSuccess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Server support for client ActivityUpdate socket message |
129,187 | 22.10.2018 15:49:12 | 14,400 | d8b7bdc93c8340f09d836ee47f099c8230e58a6e | Get rid of activity update code from App component
Socket component handles it now. | [
{
"change_type": "DELETE",
"old_path": "lib/actions/activity-actions.js",
"new_path": null,
"diff": "-// @flow\n-\n-import type { FetchJSON } from '../utils/fetch-json';\n-import type {\n- ActivityUpdate,\n- UpdateActivityResult,\n-} from '../types/activity-types';\n-\n-const updateActivityActionTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Get rid of activity update code from App component
Socket component handles it now. |
129,187 | 23.10.2018 10:14:28 | 14,400 | 5862d4de310d33c2f086dd7cea226f3090944a08 | Wait for inflight requests to resolve before closing socket | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -113,8 +113,18 @@ class Socket extends React.PureComponent<Props> {\ntransitStatuses: TransitStatus[] = [];\nopenSocket() {\n+ const { status } = this.props.connection;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Wait for inflight requests to resolve before closing socket |
129,187 | 23.10.2018 10:30:04 | 14,400 | f480e0c63a58c93d251e4d2892320a2266a98341 | Introduce forceCloseSocket | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -111,9 +111,14 @@ class Socket extends React.PureComponent<Props> {\ninitialPlatformDetailsSent = false;\nnextClientMessageID = 0;\ntransitStatuses: TransitStatus[] = []... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce forceCloseSocket |
129,187 | 23.10.2018 10:57:37 | 14,400 | 86bb4f2231215036c1166415473bc863a3ec1dff | Clean up some more old ping stuff | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -102,10 +102,6 @@ function mergeNewEntryInfos(\ncurrentEntryInfos: {[id: string]: RawEntryInfo},\nnewEntryInfos: $ReadOnlyArray<RawEntryInfo>,\nthreadInfos: {[id: string]:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clean up some more old ping stuff |
129,187 | 23.10.2018 17:13:24 | 14,400 | 411c45bd0ccdc6d15ee7f174051ad18792b1d1af | A whole bunch of fixes to buggy client socket code | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -114,25 +114,25 @@ class Socket extends React.PureComponent<Props> {\nreopenConnectionAfterClosing = false;\nopenSocket() {\n+ if (this.socket) {\nconst { status } = thi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | A whole bunch of fixes to buggy client socket code |
129,187 | 23.10.2018 19:06:34 | 14,400 | 37c807d1560975a9298caafd32bef553006d5258 | Extract foreground state and fix broken app state change logic | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -72,8 +72,8 @@ type TransitStatus =\n|};\ntype Props = {|\n- active: bool,\n// Redux state\n+ active: bool,\nopenSocket: () => WebSocket,\ngetClientResponses: (\nactiveS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract foreground state and fix broken app state change logic |
129,187 | 24.10.2018 15:34:04 | 14,400 | 181c8979b9d821424f241871be8899efe6ea0a27 | Promise-based mechanism for ActivityUpdates in Socket component | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -26,6 +26,9 @@ import {\nqueueActivityUpdatesActionType,\nactivityUpdateSuccessActionType,\nactivityUpdateFailedActionType,\n+ type ActivityUpdateResponseServerSocketMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Promise-based mechanism for ActivityUpdates in Socket component |
129,187 | 25.10.2018 12:17:54 | 14,400 | 7e5b45c9d5547203d08bc00984496aa0df77fd24 | Promise-based mechanism for ClientResponses in Socket component | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -6,6 +6,7 @@ import {\ntype ClientResponse,\nclearDeliveredClientResponsesActionType,\nprocessServerRequestsActionType,\n+ clientResponsePropType,\n} from '../types/requ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Promise-based mechanism for ClientResponses in Socket component |
129,187 | 26.10.2018 12:30:53 | 14,400 | 37efc4a040551cb752b59ea4e6688d59fe4a8253 | Move focused time code to separate file in server package | [
{
"change_type": "DELETE",
"old_path": "lib/shared/activity-utils.js",
"new_path": null,
"diff": "-// @flow\n-\n-// We can't push yet, so we rely on pings to keep Redux state updated with the\n-// server. As a result, we do them fairly frequently (once every 3s) while the\n-// app is active and the ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move focused time code to separate file in server package |
129,187 | 26.10.2018 14:41:25 | 14,400 | c51b16a60532ac3e7e100a04027a77df11f53bb6 | Application-level ping/pong to detect server/client "going away"
Protocol-level ping/pong can only be initiated by server, and can't be handled at application level on client. | [
{
"change_type": "MODIFY",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/components/socket.react.js",
"diff": "@@ -49,6 +49,7 @@ import {\n} from '../utils/action-utils';\nimport { socketAuthErrorResolutionAttempt } from '../actions/user-actions';\nimport { ServerError } from '../ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Application-level ping/pong to detect server/client "going away"
Protocol-level ping/pong can only be initiated by server, and can't be handled at application level on client. |
129,187 | 26.10.2018 14:45:52 | 14,400 | b1a7ea162b390198ea2d24936ad0e31f7fd588d4 | Move Socket to its own folder | [
{
"change_type": "RENAME",
"old_path": "lib/components/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "native/socket.react.js",
"new_path": "native/socket.react.js",
"diff": "@@ -9,7 +9,7 @@ import {\nsessionStateF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move Socket to its own folder |
129,187 | 26.10.2018 14:49:33 | 14,400 | 6342f72f57a482c1e39cb44e36edda20bcdcc731 | Move InflightRequests code to its own file | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/socket/inflight-requests.js",
"diff": "+// @flow\n+\n+import {\n+ type ServerSocketMessage,\n+ type RequestsServerSocketMessage,\n+ type ActivityUpdateResponseServerSocketMessage,\n+ type PongServerSocketMessage,\n+ serverSocketMessageTypes,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move InflightRequests code to its own file |
129,187 | 26.10.2018 19:17:56 | 14,400 | 4919525ca23cb10060c6ca8edfd24f033d47334d | Extract InflightRequests functionality into class and handle timeouts | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -5,29 +5,109 @@ import {\ntype RequestsServerSocketMessage,\ntype ActivityUpdateResponseServerSocketMessage,\ntype PongServerSocketMessage,\n+ type ServerSocketMessage... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract InflightRequests functionality into class and handle timeouts |
129,187 | 27.10.2018 12:40:50 | 14,400 | 81ca8b56192fb27931862847bdb2a4e2d822c92f | Trigger reject of all inflight requests on any request timeout | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -49,6 +49,11 @@ async function timeout(expectedType: ServerSocketMessageType) {\nclass InflightRequests {\ndata: InflightRequest[] = [];\n+ timeoutCallback: () => void... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Trigger reject of all inflight requests on any request timeout |
129,187 | 29.10.2018 11:17:57 | 14,400 | a09d423972f8b5aae830a26e24183855427d39b2 | [server] Move socket code to new Socket class | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket.js",
"new_path": "server/src/socket.js",
"diff": "@@ -119,33 +119,47 @@ const clientSocketMessageInputValidator = t.union([\n}),\n]);\n-type SendMessageFunc = (message: ServerSocketMessage) => void;\n-\nfunction onConnection(ws: WebSocket, re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move socket code to new Socket class |
129,187 | 29.10.2018 11:35:09 | 14,400 | 04f350e1a5cff2c311d44aeadbabb7d425244204 | [server] Rename activity deleters | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -12,7 +12,7 @@ import { deleteOrphanedEntries } from './deleters/entry-deleters';\nimport { deleteOrphanedRevisions } from './deleters/revision-deleters';\nimport { deleteOrphanedRoles } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rename activity deleters |
129,187 | 29.10.2018 11:37:22 | 14,400 | c6aecc3861b82ddfaf9bf5fb423043a7456ae0bf | [server] Keep updating activity time while socket is active | [
{
"change_type": "MODIFY",
"old_path": "server/src/shared/focused-times.js",
"new_path": "server/src/shared/focused-times.js",
"diff": "@@ -20,6 +20,7 @@ function earliestFocusedTimeConsideredExpired() {\n}\nexport {\n+ focusedTableRefreshFrequency,\nearliestFocusedTimeConsideredCurrent,\nearliestFo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Keep updating activity time while socket is active |
129,187 | 29.10.2018 13:03:38 | 14,400 | ec56da5b3306c4c3afc2b579459f3d08de89aa18 | [server] Have server close inactive sockets | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket.js",
"new_path": "server/src/socket.js",
"diff": "@@ -28,6 +28,7 @@ import { mostRecentMessageTimestamp } from 'lib/shared/message-utils';\nimport { mostRecentUpdateTimestamp } from 'lib/shared/update-utils';\nimport { promiseAll } from 'lib/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Have server close inactive sockets |
129,187 | 29.10.2018 15:20:47 | 14,400 | 8a9e51b1b0597a741087f07d0cc2e519f90bc97e | [lib] Reconnect every 2 seconds while disconnected and active | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -41,6 +41,7 @@ import type { LogInExtraInfo } from '../types/account-types';\nimport * as React from 'react';\nimport PropTypes from 'prop-types';\nimport invariant from 'invari... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Reconnect every 2 seconds while disconnected and active |
129,187 | 29.10.2018 16:49:42 | 14,400 | ebbc2e199b9b24bb561162b38449d9cf3240df01 | [server] Set socket to null in finishClosingSocket
This means `onClose` won't get called for it, but is necessary for the `this.reopenConnectionAfterClosing` logic to work correctly. We'll just do everything we would do in `onClose` in `finishClosingSocket` as well.
Also, moved the socket code to handle `ServerRequest`... | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -201,9 +201,11 @@ class Socket extends React.PureComponent<Props> {\nupdateConnectionStatusActionType,\n{ status: \"disconnected\" },\n);\n+ registerActiveWebSocket(null);\nif (... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set socket to null in finishClosingSocket
This means `onClose` won't get called for it, but is necessary for the `this.reopenConnectionAfterClosing` logic to work correctly. We'll just do everything we would do in `onClose` in `finishClosingSocket` as well.
Also, moved the socket code to handle `ServerReques... |
129,187 | 31.10.2018 18:21:55 | 14,400 | 161548ce6417e0ea923a6228b1f3644c8834b883 | [lib] Narrow situations where we retry socket requests in | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -165,5 +165,6 @@ class InflightRequests {\n}\nexport {\n+ SocketTimeout,\nInflightRequests,\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/socket/so... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Narrow situations where we retry socket requests in |
129,187 | 31.10.2018 18:50:10 | 14,400 | 5c91b983f016b1c60096fcdf8afae208cadb114f | [lib] Use promises and async functions for socket initialization code | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "import {\ntype ServerSocketMessage,\n+ type StateSyncServerSocketMessage,\ntype RequestsServerSocketMessage,\ntype ActivityUpdateResponseServerSocketMessage,\ntype PongSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use promises and async functions for socket initialization code |
129,187 | 31.10.2018 19:06:06 | 14,400 | 694bec9d5c46af4b668c2a38124626b7b154de2e | [lib] Move inflightRequests to Socket component's state
So we can automatically update children when it changes. | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -75,7 +75,10 @@ type Props = {|\ndispatch: Dispatch,\ndispatchActionPayload: DispatchActionPayload,\n|};\n-class Socket extends React.PureComponent<Props> {\n+type State = {|\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move inflightRequests to Socket component's state
So we can automatically update children when it changes. |
129,187 | 01.11.2018 00:30:05 | 14,400 | e62a227263e449091132c5886d4c456da04ce0e2 | Extract ActivityUpdates logic from Socket into ActivityMaintainer | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/socket/activity-maintainer.react.js",
"diff": "+// @flow\n+\n+import {\n+ type ActivityUpdateResponseServerSocketMessage,\n+ clientSocketMessageTypes,\n+ serverSocketMessageTypes,\n+ queueActivityUpdatesActionType,\n+ activityUpdateSuccessAc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract ActivityUpdates logic from Socket into ActivityMaintainer |
129,187 | 01.11.2018 17:57:18 | 14,400 | 84c865b54ca05cfbdbe772b826937a93c4c23cb3 | Extract ClientResponses logic from Socket into ClientResponseMaintainer | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/socket/client-response-maintainer.react.js",
"diff": "+// @flow\n+\n+import {\n+ type RequestsServerSocketMessage,\n+ type ServerSocketMessage,\n+ clientSocketMessageTypes,\n+ serverSocketMessageTypes,\n+ type ClientSocketMessageWithoutID,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Extract ClientResponses logic from Socket into ClientResponseMaintainer |
129,187 | 02.11.2018 17:17:27 | 14,400 | 36c1cd63df514bdd4c9f989690064ab4bc5483dd | Prevent user from being logged in while their currentUserInfo indicates otherwise
This makes sure the nav state is consistent with the `currentUserInfo` state.
Also includes a Socket bugfix to prevent the web from crashing on `AUTH_ERROR`. | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -180,6 +180,10 @@ async function fetchNewCookieFromNativeCredentials(\nsource: LogInActionSource,\nlogInExtraInfo: () => LogInExtraInfo,\n): Promise<?ClientSessionChange> {\n+ con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prevent user from being logged in while their currentUserInfo indicates otherwise
This makes sure the nav state is consistent with the `currentUserInfo` state.
Also includes a Socket bugfix to prevent the web from crashing on `AUTH_ERROR`. |
129,187 | 02.11.2018 17:42:26 | 14,400 | 7d6fe998573d0a8e409dfe6cbe34eaa3bfab9ea6 | Hit logOut in Socket when a new anonymous cookie is needed | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -31,8 +31,11 @@ import {\ntype SocketListener,\n} from '../types/socket-types';\nimport type { Dispatch } from '../types/redux-types';\n-import type { DispatchActionPayload } fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Hit logOut in Socket when a new anonymous cookie is needed |
129,187 | 02.11.2018 23:25:53 | 14,400 | 33d0f0a73089e7c01a0a34d0fa06ce2d31dde360 | Use "reconnecting" ConnectionStatus in reconnect
This will trigger a red bar to inform the user of the connection issue. | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -29,6 +29,7 @@ import {\ntype PingClientSocketMessage,\ntype ClientSocketMessageWithoutID,\ntype SocketListener,\n+ type ConnectionStatus,\n} from '../types/socket-types';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use "reconnecting" ConnectionStatus in reconnect
This will trigger a red bar to inform the user of the connection issue. |
129,187 | 03.11.2018 13:58:15 | 14,400 | e9baa498b4db8aeb5d0c4621dbc989ff49bced35 | [server] Move socket to its own folder | [
{
"change_type": "MODIFY",
"old_path": "server/src/server.js",
"new_path": "server/src/server.js",
"diff": "@@ -61,7 +61,7 @@ import {\nerrorReportFetchInfosResponder,\nerrorReportDownloadHandler,\n} from './responders/report-responders';\n-import { onConnection } from './socket';\n+import { onConne... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move socket to its own folder |
129,187 | 03.11.2018 16:58:18 | 14,400 | 1a4b410cc82a2a1aacd31bed0022db75d9b7d64d | Use Redis to keep one socket open for session | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -299,7 +299,7 @@ class Socket extends React.PureComponent<Props, State> {\nsocket.send(JSON.stringify(message));\n}\n- messageFromEvent(event: MessageEvent): ?ServerSocketMessag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use Redis to keep one socket open for session |
129,187 | 03.11.2018 17:26:51 | 14,400 | 1640901efba0b67fa3e90567912f6921af439824 | [server] Include isSocket on Viewer | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/bots.js",
"new_path": "server/src/session/bots.js",
"diff": "@@ -20,6 +20,7 @@ function createBotViewer(userID: string): Viewer {\nthrow new ServerError('invalid_bot_id');\n}\nreturn new Viewer({\n+ isSocket: true,\nloggedIn: true,\nid: user... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include isSocket on Viewer |
129,187 | 03.11.2018 18:05:55 | 14,400 | 37ed1025509efc636092b921d1afe48d424bf170 | Introducing RawUpdateInfo | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/update-utils.js",
"new_path": "lib/shared/update-utils.js",
"diff": "import {\ntype UpdateInfo,\ntype UpdateData,\n+ type RawUpdateInfo,\nupdateTypes,\n} from '../types/update-types';\n@@ -74,10 +75,76 @@ function conditionKeyForUpdateDataFromKey(\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introducing RawUpdateInfo |
129,187 | 03.11.2018 18:25:30 | 14,400 | f88f0a0a418b9a7ff9dea7321b2f00281fa53c02 | [server] Publish new RawUpdateInfos to Redis | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -19,6 +19,7 @@ import type {\nFetchEntryInfosResponse,\nCalendarQuery,\n} from 'lib/types/entry-types';\n+import { type UpdateTarget, redisMessageTypes } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Publish new RawUpdateInfos to Redis |
129,187 | 03.11.2018 18:50:55 | 14,400 | ed4a284fae5442dea7d6f23621501b4992c323d0 | Send socket message when Redis sends new RawUpdateInfos | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -125,7 +125,10 @@ class InflightRequests {\nresolveRequestsForMessage(message: ServerSocketMessage) {\nfor (let inflightRequest of this.data) {\n- if (inflightRequest.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Send socket message when Redis sends new RawUpdateInfos |
129,187 | 04.11.2018 12:24:27 | 18,000 | 16446752076d4decfd6fc21bf9bb1f90b6f0fad0 | [server] Refactor createMessages code to reduce SQL queries
Code to update unread status and generate push notifs now shares a SQL query, which upcoming Redis updates will also share. | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -32,11 +32,6 @@ import { createUpdates } from './update-creator';\nimport { handleAsyncPromise } from '../responders/handlers';\nimport { earliestFocused... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Refactor createMessages code to reduce SQL queries
Code to update unread status and generate push notifs now shares a SQL query, which upcoming Redis updates will also share. |
129,187 | 04.11.2018 13:22:26 | 18,000 | c8f4553152c5d2a4700e63dbf186945869d96a60 | [server] Publish new RawMessageInfos to Redis | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redis-types.js",
"new_path": "lib/types/redis-types.js",
"diff": "// @flow\nimport type { RawUpdateInfo } from './update-types';\n+import type { RawMessageInfo } from './message-types';\n// The types of messages that can be published to Redis\nexport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Publish new RawMessageInfos to Redis |
129,187 | 04.11.2018 15:07:59 | 18,000 | c68536bfdb1a43bc9f7955d6a963fb7e547b107c | [server] Check VISIBLE permission for any activity updates | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/promises.js",
"new_path": "lib/utils/promises.js",
"diff": "@@ -22,6 +22,15 @@ async function promiseAll<T: {[key: string]: Promisable<*>}>(\nreturn byName;\n}\n+async function promiseFilter<T>(\n+ input: $ReadOnlyArray<T>,\n+ filterFunc: (value: T) ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Check VISIBLE permission for any activity updates |
129,187 | 04.11.2018 16:28:29 | 18,000 | b2f90421f5633b5d90e980bc07b5768843aaffb9 | Send socket message when Redis sends new RawMessageInfos | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -514,7 +514,7 @@ export const messageTruncationStatus = Object.freeze({\n// result set for a given thread is contiguous with what the client has in its\n// state. If the client ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Send socket message when Redis sends new RawMessageInfos |
129,187 | 04.11.2018 16:43:34 | 18,000 | b845df85c066b7a5f3bfb68a0392b602c5a9bf33 | Rename "Maintainers" to "Handlers" | [
{
"change_type": "RENAME",
"old_path": "lib/socket/activity-maintainer.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -33,7 +33,7 @@ type Props = {|\n// Redux dispatch functions\ndispatchActionPayload: DispatchActionPayload,\n|};\n-class ActivityMaintainer extends React.P... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename "Maintainers" to "Handlers" |
129,187 | 04.11.2018 17:35:31 | 18,000 | e5e0b93366952f28656a5e6b98151347f28fb855 | [lib] Handle serverSocketMessageTypes.UPDATES | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/calendar-filters-reducer.js",
"new_path": "lib/reducers/calendar-filters-reducer.js",
"diff": "@@ -10,7 +10,11 @@ import {\n} from '../types/filter-types';\nimport type { BaseAction } from '../types/redux-types';\nimport type { RawThreadInfo } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Handle serverSocketMessageTypes.UPDATES |
129,187 | 04.11.2018 18:00:11 | 18,000 | 400c5c0bbb900a3563c0b97fd755bc8ff188cb71 | [lib] Handle serverSocketMessageTypes.MESSAGES | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -9,6 +9,7 @@ import {\nmessageTruncationStatus,\nmessageTypes,\ndefaultNumberPerThread,\n+ processMessagesActionType,\n} from '../types/message-types';\nimport type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Handle serverSocketMessageTypes.MESSAGES |
129,187 | 04.11.2018 22:25:07 | 18,000 | 8090e91d44fa25312dc8d7be81210003867994d6 | Fix bug preventing response to first message
And also don't send any requests response if only activity update request.
Also fix bug causing Redis subscriptions to immediately unsubscribe. | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/inflight-requests.js",
"new_path": "lib/socket/inflight-requests.js",
"diff": "@@ -126,7 +126,8 @@ class InflightRequests {\nresolveRequestsForMessage(message: ServerSocketMessage) {\nfor (let inflightRequest of this.data) {\nif (\n- !message.respon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix bug preventing response to first message
And also don't send any requests response if only activity update request.
Also fix bug causing Redis subscriptions to immediately unsubscribe. |
129,187 | 05.11.2018 10:07:38 | 18,000 | c993a9fcf3a816077895aeedfedc97df879dfd08 | [native] Use background color from React Navigation 2
React Navigation 3 changed it to white, and `cardStyle` doesn't seem to be able to override it anymore.
(https://github.com/react-navigation/react-navigation-stack/issues/53) | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -294,6 +294,7 @@ const styles = StyleSheet.create({\n},\ncontainer: {\nflex: 1,\n+ backgroundColor: \"#E9E9EF\",\n},\nsearchContainer: {\nbackgroundColor: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use background color from React Navigation 2
React Navigation 3 changed it to white, and `cardStyle` doesn't seem to be able to override it anymore.
(https://github.com/react-navigation/react-navigation-stack/issues/53) |
129,187 | 05.11.2018 10:10:46 | 18,000 | 918be67c3b852f22ac40046c14cb4d0d6fa4859b | [native] Don't log the user out during REHYDRATE
This allows `navInfo` to get rehydrated on dev again. | [
{
"change_type": "MODIFY",
"old_path": "native/redux-setup.js",
"new_path": "native/redux-setup.js",
"diff": "@@ -30,7 +30,7 @@ import invariant from 'invariant';\nimport thunk from 'redux-thunk';\nimport { createStore as defaultCreateStore, applyMiddleware } from 'redux';\nimport { composeWithDevTo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't log the user out during REHYDRATE
This allows `navInfo` to get rehydrated on dev again. |
129,187 | 05.11.2018 18:32:30 | 18,000 | 569ab429ccf82391c421541cbe2ec1d564f8b041 | [lib] Use leading & trailing debounce for Socket reconnect | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -42,7 +42,7 @@ import type { LogInExtraInfo, LogOutResult } from '../types/account-types';\nimport * as React from 'react';\nimport PropTypes from 'prop-types';\nimport invarian... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use leading & trailing debounce for Socket reconnect |
129,187 | 05.11.2018 18:38:54 | 18,000 | 7ca25be4a9e759f8de3f5b0b047277c8aea14f91 | [server] Use debounce for server socket timeout | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -24,6 +24,7 @@ import { redisMessageTypes, type RedisMessage } from 'lib/types/redis-types';\nimport t from 'tcomb';\nimport invariant from 'invariant';\n+import _debounce fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use debounce for server socket timeout |
129,187 | 05.11.2018 20:43:50 | 18,000 | 81b4a636da611ee0529bbc21c294da40fb049d41 | Logic for server socket to initiate state check mechanism
State check occurs once every `sessionCheckFrequency`ms, but any activity debounces state check by `stateCheckInactivityActivationInterval`ms. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/session-types.js",
"new_path": "lib/types/session-types.js",
"diff": "@@ -12,7 +12,9 @@ import PropTypes from 'prop-types';\nexport const cookieLifetime = 30*24*60*60*1000; // in milliseconds\n//export const sessionCheckFrequency = 3*60*60*1000; // i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Logic for server socket to initiate state check mechanism
State check occurs once every `sessionCheckFrequency`ms, but any activity debounces state check by `stateCheckInactivityActivationInterval`ms. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.