author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,191 | 15.10.2020 13:40:39 | -7,200 | 414e9b7523235a4c35b1dc10a4e9e0b64e9019c8 | [server] Do not update unread column in activity updater
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -146,17 +146,11 @@ async function activityUpdater(\nviewer,\nupdatesForCurrentSession: 'ignore',\n});\n- const setUnreadStatusPromise = updateUnreadS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Do not update unread column in activity updater
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D240 |
129,187 | 19.10.2020 13:42:49 | 14,400 | 7b15c602aa73511a03b88a77bbdfab50b2b59cab | [native] Don't list sidebars under subthreads in ThreadSettings
Summary: I'll display them in a separate category in the next diff.
Test Plan: I checked a thread that has sidebars and made sure the sidebars were no longer listed
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -6,6 +6,7 @@ import {\ntype RelativeMemberInfo,\nrelativeMemberInfoPropType,\nthreadPermissions,\n+ threadTypes,\n} from 'lib/types/thread-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't list sidebars under subthreads in ThreadSettings
Summary: I'll display them in a separate category in the next diff.
Test Plan: I checked a thread that has sidebars and made sure the sidebars were no longer listed
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Dif... |
129,187 | 19.10.2020 13:52:09 | 14,400 | 0d7af7e95bc6c02e3b291714b6b18ad142a50008 | [native] Display list of sidebars in ThreadSettings
Summary: Displaying them in a separate list
Test Plan: I checked a thread with sidebars and made sure they were listed
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -210,6 +210,7 @@ type Props = {|\ntype State = {|\n+showMaxMembers: number,\n+showMaxSubthreads: number,\n+ +showMaxSidebars: number,\n+nam... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display list of sidebars in ThreadSettings
Summary: Displaying them in a separate list
Test Plan: I checked a thread with sidebars and made sure they were listed
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D260 |
129,187 | 19.10.2020 15:10:59 | 14,400 | d69df31d283d9ef0e11b7b9139892ccdcbfbffa4 | [native] Memoize getMarkdownStyles
Summary: This makes it so it only ever gets computed twice (for `light` and `dark`) instead of getting recomputed for every time it's used.
Test Plan: Flow, make sure it loads. This is a pretty minimal change
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/styles.js",
"new_path": "native/markdown/styles.js",
"diff": "import type { GlobalTheme } from '../types/themes';\nimport { Platform } from 'react-native';\n+import _memoize from 'lodash/memoize';\nimport { getStylesForTheme } from '../themes/c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Memoize getMarkdownStyles
Summary: This makes it so it only ever gets computed twice (for `light` and `dark`) instead of getting recomputed for every time it's used.
Test Plan: Flow, make sure it loads. This is a pretty minimal change
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: ... |
129,187 | 19.10.2020 15:18:52 | 14,400 | 5c5853f4b747dcf0fe456d5f4e344eecf4abf966 | [client] Memoize MarkdownRules
Summary: This makes it so it only ever gets computed twice (for `light` and `dark`) instead of getting recomputed for every time it's used.
Test Plan: Another minor change, once again just Flow and reloading...
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/rules.react.js",
"new_path": "native/markdown/rules.react.js",
"diff": "import * as React from 'react';\nimport { Text, Linking, Alert, View } from 'react-native';\nimport * as SimpleMarkdown from 'simple-markdown';\n+import _memoize from 'loda... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [client] Memoize MarkdownRules
Summary: This makes it so it only ever gets computed twice (for `light` and `dark`) instead of getting recomputed for every time it's used.
Test Plan: Another minor change, once again just Flow and reloading...
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zr... |
129,187 | 19.10.2020 15:51:02 | 14,400 | 227450012a27303aa3dd587ba01668ab4385a702 | [native] Convert InnerTextMessage to hook
Test Plan: Flow, reloading...
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inner-text-message.react.js",
"new_path": "native/chat/inner-text-message.react.js",
"diff": "// @flow\n-import { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport type { ChatTextMessageInfoItemWithHeight } from './text-message... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert InnerTextMessage to hook
Test Plan: Flow, reloading...
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D266 |
129,187 | 19.10.2020 15:54:01 | 14,400 | 77562ba5d529385246e442e20ee3ce54d92dafa8 | [web] Convert TextMessage to hook
Test Plan: Flow, reloading...
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/text-message.react.js",
"new_path": "web/chat/text-message.react.js",
"diff": "// @flow\n-import {\n- type ChatMessageInfoItem,\n- chatMessageItemPropType,\n-} from 'lib/selectors/chat-selectors';\n+import type { ChatMessageInfoItem } from 'lib/select... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Convert TextMessage to hook
Test Plan: Flow, reloading...
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D267 |
129,187 | 19.10.2020 16:14:56 | 14,400 | 1e9cdb90a6d785f0629e8cbb6692dc979f5169a6 | [client] Only bold if they match usernames of thread members
Summary: This is the final goal of all that Markdown work.
Test Plan: Test that match usernames and ones that don't
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "// @flow\n+import type { RelativeMemberInfo } from '../types/thread-types';\n+\n+import invariant from 'invariant';\n+\nimport { oldValidUsernameRegexString } from './account-utils';\n// s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [client] Only bold @mentions if they match usernames of thread members
Summary: This is the final goal of all that Markdown work.
Test Plan: Test @mentions that match usernames and ones that don't
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https... |
129,187 | 19.10.2020 16:33:13 | 14,400 | 04c6b02ffc47ec81a7f1acdab60988265a1296a9 | [native] Convert ThreadSettingsDeleteThread to hook
Test Plan: This is just a refactor. I used Flow, and reloaded to make sure it worked
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-delete-thread.react.js",
"new_path": "native/chat/settings/thread-settings-delete-thread.react.js",
"diff": "// @flow\n-import { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n+import type { ThreadInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert ThreadSettingsDeleteThread to hook
Test Plan: This is just a refactor. I used Flow, and reloaded to make sure it worked
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D269 |
129,187 | 19.10.2020 16:40:50 | 14,400 | 04c26827cdad3b708d60b2cd31d5d74c67289426 | [native] Use hook for data-binding in ThreadSettingsLeaveThread
Test Plan: This is just a refactor. I used Flow, and reloaded to make sure it worked
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-leave-thread.react.js",
"new_path": "native/chat/settings/thread-settings-leave-thread.react.js",
"diff": "@@ -5,17 +5,17 @@ import {\nthreadInfoPropType,\ntype LeaveThreadPayload,\n} from 'lib/types/thread-types';\n-import... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in ThreadSettingsLeaveThread
Test Plan: This is just a refactor. I used Flow, and reloaded to make sure it worked
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D270 |
129,187 | 19.10.2020 19:16:42 | 14,400 | 7701631b269ef14b1bb70dec7642f612702d7750 | [native] Add a button to promote sidebars to subthreads
Summary: This button lets you take a sidebar that grew out of an initial conversation and turn it into a full-fledged subthread
Test Plan: Test the button and make sure it works!
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-leave-thread.react.js",
"new_path": "native/chat/settings/thread-settings-leave-thread.react.js",
"diff": "@@ -45,6 +45,7 @@ import { clearThreadsActionType } from '../../navigation/action-types';\ntype BaseProps = {|\n+thr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add a button to promote sidebars to subthreads
Summary: This button lets you take a sidebar that grew out of an initial conversation and turn it into a full-fledged subthread
Test Plan: Test the button and make sure it works!
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adria... |
129,187 | 19.10.2020 19:18:14 | 14,400 | c21949a65da7163327a92345700bd057d7febe65 | [native] Make ChatSettingsItem type $ReadOnly
Summary: Minor just, I just put this in a separate diff to make earlier ones easier to read
Test Plan: Flow, make sure it loads
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -91,112 +91,112 @@ export type ThreadSettingsNavigate = $PropertyType<\ntype ChatSettingsItem =\n| {|\n- itemType: 'header',\n- key: string... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make ChatSettingsItem type $ReadOnly
Summary: Minor just, I just put this in a separate diff to make earlier ones easier to read
Test Plan: Flow, make sure it loads
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D275 |
129,187 | 20.10.2020 19:07:39 | 14,400 | cee435743ad58003ac874bf4ff8e6db81c88365d | [native] showMaxSubthreads -> numSubthreadsShowing
Summary: [pointed out](https://phabricator.ashoat.com/D260#inline-1161) that the earlier name was confusing because it sounded like an action. I've updated it to be more clear.
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian, palys-swm | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -217,8 +217,8 @@ type Props = {|\n|};\ntype State = {|\n+showMaxMembers: number,\n- +showMaxSubthreads: number,\n- +showMaxSidebars: number... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] showMaxSubthreads -> numSubthreadsShowing
Summary: @palys-swm [pointed out](https://phabricator.ashoat.com/D260#inline-1161) that the earlier name was confusing because it sounded like an action. I've updated it to be more clear.
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: Kat... |
129,187 | 21.10.2020 17:01:06 | 14,400 | 70063e4d7c03a46d6d5b1832160857d875d41352 | Make case-insensistive
Summary: `lib` code affects bolding in `Markdown` components, `server` code affects delivery of push notifs
Test Plan: I tested the RegEx in a JavaScript CLI
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "@@ -151,7 +151,7 @@ function parseList(\nfunction matchMentions(members: $ReadOnlyArray<RelativeMemberInfo>) {\nconst memberSet = new Set(\n- members.map(({ username }) => username).filter... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make @mentions case-insensistive
Summary: `lib` code affects bolding in `Markdown` components, `server` code affects delivery of push notifs
Test Plan: I tested the RegEx in a JavaScript CLI
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: http... |
129,187 | 21.10.2020 19:05:11 | 14,400 | 5a52f78319e9c77b1931fb3ac78c17227e2d686b | [native] Programmatically determine firstActionButton/lastActionButton in ThreadSettings
Summary: This way is more futureproof for when we need to add another one of these buttons
Test Plan: Flow, make sure `ThreadSettings` still loads
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -152,13 +152,7 @@ type ChatSettingsItem =\n+key: string,\n+onPress: () => void,\n|}\n- | {|\n- +itemType: 'childThread',\n- +key: string,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Programmatically determine firstActionButton/lastActionButton in ThreadSettings
Summary: This way is more futureproof for when we need to add another one of these buttons
Test Plan: Flow, make sure `ThreadSettings` still loads
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, z... |
129,187 | 21.10.2020 19:18:08 | 14,400 | ac1149dd8ab79facd13d9cf9e516f9f4950eb54e | [native] Determine buttonsStyle in ThreadSettings
Summary: This centralizes the logic instead of having it be separate in the different button components. Follow-up to feedback in D271.
Test Plan: Flow, make sure `ThreadSettings` still loads
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-delete-thread.react.js",
"new_path": "native/chat/settings/thread-settings-delete-thread.react.js",
"diff": "import type { ThreadInfo } from 'lib/types/thread-types';\nimport type { ThreadSettingsNavigate } from './thread-s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Determine buttonsStyle in ThreadSettings
Summary: This centralizes the logic instead of having it be separate in the different button components. Follow-up to feedback in D271.
Test Plan: Flow, make sure `ThreadSettings` still loads
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411... |
129,187 | 21.10.2020 23:56:05 | 14,400 | 78011383f4629169bc1de597c35e5f329b8c6547 | [native] Convert ThreadSettingsChildThread to hook
Test Plan: Flow, make sure `ThreadSettings` still loads
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-child-thread.react.js",
"new_path": "native/chat/settings/thread-settings-child-thread.react.js",
"diff": "// @flow\n-import { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n+import type { ThreadInfo ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert ThreadSettingsChildThread to hook
Test Plan: Flow, make sure `ThreadSettings` still loads
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D287 |
129,187 | 22.10.2020 00:14:01 | 14,400 | 076f493c92a7f2ac3ab005992510be798a02aeac | [native] Simplify ChatSettingsItem type
Summary: After the work in D286 and D288, we no longer have to explicitly type `listData` items as we're constructing them, so we can now type `ChatSettingsItem` in one statement again.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -153,28 +153,19 @@ type ChatSettingsItem =\n+key: string,\n+onPress: () => void,\n|}\n- | ChatSettingsChildThreadItem\n| {|\n- +itemType: '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Simplify ChatSettingsItem type
Summary: After the work in D286 and D288, we no longer have to explicitly type `listData` items as we're constructing them, so we can now type `ChatSettingsItem` in one statement again.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: Ka... |
129,187 | 22.10.2020 00:27:33 | 14,400 | 6248a1303749e81baf868ccc8ff2d5d632d35e51 | [native] Don't update verticalBounds while keyboard is showing
Summary: Fixes this bug:
Test Plan: Made sure the bug doesn't occur anymore
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "@@ -296,6 +296,12 @@ class MessageList extends React.PureComponent<Props, State> {\nif (!flatListContainer) {\nreturn;\n}\n+\n+ const { keyboardState } = this.props;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't update verticalBounds while keyboard is showing
Summary: Fixes this bug: https://www.dropbox.com/s/mcfsn9gjjpl7l2n/2020-10-22%2000.25.39.mp4?dl=0
Test Plan: Made sure the bug doesn't occur anymore
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differ... |
129,187 | 23.10.2020 17:30:55 | 14,400 | fc71cc43ed1a0f98e54525181e48a28ba0abd687 | [native] Convert InlineMultimedia to hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inline-multimedia.react.js",
"new_path": "native/chat/inline-multimedia.react.js",
"diff": "// @flow\n-import { type MediaInfo, mediaInfoPropType } from 'lib/types/media-types';\n-import {\n- type PendingMultimediaUpload,\n- pendingMultimediaUpload... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert InlineMultimedia to hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D298 |
129,187 | 25.10.2020 18:26:26 | 14,400 | baed4619869682312ff5434b17cbcebca6821d9d | [native] Use hook for data-binding in LogInPanel
Test Plan: Flow, make sure it loads
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "// @flow\n-import type { DispatchActionPromise } from 'lib/utils/action-utils';\n-import type { AppState } from '../redux/redux-setup';\nimport type { LoadingSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in LogInPanel
Test Plan: Flow, make sure it loads
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D305 |
129,187 | 25.10.2020 18:41:54 | 14,400 | a479ac5d758cc397030e7f5ff3f457d94c4cb3e4 | [native] Use hook for data-binding in LoggedOutModal
Test Plan: Flow, make sure it loads
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "// @flow\n-import type { DispatchActionPayload } from 'lib/utils/action-utils';\nimport type { Dispatch } from 'lib/types/redux-types';\n-import type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in LoggedOutModal
Test Plan: Flow, make sure it loads
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D306 |
129,187 | 25.10.2020 18:45:27 | 14,400 | f120d2a19d44d56d05d1d2733109757d8bda7544 | [native] Use hook for data-binding in ResetPasswordPanel
Test Plan: Flow, make sure it loads
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/reset-password-panel.react.js",
"new_path": "native/account/reset-password-panel.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport type { LoadingStatus } from 'lib/types/loading-types';\n-import type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in ResetPasswordPanel
Test Plan: Flow, make sure it loads
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D307 |
129,187 | 26.10.2020 13:41:14 | 14,400 | cb3280bc7f9301b9db83e58145759ce7805d172d | [native] codeVersion -> 69 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 69 |
129,187 | 26.10.2020 20:01:31 | 14,400 | 150de37c48f7957b244a766a20bb2f6aea65749a | RN0.63 1/16: remove patch for RN0.62
Summary:
These two patches are in the 0.63 release:
1.
2.
Test Plan: I made sure the two patches are there
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "DELETE",
"old_path": "patches/react-native+0.62.2.patch",
"new_path": null,
"diff": "-diff --git a/node_modules/react-native/Libraries/Image/AssetSourceResolver.js b/node_modules/react-native/Libraries/Image/AssetSourceResolver.js\n-index 624c622..bc67109 100644\n---- a/node_module... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 1/16: remove patch for RN0.62
Summary:
These two patches are in the 0.63 release:
1. https://github.com/facebook/react-native/commit/7deeec7
2. https://github.com/facebook/react-native/commit/b6ded72
Test Plan: I made sure the two patches are there
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
... |
129,187 | 26.10.2020 20:06:56 | 14,400 | bb0abbee84a8261fe62ce014fd3b79c13e1f1afd | RN0.63 2/16:
Test Plan: I made sure web still loads, and tested the native stuff together with the rest
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/package.json",
"new_path": "lib/package.json",
"diff": "\"invariant\": \"^2.2.4\",\n\"lodash\": \"^4.17.19\",\n\"prop-types\": \"^15.7.2\",\n- \"react\": \"16.11.0\",\n+ \"react\": \"16.13.1\",\n\"react-redux\": \"^7.1.1\",\n\"reselect\": \"^4.0.0\",\n\"re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 2/16: react@16.13.1
Test Plan: I made sure web still loads, and tested the native stuff together with the rest
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D312 |
129,187 | 26.10.2020 20:20:45 | 14,400 | e14efa2402792bc342730cc979ad37c1bc5c0792 | RN0.63 5/16: Android updates
Test Plan: I made sure Android compiled in dev and release modes on API level 29, and tested dev mode on API levels 21, 22, and 23.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -20,7 +20,7 @@ import com.android.build.OutputFile\n* // default. Can be overridden with ENTRY_FILE environment variable.\n* entryFile: \"index.android.js\",\n*\n- * /... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 5/16: Android updates
Test Plan: I made sure Android compiled in dev and release modes on API level 29, and tested dev mode on API levels 21, 22, and 23.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D315 |
129,187 | 26.10.2020 21:40:28 | 14,400 | 91fccada54a5b00d4065f5c53bba5f0bcf362212 | RN0.63 9/16: YellowBox -> LogBox
Summary: In React Native 0.63, `YellowBox` is deprecated in favor of `LogBox`.
Test Plan: I made sure the warnings about `YellowBox` deprecation stopped being printed
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/push/push-handler.react.js",
"new_path": "native/push/push-handler.react.js",
"diff": "@@ -22,7 +22,7 @@ import {\nPlatform,\nAlert,\nVibration,\n- YellowBox,\n+ LogBox,\n} from 'react-native';\nimport NotificationsIOS from 'react-native-notifications';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 9/16: YellowBox -> LogBox
Summary: In React Native 0.63, `YellowBox` is deprecated in favor of `LogBox`.
Test Plan: I made sure the warnings about `YellowBox` deprecation stopped being printed
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D3... |
129,187 | 27.10.2020 00:53:29 | 14,400 | 46403debd4cd7d64552483f77d7956c3fadda65e | RN0.63 11/16: Fix Flow bug when merging Media
Summary: Flow is worried about `Video` getting merged with an `Image`
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -771,8 +771,22 @@ function reduceMessageStore(\nfor (let singleMedia of message.media) {\nif (singleMedia.id !== currentMediaID) {\nmedia.push(singleMedia);\n- } else ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 11/16: Fix Flow bug when merging Media
Summary: Flow is worried about `Video` getting merged with an `Image`
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D321 |
129,187 | 27.10.2020 00:55:55 | 14,400 | 5a4b49c8651cae9c5de926cc2d4e43a96384561e | RN0.63 12/16: Fix Flow bug with Animated interpolate outputRange
Summary: Not sure what's up here...
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -88,7 +88,7 @@ class ChatList extends React.PureComponent<Props, State> {\nsuper(props);\nconst sendButtonTranslateY = this.newMessagesPillProgress.interpolate({\ninputR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 12/16: Fix Flow bug with Animated interpolate outputRange
Summary: Not sure what's up here...
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D322 |
129,187 | 27.10.2020 00:58:24 | 14,400 | 09fb0594b528e64afa2a4307dde0559f2fe8b579 | RN0.63 14/16: Flow type NativeMethodsMixinType -> NativeMethods
Summary: These types got restructured and renamed
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/camera-modal.react.js",
"new_path": "native/media/camera-modal.react.js",
"diff": "@@ -17,7 +17,7 @@ import {\nInputStateContext,\n} from '../input/input-state';\nimport type { ViewStyle } from '../types/styles';\n-import type { NativeMethodsMixin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 14/16: Flow type NativeMethodsMixinType -> NativeMethods
Summary: These types got restructured and renamed
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D324 |
129,187 | 27.10.2020 01:02:42 | 14,400 | 27535fb372ef0eb3d7963ac99109cc3ec5410f3f | RN0.63 15/16: Get rid of $FlowFixMe for object spreads
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -130,7 +130,6 @@ function reduceUserInfos(state: UserStore, action: BaseAction): UserStore {\nconst newUserInfos = _keyBy(userInfo => userInfo.id)(\naction.payload.userInfos... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 15/16: Get rid of $FlowFixMe for object spreads
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D325 |
129,187 | 27.10.2020 01:10:49 | 14,400 | 4e365dec408fb31d384a42661b03117065ffa125 | RN0.63 16/16: Patch react-native-firebase Flow type
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native-firebase+5.6.0.patch",
"new_path": "patches/react-native-firebase+5.6.0.patch",
"diff": "@@ -138,6 +138,19 @@ index 1716dbe..8a52a88 100644\n) {\nthrow new Error(\n'Query.onSnapshot failed: Observer.error must be a valid function.'\n+diff ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | RN0.63 16/16: Patch react-native-firebase Flow type
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D326 |
129,187 | 28.10.2020 18:33:44 | 14,400 | 7ad11fb1b5ebcd7dbbcacd82a1ea13801345a4f1 | Introduce threadPermissions.CREATE_SIDEBARS
Summary:
In ["announcement threads"](https://site.ashoat.com/comm/app/demo#orgs) I want it so only admins can create subthreads, but anybody can create sidebars.
This diffs creates a new permission type `CREATE_SIDEBARS`, separate from `CREATE_SUBTHREADS`.
Test Plan: Flow
Rev... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -34,7 +34,6 @@ export function assertThreadType(threadType: number): ThreadType {\nreturn threadType;\n}\n-// Keep in sync with server/permissions.php\nexport const threadPermissi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce threadPermissions.CREATE_SIDEBARS
Summary:
In ["announcement threads"](https://site.ashoat.com/comm/app/demo#orgs) I want it so only admins can create subthreads, but anybody can create sidebars.
This diffs creates a new permission type `CREATE_SIDEBARS`, separate from `CREATE_SUBTHREADS`.
Test Plan: Flow
... |
129,187 | 29.10.2020 14:47:46 | 14,400 | a78742f4ca70101336ed9d11763dcbf1d3f30ffa | [server] Simplify validationQuery in updateThread
Summary: In D273 I removed the need to query the `users` table, but didn't realize it. This diff simplies the query, since it only needs to hit the `threads` table now.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -336,10 +336,9 @@ async function updateThread(\n}\nconst validationQuery = SQL`\n- SELECT t.type, t.parent_thread_id\n- FROM users u\n- LEFT JOIN threads... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Simplify validationQuery in updateThread
Summary: In D273 I removed the need to query the `users` table, but didn't realize it. This diff simplies the query, since it only needs to hit the `threads` table now.
Test Plan: Flow
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zr... |
129,187 | 29.10.2020 15:33:46 | 14,400 | 307e019fe412ac7440a1f285c6926268dac2b4eb | [server] Avoid double-fetching in leaveThread
Summary: I noticed we could avoid double-fetching from the same table in `leaveThread`
Test Plan: Flow, try leaving some threads
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -24,7 +24,7 @@ import { ServerError } from 'lib/utils/errors';\nimport { promiseAll } from 'lib/utils/promises';\nimport { filteredThreadIDs } from 'lib/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid double-fetching in leaveThread
Summary: I noticed we could avoid double-fetching from the same table in `leaveThread`
Test Plan: Flow, try leaving some threads
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.... |
129,187 | 29.10.2020 15:50:50 | 14,400 | f01953b179d948aca02d25914fc846015144aaee | [server] Avoid double-fetching in createThread
Summary: I noticed we could avoid double-fetching from the same table in `createThread`
Test Plan: Flow, create a thread
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -12,17 +12,19 @@ import type { Viewer } from '../session/viewer';\nimport invariant from 'invariant';\n-import { generateRandomColor } from 'lib/shared/thr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid double-fetching in createThread
Summary: I noticed we could avoid double-fetching from the same table in `createThread`
Test Plan: Flow, create a thread
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.... |
129,187 | 01.11.2020 19:44:42 | 18,000 | 9ec7df4b97475397b390a6896d6d5a1a64959ef2 | [native] Use hook for data-binding in RegisterPanel
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/register-panel.react.js",
"new_path": "native/account/register-panel.react.js",
"diff": "// @flow\n-import type { DispatchActionPromise } from 'lib/utils/action-utils';\n-import type { AppState } from '../redux/redux-setup';\nimport type { Loadi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in RegisterPanel
Test Plan: Flow
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D351 |
129,187 | 01.11.2020 19:50:55 | 18,000 | 195685a6700879390513db44a7a494a1b16db124 | [native] Use hook for data-binding in VerificationModal
Test Plan: Flow
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/verification-modal.react.js",
"new_path": "native/account/verification-modal.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\n-import type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport {\nt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in VerificationModal
Test Plan: Flow
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D352 |
129,187 | 02.11.2020 22:26:41 | 18,000 | cf73c662136e526d29d397f7ffa2a3ef98cae42b | [server] Don't throw no_parent_thread_specified if parentThreadID not set
Summary: Accidentally messed this up in D344. Should've tested better. This was breaking whenever I called `editThread` without setting `changes.parentThreadID`.
Test Plan: Call `editThread` and make sure it doesn't crash
Reviewers: palys-swm
Sub... | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -401,6 +401,8 @@ async function updateThread(\n// If the thread is being switched to nested, a parent must be specified\nif (\noldThreadType === threadTy... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't throw no_parent_thread_specified if parentThreadID not set
Summary: Accidentally messed this up in D344. Should've tested better. This was breaking whenever I called `editThread` without setting `changes.parentThreadID`.
Test Plan: Call `editThread` and make sure it doesn't crash
Reviewers: palys-swm
... |
129,191 | 29.10.2020 11:33:15 | -3,600 | 59702810c7f701eec90912299a4ce9ac702d715b | [native] Add optional user info parameter to message list nav params
Test Plan: flow
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-types.js",
"new_path": "native/chat/message-list-types.js",
"diff": "import { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\nimport type { MarkdownRules } from '../markdown/rules.react';\n+import { type UserInfo,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add optional user info parameter to message list nav params
Test Plan: flow
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D341 |
129,187 | 05.11.2020 23:53:53 | 18,000 | 43478d37ea0aee0935a512b4dc69c1037b0ca736 | [native] Use hook for data-binding in Calendar
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "// @flow\n-import {\n- type EntryInfo,\n- entryInfoPropType,\n- type CalendarQuery,\n- type CalendarQueryUpdateResult,\n+import type {\n+ EntryInfo,\n+ CalendarQuery,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in Calendar
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D371 |
129,187 | 06.11.2020 00:06:13 | 18,000 | 723edc6e5e8677e0129cace060f90c8d3fe3974c | [native] Use hook for data-binding in Entry
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "// @flow\nimport type { EntryInfoWithHeight } from './calendar.react';\n-import {\n- entryInfoPropType,\n- type CreateEntryInfo,\n- type SaveEntryInfo,\n- type SaveEntryRes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in Entry
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D372 |
129,187 | 08.11.2020 17:48:35 | 18,000 | 91bb1b6c9338eb9db4ef62803793ad9122c7d382 | [native] Use hook for data-binding in MoreHeader
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/more-header.react.js",
"new_path": "native/more/more-header.react.js",
"diff": "// @flow\n+import type { StackHeaderProps } from '@react-navigation/stack';\n+\n+import * as React from 'react';\n+\nimport Header from '../navigation/header.react';\ni... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in MoreHeader
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D374 |
129,187 | 08.11.2020 18:21:06 | 18,000 | f5bae34105f0a91ef33560214a153e4046f66c20 | [native] Convert MessageStorePruner to hook
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-store-pruner.react.js",
"new_path": "native/chat/message-store-pruner.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\n-import { messageStorePruneActionType } from 'lib/actions/message-actions';\n-import... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert MessageStorePruner to hook
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D376 |
129,187 | 08.11.2020 18:32:26 | 18,000 | ad32a088f6731278fa183be8b95173854b81a6e1 | [native] Use hook for data-binding in DeleteThread
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/delete-thread.react.js",
"new_path": "native/chat/settings/delete-thread.react.js",
"diff": "// @flow\n-import type { AppState } from '../../redux/redux-setup';\n-import type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data-binding in DeleteThread
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D377 |
129,187 | 08.11.2020 18:34:34 | 18,000 | 6f65d2aa45adb856780477a39d3f39d9f7fc7b9a | [native] Get rid of withNavContext and connectNav
Summary:
They're no longer used. Going forward, let's use hooks for data binding.
I also got rid of `navContextPropType`.
Test Plan: Flow
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-context.js",
"new_path": "native/navigation/navigation-context.js",
"diff": "@@ -9,7 +9,6 @@ import type { ChatRouterNavigationAction } from '../chat/chat-router';\nimport type { OverlayRouterNavigationAction } from './overlay-rout... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of withNavContext and connectNav
Summary:
They're no longer used. Going forward, let's use hooks for data binding.
I also got rid of `navContextPropType`.
Test Plan: Flow
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.... |
129,187 | 11.11.2020 19:50:43 | 18,000 | 2278756d9de90d94d3072b060596793ce441c13d | [server] Button to show rest of sidebars when there are too many
Summary: Introducing `ChatThreadListSeeMoreSidebars`, which will pop up a modal with all of the sidebars.
Test Plan: Make sure the button displays where it should, and looks good
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -34,6 +34,7 @@ import { useColors, useStyles } from '../themes/colors';\nimport { SingleLine } from '../components/single-line.react';\nimport { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Button to show rest of sidebars when there are too many
Summary: Introducing `ChatThreadListSeeMoreSidebars`, which will pop up a modal with all of the sidebars.
Test Plan: Make sure the button displays where it should, and looks good
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu4... |
129,187 | 11.11.2020 21:25:08 | 18,000 | 49d7c18b41906106a39225f1d48a9cace745c7e8 | [native] Dummy SidebarListModal
Summary: Boilerplate for the new modal and code that will navigate to it
Test Plan: Flow, make sure the app still works, and make sure the modals get opened when the button is pressed
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -39,12 +39,14 @@ import ChatThreadListSeeMoreSidebars from './chat-thread-list-see-more-sidebars.\ntype Props = {|\n+data: ChatThreadItem,\n+onPr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Dummy SidebarListModal
Summary: Boilerplate for the new modal and code that will navigate to it
Test Plan: Flow, make sure the app still works, and make sure the modals get opened when the button is pressed
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Rev... |
129,183 | 27.10.2020 13:21:17 | -3,600 | 7f58395749001f632ab06dcff9618f7e6d1cc66f | Add functions to check for admins and replace in codebase
Test Plan: Made sure the behaviour is still the same
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -22,7 +22,6 @@ import _compact from 'lodash/fp/compact';\nimport _filter from 'lodash/fp/filter';\nimport _sortBy from 'lodash/fp/sortBy';\nimport _memoize from 'l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add functions to check for admins and replace in codebase
Test Plan: Made sure the behaviour is still the same
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D338 |
129,183 | 05.11.2020 15:03:22 | -3,600 | f4534979f04c98aabdd8a43f016c287c5e7c314c | [server] Don't allow to send messages in 1-1 chats with blocks
Test Plan: Made sure users can't send messages with checks like in D291
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -10,6 +10,7 @@ import {\ntype ThreadCurrentUserInfo,\ntype RoleInfo,\ntype ServerMemberInfo,\n+ type ThreadPermissionsInfo,\nthreadTypes,\nthreadPermissions,\n} from '../types/t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't allow to send messages in 1-1 chats with blocks
Test Plan: Made sure users can't send messages with checks like in D291
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D308 |
129,183 | 10.11.2020 14:51:09 | -3,600 | c7fce2eb80f7fb42cd9d0171b7e23dc0aa510d10 | Handle create_sidebars and create_subthreads permission check
Test Plan: Checked if subthreads can be created only when permissions are true
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -12,10 +12,7 @@ import type { Viewer } from '../session/viewer';\nimport invariant from 'invariant';\n-import {\n- generateRandomColor,\n- threadHasPermiss... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Handle create_sidebars and create_subthreads permission check
Test Plan: Checked if subthreads can be created only when permissions are true
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D387 |
129,183 | 10.11.2020 14:52:04 | -3,600 | 3dc0f6c0b7524b2d8828738fc8cc5cf61cdb3d28 | Add comment to warn about fetchThreadPermissionsBlob
Test Plan: Nothing to test, just comment added
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/thread-permission-fetchers.js",
"new_path": "server/src/fetchers/thread-permission-fetchers.js",
"diff": "@@ -16,6 +16,11 @@ import { dbQuery, SQL } from '../database/database';\nimport { fetchKnownUserInfos } from '../fetchers/user-fetcher... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add comment to warn about fetchThreadPermissionsBlob
Test Plan: Nothing to test, just comment added
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D388 |
129,183 | 10.11.2020 15:11:16 | -3,600 | 6da52fa52b7a05ffec0fc55101585a78a05f5360 | Don't allow threadHasPermission check on RawThreadInfo when checking permission that might be disabled
Test Plan: Check if behavior is the same for ThreadInfo, error only on disabledPermission and RawThreadInfo
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -20,6 +20,7 @@ import { userRelationshipStatus } from '../types/relationship-types';\nimport tinycolor from 'tinycolor2';\nimport _find from 'lodash/fp/find';\n+import invariant... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't allow threadHasPermission check on RawThreadInfo when checking permission that might be disabled
Test Plan: Check if behavior is the same for ThreadInfo, error only on disabledPermission and RawThreadInfo
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: h... |
129,183 | 09.11.2020 12:27:21 | -3,600 | 300d299040284045b27c6730179ec7a61ac39705 | [web] Don't show buttons for entries when no edit_entries permission
Test Plan: Made sure entries from blocked threads are disabled
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/entry.react.js",
"new_path": "web/calendar/entry.react.js",
"diff": "@@ -12,7 +12,7 @@ import {\ntype CalendarQuery,\n} from 'lib/types/entry-types';\nimport type { ThreadInfo } from 'lib/types/thread-types';\n-import { threadInfoPropType } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Don't show buttons for entries when no edit_entries permission
Test Plan: Made sure entries from blocked threads are disabled
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D380 |
129,183 | 10.11.2020 12:10:04 | -3,600 | 797200cfe73811e6e8e4d58ac25173e2078a6246 | [native] Don't show buttons for entries when there is no edit_entries permission
Test Plan: Checked that in blocked threads entries are disabled
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -10,7 +10,7 @@ import type {\nDeleteEntryResponse,\nCalendarQuery,\n} from 'lib/types/entry-types';\n-import type { ThreadInfo } from 'lib/types/thread-types';\n+import ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't show buttons for entries when there is no edit_entries permission
Test Plan: Checked that in blocked threads entries are disabled
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D379 |
129,183 | 09.11.2020 15:28:31 | -3,600 | e52c3d9bb756f959cf290c03f5e4bba5379cdb26 | Add option to unblock user when relationshipStatus = both_blocked
Test Plan: Make sure button is visible and the relationship updates correctly
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-list-item.react.js",
"new_path": "native/more/relationship-list-item.react.js",
"diff": "@@ -83,6 +83,7 @@ class RelationshipListItem extends React.PureComponent<Props> {\n);\n} else if (\nuserInfo.relationshipStatus === userRelationsh... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add option to unblock user when relationshipStatus = both_blocked
Test Plan: Make sure button is visible and the relationship updates correctly
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D381 |
129,187 | 13.11.2020 19:15:47 | 18,000 | daa585912c981902ad847c655064b7607c14a188 | [lib] Move threadSearchText to thread-utils
Summary: (About to use it in `SidebarListModal`)
Test Plan: Flow (just moving a function)
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/nav-selectors.js",
"new_path": "lib/selectors/nav-selectors.js",
"diff": "@@ -12,6 +12,7 @@ import { createSelector } from 'reselect';\nimport { getConfig } from '../utils/config';\nimport SearchIndex from '../shared/search-index';\n+import { thr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move threadSearchText to thread-utils
Summary: (About to use it in `SidebarListModal`)
Test Plan: Flow (just moving a function)
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D399 |
129,187 | 13.11.2020 19:16:28 | 18,000 | 75fbc146441d0d817fda21b86659ebfd82b8748a | [native] FlatList and search logic for SidebarListModal
Summary: This diff handles deciding which `SidebarInfo`s to display in the `SidebarListModal`.
Test Plan: Makes sure it loads correctly. Most of the testing was done in concert with the next diff
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/sidebar-list-modal.react.js",
"new_path": "native/chat/sidebar-list-modal.react.js",
"diff": "// @flow\n-import type { ThreadInfo } from 'lib/types/thread-types';\n+import type { ThreadInfo, SidebarInfo } from 'lib/types/thread-types';\n+import typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] FlatList and search logic for SidebarListModal
Summary: This diff handles deciding which `SidebarInfo`s to display in the `SidebarListModal`.
Test Plan: Makes sure it loads correctly. Most of the testing was done in concert with the next diff
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo,... |
129,187 | 14.11.2020 23:57:59 | 18,000 | 15dbf67437d48d2d865100c6f33d73d9fe9cb9ae | [native] Update React Navigation libs
Summary: I checked all of the `CHANGELOG`s and version notes, and none of these should have breaking changes.
Test Plan: Compile & run app, play around a bit
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -127,6 +127,7 @@ function ChatNavigator({\nstate={state}\ndescriptors={descriptors}\nnavigation={navigation}\n+ detachInactiveScreens={Platform.OS !== 'ios'}\n/>\n);\n}\n"
},
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update React Navigation libs
Summary: I checked all of the `CHANGELOG`s and version notes, and none of these should have breaking changes.
Test Plan: Compile & run app, play around a bit
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabr... |
129,187 | 15.11.2020 00:13:01 | 18,000 | 42412dcbec5703fca7324a5d498af6952bbbb57b | [native] Update react-native-reanimated and react-native-gesture-handler
Summary: I checked version notes and neither of these should have breaking changes.
Test Plan: Compile & run app, play around a bit
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -387,11 +387,11 @@ PODS:\n- SDWebImageWebPCoder (~> 0.2.3)\n- RNFS (2.15.2):\n- React\n- - RNGestureHandler (1.6.1):\n+ - RNGestureHandler (1.8.0):\n- React\n- RNKeychain (4.0.1):\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update react-native-reanimated and react-native-gesture-handler
Summary: I checked version notes and neither of these should have breaking changes.
Test Plan: Compile & run app, play around a bit
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: http... |
129,191 | 09.11.2020 13:37:35 | -3,600 | a1d37df5f2af2a2b0d7e67b2a09a46507e15740c | [native] Add option to choose updates type when creating a thread
Test Plan: I created a thread by using thread composer and it was created successfully. I also tested pending thread creation by sending a friend request.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -9,6 +9,7 @@ import {\nimport { messageTypes } from 'lib/types/message-types';\nimport { userRelationshipStatus } from 'lib/types/relationship-types';\nimp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add option to choose updates type when creating a thread
Test Plan: I created a thread by using thread composer and it was created successfully. I also tested pending thread creation by sending a friend request.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revis... |
129,191 | 09.11.2020 14:46:42 | -3,600 | 098f2d84fdb23c3999268259e41146a16ddcf96a | [native] Add option to choose updates type when creating a message
Test Plan: I tested it in D369: the thread creation message was successfuly delivered. Also creating text message worked as expected.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -10,6 +10,7 @@ import { threadPermissions } from 'lib/types/thread-types';\nimport { updateTypes } from 'lib/types/update-types';\nimport { redisMessageT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add option to choose updates type when creating a message
Test Plan: I tested it in D369: the thread creation message was successfuly delivered. Also creating text message worked as expected.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabric... |
129,191 | 05.11.2020 14:50:33 | -3,600 | cdc63e2d5f79b353c2d801532ee919f53725937f | [native] Use hook for data binding in chat thread list
Test Plan: Flow, threads list is displayed correctly, search works as expected
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport type { ThreadInfo } from 'lib/types/thread-types';\nimport type { TabNavigationProp }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook for data binding in chat thread list
Test Plan: Flow, threads list is displayed correctly, search works as expected
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D370 |
129,183 | 17.11.2020 14:01:33 | -3,600 | f1a24a15f3307436651fd34d491d0f11de99cd75 | Stop using getUserSearchResults in RelationshipUpdateModal
Test Plan: Made sure block list and friend list still work as before
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-update-modal.react.js",
"new_path": "native/more/relationship-update-modal.react.js",
"diff": "// @flow\n-import type { GlobalAccountUserInfo, UserInfo } from 'lib/types/user-types';\n+import type {\n+ GlobalAccountUserInfo,\n+ UserInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Stop using getUserSearchResults in RelationshipUpdateModal
Test Plan: Made sure block list and friend list still work as before
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D413 |
129,183 | 16.11.2020 12:17:41 | -3,600 | c6c900b2ed01ef2ba3e5a959ec08728a46ec50c5 | Include all not-blocked users in userInfoSelectorForPotentialMembers
Summary: We want to list non-friends with a notice when adding to a thread, so we need to change selector
Test Plan: Made sure only blocked users are excluded
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "@@ -8,7 +8,6 @@ import type {\n} from '../types/user-types';\nimport {\ntype RawThreadInfo,\n- type MemberInfo,\ntype RelativeMemberInfo,\n} from '../types/thread-types';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include all not-blocked users in userInfoSelectorForPotentialMembers
Summary: We want to list non-friends with a notice when adding to a thread, so we need to change selector
Test Plan: Made sure only blocked users are excluded
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differ... |
129,183 | 16.11.2020 15:00:00 | -3,600 | 5bfc42807e9685b0f0f2cb14f25e7c7b57060bfe | [native] Show alert when trying to add non-friend to a thread
Test Plan: Checked if alert is displayed only when clicking on non-friends, and for other users behaviour is still the same
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/search-utils.js",
"new_path": "lib/shared/search-utils.js",
"diff": "@@ -70,15 +70,24 @@ function getPotentialMemberItems(\nif (isMemberOfParentThread) {\nreturn { ...result };\n}\n- let notice;\n+ let notice, alertText;\n+ const userText = result.u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show alert when trying to add non-friend to a thread
Test Plan: Checked if alert is displayed only when clicking on non-friends, and for other users behaviour is still the same
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat... |
129,191 | 12.11.2020 17:57:06 | -3,600 | e1c71c58906b030315619f715be32dac10ce0696 | [server][lib] Add update relationship message type
Test Plan: Sending and displaying this message was tested in the next diff. I havent tested the notifications... is there any easy way to test them?
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -190,6 +190,21 @@ function robotextForMessageInfo(\n`${creator} restored an event scheduled for ${date}: ` +\n`\"${messageInfo.text}\"`\n);\n+ } else if (messageInfo.type === ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server][lib] Add update relationship message type
Test Plan: Sending and displaying this message was tested in the next diff. I havent tested the notifications... is there any easy way to test them?
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabrica... |
129,187 | 17.11.2020 18:11:41 | 18,000 | 8554b1dab2de0dd57706be5dcb74951d5304d0ba | [native] Use org.squadcal package for ReactNativeFlipper.java
Summary: I just noticed I hadn't changed these from the defaults. This change should be a no-op.
Test Plan: Compile Android, make sure everything still works
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/debug/java/org/squadcal/ReactNativeFlipper.java",
"new_path": "native/android/app/src/debug/java/org/squadcal/ReactNativeFlipper.java",
"diff": "* <p>This source code is licensed under the MIT license found in the LICENSE file in the roo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use org.squadcal package for ReactNativeFlipper.java
Summary: I just noticed I hadn't changed these from the defaults. This change should be a no-op.
Test Plan: Compile Android, make sure everything still works
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Rev... |
129,187 | 18.11.2020 15:47:08 | 18,000 | 7c92fe9cc8f970cbb17c112b58d56f3496fdb689 | [native] Move waitForInteractions to timers.js
Summary: I'm going to introduce an async function equivalent of `requestAnimationFrame`, and I figured it should go in the same file.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -68,7 +68,7 @@ import {\nimport LoadingIndicator from './loading-indicator.react';\nimport { colors, useStyles } from '../themes/colors';\nimport { NavContext } from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move waitForInteractions to timers.js
Summary: I'm going to introduce an async function equivalent of `requestAnimationFrame`, and I figured it should go in the same file.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabrica... |
129,183 | 19.11.2020 09:17:00 | -3,600 | bd3deb9e2c72e359e14481813fed7cd81bab2a00 | Update threadIsWithBlockedUserOnly function
Summary: Accept both rawThreadInfo and threadInfo, add optional parameter to check only blocked_by_viewer relationship status
Test Plan: Made sure threadIsWithBlockedUserOnly works as before
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -141,7 +141,9 @@ function threadIsGroupChat(threadInfo: ThreadInfo | RawThreadInfo) {\n);\n}\n-function threadOrParentThreadIsGroupChat(threadInfo: RawThreadInfo) {\n+function t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update threadIsWithBlockedUserOnly function
Summary: Accept both rawThreadInfo and threadInfo, add optional parameter to check only blocked_by_viewer relationship status
Test Plan: Made sure threadIsWithBlockedUserOnly works as before
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
... |
129,183 | 19.11.2020 10:09:09 | -3,600 | 689d121957048562a59ec0955399c17ac1a959de | [native] Update notice in a thread when user blocked target
Test Plan: Check if in thread with target user blocked new notice is displayed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -11,6 +11,7 @@ import {\nimport type { LoadingStatus } from 'lib/types/loading-types';\nimport { loadingStatusPropType } from 'lib/types/loading-types';\nimpor... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update notice in a thread when user blocked target
Test Plan: Check if in thread with target user blocked new notice is displayed
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D422 |
129,183 | 19.11.2020 10:12:00 | -3,600 | 809012ff596cc1f643ec64f267f5bb3938f49f28 | [web] Update notice in a thread when user blocked target
Test Plan: Check if in thread with target user blocked new notice is displayed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -11,6 +11,7 @@ import {\ntype ThreadJoinPayload,\n} from 'lib/types/thread-types';\nimport { messageTypes } from 'lib/types/message-types';\n+import { type UserInfo,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Update notice in a thread when user blocked target
Test Plan: Check if in thread with target user blocked new notice is displayed
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D423 |
129,183 | 19.11.2020 15:30:11 | -3,600 | 5e90c90c5dc8195e8005332938af1e0b2c1dd245 | Rename function
Test Plan: Check if everything works
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/thread-permission-fetchers.js",
"new_path": "server/src/fetchers/thread-permission-fetchers.js",
"diff": "@@ -95,7 +95,7 @@ async function checkThreads(\nconst [[result], disabledThreadIDs] = await Promise.all([\ndbQuery(query),\n- checkThr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename function
Test Plan: Check if everything works
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D424 |
129,183 | 20.11.2020 08:08:30 | -3,600 | d52b16828c199563b045e86e4c6bedcc6f0c09f3 | [native] Display correct notice when user can't join thread
Test Plan: Check if correct notice is displayed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -386,11 +386,12 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nrender() {\nconst isMember = viewerIsMember(this.props.threadInfo);\n+ const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display correct notice when user can't join thread
Test Plan: Check if correct notice is displayed
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D426 |
129,183 | 20.11.2020 08:09:37 | -3,600 | 1f5460cfbe5cfada8540cf3e215218ce0297ab02 | [web] Display correct notice when user can't join thread
Test Plan: Check if correct notice is displayed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -172,11 +172,12 @@ class ChatInputBar extends React.PureComponent<Props> {\nrender() {\nconst isMember = viewerIsMember(this.props.threadInfo);\n+ const canJoin = th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display correct notice when user can't join thread
Test Plan: Check if correct notice is displayed
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D427 |
129,187 | 22.11.2020 21:23:48 | 18,000 | dcb260abe2c7601144b8e19732e55407d2b32bc1 | [lib] Include mostRecentNonLocalMessage in SidebarInfo
Summary: We'll need this so we can call `updateUnreadStatus` for sidebars, so we can support mark-as-unread through `Swipeable`.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -34,6 +34,7 @@ import {\nmessageKey,\nrobotextForMessageInfo,\ncreateMessageInfo,\n+ getMostRecentNonLocalMessageID,\n} from '../shared/message-utils';\nimport { threa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Include mostRecentNonLocalMessage in SidebarInfo
Summary: We'll need this so we can call `updateUnreadStatus` for sidebars, so we can support mark-as-unread through `Swipeable`.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabr... |
129,187 | 22.11.2020 21:47:03 | 18,000 | 452309d5f106644113594dd87956bba972fa7992 | [native] Factor out ChatThreadListItem swipeability into SwipeableThread
Summary: I want to extract that functionality so I can use it for sidebars as well.
Test Plan: Flow, render the `ChatThreadList`, make sure swipe and mark-as-unread still work
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -5,25 +5,10 @@ import {\nchatThreadItemPropType,\n} from 'lib/selectors/chat-selectors';\nimport type { ThreadInfo } from 'lib/types/thread-types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Factor out ChatThreadListItem swipeability into SwipeableThread
Summary: I want to extract that functionality so I can use it for sidebars as well.
Test Plan: Flow, render the `ChatThreadList`, make sure swipe and mark-as-unread still work
Reviewers: palys-swm, KatPo
Reviewed By: KatPo
Subscribers: KatPo,... |
129,183 | 23.11.2020 07:24:31 | -3,600 | d425cd9f5779e3196a031df8b3a184deee998766 | Make user search case-insensitive
Test Plan: Check if for a prefix results include users with both upper and lower case username
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/search/users.js",
"new_path": "server/src/search/users.js",
"diff": "@@ -11,7 +11,7 @@ async function searchForUsers(\nconst sqlQuery = SQL`SELECT id, username FROM users `;\nconst prefix = query.prefix;\nif (prefix) {\n- sqlQuery.append(SQL`WHERE u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Make user search case-insensitive
Test Plan: Check if for a prefix results include users with both upper and lower case username
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D435 |
129,187 | 23.11.2020 20:07:49 | 18,000 | 053cbd705752b2c5fdf4695659063bd3c69dbe35 | [native] Extract useMessageListContext from MessageListContainer
Summary: We have another place we need to render `MessageListContext.Provider`: `TextMessageTooltipButton`. This is so the `InnerTextMessage` inside has access to Markdown rules.
Test Plan: Flow, will test in combination with later diffs
Reviewers: KatPo,... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -33,8 +33,10 @@ import {\ntype OverlayContextType,\n} from '../navigation/overlay-context';\nimport { useSelector } from '../redux/redux-utils'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract useMessageListContext from MessageListContainer
Summary: We have another place we need to render `MessageListContext.Provider`: `TextMessageTooltipButton`. This is so the `InnerTextMessage` inside has access to Markdown rules.
Test Plan: Flow, will test in combination with later diffs
Reviewers: Kat... |
129,187 | 23.11.2020 20:12:33 | 18,000 | 95737fe106e3544e5d7b612306e902933cef2767 | [native] Set MessageListContext in TextMessageTooltipButton
Summary: We need this so `InnerTextMessage` has access to Markdown rules.
Test Plan: Bring up `TextMessageTooltipModal` and make sure it looks correct
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message-tooltip-button.react.js",
"new_path": "native/chat/text-message-tooltip-button.react.js",
"diff": "@@ -9,6 +9,10 @@ import Animated from 'react-native-reanimated';\nimport { InnerTextMessage } from './inner-text-message.react';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set MessageListContext in TextMessageTooltipButton
Summary: We need this so `InnerTextMessage` has access to Markdown rules.
Test Plan: Bring up `TextMessageTooltipModal` and make sure it looks correct
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: ht... |
129,183 | 25.11.2020 15:28:07 | -3,600 | 8901a96cd0c9cfb867a91c952000ac2ab6cb3790 | [lib] Introduce userStoreSearchIndex selector
Test Plan: Tested in D436
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "@@ -157,6 +157,23 @@ const isLoggedIn = (state: BaseAppState<*>) =>\nstate.dataLoaded\n);\n+const userStoreSearchIndex: (\n+ state: BaseAppState<*>,\n+) => SearchIndex = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce userStoreSearchIndex selector
Test Plan: Tested in D436
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D443 |
129,183 | 26.11.2020 13:19:58 | -3,600 | 8bf12fb18244503c96b285a74171ae88c729f115 | [lib] Filter anonymus users out of relationships
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/relationship-selectors.js",
"new_path": "lib/selectors/relationship-selectors.js",
"diff": "@@ -20,19 +20,22 @@ const userRelationshipsSelector: (\nconst blocked = [];\nfor (const userID in userInfos) {\nconst userInfo = userInfos[userID];\n- con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Filter anonymus users out of relationships
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D446 |
129,187 | 26.11.2020 21:13:28 | 18,000 | 9f72a0876b3f7b16bbb244c6181e9bc8cab6119a | [native] Remove PropTypes from ChatThreadListItem
Summary: We haven't been using this for function components, and this one in particular hasn't been updated.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "// @flow\n-import {\n- type ChatThreadItem,\n- chatThreadItemPropType,\n-} from 'lib/selectors/chat-selectors';\n+import type { ChatThreadItem } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Remove PropTypes from ChatThreadListItem
Summary: We haven't been using this for function components, and this one in particular hasn't been updated.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D450 |
129,187 | 27.11.2020 23:59:05 | 18,000 | 74ded68b7d054e4d21f95607c33310c901cfa423 | [web] Extract ChatThreadListItemMenu
Summary: I'll need to reuse this for sidebars.
Test Plan: Test menu and mark-as-read/mark-as-unread functionality
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "+// @flow\n+\n+import type {\n+ SetThreadUnreadStatusPayload,\n+ SetThreadUnreadStatusRequest,\n+} from 'lib/types/activity-types';\n+import type { ChatThreadItem } from 'lib/selectors/chat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Extract ChatThreadListItemMenu
Summary: I'll need to reuse this for sidebars.
Test Plan: Test menu and mark-as-read/mark-as-unread functionality
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D451 |
129,187 | 28.11.2020 23:34:28 | 18,000 | e84cb9004cf10754e2e2c2e30ea77d7a5e336948 | [web] Use Hook for data-binding in AccountBar
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/account-bar.react.js",
"new_path": "web/account-bar.react.js",
"diff": "// @flow\n-import type { AppState } from './redux/redux-setup';\n-import type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport type { LogOutResult } from 'lib/types/acc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use Hook for data-binding in AccountBar
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D452 |
129,187 | 29.11.2020 13:59:15 | 18,000 | 122e3d1a56a81ab8e2bb02072a73c90eceb2a3fe | [native] Extract SidebarItem
Summary: While working on the web side of this, I realized it's weird for `ChatThreadListSidebar` to be handling both the `ChatThreadList` and the `SidebarListModal` use case, especially since it's basically just a conditional branch.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers:... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -22,7 +22,7 @@ type Props = {|\n+onPressItem: (threadInfo: ThreadInfo) => void,\n+onPressSeeMoreSidebars: (threadInfo: ThreadInfo) => void,\n+onS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract SidebarItem
Summary: While working on the web side of this, I realized it's weird for `ChatThreadListSidebar` to be handling both the `ChatThreadList` and the `SidebarListModal` use case, especially since it's basically just a conditional branch.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed... |
129,187 | 29.11.2020 14:22:43 | 18,000 | c008921b300e03c12bd610422aec514a6233df43 | [web] Convert ChatThreadListItem to Hook
Summary: Data-binding was initially in `ChatThreadList`, but I moved it inline into `ChatThreadListItem`. Converted both to function components/Hooks.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "// @flow\n-import {\n- type ChatThreadItem,\n- chatThreadItemPropType,\n-} from 'lib/selectors/chat-selectors';\n-import type { Dispatch } from 'lib/types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Convert ChatThreadListItem to Hook
Summary: Data-binding was initially in `ChatThreadList`, but I moved it inline into `ChatThreadListItem`. Converted both to function components/Hooks.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https... |
129,183 | 27.11.2020 12:54:28 | -3,600 | 867326547a6ecea8d39bfe01e5de25b9c10be432 | [native] Dismiss keyboard in relationship list
Test Plan: Checked if there are no weird effects when some action on relationship list is performed, checked if keyboard gets dismissed
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-list-item.react.js",
"new_path": "native/more/relationship-list-item.react.js",
"diff": "@@ -41,6 +41,10 @@ import {\nOverlayContext,\ntype OverlayContextType,\n} from '../navigation/overlay-context';\n+import {\n+ type KeyboardState,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Dismiss keyboard in relationship list
Test Plan: Checked if there are no weird effects when some action on relationship list is performed, checked if keyboard gets dismissed
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.co... |
129,187 | 30.11.2020 11:50:19 | 18,000 | 45ec538090e763735aa06c401e0fd7d87970bbd2 | [native] Update to
Summary: New point release, [link](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0634) to `CHANGELOG`.
Test Plan: `yarn cleaninstall`, recompile both iOS and Android, make sure it works
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -28,14 +28,14 @@ PODS:\n- UMPermissionsInterface\n- EXSplashScreen (0.3.1):\n- UMCore\n- - FBLazyVector (0.63.3)\n- - FBReactNativeSpec (0.63.3):\n+ - FBLazyVector (0.63.4)\n+ - FBRea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to react-native@0.63.4
Summary: New point release, [link](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0634) to `CHANGELOG`.
Test Plan: `yarn cleaninstall`, recompile both iOS and Android, make sure it works
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
S... |
129,187 | 30.11.2020 13:02:23 | 18,000 | a2dbcc477c2ee0d7b5e53b49a72c18e9a55eef64 | [web] Extract useOnClickThread/useThreadIsActive from ChatThreadListItem
Summary: I want to use these Hooks for sidebars too.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "// @flow\nimport type { ChatThreadItem } from 'lib/selectors/chat-selectors';\n-import { updateNavInfoActionType } from '../redux/redux-setup';\nimport * ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Extract useOnClickThread/useThreadIsActive from ChatThreadListItem
Summary: I want to use these Hooks for sidebars too.
Test Plan: Flow
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D459 |
129,187 | 30.11.2020 13:18:15 | 18,000 | f0f4c6e2eea96a66ca9abb68cb2727eec5d97418 | [web] Only bold unread thread titles
Summary: This is more consistent with `native` and makes it clearer which threads are unread.
Test Plan: Look at the website on my local dev environment
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -29,15 +29,44 @@ function ChatThreadListItem(props: Props) {\nconst lastActivity = shortAbsoluteDate(item.lastUpdatedTime, timeZone);\nconst active = u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Only bold unread thread titles
Summary: This is more consistent with `native` and makes it clearer which threads are unread.
Test Plan: Look at the website on my local dev environment
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phab... |
129,187 | 30.11.2020 14:17:01 | 18,000 | 444436b71324aea5140f7bfa876b7caf1217c6cb | [web] Show sidebars inline in ChatThreadList
Summary: Just like on `native` in this video:
Test Plan: Look at the sidebars on my web environment, make sure pressing them brings up the `ChatMessageList`
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -15,6 +15,7 @@ import {\nuseOnClickThread,\nuseThreadIsActive,\n} from '../selectors/nav-selectors';\n+import ChatThreadListSidebar from './chat-thread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Show sidebars inline in ChatThreadList
Summary: Just like on `native` in this video: https://site.ashoat.com/comm/app/demo
Test Plan: Look at the sidebars on my web environment, make sure pressing them brings up the `ChatMessageList`
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zreb... |
129,187 | 30.11.2020 14:37:03 | 18,000 | 1104440877258f83a56fbddbd46c9a48c1800e1c | [web] Add ChatThreadListItemMenu to ChatThreadListSidebar
Summary: This adds mark-as-read/mark-as-unread functionality for sidebars on web. I also made some minor style changes for the menu that apply outside of sidebars (namely, decreased size).
Test Plan: Test mark-as-read and mark-as-unread functionality
Reviewers: ... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "@@ -4,7 +4,7 @@ import type {\nSetThreadUnreadStatusPayload,\nSetThreadUnreadStatusRequest,\n} from 'lib/types/activity-types';\n-import type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add ChatThreadListItemMenu to ChatThreadListSidebar
Summary: This adds mark-as-read/mark-as-unread functionality for sidebars on web. I also made some minor style changes for the menu that apply outside of sidebars (namely, decreased size).
Test Plan: Test mark-as-read and mark-as-unread functionality
Reviewer... |
129,187 | 01.12.2020 15:51:31 | 18,000 | f75ff8eeeb4c8703592763c4451ecb36d684234e | [server] Increase space for Phabricator backups
Summary: The Phabricator database is larger than I expected. Currently it takes up 46 MiB for one backup, so I'm increasing the space we have allocated for these backups.
Test Plan: #testinprod
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/bash/backup_phabricator.sh",
"new_path": "server/bash/backup_phabricator.sh",
"diff": "@@ -13,7 +13,7 @@ BACKUP_PATH=/mnt/backup\nBACKUP_USER=squadcal\n# The maximum amount of space to spend on Phabricator backups\n-MAX_DISK_USAGE_KB=51200 # 50 MiB\n+MA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Increase space for Phabricator backups
Summary: The Phabricator database is larger than I expected. Currently it takes up 46 MiB for one backup, so I'm increasing the space we have allocated for these backups.
Test Plan: #testinprod
Reviewers: palys-swm, KatPo
Reviewed By: KatPo
Subscribers: KatPo, zrebcu... |
129,183 | 27.11.2020 14:59:36 | -3,600 | 16f1904e6ec28fa5be05284d253a88ea3beeb816 | Introduce threadPermissions.LEAVE_THREAD
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -52,6 +52,7 @@ export const threadPermissions = Object.freeze({\nADD_MEMBERS: 'add_members',\nREMOVE_MEMBERS: 'remove_members',\nCHANGE_ROLE: 'change_role',\n+ LEAVE_THREAD: 'leav... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce threadPermissions.LEAVE_THREAD
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D448 |
129,183 | 27.11.2020 15:01:47 | -3,600 | 99afe238f30cf1f7386dff73932e1248601a5970 | [native] Check threadPermissions.LEAVE_THREAD
Test Plan: Check if button is displayed when permission is set
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -675,7 +675,12 @@ class ThreadSettings extends React.PureComponent<Props, State> {\n});\n}\n- if (viewerIsMember(threadInfo)) {\n+ const ca... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Check threadPermissions.LEAVE_THREAD
Test Plan: Check if button is displayed when permission is set
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D449 |
129,183 | 30.11.2020 10:14:09 | -3,600 | 2a661a4a47ab6c5f59390d7b9695f784b89b842a | [server] Check threadPermissions.LEAVE_THREAD
Test Plan: Check if server throws error on threads with no leave_thread permission and doesn't on those which have it
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -226,12 +226,17 @@ async function leaveThread(\nthrow new ServerError('not_logged_in');\n}\n- const fetchThreadResult = await fetchThreadInfos(\n+ const ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Check threadPermissions.LEAVE_THREAD
Test Plan: Check if server throws error on threads with no leave_thread permission and doesn't on those which have it
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D455 |
129,183 | 02.12.2020 09:31:30 | -3,600 | acbf1b483a7abb3c3622f8747e333e317d4482c7 | [server] Extract updateAllThreadPermissions and rename to recalculateAllThreadPermissions
Summary: Extracted function to reuse in D466
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-sidebar-permissions.js",
"new_path": "server/src/scripts/create-sidebar-permissions.js",
"diff": "import {\nthreadPermissions,\nthreadPermissionPrefixes,\n- assertThreadType,\n} from 'lib/types/thread-types';\n-import bots from 'lib/f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Extract updateAllThreadPermissions and rename to recalculateAllThreadPermissions
Summary: Extracted function to reuse in D466
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D468 |
129,183 | 03.12.2020 12:08:09 | -3,600 | 8c7628f84442c9d74ec84cf420af23a0e60ae00b | [native] Use hook instead of connect functions and HOC in ColorPickerModal
Test Plan: Flow
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/color-picker-modal.react.js",
"new_path": "native/chat/settings/color-picker-modal.react.js",
"diff": "@@ -6,28 +6,24 @@ import {\n} from 'lib/actions/thread-actions';\nimport {\ntype ThreadInfo,\n- threadInfoPropType,\ntype ChangeThreadSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ColorPickerModal
Test Plan: Flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D473 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.