author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,200 | 24.06.2022 09:21:56 | 14,400 | fe72ec70f739b77c8aecccd2efefd74a6f87af7f | [services][identity] helper function to finish PAKE login
Summary:
helper function completes PAKE login and returns an access token or an error depending on the outcome
depends on D4350
Test Plan: tested with method that calls this helper
Reviewers: palys-swm, jimpo, karol-bisztyga
Subscribers: ashoat, Adrian, atul, ya... | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/service.rs",
"new_path": "services/identity/src/service.rs",
"diff": "@@ -44,6 +44,7 @@ mod proto {\ntonic::include_proto!(\"identity\");\n}\n+#[derive(Debug)]\nenum PakeWorkflow {\nRegistration,\nLogin,\n@@ -360,3 +361,56 @@ async fn pak... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] helper function to finish PAKE login
Summary:
helper function completes PAKE login and returns an access token or an error depending on the outcome
depends on D4350
Test Plan: tested with method that calls this helper
Reviewers: palys-swm, jimpo, karol-bisztyga
Reviewed By: palys-swm
Subscrib... |
129,184 | 28.06.2022 22:28:40 | 25,200 | 7cac0c47e3521f8c8ad424d1cccef57b25a98e46 | [native] `codeVersion` -> 136 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 136 |
129,200 | 28.06.2022 14:17:54 | 14,400 | 3cecc94df5c13c99226e9dd20b2a87f036141cea | [services] refactor some if let statements to reduce nesting
Summary: pretty straightforward refactor. resolves : Refactor `if let` error handling](https://linear.app/comm/issue/ENG-1305/refactor-if-let-error-handling)
Test Plan: cargo build
Reviewers: palys-swm, karol-bisztyga, jimpo
Subscribers: ashoat, Adrian, atul,... | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/service.rs",
"new_path": "services/identity/src/service.rs",
"diff": "@@ -94,26 +94,19 @@ impl IdentityService for MyIdentityService {\npake_registration_request_and_user_id,\n)),\n}) => {\n- if let Err(e) = tx\n- .send(\n- pake_registrat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] refactor some if let statements to reduce nesting
Summary: pretty straightforward refactor. resolves [ENG-1305 : Refactor `if let` error handling](https://linear.app/comm/issue/ENG-1305/refactor-if-let-error-handling)
Test Plan: cargo build
Reviewers: palys-swm, karol-bisztyga, jimpo
Reviewed By: palys-s... |
129,184 | 27.06.2022 17:18:17 | 25,200 | 3ceabb267af8317c7b289779d461f2fb97c806cd | [services] Remove `build-[blob/backup]-base` from `services/package.json`
Summary: We no longer have a base image for blob/backup base. These commands are no longer relevant.
Test Plan: NA, searched codebase
Reviewers: def-au1t, palys-swm, yayabosh, karol-bisztyga
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"test-tunnelbroker-service\": \"./scripts/test_service.sh tunnelbroker\",\n\"run-tunnelbroker-service-dev-mode\": \"COMM_SERVICES_DEV_MODE=1 ./scripts/run_server_image.sh tunnelbroker\",\n\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Remove `build-[blob/backup]-base` from `services/package.json`
Summary: We no longer have a base image for blob/backup base. These commands are no longer relevant.
Test Plan: NA, searched codebase
Reviewers: def-au1t, palys-swm, yayabosh, karol-bisztyga
Reviewed By: palys-swm, yayabosh, karol-bisztyga
S... |
129,203 | 29.06.2022 10:23:34 | 14,400 | aabc6d1d8ca35bf82162ea06827864e28eeaf85d | [keyserver] Delete `backup-phabricator.sh`
Summary: Deletes `backup-phabricator.sh`, per comment on Linear [[ | here ]].
Test Plan: I no longer see the file
Reviewers: ashoat, atul
Subscribers: palys-swm, Adrian, ashoat | [
{
"change_type": "DELETE",
"old_path": "keyserver/bash/backup-phabricator.sh",
"new_path": null,
"diff": "-#!/usr/bin/env bash\n-\n-# run as: ssh user on root wheel\n-# run from: wherever\n-\n-# The path to Phabricator on our server\n-PHABRICATOR_PATH=/var/www/phacility/phabricator\n-\n-# The path t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Delete `backup-phabricator.sh`
Summary: Deletes `backup-phabricator.sh`, per @ashoat's comment on Linear [[ https://linear.app/comm/issue/ENG-1295#comment-6c323c7f | here ]].
Test Plan: I no longer see the file
Reviewers: ashoat, atul
Reviewed By: ashoat, atul
Subscribers: palys-swm, Adrian, ashoat
Di... |
129,203 | 29.06.2022 11:08:00 | 14,400 | 69b13a14348dbdf7d68129a168ad366fb204bf2e | [services] Clean up `run_server_image.sh`
Summary: Cleaned up `run_server_image.sh` with style fixes and some double quoting to safely prevent globbing and word splitting. More details in inline comments.
Test Plan: [[ | ShellCheck ]], close reading.
Reviewers: ashoat, karol-bisztyga, atul
Subscribers: palys-swm, Adria... | [
{
"change_type": "MODIFY",
"old_path": "services/scripts/run_server_image.sh",
"new_path": "services/scripts/run_server_image.sh",
"diff": "set -e\nif [ \"$#\" -lt 1 ] || [ \"$#\" -gt 2 ]; then\n- echo \"Illegal number of parameters, expected:\"\n+ echo \"Illegal number of arguments, expected 2:\"\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Clean up `run_server_image.sh`
Summary: Cleaned up `run_server_image.sh` with style fixes and some double quoting to safely prevent globbing and word splitting. More details in inline comments.
Test Plan: [[ https://www.shellcheck.net/ | ShellCheck ]], close reading.
Reviewers: ashoat, karol-bisztyga, atu... |
129,203 | 29.06.2022 16:36:00 | 14,400 | c8c20687c78e99f4f46b3d9657f2024390bbf446 | [services] Use `[[ ]]` instead of `[ ]` in `run_server_image.sh`
Had a git issue, this addresses | [
{
"change_type": "MODIFY",
"old_path": "services/scripts/run_server_image.sh",
"new_path": "services/scripts/run_server_image.sh",
"diff": "set -e\n-if [ \"$#\" -lt 1 ] || [ \"$#\" -gt 2 ]; then\n+if [[ \"$#\" -lt 1 ]] || [[ \"$#\" -gt 2 ]]; then\necho \"Illegal number of arguments, expected 2:\"\ne... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Use `[[ ]]` instead of `[ ]` in `run_server_image.sh`
Had a git issue, this addresses https://phab.comm.dev/D4398?vs=on&id=13979#124507. |
129,184 | 29.06.2022 11:46:53 | 25,200 | eb3734aa442fd7dd455b67f675ffe9b47403559b | [CI] Update `eslint_flow_jest` pipeline to enable autoscaling
Summary: Run this workflow within `node:16.13-bullseye` container to enable autoscaling.
Test Plan: Buildkite CI
Reviewers: def-au1t, palys-swm, yayabosh
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/eslint_flow_jest.yml",
"new_path": ".buildkite/eslint_flow_jest.yml",
"diff": "@@ -4,5 +4,10 @@ steps:\n- 'yarn cleaninstall --frozen-lockfile --skip-optional'\n- 'yarn eslint --max-warnings=0 & yarn workspace lib flow & yarn workspace web flow & ya... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Update `eslint_flow_jest` pipeline to enable autoscaling
Summary: Run this workflow within `node:16.13-bullseye` container to enable autoscaling.
Test Plan: Buildkite CI
Reviewers: def-au1t, palys-swm, yayabosh
Reviewed By: palys-swm
Subscribers: ashoat, Adrian
Differential Revision: https://phab.comm.dev/D4... |
129,184 | 29.06.2022 14:24:35 | 25,200 | 4eb65acee8da19d21f288420c9fe745ae11331df | [CI] Update `android` pipeline to enable autoscaling
Summary: Run this workflow within `reactnativecommunity/react-native-android:latest` to enable autoscaling.
Test Plan: Buildkite CI
Reviewers: def-au1t, palys-swm, yayabosh, geekbrother, ashoat
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/android.yml",
"new_path": ".buildkite/android.yml",
"diff": "@@ -3,5 +3,10 @@ steps:\n- 'yarn cleaninstall --frozen-lockfile --skip-optional'\n- 'cd native/android'\n- './gradlew bundleRelease --no-daemon \"-Dorg.gradle.jvmargs=-Xmx32g -XX:MaxPermSi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Update `android` pipeline to enable autoscaling
Summary: Run this workflow within `reactnativecommunity/react-native-android:latest` to enable autoscaling.
Test Plan: Buildkite CI
Reviewers: def-au1t, palys-swm, yayabosh, geekbrother, ashoat
Reviewed By: ashoat
Subscribers: ashoat, Adrian
Differential Revisi... |
129,184 | 29.06.2022 14:28:50 | 25,200 | 8eb4dabef91cc7bef079df4f4954596f336e9c2a | [CI] Deprecate `services` workflow on Buildkite/GH Actions
Summary: We gave each service their own workflow to enable higher concurrency with autoscaling instances. As a result, the `services` workflow is now redundant/unnecessary and can be removed.
Test Plan: NA
Reviewers: def-au1t, palys-swm, yayabosh
Subscribers: a... | [
{
"change_type": "DELETE",
"old_path": ".buildkite/services.yml",
"new_path": null,
"diff": "-steps:\n- - command:\n- - 'yarn cleaninstall --frozen-lockfile --skip-optional'\n- - 'cd services && yarn build-all'\n- agents:\n- - 'docker=true'\n"
},
{
"change_type": "DELETE",
"old_path": ".... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Deprecate `services` workflow on Buildkite/GH Actions
Summary: We gave each service their own workflow to enable higher concurrency with autoscaling instances. As a result, the `services` workflow is now redundant/unnecessary and can be removed.
Test Plan: NA
Reviewers: def-au1t, palys-swm, yayabosh
Reviewed B... |
129,196 | 17.05.2022 16:16:29 | -7,200 | 19b5044030075503fd840b3134ad54e9d4357b37 | Implement JNI files to use MessageOperationUtilities in CommNotificationsHandler on Android
Summary: Implement JNI files to use MessageOperationsUtilities functionality on Android in CommNotificationHandler.java
Test Plan: No test plan. Child differential will use those changes and thus will provide opportunities for t... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/cpp/MessageOperationsUtilitiesJNIHelper.cpp",
"diff": "+#include \"MessageOperationsUtilitiesJNIHelper.h\"\n+#include \"MessageOperationsUtilities.h\"\n+#include \"SQLiteQueryExecutor.h\"\n+\n+namespace comm {\n+void Messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement JNI files to use MessageOperationUtilities in CommNotificationsHandler on Android
Summary: Implement JNI files to use MessageOperationsUtilities functionality on Android in CommNotificationHandler.java
Test Plan: No test plan. Child differential will use those changes and thus will provide opportunities for... |
129,200 | 01.07.2022 17:47:11 | 14,400 | 981190b71bb26f6c7ab8015b3f2fa7ad34995422 | [services] add new DB error types
Summary: These new types will help us be more precise with our error handling
Test Plan: cargo build
Reviewers: palys-swm, jimpo, karol-bisztyga
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/database.rs",
"new_path": "services/identity/src/database.rs",
"diff": "use std::collections::HashMap;\n+use std::fmt::{Display, Formatter, Result as FmtResult};\nuse bytes::Bytes;\nuse chrono::{DateTime, ParseError, Utc};\n@@ -258,6 +259... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] add new DB error types
Summary: These new types will help us be more precise with our error handling
Test Plan: cargo build
Reviewers: palys-swm, jimpo, karol-bisztyga
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, atul, yayabosh
Differential Revision: https://phab.comm.dev/D4427 |
129,203 | 30.06.2022 17:00:25 | 14,400 | 1209c4709b296ee945853bc12ee9660ba7affc0a | [keyserver] Use `[[ ]]` instead of `[ ]` in `source-nvm.sh`
Summary:
Relevant Linear issue [[ | here ]]. Replaced `[ ]` with `[[ ]]` in `source-nvm.sh`.
Depends on D4429
Test Plan: N/A
Reviewers: ashoat, atul
Subscribers: palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "keyserver/bash/source-nvm.sh",
"new_path": "keyserver/bash/source-nvm.sh",
"diff": "unset PREFIX\n# Nix controls the version of node within the development shell\n-[ -n \"$IN_NIX_SHELL\" ] && exit 0\n+[[ -n \"$IN_NIX_SHELL\" ]] && exit 0\n# Intel Mac\n-[ -s \"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Use `[[ ]]` instead of `[ ]` in `source-nvm.sh`
Summary:
Relevant Linear issue [[ https://linear.app/comm/issue/ENG-157/make-brackets-consistent-in-bash-scripts-in-services | here ]]. Replaced `[ ]` with `[[ ]]` in `source-nvm.sh`.
Depends on D4429
Test Plan: N/A
Reviewers: ashoat, atul
Reviewed By: as... |
129,203 | 05.07.2022 14:58:29 | 14,400 | 23c50285a0c1ab8fd3ad293293f119764e4c3023 | [services] Clean up `run_all_services.sh`
Summary: Relevant Linear issue [[ | here ]]. Added double quotes to prevent word-splitting or globbing in `run_all_services.sh`.
Test Plan: [[ | ShellCheck ]], close reading.
Reviewers: ashoat, atul, palys-swm
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "services/scripts/run_all_services.sh",
"new_path": "services/scripts/run_all_services.sh",
"diff": "set -e\n-SERVICES_LIST=`./scripts/list_services.sh`\n+SERVICES_LIST=$(./scripts/list_services.sh)\nSERVICES=\"\"\nfor SERVICE in $SERVICES_LIST; do\nSERVICES=\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Clean up `run_all_services.sh`
Summary: Relevant Linear issue [[ https://linear.app/comm/issue/ENG-1295/clean-up-shell-scripts-in-codebase | here ]]. Added double quotes to prevent word-splitting or globbing in `run_all_services.sh`.
Test Plan: [[ https://www.shellcheck.net/ | ShellCheck ]], close reading.... |
129,203 | 05.07.2022 15:07:17 | 14,400 | 78751dfb13340ea1409c72af1e83839b12a298a3 | [services] Clean up `test_all_services.sh`
Summary: Relevant Linear issue [[ | here ]]. Used `$(...)` syntax instead of legacy backticks `...`
Test Plan: [[ | ShellCheck ]], close reading
Reviewers: ashoat, atul, palys-swm
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "services/scripts/test_all_services.sh",
"new_path": "services/scripts/test_all_services.sh",
"diff": "set -e\n-SERVICES=`./scripts/list_services.sh`\n+SERVICES=$(./scripts/list_services.sh)\nfor SERVICE in $SERVICES; do\n- ./scripts/test_service.sh $SERVICE\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Clean up `test_all_services.sh`
Summary: Relevant Linear issue [[ https://linear.app/comm/issue/ENG-1295/clean-up-shell-scripts-in-codebase | here ]]. Used `$(...)` syntax instead of legacy backticks `...`
Test Plan: [[ https://www.shellcheck.net/ | ShellCheck ]], close reading
Reviewers: ashoat, atul, pa... |
129,203 | 05.07.2022 15:01:38 | 14,400 | 6c4bb54796f1e69abd057b9b944d5116a7d8da80 | [services] Clean up `test_service.sh`
Summary: Relevant Linear issue [[ | here ]]. More details in inline comments below.
Test Plan: [[ | ShellCheck ]], close reading.
Reviewers: ashoat, atul, palys-swm
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "services/scripts/test_service.sh",
"new_path": "services/scripts/test_service.sh",
"diff": "set -e\n-SERVICES=`./scripts/list_services.sh`\n-SERVICE=`echo \"$SERVICES\" | grep $1` || echo \"No such service: $1\"\n+SERVICES=$(./scripts/list_services.sh)\n+SERVI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Clean up `test_service.sh`
Summary: Relevant Linear issue [[ https://linear.app/comm/issue/ENG-1295/clean-up-shell-scripts-in-codebase | here ]]. More details in inline comments below.
Test Plan: [[ https://www.shellcheck.net/ | ShellCheck ]], close reading.
Reviewers: ashoat, atul, palys-swm
Reviewed By... |
129,203 | 07.07.2022 11:39:57 | 14,400 | 8dd41c6dc66be20464bf23cdd53b3b5631967f28 | [native] Clean up `detect_abis.sh`
Summary: Relevant Linear issue [[ | here ]]. More details in inline comments.
Test Plan: [[ | ShellCheck ]], close reading.
Reviewers: ashoat, atul, karol-bisztyga
Subscribers: palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/bash/detect_abis.sh",
"new_path": "native/android/app/bash/detect_abis.sh",
"diff": "@@ -7,7 +7,7 @@ ABIS=()\nfor ID in ${IDS}\ndo\n- ABI=\"$(adb -s $ID shell getprop ro.product.cpu.abi)\"\n+ ABI=$(adb -s \"$ID\" shell getprop ro.product.cpu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clean up `detect_abis.sh`
Summary: Relevant Linear issue [[ https://linear.app/comm/issue/ENG-1295/clean-up-shell-scripts-in-codebase | here ]]. More details in inline comments.
Test Plan: [[ https://www.shellcheck.net/ | ShellCheck ]], close reading.
Reviewers: ashoat, atul, karol-bisztyga
Reviewed By: at... |
129,190 | 30.06.2022 15:33:57 | -7,200 | d2dfb7c29002cc414d5f999e8e9ec829d69faf2b | [services] Tests - Add chunk limit to tools
Summary:
Depends on D4247
Adding an equivalent to `GRPC_CHUNK_SIZE_LIMIT`
Test Plan: none really
Reviewers: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/lib/tools.rs",
"new_path": "services/commtest/tests/lib/tools.rs",
"diff": "@@ -18,5 +18,12 @@ pub enum Error {\nTonicStatus(tonic::Status),\n}\n+pub const GRPC_METADATA_SIZE_BYTES: usize = 5;\n+\n+#[allow(dead_code)]\n+pub fn get_grpc_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Add chunk limit to tools
Summary:
Depends on D4247
Adding an equivalent to `GRPC_CHUNK_SIZE_LIMIT` - https://github.com/CommE2E/comm/blob/7e9032d9732db37fadbc2761ccfa3baac5875b2d/services/lib/src/GlobalConstants.h#L20
Test Plan: none really
Reviewers: palys-swm, varun
Reviewed By: palys-swm, var... |
129,190 | 30.06.2022 15:33:59 | -7,200 | 3871d95d9e367b82e4a9d1689858be119f6078e4 | [services] Tests - Update packages
Summary:
Depends on D4248
I updated the list of packages necessary for the tests to run.
Test Plan: `cd services/commtest && COMM_TEST_TARGET=backup cargo build`
Reviewers: palys-swm, varun, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/Cargo.lock",
"new_path": "services/commtest/Cargo.lock",
"diff": "@@ -17,12 +17,50 @@ version = \"1.0.45\"\nsource = \"registry+https://github.com/rust-lang/crates.io-index\"\nchecksum = \"ee10e43ae4a853c0a3591d4e2ada1719e553be18199d9da9d4a83... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Update packages
Summary:
Depends on D4248
I updated the list of packages necessary for the tests to run.
Test Plan: `cd services/commtest && COMM_TEST_TARGET=backup cargo build`
Reviewers: palys-swm, varun, ashoat
Reviewed By: varun, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh... |
129,190 | 30.06.2022 15:34:21 | -7,200 | 8810a366fdc6f8bec147e3ff675abd793bd3dd6d | [services] Tests - Blob - Add Put
Summary:
Depends on D4273
Adding `Put` method to blob's tests.
Test Plan: For now, this method's not invoked. The Rust project should build normally.
Reviewers: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/commtest/tests/blob/put.rs",
"diff": "+#[path = \"./blob_utils.rs\"]\n+mod blob_utils;\n+#[path = \"../lib/tools.rs\"]\n+mod tools;\n+\n+use crate::blob_utils::{\n+ proto::put_request::Data::*, proto::PutRequest, BlobData, BlobServiceCl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Blob - Add Put
Summary:
Depends on D4273
Adding `Put` method to blob's tests.
Test Plan: For now, this method's not invoked. The Rust project should build normally.
Reviewers: palys-swm, varun
Reviewed By: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential Rev... |
129,190 | 30.06.2022 15:34:23 | -7,200 | 23ee43573ca07792eafb30eb3bf36738e4e700d7 | [services] Tests - Blob - Add Get
Summary:
Depends on D4274
Adding `Get` method to blob's tests.
Test Plan: For now, this method's not invoked. The Rust project should build normally.
Reviewers: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/commtest/tests/blob/get.rs",
"diff": "+#[path = \"./blob_utils.rs\"]\n+mod blob_utils;\n+#[path = \"../lib/tools.rs\"]\n+mod tools;\n+\n+use tonic::Request;\n+\n+use crate::blob_utils::{proto::GetRequest, BlobData, BlobServiceClient};\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Blob - Add Get
Summary:
Depends on D4274
Adding `Get` method to blob's tests.
Test Plan: For now, this method's not invoked. The Rust project should build normally.
Reviewers: palys-swm, varun
Reviewed By: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differential Rev... |
129,190 | 30.06.2022 15:34:25 | -7,200 | 02caf33e16fee91321236bfd70ee11de8447b876 | [services] Tests - Blob - Add Remove
Summary:
Depends on D4275
Adding `Remove` method to blob's tests.
Test Plan: For now, this method's not invoked. The Rust project should build normally.
Reviewers: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/commtest/tests/blob/remove.rs",
"diff": "+#[path = \"./blob_utils.rs\"]\n+mod blob_utils;\n+#[path = \"../lib/tools.rs\"]\n+mod tools;\n+\n+use tonic::Request;\n+\n+use crate::blob_utils::{proto::RemoveRequest, BlobData, BlobServiceClie... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Blob - Add Remove
Summary:
Depends on D4275
Adding `Remove` method to blob's tests.
Test Plan: For now, this method's not invoked. The Rust project should build normally.
Reviewers: palys-swm, varun
Reviewed By: palys-swm, varun
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh
Differenti... |
129,190 | 30.06.2022 15:34:37 | -7,200 | cc745f3bbc81e12129ae8578701cf36d8b1b7d7b | [services] Backup - Send Log - Check the real item size
Summary:
Depends on D4411
Test Plan: Services build, for now this went out of sync with the integration tests
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Reactors/server/SendLogReactor.cpp",
"new_path": "services/backup/src/Reactors/server/SendLogReactor.cpp",
"diff": "@@ -20,6 +20,13 @@ void SendLogReactor::storeInDatabase() {\nstoredInBlob ? this->blobHolder : this->value,\n{},\nthis->hash... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Send Log - Check the real item size
Summary:
Depends on D4411
https://linear.app/comm/issue/ENG-1288/properly-handle-the-dynamodb-item-size-limit
Test Plan: Services build, for now this went out of sync with the integration tests
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat,... |
129,190 | 30.06.2022 16:08:14 | -7,200 | 68aa78321a3ce0837f0f96fef725e5b25e711f1b | [services] Tests - run cargo fmt
Summary:
Depends on D4379
Something's wrong, `cargo fmt` should be fired up in git pre commit hooks, this should be fixed.
Test Plan: -
Reviewers: varun, ashoat
Subscribers: varun, ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup/add_attachments.rs",
"new_path": "services/commtest/tests/backup/add_attachments.rs",
"diff": "@@ -24,11 +24,11 @@ pub async fn run(\nlet log_id = backup_data.log_items[index].id.clone();\nprintln!(\"add attachments for log {}/{}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - run cargo fmt
Summary:
Depends on D4379
Something's wrong, `cargo fmt` should be fired up in git pre commit hooks, this should be fixed.
Test Plan: -
Reviewers: varun, ashoat
Reviewed By: varun, ashoat
Subscribers: varun, ashoat, palys-swm, Adrian, atul, yayabosh
Differential Revision: https://... |
129,190 | 05.07.2022 09:10:30 | -7,200 | 35a55850500012c6252663f297bbbf051b5cb5bb | [services] Add reset local cloud command
Summary:
Depends on D4425
Adding a reset command to the services' package.json so it is easier to reset the local cloud.
Test Plan:
```
cd services
yarn reset-local-cloud
```
Reviewers: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"run-integration-tests\": \"./scripts/run_integration_tests.sh\",\n\"run-all-services-in-sandbox\": \"COMM_SERVICES_SANDBOX=1 ./scripts/run_all_services.sh\",\n\"init-local-cloud\": \"./scr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add reset local cloud command
Summary:
Depends on D4425
Adding a reset command to the services' package.json so it is easier to reset the local cloud.
Test Plan:
```
cd services
yarn reset-local-cloud
```
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, yayabosh... |
129,203 | 08.07.2022 10:20:00 | 14,400 | 7cac76eb32619adeffa18c2ee52ba61b5b596d07 | [keyserver] Delete `deploy.sh`
Summary: See [[ | comment ]] on D4477. This diff removes `deploy.sh` since we don't use it anymore and instead use Docker in production.
Test Plan: N/A
Reviewers: ashoat, atul
Subscribers: palys-swm, Adrian, ashoat | [
{
"change_type": "DELETE",
"old_path": "keyserver/bash/deploy.sh",
"new_path": null,
"diff": "-#!/usr/bin/env bash\n-\n-# run as: ssh user on root wheel\n-# run from: wherever\n-# param: path to link to\n-\n-# The maximum amount of space to spend on checkouts. By default we leave around\n-# old depl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Delete `deploy.sh`
Summary: See @ashoat's [[ https://phab.comm.dev/D4477#127356 | comment ]] on D4477. This diff removes `deploy.sh` since we don't use it anymore and instead use Docker in production.
Test Plan: N/A
Reviewers: ashoat, atul
Reviewed By: ashoat, atul
Subscribers: palys-swm, Adrian, asho... |
129,203 | 08.07.2022 16:00:47 | 14,400 | d9e99fc9e2b3ef05b6ded5dc6423f2486d9d35fe | [CI] Add emojis to Buildkite pipelines
Summary:
Super quick change that adds a `label` to each Buildkite pipeline's YAML file.
You can see the emojis here:
Test Plan: Ran builds in Buildkite and saw emojis.
Reviewers: atul, palys-swm
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/android.yml",
"new_path": ".buildkite/android.yml",
"diff": "steps:\n- - command:\n+ - label: \":robot_face: Android Build\"\n+ command:\n- 'yarn cleaninstall --frozen-lockfile --skip-optional'\n- 'cd native/android'\n- './gradlew bundleRelease --no... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Add emojis to Buildkite pipelines
Summary:
Super quick change that adds a `label` to each Buildkite pipeline's YAML file.
You can see the emojis here: https://github.com/buildkite/emojis
Test Plan: Ran builds in Buildkite and saw emojis.
Reviewers: atul, palys-swm
Reviewed By: atul
Subscribers: ashoat, Adria... |
129,193 | 07.07.2022 08:40:31 | 25,200 | 331bc7da607ffa699bf3cef6f4eefed57fcdff6f | [Nix] Add cocoapods for ios build
Summary: Add cocoapods to allow for pod installs
Test Plan:
Install XCode
```
nix develop
cd native/ios && pod install && xcodebuild -workspace Comm.xcworkspace -scheme Comm -destination generic/platform=iOS -allowProvisioningUpdates
```
Reviewers: atul, ashoat, varun, marcinwasowicz
S... | [
{
"change_type": "MODIFY",
"old_path": "nix/dev-shell.nix",
"new_path": "nix/dev-shell.nix",
"diff": ", boost\n, cargo\n, cmake\n+, cocoapods\n, cryptopp\n, darwin\n, folly\n@@ -52,7 +53,8 @@ mkShell {\npkg-config\nprotobuf_3_15_cmake\ngrpc\n-\n+ ] ++ lib.optionals stdenv.isDarwin [\n+ cocoapods # n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [Nix] Add cocoapods for ios build
Summary: Add cocoapods to allow for pod installs
Test Plan:
Install XCode
```
nix develop
cd native/ios && pod install && xcodebuild -workspace Comm.xcworkspace -scheme Comm -destination generic/platform=iOS -allowProvisioningUpdates
```
Reviewers: atul, ashoat, varun, marcinwasowic... |
129,203 | 12.07.2022 14:16:22 | 14,400 | 82db148f42fa113bf2849b70b59e5b401ca28fc9 | [native] Merge conditionals in `InputStateContainer`
Summary: Minor change which merges conditional logic in `InputStateContainer` since the code in each block is the exact same.
Test Plan: Flow, close reading.
Reviewers: atul, palys-swm, def-au1t
Subscribers: ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -495,25 +495,11 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nfor (const selection of selections) {\nconst localMed... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Merge conditionals in `InputStateContainer`
Summary: Minor change which merges conditional logic in `InputStateContainer` since the code in each block is the exact same.
Test Plan: Flow, close reading.
Reviewers: atul, palys-swm, def-au1t
Reviewed By: atul
Subscribers: ashoat, Adrian
Differential Revisio... |
129,196 | 28.06.2022 14:57:50 | -7,200 | 99894c91276b820177d8ad06746e097c4c22537f | Implement encryption-decryption layer for elementary file operations
Summary: Implements encryption-decryption layer for flat-file message store operations.
Test Plan: Modify AppDelegate so that on AppLaunch it encrypts and decrypts some text then assert they are equal.
Reviewers: palys-swm, varun, karol-bisztyga
Subsc... | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/TemporaryMessageStorage/EncryptedFileUtils.mm",
"new_path": "native/ios/Comm/TemporaryMessageStorage/EncryptedFileUtils.mm",
"diff": "+ (NSData *)_encryptData:(NSString *)data error:(NSError **)error;\n+ (NSString *)_decryptData:(NSString *)dat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement encryption-decryption layer for elementary file operations
Summary: Implements encryption-decryption layer for flat-file message store operations.
Test Plan: Modify AppDelegate so that on AppLaunch it encrypts and decrypts some text then assert they are equal.
Reviewers: palys-swm, varun, karol-bisztyga
R... |
129,200 | 13.07.2022 14:29:30 | 14,400 | d6ac92d9804dfa25ef1bc0d24712e156ed7d52eb | [docs] add Terraform installation instructions
Summary: We should have Terraform installation instructions in the dev_services.md doc since we use Terraform scripts in our local cloud.
Test Plan: followed these instructions to install Terraform
Reviewers: yayabosh, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "docs/dev_services.md",
"new_path": "docs/dev_services.md",
"diff": "@@ -20,6 +20,10 @@ Some of our services access AWS resources via the AWS C++ SDK. To access these r\nWe recommend running `aws configure`, which will prompt you for the necessary configuration... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] add Terraform installation instructions
Summary: We should have Terraform installation instructions in the dev_services.md doc since we use Terraform scripts in our local cloud.
Test Plan: followed these instructions to install Terraform
Reviewers: yayabosh, ashoat
Reviewed By: yayabosh, ashoat
Subscribers:... |
129,201 | 07.07.2022 13:53:16 | -7,200 | 8c0a660c8382ce39663268604a54d95c0166b913 | [services] Tunnelbroker - Tests for `validateUUIDv4` function
Summary: This diff introduces tests for a `validateUUIDv4` function from D4467 which validate generated UUIDs.
Test Plan: Expected test results on run `yarn test-tunnelbroker-service-in-sandbox`.
Reviewers: karol-bisztyga, palys-swm
Subscribers: ashoat, paly... | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/test/ToolsTest.cpp",
"new_path": "services/tunnelbroker/test/ToolsTest.cpp",
"diff": "@@ -34,6 +34,31 @@ TEST(ToolsTest, ValidateDeviceIDReturnsTrueOnGeneratedValidDeviceID) {\n<< \"\\\" is invalid by the function\";\n}\n+TEST(ToolsTest, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tunnelbroker - Tests for `validateUUIDv4` function
Summary: This diff introduces tests for a `validateUUIDv4` function from D4467 which validate generated UUIDs.
Test Plan: Expected test results on run `yarn test-tunnelbroker-service-in-sandbox`.
Reviewers: karol-bisztyga, palys-swm
Reviewed By: karol-bi... |
129,187 | 13.07.2022 10:05:22 | 14,400 | e42b5ff5959467bb5387c724e3f0bdcb788289f4 | [keyserver] Rename COMM_MYSQL env variables to COMM_DATABASE
Summary: See feedback [here](https://phab.comm.dev/D4499?id=14398#inline-28206).
Test Plan: I `git grep` for each variable name to make sure the spelling was correct, and I made sure the number of results matched my expectations
Reviewers: jonringer-comm, atu... | [
{
"change_type": "MODIFY",
"old_path": "keyserver/docker-compose.yml",
"new_path": "keyserver/docker-compose.yml",
"diff": "@@ -16,10 +16,10 @@ services:\nenvironment:\n- REDIS_URL=redis://cache\n- COMM_LISTEN_ADDR=0.0.0.0\n- - COMM_MYSQL_HOST=${COMM_MYSQL_HOST:-database}\n- - COMM_MYSQL_DATABASE\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Rename COMM_MYSQL env variables to COMM_DATABASE
Summary: See feedback [here](https://phab.comm.dev/D4499?id=14398#inline-28206).
Test Plan: I `git grep` for each variable name to make sure the spelling was correct, and I made sure the number of results matched my expectations
Reviewers: jonringer-comm, ... |
129,187 | 13.07.2022 11:39:52 | 14,400 | e2cb36c1a0d9a9a1f6373b6739c1c3b9da34e564 | [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB
Summary: Depends on D4516
Test Plan: Tested in combination with next diffs
Reviewers: jonringer-comm, atul, palys-swm
Subscribers: Adrian, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/database/db-config.js",
"new_path": "keyserver/src/database/db-config.js",
"diff": "@@ -4,12 +4,13 @@ import invariant from 'invariant';\nimport { importJSON } from '../utils/import-json';\n+type DBType = 'mysql5.7' | 'mariadb10.8';\nexport type ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Introduce getDBType function to distinguish MySQL and MariaDB
Summary: Depends on D4516
Test Plan: Tested in combination with next diffs
Reviewers: jonringer-comm, atul, palys-swm
Reviewed By: atul
Subscribers: Adrian, yayabosh
Differential Revision: https://phab.comm.dev/D4518 |
129,182 | 19.07.2022 12:22:16 | -7,200 | 40369c86934fff534bdfacdf765abf1973b28c1a | [lib,keyserver] Rename thread to chat
Summary:
Linear issue:
Diff renames thread to chat in all strings displayed to the user in keyserver and lib
Test Plan: Checked if strings changed as expected in web or mobile.
Reviewers: palys-swm, ashoat, def-au1t
Subscribers: Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/creators/thread-creator.js",
"new_path": "keyserver/src/creators/thread-creator.js",
"diff": "@@ -52,7 +52,7 @@ import type { UpdatesForCurrentSession } from './update-creator';\nconst { commbot } = bots;\nconst privateThreadDescription: string =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib,keyserver] Rename thread to chat
Summary:
Linear issue: https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in keyserver and lib
Test Plan: Checked if strings changed as expected in web or mobile.
Reviewers: palys-swm, ... |
129,182 | 19.07.2022 12:22:16 | -7,200 | 9e4270d1e5260e848dd41c0729aff7249e6f82c9 | [native] Rename thread to chat
Summary:
Linear issue:
Diff renames thread to chat in all strings displayed to the user in native
Test Plan: Checked if strings changed as expected in web or mobile.
Reviewers: palys-swm, ashoat, def-au1t
Subscribers: Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -428,7 +428,7 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nname=\"plus\"\nstyle={this.props.styles.joinButtonText}\n/>\n- <Text style={th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename thread to chat
Summary:
Linear issue:
https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in native
Test Plan: Checked if strings changed as expected in web or mobile.
Reviewers: palys-swm, ashoat, def-au1t
... |
129,182 | 19.07.2022 12:22:16 | -7,200 | 4c883c8ccb46d9ce91e32ec5caa563690c8e9bc9 | [web] Rename thread to chat
Summary:
Linear issue:
Diff renames thread to chat in all strings displayed to the user in web
Test Plan: Checked if strings changed as expected in web.
Reviewers: palys-swm, ashoat, def-au1t, yayabosh
Subscribers: Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/filter-panel.react.js",
"new_path": "web/calendar/filter-panel.react.js",
"diff": "@@ -326,9 +326,7 @@ class Category extends React.PureComponent<CategoryProps> {\n}\nconst icon = this.props.collapsed ? faChevronUp : faChevronDown;\nconst details ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename thread to chat
Summary:
Linear issue:
https://linear.app/comm/issue/ENG-1357/rename-sidebar-to-thread-in-product-copy
Diff renames thread to chat in all strings displayed to the user in web
Test Plan: Checked if strings changed as expected in web.
Reviewers: palys-swm, ashoat, def-au1t, yayabosh
Review... |
129,200 | 13.07.2022 14:41:27 | 14,400 | 6912b58e7f20541fe7fbead79fac54c2dec4639a | [services] add dynamodb tables for identity service to terraform
Summary: These tables already exist in DynamoDB but they should still be added here so we can manage them with Terraform.
Test Plan: ran `terraform validate`
Reviewers: geekbrother, palys-swm, karol-bisztyga
Subscribers: ashoat, Adrian, atul, yayabosh | [
{
"change_type": "MODIFY",
"old_path": "services/terraform/dynamodb.tf",
"new_path": "services/terraform/dynamodb.tf",
"diff": "@@ -161,3 +161,33 @@ resource \"aws_dynamodb_table\" \"tunnelbroker-messages\" {\nenabled = true\n}\n}\n+\n+resource \"aws_dynamodb_table\" \"identity-users\" {\n+ name = \... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] add dynamodb tables for identity service to terraform
Summary: These tables already exist in DynamoDB but they should still be added here so we can manage them with Terraform.
Test Plan: ran `terraform validate`
Reviewers: geekbrother, palys-swm, karol-bisztyga
Reviewed By: geekbrother, palys-swm
Subscr... |
129,184 | 19.07.2022 15:17:04 | 14,400 | b35ec303de6cf4dcc79c55491212cf96c9cd65d9 | [native] `codeVersion` -> 137 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 137 |
129,190 | 21.07.2022 15:03:20 | -7,200 | 04748179453f85243d8b88d9e8ea4acfacfa25ea | [services] Tests - Run formatter
Summary:
Depends on D4555
Running rust formater on the tests.
Test Plan: None really, it's just code styling, the code compiles and runs as before.
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup/pull_backup.rs",
"new_path": "services/commtest/tests/backup/pull_backup.rs",
"diff": "@@ -3,8 +3,8 @@ mod backup_utils;\n#[path = \"../lib/tools.rs\"]\nmod tools;\n-use tonic::Request;\nuse std::io::{Error as IOError, ErrorKind}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Run formatter
Summary:
Depends on D4555
Running rust formater on the tests.
Test Plan: None really, it's just code styling, the code compiles and runs as before.
Reviewers: tomek, varun
Reviewed By: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh
Differential Revision: https://pha... |
129,190 | 18.07.2022 15:58:45 | -7,200 | 499626f0d48d71298df1244d531d5fa7ca2dc281 | [services] Backup - pull backup - change tests
Summary:
Depends on D4598
Test all the changes from the last 3 diffs.
Test Plan:
```
cd services
yarn run-blob-service-in-sandbox
yarn run-backup-service-in-sandbox
yarn run-integration-tests backup
```
Reviewers: tomek
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup/pull_backup.rs",
"new_path": "services/commtest/tests/backup/pull_backup.rs",
"diff": "@@ -68,7 +68,7 @@ pub async fn run(\n\"backup id expected but not received\",\n))?;\nprintln!(\n- \"compaction (id {}), pushing chunk (size: {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - pull backup - change tests
Summary:
Depends on D4598
Test all the changes from the last 3 diffs.
Test Plan:
```
cd services
yarn run-blob-service-in-sandbox
yarn run-backup-service-in-sandbox
yarn run-integration-tests backup
```
Reviewers: tomek
Reviewed By: tomek
Subscribers: ashoat, tomek,... |
129,184 | 25.07.2022 10:14:09 | 14,400 | ddf524180469be07718f81742686dfe8b29aaa7b | [lintstaged] Add Jest tests to `.lintstaged.js`
Summary: Run `lib` and `keyserver` tests for the same conditions that `flow` is run in those directories.
Test Plan:
Proof that the tests run:
{F115690}
Reviewers: jacek, abosh, varun, tomek
Subscribers: ashoat, adrian | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -17,6 +17,9 @@ module.exports = {\n'lib/**/*.js': function libFlow(files) {\nreturn 'yarn workspace lib flow --quiet';\n},\n+ 'lib/**/*.js': function libTest(files) {\n+ return 'yarn workspace lib ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lintstaged] Add Jest tests to `.lintstaged.js`
Summary: Run `lib` and `keyserver` tests for the same conditions that `flow` is run in those directories.
Test Plan:
Proof that the tests run:
{F115690}
Reviewers: jacek, abosh, varun, tomek
Reviewed By: abosh, varun
Subscribers: ashoat, adrian
Differential Revision... |
129,184 | 25.07.2022 10:45:08 | 14,400 | c95753960ef587df8010013c0a03a0a69c1a1c0c | [lintstaged] Rename `keyServer` => `keyserver`
Summary: `keyserver` is one "word" so shouldn't be camelCase.
Test Plan: Made a change in `/keyserver` and made sure that the `lintstaged` steps ran as expected.
Reviewers: tomek, jacek, abosh, varun
Subscribers: ashoat, adrian | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -26,10 +26,10 @@ module.exports = {\n'{native,lib}/**/*.js': function nativeFlow(files) {\nreturn 'yarn workspace native flow --quiet';\n},\n- '{keyserver,web,lib}/**/*.js': function keyServerFlow(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lintstaged] Rename `keyServer` => `keyserver`
Summary: `keyserver` is one "word" so shouldn't be camelCase.
Test Plan: Made a change in `/keyserver` and made sure that the `lintstaged` steps ran as expected.
Reviewers: tomek, jacek, abosh, varun
Reviewed By: abosh, varun
Subscribers: ashoat, adrian
Differential ... |
129,185 | 26.07.2022 10:10:21 | -7,200 | 633414d383083bbb63aaa78878d8abe9e99c395f | [web] Remove old `NewThreadModal` component
Summary: The diff removes old `NewThreadModal` component that was not used anywhere. Also styles for this modal from `style.css` has been removed.
Test Plan: Web app build and runs as before
Reviewers: tomek, atul
Subscribers: ashoat, adrian, abosh | [
{
"change_type": "DELETE",
"old_path": "web/modals/threads/new-thread-modal.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import * as React from 'react';\n-\n-import { newThreadActionTypes, newThread } from 'lib/actions/thread-actions';\n-import { createLo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove old `NewThreadModal` component
Summary: The diff removes old `NewThreadModal` component that was not used anywhere. Also styles for this modal from `style.css` has been removed.
Test Plan: Web app build and runs as before
Reviewers: tomek, atul
Reviewed By: atul
Subscribers: ashoat, adrian, abosh
Dif... |
129,190 | 21.07.2022 11:30:36 | -7,200 | 2eb10c1818e3861ccebc65808eaed1043e1ea7c2 | [services] Tunnelbroker - remove include iostream
Summary:
Depends on D4591
Removing `#include <iostream>` everywhere. This include was used for `std::cout` and since we quit using it, we can clear out all such includes.
Test Plan: Tunnelbroker builds.
Reviewers: tomek, max
Subscribers: ashoat, tomek, adrian, atul, abo... | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/src/DeliveryBroker/DeliveryBroker.h",
"new_path": "services/tunnelbroker/src/DeliveryBroker/DeliveryBroker.h",
"diff": "#include <folly/concurrency/ConcurrentHashMap.h>\n-#include <iostream>\n#include <string>\nnamespace comm {\n"
},
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tunnelbroker - remove include iostream
Summary:
Depends on D4591
Removing `#include <iostream>` everywhere. This include was used for `std::cout` and since we quit using it, we can clear out all such includes.
Test Plan: Tunnelbroker builds.
Reviewers: tomek, max
Reviewed By: tomek, max
Subscribers: as... |
129,190 | 21.07.2022 11:31:02 | -7,200 | 7a3c6c729a56e74bae59f059c12a26a50ba9eaf1 | [services] Backup - remove include iostream
Summary:
Depends on D4592
Removing `#include <iostream>` everywhere. This include was used for `std::cout` and since we quit using it, we can clear out all such includes.
Test Plan: Backup builds
Reviewers: tomek, max
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/DatabaseManager.cpp",
"new_path": "services/backup/src/DatabaseManager.cpp",
"diff": "#include <aws/dynamodb/model/ScanRequest.h>\n#include <aws/dynamodb/model/UpdateItemRequest.h>\n-#include <iostream>\n-\nnamespace comm {\nnamespace netwo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - remove include iostream
Summary:
Depends on D4592
Removing `#include <iostream>` everywhere. This include was used for `std::cout` and since we quit using it, we can clear out all such includes.
Test Plan: Backup builds
Reviewers: tomek, max
Reviewed By: tomek, max
Subscribers: ashoat, tomek, ... |
129,190 | 21.07.2022 11:31:25 | -7,200 | 60452ea0821ab55bc23768d09740d30842bd39a9 | [services] Blob - remove include iostream
Summary:
Depends on D4593
Removing `#include <iostream>` everywhere. This include was used for `std::cout` and since we quit using it, we can clear out all such includes.
Test Plan: Blob builds
Reviewers: tomek, max
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/blob/src/BlobServiceImpl.cpp",
"new_path": "services/blob/src/BlobServiceImpl.cpp",
"diff": "#include <glog/logging.h>\n-#include <iostream>\n#include <memory>\nnamespace comm {\n"
},
{
"change_type": "MODIFY",
"old_path": "services/blob/s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - remove include iostream
Summary:
Depends on D4593
Removing `#include <iostream>` everywhere. This include was used for `std::cout` and since we quit using it, we can clear out all such includes.
Test Plan: Blob builds
Reviewers: tomek, max
Reviewed By: tomek, max
Subscribers: ashoat, tomek, adri... |
129,190 | 26.07.2022 13:19:09 | -7,200 | 0dc8a1937bd6cebb584a3df09b295922ee8188d5 | [services] Use mutual server listen address
Summary:
Depends on D4595
This is a follow-up for
Test Plan: Services build properly (tunnelbroker, blob, backup)
Reviewers: tomek, max
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/server.cpp",
"new_path": "services/backup/src/server.cpp",
"diff": "#include \"BackupServiceImpl.h\"\n+#include \"GlobalConstants.h\"\n#include \"GlobalTools.h\"\n#include <glog/logging.h>\n#include <grpcpp/grpcpp.h>\n#include <memory>\n-#i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Use mutual server listen address
Summary:
Depends on D4595
This is a follow-up for https://phab.comm.dev/D4590#131582
Test Plan: Services build properly (tunnelbroker, blob, backup)
Reviewers: tomek, max
Reviewed By: tomek
Subscribers: ashoat, tomek, adrian, atul, abosh
Differential Revision: https://... |
129,185 | 26.07.2022 17:29:04 | -7,200 | 296f64250f2eb1d8d7bb3e49ff0082450d54b265 | [web] Introduce `Sidebar` component
Summary:
Introduce component displaying single Sidebar item in the list in Sidebars Modal on web.
{F113322}
Test Plan: The component will be used in the following diffs introducing the modal.
Reviewers: tomek, atul, ashoat
Subscribers: ashoat, adrian, abosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/threads/sidebars/sidebar.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import type { ChatThreadItem } from 'lib/selectors/chat-selectors';\n+import { getMessagePreview } from 'lib/shared/message-utils';\n+imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `Sidebar` component
Summary:
Introduce component displaying single Sidebar item in the list in Sidebars Modal on web.
{F113322}
Test Plan: The component will be used in the following diffs introducing the modal.
Reviewers: tomek, atul, ashoat
Reviewed By: tomek, ashoat
Subscribers: ashoat, adrian,... |
129,185 | 26.07.2022 17:29:04 | -7,200 | 0c00898702611218a09852f76161aa6950d9c487 | [web] Introduce `SidebarList` component
Summary:
Introduce component displaying list of sidebars in Sidebars modal.
{F113329}
{F115291}
Test Plan: The component will be used in Sidebars Modal after next diff.
Reviewers: tomek, atul, ashoat
Subscribers: ashoat, adrian, abosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/threads/sidebars/sidebar-list.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import type { ChatThreadItem } from 'lib/selectors/chat-selectors';\n+\n+import Sidebar from './sidebar.react';\n+import css from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `SidebarList` component
Summary:
Introduce component displaying list of sidebars in Sidebars modal.
{F113329}
{F115291}
Test Plan: The component will be used in Sidebars Modal after next diff.
Reviewers: tomek, atul, ashoat
Reviewed By: tomek, ashoat
Subscribers: ashoat, adrian, abosh
Differential... |
129,185 | 26.07.2022 17:29:04 | -7,200 | 5b394475454f2d24e9065c511e8a3a4ce9db70c1 | [web] Remove old `SidebarListModal` component
Summary: The diff removes an old sidebar list modal as it's no longer used.
Test Plan: web app should build without errors. The component was no longer used on web.
Reviewers: tomek, atul
Subscribers: ashoat, adrian, abosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -240,46 +240,6 @@ ul.list {\noverflow: auto;\n}\n-div.search {\n- display: flex;\n- background-color: #dddddd;\n- border-radius: 5px;\n- padding: 3px 5px;\n- align-items: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove old `SidebarListModal` component
Summary: The diff removes an old sidebar list modal as it's no longer used.
Test Plan: web app should build without errors. The component was no longer used on web.
Reviewers: tomek, atul
Reviewed By: tomek
Subscribers: ashoat, adrian, abosh
Differential Revision: htt... |
129,192 | 26.07.2022 18:12:28 | -7,200 | feb0d5a36ecb0237935a231b55bfd9aa31a46ca0 | [services] Backup - Fix missing hash in unit tests
Summary:
Depends on D4502
Fixing missing hash parameter in LogItem initialisation in generateLogItem function
Test Plan: `cd services && yarn run-unit-tests backup`
Reviewers: tomek, karol
Subscribers: ashoat, tomek, adrian, atul, karol, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/test/DatabaseManagerTest.cpp",
"new_path": "services/backup/test/DatabaseManagerTest.cpp",
"diff": "@@ -38,7 +38,8 @@ generateBackupItem(const std::string &userID, const std::string &backupID) {\n}\nLogItem generateLogItem(const std::string &ba... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Fix missing hash in unit tests
Summary:
Depends on D4502
Fixing missing hash parameter in LogItem initialisation in generateLogItem function
Test Plan: `cd services && yarn run-unit-tests backup`
Reviewers: tomek, karol
Reviewed By: tomek, karol
Subscribers: ashoat, tomek, adrian, atul, karol, ... |
129,192 | 26.07.2022 18:12:29 | -7,200 | 80b0b0f5fb8452e836f53f64b715e0aed7b8c266 | [services] Backup - Remove unnecessary brackets in unit test
Summary:
Depends on D4503
Removing redundant brackets in generating functions
Test Plan: `cd services && yarn run-unit-tests backup`
Reviewers: tomek, karol
Subscribers: ashoat, tomek, adrian, atul, karol, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/test/DatabaseManagerTest.cpp",
"new_path": "services/backup/test/DatabaseManagerTest.cpp",
"diff": "@@ -34,12 +34,12 @@ generateBackupItem(const std::string &userID, const std::string &backupID) {\ncomm::network::tools::getCurrentTimestamp(),\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Remove unnecessary brackets in unit test
Summary:
Depends on D4503
Removing redundant brackets in generating functions
Test Plan: `cd services && yarn run-unit-tests backup`
Reviewers: tomek, karol
Reviewed By: tomek, karol
Subscribers: ashoat, tomek, adrian, atul, karol, abosh
Differential Re... |
129,184 | 28.07.2022 12:45:38 | 14,400 | 8a1bb457ce1f7655324de4befa1d106a244d2125 | [keyserver] Bump `notification.mutableContent` version gate to 1000
Summary: Want to defer this for now to isolate changes while troubleshooting iOS crashes.
Test Plan: NA
Reviewers: ashoat, marcin, tomek
Subscribers: adrian, abosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/push/send.js",
"new_path": "keyserver/src/push/send.js",
"diff": "@@ -493,7 +493,7 @@ function prepareIOSNotification(\nnotification.payload.id = uniqueID;\nnotification.payload.threadID = threadInfo.id;\nnotification.payload.messageInfos = JSON.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Bump `notification.mutableContent` version gate to 1000
Summary: Want to defer this for now to isolate changes while troubleshooting iOS crashes.
Test Plan: NA
Reviewers: ashoat, marcin, tomek
Reviewed By: ashoat
Subscribers: adrian, abosh
Differential Revision: https://phab.comm.dev/D4668 |
129,184 | 28.07.2022 13:14:53 | 14,400 | ebc5aa874bca4f5238114d8a24867c7b7945b745 | [native] `codeVersion` -> 138` | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 138` |
129,200 | 27.07.2022 16:33:07 | 14,400 | 9ffcf5a5ebca2236f83b0bec5636a9a7e847e767 | [services] Helper function to parse userID from AttributeValue
Summary:
Returns the userID String if present, otherwise returns the appropriate error
Depends on D4648
Test Plan: Tested in subsequent diff that uses helper
Reviewers: tomek, karol
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/database.rs",
"new_path": "services/identity/src/database.rs",
"diff": "@@ -400,6 +400,25 @@ fn parse_registration_data_attribute(\n}\n}\n+fn parse_string_attribute(\n+ attribute_name: &'static str,\n+ attribute_value: Option<AttributeVal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Helper function to parse userID from AttributeValue
Summary:
Returns the userID String if present, otherwise returns the appropriate error
Depends on D4648
Test Plan: Tested in subsequent diff that uses helper
Reviewers: tomek, karol
Reviewed By: tomek
Subscribers: ashoat, adrian, atul, abosh
Differen... |
129,184 | 28.07.2022 15:50:45 | 14,400 | 402eb91623814978ee8640752d4707ba20859452 | [native] Don't use `std::move(...)` in return statements in `Session.cpp`
Summary: Caught this with `Product -> Analyze` when trying to investigate an unrelated issue.
Test Plan: NA
Reviewers: ashoat, tomek, karol
Subscribers: adrian, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/CryptoTools/Session.cpp",
"new_path": "native/cpp/CommonCpp/CryptoTools/Session.cpp",
"diff": "@@ -34,7 +34,7 @@ std::unique_ptr<Session> Session::createSessionAsInitializer(\nthrow std::runtime_error(\n\"error createOutbound => ::olm_crea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't use `std::move(...)` in return statements in `Session.cpp`
Summary: Caught this with `Product -> Analyze` when trying to investigate an unrelated issue.
Test Plan: NA
Reviewers: ashoat, tomek, karol
Reviewed By: ashoat
Subscribers: adrian, abosh
Differential Revision: https://phab.comm.dev/D4670 |
129,200 | 29.07.2022 11:17:34 | 14,400 | 0c38f0d781735533d6397baef073239f1c0f5b00 | [services] fix variable name
Summary: updated a helper function to make it more extensible but forgot to change the names of one of the local variables
Test Plan: `cargo build`
Reviewers: atul, tomek
Subscribers: ashoat, adrian, karol, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/database.rs",
"new_path": "services/identity/src/database.rs",
"diff": "@@ -468,7 +468,7 @@ fn parse_string_attribute(\nattribute_value: Option<AttributeValue>,\n) -> Result<String, DBItemError> {\nmatch attribute_value {\n- Some(Attribut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] fix variable name
Summary: updated a helper function to make it more extensible but forgot to change the names of one of the local variables
Test Plan: `cargo build`
Reviewers: atul, tomek
Reviewed By: atul
Subscribers: ashoat, adrian, karol, abosh
Differential Revision: https://phab.comm.dev/D4682 |
129,184 | 29.07.2022 14:33:00 | 14,400 | 7a3561cb68ccdf68638b23f7a331bd9626fc0f21 | [native] `codeVersion` -> 139 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 139 |
129,184 | 31.07.2022 16:25:16 | 14,400 | 0fd0b76d220c924b796b5a1585150f2341b466e8 | [yarn] Move `gaxios` dependency from `native` to root `package.json`
Summary:
So that the `gaxios` dependency can be resolved from `comm/scripts/generate-phab-tag-removal-script.js`.
Depends on D4690
Test Plan: CI
Reviewers: ashoat, tomek, jacek, abosh
Subscribers: adrian | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"flow-mono-cli\": \"^1.5.0\",\n\"flow-typed\": \"^3.2.1\",\n\"fs-extra\": \"^8.1.0\",\n- \"gaxios\": \"^4.3.2\",\n\"googleapis\": \"^89.0.0\",\n\"jest\": \"^26.6.3\",\n\"jetifier\": \"^1.6.4\",... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [yarn] Move `gaxios` dependency from `native` to root `package.json`
Summary:
So that the `gaxios` dependency can be resolved from `comm/scripts/generate-phab-tag-removal-script.js`.
---
Depends on D4690
Test Plan: CI
Reviewers: ashoat, tomek, jacek, abosh
Reviewed By: ashoat
Subscribers: adrian
Differential Re... |
129,184 | 01.08.2022 13:53:40 | 14,400 | cb7c1681b3ffe584c2e9a6988e126dd277581b3d | [native] `codeVersion` -> 140 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 140 |
129,190 | 20.07.2022 12:26:29 | -7,200 | b525823ae3e2c0abf8d9a6b203cfd1314d24ad6e | [services] Tests - Add REMOVE for Blob performance tests
Summary:
Depends on D4583
Adding the logic for the `remove` operations.
Test Plan:
```
cd services
yarn run-performance-tests blob
```
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/blob_performance_test.rs",
"new_path": "services/commtest/tests/blob_performance_test.rs",
"diff": "@@ -4,6 +4,8 @@ mod blob_utils;\nmod get;\n#[path = \"./blob/put.rs\"]\nmod put;\n+#[path = \"./blob/remove.rs\"]\n+mod remove;\n#[path ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Add REMOVE for Blob performance tests
Summary:
Depends on D4583
Adding the logic for the `remove` operations.
Test Plan:
```
cd services
yarn run-performance-tests blob
```
Reviewers: tomek, varun
Reviewed By: tomek
Subscribers: ashoat, tomek, adrian, atul, abosh
Differential Revision: https:/... |
129,190 | 26.07.2022 11:48:29 | -7,200 | 21ab868fa7bc2625e3c1d2954f0e6ef4e448b3b2 | [services] Tests - Backup - Create new backup
Summary:
Depends on D4631
Adding a piece of test for "add attachments for backup" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup_performance_test.rs",
"new_path": "services/commtest/tests/backup_performance_test.rs",
"diff": "#[path = \"./backup/backup_utils.rs\"]\nmod backup_utils;\n+#[path = \"./backup/create_new_backup.rs\"]\n+mod create_new_backup;\n#[... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Backup - Create new backup
Summary:
Depends on D4631
Adding a piece of test for "add attachments for backup" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Reviewed By: tomek
Subscribers: ashoat, tomek, adrian, atul, abosh
Differential... |
129,190 | 25.07.2022 13:10:39 | -7,200 | 0971023d31cb7ce4f58fb8023960cf8ff217a99b | [services] Tests - Backup - Add attachments for backups
Summary:
Depends on D4637
Adding a piece of test for "add attachments for backup" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup_performance_test.rs",
"new_path": "services/commtest/tests/backup_performance_test.rs",
"diff": "+#[path = \"./backup/add_attachments.rs\"]\n+mod add_attachments;\n#[path = \"./backup/backup_utils.rs\"]\nmod backup_utils;\n#[path... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Backup - Add attachments for backups
Summary:
Depends on D4637
Adding a piece of test for "add attachments for backup" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Reviewed By: tomek
Subscribers: ashoat, tomek, adrian, atul, abosh
Di... |
129,190 | 25.07.2022 13:11:56 | -7,200 | 6896bb4bb392966602d0f62c01d96a6615443740 | [services] Tests - Backup - Send log
Summary:
Depends on D4632
Adding a piece of test for "send log" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup_performance_test.rs",
"new_path": "services/commtest/tests/backup_performance_test.rs",
"diff": "@@ -4,6 +4,8 @@ mod add_attachments;\nmod backup_utils;\n#[path = \"./backup/create_new_backup.rs\"]\nmod create_new_backup;\n+#[pat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Backup - Send log
Summary:
Depends on D4632
Adding a piece of test for "send log" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Reviewed By: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh
Differential Revision: https://p... |
129,190 | 25.07.2022 14:26:23 | -7,200 | 48a8514485d44fe5164a3bd24a8a2a2f0bf2ddda | [services] Tests - Backup - Add attachments for logs
Summary:
Depends on D4633
Adding a piece of test for "add attachments for logs" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup_performance_test.rs",
"new_path": "services/commtest/tests/backup_performance_test.rs",
"diff": "@@ -107,7 +107,7 @@ async fn backup_performance_test() -> Result<(), Error> {\nrt.block_on(async {\nprintln!(\"performing ADD ATTACH... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Backup - Add attachments for logs
Summary:
Depends on D4633
Adding a piece of test for "add attachments for logs" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Reviewed By: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh
... |
129,190 | 25.07.2022 14:46:34 | -7,200 | 4100487108b30f6698add6ecc0944d2e946f16f8 | [services] Tests - Backup - Pull backup
Summary:
Depends on D4635
Adding a piece of test for "pull backup" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Subscribers: ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup_performance_test.rs",
"new_path": "services/commtest/tests/backup_performance_test.rs",
"diff": "@@ -4,6 +4,8 @@ mod add_attachments;\nmod backup_utils;\n#[path = \"./backup/create_new_backup.rs\"]\nmod create_new_backup;\n+#[pat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tests - Backup - Pull backup
Summary:
Depends on D4635
Adding a piece of test for "pull backup" functionality.
Test Plan:
```
cd services
yarn run-performance-tests backup 1
```
Reviewers: tomek, varun
Reviewed By: tomek
Subscribers: ashoat, tomek, adrian, atul, abosh
Differential Revision: https://ph... |
129,190 | 02.08.2022 12:04:36 | -7,200 | 3801e446e5eda2dacb1e4275a6d7d31cba746758 | [services] Blob - PullBackupReactor - Simplify write response logic
Summary:
Depends on D4649
I spotted that there's a redundant call of `prepareDataChunkWithPadding` and the logic of the `PullBackupReactor::writeResponse` can be simplified.
Test Plan:
```
cd services
yarn run-backup-service-in-sandbox
```
Reviewers: t... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Reactors/server/PullBackupReactor.cpp",
"new_path": "services/backup/src/Reactors/server/PullBackupReactor.cpp",
"diff": "@@ -164,10 +164,7 @@ PullBackupReactor::writeResponse(backup::PullBackupResponse *response) {\n// If there's data insi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Blob - PullBackupReactor - Simplify write response logic
Summary:
Depends on D4649
I spotted that there's a redundant call of `prepareDataChunkWithPadding` and the logic of the `PullBackupReactor::writeResponse` can be simplified.
Test Plan:
```
cd services
yarn run-backup-service-in-sandbox
```
Reviewer... |
129,200 | 29.07.2022 14:20:01 | 14,400 | 5d4131ef61ab63421ee642ba37c9ed12f625e8b9 | [native] rust project for native gRPC client
Summary: set up the Cargo project with some obvious dependencies
Test Plan: cargo build
Reviewers: tomek, karol, ashoat
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/Cargo.lock",
"diff": "+# This file is automatically @generated by Cargo.\n+# It is not intended for manual editing.\n+version = 3\n+\n+[[package]]\n+name = \"anyhow\"\n+version = \"1.0.58\"\n+source = \"regi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] rust project for native gRPC client
Summary: set up the Cargo project with some obvious dependencies
Test Plan: cargo build
Reviewers: tomek, karol, ashoat
Reviewed By: tomek, ashoat
Subscribers: ashoat, adrian, atul, abosh
Differential Revision: https://phab.comm.dev/D4683 |
129,200 | 01.08.2022 17:30:13 | 14,400 | 00e7acfc26064449d7d7d1e23e4ff2a8693965d1 | [native] create bridge module and runtime
Summary: lazily create a static tokio runtime object that can be passed around for client calls. create the ffi module where library APIs will go.
Test Plan: cargo build
Reviewers: tomek, karol
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "+use lazy_static::lazy_static;\n+use std::sync::Arc;\n+use tokio::runtime::{Builder, Runtime};\npub mod identity {\ntonic::include_proto... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] create bridge module and runtime
Summary: lazily create a static tokio runtime object that can be passed around for client calls. create the ffi module where library APIs will go.
Test Plan: cargo build
Reviewers: tomek, karol
Reviewed By: tomek
Subscribers: ashoat, adrian, atul, abosh
Differential Revis... |
129,185 | 03.08.2022 13:22:41 | -7,200 | e062e97558682487fe30e0fafac3dd6a1489d271 | [lib] Introduce shared `getRelationshipDispatchAction` function
Summary: Move part of the logic responsible for selecting correct `RelationshipAction` basing on provided `RelationshipButton` to lib so it could be resused on web
Test Plan: Confirm the existing logic still worrks on native
Reviewers: tomek, atul
Subscrib... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/relationship-utils.js",
"new_path": "lib/shared/relationship-utils.js",
"diff": "// @flow\n+import invariant from 'invariant';\n+\nimport {\ntype RelationshipButton,\ntype UserRelationshipStatus,\nuserRelationshipStatus,\nrelationshipButtons,\n+ rel... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce shared `getRelationshipDispatchAction` function
Summary: Move part of the logic responsible for selecting correct `RelationshipAction` basing on provided `RelationshipButton` to lib so it could be resused on web
Test Plan: Confirm the existing logic still worrks on native
Reviewers: tomek, atul
Revi... |
129,203 | 02.08.2022 17:27:39 | 14,400 | ec1b0cdf22a0af02ff48ca2a674e601cac328318 | [keyserver] Delete `setup.sh`
Summary: Per [[ | comment ]] on D4714. Relevant Linear issue [[ | here ]].
Test Plan: Ran `git grep setup.sh` and found no occurrences of `setup.sh` in the codebase.
Reviewers: ashoat, atul
Subscribers: tomek, adrian, ashoat | [
{
"change_type": "DELETE",
"old_path": "keyserver/bash/setup.sh",
"new_path": null,
"diff": "-#!/usr/bin/env bash\n-\n-# run as: node user\n-# run from: root of repo\n-\n-set -e\n-\n-. ~/.nvm/nvm.sh\n-\n-chmod -R u=rwX,g=rX,o=rX .\n-chmod -R u=rwX,g=,o= keyserver/secrets\n-\n-pushd server && nvm ins... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Delete `setup.sh`
Summary: Per @ashoat's [[ https://phab.comm.dev/D4714#135639 | comment ]] on D4714. Relevant Linear issue [[ https://linear.app/comm/issue/ENG-1536/delete-setupsh | here ]].
Test Plan: Ran `git grep setup.sh` and found no occurrences of `setup.sh` in the codebase.
Reviewers: ashoat, atu... |
129,182 | 05.08.2022 09:19:53 | -7,200 | b868710dbe7313e615128c652a5041c997030e76 | [web] Add jest library to web
Summary: Add jest library to web to allow testing on web.
Test Plan: See that everyting still compiles.
Reviewers: tomek, abosh, ashoat, atul
Subscribers: ashoat, adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "web/.eslintrc.json",
"new_path": "web/.eslintrc.json",
"diff": "{\n\"env\": {\n- \"browser\": true\n+ \"browser\": true,\n+ \"jest\": true\n},\n\"globals\": {\n\"process\": true\n"
},
{
"change_type": "MODIFY",
"old_path": "web/babel.config.cjs",
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add jest library to web
Summary: Add jest library to web to allow testing on web.
Test Plan: See that everyting still compiles.
Reviewers: tomek, abosh, ashoat, atul
Reviewed By: tomek, abosh, ashoat
Subscribers: ashoat, adrian, atul
Differential Revision: https://phab.comm.dev/D4709 |
129,200 | 04.08.2022 15:38:55 | 14,400 | 026b4b057291c1cd4760ed50a613a1eb9308374e | [native] add verify_user_token client method
Summary: use the identity service client to call the VerifyUserToken RPC
Test Plan: cargo build, successfully called RPC
Reviewers: tomek, karol, max
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "@@ -6,7 +6,7 @@ use tonic::{transport::Channel, Response, Status};\nuse identity::{\nget_user_id_request::AuthType,\nidentity_service_cl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add verify_user_token client method
Summary: use the identity service client to call the VerifyUserToken RPC
Test Plan: cargo build, successfully called RPC
Reviewers: tomek, karol, max
Reviewed By: tomek
Subscribers: ashoat, adrian, atul, abosh
Differential Revision: https://phab.comm.dev/D4747 |
129,184 | 08.08.2022 16:18:37 | 14,400 | 8d121152a74e0f8096e487d41328a456ba7da994 | [tunnelbroker] Removed unused include directives
Summary: Just a minor thing I noticed while testing some of the nix tunnelbroker diffs.
Test Plan: NA, CI?
Reviewers: jon, abosh, varun, tomek, max, karol
Subscribers: ashoat, adrian | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/src/Amqp/AmqpManager.cpp",
"new_path": "services/tunnelbroker/src/Amqp/AmqpManager.cpp",
"diff": "#include \"Constants.h\"\n#include \"DeliveryBroker.h\"\n#include \"GlobalTools.h\"\n-#include \"Tools.h\"\n#include <glog/logging.h>\n"
}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [tunnelbroker] Removed unused include directives
Summary: Just a minor thing I noticed while testing some of the nix tunnelbroker diffs.
Test Plan: NA, CI?
Reviewers: jon, abosh, varun, tomek, max, karol
Reviewed By: jon, abosh, varun
Subscribers: ashoat, adrian
Differential Revision: https://phab.comm.dev/D4773 |
129,190 | 09.08.2022 14:57:47 | -7,200 | d79c9338ccc1ab2fe5bd92d29abb2848f23924e6 | [services] Tunnelbroker - Fix scripts in Dockerfiles
Summary:
Raised in
I mistakenly put `run_service.sh` instead of `run_tests.sh`
Test Plan:
```
cd services
yarn test-tunnelbroker-service
```
This should run tunnelbroker tests
Reviewers: max, ashoat, tomek
Subscribers: jon, ashoat, tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/Dockerfile",
"new_path": "services/tunnelbroker/Dockerfile",
"diff": "@@ -43,4 +43,4 @@ COPY services/tunnelbroker/ .\nRUN scripts/build_service.sh\n-CMD if [ \"$COMM_TEST_SERVICES\" -eq 1 ]; then scripts/run_service.sh; else scripts/run_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Tunnelbroker - Fix scripts in Dockerfiles
Summary:
Raised in https://phabricator.ashoat.com/D3988#112748
I mistakenly put `run_service.sh` instead of `run_tests.sh`
Test Plan:
```
cd services
yarn test-tunnelbroker-service
```
This should run tunnelbroker tests
Reviewers: max, ashoat, tomek
Reviewed By:... |
129,193 | 04.08.2022 15:27:19 | 25,200 | 7d9a7f524d642bfbb41285e496ac31f8f3cf4b2b | [Nix] Provide nix way of starting MariaDB
Summary: Provide nix native way of creating a MariaDB database
Test Plan:
From any branch, on a darwin (MacOS) machine:
```
nix run 'github:commE2E/comm?ref=jonringer/mariadb#mariadb-up'
```
Reviewers: ashoat, varun, abosh, atul
Subscribers: ashoat, tomek, adrian | [
{
"change_type": "MODIFY",
"old_path": "nix/dev-shell.nix",
"new_path": "nix/dev-shell.nix",
"diff": ", grpc\n, libiconv\n, libuv\n+, mariadb\n, nodejs-16_x\n, olm\n, openjdk8\n@@ -42,6 +43,7 @@ mkShell {\nshellcheck\n# node development\n+ mariadb\nnodejs-16_x\nyarn\nwatchman # react native\n@@ -92,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [Nix] Provide nix way of starting MariaDB
Summary: Provide nix native way of creating a MariaDB database
Test Plan:
From any branch, on a darwin (MacOS) machine:
```
nix run 'github:commE2E/comm?ref=jonringer/mariadb#mariadb-up'
```
Reviewers: ashoat, varun, abosh, atul
Reviewed By: varun, abosh
Subscribers: ashoa... |
129,184 | 10.08.2022 14:44:14 | 14,400 | 1b9ebceef002ff21ba3a8622064b0ef403237a8c | [native] `codeVersion` -> 141 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 141 |
129,203 | 11.08.2022 12:20:11 | 14,400 | e4700dca8ef9594f3521201f9af0c72a9b9db65b | [web] Remove extraneous `console.log(...)` statement from `MessageTimestampTooltip` | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-timestamp-tooltip.react.js",
"new_path": "web/chat/message-timestamp-tooltip.react.js",
"diff": "@@ -31,7 +31,6 @@ type Props = {\nfunction MessageTimestampTooltip(props: Props): React.Node {\nconst { messagePositionInfo, timeZone } = props;\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove extraneous `console.log(...)` statement from `MessageTimestampTooltip` |
129,200 | 10.08.2022 15:32:08 | 14,400 | d12c7f9e54c0820b58ecba6ff16455aa8b32b62e | [services] fix update expression for DDB
Summary: Apparently the SET keyword should only be used once in update expressions.
Test Plan: Used the DDB client and successfully updated an item in the users table
Reviewers: tomek, karol
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/database.rs",
"new_path": "services/identity/src/database.rs",
"diff": "@@ -86,25 +86,23 @@ impl DatabaseClient {\nusername: Option<String>,\nuser_public_key: Option<String>,\n) -> Result<UpdateItemOutput, Error> {\n- let mut update_expre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] fix update expression for DDB
Summary: Apparently the SET keyword should only be used once in update expressions.
Test Plan: Used the DDB client and successfully updated an item in the users table
Reviewers: tomek, karol
Reviewed By: tomek
Subscribers: ashoat, adrian, atul, abosh
Differential Revision:... |
129,200 | 10.08.2022 19:16:05 | 14,400 | 238538eda84c54bb02cdd7e7a0c95ff2729e105f | [native] new dependencies for gRPC client
Summary:
We use all of these dependencies in the Identity service.
Depends on D4797
Test Plan: `cargo build`
Reviewers: ashoat, tomek
Subscribers: tomek, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/Cargo.lock",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/Cargo.lock",
"diff": "@@ -944,11 +944,14 @@ dependencies = [\n\"cxx-build\",\n\"identity\",\n\"lazy_static\",\n+ \"opaque-ke\",\n\"prost 0.11.0\",\n+ \"rand\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] new dependencies for gRPC client
Summary:
We use all of these dependencies in the Identity service.
Depends on D4797
Test Plan: `cargo build`
Reviewers: ashoat, tomek
Reviewed By: ashoat, tomek
Subscribers: tomek, adrian, atul, abosh
Differential Revision: https://phab.comm.dev/D4798 |
129,200 | 10.08.2022 19:19:37 | 14,400 | 5a8492a7faebf942dd411365c9a3a08e56e3f935 | [native] small changes to the client methods
Summary:
add tracing and fix the endpoint for the Identity service
Depends on D4798
Test Plan: `cargo build`
Reviewers: tomek, karol
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "@@ -2,6 +2,7 @@ use lazy_static::lazy_static;\nuse std::sync::Arc;\nuse tokio::runtime::{Builder, Runtime};\nuse tonic::{transport::Chan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] small changes to the client methods
Summary:
add tracing and fix the endpoint for the Identity service
Depends on D4798
Test Plan: `cargo build`
Reviewers: tomek, karol
Reviewed By: tomek
Subscribers: ashoat, adrian, atul, abosh
Differential Revision: https://phab.comm.dev/D4799 |
129,187 | 15.08.2022 16:04:06 | 14,400 | 722474a2e0fe30b26990543f2d5490f47883182d | [native] Fix up redux-persist types
Summary: This resolves [ENG-1593](https://linear.app/comm/issue/ENG-1593/make-sure-flow-on-native-checks-how-redux-persist-is-used). See [this comment](https://linear.app/comm/issue/ENG-1593#comment-77afa017).
Test Plan: Flow
Reviewers: tomek
Subscribers: adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "; We fork some components by platform\n.*/*[.]android.js\n-.*/node_modules/redux-persist/lib/index.js\n.*/node_modules/react-native-fast-image/src/index.js.flow\n.*/node_modules/react-native-fs/FS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up redux-persist types
Summary: This resolves [ENG-1593](https://linear.app/comm/issue/ENG-1593/make-sure-flow-on-native-checks-how-redux-persist-is-used). See [this comment](https://linear.app/comm/issue/ENG-1593#comment-77afa017).
Test Plan: Flow
Reviewers: tomek
Reviewed By: tomek
Subscribers: adri... |
129,187 | 15.08.2022 14:40:43 | 14,400 | 3b928cdd35d88db1bb6daf4332f6f22235ecdb5d | [keyserver] Introduce assertValidDBType
Summary: This diff is a simple refactor, and should be a no-op. In the next diff I'll modify `assertValidDBType` to deprecate MySQL.
Test Plan:
1. Flow
2. I ran `keyserver` locally and made sure things generally still worked
Reviewers: tomek, atul
Subscribers: adrian, abosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/database/db-config.js",
"new_path": "keyserver/src/database/db-config.js",
"diff": "@@ -13,6 +13,17 @@ export type DBConfig = {\n+dbType: DBType,\n};\n+function assertValidDBType(dbType: ?string): DBType {\n+ if (!dbType) {\n+ return 'mysql5.7';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Introduce assertValidDBType
Summary: This diff is a simple refactor, and should be a no-op. In the next diff I'll modify `assertValidDBType` to deprecate MySQL.
Test Plan:
1. Flow
2. I ran `keyserver` locally and made sure things generally still worked
Reviewers: tomek, atul
Reviewed By: tomek
Subscrib... |
129,191 | 16.08.2022 13:21:57 | -7,200 | 5b9642aee34cf4047fbee8fefeaa3aee43fc02a3 | [web] Use dispatchActionPromise when logging out
Summary:
Instead of calling server directly, we need to use `dispatchActionPromise` function, so that relevant redux actions are dispatched.
Fixes
Test Plan: Log out and check if logout success action was dispatched.
Reviewers: jacek, atul, ashoat
Subscribers: ashoat, ad... | [
{
"change_type": "MODIFY",
"old_path": "web/settings/account-settings.react.js",
"new_path": "web/settings/account-settings.react.js",
"diff": "import * as React from 'react';\n-import { logOut } from 'lib/actions/user-actions';\n+import { logOut, logOutActionTypes } from 'lib/actions/user-actions';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use dispatchActionPromise when logging out
Summary:
Instead of calling server directly, we need to use `dispatchActionPromise` function, so that relevant redux actions are dispatched.
Fixes https://linear.app/comm/issue/ENG-1604/clean-enabled-apps-on-logout
Test Plan: Log out and check if logout success action ... |
129,200 | 11.08.2022 23:41:15 | 14,400 | 3aecb610154dad25f18989e1906d00d47d30e315 | [native] set up CXX bridge
Summary:
create the ffi module that will be used to generate the bridge between C++ and Rust code
Depends on D4815
Test Plan: `cargo build`
Reviewers: tomek, karol
Subscribers: jon, ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/build.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/build.rs",
"diff": "fn main() {\ntonic_build::compile_protos(\"../protos/identity.proto\")\n.unwrap_or_else(|e| panic!(\"Failed to compile protos {:?}\", e));\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] set up CXX bridge
Summary:
create the ffi module that will be used to generate the bridge between C++ and Rust code
Depends on D4815
Test Plan: `cargo build`
Reviewers: tomek, karol
Reviewed By: tomek, karol
Subscribers: jon, ashoat, adrian, atul, abosh
Differential Revision: https://phab.comm.dev/D4820 |
129,200 | 12.08.2022 01:12:02 | 14,400 | 630cd9b1ac4a1505e22b20410a5b84a908166a42 | [native] add corrosion to android cmake project
Summary:
add corrosion to the CMakeLists.txt file with `find_package`
Depends on D4820
Test Plan: successfully built the android app
Reviewers: tomek, karol, max, jon, inka, ashoat
Subscribers: ashoat, adrian, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/CMakeLists.txt",
"new_path": "native/android/app/CMakeLists.txt",
"diff": "@@ -11,13 +11,12 @@ set (CMAKE_CXX_STANDARD 14)\n# cmake-lint: disable=C0301\n# Sets the minimum version of CMake required to build the native library.\n-cmake_minimu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add corrosion to android cmake project
Summary:
add corrosion to the CMakeLists.txt file with `find_package`
Depends on D4820
Test Plan: successfully built the android app
Reviewers: tomek, karol, max, jon, inka, ashoat
Reviewed By: jon, ashoat
Subscribers: ashoat, adrian, atul, abosh
Differential Revis... |
129,196 | 19.08.2022 15:25:34 | -7,200 | bdf48184b6b72c1b914f7a256f559bb022a803ec | [native] codeVersion -> 142 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 142 |
129,200 | 18.08.2022 17:22:00 | 14,400 | 84f51ba2ce9e76d7ce69bc628284ebfc12f7393f | [native] enum for grpc client data
Summary:
We will pass this enum as a param to the login helper functions to distinguish between the registration and login workflows.
Depends on D4876
Test Plan: `cargo build` (dead code)
Reviewers: tomek, karol, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "@@ -373,3 +373,8 @@ struct LoginResponseAndSender {\nresponse: Option<LoginResponse>,\nsender: mpsc::Sender<LoginRequest>,\n}\n+\n+enum ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] enum for grpc client data
Summary:
We will pass this enum as a param to the login helper functions to distinguish between the registration and login workflows.
Depends on D4876
Test Plan: `cargo build` (dead code)
Reviewers: tomek, karol, atul
Reviewed By: tomek
Subscribers: ashoat, abosh
Differential R... |
129,200 | 22.08.2022 23:48:35 | 14,400 | e46754ceabfd9392f1ab7701ac57168b8325b5ec | [native] introduce generic for unexpected response handler
Summary:
Since this function just logs the unexpected message and returns a gRPC Status, we can make it generic
Depends on D4904
Test Plan: `cargo build` (very small refactor)
Reviewers: tomek, karol, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "@@ -263,8 +263,8 @@ fn pake_login_finish(\n.map(|res| res.message)\n}\n-fn handle_unexpected_registration_response(\n- message: Option<R... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] introduce generic for unexpected response handler
Summary:
Since this function just logs the unexpected message and returns a gRPC Status, we can make it generic
Depends on D4904
Test Plan: `cargo build` (very small refactor)
Reviewers: tomek, karol, atul
Reviewed By: tomek
Subscribers: ashoat, abosh
Di... |
129,200 | 23.08.2022 14:30:42 | 14,400 | 5758a7b045ce3e56398a58c477e534b881255a2b | [native] pake login method for gRPC client
Summary: Uses the existing helper functions to log a user in using PAKE.
Test Plan: successfully logged in an existing user by calling method
Reviewers: tomek, karol, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "@@ -21,6 +21,7 @@ use crate::identity::{\nlogin_request::Data::PakeLoginRequest,\nlogin_response::Data::PakeLoginResponse as LoginPakeLo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] pake login method for gRPC client
Summary: Uses the existing helper functions to log a user in using PAKE.
Test Plan: successfully logged in an existing user by calling method
Reviewers: tomek, karol, atul
Reviewed By: tomek
Subscribers: ashoat, abosh
Differential Revision: https://phab.comm.dev/D4927 |
129,182 | 25.08.2022 11:32:59 | -7,200 | 9c3ebbf367e774b173474dfe3f448d855978a9c6 | [web] Add device ID to redux
Summary: Add device ID to redux on web so it can be persisted.
Test Plan: Check with redux tools that the ID is indeed present in the redux store.
Reviewers: tomek, atul, max, jacek, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/website-responders.js",
"new_path": "keyserver/src/responders/website-responders.js",
"diff": "@@ -299,6 +299,7 @@ async function websiteResponder(\nconst statePromises = {\nnavInfo: navInfoPromise,\n+ deviceID: null,\ncurrentUserInfo:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add device ID to redux
Summary: Add device ID to redux on web so it can be persisted.
Test Plan: Check with redux tools that the ID is indeed present in the redux store.
Reviewers: tomek, atul, max, jacek, ashoat
Reviewed By: tomek, max, ashoat
Subscribers: ashoat, abosh
Differential Revision: https://phab.... |
129,182 | 25.08.2022 11:32:59 | -7,200 | e6b6eeef7b00fcfc22f80709ac1342fb4969f20c | [web] refactor device-ID-regex-related code
Summary: In response to comments on D4868 I refactored code ralated to device ID regex
Test Plan: Run `yarn test` on web
Reviewers: tomek, ashoat
Subscribers: atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/src/Constants.h",
"new_path": "services/tunnelbroker/src/Constants.h",
"diff": "@@ -44,6 +44,8 @@ const size_t AMQP_RECONNECT_MAX_ATTEMPTS = 10;\n// DEVICEID_CHAR_LENGTH has to be kept in sync with deviceIDCharLength\n// which is defined ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] refactor device-ID-regex-related code
Summary: In response to comments on D4868 I refactored code ralated to device ID regex
Test Plan: Run `yarn test` on web
Reviewers: tomek, ashoat
Reviewed By: tomek, ashoat
Subscribers: atul, abosh
Differential Revision: https://phab.comm.dev/D4883 |
129,200 | 24.08.2022 17:12:32 | 14,400 | e06b3c38cc103b9705896fc5accecaccb9776742 | [native] add c++11 flag to build
Summary: this ensures that the compiler knows which edition of C++ to use.
Test Plan: `cargo build`
Reviewers: tomek, karol, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/build.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/build.rs",
"diff": "fn main() {\ntonic_build::compile_protos(\"../protos/identity.proto\")\n.unwrap_or_else(|e| panic!(\"Failed to compile protos {:?}\", e));\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add c++11 flag to build
Summary: this ensures that the compiler knows which edition of C++ to use.
Test Plan: `cargo build`
Reviewers: tomek, karol, atul
Reviewed By: atul
Subscribers: ashoat, abosh
Differential Revision: https://phab.comm.dev/D4950 |
129,200 | 25.08.2022 07:05:26 | 14,400 | 3b5ea22263b57b56b5bccbf657665281dec15d74 | [native] remove unused types
Summary:
Introduced some types with the intention of simplifying our code but it proved too difficult. Removing them for now since they're unused.
Depends on D4950
Test Plan: `cargo build`
Reviewers: tomek, karol, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"new_path": "native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs",
"diff": "@@ -98,12 +98,6 @@ mod ffi {\n}\n}\n-#[derive(Debug)]\n-enum AuthType {\n- Password = 0,\n- Wallet = 1,\n-}\n-\n#[derive(Debug)]\nstruct... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] remove unused types
Summary:
Introduced some types with the intention of simplifying our code but it proved too difficult. Removing them for now since they're unused.
Depends on D4950
Test Plan: `cargo build`
Reviewers: tomek, karol, atul
Reviewed By: atul
Subscribers: ashoat, abosh
Differential Revisio... |
129,203 | 23.08.2022 17:09:25 | 14,400 | 24746e00189dbf1643fe52f66459b474cfe565f0 | [web] Memoize `loginButtonContent` and `saveButtonContent`
Summary: Noticed these could be memoized.
Test Plan: Made sure everything looked as expected on the `LogInForm` modal and `ThreadSettingsGeneralTab` save button. Loading indicators showed up correctly, disappeared after submit was complete, etc.
Reviewers: atul... | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.react.js",
"new_path": "web/account/log-in-form.react.js",
"diff": "@@ -113,12 +113,12 @@ function LoginForm(): React.Node {\n[dispatchActionPromise, logInAction, loginExtraInfo, username],\n);\n- let loginButtonContent;\n+ const loginB... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Memoize `loginButtonContent` and `saveButtonContent`
Summary: Noticed these could be memoized.
Test Plan: Made sure everything looked as expected on the `LogInForm` modal and `ThreadSettingsGeneralTab` save button. Loading indicators showed up correctly, disappeared after submit was complete, etc.
Reviewers: a... |
129,203 | 23.08.2022 17:32:10 | 14,400 | 669f84ba59ecdfce4d98fe92ce7a9560cb58605d | [web] Simplify `return` value of `changeThreadSettingsAction`
Summary: Noticed this when reading through [[ | feedback ]] on D4416 when requesting review on D4931. Looks like I forgot to add this in after he accepted!
Test Plan: Flow, feedback
Reviewers: tomek, atul
Subscribers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/settings/thread-settings-general-tab.react.js",
"new_path": "web/modals/threads/settings/thread-settings-general-tab.react.js",
"diff": "@@ -103,11 +103,10 @@ function ThreadSettingsGeneralTab(\nconst changeThreadSettingsAction = React.useCa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Simplify `return` value of `changeThreadSettingsAction`
Summary: Noticed this when reading through @tomek's [[ https://phab.comm.dev/D4416?id=14041#inline-27509 | feedback ]] on D4416 when requesting review on D4931. Looks like I forgot to add this in after he accepted!
Test Plan: Flow, @tomek's feedback
Revie... |
129,203 | 19.08.2022 17:11:25 | 14,400 | 7f7f5ebfdd115b1cd463419711c273d1280f748b | [native] Use `Array.some(...)` in `uploadInProgress`
Summary: Depends on D4890. Minor change that avoids another level of indentation/for loop by using [[ | Array.some(...) ]].
Test Plan: Flow, close reading.
Reviewers: atul, tomek, jacek
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -372,13 +372,14 @@ class InputStateContainer extends React.PureComponent<Props, State> {\n}\nfor (const localMessageID in this.state.pendingUpl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `Array.some(...)` in `uploadInProgress`
Summary: Depends on D4890. Minor change that avoids another level of indentation/for loop by using [[ https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some | Array.some(...) ]].
Test Plan: Flow, close reading.
Reviewers: atul,... |
129,203 | 25.08.2022 13:50:21 | 14,400 | c3c3ab6a16f7de1c434baf8b092f8b9d6e2538c3 | [native] Make return value more concise in `uploadInProgress`
Summary: Super quick change that depends on D4892.
Test Plan: Flow, close reading. Unfortunately cannot use `Object.values(...)` because of Flow errors.
Reviewers: atul, tomek
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -370,17 +370,13 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nif (this.props.ongoingMessageCreation) {\nreturn true... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make return value more concise in `uploadInProgress`
Summary: Super quick change that depends on D4892.
Test Plan: Flow, close reading. Unfortunately cannot use `Object.values(...)` because of Flow errors.
Reviewers: atul, tomek
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.c... |
129,190 | 29.08.2022 15:56:52 | -7,200 | 15ddad8a568884ed06d7f09a3736315353da85b1 | [services] Backup - Rust lib - Add is initialized
Summary:
Depends on D4861
Adding a function that checks whether the client's been initialized
Test Plan: test plan in D4870
Reviewers: varun, tomek, ashoat
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": ".gitignore",
"new_path": ".gitignore",
"diff": "@@ -34,3 +34,4 @@ services/lib/src/build\n# Nix\nresult*\n+services/backup/rust_lib/target/\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/rust_lib/Cargo.lock",
"new_path": "service... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Rust lib - Add is initialized
Summary:
Depends on D4861
Adding a function that checks whether the client's been initialized
Test Plan: test plan in D4870
Reviewers: varun, tomek, ashoat
Reviewed By: varun, tomek, ashoat
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://ph... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.