author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,992 | 27.08.2018 20:35:00 | 25,200 | ae648bafda2d82a6641e4a28bed34dae40d426ec | Add command-line parameter to trigger panic on signal
This is to troubleshoot problems with a hung process that is
not responding to 'runsc debug --stack' command. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling.go",
"new_path": "pkg/sentry/sighandling/sighandling.go",
"diff": "@@ -103,7 +103,7 @@ func forwardSignals(k *kernel.Kernel, sigchans []chan os.Signal, start, stop cha\n// PrepareForwarding ensures that synchronous signals ar... | Go | Apache License 2.0 | google/gvisor | Add command-line parameter to trigger panic on signal
This is to troubleshoot problems with a hung process that is
not responding to 'runsc debug --stack' command.
PiperOrigin-RevId: 210483513
Change-Id: I4377b210b4e51bc8a281ad34fd94f3df13d9187d |
259,948 | 28.08.2018 09:20:05 | 25,200 | d08ccdaaad0ff00622321957aa01cac149741005 | sentry: avoid double counting map objects in save / restore stats. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/decode.go",
"new_path": "pkg/state/decode.go",
"diff": "@@ -365,6 +365,12 @@ func (ds *decodeState) decodeObject(os *objectState, obj reflect.Value, object *\n// (For non-interfaces this is a no-op).\ndyntyp := reflect.TypeOf(obj.Interface())\nif dyn... | Go | Apache License 2.0 | google/gvisor | sentry: avoid double counting map objects in save / restore stats.
PiperOrigin-RevId: 210551929
Change-Id: Idd05935bffc63b39166cc3751139aff61b689faa |
259,881 | 28.08.2018 09:20:17 | 25,200 | 25a8e13a78ad6418a1798ec419a1b5ab2116a7f8 | Bump to Go 1.11
The procid offset is unchanged. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "# Load go bazel rules and gazelle.\nhttp_archive(\nname = \"io_bazel_rules_go\",\n- url = \"https://github.com/bazelbuild/rules_go/releases/download/0.14.0/rules_go-0.14.0.tar.gz\",\n- sha256 = \"5756a4ad75b3703eb6... | Go | Apache License 2.0 | google/gvisor | Bump to Go 1.11
The procid offset is unchanged.
PiperOrigin-RevId: 210551969
Change-Id: I33ba1ce56c2f5631b712417d870aa65ef24e6022 |
259,992 | 28.08.2018 11:29:53 | 25,200 | f7366e4e6465530ecc1641312011fd82a94f55f8 | Consolidate image tests into a single file
This is to keep it consistent with other test, and
it's easier to maintain them in single file.
Also increase python test timeout to deflake it. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/BUILD",
"new_path": "runsc/test/image/BUILD",
"diff": "@@ -7,8 +7,6 @@ go_test(\nsize = \"large\",\nsrcs = [\n\"image_test.go\",\n- \"python_test.go\",\n- \"tomcat_test.go\",\n],\ndata = [\n\"latin10k.txt\",\n"
},
{
"change_type": "MOD... | Go | Apache License 2.0 | google/gvisor | Consolidate image tests into a single file
This is to keep it consistent with other test, and
it's easier to maintain them in single file.
Also increase python test timeout to deflake it.
PiperOrigin-RevId: 210575042
Change-Id: I2ef5bcd5d97c08549f0c5f645c4b694253ef0b4d |
259,881 | 28.08.2018 12:55:11 | 25,200 | ea113a4380543080f7ad92f536e71706e71d9285 | Drop support for Go 1.10 | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/BUILD",
"new_path": "runsc/boot/filter/BUILD",
"diff": "@@ -6,8 +6,6 @@ go_library(\nname = \"filter\",\nsrcs = [\n\"config.go\",\n- \"config_go110.go\",\n- \"config_go111.go\",\n\"extra_filters.go\",\n\"extra_filters_msan.go\",\n\"extra_filt... | Go | Apache License 2.0 | google/gvisor | Drop support for Go 1.10
PiperOrigin-RevId: 210589588
Change-Id: Iba898bc3eb8f13e17c668ceea6dc820fc8180a70 |
259,948 | 28.08.2018 13:20:54 | 25,200 | d724863a313f5e08a043c8f2ccb4969e8ea23de1 | sentry: optimize dirent weakref map save / restore.
Weak references save / restore involves multiple interface indirection
and cause material latency overhead when there are lots of dirents, each
containing a weak reference map. The nil entries in the map should also
be purged. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -201,7 +201,7 @@ type Dirent struct {\nmu sync.Mutex `state:\"nosave\"`\n// children are cached via weak references.\n- children map[string]*refs.WeakRef\n+ children map[string]*refs.... | Go | Apache License 2.0 | google/gvisor | sentry: optimize dirent weakref map save / restore.
Weak references save / restore involves multiple interface indirection
and cause material latency overhead when there are lots of dirents, each
containing a weak reference map. The nil entries in the map should also
be purged.
PiperOrigin-RevId: 210593727
Change-Id: Ied6f4c3c0726fcc53a24b983d9b3a79121b6b758 |
259,992 | 28.08.2018 17:08:49 | 25,200 | 30c025f3efdf5b599d8fbd4172bb5b856cc269af | Add argument checks to seccomp
This is required to increase protection when running in GKE. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/BUILD",
"new_path": "runsc/boot/filter/BUILD",
"diff": "@@ -22,6 +22,7 @@ go_library(\n\"//pkg/sentry/platform\",\n\"//pkg/sentry/platform/kvm\",\n\"//pkg/sentry/platform/ptrace\",\n+ \"//pkg/tcpip/link/fdbased\",\n\"@org_golang_x_sys//unix:g... | Go | Apache License 2.0 | google/gvisor | Add argument checks to seccomp
This is required to increase protection when running in GKE.
PiperOrigin-RevId: 210635123
Change-Id: Iaaa8be49e73f7a3a90805313885e75894416f0b5 |
259,854 | 29.08.2018 14:14:32 | 25,200 | 313d4af52d774b07d4b98d770d38684c9c119f67 | ping: update comment about UDP | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/ping/protocol.go",
"new_path": "pkg/tcpip/transport/ping/protocol.go",
"diff": "@@ -85,7 +85,7 @@ func (p *protocol) MinimumPacketSize() int {\npanic(fmt.Sprint(\"unknown protocol number: \", p.number))\n}\n-// ParsePorts returns the source... | Go | Apache License 2.0 | google/gvisor | ping: update comment about UDP
PiperOrigin-RevId: 210788012
Change-Id: I5ebdcf3d02bfab3484a1374fbccba870c9d68954 |
259,992 | 30.08.2018 17:29:14 | 25,200 | 3e493adf7adb6c8b920ae224fb68e2c317a16a56 | Add seccomp filter to fsgofer | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/BUILD",
"new_path": "runsc/cmd/BUILD",
"diff": "@@ -42,6 +42,7 @@ go_library(\n\"//runsc/console\",\n\"//runsc/container\",\n\"//runsc/fsgofer\",\n+ \"//runsc/fsgofer/filter\",\n\"//runsc/specutils\",\n\"@com_github_google_subcommands//:go_default_li... | Go | Apache License 2.0 | google/gvisor | Add seccomp filter to fsgofer
PiperOrigin-RevId: 211011542
Change-Id: Ib5a83a00f8eb6401603c6fb5b59afc93bac52558 |
259,992 | 31.08.2018 09:44:31 | 25,200 | e669697241e9774f1a1e4ab609dde933a0563ba6 | Fix RunAsRoot arguments forwarding
It was including the path to the executable twice in the
arguments. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/testutil/testutil.go",
"new_path": "runsc/test/testutil/testutil.go",
"diff": "@@ -254,7 +254,7 @@ func RunAsRoot(m *testing.M) {\nruntime.LockOSThread()\ndefer runtime.UnlockOSThread()\n- cmd := exec.Command(\"/proc/self/exe\", os.Args...)\n+ cmd :... | Go | Apache License 2.0 | google/gvisor | Fix RunAsRoot arguments forwarding
It was including the path to the executable twice in the
arguments.
PiperOrigin-RevId: 211098311
Change-Id: I5357c51c63f38dfab551b17bb0e04011a0575010 |
259,885 | 31.08.2018 13:06:16 | 25,200 | b1c1afa3ccc499df3fd15814d2b6cf9005bc2ab1 | Delete the long-obsolete kernel.TaskMaybe interface. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -499,13 +499,6 @@ func (t *Task) afterLoad() {\n// struct.\nconst copyScratchBufferLen = 52\n-// TaskMaybe is the interface for extracting Tasks out of things which may be\n-// or... | Go | Apache License 2.0 | google/gvisor | Delete the long-obsolete kernel.TaskMaybe interface.
PiperOrigin-RevId: 211131855
Change-Id: Ia7799561ccd65d16269e0ae6f408ab53749bca37 |
259,885 | 31.08.2018 13:57:02 | 25,200 | 098046ba193b839d69c059f7a0e68c89409b4237 | Disintegrate kernel.TaskResources.
This allows us to call kernel.FDMap.DecRef without holding mutexes
cleanly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -95,7 +95,6 @@ go_library(\n\"task_list.go\",\n\"task_log.go\",\n\"task_net.go\",\n- \"task_resources.go\",\n\"task_run.go\",\n\"task_sched.go\",\n\"task_signals.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Disintegrate kernel.TaskResources.
This allows us to call kernel.FDMap.DecRef without holding mutexes
cleanly.
PiperOrigin-RevId: 211139657
Change-Id: Ie59d5210fb9282e1950e2e40323df7264a01bcec |
259,885 | 31.08.2018 14:16:36 | 25,200 | b935311e2371abdbceba89294d0001905f2658d5 | Do not use fs.FileOwnerFromContext in fs/proc.file.UnstableAttr().
From //pkg/sentry/context/context.go:
// - It is *not safe* to retain a Context passed to a function beyond the scope
// of that function call.
Passing a stored kernel.Task as a context.Context to
fs.FileOwnerFromContext violates this requirement. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/file.go",
"new_path": "pkg/sentry/fs/proc/file.go",
"diff": "@@ -51,7 +51,8 @@ func (f *file) UnstableAttr(ctx context.Context, inode *fs.Inode) (fs.UnstableAt\nreturn fs.UnstableAttr{}, err\n}\nif f.t != nil {\n- uattr.Owner = fs.FileOwnerF... | Go | Apache License 2.0 | google/gvisor | Do not use fs.FileOwnerFromContext in fs/proc.file.UnstableAttr().
From //pkg/sentry/context/context.go:
// - It is *not safe* to retain a Context passed to a function beyond the scope
// of that function call.
Passing a stored kernel.Task as a context.Context to
fs.FileOwnerFromContext violates this requirement.
PiperOrigin-RevId: 211143021
Change-Id: I4c5b02bd941407be4c9cfdbcbdfe5a26acaec037 |
259,885 | 31.08.2018 15:43:32 | 25,200 | f8ccfbbed4875e65c78c849cd46afa882ba68ee3 | Document more task-goroutine-owned fields in kernel.Task.
Task.creds can only be changed by the task's own set*id and execve
syscalls, and Task namespaces can only be changed by the task's own
unshare/setns syscalls. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -354,19 +354,19 @@ type Task struct {\n// creds is the task's credentials.\n//\n- // creds is protected by mu, however the value itself is immutable and\n- // can only be changed ... | Go | Apache License 2.0 | google/gvisor | Document more task-goroutine-owned fields in kernel.Task.
Task.creds can only be changed by the task's own set*id and execve
syscalls, and Task namespaces can only be changed by the task's own
unshare/setns syscalls.
PiperOrigin-RevId: 211156279
Change-Id: I94d57105d34e8739d964400995a8a5d76306b2a0 |
259,992 | 31.08.2018 16:11:07 | 25,200 | 66c03b3dd79c45014da19f36973a85290e9a4458 | Mounting over '/tmp' may fail | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -744,8 +744,8 @@ func TestUnixDomainSockets(t *testing.T) {\nspec.Mounts = []specs.Mount{\nspecs.Mount{\nType: \"bind\",\n- Destination: \"/tmp\",\n- Source: \"/tm... | Go | Apache License 2.0 | google/gvisor | Mounting over '/tmp' may fail
PiperOrigin-RevId: 211160120
Change-Id: Ie5f280bdac17afd01cb16562ffff6222b3184c34 |
259,858 | 04.09.2018 09:18:00 | 25,200 | c09f9acd7c7a2e85472b1ee47bf26f7c89ded43e | Distinguish Element and Linker for ilist.
Furthermore, allow for the specification of an ElementMapper. This allows a
single "Element" type to exist on multiple inline lists, and work without
having to embed the entry type.
This is a requisite change for supporting a per-Inode list of Dirents. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ilist/BUILD",
"new_path": "pkg/ilist/BUILD",
"diff": "@@ -28,6 +28,7 @@ go_template_instance(\nprefix = \"direct\",\ntemplate = \":generic_list\",\ntypes = {\n+ \"Element\": \"*direct\",\n\"Linker\": \"*direct\",\n},\n)\n@@ -47,6 +48,10 @@ go_template(\nsr... | Go | Apache License 2.0 | google/gvisor | Distinguish Element and Linker for ilist.
Furthermore, allow for the specification of an ElementMapper. This allows a
single "Element" type to exist on multiple inline lists, and work without
having to embed the entry type.
This is a requisite change for supporting a per-Inode list of Dirents.
PiperOrigin-RevId: 211467497
Change-Id: If2768999b43e03fdaecf8ed15f435fe37518d163 |
259,881 | 04.09.2018 13:28:37 | 25,200 | 3944cb41cbef64ac507e87f258441000a46424d5 | /proc/PID/mounts is not tab-delimited | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/mounts.go",
"new_path": "pkg/sentry/fs/proc/mounts.go",
"diff": "@@ -173,7 +173,7 @@ func (mf *mountsFile) ReadSeqFileData(ctx context.Context, handle seqfile.SeqHan\nvar buf bytes.Buffer\nforEachMountSource(mf.t, func(mountPath string, m *f... | Go | Apache License 2.0 | google/gvisor | /proc/PID/mounts is not tab-delimited
PiperOrigin-RevId: 211513847
Change-Id: Ib484dd2d921c3e5d70d0e410cd973d3bff4f6b73 |
260,013 | 05.09.2018 09:20:18 | 25,200 | 2b8dae0bc5594f7088dd028268efaedbb5a72507 | Open(2) isn't honoring O_NOFOLLOW | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -37,6 +37,7 @@ const (\nO_DIRECT = 00040000\nO_LARGEFILE = 00100000\nO_DIRECTORY = 00200000\n+ O_NOFOLLOW = 00400000\nO_CLOEXEC = 02000000\nO_SYNC = 04010000\nO_PATH = 010000000\n"
},
... | Go | Apache License 2.0 | google/gvisor | Open(2) isn't honoring O_NOFOLLOW
PiperOrigin-RevId: 211644897
Change-Id: I882ed827a477d6c03576463ca5bf2d6351892b90 |
259,992 | 05.09.2018 13:12:15 | 25,200 | 1d22d87fdc464b0641eca69f730777c27984c2ff | Move multi-container test to a single file | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "@@ -38,6 +38,7 @@ go_test(\nsrcs = [\n\"container_test.go\",\n\"fs_test.go\",\n+ \"multi_container_test.go\",\n],\ndata = [\n\":uds_test_app\",\n"
},
{
"change_type": "MODIFY",
"... | Go | Apache License 2.0 | google/gvisor | Move multi-container test to a single file
PiperOrigin-RevId: 211685288
Change-Id: I7872f2a83fcaaa54f385e6e567af6e72320c5aa0 |
259,992 | 05.09.2018 13:16:49 | 25,200 | 4b57fd920d2d9fe3c8351d5b73b496902c928d95 | Add MADVISE to fsgofer seccomp profile | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -105,6 +105,7 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_GETTIMEOFDAY: {},\nsyscall.SYS_LINKAT: {},\nsyscall.SYS_LSEEK: {},\n+ syscall.SYS_MADVISE: {},\... | Go | Apache License 2.0 | google/gvisor | Add MADVISE to fsgofer seccomp profile
PiperOrigin-RevId: 211686037
Change-Id: I0e776ca760b65ba100e495f471b6e811dbd6590a |
259,992 | 05.09.2018 14:01:25 | 25,200 | 0c7cfca0da234ae34497c420a23fea91a47a566c | Running container should have a valid sandbox | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -517,6 +517,7 @@ func (c *Container) Destroy() error {\nlog.Warningf(\"Failed to destroy sandbox %q: %v\", c.Sandbox.ID, err)\n}\n}\n+ c.Status = Stopped\nc.Sandbox = nil\ni... | Go | Apache License 2.0 | google/gvisor | Running container should have a valid sandbox
PiperOrigin-RevId: 211693868
Change-Id: Iea340dd78bf26ae6409c310b63c17cc611c2055f |
259,992 | 05.09.2018 14:28:52 | 25,200 | 12aef686af3f37029e619602286f00a40144c52d | Enabled bind mounts in sub-containers
With multi-gofers, bind mounts in sub-containers should
just work. Removed restrictions and added test. There are
also a few cleanups along the way, e.g. retry unmounting
in case cleanup races with gofer teardown. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fds.go",
"new_path": "runsc/boot/fds.go",
"diff": "@@ -28,11 +28,6 @@ import (\n// createFDMap creates an fd map that contains stdin, stdout, and stderr. If\n// console is true, then ioctl calls will be passed through to the host fd.\n-//\n-// TODO:... | Go | Apache License 2.0 | google/gvisor | Enabled bind mounts in sub-containers
With multi-gofers, bind mounts in sub-containers should
just work. Removed restrictions and added test. There are
also a few cleanups along the way, e.g. retry unmounting
in case cleanup races with gofer teardown.
PiperOrigin-RevId: 211699569
Change-Id: Ic0a69c29d7c31cd7e038909cc686c6ac98703374 |
259,942 | 05.09.2018 16:46:47 | 25,200 | b3b66dbd1f7f1d5411fd1f7ea76fc5ea7027ec35 | Enable constructing a Prependable from a View without allocating. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/buffer/prependable.go",
"new_path": "pkg/tcpip/buffer/prependable.go",
"diff": "@@ -32,6 +32,15 @@ func NewPrependable(size int) Prependable {\nreturn Prependable{buf: NewView(size), usedIdx: size}\n}\n+// NewPrependableFromView creates an entirely-u... | Go | Apache License 2.0 | google/gvisor | Enable constructing a Prependable from a View without allocating.
PiperOrigin-RevId: 211722525
Change-Id: Ie73753fd09d67d6a2ce70cfe2d4ecf7275f09ce0 |
259,992 | 05.09.2018 18:05:59 | 25,200 | 41b56696c4923276c6269812bb3dfa7643dab65d | Imported FD in exec was leaking
Imported file needs to be closed after it's
been imported. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -119,6 +119,10 @@ func (proc *Proc) Exec(args *ExecArgs, waitStatus *uint32) error {\nreturn err\n}\ndefer file.DecRef()\n+\n+ // We're done with this file.\n+ f.Close()\n+\nif ... | Go | Apache License 2.0 | google/gvisor | Imported FD in exec was leaking
Imported file needs to be closed after it's
been imported.
PiperOrigin-RevId: 211732472
Change-Id: Ia9249210558b77be076bcce465b832a22eed301f |
259,992 | 05.09.2018 18:31:37 | 25,200 | 5f0002fc83a77a39d9a2ef1443bc6c18e22ea779 | Use container's capabilities in exec
When no capabilities are specified in exec, use the
container's capabilities to match runc's behavior. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/exec.go",
"new_path": "runsc/cmd/exec.go",
"diff": "@@ -115,16 +115,22 @@ func (ex *Exec) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nFatalf(\"error loading sandbox: %v\", err)\n}\n+ // Replace empty settings with defaults from ... | Go | Apache License 2.0 | google/gvisor | Use container's capabilities in exec
When no capabilities are specified in exec, use the
container's capabilities to match runc's behavior.
PiperOrigin-RevId: 211735186
Change-Id: Icd372ed64410c81144eae94f432dffc9fe3a86ce |
259,891 | 05.09.2018 21:13:46 | 25,200 | 8f0b6e7fc02919df034dea9e9c9dbab1b80de2be | runsc: Support runsc kill multi-container.
Now, we can kill individual containers rather than the entire sandbox. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -22,7 +22,6 @@ import (\nspecs \"github.com/opencontainers/runtime-spec/specs-go\"\n\"gvisor.googlesource.com/gvisor/pkg/control/server\"\n\"gvisor.googlesource.com/gvisor/pkg/log\"... | Go | Apache License 2.0 | google/gvisor | runsc: Support runsc kill multi-container.
Now, we can kill individual containers rather than the entire sandbox.
PiperOrigin-RevId: 211748106
Change-Id: Ic97e91db33d53782f838338c4a6d0aab7a313ead |
259,891 | 06.09.2018 10:40:53 | 25,200 | d95663a6b9831b56602c09f33a9679fa15175b97 | runsc testing: Move TestMultiContainerSignal to multi_container_test. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -38,7 +38,6 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/sentry/kernel/auth\"\n\"gvisor.googlesource.com/gvisor/pkg/unet\"\n\"gvisor.googlesource.com/gvisor/r... | Go | Apache License 2.0 | google/gvisor | runsc testing: Move TestMultiContainerSignal to multi_container_test.
PiperOrigin-RevId: 211831396
Change-Id: Id67f182cb43dccb696180ec967f5b96176f252e0 |
259,992 | 06.09.2018 10:58:58 | 25,200 | efac28976c6dbf40627d02753fee1467c8272b45 | Enable network for multi-container | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/network.go",
"new_path": "runsc/sandbox/network.go",
"diff": "@@ -57,6 +57,7 @@ const (\nfunc setupNetwork(conn *urpc.Client, pid int, spec *specs.Spec, conf *boot.Config) error {\nlog.Infof(\"Setting up network\")\n+ if !conf.MultiContainer {\n/... | Go | Apache License 2.0 | google/gvisor | Enable network for multi-container
PiperOrigin-RevId: 211834411
Change-Id: I52311a6c5407f984e5069359d9444027084e4d2a |
259,992 | 07.09.2018 10:44:50 | 25,200 | f895cb4d8b4b37a563b7a5b9dc92eae552084b44 | Use root abstract socket namespace for exec | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -106,6 +106,7 @@ func (proc *Proc) Exec(args *ExecArgs, waitStatus *uint32) error {\nMaxSymlinkTraversals: linux.MaxSymlinkTraversals,\nUTSNamespace: proc.Kernel.RootUTSNamespac... | Go | Apache License 2.0 | google/gvisor | Use root abstract socket namespace for exec
PiperOrigin-RevId: 211999211
Change-Id: I5968dd1a8313d3e49bb6e6614e130107495de41d |
259,992 | 07.09.2018 12:27:44 | 25,200 | bc81f3fe4a042a15343d2eab44da32d818ac1ade | Remove '--file-access=direct' option
It was used before gofer was implemented and it's not
supported anymore.
BREAKING CHANGE: proxy-shared and proxy-exclusive options
are now: shared and exclusive. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -85,8 +85,11 @@ go_test(\ndeps = [\n\"//pkg/control/server\",\n\"//pkg/log\",\n+ \"//pkg/p9\",\n\"//pkg/sentry/context/contexttest\",\n\"//pkg/sentry/fs\",\n+ \"//pkg/unet\",\n+ \"//runsc/fsgofer\"... | Go | Apache License 2.0 | google/gvisor | Remove '--file-access=direct' option
It was used before gofer was implemented and it's not
supported anymore.
BREAKING CHANGE: proxy-shared and proxy-exclusive options
are now: shared and exclusive.
PiperOrigin-RevId: 212017643
Change-Id: If029d4073fe60583e5ca25f98abb2953de0d78fd |
259,992 | 07.09.2018 13:38:12 | 25,200 | 8ce3fbf9f87677ac34c577be9fb9b395ede8e714 | Only start signal forwarding after init process is created | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -84,6 +84,10 @@ type Loader struct {\n// spec is the base configuration for the root container.\nspec *specs.Spec\n+ // startSignalForwarding enables forwarding of signals to the sandboxed\... | Go | Apache License 2.0 | google/gvisor | Only start signal forwarding after init process is created
PiperOrigin-RevId: 212028121
Change-Id: If9c2c62f3be103e2bb556b8d154c169888e34369 |
259,858 | 07.09.2018 16:52:02 | 25,200 | 6cfb5cd56d4660cc0de6cd991a7ed4601824a7e6 | Add additional sanity checks for walk. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/file.go",
"new_path": "pkg/p9/file.go",
"diff": "@@ -20,10 +20,13 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/fd\"\n)\n-// Attacher is provided by the user.\n+// Attacher is provided by the server.\ntype Attacher interface {\n// Attach returns a n... | Go | Apache License 2.0 | google/gvisor | Add additional sanity checks for walk.
PiperOrigin-RevId: 212058684
Change-Id: I319709b9ffcfccb3231bac98df345d2a20eca24b |
259,992 | 07.09.2018 16:58:19 | 25,200 | 172860a059ce2cff68aa85a3f66319ee52bdec13 | Add 'Starting gVisor...' message to syslog
This allows applications to verify they are running with gVisor. It
also helps debugging when running with a mix of container runtimes.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/syslog.go",
"new_path": "pkg/sentry/kernel/syslog.go",
"diff": "@@ -86,14 +86,18 @@ func (s *syslog) Log() []byte {\nreturn m\n}\n- time := 0.0\n+ const format = \"<6>[%11.6f] %s\\n\"\n+\n+ s.msg = append(s.msg, []byte(fmt.Sprintf(format, 0.0... | Go | Apache License 2.0 | google/gvisor | Add 'Starting gVisor...' message to syslog
This allows applications to verify they are running with gVisor. It
also helps debugging when running with a mix of container runtimes.
Closes #54
PiperOrigin-RevId: 212059457
Change-Id: I51d9595ee742b58c1f83f3902ab2e2ecbd5cedec |
259,992 | 07.09.2018 16:59:33 | 25,200 | cf5006ff24c966a652f5b9cbce3ba363208c197a | Disable test until we figure out what's broken | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/image_test.go",
"new_path": "runsc/test/image/image_test.go",
"diff": "@@ -147,7 +147,8 @@ func TestNginx(t *testing.T) {\n}\n}\n-func TestMysql(t *testing.T) {\n+// TODO: Enable again when bug is fixed.\n+func DISABLED_TestMysql(t *testing.T)... | Go | Apache License 2.0 | google/gvisor | Disable test until we figure out what's broken
PiperOrigin-RevId: 212059579
Change-Id: I052c2192d3483d7bd0fd2232ef2023a12da66446 |
259,881 | 07.09.2018 18:13:50 | 25,200 | 7045828a310d47a2940214f71ae75b8b7b682b78 | Update cleanup TODO | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling.go",
"new_path": "pkg/sentry/sighandling/sighandling.go",
"diff": "@@ -87,9 +87,8 @@ func forwardSignals(k *kernel.Kernel, sigchans []chan os.Signal, start, stop, do\n//\n// Otherwise ignore the signal.\n//\n- // TODO: Conver... | Go | Apache License 2.0 | google/gvisor | Update cleanup TODO
PiperOrigin-RevId: 212068327
Change-Id: I3f360cdf7d6caa1c96fae68ae3a1caaf440f0cbe |
259,942 | 10.09.2018 13:02:43 | 25,200 | da9ecb748cf6eb26e43338481d1ecba22eea09b2 | Simplify some code in VectorisedView#ToView. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/buffer/view.go",
"new_path": "pkg/tcpip/buffer/view.go",
"diff": "@@ -154,13 +154,11 @@ func (vv *VectorisedView) Size() int {\n// ToView returns a single view containing the content of the vectorised view.\nfunc (vv *VectorisedView) ToView() View {\... | Go | Apache License 2.0 | google/gvisor | Simplify some code in VectorisedView#ToView.
PiperOrigin-RevId: 212317717
Change-Id: Ic77449c53bf2f8be92c9f0a7a726c45bd35ec435 |
259,992 | 10.09.2018 13:23:49 | 25,200 | 7e9e6745ca1f17031bbea14cb08b3ee3c0f9f818 | Allow '/dev/zero' to be mapped with unaligned length | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/special_mappable.go",
"new_path": "pkg/sentry/mm/special_mappable.go",
"diff": "@@ -138,10 +138,15 @@ func (m *SpecialMappable) Length() uint64 {\n// uses an ephemeral file created by mm/shmem.c:shmem_zero_setup(); we should\n// do the same to ge... | Go | Apache License 2.0 | google/gvisor | Allow '/dev/zero' to be mapped with unaligned length
PiperOrigin-RevId: 212321271
Change-Id: I79d71c2e6f4b8fcd3b9b923fe96c2256755f4c48 |
259,885 | 10.09.2018 15:22:44 | 25,200 | a29c39aa629b6118765e5075eb228752934d7081 | Map committed chunks concurrently in FileMem.LoadFrom. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/filemem/filemem_state.go",
"new_path": "pkg/sentry/platform/filemem/filemem_state.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"fmt\"\n\"io\"\n\"runtime\"\n+ \"sync/atomic\"\n\"syscall\"\n\"gvisor.googlesource.com/gvisor/pkg/log\"\n@@ -127,6 ... | Go | Apache License 2.0 | google/gvisor | Map committed chunks concurrently in FileMem.LoadFrom.
PiperOrigin-RevId: 212345401
Change-Id: Iac626ee87ba312df88ab1019ade6ecd62c04c75c |
259,992 | 11.09.2018 11:04:06 | 25,200 | c44bc6612fc4554d0aa4e484a46cd1f6b6a7b5c5 | Allow fstatat back in syscall filters | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -208,6 +208,7 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_MPROTECT: {},\nsyscall.SYS_MUNMAP: {},\nsyscall.SYS_NANOSLEEP: {},\n+ syscall.SYS_NEWFSTATAT: {},\nsy... | Go | Apache License 2.0 | google/gvisor | Allow fstatat back in syscall filters
PiperOrigin-RevId: 212483372
Change-Id: If95f32a8e41126cf3dc8bd6c8b2fb0fcfefedc6d |
259,881 | 12.09.2018 10:50:22 | 25,200 | 0efde2bfbde2fea78134a32f5fb34332ec0ce531 | Remove getdents from filters
It was only used by whitelistfs, which was removed in | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -98,7 +98,6 @@ var allowedSyscalls = seccomp.SyscallRules{\nseccomp.AllowValue(0),\n},\n},\n- syscall.SYS_GETDENTS64: {},\nsyscall.SYS_GETPID: {},\nunix.SYS_GETRANDOM: {},\nsy... | Go | Apache License 2.0 | google/gvisor | Remove getdents from filters
It was only used by whitelistfs, which was removed in
bc81f3fe4a042a15343d2eab44da32d818ac1ade.
PiperOrigin-RevId: 212666374
Change-Id: Ia35e6dc9d68c1a3b015d5b5f71ea3e68e46c5bed |
259,891 | 12.09.2018 15:22:24 | 25,200 | 2eff1fdd061be9cfabc36532dda8cbefeb02e534 | runsc: Add exec flag that specifies where to save the sandbox-internal pid.
This is different from the existing -pid-file flag, which saves a host pid. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -87,6 +87,24 @@ type ExecArgs struct {\n// Exec runs a new task.\nfunc (proc *Proc) Exec(args *ExecArgs, waitStatus *uint32) error {\n+ newTG, err := proc.execAsync(args)\n+ if ... | Go | Apache License 2.0 | google/gvisor | runsc: Add exec flag that specifies where to save the sandbox-internal pid.
This is different from the existing -pid-file flag, which saves a host pid.
PiperOrigin-RevId: 212713968
Change-Id: I2c486de8dd5cfd9b923fb0970165ef7c5fc597f0 |
259,948 | 12.09.2018 17:23:56 | 25,200 | 9dec7a3db99d8c7045324bc6d8f0c27e88407f6c | compressio: stop worker-pool reference / dependency loop. | [
{
"change_type": "MODIFY",
"old_path": "pkg/compressio/compressio.go",
"new_path": "pkg/compressio/compressio.go",
"diff": "@@ -127,7 +127,7 @@ type result struct {\n// The goroutine will exit when input is closed, and the goroutine will close\n// output.\ntype worker struct {\n- pool *pool\n+ hashP... | Go | Apache License 2.0 | google/gvisor | compressio: stop worker-pool reference / dependency loop.
PiperOrigin-RevId: 212732300
Change-Id: I9a0b9b7c28e7b7439d34656dd4f2f6114d173e22 |
259,881 | 13.09.2018 14:06:34 | 25,200 | 9c6b38e2952650cba32e21d0719bcb0ffdc10860 | Format struct itimerspec | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64.go",
"new_path": "pkg/sentry/strace/linux64.go",
"diff": "@@ -240,8 +240,8 @@ var linuxAMD64 = SyscallMap{\n220: makeSyscallInfo(\"semtimedop\", Hex, Hex, Hex, Hex),\n221: makeSyscallInfo(\"fadvise64\", Hex, Hex, Hex, Hex),\n222: make... | Go | Apache License 2.0 | google/gvisor | Format struct itimerspec
PiperOrigin-RevId: 212874745
Change-Id: I0c3e8e6a9e8976631cee03bf0b8891b336ddb8c8 |
259,985 | 13.09.2018 15:15:33 | 25,200 | adf8f339703922211886d3e5588160f65bc131b3 | Extend memory usage events to report mapped memory usage. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/memevent/memory_events.go",
"new_path": "pkg/sentry/kernel/memevent/memory_events.go",
"diff": "@@ -94,5 +94,8 @@ func (m *MemoryEvents) emit() {\nsnapshot, _ := usage.MemoryAccounting.Copy()\ntotal := totalPlatform + snapshot.Mapped\n- event... | Go | Apache License 2.0 | google/gvisor | Extend memory usage events to report mapped memory usage.
PiperOrigin-RevId: 212887555
Change-Id: I3545383ce903cbe9f00d9b5288d9ef9a049b9f4f |
259,854 | 13.09.2018 19:11:12 | 25,200 | 29a7271f5da9fdb7b4a9a6c9ea61421ce6844a73 | Plumb monotonic time to netstack
Netstack needs to be portable, so this seems to be preferable to using raw
system calls. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -943,6 +943,8 @@ func (k *Kernel) SetExitError(err error) {\n}\n}\n+var _ tcpip.Clock = (*Kernel)(nil)\n+\n// NowNanoseconds implements tcpip.Clock.NowNanoseconds.\nfunc (k *K... | Go | Apache License 2.0 | google/gvisor | Plumb monotonic time to netstack
Netstack needs to be portable, so this seems to be preferable to using raw
system calls.
PiperOrigin-RevId: 212917409
Change-Id: I7b2073e7db4b4bf75300717ca23aea4c15be944c |
259,981 | 13.09.2018 21:46:03 | 25,200 | faa34a0738456f5328cf99de13622a150042776d | platform/kvm: Get max vcpu number dynamically by ioctl
The old kernel version, such as 4.4, only support 255 vcpus.
While gvisor is ran on these kernels, it could panic because the
vcpu id and vcpu number beyond max_vcpus.
Use ioctl(vmfd, _KVM_CHECK_EXTENSION, _KVM_CAP_MAX_VCPUS) to get max
vcpus number dynamically. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/address_space.go",
"new_path": "pkg/sentry/platform/kvm/address_space.go",
"diff": "@@ -26,31 +26,26 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/sentry/usermem\"\n)\n-type vCPUBitArray [(_KVM_NR_VCPUS + 63) / 64]uint64\n-\n// dirt... | Go | Apache License 2.0 | google/gvisor | platform/kvm: Get max vcpu number dynamically by ioctl
The old kernel version, such as 4.4, only support 255 vcpus.
While gvisor is ran on these kernels, it could panic because the
vcpu id and vcpu number beyond max_vcpus.
Use ioctl(vmfd, _KVM_CHECK_EXTENSION, _KVM_CAP_MAX_VCPUS) to get max
vcpus number dynamically.
Change-Id: I50dd859a11b1c2cea854a8e27d4bf11a411aa45c
PiperOrigin-RevId: 212929704 |
259,885 | 14.09.2018 11:09:41 | 25,200 | 0380bcb3a4125723dc5248f70174ff64fb1942a2 | Fix interaction between rt_sigtimedwait and ignored signals. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -108,9 +108,12 @@ type Task struct {\n// goroutine.\nsignalMask linux.SignalSet\n- // FIXME: An equivalent to task_struct::real_blocked is needed\n- // to prevent signals that are... | Go | Apache License 2.0 | google/gvisor | Fix interaction between rt_sigtimedwait and ignored signals.
PiperOrigin-RevId: 213011782
Change-Id: I716c6ea3c586b0c6c5a892b6390d2d11478bc5af |
259,881 | 14.09.2018 15:58:56 | 25,200 | 3aa50f18a4102429aa40f5d0e518357ceaed2373 | Reuse readlink parameter, add sockaddr max. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -140,6 +140,10 @@ const (\nSO_TYPE = 3\n)\n+// SockAddrMax is the maximum size of a struct sockaddr, from\n+// uapi/linux/socket.h.\n+const SockAddrMax = 128\n+\n// SockAddrInt is str... | Go | Apache License 2.0 | google/gvisor | Reuse readlink parameter, add sockaddr max.
PiperOrigin-RevId: 213058623
Change-Id: I522598c655d633b9330990951ff1c54d1023ec29 |
259,891 | 17.09.2018 11:30:16 | 25,200 | 25add7b22b1b0b6a4bac1e72536d3f3a0c70f048 | runsc: Fix stdin/out/err in multi-container mode.
Stdin/out/err weren't being sent to the sentry. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -186,7 +186,9 @@ type StartArgs struct {\n// CID is the ID of the container to start.\nCID string\n- // FilePayload contains the file descriptor over which the sandbox will\n+ // Fi... | Go | Apache License 2.0 | google/gvisor | runsc: Fix stdin/out/err in multi-container mode.
Stdin/out/err weren't being sent to the sentry.
PiperOrigin-RevId: 213307171
Change-Id: Ie4b634a58b1b69aa934ce8597e5cc7a47a2bcda2 |
259,881 | 17.09.2018 12:15:35 | 25,200 | d639c3d61bfdbd42eb809c21a15275cc75524b7e | Allow NULL data in mount(2) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_mount.go",
"new_path": "pkg/sentry/syscalls/linux/sys_mount.go",
"diff": "@@ -46,14 +46,17 @@ func Mount(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\nreturn 0, nil, err\n}\n+ data := \"\"\n+ if dataAddr !... | Go | Apache License 2.0 | google/gvisor | Allow NULL data in mount(2)
PiperOrigin-RevId: 213315267
Change-Id: I7562bcd81fb22e90aa9c7dd9eeb94803fcb8c5af |
259,854 | 17.09.2018 13:35:00 | 25,200 | ab6fa44588233fa48d1ae0bf7d9b0d9e984a6af0 | Allow kernel.(*Task).Block to accept an extract only channel | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/lock/lock.go",
"new_path": "pkg/sentry/fs/lock/lock.go",
"diff": "@@ -121,7 +121,7 @@ type Locks struct {\n// Blocker is the interface used for blocking locks. Passing a nil Blocker\n// will be treated as non-blocking.\ntype Blocker interface {\n... | Go | Apache License 2.0 | google/gvisor | Allow kernel.(*Task).Block to accept an extract only channel
PiperOrigin-RevId: 213328293
Change-Id: I4164133e6f709ecdb89ffbb5f7df3324c273860a |
259,891 | 17.09.2018 16:24:05 | 25,200 | bb88c187c5457df14fa78e5e6b6f48cbc90fb489 | runsc: Enable waiting on exited processes.
This makes `runsc wait` behave more like waitpid()/wait4() in that:
Once a process has run to completion, you can wait on it and get its exit
code.
Processes not waited on will consume memory (like a zombie process) | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -87,7 +87,7 @@ type ExecArgs struct {\n// Exec runs a new task.\nfunc (proc *Proc) Exec(args *ExecArgs, waitStatus *uint32) error {\n- newTG, err := proc.execAsync(args)\n+ newT... | Go | Apache License 2.0 | google/gvisor | runsc: Enable waiting on exited processes.
This makes `runsc wait` behave more like waitpid()/wait4() in that:
- Once a process has run to completion, you can wait on it and get its exit
code.
- Processes not waited on will consume memory (like a zombie process)
PiperOrigin-RevId: 213358916
Change-Id: I5b5eca41ce71eea68e447380df8c38361a4d1558 |
259,992 | 17.09.2018 21:17:31 | 25,200 | 26b08e182cd08371f14dc58fd54ed7865452cea7 | Rename container in test
's' used to stand for sandbox, before container exited. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -192,16 +192,16 @@ func run(spec *specs.Spec, conf *boot.Config) error {\ndefer os.RemoveAll(bundleDir)\n// Create, start and wait for the container.\n- s, err := ... | Go | Apache License 2.0 | google/gvisor | Rename container in test
's' used to stand for sandbox, before container exited.
PiperOrigin-RevId: 213390641
Change-Id: I7bda94a50398c46721baa92227e32a7a1d817412 |
259,992 | 17.09.2018 21:33:51 | 25,200 | 5d9816be41a967fa1fa9bbbe0c638dd322c7c0b1 | Remove memory usage static init
panic() during init() can be hard to debug.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/usage/memory.go",
"new_path": "pkg/sentry/usage/memory.go",
"diff": "@@ -117,15 +117,16 @@ type MemoryLocked struct {\nFile *os.File\n}\n-func newMemoryLocked() MemoryLocked {\n- name := \"memory-usage\"\n+// Init initializes global 'MemoryAccountin... | Go | Apache License 2.0 | google/gvisor | Remove memory usage static init
panic() during init() can be hard to debug.
Updates #100
PiperOrigin-RevId: 213391932
Change-Id: Ic103f1981c5b48f1e12da3b42e696e84ffac02a9 |
259,992 | 18.09.2018 02:08:11 | 25,200 | da20559137ccbf7f27e6008472f4d9159306df4a | Provide better message when memfd_create fails with ENOSYS
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/filemem/filemem.go",
"new_path": "pkg/sentry/platform/filemem/filemem.go",
"diff": "@@ -233,6 +233,9 @@ func newFromFile(file *os.File) (*FileMem, error) {\nfunc New(name string) (*FileMem, error) {\nfd, err := memutil.CreateMemFD(name, 0)\... | Go | Apache License 2.0 | google/gvisor | Provide better message when memfd_create fails with ENOSYS
Updates #100
PiperOrigin-RevId: 213414821
Change-Id: I90c2e6c18c54a6afcd7ad6f409f670aa31577d37 |
260,013 | 18.09.2018 11:13:27 | 25,200 | ed08597d121a624592e5517a28ae40ddbcc59cb0 | Allow for MSG_CTRUNC in input flags for recv. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"new_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"diff": "@@ -602,7 +602,7 @@ func RecvMsg(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysca\n}\n// Reject flags that we don't handle yet.\n- if f... | Go | Apache License 2.0 | google/gvisor | Allow for MSG_CTRUNC in input flags for recv.
PiperOrigin-RevId: 213481363
Change-Id: I8150ea20cebeb207afe031ed146244de9209e745 |
259,992 | 18.09.2018 19:11:49 | 25,200 | 8aec7473a1cc106d1de2e6c072b84eecc1f239b5 | Added state machine checks for Container.Status
For my own sanitity when thinking about possible transitions and state. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -92,7 +92,7 @@ type Container struct {\nStatus Status `json:\"status\"`\n// GoferPid is the pid of the gofer running along side the sandbox. May\n- // be 0 if the gofer has ... | Go | Apache License 2.0 | google/gvisor | Added state machine checks for Container.Status
For my own sanitity when thinking about possible transitions and state.
PiperOrigin-RevId: 213559482
Change-Id: I25588c86cf6098be4eda01f4e7321c102ceef33c |
259,942 | 19.09.2018 13:42:55 | 25,200 | 2e497de2d9f6c410a214faae9962e762757b0648 | Pass local link address to DeliverNetworkPacket
This allows a NetworkDispatcher to implement transparent bridging,
assuming all implementations of LinkEndpoint.WritePacket call eth.Encode
with header.EthernetFields.SrcAddr set to the passed
Route.LocalLinkAddress, if it is provided. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -72,7 +72,7 @@ func (e *Endpoint) Inject(protocol tcpip.NetworkProtocolNumber, vv buffer.Vector\n// InjectLinkAddr injects an inbound packet with a remote link add... | Go | Apache License 2.0 | google/gvisor | Pass local link address to DeliverNetworkPacket
This allows a NetworkDispatcher to implement transparent bridging,
assuming all implementations of LinkEndpoint.WritePacket call eth.Encode
with header.EthernetFields.SrcAddr set to the passed
Route.LocalLinkAddress, if it is provided.
PiperOrigin-RevId: 213686651
Change-Id: I446a4ac070970202f0724ef796ff1056ae4dd72a |
259,992 | 19.09.2018 17:14:20 | 25,200 | e3952733011df912ecaa48974832a054a45c345a | Fix sandbox and gofer capabilities
Capabilities.Set() adds capabilities,
but doesn't remove existing ones that might have been loaded. Fixed
the code and added tests. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -428,13 +428,13 @@ func parseAndFilterOptions(opts []string, allowedKeys ...string) ([]string, erro\nkv := strings.Split(o, \"=\")\nswitch len(kv) {\ncase 1:\n- if contains(allowedKeys, o) {\n+ if ... | Go | Apache License 2.0 | google/gvisor | Fix sandbox and gofer capabilities
Capabilities.Set() adds capabilities,
but doesn't remove existing ones that might have been loaded. Fixed
the code and added tests.
PiperOrigin-RevId: 213726369
Change-Id: Id7fa6fce53abf26c29b13b9157bb4c6616986fba |
259,854 | 19.09.2018 17:48:24 | 25,200 | 117ac8bc5b4a98cd74c68ac0feed02b5bb4b78b1 | Fix data race on tcp.endpoint.hardError in tcp.(*endpoint).Read
tcp.endpoint.hardError is protected by tcp.endpoint.mu. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -127,7 +127,7 @@ type endpoint struct {\n// hardError is meaningful only when state is stateError, it stores the\n// error to be returned when read/write sysca... | Go | Apache License 2.0 | google/gvisor | Fix data race on tcp.endpoint.hardError in tcp.(*endpoint).Read
tcp.endpoint.hardError is protected by tcp.endpoint.mu.
PiperOrigin-RevId: 213730698
Change-Id: I4e4f322ac272b145b500b1a652fbee0c7b985be2 |
259,992 | 19.09.2018 18:16:18 | 25,200 | b873e388f36ee7251059d54a963c27a55be50ab5 | Update gocapability commit to get bug fix | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -79,5 +79,5 @@ go_repository(\ngo_repository(\nname = \"com_github_syndtr_gocapability\",\nimportpath = \"github.com/syndtr/gocapability\",\n- commit = \"33e07d32887e1e06b7c025f27ce52f62c7990bc0\",\n+ commit = \... | Go | Apache License 2.0 | google/gvisor | Update gocapability commit to get bug fix
PiperOrigin-RevId: 213734203
Change-Id: I9cf5d3885fb88b41444c686168d4cab00f09988a |
259,891 | 19.09.2018 22:19:10 | 25,200 | ffb5fdd69021713e88ec965e77487b7fc28bc104 | runsc: Fix stdin/stdout/stderr in multi-container mode.
The issue with the previous change was that the stdin/stdout/stderr passed to
the sentry were dup'd by host.ImportFile. This left a dangling FD that by never
closing caused containerd to timeout waiting on container stop. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -193,7 +193,9 @@ type StartArgs struct {\n// CID is the ID of the container to start.\nCID string\n- // FilePayload contains the file descriptor over which the sandbox will\n+ // Fi... | Go | Apache License 2.0 | google/gvisor | runsc: Fix stdin/stdout/stderr in multi-container mode.
The issue with the previous change was that the stdin/stdout/stderr passed to
the sentry were dup'd by host.ImportFile. This left a dangling FD that by never
closing caused containerd to timeout waiting on container stop.
PiperOrigin-RevId: 213753032
Change-Id: Ia5e4c0565c42c8610d3b59f65599a5643b0901e4 |
259,992 | 20.09.2018 18:53:02 | 25,200 | b63c4bfe02d1b88eb12d75d0c7051a006d5cbe7d | Set Sandbox.Chroot so it gets cleaned up upon destruction
I've made several attempts to create a test, but the lack of
permission from the test user makes it nearly impossible to
test anything useful. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -95,8 +95,8 @@ type Container struct {\n// be 0 if the gofer has been killed.\nGoferPid int `json:\"goferPid\"`\n- // Sandbox is the sandbox this container is running in. It... | Go | Apache License 2.0 | google/gvisor | Set Sandbox.Chroot so it gets cleaned up upon destruction
I've made several attempts to create a test, but the lack of
permission from the test user makes it nearly impossible to
test anything useful.
PiperOrigin-RevId: 213922174
Change-Id: I5b502ca70cb7a6645f8836f028fb203354b4c625 |
259,992 | 26.09.2018 21:58:54 | 25,200 | fca9a390db4c965b4606dd85838460841bd4ab14 | Return correct parent PID
Old code was returning ID of the thread that created
the child process. It should be returning the ID of
the parent process instead. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -269,11 +269,14 @@ func Processes(k *kernel.Kernel, out *[]*Process) error {\ncontinue\n}\n+ ppid := kernel.ThreadID(0)\n+ if tg.Leader().Parent() != nil {\n+ ppid = ts.Root.IDO... | Go | Apache License 2.0 | google/gvisor | Return correct parent PID
Old code was returning ID of the thread that created
the child process. It should be returning the ID of
the parent process instead.
PiperOrigin-RevId: 214720910
Change-Id: I95715c535bcf468ecf1ae771cccd04a4cd345b36 |
259,992 | 27.09.2018 08:57:32 | 25,200 | 6910ff36434f4bc5aa8c6b3094b617c7c92a9803 | Move uds_test_app to common test_app
This was done so it's easier to add more functionality
to this file for other tests. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "@@ -2,13 +2,6 @@ package(licenses = [\"notice\"]) # Apache 2.0\nload(\"@io_bazel_rules_go//go:def.bzl\", \"go_binary\", \"go_library\", \"go_test\")\n-go_binary(\n- name = \"uds_test_app\",\... | Go | Apache License 2.0 | google/gvisor | Move uds_test_app to common test_app
This was done so it's easier to add more functionality
to this file for other tests.
PiperOrigin-RevId: 214782043
Change-Id: I1f38b9ee1219b3ce7b789044ada8e52bdc1e6279 |
259,992 | 27.09.2018 10:25:19 | 25,200 | b514ab05897bca53c1d4f71c912f2977b3134daf | Refactor 'runsc boot' to take container ID as argument
This makes the flow slightly simpler (no need to call
Loader.SetRootContainer). And this is required change to tag
tasks with container ID inside the Sentry. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -171,7 +171,6 @@ func (cm *containerManager) StartRoot(cid *string, _ *struct{}) error {\nif err := <-cm.startResultChan; err != nil {\nreturn fmt.Errorf(\"failed to start sandbox: ... | Go | Apache License 2.0 | google/gvisor | Refactor 'runsc boot' to take container ID as argument
This makes the flow slightly simpler (no need to call
Loader.SetRootContainer). And this is required change to tag
tasks with container ID inside the Sentry.
PiperOrigin-RevId: 214795210
Change-Id: I6ff4af12e73bb07157f7058bb15fd5bb88760884 |
259,948 | 27.09.2018 10:41:28 | 25,200 | 234f36b6f2cb0db74d119079e5244619d6ea38ad | sentry: export cpuTime function. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/state/state_metadata.go",
"new_path": "pkg/sentry/state/state_metadata.go",
"diff": "@@ -28,7 +28,7 @@ const (\n)\nfunc addSaveMetadata(m map[string]string) {\n- t, err := cpuTime()\n+ t, err := CPUTime()\nif err != nil {\nlog.Warningf(\"Error getti... | Go | Apache License 2.0 | google/gvisor | sentry: export cpuTime function.
PiperOrigin-RevId: 214798278
Change-Id: Id59d1ceb35037cda0689d3a1c4844e96c6957615 |
259,992 | 27.09.2018 22:52:25 | 25,200 | 1166c088fc51c83af3198e25d5e774103ae976fc | Move common test code to function | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -62,7 +62,8 @@ func waitForProcessList(cont *Container, want []*control.Process) error {\n}\nreturn nil\n}\n- return testutil.Poll(cb, 5*time.Second)\n+ // Gives p... | Go | Apache License 2.0 | google/gvisor | Move common test code to function
PiperOrigin-RevId: 214890335
Change-Id: I42743f0ce46a5a42834133bce2f32d187194fc87 |
259,992 | 28.09.2018 09:43:13 | 25,200 | cf226d48ce8c49409049e03ed405366db9fc2a04 | Switch to root in userns when CAP_SYS_CHROOT is also missing
Some tests check current capabilities and re-run the tests as root inside
userns if required capabibilities are missing. It was checking for
CAP_SYS_ADMIN only, CAP_SYS_CHROOT is also required now. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/capability.go",
"new_path": "runsc/cmd/capability.go",
"diff": "@@ -60,7 +60,11 @@ func applyCaps(caps *specs.LinuxCapabilities) error {\nnewCaps.Set(c, set...)\n}\n- return newCaps.Apply(capability.CAPS | capability.BOUNDS | capability.AMBS)\n+ if e... | Go | Apache License 2.0 | google/gvisor | Switch to root in userns when CAP_SYS_CHROOT is also missing
Some tests check current capabilities and re-run the tests as root inside
userns if required capabibilities are missing. It was checking for
CAP_SYS_ADMIN only, CAP_SYS_CHROOT is also required now.
PiperOrigin-RevId: 214949226
Change-Id: Ic81363969fa76c04da408fae8ea7520653266312 |
259,881 | 28.09.2018 11:02:11 | 25,200 | 3ff24b4f2c6d5a7a872a744150bbfca795afdbfc | Require AF_UNIX sockets from the gofer
host.endpoint already has the check, but it is missing from
host.ConnectedEndpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/socket.go",
"new_path": "pkg/sentry/fs/gofer/socket.go",
"diff": "package gofer\nimport (\n+ \"gvisor.googlesource.com/gvisor/pkg/log\"\n\"gvisor.googlesource.com/gvisor/pkg/p9\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/fs\"\n\"gvisor.g... | Go | Apache License 2.0 | google/gvisor | Require AF_UNIX sockets from the gofer
host.endpoint already has the check, but it is missing from
host.ConnectedEndpoint.
PiperOrigin-RevId: 214962762
Change-Id: I88bb13a5c5871775e4e7bf2608433df8a3d348e6 |
259,992 | 28.09.2018 12:20:56 | 25,200 | 2496d9b4b6343154525f73e9583a4a60bebcfa30 | Make runsc kill and delete more conformant to the "spec" | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -21,10 +21,8 @@ import (\n\"path\"\nspecs \"github.com/opencontainers/runtime-spec/specs-go\"\n- \"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n\"gvisor.googlesource.com/gvisor/p... | Go | Apache License 2.0 | google/gvisor | Make runsc kill and delete more conformant to the "spec"
PiperOrigin-RevId: 214976251
Change-Id: I631348c3886f41f63d0e77e7c4f21b3ede2ab521 |
259,992 | 28.09.2018 15:51:36 | 25,200 | 49ff81a42b51a3fa2ee139e1e86179fa0c427a86 | Add ruby image tests | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/BUILD",
"new_path": "runsc/test/image/BUILD",
"diff": "@@ -11,6 +11,8 @@ go_test(\ndata = [\n\"latin10k.txt\",\n\"mysql.sql\",\n+ \"ruby.rb\",\n+ \"ruby.sh\",\n],\nembed = [\":image\"],\ntags = [\n"
},
{
"change_type": "MODIFY",
"o... | Go | Apache License 2.0 | google/gvisor | Add ruby image tests
PiperOrigin-RevId: 215009066
Change-Id: I54ab920fa649cf4d0817f7cb8ea76f9126523330 |
259,992 | 28.09.2018 17:47:22 | 25,200 | cfdd418fe23880cad88639596c1171cbe7ad6ffb | Made a few changes to make testutil.Docker easier to use | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/image_test.go",
"new_path": "runsc/test/image/image_test.go",
"diff": "@@ -40,7 +40,7 @@ import (\nfunc TestHelloWorld(t *testing.T) {\nd := testutil.MakeDocker(\"hello-test\")\n- if _, err := d.Run(\"hello-world\"); err != nil {\n+ if err := ... | Go | Apache License 2.0 | google/gvisor | Made a few changes to make testutil.Docker easier to use
PiperOrigin-RevId: 215023376
Change-Id: I139569bd15c013e5dd0f60d0c98a64eaa0ba9e8e |
259,992 | 28.09.2018 18:14:59 | 25,200 | 50c283b9f56bb7200938d9e207355f05f79f0d17 | Add test for 'signall --all' with stopped container | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/multi_container_test.go",
"new_path": "runsc/container/multi_container_test.go",
"diff": "@@ -527,6 +527,12 @@ func TestMultiContainerProcesses(t *testing.T) {\n// TestMultiContainerKillAll checks that all process that belong to a container\n//... | Go | Apache License 2.0 | google/gvisor | Add test for 'signall --all' with stopped container
PiperOrigin-RevId: 215025517
Change-Id: I04b9d8022b3d9dfe279e466ddb91310b9860b9af |
259,992 | 30.09.2018 22:21:34 | 25,200 | 9c7eb13079e65100b69b41536a51d2433b05637b | Removed duplicate/stale TODOs | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/kill.go",
"new_path": "runsc/cmd/kill.go",
"diff": "@@ -80,8 +80,6 @@ func (k *Kill) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nif err != nil {\nFatalf(\"%v\", err)\n}\n- // TODO: Distinguish between already-exited containers a... | Go | Apache License 2.0 | google/gvisor | Removed duplicate/stale TODOs
PiperOrigin-RevId: 215162121
Change-Id: I35f06ac3235cf31c9e8a158dcf6261a7ded6c4c4 |
259,992 | 30.09.2018 23:22:13 | 25,200 | 43e6aff50e23763d12c71b054f100fd91da46736 | Don't fail if Root is readonly and is not a mount point
This makes runsc more friendly to run without docker or K8s. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -1556,6 +1556,27 @@ func TestGoferExits(t *testing.T) {\n}\n}\n+func TestRootNotMount(t *testing.T) {\n+ spec := testutil.NewSpecWithArgs(\"/bin/true\")\n+\n+ root... | Go | Apache License 2.0 | google/gvisor | Don't fail if Root is readonly and is not a mount point
This makes runsc more friendly to run without docker or K8s.
PiperOrigin-RevId: 215165586
Change-Id: Id45a9fc24a3c09b1645f60dbaf70e64711a7a4cd |
259,992 | 01.10.2018 10:29:45 | 25,200 | a2ad8fef136b31989bfcd2f40003f6113aebaf1d | Make multi-container the default mode for runsc
And remove multicontainer option. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -193,10 +193,6 @@ type Config struct {\n// disabled. Pardon the double negation, but default to enabled is important.\nDisableSeccomp bool\n- // MultiContainer enables multiple containers s... | Go | Apache License 2.0 | google/gvisor | Make multi-container the default mode for runsc
And remove multicontainer option.
PiperOrigin-RevId: 215236981
Change-Id: I9fd1d963d987e421e63d5817f91a25c819ced6cb |
259,881 | 01.10.2018 14:15:52 | 25,200 | 0400e5459288592768af12ab71609c6df6afe3d7 | Add itimer types to linux package, strace | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -44,6 +44,7 @@ go_library(\n\"signal.go\",\n\"socket.go\",\n\"time.go\",\n+ \"timer.go\",\n\"tty.go\",\n\"uio.go\",\n\"utsname.go\",\n"
},
{
"change_type": "ADD",
"old_path": null... | Go | Apache License 2.0 | google/gvisor | Add itimer types to linux package, strace
PiperOrigin-RevId: 215278262
Change-Id: Icd10384c99802be6097be938196044386441e282 |
259,992 | 03.10.2018 09:31:53 | 25,200 | 77e43adeab4abcd301d76222e0304f551fbcf0cc | Add TIOCINQ to allowed seccomp when hostinet is used | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -335,6 +335,10 @@ func hostInetFilters() seccomp.SyscallRules {\nseccomp.AllowAny{},\nseccomp.AllowValue(syscall.TIOCOUTQ),\n},\n+ {\n+ seccomp.AllowAny{},\n+ seccomp.AllowVal... | Go | Apache License 2.0 | google/gvisor | Add TIOCINQ to allowed seccomp when hostinet is used
PiperOrigin-RevId: 215574070
Change-Id: Ib36e804adebaf756adb9cbc2752be9789691530b |
259,885 | 03.10.2018 13:50:58 | 25,200 | 8e729e0e1fd22147d2a609f9bae13aa4d96f02fd | Add //pkg/sync:generic_atomicptr. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/BUILD",
"new_path": "pkg/sync/BUILD",
"diff": "@@ -7,6 +7,14 @@ package(\nload(\"//tools/go_generics:defs.bzl\", \"go_template\")\n+go_template(\n+ name = \"generic_atomicptr\",\n+ srcs = [\"atomicptr_unsafe.go\"],\n+ types = [\n+ \"Value\",\n+ ],\n+)... | Go | Apache License 2.0 | google/gvisor | Add //pkg/sync:generic_atomicptr.
PiperOrigin-RevId: 215620949
Change-Id: I519da4b44386d950443e5784fb8c48ff9a36c5d3 |
259,854 | 03.10.2018 17:02:05 | 25,200 | 4fef31f96c289d5e58c3c2997ee38fcb22c0378f | Add S/R support for FIOASYNC | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/file.go",
"new_path": "pkg/sentry/fs/file.go",
"diff": "@@ -85,6 +85,9 @@ type File struct {\n// async handles O_ASYNC notifications.\nasync FileAsync\n+ // saving indicates that this file is in the process of being saved.\n+ saving bool `state:\... | Go | Apache License 2.0 | google/gvisor | Add S/R support for FIOASYNC
PiperOrigin-RevId: 215655197
Change-Id: I668b1bc7c29daaf2999f8f759138bcbb09c4de6f |
259,854 | 03.10.2018 20:21:25 | 25,200 | beac59b37a8b0ea834904870e5c236d2627947a2 | Fix panic if FIOASYNC callback is registered and triggered without target | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fasync/fasync.go",
"new_path": "pkg/sentry/kernel/fasync/fasync.go",
"diff": "@@ -60,6 +60,11 @@ func (a *FileAsync) Callback(e *waiter.Entry) {\nif tg != nil {\nt = tg.Leader()\n}\n+ if t == nil {\n+ // No recipient has been registered.\n+ a... | Go | Apache License 2.0 | google/gvisor | Fix panic if FIOASYNC callback is registered and triggered without target
PiperOrigin-RevId: 215674589
Change-Id: I4f8871b64c570dc6da448d2fe351cec8a406efeb |
259,992 | 03.10.2018 20:43:18 | 25,200 | 3f46f2e5017106d1569f759b8d19aee6e9827c58 | Fix sandbox chroot
Sandbox was setting chroot, but was not chaging the working
dir. Added test to ensure this doesn't happen in the future. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -35,6 +35,11 @@ bazel build //...\nruntime=runsc_test_$((RANDOM))\nsudo -n ./runsc/test/install.sh --runtime ${runtime}\n+# Best effort to uninstall the runtime\n+uninstallRuntime() {\n+ sudo... | Go | Apache License 2.0 | google/gvisor | Fix sandbox chroot
Sandbox was setting chroot, but was not chaging the working
dir. Added test to ensure this doesn't happen in the future.
PiperOrigin-RevId: 215676270
Change-Id: I14352d3de64a4dcb90e50948119dc8328c9c15e1 |
259,881 | 08.10.2018 11:38:02 | 25,200 | 569c2b06c47d269d961405fa652d45e51860d005 | Statfs Namelen should be NAME_MAX not PATH_MAX
We accidentally set the wrong maximum. I've also added PATH_MAX and
NAME_MAX to the linux abi package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fs.go",
"new_path": "pkg/abi/linux/fs.go",
"diff": "@@ -28,6 +28,12 @@ const (\nV9FS_MAGIC = 0x01021997\n)\n+// Filesystem path limits, from uapi/linux/limits.h.\n+const (\n+ NAME_MAX = 255\n+ PATH_MAX = 4096\n+)\n+\n// Statfs is struct statfs, f... | Go | Apache License 2.0 | google/gvisor | Statfs Namelen should be NAME_MAX not PATH_MAX
We accidentally set the wrong maximum. I've also added PATH_MAX and
NAME_MAX to the linux abi package.
PiperOrigin-RevId: 216221311
Change-Id: I44805fcf21508831809692184a0eba4cee469633 |
259,881 | 08.10.2018 17:43:31 | 25,200 | b8048f75daa2ec13059162cb421236f99e5e4a0e | Uncapitalize error | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -142,7 +142,7 @@ func init() {\n// New also handles setting up a kernel for restoring a container.\nfunc New(id string, spec *specs.Spec, conf *Config, controllerFD, deviceFD int, goferFDs ... | Go | Apache License 2.0 | google/gvisor | Uncapitalize error
PiperOrigin-RevId: 216281263
Change-Id: Ie0c189e7f5934b77c6302336723bc1181fd2866c |
260,013 | 09.10.2018 09:51:01 | 25,200 | acf7a951894a1b445ff61e945e32c989892f476f | Add memunit to sysinfo(2).
Also properly add padding after Procs in the linux.Sysinfo
structure. This will be implicitly padded to 64bits so we
need to do the same. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/linux.go",
"new_path": "pkg/abi/linux/linux.go",
"diff": "@@ -31,6 +31,7 @@ type Sysinfo struct {\nTotalSwap uint64\nFreeSwap uint64\nProcs uint16\n+ _ [6]byte // Pad Procs to 64bits.\nTotalHigh uint64\nFreeHigh uint64\nUnit uint32\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Add memunit to sysinfo(2).
Also properly add padding after Procs in the linux.Sysinfo
structure. This will be implicitly padded to 64bits so we
need to do the same.
PiperOrigin-RevId: 216372907
Change-Id: I6eb6a27800da61d8f7b7b6e87bf0391a48fdb475 |
259,854 | 09.10.2018 15:11:46 | 25,200 | c36d2ef3733a0619b992f8ddc23b072474b04044 | Add new netstack metrics to the sentry | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -48,9 +48,6 @@ var (\n// TODO: Support metric fields.\n//\ntype Uint64Metric struct {\n- // metadata describes the metric. It is immutable.\n- metadata *pb.MetricMetadata\n-\n// value is th... | Go | Apache License 2.0 | google/gvisor | Add new netstack metrics to the sentry
PiperOrigin-RevId: 216431260
Change-Id: Ia6e5c8d506940148d10ff2884cf4440f470e5820 |
259,992 | 09.10.2018 21:06:18 | 25,200 | 20508bafb88d2037ea3b2c8483b191ce72e7ad7e | Add tests to verify gofer is chroot'ed | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/debug.go",
"new_path": "runsc/cmd/debug.go",
"diff": "@@ -85,7 +85,7 @@ func (d *Debug) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nif err != nil {\nFatalf(\"error loading container %q: %v\", id, err)\n}\n- if candidate.Pid() ==... | Go | Apache License 2.0 | google/gvisor | Add tests to verify gofer is chroot'ed
PiperOrigin-RevId: 216472439
Change-Id: Ic4cb86c8e0a9cb022d3ceed9dc5615266c307cf9 |
260,026 | 10.10.2018 14:17:27 | 25,200 | 8388a505e735045f31c6f7180711ef57148dc517 | Support for older Linux kernels without getrandom | [
{
"change_type": "MODIFY",
"old_path": "pkg/rand/rand_linux.go",
"new_path": "pkg/rand/rand_linux.go",
"diff": "package rand\nimport (\n+ \"crypto/rand\"\n\"io\"\n+ \"sync\"\n\"golang.org/x/sys/unix\"\n)\n// reader implements an io.Reader that returns pseudorandom bytes.\n-type reader struct{}\n+typ... | Go | Apache License 2.0 | google/gvisor | Support for older Linux kernels without getrandom
Change-Id: I1fb9f5b47a264a7617912f6f56f995f3c4c5e578
PiperOrigin-RevId: 216591484 |
259,891 | 10.10.2018 16:49:40 | 25,200 | e21ba16d9cf7ba4f2d5f65651e06ab592032ef86 | Removes irrelevant TODO. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -501,9 +501,6 @@ func (l *Loader) startContainer(k *kernel.Kernel, spec *specs.Spec, conf *Config\ncaps,\nl.k.RootUserNamespace())\n- // TODO New containers should be started in new PID nam... | Go | Apache License 2.0 | google/gvisor | Removes irrelevant TODO.
PiperOrigin-RevId: 216616873
Change-Id: I4d974ab968058eadd01542081e18a987ef08f50a |
259,948 | 11.10.2018 11:40:34 | 25,200 | 0bfa03d61c7791aad03da5ac021bc60e4578858e | sentry: allow saving of unlinked files with open fds on virtual fs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent_state.go",
"new_path": "pkg/sentry/fs/dirent_state.go",
"diff": "@@ -23,16 +23,20 @@ import (\n// beforeSave is invoked by stateify.\nfunc (d *Dirent) beforeSave() {\n- // Refuse to save if the file has already been deleted (but still has\... | Go | Apache License 2.0 | google/gvisor | sentry: allow saving of unlinked files with open fds on virtual fs.
PiperOrigin-RevId: 216733414
Change-Id: I33cd3eb818f0c39717d6656fcdfff6050b37ebb0 |
259,992 | 11.10.2018 11:56:42 | 25,200 | d40d80106988e9302aaa354d4f58caa6c31429b4 | Sandbox cgroup tests
Verify that cgroup is being properly set. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -123,6 +123,8 @@ func fillFromAncestor(path string) (string, error) {\nreturn val, nil\n}\n+// countCpuset returns the number of CPU in a string formatted like:\n+// \"0-2,7,12-14 # bit... | Go | Apache License 2.0 | google/gvisor | Sandbox cgroup tests
Verify that cgroup is being properly set.
PiperOrigin-RevId: 216736137
Change-Id: I0e27fd604eca67e7dd2e3548dc372ca9cc416309 |
259,992 | 11.10.2018 14:28:15 | 25,200 | e68d86e1bd47f7905e4452f7ce0e04e683561f85 | Make debug log file name configurable
This is a breaking change if you're using --debug-log-dir.
The fix is to replace it with --debug-log and add a '/' at
the end:
--debug-log-dir=/tmp/runsc ==> --debug-log=/tmp/runsc/ | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -297,7 +297,7 @@ Docker configuration (`/etc/docker/daemon.json`):\n\"runsc\": {\n\"path\": \"/usr/local/bin/runsc\",\n\"runtimeArgs\": [\n- \"--debug-log-dir=/tmp/runsc\",\n+ \"--debug-log=/tmp/runsc/\",\n\"--d... | Go | Apache License 2.0 | google/gvisor | Make debug log file name configurable
This is a breaking change if you're using --debug-log-dir.
The fix is to replace it with --debug-log and add a '/' at
the end:
--debug-log-dir=/tmp/runsc ==> --debug-log=/tmp/runsc/
PiperOrigin-RevId: 216761212
Change-Id: I244270a0a522298c48115719fa08dad55e34ade1 |
259,992 | 11.10.2018 15:20:52 | 25,200 | 86680fa00240e3e439d1275f4f8bf89678cf3355 | Add String() method to AddressMask | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -139,6 +139,11 @@ type Address string\n// AddressMask is a bitmask for an address.\ntype AddressMask string\n+// String implements Stringer.\n+func (a AddressMask) String() string {\n+ return A... | Go | Apache License 2.0 | google/gvisor | Add String() method to AddressMask
PiperOrigin-RevId: 216770391
Change-Id: Idcdc28b2fe9e1b0b63b8119d445f05a8bcbce81e |
259,992 | 11.10.2018 17:44:50 | 25,200 | f074f0c2c77c4aec24700a49ebcbca1a7f2285e0 | Make the gofer process enter namespaces
This is done to further isolate the gofer from the host. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -726,11 +726,21 @@ func (c *Container) createGoferProcess(spec *specs.Spec, conf *boot.Config, bund\ncmd := exec.Command(binPath, args...)\ncmd.ExtraFiles = goferEnds\n+ // ... | Go | Apache License 2.0 | google/gvisor | Make the gofer process enter namespaces
This is done to further isolate the gofer from the host.
PiperOrigin-RevId: 216790991
Change-Id: Ia265b77e4e50f815d08f743a05669f9d75ad7a6f |
259,884 | 12.10.2018 12:58:42 | 25,200 | a771775f3a4680b3a121deb6f583ed62f4da8bef | Added spec command to create OCI spec config.json
The spec command is analygous to the 'runc spec' command and allows for
the convenient creation of a config.json file for users that don't have
runc handy. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/BUILD",
"new_path": "runsc/cmd/BUILD",
"diff": "@@ -23,6 +23,7 @@ go_library(\n\"restore.go\",\n\"resume.go\",\n\"run.go\",\n+ \"spec.go\",\n\"start.go\",\n\"state.go\",\n\"wait.go\",\n"
},
{
"change_type": "ADD",
"old_path": null,
"n... | Go | Apache License 2.0 | google/gvisor | Added spec command to create OCI spec config.json
The spec command is analygous to the 'runc spec' command and allows for
the convenient creation of a config.json file for users that don't have
runc handy.
Change-Id: Ifdfec37e023048ea461c32da1a9042a45b37d856
PiperOrigin-RevId: 216907826 |
259,891 | 12.10.2018 13:57:10 | 25,200 | 47d3862c33b7b74b451ea71139abdea34d5b46bd | runsc: Support retrieving MTU via netdevice ioctl.
This enables ifconfig to display MTU. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -1266,9 +1266,10 @@ func interfaceIoctl(ctx context.Context, io usermem.IO, arg int, ifr *linux.IFRe\n// Gets the metric of the device. As per netdevice(... | Go | Apache License 2.0 | google/gvisor | runsc: Support retrieving MTU via netdevice ioctl.
This enables ifconfig to display MTU.
PiperOrigin-RevId: 216917021
Change-Id: Id513b23d9d76899bcb71b0b6a25036f41629a923 |
259,948 | 15.10.2018 09:30:49 | 25,200 | 4ea69fce8def9e030cbbc4d803b95e632175750c | sentry: save fs.Dirent deleted info. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -119,7 +119,7 @@ type Dirent struct {\nparent *Dirent\n// deleted may be set atomically when removed.\n- deleted int32 `state:\"nosave\"`\n+ deleted int32\n// frozen indicates this en... | Go | Apache License 2.0 | google/gvisor | sentry: save fs.Dirent deleted info.
PiperOrigin-RevId: 217155458
Change-Id: Id3265b1ec784787039e2131c80254ac4937330c7 |
259,854 | 15.10.2018 20:21:06 | 25,200 | 324ad3564ba42a5106be77a06d0cd52290e1cd22 | Refactor host.ConnectedEndpoint
* Integrate recvMsg and sendMsg functions into Recv and Send respectively as
they are no longer shared.
* Clean up partial read/write error handling code.
* Re-order code to make sense given that there is no longer a host.endpoint
type. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/socket.go",
"new_path": "pkg/sentry/fs/host/socket.go",
"diff": "@@ -41,137 +41,6 @@ import (\n// N.B. 8MB is the default maximum on Linux (2 * sysctl_wmem_max).\nconst maxSendBufferSize = 8 << 20\n-// newSocket allocates a new unix socket w... | Go | Apache License 2.0 | google/gvisor | Refactor host.ConnectedEndpoint
* Integrate recvMsg and sendMsg functions into Recv and Send respectively as
they are no longer shared.
* Clean up partial read/write error handling code.
* Re-order code to make sense given that there is no longer a host.endpoint
type.
PiperOrigin-RevId: 217255072
Change-Id: Ib43fe9286452f813b8309d969be11f5fa40694cd |
259,992 | 17.10.2018 09:30:11 | 25,200 | ba33a70e47492f9cc8e3550ed795c892553ac1d4 | Attempt to deflake TestPythonHello
It has timed out running with kokoro a few times. I passes
consistently on my machine (200+ runsc). Increase the timeout
to see if it helps.
Failure: image_test.go:212: WaitForHTTP() timeout: Get dial tcp [::1]:32785: connect: connection refused | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/image_test.go",
"new_path": "runsc/test/image/image_test.go",
"diff": "@@ -208,7 +208,7 @@ func TestPythonHello(t *testing.T) {\n}\n// Wait until it's up and running.\n- if err := testutil.WaitForHTTP(port, 20*time.Second); err != nil {\n+ if ... | Go | Apache License 2.0 | google/gvisor | Attempt to deflake TestPythonHello
It has timed out running with kokoro a few times. I passes
consistently on my machine (200+ runsc). Increase the timeout
to see if it helps.
Failure: image_test.go:212: WaitForHTTP() timeout: Get http://localhost:32785/: dial tcp [::1]:32785: connect: connection refused
PiperOrigin-RevId: 217532428
Change-Id: Ibf860aecf537830bef832e436f2e804b3fc12f2d |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.