author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,872 | 03.12.2021 14:42:02 | -28,800 | b993286092b9ad1cdc90a5788c665e25c8f31514 | blog: adjust blog content
Resize image 2021-12-02-flamegraph-figure2.png. Adjust
some paragraph and getpid performance tables. | [
{
"change_type": "MODIFY",
"old_path": "website/assets/images/2021-12-02-flamegraph-figure2.png",
"new_path": "website/assets/images/2021-12-02-flamegraph-figure2.png",
"diff": "Binary files a/website/assets/images/2021-12-02-flamegraph-figure2.png and b/website/assets/images/2021-12-02-flamegraph-f... | Go | Apache License 2.0 | google/gvisor | blog: adjust blog content
Resize image 2021-12-02-flamegraph-figure2.png. Adjust
some paragraph and getpid performance tables.
Signed-off-by: Yong He <chenglang.hy@antgroup.com>
Signed-off-by: Jianfeng Tan <henry.tjf@antgroup.com> |
260,004 | 09.12.2021 15:14:03 | 28,800 | 7f4b03068f03fa20e1f152b3ba4dc66f16a7d7ce | Support NATing ICMPv6 Echo packets
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/icmpv6.go",
"new_path": "pkg/tcpip/header/icmpv6.go",
"diff": "@@ -240,6 +240,13 @@ func (b ICMPv6) SetIdent(ident uint16) {\nbinary.BigEndian.PutUint16(b[icmpv6IdentOffset:], ident)\n}\n+// SetIdentWithChecksumUpdate sets the Ident field and ... | Go | Apache License 2.0 | google/gvisor | Support NATing ICMPv6 Echo packets
Updates #5915.
PiperOrigin-RevId: 415367088 |
259,853 | 09.12.2021 21:48:18 | 28,800 | 4d29819e13a14f0d14e79586851364a4939f0ffe | pipe: have separate notifiers for readers and writers
This change fixes a busy loop in the pipe code. VFSPipe.Open calls ctx.BlockOn
to wait an opposite side, but waitQueue.EventRegister always triggers
EventInternal, so we never block.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/node.go",
"new_path": "pkg/sentry/kernel/pipe/node.go",
"diff": "@@ -75,7 +75,7 @@ func (i *inodeOperations) GetFile(ctx context.Context, d *fs.Dirent, flags fs.Fi\ncase flags.Read && !flags.Write: // O_RDONLY.\nr := i.p.Open(ctx, d, fla... | Go | Apache License 2.0 | google/gvisor | pipe: have separate notifiers for readers and writers
This change fixes a busy loop in the pipe code. VFSPipe.Open calls ctx.BlockOn
to wait an opposite side, but waitQueue.EventRegister always triggers
EventInternal, so we never block.
Reported-by: syzbot+773e19ca2574516c9e00@syzkaller.appspotmail.com
PiperOrigin-RevId: 415428542 |
259,909 | 10.12.2021 17:08:00 | 28,800 | 75bfc5e0e9cc68c87c0a4195b73cc786db2a9920 | Resolve to the last mount in the stack during umount.
This is done in linux with the LOOKUP_MOUNTPOINT flag. We emulate this behavior
in gVisor with getMountAt(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -297,10 +297,21 @@ func (vfs *VirtualFilesystem) UmountAt(ctx context.Context, creds *auth.Credenti\nif err != nil {\nreturn err\n}\n- defer vd.DecRef(ctx)\n- if vd.dentry != vd.mount... | Go | Apache License 2.0 | google/gvisor | Resolve to the last mount in the stack during umount.
This is done in linux with the LOOKUP_MOUNTPOINT flag. We emulate this behavior
in gVisor with getMountAt().
PiperOrigin-RevId: 415642095 |
259,909 | 13.12.2021 12:01:15 | 28,800 | a9938e0f142c02f9a0eb11121102b50392d596ef | Document confusing defer behavior in mount.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -297,6 +297,11 @@ func (vfs *VirtualFilesystem) UmountAt(ctx context.Context, creds *auth.Credenti\nif err != nil {\nreturn err\n}\n+ // This defer statement is encapsulated in a func... | Go | Apache License 2.0 | google/gvisor | Document confusing defer behavior in mount.go.
PiperOrigin-RevId: 416100664 |
259,898 | 13.12.2021 13:57:00 | 28,800 | ef0119d3d08079a735129d4c62c4d9aec64b9328 | Ignore ethernet paddings in parsing
PacketImpact testbench did not take into account that ethernet frames can have
paddings, which can cause test failures. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/layers.go",
"new_path": "test/packetimpact/testbench/layers.go",
"diff": "@@ -215,23 +215,34 @@ func NetworkProtocolNumber(v tcpip.NetworkProtocolNumber) *tcpip.NetworkProtocol\nreturn &v\n}\n+// bodySizeHint describes num of bytes ... | Go | Apache License 2.0 | google/gvisor | Ignore ethernet paddings in parsing
PacketImpact testbench did not take into account that ethernet frames can have
paddings, which can cause test failures.
PiperOrigin-RevId: 416127829 |
259,962 | 13.12.2021 23:36:02 | 28,800 | c06c9deb1c71f235f646c4dc644e848df748c2da | Add support for virtio net headers in sharedmem endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/eventfd/BUILD",
"new_path": "pkg/eventfd/BUILD",
"diff": "@@ -8,7 +8,10 @@ go_library(\n\"eventfd.go\",\n\"eventfd_unsafe.go\",\n],\n- visibility = [\"//:sandbox\"],\n+ visibility = [\n+ \"//:sandbox\",\n+ \"//cloud/cluster/node/network/client/go:__pkg__\"... | Go | Apache License 2.0 | google/gvisor | Add support for virtio net headers in sharedmem endpoint.
PiperOrigin-RevId: 416221825 |
259,853 | 14.12.2021 00:03:19 | 28,800 | 7f72261ad1d0d6eaa5688d595983e6d7e64b1fa9 | test/fifo: check that open blocks and can be interrupted
and move fifo test cases to a separate test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -306,6 +306,11 @@ syscall_test(\ntest = \"//test/syscalls/linux:mknod_test\",\n)\n+syscall_test(\n+ add_overlay = True,\n+ test = \"//test/syscalls/linux:fifo_test\",\n+)\n+\nsyscall_test(\nt... | Go | Apache License 2.0 | google/gvisor | test/fifo: check that open blocks and can be interrupted
and move fifo test cases to a separate test.
PiperOrigin-RevId: 416225961 |
259,898 | 15.12.2021 12:31:05 | 28,800 | 164a2fe386c73d28bef0954c66046b4a2b05c879 | Remove unused docker image
Remove packetimpact docker image
Update Makefile to remove unnecessary steps
Remove unused runner flags | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -231,6 +231,10 @@ syscall-tests: ## Run all system call tests.\n@$(call test,$(PARTITIONS) test/syscalls/...)\n.PHONY: syscall-tests\n+packetimpact-tests:\n+ @$(call test,--jobs=HOST_CPUS*3 --local_test_jobs=HOST_... | Go | Apache License 2.0 | google/gvisor | Remove unused docker image
- Remove packetimpact docker image
- Update Makefile to remove unnecessary steps
- Remove unused runner flags
PiperOrigin-RevId: 416621865 |
259,962 | 15.12.2021 12:48:40 | 28,800 | fe88fe67683ad3516425e8111c3074184e370b82 | Support custom socket options in hostinet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netdevice.go",
"new_path": "pkg/abi/linux/netdevice.go",
"diff": "@@ -86,3 +86,37 @@ type IFConf struct {\n_ [4]byte // Pad to sizeof(struct ifconf).\nPtr uint64\n}\n+\n+// EthtoolCmd is a marshallable type to be able to easily copyin the\n+// th... | Go | Apache License 2.0 | google/gvisor | Support custom socket options in hostinet.
PiperOrigin-RevId: 416625574 |
260,004 | 15.12.2021 13:06:52 | 28,800 | 7b6078e25245da877dc03656a9af35403abdad36 | Provide MTU for pipe LinkEndpoint
...so that callers can set different MTUs for different configurations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/pipe/pipe.go",
"new_path": "pkg/tcpip/link/pipe/pipe.go",
"diff": "@@ -26,12 +26,14 @@ import (\nvar _ stack.LinkEndpoint = (*Endpoint)(nil)\n// New returns both ends of a new pipe.\n-func New(linkAddr1, linkAddr2 tcpip.LinkAddress) (*Endpoint, ... | Go | Apache License 2.0 | google/gvisor | Provide MTU for pipe LinkEndpoint
...so that callers can set different MTUs for different configurations.
PiperOrigin-RevId: 416629560 |
260,004 | 15.12.2021 14:18:00 | 28,800 | bb129b4becfa09346eb4e2a88dcaf96dbe9a2c0f | Consider ethernet header size when returning MTU
...so that upper-layers do not send larger than expected packets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/ethernet/ethernet.go",
"new_path": "pkg/tcpip/link/ethernet/ethernet.go",
"diff": "@@ -50,6 +50,14 @@ func (e *Endpoint) LinkAddress() tcpip.LinkAddress {\nreturn header.UnspecifiedEthernetAddress\n}\n+// MTU implements stack.LinkEndpoint.\n+fun... | Go | Apache License 2.0 | google/gvisor | Consider ethernet header size when returning MTU
...so that upper-layers do not send larger than expected packets.
PiperOrigin-RevId: 416645503 |
259,898 | 15.12.2021 14:44:22 | 28,800 | 3ac6a70159af43177b12e71a66e2a6b2db6098a4 | Remove stale TODO
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/dut.go",
"new_path": "test/packetimpact/dut/dut.go",
"diff": "@@ -134,9 +134,9 @@ func Run(dut DUT) error {\n// WaitForServer waits for a pattern to occur in posix_server's logs.\nfunc WaitForServer(output io.Reader) error {\n- // TODO(gv... | Go | Apache License 2.0 | google/gvisor | Remove stale TODO
Fixes #6835.
PiperOrigin-RevId: 416651232 |
260,004 | 15.12.2021 17:08:59 | 28,800 | 5baf7212b778324cca324a60739e7733614425f9 | Fix error getting IPv6 option on IPv4 socket
Previously returned ENOPROTOOPT but should return EOPNOTSUPP to match
Linux. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1302,7 +1302,7 @@ func getSockOptIPv6(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, name\nfamily, skType, _ := s.Type()\nif family != linux.AF_... | Go | Apache License 2.0 | google/gvisor | Fix error getting IPv6 option on IPv4 socket
Previously returned ENOPROTOOPT but should return EOPNOTSUPP to match
Linux.
PiperOrigin-RevId: 416680620 |
259,951 | 20.12.2021 10:08:15 | 28,800 | ec18c6bcf9760b8a6a8eaed61ee0f6cb915b9466 | Add default TTL test for udp and tcp endpoints
Simplify the retrieval of the default TTL and include multicast flow in
the UDP SetTTL tests.
Add IPv6 protocol coverage for the TCP TTL tests | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -3403,14 +3403,81 @@ func TestSendGreaterThanMTU(t *testing.T) {\ntestBrokenUpWrite(t, c, maxPayload)\n}\n+func TestDefaultTTL(t *testing.T) {\n+ for _, test :... | Go | Apache License 2.0 | google/gvisor | Add default TTL test for udp and tcp endpoints
Simplify the retrieval of the default TTL and include multicast flow in
the UDP SetTTL tests.
Add IPv6 protocol coverage for the TCP TTL tests
PiperOrigin-RevId: 417429943 |
260,004 | 20.12.2021 10:45:51 | 28,800 | b26b4610bfb7bf37821ab33ad51ace3c6ece81dd | Use available helpers to set fields
...and introduce a helper to set the Checksum. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/checksum.go",
"new_path": "pkg/tcpip/header/checksum.go",
"diff": "@@ -24,6 +24,11 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n)\n+// PutChecksum puts the checksum in the provided byte slice.\n+func PutChecksum(b []byte, xsum uint16) ... | Go | Apache License 2.0 | google/gvisor | Use available helpers to set fields
...and introduce a helper to set the Checksum.
PiperOrigin-RevId: 417437300 |
260,004 | 20.12.2021 17:02:59 | 28,800 | 7fe91395d24ca17e3c75de6e3b8d007cbeb781f9 | Check rules without holding locks
...so that IPTables is re-enterant.
This is to prepare for a later change where an IPTables target will
attempt to send a packet which will have to go through IPTables. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -219,6 +219,11 @@ func EmptyNATTable() Table {\nfunc (it *IPTables) GetTable(id TableID, ipv6 bool) Table {\nit.mu.RLock()\ndefer it.mu.RUnlock()\n+ return it.getTableRLocked(... | Go | Apache License 2.0 | google/gvisor | Check rules without holding locks
...so that IPTables is re-enterant.
This is to prepare for a later change where an IPTables target will
attempt to send a packet which will have to go through IPTables.
PiperOrigin-RevId: 417505430 |
259,853 | 21.12.2021 10:16:59 | 28,800 | b76119a1e786b51d012d358ba8711fc9d709e046 | pipe: a reader has to wait when all writers will be notified
Otherwise, we can have a race when a reader cloes a pipe before
a write detects this reader. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/node.go",
"new_path": "pkg/sentry/kernel/pipe/node.go",
"diff": "package pipe\nimport (\n+ \"sync/atomic\"\n+\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/errors/linuxerr\"\n@@ -73,8 +7... | Go | Apache License 2.0 | google/gvisor | pipe: a reader has to wait when all writers will be notified
Otherwise, we can have a race when a reader cloes a pipe before
a write detects this reader.
PiperOrigin-RevId: 417645683 |
260,004 | 21.12.2021 10:18:40 | 28,800 | e0e530c1cde723b63e4e7dcc957350e7213358bb | Drop icmpReason.isForwarding
To prepare for later changes where IPTables can send any ICMP error
from either the Input, Forward or Output hook. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -219,7 +219,7 @@ func (e *endpoint) handleICMP(pkt *stack.PacketBuffer) {\nif optProblem.NeedICMP {\n_ = e.protocol.returnError(&icmpReasonParamProblem{\npointer: optPro... | Go | Apache License 2.0 | google/gvisor | Drop icmpReason.isForwarding
To prepare for later changes where IPTables can send any ICMP error
from either the Input, Forward or Output hook.
PiperOrigin-RevId: 417646060 |
260,004 | 21.12.2021 13:55:29 | 28,800 | e57939e24aa6ca1bf25e32dd5f591503f5ba8c56 | Update googletest to v1.11.0 | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -636,11 +636,11 @@ grpc_extra_deps()\nhttp_archive(\nname = \"com_google_googletest\",\n- sha256 = \"0a10bea96d8670e5eef948d79d824162b1577bb7889539e49ec786bfc3e48912\",\n- strip_prefix = \"googletest-565f1b84821... | Go | Apache License 2.0 | google/gvisor | Update googletest to v1.11.0
https://github.com/google/googletest/releases/tag/release-1.11.0.
PiperOrigin-RevId: 417685256 |
260,004 | 21.12.2021 15:00:16 | 28,800 | beaecd1e3cb00e1766e498f613adaaabe1f5ac37 | Support SOL_ICMPV6 -> ICMPV6_FILTER | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ip.go",
"new_path": "pkg/abi/linux/ip.go",
"diff": "@@ -159,3 +159,8 @@ const (\nIPV6_RECVFRAGSIZE = 77\nIPV6_FREEBIND = 78\n)\n+\n+// Socket options from uapi/linux/icmpv6.h\n+const (\n+ ICMPV6_FILTER = 1\n+)\n"
},
{
"change_type": "MODI... | Go | Apache License 2.0 | google/gvisor | Support SOL_ICMPV6 -> ICMPV6_FILTER
PiperOrigin-RevId: 417696519 |
259,909 | 21.12.2021 16:07:13 | 28,800 | d54045f34aa51661116a62604be12dc77ce1d627 | Implement the pivot_root syscall. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1844,3 +1844,30 @@ func (k *Kernel) ReleaseCgroupHierarchy(hid uint32) {\n})\nk.tasks.mu.RUnlock()\n}\n+\n+func (k *Kernel) ReplaceFSContextRoots(ctx context.Context, oldRoot... | Go | Apache License 2.0 | google/gvisor | Implement the pivot_root syscall.
PiperOrigin-RevId: 417707787 |
259,853 | 21.12.2021 17:10:51 | 28,800 | 271e4f4ae6db20240ad5f2cb195e681a5ed5ca9f | kernel/pipe: clean up unused fields from the Pipe structure
They have been added by mistake. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/pipe.go",
"new_path": "pkg/sentry/kernel/pipe/pipe.go",
"diff": "@@ -168,13 +168,6 @@ type Pipe struct {\n//\n// This is protected by mu.\nhadWriter bool\n-\n- // waitingWriters is used to wait when writers are initialized after a\n- // ... | Go | Apache License 2.0 | google/gvisor | kernel/pipe: clean up unused fields from the Pipe structure
They have been added by mistake.
PiperOrigin-RevId: 417716586 |
260,004 | 21.12.2021 20:20:41 | 28,800 | c299f605d3704422d50b1f159ae6492ab36cad3e | Remove unused WritePackets helpers
dropped the WritePackets family of functions for layers above the
LinkEndpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -572,56 +572,6 @@ func (it *IPTables) startReaper(interval time.Duration) {\n}()\n}\n-// CheckOutputPackets performs the output hook on the packets.\n-//\n-// Returns a map of... | Go | Apache License 2.0 | google/gvisor | Remove unused WritePackets helpers
https://github.com/google/gvisor/commit/fd89c0892ba7ff2c1e1d0bc91e181488f2f4ca8f
dropped the WritePackets family of functions for layers above the
LinkEndpoint.
PiperOrigin-RevId: 417737737 |
260,004 | 27.12.2021 11:17:22 | 28,800 | 76776aad8b3c3de915e9307a8c436af0cdbcfa21 | Perform Output hook for ICMPv4 Reply
Before this change, locally generated ICMPv4 replies would not
perform the Output hook so NAT will not be performed for locally
generated ICMPv4 replies. This change fixes that bug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n\"gvisor.dev/gvisor/pkg/tcpip/header\"\n+ \"gvisor.dev/gvisor/pkg/tcpip... | Go | Apache License 2.0 | google/gvisor | Perform Output hook for ICMPv4 Reply
Before this change, locally generated ICMPv4 replies would not
perform the Output hook so NAT will not be performed for locally
generated ICMPv4 replies. This change fixes that bug.
PiperOrigin-RevId: 418513563 |
260,004 | 27.12.2021 11:19:12 | 28,800 | 9c9fdfa07542d264b39e017b3e7df9d4de7b4b83 | Populate ethernet header fields from packet buffer
...instead of the arguments provided in the call to WritePackets.
QDisc always passes 0 for the protocol for calls to WritePackets as
each packet may have a different protocol number.
A later change will remove the unnecessary arguments from WritePackets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/ethernet/ethernet.go",
"new_path": "pkg/tcpip/link/ethernet/ethernet.go",
"diff": "@@ -91,7 +91,7 @@ func (e *Endpoint) WritePackets(r stack.RouteInfo, pkts stack.PacketBufferList,\nlinkAddr := e.LinkAddress()\nfor pkt := pkts.Front(); pkt != ni... | Go | Apache License 2.0 | google/gvisor | Populate ethernet header fields from packet buffer
...instead of the arguments provided in the call to WritePackets.
QDisc always passes 0 for the protocol for calls to WritePackets as
each packet may have a different protocol number.
A later change will remove the unnecessary arguments from WritePackets.
PiperOrigin-RevId: 418513699 |
259,898 | 28.12.2021 12:38:32 | 28,800 | 6838e0fe246e124f3403373bbdd4e6696ba517f3 | Remove unused build target
The new packetimpact runner no longer requires static linking for posix_server | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/BUILD",
"new_path": "test/packetimpact/dut/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"cc_binary\", \"go_library\", \"grpcpp\")\npackage(\n- default_visibility = [\"//test/packetimpact:__subpackages__\"],\nlicenses = [\"notice\"],\n)\nc... | Go | Apache License 2.0 | google/gvisor | Remove unused build target
The new packetimpact runner no longer requires static linking for posix_server
PiperOrigin-RevId: 418664824 |
259,951 | 29.12.2021 12:31:04 | 28,800 | 58b9bdfc21e792c5d529ec9f4ab0b2f2cd1ee082 | Use protocol-specific options for TTL/HopLimit
The new HopLimit matches the IPV6_UNICAST_HOPS socket option.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1351,6 +1351,26 @@ func getSockOptIPv6(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, name\nv := primitive.Int32(boolToInt32(ep.SocketOptions().... | Go | Apache License 2.0 | google/gvisor | Use protocol-specific options for TTL/HopLimit
The new HopLimit matches the IPV6_UNICAST_HOPS socket option.
Updates #6389
PiperOrigin-RevId: 418831844 |
259,888 | 29.12.2021 21:27:56 | 21,600 | 871aaa768d0a6357e044d113a46eaf3f0abbd86a | tools/checklocks: fix typo in readme | [
{
"change_type": "MODIFY",
"old_path": "tools/checklocks/README.md",
"new_path": "tools/checklocks/README.md",
"diff": "@@ -88,7 +88,7 @@ greater than 100%, if the lock is held multiple times. For example:\nfunc foo(ts1 *testStruct, ts2 *testStruct) {\nts1.Lock()\nts2.Lock()\n- ts1.gaurdedField = 1 ... | Go | Apache License 2.0 | google/gvisor | tools/checklocks: fix typo in readme |
260,004 | 31.12.2021 21:30:17 | 28,800 | b488df0a2f15ba21603610bdb13d8656b856218f | Support SOL_IPV6 -> IPV6_CHECKSUM | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1343,6 +1343,19 @@ func getSockOptIPv6(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, name\n}\nswitch name {\n+ case linux.IPV6_CHECKSUM:\n+ if ... | Go | Apache License 2.0 | google/gvisor | Support SOL_IPV6 -> IPV6_CHECKSUM
PiperOrigin-RevId: 419164074 |
259,853 | 04.01.2022 16:23:33 | 28,800 | 52bee5297caf67ddb7bb6d23035255e09cb10861 | unix: call Listening under the endpoint lock | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/socket.go",
"new_path": "pkg/sentry/fs/gofer/socket.go",
"diff": "@@ -93,7 +93,7 @@ func (e *endpoint) BidirectionalConnect(ctx context.Context, ce transport.Connec\nce.Unlock()\nreturn syserr.ErrAlreadyConnected\n}\n- if ce.Listening() {\n... | Go | Apache License 2.0 | google/gvisor | unix: call Listening under the endpoint lock
PiperOrigin-RevId: 419703575 |
259,853 | 04.01.2022 22:43:14 | 28,800 | 496ba59add3c7f1495c879d6fb79fedc19a8b33e | Deflake the socket_inet_loopback test
Don't close sockets for writing otherwise sendto can fail with EPIPE. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -1562,7 +1562,7 @@ TEST_P(SocketInetReusePortTest, UdpPortReuseMultiThread) {\n// Shutdown all sockets to wake up other threads.\nfor (int j = ... | Go | Apache License 2.0 | google/gvisor | Deflake the socket_inet_loopback test
Don't close sockets for writing otherwise sendto can fail with EPIPE.
PiperOrigin-RevId: 419751558 |
259,868 | 05.01.2022 13:20:41 | 28,800 | d057161dc81a0359e92fa86b4038fe72740020fe | Make `SyscallTable.lookup` be a fixed-size array rather than a slice.
Same for `SyscallFlagsTable.enable`.
This avoids a few extra memory reads during syscall execution, at the expense
of holding two slightly-larger-than-necessary-in-practice lookup arrays in
memory. Syscall latency overhead should be improved very slightly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/syscalls.go",
"new_path": "pkg/sentry/kernel/syscalls.go",
"diff": "@@ -25,12 +25,14 @@ import (\n\"gvisor.dev/gvisor/pkg/sync\"\n)\n+const (\n// maxSyscallNum is the highest supported syscall number.\n//\n// The types below create fast looku... | Go | Apache License 2.0 | google/gvisor | Make `SyscallTable.lookup` be a fixed-size array rather than a slice.
Same for `SyscallFlagsTable.enable`.
This avoids a few extra memory reads during syscall execution, at the expense
of holding two slightly-larger-than-necessary-in-practice lookup arrays in
memory. Syscall latency overhead should be improved very slightly.
PiperOrigin-RevId: 419898650 |
259,898 | 05.01.2022 16:44:54 | 28,800 | 66ad3a56574a393da544b5a9e97393d03525bc8b | Update PacketImpact README
Make the README accurate by not mentioning docker containers. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/README.md",
"new_path": "test/packetimpact/README.md",
"diff": "Packetimpact is a tool for platform-independent network testing. It is heavily\ninspired by [packetdrill](https://github.com/google/packetdrill). It creates two\n-docker containe... | Go | Apache License 2.0 | google/gvisor | Update PacketImpact README
Make the README accurate by not mentioning docker containers.
PiperOrigin-RevId: 419940405 |
259,853 | 06.01.2022 10:33:27 | 28,800 | aa06a0cc20fda0a5cd6cbe122d29dc0756448af9 | vdso: remove empty note section
An empty note section looks weird and can confuse some tools. For example,
we've seen this in | [
{
"change_type": "MODIFY",
"old_path": "vdso/vdso_amd64.lds",
"new_path": "vdso/vdso_amd64.lds",
"diff": "@@ -43,8 +43,6 @@ SECTIONS {\n.gnu.version_d : { *(.gnu.version_d) }\n.gnu.version_r : { *(.gnu.version_r) }\n- .note : { *(.note.*) } :text :note\n-\n.eh_frame_hdr : { *(.eh_frame_hdr) } :text ... | Go | Apache License 2.0 | google/gvisor | vdso: remove empty note section
An empty note section looks weird and can confuse some tools. For example,
we've seen this in https://reviews.llvm.org/D116639.
PiperOrigin-RevId: 420093551 |
259,907 | 06.01.2022 14:51:24 | 28,800 | d7dbf65873e2e05723ea23fbfa414742342456e9 | Add Bind RPC to gvisor's 9P protocol and implement it in runsc/fsgofer.
This new RPC allows a client to be able to bind (and hence create) UDS on the
host filesystem. Following changes will add functionality to listen and accept
on such a bound UDS. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/client_file.go",
"new_path": "pkg/p9/client_file.go",
"diff": "@@ -348,6 +348,37 @@ func (c *clientFile) Open(flags OpenFlags) (*fd.FD, QID, uint32, error) {\nreturn rlopen.File, rlopen.QID, rlopen.IoUnit, nil\n}\n+func (c *clientFile) Bind(sockType uin... | Go | Apache License 2.0 | google/gvisor | Add Bind RPC to gvisor's 9P protocol and implement it in runsc/fsgofer.
This new RPC allows a client to be able to bind (and hence create) UDS on the
host filesystem. Following changes will add functionality to listen and accept
on such a bound UDS.
PiperOrigin-RevId: 420149313 |
260,004 | 06.01.2022 17:08:48 | 28,800 | 381a17d92329370c8807ba14962746debb06ae83 | Support REJECT hook | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/icmpv4.go",
"new_path": "pkg/tcpip/header/icmpv4.go",
"diff": "@@ -102,13 +102,17 @@ const (\nICMPv4ReassemblyTimeout ICMPv4Code = 1\n)\n-// ICMP codes for ICMPv4 Destination Unreachable messages as defined in RFC 792.\n+// ICMP codes for ICMP... | Go | Apache License 2.0 | google/gvisor | Support REJECT hook
PiperOrigin-RevId: 420174647 |
259,962 | 06.01.2022 17:30:26 | 28,800 | f2a57c9dac27bd6dcd1c53156d94bdcbdb7a542e | Fixes multiple bugs in server_rx implementation.
fillPacket was incorrectly setting the buffer sizes and
causing large packets to be egressed incorrectly resulting
in packet drops when the MTU was > buffer size. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/BUILD",
"new_path": "pkg/tcpip/link/sharedmem/BUILD",
"diff": "@@ -56,15 +56,18 @@ go_test(\nsrcs = [\"sharedmem_server_test.go\"],\ndeps = [\n\":sharedmem\",\n+ \"//pkg/log\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/adapters/gonet\",\n\"//pk... | Go | Apache License 2.0 | google/gvisor | Fixes multiple bugs in server_rx implementation.
fillPacket was incorrectly setting the buffer sizes and
causing large packets to be egressed incorrectly resulting
in packet drops when the MTU was > buffer size.
PiperOrigin-RevId: 420178122 |
259,853 | 13.01.2022 11:42:46 | 28,800 | 6b2178dd644657396811d3ffb6e996c27f586d89 | buildkite: skip cgroupv2 tests
Skip them for now to not block new changes.
We need to find out why buildkite doesn't have cgroupv2 agents. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -116,6 +116,7 @@ steps:\ncommand: make unit-tests\nagents:\nqueue: \"cgroupv2\"\n+ skip: \"Currently broken\"\n- <<: *common\nlabel: \":test_tube: Container tests\"\ncommand: make c... | Go | Apache License 2.0 | google/gvisor | buildkite: skip cgroupv2 tests
Skip them for now to not block new changes.
We need to find out why buildkite doesn't have cgroupv2 agents.
PiperOrigin-RevId: 421620826 |
259,907 | 14.01.2022 01:43:24 | 28,800 | 0a22b6c29ff587841fbbca3e4fe65ed5f8a499ff | Deleted should be a property of pathNode, not fidRef.
This reduces the work required to do when a file is deleted. Just mark the path
node deleted. All fidRefs pointing to it will read the correct value then. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/handlers.go",
"new_path": "pkg/p9/handlers.go",
"diff": "@@ -1249,11 +1249,6 @@ func doWalk(cs *connState, ref *fidRef, names []string, getattr bool) (qids []QI\nfile: sf,\nmode: ref.mode,\npathNode: ref.pathNode,\n-\n- // For the clone case, the cloned... | Go | Apache License 2.0 | google/gvisor | Deleted should be a property of pathNode, not fidRef.
This reduces the work required to do when a file is deleted. Just mark the path
node deleted. All fidRefs pointing to it will read the correct value then.
PiperOrigin-RevId: 421766678 |
259,909 | 14.01.2022 12:16:45 | 28,800 | b5355d8bf967efc15d505fed78e151aff954d356 | Add a panic mode to refs and refsvfs2.
This mode causes a panic rather than just a warning
when leaks are detected during a call to DoLeakCheck(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -238,6 +238,9 @@ const (\n// LeaksLogTraces indicates that a trace collected during allocation\n// should be logged when leaks are found.\nLeaksLogTraces\n+\n+ // LeaksPanic indidcates ... | Go | Apache License 2.0 | google/gvisor | Add a panic mode to refs and refsvfs2.
This mode causes a panic rather than just a warning
when leaks are detected during a call to DoLeakCheck().
PiperOrigin-RevId: 421885173 |
260,004 | 14.01.2022 12:55:20 | 28,800 | c6de0ac8026c77cfd7f68ced7b59480dbf956e7d | Drop return from IPTables.ReplaceTable
We always return the same thing. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -289,7 +289,8 @@ func SetEntries(task *kernel.Task, stk *stack.Stack, optVal []byte, ipv6 bool) *\n// - There are no chains without an unconditional ... | Go | Apache License 2.0 | google/gvisor | Drop return from IPTables.ReplaceTable
We always return the same thing.
PiperOrigin-RevId: 421893067 |
259,868 | 14.01.2022 14:32:51 | 28,800 | 027eb1492c2a6b87fdcd79821b0852a2fec976bd | BigQuery metrics: Add ability to output `benchstat`-formatted benchmark data. | [
{
"change_type": "MODIFY",
"old_path": "tools/bigquery/bigquery.go",
"new_path": "tools/bigquery/bigquery.go",
"diff": "@@ -21,6 +21,8 @@ package bigquery\nimport (\n\"context\"\n\"fmt\"\n+ \"regexp\"\n+ \"sort\"\n\"strconv\"\n\"strings\"\n\"time\"\n@@ -81,6 +83,31 @@ func (s *Suite) debugString(sb ... | Go | Apache License 2.0 | google/gvisor | BigQuery metrics: Add ability to output `benchstat`-formatted benchmark data.
PiperOrigin-RevId: 421914403 |
259,907 | 14.01.2022 15:44:37 | 28,800 | 0ab91dbf4e865d4d48a375b880f1bbeb64b04686 | Do not check the stability of certain /proc/cpuinfo fields. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -395,6 +395,25 @@ int ReadlinkWhileExited(std::string const& basename, char* buf, size_t count) {\nreturn ret;\n}\n+void RemoveUnstableCPUInfoFields(std::vector<std::string>& ... | Go | Apache License 2.0 | google/gvisor | Do not check the stability of certain /proc/cpuinfo fields.
PiperOrigin-RevId: 421928736 |
259,909 | 15.01.2022 16:33:32 | 28,800 | 6d15b0ee64f191a3c5282058fee88bc2b99697e8 | Fix packet buffer reference counting in IP fragmentation/reassembly.
This change also adds a reference counting check to the
fragmentation/reassembly unit tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/fragmentation/BUILD",
"new_path": "pkg/tcpip/network/internal/fragmentation/BUILD",
"diff": "@@ -41,10 +41,13 @@ go_test(\nsize = \"small\",\nsrcs = [\n\"fragmentation_test.go\",\n+ \"main_test.go\",\n\"reassembler_test.go\",\n],\nli... | Go | Apache License 2.0 | google/gvisor | Fix packet buffer reference counting in IP fragmentation/reassembly.
This change also adds a reference counting check to the
fragmentation/reassembly unit tests.
PiperOrigin-RevId: 422097740 |
259,962 | 18.01.2022 10:38:50 | 28,800 | 82fa6d300bf0a4a0ec06aadcd279cde108dc46c7 | Add Leak checking to UDP/ICMP tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/icmp/BUILD",
"new_path": "pkg/tcpip/transport/icmp/BUILD",
"diff": "@@ -48,6 +48,8 @@ go_test(\nsrcs = [\"icmp_test.go\"],\ndeps = [\n\":icmp\",\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"//pkg/t... | Go | Apache License 2.0 | google/gvisor | Add Leak checking to UDP/ICMP tests.
PiperOrigin-RevId: 422593497 |
259,909 | 18.01.2022 11:27:12 | 28,800 | 2f6454681c56d730d9c48ca750bf421a798b712e | Add leak checker to waitable tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/waitable/BUILD",
"new_path": "pkg/tcpip/link/waitable/BUILD",
"diff": "@@ -23,6 +23,8 @@ go_test(\n],\nlibrary = \":waitable\",\ndeps = [\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/stack\"... | Go | Apache License 2.0 | google/gvisor | Add leak checker to waitable tests.
PiperOrigin-RevId: 422605449 |
259,909 | 18.01.2022 16:03:26 | 28,800 | 8c9dc0babfd64d5f053039c898401f94c6be6d0d | Update PacketBuffer to hold a Buffer struct instead of a Buffer pointer.
The extra pointer indirection is not necessary and allows for a nil buffer.
This change bumps the PacketBuffer struct size from 296 to 792 bytes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/buffer/view.go",
"new_path": "pkg/buffer/view.go",
"diff": "@@ -380,8 +380,8 @@ func (v *View) Copy() (other View) {\n// Clone makes a more shallow copy compared to Copy. The underlying payload\n// slice (buffer.data) is shared but the buffers themselves a... | Go | Apache License 2.0 | google/gvisor | Update PacketBuffer to hold a Buffer struct instead of a Buffer pointer.
The extra pointer indirection is not necessary and allows for a nil buffer.
This change bumps the PacketBuffer struct size from 296 to 792 bytes.
PiperOrigin-RevId: 422669812 |
259,909 | 18.01.2022 17:07:03 | 28,800 | 30f36c9c8789d0fcebf6371fc3d8820a873b2c49 | Enable leak checker in sharedmem tests.
This change also adds packet cleanup after qDisc queue is closed. This is
required for sharedmem_server_test to pass. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/qdisc/fifo/fifo.go",
"new_path": "pkg/tcpip/link/qdisc/fifo/fifo.go",
"diff": "@@ -69,6 +69,13 @@ func New(lower stack.LinkWriter, n int, queueLen int) stack.QueueingDiscipline {\ngo func() {\ndefer d.wg.Done()\nqd.dispatchLoop()\n+ qd.mu.Lock()... | Go | Apache License 2.0 | google/gvisor | Enable leak checker in sharedmem tests.
This change also adds packet cleanup after qDisc queue is closed. This is
required for sharedmem_server_test to pass.
PiperOrigin-RevId: 422682841 |
259,909 | 18.01.2022 17:21:03 | 28,800 | 4ce5c43a309facd82a521facd545c463a34ba7cb | Add leak checking to qdisc and nested tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/nested/BUILD",
"new_path": "pkg/tcpip/link/nested/BUILD",
"diff": "@@ -23,6 +23,8 @@ go_test(\n\"nested_test.go\",\n],\ndeps = [\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/link/nested\",\n... | Go | Apache License 2.0 | google/gvisor | Add leak checking to qdisc and nested tests.
PiperOrigin-RevId: 422685326 |
259,909 | 18.01.2022 18:47:34 | 28,800 | 3d578afc8da96bf87e40b27423d063db45e5e4cc | Add leak checking to ethernet and muxed tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/ethernet/BUILD",
"new_path": "pkg/tcpip/link/ethernet/BUILD",
"diff": "@@ -20,6 +20,8 @@ go_test(\nsrcs = [\"ethernet_test.go\"],\ndeps = [\n\":ethernet\",\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"/... | Go | Apache License 2.0 | google/gvisor | Add leak checking to ethernet and muxed tests.
PiperOrigin-RevId: 422698888 |
259,885 | 19.01.2022 13:44:18 | 28,800 | 8e22ce50198bef6ce182cb1426b012400a348ef3 | Consistently order Pipe.mu before other file mutexes and MM.activeMu. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/pipe_util.go",
"new_path": "pkg/sentry/kernel/pipe/pipe_util.go",
"diff": "@@ -43,21 +43,26 @@ func (p *Pipe) Release(context.Context) {\n// Read reads from the Pipe into dst.\nfunc (p *Pipe) Read(ctx context.Context, dst usermem.IOSeque... | Go | Apache License 2.0 | google/gvisor | Consistently order Pipe.mu before other file mutexes and MM.activeMu.
PiperOrigin-RevId: 422894869 |
259,885 | 19.01.2022 15:59:28 | 28,800 | 04ddb203afd244ff67b51c12fbab3e9de9718066 | Add caller for the ExitNotifyParent checkpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exit.go",
"new_path": "pkg/sentry/kernel/task_exit.go",
"diff": "@@ -32,6 +32,7 @@ import (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/errors/linuxerr\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel/auth\"\n+ \"gvisor.dev/gvi... | Go | Apache License 2.0 | google/gvisor | Add caller for the ExitNotifyParent checkpoint.
PiperOrigin-RevId: 422925140 |
259,907 | 19.01.2022 17:38:09 | 28,800 | 5fb52763235857427fef62ef227b26f1fad4de2c | Handle 0 sized writes to /dev/net/tun.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/tundev/BUILD",
"new_path": "pkg/sentry/devices/tundev/BUILD",
"diff": "@@ -20,5 +20,6 @@ go_library(\n\"//pkg/tcpip/link/tun\",\n\"//pkg/usermem\",\n\"//pkg/waiter\",\n+ \"@org_golang_x_sys//unix:go_default_library\",\n],\n)\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Handle 0 sized writes to /dev/net/tun.
Reported-by: syzbot+f8718f94cb39f7d7e58f@syzkaller.appspotmail.com
PiperOrigin-RevId: 422944054 |
259,907 | 20.01.2022 20:13:43 | 28,800 | 2a62f437960641b655f790cfb13ca14ca6a7478d | Avoid uint32 to int cast in lisafs unmarshalling code.
On 32 bit systems, 0xffffffff will be cast to -1 which can trip the bound
checks in the unmarshalling code. A compromised sentry (client) will be able
to panic the gofer server. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/fd.go",
"new_path": "pkg/lisafs/fd.go",
"diff": "@@ -344,11 +344,11 @@ type ControlFDImpl interface {\nSymlink(c *Connection, name string, target string, uid UID, gid GID) (Inode, error)\nLink(c *Connection, dir ControlFDImpl, name string) (Inode, e... | Go | Apache License 2.0 | google/gvisor | Avoid uint32 to int cast in lisafs unmarshalling code.
On 32 bit systems, 0xffffffff will be cast to -1 which can trip the bound
checks in the unmarshalling code. A compromised sentry (client) will be able
to panic the gofer server.
PiperOrigin-RevId: 423221118 |
259,903 | 23.01.2022 13:05:38 | 18,000 | e66d177645c07372fa76d010464a95f0191efa0b | Allocate auxv with better capacity while loading stack | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/stack.go",
"new_path": "pkg/sentry/arch/stack.go",
"diff": "@@ -190,7 +190,7 @@ func (s *Stack) Load(args []string, env []string, aux Auxv) (StackLayout, error)\n// NOTE: We need an extra zero here per spec.\n// The Push function will automatic... | Go | Apache License 2.0 | google/gvisor | Allocate auxv with better capacity while loading stack |
259,875 | 24.01.2022 12:44:00 | 28,800 | 2b2f9ea914bd52b7155f5643d7975f38b3331b58 | Use network protocol default ttl instead of a hardcoded one. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1330,6 +1330,15 @@ func getSockOptICMPv6(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, nam\nreturn nil, syserr.ErrProtocolNotAvailable\n}\n+fun... | Go | Apache License 2.0 | google/gvisor | Use network protocol default ttl instead of a hardcoded one.
PiperOrigin-RevId: 423886874 |
259,909 | 24.01.2022 13:47:32 | 28,800 | e7091facd206e23cfe243c46c49906daf68c97b0 | Add leak checking to fdbased_test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/BUILD",
"new_path": "pkg/tcpip/link/fdbased/BUILD",
"diff": "@@ -30,6 +30,8 @@ go_test(\nsrcs = [\"endpoint_test.go\"],\nlibrary = \":fdbased\",\ndeps = [\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\... | Go | Apache License 2.0 | google/gvisor | Add leak checking to fdbased_test.
PiperOrigin-RevId: 423901655 |
259,853 | 24.01.2022 17:15:29 | 28,800 | 8b98da43f265d707acbfe1f9591ffc455e0fb45e | cpuid: deflake cpuid_test
xsavec, xgetbv1 are in Sub-leaf (EAX = 0DH, ECX = 1). | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/features_amd64.go",
"new_path": "pkg/cpuid/features_amd64.go",
"diff": "@@ -81,13 +81,14 @@ func (f *Feature) set(s Static, on bool) {\nout := s.Query(In{Eax: uint32(featureInfo)})\nout.Ecx |= (1 << 26)\ns[In{Eax: uint32(featureInfo)}] = out\n- out =... | Go | Apache License 2.0 | google/gvisor | cpuid: deflake cpuid_test
xsavec, xgetbv1 are in Sub-leaf (EAX = 0DH, ECX = 1).
PiperOrigin-RevId: 423948954 |
259,853 | 24.01.2022 17:38:42 | 28,800 | 4cfb21a86a7d81669235326fd2e2fb854c0f406c | Fix deadlock caused by calling absl::Now() after fork
absl::Now() may acquires a lock. The problem happens if fork()
is called when another thread holds the lock. In this case,
absl::Now() is stuck in a child process. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/concurrency.cc",
"new_path": "test/syscalls/linux/concurrency.cc",
"diff": "// limitations under the License.\n#include <signal.h>\n+#include <time.h>\n#include <atomic>\n@@ -78,9 +79,12 @@ TEST(ConcurrencyTest, MultiProcessMultithreaded) {... | Go | Apache License 2.0 | google/gvisor | Fix deadlock caused by calling absl::Now() after fork
absl::Now() may acquires a lock. The problem happens if fork()
is called when another thread holds the lock. In this case,
absl::Now() is stuck in a child process.
PiperOrigin-RevId: 423952981 |
259,885 | 24.01.2022 18:09:17 | 28,800 | d894748026b128ea09593729676dddd25eef2cca | Add missing fields to seccheck.ExecveInfo. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/execve.go",
"new_path": "pkg/sentry/seccheck/execve.go",
"diff": "@@ -42,6 +42,12 @@ type ExecveInfo struct {\n// BinaryMode is the executable binary file's mode.\nBinaryMode uint16\n+ // BinaryUID is the executable binary file's owner.\n+ ... | Go | Apache License 2.0 | google/gvisor | Add missing fields to seccheck.ExecveInfo.
PiperOrigin-RevId: 423958103 |
259,858 | 24.01.2022 18:16:30 | 28,800 | cbc2aa94820f1b9e3a00bbda0ddb35e6c0ce08b4 | Add checklocks annotations for ipv4 types. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -538,7 +538,7 @@ func (p *protocol) returnError(reason icmpReason, pkt *stack.PacketBuffer, deliv\n// which it arrived, which isn't necessarily the same as the NIC on wh... | Go | Apache License 2.0 | google/gvisor | Add checklocks annotations for ipv4 types.
PiperOrigin-RevId: 423959261 |
259,858 | 24.01.2022 19:13:11 | 28,800 | 7b6fc15705541555f0fcf0d72e1f2088d27b712c | Add checklocks annotations for stack/nic.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -68,20 +68,22 @@ type nic struct {\n// complete.\nlinkResQueue packetsPendingLinkResolution\n- mu struct {\n- sync.RWMutex\n+ // mu protects annotated fields below.\n+ mu sync.RWMutex\n... | Go | Apache License 2.0 | google/gvisor | Add checklocks annotations for stack/nic.go.
PiperOrigin-RevId: 423966906 |
259,853 | 24.01.2022 19:18:37 | 28,800 | 836731eb725425deb23fb516320f655079255429 | kvm: enable supervisor-mode access prevention (SMAP)
SMAP can be temporarily disabled for explicit memory accesses by setting
the EFLAGS.AC (Alignment Check) flag. But in out case, EFLAGS.AC is in
KernelFlagsClear.
Sentry never reads/writes app memory from app address space. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -194,6 +194,9 @@ func (c *CPU) CR4() uint64 {\nif hasSMEP {\ncr4 |= _CR4_SMEP\n}\n+ if hasSMAP {\n+ cr4 |= _CR4_SMAP\n+ }\nif hasFSGSBASE {\ncr4 |= _CR4_FSGSBASE\n}\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | kvm: enable supervisor-mode access prevention (SMAP)
SMAP can be temporarily disabled for explicit memory accesses by setting
the EFLAGS.AC (Alignment Check) flag. But in out case, EFLAGS.AC is in
KernelFlagsClear.
Sentry never reads/writes app memory from app address space.
PiperOrigin-RevId: 423967732 |
259,858 | 24.01.2022 19:51:35 | 28,800 | 7482e48e35ca75d24ffc03957d2ad38951143649 | Add checklocks annoations for stack/route.go. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/route.go",
"new_path": "pkg/tcpip/stack/route.go",
"diff": "@@ -33,16 +33,16 @@ type Route struct {\n// address's assigned status without the NIC.\nlocalAddressNIC *nic\n- mu struct {\n- sync.RWMutex\n+ // mu protects annotated fields below.\n+... | Go | Apache License 2.0 | google/gvisor | Add checklocks annoations for stack/route.go.
PiperOrigin-RevId: 423973318 |
259,858 | 24.01.2022 20:45:54 | 28,800 | 06ffd8eaa600eb34be63957dcb170cda5650896d | Add checklocks annotations for arp. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp.go",
"new_path": "pkg/tcpip/network/arp/arp.go",
"diff": "@@ -57,25 +57,25 @@ type endpoint struct {\nnic stack.NetworkInterface\nstats sharedStats\n- mu struct {\n- sync.Mutex\n+ // mu protects annotated fields below.\n+ mu sync.Mute... | Go | Apache License 2.0 | google/gvisor | Add checklocks annotations for arp.
PiperOrigin-RevId: 423980993 |
259,907 | 24.01.2022 21:58:50 | 28,800 | f3ff82093eb55b5b53ad99576f8181867ecfedd0 | Wrap server-side panics in EREMOTEIO.
EREMOTEIO is a more appropriate generic error for a remote procedure call (RPC)
failure on the gofer. EFAULT means bad address and can be misleading to the
application as it will denote a MM layer related issue. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/connection.go",
"new_path": "pkg/lisafs/connection.go",
"diff": "package lisafs\nimport (\n+ \"runtime/debug\"\n+\n\"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/flipcall\"\n\"gvisor.dev/gvisor/pkg/log\"\n@@ -156,7 +158,7 @@ func (c *Connection)... | Go | Apache License 2.0 | google/gvisor | Wrap server-side panics in EREMOTEIO.
EREMOTEIO is a more appropriate generic error for a remote procedure call (RPC)
failure on the gofer. EFAULT means bad address and can be misleading to the
application as it will denote a MM layer related issue.
PiperOrigin-RevId: 423990374 |
259,962 | 25.01.2022 12:22:37 | 28,800 | 434e58d261210ebfd60fe133c1b01f6804fbe06f | Remove NICs on stack shutdown to ensure qdisc cleanup. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1530,9 +1530,13 @@ func (s *Stack) Wait() {\np.Wait()\n}\n- s.mu.RLock()\n- defer s.mu.RUnlock()\n- for _, n := range s.nics {\n+ s.mu.Lock()\n+ defer s.mu.Unlock()\n+\n+ for id, n... | Go | Apache License 2.0 | google/gvisor | Remove NICs on stack shutdown to ensure qdisc cleanup.
PiperOrigin-RevId: 424149803 |
259,858 | 25.01.2022 12:30:32 | 28,800 | b92bb28e6a87d49d1551a85b82476e792e1c2cbb | Fix release tags generation. | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/check/build.go",
"new_path": "tools/nogo/check/build.go",
"diff": "@@ -16,6 +16,7 @@ package check\nimport (\n\"fmt\"\n+ \"go/build\"\n\"io\"\n\"os\"\n@@ -39,7 +40,7 @@ var findStdPkg = func(path string) (io.ReadCloser, error) {\nreturn os.Open(fmt.... | Go | Apache License 2.0 | google/gvisor | Fix release tags generation.
PiperOrigin-RevId: 424151576 |
259,885 | 25.01.2022 14:12:37 | 28,800 | edb6bd399e13d958515151cd69230863d7e92dc3 | Add caller for the Execve checkpoint.
Binary fields are VFS2-only. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1014,6 +1014,7 @@ func (k *Kernel) CreateProcess(args CreateProcessArgs) (*ThreadGroup, ThreadID,\nargs.File = nil\ncase args.File != nil:\n// If File is set, take the File p... | Go | Apache License 2.0 | google/gvisor | Add caller for the Execve checkpoint.
Binary fields are VFS2-only.
PiperOrigin-RevId: 424176912 |
259,853 | 25.01.2022 16:28:20 | 28,800 | 18dca1bf998524f53ee03bc413382bfcc880f967 | kvm: fix a race condition between seccompMMapHandler and machine.Destroy
A machine file descriptor has to be closed only when we are sure that
it isn't used by seccompMMapHandler. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -369,10 +369,6 @@ func (m *machine) mapPhysical(physical, length uintptr, phyRegions []physicalReg\nfunc (m *machine) Destroy() {\nruntime.SetFinalizer(m, nil)\n... | Go | Apache License 2.0 | google/gvisor | kvm: fix a race condition between seccompMMapHandler and machine.Destroy
A machine file descriptor has to be closed only when we are sure that
it isn't used by seccompMMapHandler.
PiperOrigin-RevId: 424207803 |
259,853 | 25.01.2022 17:39:02 | 28,800 | e3c34d68d345d8142489de7e08e93b744627881d | Disable VMX and SVM in guest PCID.
The origin version converts KVM cpuid entries into cpuid.Static
to be able to modify it. But such conversion has side-effects
that we need to avoid and so it looks reasonable to modify KVM
cpuid entries directly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/features_amd64.go",
"new_path": "pkg/cpuid/features_amd64.go",
"diff": "@@ -32,17 +32,33 @@ func featureID(b block, bit int) Feature {\n}\n// block returns the block associated with the feature.\n-func (f *Feature) block() block {\n- return block((*f... | Go | Apache License 2.0 | google/gvisor | Disable VMX and SVM in guest PCID.
The origin version converts KVM cpuid entries into cpuid.Static
to be able to modify it. But such conversion has side-effects
that we need to avoid and so it looks reasonable to modify KVM
cpuid entries directly.
PiperOrigin-RevId: 424221630 |
259,962 | 25.01.2022 22:02:35 | 28,800 | c89b6d26118c3c20d1a2c5ea75584e78288ee117 | Add leak checking to tcp tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/BUILD",
"new_path": "pkg/tcpip/transport/tcp/BUILD",
"diff": "@@ -82,11 +82,14 @@ go_test(\nname = \"tcp_test\",\nsize = \"small\",\nsrcs = [\n+ \"main_test.go\",\n\"segment_test.go\",\n\"timer_test.go\",\n],\nlibrary = \":tcp\",\ndeps ... | Go | Apache License 2.0 | google/gvisor | Add leak checking to tcp tests.
PiperOrigin-RevId: 424258607 |
259,962 | 25.01.2022 23:14:16 | 28,800 | ee08e56d4ce6ca0dfa23f75b6a10800b15c35ea4 | Add leak checking to transport internal network tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/internal/network/BUILD",
"new_path": "pkg/tcpip/transport/internal/network/BUILD",
"diff": "@@ -28,6 +28,8 @@ go_test(\nsrcs = [\"endpoint_test.go\"],\ndeps = [\n\":network\",\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"/... | Go | Apache License 2.0 | google/gvisor | Add leak checking to transport internal network tests.
PiperOrigin-RevId: 424267559 |
259,853 | 25.01.2022 23:14:19 | 28,800 | daea5b76742c7f999c096fa1009dd46b71e53cbb | kvm: Check that VMX and SVM are disabled in guest PCID | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/BUILD",
"new_path": "pkg/sentry/platform/kvm/BUILD",
"diff": "@@ -131,6 +131,7 @@ go_test(\n],\ndeps = [\n\"//pkg/abi/linux\",\n+ \"//pkg/cpuid\",\n\"//pkg/hostarch\",\n\"//pkg/memutil\",\n\"//pkg/ring0\",\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | kvm: Check that VMX and SVM are disabled in guest PCID
PiperOrigin-RevId: 424267563 |
259,962 | 26.01.2022 09:55:27 | 28,800 | b57e94c30307300263820b0ed49bbb546984a0bd | Enable leak checker for tcp_conntrack tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcpconntrack/BUILD",
"new_path": "pkg/tcpip/transport/tcpconntrack/BUILD",
"diff": "@@ -18,6 +18,8 @@ go_test(\nsrcs = [\"tcp_conntrack_test.go\"],\ndeps = [\n\":tcpconntrack\",\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip/heade... | Go | Apache License 2.0 | google/gvisor | Enable leak checker for tcp_conntrack tests.
PiperOrigin-RevId: 424374964 |
259,858 | 26.01.2022 11:05:19 | 28,800 | c18ec0b53cf2ef47ae5660bd2ae392c48047229f | Fix race build error.
This adds a test to smoke-tests to ensure that the race build does not
break again. In debugging this issue, a race in the nogo tool itself
was discovered, and a related fix is included. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -187,6 +187,7 @@ debian: ## Builds the debian packages.\nsmoke-tests: ## Runs a simple smoke test after build runsc.\n@$(call run,//runsc,--alsologtostderr --network none --debug --TESTONLY-unsafe-nonroot=true --r... | Go | Apache License 2.0 | google/gvisor | Fix race build error.
This adds a test to smoke-tests to ensure that the race build does not
break again. In debugging this issue, a race in the nogo tool itself
was discovered, and a related fix is included.
PiperOrigin-RevId: 424393624 |
260,004 | 26.01.2022 14:27:06 | 28,800 | ad021f48c08e78a2dbd2223525fbb80990cfaf0f | Add link-layer headers in nic
This removes the need for the stack to add a link header out-of-line the
write path when delivering outbound packets to a packet socket. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/ethernet/ethernet.go",
"new_path": "pkg/tcpip/link/ethernet/ethernet.go",
"diff": "@@ -79,17 +79,6 @@ func (e *Endpoint) Capabilities() stack.LinkEndpointCapabilities {\nreturn c\n}\n-// WritePackets implements stack.LinkEndpoint.\n-func (e *End... | Go | Apache License 2.0 | google/gvisor | Add link-layer headers in nic
This removes the need for the stack to add a link header out-of-line the
write path when delivering outbound packets to a packet socket.
PiperOrigin-RevId: 424444109 |
259,858 | 26.01.2022 16:28:04 | 28,800 | b5962471e17d31f509094b21a330db789df477a8 | Increase buildkite parallelism.
Since there is very little wasted work for Buildkite, increasing the
parallelsim will decrease throw-away work on cancelation or failure.
This aims to achieve ~3 minutes per individiaul test instance. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -129,7 +129,7 @@ steps:\n- <<: *common\nlabel: \":toolbox: System call tests\"\ncommand: make syscall-tests\n- parallelism: 20\n+ parallelism: 60\n# Integration tests.\n- <<: *commo... | Go | Apache License 2.0 | google/gvisor | Increase buildkite parallelism.
Since there is very little wasted work for Buildkite, increasing the
parallelsim will decrease throw-away work on cancelation or failure.
This aims to achieve ~3 minutes per individiaul test instance.
PiperOrigin-RevId: 424469351 |
259,909 | 26.01.2022 17:24:05 | 28,800 | 6a28dc7c59632b4007a095377073b8b74df85bea | Correct fragmentation reference counting.
Before this change the only reference on the packet after reassembly
processing was held by the reassembler in the holes array. This meant that
after the reassembly cleanup job, there were no references left on the
packet, leading to use after free bugs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/fragmentation/fragmentation_test.go",
"new_path": "pkg/tcpip/network/internal/fragmentation/fragmentation_test.go",
"diff": "@@ -112,6 +112,9 @@ func TestFragmentationProcess(t *testing.T) {\nfor i, in := range c.in {\ndefer in.pkt.D... | Go | Apache License 2.0 | google/gvisor | Correct fragmentation reference counting.
Before this change the only reference on the packet after reassembly
processing was held by the reassembler in the holes array. This meant that
after the reassembly cleanup job, there were no references left on the
packet, leading to use after free bugs.
PiperOrigin-RevId: 424479461 |
260,004 | 26.01.2022 18:31:27 | 28,800 | f54fcc6e11ae42289e4e8d3e4df35f33c458c7f0 | Drop LinkEndpoint.WriteRawPacket | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -268,13 +268,3 @@ func (*Endpoint) ARPHardwareType() header.ARPHardwareType {\n// AddHeader implements stack.LinkEndpoint.AddHeader.\nfunc (*Endpoint) AddHeader(*s... | Go | Apache License 2.0 | google/gvisor | Drop LinkEndpoint.WriteRawPacket
PiperOrigin-RevId: 424490855 |
259,897 | 26.01.2022 00:48:59 | -7,200 | b7ccfa5084e252f3b159aa3d44c007b889cd4287 | Fixes #7086,#6964,#3413,#7001.
Also adds fuse fsync, rename, flock support. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -232,6 +232,43 @@ type FUSEInitOut struct {\n_ [8]uint32\n}\n+// FUSEStatfsOut is the reply sent by the daemon to the kernel\n+// for FUSE_STATFS.\n+// from https://elixir.bootlin.com/lin... | Go | Apache License 2.0 | google/gvisor | Fixes #7086,#6964,#3413,#7001.
Also adds fuse fsync, rename, flock support. |
259,962 | 27.01.2022 17:14:39 | 28,800 | 2083e858ad8de9652b2e5625442899dd1c4cb459 | Add support to provide a sharedmem path to sharedmem. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/queuepair.go",
"new_path": "pkg/tcpip/link/sharedmem/queuepair.go",
"diff": "@@ -26,11 +26,11 @@ import (\n)\nconst (\n- // defaultQueueDataSize is the size of the shared memory data region that\n+ // DefaultQueueDataSize is the size o... | Go | Apache License 2.0 | google/gvisor | Add support to provide a sharedmem path to sharedmem.
PiperOrigin-RevId: 424744312 |
259,858 | 28.01.2022 14:05:00 | 28,800 | 62665f881df71583fcfb22657f5af0ec8f9790c9 | Remove unnecessary use of _impl pkg rules.
Updates bazelbuild/rules_pkg#263 | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -585,8 +585,11 @@ rbe_autoconfig(name = \"rbe_default\")\nhttp_archive(\nname = \"rules_pkg\",\n- sha256 = \"353b20e8b093d42dd16889c7f918750fb8701c485ac6cceb69a5236500507c27\",\n- url = \"https://github.com/baze... | Go | Apache License 2.0 | google/gvisor | Remove unnecessary use of _impl pkg rules.
Updates bazelbuild/rules_pkg#263
PiperOrigin-RevId: 424953384 |
259,907 | 28.01.2022 15:34:38 | 28,800 | e29fd32d0a4ef4b8d1386e8d3b12b79e10749fb4 | Get rid of unnecessary lisafs.Inode allocations.
lisafs.Inode is a heavy struct with linux.Statx in it. However the cost of
copying it on return is lower than that of an allocation.
Additionally unclutter the filesystem.doCreateAt function signature. It already
is quite complex. lisafs had added more complexity earlier. Revert that. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/client.go",
"new_path": "pkg/lisafs/client.go",
"diff": "@@ -72,7 +72,7 @@ type Client struct {\n// the server and creates channels for fast IPC. NewClient takes ownership over\n// the passed socket. On success, it returns the initialized client alo... | Go | Apache License 2.0 | google/gvisor | Get rid of unnecessary lisafs.Inode allocations.
lisafs.Inode is a heavy struct with linux.Statx in it. However the cost of
copying it on return is lower than that of an allocation.
Additionally unclutter the filesystem.doCreateAt function signature. It already
is quite complex. lisafs had added more complexity earlier. Revert that.
PiperOrigin-RevId: 424972317 |
259,962 | 28.01.2022 17:10:32 | 28,800 | 44f0f2dc400aab0cfa9881604bbe297f5249f611 | Exclude tcp_noracedetector_test.go from gotsan runs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/test/e2e/BUILD",
"new_path": "pkg/tcpip/transport/tcp/test/e2e/BUILD",
"diff": "@@ -164,6 +164,9 @@ go_test(\nname = \"tcp_noracedetector_test\",\nsize = \"small\",\nsrcs = [\"tcp_noracedetector_test.go\"],\n+ # These tests can be extre... | Go | Apache License 2.0 | google/gvisor | Exclude tcp_noracedetector_test.go from gotsan runs.
PiperOrigin-RevId: 424989750 |
259,907 | 28.01.2022 19:11:56 | 28,800 | 2a3d59997fb9731bae6f0dd3b23d4b17455fed29 | Enable reference count leak checking for lisafs.
Also add DoRepeatedLeakCheck() to refsvfs2 package.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/connection_test.go",
"new_path": "pkg/lisafs/connection_test.go",
"diff": "@@ -104,6 +104,7 @@ func runServerClient(t testing.TB, clientFn func(c *lisafs.Client)) {\nc.Close() // This should trigger client and server shutdown.\nts.Wait()\n+ ts.Serve... | Go | Apache License 2.0 | google/gvisor | Enable reference count leak checking for lisafs.
Also add DoRepeatedLeakCheck() to refsvfs2 package.
Updates #5466
PiperOrigin-RevId: 425004987 |
259,885 | 31.01.2022 12:22:36 | 28,800 | 5ef032d4df2810ec9dfe2d8c9ed13f8cd4eb4a33 | Implement faccessat2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -96,6 +96,11 @@ const (\nAT_EMPTY_PATH = 0x1000\n)\n+// Constants for faccessat2(2).\n+const (\n+ AT_EACCESS = 0x200\n+)\n+\n// Constants for all file-related ...at(2) syscalls.\nconst (\... | Go | Apache License 2.0 | google/gvisor | Implement faccessat2.
PiperOrigin-RevId: 425432076 |
259,909 | 31.01.2022 16:05:18 | 28,800 | 0f8db423e2706e01d932ee1bf3c444bf26654b08 | Fix cgroupv2 bug that set the wrong iops throttle. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup_v2.go",
"new_path": "runsc/cgroup/cgroup_v2.go",
"diff": "@@ -513,7 +513,7 @@ func (*io2) set(spec *specs.LinuxResources, path string) error {\nreturn err\n}\n- if err := setThrottle2(path, \"riops\", blkio.ThrottleWriteIOPSDevice); err != ... | Go | Apache License 2.0 | google/gvisor | Fix cgroupv2 bug that set the wrong iops throttle.
PiperOrigin-RevId: 425483482 |
259,992 | 01.02.2022 14:00:10 | 28,800 | 5a642df6b32622af8495ee659cd671f2dae213f3 | Reorder cmd groups
Also fixed gofer which was added twice. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cli/main.go",
"new_path": "runsc/cli/main.go",
"diff": "@@ -59,47 +59,46 @@ var (\nfunc Main(version string) {\n// Help and flags commands are generated automatically.\nhelp := cmd.NewHelp(subcommands.DefaultCommander)\n- help.Register(new(cmd.Syscalls))... | Go | Apache License 2.0 | google/gvisor | Reorder cmd groups
Also fixed gofer which was added twice.
PiperOrigin-RevId: 425709601 |
259,962 | 01.02.2022 22:34:52 | 28,800 | 404b90fa4ad81c50a8d84f23eaa249d66269ba52 | Fix stale comment on Endpoint.ReadContext.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -167,7 +167,7 @@ func (e *Endpoint) Read() *stack.PacketBuffer {\n}\n// ReadContext does blocking read for one packet from the outbound packet queue.\n-// It can b... | Go | Apache License 2.0 | google/gvisor | Fix stale comment on Endpoint.ReadContext.
Fixes #7109
PiperOrigin-RevId: 425799066 |
259,962 | 01.02.2022 22:38:54 | 28,800 | bcba5136d0d02b7a9b3c8979a886a452a9035ff7 | Remove stale nic.DeliverNetworkPacket comment.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -699,9 +699,6 @@ func (n *nic) isInGroup(addr tcpip.Address) bool {\n// DeliverNetworkPacket finds the appropriate network protocol endpoint and\n// hands the packet over for further pr... | Go | Apache License 2.0 | google/gvisor | Remove stale nic.DeliverNetworkPacket comment.
Fixes #7080
PiperOrigin-RevId: 425799488 |
259,868 | 02.02.2022 20:17:30 | 28,800 | a5ce865145c718f26c7a8f305f6c8262e992051c | fuse: Attempt to fix five data races.
I am not fully familiar with this code, but I added some `checklocks`
annotations wherever it seemed appropriate and obvious from existing comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection.go",
"diff": "@@ -48,7 +48,7 @@ const (\ntype connection struct {\nfd *DeviceFD\n- // mu protects access to struct memebers.\n+ // mu protects access to struct members.\nmu s... | Go | Apache License 2.0 | google/gvisor | fuse: Attempt to fix five data races.
I am not fully familiar with this code, but I added some `checklocks`
annotations wherever it seemed appropriate and obvious from existing comments.
PiperOrigin-RevId: 426042114 |
259,909 | 02.02.2022 21:48:57 | 28,800 | 66da66de302bbb1d0fe5da853055e76369abba61 | Fix incorrect behavior for qdisc wakeups.
Without this fix, the qdisc dispatch loop writes at most one batch,
then waits for another wakeup before writing any more packets. All
packets in the queue should be written to the link endpoint after
a wakeup. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/qdisc/fifo/fifo.go",
"new_path": "pkg/tcpip/link/qdisc/fifo/fifo.go",
"diff": "@@ -28,6 +28,13 @@ import (\nvar _ stack.QueueingDiscipline = (*discipline)(nil)\n+const (\n+ // BatchSize represents the number of packets written to the\n+ // lower... | Go | Apache License 2.0 | google/gvisor | Fix incorrect behavior for qdisc wakeups.
Without this fix, the qdisc dispatch loop writes at most one batch,
then waits for another wakeup before writing any more packets. All
packets in the queue should be written to the link endpoint after
a wakeup.
PiperOrigin-RevId: 426053587 |
259,868 | 03.02.2022 01:43:48 | 28,800 | 95d883a92e31909b13511d34c107f22f04012172 | Refactor task start and exit from a PID namespace into separate functions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -200,6 +200,7 @@ go_library(\n\"task_work.go\",\n\"thread_group.go\",\n\"threads.go\",\n+ \"threads_impl.go\",\n\"timekeeper.go\",\n\"timekeeper_state.go\",\n\"tty.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Refactor task start and exit from a PID namespace into separate functions.
PiperOrigin-RevId: 426083905 |
259,853 | 03.02.2022 10:39:16 | 28,800 | e31c3f18da12b54917a22a13a87830b94a1d7922 | kvm: sentry executable mappings have to be read-only
The sentry guest page tables must not allow to execute writable memory regions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -198,7 +198,7 @@ func (m *machine) createVCPU(id int) *vCPU {\n// readOnlyGuestRegions contains regions that have to be mapped read-only into\n// the guest physi... | Go | Apache License 2.0 | google/gvisor | kvm: sentry executable mappings have to be read-only
The sentry guest page tables must not allow to execute writable memory regions.
PiperOrigin-RevId: 426183789 |
259,951 | 03.02.2022 13:27:19 | 28,800 | 56de63a4cb1ce9f01fa69211e7b3285fa6a34ee3 | Remove unused parameter in UDP tests instantiation
The variant kDualStack is never used by any test. It just duplicates
kIpv6 case. Because the parameters are now just kIpv4 and kIpv6, use
an int to encode the address family, instead of the enum. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket.cc",
"new_path": "test/syscalls/linux/udp_socket.cc",
"diff": "@@ -55,8 +55,7 @@ namespace {\n// Fixture for tests parameterized by the address family to use (AF_INET and\n// AF_INET6) when creating sockets.\n-class UdpSocketTest... | Go | Apache License 2.0 | google/gvisor | Remove unused parameter in UDP tests instantiation
The variant kDualStack is never used by any test. It just duplicates
kIpv6 case. Because the parameters are now just kIpv4 and kIpv6, use
an int to encode the address family, instead of the enum.
PiperOrigin-RevId: 426224701 |
259,853 | 03.02.2022 14:51:32 | 28,800 | 237e45d23aabd8e3f7679cbd87abbea757702ae9 | filters: don't allow to create new executable mappings | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp.go",
"new_path": "pkg/seccomp/seccomp.go",
"diff": "@@ -41,11 +41,14 @@ const (\n// used because it only kills the offending thread and often keeps the sentry\n// hanging.\n//\n+// denyRules describes forbidden syscalls. rules describes all... | Go | Apache License 2.0 | google/gvisor | filters: don't allow to create new executable mappings
PiperOrigin-RevId: 426244201 |
259,985 | 03.02.2022 15:11:53 | 28,800 | 55ef37166897eae03ea8e572487db4eefc3f9d1d | Return well-defined error on short payload in FUSE.
Errors from syscalls without a well-defined translation to errnos
result in sentry panics.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/request_response.go",
"new_path": "pkg/sentry/fsimpl/fuse/request_response.go",
"diff": "package fuse\nimport (\n- \"fmt\"\n-\n\"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n+ \"gvisor.dev/gvisor/pkg/errors/linuxerr\"\n\... | Go | Apache License 2.0 | google/gvisor | Return well-defined error on short payload in FUSE.
Errors from syscalls without a well-defined translation to errnos
result in sentry panics.
Reported-by: syzbot+907201b840bb25d94e00@syzkaller.appspotmail.com
PiperOrigin-RevId: 426248731 |
259,962 | 03.02.2022 16:44:43 | 28,800 | 7345bd99ea5a5cb378ac73ed7a10c17744c82800 | Make shared memory file location configurable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/queuepair.go",
"new_path": "pkg/tcpip/link/sharedmem/queuepair.go",
"diff": "@@ -74,16 +74,16 @@ type QueuePair struct {\n// QueueOptions allows queue specific configuration to be specified when\n// creating a QueuePair.\ntype QueueOpt... | Go | Apache License 2.0 | google/gvisor | Make shared memory file location configurable.
PiperOrigin-RevId: 426268960 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.