author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,951 | 04.10.2021 13:55:19 | 25,200 | 6c1237da03bf52d51284e15e6c6c2b6776cd7da6 | Reply to invalid ACKs even when accept queue is full
Before checking if there is space in the accept queue, the listener
should verify that the cookie is valid. If it is not, instead of
silently dropping the packet, reply with an RST.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -583,23 +583,6 @@ func (e *endpoint) handleListenSegment(ctx *listenContext, s *segment) tcpip.Err\nreturn nil\ncase s.flags.Contains(header.TCPFlagAck):\n- // Kee... | Go | Apache License 2.0 | google/gvisor | Reply to invalid ACKs even when accept queue is full
Before checking if there is space in the accept queue, the listener
should verify that the cookie is valid. If it is not, instead of
silently dropping the packet, reply with an RST.
Fixes #6683
PiperOrigin-RevId: 400807346 |
259,907 | 06.10.2021 11:27:58 | 25,200 | a259115490332409b284868a0d25e39f2d63a3fe | Add global lisafs kernel flag. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -78,11 +78,19 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip\"\n)\n-// VFS2Enabled is set to true when VFS2 is enabled. Added as a global for allow\n-// easy access everywhere. To... | Go | Apache License 2.0 | google/gvisor | Add global lisafs kernel flag.
PiperOrigin-RevId: 401296116 |
260,004 | 07.10.2021 15:30:09 | 25,200 | 3517d070cc3128ad3439e10b8abb42b7df60c2b2 | Track UDP packets performing REDIRECT NAT | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables_targets.go",
"new_path": "pkg/tcpip/stack/iptables_targets.go",
"diff": "@@ -132,36 +132,12 @@ func (rt *RedirectTarget) Action(pkt *PacketBuffer, hook Hook, r *Route, address\npanic(\"redirect target is supported only on output and pr... | Go | Apache License 2.0 | google/gvisor | Track UDP packets performing REDIRECT NAT
PiperOrigin-RevId: 401620449 |
259,853 | 07.10.2021 15:47:05 | 25,200 | 710e51372dc822501769d700531ec6f0f81221e6 | tests: use a proper path to the kvm device | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm.go",
"new_path": "pkg/sentry/platform/kvm/kvm.go",
"diff": "@@ -77,7 +77,11 @@ var (\n// OpenDevice opens the KVM device at /dev/kvm and returns the File.\nfunc OpenDevice() (*os.File, error) {\n- f, err := os.OpenFile(\"/dev/kvm\",... | Go | Apache License 2.0 | google/gvisor | tests: use a proper path to the kvm device
PiperOrigin-RevId: 401624134 |
259,962 | 07.10.2021 16:29:09 | 25,200 | 0743a862e5e90368291ad4ef9061f3c4ca3a065f | Update compat list for tcpdump.
A libpcap change broke tcpdump support in gvisor. As a result tcpdump
w/ libpcap> 1.10 fails with gvisor.
Updates | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/compatibility.md",
"new_path": "g3doc/user_guide/compatibility.md",
"diff": "@@ -42,6 +42,9 @@ Most common utilities work. Note that:\n* Some tools, such as `tcpdump` and old versions of `ping`, require explicitly\nenabling raw sockets via the... | Go | Apache License 2.0 | google/gvisor | Update compat list for tcpdump.
A libpcap change broke tcpdump support in gvisor. As a result tcpdump
w/ libpcap> 1.10 fails with gvisor.
Updates #6664, #6699
PiperOrigin-RevId: 401633061 |
259,896 | 07.10.2021 16:48:28 | 25,200 | 487651ac46f302592ccffc9e5a4336a331010e42 | Add a new metric to detect the number of spurious loss recoveries.
Implements RFC 3522 (Eifel detection algorithm) to detect if the connection
entered loss recovery unnecessarily.
Added a new metric to count the total number of spurious loss recoveries.
Added tests to verify the new metric. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -274,6 +274,7 @@ var Metrics = tcpip.Stats{\nChecksumErrors: mustCreateMetric(\"/netstack/tcp/checksum_errors\", \"Number of segments dropped due to bad ... | Go | Apache License 2.0 | google/gvisor | Add a new metric to detect the number of spurious loss recoveries.
- Implements RFC 3522 (Eifel detection algorithm) to detect if the connection
entered loss recovery unnecessarily.
- Added a new metric to count the total number of spurious loss recoveries.
- Added tests to verify the new metric.
PiperOrigin-RevId: 401637359 |
259,907 | 08.10.2021 15:38:41 | 25,200 | 34e68b6b4ff04de5c7b5e2dc46e5bd44c6845e63 | Remove redundant slice copy in lisafs gofer client.
listXattr() was doing redundant work. Remove it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -2049,16 +2049,7 @@ func (d *dentry) listXattr(ctx context.Context, size uint64) ([]string, error) {\n}\nif d.fs.opts.lisaEnabled {\n- xattrs, err := d.controlFDLisa... | Go | Apache License 2.0 | google/gvisor | Remove redundant slice copy in lisafs gofer client.
listXattr() was doing redundant work. Remove it.
PiperOrigin-RevId: 401871315 |
260,004 | 11.10.2021 11:44:42 | 25,200 | 4ea18a8a7b72f49734a2f89be1ff7a4be87017c7 | Support IP_PKTINFO and IPV6_RECVPKTINFO on raw sockets
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -49,6 +49,7 @@ type rawPacket struct {\nreceivedAt time.Time `state:\".(int64)\"`\n// senderAddr is the network address of the sender.\nsenderAddr tcpip.FullAd... | Go | Apache License 2.0 | google/gvisor | Support IP_PKTINFO and IPV6_RECVPKTINFO on raw sockets
Updates #1584, #3556.
PiperOrigin-RevId: 402354066 |
260,004 | 11.10.2021 12:33:44 | 25,200 | 125fae59beb2a054061fab4cc300994b753e127a | Add unit test for Redirect target
We already have integration tests `make iptables-tests` that tests
the REDIRECT target, but unit tests are a lot faster and easier
to run than the integration test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/integration/iptables_test.go",
"new_path": "pkg/tcpip/tests/integration/iptables_test.go",
"diff": "@@ -1162,19 +1162,19 @@ func TestInputHookWithLocalForwarding(t *testing.T) {\n}\n}\n-func TestSNAT(t *testing.T) {\n- const listenPort = 8080\n... | Go | Apache License 2.0 | google/gvisor | Add unit test for Redirect target
We already have integration tests `make iptables-tests` that tests
the REDIRECT target, but unit tests are a lot faster and easier
to run than the integration test.
PiperOrigin-RevId: 402365412 |
260,004 | 11.10.2021 21:34:07 | 25,200 | ab1ef0baba1d15c4d4e7717d23cf8b32fd6b5feb | Support DNAT target | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables_targets.go",
"new_path": "pkg/tcpip/stack/iptables_targets.go",
"diff": "@@ -83,6 +83,45 @@ func (*ReturnTarget) Action(*PacketBuffer, Hook, *Route, AddressableEndpoint) (R\nreturn RuleReturn, 0\n}\n+// DNATTarget modifies the destinat... | Go | Apache License 2.0 | google/gvisor | Support DNAT target
PiperOrigin-RevId: 402468096 |
259,992 | 12.10.2021 11:35:25 | 25,200 | 98a694eebc0b50e2e591da3af4a0ac280bf411d0 | Make cgroup creation/deletion more robust
Don't attempt to create directory is controller is not
present in the system
Ensure that all files being written exist in cgroupfs
Attempt to delete directories during Uninstall even if
other deletions have failed
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/BUILD",
"new_path": "pkg/sync/BUILD",
"diff": "@@ -26,6 +26,7 @@ go_library(\n\"rwmutex_unsafe.go\",\n\"seqcount.go\",\n\"sync.go\",\n+ \"wait.go\",\n],\nmarshal = False,\nstateify = False,\n"
},
{
"change_type": "ADD",
"old_path": null,
... | Go | Apache License 2.0 | google/gvisor | Make cgroup creation/deletion more robust
- Don't attempt to create directory is controller is not
present in the system
- Ensure that all files being written exist in cgroupfs
- Attempt to delete directories during Uninstall even if
other deletions have failed
Fixes #6446
PiperOrigin-RevId: 402614820 |
259,907 | 12.10.2021 12:44:53 | 25,200 | 035e44c7cb990d91e77b57b146b8dc78ad064b95 | Make DoubleLayerEpoll use non blocking pipes.
We don't want the read to block and want to test that epoll_wait returns only
when there is data available in rfd to be read. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/epoll.cc",
"new_path": "test/syscalls/linux/epoll.cc",
"diff": "@@ -499,7 +499,7 @@ TEST(EpollTest, PipeReaderHupAfterWriterClosed) {\nTEST(EpollTest, DoubleLayerEpoll) {\nint pipefds[2];\n- ASSERT_THAT(pipe(pipefds), SyscallSucceeds());\n+... | Go | Apache License 2.0 | google/gvisor | Make DoubleLayerEpoll use non blocking pipes.
We don't want the read to block and want to test that epoll_wait returns only
when there is data available in rfd to be read.
PiperOrigin-RevId: 402631091 |
260,004 | 12.10.2021 15:29:57 | 25,200 | 08f1d96168ace77ff105da76f384aa0997a21e2f | Separate DNAT and SNAT manip states
This change also refactors the conntrack packet handling code
to not perform the actual rewriting of the packet while holding
the lock.
This change prepares for a followup CL that adds support for twice-NAT.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -45,17 +45,6 @@ const (\ndirReply\n)\n-// Manipulation type for the connection.\n-// TODO(gvisor.dev/issue/5696): Define this as a bit set and support SNAT and\n-// DNAT at ... | Go | Apache License 2.0 | google/gvisor | Separate DNAT and SNAT manip states
This change also refactors the conntrack packet handling code
to not perform the actual rewriting of the packet while holding
the lock.
This change prepares for a followup CL that adds support for twice-NAT.
Updates #5696.
PiperOrigin-RevId: 402671685 |
259,962 | 12.10.2021 16:24:34 | 25,200 | e54ee7a990753ba0616b9dc6010323f5a411cb5f | Create constants for Keepalive defaults.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -813,10 +813,9 @@ func newEndpoint(s *stack.Stack, protocol *protocol, netProto tcpip.NetworkProto\nwaiterQueue: waiterQueue,\nstate: uint32(StateInitial),\nke... | Go | Apache License 2.0 | google/gvisor | Create constants for Keepalive defaults.
Fixes #6725
PiperOrigin-RevId: 402683244 |
260,004 | 12.10.2021 19:36:55 | 25,200 | 747cb92460bc30983263fcd85562a8586842d824 | Support Twice NAT
This CL allows both SNAT and DNAT targets to be performed on the same
packet.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -439,7 +439,7 @@ func (e *endpoint) WritePacket(r *stack.Route, params stack.NetworkHeaderParams,\n// We should do this for every packet, rather than only NATted packets... | Go | Apache License 2.0 | google/gvisor | Support Twice NAT
This CL allows both SNAT and DNAT targets to be performed on the same
packet.
Fixes #5696.
PiperOrigin-RevId: 402714738 |
260,004 | 13.10.2021 09:48:35 | 25,200 | b74bbe11e6da5f3ec00bafe4a93ab383bea78af1 | Represent direction with boolean
...since direction can only hold one of two possible values. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -37,14 +37,6 @@ import (\n// Our hash table has 16K buckets.\nconst numBuckets = 1 << 14\n-// Direction of the tuple.\n-type direction int\n-\n-const (\n- dirOriginal direct... | Go | Apache License 2.0 | google/gvisor | Represent direction with boolean
...since direction can only hold one of two possible values.
PiperOrigin-RevId: 402855698 |
259,853 | 13.10.2021 13:48:43 | 25,200 | 82218937948bd59f8d20e44575405874d56f0ae7 | runsc: allow to run rootless containers on cgroupV2
Before cl/402392291 and cl/402614820, it worked without any problem.
In this case, we just ignore a cgroup configuration. We do the same thing,
when we don't have permissions to create new cgroups on cgroupV1. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -1278,7 +1278,10 @@ func (c *Container) setupCgroupForSubcontainer(conf *config.Config, spec *specs.\n// no cgroups was configured.\nfunc cgroupInstall(conf *config.Config, ... | Go | Apache License 2.0 | google/gvisor | runsc: allow to run rootless containers on cgroupV2
Before cl/402392291 and cl/402614820, it worked without any problem.
In this case, we just ignore a cgroup configuration. We do the same thing,
when we don't have permissions to create new cgroups on cgroupV1.
PiperOrigin-RevId: 402913129 |
259,891 | 13.10.2021 14:36:53 | 25,200 | 1796cd89d516033800f9c887250481c26bab0ae0 | add create-only raw sockets
These can be used by applications to manipulate iptables rules without enabling
arbitrary reads from and writes to the underlying packet socket. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/tcpip/transport/internal/noop/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"noop\",\n+ srcs = [\"endpoint.go\"],\n+ visibility = [\"//pkg/tcpip/transport/raw:_... | Go | Apache License 2.0 | google/gvisor | add create-only raw sockets
These can be used by applications to manipulate iptables rules without enabling
arbitrary reads from and writes to the underlying packet socket.
PiperOrigin-RevId: 402924733 |
259,962 | 13.10.2021 15:17:23 | 25,200 | 4e2cc2bef3220bb77a60b4a33fb02f491d5acf98 | Minor fixes to sharedmem.
Use route/protocol from packetbuffer.
Sharedmem implementation should use the EgressRoute/NetworkProtocolNumber
embedded in the packetbuffer rather than what is passed as parameters to
Write(Raw)Packet(s). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/BUILD",
"new_path": "pkg/tcpip/link/sharedmem/BUILD",
"diff": "@@ -19,6 +19,7 @@ go_library(\n\"//pkg/cleanup\",\n\"//pkg/eventfd\",\n\"//pkg/log\",\n+ \"//pkg/memutil\",\n\"//pkg/sync\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n"
... | Go | Apache License 2.0 | google/gvisor | Minor fixes to sharedmem.
Use route/protocol from packetbuffer.
Sharedmem implementation should use the EgressRoute/NetworkProtocolNumber
embedded in the packetbuffer rather than what is passed as parameters to
Write(Raw)Packet(s).
PiperOrigin-RevId: 402934171 |
260,001 | 14.10.2021 16:24:35 | 25,200 | 6f4fcc4bac81f0fc73712b0216e3ed50b056a925 | Add a size parameter | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ioctl.go",
"new_path": "pkg/abi/linux/ioctl.go",
"diff": "@@ -180,8 +180,12 @@ var (\n// to get quote.\nconst SizeOfQuoteInputData = 64\n-// SignReport is a struct that gets signed quote from input data.\n+// SignReport is a struct that gets sign... | Go | Apache License 2.0 | google/gvisor | Add a size parameter
PiperOrigin-RevId: 403214414 |
259,881 | 15.10.2021 13:49:48 | 25,200 | 04dc27899bbdeb9bbce2b2647856d160e8ccd78d | Fix incorrect printf verb
tcpip.Error does not implement error and thus cannot be used with %w.
This was flagged by nogo. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/tcp_proxy.go",
"new_path": "test/benchmarks/tcp/tcp_proxy.go",
"diff": "@@ -213,7 +213,7 @@ func newNetstackImpl(mode string) (impl, error) {\nAddressWithPrefix: parsedAddr.WithPrefix(),\n}\nif err := s.AddProtocolAddress(nicID, protocolAdd... | Go | Apache License 2.0 | google/gvisor | Fix incorrect printf verb
tcpip.Error does not implement error and thus cannot be used with %w.
This was flagged by nogo.
PiperOrigin-RevId: 403458480 |
259,978 | 15.10.2021 14:01:39 | 25,200 | e4fc15bd88f0b62fb8923f1417175f015482c0bd | Implement WriteRawPacket for pipe
Implement WriteRawPacket for pipe by calling `DeliverNetworkPacket`
on the other end with empty values for the route and protocol number,
and relies on the `NetworkDispatcher` to decapsulate the link layer
header from the raw packet itself. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/pipe/pipe.go",
"new_path": "pkg/tcpip/link/pipe/pipe.go",
"diff": "@@ -123,4 +123,6 @@ func (*Endpoint) AddHeader(_, _ tcpip.LinkAddress, _ tcpip.NetworkProtocolNumber\n}\n// WriteRawPacket implements stack.LinkEndpoint.\n-func (*Endpoint) Write... | Go | Apache License 2.0 | google/gvisor | Implement WriteRawPacket for pipe
Implement WriteRawPacket for pipe by calling `DeliverNetworkPacket`
on the other end with empty values for the route and protocol number,
and relies on the `NetworkDispatcher` to decapsulate the link layer
header from the raw packet itself.
PiperOrigin-RevId: 403461448 |
260,004 | 15.10.2021 15:16:14 | 25,200 | 706f6f35f468c63cfaf385fb099af09b835bcfe1 | Satisfy nogo | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet_test.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet_test.go",
"diff": "@@ -630,7 +630,7 @@ func makePipe() (c1, c2 net.Conn, stop func(), err error) {\nAddressWithPrefix: ip.WithPrefix(),\n}\nif err := s.AddProtocolAddress(NICI... | Go | Apache License 2.0 | google/gvisor | Satisfy nogo
PiperOrigin-RevId: 403479257 |
259,992 | 18.10.2021 11:44:11 | 25,200 | eafa3f19e4d2c0a490af78dbe77289c7b5edbb76 | Mount namespace can be nil after task exits
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -950,7 +950,7 @@ func (l *Loader) executeAsync(args *control.ExecArgs) (kernel.ThreadID, error) {\nif kernel.VFS2Enabled {\n// task.MountNamespaceVFS2() does not take a ref, so we must do s... | Go | Apache License 2.0 | google/gvisor | Mount namespace can be nil after task exits
Updates #1035
PiperOrigin-RevId: 404017795 |
259,881 | 18.10.2021 12:14:22 | 25,200 | c7e5b4bd67e0a80c07bf051654e7d28fb592cc39 | Add hook to add addition build tags | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/build.go",
"new_path": "tools/nogo/build.go",
"diff": "@@ -31,3 +31,8 @@ func findStdPkg(GOOS, GOARCH, path string) (io.ReadCloser, error) {\n}\nreturn os.Open(fmt.Sprintf(\"external/go_sdk/pkg/%s_%s/%s.a\", GOOS, GOARCH, path))\n}\n+\n+// ReleaseTa... | Go | Apache License 2.0 | google/gvisor | Add hook to add addition build tags
PiperOrigin-RevId: 404025736 |
259,881 | 18.10.2021 13:13:04 | 25,200 | fb053829f9cad92527e7df93b17e211f5885a783 | Update testDeps definition for
The in-progress Go 1.18's testing.corpusEntry changed definition slightly in
Update our definition to the new version. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/runner/lib/lib.go",
"new_path": "test/runtimes/runner/lib/lib.go",
"diff": "@@ -209,7 +209,7 @@ func (f testDeps) SnapshotCoverage() {}\n// Copied from testing/fuzz.go.\ntype corpusEntry = struct {\nParent string\n- Name string\n+ Path string\nDa... | Go | Apache License 2.0 | google/gvisor | Update testDeps definition for https://golang.org/cl/354632
The in-progress Go 1.18's testing.corpusEntry changed definition slightly in
https://golang.org/cl/354632. Update our definition to the new version.
PiperOrigin-RevId: 404040853 |
259,992 | 18.10.2021 13:22:38 | 25,200 | 832c309ce95b5b68bdb4e98ac85dc64c6762646e | Change test to use VFS2
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -984,7 +984,7 @@ func (c *containerMounter) createRestoreEnvironment(conf *config.Config) (*fs.Re\n// Add root mount.\nfd := c.fds.remove()\n- opts := goferMountData(fd, conf.FileAccess, \"/\", fal... | Go | Apache License 2.0 | google/gvisor | Change test to use VFS2
Updates #1035
PiperOrigin-RevId: 404043283 |
259,992 | 18.10.2021 15:06:45 | 25,200 | fa56fbf44e440bbbca710ef1b7cc1d54f862c20e | Report ramdiskfs usage correctly
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"diff": "@@ -95,7 +95,7 @@ type regularFile struct {\nfunc (fs *filesystem) newRegularFile(kuid auth.KUID, kgid auth.KGID, mode linux.FileMode, parentDir *director... | Go | Apache License 2.0 | google/gvisor | Report ramdiskfs usage correctly
Updates #1035
PiperOrigin-RevId: 404072231 |
259,891 | 18.10.2021 15:07:06 | 25,200 | 211bbf82ad2f490ed7215568c2065d76dfa682ca | conntrack: use tcpip.Clock instead of time.Time
We should be using a monotonic clock
This will make future testing easier
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -58,8 +58,8 @@ var nameToID = map[string]stack.TableID{\n// DefaultLinuxTables returns the rules of stack.DefaultTables() wrapped for\n// compatibili... | Go | Apache License 2.0 | google/gvisor | conntrack: use tcpip.Clock instead of time.Time
- We should be using a monotonic clock
- This will make future testing easier
Updates #6748.
PiperOrigin-RevId: 404072318 |
259,891 | 18.10.2021 20:41:37 | 25,200 | 03bc93d2b82045fc44102d0f40a208f97db16479 | conntrack: update state of un-NATted connections
This prevents reaping connections unnecessarily early. This change both moves
the state update to the beginning of handlePacket and fixes a bug where
un-finalized connections could become un-reapable.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -132,6 +132,7 @@ go_test(\nname = \"stack_test\",\nsize = \"small\",\nsrcs = [\n+ \"conntrack_test.go\",\n\"forwarding_test.go\",\n\"neighbor_cache_test.go\",\n\"neighbor_entry_test.go\",... | Go | Apache License 2.0 | google/gvisor | conntrack: update state of un-NATted connections
This prevents reaping connections unnecessarily early. This change both moves
the state update to the beginning of handlePacket and fixes a bug where
un-finalized connections could become un-reapable.
Fixes #6748
PiperOrigin-RevId: 404141012 |
259,881 | 19.10.2021 08:15:48 | 25,200 | 83840125e0bd050129fc3c8983a5bcef7afefe4e | Drop accept from sentryctl socket filters
Now that we use x/sys/unix beyond we always use
accept4 in place of accept. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -651,11 +651,6 @@ func controlServerFilters(fd int) seccomp.SyscallRules {\nseccomp.EqualTo(fd),\n},\n},\n- unix.SYS_ACCEPT: []seccomp.Rule{\n- {\n- seccomp.EqualTo(fd),\n- },... | Go | Apache License 2.0 | google/gvisor | Drop accept from sentryctl socket filters
Now that we use x/sys/unix beyond https://golang.org/cl/313690 we always use
accept4 in place of accept.
PiperOrigin-RevId: 404265340 |
259,985 | 19.10.2021 15:36:02 | 25,200 | 80d655d842755c93d7d6bf0288732cd5d3552c50 | Stub cpuset cgroup control files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/BUILD",
"new_path": "pkg/sentry/fsimpl/cgroupfs/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\... | Go | Apache License 2.0 | google/gvisor | Stub cpuset cgroup control files.
PiperOrigin-RevId: 404382475 |
259,992 | 19.10.2021 17:03:06 | 25,200 | 6dde3d5ae51030fceb0798d671d19ec1df3ae7a3 | Fix typo in FIXME | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm_safecopy_test.go",
"new_path": "pkg/sentry/platform/kvm/kvm_safecopy_test.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// FIXME(gvisor.dev/issue//6629): Th... | Go | Apache License 2.0 | google/gvisor | Fix typo in FIXME
PiperOrigin-RevId: 404400399 |
260,004 | 19.10.2021 17:22:45 | 25,200 | bdf4e41c863ce025c67bfd30b5c52d15bdc54ced | Always parse Transport headers
..including ICMP headers before delivering them to the
TransportDispatcher.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/parse/parse.go",
"new_path": "pkg/tcpip/header/parse/parse.go",
"diff": "@@ -110,6 +110,16 @@ traverseExtensions:\nswitch extHdr := extHdr.(type) {\ncase header.IPv6FragmentExtHdr:\n+ if extHdr.IsAtomic() {\n+ // This fragment extension header... | Go | Apache License 2.0 | google/gvisor | Always parse Transport headers
..including ICMP headers before delivering them to the
TransportDispatcher.
Updates #3810.
PiperOrigin-RevId: 404404002 |
259,992 | 20.10.2021 10:42:29 | 25,200 | c23d67f3c092176d0d5313f186d571d4067c1d57 | Report correct error when restore fails
When file corruption is detected, report vfs.ErrCorruption to
distinguish corruption error from other restore errors.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/save_restore.go",
"new_path": "pkg/sentry/fsimpl/gofer/save_restore.go",
"diff": "@@ -277,18 +277,18 @@ func (d *dentry) restoreFile(ctx context.Context, file p9file, qid p9.QID, attrM\nif d.isRegularFile() {\nif opts.ValidateFileSizes ... | Go | Apache License 2.0 | google/gvisor | Report correct error when restore fails
When file corruption is detected, report vfs.ErrCorruption to
distinguish corruption error from other restore errors.
Updates #1035
PiperOrigin-RevId: 404588445 |
259,992 | 20.10.2021 14:12:55 | 25,200 | cfcd3eba9f011b73be1f359f6da7af7f2584a089 | Add Debug to log file header | [
{
"change_type": "MODIFY",
"old_path": "runsc/cli/main.go",
"new_path": "runsc/cli/main.go",
"diff": "@@ -229,6 +229,7 @@ func Main(version string) {\nlog.Infof(\"\\t\\tNetwork: %v, logging: %t\", conf.Network, conf.LogPackets)\nlog.Infof(\"\\t\\tStrace: %t, max size: %d, syscalls: %s\", conf.Strace... | Go | Apache License 2.0 | google/gvisor | Add Debug to log file header
PiperOrigin-RevId: 404635832 |
259,962 | 21.10.2021 13:50:08 | 25,200 | 207221ffb27f2010c46468d827f1817432df3960 | Add an integration test for istio like redirect.
Updates #6441,#6317 | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"bytes\"\n\"context\"\n\"errors\"\n+ \"fmt\"\n\"io\"\n\"net\"\n\"time\"\n@@ -471,9 +472,9 @@ func DialTCP(s *stack.Stack, addr tcpip.Full... | Go | Apache License 2.0 | google/gvisor | Add an integration test for istio like redirect.
Updates #6441,#6317
PiperOrigin-RevId: 404872327 |
259,875 | 23.10.2021 15:38:28 | 25,200 | c0dfa0e845b3571550e84bdebb411b119086b4aa | initialize hostFeatureSet from init function | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -43,7 +43,7 @@ func HostFeatureSet() *FeatureSet {\nreturn hostFeatureSet\n}\n-var hostFeatureSet = getHostFeatureSet()\n+var hostFeatureSet *FeatureSet\n// ErrIncompatible is returned by Featu... | Go | Apache License 2.0 | google/gvisor | initialize hostFeatureSet from init function |
259,853 | 25.10.2021 13:29:21 | 25,200 | a8a66d899fe075c2a23b21edd0aab4e658ad7e81 | Deflake the fcntl test
Wait when a child process will start to measure a blocking time more precise. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/fcntl.cc",
"new_path": "test/syscalls/linux/fcntl.cc",
"diff": "@@ -175,12 +175,19 @@ class FcntlSignalTest : public ::testing::Test {\nnamespace {\nPosixErrorOr<Cleanup> SubprocessLock(std::string const& path, bool for_write,\n- bool block... | Go | Apache License 2.0 | google/gvisor | Deflake the fcntl test
Wait when a child process will start to measure a blocking time more precise.
PiperOrigin-RevId: 405478376 |
259,907 | 25.10.2021 13:43:37 | 25,200 | 4d07fc952d6bb5aa70b4bc9ff5e6457987f1721c | Do not leak non-permission mode bits in mq_open(2).
As caught by syzkaller, we were leaking non-permission bits while passing the
user generated mode. DynamicBytesFile panics in this case.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/mq/mq.go",
"new_path": "pkg/sentry/kernel/mq/mq.go",
"diff": "@@ -122,7 +122,7 @@ type OpenOpts struct {\n// FindOrCreate creates a new POSIX message queue or opens an existing queue.\n// See mq_open(2).\n-func (r *Registry) FindOrCreate(ctx ... | Go | Apache License 2.0 | google/gvisor | Do not leak non-permission mode bits in mq_open(2).
As caught by syzkaller, we were leaking non-permission bits while passing the
user generated mode. DynamicBytesFile panics in this case.
Reported-by: syzbot+5abe52d47d56a5a98c89@syzkaller.appspotmail.com
PiperOrigin-RevId: 405481392 |
259,885 | 26.10.2021 00:19:54 | 25,200 | 12480f1c4b49234a3761856e40d4d122695b610f | Ensure statfs::f_namelen is set by VFS2 gofer statfs/fstatfs.
VFS1 discards the value of f_namelen returned by the filesystem and returns
NAME_MAX unconditionally instead, so it doesn't run into this. Also set
f_frsize for completeness. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1696,7 +1696,7 @@ func (fs *filesystem) StatFSAt(ctx context.Context, rp *vfs.ResolvingPath) (linu\nif err := d.controlFDLisa.StatFSTo(ctx, &statFS); err ... | Go | Apache License 2.0 | google/gvisor | Ensure statfs::f_namelen is set by VFS2 gofer statfs/fstatfs.
VFS1 discards the value of f_namelen returned by the filesystem and returns
NAME_MAX unconditionally instead, so it doesn't run into this. Also set
f_frsize for completeness.
PiperOrigin-RevId: 405579707 |
259,898 | 26.10.2021 10:11:19 | 25,200 | c8d835470037be9efcad13091fb6d173c68cc0ca | Remove superfluous SO_RCVBUFFORCE | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/rawsockets.go",
"new_path": "test/packetimpact/testbench/rawsockets.go",
"diff": "@@ -58,9 +58,6 @@ func (n *DUTTestNet) NewSniffer(t *testing.T) (Sniffer, error) {\nif err := unix.Bind(snifferFd, &sa); err != nil {\nreturn Sniffer{... | Go | Apache License 2.0 | google/gvisor | Remove superfluous SO_RCVBUFFORCE
PiperOrigin-RevId: 405674425 |
260,001 | 26.10.2021 11:48:33 | 25,200 | 8b2e8caad400fd3e7d3e4e235d26dd2d556bf65c | Move attestation definitions to standalone package | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/abi/attestation/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"attestation\",\n+ srcs = [\"attestation.go\"],\n+ visibility = [\"//visibility:public\"],\n+)\n"
... | Go | Apache License 2.0 | google/gvisor | Move attestation definitions to standalone package
PiperOrigin-RevId: 405698863 |
259,907 | 26.10.2021 11:56:09 | 25,200 | 763d7e6e396d8d4c67d650e02bd2350b22606ada | Obtain ref on root dentry in mqfs.GetFilesystem.
As documented in FilesystemType.GetFilesystem, a reference should be taken on
the returned dentry and filesystem by GetFilesystem implementation. mqfs did
not do that.
Additionally cleanup and clarify ref counting of dentry, filesystem and mount
in mqfs.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/mqfs/mqfs.go",
"new_path": "pkg/sentry/fsimpl/mqfs/mqfs.go",
"diff": "@@ -75,6 +75,7 @@ func (ft FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.VirtualF\nimpl.fs.MaxCachedDentries = maxCachedDentries\nimpl.fs.VFSFilesystem().I... | Go | Apache License 2.0 | google/gvisor | Obtain ref on root dentry in mqfs.GetFilesystem.
As documented in FilesystemType.GetFilesystem, a reference should be taken on
the returned dentry and filesystem by GetFilesystem implementation. mqfs did
not do that.
Additionally cleanup and clarify ref counting of dentry, filesystem and mount
in mqfs.
Reported-by: syzbot+a2c54bfb6e1525228e5f@syzkaller.appspotmail.com
Reported-by: syzbot+ccd305cdab11cfebbfff@syzkaller.appspotmail.com
PiperOrigin-RevId: 405700565 |
260,004 | 26.10.2021 12:37:43 | 25,200 | 07b22740a11632c0641657cc4dd145bd0d1e5afb | Run packet socket tests on Fuchsia | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/packet_socket.cc",
"new_path": "test/syscalls/linux/packet_socket.cc",
"diff": "@@ -94,7 +94,9 @@ TEST_P(PacketSocketTest, GetSockName) {\nEq(sizeof(addr) - sizeof(addr.sll_addr))));\nEXPECT_EQ(addr.sll_family, AF_PACKET);\nEXPECT_EQ(addr.s... | Go | Apache License 2.0 | google/gvisor | Run packet socket tests on Fuchsia
Bug: https://fxbug.dev/81592
PiperOrigin-RevId: 405710156 |
259,853 | 26.10.2021 15:20:07 | 25,200 | f54a25c1f03e705f2fb65be7389ddeb37bc5e64e | Validate an icmp header before accessing it
A header can't be smaller than header.ICMPv4MinimumSize.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -572,6 +572,10 @@ func (p *protocol) returnError(reason icmpReason, pkt *stack.PacketBuffer) tcpip\n// if problems arise this could be reversed. It was judged less of a ... | Go | Apache License 2.0 | google/gvisor | Validate an icmp header before accessing it
A header can't be smaller than header.ICMPv4MinimumSize.
Reported-by: syzbot+57b68b14b4f6a58bf985@syzkaller.appspotmail.com
PiperOrigin-RevId: 405748438 |
259,907 | 26.10.2021 16:57:12 | 25,200 | 7b8f19dc76a9fecbf4d2e5f43a47c6d47d53e100 | Simplify vfs.NewDisconnectedMount signature and callpoints.
vfs.NewDisconnectedMount has no error paths. Its much prettier without the
error return value.
Also simplify MountDisconnected which would immediately drop the refs taken by
NewDisconnectedMount. Instead make it directly call newMount. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/mqfs/registry.go",
"new_path": "pkg/sentry/fsimpl/mqfs/registry.go",
"diff": "@@ -71,10 +71,7 @@ func NewRegistryImpl(ctx context.Context, vfsObj *vfs.VirtualFilesystem, creds *\nvar dentry kernfs.Dentry\ndentry.InitRoot(&fs.Filesystem, fs.ne... | Go | Apache License 2.0 | google/gvisor | Simplify vfs.NewDisconnectedMount signature and callpoints.
vfs.NewDisconnectedMount has no error paths. Its much prettier without the
error return value.
Also simplify MountDisconnected which would immediately drop the refs taken by
NewDisconnectedMount. Instead make it directly call newMount.
PiperOrigin-RevId: 405767966 |
259,977 | 27.10.2021 10:03:11 | 25,200 | 22a6a37079c69129d10abfbdd6fdfdf7a9d4a68d | Record counts of packets with unknown L3/L4 numbers
Previously, we recorded a single aggregated count. These per-protocol counts
can help us debug field issues when frames are dropped for this reason. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -81,8 +81,6 @@ func mustCreateGauge(name, description string) *tcpip.StatCounter {\nvar Metrics = tcpip.Stats{\nDroppedPackets: mustCreateMetric(\"/netst... | Go | Apache License 2.0 | google/gvisor | Record counts of packets with unknown L3/L4 numbers
Previously, we recorded a single aggregated count. These per-protocol counts
can help us debug field issues when frames are dropped for this reason.
PiperOrigin-RevId: 405913911 |
260,004 | 27.10.2021 13:39:24 | 25,200 | 3015c0ac67ef7703899e753121efe326dc0cbecd | NAT ICMPv4 errors
...so a NAT-ed connection's socket can handle ICMP errors.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -209,19 +209,120 @@ type bucket struct {\ntuples tupleList\n}\n-func getTransportHeader(pkt *PacketBuffer) (header.ChecksummableTransport, bool) {\n+func getHeaders(pkt *Pac... | Go | Apache License 2.0 | google/gvisor | NAT ICMPv4 errors
...so a NAT-ed connection's socket can handle ICMP errors.
Updates #5916.
PiperOrigin-RevId: 405970089 |
259,891 | 27.10.2021 15:37:20 | 25,200 | 9541a5842bf843414d872a539d32ce6e3202bf04 | rename tcp_conntrack inbound/outbound to reply/original
Connection tracking is agnostic to whether the packet is inbound or outbound. It
cares who initiated the connection. The naming can get confusing as conntrack
can track connections originating from any host.
Part of resolving | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -164,9 +164,9 @@ func (cn *conn) updateLocked(pkt *PacketBuffer, reply bool) {\n}\nif reply {\n- cn.tcb.UpdateStateInbound(tcpHeader)\n+ cn.tcb.UpdateStateReply(tcpHeader)\n... | Go | Apache License 2.0 | google/gvisor | rename tcp_conntrack inbound/outbound to reply/original
Connection tracking is agnostic to whether the packet is inbound or outbound. It
cares who initiated the connection. The naming can get confusing as conntrack
can track connections originating from any host.
Part of resolving #6736.
PiperOrigin-RevId: 405997540 |
259,985 | 27.10.2021 17:58:29 | 25,200 | 6078d26588c021d4b78501ad25cb725ff2db797e | Sychronize access to cpuset controller bitmaps.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cpuset.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cpuset.go",
"diff": "@@ -26,6 +26,7 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/fsimpl/kernfs\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel/auth\... | Go | Apache License 2.0 | google/gvisor | Sychronize access to cpuset controller bitmaps.
Reported-by: syzbot+39d434b96cf7c29a66ad@syzkaller.appspotmail.com
Reported-by: syzbot+7c38bce6353d91facca3@syzkaller.appspotmail.com
PiperOrigin-RevId: 406024052 |
260,004 | 28.10.2021 19:33:32 | 25,200 | 1953d2ad28d405a3ab028feba7b6fca18339e9be | NAT ICMPv6 errors
...so a NAT-ed connection's socket can handle ICMP errors.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -209,6 +209,22 @@ type bucket struct {\ntuples tupleList\n}\n+func getEmbeddedNetAndTransHeaders(pkt *PacketBuffer, netHdrLength int, netHdrFunc func([]byte) header.Network)... | Go | Apache License 2.0 | google/gvisor | NAT ICMPv6 errors
...so a NAT-ed connection's socket can handle ICMP errors.
Updates #5916.
PiperOrigin-RevId: 406270868 |
260,029 | 31.10.2021 17:40:02 | -19,080 | 40bf5aa790004178ad315328e4d75bf9af0a4451 | Update REDME.md
Grammar correction. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/README.md",
"new_path": "g3doc/README.md",
"diff": "@@ -23,7 +23,7 @@ links below to see detailed instructions for each of them:\ngVisor provides a virtualized environment in order to sandbox containers. The\nsystem interfaces normally implemented by the... | Go | Apache License 2.0 | google/gvisor | Update REDME.md
Grammar correction. |
259,858 | 01.11.2021 16:05:18 | 25,200 | 9776edb3fa9e67a28182aedc9342ef9c1b556d7c | Move ThreadGroupIDFromContext to kernel/auth.
This function doesn't belong in the global context package. Move to a more
suitable package to break the dependency cycle. | [
{
"change_type": "MODIFY",
"old_path": "pkg/context/context.go",
"new_path": "pkg/context/context.go",
"diff": "@@ -29,26 +29,6 @@ import (\n\"gvisor.dev/gvisor/pkg/log\"\n)\n-type contextID int\n-\n-// Globally accessible values from a context. These keys are defined in the\n-// context package to ... | Go | Apache License 2.0 | google/gvisor | Move ThreadGroupIDFromContext to kernel/auth.
This function doesn't belong in the global context package. Move to a more
suitable package to break the dependency cycle.
PiperOrigin-RevId: 406942122 |
259,907 | 01.11.2021 16:48:16 | 25,200 | 58017e655399384afed2cedea0e269cb1ad2dd7e | Handle UMOUNT_NOFOLLOW in VFS2 umount(2).
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/mount.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/mount.go",
"diff": "@@ -136,14 +136,14 @@ func Umount2(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysca\nif err != nil {\nreturn 0, nil, err\n}\n- tpop, er... | Go | Apache License 2.0 | google/gvisor | Handle UMOUNT_NOFOLLOW in VFS2 umount(2).
Reported-by: syzbot+f9ecb181a4b3abdde9b9@syzkaller.appspotmail.com
Reported-by: syzbot+8c5cb9d7a044a91a513b@syzkaller.appspotmail.com
PiperOrigin-RevId: 406951359 |
259,892 | 31.10.2021 16:33:32 | -7,200 | a0849e657836cc76fc94e09bcae0755944b46a5c | copy PERM ARP entries from namespace on boot
copy and setup PERMANENT (static) ARP entries
from CNI namespace to the sandbox
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/network.go",
"new_path": "runsc/boot/network.go",
"diff": "@@ -78,6 +78,11 @@ type DefaultRoute struct {\nName string\n}\n+type Neighbor struct {\n+ IP net.IP\n+ HardwareAddr net.HardwareAddr\n+}\n+\n// FDBasedLink configures an fd-based link.\ntype... | Go | Apache License 2.0 | google/gvisor | copy PERM ARP entries from namespace on boot
copy and setup PERMANENT (static) ARP entries
from CNI namespace to the sandbox
Fixes #3301 |
259,992 | 02.11.2021 12:26:18 | 25,200 | 1e1d6b2be37873c5e62461834df973f41565c662 | Allow SetAttr and Allocate for deleted files
It's safe to call SetAttr and Allocate on fsgofer because the
file path is not used to open the file, if needed.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/file.go",
"new_path": "pkg/p9/file.go",
"diff": "@@ -21,13 +21,37 @@ import (\n\"gvisor.dev/gvisor/pkg/fd\"\n)\n+// AttacherOptions contains Attacher configuration.\n+type AttacherOptions struct {\n+ // SetAttrOnDeleted is set to true if it's safe to ca... | Go | Apache License 2.0 | google/gvisor | Allow SetAttr and Allocate for deleted files
It's safe to call SetAttr and Allocate on fsgofer because the
file path is not used to open the file, if needed.
Fixes #3654
PiperOrigin-RevId: 407149393 |
260,004 | 02.11.2021 14:51:10 | 25,200 | 88cf2e93e5ca3ce0f852a0e3dfb06099777c08c0 | Extract tcb & lastUsed to its own lock
These fields do not need to synchronize reads/writes with the rest of
the connection. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -119,22 +119,24 @@ type conn struct {\n//\n// +checklocks:mu\ndestinationManip bool\n+\n+ stateMu sync.RWMutex `state:\"nosave\"`\n// tcb is TCB control block. It is used to... | Go | Apache License 2.0 | google/gvisor | Extract tcb & lastUsed to its own lock
These fields do not need to synchronize reads/writes with the rest of
the connection.
PiperOrigin-RevId: 407183693 |
259,975 | 04.11.2021 14:52:36 | 25,200 | fe8e48fc6d5094fe34783b1040b2ae4ba05349b5 | [syserr] Move ConvertIntr function to linuxerr package
Move ConverIntr out of syserr package and delete an unused function. | [
{
"change_type": "MODIFY",
"old_path": "pkg/errors/linuxerr/internal.go",
"new_path": "pkg/errors/linuxerr/internal.go",
"diff": "@@ -118,3 +118,12 @@ func SyscallRestartErrorFromReturn(rv uintptr) (*errors.Error, bool) {\nerr, ok := restartMap[int(rv)]\nreturn err, ok\n}\n+\n+// ConvertIntr convert... | Go | Apache License 2.0 | google/gvisor | [syserr] Move ConvertIntr function to linuxerr package
Move ConverIntr out of syserr package and delete an unused function.
PiperOrigin-RevId: 407676258 |
259,891 | 07.11.2021 14:54:34 | 28,800 | efe264ef0cdf5929834614b26017f688ac139036 | Use platform-independant iovec functions | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/socket_unsafe.go",
"new_path": "pkg/sentry/fs/host/socket_unsafe.go",
"diff": "@@ -43,12 +43,12 @@ func fdReadVec(fd int, bufs [][]byte, control []byte, peek bool, maxlen int64) (\nvar msg unix.Msghdr\nif len(control) != 0 {\nmsg.Control = &... | Go | Apache License 2.0 | google/gvisor | Use platform-independant iovec functions |
259,907 | 08.11.2021 00:37:24 | 28,800 | 4622e17bccc7c40a2698e8314d29bbde87090cec | Simplify {Un}MarshalUnsafeSlice method signatures.
Earlier this function was returning (int, error) much like the Copy{In/Out}
methods. The returned error was always nil. The returned int was never used.
Instead make it returned the shifted buffer which is more useful.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/message.go",
"new_path": "pkg/lisafs/message.go",
"diff": "@@ -307,11 +307,7 @@ func (m *MountResp) MarshalBytes(dst []byte) []byte {\ndst = m.MaxMessageSize.MarshalUnsafe(dst)\nnumSupported := primitive.Uint16(len(m.SupportedMs))\ndst = numSupporte... | Go | Apache License 2.0 | google/gvisor | Simplify {Un}MarshalUnsafeSlice method signatures.
Earlier this function was returning (int, error) much like the Copy{In/Out}
methods. The returned error was always nil. The returned int was never used.
Instead make it returned the shifted buffer which is more useful.
Updates #6450
PiperOrigin-RevId: 408268327 |
259,907 | 08.11.2021 09:41:41 | 28,800 | 55b70552c16232c19f31f1cf9413b8aebd525cda | Replace references of ConnectableEndpoint with BoundEndpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/socket.go",
"new_path": "pkg/sentry/fs/gofer/socket.go",
"diff": "@@ -79,7 +79,7 @@ func sockTypeToP9(t linux.SockType) (p9.ConnectFlags, bool) {\nreturn 0, false\n}\n-// BidirectionalConnect implements ConnectableEndpoint.BidirectionalConn... | Go | Apache License 2.0 | google/gvisor | Replace references of ConnectableEndpoint with BoundEndpoint.
PiperOrigin-RevId: 408366542 |
259,907 | 08.11.2021 11:33:07 | 28,800 | 49d23beb283d0306c9ccf5300e73517153ddd3c2 | Allow array and primitive types with names starting with W. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator_interfaces_array_newtype.go",
"new_path": "tools/go_marshal/gomarshal/generator_interfaces_array_newtype.go",
"diff": "@@ -139,11 +139,11 @@ func (g *interfaceGenerator) emitMarshallableForArrayNewtype(n *ast.Ident, a *as\n... | Go | Apache License 2.0 | google/gvisor | Allow array and primitive types with names starting with W.
PiperOrigin-RevId: 408397832 |
259,853 | 09.11.2021 20:56:41 | 28,800 | 37792ee1e6e12fbc6fb81a5913846a5a80233f0c | Validate ControlMessageHeader.Length
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/BUILD",
"new_path": "pkg/sentry/socket/control/BUILD",
"diff": "@@ -37,6 +37,7 @@ go_test(\ndeps = [\n\"//pkg/abi/linux\",\n\"//pkg/binary\",\n+ \"//pkg/errors/linuxerr\",\n\"//pkg/hostarch\",\n\"//pkg/sentry/socket\",\n\"@com_github_... | Go | Apache License 2.0 | google/gvisor | Validate ControlMessageHeader.Length
Reported-by: syzbot+fee12cabc732cf92d9e7@syzkaller.appspotmail.com
PiperOrigin-RevId: 408776291 |
259,909 | 10.11.2021 14:09:13 | 28,800 | bb1ae811f4eb3ba59ab8e64672f06a83bc17fd4c | Prevent PacketBuffers from being returned to the pool too early in nic.
PacketBuffers were calling DecRef inside the forEach callback in
deliverOutboundPacket and DeliverNetworkPacket, even though
they were referenced in future iterations of the loop. This caused a
data race.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -740,6 +740,11 @@ func (n *nic) DeliverNetworkPacket(remote, local tcpip.LinkAddress, protocol tcp\n// Deliver to interested packet endpoints without holding NIC lock.\nvar packetEPPkt ... | Go | Apache License 2.0 | google/gvisor | Prevent PacketBuffers from being returned to the pool too early in nic.
PacketBuffers were calling DecRef inside the forEach callback in
deliverOutboundPacket and DeliverNetworkPacket, even though
they were referenced in future iterations of the loop. This caused a
data race.
Reported-by: syzbot+10c56102ab3d68689806@syzkaller.appspotmail.com
PiperOrigin-RevId: 408972907 |
259,992 | 10.11.2021 14:58:21 | 28,800 | ffc3a0d840f0a7027d2db9600544a1fbe5f8d004 | Fix socket permission
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sockfs/sockfs.go",
"new_path": "pkg/sentry/fsimpl/sockfs/sockfs.go",
"diff": "@@ -117,7 +117,7 @@ func NewDentry(ctx context.Context, mnt *vfs.Mount) *vfs.Dentry {\nfs := mnt.Filesystem().Impl().(*filesystem)\n// File mode matches net/socket.... | Go | Apache License 2.0 | google/gvisor | Fix socket permission
Closes #6773
PiperOrigin-RevId: 408984647 |
259,992 | 10.11.2021 17:04:36 | 28,800 | 07836a3ff1b0c4612afe80e5914cb637a39f8f0b | Implement ioctl(fd, FIONREAD) for host FDs
Closes | [
{
"change_type": "MODIFY",
"old_path": "images/basic/integrationtest/Dockerfile.x86_64",
"new_path": "images/basic/integrationtest/Dockerfile.x86_64",
"diff": "@@ -11,3 +11,4 @@ RUN gcc -O2 -o test_copy_up test_copy_up.c\nRUN gcc -O2 -o test_rewinddir test_rewinddir.c\nRUN gcc -O2 -o link_test link_... | Go | Apache License 2.0 | google/gvisor | Implement ioctl(fd, FIONREAD) for host FDs
Closes #6796
PiperOrigin-RevId: 409013591 |
259,992 | 11.11.2021 11:22:03 | 28,800 | 83eb263b454882a20e4a8920ac2e082cf9d78001 | Make more cgroup controllers optional
Mark all noop cgroups as optional, after all there is no harm in skipping them.
Make pids cgroup optional because they are not present on Synology NAS.
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -57,7 +57,7 @@ var controllers = map[string]controller{\n\"devices\": &noop{},\n\"freezer\": &noop{},\n\"perf_event\": &noop{},\n- \"rdma\": &noop{isOptional: true},\n+ \"rdma\": &noop{... | Go | Apache License 2.0 | google/gvisor | Make more cgroup controllers optional
Mark all noop cgroups as optional, after all there is no harm in skipping them.
Make pids cgroup optional because they are not present on Synology NAS.
Closes #6856
PiperOrigin-RevId: 409197613 |
259,896 | 11.11.2021 13:09:37 | 28,800 | 5202e4f1781079708414b2f2e52523d7f117c865 | Fix typo and bazel output binary path. | [
{
"change_type": "MODIFY",
"old_path": "test/iptables/README.md",
"new_path": "test/iptables/README.md",
"diff": "@@ -17,7 +17,7 @@ iptables require some extra Docker configuration to work. Enable IPv6 in\nAnd if you're running manually (i.e. not using the `make` target), you'll need\nto:\n-* Enable... | Go | Apache License 2.0 | google/gvisor | Fix typo and bazel output binary path.
PiperOrigin-RevId: 409224559 |
260,004 | 11.11.2021 15:54:11 | 28,800 | 6961f3ef47257e88a4b147dce4948c73397da3f3 | Handle source port conflicts
This change also updates the ConnTrack seed to be generated by the
stack's random generator instead of using the stack's seed.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/netfilter.go",
"new_path": "pkg/sentry/socket/netfilter/netfilter.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"bytes\"\n\"errors\"\n\"fmt\"\n+ \"math/rand\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/hostarch\"\n@@... | Go | Apache License 2.0 | google/gvisor | Handle source port conflicts
This change also updates the ConnTrack seed to be generated by the
stack's random generator instead of using the stack's seed.
Fixes #5773.
PiperOrigin-RevId: 409264463 |
259,909 | 12.11.2021 12:18:18 | 28,800 | ed3ac3a84d5779cf31cb5f29e9033d951f3c7030 | Move `defer pkt.DecRef()` to outside of the dispatch loop.
This avoids unnecessary allocations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/packet_dispatchers.go",
"new_path": "pkg/tcpip/link/fdbased/packet_dispatchers.go",
"diff": "@@ -284,13 +284,16 @@ func (d *recvMMsgDispatcher) dispatch() (bool, tcpip.Error) {\nreturn false, err\n}\n// Process each of received packets.\... | Go | Apache License 2.0 | google/gvisor | Move `defer pkt.DecRef()` to outside of the dispatch loop.
This avoids unnecessary allocations.
PiperOrigin-RevId: 409473262 |
260,004 | 12.11.2021 12:56:49 | 28,800 | 1dbdfd074930afc0c1a4abcd752e18bd606ffef4 | Remove unused member
missed this. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables_types.go",
"new_path": "pkg/tcpip/stack/iptables_types.go",
"diff": "@@ -81,11 +81,6 @@ const (\n//\n// +stateify savable\ntype IPTables struct {\n- // priorities maps each hook to a list of table names. The order of the\n- // list is ... | Go | Apache License 2.0 | google/gvisor | Remove unused member
https://github.com/google/gvisor/commit/49e80a1440b349b24bddb1ba4fa5469645a84e27
missed this.
PiperOrigin-RevId: 409481435 |
259,891 | 12.11.2021 15:21:47 | 28,800 | 82793c5e9056547c20ddbfa1190a65585a420d1e | netstack: fix Mac build error
Stub out sighandling functions with panics on Darwin
Put Linux-specific errors into their own syserr file
Not sure how best to get automated tests running, so I'll leave that for a later
change.
Fixes
Related to | [
{
"change_type": "MODIFY",
"old_path": "pkg/sighandling/BUILD",
"new_path": "pkg/sighandling/BUILD",
"diff": "@@ -6,7 +6,8 @@ go_library(\nname = \"sighandling\",\nsrcs = [\n\"sighandling.go\",\n- \"sighandling_unsafe.go\",\n+ \"sighandling_darwin.go\",\n+ \"sighandling_linux_unsafe.go\",\n],\nvisib... | Go | Apache License 2.0 | google/gvisor | netstack: fix Mac build error
- Stub out sighandling functions with panics on Darwin
- Put Linux-specific errors into their own syserr file
Not sure how best to get automated tests running, so I'll leave that for a later
change.
Fixes #6839.
Related to #1270.
PiperOrigin-RevId: 409516969 |
259,891 | 12.11.2021 16:21:52 | 28,800 | b490036d831ded4169784a0b8130cd033d1969ac | netstack: remove {linux,darwin}HostTranslation
It can be replaced with a simpler type. | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/host_darwin.go",
"new_path": "pkg/syserr/host_darwin.go",
"diff": "@@ -25,26 +25,21 @@ import (\nconst maxErrno = 107\n-type darwinHostTranslation struct {\n- err *Error\n- ok bool\n-}\n-\n-var darwinHostTranslations [maxErrno]darwinHostTranslation\... | Go | Apache License 2.0 | google/gvisor | netstack: remove {linux,darwin}HostTranslation
It can be replaced with a simpler type.
PiperOrigin-RevId: 409533054 |
259,853 | 12.11.2021 17:30:18 | 28,800 | ea031446515989a9d8b564b326eb26e68a755460 | Use vDSO clock_gettime
The vDSO calls are much faster.
For exeample, here are results of read_benchmark_test_tmpfs_kvm before and
after this change:
Before:
BM_Read/65536/real_time 7309 ns 7260 ns 82640 bytes_per_second=8.35016G/s
After:
BM_Read/65536/real_time 2065 ns 2080 ns 346151 bytes_per_second=29.558G/s | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/time/BUILD",
"new_path": "pkg/sentry/time/BUILD",
"diff": "@@ -27,10 +27,12 @@ go_library(\n\"sampler.go\",\n\"sampler_amd64.go\",\n\"sampler_arm64.go\",\n- \"sampler_unsafe.go\",\n\"seqatomic_parameters_unsafe.go\",\n\"tsc_amd64.s\",\n\"tsc_arm64.s... | Go | Apache License 2.0 | google/gvisor | Use vDSO clock_gettime
The vDSO calls are much faster.
For exeample, here are results of read_benchmark_test_tmpfs_kvm before and
after this change:
Before:
BM_Read/65536/real_time 7309 ns 7260 ns 82640 bytes_per_second=8.35016G/s
After:
BM_Read/65536/real_time 2065 ns 2080 ns 346151 bytes_per_second=29.558G/s
PiperOrigin-RevId: 409547486 |
259,985 | 12.11.2021 17:31:23 | 28,800 | 8650614c32c4dc5e8754b7bf4c84278551cff419 | Shift buffer correctly when unmarshalling FUSE dirents. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fuse.go",
"new_path": "pkg/abi/linux/fuse.go",
"diff": "@@ -782,21 +782,31 @@ func (r *FUSEDirent) SizeBytes() int {\nreturn (dataSize + (FUSE_DIRENT_ALIGN - 1)) & ^(FUSE_DIRENT_ALIGN - 1)\n}\n+// shiftNextDirent advances buf to the start of the ... | Go | Apache License 2.0 | google/gvisor | Shift buffer correctly when unmarshalling FUSE dirents.
PiperOrigin-RevId: 409547679 |
259,907 | 12.11.2021 17:37:13 | 28,800 | 66fb6859d1d0ce6aa7b9ea034a0f1ebab2a91775 | Update CPUID features. | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid_x86.go",
"new_path": "pkg/cpuid/cpuid_x86.go",
"diff": "@@ -167,7 +167,7 @@ const (\nX86FeatureOSPKE\nX86FeatureWAITPKG\nX86FeatureAVX512_VBMI2\n- _ // ecx bit 7 is reserved\n+ X86FeatureCET_SS\nX86FeatureGFNI\nX86FeatureVAES\nX86FeatureVPCLMUL... | Go | Apache License 2.0 | google/gvisor | Update CPUID features.
PiperOrigin-RevId: 409548753 |
259,909 | 16.11.2021 13:43:31 | 28,800 | 5117717034dae2cbaed9497e0369f8772fd6a542 | Fix PacketBuffer memory leak. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/sharedmem.go",
"new_path": "pkg/tcpip/link/sharedmem/sharedmem.go",
"diff": "@@ -413,13 +413,13 @@ func (e *endpoint) dispatchLoop(d stack.NetworkDispatcher) {\npkt := stack.NewPacketBuffer(stack.PacketBufferOptions{\nData: buffer.View... | Go | Apache License 2.0 | google/gvisor | Fix PacketBuffer memory leak.
PiperOrigin-RevId: 410339192 |
260,004 | 16.11.2021 15:40:39 | 28,800 | 4ab52f3cfdbe2c75c6525aa6732210a6d5d64b11 | Drop connection on reply tuple conflict
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"fmt\"\n\"math/rand\"\n\"sync\"\n+ \"sync/atomic\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n@@ -108,6 +109,17 @@ const (\nmanipPerformedNoop\n)\... | Go | Apache License 2.0 | google/gvisor | Drop connection on reply tuple conflict
Updates #6850.
PiperOrigin-RevId: 410368440 |
259,891 | 18.11.2021 12:16:39 | 28,800 | 91313ede801abfe863f67f340903c01e7a6a7852 | buildkite: build Netstack on several platforms
Addresses
RELNOTES: n/a | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -20,6 +20,21 @@ _templates:\nBENCHMARKS_PROJECT: gvisor-benchmarks\nBENCHMARKS_TABLE: benchmarks\nBENCHMARKS_UPLOAD: true\n+ netstack_test: &netstack_test\n+ env:\n+ PACKAGES: >\n+ ... | Go | Apache License 2.0 | google/gvisor | buildkite: build Netstack on several platforms
Addresses #6839.
RELNOTES: n/a
PiperOrigin-RevId: 410869145 |
259,858 | 19.11.2021 16:01:06 | 28,800 | 889190828c60e621be3c6ce4f9d6692b63911203 | Skip header install if not available. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -7,9 +7,13 @@ function install_pkgs() {\nfi\ndone\n}\n-install_pkgs make \"linux-headers-$(uname -r)\" linux-libc-dev \\\n- graphviz jq curl binutils gnupg gnupg-agent gcc p... | Go | Apache License 2.0 | google/gvisor | Skip header install if not available.
PiperOrigin-RevId: 411164318 |
259,891 | 22.11.2021 14:23:18 | 28,800 | 2bedb2dc397a372ea97329e8675c87a9000ad63c | mark platforms as Linux-only
Related to | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/platforms/BUILD",
"new_path": "runsc/boot/platforms/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"select_system\")\npackage(licenses = [\"notice\"])\n+# Don't rewrite the deps attribute o... | Go | Apache License 2.0 | google/gvisor | mark platforms as Linux-only
Related to #1270.
PiperOrigin-RevId: 411648212 |
259,909 | 23.11.2021 14:27:23 | 28,800 | 2758e1123074002d7cda139e92af28b96100b8cd | Modify udpPacket to hold a PacketBuffer reference instead of a VectorizedView. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/packet_buffer.go",
"new_path": "pkg/tcpip/stack/packet_buffer.go",
"diff": "@@ -15,6 +15,7 @@ package stack\nimport (\n\"fmt\"\n+ \"io\"\n\"gvisor.dev/gvisor/pkg/buffer\"\n\"gvisor.dev/gvisor/pkg/sync\"\n@@ -91,6 +92,8 @@ type PacketBufferOptio... | Go | Apache License 2.0 | google/gvisor | Modify udpPacket to hold a PacketBuffer reference instead of a VectorizedView.
PiperOrigin-RevId: 411896048 |
259,992 | 23.11.2021 15:23:25 | 28,800 | 82fd0523dcefb3c39e50bbd8d77928758c31f546 | Skip readonly controllers
Some system have controller directories created, but they are
read-only. Handle that case and skip optional controllers.
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"bufio\"\n\"context\"\n\"encoding/json\"\n+ \"errors\"\n\"fmt\"\n\"io\"\n\"io/ioutil\"\n@@ -445,7 +446,7 @@ func createController(c Cgroup, name string) (bool,... | Go | Apache License 2.0 | google/gvisor | Skip readonly controllers
Some system have controller directories created, but they are
read-only. Handle that case and skip optional controllers.
Closes #5887
PiperOrigin-RevId: 411907208 |
259,891 | 23.11.2021 16:57:47 | 28,800 | 654af2af2e5866bd5adc1f01c2faf0663eb3ca77 | Explicitly pass TCP payload size in conntrack | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -193,14 +193,14 @@ func (cn *conn) update(pkt *PacketBuffer, reply bool) {\n// client. However, we only need to know whether the connection is\n// established or not, so the... | Go | Apache License 2.0 | google/gvisor | Explicitly pass TCP payload size in conntrack
PiperOrigin-RevId: 411925572 |
259,891 | 23.11.2021 17:40:37 | 28,800 | 5e984d5aa2c3f98934040e199d460c74744e5799 | conntrack: account for window scaling
Conntrack was not reading the window scale TCP option and thus could reject
valid packets for being beyond the receive window.
Addresses | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -160,7 +160,9 @@ go_test(\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/faketime\",\n\"//pkg/tcpip/header\",\n+ \"//pkg/tcpip/seqnum\",\n\"//pkg/tcpip/testutil\",\n+ \"//pkg/tcpip/transport/tcp... | Go | Apache License 2.0 | google/gvisor | conntrack: account for window scaling
Conntrack was not reading the window scale TCP option and thus could reject
valid packets for being beyond the receive window.
Addresses #6734.
PiperOrigin-RevId: 411932393 |
259,907 | 29.11.2021 19:24:41 | 28,800 | 91d4826f5be789d67a02857f177160e94d1ba0e9 | Add support for flexible filename limits for tmpfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -117,9 +117,9 @@ func (fs *filesystem) Sync(ctx context.Context) error {\nreturn retErr\n}\n-// maxFilenameLen is the maximum length of a filename. This is... | Go | Apache License 2.0 | google/gvisor | Add support for flexible filename limits for tmpfs.
PiperOrigin-RevId: 413038601 |
259,884 | 29.11.2021 21:24:21 | 28,800 | afd549d79c503129a052f6fa24a9313af6b856b0 | Check for support for xgetbv
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"reflect\"\n\"sync\"\n+ \"gvisor.dev/gvisor/pkg/cpuid\"\n\"gvisor.dev/gvisor/pkg/hostarch\"\n\"gvisor.dev/gvisor/pkg/sentry/arch\"\n)\n@@ -268,13 +269,19... | Go | Apache License 2.0 | google/gvisor | Check for support for xgetbv
Fixes #5738
PiperOrigin-RevId: 413054140 |
259,883 | 26.11.2020 19:55:57 | -28,800 | 576c9e28748c8525da7d985f2daa81c189bc08d6 | blog: Running gVisor in Production at Scale in Ant
A blog about how Ant Group run gVisor in production at scale. | [
{
"change_type": "MODIFY",
"old_path": "website/_config.yml",
"new_path": "website/_config.yml",
"diff": "@@ -47,3 +47,9 @@ authors:\nnybidari:\nname: Nayana Bidari\nemail: nybidari@google.com\n+ jianfengt:\n+ name: Jianfeng Tan\n+ email: henry.tjf@antgroup.com\n+ yonghe:\n+ name: Yong He\n+ email: ... | Go | Apache License 2.0 | google/gvisor | blog: Running gVisor in Production at Scale in Ant
A blog about how Ant Group run gVisor in production at scale.
Signed-off-by: Jianfeng Tan <henry.tjf@antgroup.com>
Signed-off-by: Yong He <chenglang.hy@antgroup.com> |
259,884 | 30.11.2021 22:14:58 | 28,800 | 72e222cd661477de4a9d15b01fe84e3fc4046dac | Handle empty values for XDG_RUNTIME_DIR properly.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/config/flags.go",
"new_path": "runsc/config/flags.go",
"diff": "@@ -126,7 +126,8 @@ func NewFromFlags() (*Config, error) {\nif len(conf.RootDir) == 0 {\n// If not set, set default root dir to something (hopefully) user-writeable.\nconf.RootDir = \"/var/r... | Go | Apache License 2.0 | google/gvisor | Handle empty values for XDG_RUNTIME_DIR properly.
Fixes #6849
PiperOrigin-RevId: 413322019 |
260,004 | 01.12.2021 13:47:45 | 28,800 | 4aec33aac600635aad736d18de4df3f71de3aadd | Explicitly allow new connections to be created
This change is to prepare for later changes which may determine if a
packet is sent in response to an original packet so that the reply
packet does not create a new connection. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -357,66 +357,76 @@ func getTupleIDForPacketInICMPError(pkt *PacketBuffer, getNetAndTransHdr netAndT\nreturn tupleID{}, false\n}\n-func getTupleID(pkt *PacketBuffer) (tid tup... | Go | Apache License 2.0 | google/gvisor | Explicitly allow new connections to be created
This change is to prepare for later changes which may determine if a
packet is sent in response to an original packet so that the reply
packet does not create a new connection.
PiperOrigin-RevId: 413501477 |
259,896 | 01.12.2021 13:57:43 | 28,800 | 8777a4f8c6912d0e6f953afe05a7c14ebdf00a3a | Increment spurious recovery metric only for RTO. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -273,6 +273,7 @@ var Metrics = tcpip.Stats{\nFailedPortReservations: mustCreateMetric(\"/netstack/tcp/failed_port_reservations\", \"Number of time TCP fa... | Go | Apache License 2.0 | google/gvisor | Increment spurious recovery metric only for RTO.
PiperOrigin-RevId: 413504208 |
260,004 | 01.12.2021 17:43:08 | 28,800 | 054229a46bb6f6f2e56fdec8d9a74a2d4fa62a2b | Extract NAT types
...to be shared across tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/integration/iptables_test.go",
"new_path": "pkg/tcpip/tests/integration/iptables_test.go",
"diff": "@@ -1164,40 +1164,7 @@ func TestInputHookWithLocalForwarding(t *testing.T) {\n}\n}\n-func TestNAT(t *testing.T) {\n- const listenPort uint16 = 8... | Go | Apache License 2.0 | google/gvisor | Extract NAT types
...to be shared across tests.
PiperOrigin-RevId: 413552100 |
259,853 | 01.12.2021 17:53:47 | 28,800 | b2f8b495ad73edb34d47154eba9535a14bd32d61 | cgroup/cpuset: handle the offset argument of write methods properly
offset is an offset in a file, so here is no sense to
drop first "offset" number of bytes from a buffer.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -234,11 +234,10 @@ func (d *tasksData) Write(ctx context.Context, src usermem.IOSequence, offset in\n// parseInt64FromString interprets src as string encoding a ... | Go | Apache License 2.0 | google/gvisor | cgroup/cpuset: handle the offset argument of write methods properly
offset is an offset in a file, so here is no sense to
drop first "offset" number of bytes from a buffer.
Reported-by: syzbot+b9610cff22c10d9bead4@syzkaller.appspotmail.com
PiperOrigin-RevId: 413553935 |
259,898 | 02.12.2021 14:32:09 | 28,800 | 40355372f94dad60248767e2c09a199dacf1265a | Allow DUT binaries to define their own flags
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/BUILD",
"new_path": "test/packetimpact/dut/BUILD",
"diff": "@@ -33,6 +33,10 @@ go_library(\nname = \"dut\",\ntestonly = True,\nsrcs = [\"dut.go\"],\n+ visibility = [\n+ \"//test/packetimpact:__subpackages__\",\n+ \"//turquoise/connectivit... | Go | Apache License 2.0 | google/gvisor | Allow DUT binaries to define their own flags
Updates #6835
PiperOrigin-RevId: 413772074 |
259,975 | 02.12.2021 23:56:25 | 28,800 | 74536aba2cf9ee885df5be2a763921439391e10e | [benchmarks] Don't run vfs1 benchmarks anymore. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -394,7 +394,6 @@ benchmark-platforms: load-benchmarks $(RUNTIME_BIN) ## Runs benchmarks for runc\n@set -xe; for PLATFORM in $$($(RUNTIME_BIN) help platforms); do \\\nexport PLATFORM; \\\n$(call run_benchmark,$${PL... | Go | Apache License 2.0 | google/gvisor | [benchmarks] Don't run vfs1 benchmarks anymore.
PiperOrigin-RevId: 413860206 |
259,898 | 03.12.2021 08:28:37 | 28,800 | 791b9428a6de0b2b41806ff1f7ea6bdc6716ed15 | Use net.InterfaceByName to retrieve runsc DUT's device ID. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/dut/runsc/BUILD",
"new_path": "test/packetimpact/dut/runsc/BUILD",
"diff": "@@ -29,5 +29,4 @@ go_binary(\nname = \"devid\",\ntestonly = True,\nsrcs = [\"devid.go\"],\n- deps = [\"@com_github_vishvananda_netlink//:go_default_library\"],\n)\n"
... | Go | Apache License 2.0 | google/gvisor | Use net.InterfaceByName to retrieve runsc DUT's device ID.
PiperOrigin-RevId: 413941742 |
259,898 | 03.12.2021 18:24:53 | 28,800 | 969fb6fb8469618adf6888c9319300ff64b02ae8 | Update expectations for generic_dgram_socket_send_recv_test
prepare for removing the docker packetimpact runner entirely
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -334,10 +334,6 @@ ALL_TESTS = [\nPacketimpactTestInfo(\nname = \"generic_dgram_socket_send_recv\",\ntimeout = \"long\",\n- # This test has assumed the presense of ... | Go | Apache License 2.0 | google/gvisor | Update expectations for generic_dgram_socket_send_recv_test
prepare for removing the docker packetimpact runner entirely
Updates #6835
PiperOrigin-RevId: 414065450 |
259,858 | 06.12.2021 10:09:28 | 28,800 | 3f2ffc9f0c62c9e41e2b58519d472da9c9a5ccb2 | Allow reading for mixed atomic semantics.
This relaxes constraints on mixed atomic / lock protected fields. We
explicitly allow reads in this case, since this should be safe. | [
{
"change_type": "MODIFY",
"old_path": "tools/checklocks/analysis.go",
"new_path": "tools/checklocks/analysis.go",
"diff": "@@ -83,21 +83,24 @@ func (pc *passContext) checkTypeAlignment(pkg *types.Package, typ *types.Named)\n_ = pc.typeAlignment(pkg, typ.Obj())\n}\n+// atomicRules specify read const... | Go | Apache License 2.0 | google/gvisor | Allow reading for mixed atomic semantics.
This relaxes constraints on mixed atomic / lock protected fields. We
explicitly allow reads in this case, since this should be safe.
PiperOrigin-RevId: 414476414 |
259,907 | 06.12.2021 10:33:02 | 28,800 | d62190f8b521fa1b4cc7fc26b24b3f821f198bf7 | Fix lisafs bug which tramples dentry UID on remote revalidation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1173,7 +1173,7 @@ func (d *dentry) updateFromLisaStatLocked(stat *linux.Statx) {\natomic.StoreUint32(&d.uid, dentryUIDFromLisaUID(lisafs.UID(stat.UID)))\n}\nif stat... | Go | Apache License 2.0 | google/gvisor | Fix lisafs bug which tramples dentry UID on remote revalidation.
PiperOrigin-RevId: 414483232 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.