author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,880 | 10.08.2021 13:06:51 | -7,200 | f971396c6515fc71d3cc8cdfbf60845c1d1e9e03 | fix missing SIGTTOU signal in SetForegroundProcessGroup | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/thread_group.go",
"new_path": "pkg/sentry/kernel/thread_group.go",
"diff": "@@ -489,11 +489,6 @@ func (tg *ThreadGroup) SetForegroundProcessGroup(tty *TTY, pgid ProcessGroupID)\ntg.signalHandlers.mu.Lock()\ndefer tg.signalHandlers.mu.Unlock()... | Go | Apache License 2.0 | google/gvisor | fix missing SIGTTOU signal in SetForegroundProcessGroup |
259,907 | 11.08.2021 15:25:31 | 25,200 | c2353e4055ac77d5a205594b5e3d2697b96abd7d | [op] Fix //debian:debian. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -444,7 +444,7 @@ $(RELEASE_ARTIFACTS)/%:\n@mkdir -p $@\n@$(call copy,//runsc:runsc,$@)\n@$(call copy,//shim:containerd-shim-runsc-v1,$@)\n- @$(call copy,//debian:debian,$@)\n+ @$(call deb_copy,//debian:debian,$@)\... | Go | Apache License 2.0 | google/gvisor | [op] Fix //debian:debian.
Co-authored-by: Andrei Vagin <avagin@google.com>
PiperOrigin-RevId: 390232925 |
260,007 | 11.08.2021 16:18:52 | 25,200 | 23f8e8481678593b83842b58306e2e960752ff4a | Fix LinkTest.OldnameDoesNotExist
Previous, this test was the same as OldnameIsEmpty. This CL makes the test check
what happens if the old name does not exist. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/link.cc",
"new_path": "test/syscalls/linux/link.cc",
"diff": "@@ -142,7 +142,8 @@ TEST(LinkTest, OldnameIsEmpty) {\nTEST(LinkTest, OldnameDoesNotExist) {\nconst std::string oldname = NewTempAbsPath();\nconst std::string newname = NewTempAbs... | Go | Apache License 2.0 | google/gvisor | Fix LinkTest.OldnameDoesNotExist
Previous, this test was the same as OldnameIsEmpty. This CL makes the test check
what happens if the old name does not exist.
PiperOrigin-RevId: 390243070 |
259,985 | 11.08.2021 16:32:51 | 25,200 | 8d84c5a8eeb6a08de2ac4920c1e6959055ccbda1 | Wrap test queues in Queue object on creation. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/msgqueue.cc",
"new_path": "test/syscalls/linux/msgqueue.cc",
"diff": "@@ -40,6 +40,10 @@ constexpr int kInterruptSignal = SIGALRM;\nclass Queue {\npublic:\nexplicit Queue(int id) : id_(id) {}\n+ Queue(const Queue&) = delete;\n+ Queue& opera... | Go | Apache License 2.0 | google/gvisor | Wrap test queues in Queue object on creation.
PiperOrigin-RevId: 390245901 |
260,007 | 11.08.2021 16:58:15 | 25,200 | 09b453cec07bceeb4185bc9bc951efbda366472b | Fix FSSupportsMap check
Previously, this check always failed because we did not provide MAP_SHARED
or MAP_PRIVATE. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mmap.cc",
"new_path": "test/syscalls/linux/mmap.cc",
"diff": "@@ -795,7 +795,7 @@ class MMapFileTest : public MMapTest {\nbool FSSupportsMap() const {\nbool supported = true;\n- void* ret = mmap(nullptr, 1, PROT_NONE, 0, fd_.get(), 0);\n+ v... | Go | Apache License 2.0 | google/gvisor | Fix FSSupportsMap check
Previously, this check always failed because we did not provide MAP_SHARED
or MAP_PRIVATE.
PiperOrigin-RevId: 390251086 |
259,985 | 11.08.2021 17:18:53 | 25,200 | a50596874a4971167f97a05181363e91292a2885 | Initial cgroupfs support for subcontainers
Allow creation and management of subcontainers through cgroupfs
directory syscalls. Also add a mechanism to specify a default root
container to start new jobs in.
This implements the filesystem support for subcontainers, but doesn't
implement hierarchical resource accounting or task migration. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/BUILD",
"new_path": "pkg/sentry/fsimpl/cgroupfs/BUILD",
"diff": "@@ -32,6 +32,7 @@ go_library(\n\"//pkg/context\",\n\"//pkg/coverage\",\n\"//pkg/errors/linuxerr\",\n+ \"//pkg/fspath\",\n\"//pkg/log\",\n\"//pkg/refs\",\n\"//pkg/refsvf... | Go | Apache License 2.0 | google/gvisor | Initial cgroupfs support for subcontainers
Allow creation and management of subcontainers through cgroupfs
directory syscalls. Also add a mechanism to specify a default root
container to start new jobs in.
This implements the filesystem support for subcontainers, but doesn't
implement hierarchical resource accounting or task migration.
PiperOrigin-RevId: 390254870 |
260,004 | 11.08.2021 18:18:36 | 25,200 | d51bc877f40d2acbf5b83895f636186c87463ab1 | Run packet socket tests on Fuchsia
+ Do not check for CAP_NET_RAW on Fuchsia
Fuchsia does not support capabilities the same way Linux does. Instead
emulate the check for CAP_NET_RAW by checking if a packet socket may
be created. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -7,6 +7,8 @@ package(\nexports_files(\n[\n+ \"packet_socket.cc\",\n+ \"packet_socket_raw.cc\",\n\"raw_socket.cc\",\n\"raw_socket_hdrincl.cc\",\n\"raw_socket_icmp.cc\",\n@@ -1446,6... | Go | Apache License 2.0 | google/gvisor | Run packet socket tests on Fuchsia
+ Do not check for CAP_NET_RAW on Fuchsia
Fuchsia does not support capabilities the same way Linux does. Instead
emulate the check for CAP_NET_RAW by checking if a packet socket may
be created.
Bug: https://fxbug.dev/79016, https://fxbug.dev/81592
PiperOrigin-RevId: 390263666 |
260,001 | 11.08.2021 20:09:11 | 25,200 | 4249ba85068e7a398187af6c87daca2172ed25e5 | Do not clear merkle files when creating dentry
The dentry for each file/directory can be created/destroyed multiple
times during sandbox lifetime. We should not clear the Merkle file each
time a dentry is created. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -595,23 +595,6 @@ func (fs *filesystem) lookupAndVerifyLocked(ctx context.Context, parent *dentry,\n}\n}\n- // Clear the Merkle tree file if they are to ... | Go | Apache License 2.0 | google/gvisor | Do not clear merkle files when creating dentry
The dentry for each file/directory can be created/destroyed multiple
times during sandbox lifetime. We should not clear the Merkle file each
time a dentry is created.
PiperOrigin-RevId: 390277107 |
260,001 | 11.08.2021 21:14:28 | 25,200 | 01cfe5952883524b185f60f60485dbc25f988cad | Add verity stat benchmark test | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -174,3 +174,10 @@ syscall_test(\ntest = \"//test/perf/linux:verity_open_read_close_benchmark\",\nvfs1 = False,\n)\n+\n+syscall_test(\n+ size = \"large\",\n+ debug = False,\n+ test = \"//test/perf/lin... | Go | Apache License 2.0 | google/gvisor | Add verity stat benchmark test
PiperOrigin-RevId: 390284683 |
259,853 | 12.08.2021 10:11:21 | 25,200 | f06b1fe862be23698539ca0b0dae5f9d5e4f7e51 | test/pipe: use futex() for sync with the signal hander | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pipe.cc",
"new_path": "test/syscalls/linux/pipe.cc",
"diff": "// limitations under the License.\n#include <fcntl.h> /* Obtain O_* constant definitions */\n+#include <linux/futex.h>\n#include <linux/magic.h>\n#include <signal.h>\n#include <s... | Go | Apache License 2.0 | google/gvisor | test/pipe: use futex() for sync with the signal hander
PiperOrigin-RevId: 390399815 |
260,001 | 12.08.2021 14:59:27 | 25,200 | 5f132ae1f889829e57ef6b2117342247b0f75b3a | Clear Merkle files before measuring verity fs | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/verity_prepare.go",
"new_path": "runsc/cmd/verity_prepare.go",
"diff": "@@ -82,7 +82,7 @@ func (c *VerityPrepare) Execute(_ context.Context, f *flag.FlagSet, args ...inte\n},\nProcess: &specs.Process{\nCwd: absRoot,\n- Args: []string{c.tool, \"--path... | Go | Apache License 2.0 | google/gvisor | Clear Merkle files before measuring verity fs
PiperOrigin-RevId: 390467957 |
260,001 | 12.08.2021 18:29:40 | 25,200 | ddcf884e9d396930095ab1fde51b14201e8cf718 | Add Usage controls
Add Usage controls and implement "usage/usagefd" commands. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/BUILD",
"new_path": "pkg/sentry/control/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n\"pprof.go\",\n\"proc.go\",\n\"state.go\",\n+ \"usage.go\",\n],\nvisibility = [\n\"//:sandbox\",\n@@ -39,6 +40,7 @@ go_library(\n\"//pkg/tcpip/link/sniff... | Go | Apache License 2.0 | google/gvisor | Add Usage controls
Add Usage controls and implement "usage/usagefd" commands.
PiperOrigin-RevId: 390507423 |
260,004 | 13.08.2021 07:39:19 | 25,200 | eb0f24c6c48ea5301c5136b53333e189d0dc4c58 | Free multicastMemberships on UDP endpoint close
tcpip.Endpoint.Close is documented to free all resources associated
with an endpoint so we don't need to create an empty map to clear
the multicast memberships. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -266,7 +266,7 @@ func (e *endpoint) Close() {\nfor mem := range e.multicastMemberships {\ne.stack.LeaveGroup(e.NetProto, mem.nicID, mem.multicastAddr)\n}\n- e.... | Go | Apache License 2.0 | google/gvisor | Free multicastMemberships on UDP endpoint close
tcpip.Endpoint.Close is documented to free all resources associated
with an endpoint so we don't need to create an empty map to clear
the multicast memberships.
PiperOrigin-RevId: 390609826 |
259,881 | 13.08.2021 10:41:10 | 25,200 | 8f2b11a87e0c8fc89636617c9161caee9f8f1fb5 | Update `core` allowed dependencies
This list has gotten a little out-of-date. Note that `clockwork` used to be
used but was removed in gvisor.dev/pr/5384. | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -69,6 +69,10 @@ Rules:\nbinary). Use `//pkg/unet` instead.\n* `@org_golang_x_sys//unix:go_default_library` (Go import\n`golang.org/x/sys/unix`).\n+ * `@org_golang_x_time//rate:go_default_library` (Go... | Go | Apache License 2.0 | google/gvisor | Update `core` allowed dependencies
This list has gotten a little out-of-date. Note that `clockwork` used to be
used but was removed in gvisor.dev/pr/5384.
PiperOrigin-RevId: 390644841 |
260,001 | 13.08.2021 14:17:56 | 25,200 | 6eb8596f72f3c889de3f826b82319d41ac655829 | Add Event controls
Add Event controls and implement "stream" commands. | [
{
"change_type": "MODIFY",
"old_path": "pkg/eventchannel/BUILD",
"new_path": "pkg/eventchannel/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\n\"event.go\",\n\"event_any.go\",\n+ \"processor.go\",\n\"rate.go\",\n],\nvisibility = [\"//:sandbox\"],\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | Add Event controls
Add Event controls and implement "stream" commands.
PiperOrigin-RevId: 390691702 |
259,880 | 16.08.2021 16:33:57 | -7,200 | 7c5ab794f140dda031ba015d79892a79dd523d50 | fix sending of SIGTTOU signal in SetForegroundProcessGroup
Changed sendSignal to sendSignalLocked because tg.pidns.owner.mu and tg.signalHandlers.mu
are already locked in SetForegroundProcess
Added a control to verify whether the calling process is ignoring SIGTTOU
before sending the signal | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/thread_group.go",
"new_path": "pkg/sentry/kernel/thread_group.go",
"diff": "@@ -511,9 +511,11 @@ func (tg *ThreadGroup) SetForegroundProcessGroup(tty *TTY, pgid ProcessGroupID)\nreturn -1, linuxerr.EPERM\n}\n- //if the calling process is a me... | Go | Apache License 2.0 | google/gvisor | fix sending of SIGTTOU signal in SetForegroundProcessGroup
Changed sendSignal to sendSignalLocked because tg.pidns.owner.mu and tg.signalHandlers.mu
are already locked in SetForegroundProcess
Added a control to verify whether the calling process is ignoring SIGTTOU
before sending the signal |
259,853 | 16.08.2021 15:50:30 | 25,200 | bb13d015a4ffcedac42cce05ec9f1ff4728d12d7 | imges/syzkaller: add --allow-releaseinfo-change to apt update
Otherwise, it fails with this error:
Get:3 buster/updates InRelease
Reading package lists...
E: Repository 'http://deb.debian.org/debian buster InRelease' changed its
'Suite' value from 'stable' to 'oldstable' | [
{
"change_type": "MODIFY",
"old_path": "images/syzkaller/Dockerfile",
"new_path": "images/syzkaller/Dockerfile",
"diff": "@@ -2,7 +2,7 @@ FROM gcr.io/syzkaller/env\n# This image is mostly for investigating syzkaller crashes, so let's install\n# developer tools.\n-RUN apt update && apt install -y git... | Go | Apache License 2.0 | google/gvisor | imges/syzkaller: add --allow-releaseinfo-change to apt update
Otherwise, it fails with this error:
Get:3 http://security.debian.org/debian-security buster/updates InRelease
Reading package lists...
E: Repository 'http://deb.debian.org/debian buster InRelease' changed its
'Suite' value from 'stable' to 'oldstable'
PiperOrigin-RevId: 391155532 |
259,954 | 05.08.2021 09:49:09 | 21,600 | 0f62f21527b9014653de07fa366fb5b0f48fb16c | Support runtime options type used in containerd v1.5 | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/runtimeoptions/runtimeoptions.go",
"new_path": "pkg/shim/runtimeoptions/runtimeoptions.go",
"diff": "// Package runtimeoptions contains the runtimeoptions proto.\npackage runtimeoptions\n+\n+import proto \"github.com/gogo/protobuf/proto\"\n+\n+func in... | Go | Apache License 2.0 | google/gvisor | Support runtime options type used in containerd v1.5 |
259,853 | 16.08.2021 23:12:12 | 25,200 | 6294a7a6ec6d0e4666f5413df6e59738d02fc12e | test/syscalls/proc_net: /proc/net/snmp can contain system-wide statistics
This is a new kernel feature that are controlled by the net.core.mibs_allocation
sysctl. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net.cc",
"new_path": "test/syscalls/linux/proc_net.cc",
"diff": "@@ -152,6 +152,22 @@ TEST(ProcNetDev, Format) {\nEXPECT_GT(entries.size(), 0);\n}\n+// GetMibsAllocationSysctl retuns a value of the net.core.mibs_allocation\n+// sysctl.... | Go | Apache License 2.0 | google/gvisor | test/syscalls/proc_net: /proc/net/snmp can contain system-wide statistics
This is a new kernel feature that are controlled by the net.core.mibs_allocation
sysctl.
PiperOrigin-RevId: 391215784 |
259,853 | 17.08.2021 12:55:41 | 25,200 | 8f6c54c8c023d551d6d09b5428ac59fb704c7067 | Deflake test/perf:randread_benchmark
The test expects that pread reads the full buffer, it means that the pread
offset has to be equal or less than file_size - buffer_size. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/linux/randread_benchmark.cc",
"new_path": "test/perf/linux/randread_benchmark.cc",
"diff": "@@ -85,7 +85,7 @@ void BM_RandRead(benchmark::State& state) {\nunsigned int seed = 1;\nfor (auto _ : state) {\nTEST_CHECK(PreadFd(fd.get(), buf.data(), buf.si... | Go | Apache License 2.0 | google/gvisor | Deflake test/perf:randread_benchmark
The test expects that pread reads the full buffer, it means that the pread
offset has to be equal or less than file_size - buffer_size.
PiperOrigin-RevId: 391356863 |
259,880 | 16.08.2021 16:37:00 | -7,200 | a5f2ef66d3c7e5ed1fd90cc8670b3e3891ad8af9 | added two system call tests for setForegroundProcessGroup
Test the correct sending of the SIGTTOU in setForegroundProcess | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -1640,6 +1640,57 @@ TEST_F(JobControlTest, DISABLED_SetForegroundProcessGroup) {\nASSERT_NO_ERRNO(res);\n}\n+// This test verify if a SIGTTOU signal is sent to the calling proce... | Go | Apache License 2.0 | google/gvisor | added two system call tests for setForegroundProcessGroup
Test the correct sending of the SIGTTOU in setForegroundProcess |
259,880 | 17.08.2021 22:57:39 | -7,200 | 482de52b60d9ac0bc40f264c82c8eb094401a119 | Added a SIGTTOU block check in SetForegroundProcessGroup | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/thread_group.go",
"new_path": "pkg/sentry/kernel/thread_group.go",
"diff": "@@ -511,10 +511,13 @@ func (tg *ThreadGroup) SetForegroundProcessGroup(tty *TTY, pgid ProcessGroupID)\nreturn -1, linuxerr.EPERM\n}\n- sa:= tg.signalHandlers.actions[... | Go | Apache License 2.0 | google/gvisor | Added a SIGTTOU block check in SetForegroundProcessGroup |
260,001 | 18.08.2021 13:11:36 | 25,200 | 75b5a4f455c2e81bb38dcf786c788089ad1aebf7 | Add control configs
Also plumber the controls through runsc | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/BUILD",
"new_path": "pkg/sentry/control/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\", \"proto_library\")\npackage(licenses = [\"notice\"])\n+proto_library(... | Go | Apache License 2.0 | google/gvisor | Add control configs
Also plumber the controls through runsc
PiperOrigin-RevId: 391594318 |
259,880 | 17.08.2021 23:25:47 | -7,200 | ce4e54186e7c4a59bcdd9a74d89c5d4c2a7174f9 | Added a system call test for SetForegroundProcessGroup
Added a test to check if the process in background is blocking SIGTTOU
Some minor formatting fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -1640,18 +1640,18 @@ TEST_F(JobControlTest, DISABLED_SetForegroundProcessGroup) {\nASSERT_NO_ERRNO(res);\n}\n-// This test verify if a SIGTTOU signal is sent to the calling proc... | Go | Apache License 2.0 | google/gvisor | Added a system call test for SetForegroundProcessGroup
-Added a test to check if the process in background is blocking SIGTTOU
-Some minor formatting fixes |
259,898 | 18.08.2021 16:56:40 | 25,200 | a4ae5fed32c09d5c09b4d540b9d5faa8fcd5dda1 | Split TCP secrets from Stack to tcp.protocol
Use different secrets for different purposes (port picking,
ISN generation, tsOffset generation) and moved the secrets
from stack.Stack to tcp.protocol. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -119,8 +119,7 @@ type Stack struct {\n// by the stack.\nicmpRateLimiter *ICMPRateLimiter\n- // seed is a one-time random value initialized at stack startup\n- // and is used to seed... | Go | Apache License 2.0 | google/gvisor | Split TCP secrets from Stack to tcp.protocol
Use different secrets for different purposes (port picking,
ISN generation, tsOffset generation) and moved the secrets
from stack.Stack to tcp.protocol.
PiperOrigin-RevId: 391641238 |
259,898 | 19.08.2021 13:12:50 | 25,200 | 50ed6b2e0994225b9bffa63b57a42da2d05e02b9 | Use a hash function to generate tcp timestamp offset
Also fix an option parsing error in checker.TCPTimestampChecker while I am here. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -729,7 +729,7 @@ func TCPTimestampChecker(wantTS bool, wantTSVal uint32, wantTSEcr uint32) Transp\nreturn\n}\nl := int(opts[i+1])\n- if i < 2 || i+l > limit {\n+ if l < 2 ||... | Go | Apache License 2.0 | google/gvisor | Use a hash function to generate tcp timestamp offset
Also fix an option parsing error in checker.TCPTimestampChecker while I am here.
PiperOrigin-RevId: 391828329 |
259,885 | 19.08.2021 17:08:02 | 25,200 | a77eaf2a9e0539326defc766d748b8eff1d89b0b | Use MM-mapped I/O instead of buffered copies in gofer.specialFileFD.
The rationale given for using buffered copies is still valid, but it's unclear
whether holding MM locks or allocating buffers is better in practice, and the
former is at least consistent with gofer.regularFileFD (and VFS1), making
performance easier to reason about. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/handle.go",
"new_path": "pkg/sentry/fsimpl/gofer/handle.go",
"diff": "@@ -20,6 +20,7 @@ import (\n\"gvisor.dev/gvisor/pkg/p9\"\n\"gvisor.dev/gvisor/pkg/safemem\"\n\"gvisor.dev/gvisor/pkg/sentry/hostfd\"\n+ \"gvisor.dev/gvisor/pkg/sync\"... | Go | Apache License 2.0 | google/gvisor | Use MM-mapped I/O instead of buffered copies in gofer.specialFileFD.
The rationale given for using buffered copies is still valid, but it's unclear
whether holding MM locks or allocating buffers is better in practice, and the
former is at least consistent with gofer.regularFileFD (and VFS1), making
performance easier to reason about.
PiperOrigin-RevId: 391877913 |
260,001 | 19.08.2021 17:20:21 | 25,200 | 3ba8df92a86aa1044ab59110c640ba413341b9f3 | Cache verity dentries
Add an LRU cache to cache verity dentries when ref count drop to 0. This
way we don't need to hash and verify the previous opened files or
directories each time. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/BUILD",
"new_path": "pkg/sentry/fsimpl/verity/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+load(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\nlicenses([\"notice\"])\n+go_template_instance(\n... | Go | Apache License 2.0 | google/gvisor | Cache verity dentries
Add an LRU cache to cache verity dentries when ref count drop to 0. This
way we don't need to hash and verify the previous opened files or
directories each time.
PiperOrigin-RevId: 391880157 |
259,885 | 20.08.2021 15:11:49 | 25,200 | 154ccbae312f5754b3497e6a296da756952d620c | Remove experimental warning in the VFS2 README. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/README.md",
"new_path": "pkg/sentry/vfs/README.md",
"diff": "# The gVisor Virtual Filesystem\n-THIS PACKAGE IS CURRENTLY EXPERIMENTAL AND NOT READY OR ENABLED FOR PRODUCTION\n-USE. For the filesystem implementation currently used by gVisor, see ... | Go | Apache License 2.0 | google/gvisor | Remove experimental warning in the VFS2 README.
PiperOrigin-RevId: 392078690 |
259,885 | 20.08.2021 17:47:30 | 25,200 | 0a15a216daab9523a5f0c7b93bbceae98dbcbcc1 | Allow gofer.specialFileFDs to be mmapped with a host FD. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/save_restore.go",
"new_path": "pkg/sentry/fsimpl/gofer/save_restore.go",
"diff": "@@ -158,6 +158,10 @@ func (d *dentryPlatformFile) afterLoad() {\n// afterLoad is invoked by stateify.\nfunc (fd *specialFileFD) afterLoad() {\nfd.handle.f... | Go | Apache License 2.0 | google/gvisor | Allow gofer.specialFileFDs to be mmapped with a host FD.
PiperOrigin-RevId: 392102898 |
259,858 | 23.08.2021 10:50:37 | 25,200 | 8dc3be7a61c9d8199c66260cd2d416c8e3e0bc96 | Use --output=starlark trick for all build path parsing.
There is no reason to limit this to debian paths. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -444,7 +444,7 @@ $(RELEASE_ARTIFACTS)/%:\n@mkdir -p $@\n@$(call copy,//runsc:runsc,$@)\n@$(call copy,//shim:containerd-shim-runsc-v1,$@)\n- @$(call deb_copy,//debian:debian,$@)\n+ @$(call copy,//debian:debian,$@)\... | Go | Apache License 2.0 | google/gvisor | Use --output=starlark trick for all build path parsing.
There is no reason to limit this to debian paths.
PiperOrigin-RevId: 392469415 |
259,992 | 24.08.2021 15:23:14 | 25,200 | 19051dd26fe4840cdeb599f6fb393bf72851b4ee | Fix uninitialized messages in MsgqueueTest | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/msgqueue.cc",
"new_path": "test/syscalls/linux/msgqueue.cc",
"diff": "@@ -731,8 +731,9 @@ TEST(MsgqueueTest, MsgCtlIpcStat) {\nabsl::SleepFor(absl::Seconds(1));\nauto pre_send = absl::Now();\n- msgbuf buf;\n- ASSERT_THAT(msgsnd(queue.get(),... | Go | Apache License 2.0 | google/gvisor | Fix uninitialized messages in MsgqueueTest
PiperOrigin-RevId: 392760305 |
260,001 | 25.08.2021 14:35:03 | 25,200 | c1d656c8e447da8b499dbe4ecf85bd7b96a2685e | Remove quotedev device | [
{
"change_type": "DELETE",
"old_path": "pkg/sentry/devices/quotedev/BUILD",
"new_path": null,
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n-\n-licenses([\"notice\"])\n-\n-go_library(\n- name = \"quotedev\",\n- srcs = [\"quotedev.go\"],\n- visibility = [\"//pkg/sentry:internal\"],\n- deps = ... | Go | Apache License 2.0 | google/gvisor | Remove quotedev device
PiperOrigin-RevId: 392982220 |
259,898 | 25.08.2021 16:32:16 | 25,200 | 4c7aaa941eaa05eea99b1b1e7f8e33b42c2bd6a8 | Improve TestTimestampSynCookies
.. by advancing the clock so that NowMonotonic does not return 0. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -8221,6 +8221,11 @@ func TestSendBufferTuning(t *testing.T) {\nfunc TestTimestampSynCookies(t *testing.T) {\nclock := faketime.NewManualClock()\n+ tsNow := fun... | Go | Apache License 2.0 | google/gvisor | Improve TestTimestampSynCookies
.. by advancing the clock so that NowMonotonic does not return 0.
PiperOrigin-RevId: 393005373 |
259,880 | 26.08.2021 17:00:10 | -7,200 | 73ba5943cfdc49ac2cb4638e00b14223ec7ee2b4 | fix tests in pty.cc
fixed and enabled SetForegroundProcessGroup and SetForegroundProcessGroupEmptyProcessGroup. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -1594,9 +1594,9 @@ TEST_F(JobControlTest, GetForegroundProcessGroupNonControlling) {\n// - creates a child process in a new process group\n// - sets that child as the foreground... | Go | Apache License 2.0 | google/gvisor | fix tests in pty.cc
fixed and enabled SetForegroundProcessGroup and SetForegroundProcessGroupEmptyProcessGroup. |
259,898 | 26.08.2021 17:42:15 | 25,200 | 1076702371fa02a36b70a6abf10dbec886742208 | Add Stack.Seed() back
... because it is still used by fuchsia. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1823,6 +1823,13 @@ func (s *Stack) SetNUDConfigurations(id tcpip.NICID, proto tcpip.NetworkProtocol\nreturn nic.setNUDConfigs(proto, c)\n}\n+// Seed returns a 32 bit value that can... | Go | Apache License 2.0 | google/gvisor | Add Stack.Seed() back
... because it is still used by fuchsia.
PiperOrigin-RevId: 393246904 |
260,004 | 27.08.2021 11:12:08 | 25,200 | fbf020d6a0258275a68573032bea225a1f5396ab | Add LinkEndpoint.WriteRawPacket with stubs
...returning unsupported errors. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -290,3 +290,6 @@ func (*Endpoint) ARPHardwareType() header.ARPHardwareType {\n// AddHeader implements stack.LinkEndpoint.AddHeader.\nfunc (*Endpoint) AddHeader(tcp... | Go | Apache License 2.0 | google/gvisor | Add LinkEndpoint.WriteRawPacket with stubs
...returning unsupported errors.
PiperOrigin-RevId: 393388991 |
259,898 | 30.08.2021 10:56:32 | 25,200 | 9625071e6dd6d949f6bd443910eaf56ce1c9762d | Avoid pseudo endpoint for TSVal generation | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/tcpip/internal/tcp/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"tcp\",\n+ srcs = [\"tcp.go\"],\n+ visibility = [\"//pkg/tcpip:__subpackages__\"],\n+ deps = [\... | Go | Apache License 2.0 | google/gvisor | Avoid pseudo endpoint for TSVal generation
PiperOrigin-RevId: 393808461 |
259,885 | 30.08.2021 12:37:33 | 25,200 | 574c6542a538bc2917fc95e443cf0976946db1c0 | Use specialFileFD handles in specialFileFD.Stat(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -995,7 +995,7 @@ func (d *dentry) refreshSizeLocked(ctx context.Context) error {\nif d.writeFD < 0 {\nd.handleMu.RUnlock()\n// Ask the gofer if we don't have a host ... | Go | Apache License 2.0 | google/gvisor | Use specialFileFD handles in specialFileFD.Stat().
PiperOrigin-RevId: 393831108 |
259,885 | 30.08.2021 13:25:31 | 25,200 | a247e227b1f629392d0a9132dc490a6ef9ee2519 | Narrow COW-break on thread stacks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/pma.go",
"new_path": "pkg/sentry/mm/pma.go",
"diff": "@@ -324,20 +324,37 @@ func (mm *MemoryManager) getPMAsInternalLocked(ctx context.Context, vseg vmaIter\npanic(fmt.Sprintf(\"pma %v needs to be copied for writing, but is not readable: %v\", ps... | Go | Apache License 2.0 | google/gvisor | Narrow COW-break on thread stacks.
PiperOrigin-RevId: 393841270 |
259,975 | 30.08.2021 15:32:22 | 25,200 | dfbcb8903ae8bd0d1ff984889f1b5cf1e041865e | [syserr] Fix SIGBUS on syserr.FromError
Fix syzcaller panic SIGBUS on error handling. Done by
adding an interface, errors.GuestError, which errors can
implement in order to be compared against each other. | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/BUILD",
"new_path": "pkg/syserr/BUILD",
"diff": "@@ -14,6 +14,7 @@ go_library(\n\"//pkg/abi/linux/errno\",\n\"//pkg/errors\",\n\"//pkg/errors/linuxerr\",\n+ \"//pkg/safecopy\",\n\"//pkg/tcpip\",\n\"@org_golang_x_sys//unix:go_default_library\",\n],\n... | Go | Apache License 2.0 | google/gvisor | [syserr] Fix SIGBUS on syserr.FromError
Fix syzcaller panic SIGBUS on error handling. Done by
adding an interface, errors.GuestError, which errors can
implement in order to be compared against each other.
PiperOrigin-RevId: 393867554 |
259,885 | 31.08.2021 23:09:45 | 25,200 | c5cc6a65664fed83932596abf2a446a93e357bbe | Remove splice-to/from-weird-files tests.
These tests are permanently broken on Linux after "fs: don't allow
splice read/write without explicit ops". | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/eventfd.cc",
"new_path": "test/syscalls/linux/eventfd.cc",
"diff": "@@ -149,31 +149,6 @@ TEST(EventfdTest, BigWriteBigRead) {\nEXPECT_EQ(l[0], 1);\n}\n-TEST(EventfdTest, SpliceFromPipePartialSucceeds) {\n- int pipes[2];\n- ASSERT_THAT(pipe2... | Go | Apache License 2.0 | google/gvisor | Remove splice-to/from-weird-files tests.
These tests are permanently broken on Linux after 36e2c7421f02 "fs: don't allow
splice read/write without explicit ops".
PiperOrigin-RevId: 394161079 |
259,885 | 01.09.2021 10:27:30 | 25,200 | 810ea0957517bcfc459627aeb10a3594340c895b | Cache cpuid.HostFeatureSet(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/cpuid.go",
"new_path": "pkg/cpuid/cpuid.go",
"diff": "@@ -37,6 +37,14 @@ package cpuid\n// arch/arm64/include/uapi/asm/hwcap.h\ntype Feature int\n+// HostFeatureSet returns a FeatureSet that matches that of the host machine.\n+// Callers must not mut... | Go | Apache License 2.0 | google/gvisor | Cache cpuid.HostFeatureSet().
PiperOrigin-RevId: 394261815 |
259,896 | 01.09.2021 10:43:26 | 25,200 | 5e3a5189152e682f94c745a544993c26e18eb9a2 | gVisor rack blog
A blog about RACK loss detection algorithm implemented in gVisor.
(https://datatracker.ietf.org/doc/rfc8985/) | [
{
"change_type": "MODIFY",
"old_path": "website/_config.yml",
"new_path": "website/_config.yml",
"diff": "@@ -44,3 +44,6 @@ authors:\nmpratt:\nname: Michael Pratt\nemail: mpratt@google.com\n+ nybidari:\n+ name: Nayana Bidari\n+ email: nybidari@google.com\n"
},
{
"change_type": "ADD",
"ol... | Go | Apache License 2.0 | google/gvisor | gVisor rack blog
A blog about RACK loss detection algorithm implemented in gVisor.
(https://datatracker.ietf.org/doc/rfc8985/)
PiperOrigin-RevId: 394265634 |
259,853 | 01.09.2021 11:46:02 | 25,200 | 927ea16dd384f675a2ce1456be457a371109c488 | unix: handle a case when a buffer is overflowed
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/queue.go",
"new_path": "pkg/sentry/socket/unix/transport/queue.go",
"diff": "@@ -133,7 +133,7 @@ func (q *queue) Enqueue(ctx context.Context, data [][]byte, c ControlMessages, f\nfree := q.limit - q.used\nif l > free && truncat... | Go | Apache License 2.0 | google/gvisor | unix: handle a case when a buffer is overflowed
Reported-by: syzbot+1aab6800bd14829609b8@syzkaller.appspotmail.com
PiperOrigin-RevId: 394279838 |
259,885 | 01.09.2021 13:05:27 | 25,200 | 5da4270a884e9f0c88d583da34f757783f314645 | Propagate vfs.MkdirOptions.ForSyntheticMountpoint to overlay copy-up. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"new_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"diff": "@@ -36,6 +36,10 @@ func (d *dentry) isCopiedUp() bool {\n//\n// Preconditions: filesystem.renameMu must be locked.\nfunc (d *dentry) copyUpLocked(ctx context.Co... | Go | Apache License 2.0 | google/gvisor | Propagate vfs.MkdirOptions.ForSyntheticMountpoint to overlay copy-up.
PiperOrigin-RevId: 394296687 |
259,885 | 01.09.2021 13:21:40 | 25,200 | 702fe7d60da4d38344f00200187fe1f0766bef8d | Cache vdso.so's __kernel_rt_sigreturn location. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/loader.go",
"new_path": "pkg/sentry/loader/loader.go",
"diff": "@@ -295,15 +295,7 @@ func Load(ctx context.Context, args LoadArgs, extraAuxv []arch.AuxEntry, vdso *V\nm.SetEnvvEnd(sl.EnvvEnd)\nm.SetAuxv(auxv)\nm.SetExecutable(ctx, file)\n-\n-... | Go | Apache License 2.0 | google/gvisor | Cache vdso.so's __kernel_rt_sigreturn location.
PiperOrigin-RevId: 394300607 |
259,885 | 01.09.2021 14:04:50 | 25,200 | b4de26d6b1bbb0e75187690da6d3fe120f53656b | Don't use reflection in fpu.alignedBytes.
reflect.ValueOf takes an interface{}, so when passed a slice the compiler emits
a call to runtime.convTslice to heap-allocate a copy of the slice header. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/fpu/BUILD",
"new_path": "pkg/sentry/arch/fpu/BUILD",
"diff": "@@ -9,6 +9,7 @@ go_library(\n\"fpu_amd64.go\",\n\"fpu_amd64.s\",\n\"fpu_arm64.go\",\n+ \"fpu_unsafe.go\",\n],\nvisibility = [\"//:sandbox\"],\ndeps = [\n"
},
{
"change_type":... | Go | Apache License 2.0 | google/gvisor | Don't use reflection in fpu.alignedBytes.
reflect.ValueOf takes an interface{}, so when passed a slice the compiler emits
a call to runtime.convTslice to heap-allocate a copy of the slice header.
PiperOrigin-RevId: 394310052 |
260,001 | 01.09.2021 15:48:29 | 25,200 | 5032f4f57d9d46a3dfebb50523907724713e0001 | Add ioctl stub constants | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ioctl.go",
"new_path": "pkg/abi/linux/ioctl.go",
"diff": "@@ -170,3 +170,18 @@ const (\nKCOV_MODE_TRACE_PC = 2\nKCOV_MODE_TRACE_CMP = 3\n)\n+\n+// Attestation ioctls.\n+var (\n+ SIGN_ATTESTATION_REPORT = IOC(_IOC_READ, 's', 1, 65)\n+)\n+\n+// Siz... | Go | Apache License 2.0 | google/gvisor | Add ioctl stub constants
PiperOrigin-RevId: 394331928 |
259,962 | 01.09.2021 17:30:17 | 25,200 | 2d3919532a7531083a5e4db956401ff0e1356a77 | Out-of-order segment should not block in-sequence segments.
For a small receive buffer the first out-of-order segment will get accepted and
fill up the receive buffer today. This change now includes the size of the
out-of-order segment when checking whether to queue the out of order segment or
not. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/rcv.go",
"new_path": "pkg/tcpip/transport/tcp/rcv.go",
"diff": "@@ -477,7 +477,7 @@ func (r *receiver) handleRcvdSegment(s *segment) (drop bool, err tcpip.Error) {\n// segments. This ensures that we always leave some space for the inord... | Go | Apache License 2.0 | google/gvisor | Out-of-order segment should not block in-sequence segments.
For a small receive buffer the first out-of-order segment will get accepted and
fill up the receive buffer today. This change now includes the size of the
out-of-order segment when checking whether to queue the out of order segment or
not.
PiperOrigin-RevId: 394351309 |
259,951 | 07.09.2021 14:05:54 | 25,200 | dfc518005bf9fd6abdc8dc906d7572f6cc2c5a35 | Remove protocolMainLoop unused return value | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -1342,7 +1342,7 @@ func (e *endpoint) protocolMainLoopDone(closeTimer tcpip.Timer) {\n// protocolMainLoop is the main loop of the TCP protocol. It runs in its ow... | Go | Apache License 2.0 | google/gvisor | Remove protocolMainLoop unused return value
PiperOrigin-RevId: 395325998 |
259,902 | 07.09.2021 14:56:27 | 25,200 | 2f2fb3813f59922156258b816ea50d49a70d617c | Conditionally use GetAbsoluteTestTmpdir() rather than hard-code "/tmp"
NewTempAbsPathInDir("/tmp") prevents the generated socket address from
exceeding sizeof(addr.sun_path). However, existing systems that are built with
the ANDROID configuration have their temp directory in a different location.
This change allows those systems to run tests that depend on UniqueUnixAddr. | [
{
"change_type": "MODIFY",
"old_path": "test/util/socket_util.cc",
"new_path": "test/util/socket_util.cc",
"diff": "@@ -57,7 +57,19 @@ Creator<FileDescriptor> SyscallSocketCreator(int domain, int type,\nPosixErrorOr<struct sockaddr_un> UniqueUnixAddr(bool abstract, int domain) {\nstruct sockaddr_un ... | Go | Apache License 2.0 | google/gvisor | Conditionally use GetAbsoluteTestTmpdir() rather than hard-code "/tmp"
NewTempAbsPathInDir("/tmp") prevents the generated socket address from
exceeding sizeof(addr.sun_path). However, existing systems that are built with
the ANDROID configuration have their temp directory in a different location.
This change allows those systems to run tests that depend on UniqueUnixAddr.
PiperOrigin-RevId: 395336483 |
259,985 | 07.09.2021 15:06:55 | 25,200 | e90ecdb48885bcabd0d7b00ff01621e7f92e3614 | Stub some memory control files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/memory.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/memory.go",
"diff": "@@ -32,21 +32,33 @@ type memoryController struct {\ncontrollerCommon\nlimitBytes int64\n+ softLimitBytes int64\n+ moveChargeAtImmigrate int64\n}\nvar _ controll... | Go | Apache License 2.0 | google/gvisor | Stub some memory control files.
PiperOrigin-RevId: 395338926 |
259,962 | 09.09.2021 11:01:29 | 25,200 | 5e9c3a0b934f0dd7513e21372b3fd8593b87525b | Add EthernetHeader only if underlying NIC has a mac address.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/network.go",
"new_path": "runsc/boot/network.go",
"diff": "@@ -210,7 +210,7 @@ func (n *Network) CreateLinksAndRoutes(args *CreateLinksAndRoutesArgs, _ *struct\nlinkEP, err := fdbased.New(&fdbased.Options{\nFDs: FDs,\nMTU: uint32(link.MTU),\n- Ether... | Go | Apache License 2.0 | google/gvisor | Add EthernetHeader only if underlying NIC has a mac address.
Fixes #6532
PiperOrigin-RevId: 395741741 |
259,985 | 09.09.2021 22:54:51 | 25,200 | 7da9bb18c28bdd874e928d85363e1f99cea03b2c | Use accessor for runsc ControlConfig proto. | [
{
"change_type": "MODIFY",
"old_path": "runsc/config/config.go",
"new_path": "runsc/config/config.go",
"diff": "@@ -404,7 +404,7 @@ func (c *controlConfig) Get() interface{} {\n// String implements flag.Value.\nfunc (c *controlConfig) String() string {\nv := \"\"\n- for _, control := range c.Control... | Go | Apache License 2.0 | google/gvisor | Use accessor for runsc ControlConfig proto.
PiperOrigin-RevId: 395859347 |
259,858 | 13.09.2021 10:51:23 | 25,200 | 6bcacb2fd17fadefbc9fb2eed9059eb36ae2783b | Support anonymous structs in checklocks.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -41,17 +41,6 @@ func (l *linkResolver) confirmReachable(addr tcpip.Address) {\nvar _ NetworkInterface = (*nic)(nil)\n-// TODO(https://gvisor.dev/issue/6558): Use an anonymous struct in ... | Go | Apache License 2.0 | google/gvisor | Support anonymous structs in checklocks.
Fixes #6558
PiperOrigin-RevId: 396393293 |
259,881 | 13.09.2021 16:01:07 | 14,400 | 9bdeddd8826f98251584567b4157c63b297b7825 | runsc/cmd: alphabetize runsc debug profiling options
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/debug.go",
"new_path": "runsc/cmd/debug.go",
"diff": "@@ -37,9 +37,9 @@ type Debug struct {\npid int\nstacks bool\nsignal int\n- profileHeap string\n- profileCPU string\nprofileBlock string\n+ profileCPU string\n+ profileHeap string\nprofileMutex str... | Go | Apache License 2.0 | google/gvisor | runsc/cmd: alphabetize runsc debug profiling options
Updates #220 |
260,004 | 13.09.2021 14:40:18 | 25,200 | e07fd058ec474d801748a849d9c5d1c6118c3c11 | Set NICID before delivering packet to raw endpoint
...as raw endpoints expect the packet's NICID to be set. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/BUILD",
"new_path": "pkg/tcpip/network/BUILD",
"diff": "@@ -23,8 +23,10 @@ go_test(\n\"//pkg/tcpip/stack\",\n\"//pkg/tcpip/testutil\",\n\"//pkg/tcpip/transport/icmp\",\n+ \"//pkg/tcpip/transport/raw\",\n\"//pkg/tcpip/transport/tcp\",\n\"//pkg... | Go | Apache License 2.0 | google/gvisor | Set NICID before delivering packet to raw endpoint
...as raw endpoints expect the packet's NICID to be set.
PiperOrigin-RevId: 396446552 |
259,853 | 13.09.2021 15:31:52 | 25,200 | 95fe4fea19f30281a3ff53f62c9fcda533c4e04a | tools/show_paths.bzl: check that provider_map isn't None
Otherwise it can fail:
$ bazel cquery pkg/p9/... --output=starlark --starlark:file=tools/show_paths.bzl
...
ERROR: Starlark evaluation error for //pkg/p9/p9test:mockgen:
Traceback (most recent call last):
File "tools/show_paths.bzl", line 8, column 32, in format
Error: 'NoneType' value has no field or method 'get' | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -169,6 +169,11 @@ steps:\nlabel: \":mechanical_arm: ARM\"\ncommand: make arm-qemu-smoke-test\n+ # Build everything.\n+ - <<: *common\n+ label: \":world_map: Build everything\"\n+ co... | Go | Apache License 2.0 | google/gvisor | tools/show_paths.bzl: check that provider_map isn't None
Otherwise it can fail:
$ bazel cquery pkg/p9/... --output=starlark --starlark:file=tools/show_paths.bzl
...
ERROR: Starlark evaluation error for //pkg/p9/p9test:mockgen:
Traceback (most recent call last):
File "tools/show_paths.bzl", line 8, column 32, in format
Error: 'NoneType' value has no field or method 'get'
PiperOrigin-RevId: 396457764 |
260,004 | 13.09.2021 19:40:40 | 25,200 | 226e7d32cb855e69b3bf7a28791a17235074e49a | Accept packets destined to bound address
...if bound to an address.
We previously checked the source of a packet instead of the destination
of a packet when bound to an address. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -562,8 +562,6 @@ func (e *endpoint) HandlePacket(pkt *stack.PacketBuffer) {\nreturn\n}\n- remoteAddr := pkt.Network().SourceAddress()\n-\nif e.bound {\n// If b... | Go | Apache License 2.0 | google/gvisor | Accept packets destined to bound address
...if bound to an address.
We previously checked the source of a packet instead of the destination
of a packet when bound to an address.
PiperOrigin-RevId: 396497647 |
259,881 | 14.09.2021 16:20:25 | 14,400 | 5ab2bdf332ccedbc3eedc6e5f7c96f6adb2b80d4 | runsc: allow rootless mode for runsc run
Rootless mode seems to work fine for simple containers with runsc run,
so allow its use.
Since runsc run is more widely used, require a workable --network option
is passed rather than automatically switching like runsc do does.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/run.go",
"new_path": "runsc/cmd/run.go",
"diff": "@@ -68,7 +68,14 @@ func (r *Run) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}) s\nwaitStatus := args[1].(*unix.WaitStatus)\nif conf.Rootless {\n- return Errorf(\"Rootless mode not s... | Go | Apache License 2.0 | google/gvisor | runsc: allow rootless mode for runsc run
Rootless mode seems to work fine for simple containers with runsc run,
so allow its use.
Since runsc run is more widely used, require a workable --network option
is passed rather than automatically switching like runsc do does.
Fixes #3036 |
260,004 | 14.09.2021 13:35:21 | 25,200 | 2b46e2d19e642ed8a0a58ea1c62a38b53e7dfb2d | Defer mutex unlocking | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -534,8 +534,11 @@ func (e *endpoint) GetSockOptInt(opt tcpip.SockOptInt) (int, tcpip.Error) {\n// HandlePacket implements stack.RawTransportEndpoint.HandlePack... | Go | Apache License 2.0 | google/gvisor | Defer mutex unlocking
PiperOrigin-RevId: 396670516 |
260,004 | 14.09.2021 14:00:55 | 25,200 | 5593b8a7e6cb5fc04c1b9e23a92b880517330cd4 | Don't use SOL_UDP when creating sockets
SOL_UDP is used when get/set-ing socket options to specify the socket
level. When creating normal UDP sockets, the protocol need not be
specified. When creating RAW IP sockets for UDP, use IPPROTO_UDP. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/raw_socket.cc",
"new_path": "test/syscalls/linux/raw_socket.cc",
"diff": "@@ -950,7 +950,7 @@ void TestRawSocketMaybeBindReceive(bool do_bind) {\n};\nFileDescriptor udp_sock =\n- ASSERT_NO_ERRNO_AND_VALUE(Socket(AF_INET, SOCK_DGRAM, SOL_UDP... | Go | Apache License 2.0 | google/gvisor | Don't use SOL_UDP when creating sockets
SOL_UDP is used when get/set-ing socket options to specify the socket
level. When creating normal UDP sockets, the protocol need not be
specified. When creating RAW IP sockets for UDP, use IPPROTO_UDP.
PiperOrigin-RevId: 396675986 |
260,004 | 14.09.2021 17:17:17 | 25,200 | 39470428dd3c5fef966cee138ae00ab8b9059983 | Use a shared method to get loopback index
Code to get the loopback interface's index is scattered throughout the
syscall tests. Implement the code once and use that in tests (where
applicable).
While I am here, trim the dependencies/includes for network namespace
tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1446,6 +1446,7 @@ cc_binary(\ndefines = select_system(),\nlinkstatic = 1,\ndeps = [\n+ \":ip_socket_test_util\",\n\":unix_domain_socket_test_util\",\n\"//test/util:capability_uti... | Go | Apache License 2.0 | google/gvisor | Use a shared method to get loopback index
Code to get the loopback interface's index is scattered throughout the
syscall tests. Implement the code once and use that in tests (where
applicable).
While I am here, trim the dependencies/includes for network namespace
tests.
PiperOrigin-RevId: 396718124 |
260,004 | 15.09.2021 12:18:00 | 25,200 | 149ca009678edc580de9f0b1d54f551d376742cb | [bind] Return EINVAL for under sized address
...and EAFNOSUPPORT for unexpected address family.
To comply with Linux.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -419,6 +419,27 @@ func bytesToIPAddress(addr []byte) tcpip.Address {\nreturn tcpip.Address(addr)\n}\n+// minSockAddrLen returns the minimum length in byt... | Go | Apache License 2.0 | google/gvisor | [bind] Return EINVAL for under sized address
...and EAFNOSUPPORT for unexpected address family.
To comply with Linux.
Updates #6021, #6575.
PiperOrigin-RevId: 396893590 |
260,004 | 15.09.2021 23:48:05 | 25,200 | 477d7e5e10378e2f80f21ac9f536d12c4b94d7ce | Annotate checklocks on mutex protected fields
...to catch lock-related bugs in nogo tests.
Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/internal/network/endpoint.go",
"new_path": "pkg/tcpip/transport/internal/network/endpoint.go",
"diff": "@@ -18,7 +18,6 @@ package network\nimport (\n\"fmt\"\n- \"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/sync\"\n\"gvisor.dev/gvisor/pkg/tcpip\"... | Go | Apache License 2.0 | google/gvisor | Annotate checklocks on mutex protected fields
...to catch lock-related bugs in nogo tests.
Also update the endpoint's state field to be accessed while the mutex is
held instead of requiring atomic operations as nothing needs to call the
State method while the mutex is held.
Updates #6566.
PiperOrigin-RevId: 397010316 |
260,004 | 16.09.2021 11:50:51 | 25,200 | 282a4dd52b337dccfb578e9d32dd1005c864dd8d | Don't allow binding to broadcast on ICMP sockets
...to match Linux behaviour.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/icmp/endpoint.go",
"new_path": "pkg/tcpip/transport/icmp/endpoint.go",
"diff": "@@ -688,9 +688,20 @@ func (e *endpoint) bindLocked(addr tcpip.FullAddress) tcpip.Error {\nreturn nil\n}\n+func (e *endpoint) isBroadcastOrMulticast(nicID tcpip.... | Go | Apache License 2.0 | google/gvisor | Don't allow binding to broadcast on ICMP sockets
...to match Linux behaviour.
Fixes #5711.
PiperOrigin-RevId: 397132671 |
260,004 | 16.09.2021 19:50:00 | 25,200 | 85bd3dd9b119cbc5a68b778a18ae73d3567ff610 | Annotate checklocks on mutex protected fields
...to catch lock-related bugs in nogo tests.
Checklocks also pointed out a locking violation which is fixed
in this change.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/transport_demuxer.go",
"new_path": "pkg/tcpip/stack/transport_demuxer.go",
"diff": "@@ -32,11 +32,13 @@ type protocolIDs struct {\n// transportEndpoints manages all endpoints of a given protocol. It has its own\n// mutex so as to reduce interfe... | Go | Apache License 2.0 | google/gvisor | Annotate checklocks on mutex protected fields
...to catch lock-related bugs in nogo tests.
Checklocks also pointed out a locking violation which is fixed
in this change.
Updates #6566.
PiperOrigin-RevId: 397225322 |
260,004 | 16.09.2021 20:04:00 | 25,200 | b28bd31bb6d920c23b5036d94bc7123143369e24 | Allow creating packet socket bound to any protocol
...even protocols the stack is unaware of.
While I am here, annotate checklocks on stack.packetEndpointList. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -97,6 +97,8 @@ type packetEndpointList struct {\nmu sync.RWMutex\n// eps is protected by mu, but the contained PacketEndpoint values are not.\n+ //\n+ // +checklocks:mu\neps []PacketEnd... | Go | Apache License 2.0 | google/gvisor | Allow creating packet socket bound to any protocol
...even protocols the stack is unaware of.
While I am here, annotate checklocks on stack.packetEndpointList.
PiperOrigin-RevId: 397226754 |
259,927 | 18.09.2021 05:57:28 | 25,200 | 09477db2bc0535c93a09442c6b5216497b3bc7db | Avoid ambient clock on ICMP Rate Limiter | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/icmp_rate_limit.go",
"new_path": "pkg/tcpip/stack/icmp_rate_limit.go",
"diff": "@@ -16,6 +16,7 @@ package stack\nimport (\n\"golang.org/x/time/rate\"\n+ \"gvisor.dev/gvisor/pkg/tcpip\"\n)\nconst (\n@@ -31,11 +32,41 @@ const (\n// ICMPRateLimite... | Go | Apache License 2.0 | google/gvisor | Avoid ambient clock on ICMP Rate Limiter
PiperOrigin-RevId: 397496920 |
260,004 | 19.09.2021 13:13:29 | 25,200 | 89a0011c100d778cd8a0cc5e1b14996461c66629 | Support IPV6_RECVPKTINFO on UDP sockets | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/socket.go",
"new_path": "pkg/abi/linux/socket.go",
"diff": "@@ -542,6 +542,15 @@ type ControlMessageIPPacketInfo struct {\nDestinationAddr InetAddr\n}\n+// ControlMessageIPv6PacketInfo represents struct in6_pktinfo from linux/ipv6.h.\n+//\n+// +m... | Go | Apache License 2.0 | google/gvisor | Support IPV6_RECVPKTINFO on UDP sockets
PiperOrigin-RevId: 397631833 |
260,004 | 20.09.2021 12:14:29 | 25,200 | 5951ec5bce17e7696d2fd53ce384839555dd3c79 | Do not allow unbinding network protocol
Once a packet socket is bound to a network protocol, it cannot be
unbound from that protocol; the network protocol binding may only be
updated to a different network protocol.
To comply with Linux. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/packet/endpoint.go",
"new_path": "pkg/tcpip/transport/packet/endpoint.go",
"diff": "@@ -82,11 +82,9 @@ type endpoint struct {\nmu sync.RWMutex `state:\"nosave\"`\n// +checklocks:mu\n- netProto tcpip.NetworkProtocolNumber\n- // +checklocks:m... | Go | Apache License 2.0 | google/gvisor | Do not allow unbinding network protocol
Once a packet socket is bound to a network protocol, it cannot be
unbound from that protocol; the network protocol binding may only be
updated to a different network protocol.
To comply with Linux.
PiperOrigin-RevId: 397810878 |
260,004 | 20.09.2021 19:35:51 | 25,200 | 3fe8d7ecf193b4efd099ceabe2d39a119ffe4fbc | Support getsockname for packet sockets
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/packet/endpoint.go",
"new_path": "pkg/tcpip/transport/packet/endpoint.go",
"diff": "@@ -318,8 +318,14 @@ func (ep *endpoint) Bind(addr tcpip.FullAddress) tcpip.Error {\n}\n// GetLocalAddress implements tcpip.Endpoint.GetLocalAddress.\n-func... | Go | Apache License 2.0 | google/gvisor | Support getsockname for packet sockets
Updates #6621
PiperOrigin-RevId: 397898852 |
259,853 | 21.09.2021 15:37:08 | 25,200 | c485602ded3982f8fd1078e34a4b298879f1807e | socket/unix: clean up socket queue after releasing a queue lock
A socket queue can contain sockets (others and this one). We have to avoid
taking locks of the same class where it is possible. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/queue.go",
"new_path": "pkg/sentry/socket/unix/transport/queue.go",
"diff": "@@ -59,12 +59,14 @@ func (q *queue) Close() {\n// q.WriterQueue.Notify(waiter.WritableEvents)\nfunc (q *queue) Reset(ctx context.Context) {\nq.mu.Lock... | Go | Apache License 2.0 | google/gvisor | socket/unix: clean up socket queue after releasing a queue lock
A socket queue can contain sockets (others and this one). We have to avoid
taking locks of the same class where it is possible.
PiperOrigin-RevId: 398100744 |
259,951 | 21.09.2021 17:27:27 | 25,200 | 0ed53e5e92a065f63864ecfd0dd6d93c12daaef5 | Handle Shutdown on connecting tcp socket
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -30,6 +30,10 @@ import (\n\"gvisor.dev/gvisor/pkg/waiter\"\n)\n+// InitialRTO is the initial retransmission timeout.\n+// https://github.com/torvalds/linux/blob/... | Go | Apache License 2.0 | google/gvisor | Handle Shutdown on connecting tcp socket
Fixes #6495
PiperOrigin-RevId: 398121921 |
259,992 | 22.09.2021 11:29:38 | 25,200 | cc095a6e4c26c6a818e92a7d1f5d2b59c2a2e163 | Remove terminal usage from `runsc spec`
Most usages of `runsc spec`+`runsc run` do not expect stdios to be a terminal.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/spec.go",
"new_path": "runsc/cmd/spec.go",
"diff": "@@ -30,7 +30,6 @@ func writeSpec(w io.Writer, cwd string, netns string, args []string) error {\nspec := &specs.Spec{\nVersion: \"1.0.0\",\nProcess: &specs.Process{\n- Terminal: true,\nUser: specs.Us... | Go | Apache License 2.0 | google/gvisor | Remove terminal usage from `runsc spec`
Most usages of `runsc spec`+`runsc run` do not expect stdios to be a terminal.
Updates #6619
PiperOrigin-RevId: 398288237 |
259,853 | 16.09.2021 22:52:17 | 0 | c1a726e8c5b751ab71500302d5700a9472c5cbd5 | kvm: fix tests on arm64 | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/testutil/testutil_arm64.go",
"new_path": "pkg/sentry/platform/kvm/testutil/testutil_arm64.go",
"diff": "@@ -30,8 +30,8 @@ import (\nfunc TLSWorks() bool\n// SetTestTarget sets the rip appropriately.\n-func SetTestTarget(regs *arch.Regis... | Go | Apache License 2.0 | google/gvisor | kvm: fix tests on arm64 |
259,946 | 22.09.2021 14:56:26 | 25,200 | 4f67756752002dc72bb64cdecd1fa17746f8217f | Change EcdsaVerify to specifically P-384 and compute the SHA384 digest. | [
{
"change_type": "MODIFY",
"old_path": "pkg/crypto/crypto_stdlib.go",
"new_path": "pkg/crypto/crypto_stdlib.go",
"diff": "@@ -19,14 +19,21 @@ package crypto\nimport (\n\"crypto/ecdsa\"\n+ \"crypto/elliptic\"\n\"crypto/sha512\"\n+ \"fmt\"\n\"math/big\"\n)\n-// EcdsaVerify verifies the signature in r,... | Go | Apache License 2.0 | google/gvisor | Change EcdsaVerify to specifically P-384 and compute the SHA384 digest.
PiperOrigin-RevId: 398336708 |
259,868 | 22.09.2021 17:12:57 | 25,200 | 6b7f58b2ac084088c8ef37ce041262be710404b1 | Add `NewCondition` helper in `bigquery.go`. | [
{
"change_type": "MODIFY",
"old_path": "tools/bigquery/bigquery.go",
"new_path": "tools/bigquery/bigquery.go",
"diff": "@@ -107,10 +107,7 @@ func (bm *Benchmark) AddMetric(metricName, unit string, sample float64) {\n// AddCondition adds a condition to an existing Benchmark.\nfunc (bm *Benchmark) Add... | Go | Apache License 2.0 | google/gvisor | Add `NewCondition` helper in `bigquery.go`.
PiperOrigin-RevId: 398366805 |
259,868 | 22.09.2021 17:47:45 | 25,200 | 440fc07f70203caf517c5cbc3dcc3e83b7de3f05 | Make benchmark `String()` output prettier. | [
{
"change_type": "MODIFY",
"old_path": "tools/bigquery/bigquery.go",
"new_path": "tools/bigquery/bigquery.go",
"diff": "@@ -40,29 +40,45 @@ type Suite struct {\n}\nfunc (s *Suite) String() string {\n- conditions := make([]string, 0, len(s.Conditions))\n- for _, c := range s.Conditions {\n- condition... | Go | Apache License 2.0 | google/gvisor | Make benchmark `String()` output prettier.
PiperOrigin-RevId: 398372542 |
260,004 | 22.09.2021 17:52:43 | 25,200 | d8772545113ff941d34a4eae5f43df3f39d3547f | Track UDP connections
This will enable NAT to be performed on UDP packets that are sent
in response to packets sent by the stack.
This will also enable ICMP errors to be properly NAT-ed in response
to UDP packets
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -160,7 +160,13 @@ func (cn *conn) timedOut(now time.Time) bool {\n// update the connection tracking state.\n//\n// Precondition: cn.mu must be held.\n-func (cn *conn) update... | Go | Apache License 2.0 | google/gvisor | Track UDP connections
This will enable NAT to be performed on UDP packets that are sent
in response to packets sent by the stack.
This will also enable ICMP errors to be properly NAT-ed in response
to UDP packets (#5916).
Updates #5915.
PiperOrigin-RevId: 398373251 |
259,885 | 22.09.2021 18:09:49 | 25,200 | de750eb1d3ef2c8c60274c62c4463392b29b45c7 | Add Execve and ExitNotifyParent checkpoints.
Call sites for the two checkpoints aren't added yet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/BUILD",
"new_path": "pkg/sentry/seccheck/BUILD",
"diff": "@@ -8,6 +8,8 @@ go_fieldenum(\nname = \"seccheck_fieldenum\",\nsrcs = [\n\"clone.go\",\n+ \"execve.go\",\n+ \"exit.go\",\n\"task.go\",\n],\nout = \"seccheck_fieldenum.go\",\n@@ -29,6... | Go | Apache License 2.0 | google/gvisor | Add Execve and ExitNotifyParent checkpoints.
Call sites for the two checkpoints aren't added yet.
PiperOrigin-RevId: 398375903 |
260,004 | 23.09.2021 11:37:51 | 25,200 | d480289adb9bd3421dd6275ff480f5e5743e326b | Introduce method per iptables hook
...to make it clear what arguments are needed per hook. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -426,7 +426,7 @@ func (e *endpoint) WritePacket(r *stack.Route, params stack.NetworkHeaderParams,\n// iptables filtering. All packets that reach here are locally\n// gen... | Go | Apache License 2.0 | google/gvisor | Introduce method per iptables hook
...to make it clear what arguments are needed per hook.
PiperOrigin-RevId: 398538776 |
260,004 | 23.09.2021 11:42:24 | 25,200 | 2e4f26ac5ed206e981f662326e19d60b5f05bd4c | Compose ICMP endpoint with datagram-based endpoint
An ICMP endpoint's write path can use the datagram-based endpoint.
Updates
Test: Datagram-based generic socket + ICMP/ping syscall tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/icmp/BUILD",
"new_path": "pkg/tcpip/transport/icmp/BUILD",
"diff": "@@ -33,6 +33,8 @@ go_library(\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/ports\",\n\"//pkg/tcpip/stack\",\n+ \"//pkg/tcpip/transport\",\n+ \"//pkg/tcpip/transport/internal/net... | Go | Apache License 2.0 | google/gvisor | Compose ICMP endpoint with datagram-based endpoint
An ICMP endpoint's write path can use the datagram-based endpoint.
Updates #6565.
Test: Datagram-based generic socket + ICMP/ping syscall tests.
PiperOrigin-RevId: 398539844 |
260,004 | 23.09.2021 13:09:30 | 25,200 | 8627db006bda75fd81d17bf4535b381abafaed8a | Pass AddressableEndpoint to IPTables
...instead of an address.
This allows a later change to more precisely select an address
based on the NAT type (source vs. destination NAT). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/targets.go",
"new_path": "pkg/sentry/socket/netfilter/targets.go",
"diff": "@@ -647,7 +647,7 @@ func (jt *JumpTarget) id() targetID {\n}\n// Action implements stack.Target.Action.\n-func (jt *JumpTarget) Action(*stack.PacketBuffer, ... | Go | Apache License 2.0 | google/gvisor | Pass AddressableEndpoint to IPTables
...instead of an address.
This allows a later change to more precisely select an address
based on the NAT type (source vs. destination NAT).
PiperOrigin-RevId: 398559901 |
259,907 | 23.09.2021 23:31:17 | 25,200 | 12175748aba75c0b3be5b3981763c1a1f5e73763 | Allow lisafs client to send more data than MaxMessageSize using chunks.
The p9 client does the same. This allows applications to read/write >= 2MB of
data. This enables the read write benchmarks to work with lisafs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/client_file.go",
"new_path": "pkg/lisafs/client_file.go",
"diff": "package lisafs\nimport (\n+ \"fmt\"\n+\n\"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/context\"\n@@ -121,34 +123,84 @@ func (f *ClientFD) Sy... | Go | Apache License 2.0 | google/gvisor | Allow lisafs client to send more data than MaxMessageSize using chunks.
The p9 client does the same. This allows applications to read/write >= 2MB of
data. This enables the read write benchmarks to work with lisafs.
Updates #5466
PiperOrigin-RevId: 398659947 |
259,853 | 24.09.2021 11:22:56 | 25,200 | e3657847cb7edcecc3facc4c499fc0b154364487 | Update the comment for Task.netns
Task.netns can be accessed atomically, so Task.mu isn't needed to access it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -511,8 +511,6 @@ type Task struct {\nnumaNodeMask uint64\n// netns is the task's network namespace. netns is never nil.\n- //\n- // netns is protected by mu.\nnetns inet.Namespace... | Go | Apache License 2.0 | google/gvisor | Update the comment for Task.netns
Task.netns can be accessed atomically, so Task.mu isn't needed to access it.
PiperOrigin-RevId: 398773947 |
259,929 | 27.09.2021 10:13:22 | 14,400 | b5ae22f201854698acfb64266bba662de5c5b12b | Minor documentation wording change | [
{
"change_type": "MODIFY",
"old_path": "g3doc/README.md",
"new_path": "g3doc/README.md",
"diff": "@@ -139,8 +139,8 @@ pipes, etc) are sent to the Gofer, described below.\nThe Gofer is a standard host process which is started with each container and\ncommunicates with the Sentry via the [9P protocol]... | Go | Apache License 2.0 | google/gvisor | Minor documentation wording change |
259,868 | 27.09.2021 15:28:45 | 25,200 | e251f6cc5c2641e000846b35e4aa7f0d41c4b319 | Move `sighandling` package out of `sentry`. | [
{
"change_type": "RENAME",
"old_path": "pkg/sentry/sighandling/BUILD",
"new_path": "pkg/sighandling/BUILD",
"diff": "@@ -8,7 +8,7 @@ go_library(\n\"sighandling.go\",\n\"sighandling_unsafe.go\",\n],\n- visibility = [\"//pkg/sentry:internal\"],\n+ visibility = [\"//:sandbox\"],\ndeps = [\n\"//pkg/abi/... | Go | Apache License 2.0 | google/gvisor | Move `sighandling` package out of `sentry`.
PiperOrigin-RevId: 399295737 |
259,868 | 28.09.2021 16:53:22 | 25,200 | 65698b627e81d0b078a5f993260f6359e22e7970 | Move `safecopy.ReplaceSignalHandler` into `sighandling` package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/safecopy/BUILD",
"new_path": "pkg/safecopy/BUILD",
"diff": "@@ -18,9 +18,9 @@ go_library(\n],\nvisibility = [\"//:sandbox\"],\ndeps = [\n- \"//pkg/abi/linux\",\n\"//pkg/errors\",\n\"//pkg/errors/linuxerr\",\n+ \"//pkg/sighandling\",\n\"@org_golang_x_sys//u... | Go | Apache License 2.0 | google/gvisor | Move `safecopy.ReplaceSignalHandler` into `sighandling` package.
PiperOrigin-RevId: 399560357 |
259,881 | 30.09.2021 08:43:12 | 25,200 | b4d4f4bd861c98feb0e28d637ef701b9f7f1840e | Add timer_create and timer_settime to filters
Go 1.18 (as of golang.org/cl/324129) uses per-thread timers created and set
with timer_create/timer_settime for more accurate CPU pprof profiling.
Add these syscalls to the allowed syscall filters. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -304,6 +304,22 @@ var allowedSyscalls = seccomp.SyscallRules{\nseccomp.EqualTo(unix.SPLICE_F_NONBLOCK), /* flags */\n},\n},\n+ unix.SYS_TIMER_CREATE: []seccomp.Rule{\n+ {\n+ s... | Go | Apache License 2.0 | google/gvisor | Add timer_create and timer_settime to filters
Go 1.18 (as of golang.org/cl/324129) uses per-thread timers created and set
with timer_create/timer_settime for more accurate CPU pprof profiling.
Add these syscalls to the allowed syscall filters.
PiperOrigin-RevId: 399941561 |
259,881 | 30.09.2021 14:45:28 | 25,200 | c122663548b9bf4bc46843cc662ea8d7e96e7676 | Skip analysis of standard library packages using generics
The upstream analysis packages we depend on do not yet support analysis of code
using Go 1.18 type parameter features, making analysis of the Go tip standard
library choke and crash. Skip these packages for now. | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/nogo.go",
"new_path": "tools/nogo/nogo.go",
"diff": "@@ -293,6 +293,19 @@ func CheckStdlib(config *StdlibConfig, analyzers []*analysis.Analyzer) (allFindi\nbreak\n}\n+ // Go standard library packages using Go 1.18 type parameter features.\n+ //\n+ /... | Go | Apache License 2.0 | google/gvisor | Skip analysis of standard library packages using generics
The upstream analysis packages we depend on do not yet support analysis of code
using Go 1.18 type parameter features, making analysis of the Go tip standard
library choke and crash. Skip these packages for now.
PiperOrigin-RevId: 400030256 |
259,992 | 01.10.2021 09:20:14 | 25,200 | 94623ccf513ed21ec67e1fcb6800ee1250fe27b2 | Use root context to mount volumes
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/vfs.go",
"new_path": "runsc/boot/vfs.go",
"diff": "@@ -173,7 +173,7 @@ func (c *containerMounter) mountAll(conf *config.Config, procArgs *kernel.Create\nrootProcArgs.Credentials = rootCreds\nrootProcArgs.Umask = 0022\nrootProcArgs.MaxSymlinkTraversa... | Go | Apache License 2.0 | google/gvisor | Use root context to mount volumes
Fixes #6643
PiperOrigin-RevId: 400218778 |
260,004 | 01.10.2021 11:02:02 | 25,200 | 8073370009aeccaffa7885ab073e630f644fafe6 | Let connection handle tracked packets
...to save a call to `ConnTrack.connFor` when callers already have a
reference to the ConnTrack entry. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -388,30 +388,35 @@ func (ct *ConnTrack) insertConn(conn *conn) {\n// connection exists. Returns whether, after the packet traverses the tables,\n// it should create a new en... | Go | Apache License 2.0 | google/gvisor | Let connection handle tracked packets
...to save a call to `ConnTrack.connFor` when callers already have a
reference to the ConnTrack entry.
PiperOrigin-RevId: 400244955 |
260,004 | 01.10.2021 11:47:11 | 25,200 | 788bbc2904983417efe430cc5c66b3af990d3bfe | Drop IPTables.checkPackets
...and have `CheckOutputPackets`, `CheckPostroutingPackets` call their
equivalent methods that operate on a single packet buffer directly.
This is so that the `Check{Output, Postrouting}Packets` methods may
leverage any hook-specific work that `Check{Output, Postrouting}`
may perform.
Note: Later changes will add hook-specific logic to the
`Check{Output, Postrouting}` methods. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -431,7 +431,9 @@ func (it *IPTables) startReaper(interval time.Duration) {\n//\n// Precondition: The packets' network and transport header must be set.\nfunc (it *IPTables) Ch... | Go | Apache License 2.0 | google/gvisor | Drop IPTables.checkPackets
...and have `CheckOutputPackets`, `CheckPostroutingPackets` call their
equivalent methods that operate on a single packet buffer directly.
This is so that the `Check{Output, Postrouting}Packets` methods may
leverage any hook-specific work that `Check{Output, Postrouting}`
may perform.
Note: Later changes will add hook-specific logic to the
`Check{Output, Postrouting}` methods.
PiperOrigin-RevId: 400255651 |
260,004 | 01.10.2021 12:33:13 | 25,200 | 8603cce51d6d930aed128fff873591520dcb0853 | Annotate checklocks on mutex protected fields
...to catch lock-related bugs in nogo tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -117,15 +117,18 @@ type conn struct {\n// update the state of tcb. It is immutable.\ntcbHook Hook\n- // mu protects all mutable state.\nmu sync.Mutex `state:\"nosave\"`\n// ... | Go | Apache License 2.0 | google/gvisor | Annotate checklocks on mutex protected fields
...to catch lock-related bugs in nogo tests.
Updates #6566.
PiperOrigin-RevId: 400265818 |
260,004 | 01.10.2021 13:35:04 | 25,200 | 6e83c4b751c60652247d0ebbe559261352b2131f | Drop conn.tcbHook
...as the packet's direction gives us the information that tcbHook is
used to derive. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -113,10 +113,6 @@ type conn struct {\n// TODO(gvisor.dev/issue/5696): Support updating manipulation type.\nmanip manipType\n- // tcbHook indicates if the packet is inbound o... | Go | Apache License 2.0 | google/gvisor | Drop conn.tcbHook
...as the packet's direction gives us the information that tcbHook is
used to derive.
PiperOrigin-RevId: 400280102 |
260,004 | 01.10.2021 14:56:29 | 25,200 | 51c4fbb840b98380b4016bac030f0adbd5725d70 | Drop ConnTrack.handlePacket
Move the hook specific logic to the IPTables hook functions.
This lets us avoid having to perform checks on the hook to determine
what action to take.
Later changes will drop the need for handlePacket's return value,
reducing the value of this function that all hooks call into. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -403,29 +403,6 @@ func insertConn(tupleBkt *bucket, replyBkt *bucket, conn *conn) {\n}\n}\n-// handlePacket will manipulate the port and address of the packet if the\n-// co... | Go | Apache License 2.0 | google/gvisor | Drop ConnTrack.handlePacket
Move the hook specific logic to the IPTables hook functions.
This lets us avoid having to perform checks on the hook to determine
what action to take.
Later changes will drop the need for handlePacket's return value,
reducing the value of this function that all hooks call into.
PiperOrigin-RevId: 400298023 |
260,004 | 01.10.2021 17:00:24 | 25,200 | 3bab5e56677942c19d0777a1d6aee38a25a05bbb | Read lock when getting connections
We should avoid taking the write lock to avoid contention when looking
for a packet's tracked connection.
No need to reap timed out connections when looking for connections
as the reaper (which runs periodically) will handle that. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -113,7 +113,7 @@ type conn struct {\n// TODO(gvisor.dev/issue/5696): Support updating manipulation type.\nmanip manipType\n- mu sync.Mutex `state:\"nosave\"`\n+ mu sync.RWMu... | Go | Apache License 2.0 | google/gvisor | Read lock when getting connections
We should avoid taking the write lock to avoid contention when looking
for a packet's tracked connection.
No need to reap timed out connections when looking for connections
as the reaper (which runs periodically) will handle that.
PiperOrigin-RevId: 400322514 |
259,951 | 04.10.2021 09:50:18 | 25,200 | 429821b0a91091db71509276855e5919d4d90a49 | Test listener receiving an invalid ACK while the accept queue is full
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/tests/tcp_listen_backlog_test.go",
"new_path": "test/packetimpact/tests/tcp_listen_backlog_test.go",
"diff": "@@ -144,13 +144,33 @@ func TestTCPListenBacklog(t *testing.T) {\n}\n}\n+ // While the accept queue is still full, send an unexpected... | Go | Apache License 2.0 | google/gvisor | Test listener receiving an invalid ACK while the accept queue is full
Updates #6683
PiperOrigin-RevId: 400745768 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.