author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,858 | 03.02.2022 22:24:31 | 28,800 | dce4528a1a95e172c69eefb76cffe0736c2730d9 | Clean documentation and add go vet support for checklocks.
This makes it easier to iterate with checklocks. This pattern will be
duplicated with more complex analyzers.
Updates | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -118,6 +118,7 @@ go_path(\n\"//runsc/cli\",\n\"//shim/cli\",\n\"//webhook/pkg/cli\",\n+ \"//tools/checklocks\",\n# Packages that are not dependencies of the above.\n\"//pkg/sentry/kernel/memevent\",\n"
},
{
"cha... | Go | Apache License 2.0 | google/gvisor | Clean documentation and add go vet support for checklocks.
This makes it easier to iterate with checklocks. This pattern will be
duplicated with more complex analyzers.
Updates #7038
PiperOrigin-RevId: 426317618 |
259,978 | 04.02.2022 10:26:35 | 28,800 | 518535de9b0e27cb13ac22b1bf8e6d2a8104d8a4 | Expose address deprecation on Stack
Add a method for setting an address to be deprecated/preferred to
AddressableEndpoint, so that addresses added from outside the stack
can be deprecated/renewed respectively, e.g. by a DHCPv6 client. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -1053,6 +1053,13 @@ func (e *endpoint) RemovePermanentAddress(addr tcpip.Address) tcpip.Error {\nreturn e.addressableEndpointState.RemovePermanentAddress(addr)\n}\n+// S... | Go | Apache License 2.0 | google/gvisor | Expose address deprecation on Stack
Add a method for setting an address to be deprecated/preferred to
AddressableEndpoint, so that addresses added from outside the stack
can be deprecated/renewed respectively, e.g. by a DHCPv6 client.
PiperOrigin-RevId: 426435598 |
259,868 | 04.02.2022 14:08:51 | 28,800 | e219f75d8b3c28d4d41f8b232b9879391688ceb2 | Fuse: Cache `maxActiveRequests` in `connection` to avoid reading it from `fs`.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/connection.go",
"new_path": "pkg/sentry/fsimpl/fuse/connection.go",
"diff": "@@ -148,6 +148,11 @@ type connection struct {\n// Negotiated in FUSE_INIT.\nmaxPages uint16\n+ // maxActiveRequests specifies the maximum number of active reque... | Go | Apache License 2.0 | google/gvisor | Fuse: Cache `maxActiveRequests` in `connection` to avoid reading it from `fs`.
Reported-by: syzbot+6a1f1b6e126622f61c0e@syzkaller.appspotmail.com
PiperOrigin-RevId: 426488251 |
259,858 | 04.02.2022 14:42:08 | 28,800 | 1ebb4fd3670e1e093bcadc9fc2fa1e6837b532e3 | Fix build configurations.
This standardizes some build configurations and simplifies the structure
of packages intended to avoid fighting with automated formatting tools.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/platforms/BUILD",
"new_path": "runsc/boot/platforms/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\", \"select_system\")\n+# The go_library rule is imported as a different name in this case,\n+# in order to avoid automated tooling doing t... | Go | Apache License 2.0 | google/gvisor | Fix build configurations.
This standardizes some build configurations and simplifies the structure
of packages intended to avoid fighting with automated formatting tools.
Updates #6938
PiperOrigin-RevId: 426495825 |
259,858 | 04.02.2022 22:38:53 | 28,800 | 6c2d9a2359e30c2c5316bc21903f07f52c122872 | Allow disabling nogo stdlib facts.
Rebuilding the set of standard library facts can be time consuming. Allow this
to be disabled for faster iteration. This is done by provided a build setting
which can be toggled directly, for example:
bazel build --//tools/nogo:fast ... | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/defs.bzl",
"new_path": "tools/bazeldefs/defs.bzl",
"diff": "load(\"@bazel_skylib//rules:build_test.bzl\", _build_test = \"build_test\")\nload(\"@bazel_skylib//:bzl_library.bzl\", _bzl_library = \"bzl_library\")\n+load(\"@bazel_skylib//rules:com... | Go | Apache License 2.0 | google/gvisor | Allow disabling nogo stdlib facts.
Rebuilding the set of standard library facts can be time consuming. Allow this
to be disabled for faster iteration. This is done by provided a build setting
which can be toggled directly, for example:
bazel build --//tools/nogo:fast ...
PiperOrigin-RevId: 426562548 |
259,853 | 08.02.2022 17:24:47 | 28,800 | a15231dabe4702f166529f5e360358562caeeebc | kvm: fix CPU offsets for arm64
We have to calculate offsets in the CPU structure,
but we calculate offsets in the CPUArchState structure.
Fixes: ("Refactor nogo and provide facts render.") | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/entry_arm64.s",
"new_path": "pkg/ring0/entry_arm64.s",
"diff": "#include \"funcdata.h\"\n#include \"textflag.h\"\n-{{ with .CPU }}\n-#define CPU_SELF {{ .self.Offset }}\n-#define CPU_REGISTERS {{ .registers.Offset }}\n-{{ end }}\n-{{ with .CPUArchSta... | Go | Apache License 2.0 | google/gvisor | kvm: fix CPU offsets for arm64
We have to calculate offsets in the CPU structure,
but we calculate offsets in the CPUArchState structure.
Fixes: 0e492a2b5e6d ("Refactor nogo and provide facts render.")
PiperOrigin-RevId: 427336023 |
259,853 | 09.02.2022 16:26:39 | 28,800 | cd8ba85c624d3e10b63685b4ea841525c501179c | kvm/arm64: exclude PROT_NONE mappings from the read-only list
Go-runtime uses PROT_NONE mappings as place holders for future read-write
mappings.
Accese mode has to be a property of physicalRegion. It makes code cleaner. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/address_space.go",
"new_path": "pkg/sentry/platform/kvm/address_space.go",
"diff": "@@ -123,7 +123,7 @@ func (as *addressSpace) mapLocked(addr hostarch.Addr, m hostMapEntry, at hostarc\n// not have physical mappings, the KVM module may ... | Go | Apache License 2.0 | google/gvisor | kvm/arm64: exclude PROT_NONE mappings from the read-only list
Go-runtime uses PROT_NONE mappings as place holders for future read-write
mappings.
Accese mode has to be a property of physicalRegion. It makes code cleaner.
Signed-off-by: Andrei Vagin <avagin@google.com> |
259,992 | 09.02.2022 17:29:31 | 28,800 | 974c0c2c9a108e2e90bf80b5acd4e3136bb1e97d | Allow safe flags to be set from annotations
runsc flags can be set through annotations only when `--allow-flag-override`
is set. However, certain flags can be safely set and should not require
an admin to set the override flag. | [
{
"change_type": "MODIFY",
"old_path": "runsc/config/config.go",
"new_path": "runsc/config/config.go",
"diff": "@@ -31,9 +31,11 @@ import (\n// Follow these steps to add a new flag:\n// 1. Create a new field in Config.\n// 2. Add a field tag with the flag name\n-// 3. Register a new flag in flags.go... | Go | Apache License 2.0 | google/gvisor | Allow safe flags to be set from annotations
runsc flags can be set through annotations only when `--allow-flag-override`
is set. However, certain flags can be safely set and should not require
an admin to set the override flag.
PiperOrigin-RevId: 427613132 |
259,962 | 09.02.2022 22:58:41 | 28,800 | 5a52fcc5466a7da26994ac168d56ee5e9cd21ae9 | Fix buffer aliasing issue when Merging views. | [
{
"change_type": "MODIFY",
"old_path": "pkg/buffer/view.go",
"new_path": "pkg/buffer/view.go",
"diff": "@@ -385,6 +385,10 @@ func (v *View) Clone() View {\nsize: v.size,\n}\nfor buf := v.data.Front(); buf != nil; buf = buf.Next() {\n+ // Copy the buffer structs itself as they are stateful and\n+ // ... | Go | Apache License 2.0 | google/gvisor | Fix buffer aliasing issue when Merging views.
PiperOrigin-RevId: 427662565 |
259,907 | 11.02.2022 11:12:48 | 28,800 | 697d3d52eb9494cee096eeb5d831c9767e02d15e | Fix walking to attach path logic in lisafs.
The attach path (if one exists) is always absolute. This is checked while
setting that option. strings.Split(aname, "/") creates an extra empty string in
the beginning of the slice. Exclude that while making Walk RPC. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -541,9 +541,9 @@ func (fs *filesystem) initClientLisa(ctx context.Context) (lisafs.Inode, error)\nreturn rootInode, nil\n}\n- // Walk to the attach point from root i... | Go | Apache License 2.0 | google/gvisor | Fix walking to attach path logic in lisafs.
The attach path (if one exists) is always absolute. This is checked while
setting that option. strings.Split(aname, "/") creates an extra empty string in
the beginning of the slice. Exclude that while making Walk RPC.
PiperOrigin-RevId: 428046171 |
259,885 | 11.02.2022 11:43:37 | 28,800 | da30d5dd1c3d2366bdc9a094d3ea1dd9b6f48774 | Avoid lock recursion when gofer revalidation invalidates a mount point. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/revalidate.go",
"new_path": "pkg/sentry/fsimpl/gofer/revalidate.go",
"diff": "@@ -291,10 +291,18 @@ func (fs *filesystem) revalidateHelper(ctx context.Context, vfsObj *vfs.VirtualF\nreturn nil\n}\n// The file at this path has changed or... | Go | Apache License 2.0 | google/gvisor | Avoid lock recursion when gofer revalidation invalidates a mount point.
PiperOrigin-RevId: 428053753 |
260,004 | 11.02.2022 11:55:38 | 28,800 | 029554dc3ca1360c91252648f9ef8c0fe24cc2a9 | Support SO_BINDTODEVICE on raw endpoints | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -160,6 +160,11 @@ func newEndpoint(s *stack.Stack, netProto tcpip.NetworkProtocolNumber, transProt\nreturn e, nil\n}\n+// HasNIC implements tcpip.SocketOptions... | Go | Apache License 2.0 | google/gvisor | Support SO_BINDTODEVICE on raw endpoints
PiperOrigin-RevId: 428056402 |
259,907 | 12.02.2022 16:14:28 | 28,800 | 0255d313a4c825c62634ee41d73a4eef060872d7 | Remove VFS1 continuous runtime tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -214,33 +214,6 @@ steps:\ncommand: make python3.7.3-runtime-tests_vfs2\nparallelism: 20\n- # Runtime tests (VFS1).\n- - <<: *common\n- label: \":php: PHP runtime tests (VFS1)\"\n- c... | Go | Apache License 2.0 | google/gvisor | Remove VFS1 continuous runtime tests.
Updates #1624
PiperOrigin-RevId: 428255277 |
259,951 | 14.02.2022 13:49:24 | 28,800 | 4a94302bafb8cb3f95e740a13c37659e80cf04bf | Support receiving PKTINFO on icmp endpoints | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "@@ -600,6 +600,16 @@ func Parse(t *kernel.Task, socketOrEndpoint interface{}, buf []byte, width uint)\ntclass.UnmarshalUnsafe(buf)\ncmsgs.IP.TClass = uint32(tcl... | Go | Apache License 2.0 | google/gvisor | Support receiving PKTINFO on icmp endpoints
PiperOrigin-RevId: 428599075 |
259,962 | 15.02.2022 18:26:42 | 28,800 | 0917380792ac17eeb27784104bc46704ce7bc126 | Clear pending packet queue when nic is removed.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -316,9 +316,13 @@ func (n *nic) remove() tcpip.Error {\nep.Close()\n}\n+ // drain and drop any packets pending link resolution.\n+ n.linkResQueue.cancel()\n+\n// Prevent packets from go... | Go | Apache License 2.0 | google/gvisor | Clear pending packet queue when nic is removed.
Updates #6910
PiperOrigin-RevId: 428925334 |
259,962 | 15.02.2022 20:50:46 | 28,800 | ae089adbb223bc1600321ac0563c6fd4c26db97c | Add Leak checking to ipv4 tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/fragmentation/fragmentation.go",
"new_path": "pkg/tcpip/network/internal/fragmentation/fragmentation.go",
"diff": "@@ -19,9 +19,9 @@ package fragmentation\nimport (\n\"errors\"\n\"fmt\"\n- \"log\"\n\"time\"\n+ \"gvisor.dev/gvisor/pkg... | Go | Apache License 2.0 | google/gvisor | Add Leak checking to ipv4 tests.
PiperOrigin-RevId: 428946053 |
259,907 | 16.02.2022 00:40:31 | 28,800 | 12a9efa29cd4adb79fc38ce03f7fef25ca655692 | Do not attempt to clear release dentries if fs.root is nil.
When initializing the fs.client and fs.root fails, the filesystem is released.
The release implementation panics when leak checking is enabled (in tests)
because it lacks nil-checks for fs.root. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -697,8 +697,9 @@ func (fs *filesystem) Release(ctx context.Context) {\n// If leak checking is enabled, release all outstanding references in the\n// filesystem. We d... | Go | Apache License 2.0 | google/gvisor | Do not attempt to clear release dentries if fs.root is nil.
When initializing the fs.client and fs.root fails, the filesystem is released.
The release implementation panics when leak checking is enabled (in tests)
because it lacks nil-checks for fs.root.
PiperOrigin-RevId: 428976387 |
259,907 | 16.02.2022 10:39:41 | 28,800 | ca697cfd2a7a66714dca372de2d5d2a3b8e99f10 | Do not generate VFS1 tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -151,33 +151,28 @@ syscall_test(\nsize = \"large\",\ndebug = False,\ntest = \"//test/perf/linux:verity_open_benchmark\",\n- vfs1 = False,\n)\nsyscall_test(\nsize = \"large\",\ndebug = False,\ntest = ... | Go | Apache License 2.0 | google/gvisor | Do not generate VFS1 tests.
Updates #1624
PiperOrigin-RevId: 429085588 |
259,885 | 16.02.2022 12:45:12 | 28,800 | 03d7c4895153dbe446447643ceacccc74d12997f | Don't copy up event registrations in VFS2 overlay.
Doing so can deadlock, and regular files and symlinks usually shouldn't be
event-registerable anyway (especially after cl/426516504). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/regular_file.go",
"new_path": "pkg/sentry/fsimpl/overlay/regular_file.go",
"diff": "@@ -60,10 +60,6 @@ type regularFileFD struct {\ncopiedUp bool\ncachedFD *vfs.FileDescription\ncachedFlags uint32\n-\n- // If copiedUp is false, lowerW... | Go | Apache License 2.0 | google/gvisor | Don't copy up event registrations in VFS2 overlay.
Doing so can deadlock, and regular files and symlinks usually shouldn't be
event-registerable anyway (especially after cl/426516504).
PiperOrigin-RevId: 429117155 |
259,962 | 16.02.2022 13:33:28 | 28,800 | 55aa2b2b230025dc666c73cb7916a6fad36dd4da | Enable leak checking for network tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/BUILD",
"new_path": "pkg/tcpip/network/BUILD",
"diff": "@@ -7,9 +7,12 @@ go_test(\nsize = \"small\",\nsrcs = [\n\"ip_test.go\",\n+ \"main_test.go\",\n\"multicast_group_test.go\",\n],\ndeps = [\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pk... | Go | Apache License 2.0 | google/gvisor | Enable leak checking for network tests.
Updates #6910
PiperOrigin-RevId: 429127828 |
259,868 | 16.02.2022 14:17:35 | 28,800 | d8500d0467d3d4cede2034f0f38389608b81a5ce | gVisor KVM: Use the KVM device path that was actually opened in error message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm.go",
"new_path": "pkg/sentry/platform/kvm/kvm.go",
"diff": "@@ -84,7 +84,7 @@ func OpenDevice() (*os.File, error) {\n}\nf, err := os.OpenFile(dev, unix.O_RDWR, 0)\nif err != nil {\n- return nil, fmt.Errorf(\"error opening /dev/kvm: ... | Go | Apache License 2.0 | google/gvisor | gVisor KVM: Use the KVM device path that was actually opened in error message.
PiperOrigin-RevId: 429138394 |
259,898 | 16.02.2022 15:07:11 | 28,800 | d96b1860ba05238d0f5196e5e8611ea5bdb137c5 | Add a PacketImpact test for Ack behavior in SYN-RCVD
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -307,6 +307,10 @@ ALL_TESTS = [\nname = \"generic_dgram_socket_send_recv\",\ntimeout = \"long\",\n),\n+ PacketimpactTestInfo(\n+ name = \"tcp_acceptable_ack_syn_rc... | Go | Apache License 2.0 | google/gvisor | Add a PacketImpact test for Ack behavior in SYN-RCVD
Updates #7199.
PiperOrigin-RevId: 429150157 |
259,885 | 16.02.2022 17:21:14 | 28,800 | 44644d9c19499b9e32bedbf5ddca223e8f18002f | Save/restore floating point state in amd64 signal frames. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch.go",
"new_path": "pkg/sentry/arch/arch.go",
"diff": "@@ -148,7 +148,9 @@ type Context interface {\n// stack is not going to be used).\n//\n// sigset is the signal mask before entering the signal handler.\n- SignalSetup(st *Stack, act *linu... | Go | Apache License 2.0 | google/gvisor | Save/restore floating point state in amd64 signal frames.
PiperOrigin-RevId: 429178859 |
259,992 | 16.02.2022 17:45:24 | 28,800 | 0b86ae090e00b788cec15a6819c8c925cb67102a | Add tests for containerd v1.6.0-rc.4 | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -175,6 +175,14 @@ steps:\ncommand: make containerd-test-1.5.4\nagents:\nqueue: \"cgroupv2\"\n+ - <<: *common\n+ label: \":docker: Containerd 1.6.0-rc.4 tests\"\n+ command: make cont... | Go | Apache License 2.0 | google/gvisor | Add tests for containerd v1.6.0-rc.4
PiperOrigin-RevId: 429182915 |
259,992 | 16.02.2022 17:49:02 | 28,800 | 81ea55d8fc96150f8a79e8d54ade92f579fbe385 | Misc changes
Make a few nit changes to cgroups
Better OOM watcher debug logging | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/oom_v2.go",
"new_path": "pkg/shim/oom_v2.go",
"diff": "@@ -65,15 +65,17 @@ func (w *watcherV2) run(ctx context.Context) {\nreturn\ncase i := <-w.itemCh:\nif i.err != nil {\n+ logrus.WithError(i.err).Debugf(\"Error listening for OOM, id: %q\", i.id)\nd... | Go | Apache License 2.0 | google/gvisor | Misc changes
Make a few nit changes to cgroups
Better OOM watcher debug logging
PiperOrigin-RevId: 429183470 |
259,992 | 16.02.2022 17:49:15 | 28,800 | 9b93c12a1395a4c291a51f6b9cf8d909852d8753 | Implement CreateRuntime hook
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -329,7 +329,28 @@ func New(conf *config.Config, args Args) (*Container, error) {\nreturn nil, err\n}\n- // Write the PID file. Containerd considers the create complete after... | Go | Apache License 2.0 | google/gvisor | Implement CreateRuntime hook
Closes #7149
PiperOrigin-RevId: 429183505 |
259,907 | 16.02.2022 19:25:35 | 28,800 | ab3728508f021757c0ebe2a1285b0c74d220d74c | Add syscall test for rename when an writable FD exists and file perms changed.
The gofer server should not attempt to re-open the writable FD on server on
rename. runsc/fsgofer works as expected. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -2148,6 +2148,7 @@ cc_binary(\n\"//test/util:fs_util\",\n\"@com_google_absl//absl/strings\",\ngtest,\n+ \"//test/util:save_util\",\n\"//test/util:temp_path\",\n\"//test/util:test_... | Go | Apache License 2.0 | google/gvisor | Add syscall test for rename when an writable FD exists and file perms changed.
The gofer server should not attempt to re-open the writable FD on server on
rename. runsc/fsgofer works as expected.
PiperOrigin-RevId: 429197853 |
259,962 | 17.02.2022 09:14:16 | 28,800 | 2822b56f303a59c43620f650c247b227e241ea00 | Add Leak checking to arp tests.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/BUILD",
"new_path": "pkg/tcpip/network/arp/BUILD",
"diff": "@@ -26,6 +26,8 @@ go_test(\nsrcs = [\"arp_test.go\"],\ndeps = [\n\":arp\",\n+ \"//pkg/refs\",\n+ \"//pkg/refsvfs2\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/fak... | Go | Apache License 2.0 | google/gvisor | Add Leak checking to arp tests.
Updates #6910
PiperOrigin-RevId: 429325291 |
259,853 | 18.02.2022 01:45:58 | 28,800 | f51097051ac5707065e262dacb6d9f8f05ff55fb | tun: reject packets larger MTU
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/tundev/tundev.go",
"new_path": "pkg/sentry/devices/tundev/tundev.go",
"diff": "@@ -143,6 +143,13 @@ func (fd *tunFD) Write(ctx context.Context, src usermem.IOSequence, opts vfs.Wri\nif src.NumBytes() == 0 {\nreturn 0, unix.EINVAL\n}\n+ mtu, ... | Go | Apache License 2.0 | google/gvisor | tun: reject packets larger MTU
Reported-by: syzbot+d82dbadde2cbe70eb6dd@syzkaller.appspotmail.com
PiperOrigin-RevId: 429508995 |
259,985 | 18.02.2022 14:15:07 | 28,800 | 155ac7c193a036a2d1f3fc1bf1846ad01c77f31c | cgroupfs: Push controller state to inodes.
This is necessary for subcontainers since each cgroup needs to carry
independent state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -45,6 +45,11 @@ func (c *controllerCommon) init(ty kernel.CgroupControllerType, fs *filesystem)\nc.fs = fs\n}\n+func (c *controllerCommon) cloneFrom(other *contr... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Push controller state to inodes.
This is necessary for subcontainers since each cgroup needs to carry
independent state.
PiperOrigin-RevId: 429646074 |
260,004 | 18.02.2022 16:29:17 | 28,800 | ec0db35a80230f4347b8de95e5d342ce3cbdf090 | Test all ones UDP checksum is valid
...after observing the all ones checksum in an outgoing packet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/udp_test.go",
"new_path": "pkg/tcpip/transport/udp/udp_test.go",
"diff": "@@ -2049,7 +2049,15 @@ func TestChecksumWithZeroValueOnesComplementSum(t *testing.T) {\nt.Fatal(\"Packet wasn't written out\")\n}\n+ v := stack.PayloadSince(pkt.N... | Go | Apache License 2.0 | google/gvisor | Test all ones UDP checksum is valid
...after observing the all ones checksum in an outgoing packet.
PiperOrigin-RevId: 429671893 |
259,907 | 18.02.2022 21:03:18 | 28,800 | e4f093f7b1739b0872774057932704613343db77 | Fix lisafs client bugs for S/R support.
There was a bug in checking for the availability of STATX_SIZE on restore.
Make the gofer client resilient to bad open(flags). Like 9P, make lisafs
default to O_RDONLY when a valid open mode is not available. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/handle.go",
"new_path": "pkg/sentry/fsimpl/gofer/handle.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/lisafs\"\n+ \"gvisor.dev/gvisor/pkg/log\"\n\"gvisor.... | Go | Apache License 2.0 | google/gvisor | Fix lisafs client bugs for S/R support.
- There was a bug in checking for the availability of STATX_SIZE on restore.
- Make the gofer client resilient to bad open(flags). Like 9P, make lisafs
default to O_RDONLY when a valid open mode is not available.
PiperOrigin-RevId: 429705352 |
259,885 | 22.02.2022 12:22:01 | 28,800 | 377cfd813d4c36fed538274136b85f06fe364613 | Add sync.SeqCount.BeginWriteOk. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/seqcount.go",
"new_path": "pkg/sync/seqcount.go",
"diff": "@@ -117,7 +117,17 @@ func (s *SeqCount) BeginWrite() {\n}\n}\n-// EndWrite ends the effect of a preceding BeginWrite.\n+// BeginWriteOk combines the semantics of ReadOk and BeginWrite. If the ... | Go | Apache License 2.0 | google/gvisor | Add sync.SeqCount.BeginWriteOk.
PiperOrigin-RevId: 430268914 |
259,951 | 22.02.2022 16:16:33 | 28,800 | 9d5239e7147d4385064a06ed159ae709c2006deb | Rename ControlMessages type to indicate the cmsg direction
With the introduction of sendable control messages, the original cmsg type
is now renamed to ReceivableControlMessages. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -2897,7 +2897,7 @@ func (s *socketOpsCommon) nonBlockingRead(ctx context.Context, dst usermem.IOSeq\nreturn res.Count, 0, nil, 0, cmsg, syserr.TranslateN... | Go | Apache License 2.0 | google/gvisor | Rename ControlMessages type to indicate the cmsg direction
With the introduction of sendable control messages, the original cmsg type
is now renamed to ReceivableControlMessages.
PiperOrigin-RevId: 430319598 |
259,907 | 22.02.2022 17:05:47 | 28,800 | 395c38be75d1757d3eff9241602eec73d658b40c | Add ECONNABORTED to the partial result error list.
Allow application to receive partial result due to ECONNABORTED. Similar to
how ECONNRESET and ETIMEDOUT are handled.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/error.go",
"new_path": "pkg/sentry/syscalls/linux/error.go",
"diff": "@@ -156,9 +156,12 @@ func handleIOErrorImpl(ctx context.Context, partialResult bool, errOrig, intr er\nreturn true, nil\ncase linuxerr.Equals(linuxerr.ECONNRESET, t... | Go | Apache License 2.0 | google/gvisor | Add ECONNABORTED to the partial result error list.
Allow application to receive partial result due to ECONNABORTED. Similar to
how ECONNRESET and ETIMEDOUT are handled.
Reported-by: syzbot+a0029790ed0bda86356e@syzkaller.appspotmail.com
PiperOrigin-RevId: 430328305 |
259,898 | 23.02.2022 00:41:50 | 28,800 | 45835a60fd09e083cdd39058ab30ca3d5a6bac47 | Fix the RST response to unacceptable ACK in SYN-RCVD
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -214,12 +214,11 @@ func (h *handshake) resetToSynRcvd(iss seqnum.Value, irs seqnum.Value, opts head\n// response.\nfunc (h *handshake) checkAck(s *segment) bool ... | Go | Apache License 2.0 | google/gvisor | Fix the RST response to unacceptable ACK in SYN-RCVD
Fixes #7199.
PiperOrigin-RevId: 430388697 |
259,951 | 23.02.2022 15:38:20 | 28,800 | 21dffa8f4c8a6d9c744f3629782eab26890d7187 | Support sending TTL and HopLimit | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/control/control.go",
"new_path": "pkg/sentry/socket/control/control.go",
"diff": "package control\nimport (\n+ \"math\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -522,6 +523,10 @@ func CmsgsSpace(t *kernel.Task, cmsgs socket.ControlM... | Go | Apache License 2.0 | google/gvisor | Support sending TTL and HopLimit
PiperOrigin-RevId: 430554985 |
259,909 | 24.02.2022 11:27:11 | 28,800 | 28688eb1a5ab1531eedf7561bc072b3376923dfb | Support cgroup Install() through systemd.
This change implements Install() though systemd and adds associated tests.
The properties saved by the systemdCgroup object will be applied during
Join(), which will be added in a later change. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/BUILD",
"new_path": "runsc/cgroup/BUILD",
"diff": "@@ -7,12 +7,15 @@ go_library(\nsrcs = [\n\"cgroup.go\",\n\"cgroup_v2.go\",\n+ \"systemd.go\",\n],\nvisibility = [\"//:sandbox\"],\ndeps = [\n\"//pkg/cleanup\",\n\"//pkg/log\",\n\"@com_github_cenka... | Go | Apache License 2.0 | google/gvisor | Support cgroup Install() through systemd.
This change implements Install() though systemd and adds associated tests.
The properties saved by the systemdCgroup object will be applied during
Join(), which will be added in a later change.
PiperOrigin-RevId: 430751223 |
259,885 | 24.02.2022 12:26:32 | 28,800 | 6ca818990a7778c9a6e63f53a489f9f8d51ac3b2 | Ensure that open(O_RDWR) doesn't copy-up on read-only VFS2 overlay mounts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -797,6 +797,10 @@ func (fs *filesystem) OpenAt(ctx context.Context, rp *vfs.ResolvingPath, opts vf\nreturn nil, linuxerr.EEXIST\n}\nif start.isRegularF... | Go | Apache License 2.0 | google/gvisor | Ensure that open(O_RDWR) doesn't copy-up on read-only VFS2 overlay mounts.
PiperOrigin-RevId: 430765773 |
259,909 | 24.02.2022 15:55:07 | 28,800 | 510cc2f7fca91b42cf3ed4813631233e478b566a | Fix pivot_root lock inversion.
PivotRoot takes vfs.mountMu then calls PrependPath which calls fs.mu.
RmdirAt() takes fs.mu and then calls PrepareDeleteDentry which takes
vfs.mountMu. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -727,9 +727,8 @@ func (vfs *VirtualFilesystem) PivotRoot(ctx context.Context, creds *auth.Credent\nrootVd := RootFromContext(ctx)\ndefer rootVd.DecRef(ctx)\n- vfs.mountMu.Lock()\n- de... | Go | Apache License 2.0 | google/gvisor | Fix pivot_root lock inversion.
PivotRoot takes vfs.mountMu then calls PrependPath which calls fs.mu.
RmdirAt() takes fs.mu and then calls PrepareDeleteDentry which takes
vfs.mountMu.
PiperOrigin-RevId: 430813050 |
259,962 | 25.02.2022 11:08:46 | 28,800 | f461bb7b64b6cc3bc606a92256651c9a431bc765 | Fix MTU advertised by sharedmem to exclude header size. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/sharedmem.go",
"new_path": "pkg/tcpip/link/sharedmem/sharedmem.go",
"diff": "@@ -298,7 +298,7 @@ func (e *endpoint) IsAttached() bool {\n// MTU implements stack.LinkEndpoint.MTU. It returns the value initialized\n// during construction... | Go | Apache License 2.0 | google/gvisor | Fix MTU advertised by sharedmem to exclude header size.
PiperOrigin-RevId: 430986440 |
259,907 | 25.02.2022 12:36:11 | 28,800 | 7e8f4c3b3fb8ed2fd42df95880ac68b9fb406052 | Do not generate native variants for verity benchmarks. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -149,30 +149,35 @@ syscall_test(\nsyscall_test(\nsize = \"large\",\n+ allow_native = False,\ndebug = False,\ntest = \"//test/perf/linux:verity_open_benchmark\",\n)\nsyscall_test(\nsize = \"large\",\n... | Go | Apache License 2.0 | google/gvisor | Do not generate native variants for verity benchmarks.
PiperOrigin-RevId: 431006942 |
260,004 | 25.02.2022 18:03:08 | 28,800 | 65d8057067bbf8cdf03a98c9522c6010fc0eeec3 | Return previous config when setting NIC forwarding
...so that callers can determine if forwarding changed as a consequence
of their call. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -190,23 +190,24 @@ func (e *endpoint) Forwarding() bool {\n// setForwarding sets the forwarding status for the endpoint.\n//\n-// Returns true if the forwarding status w... | Go | Apache License 2.0 | google/gvisor | Return previous config when setting NIC forwarding
...so that callers can determine if forwarding changed as a consequence
of their call.
PiperOrigin-RevId: 431069840 |
259,868 | 25.02.2022 18:27:15 | 28,800 | 488841f73ae16a2a1e9224ac402aa6a0b183a92d | Replace use of undocumented `GVISOR_KVM_DEV` environment variable with flags.
This allows overriding the path used to access the kernel's KVM device file,
typically at `/dev/kvm`, with a flag-controlled path instead. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"new_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"diff": "@@ -45,6 +45,7 @@ import (\nvar (\nplatformFlag = flag.String(\"platform\", \"ptrace\", \"specify which platform to use\")\n+ platformDevicePathFlag = flag.Stri... | Go | Apache License 2.0 | google/gvisor | Replace use of undocumented `GVISOR_KVM_DEV` environment variable with flags.
This allows overriding the path used to access the kernel's KVM device file,
typically at `/dev/kvm`, with a flag-controlled path instead.
PiperOrigin-RevId: 431073099 |
259,924 | 25.02.2022 21:48:16 | 28,800 | 7f3fdc910f3722b6ca9ca54c77c5703a7b81c4d8 | Implement core tagging
Links to some possibly useful reference material on core tagging:
* LWN article:
* Kernel docs: | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -88,8 +88,8 @@ go_repository(\ngo_repository(\nname = \"org_golang_x_sys\",\nimportpath = \"golang.org/x/sys\",\n- sum = \"h1:oN6lz7iLW/YC7un8pq+9bOLyXrprv2+DKfkJY+2LJJw=\",\n- version = \"v0.0.0-20211007075335-... | Go | Apache License 2.0 | google/gvisor | Implement core tagging
Links to some possibly useful reference material on core tagging:
* LWN article: https://lwn.net/Articles/861251/
* Kernel docs: https://www.kernel.org/doc/Documentation/admin-guide/hw-vuln/core-scheduling.rst
PiperOrigin-RevId: 431093418 |
259,975 | 28.02.2022 09:37:43 | 28,800 | 5240904367dfc7a634cd7a140fb4898ca58ed419 | Fix issue with parsing flags in root_test. | [
{
"change_type": "MODIFY",
"old_path": "test/root/main_test.go",
"new_path": "test/root/main_test.go",
"diff": "@@ -31,7 +31,9 @@ import (\n// path for runsc.\nfunc TestMain(m *testing.M) {\nconfig.RegisterFlags(flag.CommandLine)\n+ if !flag.CommandLine.Parsed() {\nflag.Parse()\n+ }\nif !specutils.H... | Go | Apache License 2.0 | google/gvisor | Fix issue with parsing flags in root_test.
PiperOrigin-RevId: 431455723 |
259,858 | 28.02.2022 14:56:09 | 28,800 | 711770642a96af6525c059dca4f7269d946a5fb4 | Add release commands to BuildKite. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "+# Clear any downloaded credentials.\n+rm -f repo.key\n+\n# Upload all relevant test failures.\nmake -s testlogs 2>/dev/null | grep // | sort | uniq | (\ndeclare log_count=0\... | Go | Apache License 2.0 | google/gvisor | Add release commands to BuildKite.
PiperOrigin-RevId: 431532954 |
259,858 | 28.02.2022 17:43:47 | 28,800 | d79504d2723621ab1e35903ac17c346d4a5e19ac | Fix mirror typo in emoji and gcloud error. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -42,11 +42,8 @@ sudo rm -rf /tmp/profile\n# Download credentials, if a release agent.\nif test \"${BUILDKITE_AGENT_META_DATA_QUEUE}\" = \"release\"; then\n- # Update gcloud ... | Go | Apache License 2.0 | google/gvisor | Fix mirror typo in emoji and gcloud error.
PiperOrigin-RevId: 431566908 |
259,992 | 01.03.2022 18:57:15 | 28,800 | c6bb9ceb66d88d2dc83e9fd1157b1f8aa328ce8a | Remove VFS2 test dimension
The default is VFS2 enabled, so the tests setting VFS2 are redundant.
Updates | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -205,23 +205,23 @@ steps:\n# Runtime tests.\n- <<: *common\nlabel: \":php: PHP runtime tests\"\n- command: make php7.3.6-runtime-tests_vfs2\n+ command: make php7.3.6-runtime-tests\n... | Go | Apache License 2.0 | google/gvisor | Remove VFS2 test dimension
The default is VFS2 enabled, so the tests setting VFS2 are redundant.
Updates #1624
PiperOrigin-RevId: 431827013 |
259,858 | 01.03.2022 23:32:28 | 28,800 | 5cfaa79a1a20b68941babf87f44889d8d7b65a68 | Fix gcloud secret access.
The secret access command apparently returns JSON (why!??) and the
payload is base64 encoded. Decode per the example provided in the
documentation [1].
[1] | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -43,7 +43,7 @@ sudo rm -rf /tmp/profile\n# Download credentials, if a release agent.\nif test \"${BUILDKITE_AGENT_META_DATA_QUEUE}\" = \"release\"; then\n# Pull down secrets... | Go | Apache License 2.0 | google/gvisor | Fix gcloud secret access.
The secret access command apparently returns JSON (why!??) and the
payload is base64 encoded. Decode per the example provided in the
documentation [1].
[1] https://cloud.google.com/sdk/gcloud/reference/secrets/versions/access
PiperOrigin-RevId: 431862918 |
259,992 | 02.03.2022 11:52:23 | 28,800 | 25c65171055e267d00df10a36ede442fa2e3f003 | Drop support for containerd 1.3
Update containerd versions used in test to the latest of each
minor version. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -315,22 +315,18 @@ else\nendif\n@$(call sudo,test/root:root_test,--runtime=$(RUNTIME) -test.v)\n-ifeq ($(CGROUPV2),false)\n-containerd-tests-min: containerd-test-1.3.9\n-else\n-containerd-tests-min: containerd-tes... | Go | Apache License 2.0 | google/gvisor | Drop support for containerd 1.3
Update containerd versions used in test to the latest of each
minor version.
PiperOrigin-RevId: 431993047 |
259,858 | 02.03.2022 12:48:20 | 28,800 | 137468a8ebc7312755a09a2251935cf8cd577160 | Make release pipeline architecture-independent. | [
{
"change_type": "MODIFY",
"old_path": ".bazelrc",
"new_path": ".bazelrc",
"diff": "@@ -21,7 +21,12 @@ build --cxxopt=-std=c++17\n# Display the current git revision in the info block.\nbuild --stamp --workspace_status_command tools/workspace_status.sh\n+# Set flags for x86_64.\n+build:x86_64 --cross... | Go | Apache License 2.0 | google/gvisor | Make release pipeline architecture-independent.
PiperOrigin-RevId: 432006218 |
259,858 | 02.03.2022 13:04:04 | 28,800 | 6d66109a530277cb3e4864522b6401ac6b68bfa3 | Fix repository.
Some versions of gpg don't select the key as the default after import,
and it must be specified explicitly. Select the last imported key. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -84,6 +84,12 @@ trap cleanup EXIT\ngpg \"${gpg_opts[@]}\" --import \"${private_key}\" || \\\ngpg \"${gpg_opts[@]}\" --import \"${private_key}\"\n+# Select the private key version. For some versio... | Go | Apache License 2.0 | google/gvisor | Fix repository.
Some versions of gpg don't select the key as the default after import,
and it must be specified explicitly. Select the last imported key.
PiperOrigin-RevId: 432009606 |
259,858 | 02.03.2022 17:23:35 | 28,800 | 17b93a84fae9c92cbc7c0dbb3748eb80484e3b1e | Attempt to fix gpg package signing (redux).
The semantics for gpg seem to vary in subtle way across systems. This
attempts to identify the key fingerprint on import, since listing the
secret keys afterwards does not appear to have the intended effect. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -81,13 +81,14 @@ trap cleanup EXIT\n# is not found. This isn't actually a failure for us, because we don't require\n# the public key (this may be stored separately). The second import will succee... | Go | Apache License 2.0 | google/gvisor | Attempt to fix gpg package signing (redux).
The semantics for gpg seem to vary in subtle way across systems. This
attempts to identify the key fingerprint on import, since listing the
secret keys afterwards does not appear to have the intended effect.
PiperOrigin-RevId: 432067329 |
259,977 | 03.03.2022 12:52:35 | 28,800 | 15898a341f036322aa7f66027fd285066a1278d8 | Move erroneously placed comment in UDP endpoint | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -922,7 +922,7 @@ func (e *endpoint) HandlePacket(id stack.TransportEndpointID, pkt *stack.PacketB\ne.stats.PacketsReceived.Increment()\ne.rcvMu.Lock()\n- // Dr... | Go | Apache License 2.0 | google/gvisor | Move erroneously placed comment in UDP endpoint
PiperOrigin-RevId: 432261816 |
259,858 | 03.03.2022 20:21:50 | 28,800 | c8b0aadfa9c3698b595dbcfc1e259af21e32dc8f | Force apt to not bring up an ncurses menu. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "function install_pkgs() {\nexport DEBIAN_FRONTEND=noninteractive\nwhile true; do\n- if sudo -E apt-get update && sudo -E apt-get install -y \"$@\"; then\n+ if sudo -E apt-get u... | Go | Apache License 2.0 | google/gvisor | Force apt to not bring up an ncurses menu.
PiperOrigin-RevId: 432347975 |
259,885 | 04.03.2022 11:40:40 | 28,800 | 0b81a0d7b2304d23ba60ba9453d8468d63dc16a2 | Don't panic in overlay.filesystem.UnlinkAt unless necessary. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -1215,8 +1215,8 @@ func (fs *filesystem) RenameAt(ctx context.Context, rp *vfs.ResolvingPath, oldPa\nStart: replaced.upperVD,\nPath: fspath.Parse(white... | Go | Apache License 2.0 | google/gvisor | Don't panic in overlay.filesystem.UnlinkAt unless necessary.
PiperOrigin-RevId: 432496516 |
259,907 | 05.03.2022 11:14:41 | 28,800 | e3f424c5c51c2d8c6a91624326cf55c372391516 | Set DEBIAN_FRONTEND to be noninteractive for containerd installing.
This was causing annoying timeout issues on BuildKite where the cgroupsv2
agents that are on ubuntu-2110 image to get stuck indefinitely.
Also rollback the experimental changes in pre-command hook to simplify scripts
and make things consistent. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -4,13 +4,7 @@ function install_pkgs() {\nexport DEBIAN_FRONTEND=noninteractive\nwhile true; do\nif sudo -E apt-get update && \\\n- sudo -E apt-get install -y \\\n- -o Dpkg::... | Go | Apache License 2.0 | google/gvisor | Set DEBIAN_FRONTEND to be noninteractive for containerd installing.
This was causing annoying timeout issues on BuildKite where the cgroupsv2
agents that are on ubuntu-2110 image to get stuck indefinitely.
Also rollback the experimental changes in pre-command hook to simplify scripts
and make things consistent.
PiperOrigin-RevId: 432671125 |
259,885 | 07.03.2022 10:40:14 | 28,800 | 81d384cfe9d38e940e73ad7dad3a8e4de5f06086 | Fix race between epoll readiness check and re-readying. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/epoll/epoll.go",
"new_path": "pkg/sentry/kernel/epoll/epoll.go",
"diff": "@@ -77,6 +77,8 @@ type pollEntry struct {\n// in-struct pointers. Instead, EventPoll will properly set this field\n// in its loading logic.\ncurList *pollEntryList `sta... | Go | Apache License 2.0 | google/gvisor | Fix race between epoll readiness check and re-readying.
PiperOrigin-RevId: 432982236 |
259,951 | 07.03.2022 11:53:51 | 28,800 | 90bf1c1ff7a22142bcf5c22fd5901d5ab33a8a7c | Expose endpoint's state for raw and icmp sockets
The datagram endpoint state is valid and set for these endpoints, so we
can expose them (as we do for udp endpoints). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/BUILD",
"new_path": "pkg/tcpip/transport/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"])\n@@ -11,3 +11,22 @@ go_library(\nvisibility = ... | Go | Apache License 2.0 | google/gvisor | Expose endpoint's state for raw and icmp sockets
The datagram endpoint state is valid and set for these endpoints, so we
can expose them (as we do for udp endpoints).
PiperOrigin-RevId: 433001691 |
259,907 | 07.03.2022 13:21:32 | 28,800 | 21a689b36fb0188162187adb4d79122c3b5ba7b1 | Tolerate channel creation error in lisafs.
We might get a cranky server which does not want to allocate too many channels.
On server, the number of channels allowed is controlled by GOMAXPROCS and might
vary from 2 to 4.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/client.go",
"new_path": "pkg/lisafs/client.go",
"diff": "@@ -122,16 +122,13 @@ func NewClient(sock *unet.Socket) (*Client, Inode, error) {\n// channels and costly initialization like flipcall.Endpoint.Connect can\n// proceed parallely.\nvar channels... | Go | Apache License 2.0 | google/gvisor | Tolerate channel creation error in lisafs.
We might get a cranky server which does not want to allocate too many channels.
On server, the number of channels allowed is controlled by GOMAXPROCS and might
vary from 2 to 4.
Updates #6313
PiperOrigin-RevId: 433023166 |
259,907 | 07.03.2022 17:25:06 | 28,800 | 3d5201528603693b3383adc656acee0fe460b099 | Get rid of FSync RPC batching in gofer client with lisafs.
This optimization was not used correctly, as described in the change. We could
use it correctly to optimize sync(2) and syncfs(2). But that substantially
increases code complexity. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -56,15 +56,16 @@ func (fs *filesystem) Sync(ctx context.Context) error {\nvar retErr error\nif fs.opts.lisaEnabled {\n- // Try accumulating all FDIDs to fs... | Go | Apache License 2.0 | google/gvisor | Get rid of FSync RPC batching in gofer client with lisafs.
This optimization was not used correctly, as described in the change. We could
use it correctly to optimize sync(2) and syncfs(2). But that substantially
increases code complexity.
PiperOrigin-RevId: 433080982 |
259,853 | 07.03.2022 20:00:47 | 28,800 | 9851f1f320065ed83a72c8f4ea2b10e4cc7d1411 | tools/make_release.sh: don't overwrite global variables. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_release.sh",
"new_path": "tools/make_release.sh",
"diff": "@@ -41,6 +41,7 @@ done\n# install_raw installs raw artifacts.\ninstall_raw() {\nfor binary in \"${binaries[@]}\"; do\n+ local arch name\n# Copy the raw file & generate a sha512sum, sorted by... | Go | Apache License 2.0 | google/gvisor | tools/make_release.sh: don't overwrite global variables.
PiperOrigin-RevId: 433105561 |
259,907 | 08.03.2022 10:59:00 | 28,800 | bbf4a590868eba1d343c7edab46f60f8b4c9da18 | Update lisafs to return ENOMEM on hitting max channel limit.
Also add check to ensure that at least 1 channel is created. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/channel.go",
"new_path": "pkg/lisafs/channel.go",
"diff": "@@ -102,9 +102,13 @@ func (c *Connection) createChannel(maxMessageSize uint32) (*channel, flipcall.Pa\nc.channelsMu.Lock()\ndefer c.channelsMu.Unlock()\n// If c.channels is nil, the connecti... | Go | Apache License 2.0 | google/gvisor | Update lisafs to return ENOMEM on hitting max channel limit.
Also add check to ensure that at least 1 channel is created.
PiperOrigin-RevId: 433256702 |
259,881 | 09.03.2022 10:01:36 | 28,800 | 3cf58092122ae723b6e070b6e655ad652e98f832 | Bump Go branch workflow to 1.17
This matches the version in WORKSPACE and go.mod. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -45,7 +45,7 @@ jobs:\nfetch-depth: 0\n- uses: actions/setup-go@v2\nwith:\n- go-version: 1.15\n+ go-version: 1.17\n- run: tools/go_branch.sh\n- run: git checkout go && git clean -xf ... | Go | Apache License 2.0 | google/gvisor | Bump Go branch workflow to 1.17
This matches the version in WORKSPACE and go.mod.
PiperOrigin-RevId: 433506784 |
259,962 | 09.03.2022 17:28:38 | 28,800 | d38b0b3efe411a6baee2dd4e46045fba0c3e0c2b | Add a bulk transfer test for sharedmem. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/sharedmem_server_test.go",
"new_path": "pkg/tcpip/link/sharedmem/sharedmem_server_test.go",
"diff": "@@ -125,7 +125,7 @@ func newClientStack(t *testing.T, qPair *sharedmem.QueuePair, peerFD int) (*stac\nif err != nil {\nreturn nil, fmt... | Go | Apache License 2.0 | google/gvisor | Add a bulk transfer test for sharedmem.
PiperOrigin-RevId: 433618153 |
259,962 | 09.03.2022 20:00:54 | 28,800 | 00a4ea9bfbfea6047f451e26c6e02d0254090e7e | Minor code cleanups no functionality change. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/pipe/rx.go",
"new_path": "pkg/tcpip/link/sharedmem/pipe/rx.go",
"diff": "@@ -54,7 +54,15 @@ func (r *Rx) Pull() []byte {\n// Check if this is a wrapping slot. If that's the case, it carries no\n// data, so we just skip it and try again... | Go | Apache License 2.0 | google/gvisor | Minor code cleanups no functionality change.
PiperOrigin-RevId: 433640207 |
259,907 | 09.03.2022 21:44:30 | 28,800 | 1fcaa119a53ada26ade9fb1405cd593204699adc | Make watchdog panic for runtime tests.
This will make deadlocks more apparent in test results. Currently runtime tests
just timeout after 30 mins if there is some deadlock. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -231,8 +231,8 @@ packetimpact-tests:\n.PHONY: packetimpact-tests\n%-runtime-tests: load-runtimes_% $(RUNTIME_BIN)\n- @$(call install_runtime,$(RUNTIME),) # Ensure flags are cleared.\n- @$(call test_runtime,$(RUNTI... | Go | Apache License 2.0 | google/gvisor | Make watchdog panic for runtime tests.
This will make deadlocks more apparent in test results. Currently runtime tests
just timeout after 30 mins if there is some deadlock.
PiperOrigin-RevId: 433654750 |
260,009 | 10.03.2022 14:51:25 | 28,800 | 4503ba3f5efdf74079a9dba2242a38d51d0cf58d | Fix data race when using UNSHARE in close_range.
Also add test that fails under gotsan without the fix. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fd_table.go",
"new_path": "pkg/sentry/kernel/fd_table.go",
"diff": "@@ -760,6 +760,9 @@ func (f *FDTable) RemoveNextInRange(ctx context.Context, startFd int32, endFd in\n// GetLastFd returns the last set FD in the FDTable bitmap.\nfunc (f *FD... | Go | Apache License 2.0 | google/gvisor | Fix data race when using UNSHARE in close_range.
Also add test that fails under gotsan without the fix.
PiperOrigin-RevId: 433857741 |
260,009 | 10.03.2022 17:38:39 | 28,800 | ee133dbcf204c8518d9b272d2f91977f3ee1971c | Check UDP packet size before allocation.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/endpoint.go",
"new_path": "pkg/tcpip/transport/udp/endpoint.go",
"diff": "@@ -396,28 +396,32 @@ func (e *endpoint) prepareForWrite(p tcpip.Payloader, opts tcpip.WriteOptions) (\nreturn udpPacketInfo{}, err\n}\n- // TODO(https://gvisor.d... | Go | Apache License 2.0 | google/gvisor | Check UDP packet size before allocation.
Reported-by: syzbot+66a702d22e8ec6757346@syzkaller.appspotmail.com
PiperOrigin-RevId: 433892548 |
259,975 | 14.03.2022 11:52:34 | 25,200 | 9118171bef5de95f33f0888a888009bcfb8dc7ac | [benchmarks] Set smoke test to Startup benchmark and shorten long running benchmarks.
The smoke test runs ffmpeg, which is a few orders of magnitude longer than the startup benchmark.
Adding --test.benchtime=1ns ensures long running benchmarks only run once when benchmarks are calculating
b.N. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -264,20 +264,20 @@ steps:\n# Run basic benchmarks smoke tests (no upload).\n- <<: *common\nlabel: \":fire: Benchmarks smoke test\"\n- command: make benchmark-platforms\n+ command: m... | Go | Apache License 2.0 | google/gvisor | [benchmarks] Set smoke test to Startup benchmark and shorten long running benchmarks.
The smoke test runs ffmpeg, which is a few orders of magnitude longer than the startup benchmark.
Adding --test.benchtime=1ns ensures long running benchmarks only run once when benchmarks are calculating
b.N.
PiperOrigin-RevId: 434526626 |
259,884 | 15.03.2022 12:52:14 | 25,200 | dddbb7d7a944ec7cac77b65e500f0715095810be | Redirect new issues to Github chooser menu. | [
{
"change_type": "MODIFY",
"old_path": "website/cmd/server/main.go",
"new_path": "website/cmd/server/main.go",
"diff": "@@ -34,7 +34,7 @@ var redirects = map[string]string{\n\"/change\": \"https://github.com/google/gvisor\",\n\"/issue\": \"https://github.com/google/gvisor/issues\",\n\"/issues\": \"h... | Go | Apache License 2.0 | google/gvisor | Redirect new issues to Github chooser menu.
PiperOrigin-RevId: 434831027 |
259,975 | 15.03.2022 13:19:32 | 25,200 | 334090575d9f83329d15bf4e858630de32bcc634 | [benchmarks] Fix issue with run-benchmark.
make run-benchmark should not install a new runtime. Instead, just run the
benchmark with the given RUNTIME.
Move all of the logic to install the runtime to benchmark-platforms. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -367,14 +367,13 @@ init-benchmark-table: ## Initializes a BigQuery table with the benchmark schema.\n@$(call run,//tools/parsers:parser,init --project=$(BENCHMARKS_PROJECT) --dataset=$(BENCHMARKS_DATASET) --table=... | Go | Apache License 2.0 | google/gvisor | [benchmarks] Fix issue with run-benchmark.
make run-benchmark should not install a new runtime. Instead, just run the
benchmark with the given RUNTIME.
Move all of the logic to install the runtime to benchmark-platforms.
PiperOrigin-RevId: 434838884 |
259,992 | 17.03.2022 14:48:06 | 25,200 | 49896299a13934364c35563cfde04d53b6d97fa5 | Add product_name to sysfs
Some applications use product_name to find out if they are running inside
cloud providers and behave differently, like changing network settings or
expecting services to be available to the VM.
More details here:
This is also needed for: go/auth-library-noping | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sys/sys.go",
"new_path": "pkg/sentry/fsimpl/sys/sys.go",
"diff": "@@ -34,6 +34,7 @@ import (\nconst (\n// Name is the default filesystem name.\nName = \"sysfs\"\n+ defaultSysMode = linux.FileMode(0444)\ndefaultSysDirMode = linux.FileMode(0755... | Go | Apache License 2.0 | google/gvisor | Add product_name to sysfs
Some applications use product_name to find out if they are running inside
cloud providers and behave differently, like changing network settings or
expecting services to be available to the VM.
More details here: https://docs.google.com/document/d/1xQXE27x9wTvwPsgiX9Hn0o8mcq5z3SKi-1jwscQsCAk
This is also needed for: go/auth-library-noping
PiperOrigin-RevId: 435454155 |
259,977 | 17.03.2022 16:47:32 | 25,200 | 438c84460d6ed2dc085c407b05f15eed9e97d608 | Poll for POLLERR before validating ICMP error
...since ICMP errors are returned asynchronously. This also matches the
behavior of existing tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket.cc",
"new_path": "test/syscalls/linux/udp_socket.cc",
"diff": "@@ -382,6 +382,11 @@ TEST_P(UdpSocketTest, ConnectWriteToInvalidPort) {\nASSERT_THAT(sendto(sock_.get(), buf, sizeof(buf), 0, addr, addrlen_),\nSyscallSucceedsWithVal... | Go | Apache License 2.0 | google/gvisor | Poll for POLLERR before validating ICMP error
...since ICMP errors are returned asynchronously. This also matches the
behavior of existing tests.
PiperOrigin-RevId: 435484650 |
259,907 | 18.03.2022 00:03:55 | 25,200 | aaf0574af7b4ca4e1974c1e5a8a95e0a025b563b | Set DEBIAN_FRONTEND to be noninteractive in make_apt.sh.
This would prevent timeout issues where apt-get gets stuck on some prompt. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -30,6 +30,7 @@ readonly root\nshift; shift; shift # For \"$@\" below.\n# Ensure that we have the correct packages installed.\n+export DEBIAN_FRONTEND=noninteractive\nfunction apt_install() {\nwhi... | Go | Apache License 2.0 | google/gvisor | Set DEBIAN_FRONTEND to be noninteractive in make_apt.sh.
This would prevent timeout issues where apt-get gets stuck on some prompt.
PiperOrigin-RevId: 435558241 |
259,907 | 18.03.2022 00:15:32 | 25,200 | cf0bdacdd5228f920023f713715589df90b03846 | Revive VFS1-only failing runtime tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"new_path": "test/runtimes/exclude/nodejs12.4.0.csv",
"diff": "@@ -11,10 +11,6 @@ parallel/test-dgram-bind-fd.js,b/132447356,\nparallel/test-dgram-socket-buffer-size.js,b/68847921,\nparallel/test-dns-channel-timeout.js,... | Go | Apache License 2.0 | google/gvisor | Revive VFS1-only failing runtime tests.
PiperOrigin-RevId: 435560141 |
259,985 | 18.03.2022 01:15:27 | 25,200 | 24cef0a622bb99fdfafe7898679a95a2a974b499 | cgroupfs: Stub control files to allow subcontainer creation with gcontain. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"diff": "package cgroupfs\nimport (\n+ \"bytes\"\n\"fmt\"\n\"sort\"\n\"strconv\"\n\"strings\"\n+ \"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/g... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Stub control files to allow subcontainer creation with gcontain.
PiperOrigin-RevId: 435569386 |
259,864 | 18.03.2022 09:15:08 | -3,600 | 49c97d8b25addb82150a566545720299ec991a9d | Configuration needs to use `options` not `option` | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/containerd/configuration.md",
"new_path": "g3doc/user_guide/containerd/configuration.md",
"diff": "@@ -68,7 +68,7 @@ version = 2\nruntime_type = \"io.containerd.runc.v2\"\n[plugins.\"io.containerd.grpc.v1.cri\".containerd.runtimes.runsc]\nrunt... | Go | Apache License 2.0 | google/gvisor | Configuration needs to use `options` not `option` |
259,992 | 22.03.2022 13:50:29 | 25,200 | f7712ab50c593baf4f372d163a7b553081c1857e | Revalidate symlink chain
When there are more than one symlink pointing to another symlink
the revalidation step was being skipped because steoLocked() would
process all symlinks before returning.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -191,7 +191,9 @@ func (fs *filesystem) renameMuUnlockAndCheckCaching(ctx context.Context, ds **[]\n}\n// stepLocked resolves rp.Component() to an existing ... | Go | Apache License 2.0 | google/gvisor | Revalidate symlink chain
When there are more than one symlink pointing to another symlink
the revalidation step was being skipped because steoLocked() would
process all symlinks before returning.
Closes #7297
PiperOrigin-RevId: 436562314 |
259,992 | 22.03.2022 16:42:06 | 25,200 | e5c86191d1529ae4b15745b944b45311d1aaec9a | Group FD flags in cmd.Boot/Gofer | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/boot.go",
"new_path": "runsc/cmd/boot.go",
"diff": "@@ -132,16 +132,20 @@ func (*Boot) Usage() string {\n// SetFlags implements subcommands.Command.SetFlags.\nfunc (b *Boot) SetFlags(f *flag.FlagSet) {\nf.StringVar(&b.bundleDir, \"bundle\", \"\", \"r... | Go | Apache License 2.0 | google/gvisor | Group FD flags in cmd.Boot/Gofer
PiperOrigin-RevId: 436602364 |
259,858 | 22.03.2022 21:30:25 | 25,200 | 1e5014d65723a8dc535f985525cceddf02088d11 | Don't mark all Copy* functions as go:nosplit.
This relaxes the checkescape annotation in the test slightly, but allowing
stack splits should not cause issues.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator_interfaces_array_newtype.go",
"new_path": "tools/go_marshal/gomarshal/generator_interfaces_array_newtype.go",
"diff": "@@ -107,7 +107,6 @@ func (g *interfaceGenerator) emitMarshallableForArrayNewtype(n *ast.Ident, a *as\ng.... | Go | Apache License 2.0 | google/gvisor | Don't mark all Copy* functions as go:nosplit.
This relaxes the checkescape annotation in the test slightly, but allowing
stack splits should not cause issues.
Fixes #7309
PiperOrigin-RevId: 436645425 |
259,985 | 23.03.2022 17:23:57 | 25,200 | 9085d334deed528d3f9336c9fd98cf3282e0eee0 | kernfs: Handle duplicate unlink on orphaned directories.
Also don't print kernfs inode internals on panic, when we can't
acquire the necessary locks.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -242,6 +242,15 @@ func checkDeleteLocked(ctx context.Context, rp *vfs.ResolvingPath, d *Dentry) er\nif parent.vfsd.IsDead() {\nreturn linuxerr.ENOENT\n}\... | Go | Apache License 2.0 | google/gvisor | kernfs: Handle duplicate unlink on orphaned directories.
Also don't print kernfs inode internals on panic, when we can't
acquire the necessary locks.
Reported-by: syzbot+101505e52936904e7d9f@syzkaller.appspotmail.com
Reported-by: syzbot+b9fe0fa83736b77030d2@syzkaller.appspotmail.com
PiperOrigin-RevId: 436869482 |
259,868 | 23.03.2022 18:52:55 | 25,200 | 7da1c59e773fad3ff7eab51d04601c92932e2a3b | Fix broken `+checkescape` annotation in sleep package.
Make `checkescape` check for variants of `+checkescape` that would silently be
ignored. #codehealth | [
{
"change_type": "MODIFY",
"old_path": "pkg/sleep/sleep_unsafe.go",
"new_path": "pkg/sleep/sleep_unsafe.go",
"diff": "@@ -166,6 +166,7 @@ func (s *Sleeper) AddWaker(w *Waker) {\n// block, then we will need to explicitly wake a runtime P.\n//\n// Precondition: wakepOrSleep may be true iff block is tr... | Go | Apache License 2.0 | google/gvisor | Fix broken `+checkescape` annotation in sleep package.
Make `checkescape` check for variants of `+checkescape` that would silently be
ignored. #codehealth
PiperOrigin-RevId: 436882400 |
259,985 | 24.03.2022 15:07:06 | 25,200 | 5835bc8c3a4bd1b2c41a40ff706282f6224aaffc | cgroupfs: Handle invalid PID/PGID on migration.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -302,6 +302,9 @@ func (d *cgroupProcsData) Write(ctx context.Context, fd *vfs.FileDescription, sr\nt := kernel.TaskFromContext(ctx)\ncurrPidns := t.ThreadGroup()... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Handle invalid PID/PGID on migration.
Reported-by: syzbot+670d686c42a0a8d7f8a6@syzkaller.appspotmail.com
PiperOrigin-RevId: 437096386 |
259,881 | 28.03.2022 11:22:25 | 25,200 | 34623f4d753169d8af72a75c8e72bbd27e64c01b | Skip analysis of sync/atomic
is adding Pointer[T] to sync/atomic,
which will trip up analyzers that don't handle generics. Skip
it for now.
Drop constraints, maps, slices, as they were dropped from the
standard library. | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/check/check.go",
"new_path": "tools/nogo/check/check.go",
"diff": "@@ -746,9 +746,7 @@ func SplitPackages(srcs []string, srcRootPrefix string) map[string][]string {\n//\n// TODO(b/201686256): remove once tooling can handle type parameters.\nvar uses... | Go | Apache License 2.0 | google/gvisor | Skip analysis of sync/atomic
https://go.dev/issue/50860 is adding Pointer[T] to sync/atomic,
which will trip up analyzers that don't handle generics. Skip
it for now.
Drop constraints, maps, slices, as they were dropped from the
standard library.
PiperOrigin-RevId: 437808952 |
259,896 | 29.03.2022 15:46:02 | 25,200 | 007a91a911084e46efffc4e2531ff8dee5cf1917 | Silence the error log message for SO_RCVLOWAT option.
Removed the unimplemented syscall message for SO_RCVLOWAT option and added a
test for {g,s}etsockopt. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1064,6 +1064,14 @@ func getSockOptSocket(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, fam\nvP := primitive.Int32(boolToInt32(v))\nreturn &vP, ... | Go | Apache License 2.0 | google/gvisor | Silence the error log message for SO_RCVLOWAT option.
Removed the unimplemented syscall message for SO_RCVLOWAT option and added a
test for {g,s}etsockopt.
PiperOrigin-RevId: 438145815 |
259,891 | 29.03.2022 17:45:26 | 25,200 | c2bd153760b0ae24b1cd0183741742ae82f4c4da | don't check refcount in packet buffer's destroy function
The function is only called when refcount is zero,
so we don't have to check again. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/packet_buffer.go",
"new_path": "pkg/tcpip/stack/packet_buffer.go",
"diff": "@@ -188,9 +188,7 @@ func NewPacketBuffer(opts PacketBufferOptions) *PacketBuffer {\n// pool.\nfunc (pk *PacketBuffer) DecRef() {\npk.packetBufferRefs.DecRef(func() {\n-... | Go | Apache License 2.0 | google/gvisor | don't check refcount in packet buffer's destroy function
The function is only called when refcount is zero,
so we don't have to check again.
PiperOrigin-RevId: 438171100 |
259,985 | 29.03.2022 20:00:11 | 25,200 | 5bb1f5086ed69f0d77b217cec5c10e94a1f00498 | cgroupfs: Implement hierarchical accounting for cpuacct controller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -40,6 +40,11 @@ import (\ntype controllerCommon struct {\nty kernel.CgroupControllerType\nfs *filesystem\n+ // parent is the parent controller if any. Immutable.... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Implement hierarchical accounting for cpuacct controller.
PiperOrigin-RevId: 438193226 |
259,853 | 30.03.2022 10:50:36 | 25,200 | be49295381b41b4d50f597e12999b25b913c2eb0 | make: set --//tools/nogo:fast by default
nogo:fast is converted to nogo:full with the opposite meaning.
All nogo tests have to be always executed with this option.
Analyzing Go Standard Library takes about 10 minutes on buildkite,
but it is required only to run nogo tests. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -197,7 +197,7 @@ smoke-race-tests: ## Runs a smoke test after build building runsc in race config\n.PHONY: smoke-race-tests\nnogo-tests:\n- @$(call test,--build_tag_filters=nogo --test_tag_filters=nogo //:all pkg/... | Go | Apache License 2.0 | google/gvisor | make: set --//tools/nogo:fast by default
nogo:fast is converted to nogo:full with the opposite meaning.
All nogo tests have to be always executed with this option.
Analyzing Go Standard Library takes about 10 minutes on buildkite,
but it is required only to run nogo tests.
PiperOrigin-RevId: 438343203 |
259,868 | 30.03.2022 16:45:10 | 25,200 | 8e55783cd36c391a4ea02383a3d5b83cf5099aac | gvisor.dev: Fix chart axis precision to one decimal point to avoid overflow. | [
{
"change_type": "MODIFY",
"old_path": "website/_includes/graph.html",
"new_path": "website/_includes/graph.html",
"diff": "@@ -90,7 +90,7 @@ d3.csv(\"{{ include.url }}\", function(d, i, columns) {\nvar x1_domain = runtimes;\n}\n- // Determine varaible margins.\n+ // Determine variable margins.\nvar... | Go | Apache License 2.0 | google/gvisor | gvisor.dev: Fix chart axis precision to one decimal point to avoid overflow.
PiperOrigin-RevId: 438428560 |
259,853 | 30.03.2022 17:48:40 | 25,200 | 5d9d852f375fa6b5524d6806a4f6252ecda107d2 | test/runtimes: move all runner actions under timeout | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/runner/lib/lib.go",
"new_path": "test/runtimes/runner/lib/lib.go",
"diff": "@@ -56,10 +56,14 @@ func RunTests(lang, image, excludeFile string, batchSize int, timeout time.Durat\nreturn 1\n}\n+ timeoutChan := make(chan struct{})\n+ // Add one minu... | Go | Apache License 2.0 | google/gvisor | test/runtimes: move all runner actions under timeout
PiperOrigin-RevId: 438441356 |
259,909 | 31.03.2022 09:14:46 | 25,200 | d9cffce328f9e2ada874cfc4df21890086bceb48 | Parse cgroupv2 path only once while scanning mountinfo.
Some systems have multiple cgroup2 mounts. In these cases, loadPathsHelper
incorrectly attempts to overwrite `paths[cgroup2Key]` with an already
processed value, which causes an error in filepath.Rel.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -40,6 +40,8 @@ import (\nconst (\ncgroupRoot = \"/sys/fs/cgroup\"\n+ cgroupv1FsName = \"cgroup\"\n+ cgroupv2FsName = \"cgroup2\"\n)\nvar controllers = map[string]controller{\n@@ -255,6 ... | Go | Apache License 2.0 | google/gvisor | Parse cgroupv2 path only once while scanning mountinfo.
Some systems have multiple cgroup2 mounts. In these cases, loadPathsHelper
incorrectly attempts to overwrite `paths[cgroup2Key]` with an already
processed value, which causes an error in filepath.Rel.
Fixes #7334
PiperOrigin-RevId: 438583982 |
259,853 | 31.03.2022 14:20:46 | 25,200 | 3b3376ce7d7bc926542b304f23b261c84061fc0f | platform/kvm: don't call mmap for less than one page
mmap can't allocate less than one page.
In addition, we can check whether a new region is merged with a previous one
and avoid a hole overhead. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/physical_map.go",
"new_path": "pkg/sentry/platform/kvm/physical_map.go",
"diff": "@@ -99,6 +99,11 @@ func fillAddressSpace() (excludedRegions []region) {\nunix.MAP_ANONYMOUS|unix.MAP_PRIVATE|unix.MAP_NORESERVE,\n0, 0)\nif errno != 0 {\n... | Go | Apache License 2.0 | google/gvisor | platform/kvm: don't call mmap for less than one page
mmap can't allocate less than one page.
In addition, we can check whether a new region is merged with a previous one
and avoid a hole overhead.
PiperOrigin-RevId: 438660167 |
259,975 | 31.03.2022 14:35:31 | 25,200 | c86b049468e0884e4506bb291afb563c8ddafce4 | [benchmarks] Fix benchmarks readme after feedback. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/README.md",
"new_path": "test/benchmarks/README.md",
"diff": "@@ -21,12 +21,11 @@ To run, use the Makefile:\n- The above command will place several configurations of runsc in your\n/etc/docker/daemon.json file. Choose one without the debug opti... | Go | Apache License 2.0 | google/gvisor | [benchmarks] Fix benchmarks readme after feedback.
PiperOrigin-RevId: 438663626 |
259,853 | 31.03.2022 14:57:15 | 25,200 | 973f8636d78e947da65881bcbfd627bb0035f29d | platform/kvm: limit virtual address space size to 256TB
This is maximum that can be addressed with 4-level paging. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/lib_amd64.go",
"new_path": "pkg/ring0/lib_amd64.go",
"diff": "@@ -84,6 +84,12 @@ var (\nfunc Init(fs cpuid.FeatureSet) {\n// Initialize all sizes.\nVirtualAddressBits = uintptr(fs.VirtualAddressBits())\n+ // TODO(gvisor.dev/issue/7349): introduce sup... | Go | Apache License 2.0 | google/gvisor | platform/kvm: limit virtual address space size to 256TB
This is maximum that can be addressed with 4-level paging.
PiperOrigin-RevId: 438668768 |
259,985 | 31.03.2022 15:30:47 | 25,200 | 8a8349e1bca4d116806f0aac3587cf0771d0c5cd | cgroupfs: Return the correct cgroup path for tasks from procfs.
Previously we were returning the path to the control file used to
migrate a task, rather than the path to the cgroup directory. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -283,9 +283,15 @@ func (c *cgroupInode) AbortMigrate(t *kernel.Task, src *kernel.Cgroup) {\n}\n}\n-func (c *cgroupInode) Cgroup(fd *vfs.FileDescription) kernel.C... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Return the correct cgroup path for tasks from procfs.
Previously we were returning the path to the control file used to
migrate a task, rather than the path to the cgroup directory.
PiperOrigin-RevId: 438676422 |
259,985 | 31.03.2022 16:27:37 | 25,200 | 78d2200a17231f62eef733cae44c0883605eb795 | cgroupfs: Directories should support setstat. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"diff": "@@ -429,9 +429,9 @@ func (*dir) Keep() bool {\nreturn true\n}\n-// SetStat implements kernfs.Inode.SetStat not allowing inode attributes to be changed.\n-fu... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Directories should support setstat.
PiperOrigin-RevId: 438688088 |
259,909 | 31.03.2022 16:45:36 | 25,200 | 28549d8578ee1aad937592eee523016d35f4e733 | Transition to closed state before releasing a tcp endpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1003,6 +1003,8 @@ func (e *endpoint) notifyProtocolGoroutine(n uint32) {\nfunc (e *endpoint) Release() {\ne.LockUser()\ndefer e.UnlockUser()\n+ e.transitionTo... | Go | Apache License 2.0 | google/gvisor | Transition to closed state before releasing a tcp endpoint.
PiperOrigin-RevId: 438691888 |
259,982 | 01.04.2022 14:59:38 | 25,200 | 5b538f75e447d934ac81a1bfc167306ef8f55814 | Created tests for mounting tmpfs with size option enabled.
Tests include:
Allocating memory below and above range for single file.
Allocating memory above range for multiple file. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mount.cc",
"new_path": "test/syscalls/linux/mount.cc",
"diff": "#include <errno.h>\n#include <fcntl.h>\n#include <stdio.h>\n+#include <sys/eventfd.h>\n#include <sys/mount.h>\n+#include <sys/resource.h>\n+#include <sys/signalfd.h>\n#include ... | Go | Apache License 2.0 | google/gvisor | Created tests for mounting tmpfs with size option enabled.
Tests include:
Allocating memory below and above range for single file.
Allocating memory above range for multiple file.
PiperOrigin-RevId: 438918539 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.