author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,868 | 23.05.2022 17:46:56 | 25,200 | 6a922404e7832a7ea81373ac3e525b9ac9f9a4bd | Default Docker image: Add kmod package. | [
{
"change_type": "MODIFY",
"old_path": "images/default/Dockerfile",
"new_path": "images/default/Dockerfile",
"diff": "@@ -7,7 +7,7 @@ RUN apt-get update && apt-get install -y curl gnupg2 git \\\nopenjdk-11-jdk-headless zip unzip \\\napt-transport-https ca-certificates gnupg-agent \\\nsoftware-proper... | Go | Apache License 2.0 | google/gvisor | Default Docker image: Add kmod package.
PiperOrigin-RevId: 450564818 |
259,868 | 23.05.2022 19:09:10 | 25,200 | a6fbca2eec789ed5ca0704eb0816021ead957902 | `yaml_test`: Add argument to allow non-strict YAML decoding. | [
{
"change_type": "MODIFY",
"old_path": "tools/yamltest/defs.bzl",
"new_path": "tools/yamltest/defs.bzl",
"diff": "@@ -6,9 +6,10 @@ def _yaml_test_impl(ctx):\nctx.actions.write(runner, \"\\n\".join([\n\"#!/bin/bash\",\n\"set -euo pipefail\",\n- \"%s -schema=%s -- %s\" % (\n+ \"%s -schema=%s -strict=%... | Go | Apache License 2.0 | google/gvisor | `yaml_test`: Add argument to allow non-strict YAML decoding.
PiperOrigin-RevId: 450576605 |
259,985 | 24.05.2022 14:44:11 | 25,200 | edf123719cc4f2d60520ecf33f3de54ae9857d31 | cgroupfs: Implement named hierarchies. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -203,10 +203,16 @@ func (fs *filesystem) newCgroupInode(ctx context.Context, creds *auth.Credential\nreturn c\n}\n+// HierarchyID implements kernel.CgroupImpl.Hi... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Implement named hierarchies.
PiperOrigin-RevId: 450773348 |
259,907 | 24.05.2022 15:57:00 | 25,200 | b274736ac7ee604a5ec8b834c6cad0a621bb0e2e | Add support for /prod/[pid]/fd to trace procfs.
On Linux, /proc/[pid]/fd/ entries are symlinks with name
as FD number and target as the file path.
runsc trace procfs will return the FD numbers and their
corresponding file paths for each process.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/dump.go",
"new_path": "runsc/boot/procfs/dump.go",
"diff": "@@ -29,6 +29,14 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/vfs\"\n)\n+// FDInfo contains information about an application file descriptor.\n+type FDInfo struct {\n+ // Number is the... | Go | Apache License 2.0 | google/gvisor | Add support for /prod/[pid]/fd to trace procfs.
On Linux, /proc/[pid]/fd/ entries are symlinks with name
as FD number and target as the file path.
runsc trace procfs will return the FD numbers and their
corresponding file paths for each process.
Updates #4805
PiperOrigin-RevId: 450788929 |
259,907 | 24.05.2022 16:40:13 | 25,200 | 0ad98ee0e8426830c79c46787ac9ea0d6c5623ff | Add support for process start time to trace procfs.
Added test for this.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/dump.go",
"new_path": "runsc/boot/procfs/dump.go",
"diff": "@@ -52,6 +52,8 @@ type ProcessProcfsDump struct {\n// FDs contains the directory entries of /proc/[pid]/fd and also contains the\n// symlink target for each FD.\nFDs []FDInfo `json:\... | Go | Apache License 2.0 | google/gvisor | Add support for process start time to trace procfs.
Added test for this.
Updates #4805
PiperOrigin-RevId: 450797692 |
259,907 | 24.05.2022 22:45:42 | 25,200 | f7d57e9746192459f6d1e1411bed5ccc32cdfb3c | Add support for /proc/[pid]/root to trace procfs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/dump.go",
"new_path": "runsc/boot/procfs/dump.go",
"diff": "@@ -37,7 +37,8 @@ type FDInfo struct {\nPath string `json:\"path,omitempty\"`\n}\n-// ProcessProcfsDump contains the procfs dump for one process.\n+// ProcessProcfsDump contains the ... | Go | Apache License 2.0 | google/gvisor | Add support for /proc/[pid]/root to trace procfs.
Updates #4805
PiperOrigin-RevId: 450846922 |
259,891 | 25.05.2022 10:38:47 | 25,200 | 0a6e768256203700a484d2b7e42e5a428bfc34b6 | reduce sharedmem server test runtime
The large bulk tests can take 25-45+ seconds. AFAIK we don't need to test such
large values. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sharedmem/sharedmem_server_test.go",
"new_path": "pkg/tcpip/link/sharedmem/sharedmem_server_test.go",
"diff": "@@ -297,8 +297,6 @@ func TestServerBulkTransfer(t *testing.T) {\n512 << 20, // 512 MiB\n1024 << 20, // 1 GiB\n2048 << 20, // 2 GiB\n- ... | Go | Apache License 2.0 | google/gvisor | reduce sharedmem server test runtime
The large bulk tests can take 25-45+ seconds. AFAIK we don't need to test such
large values.
PiperOrigin-RevId: 450959539 |
259,992 | 25.05.2022 11:58:07 | 25,200 | d2743355aea086de1884454ec6d62560bd23730d | Handle negative FDs in syscall points
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/points.go",
"new_path": "pkg/sentry/syscalls/linux/points.go",
"diff": "@@ -35,13 +35,16 @@ func newExitMaybe(info kernel.SyscallInfo) *pb.Exit {\n}\nfunc getFilePath(t *kernel.Task, fd int32) string {\n+ if fd < 0 {\n+ return \"\"\n+... | Go | Apache License 2.0 | google/gvisor | Handle negative FDs in syscall points
Updates #4805
PiperOrigin-RevId: 450980807 |
259,985 | 25.05.2022 12:05:47 | 25,200 | 2a6fe814c742559f3aac9932b00e219eda6a2158 | cgroupfs: Mark the "cgroup.procs" and "task" files as writable.
We were bypassing permission checks and writing to these files from
tests since all our tests run as the root user. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -175,8 +175,8 @@ func (fs *filesystem) newCgroupInode(ctx context.Context, creds *auth.Credential\nc.dir.cgi = c\ncontents := make(map[string]kernfs.Inode)\n- co... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Mark the "cgroup.procs" and "task" files as writable.
We were bypassing permission checks and writing to these files from
tests since all our tests run as the root user.
PiperOrigin-RevId: 450983044 |
259,891 | 25.05.2022 12:22:53 | 25,200 | 2b52af3592780308e5ea43862e06349b02b98111 | netstack: have IncRef() return *PacketBuffer
This makes it clearer where the new ownership is occuring. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -84,10 +84,9 @@ func (q *queue) Write(pkt *stack.PacketBuffer) tcpip.Error {\nreturn &tcpip.ErrClosedForSend{}\n}\n- pkt.IncRef()\nwrote := false\nselect {\n- case... | Go | Apache License 2.0 | google/gvisor | netstack: have IncRef() return *PacketBuffer
This makes it clearer where the new ownership is occuring.
PiperOrigin-RevId: 450987161 |
259,992 | 25.05.2022 12:28:30 | 25,200 | 1c0fe0e724619871b906ada123692d067a38b253 | Remove VFS1 TTY from runsc
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -39,9 +39,8 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/control\"\n\"gvisor.dev/gvisor/pkg/sentry/fdimport\"\n\"gvisor.dev/gvisor/pkg/sentry/fs\"\n- \"gvisor.dev/gvisor/pkg/sentry/fs/host\"... | Go | Apache License 2.0 | google/gvisor | Remove VFS1 TTY from runsc
Updates #1624
PiperOrigin-RevId: 450988463 |
259,982 | 25.05.2022 13:31:29 | 25,200 | f84e9a85d1e5716745780537fce0e6c51fa2f1fb | Add Points to some syscalls
Added a raw syscall points to all syscalls. Added schematized syscall
points to the following syscalls:
Chdir
Fchdir
Setgid
Setuid
Setsid
Setresuid
Setresgid | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/server.cc",
"new_path": "examples/seccheck/server.cc",
"diff": "@@ -92,6 +92,9 @@ std::vector<Callback> dispatchers = {\nunpackSyscall<::gvisor::syscall::Connect>,\nunpackSyscall<::gvisor::syscall::Execve>,\nunpackSyscall<::gvisor::syscall::S... | Go | Apache License 2.0 | google/gvisor | Add Points to some syscalls
Added a raw syscall points to all syscalls. Added schematized syscall
points to the following syscalls:
- Chdir
- Fchdir
- Setgid
- Setuid
- Setsid
- Setresuid
- Setresgid
PiperOrigin-RevId: 451001973 |
259,992 | 25.05.2022 13:57:21 | 25,200 | 11a9f17b9a6041ce32bf3c4cd0a9bb48a5700432 | Trace points integration test
Updates | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -203,7 +203,7 @@ nogo-tests:\n# For unit tests, we take everything in the root, pkg/... and tools/..., and\n# pull in all directories in runsc except runsc/container.\nunit-tests: ## Local package unit tests in pk... | Go | Apache License 2.0 | google/gvisor | Trace points integration test
Updates #4805
PiperOrigin-RevId: 451007875 |
259,907 | 25.05.2022 15:27:33 | 25,200 | a3892a07b5a16b6cc0bbc03d723ddfe2d64a8a57 | Add support for prlimit(RLIMIT_NOFILE) to trace procfs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/limits/limits.go",
"new_path": "pkg/sentry/limits/limits.go",
"diff": "@@ -51,9 +51,9 @@ const Infinity = ^uint64(0)\n// +stateify savable\ntype Limit struct {\n// Cur specifies the current limit.\n- Cur uint64\n+ Cur uint64 `json:\"cur,omitempty\"`... | Go | Apache License 2.0 | google/gvisor | Add support for prlimit(RLIMIT_NOFILE) to trace procfs.
Updates #4805
PiperOrigin-RevId: 451029238 |
259,966 | 26.05.2022 08:02:48 | 25,200 | 33c687560388eab79133f3cf1f8a69afc8c9d200 | Implement remove multicast route.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -1521,6 +1521,20 @@ func (p *protocol) AddMulticastRoute(addresses stack.UnicastSourceAndMulticastDe\nreturn nil\n}\n+// RemoveMulticastRoute implements\n+// stack.Multi... | Go | Apache License 2.0 | google/gvisor | Implement remove multicast route.
Updates #7338.
PiperOrigin-RevId: 451162886 |
259,966 | 26.05.2022 08:56:43 | 25,200 | e9520375517bfb0c868019cad4574254012ad07f | Implement GetMulticastRouteLastUsedTime.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -1535,6 +1535,22 @@ func (p *protocol) RemoveMulticastRoute(addresses stack.UnicastSourceAndMulticas\nreturn nil\n}\n+// MulticastRouteLastUsedTime implements\n+// stack... | Go | Apache License 2.0 | google/gvisor | Implement GetMulticastRouteLastUsedTime.
Updates #7338.
PiperOrigin-RevId: 451172827 |
259,891 | 26.05.2022 12:29:26 | 25,200 | 3dfcffdb157bc1888d1f370d3ef64089caed55e8 | remove checkescape from iptables.go
These fail on buildkite arm64 machines. While we figure out the problem, we
should unblock submits. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -315,7 +315,7 @@ func (it *IPTables) shouldSkipOrPopulateTables(tables []checkTable, pkt *PacketB\n// This is called in the hot path even when iptables are disabled, so we ens... | Go | Apache License 2.0 | google/gvisor | remove checkescape from iptables.go
These fail on buildkite arm64 machines. While we figure out the problem, we
should unblock submits.
PiperOrigin-RevId: 451219197 |
260,004 | 26.05.2022 14:04:28 | 25,200 | 6f5e475674d6c200e4f09f9f0edd1ef15d3fc0e0 | Loop multicast packets from raw sockets | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/BUILD",
"new_path": "pkg/tcpip/transport/BUILD",
"diff": "@@ -30,5 +30,6 @@ go_test(\n\"//pkg/tcpip/transport/raw\",\n\"//pkg/tcpip/transport/udp\",\n\"//pkg/waiter\",\n+ \"@com_github_google_go_cmp//cmp:go_default_library\",\n],\n)\n"
},... | Go | Apache License 2.0 | google/gvisor | Loop multicast packets from raw sockets
Bug: https://fxbug.dev/101226
PiperOrigin-RevId: 451239264 |
259,907 | 26.05.2022 20:00:05 | 25,200 | 37076bc16f911c0176cd6dd1cf6b35ed59ce9002 | Add support for /proc/[pid]/cgroup to trace procfs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_cgroup.go",
"new_path": "pkg/sentry/kernel/task_cgroup.go",
"diff": "@@ -177,20 +177,21 @@ func (t *Task) MigrateCgroup(dst Cgroup) error {\nreturn nil\n}\n-// taskCgroupEntry represents a line in /proc/<pid>/cgroup, and is used to\n+// ... | Go | Apache License 2.0 | google/gvisor | Add support for /proc/[pid]/cgroup to trace procfs.
Updates #4805
PiperOrigin-RevId: 451297968 |
259,907 | 26.05.2022 20:31:04 | 25,200 | 565fbe2151b328d4a5aa1151e8efb28cd9484549 | Add support for /proc/[pid]/status to trace procfs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/dump.go",
"new_path": "runsc/boot/procfs/dump.go",
"diff": "@@ -38,11 +38,26 @@ type FDInfo struct {\nPath string `json:\"path,omitempty\"`\n}\n+// UIDGID contains information for /proc/[pid]/status/{uid,gid}.\n+type UIDGID struct {\n+ Real u... | Go | Apache License 2.0 | google/gvisor | Add support for /proc/[pid]/status to trace procfs.
Updates #4805
PiperOrigin-RevId: 451301995 |
259,907 | 26.05.2022 22:22:53 | 25,200 | f1c9664506be4b072bb57b517cc18decaeec7350 | Add support for /proc/[pid]/stat to trace procfs.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -639,7 +639,7 @@ func (cm *containerManager) ProcfsDump(_ *struct{}, out *[]procfs.ProcessProcfsD\n*out = make([]procfs.ProcessProcfsDump, 0, len(cm.l.processes))\nfor _, tg := rang... | Go | Apache License 2.0 | google/gvisor | Add support for /proc/[pid]/stat to trace procfs.
Updates #4805
PiperOrigin-RevId: 451314545 |
259,907 | 30.05.2022 19:46:54 | 25,200 | c7690e05c1fd863a7f6670078a7a557cba19f58a | Add option to hide application data in strace logs.
This is helpful in disabling printing sensitive application data when strace is
enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/socket.go",
"new_path": "pkg/sentry/strace/socket.go",
"diff": "@@ -462,7 +462,7 @@ func sockOptVal(t *kernel.Task, level, optname uint64, optVal hostarch.Addr, opt\n}\nreturn fmt.Sprintf(\"%#x {value=%v}\", optVal, v)\ndefault:\n- return dum... | Go | Apache License 2.0 | google/gvisor | Add option to hide application data in strace logs.
This is helpful in disabling printing sensitive application data when strace is
enabled.
PiperOrigin-RevId: 451946198 |
259,966 | 31.05.2022 08:21:46 | 25,200 | ea5c64b6174388a62727ba0d9c4a5eadfe7a3f29 | Emit multicast forwarding events.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -367,6 +367,18 @@ func (e *endpoint) disableLocked() {\n}\n}\n+// multicastEventDispatcher returns the multicast forwarding event dispatcher.\n+//\n+// Panics if a multi... | Go | Apache License 2.0 | google/gvisor | Emit multicast forwarding events.
Updates #7338.
PiperOrigin-RevId: 452051657 |
259,891 | 31.05.2022 14:12:48 | 25,200 | f4d6127a5cc311560d74581554d86ffccdbc61f9 | checkescape: address ARM relative offsets
`go tool objdump` produces relative offsets for BL instructions as a number of
instructions rather than a number of bytes. Calculate the byte offset ourselves.
Example passing run on ARM machine:
Filed bug upstream about confusing output here: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/iptables.go",
"new_path": "pkg/tcpip/stack/iptables.go",
"diff": "@@ -315,7 +315,7 @@ func (it *IPTables) shouldSkipOrPopulateTables(tables []checkTable, pkt *PacketB\n// This is called in the hot path even when iptables are disabled, so we ens... | Go | Apache License 2.0 | google/gvisor | checkescape: address ARM relative offsets
`go tool objdump` produces relative offsets for BL instructions as a number of
instructions rather than a number of bytes. Calculate the byte offset ourselves.
Example passing run on ARM machine:
https://buildkite.com/gvisor/pipeline/builds/14732#018106ac-ac8e-4636-9a5a-bde1641b1175
Filed bug upstream about confusing output here:
https://github.com/golang/go/issues/53117
PiperOrigin-RevId: 452137751 |
259,868 | 31.05.2022 15:18:22 | 25,200 | 3ec7b4b614ad2d8f13e481e5f80b79d685002860 | Add Makefile support to mount kernel header files and device files.
Also use `realpath` in place of `readlink` wherever appropriate. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "## BAZEL_CACHE - The bazel cache directory (default: detected).\n## GCLOUD_CONFIG - The gcloud config directory (detect: detected).\n## DOCKER_SOCKET - The Docker socket (default: detected).\n+## DEVICE_F... | Go | Apache License 2.0 | google/gvisor | Add Makefile support to mount kernel header files and device files.
Also use `realpath` in place of `readlink` wherever appropriate.
PiperOrigin-RevId: 452152372 |
259,868 | 31.05.2022 15:44:05 | 25,200 | 9ab1f6756b6ecea55aca988ff464bbfff454d0d4 | runsc: Add more precise error messages in `{container,sandbox}.go`. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -219,7 +219,7 @@ func New(conf *config.Config, args Args) (*Container, error) {\n// Lock the container metadata file to prevent concurrent creations of\n// containers with t... | Go | Apache License 2.0 | google/gvisor | runsc: Add more precise error messages in `{container,sandbox}.go`.
PiperOrigin-RevId: 452158030 |
259,907 | 31.05.2022 16:43:47 | 25,200 | cad9a8303f2e76afd7ad7bfaba367c08fa3fdb46 | Add ppid to trace procfs output.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/dump.go",
"new_path": "runsc/boot/procfs/dump.go",
"diff": "@@ -49,6 +49,7 @@ type UIDGID struct {\ntype Status struct {\nComm string `json:\"comm,omitempty\"`\nPID int32 `json:\"pid,omitempty\"`\n+ PPID int32 `json:\"ppid,omitempty\"`\nUID U... | Go | Apache License 2.0 | google/gvisor | Add ppid to trace procfs output.
Updates #4805
PiperOrigin-RevId: 452169866 |
259,909 | 31.05.2022 17:14:09 | 25,200 | c24bef7b80aba0831b1a7907737df8ee0bc152bd | Fix racy behavior in tcp Read().
The startRead and commitRead with RcvReadMu is not safe anymore with the
change to Close() that purges the read queue.
This may reduce performance of highly concurrent reads. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -214,7 +214,10 @@ func (l *listenContext) createConnectingEndpoint(s *segment, rcvdSynOpts header.\n// Bootstrap the auto tuning algorithm. Starting at zero will r... | Go | Apache License 2.0 | google/gvisor | Fix racy behavior in tcp Read().
The startRead and commitRead with RcvReadMu is not safe anymore with the
change to Close() that purges the read queue.
This may reduce performance of highly concurrent reads.
PiperOrigin-RevId: 452175522 |
259,868 | 31.05.2022 18:45:22 | 25,200 | b43a19fad0e480081cbc09b618c5150ef4dcc2c1 | BuildKite pre-command: Install kernel headers if available, install `kmod`. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "+# Download any build-specific configuration that has been uploaded.\n+# This allows top-level steps to override all subsequent steps.\n+buildkite-agent artifact download 'tool... | Go | Apache License 2.0 | google/gvisor | BuildKite pre-command: Install kernel headers if available, install `kmod`.
PiperOrigin-RevId: 452188918 |
259,868 | 31.05.2022 19:01:53 | 25,200 | a507abead7487757d30ba28d7dc61d24a6bd3419 | Run ARM64 smoke tests after AMD64, in parallel with the other tests.
This means only the AMD64 smoke tests block all other steps, which speeds up
builds as ARM64 agents are more often contended for. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -49,13 +49,12 @@ steps:\ncommand: make smoke-tests\nagents:\narch: \"amd64\"\n+ - wait\n- <<: *common\nlabel: \":fire: Smoke tests (ARM64)\"\ncommand: make smoke-tests\nagents:\narc... | Go | Apache License 2.0 | google/gvisor | Run ARM64 smoke tests after AMD64, in parallel with the other tests.
This means only the AMD64 smoke tests block all other steps, which speeds up
builds as ARM64 agents are more often contended for.
PiperOrigin-RevId: 452190945 |
259,891 | 01.06.2022 13:42:04 | 25,200 | a09c49b908d41ae49d90c5c30ea6c6acea7afc37 | netstack: conntrack skips bad packets
Conntrack, like Linux, now skips bad packets entirely and lets the appropriate
layer deal with them. See net/netfilter/nf_conntrack_core.c:nf_conntrack_in.
This change shares the bad packet detection code between conntrack and TCP/UDP
so that they see the same packets as bad. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/tcp.go",
"new_path": "pkg/tcpip/header/tcp.go",
"diff": "@@ -687,3 +687,23 @@ func Acceptable(segSeq seqnum.Value, segLen seqnum.Size, rcvNxt, rcvAcc seqnum.V\n// as Linux.\nreturn rcvNxt.LessThan(segSeq.Add(segLen)) && segSeq.LessThanEq(rcvAc... | Go | Apache License 2.0 | google/gvisor | netstack: conntrack skips bad packets
Conntrack, like Linux, now skips bad packets entirely and lets the appropriate
layer deal with them. See net/netfilter/nf_conntrack_core.c:nf_conntrack_in.
This change shares the bad packet detection code between conntrack and TCP/UDP
so that they see the same packets as bad.
PiperOrigin-RevId: 452374626 |
259,975 | 01.06.2022 16:25:50 | 25,200 | 9b751b88ed507d4efd1e89ed72cdc857f7d709b1 | [bugs] Refactor seccomp test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp_test.go",
"new_path": "pkg/seccomp/seccomp_test.go",
"diff": "@@ -965,44 +965,49 @@ func TestRandom(t *testing.T) {\n// that it doesn't die when the filter is not triggered.\nfunc TestRealDeal(t *testing.T) {\nfor _, test := range []struct ... | Go | Apache License 2.0 | google/gvisor | [bugs] Refactor seccomp test.
PiperOrigin-RevId: 452409930 |
259,992 | 03.06.2022 09:50:14 | 25,200 | 0968254ce715c0d8e6457558d55cb405a545ad2f | Speed up container_test
TestExePath doesn't need to run on all platforms, but it does need
to run with overlay enabled (it was doing the opposite).
TestExecProcList doesn't need to wait for `sleep 5` to finish
executing. Exec success is tested in TestExec and many other tests
already. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -394,8 +394,6 @@ func run(spec *specs.Spec, conf *config.Config) error {\nvar platforms = flag.String(\"test_platforms\", os.Getenv(\"TEST_PLATFORMS\"), \"Platform... | Go | Apache License 2.0 | google/gvisor | Speed up container_test
TestExePath doesn't need to run on all platforms, but it does need
to run with overlay enabled (it was doing the opposite).
TestExecProcList doesn't need to wait for `sleep 5` to finish
executing. Exec success is tested in TestExec and many other tests
already.
PiperOrigin-RevId: 452785343 |
259,992 | 03.06.2022 11:53:41 | 25,200 | d25fe0538ace4a188b4872508149127219c26e83 | Drain all messages before closing socket
Updates | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/server.cc",
"new_path": "examples/seccheck/server.cc",
"diff": "@@ -123,6 +123,19 @@ void unpack(absl::string_view buf) {\ncb(proto);\n}\n+bool readAndUnpack(int client) {\n+ std::array<char, maxEventSize> buf;\n+ int bytes = read(client, buf... | Go | Apache License 2.0 | google/gvisor | Drain all messages before closing socket
Updates #4805
PiperOrigin-RevId: 452812458 |
259,853 | 03.06.2022 13:00:02 | 25,200 | aaaa3429f7851a35e5db8f367eedbd53f8df082d | fs: use lockdep mutexes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/BUILD",
"new_path": "pkg/sentry/fs/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\n+load(\"//pkg/sync/locking:locking.bzl\", \"declare_mutex\")\npackage(l... | Go | Apache License 2.0 | google/gvisor | fs: use lockdep mutexes
PiperOrigin-RevId: 452826155 |
259,907 | 03.06.2022 14:46:16 | 25,200 | 501f43c16f1d3aa4b60e56c445a295af7925cd65 | Deflake TestProcfsDump.
The sleep process in the container may have other open FDs to
SO files. So just check for stdout, stderr, stdin. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/trace_test.go",
"new_path": "runsc/container/trace_test.go",
"diff": "@@ -370,11 +370,11 @@ func TestProcfsDump(t *testing.T) {\nt.Errorf(\"expected CWD %q, got %q\", spec.Process.Cwd, procfsDump[0].CWD)\n}\n- // Expect 3 host FDs for stdout, s... | Go | Apache License 2.0 | google/gvisor | Deflake TestProcfsDump.
The sleep process in the container may have other open FDs to
SO files. So just check for stdout, stderr, stdin.
PiperOrigin-RevId: 452847291 |
259,868 | 03.06.2022 17:01:28 | 25,200 | 4a0ab9caa8400ca682f1940ae9103641ae4381ba | Export `GVISOR_PLATFORM_SUPPORT` environment variable for tests.
This environment variable encodes what capabilities the platform
supports, and is consumed by `platform_util.cc` to determine
which syscall tests are appropriate to run. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/BUILD",
"new_path": "test/runner/BUILD",
"diff": "@@ -27,4 +27,5 @@ bzl_library(\nname = \"defs_bzl\",\nsrcs = [\"defs.bzl\"],\nvisibility = [\"//visibility:private\"],\n+ deps = [\"//tools:defs_bzl\"],\n)\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | Export `GVISOR_PLATFORM_SUPPORT` environment variable for tests.
This environment variable encodes what capabilities the platform
supports, and is consumed by `platform_util.cc` to determine
which syscall tests are appropriate to run.
PiperOrigin-RevId: 452870567 |
259,909 | 05.06.2022 19:08:14 | 25,200 | 7dbe1e6670860b7e4e2588c350adabee43bdf05c | Fix connect() not properly setting endpoint state.
If connect does not set the state to Connecting before taking over the binding
of another endpoint in TIME_WAIT, a race can happen where an segment is
processed without the endpoint having a proper state, causing a panic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -2162,73 +2162,11 @@ func (e *endpoint) Connect(addr tcpip.FullAddress) tcpip.Error {\nreturn err\n}\n-// connect connects the endpoint to its peer.\n+// regis... | Go | Apache License 2.0 | google/gvisor | Fix connect() not properly setting endpoint state.
If connect does not set the state to Connecting before taking over the binding
of another endpoint in TIME_WAIT, a race can happen where an segment is
processed without the endpoint having a proper state, causing a panic.
PiperOrigin-RevId: 453109764 |
259,992 | 06.06.2022 16:44:24 | 25,200 | a30c81cd802214ab5f08335e663c228a66e566c5 | Only check for systemd when needed | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -402,7 +402,7 @@ func new(pid, cgroupsPath string, useSystemd bool) (Cgroup, error) {\nOwn: make(map[string]bool),\n}\n}\n- log.Debugf(\"New cgroup for pid: %s, %+v\", pid, cg)\n+ log.D... | Go | Apache License 2.0 | google/gvisor | Only check for systemd when needed
PiperOrigin-RevId: 453311374 |
259,853 | 07.06.2022 14:08:11 | 25,200 | 2e0ff5d9d0455217fa9c0f1d38a07d44808a3821 | platform/kvm: Disable async preemption while mapping initial virtual regions.
All new mappings are handled from the SIGSYS signal handler and we have to
guarantee that the signal handler doesn't race with the code that handles
initial regions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -318,6 +318,10 @@ func newMachine(vm int) (*machine, error) {\n}\n}\n+ // handleBluepillFault takes the slot spinlock and it is called from\n+ // seccompMmapHand... | Go | Apache License 2.0 | google/gvisor | platform/kvm: Disable async preemption while mapping initial virtual regions.
All new mappings are handled from the SIGSYS signal handler and we have to
guarantee that the signal handler doesn't race with the code that handles
initial regions.
PiperOrigin-RevId: 453521202 |
259,868 | 07.06.2022 16:40:13 | 25,200 | 68ec24098221567237af9b5404e72f0ad7194f47 | Disable tests for platforms tagged with "internal". | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/platforms/BUILD",
"new_path": "runsc/boot/platforms/BUILD",
"diff": "@@ -22,6 +22,7 @@ exempt_go_library(\nlinux = [\n\"//pkg/sentry/platform/%s\" % platform\nfor platform in platforms\n+ if \"internal\" not in platforms[platform]\n],\n),\n)\n"
},... | Go | Apache License 2.0 | google/gvisor | Disable tests for platforms tagged with "internal".
PiperOrigin-RevId: 453554360 |
259,868 | 07.06.2022 20:48:51 | 25,200 | 8b5289e723b5174402947fc09a11a66a70d0e945 | BuildKite: Install runsc under a unique runtime name.
Without this, the runtime entry can get overwritten between
runs of different pipelines, potentially with different flags. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -28,13 +28,14 @@ export PARTITION=${BUILDKITE_PARALLEL_JOB:-0}\nPARTITION=$((${PARTITION}+1)) # 1-indexed, but PARALLEL_JOB is 0-indexed.\nexport TOTAL_PARTITIONS=${BUILDKIT... | Go | Apache License 2.0 | google/gvisor | BuildKite: Install runsc under a unique runtime name.
Without this, the runtime entry can get overwritten between
runs of different pipelines, potentially with different flags.
PiperOrigin-RevId: 453589305 |
260,009 | 08.06.2022 09:59:37 | 25,200 | 3290a054c5bd6d53e23c09b8e7041c11e5a2441c | getdents: Test that size parameter is not zero before allocating PMAs.
Trying to allocate PMAs with 0 length leads to panic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/getdents.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/getdents.go",
"diff": "@@ -36,10 +36,17 @@ func Getdents64(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sy\nreturn getdents(t, args, true /* isGetdents64 ... | Go | Apache License 2.0 | google/gvisor | getdents: Test that size parameter is not zero before allocating PMAs.
Trying to allocate PMAs with 0 length leads to panic.
PiperOrigin-RevId: 453704555 |
259,891 | 08.06.2022 15:00:48 | 25,200 | f78c23ffd6758374dfb78759db7a88a38ae8d216 | state: don't print the encoded object twice upon error
Sufficiently junky data can cause printing to take a *long* time. OSS-fuzz times
out entirely [1]. On my desktop it takes ~20s to run that test.
1 | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/decode.go",
"new_path": "pkg/state/decode.go",
"diff": "@@ -639,7 +639,7 @@ func (ds *decodeState) Load(obj reflect.Value) {\nods = nil\nencoded = nil\ndefault:\n- Failf(\"wanted type or object ID, got %#v\", encoded)\n+ Failf(\"wanted type or object... | Go | Apache License 2.0 | google/gvisor | state: don't print the encoded object twice upon error
Sufficiently junky data can cause printing to take a *long* time. OSS-fuzz times
out entirely [1]. On my desktop it takes ~20s to run that test.
1 - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45414&q=gvisor&can=2
PiperOrigin-RevId: 453774647 |
259,868 | 08.06.2022 18:00:05 | 25,200 | 75f0c9b05ec592a09d00675afb06c6d40c2da349 | Fix flakiness in `Processes::ExecSwapThreadGroupLeader`.
This closes the write end of the pipe earlier in the main test
body, and avoids allocations after fork+clone when building up
the `execve` array's flags.
There may be more obvious ways to do this, let me know :) | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -4469,6 +4469,7 @@ cc_binary(\n\"//test/util:test_util\",\n\"//test/util:thread_util\",\n\"@com_google_absl//absl/flags:flag\",\n+ \"@com_google_absl//absl/strings\",\n\"@com_goog... | Go | Apache License 2.0 | google/gvisor | Fix flakiness in `Processes::ExecSwapThreadGroupLeader`.
This closes the write end of the pipe earlier in the main test
body, and avoids allocations after fork+clone when building up
the `execve` array's flags.
There may be more obvious ways to do this, let me know :)
PiperOrigin-RevId: 453809395 |
259,853 | 08.06.2022 23:55:21 | 25,200 | c3a7b477f9f08ec04225fe561266a01646ceecc0 | tests: don't use raw threads
We have to use pthreads if we want to use other libc calls. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/processes.cc",
"new_path": "test/syscalls/linux/processes.cc",
"diff": "@@ -116,13 +116,12 @@ TEST(Processes, SetPGIDOfZombie) {\nEXPECT_EQ(status, 0);\n}\n-int WritePIDToPipe(void* arg) {\n- int* pipe_fds = reinterpret_cast<int*>(arg);\n+v... | Go | Apache License 2.0 | google/gvisor | tests: don't use raw threads
We have to use pthreads if we want to use other libc calls.
PiperOrigin-RevId: 453851326 |
259,868 | 09.06.2022 16:37:07 | 25,200 | cbbcf9344369862c924001bc5e48525e7a4ee854 | Add BuildKite pipeline filegroup. Make platforms_bzl more widely visible. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -63,6 +63,12 @@ yaml_test(\nschema = \"@github_workflow_schema//file\",\n)\n+filegroup(\n+ name = \"buildkite_pipelines\",\n+ srcs = glob([\".buildkite/*.yaml\"]),\n+ visibility = [\"//:sandbox\"],\n+)\n+\nyaml_test(\nn... | Go | Apache License 2.0 | google/gvisor | Add BuildKite pipeline filegroup. Make platforms_bzl more widely visible.
PiperOrigin-RevId: 454040412 |
259,868 | 10.06.2022 14:47:03 | 25,200 | 0df51fa5db5415ad487dc9879074ff5aff4427bf | `integration_test`: Ensure Docker has experimental features enabled.
This test relies on `docker checkpoint`, which requires experimental
features to be turned on in Docker. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/dockerutil.go",
"new_path": "pkg/test/dockerutil/dockerutil.go",
"diff": "@@ -26,6 +26,7 @@ import (\n\"os/exec\"\n\"regexp\"\n\"strconv\"\n+ \"strings\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/test/testutil\"\n@@ -62,6 +63,15 @@ var (\nuseSyste... | Go | Apache License 2.0 | google/gvisor | `integration_test`: Ensure Docker has experimental features enabled.
This test relies on `docker checkpoint`, which requires experimental
features to be turned on in Docker.
PiperOrigin-RevId: 454246068 |
259,868 | 10.06.2022 15:00:29 | 25,200 | 13fff26c601398cf95e104b29cf32e5fe67af531 | Test runner: Containerize host-networking syscall tests by default. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -71,6 +71,7 @@ def _syscall_test(\nadd_uds_tree = False,\nlisafs = False,\nfuse = False,\n+ container = None,\n**kwargs):\n# Prepend \"runsc\" to non-native platform names.\nfull_platform =... | Go | Apache License 2.0 | google/gvisor | Test runner: Containerize host-networking syscall tests by default.
PiperOrigin-RevId: 454248722 |
259,868 | 10.06.2022 15:08:18 | 25,200 | 16a5ced34f90d0e8dd71cf6b6609e81d1d8a37ec | Add `VSYSCALL` capability to platforms definitions.
This can be used to selectively disable tests where vsyscall
functionality is not expected to work on a per-platform basis. | [
{
"change_type": "MODIFY",
"old_path": "test/util/platform_util.cc",
"new_path": "test/util/platform_util.cc",
"diff": "@@ -97,5 +97,23 @@ PlatformSupport PlatformSupportInt3() {\nTEST_CHECK(false);\n}\n+PlatformSupport PlatformSupportVsyscall() {\n+ const char* support = std::getenv(\"GVISOR_PLATFO... | Go | Apache License 2.0 | google/gvisor | Add `VSYSCALL` capability to platforms definitions.
This can be used to selectively disable tests where vsyscall
functionality is not expected to work on a per-platform basis.
PiperOrigin-RevId: 454250385 |
259,868 | 10.06.2022 16:05:13 | 25,200 | 6294e603c6856bee9945bdad4f76b54cd633fafd | Disable `RetKillVsyscallCausesDeathBySIGSYS` if `VSYSCALL` isn't supported. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -2241,6 +2241,7 @@ cc_binary(\n\"//test/util:logging\",\n\"//test/util:memory_util\",\n\"//test/util:multiprocess_util\",\n+ \"//test/util:platform_util\",\n\"//test/util:posix_er... | Go | Apache License 2.0 | google/gvisor | Disable `RetKillVsyscallCausesDeathBySIGSYS` if `VSYSCALL` isn't supported.
PiperOrigin-RevId: 454260740 |
259,868 | 10.06.2022 16:35:53 | 25,200 | b7c0ac33c9bb06c9b78f8f6555f1399a72a1477a | Add `PRE_BAZEL_INIT` variable to run a command before Bazel server starts.
This is useful for initializing things that the Bazel server container
requires before starting in the first place. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "## DOCKER_RUN_OPTIONS - Options for the container (default: --privileged, required for tests).\n## DOCKER_NAME - The container name (default: gvisor-bazel-HASH).\n## DOCKER_PRIVILEGED - Docker privileged ... | Go | Apache License 2.0 | google/gvisor | Add `PRE_BAZEL_INIT` variable to run a command before Bazel server starts.
This is useful for initializing things that the Bazel server container
requires before starting in the first place.
PiperOrigin-RevId: 454265814 |
259,868 | 10.06.2022 17:27:56 | 25,200 | 382499139ef4de6d24bb1058d4fa3c8451fb8293 | BuildKite `pre-command`: Improve log signal-to-noise ratio.
This removes noise from the package installation process (boring and
noisy), and adds logging for the shell commands that run after that
(which are more interesting). | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -7,7 +7,7 @@ buildkite-agent artifact download 'tools/bazeldefs/*' . || true\nfunction install_pkgs() {\nexport DEBIAN_FRONTEND=noninteractive\nwhile true; do\n- if sudo -E ... | Go | Apache License 2.0 | google/gvisor | BuildKite `pre-command`: Improve log signal-to-noise ratio.
This removes noise from the package installation process (boring and
noisy), and adds logging for the shell commands that run after that
(which are more interesting).
PiperOrigin-RevId: 454273369 |
259,975 | 13.06.2022 10:48:51 | 25,200 | 0301bb07efabc1b6e441727814fce25cf8a847ca | [bugs] Don't hold root taskset mutex when starting kernel tasks.
Holding the kernel.taskSetRWMutex isn't necessary while calling t.Start() and
doing so can cause a nested locking error. We only need to make sure start is
called on each task once. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1122,11 +1122,18 @@ func (k *Kernel) Start() error {\n// Kernel.SaveTo and need to be resumed. If k was created by NewKernel,\n// this is a no-op.\nk.resumeTimeLocked(k.Super... | Go | Apache License 2.0 | google/gvisor | [bugs] Don't hold root taskset mutex when starting kernel tasks.
Holding the kernel.taskSetRWMutex isn't necessary while calling t.Start() and
doing so can cause a nested locking error. We only need to make sure start is
called on each task once.
PiperOrigin-RevId: 454648122 |
259,853 | 13.06.2022 15:02:23 | 25,200 | 5ffcc1f799e31eba3a95d7e2f251ee111656520c | Don't leak network namespaces | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"new_path": "pkg/sentry/fsimpl/testutil/kernel.go",
"diff": "@@ -147,6 +147,7 @@ func CreateTask(ctx context.Context, name string, tc *kernel.ThreadGroup, mntns\nFDTable: k.NewFDTable(),\nUserCounters: k.GetUserCounters(c... | Go | Apache License 2.0 | google/gvisor | Don't leak network namespaces
PiperOrigin-RevId: 454707336 |
259,885 | 13.06.2022 18:11:30 | 25,200 | 82498d087ef8fa85ba4537406522a500a7b92a26 | Don't hold MM.activeMu when calling MM.vmaMapsEntryLocked().
Cloned from CL by 'hg patch'. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/debug.go",
"new_path": "pkg/sentry/mm/debug.go",
"diff": "@@ -40,24 +40,22 @@ func (mm *MemoryManager) String() string {\n// DebugString returns a string containing information about mm for debugging.\nfunc (mm *MemoryManager) DebugString(ctx con... | Go | Apache License 2.0 | google/gvisor | Don't hold MM.activeMu when calling MM.vmaMapsEntryLocked().
Cloned from CL 446797388 by 'hg patch'.
PiperOrigin-RevId: 454742145 |
259,891 | 14.06.2022 11:58:26 | 25,200 | 758a425bbc2e40cf789c521024533574ca1770e5 | shrink DataTransferStressTest | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_generic_stress.cc",
"new_path": "test/syscalls/linux/socket_generic_stress.cc",
"diff": "@@ -193,9 +193,6 @@ INSTANTIATE_TEST_SUITE_P(\nusing DataTransferStressTest = SocketPairTest;\nTEST_P(DataTransferStressTest, BigDataTransfer) {... | Go | Apache License 2.0 | google/gvisor | shrink DataTransferStressTest
PiperOrigin-RevId: 454921228 |
260,004 | 14.06.2022 12:03:43 | 25,200 | ebadfe7702fe745bf451c5538be72eacfc7f397c | Allow IPv6 only stack to use UDP endpoints
Check if stack supports IPv4 before registering an IPv6 endpoint as
dual-stack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/datagram_test.go",
"new_path": "pkg/tcpip/transport/datagram_test.go",
"diff": "@@ -1016,7 +1016,7 @@ func TestIPv6PacketInfo(t *testing.T) {\nfor _, test := range tests {\nt.Run(test.name, func(t *testing.T) {\ns := stack.New(stack.Options... | Go | Apache License 2.0 | google/gvisor | Allow IPv6 only stack to use UDP endpoints
Check if stack supports IPv4 before registering an IPv6 endpoint as
dual-stack.
PiperOrigin-RevId: 454922614 |
259,853 | 14.06.2022 14:45:20 | 25,200 | 6e662d0262c7827ab6fff7373e563f2c1bab45a1 | buildkite: move "Build everything" upper in the list
It runs for a long time and so it would be good to run it
earlier. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -59,6 +59,13 @@ steps:\nlabel: \":fire: Smoke race tests\"\ncommand: make smoke-race-tests\n+ # Build everything.\n+ - <<: *common\n+ label: \":world_map: Build everything\"\n+ comm... | Go | Apache License 2.0 | google/gvisor | buildkite: move "Build everything" upper in the list
It runs for a long time and so it would be good to run it
earlier.
PiperOrigin-RevId: 454960320 |
259,891 | 14.06.2022 20:01:58 | 25,200 | c54948f3c1940071f1690651b533e22977481de4 | notify users of common reasons for failing to create a raw socket
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/log/BUILD",
"new_path": "pkg/log/BUILD",
"diff": "@@ -9,6 +9,7 @@ go_library(\n\"json.go\",\n\"json_k8s.go\",\n\"log.go\",\n+ \"rate_limited.go\",\n],\nmarshal = False,\nstateify = False,\n@@ -18,6 +19,7 @@ go_library(\ndeps = [\n\"//pkg/linewriter\",\n\"/... | Go | Apache License 2.0 | google/gvisor | notify users of common reasons for failing to create a raw socket
Fixes #199
PiperOrigin-RevId: 455018292 |
259,858 | 14.06.2022 21:20:35 | 25,200 | 1ff543e17ee355943abfba33be59ad771bb88095 | Handle cross-package global guards.
Updates | [
{
"change_type": "MODIFY",
"old_path": "tools/checklocks/analysis.go",
"new_path": "tools/checklocks/analysis.go",
"diff": "@@ -322,9 +322,17 @@ func (pc *passContext) checkFieldAccess(inst almostInst, structObj ssa.Value, fi\npc.checkGuards(inst, structObj, fieldObj, ls, isWrite)\n}\n+// noReferrer... | Go | Apache License 2.0 | google/gvisor | Handle cross-package global guards.
Updates #7721
PiperOrigin-RevId: 455029306 |
259,992 | 15.06.2022 13:37:13 | 25,200 | 6258291815e823034218fc617c3fc70978d7137b | Small fixes to trace points
Don't collect `cwd` when task root is not present anymore, e.g. zombie.
Limit the size allocated for address in `connect(2)`.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/seccheck.go",
"new_path": "pkg/sentry/kernel/seccheck.go",
"diff": "@@ -49,13 +49,15 @@ func LoadSeccheckDataLocked(t *Task, mask seccheck.FieldMask, info *pb.ContextDa\ninfo.ContainerId = t.tg.leader.ContainerID()\n}\nif mask.Contains(secche... | Go | Apache License 2.0 | google/gvisor | Small fixes to trace points
Don't collect `cwd` when task root is not present anymore, e.g. zombie.
Limit the size allocated for address in `connect(2)`.
Updates #4805
PiperOrigin-RevId: 455208465 |
259,992 | 15.06.2022 16:10:10 | 25,200 | b252543133681c44bccdabf682b3afc447fd4702 | Restrict checkers.remote visibility
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/checkers/remote/remote.go",
"new_path": "pkg/sentry/seccheck/checkers/remote/remote.go",
"diff": "@@ -36,26 +36,26 @@ import (\nfunc init() {\nseccheck.RegisterSink(seccheck.SinkDesc{\nName: \"remote\",\n- Setup: Setup,\n- New: New,\n+ Setu... | Go | Apache License 2.0 | google/gvisor | Restrict checkers.remote visibility
Updates #4805
PiperOrigin-RevId: 455242654 |
259,907 | 15.06.2022 19:04:50 | 25,200 | 8011b8d6d298cb9bbdd3656a6f0d9ba4c5b1f955 | Make anonfs return ENOTDIR for open(O_DIRECTORY) calls.
All anonfs dentries are non-directories. So all FilesystemImpl
methods that would require an anonDentry to be a directory should
return ENOTDIR. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/anonfs.go",
"new_path": "pkg/sentry/vfs/anonfs.go",
"diff": "@@ -100,7 +100,7 @@ func (fs *anonFilesystem) Sync(ctx context.Context) error {\n// AccessAt implements vfs.Filesystem.Impl.AccessAt.\nfunc (fs *anonFilesystem) AccessAt(ctx context.Co... | Go | Apache License 2.0 | google/gvisor | Make anonfs return ENOTDIR for open(O_DIRECTORY) calls.
All anonfs dentries are non-directories. So all FilesystemImpl
methods that would require an anonDentry to be a directory should
return ENOTDIR.
PiperOrigin-RevId: 455271653 |
259,858 | 16.06.2022 08:56:19 | 25,200 | 9dfa65ebdb74f35c3bfbdebf6ee87af6073733c0 | checklocks: make behavior configurable.
Defaults are the same, but certain behaviors can now be disabled to more easily
use the analyzer on its own. Now wrappers, lock inferrence and atomic default
analysis can be disabled. For example:
```
go vet -vettool=$HOME/go/bin/checklocks -wrappers=false -inferred=false -atomic=false ./...
```
Fixes | [
{
"change_type": "MODIFY",
"old_path": "tools/checklocks/analysis.go",
"new_path": "tools/checklocks/analysis.go",
"diff": "@@ -268,6 +268,10 @@ func (pc *passContext) checkGuards(inst almostInst, from ssa.Value, accessObj ty\npc.maybeFail(inst.Pos(), \"non-atomic write of field %s, writes must stil... | Go | Apache License 2.0 | google/gvisor | checklocks: make behavior configurable.
Defaults are the same, but certain behaviors can now be disabled to more easily
use the analyzer on its own. Now wrappers, lock inferrence and atomic default
analysis can be disabled. For example:
```
go vet -vettool=$HOME/go/bin/checklocks -wrappers=false -inferred=false -atomic=false ./...
```
Fixes #7721
PiperOrigin-RevId: 455393957 |
259,992 | 16.06.2022 10:02:36 | 25,200 | 5dc4c42f8f91f5b604bef187bb5e507739e04b12 | Add more trace point integration tests
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/trace/BUILD",
"new_path": "test/trace/BUILD",
"diff": "@@ -22,6 +22,7 @@ go_test(\n\"//pkg/test/testutil\",\n\"//test/trace/config\",\n\"@org_golang_google_protobuf//proto:go_default_library\",\n+ \"@org_golang_x_sys//unix:go_default_library\",\n],\n)\n"
... | Go | Apache License 2.0 | google/gvisor | Add more trace point integration tests
Updates #4805
PiperOrigin-RevId: 455408137 |
259,868 | 16.06.2022 10:36:04 | 25,200 | 72295623b015b0a73d02af0b39cba7d11b29b177 | `bazel.mk`: Set Docker hostnames for all containers.
This makes it easier to tell where each command is being run than a
random-generated string. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "## USER - The in-container user.\n## DOCKER_RUN_OPTIONS - Options for the container (default: --privileged, required for tests).\n## DOCKER_NAME - The container name (default: gvisor-bazel-HASH).\n+## DOC... | Go | Apache License 2.0 | google/gvisor | `bazel.mk`: Set Docker hostnames for all containers.
This makes it easier to tell where each command is being run than a
random-generated string.
PiperOrigin-RevId: 455416726 |
259,868 | 16.06.2022 10:43:42 | 25,200 | 1b604ce01053e0acae0138b7e345da50afe2007f | Pass on systemd-related files to Docker containers if present.
This allows control of the Docker container via `systemd` from
within the containers themselves. This is useful for tests that
require restarting Docker, e.g. after installing a new runtime
or enabling Docker's `experimental` mode. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -13,8 +13,8 @@ function install_pkgs() {\ndone\n}\ninstall_pkgs make linux-libc-dev graphviz jq curl binutils gnupg gnupg-agent \\\n- gcc pkg-config apt-transport-https ca-c... | Go | Apache License 2.0 | google/gvisor | Pass on systemd-related files to Docker containers if present.
This allows control of the Docker container via `systemd` from
within the containers themselves. This is useful for tests that
require restarting Docker, e.g. after installing a new runtime
or enabling Docker's `experimental` mode.
PiperOrigin-RevId: 455418499 |
259,909 | 16.06.2022 13:33:01 | 25,200 | 35227fb84fd0d9a35ece6d43834ce3099d3944fc | Add a panic that prints information about the sender before calling splitSeg.
Calling splitSeg with a negative value panics anyway, we need to know why. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -859,6 +859,13 @@ func (s *sender) maybeSendSegment(seg *segment, limit int, end seqnum.Value) (se\n}\nif seg.payloadSize() > available {\n+ // A negative value causes s... | Go | Apache License 2.0 | google/gvisor | Add a panic that prints information about the sender before calling splitSeg.
Calling splitSeg with a negative value panics anyway, we need to know why.
PiperOrigin-RevId: 455455562 |
259,985 | 16.06.2022 13:54:09 | 25,200 | d5a04e338eef531108e9f6266e67e09f63ae4155 | cgroupfs: Don't copy in with cgroups locks held.
CopyIn acquires mm.mappingMu, which is ordered before cgroups locks.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/pids.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/pids.go",
"diff": "@@ -268,9 +268,6 @@ func (d *pidsMaxData) Generate(ctx context.Context, buf *bytes.Buffer) error {\n// Write implements vfs.WritableDynamicBytesSource.Write.\nfunc ... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Don't copy in with cgroups locks held.
CopyIn acquires mm.mappingMu, which is ordered before cgroups locks.
Reported-by: syzbot+97a5960840a8aeb25e6a@syzkaller.appspotmail.com
PiperOrigin-RevId: 455460140 |
259,853 | 16.06.2022 15:20:40 | 25,200 | 9f7d89e7d96635215f3589c98813e42711f1ce5b | overlay: use lockdep mutexes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/BUILD",
"new_path": "pkg/sentry/fsimpl/overlay/BUILD",
"diff": "load(\"//tools:defs.bzl\", \"go_library\")\nload(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\n+load(\"//pkg/sync/locking:locking.bzl\", \"declare_mutex\",... | Go | Apache License 2.0 | google/gvisor | overlay: use lockdep mutexes
PiperOrigin-RevId: 455478722 |
259,941 | 17.06.2022 04:55:20 | -19,080 | 66a847a0c24874d9527355ce6c2bf8d1c5d32965 | m. refactor eliminate a redundant variable | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -555,17 +555,15 @@ func (e *endpoint) writePacket(pkt *stack.PacketBuffer) tcpip.Error {\nfunc (e *endpoint) sendBatch(batchFDInfo fdInfo, pkts []*stack.PacketBu... | Go | Apache License 2.0 | google/gvisor | m. refactor eliminate a redundant variable |
259,907 | 20.06.2022 18:38:53 | 25,200 | 9dfac31f0a577b0b9746b73594ecda5a7e328904 | Add O_DIRECTORY support to openat(O_PATH) in VFS2.
VFS2 earlier was ignoring the effect of O_DIRECTORY with O_PATH. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/opath.go",
"new_path": "pkg/sentry/vfs/opath.go",
"diff": "@@ -137,3 +137,32 @@ func (fd *opathFD) StatFS(ctx context.Context) (linux.Statfs, error) {\nrp.Release(ctx)\nreturn statfs, err\n}\n+\n+func (vfs *VirtualFilesystem) openOPathFD(ctx con... | Go | Apache License 2.0 | google/gvisor | Add O_DIRECTORY support to openat(O_PATH) in VFS2.
VFS2 earlier was ignoring the effect of O_DIRECTORY with O_PATH.
PiperOrigin-RevId: 456147699 |
259,992 | 21.06.2022 09:54:32 | 25,200 | 5deab709e7e8c1a98396bf09aabba73b88924c97 | Add mode to procfs dump
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/procfs/BUILD",
"new_path": "runsc/boot/procfs/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\"dump.go\"],\nvisibility = [\"//runsc:__subpackages__\"],\ndeps = [\n+ \"//pkg/abi/linux\",\n\"//pkg/context\",\n\"//pkg/log\",\n\"//pkg/sentry/fsim... | Go | Apache License 2.0 | google/gvisor | Add mode to procfs dump
Updates #4805
PiperOrigin-RevId: 456284312 |
259,992 | 21.06.2022 13:20:23 | 25,200 | ed38782b23dce6396c77be0868397bc696484396 | Remove omitempty for fields than can be 0
Some fields can have a legitimate value of 0 and that was
causing the field to be omitted from the output, giving the
impression that it hasn't been set.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_cgroup.go",
"new_path": "pkg/sentry/kernel/task_cgroup.go",
"diff": "@@ -180,7 +180,7 @@ func (t *Task) MigrateCgroup(dst Cgroup) error {\n// TaskCgroupEntry represents a line in /proc/<pid>/cgroup, and is used to\n// format a cgroup for... | Go | Apache License 2.0 | google/gvisor | Remove omitempty for fields than can be 0
Some fields can have a legitimate value of 0 and that was
causing the field to be omitted from the output, giving the
impression that it hasn't been set.
Updates #4805
PiperOrigin-RevId: 456335515 |
259,907 | 22.06.2022 10:17:32 | 25,200 | dadb72341a65b1f03691b46a099c0fc9b99d474e | Fix remaining comments to adhere to gofmt. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task_files.go",
"new_path": "pkg/sentry/fsimpl/proc/task_files.go",
"diff": "@@ -226,6 +226,7 @@ func GetMetadata(ctx context.Context, mm *mm.MemoryManager, buf *bytes.Buffer, t\n}\n// metadataData implements vfs.DynamicBytesSource for p... | Go | Apache License 2.0 | google/gvisor | Fix remaining comments to adhere to gofmt.
PiperOrigin-RevId: 456544446 |
259,868 | 22.06.2022 17:06:28 | 25,200 | 164ca68bcd5ff3065a8f79353a99a479fd066bc2 | gVisor BuildKite `pre-command`: Clean Docker `RUNTIME` to not contain slashes.
Slashes in Docker runtime names break Docker. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -31,7 +31,10 @@ PARTITION=$((${PARTITION}+1)) # 1-indexed, but PARALLEL_JOB is 0-indexed.\nexport TOTAL_PARTITIONS=${BUILDKITE_PARALLEL_JOB_COUNT:-1}\n# Set the system-wide ... | Go | Apache License 2.0 | google/gvisor | gVisor BuildKite `pre-command`: Clean Docker `RUNTIME` to not contain slashes.
Slashes in Docker runtime names break Docker.
PiperOrigin-RevId: 456642822 |
259,868 | 23.06.2022 12:31:07 | 25,200 | 55776eca5f7bc13e22bc1e32cb5dfaa3bd822592 | integration_test: Make `TestTmpMountWithSize` error message less confusing.
If I understand correctly, this test expects the second write to fail, but
if it succeeds, the error message it shows suggests that it should have
failed.
This CL rewords this message to reflect that.
#codehealth | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/integration_test.go",
"new_path": "test/e2e/integration_test.go",
"diff": "@@ -944,7 +944,7 @@ func TestTmpMountWithSize(t *testing.T) {\n}\nechoOutput, err := d.Exec(ctx, dockerutil.ExecOpts{}, \"/bin/sh\", \"-c\", \"echo world > /tmp/foo/test2.txt\"... | Go | Apache License 2.0 | google/gvisor | integration_test: Make `TestTmpMountWithSize` error message less confusing.
If I understand correctly, this test expects the second write to fail, but
if it succeeds, the error message it shows suggests that it should have
failed.
This CL rewords this message to reflect that.
#codehealth
PiperOrigin-RevId: 456835892 |
259,907 | 23.06.2022 13:31:44 | 25,200 | c1111baf6cc0d9ad845be8e8de240e836ada5ffa | Allow strace logs for symlinkat(2) to print FD.
Helps with debugging issues that involve symlinkat(2). FD also
prints the path file that the FD backs which is helpful. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64_amd64.go",
"new_path": "pkg/sentry/strace/linux64_amd64.go",
"diff": "@@ -291,7 +291,7 @@ var linuxAMD64 = SyscallMap{\n263: makeSyscallInfo(\"unlinkat\", FD, Path, Hex),\n264: makeSyscallInfo(\"renameat\", FD, Path, Hex, Path),\n265:... | Go | Apache License 2.0 | google/gvisor | Allow strace logs for symlinkat(2) to print FD.
Helps with debugging issues that involve symlinkat(2). FD also
prints the path file that the FD backs which is helpful.
PiperOrigin-RevId: 456849268 |
259,868 | 23.06.2022 16:21:38 | 25,200 | cf533616cb27a03bd75522d35a12eb0ab2e3abe9 | BuildKite pre-command: Use alternate way to reload Docker when available. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -36,7 +36,15 @@ export TOTAL_PARTITIONS=${BUILDKITE_PARALLEL_JOB_COUNT:-1}\nexport RUNTIME=\"buildkite_runtime_${BUILDKITE_BRANCH}-${BUILDKITE_BUILD_ID}\"\nexport RUNTIME=\"... | Go | Apache License 2.0 | google/gvisor | BuildKite pre-command: Use alternate way to reload Docker when available.
PiperOrigin-RevId: 456884864 |
259,868 | 23.06.2022 17:12:20 | 25,200 | bd90c6b241ce53d31173c9689a8c37f44ae85216 | Makefile: Set `RUNTIME_DIR` actually work the way it is documented.
Prior to this, setting `RUNTIME_DIR` had no effect, as the Makefile always
clobbered it. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -94,7 +94,7 @@ endif\n## These targets faciliate local development by automatically\n## installing and configuring a runtime. Several variables may\n## be used here to tweak the installation:\n-## RUNTIME - The na... | Go | Apache License 2.0 | google/gvisor | Makefile: Set `RUNTIME_DIR` actually work the way it is documented.
Prior to this, setting `RUNTIME_DIR` had no effect, as the Makefile always
clobbered it.
PiperOrigin-RevId: 456893921 |
259,868 | 23.06.2022 17:46:34 | 25,200 | ffabadf0108addafd94f3429b3998a84d89b6c58 | BuildKite: Install runtime using `STAGED_BINARIES`, clean it up properly.
Prior to this, `STAGED_BINARIES` was executed as a command
(`$(STAGED_BINARIES)`), which didn't work. This change fixes this, and adds
cleanup of the runtime directory in `post-command`. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "+set -x\n+\n# Clear any downloaded credentials.\nrm -f repo.key\n@@ -71,3 +73,18 @@ for container in $(docker ps -q); do\ndocker container kill \"${container}\"\nfi\ndone\n+\... | Go | Apache License 2.0 | google/gvisor | BuildKite: Install runtime using `STAGED_BINARIES`, clean it up properly.
Prior to this, `STAGED_BINARIES` was executed as a command
(`$(STAGED_BINARIES)`), which didn't work. This change fixes this, and adds
cleanup of the runtime directory in `post-command`.
PiperOrigin-RevId: 456900530 |
259,909 | 24.06.2022 13:46:42 | 25,200 | efdc289a96e5bae0b5a28d705b86a711f8458d04 | Add nil receiver and io methods to bufferv2.
Allowing for nil receivers in read-like operations lets views be treated
more like slices, which is easier for the programmer generally.
io methods are useful for copy operations to avoid unnecessary allocations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bufferv2/buffer.go",
"new_path": "pkg/bufferv2/buffer.go",
"diff": "@@ -294,13 +294,13 @@ func (b *Buffer) prependOwned(v *View) {\n}\n// PullUp makes the specified range contiguous and returns the backing memory.\n-func (b *Buffer) PullUp(offset, length i... | Go | Apache License 2.0 | google/gvisor | Add nil receiver and io methods to bufferv2.
Allowing for nil receivers in read-like operations lets views be treated
more like slices, which is easier for the programmer generally.
io methods are useful for copy operations to avoid unnecessary allocations.
PiperOrigin-RevId: 457086370 |
259,909 | 27.06.2022 15:50:38 | 25,200 | 953d8d129b894a5886e9761cee2361b12d8e88e0 | Create configuration flags to control buffer pooling. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bufferv2/BUILD",
"new_path": "pkg/bufferv2/BUILD",
"diff": "@@ -6,7 +6,7 @@ package(licenses = [\"notice\"])\ngo_template_instance(\nname = \"chunk_refs\",\nout = \"chunk_refs.go\",\n- package = \"buffer\",\n+ package = \"bufferv2\",\nprefix = \"chunk\",\n... | Go | Apache License 2.0 | google/gvisor | Create configuration flags to control buffer pooling.
PiperOrigin-RevId: 457584626 |
259,891 | 27.06.2022 16:38:08 | 25,200 | 94126dd4aa4db6954884681ec1ef6a3483f578b2 | Limit the number of open files per sandbox
Fixes | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -266,8 +266,11 @@ INTEGRATION_TARGETS := //test/image:image_test //test/e2e:integration_test\ndocker-tests: load-basic $(RUNTIME_BIN)\n@$(call install_runtime,$(RUNTIME),) # Clear flags.\n+ # Used by TestRlimitNoF... | Go | Apache License 2.0 | google/gvisor | Limit the number of open files per sandbox
Fixes #6547.
PiperOrigin-RevId: 457594490 |
259,868 | 27.06.2022 18:12:36 | 25,200 | 7cba29ca3bf12f15b505d1b1b5bdda6e87cd5ca0 | gVisor Makefile: Add `--cgroupns=host` only when supported by Docker.
Docker doesn't support the `--cgroupns` option until API version 1.41.
This change prevents the addition of the `--cgroupns=host` option
(which is only necessary for `cgroup_test` to pass, not necessary
for any build) unless Docker supports it. | [
{
"change_type": "MODIFY",
"old_path": "tools/bazel.mk",
"new_path": "tools/bazel.mk",
"diff": "@@ -161,6 +161,21 @@ ifneq ($(DEVICE_FILE),)\nDOCKER_RUN_OPTIONS += --device \"$(DEVICE_FILE):$(DEVICE_FILE)\"\nendif\n+# Check if Docker API version supports cgroupns (supported in >=1.41).\n+# If not, d... | Go | Apache License 2.0 | google/gvisor | gVisor Makefile: Add `--cgroupns=host` only when supported by Docker.
Docker doesn't support the `--cgroupns` option until API version 1.41.
This change prevents the addition of the `--cgroupns=host` option
(which is only necessary for `cgroup_test` to pass, not necessary
for any build) unless Docker supports it.
PiperOrigin-RevId: 457612257 |
259,891 | 28.06.2022 10:54:36 | 25,200 | 7b50d94cc8b2063ed8b16c0de99d009bf181bb12 | factor out gofer dirent cache
This will enable simpler tuning of cache size in child CL. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1918,7 +1918,6 @@ func (fs *filesystem) MountOptions() string {\n{moptDfltGID, fs.opts.dfltgid},\n{moptMsize, fs.opts.msize},\n{moptVersion, fs.opts.versi... | Go | Apache License 2.0 | google/gvisor | factor out gofer dirent cache
This will enable simpler tuning of cache size in child CL.
PiperOrigin-RevId: 457771698 |
259,891 | 28.06.2022 18:55:27 | 25,200 | 2b97d38657de0e04a4a50473c4b704f9b5765a41 | make gofer directory cache size configurable
Passing --dcache=N causes all gofer mounts to use a global dirent cache of size
N. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -268,10 +268,12 @@ docker-tests: load-basic $(RUNTIME_BIN)\n@$(call install_runtime,$(RUNTIME),) # Clear flags.\n# Used by TestRlimitNoFile.\n@$(call install_runtime,$(RUNTIME)-fdlimit,--fdlimit=2000)\n- @$(call t... | Go | Apache License 2.0 | google/gvisor | make gofer directory cache size configurable
Passing --dcache=N causes all gofer mounts to use a global dirent cache of size
N.
PiperOrigin-RevId: 457867503 |
259,907 | 29.06.2022 22:38:08 | 25,200 | 0c3abacb1c8cf11b914eb6be46dacaff0a993ebf | Limit the lisafs buffer that are printed with strace.
Otherwise, in case case read request asks for a lot of bytes but
response contains fewer bytes, we end up printing a lot of
garbage. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/message.go",
"new_path": "pkg/lisafs/message.go",
"diff": "@@ -880,7 +880,8 @@ func (r *PReadResp) CheckedUnmarshal(src []byte) ([]byte, bool) {\n// We expect the client to have already allocated r.Buf. r.Buf probably\n// (optimally) points to userm... | Go | Apache License 2.0 | google/gvisor | Limit the lisafs buffer that are printed with strace.
Otherwise, in case case read request asks for a lot of bytes but
response contains fewer bytes, we end up printing a lot of
garbage.
PiperOrigin-RevId: 458140547 |
259,891 | 30.06.2022 11:55:27 | 25,200 | 1eb2c3659db2088a6e71aecebff1b3810471980b | rename GSO: hardware->host and software->gVisor
API names such as flags and Makefile targets are unchanged so as not to break
users. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -209,7 +209,7 @@ steps:\narch: \"amd64\"\nos: \"ubuntu\"\n- <<: *common\n- label: \":satellite: SWGSO tests\"\n+ label: \":satellite: gVisor GSO tests\"\ncommand: make swgso-tests\n... | Go | Apache License 2.0 | google/gvisor | rename GSO: hardware->host and software->gVisor
API names such as flags and Makefile targets are unchanged so as not to break
users.
PiperOrigin-RevId: 458279776 |
259,941 | 01.07.2022 01:44:38 | -19,080 | 143f134d7ee86c95717df94e96d6f518c39b6e53 | fdbased: error is specifically tcpip.Error | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -556,7 +556,7 @@ func (e *endpoint) sendBatch(batchFDInfo fdInfo, pkts []*stack.PacketBuffer) (in\n// Degrade to writePacket if underlying fd is not a socket.\ni... | Go | Apache License 2.0 | google/gvisor | fdbased: error is specifically tcpip.Error |
259,982 | 01.07.2022 12:56:51 | 25,200 | 81414d79c38c590f507669d491dcd67693be784c | Fixing accept/accept4 and pipe syscall values.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/points.go",
"new_path": "pkg/sentry/syscalls/linux/points.go",
"diff": "@@ -402,7 +402,7 @@ func pipeHelper(t *kernel.Task, cxtData *pb.ContextData, info kernel.SyscallInfo\nif info.Exit {\nif pipeFDAddr := info.Args[0].Pointer(); pip... | Go | Apache License 2.0 | google/gvisor | Fixing accept/accept4 and pipe syscall values.
Updates #4805
PiperOrigin-RevId: 458527328 |
259,896 | 06.07.2022 10:46:33 | 25,200 | 5b70da95255ebecca3a53fa3b3ab4dd9c7c53eb2 | Add a new control message for destroying sandbox in multi-container mode.
Adds SandboxShutdown() control message to destroy sandbox manually.
Adds a new gVisor API for destroying the sandbox in multi container mode.
Test to verify the API and the control message works correctly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/lifecycle.go",
"new_path": "pkg/sentry/control/lifecycle.go",
"diff": "@@ -35,16 +35,13 @@ type Lifecycle struct {\n// Kernel is the kernel where the tasks belong to.\nKernel *kernel.Kernel\n- // StartedCh is the channel used to send a messa... | Go | Apache License 2.0 | google/gvisor | Add a new control message for destroying sandbox in multi-container mode.
- Adds SandboxShutdown() control message to destroy sandbox manually.
- Adds a new gVisor API for destroying the sandbox in multi container mode.
- Test to verify the API and the control message works correctly.
PiperOrigin-RevId: 459290099 |
259,868 | 06.07.2022 12:12:44 | 25,200 | 1b60c51687643202e60267a3e9609f6fe9a7e4f4 | Makefile: Don't overwrite `RUNTIME`-related variables if they are already set.
Without this, setting `RUNTIME` in the environment has no effect. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -105,14 +105,14 @@ endif\n## DOCKER_RELOAD_COMMAND - The command to run to reload Docker. (default: sudo systemctl reload docker).\nifeq (,$(BRANCH_NAME))\n-RUNTIME := runsc\n+RUNTIME ?= runsc\nelse\n-RUNTIME := $... | Go | Apache License 2.0 | google/gvisor | Makefile: Don't overwrite `RUNTIME`-related variables if they are already set.
Without this, setting `RUNTIME` in the environment has no effect.
PiperOrigin-RevId: 459311928 |
259,896 | 06.07.2022 13:48:55 | 25,200 | d101b6b184ee22170cc2e49532328952243108db | Multi-Container: Add GetExitStatus() control message to get the exit status.
Adds a new control message GetExitStatus() which blocks until the container
has finished execution and returns the exit status.
Tests to verify that the GetExitStatus() works correctly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/lifecycle.go",
"new_path": "pkg/sentry/control/lifecycle.go",
"diff": "@@ -45,6 +45,10 @@ type Lifecycle struct {\n// MountNamespacesMap is a map of container id/names and the mount\n// namespaces.\nMountNamespacesMap map[string]*vfs.MountNa... | Go | Apache License 2.0 | google/gvisor | Multi-Container: Add GetExitStatus() control message to get the exit status.
- Adds a new control message GetExitStatus() which blocks until the container
has finished execution and returns the exit status.
- Tests to verify that the GetExitStatus() works correctly.
PiperOrigin-RevId: 459333916 |
259,982 | 07.07.2022 14:07:20 | 25,200 | c8e98d9f5ea9e7d229ab49ab3f4c5d764a7f4eca | Add Points to some syscalls
Added a raw syscall points to all syscalls. Added schematized syscall
points to the following syscalls:
- timerfd_create
- timerfd_settime
- timerfd_gettime
- fork, vfork
- inotify_init, inotify_init1
- inotify_add_watch
- inotify_rm_watch
- socketpair
Updates | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/server.cc",
"new_path": "examples/seccheck/server.cc",
"diff": "@@ -105,6 +105,14 @@ std::vector<Callback> dispatchers = {\nunpackSyscall<::gvisor::syscall::Clone>,\nunpackSyscall<::gvisor::syscall::Bind>,\nunpackSyscall<::gvisor::syscall::Ac... | Go | Apache License 2.0 | google/gvisor | Add Points to some syscalls
Added a raw syscall points to all syscalls. Added schematized syscall
points to the following syscalls:
- timerfd_create
- timerfd_settime
- timerfd_gettime
- fork, vfork
- inotify_init, inotify_init1
- inotify_add_watch
- inotify_rm_watch
- socketpair
Updates #4805
PiperOrigin-RevId: 459596784 |
259,978 | 07.07.2022 18:54:12 | 25,200 | 7103ddb238dc8ed75d8d24ce1aae5bd36fc61bd8 | Add checklocks to addressable_endpoint_state.go
Added checklocks annotations to `addressable_endpoint_state.go`.
Refactored slightly to appease the analyzer. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/addressable_endpoint_state.go",
"new_path": "pkg/tcpip/stack/addressable_endpoint_state.go",
"diff": "@@ -31,13 +31,12 @@ type AddressableEndpointState struct {\n//\n// AddressableEndpointState.mu\n// addressState.mu\n- mu struct {\n- sync.RWMu... | Go | Apache License 2.0 | google/gvisor | Add checklocks to addressable_endpoint_state.go
Added checklocks annotations to `addressable_endpoint_state.go`.
Refactored slightly to appease the analyzer.
PiperOrigin-RevId: 459651242 |
259,909 | 11.07.2022 08:54:28 | 25,200 | 3aa77e9f0a2f1e758a5926dad7e1a63938be36f4 | Enforce a minimum Send MSS.
Without this enforcement, options larger than the specified MSS can cause
MaxPayloadSize to go negative and cause all sorts of problems. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/tcp.go",
"new_path": "pkg/tcpip/header/tcp.go",
"diff": "@@ -222,6 +222,10 @@ const (\n// same as the value TCP_MIN_MSS defined net/tcp.h.\nTCPMinimumMSS = IPv4MaximumHeaderSize + TCPHeaderMaximumSize + MinIPFragmentPayloadSize - IPv4MinimumSi... | Go | Apache License 2.0 | google/gvisor | Enforce a minimum Send MSS.
Without this enforcement, options larger than the specified MSS can cause
MaxPayloadSize to go negative and cause all sorts of problems.
PiperOrigin-RevId: 460224034 |
259,909 | 11.07.2022 10:11:32 | 25,200 | d217b5c69fba5f213d1f19b894f1950c16e492d6 | Refine Buffer io methods to utilize pooled views. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bufferv2/buffer.go",
"new_path": "pkg/bufferv2/buffer.go",
"diff": "@@ -452,124 +452,117 @@ func (b *Buffer) Merge(other *Buffer) {\nother.size = 0\n}\n-// WriteFromReader writes to the buffer from an io.Reader.\n-//\n-// A minimum read size equal to unsaf... | Go | Apache License 2.0 | google/gvisor | Refine Buffer io methods to utilize pooled views.
PiperOrigin-RevId: 460241285 |
259,977 | 12.07.2022 19:33:44 | 25,200 | 69219fa35e0b37cd70020dcb6607be26e15a2995 | Log unknown network protocol numbers | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/sniffer.go",
"new_path": "pkg/tcpip/link/sniffer/sniffer.go",
"diff": "@@ -244,7 +244,7 @@ func logPacket(prefix string, dir direction, protocol tcpip.NetworkProtocolNumbe\n)\nreturn\ndefault:\n- log.Infof(\"%s%s unknown network protocol... | Go | Apache License 2.0 | google/gvisor | Log unknown network protocol numbers
PiperOrigin-RevId: 460608202 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.