repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
BloopAI/vibe-kanban
3,388
issue_to_patch
Replace README hiring banner with sunsetting notice (Vibe Kanban)
## Summary This PR updates the top banner in README.md to communicate that Vibe Kanban is sunsetting and links readers to the shutdown announcement. ## What Changed - Replaced the existing centered hiring banner near the top of the README - Added a centered sunsetting notice instead - Linked the notice to the shutdown...
97123d5262091deca5e4eba7167164e21329db36
a188c247eadd9f8144a054f3aa2faa9b5fef25d6
diff --git a/README.md b/README.md index 02e143e5015..32c6ed4ccd4 100644 --- a/README.md +++ b/README.md @@ -16,7 +16,8 @@ </p> <h1 align="center"> - <a href="https://jobs.polymer.co/vibe-kanban?source=github"><strong>We're hiring!</strong></a> + <strong>Vibe Kanban is sunsetting.</strong> + <a href="https://www...
[ "README.md" ]
[]
true
BloopAI/vibe-kanban
3,387
issue_to_patch
Sunset project routes to an export-only page (Vibe Kanban)
## Summary This PR sunsets the local project page and replaces the interactive Kanban experience with an export-only shutdown screen. ## What Changed - Added a new `ProjectSunsetPage` that explains project functionality has been retired and gives users a direct `Export data` CTA plus a link to the shutdown page. - Upd...
c768ce21e28807c4a7c7665244538a6af08c2e3c
5e049aabd677a1246e815b2d9129245e1baa6832
diff --git a/packages/web-core/src/pages/kanban/LocalProjectKanban.tsx b/packages/web-core/src/pages/kanban/LocalProjectKanban.tsx index 22aa42112a4..47afe5597b3 100644 --- a/packages/web-core/src/pages/kanban/LocalProjectKanban.tsx +++ b/packages/web-core/src/pages/kanban/LocalProjectKanban.tsx @@ -1,30 +1,5 @@ -impor...
[ "packages/web-core/src/pages/kanban/LocalProjectKanban.tsx", "packages/web-core/src/pages/kanban/ProjectKanban.tsx", "packages/web-core/src/pages/kanban/ProjectSunsetPage.tsx" ]
[ { "comment": "### Dead issue composer code left after kanban removal\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `issueComposerKey` memo, `previousIssueComposerKeyRef`, and the `useEffect` that calls `closeKanbanIssueComposer` are now dead code. Since the kanban board has been replaced by `ProjectSun...
true
BloopAI/vibe-kanban
3,385
issue_to_patch
Bump Codex to 0.124.0 and refresh the Codex executor surface (Vibe Kanban)
## Summary This PR updates Vibe Kanban's Codex integration to the latest stable Codex release line and refreshes the in-app Codex metadata to match the current product surface more closely. ## What changed - Bumped the pinned Codex Rust protocol dependencies from `rust-v0.121.0` to `rust-v0.124.0` in `crates/executo...
c395623fb3c418894dc8282931f0c1f85534ca7c
a2dddd4c6cb1e6e3d08337a5e858be2d5d92979a
diff --git a/Cargo.lock b/Cargo.lock index 97452dac772..ee04e8a8040 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1257,13 +1257,12 @@ checksum = "e9b18233253483ce2f65329a24072ec414db782531bdbb7d0bbc4bd2ce6b7e21" [[package]] name = "codex-app-server-protocol" -version = "0.121.0" -source = "git+https://github.com/ope...
[ "Cargo.lock", "crates/executors/Cargo.toml", "crates/executors/src/executors/codex.rs", "crates/executors/src/executors/codex/normalize_logs.rs", "crates/executors/src/executors/codex/slash_commands.rs", "docs/workspaces/slash-commands.mdx" ]
[]
true
BloopAI/vibe-kanban
3,384
issue_to_patch
Bump Claude Code CLI pin to 2.1.119 (Vibe Kanban)
## Summary - Update the Claude executor to use `@anthropic-ai/claude-code@2.1.119` instead of `2.1.112`. ## What Changed - Updated the hardcoded non-router Claude base command in `crates/executors/src/executors/claude.rs`. - Left the `claude-code-router` command unchanged. - Kept executor behavior, flags, permissions,...
c2bea4011c5f5ee4fb125b9e8d7a2dc5d27cb75a
1d75d7f9c6303f5e2e29f604299c397d29afc2d4
diff --git a/crates/executors/src/executors/claude.rs b/crates/executors/src/executors/claude.rs index 685a894215b..4eb401338c9 100644 --- a/crates/executors/src/executors/claude.rs +++ b/crates/executors/src/executors/claude.rs @@ -62,7 +62,7 @@ fn base_command(claude_code_router: bool) -> &'static str { if claud...
[ "crates/executors/src/executors/claude.rs" ]
[]
true
BloopAI/vibe-kanban
3,370
issue_to_patch
Pre-register execution log stores before streaming normalized logs (Vibe Kanban)
## Summary This PR fixes a startup race in `/api/execution-processes/.../normalized-logs/ws` where connecting immediately after creating an execution could return only `{"finished":true}` even though logs appeared later. ## What changed - Pre-register a live `MsgStore` immediately after the execution process row is cr...
4c0a6657adb33f3f019af81b36c97e75171553cb
33ce0f04689eeed8eb7111618d4b21236b5da755
diff --git a/crates/local-deployment/src/container.rs b/crates/local-deployment/src/container.rs index d3fe28c7234..47d87152e80 100644 --- a/crates/local-deployment/src/container.rs +++ b/crates/local-deployment/src/container.rs @@ -854,9 +854,15 @@ impl LocalContainerService { format!("{}-{}", short_uuid(work...
[ "crates/local-deployment/src/container.rs", "crates/services/src/services/container.rs", "crates/tauri-app/gen/schemas/acl-manifests.json", "crates/tauri-app/gen/schemas/desktop-schema.json", "crates/tauri-app/gen/schemas/macOS-schema.json" ]
[ { "comment": "### Normalization error path orphans running child process\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nWhen `get_msg_store_by_id` returns `None` during normalization setup, the error path returns without killing the already-running child process or marking the execution as failed in the ...
true
BloopAI/vibe-kanban
3,367
issue_to_patch
fix: scope vendored openssl to linux to unbreak windows-msvc cross-compile (Vibe Kanban)
## What changed Moved the `openssl = { version = "0.10", features = ["vendored"] }` dependency in `crates/executors/Cargo.toml` from `[dependencies]` (all targets) into a `[target.'cfg(target_os = "linux")'.dependencies]` block (Linux only). ## Why The pre-release run at https://github.com/BloopAI/vibe-kanban/action...
d737b600ad66e3197fd1c72470f696b700886d2f
c47c9c321f8ee67e3b11d8ea4caf15fa7919e6fd
diff --git a/crates/executors/Cargo.toml b/crates/executors/Cargo.toml index 6734208929c..bbb93fb2b83 100644 --- a/crates/executors/Cargo.toml +++ b/crates/executors/Cargo.toml @@ -41,10 +41,6 @@ codex-app-server-protocol = { git = "https://github.com/openai/codex.git", packa sha2 = "0.10" derivative = "2.2.0" reqwe...
[ "crates/executors/Cargo.toml" ]
[]
true
BloopAI/vibe-kanban
3,366
issue_to_patch
fix: vendor openssl to unblock musl + windows-msvc cross-compile (Vibe Kanban)
## What changed Added `openssl = { version = "0.10", features = ["vendored"] }` to `crates/executors/Cargo.toml`, plus the resulting `Cargo.lock` update. ## Why The pre-release workflow (run [#24560633908](https://github.com/BloopAI/vibe-kanban/actions/runs/24560633908)) started failing on all backend cross-compile ...
4b0581b92afab9ec8ade2f990903348fdc3fff7f
8c70dc5fa877d9af9b973db8f965184ba7244c56
diff --git a/Cargo.lock b/Cargo.lock index 47a0e857b40..a9bd42cceb4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2806,6 +2806,7 @@ dependencies = [ "json-patch 2.0.0", "jsonc-parser", "lru 0.12.5", + "openssl", "os_pipe", "rand 0.8.5", "regex", @@ -6024,6 +6025,15 @@ version = "0.2.1" source = "registry+ht...
[ "Cargo.lock", "crates/executors/Cargo.toml" ]
[]
true
BloopAI/vibe-kanban
3,365
issue_to_patch
chore: bump Claude Code to 2.1.112 and add xhigh effort variant (Vibe Kanban)
`vibe-kanban/crates/executors/src/executors/claude.rs` <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Medium risk because it updates the underlying `claude-code` CLI version and changes default/preset resolution behavior (new `xhigh` effort and model fallback), which can alter executor behavior without exp...
4ac5f06914dc3e9460df8c361cfb11da41bf8d11
4c9b80a5211e9b873512c44e5c31efeff479091d
diff --git a/crates/executors/src/executors/claude.rs b/crates/executors/src/executors/claude.rs index 5b97c9c0551..685a894215b 100644 --- a/crates/executors/src/executors/claude.rs +++ b/crates/executors/src/executors/claude.rs @@ -62,7 +62,7 @@ fn base_command(claude_code_router: bool) -> &'static str { if claud...
[ "crates/executors/src/executors/claude.rs", "packages/web-core/src/shared/hooks/useExecutorConfig.ts", "shared/schemas/claude_code.json", "shared/types.ts" ]
[ { "comment": "### Preset model_id fallback breaks reasoning_id persistence from lastUsed\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe new `model_id` fallback to `\"opus\"` in `get_preset_options` breaks the `reasoning_id` model-matching logic in `useEffectiveOverrides`. `OVERRIDE_FIELDS` processes ...
true
BloopAI/vibe-kanban
3,364
issue_to_patch
Bump pinned opencode-ai executor version to 1.4.7 (Vibe Kanban)
## Summary - Bump the pinned `opencode-ai` version used by the OpenCode executor from `1.2.27` to `1.4.7` in `crates/executors/src/executors/opencode.rs`. ## Why - The task for this branch was to update the OpenCode executor to a newer published `opencode-ai` release. - This keeps the executor aligned with the current...
b83a342f25ff4100e6d122e6cf65fdc7f784db40
8101e77202aceb20629d8cbaccbf14ebb0bac63d
diff --git a/crates/executors/src/executors/opencode.rs b/crates/executors/src/executors/opencode.rs index 364519e5f13..9d33b582438 100644 --- a/crates/executors/src/executors/opencode.rs +++ b/crates/executors/src/executors/opencode.rs @@ -89,7 +89,7 @@ type ServerPassword = String; impl Opencode { fn build_co...
[ "crates/executors/src/executors/opencode.rs", "crates/executors/src/executors/opencode/normalize_logs.rs", "crates/executors/src/executors/opencode/types.rs" ]
[ { "comment": "### Unnecessary validation causes spurious \"Unrecognized event\" messages\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `parse_session_updated_event` validation checks that `sessionID` exists as a string in the event properties, but the `SessionUpdated` variant carries no data and is ...
true
BloopAI/vibe-kanban
3,363
issue_to_patch
Bump Codex executor to 0.121.0 (Vibe Kanban)
## Summary This PR bumps the Codex executor integration from `0.116.0` to `0.121.0` and updates the related Rust protocol dependencies to the matching `rust-v0.121.0` release line. ## What Changed - Updated the Codex CLI invocation in `crates/executors/src/executors/codex.rs` from `@openai/codex@0.116.0` to `@openai/c...
b83a342f25ff4100e6d122e6cf65fdc7f784db40
664b44aaae249118ebebe226b38705d13028a7a5
diff --git a/Cargo.lock b/Cargo.lock index e63d75885ac..47a0e857b40 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -100,6 +100,7 @@ checksum = "5a15f179cd60c4584b8a8c596927aadc462e27f2ca70c04e0071964a73ba7a75" dependencies = [ "cfg-if", "const-random", + "getrandom 0.3.4", "once_cell", "version_check", "zerocop...
[ "Cargo.lock", "crates/executors/Cargo.toml", "crates/executors/src/executors/codex.rs", "crates/executors/src/executors/codex/client.rs", "crates/executors/src/executors/codex/normalize_logs.rs" ]
[ { "comment": "### MCP status silently loses resource/template information\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nSetting `detail` to `McpServerStatusDetail::ToolsAndAuthOnly` likely filters the response to only include tools and auth status. The consumer in `format_mcp_status` still tries to disp...
true
BloopAI/vibe-kanban
3,301
issue_to_patch
fix: Docker build fails due to missing patches/ directory in fe-builder stage ## Problem The Docker build fails in the `fe-builder` stage when running `pnpm install --frozen-lockfile` because the `patches/` directory is not copied into the build context. ``` ENOENT ENOENT: no such file or directory, open '/repo/pat...
fix: copy patches/ directory in Dockerfile fe-builder stage
Fixes #3300 ## Summary - Add `COPY patches/ patches/` before `pnpm install` in the `fe-builder` stage of `crates/remote/Dockerfile` - Without this, pnpm fails with `ENOENT` when trying to apply `@pierre__diffs@1.1.4.patch` during `pnpm install --frozen-lockfile` ## Test plan - [ ] Run `docker compose --env-file ../.....
abe62af2ba655a6a370b26411521fe2d7fde2116
a39e53b764e28f3fb31052960bfe211d9928d8c3
diff --git a/crates/remote/Dockerfile b/crates/remote/Dockerfile index c0c547f15cd..b61d6bf789b 100644 --- a/crates/remote/Dockerfile +++ b/crates/remote/Dockerfile @@ -19,6 +19,7 @@ COPY packages/local-web/package.json packages/local-web/package.json COPY packages/remote-web/package.json packages/remote-web/package.j...
[ "crates/remote/Dockerfile" ]
[]
true
BloopAI/vibe-kanban
3,336
issue_to_patch
ci: replace Blacksmith runners with GitHub runners
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > CI-only change, but it modifies the pre-release build/release pipeline and multi-platform build matrix, which could impact release reliability and build performance. > > **Overview** > Switches the `pre-release.yml` workflow jobs (version bump, frontend/backend bui...
576fd3e75ece8f248b8e43b5a49c55a95b97489d
81d0e6e2845b9e958c94075613a1fb425497a541
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml index 2a87d45a842..b8399c57650 100644 --- a/.github/workflows/pre-release.yml +++ b/.github/workflows/pre-release.yml @@ -31,7 +31,7 @@ env: jobs: bump-version: - runs-on: blacksmith-4vcpu-ubuntu-2404 + runs-on: ubuntu-24.04 ...
[ ".github/workflows/pre-release.yml", ".github/workflows/test.yml" ]
[]
true
BloopAI/vibe-kanban
3,345
issue_to_patch
Pin npm publish workflow to Node 22.22.1 (Vibe Kanban)
## Summary This PR updates the npm publish workflow to pin the publish job to Node `22.22.1` instead of the floating `22` release line. ## What changed - Updated `.github/workflows/publish.yml` to set `NODE_VERSION: 22.22.1` - Added an inline comment documenting the failure mode and why the patch version is pinned - P...
38aa35fee93cbe0a5a5242fe5f667aecc9e92dc6
281525781e57fb6c1d2966cede594e4eec5d76fa
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c85a14b2fcf..9df1f30329c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -22,7 +22,10 @@ permissions: id-token: write # Required for OIDC trusted publishing env: - NODE_VERSION: 22 + # Node 22.22....
[ ".github/workflows/publish.yml" ]
[]
true
BloopAI/vibe-kanban
3,344
issue_to_patch
feat: export
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Adds a new authenticated `/v1/export` endpoint that queries and packages org data (optionally downloading attachments) into a ZIP, which can impact performance and data exposure if access checks are wrong. Also removes legacy migration and several billing seat-limit...
576fd3e75ece8f248b8e43b5a49c55a95b97489d
9b23d5ee270497923126db515af8c09e599c4fd4
diff --git a/crates/api-types/src/export.rs b/crates/api-types/src/export.rs new file mode 100644 index 00000000000..48d923cddf6 --- /dev/null +++ b/crates/api-types/src/export.rs @@ -0,0 +1,11 @@ +use serde::{Deserialize, Serialize}; +use ts_rs::TS; +use uuid::Uuid; + +#[derive(Debug, Clone, Serialize, Deserialize, TS...
[ "crates/api-types/src/export.rs", "crates/api-types/src/lib.rs", "crates/api-types/src/migration.rs", "crates/db/.sqlx/query-0a805c219c9028b2677bd94ccabd47916e60d26c1cede27e467f0ae91f6639ab.json", "crates/db/.sqlx/query-0f90844fc62261ed140e02515ae464b940743113814507313c9fdc176000d1bf.json", "crates/db/.sq...
[ { "comment": "### Slug no longer lowercased, breaking case-sensitive uniqueness\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `.to_lowercase()` call was removed from slug processing, so slugs are now stored with their original casing. The database lookup in `find_organization_by_slug` uses `WHERE sl...
true
BloopAI/vibe-kanban
3,318
issue_to_patch
fix: reap execution process groups on natural exit (Vibe Kanban)
## What changed - Added a new `reap_execution(exec_id)` cleanup path in `LocalContainerService` that centralizes per-execution teardown. - Replaced duplicated cleanup logic in both the exit-monitor finalization path and `stop_execution` with `reap_execution`. - Updated natural-exit handling to ensure process-group clea...
c9d7445531bc0d8bd7cfd67a3fef184efafeb0e6
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/local-deployment/src/container.rs b/crates/local-deployment/src/container.rs index 05af5ef575b..d3fe28c7234 100644 --- a/crates/local-deployment/src/container.rs +++ b/crates/local-deployment/src/container.rs @@ -801,7 +801,13 @@ impl LocalContainerService { let _ = tokio::time::tim...
[ "crates/local-deployment/src/container.rs", "crates/utils/src/process.rs" ]
[ { "comment": "### Redundant full kill adds unnecessary delay in exit signal path\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nIn the exit signal branch of `spawn_exit_monitor`, `command::kill_process_group` is called directly (line 535), which performs a full signal escalation (SIGINT→2s sleep→SIGTERM→2s ...
true
BloopAI/vibe-kanban
3,318
comment_to_fix
fix: reap execution process groups on natural exit (Vibe Kanban)
### Redundant full kill adds unnecessary delay in exit signal path **Low Severity** <!-- DESCRIPTION START --> In the exit signal branch of `spawn_exit_monitor`, `command::kill_process_group` is called directly (line 535), which performs a full signal escalation (SIGINT→2s sleep→SIGTERM→2s sleep→SIGKILL→2s sleep) plu...
c9d7445531bc0d8bd7cfd67a3fef184efafeb0e6
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/local-deployment/src/container.rs b/crates/local-deployment/src/container.rs index 05af5ef575b..d3fe28c7234 100644 --- a/crates/local-deployment/src/container.rs +++ b/crates/local-deployment/src/container.rs @@ -801,7 +801,13 @@ impl LocalContainerService { let _ = tokio::time::tim...
[ "crates/local-deployment/src/container.rs" ]
[ { "comment": "### Redundant full kill adds unnecessary delay in exit signal path\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nIn the exit signal branch of `spawn_exit_monitor`, `command::kill_process_group` is called directly (line 535), which performs a full signal escalation (SIGINT→2s sleep→SIGTERM→2s ...
true
BloopAI/vibe-kanban
3,318
comment_to_fix
fix: reap execution process groups on natural exit (Vibe Kanban)
### Signal escalation loop skipped when group leader already exited **Medium Severity** <!-- DESCRIPTION START --> Moving the `child.try_wait()` check to *before* signal sending means the entire escalation loop (SIGINT → SIGTERM → SIGKILL) is skipped when the group leader has already exited. Since `try_wait()` checks...
c9d7445531bc0d8bd7cfd67a3fef184efafeb0e6
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/utils/src/process.rs b/crates/utils/src/process.rs index 2f43acb5516..32cb82418b0 100644 --- a/crates/utils/src/process.rs +++ b/crates/utils/src/process.rs @@ -1,36 +1,26 @@ use command_group::AsyncGroupChild; #[cfg(unix)] -use nix::{ - sys::signal::{Signal, killpg}, - unistd::{Pid, getpgid...
[ "crates/utils/src/process.rs" ]
[ { "comment": "### Signal escalation loop skipped when group leader already exited\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nMoving the `child.try_wait()` check to *before* signal sending means the entire escalation loop (SIGINT → SIGTERM → SIGKILL) is skipped when the group leader has already exited...
true
BloopAI/vibe-kanban
3,318
comment_to_fix
fix: reap execution process groups on natural exit (Vibe Kanban)
### Wrong error kind check prevents early loop exit **Medium Severity** <!-- DESCRIPTION START --> The `ErrorKind::NotFound` check on the error from `child.signal()` never matches the actual error. When `killpg()` fails because the process group no longer exists, the underlying errno is `ESRCH`, which Rust's standard...
c9d7445531bc0d8bd7cfd67a3fef184efafeb0e6
4f63f215f7e1cd74ea461fac52d23b06353f1914
diff --git a/crates/utils/src/process.rs b/crates/utils/src/process.rs index 2f43acb5516..32cb82418b0 100644 --- a/crates/utils/src/process.rs +++ b/crates/utils/src/process.rs @@ -1,36 +1,26 @@ use command_group::AsyncGroupChild; #[cfg(unix)] -use nix::{ - sys::signal::{Signal, killpg}, - unistd::{Pid, getpgid...
[ "crates/utils/src/process.rs" ]
[ { "comment": "### Wrong error kind check prevents early loop exit\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `ErrorKind::NotFound` check on the error from `child.signal()` never matches the actual error. When `killpg()` fails because the process group no longer exists, the underlying errno is `ES...
true
BloopAI/vibe-kanban
3,319
issue_to_patch
Align workspace session invalidation with host-scoped query keys (Vibe Kanban)
## What changed - Added a shared `workspaceSessionKeys` helper to define the React Query key for workspace sessions in one place. - Updated `useWorkspaceSessions` to use that shared key, including host request scope and workspace id. - Updated all workspace-session invalidation sites to use the same shared key: - `us...
2a4840061150c8bb08c529157bb8ea3efaa55725
34bb7a7daee9f24eb01e618b01ff3ec913fbd2a6
diff --git a/packages/web-core/src/features/workspace-chat/model/hooks/useCreateSession.ts b/packages/web-core/src/features/workspace-chat/model/hooks/useCreateSession.ts index 1ea689e905f..f97a4a23d63 100644 --- a/packages/web-core/src/features/workspace-chat/model/hooks/useCreateSession.ts +++ b/packages/web-core/src...
[ "packages/web-core/src/features/workspace-chat/model/hooks/useCreateSession.ts", "packages/web-core/src/features/workspace-chat/ui/SessionChatBoxContainer.tsx", "packages/web-core/src/shared/dialogs/command-bar/StartReviewDialog.tsx", "packages/web-core/src/shared/dialogs/tasks/ResolveConflictsDialog.tsx", ...
[]
true
BloopAI/vibe-kanban
3,314
issue_to_patch
fix: revert execution processes from Zustand store to React Context to fix conversation history leakage (Vibe Kanban)
## Summary - Reverts `ExecutionProcessesProvider` from Zustand store (introduced in 06a6ae18b) back to React Context for synchronous data propagation - Deletes `useExecutionProcessesStore.ts` and restores `useExecutionProcessesContext.ts` - Updates all 6 consumers to read from context instead of Zustand atomic selecto...
75f84626e5bcfd7525082b4f33e8c42ee7a37d70
dd7ec72819852495ed3ff64503a07e163efc47c9
diff --git a/packages/web-core/src/features/workspace-chat/model/contexts/RetryUiContext.tsx b/packages/web-core/src/features/workspace-chat/model/contexts/RetryUiContext.tsx index 3dea8ef821c..b9bd929234e 100644 --- a/packages/web-core/src/features/workspace-chat/model/contexts/RetryUiContext.tsx +++ b/packages/web-co...
[ "packages/web-core/src/features/workspace-chat/model/contexts/RetryUiContext.tsx", "packages/web-core/src/features/workspace-chat/model/hooks/useConversationHistory.ts", "packages/web-core/src/features/workspace-chat/model/hooks/useResetProcess.ts", "packages/web-core/src/pages/workspaces/ProcessListContainer...
[]
true
BloopAI/vibe-kanban
3,311
issue_to_patch
fix: prevent stale loadedInitialEntries guard from blocking conversation history load
## Summary Fixes conversation history not loading when switching between workspaces. The user would see "Send a message to start the conversation" instead of actual history, requiring a page reload to fix. ## Root Cause Commit `06a6ae18b` migrated `ExecutionProcessesProvider` from React Context to a Zustand store. T...
1c319f06246c88b23a35c43032403384134cabb0
85d1c58be51b85a2678fcf70a000d794ea90532e
diff --git a/packages/web-core/src/features/workspace-chat/model/hooks/useConversationHistory.ts b/packages/web-core/src/features/workspace-chat/model/hooks/useConversationHistory.ts index dee2d6f939f..a7c89265005 100644 --- a/packages/web-core/src/features/workspace-chat/model/hooks/useConversationHistory.ts +++ b/pac...
[ "packages/web-core/src/features/workspace-chat/model/hooks/useConversationHistory.ts" ]
[]
true
BloopAI/vibe-kanban
3,309
issue_to_patch
fix: use portable worker bundle to fix diff tab in prod builds (#3307)
## Summary - Fix diff tab showing empty page in production builds while working fine in dev - Switch `@pierre/diffs` worker from `worker.js` to `worker-portable.js` (pre-bundled variant) ## Root Cause The `worker.js` entry from `@pierre/diffs` contains bare module specifiers (`shiki/core`, `shiki/engine/javascript`,...
3ae515839af6d85a18ee5f05f71a43e38d1a0e05
f32a46e1b1e7f659066e53c3961b8fc3596ab1b4
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index 21c03941354..3e3f345697f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[]
true
BloopAI/vibe-kanban
3,307
issue_to_patch
Emit git-style diff headers in concatenate_diff_hunks to prevent parser crashes (Vibe Kanban)
## What changed - Updated `concatenate_diff_hunks` in `crates/utils/src/diff.rs` to prepend a `diff --git a/<path> b/<path>` header before the existing `---` / `+++` unified diff file headers. - Expanded the function documentation to explicitly describe the git-diff output format and parser behavior expectations. - Kep...
f6ca6a5ce50e6fd3273a82d285f199af5d29faa2
b14b05b7f9a67a55e03ebf72929f775f5d543a91
diff --git a/crates/utils/src/diff.rs b/crates/utils/src/diff.rs index b735abb2f16..f40796e6e67 100644 --- a/crates/utils/src/diff.rs +++ b/crates/utils/src/diff.rs @@ -190,11 +190,16 @@ fn fix_hunk_headers(hunks: Vec<String>) -> Vec<String> { new_hunks } -/// Creates a full unified diff with the file path in t...
[ "crates/utils/src/diff.rs" ]
[]
true
BloopAI/vibe-kanban
3,305
issue_to_patch
ci: temporarily disable Windows code signing in pre-release (Vibe Kanban)
## Summary - Temporarily comments out the Windows code signing steps in the pre-release workflow (Setup Jsign, Install JRE, Azure CLI login, Sign Windows artifacts) - Windows builds and artifact collection are unaffected — only signing is disabled ## Why Azure Trusted Signing is returning persistent `403 Forbidden` ...
13adc09df086db6daff3a4192dd255423753cafb
0e5d071d5aebda913b1af1fc128473508e1b3e98
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml index 11a1f6369df..2a87d45a842 100644 --- a/.github/workflows/pre-release.yml +++ b/.github/workflows/pre-release.yml @@ -925,50 +925,51 @@ jobs: --target ${{ matrix.target }} \ --version ${{ needs.bump-version....
[ ".github/workflows/pre-release.yml", "AGENTS.md" ]
[ { "comment": "### Windows code signing accidentally disabled in unrelated PR\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe entire Windows code signing pipeline (Jsign setup, JRE install, Azure login, artifact signing) is commented out in a PR whose stated purpose is investigating a default sound chang...
true
BloopAI/vibe-kanban
3,217
issue_to_patch
Add notification click handling for Windows, macOS, and Linux (Vibe Kanban)
## Summary When a user clicks an OS notification, the app now opens and navigates to the relevant workspace page. This works across all three desktop platforms. ### Problem `tauri-plugin-notification` v2 has no desktop click handling — click callbacks are mobile-only. Previously, clicking a notification did nothing (...
40223b4163a619b26bc9c9c1ae20f39680170a0a
07b42a2300b3491ff6c20c706fea5b3ba84a0a5c
diff --git a/Cargo.lock b/Cargo.lock index 3a9d4e460aa..0e2a1b4a2d4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -33,7 +33,7 @@ version = "0.5.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d122413f284cf2d62fb1b7db97e02edb8cda96d769b16e443a4f6195e35662b0" dependencies = [ - "crypto-co...
[ "Cargo.lock", "crates/server-info/Cargo.toml", "crates/tauri-app/Cargo.toml", "crates/tauri-app/src/linux_notifications.rs", "crates/tauri-app/src/macos_notifications.rs", "crates/tauri-app/src/main.rs", "crates/tauri-app/src/windows_notifications.rs", "packages/local-web/src/app/hooks/useTauriNotific...
[ { "comment": "### Updater endpoint placeholder replaced, breaking production auto-updates\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe updater endpoint was changed from the `__TAURI_UPDATE_ENDPOINT__` placeholder to `https://localhost/disabled`. The CI workflow in `pre-release.yml` (line 852) replace...
true
BloopAI/vibe-kanban
3,217
comment_to_fix
Add notification click handling for Windows, macOS, and Linux (Vibe Kanban)
### macOS notification click won't focus window without deeplinkPath **Medium Severity** <!-- DESCRIPTION START --> On macOS, the window `show()`/`set_focus()` logic is nested inside the `if let Some(value) = deeplink` block. When a notification has no `deeplinkPath` in its `userInfo` (e.g., `workspace_id` is `None`)...
40223b4163a619b26bc9c9c1ae20f39680170a0a
07b42a2300b3491ff6c20c706fea5b3ba84a0a5c
diff --git a/crates/tauri-app/src/macos_notifications.rs b/crates/tauri-app/src/macos_notifications.rs new file mode 100644 index 00000000000..b439c7de225 --- /dev/null +++ b/crates/tauri-app/src/macos_notifications.rs @@ -0,0 +1,232 @@ +//! macOS-native notification system using `UNUserNotificationCenter`. +//! +//! B...
[ "crates/tauri-app/src/macos_notifications.rs" ]
[ { "comment": "### macOS notification click won't focus window without deeplinkPath\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nOn macOS, the window `show()`/`set_focus()` logic is nested inside the `if let Some(value) = deeplink` block. When a notification has no `deeplinkPath` in its `userInfo` (e.g....
true
BloopAI/vibe-kanban
3,299
issue_to_patch
feat: add "Hide blocked" filter toggle to kanban board (Vibe Kanban)
## Summary - Adds a **"Hide blocked"** toggle to the kanban filter dialog that hides issues blocked by unresolved blocking relationships - Issues are considered blocked when they have a `blocking` relationship where the blocking issue is not yet in a "done" status (hidden statuses + last visible kanban column) - The f...
abe62af2ba655a6a370b26411521fe2d7fde2116
95dafa61d4fabfdf7d6949efbc422060e0895b36
diff --git a/crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json b/crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json deleted file mode 100644 index d089f210423..00000000000 --- a/crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eef...
[ "crates/db/.sqlx/query-04e5a05c7cad438d39c4c8590410889ab1eefa7376d474a10c119d3f4d9143c7.json", "crates/db/.sqlx/query-0ac0d0f3826330836e3fd1bf57c42777eb489ac41a650f9361e6b563fc69bf35.json", "crates/db/.sqlx/query-29cc3aa8d0ad5deda94494402500a4125e29381d63f18ef083cc4da95e2c5db5.json", "crates/db/.sqlx/query-33...
[ { "comment": "### Blocking filter scans all relationships per issue without lookup map\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `hideBlocked` filter iterates over the entire `issueRelationships` array for every issue in `result`, giving O(n×m) complexity. The existing assignee and tag filters both...
true
BloopAI/vibe-kanban
3,202
issue_to_patch
fix: load non-localhost preview URLs directly in iframe
## Summary - When the preview URL is not a loopback address (e.g. Coder port-forwarded URLs like `https://4000--workspace.coder.example.com`), load it directly in the iframe instead of routing through the subdomain-based preview proxy - The subdomain proxy (`http://{port}.localhost:{proxyPort}`) only works when VK run...
85ee7072260e240656863be1f1372b77b9fd3986
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
[ "packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx" ]
[ { "comment": "### URL bar submit constructs wrong URL for non-localhost\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `handleUrlSubmit` callback wasn't updated to handle non-localhost URLs introduced by this PR. When a user is viewing a Coder-hosted preview and submits a same-origin URL via the URL ...
true
BloopAI/vibe-kanban
3,202
comment_to_fix
fix: load non-localhost preview URLs directly in iframe
### URL bar submit constructs wrong URL for non-localhost **Medium Severity** <!-- DESCRIPTION START --> The `handleUrlSubmit` callback wasn't updated to handle non-localhost URLs introduced by this PR. When a user is viewing a Coder-hosted preview and submits a same-origin URL via the URL bar, both `devPort` and `cu...
85ee7072260e240656863be1f1372b77b9fd3986
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
[ "packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx" ]
[ { "comment": "### URL bar submit constructs wrong URL for non-localhost\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `handleUrlSubmit` callback wasn't updated to handle non-localhost URLs introduced by this PR. When a user is viewing a Coder-hosted preview and submits a same-origin URL via the URL ...
true
BloopAI/vibe-kanban
3,202
comment_to_fix
fix: load non-localhost preview URLs directly in iframe
### URL submission silently dropped when proxy port unavailable **Medium Severity** <!-- DESCRIPTION START --> When `isLoopbackPreview` is true but `previewProxyPort` is not yet available, the `if`/`else if` at lines 732–744 matches neither branch, but the unconditional `return` at line 745 still fires. This silently...
85ee7072260e240656863be1f1372b77b9fd3986
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
[ "packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx" ]
[ { "comment": "### URL submission silently dropped when proxy port unavailable\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nWhen `isLoopbackPreview` is true but `previewProxyPort` is not yet available, the `if`/`else if` at lines 732–744 matches neither branch, but the unconditional `return` at line 745...
true
BloopAI/vibe-kanban
3,202
comment_to_fix
fix: load non-localhost preview URLs directly in iframe
### Non-loopback URL bar navigation silently fails via bridge **High Severity** <!-- DESCRIPTION START --> For non-loopback previews, `bridgeRef.current?.navigateTo(directUrl)` relies on the devtools script (`devtools_script.js`) being present in the iframe to receive the `postMessage`. However, this script is only i...
85ee7072260e240656863be1f1372b77b9fd3986
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
[ "packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx" ]
[ { "comment": "### Non-loopback URL bar navigation silently fails via bridge\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nFor non-loopback previews, `bridgeRef.current?.navigateTo(directUrl)` relies on the devtools script (`devtools_script.js`) being present in the iframe to receive the `postMessage`. How...
true
BloopAI/vibe-kanban
3,202
comment_to_fix
fix: load non-localhost preview URLs directly in iframe
### IPv6 loopback `[::1]` missing from loopback address check **Low Severity** <!-- DESCRIPTION START --> The `isLoopbackPreview` check lists `localhost`, `127.0.0.1`, and `0.0.0.0` but omits the IPv6 loopback address `[::1]`. The Rust proxy's `is_loopback_redirect_host` in `preview-proxy/src/lib.rs` includes `::1`. ...
85ee7072260e240656863be1f1372b77b9fd3986
b83039993d8c0185ac67b30b6363ce3c2f96b204
diff --git a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx b/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx index cf0ed825c59..9bc3273f5e6 100644 --- a/packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx +++ b/packages/web-core/src/pages/workspaces/PreviewBrowserC...
[ "packages/web-core/src/pages/workspaces/PreviewBrowserContainer.tsx" ]
[ { "comment": "### IPv6 loopback `[::1]` missing from loopback address check\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `isLoopbackPreview` check lists `localhost`, `127.0.0.1`, and `0.0.0.0` but omits the IPv6 loopback address `[::1]`. The Rust proxy's `is_loopback_redirect_host` in `preview-proxy/s...
true
BloopAI/vibe-kanban
3,256
issue_to_patch
server: surface nested git and worktree container errors
## Summary - reuse the existing git service to API error mapping through a helper - surface nested `ContainerError::GitServiceError` failures as concrete git errors - surface nested worktree failures, including `WorktreeError::GitService(...)`, instead of flattening them to a generic internal error ## Why When an exis...
d9a2c4f906261dfb50e4a0a5c8ade1f99991bea6
89658cd3818a301d6cb2a0edbd9e1e9f31b3e985
diff --git a/crates/server/src/error.rs b/crates/server/src/error.rs index e734190f449..b026d074f21 100644 --- a/crates/server/src/error.rs +++ b/crates/server/src/error.rs @@ -51,13 +51,13 @@ pub enum ApiError { #[error(transparent)] Deployment(#[from] DeploymentError), #[error(transparent)] - Contai...
[ "crates/server/src/error.rs" ]
[ { "comment": "### Inconsistent handling of `WorktreeError::GitService` across code paths\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`WorktreeError::GitService` errors arriving through `ContainerError::Worktree` are now surfaced with detailed git error information via `git_service_error`, but the same er...
true
BloopAI/vibe-kanban
3,256
comment_to_fix
server: surface nested git and worktree container errors
### Inconsistent handling of `WorktreeError::GitService` across code paths **Low Severity** <!-- DESCRIPTION START --> `WorktreeError::GitService` errors arriving through `ContainerError::Worktree` are now surfaced with detailed git error information via `git_service_error`, but the same error type arriving through `...
d9a2c4f906261dfb50e4a0a5c8ade1f99991bea6
89658cd3818a301d6cb2a0edbd9e1e9f31b3e985
diff --git a/crates/server/src/error.rs b/crates/server/src/error.rs index e734190f449..b026d074f21 100644 --- a/crates/server/src/error.rs +++ b/crates/server/src/error.rs @@ -51,13 +51,13 @@ pub enum ApiError { #[error(transparent)] Deployment(#[from] DeploymentError), #[error(transparent)] - Contai...
[ "crates/server/src/error.rs" ]
[ { "comment": "### Inconsistent handling of `WorktreeError::GitService` across code paths\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`WorktreeError::GitService` errors arriving through `ContainerError::Worktree` are now surfaced with detailed git error information via `git_service_error`, but the same er...
true
BloopAI/vibe-kanban
3,283
issue_to_patch
Fix connection failed when viewing logs in Tauri app (Vibe Kanban)
## Summary Fixes persistent "Connection failed" errors in the logs panel and fix script dialog, particularly when: - A coding agent finishes running (live logs replaced by error) - Viewing logs for any already-completed process (always shows error) ## Root Cause Three compounding issues caused the logs panel to show...
f1c3cfa13315e421442397239b397a77d4e85da8
bea0ad443bb15636843351f6ffc829df2681bcfd
diff --git a/crates/server/src/routes/execution_processes.rs b/crates/server/src/routes/execution_processes.rs index ab698ce5d6c..425d0694264 100644 --- a/crates/server/src/routes/execution_processes.rs +++ b/crates/server/src/routes/execution_processes.rs @@ -7,7 +7,7 @@ use axum::{ routing::{get, post}, }; use...
[ "crates/server/src/routes/execution_processes.rs", "packages/web-core/src/shared/components/VirtualizedProcessLogs.tsx", "packages/web-core/src/shared/hooks/useJsonPatchWsStream.ts", "packages/web-core/src/shared/hooks/useLogStream.ts" ]
[ { "comment": "### Error never shown because `dataRef.current` is always truthy\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe condition `!dataRef.current && retryAttemptsRef.current > 6` is always false, so the \"Connection failed\" error is never displayed. `dataRef.current` is initialized to `initi...
true
BloopAI/vibe-kanban
3,281
issue_to_patch
fix: make live diff stream accurate and self-correcting
Eliminates stale/incorrect diff stats in the session chat box during live changes. - efficient periodic reconciliation (5s) to self-correct drift - atomic full diff state reset - debounced resets (1s) on HEAD changes (checkout/rebase) - avoid full reset on common commit operations <!-- CURSOR_SUMMARY --> --- > ...
37190901b6396261e6283667d48b91d619f74d64
ece9c26abd00a9282f00f95e8d66b71f601b9c88
diff --git a/crates/executors/src/logs/utils/patch.rs b/crates/executors/src/logs/utils/patch.rs index f19317007a1..2ee3471a9a7 100644 --- a/crates/executors/src/logs/utils/patch.rs +++ b/crates/executors/src/logs/utils/patch.rs @@ -1,4 +1,7 @@ -use std::{collections::HashSet, sync::Arc}; +use std::{ + collections::...
[ "crates/executors/src/logs/utils/patch.rs", "crates/git/src/lib.rs", "crates/services/src/services/diff_stream.rs", "packages/web-core/src/shared/hooks/useDiffStream.ts" ]
[ { "comment": "### Consecutive commits trigger unnecessary full resets\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`handle_git_state_change` doesn't update `last_head_commit` when it identifies a simple commit (fast path). A second commit arriving before the 5-second reconcile cycle will fail the `is_chil...
true
BloopAI/vibe-kanban
3,281
comment_to_fix
fix: make live diff stream accurate and self-correcting
### Consecutive commits trigger unnecessary full resets **Low Severity** <!-- DESCRIPTION START --> `handle_git_state_change` doesn't update `last_head_commit` when it identifies a simple commit (fast path). A second commit arriving before the 5-second reconcile cycle will fail the `is_child_of_current_head` check (s...
37190901b6396261e6283667d48b91d619f74d64
ece9c26abd00a9282f00f95e8d66b71f601b9c88
diff --git a/crates/services/src/services/diff_stream.rs b/crates/services/src/services/diff_stream.rs index 121a341d8db..9d9527cf510 100644 --- a/crates/services/src/services/diff_stream.rs +++ b/crates/services/src/services/diff_stream.rs @@ -1,21 +1,22 @@ use std::{ - collections::HashSet, + collections::{Has...
[ "crates/services/src/services/diff_stream.rs" ]
[ { "comment": "### Consecutive commits trigger unnecessary full resets\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`handle_git_state_change` doesn't update `last_head_commit` when it identifies a simple commit (fast path). A second commit arriving before the 5-second reconcile cycle will fail the `is_chil...
true
BloopAI/vibe-kanban
3,248
issue_to_patch
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
## Summary Full rewrite of the diff viewer rendering pipeline. Replaces TanStack Virtual with Pierre's native `<Virtualizer>`, optimizes for 300+ file PRs in Tauri/WKWebView, and adds file-in-view tracking with tree auto-scroll. ### Architecture migration - **Replace TanStack Virtual with Pierre `<Virtualizer>`** + `...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/Cargo.lock b/Cargo.lock index be0591b7ce9..bee253883b8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -8788,6 +8788,19 @@ dependencies = [ "walkdir", ] +[[package]] +name = "tauri-plugin-macos-fps" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "11177f7c9...
[ "Cargo.lock", "crates/tauri-app/Cargo.toml", "crates/tauri-app/src/main.rs", "crates/tauri-app/tauri.conf.json", "packages/local-web/package.json", "packages/ui/package.json", "packages/ui/src/components/ChangesPanel.tsx", "packages/ui/src/components/FileTree.tsx", "packages/ui/src/components/FileTr...
[ { "comment": "### useEffect after conditional return violates Rules of Hooks\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe `useEffect` at line 389 is placed after the conditional early return at line 197 (`if (shouldShowPlaceholder)`). When a large diff initially renders with the placeholder, only 10 ...
diff --git a/packages/web-core/src/shared/lib/diffDataAdapter.test.ts b/packages/web-core/src/shared/lib/diffDataAdapter.test.ts new file mode 100644 index 00000000000..e5d1bb4a79c --- /dev/null +++ b/packages/web-core/src/shared/lib/diffDataAdapter.test.ts @@ -0,0 +1,118 @@ +import { describe, it, expect } from 'vites...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Effect cleanup clears store on every dependency change **High Severity** <!-- DESCRIPTION START --> The `useEffect` cleanup calls `clearWorkspaceDiffData()` on every dependency change, not just on unmount. Since `diffs`, `diffPaths`, `diffStats`, etc. change frequently during streaming, every update triggers clea...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
[ "packages/web-core/src/shared/providers/WorkspaceProvider.tsx" ]
[ { "comment": "### Effect cleanup clears store on every dependency change\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe `useEffect` cleanup calls `clearWorkspaceDiffData()` on every dependency change, not just on unmount. Since `diffs`, `diffPaths`, `diffStats`, etc. change frequently during streaming,...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Debug console.log left in production code **Low Severity** <!-- DESCRIPTION START --> A styled `console.log` with flush count and batch statistics is left in the RAF callback without any development-mode guard. This will log to the browser console on every diff store flush in production, spamming users who open D...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
[ "packages/web-core/src/shared/providers/WorkspaceProvider.tsx" ]
[ { "comment": "### Debug console.log left in production code\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nA styled `console.log` with flush count and batch statistics is left in the RAF callback without any development-mode guard. This will log to the browser console on every diff store flush in production...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Unused refs never read in ChangesViewProvider **Low Severity** <!-- DESCRIPTION START --> `selectedFilePathRef` and `selectedLineNumberRef` are created and kept in sync with their corresponding state values on every render, but are never read anywhere in `ChangesViewProvider`. These are dead stores that add unnec...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx index 1cc645209d0..8a4b2e6f728 100644 --- a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx +++ b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx @@ -3,25 +3,27 @@ i...
[ "packages/web-core/src/shared/hooks/ChangesViewProvider.tsx" ]
[ { "comment": "### Unused refs never read in ChangesViewProvider\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`selectedFilePathRef` and `selectedLineNumberRef` are created and kept in sync with their corresponding state values on every render, but are never read anywhere in `ChangesViewProvider`. These are...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Unused `attempts` variable in reveal loop **Low Severity** <!-- DESCRIPTION START --> The `attempts` variable is declared, incremented on each animation frame in `attemptReveal`, but never read or used in any condition. The timeout logic relies solely on `performance.now() - revealStartTime`. This is dead code th...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Unused `attempts` variable in reveal loop\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `attempts` variable is declared, incremented on each animation frame in `attemptReveal`, but never read or used in any condition. The timeout logic relies solely on `performance.now() - revealStart...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Markdown preview feature removed without replacement **Medium Severity** <!-- DESCRIPTION START --> The deleted `PierreDiffCard` had a markdown preview toggle feature (`viewMode` state, `isMarkdownFile` check, `MarkdownPreview` component, and an eye icon button) that allowed users to preview `.md`/`.mdx` files. T...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Markdown preview feature removed without replacement\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe deleted `PierreDiffCard` had a markdown preview toggle feature (`viewMode` state, `isMarkdownFile` check, `MarkdownPreview` component, and an eye icon button) that allowed users to pr...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Large diff placeholder protection removed causing performance risk **Medium Severity** <!-- DESCRIPTION START --> The deleted `PierreDiffCard` had a large-diff guard (`LARGE_DIFF_THRESHOLD = 2000`, `forceExpanded` state, and a "Load anyway" placeholder UI) that prevented rendering massive diffs on expand. The new...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Large diff placeholder protection removed causing performance risk\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe deleted `PierreDiffCard` had a large-diff guard (`LARGE_DIFF_THRESHOLD = 2000`, `forceExpanded` state, and a \"Load anyway\" placeholder UI) that prevented rendering mas...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Scroll-to-file defaults collapsed files as unexpanded incorrectly **Low Severity** <!-- DESCRIPTION START --> `handleScrollToFile` checks `!(expandedState[expandKey] ?? false)` to decide whether to expand a file. For files with `initialExpanded=true` that were never explicitly toggled, the store has `undefined` f...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Scroll-to-file defaults collapsed files as unexpanded incorrectly\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`handleScrollToFile` checks `!(expandedState[expandKey] ?? false)` to decide whether to expand a file. For files with `initialExpanded=true` that were never explicitly toggled, ...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Stale `onDiffRef` closure in cached ref callbacks **Low Severity** <!-- DESCRIPTION START --> The `diffRefCallbacksRef` map caches ref callbacks per path, but each callback closes over the `onDiffRef` prop value at creation time. If `onDiffRef` changes on a subsequent render, already-cached callbacks continue cal...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/ui/src/components/ChangesPanel.tsx b/packages/ui/src/components/ChangesPanel.tsx index d30d0cf82aa..8bf265fcf88 100644 --- a/packages/ui/src/components/ChangesPanel.tsx +++ b/packages/ui/src/components/ChangesPanel.tsx @@ -1,7 +1,13 @@ import type { ForwardedRef, ReactNode, RefAttributes } from '...
[ "packages/ui/src/components/ChangesPanel.tsx" ]
[ { "comment": "### Stale `onDiffRef` closure in cached ref callbacks\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `diffRefCallbacksRef` map caches ref callbacks per path, but each callback closes over the `onDiffRef` prop value at creation time. If `onDiffRef` changes on a subsequent render, already-ca...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### IntersectionObserver scroll root found via fragile CSS class selector **Medium Severity** <!-- DESCRIPTION START --> The `IntersectionObserver` setup finds the scroll container via `firstWrapper.closest('.overflow-auto')`, relying on a Tailwind CSS class name. If the virtualizer's container class changes (it's cu...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### IntersectionObserver scroll root found via fragile CSS class selector\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `IntersectionObserver` setup finds the scroll container via `firstWrapper.closest('.overflow-auto')`, relying on a Tailwind CSS class name. If the virtualizer's conta...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Double state update in `scrollToFile` before callback **Low Severity** <!-- DESCRIPTION START --> `scrollToFile` calls `setSelectedFilePath`/`setSelectedLineNumber`/`setFileInView` and then also calls `selectFile` in the fallback path (when no scroll callback is registered), which repeats the same three state upd...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx index 1cc645209d0..8a4b2e6f728 100644 --- a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx +++ b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx @@ -3,25 +3,27 @@ i...
[ "packages/web-core/src/shared/hooks/ChangesViewProvider.tsx" ]
[ { "comment": "### Double state update in `scrollToFile` before callback\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`scrollToFile` calls `setSelectedFilePath`/`setSelectedLineNumber`/`setFileInView` and then also calls `selectFile` in the fallback path (when no scroll callback is registered), which repea...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Side effect inside React state updater function **Medium Severity** <!-- DESCRIPTION START --> The `mountNextBatch` function schedules a `requestAnimationFrame` inside a `setMountedCount` state updater callback. React state updaters are expected to be pure functions with no side effects. In React Strict Mode (dev...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Side effect inside React state updater function\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `mountNextBatch` function schedules a `requestAnimationFrame` inside a `setMountedCount` state updater callback. React state updaters are expected to be pure functions with no side effects...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### ExecutionProcessesProvider clears store on every dependency change **High Severity** <!-- DESCRIPTION START --> The `useEffect` cleanup in `ExecutionProcessesProvider` calls `clearExecutionProcessesData()` every time any dependency changes, not just on unmount. This causes the Zustand store to be briefly emptied ...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx b/packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx index 888006dda59..f986bf8c242 100644 --- a/packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx +++ b/packages/web-core/src/shared/providers/Execut...
[ "packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx" ]
[ { "comment": "### ExecutionProcessesProvider clears store on every dependency change\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe `useEffect` cleanup in `ExecutionProcessesProvider` calls `clearExecutionProcessesData()` every time any dependency changes, not just on unmount. This causes the Zustand s...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### PierreConversationDiff accesses `.additions` as number vs array **High Severity** <!-- DESCRIPTION START --> The code changed from `change.additions.length` and `change.deletions.length` (treating them as arrays) to `change.additions` and `change.deletions` (treating them as numbers). If the `@pierre/diffs` v1.1....
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/ui/src/components/PierreConversationDiff.tsx b/packages/ui/src/components/PierreConversationDiff.tsx index 88f86630238..0793d60cbca 100644 --- a/packages/ui/src/components/PierreConversationDiff.tsx +++ b/packages/ui/src/components/PierreConversationDiff.tsx @@ -55,7 +55,7 @@ const PIERRE_DIFFS_TH...
[ "packages/ui/src/components/PierreConversationDiff.tsx" ]
[ { "comment": "### PierreConversationDiff accesses `.additions` as number vs array\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe code changed from `change.additions.length` and `change.deletions.length` (treating them as arrays) to `change.additions` and `change.deletions` (treating them as numbers). I...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Orphaned `diffPaths` and `setDiffPaths` in useDiffViewStore **Low Severity** <!-- DESCRIPTION START --> The `diffPaths` field and `setDiffPaths` action in `useDiffViewStore` are now dead code. The `WorkspaceProvider` previously called `setDiffPaths` to populate this field, but that code was removed in this PR. Al...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
[ "packages/web-core/src/shared/providers/WorkspaceProvider.tsx" ]
[ { "comment": "### Orphaned `diffPaths` and `setDiffPaths` in useDiffViewStore\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `diffPaths` field and `setDiffPaths` action in `useDiffViewStore` are now dead code. The `WorkspaceProvider` previously called `setDiffPaths` to populate this field, but that code...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Stale theme passed to GitHub comment renderer **Low Severity** <!-- DESCRIPTION START --> The `renderAnnotation` callback in `DiffFileItem` closes over `actualTheme` and passes it to `GitHubCommentRenderer`, but `actualTheme` is missing from the `useCallback` dependency array `[diff, filePath, addComment]`. When ...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Stale theme passed to GitHub comment renderer\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `renderAnnotation` callback in `DiffFileItem` closes over `actualTheme` and passes it to `GitHubCommentRenderer`, but `actualTheme` is missing from the `useCallback` dependency array `[diff, fi...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### rAF batching can drop initial diff store update **Medium Severity** <!-- DESCRIPTION START --> The rAF-based batching in `WorkspaceProvider` skips scheduling a new `requestAnimationFrame` when one is already pending (`rafRef.current !== null`). However, the effect's cleanup cancels the pending rAF. If React runs ...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
[ "packages/web-core/src/shared/providers/WorkspaceProvider.tsx" ]
[ { "comment": "### rAF batching can drop initial diff store update\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe rAF-based batching in `WorkspaceProvider` skips scheduling a new `requestAnimationFrame` when one is already pending (`rafRef.current !== null`). However, the effect's cleanup cancels the ...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Scroll-to-file may fail before chunked mount completes **Medium Severity** <!-- DESCRIPTION START --> When `handleScrollToFile` is called during chunked mounting, it calls `setMountedCount(diffItems.length)` to force-mount all items, then immediately uses `requestAnimationFrame` to find the target `[data-diff-pat...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Scroll-to-file may fail before chunked mount completes\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nWhen `handleScrollToFile` is called during chunked mounting, it calls `setMountedCount(diffItems.length)` to force-mount all items, then immediately uses `requestAnimationFrame` to find...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Unused exported selectors in execution processes store **Low Severity** <!-- DESCRIPTION START --> `useExecutionProcessesByIdAll`, `useIsAttemptRunningAll`, and `useExecutionProcessesByIdVisible` are exported but never imported anywhere in the codebase. These are dead code left over from the migration away from `...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/stores/useExecutionProcessesStore.ts b/packages/web-core/src/shared/stores/useExecutionProcessesStore.ts new file mode 100644 index 00000000000..4bbb74d6154 --- /dev/null +++ b/packages/web-core/src/shared/stores/useExecutionProcessesStore.ts @@ -0,0 +1,86 @@ +import { create }...
[ "packages/web-core/src/shared/stores/useExecutionProcessesStore.ts" ]
[ { "comment": "### Unused exported selectors in execution processes store\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`useExecutionProcessesByIdAll`, `useIsAttemptRunningAll`, and `useExecutionProcessesByIdVisible` are exported but never imported anywhere in the codebase. These are dead code left over fro...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Module-level `fileDiffCache` leaks across workspace switches **Medium Severity** <!-- DESCRIPTION START --> `fileDiffCache` is a module-level `LruCache` instance that persists across workspace switches. When a user switches workspaces, the cache retains stale diff objects keyed by file path. If the new workspace ...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Module-level `fileDiffCache` leaks across workspace switches\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`fileDiffCache` is a module-level `LruCache` instance that persists across workspace switches. When a user switches workspaces, the cache retains stale diff objects keyed by file ...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### Chunked mount resets to zero on every diffItems change **Medium Severity** <!-- DESCRIPTION START --> The chunked rAF mount effect runs whenever `diffItems` changes. When a new diff streams in during the chunked mount phase, `diffItems` gets a new reference, the cleanup cancels the current rAF chain, and `mountNe...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Chunked mount resets to zero on every diffItems change\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe chunked rAF mount effect runs whenever `diffItems` changes. When a new diff streams in during the chunked mount phase, `diffItems` gets a new reference, the cleanup cancels the curr...
true
BloopAI/vibe-kanban
3,248
comment_to_fix
perf: replace TanStack Virtual with Pierre Virtualizer, optimize diff viewer for 300+ file PRs
### CSS selector `data-diffs` changed to `data-diff` may break **Medium Severity** <!-- DESCRIPTION START --> The CSS selectors were changed from `[data-diffs]` to `[data-diff]` in `PierreConversationDiff.tsx`. If the `@pierre/diffs` v1.1.4 library still renders elements with the `data-diffs` attribute (not `data-dif...
37190901b6396261e6283667d48b91d619f74d64
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/ui/src/components/PierreConversationDiff.tsx b/packages/ui/src/components/PierreConversationDiff.tsx index 88f86630238..0793d60cbca 100644 --- a/packages/ui/src/components/PierreConversationDiff.tsx +++ b/packages/ui/src/components/PierreConversationDiff.tsx @@ -55,7 +55,7 @@ const PIERRE_DIFFS_TH...
[ "packages/ui/src/components/PierreConversationDiff.tsx" ]
[ { "comment": "### CSS selector `data-diffs` changed to `data-diff` may break\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe CSS selectors were changed from `[data-diffs]` to `[data-diff]` in `PierreConversationDiff.tsx`. If the `@pierre/diffs` v1.1.4 library still renders elements with the `data-diff...
true
BloopAI/vibe-kanban
3,139
issue_to_patch
Add WebRTC direct tunneling with relay fallback
## Summary Adds WebRTC data channel transport for direct host-to-host connectivity, bypassing the relay server for lower latency. Falls back to relay transparently when WebRTC isn't available. ### New crates - **`relay-webrtc`** — WebRTC client/host peers, signaling, HTTP and WebSocket multiplexing over data channels...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 118f9d3bf58..246d170b0f2 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -73,8 +73,10 @@ jobs: - 'crates/relay-client/**' - 'crates/relay-control/**' - 'crates/relay-hosts/...
[ ".github/workflows/test.yml", "Cargo.lock", "Cargo.toml", "Dockerfile", "crates/deployment/Cargo.toml", "crates/deployment/src/lib.rs", "crates/desktop-bridge/Cargo.toml", "crates/desktop-bridge/src/lib.rs", "crates/desktop-bridge/src/tunnel.rs", "crates/local-deployment/Cargo.toml", "crates/loc...
[ { "comment": "### Multi-valued HTTP headers silently dropped via WebRTC\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nBoth the server-side proxy (`peer.rs`) and the client-side request builder (`relay-hosts/src/lib.rs`) convert HTTP headers into `HashMap<String, String>`, which silently drops all but th...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Multi-valued HTTP headers silently dropped via WebRTC **Medium Severity** <!-- DESCRIPTION START --> Both the server-side proxy (`peer.rs`) and the client-side request builder (`relay-hosts/src/lib.rs`) convert HTTP headers into `HashMap<String, String>`, which silently drops all but the last value for any repeat...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/peer.rs b/crates/relay-webrtc/src/peer.rs new file mode 100644 index 00000000000..862ec001709 --- /dev/null +++ b/crates/relay-webrtc/src/peer.rs @@ -0,0 +1,461 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc, time::Duration}; + +use bytes::Bytes; +use tokio::sync::{M...
[ "crates/relay-webrtc/src/peer.rs" ]
[ { "comment": "### Multi-valued HTTP headers silently dropped via WebRTC\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nBoth the server-side proxy (`peer.rs`) and the client-side request builder (`relay-hosts/src/lib.rs`) convert HTTP headers into `HashMap<String, String>`, which silently drops all but th...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### WebRTC cache permanently stuck in Connecting state **Low Severity** <!-- DESCRIPTION START --> In `maybe_start_webrtc`, after `start_connecting` marks the host as `Connecting`, the state transition to `Connected` or `Failed` happens inside a spawned task. If that task panics (e.g., unexpected error from WebRTC in...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### WebRTC cache permanently stuck in Connecting state\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nIn `maybe_start_webrtc`, after `start_connecting` marks the host as `Connecting`, the state transition to `Connected` or `Failed` happens inside a spawned task. If that task panics (e.g., unex...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Unreachable shutdown token for WebRtcHost lifecycle management **Low Severity** <!-- DESCRIPTION START --> `WebRtcHost::new` receives a freshly created `CancellationToken::new()` that is never stored or returned, making it impossible to cancel. The `WebRtcHost` uses this token to create child tokens for each peer...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/local-deployment/src/lib.rs b/crates/local-deployment/src/lib.rs index d7f0fa440b6..50e3f2c62df 100644 --- a/crates/local-deployment/src/lib.rs +++ b/crates/local-deployment/src/lib.rs @@ -1,16 +1,19 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{ + collections::HashMap, + sync::{A...
[ "crates/local-deployment/src/lib.rs" ]
[ { "comment": "### Unreachable shutdown token for WebRtcHost lifecycle management\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`WebRtcHost::new` receives a freshly created `CancellationToken::new()` that is never stored or returned, making it impossible to cancel. The `WebRtcHost` uses this token to create...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Relay-tunnel Dockerfile missing new relay-ws dependency **High Severity** <!-- DESCRIPTION START --> The PR adds `relay-ws` as a new path dependency to `relay-tunnel/Cargo.toml`, but the `relay-tunnel/Dockerfile` does not COPY the `relay-ws` crate (nor its transitive path dependencies `relay-control` source and `...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-tunnel/Dockerfile b/crates/relay-tunnel/Dockerfile index 566b26845f2..523132b67cd 100644 --- a/crates/relay-tunnel/Dockerfile +++ b/crates/relay-tunnel/Dockerfile @@ -25,6 +25,10 @@ COPY crates/services/Cargo.toml crates/services/Cargo.toml COPY crates/worktree-manager/Cargo.toml crates/workt...
[ "crates/relay-tunnel/Dockerfile" ]
[ { "comment": "### Relay-tunnel Dockerfile missing new relay-ws dependency\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe PR adds `relay-ws` as a new path dependency to `relay-tunnel/Cargo.toml`, but the `relay-tunnel/Dockerfile` does not COPY the `relay-ws` crate (nor its transitive path dependencies `...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Main Dockerfile missing new relay-webrtc crate **High Severity** <!-- DESCRIPTION START --> The PR adds `relay-webrtc` as a new workspace crate and a dependency of both `server` and `relay-hosts`, but the main `Dockerfile` does not include any COPY instructions for `crates/relay-webrtc/`. The PR correctly adds CO...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/Dockerfile b/Dockerfile index c1d05d69cb6..8fe31e24523 100644 --- a/Dockerfile +++ b/Dockerfile @@ -72,7 +72,11 @@ COPY crates/git-host/Cargo.toml crates/git-host/Cargo.toml COPY crates/local-deployment/Cargo.toml crates/local-deployment/Cargo.toml COPY crates/mcp/Cargo.toml crates/mcp/Cargo.toml COPY c...
[ "Dockerfile" ]
[ { "comment": "### Main Dockerfile missing new relay-webrtc crate\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe PR adds `relay-webrtc` as a new workspace crate and a dependency of both `server` and `relay-hosts`, but the main `Dockerfile` does not include any COPY instructions for `crates/relay-webrtc/...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Orphan CancellationToken prevents WebRTC client graceful shutdown **Medium Severity** <!-- DESCRIPTION START --> In `negotiate_webrtc`, a standalone `CancellationToken::new()` is created for the `WebRtcClient` but it's not connected to any parent shutdown token. This means during application shutdown, these WebRT...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### Orphan CancellationToken prevents WebRTC client graceful shutdown\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `negotiate_webrtc`, a standalone `CancellationToken::new()` is created for the `WebRtcClient` but it's not connected to any parent shutdown token. This means during applic...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### WebRTC bridge swaps client and upstream direction **Medium Severity** <!-- DESCRIPTION START --> In `ProxiedWsConnection::bridge`, the WebRTC path swaps the position of `stream` (upstream) and `client_socket` compared to the Relay path. While the conversion functions are also swapped to compensate, `ws_copy_bidir...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### WebRTC bridge swaps client and upstream direction\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `ProxiedWsConnection::bridge`, the WebRTC path swaps the position of `stream` (upstream) and `client_socket` compared to the Relay path. While the conversion functions are also swapped to...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### WebRTC cache blocks reconnection for stale Connected entries **Medium Severity** <!-- DESCRIPTION START --> `start_connecting` returns `false` for any `Occupied` entry that isn't an expired `Failed` state, including `Connected` entries wrapping a dead `WebRtcClient`. If `try_webrtc_proxy` detects a disconnected c...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/webrtc_cache.rs b/crates/relay-hosts/src/webrtc_cache.rs new file mode 100644 index 00000000000..de4149bb75f --- /dev/null +++ b/crates/relay-hosts/src/webrtc_cache.rs @@ -0,0 +1,104 @@ +use std::{ + collections::HashMap, + sync::Arc, + time::{Duration, Instant}, +}; + +use ...
[ "crates/relay-hosts/src/webrtc_cache.rs" ]
[ { "comment": "### WebRTC cache blocks reconnection for stale Connected entries\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`start_connecting` returns `false` for any `Occupied` entry that isn't an expired `Failed` state, including `Connected` entries wrapping a dead `WebRtcClient`. If `try_webrtc_prox...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Race condition in `wait_until_connected` misses notification **Medium Severity** <!-- DESCRIPTION START --> `wait_until_connected` checks `is_connected()` before creating the `Notified` future via `connected_notify.notified()`. If the data channel's `on_open` callback fires between the `is_connected()` check retu...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/client.rs b/crates/relay-webrtc/src/client.rs new file mode 100644 index 00000000000..c7d23c5778d --- /dev/null +++ b/crates/relay-webrtc/src/client.rs @@ -0,0 +1,683 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }...
[ "crates/relay-webrtc/src/client.rs" ]
[ { "comment": "### Race condition in `wait_until_connected` misses notification\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`wait_until_connected` checks `is_connected()` before creating the `Notified` future via `connected_notify.notified()`. If the data channel's `on_open` callback fires between the ...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Tunnel not cancelled when host is removed **Low Severity** <!-- DESCRIPTION START --> `remove_host` clears the session cache and removes the WebRTC connection, but does not cancel any active SSH tunnel in the `TunnelManager` for the removed host. The tunnel's TCP listener continues running, spawning connections t...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### Tunnel not cancelled when host is removed\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`remove_host` clears the session cache and removes the WebRTC connection, but does not cancel any active SSH tunnel in the `TunnelManager` for the removed host. The tunnel's TCP listener continues runn...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Missing timeout on WebSocket open response wait **Medium Severity** <!-- DESCRIPTION START --> `open_ws` awaits `result_rx` without any timeout, unlike `send_request` which wraps the same pattern in `tokio::time::timeout(Self::HTTP_REQUEST_TIMEOUT, ...)`. If the remote host never sends a `WsOpened` or `WsError` r...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/client.rs b/crates/relay-webrtc/src/client.rs new file mode 100644 index 00000000000..c7d23c5778d --- /dev/null +++ b/crates/relay-webrtc/src/client.rs @@ -0,0 +1,683 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }...
[ "crates/relay-webrtc/src/client.rs" ]
[ { "comment": "### Missing timeout on WebSocket open response wait\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`open_ws` awaits `result_rx` without any timeout, unlike `send_request` which wraps the same pattern in `tokio::time::timeout(Self::HTTP_REQUEST_TIMEOUT, ...)`. If the remote host never sends ...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### WebRTC client never explicitly closes peer connection **Medium Severity** <!-- DESCRIPTION START --> `WebRtcClient::shutdown` only cancels the `CancellationToken` but never calls `peer_connection.close()`. The `WebRtcClient` struct doesn't retain a handle to the `RTCPeerConnection`, so there's no way to explicitl...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/client.rs b/crates/relay-webrtc/src/client.rs new file mode 100644 index 00000000000..c7d23c5778d --- /dev/null +++ b/crates/relay-webrtc/src/client.rs @@ -0,0 +1,683 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }...
[ "crates/relay-webrtc/src/client.rs" ]
[ { "comment": "### WebRTC client never explicitly closes peer connection\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`WebRtcClient::shutdown` only cancels the `CancellationToken` but never calls `peer_connection.close()`. The `WebRtcClient` struct doesn't retain a handle to the `RTCPeerConnection`, so ...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Unused public methods on WebRtcHost struct **Low Severity** <!-- DESCRIPTION START --> The public methods `remove_peer` and `peer_count` on `WebRtcHost` are defined but never called anywhere in the codebase. These are exported public API surface that adds maintenance burden without current consumers. <!-- DESCRIP...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/host.rs b/crates/relay-webrtc/src/host.rs new file mode 100644 index 00000000000..41da49b1b93 --- /dev/null +++ b/crates/relay-webrtc/src/host.rs @@ -0,0 +1,112 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc}; + +use tokio::sync::Mutex; +use tokio_util::sync::Cancell...
[ "crates/relay-webrtc/src/host.rs" ]
[ { "comment": "### Unused public methods on WebRtcHost struct\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe public methods `remove_peer` and `peer_count` on `WebRtcHost` are defined but never called anywhere in the codebase. These are exported public API surface that adds maintenance burden without curr...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Exported `WsSender` type is never used externally **Low Severity** <!-- DESCRIPTION START --> `WsSender` is re-exported from `relay-webrtc`'s public API but is never imported or used outside the crate. The `WsConnection::sender()` method that returns it is also unused externally — all call sites consume `WsConnec...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/lib.rs b/crates/relay-webrtc/src/lib.rs new file mode 100644 index 00000000000..19abebdb3d5 --- /dev/null +++ b/crates/relay-webrtc/src/lib.rs @@ -0,0 +1,31 @@ +pub mod client; +pub mod error; +pub mod fragment; +pub mod host; +pub mod peer; +pub mod proxy; +pub mod signaling; + +pu...
[ "crates/relay-webrtc/src/lib.rs" ]
[ { "comment": "### Exported `WsSender` type is never used externally\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`WsSender` is re-exported from `relay-webrtc`'s public API but is never imported or used outside the crate. The `WsConnection::sender()` method that returns it is also unused externally — all c...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### WebRTC WS failure doesn't remove stale connection from cache **Medium Severity** <!-- DESCRIPTION START --> `try_webrtc_ws` does not remove the WebRTC connection from the cache when `open_ws` fails, unlike `try_webrtc_proxy` which calls `self.webrtc.remove(...)` on any error. If the data channel enters a zombie s...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### WebRTC WS failure doesn't remove stale connection from cache\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`try_webrtc_ws` does not remove the WebRTC connection from the cache when `open_ws` fails, unlike `try_webrtc_proxy` which calls `self.webrtc.remove(...)` on any error. If the dat...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Stale WebRTC client not shut down during reconnect **Low Severity** <!-- DESCRIPTION START --> In `start_connecting`, when a `Connected(client)` with `!client.is_connected()` is replaced by `Connecting`, the old `Arc<WebRtcClient>` is silently dropped without calling `shutdown()`. The `remove` method correctly ca...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/webrtc_cache.rs b/crates/relay-hosts/src/webrtc_cache.rs new file mode 100644 index 00000000000..de4149bb75f --- /dev/null +++ b/crates/relay-hosts/src/webrtc_cache.rs @@ -0,0 +1,104 @@ +use std::{ + collections::HashMap, + sync::Arc, + time::{Duration, Instant}, +}; + +use ...
[ "crates/relay-hosts/src/webrtc_cache.rs" ]
[ { "comment": "### Stale WebRTC client not shut down during reconnect\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nIn `start_connecting`, when a `Connected(client)` with `!client.is_connected()` is replaced by `Connecting`, the old `Arc<WebRtcClient>` is silently dropped without calling `shutdown()`. The `...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Writer task hangs without shutdown check awaiting DC **Medium Severity** <!-- DESCRIPTION START --> The server-side writer task awaits `dc_ready_rx` without selecting on the `writer_shutdown` cancellation token. If the ICE connection fails or disconnects before a data channel ever opens, this task gets stuck on t...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/peer.rs b/crates/relay-webrtc/src/peer.rs new file mode 100644 index 00000000000..862ec001709 --- /dev/null +++ b/crates/relay-webrtc/src/peer.rs @@ -0,0 +1,461 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc, time::Duration}; + +use bytes::Bytes; +use tokio::sync::{M...
[ "crates/relay-webrtc/src/peer.rs" ]
[ { "comment": "### Writer task hangs without shutdown check awaiting DC\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe server-side writer task awaits `dc_ready_rx` without selecting on the `writer_shutdown` cancellation token. If the ICE connection fails or disconnects before a data channel ever opens...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### WebRTC cache remove races with concurrent insert **Medium Severity** <!-- DESCRIPTION START --> `try_webrtc_proxy` and `try_webrtc_ws` call `self.webrtc.remove(host_id)` on request failure, but `remove` blindly deletes whatever entry exists for that host. If `maybe_start_webrtc` concurrently established a *new* c...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### WebRTC cache remove races with concurrent insert\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`try_webrtc_proxy` and `try_webrtc_ws` call `self.webrtc.remove(host_id)` on request failure, but `remove` blindly deletes whatever entry exists for that host. If `maybe_start_webrtc` concurr...
true
BloopAI/vibe-kanban
3,139
comment_to_fix
Add WebRTC direct tunneling with relay fallback
### Transport consumed before error path needs it **Medium Severity** <!-- DESCRIPTION START --> In `connect_ws_via_relay`, `maybe_start_webrtc(transport)` moves the `transport` when `result.is_ok()`. However, on the **success** path, the result is destructured on the next line. If the relay WS was successfully opene...
c9d573daec4f9ddb318fa7262be335a171fd91db
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
[ "crates/relay-hosts/src/lib.rs" ]
[ { "comment": "### Transport consumed before error path needs it\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nIn `connect_ws_via_relay`, `maybe_start_webrtc(transport)` moves the `transport` when `result.is_ok()`. However, on the **success** path, the result is destructured on the next line. If the rela...
true
BloopAI/vibe-kanban
3,264
issue_to_patch
bump codex
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Moderate risk because it upgrades Codex protocol/CLI versions and significantly expands log normalization for new JSON-RPC request/notification shapes (dynamic tools, direct item events), which could affect session rendering and approval flows. > > **Overview** > B...
76c818f7a3dc83bf1e5d308738a1f48a1a7d2c24
a9367cee105793c0c3004623737b2c143bc20e63
diff --git a/Cargo.lock b/Cargo.lock index be0591b7ce9..c9421c7b805 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1128,8 +1128,8 @@ checksum = "e9b18233253483ce2f65329a24072ec414db782531bdbb7d0bbc4bd2ce6b7e21" [[package]] name = "codex-app-server-protocol" -version = "0.114.0" -source = "git+https://github.com/opena...
[ "Cargo.lock", "crates/executors/Cargo.toml", "crates/executors/src/executors/codex.rs", "crates/executors/src/executors/codex/client.rs", "crates/executors/src/executors/codex/normalize_logs.rs", "crates/executors/src/executors/codex/slash_commands.rs", "packages/web-core/src/features/workspace-chat/ui/...
[ { "comment": "### Fallback creates invisible command state without UI entry\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `update_tool_status` fallback for unknown `call_id`s with `PendingApproval` status creates a new `CommandState` via `command_state()`, which always starts with `index: None`. The...
true
BloopAI/vibe-kanban
3,275
issue_to_patch
POC: Replace TanStack Virtual with Pierre native Virtualizer
## Summary Replace TanStack Virtual with Pierre's native `<Virtualizer>` for the diff panel. POC branch to validate the approach before merging into the main diff optimization PR. ### Architecture Change **Before:** `TanStack Virtual` → `PierreDiffCard` → `DiffCardExpandedBody` → `<FileDiff>` **After:** `Pierre <Vir...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/ui/package.json b/packages/ui/package.json index 78d897b41b5..ba084261214 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -25,7 +25,7 @@ "@lexical/react": "^0.36.2", "@lexical/table": "^0.36.2", "@phosphor-icons/react": "^2.1.10", - "@pierre/diffs": "^1.1....
[ "packages/ui/package.json", "packages/ui/src/components/FileTree.tsx", "packages/ui/src/components/FileTreeNode.tsx", "packages/web-core/package.json", "packages/web-core/src/app/styles/diff-style-overrides.css", "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx", "packages/web-core/src/...
[ { "comment": "### Hardcoded mock `|| 3` shows fake GitHub comment count\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`githubCommentCount` falls back to `3` via `|| 3` when `githubCommentsForFile.length` is `0`. This means every file with zero GitHub comments will display a badge showing \"3\" comments. T...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Hardcoded mock `|| 3` shows fake GitHub comment count **High Severity** <!-- DESCRIPTION START --> `githubCommentCount` falls back to `3` via `|| 3` when `githubCommentsForFile.length` is `0`. This means every file with zero GitHub comments will display a badge showing "3" comments. The PR description explicitly ...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Hardcoded mock `|| 3` shows fake GitHub comment count\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\n`githubCommentCount` falls back to `3` via `|| 3` when `githubCommentsForFile.length` is `0`. This means every file with zero GitHub comments will display a badge showing \"3\" comments. T...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### `startTransition` is ineffective with Zustand's synchronous store **Medium Severity** <!-- DESCRIPTION START --> Wrapping a Zustand `set()` call inside React's `startTransition` does not achieve the intended "non-blocking" panel toggle. Zustand uses `useSyncExternalStore`, which forces synchronous re-renders to p...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/shared/stores/useUiPreferencesStore.ts b/packages/web-core/src/shared/stores/useUiPreferencesStore.ts index 2626bcfe152..88590b54850 100644 --- a/packages/web-core/src/shared/stores/useUiPreferencesStore.ts +++ b/packages/web-core/src/shared/stores/useUiPreferencesStore.ts @@ -1,4 +1,...
[ "packages/web-core/src/shared/stores/useUiPreferencesStore.ts" ]
[ { "comment": "### `startTransition` is ineffective with Zustand's synchronous store\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nWrapping a Zustand `set()` call inside React's `startTransition` does not achieve the intended \"non-blocking\" panel toggle. Zustand uses `useSyncExternalStore`, which force...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Module-level `fileDiffCache` grows unboundedly across workspaces **Medium Severity** <!-- DESCRIPTION START --> `fileDiffCache` is a module-level `Map` that is never cleared. Each workspace switch accumulates stale entries holding references to `Diff` objects and their parsed results, preventing garbage collectio...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Module-level `fileDiffCache` grows unboundedly across workspaces\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`fileDiffCache` is a module-level `Map` that is never cleared. Each workspace switch accumulates stale entries holding references to `Diff` objects and their parsed results, p...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Progressive mount resets to zero causing content flash **Medium Severity** <!-- DESCRIPTION START --> When `diffItems` changes, the progressive mount effect unconditionally calls `setMountedCount(0)` before starting the rAF-based remount. This causes a render with zero items, producing a visible flash of empty co...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Progressive mount resets to zero causing content flash\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nWhen `diffItems` changes, the progressive mount effect unconditionally calls `setMountedCount(0)` before starting the rAF-based remount. This causes a render with zero items, producing ...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Scroll-to-file may race with React rendering **Medium Severity** <!-- DESCRIPTION START --> `handleScrollToFile` calls `setMountedCount(diffItems.length)` to force-mount all items, then immediately schedules a `requestAnimationFrame` to find the DOM element. Since `setMountedCount` is an async React state update,...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Scroll-to-file may race with React rendering\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`handleScrollToFile` calls `setMountedCount(diffItems.length)` to force-mount all items, then immediately schedules a `requestAnimationFrame` to find the DOM element. Since `setMountedCount` is a...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Debounce timer not cleaned up on unmount **Low Severity** <!-- DESCRIPTION START --> The `layoutTimerRef` debounce timer created in `onLayoutChange` is never cleared on component unmount. If the component unmounts while a 150ms timeout is pending, `setRightMainPanelSize` fires against stale context. <!-- DESCRIPT...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx b/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx index 7291a1e48ba..42565b86dd5 100644 --- a/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx +++ b/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx @@ -184,10 +184...
[ "packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx" ]
[ { "comment": "### Debounce timer not cleaned up on unmount\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `layoutTimerRef` debounce timer created in `onLayoutChange` is never cleared on component unmount. If the component unmounts while a 150ms timeout is pending, `setRightMainPanelSize` fires against s...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Side effect inside React state updater function **Medium Severity** <!-- DESCRIPTION START --> The `mountNextBatch` function schedules `requestAnimationFrame` inside the `setMountedCount` state updater callback. React requires state updaters to be pure functions with no side effects. In React 18 strict mode, upda...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Side effect inside React state updater function\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `mountNextBatch` function schedules `requestAnimationFrame` inside the `setMountedCount` state updater callback. React requires state updaters to be pure functions with no side effects. In...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Draft changes trigger re-render of all file diffs **Medium Severity** <!-- DESCRIPTION START --> The `annotations` useMemo depends on the full `drafts` object from `useReview()`. Since every `DiffFileItem` subscribes to the same Review context, changing a draft on *any* file causes *every* `DiffFileItem` to re-re...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Draft changes trigger re-render of all file diffs\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `annotations` useMemo depends on the full `drafts` object from `useReview()`. Since every `DiffFileItem` subscribes to the same Review context, changing a draft on *any* file causes *eve...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Mutating state inside useMemo breaks auto-collapse in StrictMode **Medium Severity** <!-- DESCRIPTION START --> The `diffItems` `useMemo` mutates `processedPaths` (a `Set` from `useState`) as a side effect. In React StrictMode, `useMemo` is double-invoked: the first call adds all paths, so the second call finds e...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Mutating state inside useMemo breaks auto-collapse in StrictMode\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `diffItems` `useMemo` mutates `processedPaths` (a `Set` from `useState`) as a side effect. In React StrictMode, `useMemo` is double-invoked: the first call adds all paths,...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### processedPaths persists across workspace switches causing stale state **Low Severity** <!-- DESCRIPTION START --> `processedPaths` is created via `useState` and never cleared when `workspaceId` changes. Since `ChangesPanelContainer` is rendered without a `key` tied to `workspaceId`, switching workspaces preserves...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### processedPaths persists across workspace switches causing stale state\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`processedPaths` is created via `useState` and never cleared when `workspaceId` changes. Since `ChangesPanelContainer` is rendered without a `key` tied to `workspaceId`, swi...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Wrong `containIntrinsicSize` for expanded folder tree nodes **Low Severity** <!-- DESCRIPTION START --> Each tree node wrapper div gets `containIntrinsicSize: 'auto 26px'`, but expanded folder nodes contain both their own `FileTreeNode` and recursively rendered children. The actual height of an expanded folder wi...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/ui/src/components/FileTree.tsx b/packages/ui/src/components/FileTree.tsx index e77fb495ab6..2a3e7195882 100644 --- a/packages/ui/src/components/FileTree.tsx +++ b/packages/ui/src/components/FileTree.tsx @@ -1,4 +1,4 @@ -import type { ReactNode } from 'react'; +import { memo, type ReactNode } from ...
[ "packages/ui/src/components/FileTree.tsx" ]
[ { "comment": "### Wrong `containIntrinsicSize` for expanded folder tree nodes\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nEach tree node wrapper div gets `containIntrinsicSize: 'auto 26px'`, but expanded folder nodes contain both their own `FileTreeNode` and recursively rendered children. The actual heig...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Stale promise handler causes scroll race condition **Low Severity** <!-- DESCRIPTION START --> When `handleScrollToFile` is called twice rapidly (e.g., quick comment navigation clicks), the first call's `.then()` handler still runs `scrollToLineInDiff` for the old file after the second call has already started sc...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Stale promise handler causes scroll race condition\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nWhen `handleScrollToFile` is called twice rapidly (e.g., quick comment navigation clicks), the first call's `.then()` handler still runs `scrollToLineInDiff` for the old file after the second ...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Modified file is now dead code **Low Severity** <!-- DESCRIPTION START --> `diffRenderMode.ts` had its `LARGE_DIFF_THRESHOLD` changed from 1000 to 800, but both consumers of this module — `DiffCardExpandedBody.tsx` and `diffHeightEstimate.ts` — were deleted in this PR. No remaining file imports from `diffRenderMo...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/shared/lib/diffRenderMode.ts b/packages/web-core/src/shared/lib/diffRenderMode.ts deleted file mode 100644 index cc0f8fe2c4d..00000000000 --- a/packages/web-core/src/shared/lib/diffRenderMode.ts +++ /dev/null @@ -1,17 +0,0 @@ -import type { Diff } from 'shared/types'; - -export const ...
[ "packages/web-core/src/shared/lib/diffRenderMode.ts" ]
[ { "comment": "### Modified file is now dead code\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`diffRenderMode.ts` had its `LARGE_DIFF_THRESHOLD` changed from 1000 to 800, but both consumers of this module — `DiffCardExpandedBody.tsx` and `diffHeightEstimate.ts` — were deleted in this PR. No remaining file...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### IntersectionObserver re-created per chunked mount batch **Medium Severity** <!-- DESCRIPTION START --> The `IntersectionObserver` effect depends on `itemsToRender.length`, which changes on every chunked mount batch (every 8 items). For a 384-file load, this creates and destroys ~48 observers. Each creation querie...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### IntersectionObserver re-created per chunked mount batch\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe `IntersectionObserver` effect depends on `itemsToRender.length`, which changes on every chunked mount batch (every 8 items). For a 384-file load, this creates and destroys ~48 obse...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Programmatic scroll state set one frame too late **Medium Severity** <!-- DESCRIPTION START --> `beginProgrammaticScroll` is called inside a `requestAnimationFrame`, leaving the state machine in `idle` for one frame after the scroll is initiated. During this gap, the `IntersectionObserver` callback (which only su...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Programmatic scroll state set one frame too late\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\n`beginProgrammaticScroll` is called inside a `requestAnimationFrame`, leaving the state machine in `idle` for one frame after the scroll is initiated. During this gap, the `IntersectionObserv...
true
BloopAI/vibe-kanban
3,275
comment_to_fix
POC: Replace TanStack Virtual with Pierre native Virtualizer
### Expand state check uses wrong default value **Low Severity** <!-- DESCRIPTION START --> `handleScrollToFile` checks `expandedState[expandKey] ?? false` to determine if a file needs expanding. The fallback `false` doesn't match `DiffFileItem`, which uses `s.expanded[expandKey] ?? initialExpanded`. Files with `init...
695efaf4275e9f1e281f4e4d85c40530d2b37957
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
[ "packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx" ]
[ { "comment": "### Expand state check uses wrong default value\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\n`handleScrollToFile` checks `expandedState[expandKey] ?? false` to determine if a file needs expanding. The fallback `false` doesn't match `DiffFileItem`, which uses `s.expanded[expandKey] ?? initial...
true
BloopAI/vibe-kanban
3,279
issue_to_patch
fix(tauri): use dynamic frontend port for dev mode
## Summary - The Tauri dev script (`tauri:dev`) had a hardcoded `devUrl` of `http://localhost:3000`, but the frontend port is dynamically assigned and often lands on 3001 or 3002 - The Tauri app's `main.rs` also had `http://localhost:3000` hardcoded for the dev webview URL ### Changes - **`package.json`**: Pass `--con...
102b291ff3c1d628bc75ca67c33998c2863633a8
58682e7ce50e74bad2df10bf9632988d8d47944c
diff --git a/crates/tauri-app/src/main.rs b/crates/tauri-app/src/main.rs index 88d768db95b..d3295ae018a 100644 --- a/crates/tauri-app/src/main.rs +++ b/crates/tauri-app/src/main.rs @@ -120,10 +120,13 @@ fn main() { // Dev mode: frontend dev server (Vite) and backend are started // exte...
[ "crates/tauri-app/src/main.rs", "package.json" ]
[ { "comment": "### Duplicated DOM-scanning logic for finding visible row\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe new `getVisibleUserMessagePatchKey` method contains ~15 lines of DOM-scanning logic (querying `[data-row-index]` elements, computing bounding rects, finding the first visible index) tha...
true
BloopAI/vibe-kanban
3,276
issue_to_patch
Render Markdown in Diff PR Comments (Vibe Kanban)
## Summary This PR fixes PR comment rendering in the diffs view so GitHub PR comments display as Markdown instead of plain text. ## What Changed - Updated `GitHubCommentRenderer` to render `comment.body` with `MarkdownPreview` instead of a plain text `<div>`. - Added a required `theme` prop (`'light' | 'dark'`) to `Gi...
ce59de9112161fcde26d7ab776ca8e3fb57f3895
b2917a6e039b9a2705c346661aa395f8387d8637
diff --git a/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx b/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx index c937f9e292c..869d05e77d2 100644 --- a/packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx +++ b/packages/web-core/src/pages/workspaces/GitHubCommentRenderer...
[ "packages/web-core/src/pages/workspaces/GitHubCommentRenderer.tsx", "packages/web-core/src/pages/workspaces/PierreDiffCard.tsx" ]
[]
true
BloopAI/vibe-kanban
3,262
issue_to_patch
chore: remove dead code and tighten boundaries
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Low Risk** > Primarily deletes unused functions/types and narrows visibility (`pub` -> `pub(crate)`/private) without changing core algorithms; main risk is unintended downstream compile breakage where removed APIs were still referenced. > > **Overview** > **Removes dead/unused API...
1660e3f644a7294ad74491922f2b49494760fc8e
792841adf3335f6fffdc18e3a24f3d76a95bf628
diff --git a/crates/api-types/src/issue_assignee.rs b/crates/api-types/src/issue_assignee.rs index 46839b843ea..2067b4562c4 100644 --- a/crates/api-types/src/issue_assignee.rs +++ b/crates/api-types/src/issue_assignee.rs @@ -3,8 +3,6 @@ use serde::{Deserialize, Serialize}; use ts_rs::TS; use uuid::Uuid; -use crate:...
[ "crates/api-types/src/issue_assignee.rs", "crates/api-types/src/issue_follower.rs", "crates/api-types/src/issue_relationship.rs", "crates/api-types/src/issue_tag.rs", "crates/db/src/models/coding_agent_turn.rs", "crates/db/src/models/execution_process.rs", "crates/db/src/models/execution_process_logs.rs...
[]
true