repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
BCUninstaller/Bulk-Crap-Uninstaller | 925 | issue_to_patch | Eat InvalidOperationException coming from ListViewGroupAccessibleObject | e3eb03c2539130596ba796013fd7d72b8f18cbd0 | b10506ded6787cfb4e5276f0da7db290de96fc8f | diff --git a/source/ObjectListView/ObjectListView.cs b/source/ObjectListView/ObjectListView.cs
index e1d2f0c0..8c00a5d1 100644
--- a/source/ObjectListView/ObjectListView.cs
+++ b/source/ObjectListView/ObjectListView.cs
@@ -6251,6 +6251,19 @@ protected override void WndProc(ref Message m)
}
}
... | [
"source/ObjectListView/ObjectListView.cs"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 899 | issue_to_patch | Bug: Orphaned MSI uninstallers only visible as "System components"
I installed in the past various Python versions in Win10 via the corresponding *.msi package.
All into the same directory C:\Program Files\Python
and without manually uninstalling the previous versions.
Unfortunately the old Uninstaller entries survi... | Fix orphaned-only view preset | Closes #862
## Summary
This PR fixes the "View unregistered" preset so orphaned entries are shown even when they are also marked as system/protected entries.
## Changes
- update the "View unregistered" action to start from the "Everything" preset
- then apply the `IsOrphaned == true` search filter
## Wh... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | e8ddec707918fd5a559c341547fbdc13f5ecc131 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
index 480096e9..474018c0 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
@@ -1682,11 +1682,12 @@ private void AddS... | [
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 897 | issue_to_patch | BCU-console.exe version 6.1 shows error
On Windows 11 Enterprise 64 bit.
```
C:\BCUninstaller>BCU-console export C:\Export.xml
BCU-console, Version=6.1.0.0, Culture=neutral, PublicKeyToken=null
Starting export to C:\Export.xml
Looking for applications...
Scanning installed MSI products...
Scanning registry for unins... | Harden BCU console export and size detection - Fix BCU-console export failures | ## Summary
This PR hardens two BCU-console related failure paths.
## Fixes
- handle Everything / `es.exe` availability failures more defensively when estimating sizes
- prevent XML export from failing when application metadata contains invalid XML characters
## Changes
- catch broader startup failures i... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | ef3a1184075aa28239316ccbd442ae22ec4fe07b | diff --git a/source/BulkCrapUninstallerTests/ApplicationEntrySerializerTests.cs b/source/BulkCrapUninstallerTests/ApplicationEntrySerializerTests.cs
new file mode 100644
index 00000000..5a1d862a
--- /dev/null
+++ b/source/BulkCrapUninstallerTests/ApplicationEntrySerializerTests.cs
@@ -0,0 +1,44 @@
+using System.IO;
+us... | [
"source/BulkCrapUninstallerTests/ApplicationEntrySerializerTests.cs",
"source/KlocTools/Tools/SerializationTools.cs",
"source/UninstallTools/ApplicationEntrySerializer.cs",
"source/UninstallTools/Factory/InfoAdders/FastSizeGenerator.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 922 | issue_to_patch | Do not offer to send "no way to uninstall" error messages | baae38fbf94b2d253c030c02b4d515c044882c7f | 56b9202d82a86f5278a7200de6b094dd4dd2718e | diff --git a/source/KlocTools/Forms/Tools/PremadeDialogs.cs b/source/KlocTools/Forms/Tools/PremadeDialogs.cs
index 48046e5e..34d09638 100644
--- a/source/KlocTools/Forms/Tools/PremadeDialogs.cs
+++ b/source/KlocTools/Forms/Tools/PremadeDialogs.cs
@@ -67,6 +67,12 @@ public static bool StartProcessSafely(string command, ... | [
"source/KlocTools/Forms/Tools/PremadeDialogs.cs",
"source/UninstallTools/Uninstaller/NoWayToUninstallException.cs",
"source/UninstallTools/Uninstaller/UninstallManager.cs"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 918 | issue_to_patch | Updated Vietnamese translations | ## Updated Vietnamese translations
* Improved existing translation strings to better fit the application context
* Filled some missing translation keys | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 6e96f3159ce3b7ddeefde6b7aa78e011b4c22b03 | diff --git a/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.vi.resx b/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.vi.resx
index 2b5fc81c..21b706a7 100644
--- a/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.vi.resx
+++ b/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.vi.re... | [
"source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.vi.resx",
"source/BulkCrapUninstaller/Controls/FileTargeter.vi.resx",
"source/BulkCrapUninstaller/Controls/ListLegend.vi.resx",
"source/BulkCrapUninstaller/Controls/RelatedUninstallerAdder.vi.resx",
"source/BulkCrapUninstaller/Controls/Settings/Adva... | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 908 | issue_to_patch | Bug: "Install Date" wrong - BCU show s date of compilation not installation for Google Web Designer
Yesterday I downloaded newest, free Google Web Designer v16.4.1 from
https://webdesigner.withgoogle.com/
and installed it on Win10.
When I look into BCU for the newest installations (sorted by install date) I didn't ... | Fix: Use Directory.GetLastWriteTime for install date fallback | ## Problem
When InstallDate is not available in the registry (common for non-MSI installers like Google Web Designer), BCU falls back to using file/directory creation times. However, creation times often reflect the original build date rather than the installation date.
## Solution
This fix improves the fallback logic... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 70f20eb1232b14299b1db052ce0c2470f2df86d9 | diff --git a/source/UninstallTools/Factory/InfoAdders/InstallDateAdder.cs b/source/UninstallTools/Factory/InfoAdders/InstallDateAdder.cs
index 8776664a..94c42f86 100644
--- a/source/UninstallTools/Factory/InfoAdders/InstallDateAdder.cs
+++ b/source/UninstallTools/Factory/InfoAdders/InstallDateAdder.cs
@@ -17,7 +17,7 @@... | [
"source/UninstallTools/Factory/InfoAdders/InstallDateAdder.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 902 | issue_to_patch | Icon keeps getting corrupted
[](url)
<img width="620" height="404" alt="Image" src="https://github.com/user-attachments/assets/2579ddb5-3575-4de6-a392-01ce47f9b2a8" /> | Stabilize icon handle ownership | Closes #885
## Summary
This PR hardens icon extraction and ownership handling to prevent corrupted or unstable icons.
## Changes
- clone icons extracted from native Win32 handles instead of keeping `Icon.FromHandle(...)` results directly
- always release original icon handles with `DestroyIcon`
- switch r... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | a706072916eea446f067765a12e58609abd743fb | diff --git a/source/BulkCrapUninstaller/EntryPoint.cs b/source/BulkCrapUninstaller/EntryPoint.cs
index 2a155aca..4285ce7f 100644
--- a/source/BulkCrapUninstaller/EntryPoint.cs
+++ b/source/BulkCrapUninstaller/EntryPoint.cs
@@ -17,6 +17,7 @@ Apache License Version 2.0
using Klocman.Extensions;
using Klocman.Forms;
... | [
"source/BulkCrapUninstaller/EntryPoint.cs",
"source/BulkCrapUninstallerTests/DrawingToolsTests.cs",
"source/KlocTools/Tools/DrawingTools.cs",
"source/UninstallTools/Factory/ScoopFactory.cs",
"source/UniversalUninstaller/UninstallSelection.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 903 | issue_to_patch | How to filter grey uninstaller?
is it possible to sort or filter uninstaller by their color? | Add invalid-uninstaller view preset | Closes #878
## Summary
This PR adds a dedicated filtering preset for invalid uninstallers.
## Changes
- add a new `View Invalid` entry under the Filtering menu
- make the preset start from the `Everything` view so invalid entries are not hidden by other simple filters
- enable invalid highlighting before ... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 95cd7515184b5f655d4b47c42e76cc2d4ef1c38a | diff --git a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.Designer.cs b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.Designer.cs
index ac46bb91..10733e6a 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.Designer.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.Designer.cs
@@ -1... | [
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.Designer.cs",
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs",
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.resx"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 898 | issue_to_patch | BCUninstaller 6.1 - Show Tweaks non functional, always visible
I just upgraded to 6.1 (portable) and the show tweaks checkbox does not function. The tweaks are always visible in my program list.
<img width="1013" height="56" alt="Image" src="https://github.com/user-attachments/assets/592a6b7a-320e-4e0b-8a9a-bb433f8e6... | Fix tweak visibility filtering | Closes #867
## Summary
This PR fixes tweak visibility/filtering so "Show tweaks" and related list filtering use the same detection logic.
## Changes
- add a single `IsScriptTweak` property to `ApplicationUninstallerEntry`
- use that property in the main list filtering logic
- use that property for the "Vi... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 27d64ef092488e7c1720f0f5f6658f9064167e85 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
index 480096e9..4110d29d 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
@@ -1419,7 +1419,7 @@ private void listVi... | [
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs",
"source/BulkCrapUninstaller/Functions/ApplicationList/UninstallerListConfigurator.cs",
"source/BulkCrapUninstallerTests/ApplicationUninstallerEntryTests.cs",
"source/UninstallTools/ApplicationUninstallerEntry.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 895 | issue_to_patch | BCunistaller Ran into some unexpected error
BCUninstaller, Version=5.9.0.0, Culture=neutral, PublicKeyToken=null | MSIL | Microsoft Windows NT 10.0.26100.0 | 64bit
Please note that uninstall lists are saved in the "Advanced filtering" view, not by exporting. Lists should have the .bcul extension.
Error message: There... | Improve uninstall list load error handling | ## Summary
This PR makes `.bcul` uninstall list loading more robust and improves the error shown when loading fails.
## Changes
- reject empty uninstall list files with a clear error
- handle leading BOM / whitespace before the XML root element
- validate the expected root element before deserializing
- con... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 60f2d337a3a284f29a11f04b55708fbfadebd46b | diff --git a/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs b/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs
index 8a2b899f9..5592f2a1c 100644
--- a/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs
+++ b/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs
@@ ... | [
"source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs",
"source/BulkCrapUninstallerTests/UninstallListTests.cs",
"source/UninstallTools/Lists/UninstallList.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 892 | issue_to_patch | Add customization for Scoop path (and Scoop Global path)
My BCUninstaller cannot detect any app in Scoop, even if it might be fixed in #239 .
It may because I use `use_isolated_path` in `scoop config` , and the Scoop path has been changed since the Scoop installation.
<img width="1734" height="927" alt="Image" src="h... | Improve Scoop custom path detection | ## Summary
This PR improves Scoop detection for users with non-default or customized Scoop installations.
## Changes
- detect Scoop from `PATH`, not only from `SCOOP` / `SCOOP_GLOBAL` environment variables
- inspect Scoop `config.json` candidates and apply `root_path` / `global_path` overrides when present
-... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | e3fa587382aaa638a2bf2e7a2e95fee185ef5027 | diff --git a/source/UninstallTools/Factory/ScoopFactory.cs b/source/UninstallTools/Factory/ScoopFactory.cs
index 50c85f3d..7ee3c04f 100644
--- a/source/UninstallTools/Factory/ScoopFactory.cs
+++ b/source/UninstallTools/Factory/ScoopFactory.cs
@@ -36,15 +36,20 @@ private static bool GetScoopInfo()
{
... | [
"source/UninstallTools/Factory/ScoopFactory.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 875 | issue_to_patch | Updated Hungarian translation | I've translated the last few strings that were not yet translated. The Hungarian translation is now complete. | 5cf83c4194dae88b6ae639de607c4dcd2f70a074 | e64e1b5ad6ff13af5b8a500ab7d4c549dcf5b463 | diff --git a/source/BulkCrapUninstaller/Properties/Localisable.hu.resx b/source/BulkCrapUninstaller/Properties/Localisable.hu.resx
index c1506d23..41dcd67c 100644
--- a/source/BulkCrapUninstaller/Properties/Localisable.hu.resx
+++ b/source/BulkCrapUninstaller/Properties/Localisable.hu.resx
@@ -768,4 +768,19 @@ A beállí... | [
"source/BulkCrapUninstaller/Properties/Localisable.hu.resx",
"source/UninstallTools/Properties/Localisation.hu.resx",
"source/UninstallerAutomatizer/Forms/MainWindow.hu.resx",
"source/UninstallerAutomatizer/Properties/Localization.hu.resx",
"source/UniversalUninstaller/Properties/Localisation.hu.resx"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 868 | issue_to_patch | Fix publish script after v6.1 | Previously, `publish.bat` published the whole solution with `msbuild BulkCrapUninstaller.sln /t:Publish /m`. In v6.1, `/m` was removed to avoid the resulting random failures.
This PR keeps the script close to the original, but changes the publish flow to publish the intended applications one project at a time. It st... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 7a9e79bbe38c9987f468b0b2897a91f49a1e5b4e | diff --git a/publish.bat b/publish.bat
index 2a336922..3119dc60 100644
--- a/publish.bat
+++ b/publish.bat
@@ -5,31 +5,45 @@ rem Release Debug
set config=Release
set msbuild="D:\Applications\VS2022\MSBuild\Current\Bin\amd64\MSBuild.exe"
+if not exist %msbuild% call :findMsbuild
+if not exist %msbuild% (
+ echo Fail... | [
"publish.bat"
] | [
{
"comment": "The launcher should always build as x86 as it's set in the solution to allow it to run on any system. If started on a 32bit system it will give a more helpful warning message when a x86 build of BCU is not included.",
"path": "publish.bat",
"hunk": "@@ -57,13 +78,69 @@ rem ----------------... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 868 | comment_to_fix | Fix publish script after v6.1 | ```suggestion
echo ====== Publishing finished! ======
pause
``` | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 7a9e79bbe38c9987f468b0b2897a91f49a1e5b4e | diff --git a/publish.bat b/publish.bat
index 2a336922..3119dc60 100644
--- a/publish.bat
+++ b/publish.bat
@@ -5,31 +5,45 @@ rem Release Debug
set config=Release
set msbuild="D:\Applications\VS2022\MSBuild\Current\Bin\amd64\MSBuild.exe"
+if not exist %msbuild% call :findMsbuild
+if not exist %msbuild% (
+ echo Fail... | [
"publish.bat"
] | [
{
"comment": "```suggestion\necho ====== Publishing finished! ======\npause\n```",
"path": "publish.bat",
"hunk": "@@ -38,17 +52,24 @@ rem --- AnyCPU --------------------------------------------------\n \n set target=%CD%\\bin\\publish-AnyCPU-%netVer%\n \n-rmdir /q /s \"%target%\"\n-if errorlevel 1 (pau... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 865 | issue_to_patch | Swedish translation causes UI overflow in some windows
Hi, I've noticed that the Swedish translation in BCUninstaller occasionally causes text to overflow or extend beyond the boundaries of certain UI elements. This typically happens in dialog boxes or settings windows where the translated strings are longer than thei... | Fix : Swedish translation causes UI overflow in some windows #810 | This pull request fixes the UI overflow problems that were reported in #810
After looking over the situation, I saw that some of the issues had already been fixed. I have fixed the last Swedish translation string that was messing up the layout so that it fits within the UI limits.
Changes:
Changed one Swedish... | 05f2c74a9c2615be16c1e30f4e6ab5bdc7f25a51 | b423de84da03b2ef229e21c9bd50587a9a91c832 | diff --git a/source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.sv.resx b/source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.sv.resx
index c8e553fe..882067b4 100644
--- a/source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.sv.resx
+++ b/source/BulkCrapUninstaller/Contro... | [
"source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.sv.resx"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 852 | issue_to_patch | Improved handling of nested arrays in DynamicStringArrayConverter in case first token is empty or not a string | 3c9b0d81b13fb47021b329b6faab0603606ce663 | 471578eb18f9ede91003ca789c5eb9f9c2ba0f0b | diff --git a/source/BulkCrapUninstallerTests/BulkCrapUninstallerTests.csproj b/source/BulkCrapUninstallerTests/BulkCrapUninstallerTests.csproj
index e0ecd47ba..e2921a15f 100644
--- a/source/BulkCrapUninstallerTests/BulkCrapUninstallerTests.csproj
+++ b/source/BulkCrapUninstallerTests/BulkCrapUninstallerTests.csproj
@@ ... | [
"source/BulkCrapUninstallerTests/BulkCrapUninstallerTests.csproj",
"source/BulkCrapUninstallerTests/DynamicStringArrayConverterTests.cs",
"source/UninstallTools/Factory/Json/DynamicStringArrayConverter.cs",
"source/UninstallTools/Factory/ScoopFactory.cs",
"source/UninstallTools/UninstallTools.csproj"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 858 | issue_to_patch | Add detecting of all installed files for Msiexec uninstallers | 3c9b0d81b13fb47021b329b6faab0603606ce663 | 6043103cd20e9ee21c362a72b2e7fa22ef2cb3c1 | diff --git a/source/KlocTools/IO/MsiTools.cs b/source/KlocTools/IO/MsiTools.cs
index 130e0d59c..fba724b0e 100644
--- a/source/KlocTools/IO/MsiTools.cs
+++ b/source/KlocTools/IO/MsiTools.cs
@@ -4,13 +4,17 @@ Apache License Version 2.0
*/
using System;
+using System.Collections.Concurrent;
using System.Collections.G... | [
"source/KlocTools/IO/MsiTools.cs",
"source/KlocTools/Native/MsiWrapper.cs",
"source/UninstallTools/Factory/ApplicationUninstallerFactory.cs",
"source/UninstallTools/Factory/InfoAdders/MsiInfoAdder.cs"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 856 | issue_to_patch | Fix enumeration of subkeys in GetSubKeys method | 09362cfab6f321f27059f5b48d8146e0a8171b71 | 45f5a83869ccd9655315de5eefbc92b2c698c661 | diff --git a/source/KlocTools/Extensions/RegistryKeyExtensions.cs b/source/KlocTools/Extensions/RegistryKeyExtensions.cs
index 54c23b177..b6ce51f0c 100644
--- a/source/KlocTools/Extensions/RegistryKeyExtensions.cs
+++ b/source/KlocTools/Extensions/RegistryKeyExtensions.cs
@@ -29,7 +29,7 @@ public static IEnumerable<Reg... | [
"source/KlocTools/Extensions/RegistryKeyExtensions.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/KlocTools/Extensions/RegistryKeyExtensions.cs",
"hunk": "@@ -29,7 +29,8 @@ public static IEnumerable<RegistryKey> GetSubKeys(this RegistryKey obj, bool wri\n if (obj == null)\n throw new NullReferenceException();\n \n- ... | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 856 | comment_to_fix | Fix enumeration of subkeys in GetSubKeys method | ```suggestion
``` | 09362cfab6f321f27059f5b48d8146e0a8171b71 | 45f5a83869ccd9655315de5eefbc92b2c698c661 | diff --git a/source/KlocTools/Extensions/RegistryKeyExtensions.cs b/source/KlocTools/Extensions/RegistryKeyExtensions.cs
index 54c23b177..b6ce51f0c 100644
--- a/source/KlocTools/Extensions/RegistryKeyExtensions.cs
+++ b/source/KlocTools/Extensions/RegistryKeyExtensions.cs
@@ -29,7 +29,7 @@ public static IEnumerable<Reg... | [
"source/KlocTools/Extensions/RegistryKeyExtensions.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/KlocTools/Extensions/RegistryKeyExtensions.cs",
"hunk": "@@ -29,7 +29,8 @@ public static IEnumerable<RegistryKey> GetSubKeys(this RegistryKey obj, bool wri\n if (obj == null)\n throw new NullReferenceException();\n \n- ... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 855 | issue_to_patch | Fix RatingId extraction to handle missing package-family separator | 09362cfab6f321f27059f5b48d8146e0a8171b71 | 6bca01437f4cd214ec738356d809c2cb1bafb8b7 | diff --git a/source/UninstallTools/Factory/StoreAppFactory.cs b/source/UninstallTools/Factory/StoreAppFactory.cs
index 71bcc75a..44875d8a 100644
--- a/source/UninstallTools/Factory/StoreAppFactory.cs
+++ b/source/UninstallTools/Factory/StoreAppFactory.cs
@@ -51,13 +51,14 @@ public IList<ApplicationUninstallerEntry> Get... | [
"source/UninstallTools/Factory/StoreAppFactory.cs"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 854 | issue_to_patch | Improved assembly location retrieval to use Path.HasExtension for robustness | 09362cfab6f321f27059f5b48d8146e0a8171b71 | baf9eced5933467dd7507caa3ef323fe39d2540f | diff --git a/source/BulkCrapUninstaller/Program.cs b/source/BulkCrapUninstaller/Program.cs
index a489d269..76eb98c9 100644
--- a/source/BulkCrapUninstaller/Program.cs
+++ b/source/BulkCrapUninstaller/Program.cs
@@ -40,7 +40,7 @@ public static DirectoryInfo AssemblyLocation
{
var l... | [
"source/BulkCrapUninstaller/Program.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/BulkCrapUninstaller/Program.cs",
"hunk": "@@ -40,7 +40,8 @@ public static DirectoryInfo AssemblyLocation\n {\r\n var location = Assembly.GetAssembly(typeof(Program))?.Location;\r\n if (location == ... | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 854 | comment_to_fix | Improved assembly location retrieval to use Path.HasExtension for robustness | ```suggestion
``` | 09362cfab6f321f27059f5b48d8146e0a8171b71 | baf9eced5933467dd7507caa3ef323fe39d2540f | diff --git a/source/BulkCrapUninstaller/Program.cs b/source/BulkCrapUninstaller/Program.cs
index a489d269..76eb98c9 100644
--- a/source/BulkCrapUninstaller/Program.cs
+++ b/source/BulkCrapUninstaller/Program.cs
@@ -40,7 +40,7 @@ public static DirectoryInfo AssemblyLocation
{
var l... | [
"source/BulkCrapUninstaller/Program.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/BulkCrapUninstaller/Program.cs",
"hunk": "@@ -40,7 +40,8 @@ public static DirectoryInfo AssemblyLocation\n {\r\n var location = Assembly.GetAssembly(typeof(Program))?.Location;\r\n if (location == ... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 851 | issue_to_patch | Make equality check null-safe in CollectionExtensions | 09362cfab6f321f27059f5b48d8146e0a8171b71 | ef44352f3d67593b8c36815faf0f796907a1f3ec | diff --git a/source/KlocTools/Extensions/CollectionExtensions.cs b/source/KlocTools/Extensions/CollectionExtensions.cs
index afa5cdb28..3bf18195c 100644
--- a/source/KlocTools/Extensions/CollectionExtensions.cs
+++ b/source/KlocTools/Extensions/CollectionExtensions.cs
@@ -144,7 +144,7 @@ public static int GetPositionOf... | [
"source/KlocTools/Extensions/CollectionExtensions.cs"
] | [
{
"comment": "Please do not add PR comments into the code. If an LLM outputs them then include them in the comments instead.\n```suggestion\n```",
"path": "source/KlocTools/Extensions/CollectionExtensions.cs",
"hunk": "@@ -144,7 +144,8 @@ public static int GetPositionOfElement<T>(this T[] array, T eleme... | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 850 | issue_to_patch | Add guard for empty or invalid GUIDs in IsSystemGuid method | 09362cfab6f321f27059f5b48d8146e0a8171b71 | 0399af133274aee6013fe4f5c7626df904c9096a | diff --git a/source/UninstallTools/Junk/Finders/Registry/ComScanner.cs b/source/UninstallTools/Junk/Finders/Registry/ComScanner.cs
index a439fec8c..8c05199c8 100644
--- a/source/UninstallTools/Junk/Finders/Registry/ComScanner.cs
+++ b/source/UninstallTools/Junk/Finders/Registry/ComScanner.cs
@@ -270,6 +270,8 @@ private... | [
"source/UninstallTools/Junk/Finders/Registry/ComScanner.cs"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 847 | issue_to_patch | Add null check for registry key in startup entry validation | 09362cfab6f321f27059f5b48d8146e0a8171b71 | d9c75d87cb2a4995c317d977db314f8a075925b7 | diff --git a/source/UninstallTools/Startup/Normal/NewStartupDisable.cs b/source/UninstallTools/Startup/Normal/NewStartupDisable.cs
index b171391be..abc1d70f1 100644
--- a/source/UninstallTools/Startup/Normal/NewStartupDisable.cs
+++ b/source/UninstallTools/Startup/Normal/NewStartupDisable.cs
@@ -63,7 +63,7 @@ public bo... | [
"source/UninstallTools/Startup/Normal/NewStartupDisable.cs",
"source/UninstallTools/Startup/Normal/StartupEntry.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/UninstallTools/Startup/Normal/NewStartupDisable.cs",
"hunk": "@@ -63,7 +63,8 @@ public bool StillExists(StartupEntry startupEntry)\n if (startupEntry.IsRegKey)\r\n {\r\n using (var key = RegistryTools.OpenRegistry... | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 847 | comment_to_fix | Add null check for registry key in startup entry validation | ```suggestion
``` | 09362cfab6f321f27059f5b48d8146e0a8171b71 | d9c75d87cb2a4995c317d977db314f8a075925b7 | diff --git a/source/UninstallTools/Startup/Normal/NewStartupDisable.cs b/source/UninstallTools/Startup/Normal/NewStartupDisable.cs
index b171391be..abc1d70f1 100644
--- a/source/UninstallTools/Startup/Normal/NewStartupDisable.cs
+++ b/source/UninstallTools/Startup/Normal/NewStartupDisable.cs
@@ -63,7 +63,7 @@ public bo... | [
"source/UninstallTools/Startup/Normal/NewStartupDisable.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/UninstallTools/Startup/Normal/NewStartupDisable.cs",
"hunk": "@@ -63,7 +63,8 @@ public bool StillExists(StartupEntry startupEntry)\n if (startupEntry.IsRegKey)\r\n {\r\n using (var key = RegistryTools.OpenRegistry... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 847 | comment_to_fix | Add null check for registry key in startup entry validation | ```suggestion
``` | 09362cfab6f321f27059f5b48d8146e0a8171b71 | d9c75d87cb2a4995c317d977db314f8a075925b7 | diff --git a/source/UninstallTools/Startup/Normal/StartupEntry.cs b/source/UninstallTools/Startup/Normal/StartupEntry.cs
index 20c740365..8aec3f2fa 100644
--- a/source/UninstallTools/Startup/Normal/StartupEntry.cs
+++ b/source/UninstallTools/Startup/Normal/StartupEntry.cs
@@ -131,7 +131,7 @@ public override bool StillE... | [
"source/UninstallTools/Startup/Normal/StartupEntry.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/UninstallTools/Startup/Normal/StartupEntry.cs",
"hunk": "@@ -131,7 +131,8 @@ public override bool StillExists()\n if (!IsRegKey) return File.Exists(FullLongName);\r\n \r\n using (var key = RegistryTools.OpenRegistryKey(Pa... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 848 | issue_to_patch | Fix handling of closing quotes in uninstall string trimming | 09362cfab6f321f27059f5b48d8146e0a8171b71 | 939b4eee0161954dc0ba73fdf70424d13090a225 | diff --git a/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs b/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs
index ba24d276..74d57547 100644
--- a/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs
+++ b/source/BulkCrapUninstaller/Functions/Ap... | [
"source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs",
"hunk": "@@ -166,7 +166,8 @@ private static object CleanupUninstallString(string uninstallString)\n {\r\n var trimmed = uninstallString.Substring(UninstallS... | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 848 | comment_to_fix | Fix handling of closing quotes in uninstall string trimming | ```suggestion
``` | 09362cfab6f321f27059f5b48d8146e0a8171b71 | 939b4eee0161954dc0ba73fdf70424d13090a225 | diff --git a/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs b/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs
index ba24d276..74d57547 100644
--- a/source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs
+++ b/source/BulkCrapUninstaller/Functions/Ap... | [
"source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs"
] | [
{
"comment": "```suggestion\n```",
"path": "source/BulkCrapUninstaller/Functions/ApplicationList/ListViewDelegates.cs",
"hunk": "@@ -166,7 +166,8 @@ private static object CleanupUninstallString(string uninstallString)\n {\r\n var trimmed = uninstallString.Substring(UninstallS... | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 846 | issue_to_patch | Add CI workflow | 6f55f5b9549b29fce45402c859879a7cb24c02af | 53d44cf2855763f89d3db7c247fc2c43d99f2a61 | diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
new file mode 100644
index 000000000..a4a969be8
--- /dev/null
+++ b/.github/workflows/ci.yaml
@@ -0,0 +1,31 @@
+name: CI
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+
+jobs:
+
+ build:
+ runs-on: windows-latest
+
+ steps:
+... | [
".github/workflows/ci.yaml",
"README.md"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 844 | issue_to_patch | Italian language update | @Klocman
Please merge. Thanks. | 05c09b1a9d75b59fc5223263e5f04eae97ef5c12 | f99132770a0cb20efa0a7dc52d1e947e1e46b8be | diff --git a/source/BulkCrapUninstaller/Properties/Localisable.it.resx b/source/BulkCrapUninstaller/Properties/Localisable.it.resx
index 592e1d94..5c4f91be 100644
--- a/source/BulkCrapUninstaller/Properties/Localisable.it.resx
+++ b/source/BulkCrapUninstaller/Properties/Localisable.it.resx
@@ -783,4 +783,10 @@ Puoi pro... | [
"source/BulkCrapUninstaller/Properties/Localisable.it.resx"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 790 | issue_to_patch | Preliminary support for WoA64 | A quick fixup for #686. I only changed a few strings around and slightly modified the architecture detection method away from a deprecated function and to one that will stop needing a hacky workaround when/if this project goes to .NET 8. | 0d1bb6642f0c249cf37aa2280ed29451086e74e9 | 2eedf774b22e6162faf13b3d0cad17df3e1b6484 | diff --git a/source/BCU-console/BCU-console.csproj b/source/BCU-console/BCU-console.csproj
index 3514d6c70..10883f305 100644
--- a/source/BCU-console/BCU-console.csproj
+++ b/source/BCU-console/BCU-console.csproj
@@ -5,7 +5,7 @@
<OutputType>Exe</OutputType>
<RootNamespace>BCU_console</RootNamespace>
<GenerateA... | [
"source/BCU-console/BCU-console.csproj",
"source/BulkCrapUninstaller.sln",
"source/BulkCrapUninstaller/BulkCrapUninstaller.csproj",
"source/BulkCrapUninstaller/Forms/Windows/AboutBox.cs",
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs",
"source/KlocTools/KlocTools.csproj",
"source/KlocTools/Too... | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 839 | issue_to_patch | BCUninstaller has stop working suddenly - crash after compiling devices
Hi
BCuninstaller was working perfectly until, without reasons, he crashes after trying to check all devices (the program stops and closes immediately)
Here's the log
[BCUninstaller.log](https://github.com/user-attachments/files/23327388/BCUninsta... | Fix crashing on load when InfoCache.xml is corrupted | Fixes #815 | e33276d6f04b52d4451ba815afd0610d8021b51a | 24574405ddde00740a5c325e97447d3cd7d3126c | diff --git a/source/UninstallTools/Factory/ApplicationUninstallerFactoryCache.cs b/source/UninstallTools/Factory/ApplicationUninstallerFactoryCache.cs
index 081c91c6..20ad6697 100644
--- a/source/UninstallTools/Factory/ApplicationUninstallerFactoryCache.cs
+++ b/source/UninstallTools/Factory/ApplicationUninstallerFacto... | [
"source/UninstallTools/Factory/ApplicationUninstallerFactoryCache.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 838 | issue_to_patch | Clicking rename gives no response.
I have an item that I right click and choose Rename..., which has enabled appearance, but nothing happens.
Pretty straightforward really. If it can't do a rename or hit an error, it should display some message. I'm a big fan of not disabling menu items for things that aren't alway... | Add warning when trying to rename read-only uninstaller kinds | Fixes #830
| 785a2707f295b229c310cffa3cf74ac396ab75a9 | 8359bca1d83c48562b726abf8604bbc52bcd5de1 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
index 36ff92a6..480096e9 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
@@ -1050,11 +1050,14 @@ private void Rena... | [
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs",
"source/BulkCrapUninstaller/Functions/MessageBoxes.cs",
"source/BulkCrapUninstaller/Properties/Localisable.Designer.cs",
"source/BulkCrapUninstaller/Properties/Localisable.resx",
"source/BulkCrapUninstaller/Properties/Resources.Designer.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 837 | issue_to_patch | Startup stuck if es.exe is unresponsive
> Wrote by chatGPT and modified by me.
When I was using **BCUninstaller**, I was stuck at startup; it took me a while before I noticed that `es.exe` was unresponsive and killing it, allowing me finally to be able to use the app.
Also, at the same time, **Everything** was also u... | Add a 40s timeout to es.exe | Closes #832 | 816a113ab81aed0c050b6834512b8007534b3b2b | 0c49d1ab6d4c28d582d1b07526dc8f5b32bebce6 | diff --git a/source/UninstallTools/Factory/InfoAdders/FastSizeGenerator.cs b/source/UninstallTools/Factory/InfoAdders/FastSizeGenerator.cs
index 526b8510..c79dbb8f 100644
--- a/source/UninstallTools/Factory/InfoAdders/FastSizeGenerator.cs
+++ b/source/UninstallTools/Factory/InfoAdders/FastSizeGenerator.cs
@@ -7,6 +7,7 ... | [
"source/UninstallTools/Factory/InfoAdders/FastSizeGenerator.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 836 | issue_to_patch | Update es.exe to ES-1.1.0.36.x64 | https://github.com/voidtools/ES/releases/tag/1.1.0.36
~~Using x86 for maximum compatibility.~~ Actually scratch that, since BCU is now on .NET8, realistically [only Arm64 and x64 Windows](https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md#windows) systems are supported by BCU now. Therefore t... | 541f8af7fd4a78066ecb131eafd593e8f29d998b | d71d2770678c2eea27f411f1b38f326388bbaa0d | diff --git a/source/es.exe b/source/es.exe
index 148f420e..4bd7076e 100644
Binary files a/source/es.exe and b/source/es.exe differ
| [
"source/es.exe"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 835 | issue_to_patch | [Feature Request] Prepare to update BCU for upcoming .NET 10 LTS?
Title.
Is anything like that planned and if not, why?
Would be good to use the latest LTS (which will be .net 10) | Target net8.0 | I fixed all of the breaking issues and obsolete member calls for both net8 and net10, but for now I'm targeting net8 because net10 requires at least Visual Studio 2026 to be compiled.
The version can be changed in build.props at any time to net10 and it will work fine as long as the build environment is compatible. | 1ff2c03029b4dd305e7c55cc856b2f9f8ef4e9c6 | c17a0226b81bdf4e6a40508d5368e5b1430913a0 | diff --git a/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.cs b/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.cs
index 1844e6c83..72be0e1fe 100644
--- a/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.cs
+++ b/source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.cs
@@ -5,6 +5,7 @@... | [
"source/BulkCrapUninstaller/Controls/AdvancedClipboardCopy.cs",
"source/BulkCrapUninstaller/Controls/ListLegend.cs",
"source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs",
"source/BulkCrapUninstaller/Controls/Settings/PropertiesSidebar.cs",
"source/BulkCrapUninstaller/Forms/Windows/SettingsWindo... | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 834 | issue_to_patch | Consolidate project properties into Build.props; Deduplicate and clean up files | 25bd01ad6e16956ff34ac974ef72b1503211c8ee | 5b1de247179f7cf64e8cb82964813b8dc8f3dc33 | diff --git a/source/BCU-console/BCU-console.csproj b/source/BCU-console/BCU-console.csproj
index 10883f305..e10e6ff1e 100644
--- a/source/BCU-console/BCU-console.csproj
+++ b/source/BCU-console/BCU-console.csproj
@@ -1,58 +1,16 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>net6.0-windows1... | [
"source/BCU-console/BCU-console.csproj",
"source/BCU-console/Properties/AssemblyInfo.cs",
"source/BCU-console/Properties/PublishProfiles/FolderProfile.pubxml",
"source/BCU-console/Properties/app.manifest",
"source/BCU-launcher/BCU-launcher.rc",
"source/BCU-launcher/BCU-launcher.vcxproj",
"source/BulkCra... | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 798 | issue_to_patch | Updated Hungarian translation | Hi! I've updated the Hungarian translation. | 0d1bb6642f0c249cf37aa2280ed29451086e74e9 | a80e28458dd90bc5ba934a1619a180e16ea37177 | diff --git a/source/BulkCrapUninstaller/Forms/Helpers/NewsPopup.hu.resx b/source/BulkCrapUninstaller/Forms/Helpers/NewsPopup.hu.resx
index 08d13a564..8c5e066d7 100644
--- a/source/BulkCrapUninstaller/Forms/Helpers/NewsPopup.hu.resx
+++ b/source/BulkCrapUninstaller/Forms/Helpers/NewsPopup.hu.resx
@@ -120,4 +120,31 @@
... | [
"source/BulkCrapUninstaller/Forms/Helpers/NewsPopup.hu.resx",
"source/BulkCrapUninstaller/Forms/Windows/SettingsWindow.hu.resx",
"source/BulkCrapUninstaller/Properties/Localisable.hu.resx",
"source/KlocTools/Controls/SearchBox.hu.resx",
"source/UninstallTools/Properties/Localisation.hu.resx"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 797 | issue_to_patch | Press Del button in search field shows error message
Press Del button in search field shows error message, instead of deleting selected text "test" in search field.
 | Fixed Delete hotkey functionality to check app focus and disposal state | […ta…tatete](https://github.com/Klocman/Bulk-Crap-Uninstaller/issues/726)
| 0d1bb6642f0c249cf37aa2280ed29451086e74e9 | ca3a53de8a30576a56cf0b95f80c077550b21707 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
index a1d9dfda0..ada1d46bb 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
@@ -1143,7 +1143,8 @@ private void Setu... | [
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 785 | issue_to_patch | Out of screen
Hello, i have this problem for a long time.
When bulk is uninstalling, it leaves a windows at the end where you need to click << end or close >> (i think, i'm french).
Then he searches for remaining files etc.
My problem is : the window is out of screen. I have 2 monitors, one is 4k and the other one is... | Fix uninstall progress window spawning out of screen with vertically offset displays | Not all the top of screens are 0. | 1eda18211a98564989134431a4f67f9e6a642fb2 | 82844cc017a96c6f742e4818dc6fd73518d28fc6 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs
index 30a72bab..acc7c313 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/UninstallProgres... | [
"source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 766 | issue_to_patch | Resolve various compiler warnings | ca8af9119c19e9174c0ed2e2e4cb37bd8dc71b71 | db754c4ee32a331f865f0b516388cfeb6b40f1f0 | diff --git a/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs b/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs
index 5e98d662..a43dd0ed 100644
--- a/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs
+++ b/source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs
@@ -6... | [
"source/BulkCrapUninstaller/Controls/Settings/AdvancedFilters.cs",
"source/BulkCrapUninstaller/EntryPoint.cs",
"source/BulkCrapUninstaller/Forms/Helpers/AdvancedClipboardCopyWindow.cs",
"source/BulkCrapUninstaller/Forms/Helpers/FeedbackWindow.cs",
"source/BulkCrapUninstaller/Forms/Helpers/ListLegendWindow.c... | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 765 | issue_to_patch | Installer: Use AnyCPU build and auto install .NET6 if needed (portable install no longer possible) | 47d4e5018a2cebdea03330235f1f8b0cbc52bbbb | 8ec7ab88fc5c2e83002483dd7773e7335ece8ab6 | diff --git a/installer/BcuSetup.iss b/installer/BcuSetup.iss
index 10d0e968..75c4bc31 100644
--- a/installer/BcuSetup.iss
+++ b/installer/BcuSetup.iss
@@ -1,5 +1,11 @@
; Tested with innosetup-6.4.3
+; Normal: include self-contained binaries for both x86 and x64
+; Light: include only AnyCPU binaries and automati... | [
"installer/BcuSetup.iss",
"installer/CodeDependencies.iss"
] | [] | true | |||
BCUninstaller/Bulk-Crap-Uninstaller | 764 | issue_to_patch | Fix SubPathIsInsideBasePath returning false for exact match | This affects junk generation and a few other things. Fixes some random issues and potentially improves junk detection. | 6383973ba1fa97f31b725ac5983b74ef56d77721 | 2bcff91d2511c9b227cd99b40be307c11671eacb | diff --git a/source/BulkCrapUninstaller/Forms/Helpers/TargetWindow.cs b/source/BulkCrapUninstaller/Forms/Helpers/TargetWindow.cs
index 309a8558..77cfa097 100644
--- a/source/BulkCrapUninstaller/Forms/Helpers/TargetWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Helpers/TargetWindow.cs
@@ -72,7 +72,7 @@ private void Wi... | [
"source/BulkCrapUninstaller/Forms/Helpers/TargetWindow.cs",
"source/BulkCrapUninstaller/Program.cs",
"source/KlocTools/Tools/PathTools.cs",
"source/UninstallTools/Junk/Finders/Misc/ShortcutJunk.cs",
"source/UninstallTools/Junk/Finders/Registry/ComScanner.cs",
"source/UninstallTools/Junk/Finders/Registry/E... | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 762 | issue_to_patch | Clean up installer and fix compile under InnoSetup v6.4 | - Updated anything that used obsolete functions
- Removed CreateQuickLaunchIcon since it doesn't work on any supported version on Windows
- Updated translations (except for Hindi, I couldn't find a version for Innosetup v6) | 348c61979ff969c69649f4158291d6784716d5f1 | e129e2fa9b8a63bf60551712208bcd1affd6db25 | diff --git a/installer/BcuSetup.iss b/installer/BcuSetup.iss
index 94d28f98..10d0e968 100644
--- a/installer/BcuSetup.iss
+++ b/installer/BcuSetup.iss
@@ -1,4 +1,6 @@
-#define MyAppName "BCUninstaller"
+; Tested with innosetup-6.4.3
+
+#define MyAppName "BCUninstaller"
#define MyAppNameShort ... | [
"installer/BcuSetup.iss",
"installer/PortablePage.iss",
"installer/assets/bigImage.bmp",
"installer/assets/bigImage.pdn",
"installer/assets/logo.ico",
"installer/assets/smallImage.bmp",
"installer/lang/ChineseSimplified.isl",
"installer/lang/Hungarian.isl",
"installer/lang/Turkish.isl",
"installer... | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 761 | issue_to_patch | application mistakenly deleted download folder when deleting osu!lazer
Bc uninstall deleted the download folder with more than 50GB of data when deleting the osu!lazer application, I created a restore point but it failed again. Is there any way to fix it? So I lost more than 50GB of a project that I worked on for more... | Be more careful around Known Folders (especially Downloads) | - Prevent Known Folders from being directly seen as junk
- Give slightly less confidence to junk directly inside of a known folder
- Completely ignore the Downloads folder for app and junk scan | 1213b4b68582c79dfad2ffb65afff1f2a7d0bf4f | 9df8564f38356ab451395b783732324d9488f822 | diff --git a/source/BulkCrapUninstaller/Controls/FileTargeter.cs b/source/BulkCrapUninstaller/Controls/FileTargeter.cs
index 3db3baa6..349b8ad3 100644
--- a/source/BulkCrapUninstaller/Controls/FileTargeter.cs
+++ b/source/BulkCrapUninstaller/Controls/FileTargeter.cs
@@ -111,7 +111,7 @@ private void ProcessFiles(ICollec... | [
"source/BulkCrapUninstaller/Controls/FileTargeter.cs",
"source/UninstallTools/Factory/DirectoryFactory.cs",
"source/UninstallTools/Junk/Confidence/ConfidenceGenerators.cs",
"source/UninstallTools/Junk/Confidence/ConfidenceRecords.cs",
"source/UninstallTools/Junk/Finders/Drive/CommonDriveJunkScanner.cs",
"... | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 760 | issue_to_patch | Creates restore points without asking
I had uninstalled a few apps before closing my pc, and it decided to create a restore point for each. Now, maybe in some events this may be useful, but it should ask before simply doing this, and here is why: Creating restore points can override prior restore points. This was exac... | Fix restore point confirmation message never appearing | Fixes #747 | f6e027e0f717877c09a50dd388aac46ac3456625 | c3f5964fb8e3502c5ac43df3740f5b1cbafd62dd | diff --git a/source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.cs b/source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.cs
index 405bc96c..2ea9fe7d 100644
--- a/source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.cs
+++ b/source/BulkCrapUninstaller/Controls/Settings/Uni... | [
"source/BulkCrapUninstaller/Controls/Settings/UninstallationSettings.cs",
"source/BulkCrapUninstaller/Forms/Wizards/BeginUninstallTaskWizard.cs",
"source/BulkCrapUninstaller/Functions/AppUninstaller.cs",
"source/BulkCrapUninstaller/Functions/Tools/SystemRestore.cs",
"source/BulkCrapUninstaller/Properties/Se... | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 759 | issue_to_patch | How can I restore a program through a restore point after accidentally uninstalling it?请问误卸载程序后如何通过还原点还原？
I uninstalled a program, which caused data loss, but I checked the option to create a restore point before uninstalling. How can I recover it now?
我卸载了一个程序 导致数据丢失 但我卸载前勾选了创建还原点 现在我该如何恢复它？ | Various fixes to SystemRestore; Should work on all versions of Windows | 47e0afc0968776ff8df9c6d1d353e75e66657a5f | 57e5e10ff768d9ddefd8ad7b6dd319b0cffd6666 | diff --git a/source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.Designer.cs b/source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.Designer.cs
index f97c8159..4b8f2fb0 100644
--- a/source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.Designer.cs
+++ b/source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.Designer.cs
@... | [
"source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.Designer.cs",
"source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.cs",
"source/BulkCrapUninstaller/Forms/Helpers/DebugWindow.resx",
"source/BulkCrapUninstaller/Functions/Tools/SystemRestore.cs",
"source/KlocTools/IO/SysRestore.cs"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 710 | issue_to_patch | Installer script improvement | @Klocman
I updated the script to get automatically some info without need to modify them manuall
- Copyright year (used in Copyright message) get from current date
- AppVersion and AppVersionShort get automatically by main exe file
Thanks. | 23fe74542d6b781a8bc3a6cf3574258779019715 | b9bfd4001e34d6c606e21012fee76e09d13a4f9d | diff --git a/installer/BcuSetup.iss b/installer/BcuSetup.iss
index f39a7be6..9406206b 100644
--- a/installer/BcuSetup.iss
+++ b/installer/BcuSetup.iss
@@ -1,14 +1,20 @@
-#define MyAppName "BCUninstaller"
-#define MyAppNameShort "BCUninstaller"
-#define MyAppPublisher "Marcin Szeniak"
-#define MyAppURL "https://gith... | [
"installer/BcuSetup.iss"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 702 | issue_to_patch | Add Hindi translation installer | Added a complete Hindi translation for the Inno Setup installer, including UI elements, messages, error prompts, and installation instructions. This update ensures a fully localized user experience for Hindi-speaking users, improving accessibility and usability. All dialogs, buttons, and system messages have been trans... | f7c6b80569722c52edd0e269668496218700773c | 0fab04dc5ecf27e24f400ce1e7bcba5472e240bd | diff --git a/installer/BcuSetup.iss b/installer/BcuSetup.iss
index c4a9da68..39d482ba 100644
--- a/installer/BcuSetup.iss
+++ b/installer/BcuSetup.iss
@@ -71,6 +71,7 @@ Name: "it"; MessagesFile: "compiler:Languages\Italian.isl"
Name: "hu"; MessagesFile: "lang\Hungarian.isl"
Name: "vi"; MessagesFile: "lang\Vietnamese... | [
"installer/BcuSetup.iss",
"installer/lang/Hindi.isl",
"installer/scripts/Ngen.iss",
"installer/scripts/PortableIcons.iss",
"installer/scripts/PortablePage.iss",
"installer/scripts/isxdl/Hindi.ini",
"installer/scripts/products.iss"
] | [] | true | ||
Baseflow/PhotoView | 778 | issue_to_patch | Failing SonarQube CI builds due to "www" missing from gradle repositories | My SonarQube task in my CI builds was failing with a:
```
> Could not download PhotoView-2.0.0.aar (com.github.chrisbanes:PhotoView:2.0.0)
> Could not get resource 'https://jitpack.io/com/github/chrisbanes/PhotoView/2.0.0/PhotoView-2.0.0.aar'.
> Could not GET 'https://jitpack.io/com/github/chrisb... | d2a1173d74816e96560f4d60115d5fcc30f86b47 | 0fbce1017512f64bd9e22681f9bb60843d90e974 | diff --git a/README.md b/README.md
index 0289daf3..9d2552ca 100755
--- a/README.md
+++ b/README.md
@@ -9,10 +9,16 @@ Add this in your root `build.gradle` file (**not** your module `build.gradle` fi
```gradle
allprojects {
- repositories {
- maven { url "https://jitpack.io" }
+ repositories {
+ mave... | [
"README.md"
] | [] | true | ||
Baseflow/PhotoView | 765 | issue_to_patch | Translate image during scale | **This PR changes the behaviour of the scale action.**
Until now when the user scaled the image and the focus point has changed, we did not translate the image.
Now we translate the image as well allowing the user to zoom and pan the image simultaneously.
This change can be opt-in but I figured since this has beco... | d2a1173d74816e96560f4d60115d5fcc30f86b47 | 139a9ffeaf70bd628b015374cb6530fcf7d0bcb7 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java b/photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java
index 822754ff..aea97a7b 100755
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java
+++ b/photoview/sr... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/OnGestureListener.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 755 | issue_to_patch | License not included in pom file
The license is currently not mentioned in the `pom` file. This is necessary for automatic license reporting tools to correctly identify the license.
Would it be possible to include this metadata in the next release? | Include license in pom | Fixes #754
This PR does a bit more than I originally planned to do, but I had several problems building this library. The main change is the switch to the standard `maven-publish` plugin, which correctly inserts the licensing metadata in the pom file.
- Upgrad to Gradle 6.3. I had [problems](https://github.com/g... | 2aead501d8064705cb6858f035735b85bae2c701 | a03bc84c45aa88a4393f8226b3f7d30f30dbc28f | diff --git a/gradle.properties b/gradle.properties
index b363d16f..5bac8ac5 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -1,14 +1,1 @@
-VERSION_NAME=1.2.4
-VERSION_CODE=124
-GROUP=com.github.chrisbanes.photoview
-
-POM_DESCRIPTION=A simple ImageView that support zooming, both by Multi-touch gestures and do... | [
"gradle.properties",
"gradle/wrapper/gradle-wrapper.jar",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat",
"photoview/build.gradle"
] | [] | true | |
Baseflow/PhotoView | 747 | issue_to_patch | Library version updates | This PR updates the used library versions and enables android x useage at gradle.properties file | cc4d856a413c9d1c1aea2119382b2c2e45c92fb3 | 53adf745abb8aa74fe66bb4c88cc62c0ad0af6f8 | diff --git a/build.gradle b/build.gradle
index 7a1cacbf..16629891 100755
--- a/build.gradle
+++ b/build.gradle
@@ -6,7 +6,7 @@ buildscript {
}
dependencies {
- classpath 'com.android.tools.build:gradle:3.5.3'
+ classpath 'com.android.tools.build:gradle:3.6.0'
classpath 'com.github.dce... | [
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"photoview/build.gradle",
"sample/build.gradle"
] | [
{
"comment": "This part should not be needed.",
"path": "gradle.properties",
"hunk": "@@ -12,3 +12,6 @@ POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt\n POM_LICENCE_DIST=repo\n POM_DEVELOPER_ID=chrisbanes\n POM_DEVELOPER_NAME=Chris Banes\n+\n+android.useAndroidX=true\n+android.enableJeti... | true | ||
Baseflow/PhotoView | 640 | issue_to_patch | Allow parent intercept touches on top and bottom edges. | It needed for "scroll to dismiss" feature. | 56fbd307a27e782b268aa7d77cf66435cc481ba0 | d550921a20a655c2fa462edd3487e2997007f522 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java b/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
index 8144a6a4..f8494d41 100644
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
+++ b/photoview/src/main/java/... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 666 | issue_to_patch | Added image bounce on scaling down | Removed scaling down restriction in order to let image bounce from scaled down size to normal size. This is how it looks now:
| 0564bdef1c3b9636a6afcc3b665b35e6878ca10f | 8f231f5f2e7c9a49b8c0ebfd368451a9fa940b43 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java b/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
index 18f1744c..8144a6a4 100644
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
+++ b/photoview/src/main/java/... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 667 | issue_to_patch | Fixed quick scaling flipped image | ### Bug Description
Good bug description here - [Quick Scale issue](https://github.com/signalapp/Signal-Android/issues/8061). This issue is caused by broken method `getScaleFactor()` in `ScaleGestureDetector.java`:
```
public float getScaleFactor() {
if (inAnchoredScaleMode()) {
// Drag is moving up;... | 0564bdef1c3b9636a6afcc3b665b35e6878ca10f | bb45af31ec2c5c6dd3ec92ce902d66044dfa5dbd | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java b/photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java
index 0c2c6049..822754ff 100755
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java
+++ b/photoview/sr... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/CustomGestureDetector.java"
] | [] | true | ||
Baseflow/PhotoView | 632 | issue_to_patch | Fix getPointerCount() calls | When I submitted pull request #621 I accidentally replaced `MotionEventCompat.getPointerCount(e2)` with `e1.getPointerCount()` instead of `e2.getPointerCount()`.
Thank you to @rexih for noticing! | d69cc122f69802d4e69bfff8e30cf11ba933acbc | 7cd26009764389a560c62e9bea279a9456be0eeb | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java b/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
index 0972646c..67042c18 100644
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
+++ b/photoview/src/main/java/... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 621 | issue_to_patch | Call getPointerCount() without using support-core-utils | MotionEventCompat.getPointerCount is deprecated and using support libraries will cause problems in the future.
Google is renaming all support library packages with the Android P release, please see https://developer.android.com/topic/libraries/support-library/androidx-rn for further information.
With calling `getPo... | 82e03f83a2f85a82fc0b89e35fa4177bf5ced49b | 44963b73b7305e57c5b9c979952e4662bd91b497 | diff --git a/photoview/build.gradle b/photoview/build.gradle
index 968efdda..58dae544 100644
--- a/photoview/build.gradle
+++ b/photoview/build.gradle
@@ -13,8 +13,4 @@ android {
}
}
-dependencies {
- implementation "com.android.support:support-core-utils:$supportLibVersion"
-}
-
apply from: 'https://raw.gi... | [
"photoview/build.gradle",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 622 | issue_to_patch | Update README.md | I updated the links of HackyDrawerLayout.java | 82e03f83a2f85a82fc0b89e35fa4177bf5ced49b | 93e5871897b27ea8b7610b99b442116fca864cbd | diff --git a/README.md b/README.md
index 13978c8b..279a2d3a 100755
--- a/README.md
+++ b/README.md
@@ -44,7 +44,7 @@ photoView.setImageResource(R.drawable.image);
That's it!
## Issues With ViewGroups
-There are some ViewGroups (ones that utilize onInterceptTouchEvent) that throw exceptions when a PhotoView is place... | [
"README.md"
] | [] | true | ||
Baseflow/PhotoView | 614 | issue_to_patch | Build with Android 27 | 86d7c19379faa3180ac8fc6d36a23e59a68807ee | e14b39dc4cf708936d5eb24f9e8c7ae85cc1f824 | diff --git a/build.gradle b/build.gradle
index e3b1ad04..2d0cc08c 100755
--- a/build.gradle
+++ b/build.gradle
@@ -1,11 +1,13 @@
buildscript {
repositories {
jcenter()
+ google()
+ mavenCentral()
}
dependencies {
- classpath 'com.android.tools.build:gradle:2.3.3'
- ... | [
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"photoview/build.gradle",
"sample/build.gradle"
] | [] | true | |||
Baseflow/PhotoView | 570 | issue_to_patch | Update README.md | Moved from compile to implementation | 462338c694e45e056f9e0dc4c3d3fb83c30139d7 | da89c22e592a0b6fff13873b5b1d0e34f1a21381 | diff --git a/README.md b/README.md
index cd786a59..13978c8b 100755
--- a/README.md
+++ b/README.md
@@ -18,7 +18,7 @@ allprojects {
Then, add the library to your module `build.gradle`
```gradle
dependencies {
- compile 'com.github.chrisbanes:PhotoView:latest.release.here'
+ implementation 'com.github.chrisbanes... | [
"README.md"
] | [] | true | ||
Baseflow/PhotoView | 515 | issue_to_patch | setScale not functioning when animate == false unless after long delay
I'm currently trying to use `setScale` on an image in a `ViewPager` and I'm running into some trouble.
I'm fully aware that I need to delay the calling of post and in the following example, this works as expected.
```
@Override
public PhotoVi... | Fix maxscale | First, revert back to old logic for layout change listener. [old logic](https://github.com/chrisbanes/PhotoView/commit/1de1e50c7ae2a560abe8202f005a4765b32f39ba#diff-ba07f735ed51a279480298ac9e3d9b37L369)
It should fix https://github.com/chrisbanes/PhotoView/issues/452 and https://github.com/chrisbanes/PhotoView/issues/... | 9dd9fba55d10e742bbed16bd009e73deb1891af3 | 94332067e04a471162528b7f054027498e327f14 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoView.java b/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoView.java
index aebcff39..dd1c9717 100644
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoView.java
+++ b/photoview/src/main/java/com/github/chrisbanes/ph... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoView.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | |
Baseflow/PhotoView | 517 | issue_to_patch | Ignore layout change event if no bounds has been changed | `PhotoView#onLayoutChange` may be invoked when no layout has been changed.
For instance, when you call `setSystemUiVisibility` to a decor view, `onLayoutChange` would be invoked though some of those events does not involve a change of bounds.
So, we gotta check if the layout is actually changed or not before callin... | 57e11bc5c4b752bb84a5510b1d2d0e0c6d0b87c7 | 23710f3dba6daec04d01790c28e69b2fc8610916 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java b/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
index 3991e3fd..3288b9a4 100644
--- a/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java
+++ b/photoview/src/main/java/... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 502 | issue_to_patch | Add OnViewTapListener which behaves same as the one in 1.x | I think some people needs OnViewTapListener even in v2.0.
For example, think about PhotoViews inside a ViewPager.
What if I want to implement a feature something like going previous/next page on tap left/right side?
Neither OnPhotoTapListener nor OnOutsidePhotoTapListener is enough.
(OnOutsidePhotoTapListener lac... | a322cc0469484196b8e2ac6641bd6215acc51658 | cf1020a29871df337e16b7f84e632a89d3ec1756 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/OnViewTapListener.java b/photoview/src/main/java/com/github/chrisbanes/photoview/OnViewTapListener.java
new file mode 100644
index 00000000..68562551
--- /dev/null
+++ b/photoview/src/main/java/com/github/chrisbanes/photoview/OnViewTapListener.java
@@... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/OnViewTapListener.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoView.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 513 | issue_to_patch | Add OnViewDragListener | I've been using PhotoView for a while now and it would be nice if there was a way that I could implement my own callback when an onDrag of the image occurs. In this pull request, I added an `OnViewDragListener` and implemented it to the PhotoView | 323bee00679e2a7014db0063f00999b2d7d50f21 | 351f2bc52ac1584e41a174ea3eac32d09fcf8176 | diff --git a/photoview/src/main/java/com/github/chrisbanes/photoview/OnViewDragListener.java b/photoview/src/main/java/com/github/chrisbanes/photoview/OnViewDragListener.java
new file mode 100644
index 00000000..66999a5e
--- /dev/null
+++ b/photoview/src/main/java/com/github/chrisbanes/photoview/OnViewDragListener.java... | [
"photoview/src/main/java/com/github/chrisbanes/photoview/OnViewDragListener.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoView.java",
"photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 435 | issue_to_patch | Fix Simple Sample / Capture Display Matrix Crash | I found `Simple Sample > Menu > Capture Display Matrix` to crash.
mCurrentDisplayMatrix was null.
And I think that `Restore Display Matrix` feature works fine in below code .
```
case R.id.menu_matrix_capture:
- mAttacher.getDisplayMatrix(mCurrentDisplayMatrix);
+ mAtta... | 9354b9217b92a16a54b8f04875cb93fff0d6c8f6 | 93273f5cf79e8d773481c66d612a488ff8a34ae9 | diff --git a/sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java b/sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java
index a3f095ef..7c4f0637 100755
--- a/sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java
+++ b/sample/src/main/java/uk/co/senab/... | [
"sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java"
] | [] | true | ||
Baseflow/PhotoView | 427 | issue_to_patch | Replace word "project" with "module" to avoid confusion in grade setu… | …p instructions
| 061fc8c91490008c0bbeba8520d108039083afe2 | e5f5e7669949527303a62e774f943583c7763cd8 | diff --git a/README.md b/README.md
index 00de258a..f43915d7 100755
--- a/README.md
+++ b/README.md
@@ -23,7 +23,7 @@ allprojects {
}
```
-Then, add the library to your project `build.gradle`
+Then, add the library to your module `build.gradle`
```gradle
dependencies {
compile 'com.github.chrisbanes:PhotoView... | [
"README.md"
] | [] | true | ||
Baseflow/PhotoView | 400 | issue_to_patch | Correct typos | 97bfec6df6b85d9198760e746ef6a828a12702d5 | 662f95774df6273305531087ca198f68bfbdcd2c | diff --git a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
index beb42c33..377807bf 100755
--- a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttache... | [
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | |||
Baseflow/PhotoView | 394 | issue_to_patch | Fix post-Lollipop shared elements transition animations | Fix this issue: https://github.com/chrisbanes/PhotoView/issues/243
The main problem was that PhotoView does not override getImageMatrix
method, and when ChangeImageTransform call image.getImageMatrix() it
will receive matrix not from PhotoViewAttacher, but from PhotoView's
parent ImageView.
| 852bcc07b1b6bc177f52f97d2e65a4dff6b3b8ce | 685fc7c5f8fab6151f830dd70a172b28c0ec13b3 | diff --git a/library/src/main/java/uk/co/senab/photoview/PhotoView.java b/library/src/main/java/uk/co/senab/photoview/PhotoView.java
index 66177e40..78b0b8e6 100755
--- a/library/src/main/java/uk/co/senab/photoview/PhotoView.java
+++ b/library/src/main/java/uk/co/senab/photoview/PhotoView.java
@@ -123,6 +123,11 @@ publ... | [
"library/src/main/java/uk/co/senab/photoview/PhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 392 | issue_to_patch | Update compile SDK and support lib to 24 | Update to target build tool 24.0.0, targetSdkVersion 24 and Support lib 24.1.1.
| 6c4d5b5bb70f30c0447d23f63dafde025f56922a | e72429aea401fee3c208463c5e0c207409f30804 | diff --git a/library/build.gradle b/library/build.gradle
index c293a7d9..7bc2d706 100755
--- a/library/build.gradle
+++ b/library/build.gradle
@@ -1,19 +1,19 @@
apply plugin: 'com.android.library'
android {
- compileSdkVersion 23
- buildToolsVersion '23.0.3'
+ compileSdkVersion 24
+ buildToolsVersion '2... | [
"library/build.gradle",
"sample/build.gradle"
] | [] | true | ||
Baseflow/PhotoView | 362 | issue_to_patch | Fix typo in README.md | d7bf03540fd54a614d62cc37293cdf2a8fd19db8 | 89ba6120a51d90ad90b9a88da07f3f6af5457b20 | diff --git a/README.md b/README.md
index 94ff3667..e9190f16 100755
--- a/README.md
+++ b/README.md
@@ -9,7 +9,7 @@ Branch **Master**: [![Build Status](https://travis-ci.org/chrisbanes/PhotoView.p
## Features
- Out of the box zooming, using multi-touch and double-tap.
- Scrolling, with smooth scrolling fling.
-- Work... | [
"README.md"
] | [] | true | |||
Baseflow/PhotoView | 361 | issue_to_patch | Small code spring clean | There were a few things which I had noticed that appeared to be redundant, so I had decided to remove them.
| 5394c11b94164dff0d29667ca98baa1c6ce72553 | cbe43f5eea0ffc91b27b064a7386bc73b95709ee | diff --git a/sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java b/sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java
index 711cc4b9..a3f095ef 100755
--- a/sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java
+++ b/sample/src/main/java/uk/co/senab/... | [
"sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java",
"sample/src/main/java/uk/co/senab/photoview/sample/ViewPagerActivity.java",
"sample/src/main/res/menu/main_menu.xml",
"sample/src/main/res/values/strings.xml"
] | [] | true | ||
Baseflow/PhotoView | 360 | issue_to_patch | Make getOnViewTapListener() and getOnPhotoTapListener() package local | I removed these two methods from the `IPhotoView` interface as obviously methods inherited from the interface have to be `public`. It also makes more sense to remove them from the interface as it shouldn't be possible to override them via `getIPhotoViewImplementation()`. Previously discussed [here](https://github.com/c... | 565abe58b8724714e13d363d99245c02b59bdd65 | ec0776031801750b75694814367d2faba4dea535 | diff --git a/library/src/main/java/uk/co/senab/photoview/IPhotoView.java b/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
index 91c948a1..a597d436 100755
--- a/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
+++ b/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
@@ -158,17 +158,6 @@ ... | [
"library/src/main/java/uk/co/senab/photoview/IPhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 359 | issue_to_patch | Remove redundant variable which is always false | `mFirstScroll` is initialised to `false` and then is reassigned to `false`, thus making the `if` statement redundant as it never returns `true`.
| 956a00ca80e58da6c90edab295361f4aa9f1ff1e | 3e13a68cdf5a2127ce1c45880582e9cd561d66bd | diff --git a/library/src/main/java/uk/co/senab/photoview/scrollerproxy/GingerScroller.java b/library/src/main/java/uk/co/senab/photoview/scrollerproxy/GingerScroller.java
index c58cdb96..e831ce36 100755
--- a/library/src/main/java/uk/co/senab/photoview/scrollerproxy/GingerScroller.java
+++ b/library/src/main/java/uk/co... | [
"library/src/main/java/uk/co/senab/photoview/scrollerproxy/GingerScroller.java"
] | [] | true | ||
Baseflow/PhotoView | 340 | issue_to_patch | Deprecate getOnPhotoTapListener and getOnViewTapListener and update support library dependencies | Deprecate the getters for these listeners as discussed in [#338](https://github.com/chrisbanes/PhotoView/pull/338).
| 622cf19f9c12f56cdf46dfa6b4c22bf18d9c92d4 | bff7467f9b0926fc2ae976a4c8ea0e8c14c9d26a | diff --git a/library/build.gradle b/library/build.gradle
index 3bfb3eb1..ab6f747e 100755
--- a/library/build.gradle
+++ b/library/build.gradle
@@ -14,7 +14,7 @@ android {
}
dependencies {
- compile "com.android.support:support-v4:23.2.1"
+ compile "com.android.support:support-v4:23.3.0"
}
//./gradlew clea... | [
"library/build.gradle",
"library/src/main/java/uk/co/senab/photoview/IPhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java",
"library/src/main/java/uk/co/senab/photoview/gestures/CupcakeGestureDetector.java",
"li... | [] | true | ||
Baseflow/PhotoView | 297 | issue_to_patch | add a callback that can accept a tap touch event when user touch out … | I add a callback in OnPhotoTapListener that can accept a tap touch event when user touch out of the photo so that I can do something when I touch somewhere out of the photo.
| f2f3f739d403cb501d2fd588b31cd809a4a5529d | e96e38b3cf35d75c7f4afbecd4c971bd87dabac5 | diff --git a/library/src/main/java/uk/co/senab/photoview/DefaultOnDoubleTapListener.java b/library/src/main/java/uk/co/senab/photoview/DefaultOnDoubleTapListener.java
index d0ba1ef0..c82ec3ce 100755
--- a/library/src/main/java/uk/co/senab/photoview/DefaultOnDoubleTapListener.java
+++ b/library/src/main/java/uk/co/senab... | [
"library/src/main/java/uk/co/senab/photoview/DefaultOnDoubleTapListener.java",
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java",
"sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java"
] | [] | true | ||
Baseflow/PhotoView | 322 | issue_to_patch | (Reopen) Fix IllegalArgumentException occurred on 'onTouchEvent' | reopen before pull request on master branch (https://github.com/chrisbanes/PhotoView/pull/321)
---
I catch IllegalArgumentException occurred on 'TouchManagerFroyoGestureDetector.java:64' by error report.
It is logged in Android issue.
https://code.google.com/p/android/issues/detail?id=163954
| b4cbaeb7bcde0e4f8361f00fe0abb8cc4836c05e | 93d72e95932232b59d0db34d07f42a7325ef97e7 | diff --git a/library/src/main/java/uk/co/senab/photoview/gestures/EclairGestureDetector.java b/library/src/main/java/uk/co/senab/photoview/gestures/EclairGestureDetector.java
index 2d5215b1..c467e1c8 100755
--- a/library/src/main/java/uk/co/senab/photoview/gestures/EclairGestureDetector.java
+++ b/library/src/main/java... | [
"library/src/main/java/uk/co/senab/photoview/gestures/EclairGestureDetector.java",
"library/src/main/java/uk/co/senab/photoview/gestures/FroyoGestureDetector.java"
] | [] | true | ||
Baseflow/PhotoView | 291 | issue_to_patch | Add a callback if the user flings anywhere on the view | I need to detecting user's fling action. So I add some line hat determine user's single touch action and send event to listener(I give a name, OnSingleFlingListener).
| f2f3f739d403cb501d2fd588b31cd809a4a5529d | 9ee836af3c28ffb29f6af2179f2d87eb33d96c10 | diff --git a/library/src/main/java/uk/co/senab/photoview/IPhotoView.java b/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
index b36b2135..5f6b8ca7 100755
--- a/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
+++ b/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
@@ -346,4 +346,11 @@ ... | [
"library/src/main/java/uk/co/senab/photoview/IPhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java",
"sample/src/main/java/uk/co/senab/photoview/sample/SimpleSampleActivity.java"
] | [] | true | ||
Baseflow/PhotoView | 319 | issue_to_patch | Popular Android library badge | I'm generating badges to highlight awesome open source Android libraries. They are ranked based on how many top apps the library is used in. If you would like to include it, I've added it to the README. If not, no problem, just close this. Let me know if you have any questions. Cheers!
| d299db09741af464dca7d695ed08824dbdcc6604 | 16a54bc44e3c90551f6c2da6c3e798b6eb476f2d | diff --git a/README.md b/README.md
index 90306f27..0101daac 100755
--- a/README.md
+++ b/README.md
@@ -5,6 +5,8 @@ Branch **Master**: [
+[![Badge](http://www.libtastic.com... | [
"README.md"
] | [] | true | ||
Baseflow/PhotoView | 296 | issue_to_patch | Introduce base rotation property for proper orientation handling | This actually provides a sane fix for #128 We've had this fix internally for a while, but are now hoping it makes it into the library so we dont have to compile our fork instead of including a dependency.
Users can now specify a base rotation amount (for setting the orientation based off EXIF information , for example... | f2f3f739d403cb501d2fd588b31cd809a4a5529d | 2632ba2afd22d291ba7c5ccc3d2027ac5c4a55d3 | diff --git a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
index 31ecfa13..19e262ed 100755
--- a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttache... | [
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 304 | issue_to_patch | Added void getDisplayMatrix(matrix) and corrected getDisplayMatrix documentation | - Updated documentation in IPhotoView to resolve invalid return value comment
- Added getDisplayMatrix(matrix) to IPhotoView to permit copy without allocation
- Implemented getDisplayMatrix(matrix) in PhotoViewAttacher
- Implemented getDisplayMatrix(matrix) proxy method in PhotoView
| f2f3f739d403cb501d2fd588b31cd809a4a5529d | 250391cb2e92b8543318a15283834d5a04f13939 | diff --git a/library/src/main/java/uk/co/senab/photoview/IPhotoView.java b/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
index b36b2135..d3ac9a61 100755
--- a/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
+++ b/library/src/main/java/uk/co/senab/photoview/IPhotoView.java
@@ -58,10 +58,18 @@ p... | [
"library/src/main/java/uk/co/senab/photoview/IPhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoView.java",
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 255 | issue_to_patch | Ensure the scale changed listener responds to animation events, Closes #254 | ...254
| 40aa26788ca412a1442cccf446965675e8988d7c | b4dc5d87352bcf82d91fc28947aee6eee24e5e56 | diff --git a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
index c7e18637..884a8ee4 100755
--- a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttache... | [
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 240 | issue_to_patch | Fix for regression on issue #72. | If the PhotoView gesture detector handles scaling or dragging the PhotoView, we will continue to block the parent view from receiving onTouch events. If the gesture detector did not scale or drag the PhotoView at all, we allow the parent to properly receive all touch events.
Tested on 4.x and 5.x in an Activity with b... | 0aae4b5ca9a4b17f03e031f9cd97e9d0736b7714 | b2889624675d8a09ccfa762b17392fa3aaf7ca0f | diff --git a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
index 8ba6325a..c7e18637 100755
--- a/library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/main/java/uk/co/senab/photoview/PhotoViewAttache... | [
"library/src/main/java/uk/co/senab/photoview/PhotoViewAttacher.java",
"library/src/main/java/uk/co/senab/photoview/gestures/CupcakeGestureDetector.java",
"library/src/main/java/uk/co/senab/photoview/gestures/GestureDetector.java"
] | [] | true | ||
Baseflow/PhotoView | 93 | issue_to_patch | Removed dependency to android support library | The dependency to the `com.android.support:support-v4:18.0.+` is not needed in the library module. This PR removes the dependency in the library `build.gradle`.
| 3f2b0c08f5260b2b313c97534ece954db9a29029 | 3e45f589a83e843f806b17203fbcfb865a66aa3d | diff --git a/library/build.gradle b/library/build.gradle
index 47d0f3fa..04164305 100644
--- a/library/build.gradle
+++ b/library/build.gradle
@@ -1,9 +1,5 @@
apply plugin: 'android-library'
-dependencies {
- compile 'com.android.support:support-v4:18.0.+'
-}
-
android {
compileSdkVersion 18
buildTools... | [
"library/build.gradle"
] | [] | true | ||
Baseflow/PhotoView | 95 | issue_to_patch | Updated travis config to install build-tools | Check https://plus.google.com/u/0/101739875387504930639/posts/HmmKCPfkg2b for more informations
| f9022ff2c79864bb1b96e6f8e8249d4332318019 | a0e3128bae54c963a386bdfc61c6a037d9eef1e6 | diff --git a/.travis.yml b/.travis.yml
index a4383de4..6e07fa82 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -30,12 +30,7 @@ before_install:
- export PATH=${PATH}:${ANDROID_HOME}/tools:${ANDROID_HOME}/platform-tools
# manually set sdk.dir variable, according to local paths
- echo "sdk.dir=$ANDROID_HOME" > loc... | [
".travis.yml"
] | [] | true | ||
Baseflow/PhotoView | 122 | issue_to_patch | Return the draw matrix instead of the supplemental matrix on getDisplayMatrix | For the display matrix returned from the attacher's getDisplayMatrix, return the composition of local changes with the changes based on the scaling type of the base imageView.
I don't know enough about the original intention of getDisplayMatrix to know what the intent was here, but:
1) returning the drawing matrix se... | 8c365aaa61aae87e3037bf1f6875f2e703bfedc8 | 0aa6cd9827709c7583c791e25873a8ad5260e919 | diff --git a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
index c28ac368..3cff8078 100644
--- a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
@@ -670,7 +670,7 @@ public final ... | [
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 80 | issue_to_patch | Refactored AnimatedZoomRunnable to use a TimeInterpolator | This fixes #61
| 4bb6e2df134a910de27cee302e3d8d3e23cbef80 | 87a31b7568c65e8d59e3f63e4d7d15030adab8a7 | diff --git a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
index 0db27370..066384ec 100644
--- a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
@@ -15,6 +15,7 @@
*************... | [
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [
{
"comment": "TimeInterpolator is added in API 11 (http://developer.android.com/reference/android/animation/TimeInterpolator.html) either backport it with the pull request (only if it is really necessary), or change the sInterpolator to `android.view.animation.Interpolator` (directly interface type)\n",
"pa... | true | ||
Baseflow/PhotoView | 100 | issue_to_patch | Do not drag if we are already scaling. | Scaling does not zoom to the correct focal point. This is due to the fact that we are allowing dragging and scaling at the same time. I've disabled dragging when we are scaling in onDrag.
| edd3393217e2c1e408369216fc98656e1b8eda69 | ad50acc09216326f3a19a6666d3a831430363583 | diff --git a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
index d40d1631..6fdffbce 100644
--- a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
@@ -346,6 +346,10 @@ public final... | [
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 138 | issue_to_patch | How to get PhotoView with Maven or Gradle in README.md
please tell the developer how to get PhotoView with Maven or Gradle in README.md,
Thank You. | Update README.md | fixed #137
| 8c365aaa61aae87e3037bf1f6875f2e703bfedc8 | 8c4b6f0e9755b9957400ec03bbfd1d353bcf3403 | diff --git a/README.md b/README.md
index dc79c9de..e5e730a3 100644
--- a/README.md
+++ b/README.md
@@ -14,6 +14,22 @@ PhotoView aims to help produce an easily usable implementation of a zooming Andr
- Allows the application to be notified when the displayed Matrix has changed. Useful for when you need to update your U... | [
"README.md"
] | [] | true | |
Baseflow/PhotoView | 134 | issue_to_patch | Updated Android Gradle plugin to support Gradle 1.9. | Updatd build.gradle to use Gradle 1.9. Unfortunately we cannot use Gradle 1.10 yet.
| 5fb040bcbd3d3ed46bf799808eef6f20eb6f709a | 041ff5b649ed8f08f9c7a5ffbaf832d05b325e3f | diff --git a/.travis.yml b/.travis.yml
index 830f9439..60752e98 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -17,9 +17,9 @@ before_install:
# for gradle output style
- export TERM=dumb
# newer version of gradle
- - wget http://services.gradle.org/distributions/gradle-1.8-bin.zip
- - unzip -qq gradle-1.8-bin... | [
".travis.yml",
"build.gradle",
"sample/AndroidManifest.xml",
"sample/build.gradle"
] | [] | true | ||
Baseflow/PhotoView | 26 | issue_to_patch | Support long-press listener in Attacher | Hi there. Consider pulling this small feature to enable long-press in PhotoView-enabled views, or some derivation of it, into your dev branch. All the best!
| fbe7598ffdbdc40aa92590e079fcca7b9fdaf7d9 | c082509dbff5d65e09292bbcaf1ae71a73f8fd8d | diff --git a/library/src/uk/co/senab/photoview/PhotoView.java b/library/src/uk/co/senab/photoview/PhotoView.java
index 16e8bff7..ae092285 100644
--- a/library/src/uk/co/senab/photoview/PhotoView.java
+++ b/library/src/uk/co/senab/photoview/PhotoView.java
@@ -117,6 +117,12 @@ public void setOnMatrixChangeListener(OnMatr... | [
"library/src/uk/co/senab/photoview/PhotoView.java",
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 38 | issue_to_patch | More cleanup changes | The pull request is not totally clean, but the idea is there.
cleanup() needs some cleaning so it doesn't crash later for no reason. This one fixes the ViewAdapter removal crash and alos some rare crash where onSingleTapConfirmed is called after the view is gone.
I think the code is simple and obvious enough to be in... | db1921b57bbfe78b574652cdc12ffe6d694cd09d | 5d7fb5035fcd2dcda5082df9e7c7124c3a286c3d | diff --git a/library/res/.nofile b/library/res/.nofile
new file mode 100644
index 00000000..e69de29b
diff --git a/library/res/layout/main.xml b/library/res/layout/main.xml
deleted file mode 100644
index 0b3e0637..00000000
--- a/library/res/layout/main.xml
+++ /dev/null
@@ -1,12 +0,0 @@
-<?xml version="1.0" encoding="ut... | [
"library/res/.nofile",
"library/res/layout/main.xml",
"library/res/values/strings.xml",
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 37 | issue_to_patch | Fixes an issue when PhotoView is in a ViewPager | don't keep the ViewObserver as it may not be alive when we need to remove our view
The page with a PhotoView would be destroyed and the observer was marked as not being alive, but the listener was still called later, triggering the throw in PhotoViewAttacher saying not to use it anymore (cleanup already done).
This p... | db1921b57bbfe78b574652cdc12ffe6d694cd09d | c18ece691ad8e3ad0808536d978b9b4c160102ec | diff --git a/library/res/.nofile b/library/res/.nofile
new file mode 100644
index 00000000..e69de29b
diff --git a/library/res/layout/main.xml b/library/res/layout/main.xml
deleted file mode 100644
index 0b3e0637..00000000
--- a/library/res/layout/main.xml
+++ /dev/null
@@ -1,12 +0,0 @@
-<?xml version="1.0" encoding="ut... | [
"library/res/.nofile",
"library/res/layout/main.xml",
"library/res/values/strings.xml",
"library/src/uk/co/senab/photoview/LogManager.java",
"library/src/uk/co/senab/photoview/Logger.java",
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 96 | issue_to_patch | Updated SDK and Build-Tools versions to the most current ones. | 4a748608aa52cd5dc1714757c83cf48a085c58df | a6bd05720a06de878ed2ecfd24790e8c3679d96a | diff --git a/.travis.yml b/.travis.yml
index 6e07fa82..22e2895c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -23,15 +23,15 @@ before_install:
- export PATH=$GRADLE_HOME/bin:$PATH
# just to test gradle version, against our provided one
- gradle -v
- # newest android SDK 22.0.5
- - wget http://dl.google.com/a... | [
".travis.yml",
"library/build.gradle",
"sample/build.gradle"
] | [] | true | |||
Baseflow/PhotoView | 6 | issue_to_patch | Big boys don't cry | Why didn't you test it before merging? Banes!
| 5bc658a727822dd38dd0038d966427963c5a2d07 | 4444b3d760eeedd3f03c37b50b9eb02bf61002c9 | diff --git a/library/src/uk/co/senab/photoview/PhotoView.java b/library/src/uk/co/senab/photoview/PhotoView.java
index 8a4bb92d..7eeb214d 100644
--- a/library/src/uk/co/senab/photoview/PhotoView.java
+++ b/library/src/uk/co/senab/photoview/PhotoView.java
@@ -71,7 +71,9 @@ public float getScale() {
@Override
public ... | [
"library/src/uk/co/senab/photoview/PhotoView.java",
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 101 | issue_to_patch | Allow images to be zoomed in when double clicked. | Modified the onDoubleTap method to first check if the scale is less than the medium scale.
This was the case until edd339327 when this was changed to getMinimumScale which stopped images zooming in on double tap.
| 50dee125d043c6acac58f30af9c49d43a870bd8a | bb69ae35ad8c9828a4943c70ae1f258fd5f9153d | diff --git a/library/src/uk/co/senab/photoview/DefaultOnDoubleTapListener.java b/library/src/uk/co/senab/photoview/DefaultOnDoubleTapListener.java
index 404f55ab..d0ba1ef0 100644
--- a/library/src/uk/co/senab/photoview/DefaultOnDoubleTapListener.java
+++ b/library/src/uk/co/senab/photoview/DefaultOnDoubleTapListener.ja... | [
"library/src/uk/co/senab/photoview/DefaultOnDoubleTapListener.java"
] | [] | true | ||
Baseflow/PhotoView | 42 | issue_to_patch | Crash in PhotoViewAttacher after the view is gone | I also get crashes when the fling is still being run but the view is gone.
The patch not tested in production yet, extra tests in the fling Runnable may be necessary
This is the kinf of crash I get:
java.lang.IllegalStateException: ImageView no longer exists. You should not use this PhotoViewAttacher any more.
at ... | 5ffef295c119ad9d4530f13ea97f98125775f344 | 731a37a2241ce70aa50b9a1d170c743921f1eef0 | diff --git a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
index dcb01268..913995d8 100644
--- a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
@@ -189,6 +189,9 @@ public final ... | [
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java",
"library/src/uk/co/senab/photoview/ScrollerProxy.java"
] | [] | true | ||
Baseflow/PhotoView | 116 | issue_to_patch | Zoom enabled false fix and fix for allowing flexibility for new IPhotoView classes | **Fixes for two bugs I ran into:**
1) One prevented me from implementing my own PhotoView class (_as I could not extend PhotoView directly due to needing a pre-existing base class_).
2) When you set Zoomable to false, it was not properly scaling as FIT_CENTER. Instead it was just displaying actual size. No scaling. (_... | 8c365aaa61aae87e3037bf1f6875f2e703bfedc8 | 01af33b16ca44211eaffd342d97bc5ee5c3479a9 | diff --git a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
index c28ac368..188c9b96 100644
--- a/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
+++ b/library/src/uk/co/senab/photoview/PhotoViewAttacher.java
@@ -117,7 +117,7 @@ private stati... | [
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true | ||
Baseflow/PhotoView | 19 | issue_to_patch | Update request | - added possibility to use OnViewTapListener which ignores loaded photo bounds and processed touches from whole the view
| 4ee118c3f64c9185f8d3d7f4b1aac997af64b639 | c6fc342c4859e00f5a133eacaa8f87379b411114 | diff --git a/library/src/uk/co/senab/photoview/PhotoView.java b/library/src/uk/co/senab/photoview/PhotoView.java
index 3f659ef5..4c8468db 100644
--- a/library/src/uk/co/senab/photoview/PhotoView.java
+++ b/library/src/uk/co/senab/photoview/PhotoView.java
@@ -17,6 +17,7 @@
import uk.co.senab.photoview.PhotoViewAttach... | [
"library/src/uk/co/senab/photoview/PhotoView.java",
"library/src/uk/co/senab/photoview/PhotoViewAttacher.java"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.