repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
BetterErrors/better_errors | 520 | issue_to_patch | Require sassc only in development | This change moves the `require` call to only be invoked the first time that the Sass files are compiled. This solves the issue of applications that don't use Sass loading `better_errors` without needing to install `sassc` (see https://github.com/BetterErrors/better_errors/issues/516), and is an alternative resolution t... | 55ce4f69be35f652e4b967ad2f720ec4d6c5c72f | 6f2d1ead80d5e3d9c2cb4a58cc3d9e49636ae6b7 | diff --git a/lib/better_errors/error_page_style.rb b/lib/better_errors/error_page_style.rb
index 2d14fde5..ff1cb858 100644
--- a/lib/better_errors/error_page_style.rb
+++ b/lib/better_errors/error_page_style.rb
@@ -1,9 +1,9 @@
-require "sassc"
-
module BetterErrors
# @private
module ErrorPageStyle
def self.... | [
"lib/better_errors/error_page_style.rb"
] | [
{
"comment": "The condition here isn't strictly necessary, since multiple calls to `require` will short-circuit on second-and-subsequent invocations.\r\n\r\n```suggestion\r\n require \"sassc\"\r\n```",
"path": "lib/better_errors/error_page_style.rb",
"hunk": "@@ -1,9 +1,9 @@\n-require \"sassc\"\n-\... | true | ||
BetterErrors/better_errors | 504 | issue_to_patch | fix typo | 3cb344a3a74ee543b14c8ba524ac34ff01009552 | 0732b3043fdde32bb2a1bdb91394e6c79f4f458f | diff --git a/README.md b/README.md
index 5847a86d..d34cdb41 100644
--- a/README.md
+++ b/README.md
@@ -120,8 +120,8 @@ BetterErrors.maximum_variable_inspect_size = 100_000
```ruby
# e.g. in config/initializers/better_errors.rb
# This will stop BetterErrors from trying to inspect objects of these classes, which can c... | [
"README.md"
] | [] | true | |||
BetterErrors/better_errors | 500 | issue_to_patch | Switch to Rouge for syntax highlighting and add dark syntax-highlighting theme | Rouge seems to be more actively developed, and most importantly its CSS class names are compatible with [Pygments](https://pygments.org), which means there are more up-to-date themes available for it.
I found a good source (a gist) for Solarized themes that included the Pygments variables, and I built them as SCSS u... | db2086f86fcf8e2891480324c991aa34ccc74dd5 | 7edd3a25823706fe5601bd4e04f8ebe8b2110aca | diff --git a/better_errors.gemspec b/better_errors.gemspec
index 60a14810..a6cae6d3 100644
--- a/better_errors.gemspec
+++ b/better_errors.gemspec
@@ -31,7 +31,7 @@ Gem::Specification.new do |s|
# simplecov and coveralls must not be included here. See the Gemfiles instead.
s.add_dependency "erubi", ">= 1.0.0"
-... | [
"better_errors.gemspec",
"lib/better_errors.rb",
"lib/better_errors/code_formatter.rb",
"lib/better_errors/code_formatter/html.rb",
"lib/better_errors/error_page.rb",
"lib/better_errors/style/main.scss",
"lib/better_errors/style/syntax_highlighting.scss",
"lib/better_errors/style/syntax_highlighting_d... | [] | diff --git a/spec/better_errors/code_formatter/html_spec.rb b/spec/better_errors/code_formatter/html_spec.rb
new file mode 100644
index 00000000..406a9394
--- /dev/null
+++ b/spec/better_errors/code_formatter/html_spec.rb
@@ -0,0 +1,52 @@
+require "spec_helper"
+
+RSpec.describe BetterErrors::CodeFormatter::HTML do
+ ... | true | |
BetterErrors/better_errors | 499 | issue_to_patch | Syntax highlighter uses classes, style-src locked down | - Use CSS classes to provide code syntax highlighting style.
- That gets rid of the last use of `style` attributes, so add a nonce to the style tag and lock down the `style-src` Content Security Policy.
- Also fix the attempted load of a favicon. We never referred to one in Better Erors, but the browser attempts to l... | a52d063318014375c6a923d029a4ff78d747609b | e115f3680115f53862ec5e72010463c3f8b56edf | diff --git a/Rakefile b/Rakefile
index cdc19a8f..0eac245d 100644
--- a/Rakefile
+++ b/Rakefile
@@ -41,7 +41,7 @@ end
namespace :style do
desc "Build main.css from the SASS sources"
task :build do
- css = BetterErrors::ErrorPageStyle.compiled_style(true)
+ css = BetterErrors::ErrorPageStyle.compiled_css(tru... | [
"Rakefile",
"lib/better_errors/code_formatter.rb",
"lib/better_errors/code_formatter/html.rb",
"lib/better_errors/error_page_style.rb",
"lib/better_errors/middleware.rb",
"lib/better_errors/style/main.scss",
"lib/better_errors/style/syntax_highlighting.scss",
"lib/better_errors/templates/main.erb"
] | [] | true | ||
BetterErrors/better_errors | 498 | issue_to_patch | Use SASS to build CSS | This should allow more productivity when developing CSS changes. In development, the scss is compiled without compression and including line comments to help with development.
By moving the block of CSS out of `main.erb`, the file is reduced by a substantial amount, which should make development a bit easier as well... | 698b4c6fe189675317b2d7255d3425682e7d9c16 | 5625bf83a6729866438ed3e4f35c7823b72877b9 | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 57887159..a1253a54 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -48,10 +48,14 @@ jobs:
run: |
bundle exec gem bump better_errors --version ${{ steps.get_version.outputs.version }} --no-c... | [
".github/workflows/release.yml",
".gitignore",
"Rakefile",
"better_errors.gemspec",
"lib/better_errors/error_page.rb",
"lib/better_errors/error_page_style.rb",
"lib/better_errors/style/main.scss",
"lib/better_errors/templates/main.erb"
] | [] | true | ||
BetterErrors/better_errors | 497 | issue_to_patch | Add Content Security Policy | Add our own Content Security Policy headers when Better Errors responds, which heavily restricts the resources that can be used/referenced, but allows our scripts and styles. It uses a nonce for the script blocks, but currently we rely on inline style because of the way syntax highlighting works (which will change some... | 133f7950d5dc2fecadaf661415a0451deeef6b6a | b9d9ab7ec103ba15a3d302b7539c8b0bd14598db | diff --git a/lib/better_errors/editor.rb b/lib/better_errors/editor.rb
index b8de8fb7..96ffc3f0 100644
--- a/lib/better_errors/editor.rb
+++ b/lib/better_errors/editor.rb
@@ -84,6 +84,10 @@ def url(raw_path, line)
url_proc.call(file, line)
end
+ def scheme
+ url('/fake', 42).sub(/:.*/, ':')
+ e... | [
"lib/better_errors/editor.rb",
"lib/better_errors/error_page.rb",
"lib/better_errors/middleware.rb",
"lib/better_errors/templates/main.erb",
"lib/better_errors/templates/text.erb",
"lib/better_errors/templates/variable_info.erb",
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 74d4f2bb..ba8ce8f9 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -13,7 +13,7 @@ module BetterErrors
let(:error_page) { ErrorPage.new exception, { "PATH_INFO" => "/s... | true | |
BetterErrors/better_errors | 493 | issue_to_patch | Add Rails 6.1 to CI matrix | [6.1.0rc1](https://weblog.rubyonrails.org/2020/11/2/Rails-6-1-rc1-release/) is out, so let's make sure we remain compatible.
| fce143f9fc7eb7713feb87610b85139c7da1f836 | 6d555850780d13fc6864e7f8983d56ce4df8e7e2 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 300ea272..598146b7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -31,16 +31,19 @@ jobs:
- rails51
- rails52
- rails60
+ - rails61
- rails42_haml
- rails50_haml... | [
".github/workflows/ci.yml",
"gemfiles/rails61.gemfile",
"gemfiles/rails61_boc.gemfile",
"gemfiles/rails61_haml.gemfile"
] | [] | true | ||
BetterErrors/better_errors | 492 | issue_to_patch | Fix setting editor with symbol | The changes in commit 6591cf998872940ae64086444aa59be30f1cbe9c broke setting an editor with a symbol, when the method `Editor.for_symbol` was renamed to `Editor.editor_from_symbol`. | afc1e3ef534aaf9888bfc12f6b407cc7f9e4ddb7 | 1f65a70f1dbba0f6e294ee820dfd1e957c46572d | diff --git a/lib/better_errors.rb b/lib/better_errors.rb
index af46bdd5..346a1b1d 100644
--- a/lib/better_errors.rb
+++ b/lib/better_errors.rb
@@ -106,7 +106,7 @@ def self.editor
#
def self.editor=(editor)
if editor.is_a? Symbol
- @editor = Editor.for_symbol(editor)
+ @editor = Editor.editor_from_s... | [
"lib/better_errors.rb",
"spec/better_errors_spec.rb"
] | [] | diff --git a/spec/better_errors_spec.rb b/spec/better_errors_spec.rb
index fbec6e7c..10597158 100644
--- a/spec/better_errors_spec.rb
+++ b/spec/better_errors_spec.rb
@@ -4,7 +4,7 @@
describe ".editor" do
context "when set to a specific value" do
before do
- allow(BetterErrors::Editor).to receive(... | true | |
BetterErrors/better_errors | 491 | issue_to_patch | Fix "live shell" hint reappearing when frame changed | Fixes the work just merged in #490. The hint was reappearing when the user clicked a different frame.
This logic didn't belong inside of the `REPL` prototype anyway, so moving it out of there. Using CSS to hide it, we only need to add a body class at startup, or later, but only once. | 66f2949416c119edb18db51b040555c8f3244c1b | 9d7256b441b4bc3becd90de663df887db7614186 | diff --git a/lib/better_errors/templates/main.erb b/lib/better_errors/templates/main.erb
index 5da0c530..c282c29f 100644
--- a/lib/better_errors/templates/main.erb
+++ b/lib/better_errors/templates/main.erb
@@ -595,6 +595,9 @@
color: #8080a0;
padding-left: 20px;
}
+ .console-has-been-used .liv... | [
"lib/better_errors/templates/main.erb",
"lib/better_errors/templates/variable_info.erb"
] | [] | true | ||
BetterErrors/better_errors | 488 | issue_to_patch | Improve editor support for virtual environments | - [x] Add support for `BETTER_ERRORS_EDITOR` env var, which is used instead of `EDITOR` if present.
- [x] Add `%{file_unencoded}` replacement to editor formatting string, so when a URL needs to be unencoded, it doesn't require a Proc.
- [x] Add support for `BETTER_ERRORS_EDITOR_URL` env var, which allows the editor t... | 54aa288216272b61dd3e26989387d51f9960e622 | 123f9b327e8dc9c960c87dfaf876a8d519be57a4 | diff --git a/lib/better_errors.rb b/lib/better_errors.rb
index 8cd6b7ec..af46bdd5 100644
--- a/lib/better_errors.rb
+++ b/lib/better_errors.rb
@@ -11,20 +11,9 @@
require "better_errors/raised_exception"
require "better_errors/repl"
require "better_errors/stack_frame"
+require "better_errors/editor"
module BetterE... | [
"lib/better_errors.rb",
"lib/better_errors/editor.rb",
"lib/better_errors/error_page.rb",
"spec/better_errors/editor_spec.rb",
"spec/better_errors_spec.rb",
"spec/spec_helper.rb"
] | [] | diff --git a/spec/better_errors/editor_spec.rb b/spec/better_errors/editor_spec.rb
new file mode 100644
index 00000000..ca0127a3
--- /dev/null
+++ b/spec/better_errors/editor_spec.rb
@@ -0,0 +1,270 @@
+require "spec_helper"
+
+RSpec.describe BetterErrors::Editor do
+ describe ".for_formatting_string" do
+ it "retur... | true | |
BetterErrors/better_errors | 490 | issue_to_patch | “This is a live shell. Type in here.” gets old *really* fast.
We know it’s live already. No need to tell us.
Granted, this is nitpicking, but it would a lot cleaner without that message. Please? :grin:
Apart from that little detail, I absolutely love this gem. Great job, guys! | Hide "live shell" hint after console has been used | This is an implementation of the request in #315, but instead of removing the hint completely, it's shown only when the console has never been used.
The JS on the page sets a cookie when the user types in the console, and hides the hint if that cookie is present. (The cookie will expire after one year.)
![2020-11... | bf34bbf315e6c975bf03ddfc8353b5b51a60673c | a5293dfdbd5e414e27cf19d1a69f5500f033b744 | diff --git a/lib/better_errors/templates/main.erb b/lib/better_errors/templates/main.erb
index c7c8c6a8..5da0c530 100644
--- a/lib/better_errors/templates/main.erb
+++ b/lib/better_errors/templates/main.erb
@@ -611,17 +611,6 @@
margin: 10px 0;
}
- .sub:before {
- content: '';
- display:... | [
"lib/better_errors/templates/main.erb",
"lib/better_errors/templates/variable_info.erb"
] | [] | true | |
BetterErrors/better_errors | 487 | issue_to_patch | Text response should include the path to the console
While opening `/__better_errors` is a very useful feature, it doesn't seem to be broadly known about.
When Better Errors is responding to a non-HTML format request, it returns a text-format error with backtrace. This would be a very good place to mention the `/__... | Mention path in text response | Add a simple note to the text error response that points the developer at the `/__better_errors` path so they can interact with the console.
Fixes #486
| 65c562c3da658908191e87d5debe86d877d5fcbe | 931ffa04cf7153f2d54c30eac798017368447e6e | diff --git a/lib/better_errors/templates/text.erb b/lib/better_errors/templates/text.erb
index f51f1eed..0a99cc4b 100644
--- a/lib/better_errors/templates/text.erb
+++ b/lib/better_errors/templates/text.erb
@@ -1,7 +1,10 @@
<%== text_heading("=", "%s at %s" % [exception_type, request_path]) %>
-> <%== exception_mess... | [
"lib/better_errors/templates/text.erb",
"spec/better_errors/middleware_spec.rb"
] | [] | diff --git a/spec/better_errors/middleware_spec.rb b/spec/better_errors/middleware_spec.rb
index 4f5e9bcb..0cdd8216 100644
--- a/spec/better_errors/middleware_spec.rb
+++ b/spec/better_errors/middleware_spec.rb
@@ -147,8 +147,8 @@ module BetterErrors
it "shows the exception as-is" do
expect(status... | true |
BetterErrors/better_errors | 302 | issue_to_patch | Exception Hints | I work with a lot of people who are new to coding, and have found that people often get tripped up with reading Ruby exceptions. For example:
``` ruby
user = User.where(...).first
user # => nil
user.save # NoMethodError: undefined method `save' for nil:NilClass
```
While precise, error messages like this don't do a v... | 95d811f794ff0c61a8782d737ec0b2c3eb319167 | 081fa8454913cc443d285b2bd247fbaf79f0e070 | diff --git a/lib/better_errors/raised_exception.rb b/lib/better_errors/raised_exception.rb
index 4057d5bf..39f11c4f 100644
--- a/lib/better_errors/raised_exception.rb
+++ b/lib/better_errors/raised_exception.rb
@@ -1,7 +1,7 @@
# @private
module BetterErrors
class RaisedException
- attr_reader :exception, :messa... | [
"lib/better_errors/raised_exception.rb",
"lib/better_errors/templates/main.erb",
"spec/better_errors/raised_exception_spec.rb"
] | [] | diff --git a/spec/better_errors/raised_exception_spec.rb b/spec/better_errors/raised_exception_spec.rb
index 435c0139..6ffe86b1 100644
--- a/spec/better_errors/raised_exception_spec.rb
+++ b/spec/better_errors/raised_exception_spec.rb
@@ -68,5 +68,42 @@ module BetterErrors
subject.backtrace.first.line.should =... | true | |
BetterErrors/better_errors | 489 | issue_to_patch | Use Github Actions for CI | With the [restrictions that TravisCI has had to place on builds](https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing), we're unable to continue testing (because it's been taknig about 3 hours for Travis to run just one build).
This is a real shame, because Travis CI has been supporting free software projects... | 64d5be2525ed3c89c2616e23ce742c9ba1979f8c | db589f2463d274f54a003442a11858bd6dc546af | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
new file mode 100644
index 00000000..d2f0943e
--- /dev/null
+++ b/.github/workflows/ci.yml
@@ -0,0 +1,127 @@
+name: CI
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+ branches: [ master ]
+
+jobs:
+ test:
+ runs-on: ubuntu-latest
+ ... | [
".github/workflows/ci.yml",
".travis.yml",
"gemfiles/pry010.gemfile",
"gemfiles/pry011.gemfile",
"gemfiles/pry09.gemfile",
"gemfiles/rack.gemfile",
"gemfiles/rack_boc.gemfile",
"gemfiles/rails42.gemfile",
"gemfiles/rails42_boc.gemfile",
"gemfiles/rails42_haml.gemfile",
"gemfiles/rails50.gemfile"... | [] | diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index 29e5ac18..9828c3f3 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -2,19 +2,31 @@
ENV["EDITOR"] = nil
-# Ruby 2.4.0 and 2.4.1 has a bug with its Coverage module that causes segfaults.
-# https://bugs.ruby-lang.org/issues/13305
-# 2.4.2 shou... | true | |
BetterErrors/better_errors | 481 | issue_to_patch | Fix CSRF_TOKEN_COOKIE_NAME wrong reference to VERSION constant | It might relate to discussion at https://github.com/BetterErrors/better_errors/issues/479
After upgrading to `2.8.2` I started experiencing the following error:
```ruby
11:58:02 rails.1 | /Users/my-user/.rvm/gems/ruby-2.6.6/gems/better_errors-2.8.2/lib/better_errors/middleware.rb:43:in `<class:Middleware>‘: unin... | be7475b7a5bce98bdee64aa373c7c65397521196 | 90789f99ff1a5575f79758db562c810d20d64a25 | diff --git a/lib/better_errors.rb b/lib/better_errors.rb
index ee7a48bd..8cd6b7ec 100644
--- a/lib/better_errors.rb
+++ b/lib/better_errors.rb
@@ -3,6 +3,7 @@
require "coderay"
require "uri"
+require "better_errors/version"
require "better_errors/code_formatter"
require "better_errors/inspectable_value"
require ... | [
"lib/better_errors.rb",
"lib/better_errors/middleware.rb"
] | [] | true | ||
BetterErrors/better_errors | 480 | issue_to_patch | Fix 'uninitialized constant BetterErrors::Middleware::VERSION' | Due to the changes with CSRF_TOKEN_COOKIE_NAME, when using Better Errors version 2.8.2 I would get the following error:
~/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/bootsnap-1.4.8/lib/bootsnap/load_path_cache/core_ext/active_support.rb:61:in `block in load_missing_constant': uninitialized constant BetterErrors::... | be7475b7a5bce98bdee64aa373c7c65397521196 | 0ac88dcfd60a5340ae7212d3a07a38ce8e65892e | diff --git a/lib/better_errors/middleware.rb b/lib/better_errors/middleware.rb
index 8215c70b..3a437819 100644
--- a/lib/better_errors/middleware.rb
+++ b/lib/better_errors/middleware.rb
@@ -40,7 +40,7 @@ def self.allow_ip!(addr)
allow_ip! "127.0.0.0/8"
allow_ip! "::1/128" rescue nil # windows ruby doesn't ha... | [
"lib/better_errors/middleware.rb"
] | [] | true | ||
BetterErrors/better_errors | 478 | issue_to_patch | Invalid CSRF Token error in Better Errors console
I'm running Rails 6.0.3.3. I'm using TurboLinks 5.2.0, StimulusJS 1.1.1, and rails-ujs 6.0.3 via Webpacker 5.2.1, and not directly using Sprockets (except for ActiveAdmin). Browser is Safari 13.1.2 on macOS 10.15.6.
My layout includes output of `csrf_meta_tags` in... | Fix path of CSRF Token cookie | Fixes #476.
Since the initial Better Errors console can be opened on any path, the CSRF cookie might be set initially within a path. This would limit the visibility of the cookie, causing subsequent requests to internal Better Errors calls (which are are at `/__better_errors`) to fail because the cookie is not avail... | a9d1c4b74732840ea988031ce529ce6edf034791 | da0e0d971bfc32b646e6a86d959086b3779e340b | diff --git a/lib/better_errors/middleware.rb b/lib/better_errors/middleware.rb
index aab0210d..8215c70b 100644
--- a/lib/better_errors/middleware.rb
+++ b/lib/better_errors/middleware.rb
@@ -40,7 +40,7 @@ def self.allow_ip!(addr)
allow_ip! "127.0.0.0/8"
allow_ip! "::1/128" rescue nil # windows ruby doesn't ha... | [
"lib/better_errors/middleware.rb"
] | [] | true | |
BetterErrors/better_errors | 473 | issue_to_patch | Add TruffleRuby to CI builds | 86c19fcb607336fec78c18816ae663f8d8d492e8 | 08cade63a08aafd6f246e8325d1300050b79c2ef | diff --git a/.travis.yml b/.travis.yml
index 62e47495..0193b6d9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,6 +14,7 @@ rvm:
- 2.6.5
- 2.7.0
- ruby-head
+ - truffleruby-head
gemfile:
- gemfiles/rails42.gemfile
- gemfiles/rails50.gemfile
@@ -96,3 +97,15 @@ matrix:
gemfile: gemfiles/rails42_b... | [
".travis.yml"
] | [] | true | |||
BetterErrors/better_errors | 477 | issue_to_patch | When ActionView::Template::Error is shown, live shell is missing on last frame
The synthesized frame doesn't have a binding, so there's no live shell for it. There is a binding that could be used for this frame, but it's in the `cause`'s top stack frame, not deeper in the most recent (topmost) error's stack frame.
... | Show real cause of ActionView::Template::Error with Rails 6 | In #459 we stopped always showing the `cause` of an exception. This backs that out a bit by adding a special case for `ActionView::Template::Error` provided by Rails 6. This should solve the incorrect backtrace in that case.
Here's how this came to be:
1. [v0.0.1 of Better Errors](https://github.com/BetterErrors/... | 39395368110c8fac4374c813f7f0d3cd3888f973 | 32fc91d1b4c7c0ff19323ebc3a1c601f5d4dc772 | diff --git a/lib/better_errors/raised_exception.rb b/lib/better_errors/raised_exception.rb
index 63eae39e..f47812f6 100644
--- a/lib/better_errors/raised_exception.rb
+++ b/lib/better_errors/raised_exception.rb
@@ -4,8 +4,18 @@ class RaisedException
attr_reader :exception, :message, :backtrace
def initializ... | [
"lib/better_errors/raised_exception.rb",
"spec/better_errors/raised_exception_spec.rb"
] | [] | diff --git a/spec/better_errors/raised_exception_spec.rb b/spec/better_errors/raised_exception_spec.rb
index 99bc8218..e5fe6837 100644
--- a/spec/better_errors/raised_exception_spec.rb
+++ b/spec/better_errors/raised_exception_spec.rb
@@ -10,12 +10,32 @@ module BetterErrors
its(:message) { is_expected.to eq "who... | true |
BetterErrors/better_errors | 475 | issue_to_patch | Validate internal request method names | Internal calls expose exception information which might contain some sensitive information. The method name was taken from the request path and called on the `ErrorPage` instance without validation, which might have led to an insecure situation if a method was added to the `ErrorPage` class without us realizing that it... | 8e8e796bfbde4aa088741823c8a3fc6df2089bb0 | aa073f6f07ee05894a56e3cf79710e809051b0f3 | diff --git a/lib/better_errors/middleware.rb b/lib/better_errors/middleware.rb
index 11036128..aab0210d 100644
--- a/lib/better_errors/middleware.rb
+++ b/lib/better_errors/middleware.rb
@@ -75,7 +75,7 @@ def allow_ip?(env)
def better_errors_call(env)
case env["PATH_INFO"]
when %r{/__better_errors/(?... | [
"lib/better_errors/middleware.rb",
"spec/better_errors/middleware_spec.rb"
] | [] | diff --git a/spec/better_errors/middleware_spec.rb b/spec/better_errors/middleware_spec.rb
index 44b38fd1..6a6a48f6 100644
--- a/spec/better_errors/middleware_spec.rb
+++ b/spec/better_errors/middleware_spec.rb
@@ -294,7 +294,7 @@ def initialize(message, original_exception = nil)
let(:request_env) {
Rac... | true | |
BetterErrors/better_errors | 474 | issue_to_patch | Add CSRF protection to internal requests | Better Errors accepts requests from its own Javascript components in order to provide variables and evaluate console commands. These are now protected by a CSRF token that's set as a cookie when the error page is rendered. | 86c19fcb607336fec78c18816ae663f8d8d492e8 | 4f05b45f23277872438689d14c22fab7f03ad0b7 | diff --git a/lib/better_errors/error_page.rb b/lib/better_errors/error_page.rb
index 1f049f39..05a7e7bf 100644
--- a/lib/better_errors/error_page.rb
+++ b/lib/better_errors/error_page.rb
@@ -26,7 +26,7 @@ def id
@id ||= SecureRandom.hex(8)
end
- def render(template_name = "main")
+ def render(templa... | [
"lib/better_errors/error_page.rb",
"lib/better_errors/middleware.rb",
"lib/better_errors/templates/main.erb",
"spec/better_errors/middleware_spec.rb"
] | [] | diff --git a/spec/better_errors/middleware_spec.rb b/spec/better_errors/middleware_spec.rb
index 8a7ffa69..44b38fd1 100644
--- a/spec/better_errors/middleware_spec.rb
+++ b/spec/better_errors/middleware_spec.rb
@@ -4,9 +4,14 @@ module BetterErrors
describe Middleware do
let(:app) { Middleware.new(->env { ":)" }... | true | |
BetterErrors/better_errors | 440 | issue_to_patch | Allow editor links to work inside an iframe or with CSP that prohibits other protocols | restrictions for apps running in a third-party iframe | 448c9f2f109723d292723310ed950e7bafeaa47e | 7204a5bedadabaf6b66ae5ddeece767697c1c001 | diff --git a/README.md b/README.md
index 5ea231bc..d428c13d 100644
--- a/README.md
+++ b/README.md
@@ -35,6 +35,28 @@ end
_Note: If you discover that Better Errors isn't working - particularly after upgrading from version 0.5.0 or less - be sure to set `config.consider_all_requests_local = true` in `config/environme... | [
"README.md",
"lib/better_errors/templates/variable_info.erb",
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 0e75af51..74d4f2bb 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -76,15 +76,44 @@ module BetterErrors
end
context "variable inspection" do
+ let(:html) { ... | true | |
BetterErrors/better_errors | 465 | issue_to_patch | Question: Any plan to support ActionableError?
Hi,
Any plan to support Actionable Errors released with Rails 6?
Add `Run pending migrations` button
Rails 6 added ActiveSupport::ActionableError module to define actions we want perform on errors, right from the error page.
PendingMigrationError added by default a bu... | Support for Rails ActionableError | Fixes #443, fixes #455.
This adds support for actionable exceptions in Rails. For example, when a migration needs to be run it'll offer a button that can run the migrations for the user.
Original Actionable Errors PR in Rails: https://github.com/rails/rails/pull/34788
This is what the original PR uses to creat... | 355966bb5a2a67bae065f72fea5930abca25088a | 87cc62d7dfeef345a28cee3e68a867fffe41af1f | diff --git a/lib/better_errors/error_page.rb b/lib/better_errors/error_page.rb
index 666e39a8..1f049f39 100644
--- a/lib/better_errors/error_page.rb
+++ b/lib/better_errors/error_page.rb
@@ -28,6 +28,11 @@ def id
def render(template_name = "main")
binding.eval(self.class.template(template_name).src)
+ ... | [
"lib/better_errors/error_page.rb",
"lib/better_errors/templates/main.erb",
"spec/better_errors/error_page_spec.rb"
] | [
{
"comment": "```suggestion\r\n context 'when ActiveSupport does not provide any actions for this error type' do\r\n```",
"path": "spec/better_errors/error_page_spec.rb",
"hunk": "@@ -37,6 +37,44 @@ module BetterErrors\n expect(response).to have_tag('.exception h2', /ZeroDivisionError/)\n ... | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index ef13e6a5..0e75af51 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -37,6 +37,44 @@ module BetterErrors
expect(response).to have_tag('.exception h2', /ZeroDivisionErro... | true |
BetterErrors/better_errors | 465 | comment_to_fix | Support for Rails ActionableError | ```suggestion
context 'when ActiveSupport does not provide any actions for this error type' do
``` | 355966bb5a2a67bae065f72fea5930abca25088a | 87cc62d7dfeef345a28cee3e68a867fffe41af1f | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index ef13e6a5..0e75af51 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -37,6 +37,44 @@ module BetterErrors
expect(response).to have_tag('.exception h2', /ZeroDivisionErro... | [
"spec/better_errors/error_page_spec.rb"
] | [
{
"comment": "```suggestion\r\n context 'when ActiveSupport does not provide any actions for this error type' do\r\n```",
"path": "spec/better_errors/error_page_spec.rb",
"hunk": "@@ -37,6 +37,44 @@ module BetterErrors\n expect(response).to have_tag('.exception h2', /ZeroDivisionError/)\n ... | true | ||
BetterErrors/better_errors | 463 | issue_to_patch | binding_of_caller hides stack trace for ActionView::Template::Error
The `binding_of_caller` gem causes the stack trace to be limited and it becomes less relevant since it just errors out on the view
Example without binding of a caller
```
ActionView::Template::Error - Mode 'default' is not supported for hardwar... | Show location of error in ActionView template error | Fixes #461, fixes #462.
Previous to Rails 5.1, when an error was raised in a template, it included the location within the template in the backtrace. As of 5.1, the exception was replaced with an `ActionView::Template::Error` which provides `file_name` and `line_number` but does not include those in the backtrace. I... | 4703817f7f49c0032e108b5ed708b80234f91a49 | 73c02ede6f17f81ad70fae65c6faa0cddbba6b4d | diff --git a/lib/better_errors/raised_exception.rb b/lib/better_errors/raised_exception.rb
index d029536c..63eae39e 100644
--- a/lib/better_errors/raised_exception.rb
+++ b/lib/better_errors/raised_exception.rb
@@ -57,6 +57,10 @@ def setup_backtrace_from_backtrace
def massage_syntax_error
case exception.c... | [
"lib/better_errors/raised_exception.rb",
"spec/better_errors/raised_exception_spec.rb"
] | [] | diff --git a/spec/better_errors/raised_exception_spec.rb b/spec/better_errors/raised_exception_spec.rb
index 76c51f72..99bc8218 100644
--- a/spec/better_errors/raised_exception_spec.rb
+++ b/spec/better_errors/raised_exception_spec.rb
@@ -18,7 +18,7 @@ module BetterErrors
its(:message) { is_expected.to eq "som... | true |
BetterErrors/better_errors | 459 | issue_to_patch | better_errors should show Exception#cause when present
When `better_errors` shows an unhandled exception, it should show also the cause exception returned by `Exception#cause`.
`Exception#cause` is set automatically since Ruby 2.1, see http://devblog.avdi.org/2013/12/25/exception-causes-in-ruby-2-1/. | Show the last-raised error, not its "cause" | Fixes #296. More discussion in #433.
The change here is to show the most recent exception raised. Previously on Ruby versions supporting `Exception#cause` it would show the most recent exception's _cause_ if there was one.
The behavior in Rails of showing an "original exception" is still in place. This seems to b... | d0afd13382d6d2e22ada83f83c6d70199742787c | 8942ee39ce446507fe70367cb38e84d6b4dbdb5f | diff --git a/lib/better_errors/raised_exception.rb b/lib/better_errors/raised_exception.rb
index f3ee36ae..9e804f77 100644
--- a/lib/better_errors/raised_exception.rb
+++ b/lib/better_errors/raised_exception.rb
@@ -4,9 +4,8 @@ class RaisedException
attr_reader :exception, :message, :backtrace
def initialize... | [
"lib/better_errors/raised_exception.rb",
"spec/better_errors/middleware_spec.rb"
] | [] | diff --git a/spec/better_errors/middleware_spec.rb b/spec/better_errors/middleware_spec.rb
index 216051db..8a7ffa69 100644
--- a/spec/better_errors/middleware_spec.rb
+++ b/spec/better_errors/middleware_spec.rb
@@ -93,62 +93,68 @@ module BetterErrors
expect(status).to eq(500)
end
- if Exception.n... | true |
BetterErrors/better_errors | 449 | issue_to_patch | Allow skipping variable inspection by class name | This adds a new global setting `BetterErrors.ignored_classes` that will skip inspecting the value of local and instance variables of this type.
The default setting ignores action dispatch request and response instances, which are usually not printed anyways due to exceeding the limit of `BetterErrors.maximum_variabl... | 593db030ee06333911aaf4845918bb0f0ce3e7b0 | af1991131d16c0d4857a04e5698b51f1c5815986 | diff --git a/README.md b/README.md
index 7ddee48b..5ea231bc 100644
--- a/README.md
+++ b/README.md
@@ -93,6 +93,16 @@ See [the wiki for instructions on configuring the editor](https://github.com/Bet
BetterErrors.maximum_variable_inspect_size = 100_000
```
+## Ignore inspection of variables with certain classes.
+
+... | [
"README.md",
"lib/better_errors.rb",
"lib/better_errors/error_page.rb",
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 5ea07403..ef13e6a5 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -1,5 +1,7 @@
require "spec_helper"
+class ErrorPageTestIgnoredClass; end
+
module BetterErrors
desc... | true | |
BetterErrors/better_errors | 458 | issue_to_patch | Fix warning: __FILE__ in eval may not return location in binding | When I used better_errors with rails-6.0.2.1 and ruby-2.7.0, I got the following warnings.
```
/Users/yuuu/src/github.com/fusic/mockmock-web/vendor/bundle/ruby/2.7.0/gems/better_errors-2.6.0/lib/better_errors/raised_exception.rb:40: warning: in `eval'
/Users/yuuu/.rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/bund... | d0afd13382d6d2e22ada83f83c6d70199742787c | dbe7ca004dc5f358a0e808315a860437a68e7be1 | diff --git a/lib/better_errors/raised_exception.rb b/lib/better_errors/raised_exception.rb
index f3ee36ae..02683c10 100644
--- a/lib/better_errors/raised_exception.rb
+++ b/lib/better_errors/raised_exception.rb
@@ -36,8 +36,13 @@ def setup_backtrace
def setup_backtrace_from_bindings
@backtrace = exception... | [
"lib/better_errors/raised_exception.rb"
] | [] | true | ||
BetterErrors/better_errors | 456 | issue_to_patch | Add editor preset for VSCodium | 593db030ee06333911aaf4845918bb0f0ce3e7b0 | eb1de17b8b5e091e20a07a1a8fd3fb376684b31f | diff --git a/lib/better_errors.rb b/lib/better_errors.rb
index 27a13d67..d00286fe 100644
--- a/lib/better_errors.rb
+++ b/lib/better_errors.rb
@@ -21,6 +21,7 @@ module BetterErrors
{ symbols: [:idea], sniff: /idea/i, url: "idea://open?file=%{file}&line=%{line}" },
{ symbols: [:rubymine], sniff: /mine/i, url: ... | [
"lib/better_errors.rb"
] | [] | true | |||
BetterErrors/better_errors | 457 | issue_to_patch | CI: Drop unused sudo: false directive | This PR removes the no-longer-used Travis setting `sudo: false`. See [more at the Travis blog](https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration). | 593db030ee06333911aaf4845918bb0f0ce3e7b0 | 5639d5fa8949ab8f1fedab4676f1629378323e92 | diff --git a/.travis.yml b/.travis.yml
index d2fd1f17..62e47495 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,4 +1,3 @@
-sudo: false
language: ruby
cache: bundler
notifications:
| [
".travis.yml"
] | [] | true | ||
BetterErrors/better_errors | 444 | issue_to_patch | Allow passing IPAddrs to allow_ip | Can we add support for passing IPAddrs directly to allow_ip? | 1891ad8c227ba67279ecdb2e8c4c0aca35b2726e | 361d5065cad815234bc44b9c5601f6479223a5f0 | diff --git a/lib/better_errors/middleware.rb b/lib/better_errors/middleware.rb
index 1e4f8e2d..262cf3b2 100644
--- a/lib/better_errors/middleware.rb
+++ b/lib/better_errors/middleware.rb
@@ -33,7 +33,7 @@ class Middleware
# Adds an address to the set of IP addresses allowed to access Better
# Errors.
def... | [
"lib/better_errors/middleware.rb",
"spec/better_errors/middleware_spec.rb"
] | [
{
"comment": "What about to make it more safe? (code not tested)\r\n\r\n```ruby\r\ncase addr\r\n when String then IPAddr.new(addr)\r\n when IPAddr then addr\r\n else raise 'Unknown IP address type. Please specify it as a IPAddr compatible string like \"1.1.1.1\" or pass IPAddr object.'\r\nend\r\n```",
"p... | diff --git a/spec/better_errors/middleware_spec.rb b/spec/better_errors/middleware_spec.rb
index 6bb0ceac..216051db 100644
--- a/spec/better_errors/middleware_spec.rb
+++ b/spec/better_errors/middleware_spec.rb
@@ -40,6 +40,12 @@ module BetterErrors
app.call("REMOTE_ADDR" => "77.55.33.11")
end
+ it "sh... | true | |
BetterErrors/better_errors | 452 | issue_to_patch | CI tests for Ruby 2.6, 2.7; Rails 6.0 | c24c87f2065045d2ce984469c8f3790036f2c293 | 2d7774ed830fca8fe1d825a4c62a44204ef867c0 | diff --git a/.travis.yml b/.travis.yml
index 7e1b7a51..d2fd1f17 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -12,20 +12,25 @@ rvm:
- 2.3.8
- 2.4.9
- 2.5.7
+ - 2.6.5
+ - 2.7.0
- ruby-head
gemfile:
- gemfiles/rails42.gemfile
- gemfiles/rails50.gemfile
- gemfiles/rails51.gemfile
- gemfiles/rail... | [
".travis.yml",
"gemfiles/rails60.gemfile",
"gemfiles/rails60_boc.gemfile",
"gemfiles/rails60_haml.gemfile",
"spec/better_errors/stack_frame_spec.rb",
"spec/better_errors_spec.rb"
] | [] | diff --git a/spec/better_errors/stack_frame_spec.rb b/spec/better_errors/stack_frame_spec.rb
index 23a8982c..df96c90a 100644
--- a/spec/better_errors/stack_frame_spec.rb
+++ b/spec/better_errors/stack_frame_spec.rb
@@ -97,7 +97,7 @@ module BetterErrors
it "raises on non-NameErrors" do
frame = StackFrame... | true | ||
BetterErrors/better_errors | 453 | issue_to_patch | Fix various specs that were passing incorrectly | Many specs for the `ErrorPage` were only looking at whether certain strings appeared in the HTML that was generated. But for different reasons, the string being matched could be included in the generated HTML for other reasons.
For example, if an exception was raised inside of the spec example, the resulting page wo... | c18a975fa07ba26e05b24d5e7d34aa4d6a806b9b | 64e65fa1842db1d45313c86f8f12f7dc1c89d2a5 | diff --git a/better_errors.gemspec b/better_errors.gemspec
index 12874a86..ef996b0d 100644
--- a/better_errors.gemspec
+++ b/better_errors.gemspec
@@ -22,6 +22,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "rake", "~> 10.0"
s.add_development_dependency "rspec", "~> 3.5"
+ s.add_development_de... | [
"better_errors.gemspec",
"spec/better_errors/error_page_spec.rb",
"spec/spec_helper.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 2202006b..5ea07403 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -2,6 +2,11 @@
module BetterErrors
describe ErrorPage do
+ # It's necessary to use HTML matchers h... | true | |
BetterErrors/better_errors | 450 | issue_to_patch | Update CI Ruby to fix Travis CI failures | Update Rubies to latest minor version and exclude Rails 4.2 specs on Ruby 2.3, since the default bundler 2.1.2 gem breaks the downgrade.
Note that I tried to fix this first by using `export BUNDLER_VERSION=1.3`, which works fine locally to prefer Bundler 1.x, even if 2.x is installed, but for some reason that didn't... | 5e1d687e3cabcc39dcfe8be2e729b4eb4ec5e7cb | da5e6556b13a30634912405c56b725a0ee20174c | diff --git a/.travis.yml b/.travis.yml
index bf50dcfc..7e1b7a51 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,16 +1,6 @@
sudo: false
language: ruby
cache: bundler
-before_install:
- # Since Rails 4.2 only supports rubygems < 2, we must install an older version for it.
- - >
- if [[ "$BUNDLE_GEMFILE" =~ "rail... | [
".travis.yml"
] | [] | true | ||
BetterErrors/better_errors | 430 | issue_to_patch | Fix NoMethodError when variables cannot be retrieved from the stack frame | This seems to affect only Jbuilder frames in a Rails 5.1 app. Calling `eval("local_variables")` returns nil in any jbuilder frame. I'm working on a reproducible case for this and a spec to cover it.
```
NoMethodError (undefined method `each_with_object' for nil:NilClass):
better_errors (2.5.0) lib/better_errors/... | ad519b7fb4b7179d38085782521584c2b3b2eaae | 679b7deca53e50c22c14a103cd3f4972e459622d | diff --git a/lib/better_errors/stack_frame.rb b/lib/better_errors/stack_frame.rb
index 4b78c951..706edaf1 100644
--- a/lib/better_errors/stack_frame.rb
+++ b/lib/better_errors/stack_frame.rb
@@ -69,7 +69,10 @@ def pretty_path
def local_variables
return {} unless frame_binding
- frame_binding.eval("lo... | [
"lib/better_errors/stack_frame.rb"
] | [] | true | ||
BetterErrors/better_errors | 437 | issue_to_patch | Specify older kramdown and i18n for older ruby versions | [CI failure](https://travis-ci.org/BetterErrors/better_errors/builds/493285669) was caused by [kramdown 2.0+ requiring Ruby 2.3+](https://kramdown.gettalong.org/news.html). This fixes it by specifying the older kramdown version when the current Ruby version is older than 2.3.
Same for i18n 1.5.2, which is a dependen... | 905dffbf3f72a5ff0560295139ca2937d1a6ba8c | a331158786a4896d93bd228290ea32aa7490da35 | diff --git a/better_errors.gemspec b/better_errors.gemspec
index 217ade2e..12874a86 100644
--- a/better_errors.gemspec
+++ b/better_errors.gemspec
@@ -24,7 +24,8 @@ Gem::Specification.new do |s|
s.add_development_dependency "rspec", "~> 3.5"
s.add_development_dependency "rspec-its"
s.add_development_dependency... | [
"better_errors.gemspec",
"gemfiles/rails42.gemfile",
"gemfiles/rails42_boc.gemfile",
"gemfiles/rails42_haml.gemfile",
"gemfiles/rails50.gemfile",
"gemfiles/rails50_boc.gemfile",
"gemfiles/rails50_haml.gemfile",
"gemfiles/rails51.gemfile",
"gemfiles/rails51_boc.gemfile",
"gemfiles/rails51_haml.gemf... | [] | true | ||
BetterErrors/better_errors | 435 | issue_to_patch | Fix exception when large object's class is anonymous | Avoids the error pointed by https://github.com/BetterErrors/better_errors/issues/411#issuecomment-462005513
When a local/instance variable is anonymous and it's value is too large better_errors prints a default message in https://github.com/BetterErrors/better_errors/blob/master/lib/better_errors/error_page.rb#L111
... | 1ba749588db8235a4bbbbdb9d5d64816e1d2875b | e39add58a3520fc5d223ad5b6e2da0df4ec7baea | diff --git a/lib/better_errors/error_page.rb b/lib/better_errors/error_page.rb
index f417a3d9..e5826045 100644
--- a/lib/better_errors/error_page.rb
+++ b/lib/better_errors/error_page.rb
@@ -107,9 +107,9 @@ def text_heading(char, str)
def inspect_value(obj)
InspectableValue.new(obj).to_html
rescue Bett... | [
"lib/better_errors/error_page.rb",
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 1d802651..2202006b 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -118,7 +118,26 @@ def inspect
it "includes an indication that the variable was too large"... | true | |
BetterErrors/better_errors | 433 | issue_to_patch | Fall back to older rubygems on Ruby 2.2 and Rails 4.2 in CI | Currently CI builds are failing because it's always trying to upgrade rubygems to the latest. The latest version of rubygems refuses to install on ruby <= 2.2.
In addition, the latest version of Bundler refuses to install with an older version of Rubygems, and Rails 4.2 is incompatible with the latest version of Bun... | ad519b7fb4b7179d38085782521584c2b3b2eaae | 56121218f347059183400dd0f6a6c353a1ea03e4 | diff --git a/.travis.yml b/.travis.yml
index cfee4efa..bf50dcfc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,8 +2,15 @@ sudo: false
language: ruby
cache: bundler
before_install:
- - gem update --system
- - gem update bundler
+ # Since Rails 4.2 only supports rubygems < 2, we must install an older version for ... | [
".travis.yml"
] | [] | true | ||
BetterErrors/better_errors | 434 | issue_to_patch | Add simplecov as a development dependency | Without `simplecov` `bundle exec rspec` gives a bunch of errors like:
```
An error occurred while loading ./spec/better_errors/code_formatter_spec.rb.
Failure/Error: require 'simplecov'
LoadError:
cannot load such file -- simplecov
# ./spec/spec_helper.rb:16:in `require'
# ./spec/spec_helper.rb:16:in `<top... | ad519b7fb4b7179d38085782521584c2b3b2eaae | 39b3168e98912541635790417cdd5af9f5027cad | diff --git a/better_errors.gemspec b/better_errors.gemspec
index 2863b787..c53a8c16 100644
--- a/better_errors.gemspec
+++ b/better_errors.gemspec
@@ -25,6 +25,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "rspec-its"
s.add_development_dependency "yard"
s.add_development_dependency "kramdown"... | [
"better_errors.gemspec"
] | [] | true | ||
BetterErrors/better_errors | 427 | issue_to_patch | Add rubygems metadata | Add metadata links for quick access from the rubygems catalogue. | 638bbc6b3e40c93dfc30c1c429b843474e71e2e8 | 51bd42a9df48e073d3cf9932969627ad4bc6898b | diff --git a/better_errors.gemspec b/better_errors.gemspec
index 74093c25..2863b787 100644
--- a/better_errors.gemspec
+++ b/better_errors.gemspec
@@ -33,4 +33,12 @@ Gem::Specification.new do |s|
# optional dependencies:
# s.add_dependency "binding_of_caller"
# s.add_dependency "pry"
+
+ if s.respond_to?(:m... | [
"better_errors.gemspec"
] | [
{
"comment": "I’d suggest removing this condition, otherwise anyone building this gem on an older version of RubyGems will build a gem without metadata without being aware of it.",
"path": "better_errors.gemspec",
"hunk": "@@ -33,4 +33,10 @@ Gem::Specification.new do |s|\n # optional dependencies:\n ... | true | ||
BetterErrors/better_errors | 427 | comment_to_fix | Add rubygems metadata | I’d suggest removing this condition, otherwise anyone building this gem on an older version of RubyGems will build a gem without metadata without being aware of it. | 638bbc6b3e40c93dfc30c1c429b843474e71e2e8 | 51bd42a9df48e073d3cf9932969627ad4bc6898b | diff --git a/better_errors.gemspec b/better_errors.gemspec
index 74093c25..2863b787 100644
--- a/better_errors.gemspec
+++ b/better_errors.gemspec
@@ -33,4 +33,12 @@ Gem::Specification.new do |s|
# optional dependencies:
# s.add_dependency "binding_of_caller"
# s.add_dependency "pry"
+
+ if s.respond_to?(:m... | [
"better_errors.gemspec"
] | [
{
"comment": "I’d suggest removing this condition, otherwise anyone building this gem on an older version of RubyGems will build a gem without metadata without being aware of it.",
"path": "better_errors.gemspec",
"hunk": "@@ -33,4 +33,10 @@ Gem::Specification.new do |s|\n # optional dependencies:\n ... | true | ||
BetterErrors/better_errors | 418 | issue_to_patch | Add MRI 2.5 and Rails 5.2 to CI | - Add MRI 2.5.1 (Rails 4.x tests are excluded from this Ruby just like they are from 2.4.x.)
- Remove MRI 2.0.0 and 2.1.10. Since [2.2 is no longer supported](https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/) it seems reasonable to remove the previous two releases.
- Update to MRI 2.2.10, 2... | 946281d441523c9a009657a1c658f5134c17b482 | 6b511f876dd1f49e921fb00c7b44af4cdff9d28a | diff --git a/.travis.yml b/.travis.yml
index 7ce217a0..cfee4efa 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,9 @@
sudo: false
language: ruby
cache: bundler
+before_install:
+ - gem update --system
+ - gem update bundler
notifications:
webhooks:
# With COVERALLS_PARALLEL, coverage information sent... | [
".travis.yml",
"gemfiles/rails52.gemfile",
"gemfiles/rails52_boc.gemfile",
"gemfiles/rails52_haml.gemfile"
] | [] | true | ||
BetterErrors/better_errors | 419 | issue_to_patch | Rescue on undefined local variables in frame_binding | Some local variables appear to be undefined in the frame_binding.
For example, I see errors on local variables: `m`, `args`, `block`, `r`, and `target` when inspecting an error on a class that inherits from SimpleDelegator.
Fix: Add a rescue on NameError to catch these.
Fixes issue: https://github.com/charliesom... | 946281d441523c9a009657a1c658f5134c17b482 | f524abc6581b94dc765f1d1eb18369644dd28483 | diff --git a/lib/better_errors/stack_frame.rb b/lib/better_errors/stack_frame.rb
index 46518031..4b78c951 100644
--- a/lib/better_errors/stack_frame.rb
+++ b/lib/better_errors/stack_frame.rb
@@ -76,14 +76,16 @@ def local_variables
# considered a bug in Ruby itself, but we need to work around it.
next ... | [
"lib/better_errors/stack_frame.rb",
"spec/better_errors/stack_frame_spec.rb"
] | [] | diff --git a/spec/better_errors/stack_frame_spec.rb b/spec/better_errors/stack_frame_spec.rb
index 50bb460c..23a8982c 100644
--- a/spec/better_errors/stack_frame_spec.rb
+++ b/spec/better_errors/stack_frame_spec.rb
@@ -81,6 +81,26 @@ module BetterErrors
end
end
+ context "#local_variable" do
+ it ... | true | |
BetterErrors/better_errors | 421 | issue_to_patch | Update event names to support Turbolinks 5 | Fixes #420 | 946281d441523c9a009657a1c658f5134c17b482 | e1a1d7461c10693c6b5c16013230bbe6631231ce | diff --git a/lib/better_errors/templates/main.erb b/lib/better_errors/templates/main.erb
index 81487982..f0041177 100644
--- a/lib/better_errors/templates/main.erb
+++ b/lib/better_errors/templates/main.erb
@@ -721,12 +721,22 @@
if(document.styleSheets[i].href)
document.styleSheets[i].... | [
"lib/better_errors/templates/main.erb"
] | [] | true | ||
BetterErrors/better_errors | 422 | issue_to_patch | Fix stack overflow when ObjectSpace is not available | The specs added in #412 left out an edge case: when a platform is missing `ObjectSpace` support. And I introduced a bug in variable serialization [here](https://github.com/charliesome/better_errors/commit/f1c2fdc219409513cf64e8adb1f132598374ee68#diff-e322090784182380ed3a4a5f8490b2f0R35) by calling `to_html`.
So this... | 56d39cf920bdc9a2c9162e8661b6237285b96ef9 | 0d4b68b65c0efccd321546d4b0741f3e111d161f | diff --git a/lib/better_errors/inspectable_value.rb b/lib/better_errors/inspectable_value.rb
index 2df6187f..b62beb6e 100644
--- a/lib/better_errors/inspectable_value.rb
+++ b/lib/better_errors/inspectable_value.rb
@@ -11,13 +11,17 @@ def initialize(value)
def to_html
raise ValueLargerThanConfiguredMaximu... | [
"lib/better_errors/inspectable_value.rb",
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 77c92ed8..1d802651 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -64,56 +64,124 @@ module BetterErrors
BetterErrors.maximum_variable_inspect_size = 1010
... | true | |
BetterErrors/better_errors | 395 | issue_to_patch | NameError (uninitialized constant BetterErrors::REPL::Pry) in master
Might be related to #329. | Fix Pry `uninitialized constant` exception | This fixes #393.
The fix in #329 placed some code that was specific to `REPL::Pry` in the `ErrorPage` class. This caused an exception to be raised _when Pry is not enabled_ because `REPL::Pry` class is only loaded after `use_pry!` is called.
To fix this exception, I moved the Pry-specific behavior into `REPL::Pry... | 43694c409bba2225aa565c24dd5197dc51f6715c | b272b11f8f904d30fb0dff4f13a5d549c363dc28 | diff --git a/lib/better_errors/error_page.rb b/lib/better_errors/error_page.rb
index d7de8c1d..c8f92d90 100644
--- a/lib/better_errors/error_page.rb
+++ b/lib/better_errors/error_page.rb
@@ -45,9 +45,9 @@ def do_eval(opts)
return { error: "REPL unavailable in this stack frame" }
end
- @repls[inde... | [
"lib/better_errors/error_page.rb",
"lib/better_errors/repl.rb",
"lib/better_errors/repl/basic.rb",
"lib/better_errors/repl/pry.rb",
"spec/better_errors/error_page_spec.rb",
"spec/better_errors/repl/basic_spec.rb",
"spec/better_errors/repl/pry_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index fe7fb3bc..ba13e2ba 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -88,5 +88,62 @@ def initialize(message = nil)
expect(error_page.exception_message).not_to match(/... | true |
BetterErrors/better_errors | 398 | issue_to_patch | Ruby and Rails matrix in CI | A gemfile for each set of dependencies that Better Errors intends to support. These are:
- Rails 4.2, 5.0, and 5.1, without binding_of_caller or haml
- Rails 4.2, 5.0, and 5.1, with haml
- Rails 4.2, 5.0, and 5.1, with binding_of_caller
- Pure Rack, with and without binding_of_caller
- Pry 0.9, 0.10, (and 0.11pr... | a351d4fed2f00e8c1d6bf38316281bad30009526 | a4329ecad1676c980e7ba1ec950522a7595565da | diff --git a/.gitignore b/.gitignore
index 88654958..d3f6a852 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,3 +6,6 @@
/doc
/.bundle
/vendor/gems
+
+/gemfiles/*.gemfile.lock
+/gemfiles/.bundle
diff --git a/.travis.yml b/.travis.yml
index 501f42aa..29728910 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,8 +2,61 @@ ... | [
".gitignore",
".travis.yml",
"Gemfile",
"README.md",
"Rakefile",
"better_errors.gemspec",
"gemfiles/pry010.gemfile",
"gemfiles/pry011.gemfile",
"gemfiles/pry09.gemfile",
"gemfiles/rack.gemfile",
"gemfiles/rack_boc.gemfile",
"gemfiles/rails42.gemfile",
"gemfiles/rails42_boc.gemfile",
"gemfi... | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index ba13e2ba..16a53ea0 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -98,50 +98,74 @@ def initialize(message = nil)
end
let(:eval_tester) { double('EvalTester', ... | true | |
BetterErrors/better_errors | 403 | issue_to_patch | Fix variable inspection specs | - Rename `empty_binding` variable to `exception_binding`, since it's obviously not empty.
- Fix the specs covering variable inspection. These specs were looking for the names of variables but actually, since RSpec includes in the scope of the example a copy of the example itself, it was just finding the source code of... | e9a352d2cca7d218ae96b313fac9c2d58a85955d | e5b7a13c0851d460e89be2868633e4dd5c82bf2f | [
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 16a53ea0..2cfdc4d3 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -8,7 +8,7 @@ module BetterErrors
let(:response) { error_page.render }
- let(:empty_binding) {
... | true | ||
BetterErrors/better_errors | 402 | issue_to_patch | Fix browser performance issues with configurable maximum variable size | Based on my comment on #334 and @tobypinder’s PR #360:
> this will allow the user to set a maximum payload size for `variable.inspect`, above which the variable is filtered out of the error page. This solves many performance problems associated with the browser being slow to render error pages, the CPU requirements ... | c0044fce0a360b4f8eee1fa183b75d3705097ffb | 3e9909c26ee8441e59435aad66205ca88d216630 | diff --git a/README.md b/README.md
index 91046b88..dc38bf3d 100644
--- a/README.md
+++ b/README.md
@@ -75,6 +75,20 @@ Better Errors includes a link to your editor for the file and line of code that
By default, it uses your environment to determine which editor should be opened.
See [the wiki for instructions on confi... | [
"README.md",
"lib/better_errors.rb",
"lib/better_errors/error_page.rb",
"spec/better_errors/error_page_spec.rb"
] | [] | diff --git a/spec/better_errors/error_page_spec.rb b/spec/better_errors/error_page_spec.rb
index 2cfdc4d3..24a48d06 100644
--- a/spec/better_errors/error_page_spec.rb
+++ b/spec/better_errors/error_page_spec.rb
@@ -58,6 +58,60 @@ module BetterErrors
expect(html).not_to include('<td class="name">' + '@inst_d<... | true | |
BetterErrors/better_errors | 401 | issue_to_patch | Fix sharing the DOM with web-console | If web-console is in the same page as Better Errors, web-console was taking the `.console` element in the page.
This renames it to `.be-console`.
I also renamed the `.prompt` element to `.command-line`, since it wraps the actual prompt and the input element _and_ when it was time to grab the `promptElement` it wa... | e9a352d2cca7d218ae96b313fac9c2d58a85955d | c7d14d29e161fb7c9c2af1f8d4ddfc7da124c58c | diff --git a/lib/better_errors/templates/main.erb b/lib/better_errors/templates/main.erb
index 67d57fc0..81487982 100644
--- a/lib/better_errors/templates/main.erb
+++ b/lib/better_errors/templates/main.erb
@@ -394,7 +394,7 @@
* Monospace
* -------------------------------------------------------------------... | [
"lib/better_errors/templates/main.erb",
"lib/better_errors/templates/variable_info.erb"
] | [] | true | ||
BetterErrors/better_errors | 404 | issue_to_patch | Test coverage reporting in CI | Add Coveralls as a development dependency. All CI builds in the main fork (including pull requests) will send coverage data to coveralls.
Each matrix build sends its own coverage data. When all builds have completed, Travis sends a webhook to Coveralls so that it can stitch all coverage data together. This allows us... | f7d12b4aa4cd234573a457a04e3cbb56c6c5851d | 23566b1b3c997686882812c1956473c46cbd6f82 | diff --git a/.coveralls.yml b/.coveralls.yml
new file mode 100644
index 00000000..91600595
--- /dev/null
+++ b/.coveralls.yml
@@ -0,0 +1,1 @@
+service_name: travis-ci
diff --git a/.travis.yml b/.travis.yml
index 29728910..dd6fccdc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,13 @@
sudo: false
language: ruby
... | [
".coveralls.yml",
".travis.yml",
"gemfiles/pry010.gemfile",
"gemfiles/pry011.gemfile",
"gemfiles/pry09.gemfile",
"gemfiles/rack.gemfile",
"gemfiles/rack_boc.gemfile",
"gemfiles/rails42.gemfile",
"gemfiles/rails42_boc.gemfile",
"gemfiles/rails42_haml.gemfile",
"gemfiles/rails50.gemfile",
"gemfi... | [] | diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index c38ab51d..0469a610 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -2,5 +2,15 @@
ENV["EDITOR"] = nil
+# Ruby 2.4.0 and 2.4.1 has a bug with its Coverage module that causes segfaults.
+# https://bugs.ruby-lang.org/issues/13305
+# 2.4.2 shoul... | true | |
BetterErrors/better_errors | 405 | issue_to_patch | Fix markdown rendering of headline | 5fc4cb417e3a95aa0def8bb0d07a8aea93d9a127 | afbd228b20d76437577cca40a95327e7a291c812 | diff --git a/README.md b/README.md
index b6eaf1a3..e06b5370 100644
--- a/README.md
+++ b/README.md
@@ -81,7 +81,7 @@ By default, it uses your environment to determine which editor should be opened.
See [the wiki for instructions on configuring the editor](https://github.com/charliesome/better_errors/wiki/Link-to-your-... | [
"README.md"
] | [] | true | |||
Blankj/AndroidUtilCode | 1,805 | issue_to_patch | Fix VibrateUtils can not vibrate in background | 51c8124045ec5b7c6d342b94a4020ed2f7fda496 | c7ebceb6675670080389472445d0bcb3c71f8bc9 | diff --git a/buildSrc/src/main/groovy/Config.groovy b/buildSrc/src/main/groovy/Config.groovy
index a69b8907c7..9a8d69d659 100644
--- a/buildSrc/src/main/groovy/Config.groovy
+++ b/buildSrc/src/main/groovy/Config.groovy
@@ -34,7 +34,7 @@ class Config {
lib_base : new ModuleConfig(isApply: ... | [
"buildSrc/src/main/groovy/Config.groovy",
"feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/vibrate/VibrateActivity.kt",
"feature/utilcode/pkg/src/main/res/values/strings.xml",
"lib/utilcode/src/main/java/com/blankj/utilcode/util/VibrateUtils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 1,710 | issue_to_patch | [F] 部分应用市场以所谓ActivityUtils隐私合规问题拒绝应用上架 | 2955cf96fcc4ed6b8501d06be382cf098d7cdf50 | 99be3102e1b5dce8bf051721008811eed3dae0a0 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ActivityUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/ActivityUtils.java
index 056668652..d49ce6ff0 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ActivityUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/ActivityUtils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 1,656 | issue_to_patch | Added uri2FileNoCacheCopy | Someone else should update readmes &c. | ac872f8fb52d569d252e5fe136b0f7af14798f5a | ed848ebd638507a492946e6300b057fb621b5dba | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java
index 322b9d119..c22d1bba3 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,669 | issue_to_patch | BarUtils添加transparentNavBar实现 | 很多开发者反馈，
有transparentStatusBar方法，却没有transparentNavBar方法，
鉴于此，增加对transparentNavBar实现，
此实现已经进行Android 4.4及以上多款不同ROM机型覆盖测试，
没有任何问题 | ac872f8fb52d569d252e5fe136b0f7af14798f5a | da8b04946981398dfb217825946af55cba3b3444 | diff --git a/feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/bar/nav/BarNavActivity.kt b/feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/bar/nav/BarNavActivity.kt
index 1b3032974f..48a738ecd7 100644
--- a/feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/bar/nav/Ba... | [
"feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/bar/nav/BarNavActivity.kt",
"lib/utilcode/src/main/java/com/blankj/utilcode/util/BarUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,671 | issue_to_patch | [M] AppUtils增加getAppMinSdkVersion, getAppTargetSdkVersion支持 | AppUtils增加getAppMinSdkVersion, getAppTargetSdkVersion支持。
其中getAppMinSdkVersion方法有些特殊，
在Android 7.0以下设备运行时，返回-1，因为ApplicationInfo.minSdkVersion字段是在Android 7.0之后加入的，
在Android 7.0及以上设备运行时，返回正常。 | 31a8403444c4aa03fa2f769da68a307698565fcd | d746f1438c5e0fba890310fcf7b44e4dcb4b143b | diff --git a/feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/app/AppActivity.kt b/feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/app/AppActivity.kt
index 175fa1bc3b..21eb351146 100644
--- a/feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/app/AppActivity.kt
+++ b... | [
"feature/utilcode/pkg/src/main/java/com/blankj/utilcode/pkg/feature/app/AppActivity.kt",
"lib/utilcode/README-CN.md",
"lib/utilcode/README.md",
"lib/utilcode/src/main/java/com/blankj/utilcode/util/AppUtils.java",
"lib/utildebug/src/main/java/com/blankj/utildebug/debug/tool/appInfo/AppInfoItem.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,670 | issue_to_patch | [M] 修改BarUtils方法列表及描述 | 修改了README，方便大家对BarUtils方法读取 | 85f217f83a9b5dbcaa2207a3b30ef1258dff68d8 | cf983059a82e0306ea1bdaa773f9fec0ed03ad22 | diff --git a/lib/utilcode/README-CN.md b/lib/utilcode/README-CN.md
index 0e4e93f3a..f7523783f 100644
--- a/lib/utilcode/README-CN.md
+++ b/lib/utilcode/README-CN.md
@@ -141,6 +141,7 @@ getNavBarColor : 获取导航栏颜色
isSupportNavBar : 判断是否支持导航栏
setNavBarLightMode ... | [
"lib/utilcode/README-CN.md",
"lib/utilcode/README.md",
"lib/utilcode/src/main/AndroidManifest.xml"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,580 | issue_to_patch | Explicitly specify `android:exported` to make compatible with Android 12 | https://developer.android.com/about/versions/12/behavior-changes-12#exported | ac872f8fb52d569d252e5fe136b0f7af14798f5a | f9a1dbf0dfa8ad5bd20fe4f72bb72a4470b248db | diff --git a/lib/utilcode/src/main/AndroidManifest.xml b/lib/utilcode/src/main/AndroidManifest.xml
index fc5b75e0e..d45dd5778 100644
--- a/lib/utilcode/src/main/AndroidManifest.xml
+++ b/lib/utilcode/src/main/AndroidManifest.xml
@@ -5,12 +5,14 @@
<activity
android:name="com.blankj.utilcode.util.... | [
"lib/utilcode/src/main/AndroidManifest.xml"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,649 | issue_to_patch | fix bug 1544 | 修改获取应用分身目录下文件路径报错 | ac872f8fb52d569d252e5fe136b0f7af14798f5a | f7d1b44b628561ae6cad78ac94d25a6eb9460897 | diff --git a/lib/utilcode/src/main/res/xml/util_code_provider_paths.xml b/lib/utilcode/src/main/res/xml/util_code_provider_paths.xml
index ed731a229..b88716480 100644
--- a/lib/utilcode/src/main/res/xml/util_code_provider_paths.xml
+++ b/lib/utilcode/src/main/res/xml/util_code_provider_paths.xml
@@ -23,4 +23,9 @@
... | [
"lib/utilcode/src/main/res/xml/util_code_provider_paths.xml"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,653 | issue_to_patch | Update README-CN.md | <img width="833" alt="image" src="https://user-images.githubusercontent.com/17163056/172521763-dc363cec-bc3e-4e95-831c-f1a49e16adb8.png">
找不到1.30.6 | ac872f8fb52d569d252e5fe136b0f7af14798f5a | 8dc01389ee5599c44c7ae26a8c26411b63bfa564 | diff --git a/lib/utilcode/README-CN.md b/lib/utilcode/README-CN.md
index 0e4e93f3a..260cabac2 100644
--- a/lib/utilcode/README-CN.md
+++ b/lib/utilcode/README-CN.md
@@ -6,7 +6,7 @@ Gradle:
implementation 'com.blankj:utilcodex:1.31.0'
// Not in maintenance
-implementation 'com.blankj:utilcode:1.30.6'
+implementation... | [
"lib/utilcode/README-CN.md"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,498 | issue_to_patch | Added 4 useful methods | /**
* Returns the domain part of a given Email address
*
* @param email The Email address. E.g Returns "protonmail.com" from the given Email "johnsmith@protonmail.com".
* @return the domain part of a given Email address.
*/
public static String extractEmailProvider(String email) {
... | 66a4c0488ca6da273098058d70dabb0fe9b9bd8d | ebc64cd35122d1cba80822dd5942900d7fa507ae | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/RegexUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/RegexUtils.java
index ae90e4ea5..624a93511 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/RegexUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/Reg... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/RegexUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 768 | issue_to_patch | 1.22.7 | 94fd3e913d64f8ecbbac863f059ead274f5fa3bb | b5f55878fa1ce11d712c04b0e14c07c5021c6154 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f17493a1c0..0012fe5ae7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,4 @@
+* `18/12/24` [fix] Utils$ActivityLifecycleImpl.consumeOnActivityDestroyedListener ConcurrentModificationException. Publish v1.22.7.
* `18/12/22` [fix] AdaptScreenUtils#pt2px don't work wh... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/Utils.java",
"utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTes... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTest.java
index f3d0247ff4..eb1c7fb738 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/utilco... | true | ||
Blankj/AndroidUtilCode | 786 | issue_to_patch | 1.22.10 | 1cb90ba05b6be7d1714ded21eb2fe9fe93b42453 | 0dd56cec4056adb7e4ef744a961b3d6b6d4bb25e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 359cfd2f69..8f96c63e60 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* `19/01/02` [fix] LogUtils log object. Publish v1.22.10.
+* `19/01/01` [add] GsonUtils.
* `18/12/29` [add] AntiShakeUtils and VibrateUtils. Publish v1.22.9.
* `18/12/28` [fix] ToastUtil... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"lib/base/src/main/java/com/blankj/lib/base/BaseActivity.kt",
"lib/base/src/main/java/com/blankj/lib/base/BaseFragment.kt",
"subutil/README-CN.md",
"subutil/README.md",
"subutil/lib/build.gradle",
"subutil/pkg... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTest.java
index a84d1c4d88..5eb5cf8c61 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTes... | true | ||
Blankj/AndroidUtilCode | 778 | issue_to_patch | 1.22.9 | 63c4dae7fc69c0b5795d612439cbb04acbac292c | 12a006fb37523f53cdad0e0f8202cc782898ca6f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0012fe5ae7..359cfd2f69 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,6 @@
+* `18/12/29` [add] AntiShakeUtils and VibrateUtils. Publish v1.22.9.
+* `18/12/28` [fix] ToastUtils show behind the dialog when close notification.
+* `18/12/27` [fix] LogUtils print Strin... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"bus-gradle-plugin/project.properties",
"config.gradle",
"lib/base/build.gradle",
"lib/base/src/main/java/com/blankj/lib/base/BaseActivity.kt",
"subutil/lib/src/main/java/com/blankj/subutil/util/VibrationUtils.java",
"subutil/lib/src/test/java/com/blankj/... | [] | diff --git a/subutil/lib/src/test/java/com/blankj/subutil/util/TestUtils.java b/subutil/lib/src/test/java/com/blankj/subutil/util/TestUtils.java
index 6f308ce9b3..5e09412922 100644
--- a/subutil/lib/src/test/java/com/blankj/subutil/util/TestUtils.java
+++ b/subutil/lib/src/test/java/com/blankj/subutil/util/TestUtils.ja... | true | ||
Blankj/AndroidUtilCode | 822 | issue_to_patch | 1.23.3 | 59fd0547e97c2db5c9c6e9287c149eb503e1fa03 | a56a1f4216824e7ba239bf9da0be31c670bef525 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8059920565..22d3624b17 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,6 @@
+* `19/01/29` [fix] LogUtils format json when json not start with '{'. Publish v1.23.3.
+* `19/01/28` [fix] KeyboardUtils#fixSoftInputLeaks don't work on the device of HuaWei.
+* `19/01/26`... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"config_app.gradle",
"lib/base/build.gradle",
"subutil/pkg/src/main/java/com/blankj/subutil/pkg/feature/location/LocationActivity.kt",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/m... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/CloneUtilsTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/CloneUtilsTest.java
index 1677925160..fd23058816 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/CloneUtilsTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/uti... | true | ||
Blankj/AndroidUtilCode | 817 | issue_to_patch | see 01/26 log | db163c0423ebd7d0e1acbb27ceecae056904c2fa | e6aa1b44a3fd271e3ba42dca83bb65954c8705c8 | diff --git a/.gitignore b/.gitignore
index 9bf2876a4e..00a1a54621 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
*.iml
+*__bus__.json
.gradle
/local.properties
.idea
@@ -8,4 +9,3 @@
.externalNativeBuild
/apk
/maven
-__bus__.json
\ No newline at end of file
diff --git a/CHANGELOG.md b/CHANGELOG.md
index... | [
".gitignore",
"CHANGELOG.md",
"launcher/app/__bus__.json",
"subutil/app/__bus__.json",
"utilcode/app/__bus__.json"
] | [] | true | |||
Blankj/AndroidUtilCode | 812 | issue_to_patch | 1.23.1 | cb6283cb847762c2c19723d60d5c84f81bcc4a9b | 33339d31fb720eb380f80278d397e83a63d9f0e9 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 563df29c74..416b4719b8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* `19/01/23` [add] Modify the demo of utilcode use kotlin. Publish v1.23.1.
+* `19/01/22` [fix] AppUtils#installApp.
* `19/01/17` [fix] Publish v1.23.0.
* `19/01/16` [fix] BarUtils get A... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"launcher/app/__bus__.json",
"lib/base/build.gradle",
"lib/base/src/main/java/com/blankj/lib/base/BaseApplication.kt",
"subutil/lib/src/main/java/com/blankj/subutil/util/HttpsUtil.java",
"utilcode/README-CN.md",
"utilcode/README-STATIC-... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/FileUtilsTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/FileUtilsTest.java
index ee32695a49..c6fa77d471 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/FileUtilsTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/utilco... | true | ||
Blankj/AndroidUtilCode | 806 | issue_to_patch | see 01/18 log | a5fc6028ce0f2920185bdfa47ce52ab777760db7 | 928c3041a6d6257477b4cc17a2a6234b2ea05216 | diff --git a/lib/base/build.gradle b/lib/base/build.gradle
index 84e572ae1a..669c09c25a 100644
--- a/lib/base/build.gradle
+++ b/lib/base/build.gradle
@@ -15,5 +15,5 @@ dependencies {
api dep.free_proguard
api 'com.r0adkll:slidableactivity:2.0.5'
compileOnly dep.leakcanary.android_no_op
-// api 'com.b... | [
"lib/base/build.gradle",
"utilcode/README-CN.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/ColorUtils.java",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/GsonUtils.java",
"utilcode/lib/src/test/java/com/blankj/utilcode/util/GsonUtilsTest.java",
"utilcode/lib/src... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/GsonUtilsTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/GsonUtilsTest.java
index 7b1b2db391..f0bfb43dcf 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/GsonUtilsTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/utilco... | true | ||
Blankj/AndroidUtilCode | 827 | issue_to_patch | see 01/31 log | f369aba69a69ef4c5b3daa7e37d3827dd21e888e | 3aed129154df145eaee0da795ab58d829a2acadd | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 94eb4c5fa7..7a22251d76 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,4 @@
+* `19/01/31` [add] HttpUtils.
* `19/01/30` [add] RomUtils. Publish v1.23.4.
* `19/01/29` [fix] LogUtils format json when json not start with '{'. Publish v1.23.3.
* `19/01/28` [fix] Key... | [
"CHANGELOG.md"
] | [] | true | |||
Blankj/AndroidUtilCode | 849 | issue_to_patch | 1.23.6 | 5cada7efa7e7503b4f1ed3f27aaabd532b463013 | af793b1063a0f306a8cd7af7b535da6d20b3284e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7a22251d76..1050ee9c33 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* `19/02/28` [fix] ImageUtils#calculateInSampleSize. Publish v1.23.6.
+* `19/02/26` [fix] UriUtils#uri2File. Publish v1.23.5.
* `19/01/31` [add] HttpUtils.
* `19/01/30` [add] RomUtils. P... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/ImageUtils.java",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/UriUtil... | [] | true | |||
Blankj/AndroidUtilCode | 860 | issue_to_patch | see 03/08 log | fbd4d5d5d06182bad14b19a8047069ddccbcec54 | bad553044df57f9a9efceefcf78c6ab36f3b1897 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1050ee9c33..8271c33548 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* `19/03/08` [add] LogUtils support multi process. Publish v1.23.7.
+* `19/03/02` [fix] LogUtils#file.
* `19/02/28` [fix] ImageUtils#calculateInSampleSize. Publish v1.23.6.
* `19/02/26` ... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"launcher/app/src/main/java/com/blankj/launcher/app/UtilsApp.java",
"lib/base/build.gradle",
"lib/base/src/main/java/com/blankj/lib/base/BaseApplication.kt",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md"... | [] | true | |||
Blankj/AndroidUtilCode | 767 | issue_to_patch | see 12/22 log | 5991b5e4b9c9febf7dc08628a029c89b9fa7e337 | e0938b56544cf4a913fc41db186311f570baa4c1 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f8f9200104..f17493a1c0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,4 +1,6 @@
-* `18/12/19` [fix] AdaptScreenUtils not work in MIUI on Android 5.1.1. Publish v1.22.5.
+* `18/12/22` [fix] AdaptScreenUtils#pt2px don't work when start webview. Publish v1.22.6.
+* `18/12... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/LogUtils.java",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/NetworkUt... | [] | true | |||
Blankj/AndroidUtilCode | 766 | issue_to_patch | 1.22.5 | a13e3f728fae815906a0ef1d9be98f1477392e6e | fd165118a7e7c0d6e5d66ad1b9c50b707860935f | diff --git a/utilcode/lib/src/main/java/com/blankj/utilcode/util/AdaptScreenUtils.java b/utilcode/lib/src/main/java/com/blankj/utilcode/util/AdaptScreenUtils.java
index 46efbe595d..c1074cf4c5 100644
--- a/utilcode/lib/src/main/java/com/blankj/utilcode/util/AdaptScreenUtils.java
+++ b/utilcode/lib/src/main/java/com/blan... | [
"utilcode/lib/src/main/java/com/blankj/utilcode/util/AdaptScreenUtils.java",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/UriUtils.java",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/Utils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 759 | issue_to_patch | 1.22.4 | e048975d2aede90ddc94ef6940162dfc4914b861 | 81c0ec2deef98dbbf437c889057a1e934031f552 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 11e1e894c0..40884d4e59 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* `18/12/19` [fix] ToastUtils multi show crash when run API 25. Publish v1.22.4.
+* `18/12/18` [fix] ImageUtils recycle ret equals src. Publish v1.22.3.
* `18/12/17` [fix] Utils$FileProvi... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/BusUtils.java",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/ImageUtil... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTest.java
index 7ff3411c2f..f3d0247ff4 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/TimeUtilsTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/utilco... | true | ||
Blankj/AndroidUtilCode | 752 | issue_to_patch | see 12/17 log | f2184afeb948c26b1666ae79dc9730f4cabee72c | 81341d32f94467f85b2723fe3d8e69358704c028 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 10fef262a1..11e1e894c0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,4 @@
+* `18/12/17` [fix] Utils$FileProvider4UtilCode not found. Publish v1.22.3.
* `18/12/17` [fix] ToastUtils leak. Publish v1.22.2.
* `18/12/09` [add] Component for the project.
* `18/12/04... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/AndroidManifest.xml",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/BusUtils.java",
"utilcode/lib/s... | [] | true | |||
Blankj/AndroidUtilCode | 748 | issue_to_patch | 1.22.2 | f1c6ccbe1614ef16e4579e5ecbde159524f0e14b | e265d786bd165c661a2241f6177c8e1830efe759 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2ef8322de5..10fef262a1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,4 @@
+* `18/12/17` [fix] ToastUtils leak. Publish v1.22.2.
* `18/12/09` [add] Component for the project.
* `18/12/04` [add] BusUtils. Publish v1.22.1.
* `18/11/18` [fix] ToastUtils don't show... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"bus-gradle-plugin/CHANGELOG.md",
"bus-gradle-plugin/build.gradle",
"bus-gradle-plugin/src/main/java/com/blankj/bus/BusInject.groovy",
"bus-gradle-plugin/src/main/java/com/blankj/bus/BusTransform.groovy",
"bus-gradle-plugin/src/main/java/com/blankj/bus/Conf... | [] | diff --git a/utilcode/app/src/main/assets/test/sub/test.txt b/utilcode/pkg/src/main/assets/test/sub/test.txt
similarity index 100%
rename from utilcode/app/src/main/assets/test/sub/test.txt
rename to utilcode/pkg/src/main/assets/test/sub/test.txt
diff --git a/utilcode/app/src/main/assets/test/test.txt b/utilcode/pkg/sr... | true | ||
Blankj/AndroidUtilCode | 1,571 | issue_to_patch | 2 new methods: isJSONObject() and isJSONArray() | Check if a given input is a JSONObject or a JSONArray.
Code:
1. isJSONObject(input)
```
/**
* Checks if a given input is a JSONObject.
*
* @param input Anything.
* @return true if it is a JSONObject.
*/
public static <T> boolean isJSONObject(final T input) {
return inp... | 64555be9ffd836a0f9bebd916d28d2674930614b | 9df5d7e15b06109153d0499c3f1ed1a3080c94ed | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/JsonUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/JsonUtils.java
index ea40ac316..43046adf5 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/JsonUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/JsonUt... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/JsonUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,485 | issue_to_patch | Fix: MessengerUtils java.lang.IllegalStateException | 原始消息在发送之后会被系统回收, 服务端循环向客户端发送消息时, 会发送被使用过的消息导致异常发生.
需要创建一个副本进行消息发送 | 66a4c0488ca6da273098058d70dabb0fe9b9bd8d | ab073b7a4d856771822c08fbdf2a13f300420ce1 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/MessengerUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/MessengerUtils.java
index a764eb50b..71af539ab 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/MessengerUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilc... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/MessengerUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,491 | issue_to_patch | NEW Methods: AppUtils: isFirstTimeInstall(), isAppUpgraded() (All APIs supported) | 1. isFirstTimeInstall():
If you want to know whether this is the first time installation of this app in this device.
2. isAppUpgraded():
If you want to know whether the current version was installed over a previous version (update/upgrade) or if it is freshly installed (clean install).
Code:
* Return true... | 66a4c0488ca6da273098058d70dabb0fe9b9bd8d | 20290bb808058d92cf52a2632fc463faccc10ff6 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/AppUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/AppUtils.java
index a8b65dfec..1cc9112b1 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/AppUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/AppUtils.... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/AppUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,492 | issue_to_patch | NEW Methods: NetworkUtils: isBehindProxy(), isUsingVPN() (All APIs supported) | 1. isBehindProxy():
Returns true if device is connecting to the internet via a proxy, works for both Wi-Fi and Mobile Data.
Code:
`public static boolean isBehindProxy(){
return !(System.getProperty("http.proxyHost") == null || System.getProperty("http.proxyPort") == null);
}`
2. isUsingVPN():
R... | 66a4c0488ca6da273098058d70dabb0fe9b9bd8d | cbea6b40658e04ee923c2e4c1d5fad0e18bae5ae | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/NetworkUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/NetworkUtils.java
index 8f874dbf3..37104b1b4 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/NetworkUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/ut... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/NetworkUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,546 | issue_to_patch | isUsingNetworkProvidedTime() | Useful in situations where you want to verify that the device has a correct time set, to avoid fraud, or if you want to prevent the user from messing with the time and abusing your "one-time" and "expiring" features. | 64555be9ffd836a0f9bebd916d28d2674930614b | 8faee0b382724d3579921672f8a5dbb9c9360f30 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/TimeUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/TimeUtils.java
index 2ab5370c8..88887b621 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/TimeUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/TimeUt... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/TimeUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,561 | issue_to_patch | 修复了一个内存泄漏的问题 | //这里会发生内存泄漏 如果不设置为null
contentView.setTag(TAG_ON_GLOBAL_LAYOUT_LISTENER, null); | 64555be9ffd836a0f9bebd916d28d2674930614b | fb1f0d0a616bbbb326e9c7665887365c5dd064f9 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/KeyboardUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/KeyboardUtils.java
index 7f95fdee7..fd70fef22 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/KeyboardUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/KeyboardUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,423 | issue_to_patch | Added new methods (features) | Added 6 new very useful methods.
1. getScreenXDpi() which returns the Width (X) density in DPI.
2. getScreenYDpi() which returns the Height (Y) density in DPI.
3. calculateDistanceByX() which returns the distance between the given View's X (start point of View's width) and the screen width.
4. calculateDistanceByY(... | 10ae0707d10258469cdd6203c107b3e76db23a16 | 7402e364000fd053b7ee08650a04a8559977ba41 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ScreenUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/ScreenUtils.java
index b5cad7ef99..cb742b7a7d 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ScreenUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/uti... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/ScreenUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,445 | issue_to_patch | add environment variable | 10ae0707d10258469cdd6203c107b3e76db23a16 | fd2d59aa451d0a1c038757d68e5387ef5c7d4230 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ShellUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/ShellUtils.java
index 1f2d50888b..a4f1e4fa81 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ShellUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/S... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/ShellUtils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 1,385 | issue_to_patch | static ColorUtils.isLightColor | add static to ColorUtils.isLightColor | 27cf719c188603a1f9109c4bf1bcfb7949903b02 | be7c7c27f4191a9a741d6c63a7ef6d7e2c14e449 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ColorUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/ColorUtils.java
index d894de475b..0b0d9d37f8 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ColorUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/C... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/ColorUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,344 | issue_to_patch | perf: 优化保存图片时的安全性 | 6a266afaae1f2471d3bc57fd5e2b156a7bc85213 | 42982c4cb36f353c91fe822d0cbc562dd74a3c52 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ImageUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/ImageUtils.java
index f3222ad8f3..9e27fbde73 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ImageUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/I... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/ImageUtils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 1,320 | issue_to_patch | TemperatureUtils class added to the lib-subutil | TemperatureUtils class with TestTempConversion test class added. | 3befa9bc8fadb42db37f3b992ef3a63988d30847 | 2d4fec4b60a5f88a342615d4f6972738f8f51e63 | diff --git a/lib/subutil/src/main/java/com/blankj/subutil/util/TemperatureUtils.java b/lib/subutil/src/main/java/com/blankj/subutil/util/TemperatureUtils.java
new file mode 100644
index 0000000000..44bd62a4af
--- /dev/null
+++ b/lib/subutil/src/main/java/com/blankj/subutil/util/TemperatureUtils.java
@@ -0,0 +1,41 @@
+p... | [
"lib/subutil/src/main/java/com/blankj/subutil/util/TemperatureUtils.java",
"lib/subutil/src/test/java/com/blankj/subutil/util/TestTempConversion.java"
] | [] | diff --git a/lib/subutil/src/test/java/com/blankj/subutil/util/TestTempConversion.java b/lib/subutil/src/test/java/com/blankj/subutil/util/TestTempConversion.java
new file mode 100644
index 0000000000..daa61ea0d3
--- /dev/null
+++ b/lib/subutil/src/test/java/com/blankj/subutil/util/TestTempConversion.java
@@ -0,0 +1,51... | true | |
Blankj/AndroidUtilCode | 1,306 | issue_to_patch | #修复OneUI2系统版本前三星s8/note8等设备导航栏可见性判断错误的问题 | 3befa9bc8fadb42db37f3b992ef3a63988d30847 | c664cc558c590dc985b30a7fd370c3e2d5a501cf | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/BarUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/BarUtils.java
index 37596cd9eb..4fcd4e1ecf 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/BarUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/BarUtil... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/BarUtils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 1,314 | issue_to_patch | 修复从SAF选择文件时id解析异常的问题 | 从”最近下载“选择文件时，uri ：content://com.android.providers.downloads.documents/msf:xxx。Long.valueOf("msf:xxx")会抛出异常 | 3befa9bc8fadb42db37f3b992ef3a63988d30847 | f9dc1ec6088073cc248fc35f9c62cff1a57e2e77 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java
index 424c548b21..f589c42a09 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtil... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/UriUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,235 | issue_to_patch | unity调用浮窗申请权限时可能遇到的Bug | 修正：如果是unity申请悬浮权限，当权限设置页面打开时，app切换到后台再切回，设置页面会被强制关闭，此时正常流程不会触发 | 1fb408022f5213231067e36b0d291a41a6961c08 | a5462747bc603f0df25d17a475177621f324bb74 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/PermissionUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/PermissionUtils.java
index 0d8254ad8a..5b411ec370 100755
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/PermissionUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/PermissionUtils.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,109 | issue_to_patch | fix bug | 1.ClickUtils.createStyleDrawable()中的createAlphaDrawable创建disable传值问题；
2.ClickUtils.createAlphaDrawable和createDarkDrawable兼容性问题，一些getIntrinsicWidth()<0的drawable会闪退；
3.api21之前，View.post的回调是有可能在view还没添加到window前执行的，增加了判断。 | d133408a03a8bd42bc3ffb7f4ee659f7b18f27e6 | 359dc53f704608df44ef2032d889ab0f4eeaee66 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ClickUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/ClickUtils.java
index 1f0b5b5e9c..76b5d1d661 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/ClickUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/C... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/ClickUtils.java",
"lib/utildebug/src/main/java/com/blankj/utildebug/base/view/BaseContentFloatView.java"
] | [] | true | ||
Blankj/AndroidUtilCode | 1,094 | issue_to_patch | feat: FileUtils.getFileCharsetSimple()区分UTF-8无BOM和GBK编码 | 3513c74c1aabf5cfb7f5263dd9859f3f36e7f0a1 | 6bc10a756350a54f998bba7ab018ac08acc6fa77 | diff --git a/lib/utilcode/src/main/java/com/blankj/utilcode/util/FileUtils.java b/lib/utilcode/src/main/java/com/blankj/utilcode/util/FileUtils.java
index c73b994b4f..02dd200aa5 100644
--- a/lib/utilcode/src/main/java/com/blankj/utilcode/util/FileUtils.java
+++ b/lib/utilcode/src/main/java/com/blankj/utilcode/util/File... | [
"lib/utilcode/src/main/java/com/blankj/utilcode/util/FileUtils.java",
"lib/utilcode/src/test/res/file/GBK.txt"
] | [] | diff --git a/lib/utilcode/src/test/res/file/GBK.txt b/lib/utilcode/src/test/res/file/GBK.txt
index 88ef6b9454..3d8088b4cc 100644
--- a/lib/utilcode/src/test/res/file/GBK.txt
+++ b/lib/utilcode/src/test/res/file/GBK.txt
@@ -1,1 +1,2 @@
-GBK
\ No newline at end of file
+GBK
+�Ұ��й�
\ No newline at end of file
| true | ||
Blankj/AndroidUtilCode | 826 | issue_to_patch | Revert "1.23.4" | Reverts Blankj/AndroidUtilCode#825 | c1ed4cd2b9ffe8eecf9319e63a53702ee77d3205 | db150a70162a56ca9b31b1651ffa3dee353ee656 | diff --git a/README-CN.md b/README-CN.md
index 0d0d9a2e28..1054fb665e 100644
--- a/README-CN.md
+++ b/README-CN.md
@@ -41,7 +41,7 @@
[logo]: https://raw.githubusercontent.com/Blankj/AndroidUtilCode/master/art/logo.png
-[aucSvg]: https://img.shields.io/badge/AndroidUtilCode-v1.23.4-brightgreen.svg
+[aucSvg]: https:... | [
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"subutil/lib/src/main/java/com/blankj/subutil/util/RomUtils.java",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/DeviceUtils.java",
"utilcod... | [] | true | ||
Blankj/AndroidUtilCode | 825 | issue_to_patch | 1.23.4 | 添加设备数据获取方法 | b3bed76fc69da951700fe69a535c3b5696ba2600 | 871d01502042e36642686ad79e465915b16e4050 | diff --git a/README-CN.md b/README-CN.md
index 1054fb665e..0d0d9a2e28 100644
--- a/README-CN.md
+++ b/README-CN.md
@@ -41,7 +41,7 @@
[logo]: https://raw.githubusercontent.com/Blankj/AndroidUtilCode/master/art/logo.png
-[aucSvg]: https://img.shields.io/badge/AndroidUtilCode-v1.23.3-brightgreen.svg
+[aucSvg]: https:... | [
"README-CN.md",
"README.md",
"config.gradle",
"lib/base/build.gradle",
"subutil/lib/src/main/java/com/blankj/subutil/util/RomUtils.java",
"utilcode/README-CN.md",
"utilcode/README-STATIC-BUS.md",
"utilcode/README.md",
"utilcode/lib/src/main/java/com/blankj/utilcode/util/DeviceUtils.java",
"utilcod... | [] | true | ||
Blankj/AndroidUtilCode | 819 | issue_to_patch | 修复getNetworkType()方法在一体机判断以太网无效的问题 | 667b3d7b307044d97c0749eafe90bc0f95256a49 | 8471de6104fb34ee20217979d6b1ab20ab9b63c4 | diff --git a/utilcode/lib/src/main/java/com/blankj/utilcode/util/NetworkUtils.java b/utilcode/lib/src/main/java/com/blankj/utilcode/util/NetworkUtils.java
index a2a8ae0432..23eb3b3f00 100644
--- a/utilcode/lib/src/main/java/com/blankj/utilcode/util/NetworkUtils.java
+++ b/utilcode/lib/src/main/java/com/blankj/utilcode/... | [
"utilcode/lib/src/main/java/com/blankj/utilcode/util/NetworkUtils.java"
] | [] | true | |||
Blankj/AndroidUtilCode | 816 | issue_to_patch | 1.23.2 | 2ee43f12d7389e3c9ae6ba68c351dca0535d015f | bc713106fe2809345f1abe6e2d87e0c59322aa7c | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 416b4719b8..2729ab22f0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* `19/01/24` [add] CloneUtils. Publish v1.23.2.
+* `19/01/24` [add] BrightnessUtils and FlashlightUtils.
* `19/01/23` [add] Modify the demo of utilcode use kotlin. Publish v1.23.1.
* `19... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"config.gradle",
"launcher/app/__bus__.json",
"launcher/pkg/src/main/java/com/blankj/launcher/pkg/MainActivity.kt",
"lib/base/build.gradle",
"lib/base/src/main/java/com/blankj/lib/base/BaseBackActivity.kt",
"lib/base/src/main/java/com/blankj/lib/base/Base... | [] | diff --git a/subutil/lib/src/test/java/com/blankj/subutil/util/CloneUtilsTest.java b/subutil/lib/src/test/java/com/blankj/subutil/util/CloneUtilsTest.java
deleted file mode 100644
index 5667248e07..0000000000
--- a/subutil/lib/src/test/java/com/blankj/subutil/util/CloneUtilsTest.java
+++ /dev/null
@@ -1,44 +0,0 @@
-pac... | true | ||
Blankj/AndroidUtilCode | 805 | issue_to_patch | 1.23.0 | 239f18bbc22a703ca2965ffda17a3f318b904477 | b012e98b9b57d870cbffba8de437dce96046002f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8f96c63e60..563df29c74 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,8 @@
+* `19/01/17` [fix] Publish v1.23.0.
+* `19/01/16` [fix] BarUtils get Activity from view and delete the function of set status bar alpha.
+* `19/01/15` [add] ColorUtils.
+* `19/01/04` [add]... | [
"CHANGELOG.md",
"README-CN.md",
"README.md",
"bus-gradle-plugin/src/main/java/com/blankj/util/JsonUtils.groovy",
"bus-gradle-plugin/src/main/java/com/blankj/util/ZipUtils.java",
"config.gradle",
"launcher/pkg/src/main/java/com/blankj/launcher/pkg/MainActivity.kt",
"lib/base/build.gradle",
"lib/base/... | [] | diff --git a/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTest.java b/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTest.java
index 5eb5cf8c61..55162bd03f 100644
--- a/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTest.java
+++ b/utilcode/lib/src/test/java/com/blankj/utilcode/util/BaseTes... | true | ||
Blankj/AndroidUtilCode | 800 | issue_to_patch | 增加Android 网络工具类 HttpsUtil | 支持 4种方式向服务器传送数据
1. post + json
2 post + form
3 get + json
4 get + form | ce548a94aefcdebd464dba1907908ca5e185f9a1 | bbb9bda2b73f948a85193855a10c90fac8651344 | diff --git a/subutil/lib/src/main/java/com/blankj/subutil/util/HttpsUtil b/subutil/lib/src/main/java/com/blankj/subutil/util/HttpsUtil
new file mode 100644
index 0000000000..d9089b07bc
--- /dev/null
+++ b/subutil/lib/src/main/java/com/blankj/subutil/util/HttpsUtil
@@ -0,0 +1,127 @@
+package com.blankj.subutil.util;
+
+... | [
"subutil/lib/src/main/java/com/blankj/subutil/util/HttpsUtil"
] | [] | true | ||
BloopAI/vibe-kanban | 3,389 | issue_to_patch | Sort model selector models alphabetically (Vibe Kanban) | ## Summary
This PR updates the model selector so model options are displayed in alphabetical order instead of being reordered by recent usage.
## What Changed
- Replaced the recency-based model ordering logic in `packages/ui/src/components/ModelSelectorPopover.tsx` with a stable alphabetical sort.
- Applied the alphab... | 9f1015036c966e17a0518e1f29f116ad5852a66c | 69513261570ac04a23af9db045287415b20e5ac0 | diff --git a/packages/ui/src/components/ModelSelectorPopover.tsx b/packages/ui/src/components/ModelSelectorPopover.tsx
index f39717c04b4..2e98f9a1a76 100644
--- a/packages/ui/src/components/ModelSelectorPopover.tsx
+++ b/packages/ui/src/components/ModelSelectorPopover.tsx
@@ -18,8 +18,6 @@ import {
import { ModelProvi... | [
"packages/ui/src/components/ModelSelectorPopover.tsx"
] | [
{
"comment": "### Unused prop left in exported interface\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `recentModelEntries` prop was removed from the component destructuring and all internal usage, but it's still declared in the exported `ModelSelectorPopoverProps` interface. This means callers (like `... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.