repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Eugeny/tabby | 10,960 | issue_to_patch | Hide the mac DOCK icon
My macOS dock is jam-packed, and since I can easily show and hide tabby with option+space, I don't need the dock icon. I forgot exactly where I saw the shell changing functions of the dock icon right click context menu, but it's somewhere else too. So far, I'm not much of a shell switcher anyway... | Fix hiding the app from macos dock when docking is enabled | Resolves #9037 which is actually a bug. In MacOS it looks like the intent was to hide the application from the MacOS dock when the application is "docked" with the global hotkey, however this didn't work correctly.
Also small improvement to the description of the hideTray config setting to make it clearer that it hi... | 431ea2156337240820b61f64ec80070837af195f | f4e00643f62dab1102deae04190763c87c446081 | diff --git a/app/lib/window.ts b/app/lib/window.ts
index 8e01ee14fc2..167fab51be3 100644
--- a/app/lib/window.ts
+++ b/app/lib/window.ts
@@ -254,8 +254,12 @@ export class Window {
if (process.platform === 'darwin') {
// Lose focus
Menu.sendActionToFirstResponder('hide:')
+ ... | [
"app/lib/window.ts",
"tabby-settings/src/components/windowSettingsTab.component.pug"
] | [] | true | |
Eugeny/tabby | 10,971 | issue_to_patch | Add SFTP context menu download for files | Includes the option to download files using the menu by right-clicking.
https://github.com/Eugeny/tabby/pull/10788
<img width="408" height="238" alt="image" src="https://github.com/user-attachments/assets/8a2b4709-5d6b-42c9-a712-56571e59df5c" />
I hope to contribute, and congratulations on your work.
Regard... | 4566a9147435bb68324f3f2afb80d504407d544b | d9952d409a5acb852020ebc46aa865d8a83308e5 | diff --git a/locale/pt-BR.po b/locale/pt-BR.po
index 168b50af8ee..101d95d51a7 100644
--- a/locale/pt-BR.po
+++ b/locale/pt-BR.po
@@ -710,7 +710,7 @@ msgstr "Abaixo"
#: locale/tmp-html/tabby-settings/src/components/configSyncSettingsTab.component.html:43
msgid "Download"
-msgstr "Transferir"
+msgstr "Download"
#:... | [
"locale/pt-BR.po",
"tabby-ssh/src/components/sftpPanel.component.ts",
"tabby-ssh/src/sftpContextMenu.ts"
] | [] | true | ||
Eugeny/tabby | 11,018 | issue_to_patch | add leoberbert as a contributor for code | Adds @leoberbert as a contributor for code.
This was requested by Eugeny [in this comment](https://github.com/Eugeny/tabby/pull/10971#issuecomment-3854073906)
[skip ci] | 44dfc55bebf46970362e5ee975b8da6246b90619 | a29d52552494831e4cde3e4be9f2963a09818711 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 11f2ecc6d59..58e8547b593 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -1382,6 +1382,15 @@
"contributions": [
"code"
]
+ },
+ {
+ "login": "leoberbert",
+ "name": "Leonardo Berbert",
+ "avatar_url": ... | [
".all-contributorsrc",
"README.de-DE.md",
"README.es-ES.md",
"README.id-ID.md",
"README.it-IT.md",
"README.ja-JP.md",
"README.ko-KR.md",
"README.md",
"README.pt-BR.md",
"README.ru-RU.md",
"README.zh-CN.md"
] | [] | true | ||
Eugeny/tabby | 11,007 | issue_to_patch | The latest commit on the master branch is causing the tab to not display any content. (1.0.231-nightly.0)
<!--
# READ CAREFULLY:
* **ENGLISH ONLY** - this issue tracker is English-only. Please respect the people who take time to help you with your problems.
* Search existing issues first: https://github.com/Eugeny/ta... | fix: upgraded webpack to fix ES6 class extension bug with xterm.js v6 | Upgraded webpack to 5.90.0+ (resolved to 5.104.1) in package.json
fix https://github.com/Eugeny/tabby/issues/11006 | b31a48677da17a691e2102354beee8e5c69c8dde | 5f607b72f1f485e3441498437b9370f612deae7c | diff --git a/app/yarn.lock b/app/yarn.lock
index af886f13347..38d4be643fd 100644
--- a/app/yarn.lock
+++ b/app/yarn.lock
@@ -4393,8 +4393,7 @@ strict-uri-encode@^2.0.0:
resolved "https://registry.yarnpkg.com/strict-uri-encode/-/strict-uri-encode-2.0.0.tgz#b9c7330c7042862f6b142dc274bbcc5866ce3546"
integrity sha512... | [
"app/yarn.lock",
"package.json",
"yarn.lock"
] | [] | true | |
Eugeny/tabby | 11,005 | issue_to_patch | feat: Implement tabby:// URL scheme handler | ## Summary
This PR implements the `tabby://` custom URL scheme, enabling external control of Tabby via URLs.
It allows users to trigger CLI commands directly from browsers or other applications.
## Key Changes
- **Protocol Registration**: Registered the `tabby` scheme across Windows, macOS ( `open-url` ), and L... | a6da819b939b8761b37491b1f7cf38e6b8c3bd3c | 111c3a8eb6cda6a3661a45eda96bf166a6470d13 | diff --git a/app/lib/cli.ts b/app/lib/cli.ts
index 1b8fb06e159..6666d02e94f 100644
--- a/app/lib/cli.ts
+++ b/app/lib/cli.ts
@@ -1,52 +1,133 @@
import { app } from 'electron'
-export function parseArgs (argv: string[], cwd: string): any {
- if (argv[0].includes('node')) {
- argv = argv.slice(1)
- }
+int... | [
"app/lib/cli.ts",
"app/lib/index.ts",
"app/lib/urlHandler.ts",
"app/lib/window.ts",
"electron-builder.yml",
"tabby-core/src/api/cli.ts",
"tabby-core/src/cli.ts",
"tabby-electron/src/services/uac.service.ts",
"tabby-local/src/cli.ts",
"tabby-local/src/components/localProfileSettings.component.ts",
... | [] | true | ||
Eugeny/tabby | 11,004 | issue_to_patch | feat: Allow third-party plugins to add quick connection support. | ## Description
This PR improves the `quickConnect` CLI command to better support third-party plugins that implement `QuickConnectProfileProvider`
Plugins available for testing: `ws-term`
Test guidance: https://github.com/ruanimal/tabby-ws-term/blob/master/docs/ws-test-server.md
## Changes
- Removed hardcoded c... | c7e6858d5bf0cfe0059aefb91a3f31112dae8876 | 30d2bfd93197adc5bd6ea52887eceebeef6cb015 | diff --git a/app/lib/cli.ts b/app/lib/cli.ts
index 03213dd839a..1b8fb06e159 100644
--- a/app/lib/cli.ts
+++ b/app/lib/cli.ts
@@ -30,9 +30,8 @@ export function parseArgs (argv: string[], cwd: string): any {
})
.command('quickConnect <providerId> <query>', 'open a tab for specified quick connect provide... | [
"app/lib/cli.ts",
"tabby-core/src/cli.ts"
] | [] | true | ||
Eugeny/tabby | 10,986 | issue_to_patch | fix(pluginsSettingsTab.component.pug): flex wrapper for gap in buttons | <img width="611" height="500" alt="image" src="https://github.com/user-attachments/assets/311757af-fecd-44a0-9fe9-9fe51210e292" />
| 4566a9147435bb68324f3f2afb80d504407d544b | 8e684d117650cf4042239181fe9188571d6ad2c2 | diff --git a/tabby-plugin-manager/src/components/pluginsSettingsTab.component.pug b/tabby-plugin-manager/src/components/pluginsSettingsTab.component.pug
index 9ab70bcbd9a..056d0525a08 100644
--- a/tabby-plugin-manager/src/components/pluginsSettingsTab.component.pug
+++ b/tabby-plugin-manager/src/components/pluginsSetti... | [
"tabby-plugin-manager/src/components/pluginsSettingsTab.component.pug"
] | [] | true | ||
Eugeny/tabby | 10,974 | issue_to_patch | bump xterm | 4566a9147435bb68324f3f2afb80d504407d544b | b23c5bf19435bde7edfa659d3decee8100d4a747 | diff --git a/tabby-terminal/package.json b/tabby-terminal/package.json
index cb26cd77022..c11e15d6f8f 100644
--- a/tabby-terminal/package.json
+++ b/tabby-terminal/package.json
@@ -19,15 +19,16 @@
"author": "Tabby Developers",
"license": "MIT",
"devDependencies": {
- "@xterm/addon-canvas": "^0.6.0",
- "@... | [
"tabby-terminal/package.json",
"tabby-terminal/src/api/baseTerminalTab.component.ts",
"tabby-terminal/src/frontends/xterm.css",
"tabby-terminal/src/frontends/xtermFrontend.ts",
"tabby-terminal/src/middleware/oscProcessing.ts",
"tabby-terminal/yarn.lock"
] | [] | true | |||
FiloSottile/mkcert | 580 | issue_to_patch | Fixed broken readme link to arch linux package | 2a46726cebac0ff4e1f133d90b4e4c42f1edf44a | 4aa819db5d4c0d914f3270e15a319e9a24d5c0a0 | diff --git a/README.md b/README.md
index 6b47a0f4..4430cc03 100644
--- a/README.md
+++ b/README.md
@@ -83,7 +83,7 @@ chmod +x mkcert-v*-linux-amd64
sudo cp mkcert-v*-linux-amd64 /usr/local/bin/mkcert
```
-For Arch Linux users, [`mkcert`](https://www.archlinux.org/packages/community/x86_64/mkcert/) is available on t... | [
"README.md"
] | [] | true | |||
FiloSottile/mkcert | 433 | issue_to_patch | Build binaries for darwin/arm64 | Adds a binary build for macOS on ARM arch, ie: M1 processors. | 4b065acd87cef2cfa1b29da38926e460437b3264 | 313fa02bad408f2ec4ff9a8986c4c8f8b4248ec3 | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 91dc74d3..8272b85d 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -19,6 +19,7 @@ jobs:
CGO_ENABLED=0 GOOS=linux GOARCH=arm GOARM=6 go build -o "mkcert-$(git describe --tags)-linux-arm" -ldflags... | [
".github/workflows/release.yml"
] | [] | true | ||
FiloSottile/mkcert | 396 | issue_to_patch | Add Windows arm64 build to CI pipeline | Go 1.17 [added support for Windows arm64](https://golang.org/doc/go1.17#windows). This PR adds Windows arm64 to the CI pipeline. | 4b065acd87cef2cfa1b29da38926e460437b3264 | 95d699a80f715e7acefe9c6d4a52500780eaeed4 | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 91dc74d3..df894290 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -20,6 +20,7 @@ jobs:
CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -o "mkcert-$(git describe --tags)-linux-arm64" -ldflags "-X... | [
".github/workflows/release.yml"
] | [] | true | ||
FiloSottile/mkcert | 399 | issue_to_patch | Correct failed to save CA cert message. | 4b065acd87cef2cfa1b29da38926e460437b3264 | 9cd783f7d0f431c5bcec8cdfeb4d512ea5eb077e | diff --git a/cert.go b/cert.go
index 56750aa8..02fedd1b 100644
--- a/cert.go
+++ b/cert.go
@@ -356,7 +356,7 @@ func (m *mkcert) newCA() {
err = ioutil.WriteFile(filepath.Join(m.CAROOT, rootName), pem.EncodeToMemory(
&pem.Block{Type: "CERTIFICATE", Bytes: cert}), 0644)
- fatalIfErr(err, "failed to save CA key")
+... | [
"cert.go"
] | [] | true | |||
FiloSottile/mkcert | 340 | issue_to_patch | Linuxbrew -> Homebrew on Linux | Homebrew was formerly referred to as Linuxbrew when running on Linux or WSL. | 1a5aaff12e0edb54f32ce187079d05c4a1ffd19b | 424bcfd55bc2d6d2570b5265628d191a303415e0 | diff --git a/README.md b/README.md
index b8dacdda..c99d4754 100644
--- a/README.md
+++ b/README.md
@@ -62,7 +62,7 @@ sudo pacman -S nss
sudo zypper install mozilla-nss-tools
```
-Then you can install using [Linuxbrew](http://linuxbrew.sh/)
+Then you can install using [Homebrew on Linux](https://docs.brew.sh/Homebre... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 215 | issue_to_patch | analysis.go: use x/tools/go/analysis/multichecker to run analysis tools | This pattern has a number of advantages: it tracks the versions of the
tools in go.mod, it doesn't require installing anything in CI, it runs
all analysis passes at once, and it lets us add custom ones easily. | 4ffcbacbb0524b76b94c926e904dcdeb41daf28a | c27728edd9f0d8ebd17e466e5285b53c86cc379a | diff --git a/.travis.yml b/.travis.yml
index 892a74df..5c196286 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,11 +1,8 @@
language: go
-sudo: false
go: stable
-install: (cd && go get honnef.co/go/tools/cmd/staticcheck)
script:
- - go vet
- - staticcheck ./...
+ - go run analysis.go ./...
- CGO_ENABLED=0 GO... | [
".travis.yml",
"analysis.go",
"go.mod",
"go.sum"
] | [] | true | ||
FiloSottile/mkcert | 311 | issue_to_patch | Switch to GitHub Actions | 9c196b6cdb3bfaa43504a52bf52ae41644f0094f | 8de8c96cb29e06603c0e74d4c2da1a2748ee1847 | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
new file mode 100644
index 00000000..91dc74d3
--- /dev/null
+++ b/.github/workflows/release.yml
@@ -0,0 +1,46 @@
+on:
+ release:
+ types: [published]
+name: Upload Release Asset
+jobs:
+ release:
+ name: Upload Release Asset
+ runs-on... | [
".github/workflows/release.yml",
".github/workflows/test.yml",
".travis.yml"
] | [] | true | |||
FiloSottile/mkcert | 314 | issue_to_patch | Fix and update CI analyzers | 33ca7b5c46ee99aae00083313855e20465b7dc42 | ae7f5b048cee6b6ed8dc933bc6b47289faafd03b | diff --git a/analysis.go b/analysis.go
index b1705082..90e6cd94 100644
--- a/analysis.go
+++ b/analysis.go
@@ -20,17 +20,19 @@ import (
"golang.org/x/tools/go/analysis/passes/copylock"
"golang.org/x/tools/go/analysis/passes/errorsas"
"golang.org/x/tools/go/analysis/passes/httpresponse"
+ "golang.org/x/tools/go/an... | [
"analysis.go",
"go.mod",
"go.sum",
"truststore_windows.go"
] | [] | true | |||
FiloSottile/mkcert | 264 | issue_to_patch | Don't overwrite the -key-file if it's identical to -cert-file | Especially for testing I find it much more convenient to just store both
the key and certificate in a single file, which works with pretty much
all software I've used.
Currently, the -cert-file will overwrite the -key-file since it uses
ioutil.WriteFile(). This fixes it to *append* if the files are
identical. | 6649e9d2e72532139d0ecf6f39f24a30a688ca46 | a8bf15a751be450c44e1a8e19e6bef6b22108043 | diff --git a/cert.go b/cert.go
index 77b2ee03..34e9e804 100644
--- a/cert.go
+++ b/cert.go
@@ -108,15 +108,20 @@ func (m *mkcert) makeCert(hosts []string) {
certFile, keyFile, p12File := m.fileNames(hosts)
if !m.pkcs12 {
+ certPEM := pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: cert})
privDER, er... | [
"cert.go"
] | [
{
"comment": "-----BEGIN PGP PUBLIC KEY BLOCK-----\r\nVersion: GnuPG v1.2.2 (GNU/Linux)\r\n\r\nmQGiBD8OdRwRBACEr0/NPA88qp8f6KyIMMveLQ1FOuLi0aDQDPybG7u1nrBoi3VI\r\ntSRyfYcdExVxWQjTGd9qbShzXBw2DsxjA6YjiGzWKpVcqtj9uUDpSlylBaoadUzu\r\nSf3r3IkOHR2QJeC+9v2il30xy5XLMxDRbQYaSmf4uwTlIOUWNn118KpdawCgoNny\r\np4DR9EvRgCmY5... | true | ||
FiloSottile/mkcert | 284 | issue_to_patch | Build mkcert for arm64 Linux | There isn't a build for arm64 Linux at the moment. This PR adds support for arm64. More details: https://github.com/golang/go/wiki/GoArm | a2b1208e9c7d6a9588bce49729cfedbdf9f8be21 | 3758a791bc63464a51ffd8593473df379c6afe3d | diff --git a/.travis.yml b/.travis.yml
index 853f12d7..0e2763f1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -7,6 +7,8 @@ script:
-ldflags "-X main.Version=$(git describe --tags)"
- CGO_ENABLED=0 GOOS=linux GOARCH=arm GOARM=6 go build -o "mkcert-$(git describe --tags)-linux-arm"
-ldflags "-X main.... | [
".travis.yml"
] | [
{
"comment": "```suggestion\r\n -ldflags \"-X main.Version=$(git describe --tags)\"\r\n - CGO_ENABLED=0 GOOS=linux GOARCH=arm go build -o \"mkcert-$(git describe --tags)-linux-arm\"\r\n -ldflags \"-X main.Version=$(git describe --tags)\"\r\n \r\n```",
"path": ".travis.yml",
"hunk":... | true | ||
FiloSottile/mkcert | 265 | issue_to_patch | Make mkcert -help print to stdout instead of stderr | Currently "mkcert -help" prints to stderr, which is rather annoying as:
$ mkcert -help | less
Gives us a blank page, as it pipes only stdout. To get any results in
less I need to use:
$ mkcert 2>&1 | less
$ mkcert |& less # Non-standard bash/ zsh
Since the user explicitly asked for help with -help,... | a2b1208e9c7d6a9588bce49729cfedbdf9f8be21 | 6fdb7b3aa08b263e735382e115f25f2dab75851e | diff --git a/main.go b/main.go
index 23be39e5..0705a10c 100644
--- a/main.go
+++ b/main.go
@@ -106,8 +106,8 @@ func main() {
}
flag.Parse()
if *helpFlag {
- fmt.Fprint(flag.CommandLine.Output(), shortUsage)
- fmt.Fprint(flag.CommandLine.Output(), advancedUsage)
+ fmt.Print(shortUsage)
+ fmt.Print(advancedUsag... | [
"main.go"
] | [] | true | ||
FiloSottile/mkcert | 280 | issue_to_patch | Support camel-case name variant of Firefox Dev Edition | The latest versions of Firefox Developer Edition on macOS seem to use upper camel case naming for the app. This ensures that the CA will be added to the Firefox trust store if using recent versions of FF Dev Edition. | a2b1208e9c7d6a9588bce49729cfedbdf9f8be21 | fba82e5c6d0ffaeea4b2c81a39f486ce8e7fec90 | diff --git a/truststore_nss.go b/truststore_nss.go
index aad559ae..a82f0dc3 100644
--- a/truststore_nss.go
+++ b/truststore_nss.go
@@ -28,6 +28,7 @@ var (
"/usr/bin/firefox-nightly",
"/usr/bin/firefox-developer-edition",
"/Applications/Firefox.app",
+ "/Applications/FirefoxDeveloperEdition.app",
"/Applicat... | [
"truststore_nss.go"
] | [] | true | ||
FiloSottile/mkcert | 226 | issue_to_patch | README: Mention official Arch Linux package | Signed-off-by: Christian Rebischke <chris@nullday.de> | cb6311cfbe4d93f81c3ee65ae51f0f5e5f677c5e | 196dc45253bdf8ecaf2eac8ed2d3809bc1767a38 | diff --git a/README.md b/README.md
index 772f06e3..45aaffe5 100644
--- a/README.md
+++ b/README.md
@@ -78,12 +78,10 @@ go build -ldflags "-X main.Version=$(git describe --tags)"
or use [the pre-built binaries](https://github.com/FiloSottile/mkcert/releases).
-For Arch Linux users, mkcert is available from AUR as [... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 228 | issue_to_patch | README: Add cd mkcert to build from source instructions | This adds a missing `cd mkcert` in the instructions to build from source in the README document. | cb6311cfbe4d93f81c3ee65ae51f0f5e5f677c5e | 7fb6ee7a04673284f2fc3a8f470f7f059fcddbbf | diff --git a/README.md b/README.md
index 772f06e3..96edda1a 100644
--- a/README.md
+++ b/README.md
@@ -72,7 +72,7 @@ brew install mkcert
or build from source (requires Go 1.13+)
```
-git clone https://github.com/FiloSottile/mkcert
+git clone https://github.com/FiloSottile/mkcert && cd mkcert
go build -ldflags "-X ... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 225 | issue_to_patch | add firefox nightly and developer edition binary paths | on my system I have only Firefox Nightly installed, so `/usr/bin/firefox` doesn't exist and so `hasNSS` was false and CA wasn't installed.
on my arch based system, the binary was at `/usr/bin/firefox-nightly`
https://aur.archlinux.org/packages/firefox-nightly/
it could also be at `/usr/bin/firefox-developer-edit... | d8d73fcb89790dcb672a475ec6406c7ea7bc8f30 | 44bf034835ce33ce71975130d278784c6bc5573c | diff --git a/truststore_nss.go b/truststore_nss.go
index a7c315e5..aad559ae 100644
--- a/truststore_nss.go
+++ b/truststore_nss.go
@@ -24,7 +24,10 @@ var (
"/etc/pki/nssdb", // CentOS 7
}
firefoxPaths = []string{
- "/usr/bin/firefox", "/Applications/Firefox.app",
+ "/usr/bin/firefox",
+ "/usr/bin/firefox-nigh... | [
"truststore_nss.go"
] | [] | true | ||
FiloSottile/mkcert | 218 | issue_to_patch | Add note about advanced options in README | Clarify position of advanced options argumnts (they won’t work if are placed after domain names)
Add example. | 90341b0d5a9225a26693cb1bc6b921c63f63e449 | 2bd0474733fc25fce24a3d5e0f1a63164bad6d62 | diff --git a/README.md b/README.md
index 56f3bc9f..487b729a 100644
--- a/README.md
+++ b/README.md
@@ -144,6 +144,14 @@ To only install the local root CA into a subset of them, you can set the `TRUST_
all other flags and arguments except -install and -cert-file.
```
+> **Note:** You _must_ place these options ... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 224 | issue_to_patch | Fix git clone command | 90341b0d5a9225a26693cb1bc6b921c63f63e449 | 73c31436e31fbb590ace95d2a278d4e62495fb9a | diff --git a/README.md b/README.md
index 56f3bc9f..f9812c45 100644
--- a/README.md
+++ b/README.md
@@ -72,7 +72,7 @@ brew install mkcert
or build from source (requires Go 1.13+)
```
-git clone github.com/FiloSottile/mkcert
+git clone https://github.com/FiloSottile/mkcert
go build -ldflags "-X main.Version=$(git de... | [
"README.md"
] | [] | true | |||
FiloSottile/mkcert | 216 | issue_to_patch | mkcert -install (v1.4.0) fails to run in Ubuntu 16.04: SEC_ERROR_READ_ONLY
Ubuntu 16.04, linuxbrew-installed mkcert v1.4.0, mkcert -install fails with certutil error:
```
mkcert -install
Created a new local CA at "/home/circleci/.local/share/mkcert" 💥
The local CA is now installed in the system trust store! ⚡️
... | truststore_nss: retry certtool with sudo when it fails due to permissions | Based on @rfay's investigation and fix.
Fixes #192
Closes #193 | 00ded1d0148319fbe900df9251e2331e7fae8017 | 28654f2628d632981f653e40fb0b67e2462ba984 | diff --git a/truststore_java.go b/truststore_java.go
index 410e453c..8ad84bba 100644
--- a/truststore_java.go
+++ b/truststore_java.go
@@ -87,7 +87,7 @@ func (m *mkcert) installJava() {
"-alias", m.caUniqueName(),
}
- out, err := m.execKeytool(exec.Command(keytoolPath, args...))
+ out, err := execKeytool(exec.Co... | [
"truststore_java.go",
"truststore_nss.go"
] | [] | true | |
FiloSottile/mkcert | 181 | issue_to_patch | Add link to Chocolatey in README | a5bb69b6294a56bf6166ff4cb2bc1f4ccdb752aa | d41ff1e4135f13f81637ff189311711db7421bc1 | diff --git a/README.md b/README.md
index f24333fc..d0e0adb5 100644
--- a/README.md
+++ b/README.md
@@ -88,7 +88,7 @@ makepkg -si
### Windows
-On Windows, use Chocolatey
+On Windows, use [Chocolatey](https://chocolatey.org)
```
choco install mkcert
| [
"README.md"
] | [] | true | |||
FiloSottile/mkcert | 179 | issue_to_patch | Fix markdown formatting | It seems correctly show in GitHub, but this may not be shown correctly in other markdown readers. | df15e0c1efd3b2f372170e6866cac54df720e724 | a4c194ebeb81bf5e1f6cc3f770a26c6d99b3f073 | diff --git a/README.md b/README.md
index f61f4f4b..f24333fc 100644
--- a/README.md
+++ b/README.md
@@ -67,7 +67,7 @@ Then you can install using [Linuxbrew](http://linuxbrew.sh/)
```
brew install mkcert
-````
+```
or build from source (requires Go 1.10+)
| [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 171 | issue_to_patch | Add staticcheck to CI | 4d2ab596e7e846b57aae755987cbe65f9bc013c4 | 508a30aa7e1cbe1a77c9100ceb04ed1c21037deb | diff --git a/.travis.yml b/.travis.yml
index 4374421b..892a74df 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,11 @@
language: go
sudo: false
go: stable
-install: "# skip"
+install: (cd && go get honnef.co/go/tools/cmd/staticcheck)
script:
- go vet
+ - staticcheck ./...
- CGO_ENABLED=0 GOOS=linux G... | [
".travis.yml",
"main.go"
] | [] | true | |||
FiloSottile/mkcert | 166 | issue_to_patch | Add support for certificates with client and server auth and URL SANs | Thank you for this awesome tool! :-)
I wanted to use it to create certificates for a Service Mesh, that is for using Istio with mTLS without using Citadel.
Therefore I needed to create certificates that have an extended key usage of client and server auth.
I also needed to have Spiffe URIs in the Subject Alternate... | ff17118210caa046edd025115d18f48534442e0c | fbb34f6bf7be5785129aa4134736929f4dd955de | diff --git a/cert.go b/cert.go
index e444a8d5..8ce10c5d 100644
--- a/cert.go
+++ b/cert.go
@@ -20,6 +20,7 @@ import (
"math/big"
"net"
"net/mail"
+ "net/url"
"os"
"os/user"
"path/filepath"
@@ -70,13 +71,15 @@ func (m *mkcert) makeCert(hosts []string) {
tpl.IPAddresses = append(tpl.IPAddresses, ip)
} ... | [
"cert.go",
"main.go"
] | [
{
"comment": "Here and below, update the error.",
"path": "main.go",
"hunk": "@@ -194,6 +195,9 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n \t\t\tcontinue\n \t\t}\n+\t\tif _, err := url.Parse(name); err == nil {\n+\t\t\t... | true | ||
FiloSottile/mkcert | 166 | comment_to_fix | Add support for certificates with client and server auth and URL SANs | ```suggestion
log.Fatalf("ERROR: %q is not a valid hostname, IP, URL or email: %s", name, err)
``` | ff17118210caa046edd025115d18f48534442e0c | fbb34f6bf7be5785129aa4134736929f4dd955de | diff --git a/main.go b/main.go
index 15f247a0..fb1c40fb 100644
--- a/main.go
+++ b/main.go
@@ -13,6 +13,7 @@ import (
"log"
"net"
"net/mail"
+ "net/url"
"os"
"path/filepath"
"regexp"
@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {
if email, err := mail.ParseAddress(name); err == nil && email.... | [
"main.go"
] | [
{
"comment": "```suggestion\r\n\t\t\tlog.Fatalf(\"ERROR: %q is not a valid hostname, IP, URL or email: %s\", name, err)\r\n```",
"path": "main.go",
"hunk": "@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n... | true | ||
FiloSottile/mkcert | 166 | comment_to_fix | Add support for certificates with client and server auth and URL SANs | ```suggestion
log.Fatalf("ERROR: %q is not a valid hostname, IP, URL or email", name)
``` | ff17118210caa046edd025115d18f48534442e0c | fbb34f6bf7be5785129aa4134736929f4dd955de | diff --git a/main.go b/main.go
index 15f247a0..fb1c40fb 100644
--- a/main.go
+++ b/main.go
@@ -13,6 +13,7 @@ import (
"log"
"net"
"net/mail"
+ "net/url"
"os"
"path/filepath"
"regexp"
@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {
if email, err := mail.ParseAddress(name); err == nil && email.... | [
"main.go"
] | [
{
"comment": "```suggestion\r\n\t\t\tlog.Fatalf(\"ERROR: %q is not a valid hostname, IP, URL or email\", name)\r\n```",
"path": "main.go",
"hunk": "@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {\n \t\tif email, err := mail.ParseAddress(name); err == nil && email.Address == name {\n \t\t\tco... | true | ||
FiloSottile/mkcert | 168 | issue_to_patch | README: use $GOBIN instead of $GOPATH/bin | $GOPATH/bin works in the simple cases, but will break if the user
specifies their own $GOBIN, or if their $GOPATH has multiple elements.
This form is also simpler. Even if the user doesn't specify their custom
$GOBIN, 'go env GOBIN' will return the correct default. | 72ec55f07fe0412aafc8a5617d43b7a27c0ab68c | f4fc3e3febc5b2fc7bf3a035b503416d7cbdf485 | diff --git a/README.md b/README.md
index f61f4f4b..4cf78239 100644
--- a/README.md
+++ b/README.md
@@ -73,7 +73,7 @@ or build from source (requires Go 1.10+)
```
go get -u github.com/FiloSottile/mkcert
-$(go env GOPATH)/bin/mkcert
+$(go env GOBIN)/mkcert
```
or use [the pre-built binaries](https://github.com/Fi... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 162 | issue_to_patch | Support SLES & OpenSUSE | Add support for SLES & OpenSUSE. | bf089257905a02f86224f018e2b698996fd28480 | b058cc71f36de6a4d3f58d7489b386cbac20c8b3 | diff --git a/README.md b/README.md
index f77b0ab7..f61f4f4b 100644
--- a/README.md
+++ b/README.md
@@ -59,6 +59,8 @@ sudo apt install libnss3-tools
sudo yum install nss-tools
-or-
sudo pacman -S nss
+ -or-
+sudo zypper install mozilla-nss-tools
```
Then you can install using [Linuxbrew](http://linuxbrew.s... | [
"README.md",
"truststore_linux.go"
] | [] | true | ||
FiloSottile/mkcert | 152 | issue_to_patch | Support s/mime email certificates
Given an email address for a command line option, it would be cool to generate certificates suitable for S/MIME use in Thunderbird or Outlook. | Allow email SANs for S/MIME certificates | This PR allows email addresses to be passed in, along with IP addresses and domain names. Email addresses are added as SANs. The appropriate EKUs are added to the cert based on which types of SANs are present. To identify email addresses, I try parsing them with the `net/mail` package. This is probably overkill and I'm... | c7c85b20ae4de42e49f2d76de7b01c485c3ce5c2 | ba927432d16608ff3162bc4bee5e72b370945c78 | diff --git a/cert.go b/cert.go
index 853d8315..e444a8d5 100644
--- a/cert.go
+++ b/cert.go
@@ -19,6 +19,7 @@ import (
"log"
"math/big"
"net"
+ "net/mail"
"os"
"os/user"
"path/filepath"
@@ -61,18 +62,26 @@ func (m *mkcert) makeCert(hosts []string) {
NotBefore: time.Now(),
KeyUsage: x509.... | [
"cert.go",
"main.go"
] | [
{
"comment": "Why modify the argument here?",
"path": "main.go",
"hunk": "@@ -190,13 +191,17 @@ func (m *mkcert) Run(args []string) {\n \t\tif ip := net.ParseIP(name); ip != nil {\n \t\t\tcontinue\n \t\t}\n+\t\tif email, err := mail.ParseAddress(name); err == nil {\n+\t\t\targs[i] = email.Address",
... | true | |
FiloSottile/mkcert | 137 | issue_to_patch | Swap exec.Command("hostname") for os.Hostname() | I happened to do exactly this two days ago: https://twitter.com/davidcrawshaw/status/1095727243052105729 | 9e9563535ec66d65e984fe4d93d9025cb3abb5ab | b41064c09a72c988de9f18234f324529484c2096 | diff --git a/cert.go b/cert.go
index b3c8e829..853d8315 100644
--- a/cert.go
+++ b/cert.go
@@ -20,7 +20,6 @@ import (
"math/big"
"net"
"os"
- "os/exec"
"os/user"
"path/filepath"
"regexp"
@@ -38,8 +37,8 @@ func init() {
if u != nil {
userAndHostname = u.Username + "@"
}
- out, _ := exec.Command("hostn... | [
"cert.go"
] | [] | true | ||
FiloSottile/mkcert | 109 | issue_to_patch | Update README.md | 8dca36bc484b5cd0db538194d57fb4160a7e7864 | deb3ba7c6fc4f1ba5b1012bfc221ef0e189af5cf | diff --git a/README.md b/README.md
index 4eb020f2..3610c177 100644
--- a/README.md
+++ b/README.md
@@ -95,6 +95,7 @@ choco install mkcert
or use Scoop
```
+scoop bucket add extras
scoop install mkcert
```
| [
"README.md"
] | [] | true | |||
FiloSottile/mkcert | 102 | issue_to_patch | Add 'Firefox Nightly.app' for macOS. | Added FirefoxNightly.app for macOS, as similar to 'Firefox Developer Edition', it gets installed with a different name (as per brew https://github.com/Homebrew/homebrew-cask-versions/blob/8a61151ae75b0d87723e024256b036c511cd6096/Casks/firefox-nightly.rb#L112) | da4da8a4bc86e0dff9c338c547bb1298220d5433 | 3a04b89c57ccf6f8110e29ed4ee5434d29d3f889 | diff --git a/truststore_nss.go b/truststore_nss.go
index 1987ec88..bb52d106 100644
--- a/truststore_nss.go
+++ b/truststore_nss.go
@@ -20,6 +20,7 @@ func init() {
for _, path := range []string{
"/usr/bin/firefox", nssDB, "/Applications/Firefox.app",
"/Applications/Firefox Developer Edition.app",
+ "/Applicatio... | [
"truststore_nss.go"
] | [] | true | ||
FiloSottile/mkcert | 77 | issue_to_patch | Add ability of customizing file name | Just as mentioned in issue #72 which was opened more than one month ago, it is useful to customlize the name of target file.
Usage:
```bash
mkcert --key-file my-cert.pem --cert-file my-key.pem example.com '*.example.org' myapp.dev localhost 127.0.0.1 ::1
```
or for p12 file
```bash
mkcert --p12-file my.... | 0d0636e82470193b0d186c749e352f201b78b076 | 8e89158400ad62eb3866e1460d9c82b9dc37b201 | diff --git a/cert.go b/cert.go
index 52068dbe..79d59753 100644
--- a/cert.go
+++ b/cert.go
@@ -77,27 +77,23 @@ func (m *mkcert) makeCert(hosts []string) {
cert, err := x509.CreateCertificate(rand.Reader, tpl, m.caCert, &pub, m.caKey)
fatalIfErr(err, "failed to generate certificate")
- filename := strings.Replace(... | [
"cert.go",
"main.go"
] | [
{
"comment": "Are these replacements needed because of how we generate names? ",
"path": "cert.go",
"hunk": "@@ -39,6 +40,34 @@ func init() {\n \tuserAndHostname += strings.TrimSpace(string(out))\n }\n \n+// getFileName generate file name according to flags\n+func (m *mkcert) getFileName(w string, args ... | true | ||
FiloSottile/mkcert | 85 | issue_to_patch | java: don't attempt retry on windows | Issue: https://github.com/FiloSottile/mkcert/issues/84 | 438ae98b1ce7b50b0e8b72f1e7dc467ffe4c7087 | d025095bdf9fdc4912e8e7adc343c0ca8b4521e8 | diff --git a/README.md b/README.md
index 960c9677..5fb816d4 100644
--- a/README.md
+++ b/README.md
@@ -100,6 +100,8 @@ scoop install mkcert
or build from source (requires Go 1.10+), or use [the pre-built binaries](https://github.com/FiloSottile/mkcert/releases).
+If you're running into permission problems try runn... | [
"README.md",
"truststore_java.go"
] | [
{
"comment": "This entire block should be skipped on Windows, as it's pointless to retry if we are not adding sudo.\r\n\r\n```suggestion\r\n\tif err != nil && bytes.Contains(out, []byte(\"java.io.FileNotFoundException\")) && runtime.GOOS != \"windows\" {\r\n```",
"path": "truststore_java.go",
"hunk": "@... | true | ||
FiloSottile/mkcert | 90 | issue_to_patch | java: don't run keytool during check if we there isn't even one found | If JAVA_HOME isn't set then keytoolPath has an invalid path. This means checkJava() fails and doesn't tell the problem clearly to the user.
Issue: https://github.com/FiloSottile/mkcert/issues/88 | 48e7d200ae203621d90742f31f3032942d5ab499 | 8a91d81c0c06c1de54325f844f3534906ac29733 | diff --git a/truststore_java.go b/truststore_java.go
index a7d39803..aa7cd180 100644
--- a/truststore_java.go
+++ b/truststore_java.go
@@ -58,6 +58,10 @@ func init() {
}
func (m *mkcert) checkJava() bool {
+ if !hasKeytool {
+ return false
+ }
+
// exists returns true if the given x509.Certificate's fingerprint
... | [
"truststore_java.go"
] | [] | true | ||
FiloSottile/mkcert | 91 | issue_to_patch | README: AUR | ## Rationale
Arch Linux does not support AUR helpers ([ref](https://wiki.archlinux.org/index.php/AUR_helpers)), so the README should reflect the recommended [install process](https://wiki.archlinux.org/index.php/Arch_User_Repository#Installing_packages).
I realize this is pedantic, but users should be guided towa... | 48e7d200ae203621d90742f31f3032942d5ab499 | 654fe08561f545f39a7e5563b05d6b145b7448a0 | diff --git a/README.md b/README.md
index 111757c7..960c9677 100644
--- a/README.md
+++ b/README.md
@@ -76,10 +76,12 @@ $(go env GOPATH)/bin/mkcert
or use [the pre-built binaries](https://github.com/FiloSottile/mkcert/releases).
-On Arch Linux you can use your [AUR helper](https://wiki.archlinux.org/index.php/AUR_h... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 46 | issue_to_patch | Add Windows Support | This is to address issue #42. This uses the win32 crypt API which is what Go uses elsewhere when interfacing with the OS cert store. Also, though there is a "certutil.exe" in Windows, it's not the NSS one and therefore while I reference the FF paths, I left `hasCertutil` as false for this OS in `cert.go`.
I took car... | 61180c71ad97395b97b0a54a0d90df81206fc9c4 | 5dd27e62aa96e3661ec4e0cc502d88feadbe745d | diff --git a/truststore_windows.go b/truststore_windows.go
new file mode 100644
index 00000000..12a2777d
--- /dev/null
+++ b/truststore_windows.go
@@ -0,0 +1,130 @@
+package main
+
+import (
+ "crypto/x509"
+ "encoding/pem"
+ "fmt"
+ "io/ioutil"
+ "math/big"
+ "os"
+ "path/filepath"
+ "syscall"
+ "unsafe"
+)
+
+var (
+... | [
"truststore_windows.go"
] | [
{
"comment": "Should this just be pulled from the certificate?\r\n\r\nhttps://github.com/FiloSottile/mkcert/blob/master/cert.go#L53 ",
"path": "truststore_windows.go",
"hunk": "@@ -0,0 +1,129 @@\n+package main\n+\n+import (\n+\t\"crypto/x509\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"os\... | true | ||
FiloSottile/mkcert | 82 | issue_to_patch | docs: clarify mkcert doens't configure servers | This has come up a few times so let's clarify in the docs. | fcebdc9845560b3945005932dfc0651ac06d6b98 | 3972db8fe529ff6eee77b73b6bd812e25167e078 | diff --git a/README.md b/README.md
index 0f62dbb3..111757c7 100644
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@ The certificate is at "./example.com+5.pem" and the key at "./example.com+5-key.
Using certificates from real certificate authorities (CAs) for development can be dangerous or impossible (for hosts li... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 71 | issue_to_patch | nss/certutil installed using Macports isn't found
Hi!
First of all: big thanks, super awesome project which is really helpful for local development environments!
This is my first time using this and I use MacPorts as my preferred package manager on my macOS 10.13.6 machine. (I do have Homebrew installed, but onl... | nss: use certutil from $PATH if found on macOS | Fixes #70
@hostep can you check if this fixes your issue? | 5f8e78d01208227058e403e5b2dc3d9e136b3c9a | 0d9188ef54d7cee35648fd22793859ea74cf8016 | diff --git a/truststore_nss.go b/truststore_nss.go
index 8d97b500..1987ec88 100644
--- a/truststore_nss.go
+++ b/truststore_nss.go
@@ -28,13 +28,17 @@ func init() {
switch runtime.GOOS {
case "darwin":
- out, err := exec.Command("brew", "--prefix", "nss").Output()
+ var err error
+ certutilPath, err = exec.Loo... | [
"truststore_nss.go"
] | [] | true | |
FiloSottile/mkcert | 68 | issue_to_patch | Nitpicky fix on Macports install info | 4f4405fc0cf7b4fa59f873490962eea8258b804e | 6a88600fe7d48f2b17d108ccf35a6ffbf938e367 | diff --git a/README.md b/README.md
index 2368c16f..0f62dbb3 100644
--- a/README.md
+++ b/README.md
@@ -41,11 +41,12 @@ brew install mkcert
brew install nss # if you use Firefox
```
-or MacPorts.
+or [MacPorts](https://www.macports.org/).
```
-sudo port sync
+sudo port selfupdate
sudo port install mkcert
+sudo p... | [
"README.md"
] | [] | true | |||
FiloSottile/mkcert | 65 | issue_to_patch | Add scoop install for Windows | Same as #63 but for [Scoop installer for Windows](https://github.com/lukesampson/scoop).
See https://github.com/lukesampson/scoop/wiki/Chocolatey-Comparison
I'm waiting for PR approval in the _extras bucket_ https://github.com/lukesampson/scoop-extras/pull/1153
the script is auto-updating and will be maintained ... | f42b073e9454dd06f6d8be157ee06446e041954a | e8dc790afb0ab119979ad79db85bf7e23d12c496 | diff --git a/README.md b/README.md
index dc93f11e..2368c16f 100644
--- a/README.md
+++ b/README.md
@@ -89,6 +89,12 @@ On Windows, use Chocolatey
choco install mkcert
```
+or use Scoop
+
+```
+scoop install mkcert
+```
+
or build from source (requires Go 1.10+), or use [the pre-built binaries](https://github.com/Fi... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 61 | issue_to_patch | Mentioned Linuxbrew as the preferred way to install mkcert on Linux | Linuxbrew already packaged mkcert for Linux.
There's no need to build from source or periodically check here for updates.
Hence, it should be the preferred way to install mkcert.
I've re-phrased the README to reflect that. | 26ac5f35395fb9cba3805faf1a5a04d260271291 | 36d800beebb5dee9baef451f8282e57159737d7e | diff --git a/README.md b/README.md
index 87b82ca2..5805bdd9 100644
--- a/README.md
+++ b/README.md
@@ -30,7 +30,7 @@ mkcert automatically creates and installs a local CA in the system root store, a
## Installation
-On macOS, use Homebrew.
+On macOS, use [Homebrew](https://brew.sh/).
```
brew install mkcert
@@ ... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 63 | issue_to_patch | Add "choco install" for Windows | I love this tool and that it's so easy on macOS to use `brew install mkcert`.
I've created a Chocolatey package which is pending in review right now, but should be published very soon. ( https://chocolatey.org/packages/mkcert )
So on Windows someone can use `choco install mkcert` to install the current version or a s... | 26ac5f35395fb9cba3805faf1a5a04d260271291 | 205e48578bf67445dab994ca8f27e4519e67ac36 | diff --git a/README.md b/README.md
index 87b82ca2..0508a108 100644
--- a/README.md
+++ b/README.md
@@ -58,7 +58,13 @@ On Arch Linux you can use your [AUR helper](https://wiki.archlinux.org/index.php
yaourt -S mkcert
```
-On Windows build from source (requires Go 1.10+), or use [the pre-built binaries](https://githu... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 54 | issue_to_patch | java: fix keytool path detection on windows and JRE/JDK | Fixes: https://github.com/FiloSottile/mkcert/issues/53 | 44af1b655699715a3468685d46b5ca530469a0c4 | 3ce6d1583e9587db5eb459a74d8ab5ac8bf59ca9 | diff --git a/truststore_java.go b/truststore_java.go
index 7d84f5ff..a7d39803 100644
--- a/truststore_java.go
+++ b/truststore_java.go
@@ -13,8 +13,8 @@ import (
"hash"
"os"
"os/exec"
- "path"
"path/filepath"
+ "runtime"
"strings"
)
@@ -29,17 +29,31 @@ var (
)
func init() {
+ if runtime.GOOS == "window... | [
"truststore_java.go"
] | [
{
"comment": "Is this path created by the java installer on macos? I ran a fresh install of jdk 10 on win10 and don't see this path anywhere. I can try it on my mac as well, but I would imagine the path would be at the very least something like `/jre10.0.1/` or something like that.",
"path": "truststore_jav... | true | ||
FiloSottile/mkcert | 57 | issue_to_patch | Support installing to system trust store for Arch-based distros | Arch ca-certificates reference: https://www.archlinux.org/news/ca-certificates-update/
Working for me on Manjaro Linux 17.1.11. | 26ac5f35395fb9cba3805faf1a5a04d260271291 | bec488af3619a953a570f0a9dedd22a2426e0dd6 | diff --git a/README.md b/README.md
index 87b82ca2..26e97973 100644
--- a/README.md
+++ b/README.md
@@ -43,6 +43,8 @@ On Linux, install `certutil`
sudo apt install libnss3-tools
-or-
sudo yum install nss-tools
+ -or-
+sudo pacman -S nss
```
and build from source (requires Go 1.10+), or use [the pre-built b... | [
"README.md",
"truststore_linux.go"
] | [] | true | ||
FiloSottile/mkcert | 62 | issue_to_patch | Update README with info on how to install via MacPorts | You can now install mkcert via MacPorts. Just adding information on how to do so in the README. | 26ac5f35395fb9cba3805faf1a5a04d260271291 | c4a472e0e295966fa43a2c7696759f2a81380436 | diff --git a/README.md b/README.md
index 87b82ca2..2d923ca9 100644
--- a/README.md
+++ b/README.md
@@ -37,6 +37,13 @@ brew install mkcert
brew install nss # if you use Firefox
```
+Additionally on macOS, you can also use MacPorts.
+
+```
+sudo port sync
+sudo port install mkcert
+```
+
On Linux, install `certutil`... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 38 | issue_to_patch | support install into java cacerts file | This works for me locally on a Mac with Java 8 and 9. I'm going to test out a bit on linux and newer Java versions.
```
$ ./bin/mkcert -install
Using the local CA at "/Users/adam/Library/Application Support/mkcert" ✨
The local CA is now installed in the system trust store! ⚡️
The local CA is now installed in th... | fd504a186878bb6ec28ba2b9ce8839d88e0bd0d6 | 7207d6504562ffa68766a2094ee6643026c46011 | diff --git a/main.go b/main.go
index 25c7471c..a3298d87 100644
--- a/main.go
+++ b/main.go
@@ -83,6 +83,10 @@ func (m *mkcert) Run(args []string) {
warning = true
log.Printf("Warning: the local CA is not installed in the %s trust store! ⚠️", NSSBrowsers)
}
+ if hasJava && !m.checkJava() {
+ warning = true... | [
"main.go",
"truststore_java.go"
] | [
{
"comment": "Leftover `%s`",
"path": "main.go",
"hunk": "@@ -194,6 +203,15 @@ func (m *mkcert) uninstall() {\n \t\t\tlog.Print(\"\")\n \t\t}\n \t}\n+\tif hasJava {\n+\t\tif hasKeytool {\n+\t\t\tm.uninstallJava()\n+\t\t} else {\n+\t\t\tlog.Print(\"\")\n+\t\t\tlog.Printf(`Warning: \"keytool\" is not avai... | true | ||
FiloSottile/mkcert | 23 | issue_to_patch | Adding guide for installing mkcert on archlinux | I created an AUR PKGBUILD to quickly install mkcert on ArchLinux: https://aur.archlinux.org/packages/mkcert-git/. | 1e7d221386d437538bb1958f7b721a9c1a76882b | b454290435f209beb4a35d39a817a70a60d09b42 | diff --git a/README.md b/README.md
index 7a10ac6d..503e0143 100644
--- a/README.md
+++ b/README.md
@@ -52,6 +52,12 @@ go get -u github.com/FiloSottile/mkcert
$(go env GOPATH)/bin/mkcert
```
+On Arch Linux you can use your [AUR helper](https://wiki.archlinux.org/index.php/AUR_helpers) to install mkcert from the [PKG... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 13 | issue_to_patch | firefox: prefer cert9.db and skip that profile after | Issue: https://github.com/FiloSottile/mkcert/issues/12 | 5651e29aea6f7c031f6722881785686eea3bf57b | cb9fcc9155ea1ecfd5038b2955cdc048e95b74ef | diff --git a/truststore_nss.go b/truststore_nss.go
index 9d727274..75cf1f6b 100644
--- a/truststore_nss.go
+++ b/truststore_nss.go
@@ -100,13 +100,14 @@ func (m *mkcert) forEachNSSProfile(f func(profile string)) (found int) {
if stat, err := os.Stat(profile); err != nil || !stat.IsDir() {
continue
}
- if _, ... | [
"truststore_nss.go"
] | [] | true | ||
FiloSottile/mkcert | 33 | issue_to_patch | failed to execute "certutil -A"
This error appears when i do "mkcert -install"
>ERROR: failed to execute "certutil -A": exit status 255
>
>certutil: function failed: SEC_ERROR_LEGACY_DATABASE: The certificate/key database is in an old, unsupported format. | truststore: check if profile is a directory before joining cert*.db | This should fix FiloSottile/mkcert#12, because the `FirefoxProfile` glob also matches files like `profile.ini`. | 54cdb2c7154b97e6e477578a5f08a695822f4fcb | e7c92a2931750f6257f48ab2e0fb150e58928dee | diff --git a/truststore_nss.go b/truststore_nss.go
index 38e9ddc9..9d727274 100644
--- a/truststore_nss.go
+++ b/truststore_nss.go
@@ -97,6 +97,9 @@ func (m *mkcert) forEachNSSProfile(f func(profile string)) (found int) {
return
}
for _, profile := range profiles {
+ if stat, err := os.Stat(profile); err != nil... | [
"truststore_nss.go"
] | [] | true | |
FiloSottile/mkcert | 40 | issue_to_patch | Use $XDG_DATA_HOME on macOS if it is set. | I was a little surprised to see `mkcert` use `~/Library/Application Support` instead of `$XDG_DATA_HOME` until I looked at the code and see it was intentional choice.
I personally think it would be good to follow the XDG spec fully and default to `~/.local/share` on macOS – rather than introducing custom behaviour ... | 779fa98126dfaf67c72c49ec8dcc9747e79d81f3 | 92338fcc365f85045045b18ff58a7b5c373f921c | diff --git a/main.go b/main.go
index 25c7471c..787cc247 100644
--- a/main.go
+++ b/main.go
@@ -140,6 +140,8 @@ func getCAROOT() string {
switch runtime.GOOS {
case "windows":
dir = os.Getenv("LocalAppData")
+ case env = os.Getenv("XDG_DATA_HOME"); env != "":
+ dir = env
case "darwin":
dir = os.Getenv("HOME... | [
"main.go"
] | [
{
"comment": "Just realized that this needs to return and empty string from the calling function, too.\r\n\r\nHow would you feel about introducing an error return value instead of using the empty string as a sentinel?",
"path": "main.go",
"hunk": "@@ -131,32 +131,30 @@ print it with \"mkcert -CAROOT\".\... | true | ||
FiloSottile/mkcert | 32 | issue_to_patch | readme: update homebrew install | This was added to Homebrew in https://github.com/Homebrew/homebrew-core/pull/29733 | 54cdb2c7154b97e6e477578a5f08a695822f4fcb | 1f51b9f4242ffb53f4760501b62e95742b2fb1bf | diff --git a/README.md b/README.md
index 8f21b353..58c54e46 100644
--- a/README.md
+++ b/README.md
@@ -33,7 +33,7 @@ mkcert automatically creates and installs a local CA in the system root store, a
On macOS, use Homebrew.
```
-brew install --HEAD https://github.com/FiloSottile/mkcert/raw/master/HomebrewFormula/mkce... | [
"README.md"
] | [] | true | ||
FiloSottile/mkcert | 2 | issue_to_patch | Add Linux support for update-ca-trust and update-ca-certificates (RHEL, CentOS, Fedora, Debian, Ubuntu...) | Hmm, are there any better tools than "tee" to install files using sudo? :) | ce545753083773547cbbe9088400573a2782da1c | 1807c91e2703f93ff76fd3b0a9d8906972cc4636 | diff --git a/truststore_linux.go b/truststore_linux.go
index 43f54c9d..d2c092f6 100644
--- a/truststore_linux.go
+++ b/truststore_linux.go
@@ -5,9 +5,13 @@
package main
import (
+ "bytes"
+ "io/ioutil"
"log"
"os"
+ "os/exec"
"path/filepath"
+ "strings"
)
var (
@@ -15,11 +19,54 @@ var (
FirefoxProfile ... | [
"truststore_linux.go"
] | [] | true | ||
FiloSottile/mkcert | 27 | issue_to_patch | docs: add CA definition as certificate authorities to help other user… | …s understand the documentation and removed some redundant text for readability | e9ef9b378716610f995bdcb036496a15fb1a1181 | 86ebd242463ce8c2e4c740eb565ce47023048dbc | diff --git a/README.md b/README.md
index 3a92d467..6a04da86 100644
--- a/README.md
+++ b/README.md
@@ -24,7 +24,7 @@ The certificate is at "./example.com+5.pem" and the key at "./example.com+5-key.
<p align="center"><img width="444" alt="Chrome screenshot" src="https://user-images.githubusercontent.com/1225294/41887... | [
"README.md"
] | [] | true | ||
Fission-AI/OpenSpec | 1,166 | issue_to_patch | chore(release): version packages | This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ... | 0a01146c181a3af8dbf645547bcbe20c0d48d615 | e152be163d18925b10cb870f596e985a75599835 | diff --git a/.changeset/fuzzy-dagster-workspaces.md b/.changeset/fuzzy-dagster-workspaces.md
deleted file mode 100644
index 9624e6ccb..000000000
--- a/.changeset/fuzzy-dagster-workspaces.md
+++ /dev/null
@@ -1,5 +0,0 @@
----
-"@fission-ai/openspec": patch
----
-
-Move beta workspace view state to `.openspec-workspace/v... | [
".changeset/fuzzy-dagster-workspaces.md",
"CHANGELOG.md",
"package.json"
] | [] | true | ||
Fission-AI/OpenSpec | 1,165 | issue_to_patch | openspec update crashes when a non-OpenSpec workspace.yaml exists in the project root (filename collision with Dagster)
### Summary
`openspec update` walks up from the cwd looking for a file literally named `workspace.yaml` to detect a managed workspace. If it finds *any* `workspace.yaml` — even one belonging to a co... | [codex] Fix workspace.yaml collision detection | ## Summary
Fixes #1164.
This moves beta workspace view state out of the repository root and into OpenSpec-owned metadata. A project-level `workspace.yaml` is now always ignored by workspace discovery, so Dagster's required `workspace.yaml` no longer redirects `openspec update` into the beta workspace update path.
It... | bc7ab26650a43384ad525de42a7f58eaa13846f5 | 771964d938bafbf7c35c14ae8e4c36ae42978626 | diff --git a/.changeset/fuzzy-dagster-workspaces.md b/.changeset/fuzzy-dagster-workspaces.md
new file mode 100644
index 000000000..9624e6ccb
--- /dev/null
+++ b/.changeset/fuzzy-dagster-workspaces.md
@@ -0,0 +1,5 @@
+---
+"@fission-ai/openspec": patch
+---
+
+Move beta workspace view state to `.openspec-workspace/view.... | [
".changeset/fuzzy-dagster-workspaces.md",
"docs/cli.md",
"docs/concepts.md",
"docs/workspaces-beta/user-guide.md",
"openspec/specs/cli-update/spec.md",
"openspec/specs/workspace-foundation/spec.md",
"src/cli/index.ts",
"src/commands/workspace.ts",
"src/commands/workspace/context-status.ts",
"src/c... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# 1) Any code still reading a root-level workspace.yaml (outside .openspec-workspace/)?\nrg -nP -C3 \"workspace\\.yaml\" --type=ts -g '!**/*.test... | diff --git a/openspec/specs/cli-update/spec.md b/openspec/specs/cli-update/spec.md
index 6e848751a..34e32c91f 100644
--- a/openspec/specs/cli-update/spec.md
+++ b/openspec/specs/cli-update/spec.md
@@ -166,7 +166,7 @@ The archive slash command template SHALL support optional change ID arguments fo
- **AND** wrap it in ... | true |
Fission-AI/OpenSpec | 1,165 | comment_to_fix | [codex] Fix workspace.yaml collision detection | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Don't block repo-local projects solely because they sit under a workspace root.**
This guard fires before `UpdateCommand.execute(...)`, so `openspec update <path>` now fails for any real repo-local OpenSpec project nested under a workspace tree. That contradicts the... | bc7ab26650a43384ad525de42a7f58eaa13846f5 | 771964d938bafbf7c35c14ae8e4c36ae42978626 | diff --git a/src/cli/index.ts b/src/cli/index.ts
index d06fdddc5..0c42f43cb 100644
--- a/src/cli/index.ts
+++ b/src/cli/index.ts
@@ -4,7 +4,7 @@ import ora from 'ora';
import path from 'path';
import { fileURLToPath } from 'url';
import { promises as fs } from 'fs';
-import { AI_TOOLS } from '../core/config.js';
+im... | [
"src/cli/index.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Don't block repo-local projects solely because they sit under a workspace root.**\n\nThis guard fires before `UpdateCommand.execute(...)`, so `openspec update <path>` now fails for any real repo-local OpenSpec project nested under a workspace ... | true | ||
Fission-AI/OpenSpec | 1,165 | comment_to_fix | [codex] Fix workspace.yaml collision detection | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Narrow the catch to only “not found” cases.**
Catching all errors here can hide real filesystem failures (like permission errors) and misroute users into workspace guidance. Only return `false` for missing-path cases; rethrow everything else.
<details>
<summary... | bc7ab26650a43384ad525de42a7f58eaa13846f5 | 771964d938bafbf7c35c14ae8e4c36ae42978626 | diff --git a/src/cli/index.ts b/src/cli/index.ts
index d06fdddc5..0c42f43cb 100644
--- a/src/cli/index.ts
+++ b/src/cli/index.ts
@@ -4,7 +4,7 @@ import ora from 'ora';
import path from 'path';
import { fileURLToPath } from 'url';
import { promises as fs } from 'fs';
-import { AI_TOOLS } from '../core/config.js';
+im... | [
"src/cli/index.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Narrow the catch to only “not found” cases.**\n\nCatching all errors here can hide real filesystem failures (like permission errors) and misroute users into workspace guidance. Only return `false` for missing-path cases; rethrow everything els... | true | ||
Fission-AI/OpenSpec | 1,023 | issue_to_patch | chore(release): version packages | This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ... | aa16080d16b70f7b26cebd465334b2e16c0e7a43 | 1bc2d2d3dd4d5de047e387cabe037217be5d3b64 | diff --git a/.changeset/canonical-workspace-paths.md b/.changeset/canonical-workspace-paths.md
deleted file mode 100644
index ed2778e5d..000000000
--- a/.changeset/canonical-workspace-paths.md
+++ /dev/null
@@ -1,7 +0,0 @@
----
-"@fission-ai/openspec": patch
----
-
-### Fixed
-
-- Preserve workspace planning detection ... | [
".changeset/canonical-workspace-paths.md",
".changeset/clarify-bun-node-runtime.md",
".changeset/kind-rings-notice.md",
".changeset/mistral-vibe-and-fixes.md",
".changeset/neat-cameras-press.md",
".changeset/sync-default-core.md",
"CHANGELOG.md",
"package.json"
] | [] | true | ||
Fission-AI/OpenSpec | 1,154 | issue_to_patch | chore: add changeset for Mistral Vibe support and validator/completion fixes | ## Summary
Adds dedicated release tracking (a `minor` changeset) for user-facing changes merged to `main` since `v1.3.1` that weren't yet covered by an existing changeset.
## Changes in this release
### New Features
- **Mistral Vibe support** (#1144) — New skills-only AI tool initialized via `.vibe/skills/`
### Bug... | 055957fbcaea3f2695fdf9c350709dfc78047bde | 2d658345b12e9e45ac1c0c147b621412992c6b6e | diff --git a/.changeset/mistral-vibe-and-fixes.md b/.changeset/mistral-vibe-and-fixes.md
new file mode 100644
index 000000000..39f77daa0
--- /dev/null
+++ b/.changeset/mistral-vibe-and-fixes.md
@@ -0,0 +1,16 @@
+---
+"@fission-ai/openspec": minor
+---
+
+### New Features
+
+- **Mistral Vibe support** — OpenSpec can now... | [
".changeset/mistral-vibe-and-fixes.md"
] | [] | true | ||
Fission-AI/OpenSpec | 1,148 | issue_to_patch | [codex] clarify changeset release tracking | ## Summary
- Reframe changeset guidance around the normal release cadence by default and dedicated release tracking when maintainers want it.
- Update the PR changeset job to determine release tracking first and run Changesets validation only when a PR adds or updates changeset files.
- Keep the no-changeset CI path p... | 9e78bcaa802638205eee4a519e5f10009bf46732 | e46c6599862172826a19fec218df08ff8a55815a | diff --git a/.changeset/README.md b/.changeset/README.md
index 2511ccacb..dffd5644e 100644
--- a/.changeset/README.md
+++ b/.changeset/README.md
@@ -12,11 +12,12 @@ Follow the prompts to select version bump type and describe your changes.
## Workflow
-1. **Add a changeset** — Run `pnpm changeset` locally before or... | [
".changeset/README.md",
".github/workflows/ci.yml"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check branch protection rules for the main branch\n\ngh api repos/{owner}/{repo}/branches/main/protection \\\n --jq '.required_st... | true | ||
Fission-AI/OpenSpec | 1,116 | issue_to_patch | [codex] Document cross-platform path assertions | ## Summary
- Add test guidance that calls out Unix-only path separator assumptions in CLI output assertions.
- Tell contributors to use platform-aware path helpers or normalize display output before comparing.
- Add a patch changeset for the docs update.
## Validation
- `pnpm exec changeset status --since=origin/mai... | 7fdb1771585b1688597d73dde5a8bc906084d0de | b1f610975a85502759d8f095d59dc47eb9746e40 | [
"test/AGENTS.md"
] | [] | diff --git a/test/AGENTS.md b/test/AGENTS.md
index b608106f0..616158382 100644
--- a/test/AGENTS.md
+++ b/test/AGENTS.md
@@ -9,6 +9,13 @@ Applies to tests under `test/`.
- Full suite: `pnpm test`
- Run `pnpm run build` before focused CLI tests when implementation changes may leave `dist/` stale.
+## Cross-Platform ... | true | ||
Fission-AI/OpenSpec | 1,144 | issue_to_patch | [codex] Add Mistral Vibe support with CI fix | ## Summary
- Carries forward #1125 from @tbetous with the Mistral Vibe tool config, docs, and regression coverage.
- Adds one CI fix so the workspace update help assertion tolerates wrapped output after `vibe` is added to `--tools`.
## Validation
- `pnpm exec vitest run test/commands/workspace.test.ts test/core/avai... | 9aded17af760ad2015ed3e91ce3b93bec9f3adfc | 2b72b0249729bf129979dbe90b5addf367143554 | diff --git a/docs/supported-tools.md b/docs/supported-tools.md
index 85d8e63d8..b2ee30fb4 100644
--- a/docs/supported-tools.md
+++ b/docs/supported-tools.md
@@ -44,6 +44,7 @@ You can enable expanded workflows (`new`, `continue`, `ff`, `verify`, `bulk-arch
| Kimi CLI (`kimi`) | `.kimi/skills/openspec-*/SKILL.md` | Not ... | [
"docs/supported-tools.md",
"src/core/config.ts",
"test/commands/workspace.test.ts",
"test/core/available-tools.test.ts"
] | [] | diff --git a/test/commands/workspace.test.ts b/test/commands/workspace.test.ts
index f1210a011..7e3bffeab 100644
--- a/test/commands/workspace.test.ts
+++ b/test/commands/workspace.test.ts
@@ -1638,7 +1638,7 @@ preferred_opener:
expect(updateHelp.stdout).toContain('guidance and agent skills');
expect(updateHe... | true | |
Fission-AI/OpenSpec | 1,135 | issue_to_patch | [BUGFIX] SHALL/MUST should be in body not in the requirement title
bug:
✗ [ERROR] agent-management/spec.md: MODIFIED "系统 SHALL 支持为 Box 智能体配置 Prompt Caching 开关" must contain SHALL or MUST
my spec:
```
## MODIFIED Requirements
### Requirement: 系统 SHALL 支持为 Box 智能体配置 Prompt Caching 开关
HOW TO DO ? NO CMD(S H A L L /... | fix(validator): hint when SHALL/MUST appears only in requirement header | ## Summary
Fixes #356.
When a change delta contains a requirement whose body is missing `SHALL`/`MUST` **but whose header (the text after `### Requirement:`) already contains the keyword**, the validator currently emits the generic error:
```
✗ [ERROR] agent-management/spec.md: MODIFIED "系统 SHALL 支持为 Box 智能体配置 Promp... | 0c5f0c6c48dce8cdcb85c1c50089c2d1c7921209 | 0b759408f9f371ae036f8492cad2927472187d37 | diff --git a/src/core/validation/validator.ts b/src/core/validation/validator.ts
index 37b43a37d..47071ed47 100644
--- a/src/core/validation/validator.ts
+++ b/src/core/validation/validator.ts
@@ -165,7 +165,7 @@ export class Validator {
if (!requirementText) {
issues.push({ level: 'ERROR', path... | [
"src/core/validation/validator.ts",
"test/core/validation.test.ts"
] | [] | diff --git a/test/core/validation.test.ts b/test/core/validation.test.ts
index 972815e51..72ebc2aba 100644
--- a/test/core/validation.test.ts
+++ b/test/core/validation.test.ts
@@ -535,6 +535,92 @@ The system will log all events.
expect(report.issues.some(i => i.message.includes('must contain SHALL or MUST'))).t... | true |
Fission-AI/OpenSpec | 1,137 | issue_to_patch | Improve context-store setup and cleanup UX | ## Summary
- add guided interactive `context-store setup` with explicit non-interactive/JSON validation
- add path safety checks for setup inside existing Git repositories
- add `context-store unregister` and `context-store remove` cleanup flows with docs, completions, and tests
## Verification
- `pnpm build`
- `pnpm ... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/docs/cli.md b/docs/cli.md
index 06c64f402..9e85c5aa7 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -8,7 +8,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali
|----------|----------|---------|
| **Setup** | `init`, `update` | Initialize and update OpenSpec in your projec... | [
"docs/cli.md",
"docs/workspaces-beta/agent-cli-playbook.md",
"docs/workspaces-beta/user-guide.md",
"openspec/initiatives/context-store-and-initiatives/tasks.md",
"openspec/initiatives/context-store-and-initiatives/work-items/12-context-store-first-run-and-cleanup-ux/evidence.md",
"openspec/initiatives/con... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Keep the Agent-Compatible table in sync with newly added context-store commands.**\n\nNow that `context-store unregister` and `context-store remove` are introduced in the summary, the “Agent-Compatible Commands” matrix should also include them... | diff --git a/test/commands/context-store.test.ts b/test/commands/context-store.test.ts
index 7cbf9123f..6f7ae926e 100644
--- a/test/commands/context-store.test.ts
+++ b/test/commands/context-store.test.ts
@@ -1,5 +1,6 @@
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { Command } from... | true | |
Fission-AI/OpenSpec | 1,137 | comment_to_fix | Improve context-store setup and cleanup UX | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Keep the Agent-Compatible table in sync with newly added context-store commands.**
Now that `context-store unregister` and `context-store remove` are introduced in the summary, the “Agent-Compatible Commands” matrix should also include them (with `--json`, and `remo... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/docs/cli.md b/docs/cli.md
index 06c64f402..9e85c5aa7 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -8,7 +8,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali
|----------|----------|---------|
| **Setup** | `init`, `update` | Initialize and update OpenSpec in your projec... | [
"docs/cli.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Keep the Agent-Compatible table in sync with newly added context-store commands.**\n\nNow that `context-store unregister` and `context-store remove` are introduced in the summary, the “Agent-Compatible Commands” matrix should also include them... | true | ||
Fission-AI/OpenSpec | 1,137 | comment_to_fix | Improve context-store setup and cleanup UX | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Nested-repo detection currently fails open when `git` cannot be invoked.**
Any error from `git rev-parse` returns `null`, so a machine without Git installed—or even a transient exec failure—silently skips the new safety check and allows setup inside an existing repo... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/src/core/context-store/operations.ts b/src/core/context-store/operations.ts
index ce49f44d1..c61a3e07e 100644
--- a/src/core/context-store/operations.ts
+++ b/src/core/context-store/operations.ts
@@ -1,5 +1,6 @@
import { execFile } from 'node:child_process';
import * as nodeFs from 'node:fs';
+import * a... | [
"src/core/context-store/operations.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Nested-repo detection currently fails open when `git` cannot be invoked.**\n\nAny error from `git rev-parse` returns `null`, so a machine without Git installed—or even a transient exec failure—silently skips the new safety check and allows set... | true | ||
Fission-AI/OpenSpec | 1,137 | comment_to_fix | Improve context-store setup and cleanup UX | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**`removeContextStore()` still has a delete-before-unregister race.**
`getRegisteredContextStore()` verifies `expectedBackend` before `fs.rm()`, but the registry mutation happens afterwards. If another process rewrites the same id in that gap, this path deletes `ta... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/src/core/context-store/operations.ts b/src/core/context-store/operations.ts
index ce49f44d1..c61a3e07e 100644
--- a/src/core/context-store/operations.ts
+++ b/src/core/context-store/operations.ts
@@ -1,5 +1,6 @@
import { execFile } from 'node:child_process';
import * as nodeFs from 'node:fs';
+import * a... | [
"src/core/context-store/operations.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**`removeContextStore()` still has a delete-before-unregister race.**\n\n`getRegisteredContextStore()` verifies `expectedBackend` before `fs.rm()`, but the registry mutation happens afterwards. If another process rewrites the same id in that ... | true | ||
Fission-AI/OpenSpec | 1,137 | comment_to_fix | Improve context-store setup and cleanup UX | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Normalize `local_path` before backend equality checks.**
This compares `local_path` as a raw string, so the same directory can look “changed” after a symlink/casing/path-spelling rewrite and block `unregister`/`remove` with `context_store_registry_changed`. Using th... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/src/core/context-store/registry.ts b/src/core/context-store/registry.ts
index b3629e958..0544c37f8 100644
--- a/src/core/context-store/registry.ts
+++ b/src/core/context-store/registry.ts
@@ -31,6 +31,16 @@ export interface ResolveRegisteredContextStoreInput extends ContextStorePathOpti
id: string;
}
... | [
"src/core/context-store/registry.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Normalize `local_path` before backend equality checks.**\n\nThis compares `local_path` as a raw string, so the same directory can look “changed” after a symlink/casing/path-spelling rewrite and block `unregister`/`remove` with `context_store_r... | true | ||
Fission-AI/OpenSpec | 1,137 | comment_to_fix | Improve context-store setup and cleanup UX | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Canonicalize the cleanup path assertions.**
These checks compare raw temp paths against registry/cleanup path identities, which can diverge on symlinked temp dirs. Reuse `expectedExistingPath(storeRoot)` here, and in the successful remove case capture that canonical... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/test/commands/context-store.test.ts b/test/commands/context-store.test.ts
index 7cbf9123f..6f7ae926e 100644
--- a/test/commands/context-store.test.ts
+++ b/test/commands/context-store.test.ts
@@ -1,5 +1,6 @@
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { Command } from... | [
"test/commands/context-store.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Canonicalize the cleanup path assertions.**\n\nThese checks compare raw temp paths against registry/cleanup path identities, which can diverge on symlinked temp dirs. Reuse `expectedExistingPath(storeRoot)` here, and in the successful remove c... | true | ||
Fission-AI/OpenSpec | 1,137 | comment_to_fix | Improve context-store setup and cleanup UX | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Canonicalize the `storeRoot` identity assertion.**
This currently asserts raw path spelling instead of filesystem identity. Use canonical path comparison for `storeRoot` (as done elsewhere in this file).
<details>
<summary>Suggested fix</summary>
```diff
- a... | 21c1805d80592bce991ddd6c99165c4410e3fa0b | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | diff --git a/test/core/context-store/registry.test.ts b/test/core/context-store/registry.test.ts
index 2122a584b..533fcb453 100644
--- a/test/core/context-store/registry.test.ts
+++ b/test/core/context-store/registry.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import ... | [
"test/core/context-store/registry.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Canonicalize the `storeRoot` identity assertion.**\n\nThis currently asserts raw path spelling instead of filesystem identity. Use canonical path comparison for `storeRoot` (as done elsewhere in this file).\n\n \n\n<details>\n<summary>Suggeste... | true | ||
Fission-AI/OpenSpec | 1,136 | issue_to_patch | [codex] Polish beta context workspace flow | ## Summary
- Move context-store setup defaults into managed local storage and document the beta first-run path.
- Make `workspace open` initiative-aware, including lazy workspace creation, linked repo prompts, clearer opener behavior, and Codex CLI sandbox handling.
- Clean up generated workspace shape so workspaces a... | 11b269061897b011075a984c6c95d970a5533a66 | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 | diff --git a/docs/cli.md b/docs/cli.md
index 73c1b0740..06c64f402 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -194,7 +194,7 @@ openspec workspace setup [options]
| `--name <name>` | Workspace name. Names must be kebab-case |
| `--link <path>` | Link an existing repo or folder and infer the link name from the folder... | [
"docs/cli.md",
"docs/concepts.md",
"docs/workspaces-beta/agent-cli-playbook.md",
"docs/workspaces-beta/user-guide.md",
"openspec/initiatives/context-store-and-initiatives/roadmap.md",
"openspec/initiatives/context-store-and-initiatives/tasks.md",
"openspec/initiatives/context-store-and-initiatives/work-... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Honor `--json` by suppressing setup-link prompts.**\n\nLine 288 can still enable interactive setup-link prompting in JSON mode, which can block automation expecting machine output. Add a JSON-mode guard to `interactiveCreate`.\n\n \n\n<details... | diff --git a/openspec/specs/workspace-foundation/spec.md b/openspec/specs/workspace-foundation/spec.md
index f4e38db9e..e6ef3658c 100644
--- a/openspec/specs/workspace-foundation/spec.md
+++ b/openspec/specs/workspace-foundation/spec.md
@@ -76,10 +76,10 @@ OpenSpec SHALL keep shared workspace information separate from ... | true | |
Fission-AI/OpenSpec | 1,136 | comment_to_fix | [codex] Polish beta context workspace flow | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Honor `--json` by suppressing setup-link prompts.**
Line 288 can still enable interactive setup-link prompting in JSON mode, which can block automation expecting machine output. Add a JSON-mode guard to `interactiveCreate`.
<details>
<summary>Suggested fix</summ... | 11b269061897b011075a984c6c95d970a5533a66 | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 | diff --git a/src/commands/workspace/open-view.ts b/src/commands/workspace/open-view.ts
index e6c784c15..628677178 100644
--- a/src/commands/workspace/open-view.ts
+++ b/src/commands/workspace/open-view.ts
@@ -20,6 +20,7 @@ import {
getWorkspaceContextInitiativeId,
getWorkspaceOpenerLabel,
} from '../../core/work... | [
"src/commands/workspace/open-view.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Honor `--json` by suppressing setup-link prompts.**\n\nLine 288 can still enable interactive setup-link prompting in JSON mode, which can block automation expecting machine output. Add a JSON-mode guard to `interactiveCreate`.\n\n \n\n<details... | true | ||
Fission-AI/OpenSpec | 1,136 | comment_to_fix | [codex] Polish beta context workspace flow | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Preserve intentional user `.gitignore` entries when cleaning legacy patterns.**
The current cleanup removes any matching filename line, including user-authored ignore rules. That silently mutates user config every time `workspace open` syncs.
<details>
<summary>S... | 11b269061897b011075a984c6c95d970a5533a66 | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 | diff --git a/src/core/workspace/open-surface.ts b/src/core/workspace/open-surface.ts
index 0ba6bec8e..b77a79443 100644
--- a/src/core/workspace/open-surface.ts
+++ b/src/core/workspace/open-surface.ts
@@ -6,13 +6,15 @@ import {
WorkspaceViewState,
getWorkspaceContextInitiativeId,
getWorkspaceCodeWorkspacePath,... | [
"src/core/workspace/open-surface.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Preserve intentional user `.gitignore` entries when cleaning legacy patterns.**\n\nThe current cleanup removes any matching filename line, including user-authored ignore rules. That silently mutates user config every time `workspace open` sync... | true | ||
Fission-AI/OpenSpec | 1,134 | issue_to_patch | Fix Windows workspace open CI timeout | ## Summary
- validate workspace opener override conflicts before workspace target selection
- split the Windows-sensitive workspace open error-path test into smaller focused cases
- add an empty changeset because this is CI/test stability only
## Verification
- pnpm run build
- pnpm exec vitest run test/commands/works... | fd92ccca74cf3fe503faba59d1d862c7a9cd3581 | 928e7069c27b6811062a7b0e3633c4ca3c3f4578 | diff --git a/src/commands/workspace/open-view.ts b/src/commands/workspace/open-view.ts
index 95e0cd9ef..e6c784c15 100644
--- a/src/commands/workspace/open-view.ts
+++ b/src/commands/workspace/open-view.ts
@@ -280,6 +280,7 @@ export async function prepareWorkspaceOpen(
assertWorkspaceOpenSupportedOptions(options);
... | [
"src/commands/workspace/open-view.ts",
"test/commands/workspace.test.ts"
] | [] | diff --git a/test/commands/workspace.test.ts b/test/commands/workspace.test.ts
index aa15f05b9..deb4fc03d 100644
--- a/test/commands/workspace.test.ts
+++ b/test/commands/workspace.test.ts
@@ -1477,7 +1477,7 @@ links:
});
});
- it('reports workspace open selection, unsupported flag, unset opener, and unavail... | true | |
Fission-AI/OpenSpec | 1,117 | issue_to_patch | [codex] Fix Windows workspace change path assertion | ## Summary
- Normalize the workspace change CLI output before asserting the created change path.
- Keep the assertion focused on the displayed location while allowing Windows backslashes.
- Add an empty changeset because this is test-only and has no release impact.
## Root cause
The previous fix removed the command ... | 7fdb1771585b1688597d73dde5a8bc906084d0de | ba87d48d3b6d34c9ddf69cd3f29b488dca21ac41 | diff --git a/.changeset/neat-cameras-press.md b/.changeset/neat-cameras-press.md
new file mode 100644
index 000000000..a845151cc
--- /dev/null
+++ b/.changeset/neat-cameras-press.md
@@ -0,0 +1,2 @@
+---
+---
| [
".changeset/neat-cameras-press.md",
"test/commands/artifact-workflow.test.ts"
] | [] | diff --git a/test/commands/artifact-workflow.test.ts b/test/commands/artifact-workflow.test.ts
index e5753535a..7fe58da8c 100644
--- a/test/commands/artifact-workflow.test.ts
+++ b/test/commands/artifact-workflow.test.ts
@@ -384,7 +384,7 @@ describe('artifact-workflow CLI commands', () => {
expect(create.exitCod... | true | |
Fission-AI/OpenSpec | 1,111 | issue_to_patch | [codex] Fix Windows workspace path CI failure | ## Summary
Fix the Windows-only main CI failure in the `CI` workflow by keeping workspace planning-home path comparisons in canonical path space.
## Root cause
The failing `main` run was `CI` run `26182487591` on commit `79303b5`. Linux, macOS, lint, CodeQL, and release-prepare passed; the Windows PowerShell test le... | 79303b521068c5f525ee61db06b915fc44b098f4 | 63c15fa4050e37d9c47d270b7630ee812c624137 | diff --git a/.changeset/canonical-workspace-paths.md b/.changeset/canonical-workspace-paths.md
new file mode 100644
index 000000000..ed2778e5d
--- /dev/null
+++ b/.changeset/canonical-workspace-paths.md
@@ -0,0 +1,7 @@
+---
+"@fission-ai/openspec": patch
+---
+
+### Fixed
+
+- Preserve workspace planning detection when... | [
".changeset/canonical-workspace-paths.md",
"src/commands/config.ts",
"src/core/planning-home.ts",
"test/AGENTS.md",
"test/core/planning-home.test.ts"
] | [] | diff --git a/test/AGENTS.md b/test/AGENTS.md
new file mode 100644
index 000000000..b608106f0
--- /dev/null
+++ b/test/AGENTS.md
@@ -0,0 +1,23 @@
+# OpenSpec Test Guidance
+
+Applies to tests under `test/`.
+
+## Running Tests
+
+- Focused file: `pnpm exec vitest run test/path/to/file.test.ts`
+- Focused case: `pnpm exe... | true | |
Fission-AI/OpenSpec | 1,107 | issue_to_patch | [codex] Update recommended high-reasoning models | ## Summary
- Update the README's high-reasoning model recommendation from Opus 4.5 and GPT 5.2 to Codex 5.5 and Opus 4.7.
## Impact
- Keeps the contributor guidance aligned with the current preferred planning and implementation models.
- No runtime behavior changes.
## Validation
- `git diff --check`
<!-- This is... | 8498042fe8a738e8ad6facd94a5fc7f5025bf81d | 3dc1e188cd6bfcae1239777be1d7f90b09ec48e1 | diff --git a/README.md b/README.md
index b01bfbd4d..dcf6586b4 100644
--- a/README.md
+++ b/README.md
@@ -157,7 +157,7 @@ openspec update
## Usage Notes
-**Model selection**: OpenSpec works best with high-reasoning models. We recommend Opus 4.5 and GPT 5.2 for both planning and implementation.
+**Model selection**:... | [
"README.md"
] | [] | true | ||
Fission-AI/OpenSpec | 1,089 | issue_to_patch | [codex] Add workspace change planning workflow | ## Summary
- Adds workspace change planning schema/templates and planning-home support so workspace-scoped changes can capture proposal, design, tasks, specs, and related context.
- Updates workspace setup/update flows to install and refresh OpenSpec workflow skills from workspace-local configuration and selected phas... | 053d8a59d587f3c027a06ad80503a6b43d4f2a92 | 829ef46c341a773c52259cd73f2881681ac7e391 | diff --git a/WORKSPACE_REIMPLEMENTATION_START_HERE.md b/WORKSPACE_REIMPLEMENTATION_START_HERE.md
index b0066504f..6f3c8f7e3 100644
--- a/WORKSPACE_REIMPLEMENTATION_START_HERE.md
+++ b/WORKSPACE_REIMPLEMENTATION_START_HERE.md
@@ -39,8 +39,9 @@ Implement these flat OpenSpec changes in order:
2. `workspace-create-and-reg... | [
"WORKSPACE_REIMPLEMENTATION_START_HERE.md",
"docs/cli.md",
"docs/concepts.md",
"openspec/changes/archive/2026-05-14-workspace-change-planning/design.md",
"openspec/changes/archive/2026-05-14-workspace-change-planning/proposal.md",
"openspec/changes/archive/2026-05-14-workspace-change-planning/specs/artifa... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Fix XSS vulnerability in textarea content.**\n\nLine 741 uses `.replace(/\"/g, '"')` within a template literal assigned to `innerHTML`, which is insufficient protection. If `s.userComment` contains `</textarea>` or other HTML special char... | diff --git a/openspec/changes/archive/2026-05-14-workspace-change-planning/specs/artifact-graph/spec.md b/openspec/changes/archive/2026-05-14-workspace-change-planning/specs/artifact-graph/spec.md
new file mode 100644
index 000000000..84b44f39d
--- /dev/null
+++ b/openspec/changes/archive/2026-05-14-workspace-change-pl... | true | |
Fission-AI/OpenSpec | 1,089 | comment_to_fix | [codex] Add workspace change planning workflow | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Propagate `--force` when redirecting to workspace update.**
Line 170 drops the parsed `--force` option by passing `{}`. That makes `openspec update --force` behave inconsistently inside a workspace.
<details>
<summary>Suggested fix</summary>
```diff
- awai... | 053d8a59d587f3c027a06ad80503a6b43d4f2a92 | 829ef46c341a773c52259cd73f2881681ac7e391 | diff --git a/src/cli/index.ts b/src/cli/index.ts
index f1278dbd7..baa3e48fa 100644
--- a/src/cli/index.ts
+++ b/src/cli/index.ts
@@ -16,7 +16,11 @@ import { CompletionCommand } from '../commands/completion.js';
import { FeedbackCommand } from '../commands/feedback.js';
import { registerConfigCommand } from '../comman... | [
"src/cli/index.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Propagate `--force` when redirecting to workspace update.**\n\nLine 170 drops the parsed `--force` option by passing `{}`. That makes `openspec update --force` behave inconsistently inside a workspace.\n \n<details>\n<summary>Suggested fix</su... | true | ||
Fission-AI/OpenSpec | 1,089 | comment_to_fix | [codex] Add workspace change planning workflow | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Clarify default-schema precedence to avoid contradictory behavior.**
Line 189 says workspace creation defaults to `workspace-planning` when `--schema` is omitted, but Line 95-103 says omitted `--schema` defaults from config. These two SHALLs conflict and can produce... | 053d8a59d587f3c027a06ad80503a6b43d4f2a92 | 829ef46c341a773c52259cd73f2881681ac7e391 | diff --git a/openspec/specs/schema-resolution/spec.md b/openspec/specs/schema-resolution/spec.md
index b8c0caace..f243252ad 100644
--- a/openspec/specs/schema-resolution/spec.md
+++ b/openspec/specs/schema-resolution/spec.md
@@ -2,7 +2,6 @@
## Purpose
Define project-local schema resolution behavior, including prece... | [
"openspec/specs/schema-resolution/spec.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Clarify default-schema precedence to avoid contradictory behavior.**\n\nLine 189 says workspace creation defaults to `workspace-planning` when `--schema` is omitted, but Line 95-103 says omitted `--schema` defaults from config. These two SHALL... | true | ||
Fission-AI/OpenSpec | 1,089 | comment_to_fix | [codex] Add workspace change planning workflow | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Specify the mechanism for identifying OpenSpec-managed directories.**
The spec requires removing "only known OpenSpec-managed workflow skill directories" while preserving unrelated files (lines 443, 450, 461-462), but never specifies *how* OpenSpec identifies which ... | 053d8a59d587f3c027a06ad80503a6b43d4f2a92 | 829ef46c341a773c52259cd73f2881681ac7e391 | diff --git a/openspec/specs/workspace-links/spec.md b/openspec/specs/workspace-links/spec.md
index f8abc488b..edbc2fea8 100644
--- a/openspec/specs/workspace-links/spec.md
+++ b/openspec/specs/workspace-links/spec.md
@@ -4,7 +4,6 @@
Define the direct workspace setup, discovery, linking, relinking, health check,
and J... | [
"openspec/specs/workspace-links/spec.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Specify the mechanism for identifying OpenSpec-managed directories.**\n\nThe spec requires removing \"only known OpenSpec-managed workflow skill directories\" while preserving unrelated files (lines 443, 450, 461-462), but never specifies *how... | true | ||
Fission-AI/OpenSpec | 1,059 | issue_to_patch | docs(migration-guide): fix inconsistent /opsx:sync description | ## Issue
The `/opsx:sync` command has inconsistent descriptions across three documentation files:
- `migration-guide.md`: "Preview/spec-merge without archiving"
- `commands.md`: "Merge delta specs into main specs"
- `workflows.md`: "Merge delta specs"
## Change
Unified the description to match `commands.md`: "M... | b642398bf3cb32c2d3fa4225ef2bd6c410afe226 | b59ca1c46d3dfe7f17d2f5bf4e42a65e053833df | diff --git a/docs/migration-guide.md b/docs/migration-guide.md
index fe7e93e3d..d6355740f 100644
--- a/docs/migration-guide.md
+++ b/docs/migration-guide.md
@@ -297,7 +297,7 @@ Command availability is profile-dependent:
| `/opsx:continue` | Create the next artifact (one at a time) |
| `/opsx:ff` | Fast-forward—create... | [
"docs/migration-guide.md"
] | [] | true | ||
Fission-AI/OpenSpec | 1,057 | issue_to_patch | [codex] Fix Windows workspace launch arg expectation | ## Summary
Fixes the remaining Windows `main` CI failure after #1056 by canonicalizing the launch argument expectations in the workspace open test.
## Root cause
The latest `main` CI run after #1056 still failed in `Test (windows-pwsh)` for workflow run `25416165547`. The earlier fix updated generated workspace file... | ff506c347a9d6025f13a4fc220407de232caee27 | 1fa9b00dd562008435d4345f39c406f3aece6c41 | [
"test/commands/workspace.test.ts"
] | [] | diff --git a/test/commands/workspace.test.ts b/test/commands/workspace.test.ts
index 25a5fc311..366c6f376 100644
--- a/test/commands/workspace.test.ts
+++ b/test/commands/workspace.test.ts
@@ -991,7 +991,7 @@ paths:
fs.realpathSync.native(setup.workspace.root)
);
expect(editorLaunch.args).toEqual([
- ... | true | ||
Fission-AI/OpenSpec | 1,056 | issue_to_patch | [codex] Fix Windows workspace CI tests | ## Summary
Fixes the failing main CI Windows test job by aligning the workspace tests with the intended Windows path behavior.
## Root cause
The latest `main` CI failure was in `Test (windows-pwsh)` for workflow run `25415627238`. The workspace implementation canonicalizes existing Windows paths before persisting or... | 1cdf0410dfa20b61bcdda3779fd25209e7cda795 | 2890afc4f8ab0cfe028d640ec9999f600b45be4c | [
"test/commands/workspace.interactive.test.ts",
"test/commands/workspace.test.ts"
] | [] | diff --git a/test/commands/workspace.interactive.test.ts b/test/commands/workspace.interactive.test.ts
index 5bf33eeff..1173f1ed8 100644
--- a/test/commands/workspace.interactive.test.ts
+++ b/test/commands/workspace.interactive.test.ts
@@ -342,7 +342,8 @@ describe('workspace command interactive flows', () => {
... | true | ||
Fission-AI/OpenSpec | 1,054 | issue_to_patch | [codex] Propose workspace open agent context | ## Summary
- Adds the `workspace-open-agent-context` OpenSpec proposal artifacts.
- Captures the `workspace-open` capability for opening a workspace through a preferred agent or VS Code editor.
- Extends workspace state and maintained open-surface requirements through the existing workspace capability area.
## Valida... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/docs/cli.md b/docs/cli.md
index a56bbb3b2..81753560a 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -7,7 +7,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali
| Category | Commands | Purpose |
|----------|----------|---------|
| **Setup** | `init`, `update` | Initialize... | [
"docs/cli.md",
"docs/concepts.md",
"openspec/changes/archive/2026-05-06-workspace-open-agent-context/design.md",
"openspec/changes/archive/2026-05-06-workspace-open-agent-context/proposal.md",
"openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-foundation/spec.md",
"openspec/... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Clarify non-interactive setup commands with explicit `--no-interactive`.**\n\nThese scenarios call the flow “non-interactive,” but the command examples omit `--no-interactive`. That creates a spec ambiguity against the rest of this change set ... | diff --git a/openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-foundation/spec.md b/openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-foundation/spec.md
new file mode 100644
index 000000000..3dfce2117
--- /dev/null
+++ b/openspec/changes/archive/2026-05-06-w... | true | |
Fission-AI/OpenSpec | 1,054 | comment_to_fix | [codex] Propose workspace open agent context | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Add an explicit conflict rule when `--agent` and `--editor` are both passed.**
The opener resolution section does not define precedence or failure for `openspec workspace open --agent <tool> --editor`. This is an ambiguity in command contract and should be specified... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-open/spec.md b/openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-open/spec.md
new file mode 100644
index 000000000..fc3e565aa
--- /dev/null
+++ b/openspec/changes/archive/2026-05-06-workspace-ope... | [
"openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-open/spec.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add an explicit conflict rule when `--agent` and `--editor` are both passed.**\n\nThe opener resolution section does not define precedence or failure for `openspec workspace open --agent <tool> --editor`. This is an ambiguity in command contra... | true | ||
Fission-AI/OpenSpec | 1,054 | comment_to_fix | [codex] Propose workspace open agent context | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Fail fast instead of prompting with unavailable openers.**
This interactive fallback can still offer openers that `listWorkspaceOpenerChoices()` already marked unavailable, and the command then fails a moment later in `assertWorkspaceOpenerAvailable()`. On machines ... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts
index 2afad3c05..6d2eafca7 100644
--- a/src/commands/workspace.ts
+++ b/src/commands/workspace.ts
@@ -3,7 +3,15 @@ import chalk from 'chalk';
import * as nodeFs from 'node:fs';
import * as path from 'node:path';
-import { listWorkspaceRegistryEntrie... | [
"src/commands/workspace.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Fail fast instead of prompting with unavailable openers.**\n\nThis interactive fallback can still offer openers that `listWorkspaceOpenerChoices()` already marked unavailable, and the command then fails a moment later in `assertWorkspaceOpener... | true | ||
Fission-AI/OpenSpec | 1,054 | comment_to_fix | [codex] Propose workspace open agent context | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Regenerate the maintained `.code-workspace` before editor-based open.**
This method recomputes `openLinks.links` and `skipped` from the current local paths, but editor/GitHub Copilot launches still open the existing `codeWorkspacePath` as-is. If a linked repo was de... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/src/commands/workspace/open.ts b/src/commands/workspace/open.ts
new file mode 100644
index 000000000..1745cfc78
--- /dev/null
+++ b/src/commands/workspace/open.ts
@@ -0,0 +1,176 @@
+import { spawn as nodeSpawn } from 'node:child_process';
+import { createRequire } from 'node:module';
+
+import {
+ Workspa... | [
"src/commands/workspace/open.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Regenerate the maintained `.code-workspace` before editor-based open.**\n\nThis method recomputes `openLinks.links` and `skipped` from the current local paths, but editor/GitHub Copilot launches still open the existing `codeWorkspacePath` as-i... | true | ||
Fission-AI/OpenSpec | 1,054 | comment_to_fix | [codex] Propose workspace open agent context | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
rg -n -C5 '\blaunchWorkspaceOpenCommand\b|\bspawn\s*\(|shell:|cmd\.exe|ComSpec|\.cmd' src/commands/workspace/open.ts
```
Repository: Fission-AI/OpenSpec
Length of output: ... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/test/commands/workspace-open.test.ts b/test/commands/workspace-open.test.ts
new file mode 100644
index 000000000..c28397db6
--- /dev/null
+++ b/test/commands/workspace-open.test.ts
@@ -0,0 +1,119 @@
+import { describe, expect, it } from 'vitest';
+
+import {
+ assertWorkspaceOpenerAvailable,
+ buildWorks... | [
"test/commands/workspace-open.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nrg -n -C5 '\\blaunchWorkspaceOpenCommand\\b|\\bspawn\\s*\\(|shell:|cmd\\.exe|ComSpec|\\.cmd' src/commands/workspace/open.ts\n```\n\nReposito... | true | ||
Fission-AI/OpenSpec | 1,054 | comment_to_fix | [codex] Propose workspace open agent context | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`node child_process spawn shell true arguments not quoted Windows behavior`
💡 Result:
When using Node.js child_process.spawn(command, args, { shell: true }) on Windows, the behavior for unquoted argument... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/src/commands/workspace/open.ts b/src/commands/workspace/open.ts
new file mode 100644
index 000000000..1745cfc78
--- /dev/null
+++ b/src/commands/workspace/open.ts
@@ -0,0 +1,176 @@
+import { spawn as nodeSpawn } from 'node:child_process';
+import { createRequire } from 'node:module';
+
+import {
+ Workspa... | [
"src/commands/workspace/open.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`node child_process spawn shell true arguments not quoted Windows behavior`\n\n💡 Result:\n\nWhen using Node.js child_process.spawn(command, args, { shell: true }) on Windows, t... | true | ||
Fission-AI/OpenSpec | 1,054 | comment_to_fix | [codex] Propose workspace open agent context | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Drop the synthetic name from the workspace root folder entry.**
The new workspace-foundation spec requires the coordination root to be emitted as `path: "."` without a synthetic display name, but this always writes `name: 'OpenSpec Workspace'`. That will make the ma... | d5c824d4cd806fc6461415585ad38e20d9bcad3a | 105aafd8a73e5645aba837512737d152430caa94 | diff --git a/src/core/workspace/open-surface.ts b/src/core/workspace/open-surface.ts
new file mode 100644
index 000000000..10dbf8148
--- /dev/null
+++ b/src/core/workspace/open-surface.ts
@@ -0,0 +1,212 @@
+import * as nodeFs from 'node:fs';
+import * as path from 'node:path';
+
+import { FileSystemUtils } from '../../... | [
"src/core/workspace/open-surface.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Drop the synthetic name from the workspace root folder entry.**\n\nThe new workspace-foundation spec requires the coordination root to be emitted as `path: \".\"` without a synthetic display name, but this always writes `name: 'OpenSpec Worksp... | true | ||
Fission-AI/OpenSpec | 1,052 | issue_to_patch | [codex] archive workspace create and register repos | ## Summary
Archives the completed `workspace-create-and-register-repos` OpenSpec change and syncs its delta specs into the main specs.
## Changes
- Moved `openspec/changes/workspace-create-and-register-repos/` to `openspec/changes/archive/2026-05-06-workspace-create-and-register-repos/`.
- Added the canonical `works... | f510581b6cbdc2ebeec79e9614839e781ef37e58 | 2793979c05e772aa6ce4c152c5e2e7d7581bc98f | diff --git a/openspec/changes/workspace-create-and-register-repos/design.md b/openspec/changes/archive/2026-05-06-workspace-create-and-register-repos/design.md
similarity index 100%
rename from openspec/changes/workspace-create-and-register-repos/design.md
rename to openspec/changes/archive/2026-05-06-workspace-create-... | [
"openspec/changes/archive/2026-05-06-workspace-create-and-register-repos/design.md",
"openspec/changes/archive/2026-05-06-workspace-create-and-register-repos/proposal.md",
"openspec/changes/archive/2026-05-06-workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md",
"openspec/changes/archive/2... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add explicit non-interactive invalid workspace-name failure behavior**\n\nLine 65–80 defines success and missing-input failures, but there is no explicit scenario for an invalid `--workspace` value in `--no-interactive` mode. Please add a fail... | diff --git a/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md b/openspec/changes/archive/2026-05-06-workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md
similarity index 100%
rename from openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-wo... | true | |
Fission-AI/OpenSpec | 1,055 | issue_to_patch | [codex] Fix Windows workspace path test expectations | ## Summary
Updates workspace-related tests to expect canonical existing paths where the runtime now canonicalizes Windows paths.
## Root Cause
The latest `main` CI failure is in `Test (windows-pwsh)`. The production change in #1050 intentionally canonicalizes existing Windows paths, so temporary paths like `C:\Users... | f510581b6cbdc2ebeec79e9614839e781ef37e58 | 94e91a075a85d4f21a5f10db69694ceb03f3fb77 | [
"test/commands/workspace.interactive.test.ts",
"test/commands/workspace.test.ts",
"test/core/workspace/foundation.test.ts"
] | [] | diff --git a/test/commands/workspace.interactive.test.ts b/test/commands/workspace.interactive.test.ts
index 5662c24ae..ed58d1bd2 100644
--- a/test/commands/workspace.interactive.test.ts
+++ b/test/commands/workspace.interactive.test.ts
@@ -88,6 +88,10 @@ describe('workspace command interactive flows', () => {
ret... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.