repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Fission-AI/OpenSpec | 1,050 | issue_to_patch | [codex] Fix Windows workspace path aliases | ## Summary
Fix Windows workspace path persistence so GitHub Actions and native Windows shells do not store 8.3 short-name aliases such as `C:\Users\RUNNER~1\...` in workspace local state or the workspace registry.
## Root Cause
Workspace link paths and detected workspace roots were resolved with `path.resolve(...)` ... | 7c3acccaf7d01006e3aac2194a2a1967e4d66984 | a45790253fc0e23c600af5e664211be100e90e7c | diff --git a/src/commands/workspace/operations.ts b/src/commands/workspace/operations.ts
index 8f58673a9..5c2c6d5a3 100644
--- a/src/commands/workspace/operations.ts
+++ b/src/commands/workspace/operations.ts
@@ -49,11 +49,13 @@ export async function readRegistry(): Promise<WorkspaceRegistryState> {
async function r... | [
"src/commands/workspace/operations.ts",
"src/commands/workspace/selection.ts",
"src/core/workspace/foundation.ts",
"test/commands/workspace.test.ts",
"test/core/workspace/foundation.test.ts"
] | [] | diff --git a/test/commands/workspace.test.ts b/test/commands/workspace.test.ts
index 83bab63f4..7e76bddd8 100644
--- a/test/commands/workspace.test.ts
+++ b/test/commands/workspace.test.ts
@@ -4,7 +4,10 @@ import * as os from 'node:os';
import * as path from 'node:path';
import { COMMAND_REGISTRY } from '../../src/... | true | |
Fission-AI/OpenSpec | 1,046 | issue_to_patch | [codex] Add workspace setup commands | ## Summary
- Adds the beta `openspec workspace` command surface for `setup`, `list`/`ls`, `link`, `relink`, and `doctor`.
- Records shared workspace identity/link names separately from machine-local paths, including JSON/status output for scriptable flows.
- Updates workspace docs, OpenSpec change artifacts, shell com... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/WORKSPACE_REIMPLEMENTATION_DIRECTION.md b/WORKSPACE_REIMPLEMENTATION_DIRECTION.md
index caad72c07..48762a4a9 100644
--- a/WORKSPACE_REIMPLEMENTATION_DIRECTION.md
+++ b/WORKSPACE_REIMPLEMENTATION_DIRECTION.md
@@ -9,10 +9,10 @@ This document captures the intended direction for reimplementing OpenSpec worksp
... | [
"WORKSPACE_REIMPLEMENTATION_DIRECTION.md",
"docs/cli.md",
"docs/concepts.md",
"openspec/changes/workspace-create-and-register-repos/design.md",
"openspec/changes/workspace-create-and-register-repos/proposal.md",
"openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md",
... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Don’t abort interactive setup on an invalid inferred link name.**\n\nIf the basename inferred from `resolvedPath` fails validation, this currently throws and ends setup instead of letting the user choose a replacement name. That makes folders ... | diff --git a/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md b/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md
index e969d2bc3..c2555ca00 100644
--- a/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.m... | true | |
Fission-AI/OpenSpec | 1,046 | comment_to_fix | [codex] Add workspace setup commands | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Don’t abort interactive setup on an invalid inferred link name.**
If the basename inferred from `resolvedPath` fails validation, this currently throws and ends setup instead of letting the user choose a replacement name. That makes folders with spaces, uppercase let... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts
new file mode 100644
index 000000000..2afad3c05
--- /dev/null
+++ b/src/commands/workspace.ts
@@ -0,0 +1,622 @@
+import { Command } from 'commander';
+import chalk from 'chalk';
+import * as nodeFs from 'node:fs';
+import * as path from 'node:path';
+
+... | [
"src/commands/workspace.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Don’t abort interactive setup on an invalid inferred link name.**\n\nIf the basename inferred from `resolvedPath` fails validation, this currently throws and ends setup instead of letting the user choose a replacement name. That makes folders ... | true | ||
Fission-AI/OpenSpec | 1,046 | comment_to_fix | [codex] Add workspace setup commands | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Keep listing links even when a workspace has warnings.**
The `continue` here suppresses the link list for any non-clean workspace, so `workspace list` stops showing the known repos/folders exactly when users need that context most. Keep the links visible and let the... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts
new file mode 100644
index 000000000..2afad3c05
--- /dev/null
+++ b/src/commands/workspace.ts
@@ -0,0 +1,622 @@
+import { Command } from 'commander';
+import chalk from 'chalk';
+import * as nodeFs from 'node:fs';
+import * as path from 'node:path';
+
+... | [
"src/commands/workspace.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Keep listing links even when a workspace has warnings.**\n\nThe `continue` here suppresses the link list for any non-clean workspace, so `workspace list` stops showing the known repos/folders exactly when users need that context most. Keep the... | true | ||
Fission-AI/OpenSpec | 1,046 | comment_to_fix | [codex] Add workspace setup commands | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**Make workspace creation rollback-safe.**
`createManagedWorkspace()` writes the workspace directory, shared state, local state, `.gitignore`, and registry entry in sequence. If anything fails after the root directory is created, the catch path rethrows but leaves ... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/src/commands/workspace/operations.ts b/src/commands/workspace/operations.ts
new file mode 100644
index 000000000..8f58673a9
--- /dev/null
+++ b/src/commands/workspace/operations.ts
@@ -0,0 +1,695 @@
+import * as nodeFs from 'node:fs';
+import * as path from 'node:path';
+
+import {
+ WorkspaceLocalState,
... | [
"src/commands/workspace/operations.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**Make workspace creation rollback-safe.**\n\n`createManagedWorkspace()` writes the workspace directory, shared state, local state, `.gitignore`, and registry entry in sequence. If anything fails after the root directory is created, the catch... | true | ||
Fission-AI/OpenSpec | 1,046 | comment_to_fix | [codex] Add workspace setup commands | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Model the documented `workspace link`/`relink` shape here.**
The registry currently exposes only a single `path` positional for these subcommands, but the CLI docs and tests allow an explicit link name before the path (`workspace link api-service /repos/api`). That ... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/src/core/completions/command-registry.ts b/src/core/completions/command-registry.ts
index 09c9ecc8d..cb0085bec 100644
--- a/src/core/completions/command-registry.ts
+++ b/src/core/completions/command-registry.ts
@@ -155,6 +155,106 @@ export const COMMAND_REGISTRY: CommandDefinition[] = [
},
],
... | [
"src/core/completions/command-registry.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Model the documented `workspace link`/`relink` shape here.**\n\nThe registry currently exposes only a single `path` positional for these subcommands, but the CLI docs and tests allow an explicit link name before the path (`workspace link api-s... | true | ||
Fission-AI/OpenSpec | 1,046 | comment_to_fix | [codex] Add workspace setup commands | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Add language tags to these fenced command blocks.**
markdownlint is flagging the new workspace examples because the fences are bare ``` blocks. Using `bash` here keeps the docs lint-clean and improves rendering in code-aware editors.
<details>
<summary>🧰 Tools</su... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/docs/cli.md b/docs/cli.md
index 35bb527cd..a56bbb3b2 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -7,6 +7,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali
| Category | Commands | Purpose |
|----------|----------|---------|
| **Setup** | `init`, `update` | Initialize... | [
"docs/cli.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add language tags to these fenced command blocks.**\n\nmarkdownlint is flagging the new workspace examples because the fences are bare ``` blocks. Using `bash` here keeps the docs lint-clean and improves rendering in code-aware editors.\n\n<de... | true | ||
Fission-AI/OpenSpec | 1,046 | comment_to_fix | [codex] Add workspace setup commands | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Print the planning path in successful `workspace setup` output.**
The setup success path currently reuses `printWorkspaceListHuman()`, which shows `Location:` and links but never surfaces `doctorResult.workspace.planning_path`. That misses the planning-path output c... | 435458be5658ec8774657acb197df7e84f0e7783 | 9ce951d17a429f0e8e811ce0ef7160b3dab3f32a | diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts
new file mode 100644
index 000000000..2afad3c05
--- /dev/null
+++ b/src/commands/workspace.ts
@@ -0,0 +1,622 @@
+import { Command } from 'commander';
+import chalk from 'chalk';
+import * as nodeFs from 'node:fs';
+import * as path from 'node:path';
+
+... | [
"src/commands/workspace.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Print the planning path in successful `workspace setup` output.**\n\nThe setup success path currently reuses `printWorkspaceListHuman()`, which shows `Location:` and links but never surfaces `doctorResult.workspace.planning_path`. That misses ... | true | ||
Fission-AI/OpenSpec | 1,045 | issue_to_patch | [codex] Archive workspace foundation | ## Summary
Archives the completed `workspace-foundation` OpenSpec change and promotes its delta specs into canonical specs.
## Changes
- Moved `openspec/changes/workspace-foundation` to `openspec/changes/archive/2026-05-04-workspace-foundation`
- Added the canonical `workspace-foundation` spec
- Added workspace prod... | 76c80f80f3be9e6baf47fe1dee5e1c6a85e23034 | 106f08665440a9fe9158c81ab05122194bff0b13 | diff --git a/openspec/changes/workspace-foundation/design.md b/openspec/changes/archive/2026-05-04-workspace-foundation/design.md
similarity index 100%
rename from openspec/changes/workspace-foundation/design.md
rename to openspec/changes/archive/2026-05-04-workspace-foundation/design.md
diff --git a/openspec/changes/w... | [
"openspec/changes/archive/2026-05-04-workspace-foundation/design.md",
"openspec/changes/archive/2026-05-04-workspace-foundation/proposal.md",
"openspec/changes/archive/2026-05-04-workspace-foundation/specs/openspec-conventions/spec.md",
"openspec/changes/archive/2026-05-04-workspace-foundation/specs/workspace... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Make the workspace-mode sentinel explicit.**\n\nLine 27 says “workspace identity file” but doesn’t name the exact file; this can lead to inconsistent detection behavior. Please pin this to a concrete path (for example, `.openspec-workspace/wor... | diff --git a/openspec/changes/workspace-foundation/specs/openspec-conventions/spec.md b/openspec/changes/archive/2026-05-04-workspace-foundation/specs/openspec-conventions/spec.md
similarity index 100%
rename from openspec/changes/workspace-foundation/specs/openspec-conventions/spec.md
rename to openspec/changes/archiv... | true | |
Fission-AI/OpenSpec | 1,043 | issue_to_patch | docs: add Community Schemas section + README entry | ## Summary
Adds a "Community Schemas" section to `docs/customization.md` listing community-maintained OpenSpec schemas distributed via standalone repositories. Modeled after [github/spec-kit's community extension catalog](https://github.com/github/spec-kit/tree/main/extensions).
Also adds a brief 4-line "Community sc... | 0ca74762dc03ee25f8651eaa7c33866170112031 | 180fbeb1e5d52778a2ad5b9e94eb1850435a8635 | diff --git a/README.md b/README.md
index 2ebb93333..b01bfbd4d 100644
--- a/README.md
+++ b/README.md
@@ -115,6 +115,13 @@ If you want the expanded workflow (`/opsx:new`, `/opsx:continue`, `/opsx:ff`, `/
→ **[Customization](docs/customization.md)**: make it yours
+## Community schemas
+
+Third-party schema bundles ... | [
"README.md",
"docs/customization.md"
] | [] | true | ||
Fission-AI/OpenSpec | 1,038 | issue_to_patch | [codex] Fix Windows workspace data dir paths | ## Summary
Fixes the Windows CI failure from the workspace foundation merge by making `getGlobalDataDir` honor the requested platform's path conventions when `platform`, `env`, or `homedir` overrides are passed.
## Root Cause
`getGlobalDataDir({ platform: 'linux', homedir: '/home/tabish' })` still used native `path.... | e6d81ba0f63bee346f89e8e0499e99be196a1cde | aa75d15a4d5d27120bbdc0488d2788129cc83d78 | diff --git a/src/core/global-config.ts b/src/core/global-config.ts
index 1f213c7cb..ad321ceb8 100644
--- a/src/core/global-config.ts
+++ b/src/core/global-config.ts
@@ -69,30 +69,36 @@ export interface GlobalDataDirOptions {
homedir?: string;
}
+function joinGlobalDataPath(platform: NodeJS.Platform, ...segments: ... | [
"src/core/global-config.ts",
"test/cli-e2e/basic.test.ts",
"test/core/global-config.test.ts"
] | [] | diff --git a/test/cli-e2e/basic.test.ts b/test/cli-e2e/basic.test.ts
index 0d7e46de0..22657513d 100644
--- a/test/cli-e2e/basic.test.ts
+++ b/test/cli-e2e/basic.test.ts
@@ -134,7 +134,9 @@ describe('openspec CLI e2e basics', () => {
const result = await runCLI(['init', '--tools', 'all'], {
cwd: emptyPro... | true | |
Fission-AI/OpenSpec | 1,029 | issue_to_patch | [codex] Complete workspace foundation and setup specs | ## Summary
- complete the `workspace-foundation` implementation with `.openspec-workspace` path helpers, workspace root detection, typed shared/local/registry state parsing, write helpers, and managed workspace location helpers
- document the coordination workspace model, stable link names, local-path separation, regis... | 347f0277e3be3549cd85cdea364fbd7710f1922b | 772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878 | diff --git a/docs/concepts.md b/docs/concepts.md
index b929a588a..4e3f21ae2 100644
--- a/docs/concepts.md
+++ b/docs/concepts.md
@@ -49,6 +49,92 @@ OpenSpec organizes your work into two main areas:
This separation is key. You can work on multiple changes in parallel without conflicts. You can review a change before ... | [
"docs/concepts.md",
"openspec/changes/workspace-create-and-register-repos/design.md",
"openspec/changes/workspace-create-and-register-repos/proposal.md",
"openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md",
"openspec/changes/workspace-create-and-register-repos/specs/wo... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Command name mismatch: use `doctor`, not `check`.**\n\nLine 8 conflicts with the rest of this change set (`setup/list/link/relink/doctor`). Keeping `check` here will create a conflicting normative contract.\n\n \n\n<details>\n<summary>Suggeste... | diff --git a/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md b/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md
new file mode 100644
index 000000000..e969d2bc3
--- /dev/null
+++ b/openspec/changes/workspace-create-and-register-repos/specs/... | true | |
Fission-AI/OpenSpec | 1,029 | comment_to_fix | [codex] Complete workspace foundation and setup specs | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Command name mismatch: use `doctor`, not `check`.**
Line 8 conflicts with the rest of this change set (`setup/list/link/relink/doctor`). Keeping `check` here will create a conflicting normative contract.
<details>
<summary>Suggested spec fix</summary>
```diff
-... | 347f0277e3be3549cd85cdea364fbd7710f1922b | 772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878 | diff --git a/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md b/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md
new file mode 100644
index 000000000..e969d2bc3
--- /dev/null
+++ b/openspec/changes/workspace-create-and-register-repos/specs/... | [
"openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Command name mismatch: use `doctor`, not `check`.**\n\nLine 8 conflicts with the rest of this change set (`setup/list/link/relink/doctor`). Keeping `check` here will create a conflicting normative contract.\n\n \n\n<details>\n<summary>Suggeste... | true | ||
Fission-AI/OpenSpec | 1,029 | comment_to_fix | [codex] Complete workspace foundation and setup specs | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Specify behavior when no workspaces are known for commands that require one workspace.**
The selection contract covers explicit, current, and ambiguous-multiple cases, but it does not define the zero-known-workspaces case. That leaves first-run behavior underspecifi... | 347f0277e3be3549cd85cdea364fbd7710f1922b | 772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878 | diff --git a/openspec/changes/workspace-create-and-register-repos/specs/workspace-links/spec.md b/openspec/changes/workspace-create-and-register-repos/specs/workspace-links/spec.md
new file mode 100644
index 000000000..e9507b9cf
--- /dev/null
+++ b/openspec/changes/workspace-create-and-register-repos/specs/workspace-li... | [
"openspec/changes/workspace-create-and-register-repos/specs/workspace-links/spec.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Specify behavior when no workspaces are known for commands that require one workspace.**\n\nThe selection contract covers explicit, current, and ambiguous-multiple cases, but it does not define the zero-known-workspaces case. That leaves first... | true | ||
Fission-AI/OpenSpec | 1,029 | comment_to_fix | [codex] Complete workspace foundation and setup specs | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Clarify deprecated command names in this checklist item.**
Line 145 currently reads like `create` and `add-repo` are still part of the expected flow. For a handoff guide, this is easy to misread during implementation.
<details>
<summary>Suggested wording adjustm... | 347f0277e3be3549cd85cdea364fbd7710f1922b | 772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878 | diff --git a/openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md b/openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md
index bf74950b2..10830b0de 100644
--- a/openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md
+++ b/openspec/changes/workspace-reimple... | [
"openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Clarify deprecated command names in this checklist item.**\n\nLine 145 currently reads like `create` and `add-repo` are still part of the expected flow. For a handoff guide, this is easy to misread during implementation.\n\n \n\n<details>\n<su... | true | ||
Fission-AI/OpenSpec | 1,029 | comment_to_fix | [codex] Complete workspace foundation and setup specs | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use product-language terms here to avoid spec drift.**
Line 45 and Line 47 reintroduce `working-set entries`, which conflicts with the new conventions that avoid `working set`/`entry` in user-facing documentation. This creates contradictory guidance for later slices... | 347f0277e3be3549cd85cdea364fbd7710f1922b | 772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878 | diff --git a/openspec/changes/workspace-reimplementation-roadmap/README.md b/openspec/changes/workspace-reimplementation-roadmap/README.md
index 0c25b56c1..aa8560c26 100644
--- a/openspec/changes/workspace-reimplementation-roadmap/README.md
+++ b/openspec/changes/workspace-reimplementation-roadmap/README.md
@@ -42,9 +4... | [
"openspec/changes/workspace-reimplementation-roadmap/README.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use product-language terms here to avoid spec drift.**\n\nLine 45 and Line 47 reintroduce `working-set entries`, which conflicts with the new conventions that avoid `working set`/`entry` in user-facing documentation. This creates contradictory... | true | ||
Fission-AI/OpenSpec | 1,031 | issue_to_patch | fix: make requirement header parsing case-insensitive | ## Problem
`REQUIREMENT_HEADER_REGEX` and the inline seek/skip regexes use case-sensitive matching for `### Requirement:`, while the `## Requirements` section header is found case-insensitively (`/i`).
A user who writes `### requirement: Foo` gets a confusing validation error during archive — "no requirement entries ... | 485c97e97d766e35dd16c02370baee2044abc4f4 | 753e36377cfc2b65adbd5f99faf8a30fcfd7650b | diff --git a/src/core/parsers/requirement-blocks.ts b/src/core/parsers/requirement-blocks.ts
index 7a8161a94..afc55f891 100644
--- a/src/core/parsers/requirement-blocks.ts
+++ b/src/core/parsers/requirement-blocks.ts
@@ -16,7 +16,7 @@ export function normalizeRequirementName(name: string): string {
return name.trim(... | [
"src/core/parsers/requirement-blocks.ts",
"src/core/parsers/spec-structure.ts",
"src/core/specs-apply.ts",
"test/core/parsers/requirement-blocks.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Case-insensitive parsing here conflicts with case-sensitive validation elsewhere**\n\nLine 19 now accepts `### requirement:`/`### REQUIREMENT:`, but `src/core/specs-apply.ts` and `src/core/parsers/spec-structure.ts` still use case-sensitive he... | diff --git a/test/core/parsers/requirement-blocks.test.ts b/test/core/parsers/requirement-blocks.test.ts
new file mode 100644
index 000000000..063593939
--- /dev/null
+++ b/test/core/parsers/requirement-blocks.test.ts
@@ -0,0 +1,46 @@
+import { describe, it, expect } from 'vitest';
+import { extractRequirementsSection,... | true | |
Fission-AI/OpenSpec | 1,031 | comment_to_fix | fix: make requirement header parsing case-insensitive | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Case-insensitive parsing here conflicts with case-sensitive validation elsewhere**
Line 19 now accepts `### requirement:`/`### REQUIREMENT:`, but `src/core/specs-apply.ts` and `src/core/parsers/spec-structure.ts` still use case-sensitive header regexes. This can par... | 485c97e97d766e35dd16c02370baee2044abc4f4 | 753e36377cfc2b65adbd5f99faf8a30fcfd7650b | diff --git a/src/core/parsers/requirement-blocks.ts b/src/core/parsers/requirement-blocks.ts
index 7a8161a94..afc55f891 100644
--- a/src/core/parsers/requirement-blocks.ts
+++ b/src/core/parsers/requirement-blocks.ts
@@ -16,7 +16,7 @@ export function normalizeRequirementName(name: string): string {
return name.trim(... | [
"src/core/parsers/requirement-blocks.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Case-insensitive parsing here conflicts with case-sensitive validation elsewhere**\n\nLine 19 now accepts `### requirement:`/`### REQUIREMENT:`, but `src/core/specs-apply.ts` and `src/core/parsers/spec-structure.ts` still use case-sensitive he... | true | ||
Fission-AI/OpenSpec | 1,031 | comment_to_fix | fix: make requirement header parsing case-insensitive | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Inline header checks are still stricter than the shared requirement regex**
Line 61, Line 79, Line 179, and Line 187 use `^###\s+Requirement:` while Line 19 uses `^###\s*Requirement:`. So `###Requirement: Foo` matches the shared regex but is skipped by these loop bo... | 485c97e97d766e35dd16c02370baee2044abc4f4 | 753e36377cfc2b65adbd5f99faf8a30fcfd7650b | diff --git a/src/core/parsers/requirement-blocks.ts b/src/core/parsers/requirement-blocks.ts
index 7a8161a94..afc55f891 100644
--- a/src/core/parsers/requirement-blocks.ts
+++ b/src/core/parsers/requirement-blocks.ts
@@ -16,7 +16,7 @@ export function normalizeRequirementName(name: string): string {
return name.trim(... | [
"src/core/parsers/requirement-blocks.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Inline header checks are still stricter than the shared requirement regex**\n\nLine 61, Line 79, Line 179, and Line 187 use `^###\\s+Requirement:` while Line 19 uses `^###\\s*Requirement:`. So `###Requirement: Foo` matches the shared regex but... | true | ||
Fission-AI/OpenSpec | 1,033 | issue_to_patch | `compinit` injected by installer conflicts with Oh My Zsh
The installer adds the following block to `.zshrc`:
```
# OPENSPEC:START
# OpenSpec shell completions configuration
fpath=("/Users/<user>/.oh-my-zsh/custom/completions" $fpath)
autoload -Uz compinit
compinit
# OPENSPEC:END
```
When Oh My Zsh is present, this ... | [codex] fix Oh My Zsh completion compinit setup | ## Summary
- Stop auto-mutating `.zshrc` for Oh My Zsh zsh completion installs.
- Keep installing `_openspec` into OMZ `custom/completions`, letting OMZ manage `fpath` and `compinit` itself.
- Update zsh installer tests to assert OMZ installs leave `.zshrc` unchanged and do not inject OpenSpec `compinit` lines.
## Ro... | 485c97e97d766e35dd16c02370baee2044abc4f4 | 4c0d6a7fca8c015dfd27b0fb7e8b55917f8f2d29 | diff --git a/src/core/completions/installers/zsh-installer.ts b/src/core/completions/installers/zsh-installer.ts
index 6a4493180..bada131ab 100644
--- a/src/core/completions/installers/zsh-installer.ts
+++ b/src/core/completions/installers/zsh-installer.ts
@@ -166,27 +166,6 @@ export class ZshInstaller {
}
}
... | [
"src/core/completions/installers/zsh-installer.ts",
"test/core/completions/installers/zsh-installer.test.ts"
] | [] | diff --git a/test/core/completions/installers/zsh-installer.test.ts b/test/core/completions/installers/zsh-installer.test.ts
index a6827f4be..67168ff16 100644
--- a/test/core/completions/installers/zsh-installer.test.ts
+++ b/test/core/completions/installers/zsh-installer.test.ts
@@ -167,6 +167,7 @@ describe('ZshInstal... | true |
Fission-AI/OpenSpec | 1,032 | issue_to_patch | openspec installed via Bun fails to run — shebang hardcodes node instead of bun
## Summary
When openspec is installed via Bun, running it fails with the following error:
```bash
openspec
env: node: No such file or directory
```
This happens on systems where Node.js is not installed, because the installed binary at ... | [codex] Clarify Bun install still requires Node | ## Summary
- Clarify in the installation guide that Bun can install OpenSpec globally, but OpenSpec still runs on Node.js.
- Add an empty changeset so CI records this as a docs-only change with no package release.
## Root Cause
Issue #1019 reports that `bun add -g @fission-ai/openspec` installs an executable whose s... | 485c97e97d766e35dd16c02370baee2044abc4f4 | f1a9ec8f52a46aabb02ee363a92c3022f7219b7c | diff --git a/.changeset/clarify-bun-node-runtime.md b/.changeset/clarify-bun-node-runtime.md
new file mode 100644
index 000000000..a845151cc
--- /dev/null
+++ b/.changeset/clarify-bun-node-runtime.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/docs/installation.md b/docs/installation.md
index 78910513c..8c13c2203 100644
---... | [
".changeset/clarify-bun-node-runtime.md",
"docs/installation.md"
] | [] | true | |
Fission-AI/OpenSpec | 1,030 | issue_to_patch | [codex] Include sync in core workflow defaults | ## Summary
Adds `sync` to the default `core` workflow profile so new installs generate `/opsx:sync` skills and commands by default.
This also updates profile/init/update/config tests, user docs, and adds a changeset for the behavior change.
## Existing Users
This PR does not silently mutate custom profiles.
- User... | 347f0277e3be3549cd85cdea364fbd7710f1922b | b822af55d6b71d4ff918723de74629196c187da8 | diff --git a/.changeset/sync-default-core.md b/.changeset/sync-default-core.md
new file mode 100644
index 000000000..2b53a3526
--- /dev/null
+++ b/.changeset/sync-default-core.md
@@ -0,0 +1,7 @@
+---
+"@fission-ai/openspec": minor
+---
+
+### New Features
+
+- Include the sync workflow in the default core profile so ne... | [
".changeset/sync-default-core.md",
"README.md",
"docs/cli.md",
"docs/commands.md",
"docs/getting-started.md",
"docs/migration-guide.md",
"docs/opsx.md",
"docs/supported-tools.md",
"docs/workflows.md",
"src/core/profiles.ts",
"src/core/update.ts",
"test/commands/config-profile.test.ts",
"test... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Core command listings are now inconsistent within this doc.**\n\nAfter moving `sync` into default `core`, some command lists still reflect the old split (and Line 11 omits `explore`). Please align all “default core” and “expanded” sections in ... | diff --git a/test/commands/config-profile.test.ts b/test/commands/config-profile.test.ts
index ef116693a..6208403c2 100644
--- a/test/commands/config-profile.test.ts
+++ b/test/commands/config-profile.test.ts
@@ -64,12 +64,12 @@ describe('deriveProfileFromWorkflowSelection', () => {
it('returns custom when selecti... | true | |
Fission-AI/OpenSpec | 1,027 | issue_to_patch | docs: sync tool ID lists with AI_TOOLS source of truth | Follow-up to #1003
## Goal and constraints
PR #1003 (feat: add Kimi CLI skills-only support) added `kimi` to `AI_TOOLS` in `src/core/config.ts`, but the static tool-ID lists in `docs/cli.md` and `docs/supported-tools.md` drifted from the source of truth. Copilot AI review on #1003 flagged this drift; I kept that PR n... | cb9641a45054391c8386ee5eff150073207ca413 | a84ecda970abfe98178dda074a32098d11639952 | diff --git a/docs/cli.md b/docs/cli.md
index 5bbe6e018..a5de58260 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -89,7 +89,7 @@ openspec init [path] [options]
`--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`).
-**Supported tool IDs (`--tools`):** `amazon-... | [
"docs/cli.md",
"docs/supported-tools.md"
] | [
{
"comment": "The tool ID order here doesn’t match the `AI_TOOLS` source-of-truth order in `src/core/config.ts`. In `AI_TOOLS`, `lingma` comes after `qoder` (… `opencode`, `pi`, `qoder`, `lingma`, `qwen` …), but this list places `lingma` before `opencode/pi/qoder`. Please reorder this list to match `AI_TOOLS` i... | true | ||
Fission-AI/OpenSpec | 1,027 | comment_to_fix | docs: sync tool ID lists with AI_TOOLS source of truth | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Tool ID ordering at Line 92 still diverges from `AI_TOOLS`.**
`lingma` should appear after `qoder` to match `src/core/config.ts` ordering and keep this list consistent with runtime/help text generation.
<details>
<summary>🛠️ Suggested reorder</summary>
```diff... | cb9641a45054391c8386ee5eff150073207ca413 | a84ecda970abfe98178dda074a32098d11639952 | diff --git a/docs/cli.md b/docs/cli.md
index 5bbe6e018..a5de58260 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -89,7 +89,7 @@ openspec init [path] [options]
`--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`).
-**Supported tool IDs (`--tools`):** `amazon-... | [
"docs/cli.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Tool ID ordering at Line 92 still diverges from `AI_TOOLS`.**\n\n`lingma` should appear after `qoder` to match `src/core/config.ts` ordering and keep this list consistent with runtime/help text generation.\n\n \n\n<details>\n<summary>🛠️ Sugge... | true | ||
Fission-AI/OpenSpec | 1,027 | comment_to_fix | docs: sync tool ID lists with AI_TOOLS source of truth | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Sync is still incomplete for Lingma placement/details.**
Line 75 puts `lingma` before `opencode`, but the canonical `AI_TOOLS` order is after `qoder` (`src/core/config.ts:20-52`). Also, this file now lists `lingma` as available but still has no Lingma entry in the T... | cb9641a45054391c8386ee5eff150073207ca413 | a84ecda970abfe98178dda074a32098d11639952 | diff --git a/docs/supported-tools.md b/docs/supported-tools.md
index b47b73c2a..dc3487a89 100644
--- a/docs/supported-tools.md
+++ b/docs/supported-tools.md
@@ -42,6 +42,7 @@ You can enable expanded workflows (`new`, `continue`, `ff`, `verify`, `sync`, `b
| Kilo Code (`kilocode`) | `.kilocode/skills/openspec-*/SKILL.m... | [
"docs/supported-tools.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Sync is still incomplete for Lingma placement/details.**\n\nLine 75 puts `lingma` before `opencode`, but the canonical `AI_TOOLS` order is after `qoder` (`src/core/config.ts:20-52`). Also, this file now lists `lingma` as available but still ha... | true | ||
Fission-AI/OpenSpec | 1,025 | issue_to_patch | docs: add workspace reimplementation proposal slices | ## Summary
Adds a lightweight OpenSpec planning layer for reimplementing workspace support without nesting changes under a parent directory.
This PR adds one roadmap proposal plus six flat sibling proposal changes:
- `workspace-reimplementation-roadmap`
- `workspace-foundation`
- `workspace-create-and-register-repos... | 342ed43e694abba65a3ea275f94ba3b77df85da3 | 01d3cf01284a9eb6318cff798c4b5decb36e5c51 | diff --git a/WORKSPACE_REIMPLEMENTATION_DIRECTION.md b/WORKSPACE_REIMPLEMENTATION_DIRECTION.md
new file mode 100644
index 000000000..caad72c07
--- /dev/null
+++ b/WORKSPACE_REIMPLEMENTATION_DIRECTION.md
@@ -0,0 +1,456 @@
+# Workspace Reimplementation Direction
+
+Date: 2026-04-30
+
+Fresh-agent entry point: read `WORKS... | [
"WORKSPACE_REIMPLEMENTATION_DIRECTION.md",
"WORKSPACE_REIMPLEMENTATION_START_HERE.md",
"openspec/changes/workspace-apply-repo-slice/proposal.md",
"openspec/changes/workspace-change-planning/proposal.md",
"openspec/changes/workspace-create-and-register-repos/proposal.md",
"openspec/changes/workspace-founda... | [] | true | ||
Fission-AI/OpenSpec | 1,003 | issue_to_patch | feat: add Kimi CLI skills-only support | ## Summary
- add Kimi CLI as a supported OpenSpec tool with `skillsDir: '.kimi'`
- document Kimi as a skills-only integration using `/skill:openspec-*`
- add a focused init regression test and a changeset
- add a spec-driven change proposal for the Kimi CLI support work
## Technical Analysis
Kimi CLI does n... | 3c7a05c5dc88b2397c478805890b55ed392b19e8 | 624ad1a79562e9e2c9748935d851d20195ba5d86 | diff --git a/.changeset/kind-rings-notice.md b/.changeset/kind-rings-notice.md
new file mode 100644
index 000000000..ab0b42d0f
--- /dev/null
+++ b/.changeset/kind-rings-notice.md
@@ -0,0 +1,11 @@
+---
+"@fission-ai/openspec": minor
+---
+
+### New Features
+
+- **Kimi CLI support** — OpenSpec can now initialize Kimi CL... | [
".changeset/kind-rings-notice.md",
"docs/cli.md",
"docs/commands.md",
"docs/supported-tools.md",
"openspec/changes/archive/2026-04-23-add-kimi-cli-skills-only-support/.openspec.yaml",
"openspec/changes/archive/2026-04-23-add-kimi-cli-skills-only-support/README.md",
"openspec/changes/archive/2026-04-23-a... | [
{
"comment": "This assertion is brittle because the init implementation logs the message via `chalk.dim(...)`, which can add ANSI color codes depending on environment. Consider asserting with `.some(entry => entry.includes('Commands skipped for: kimi') && entry.includes('(no adapter)'))` (or disabling color via... | diff --git a/openspec/changes/archive/2026-04-23-add-kimi-cli-skills-only-support/specs/ai-tool-paths/spec.md b/openspec/changes/archive/2026-04-23-add-kimi-cli-skills-only-support/specs/ai-tool-paths/spec.md
new file mode 100644
index 000000000..e981874b4
--- /dev/null
+++ b/openspec/changes/archive/2026-04-23-add-kim... | true | |
Fission-AI/OpenSpec | 1,003 | comment_to_fix | feat: add Kimi CLI skills-only support | This `--tools` ID list is incomplete relative to the actual supported tool IDs in `src/core/config.ts` (e.g., it omits `bob`, `forgecode`, `junie`, and `lingma`). Please sync this list with `AI_TOOLS` (ideally generated from the source of truth) to avoid users being unable to discover valid `--tools` values.
```suggest... | 3c7a05c5dc88b2397c478805890b55ed392b19e8 | 624ad1a79562e9e2c9748935d851d20195ba5d86 | diff --git a/docs/cli.md b/docs/cli.md
index ddcdaa0a4..5bbe6e018 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -89,7 +89,7 @@ openspec init [path] [options]
`--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`).
-**Supported tool IDs (`--tools`):** `amazon-... | [
"docs/cli.md"
] | [
{
"comment": "This `--tools` ID list is incomplete relative to the actual supported tool IDs in `src/core/config.ts` (e.g., it omits `bob`, `forgecode`, `junie`, and `lingma`). Please sync this list with `AI_TOOLS` (ideally generated from the source of truth) to avoid users being unable to discover valid `--too... | true | ||
Fission-AI/OpenSpec | 1,003 | comment_to_fix | feat: add Kimi CLI skills-only support | This "Available tool IDs" list appears out of sync with `src/core/config.ts` now that `kimi` was added (for example `lingma` exists in `AI_TOOLS` but is not listed here). Please update the list (and the table above, if applicable) so documentation matches the supported tool registry.
```suggestion
**Available tool IDs ... | 3c7a05c5dc88b2397c478805890b55ed392b19e8 | 624ad1a79562e9e2c9748935d851d20195ba5d86 | diff --git a/docs/supported-tools.md b/docs/supported-tools.md
index dc5500920..b47b73c2a 100644
--- a/docs/supported-tools.md
+++ b/docs/supported-tools.md
@@ -40,6 +40,7 @@ You can enable expanded workflows (`new`, `continue`, `ff`, `verify`, `sync`, `b
| iFlow (`iflow`) | `.iflow/skills/openspec-*/SKILL.md` | `.ifl... | [
"docs/supported-tools.md"
] | [
{
"comment": "This \"Available tool IDs\" list appears out of sync with `src/core/config.ts` now that `kimi` was added (for example `lingma` exists in `AI_TOOLS` but is not listed here). Please update the list (and the table above, if applicable) so documentation matches the supported tool registry.\n```suggest... | true | ||
Fission-AI/OpenSpec | 996 | issue_to_patch | chore(release): version packages | This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ... | d1f3861d9ec694cc924b042b5da01963dcf93137 | 6f2bffee2b0c92ca17644868a254a244bec3edfe | diff --git a/.changeset/v1-3-1-patch-fixes.md b/.changeset/v1-3-1-patch-fixes.md
deleted file mode 100644
index c6dcb2bb2..000000000
--- a/.changeset/v1-3-1-patch-fixes.md
+++ /dev/null
@@ -1,11 +0,0 @@
----
-"@fission-ai/openspec": patch
----
-
-### Bug Fixes
-
-- **Canonical artifact paths** — Workflow artifact paths... | [
".changeset/v1-3-1-patch-fixes.md",
"CHANGELOG.md",
"package.json"
] | [] | true | ||
Fission-AI/OpenSpec | 995 | issue_to_patch | chore: add changeset for v1.3.1 patch fixes | ## Summary
Patch release (1.3.0 → 1.3.1) bundling the bug fixes merged to `main` since v1.3.0. All user-facing changes are fixes; docs-only and test-only commits are excluded per changeset guidelines.
### Bug Fixes included
- **Canonical artifact paths** (#971, #972) — Workflow artifact paths resolved via native `re... | 7a39e887bbeb1f72d33fc1f03cc82afee2cddf03 | 02677960300c9d8b37b408d3da36b2299efc9d5a | diff --git a/.changeset/v1-3-1-patch-fixes.md b/.changeset/v1-3-1-patch-fixes.md
new file mode 100644
index 000000000..c6dcb2bb2
--- /dev/null
+++ b/.changeset/v1-3-1-patch-fixes.md
@@ -0,0 +1,11 @@
+---
+"@fission-ai/openspec": patch
+---
+
+### Bug Fixes
+
+- **Canonical artifact paths** — Workflow artifact paths are... | [
".changeset/v1-3-1-patch-fixes.md"
] | [] | true | ||
Fission-AI/OpenSpec | 984 | issue_to_patch | Parenthesis on directory and filenames break openspec artifact check
Parenthesis characters "(" and ")" - if they are in the path for the project - break the glob pattern search, making openspec report things erroneously.
More specifically, It broken progress check, showing "specs" as not done yet, even though I had... | fix: escape glob-special characters in directory paths | ## Summary
- Escape parentheses and square brackets in the directory portion of glob patterns before passing to `fast-glob`, so they are treated as literal path characters instead of extglob syntax
- Add `escapeGlobPath()` helper that targets only `()` and `[]` — characters proven to break `fast-glob`/`picomatch` match... | 18c445a48d3fce94883296d5e76dd3aed8f57db2 | 1064457cbc6e3c8e21ab30f0689a2fc7e8a0571c | diff --git a/src/core/artifact-graph/outputs.ts b/src/core/artifact-graph/outputs.ts
index 398b9c179..9467552f2 100644
--- a/src/core/artifact-graph/outputs.ts
+++ b/src/core/artifact-graph/outputs.ts
@@ -15,21 +15,20 @@ export function isGlobPattern(pattern: string): boolean {
* Returns absolute file paths. Glob mat... | [
"src/core/artifact-graph/outputs.ts",
"test/core/artifact-graph/outputs.test.ts"
] | [] | diff --git a/test/core/artifact-graph/outputs.test.ts b/test/core/artifact-graph/outputs.test.ts
index e20dddd04..988200e2c 100644
--- a/test/core/artifact-graph/outputs.test.ts
+++ b/test/core/artifact-graph/outputs.test.ts
@@ -106,4 +106,70 @@ describe('artifact-graph/outputs', () => {
expect(resolveArtifactOutp... | true |
Fission-AI/OpenSpec | 990 | issue_to_patch | fix: handle XDG_CONFIG_HOME and %APPDATA% in telemetry config path | `src/telemetry/config.ts` hardcodes the config path to `~/.config/openspec/config.json`, ignoring `XDG_CONFIG_HOME` and Windows `%APPDATA%`, unlike `src/core/global-config.ts` which handles both.
This causes telemetry state (anonymous ID, notice-seen flag) to be written to a different directory than global config wh... | 900174000b8a09f3c46c8e09e7e5e6be35375e45 | 972a7658e75b6079f5238e0f7d97deb9573c8529 | diff --git a/src/telemetry/config.ts b/src/telemetry/config.ts
index a79704f0b..5bad282d9 100644
--- a/src/telemetry/config.ts
+++ b/src/telemetry/config.ts
@@ -1,10 +1,19 @@
/**
* Global configuration for telemetry state.
- * Stores anonymous ID and notice-seen flag in ~/.config/openspec/config.json
+ * Stores anon... | [
"src/telemetry/config.ts",
"test/telemetry/config.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Preserve existing telemetry state when moving to the new path.**\n\nUsers may already have `anonymousId` / `noticeSeen` in the old hard-coded `~/.config/openspec/config.json`. With the new resolved path, `readConfig()` returns `{}` when the new file is missin... | diff --git a/test/telemetry/config.test.ts b/test/telemetry/config.test.ts
index 075b7b8c1..ef5726621 100644
--- a/test/telemetry/config.test.ts
+++ b/test/telemetry/config.test.ts
@@ -2,6 +2,7 @@ import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import * as fs from 'node:fs';
import * as path fro... | true | |
Fission-AI/OpenSpec | 990 | comment_to_fix | fix: handle XDG_CONFIG_HOME and %APPDATA% in telemetry config path | _⚠️ Potential issue_ | _🟠 Major_
**Preserve existing telemetry state when moving to the new path.**
Users may already have `anonymousId` / `noticeSeen` in the old hard-coded `~/.config/openspec/config.json`. With the new resolved path, `readConfig()` returns `{}` when the new file is missing or lacks telemetry, caus... | 900174000b8a09f3c46c8e09e7e5e6be35375e45 | 972a7658e75b6079f5238e0f7d97deb9573c8529 | diff --git a/src/telemetry/config.ts b/src/telemetry/config.ts
index a79704f0b..5bad282d9 100644
--- a/src/telemetry/config.ts
+++ b/src/telemetry/config.ts
@@ -1,10 +1,19 @@
/**
* Global configuration for telemetry state.
- * Stores anonymous ID and notice-seen flag in ~/.config/openspec/config.json
+ * Stores anon... | [
"src/telemetry/config.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Preserve existing telemetry state when moving to the new path.**\n\nUsers may already have `anonymousId` / `noticeSeen` in the old hard-coded `~/.config/openspec/config.json`. With the new resolved path, `readConfig()` returns `{}` when the new file is missin... | true | ||
Fission-AI/OpenSpec | 990 | comment_to_fix | fix: handle XDG_CONFIG_HOME and %APPDATA% in telemetry config path | _⚠️ Potential issue_ | _🟠 Major_
**Avoid overwriting an invalid or unreadable new config during migration.**
`readConfigFile()` turns parse/read failures into `{}`, so with `XDG_CONFIG_HOME`/`APPDATA` set, `readConfig()` can treat an existing invalid new config as “missing telemetry” and Line 104 will overwrite it w... | 900174000b8a09f3c46c8e09e7e5e6be35375e45 | 972a7658e75b6079f5238e0f7d97deb9573c8529 | diff --git a/src/telemetry/config.ts b/src/telemetry/config.ts
index a79704f0b..5bad282d9 100644
--- a/src/telemetry/config.ts
+++ b/src/telemetry/config.ts
@@ -1,10 +1,19 @@
/**
* Global configuration for telemetry state.
- * Stores anonymous ID and notice-seen flag in ~/.config/openspec/config.json
+ * Stores anon... | [
"src/telemetry/config.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Avoid overwriting an invalid or unreadable new config during migration.**\n\n`readConfigFile()` turns parse/read failures into `{}`, so with `XDG_CONFIG_HOME`/`APPDATA` set, `readConfig()` can treat an existing invalid new config as “missing telemetry” and Li... | true | ||
Fission-AI/OpenSpec | 990 | comment_to_fix | fix: handle XDG_CONFIG_HOME and %APPDATA% in telemetry config path | _⚠️ Potential issue_ | _🟠 Major_
**Make the default-path tests platform-aware.**
Line 35 deletes `APPDATA`, but `getGlobalConfigDir()` uses `APPDATA` or `AppData/Roaming` on `win32`; the default-path assertions/fixtures still hard-code `.config/openspec`, so these tests fail on Windows—the platform this PR is meant ... | 900174000b8a09f3c46c8e09e7e5e6be35375e45 | 972a7658e75b6079f5238e0f7d97deb9573c8529 | diff --git a/test/telemetry/config.test.ts b/test/telemetry/config.test.ts
index 075b7b8c1..ef5726621 100644
--- a/test/telemetry/config.test.ts
+++ b/test/telemetry/config.test.ts
@@ -2,6 +2,7 @@ import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import * as fs from 'node:fs';
import * as path fro... | [
"test/telemetry/config.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Make the default-path tests platform-aware.**\n\nLine 35 deletes `APPDATA`, but `getGlobalConfigDir()` uses `APPDATA` or `AppData/Roaming` on `win32`; the default-path assertions/fixtures still hard-code `.config/openspec`, so these tests fail on Windows—the ... | true | ||
Fission-AI/OpenSpec | 991 | issue_to_patch | docs: remove teams Slack mention from README | ## Summary
- Remove the Teams section that mentioned Slack channel access from the README
## Testing
- Verified README no longer contains Slack, teams@openspec, or the Teams heading
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Documentation**
* Removed th... | f529b2596896afd95d855507b0c53b5d515433b5 | c4d5be8b308823746640846cc6d992111bee18ca | diff --git a/README.md b/README.md
index 45c18bd7e..1d010ca8d 100644
--- a/README.md
+++ b/README.md
@@ -42,10 +42,6 @@ Our philosophy:
Follow <a href="https://x.com/0xTab">@0xTab on X</a> for updates · Join the <a href="https://discord.gg/YctCnvvshC">OpenSpec Discord</a> for help and questions.
</p>
-### Teams
-... | [
"README.md"
] | [] | true | ||
Fission-AI/OpenSpec | 975 | issue_to_patch | test: align path assertions with canonical helper | ## Summary
- update Windows-sensitive artifact workflow assertions to use the same canonical path helper as production
- align artifact output tests with the helper contract instead of raw Node realpath variants
## Testing
- pnpm exec vitest run test/core/artifact-graph/outputs.test.ts test/commands/artifact-workflow.... | 93f7b797cf818cecb26abfc16dfbca9c2ec199e7 | 71ffea4b27b8ae6ecd049c5673fcb00f640ccce9 | [
"test/commands/artifact-workflow.test.ts",
"test/core/artifact-graph/outputs.test.ts"
] | [] | diff --git a/test/commands/artifact-workflow.test.ts b/test/commands/artifact-workflow.test.ts
index 0bfc8b40d..613e37f98 100644
--- a/test/commands/artifact-workflow.test.ts
+++ b/test/commands/artifact-workflow.test.ts
@@ -3,11 +3,14 @@ import { promises as fs } from 'fs';
import path from 'path';
import os from 'o... | true | ||
Fission-AI/OpenSpec | 972 | issue_to_patch | fix: prefer native realpath for canonical paths | ## Summary
- prefer Node's native realpath resolver when canonicalizing existing paths
- ensure Windows short-path aliases like `RUNNER~1` are expanded before artifact workflow JSON emits file paths
- add regression coverage for the canonicalization helper
## Context
- follow-up to #971, which merged before this Windo... | 7d07101363c0e210ae0202951104e94e03806cc3 | 493605756f2adf484b2357580783e8c14eff9ffc | diff --git a/src/utils/file-system.ts b/src/utils/file-system.ts
index c8d545e2b..6ee7cda6b 100644
--- a/src/utils/file-system.ts
+++ b/src/utils/file-system.ts
@@ -1,6 +1,9 @@
-import { promises as fs, constants as fsConstants, realpathSync } from 'fs';
+import * as nodeFs from 'fs';
import path from 'path';
+const... | [
"src/utils/file-system.ts",
"test/utils/file-system.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"Checking Vitest config for automatic mock restoration...\"\nfd -i 'vitest.config.*' | while read -r file; do\n echo \"---- ${file} ----... | diff --git a/test/utils/file-system.test.ts b/test/utils/file-system.test.ts
index 88923baf5..ab436150f 100644
--- a/test/utils/file-system.test.ts
+++ b/test/utils/file-system.test.ts
@@ -1,4 +1,5 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afte... | true | |
Fission-AI/OpenSpec | 971 | issue_to_patch | fix: canonicalize workflow artifact paths | ## Summary
- canonicalize artifact output paths before returning them in workflow JSON/text outputs
- normalize adjacent existing-file workflow paths (changeDir and template paths) to avoid OS-specific aliases leaking into machine-readable output
- add regression coverage for aliased change directories so Windows-style... | c0f29044f9addb13b4c0873d1e7c8177abe04500 | 8945ed21ca38bddc6483ed1bbfeba5fe85671618 | diff --git a/src/commands/workflow/instructions.ts b/src/commands/workflow/instructions.ts
index 498d87cf8..7afba1475 100644
--- a/src/commands/workflow/instructions.ts
+++ b/src/commands/workflow/instructions.ts
@@ -250,7 +250,7 @@ export async function generateApplyInstructions(
): Promise<ApplyInstructions> {
//... | [
"src/commands/workflow/instructions.ts",
"src/commands/workflow/templates.ts",
"src/core/artifact-graph/instruction-loader.ts",
"src/core/artifact-graph/outputs.ts",
"src/utils/file-system.ts",
"test/core/artifact-graph/outputs.test.ts"
] | [] | diff --git a/test/core/artifact-graph/outputs.test.ts b/test/core/artifact-graph/outputs.test.ts
index b2c04862e..e0adda1bc 100644
--- a/test/core/artifact-graph/outputs.test.ts
+++ b/test/core/artifact-graph/outputs.test.ts
@@ -20,7 +20,7 @@ describe('artifact-graph/outputs', () => {
const filePath = path.join(te... | true | |
Fission-AI/OpenSpec | 969 | issue_to_patch | docs: clarify initiative-first workspace model | ## Summary
- update workspace architecture to frame initiatives as the first-class planning object for larger multi-team work
- keep repo-local changes as execution artifacts, linked back to shared initiatives
- update workspace user journeys to show initiative-level planning in the coordination workspace and execution... | 7fe45ca330976088b117156c30d8c799af8d60c7 | 98d56bdec75b09785e7c8ebbce3d8e9ddec8a654 | diff --git a/openspec/explorations/explore-workflow-ux.md b/openspec/explorations/explore-workflow-ux.md
index bca7f59a0..081cedf12 100644
--- a/openspec/explorations/explore-workflow-ux.md
+++ b/openspec/explorations/explore-workflow-ux.md
@@ -6,6 +6,8 @@ The explore workflow is part of the core loop (`propose`, `expl... | [
"openspec/explorations/explore-workflow-ux.md",
"openspec/explorations/workspace-architecture.md",
"openspec/explorations/workspace-roadmap.md",
"openspec/explorations/workspace-user-journeys.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Clarify this YAML as “target state,” not current behavior.**\n\nThis example introduces `initiative`, but current metadata schema (in `src/core/artifact-graph/types.ts`) does not yet include it. Please label this snippet as proposed/future to avoid implemente... | true | ||
Fission-AI/OpenSpec | 967 | issue_to_patch | `instructions apply` fails to detect glob-pattern artifacts (e.g. `specs/*/spec.md`)
## Version
`@fission-ai/openspec` v1.2.0, Windows 11, Node.js
## Summary
`openspec instructions apply --change <name>` reports `Missing artifacts: specs` even when the spec file exists and `openspec status` correctly shows `specs:... | Fix apply instructions for glob artifact outputs | ## Summary
Fix `openspec instructions apply` so glob-generated artifacts resolve consistently with `openspec status`.
Closes #942.
## Problem
`instructions apply` used its own hand-written artifact matcher while `status` used the shared artifact-graph completion logic backed by `fast-glob`.
That caused two user-vi... | c8e2072e3ae26a978f1576d37df67e64cd1db134 | 5230e8517ba746a5e877413f287e7ee574424950 | diff --git a/src/commands/workflow/instructions.ts b/src/commands/workflow/instructions.ts
index c90ff6a3d..498d87cf8 100644
--- a/src/commands/workflow/instructions.ts
+++ b/src/commands/workflow/instructions.ts
@@ -12,6 +12,7 @@ import {
loadChangeContext,
generateInstructions,
resolveSchema,
+ resolveArtif... | [
"openspec/specs/cli-artifact-workflow/spec.md",
"src/commands/workflow/instructions.ts",
"src/commands/workflow/shared.ts",
"src/core/artifact-graph/index.ts",
"src/core/artifact-graph/outputs.ts",
"src/core/artifact-graph/state.ts",
"src/core/templates/workflows/apply-change.ts",
"src/core/templates/... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Literal-path branch should enforce file-only semantics**\n\nThe non-glob branch treats existing directories as valid outputs, while the glob branch is file-only (`onlyFiles: true`). That inconsistency can mark an artifact complete when only a directory exists... | diff --git a/openspec/specs/cli-artifact-workflow/spec.md b/openspec/specs/cli-artifact-workflow/spec.md
index 2a5811992..5c1c3ce52 100644
--- a/openspec/specs/cli-artifact-workflow/spec.md
+++ b/openspec/specs/cli-artifact-workflow/spec.md
@@ -203,7 +203,7 @@ The system SHALL generate schema-aware apply instructions v... | true |
Fission-AI/OpenSpec | 967 | comment_to_fix | Fix apply instructions for glob artifact outputs | _⚠️ Potential issue_ | _🟡 Minor_
**Literal-path branch should enforce file-only semantics**
The non-glob branch treats existing directories as valid outputs, while the glob branch is file-only (`onlyFiles: true`). That inconsistency can mark an artifact complete when only a directory exists.
<details>
<summary>Sug... | c8e2072e3ae26a978f1576d37df67e64cd1db134 | 5230e8517ba746a5e877413f287e7ee574424950 | diff --git a/src/core/artifact-graph/outputs.ts b/src/core/artifact-graph/outputs.ts
new file mode 100644
index 000000000..5dff4fc33
--- /dev/null
+++ b/src/core/artifact-graph/outputs.ts
@@ -0,0 +1,39 @@
+import * as fs from 'node:fs';
+import * as path from 'node:path';
+import fg from 'fast-glob';
+import { FileSyst... | [
"src/core/artifact-graph/outputs.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Literal-path branch should enforce file-only semantics**\n\nThe non-glob branch treats existing directories as valid outputs, while the glob branch is file-only (`onlyFiles: true`). That inconsistency can mark an artifact complete when only a directory exists... | true | ||
Fission-AI/OpenSpec | 966 | issue_to_patch | feat(validator): detect stray delta headers that silently truncate main specs
**OpenSpec version**: 1.2.0
First off — thanks for OpenSpec. I've been using it regularly on a private project and it's become a core part of how I ship changes. This issue is the first rough edge I've hit that I think benefits other users ... | fix: detect hidden requirements in main specs | Closes #954
## Summary
- detect stray delta headers and hidden `### Requirement:` blocks outside the parsed `## Requirements` section in main specs
- fail archive early with a structural error when a target main spec is malformed instead of surfacing a misleading missing-requirement error
- ignore fenced-code headings... | cd5e49346f91f37d18f0035ca50ed17d9be2c062 | fc7680bcc0e7b7a830f6d3460c19f511b537ee7b | diff --git a/src/core/parsers/change-parser.ts b/src/core/parsers/change-parser.ts
index 0c8d1e280..a2c364b70 100644
--- a/src/core/parsers/change-parser.ts
+++ b/src/core/parsers/change-parser.ts
@@ -179,17 +179,21 @@ export class ChangeParser extends MarkdownParser {
private parseSectionsFromContent(content: strin... | [
"openspec/specs/cli-update/spec.md",
"openspec/specs/openspec-conventions/spec.md",
"src/core/parsers/change-parser.ts",
"src/core/parsers/markdown-parser.ts",
"src/core/parsers/spec-structure.ts",
"src/core/specs-apply.ts",
"src/core/validation/validator.ts",
"test/core/archive.test.ts",
"test/core... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Require a real closing fence before re-enabling header parsing.**\n\n`buildCodeFenceMask()` currently reuses `getFenceMarker()` for both open and close detection. Inside an active fence, a line that only *starts* with the same marker and length can clear `act... | diff --git a/openspec/specs/cli-update/spec.md b/openspec/specs/cli-update/spec.md
index 5ba070c4d..3de91356e 100644
--- a/openspec/specs/cli-update/spec.md
+++ b/openspec/specs/cli-update/spec.md
@@ -168,7 +168,7 @@ The archive slash command template SHALL support optional change ID arguments fo
## Edge Cases
-##... | true |
Fission-AI/OpenSpec | 966 | comment_to_fix | fix: detect hidden requirements in main specs | _⚠️ Potential issue_ | _🟡 Minor_
**Require a real closing fence before re-enabling header parsing.**
`buildCodeFenceMask()` currently reuses `getFenceMarker()` for both open and close detection. Inside an active fence, a line that only *starts* with the same marker and length can clear `activeFence`, even when it st... | cd5e49346f91f37d18f0035ca50ed17d9be2c062 | fc7680bcc0e7b7a830f6d3460c19f511b537ee7b | diff --git a/src/core/parsers/markdown-parser.ts b/src/core/parsers/markdown-parser.ts
index 8bd59d1ae..abad78df2 100644
--- a/src/core/parsers/markdown-parser.ts
+++ b/src/core/parsers/markdown-parser.ts
@@ -9,11 +9,13 @@ export interface Section {
export class MarkdownParser {
private lines: string[];
+ privat... | [
"src/core/parsers/markdown-parser.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Require a real closing fence before re-enabling header parsing.**\n\n`buildCodeFenceMask()` currently reuses `getFenceMarker()` for both open and close detection. Inside an active fence, a line that only *starts* with the same marker and length can clear `act... | true | ||
Fission-AI/OpenSpec | 966 | comment_to_fix | fix: detect hidden requirements in main specs | _⚠️ Potential issue_ | _🟡 Minor_
**Ignore fenced examples in the requirement-count assertion.**
`rawRequirementCount` is taken from the raw markdown, so a valid fenced example containing `### Requirement:` will bump the count even though `MarkdownParser` now ignores those lines. That makes this test fail on the same... | cd5e49346f91f37d18f0035ca50ed17d9be2c062 | fc7680bcc0e7b7a830f6d3460c19f511b537ee7b | diff --git a/test/specs/source-specs-normalization.test.ts b/test/specs/source-specs-normalization.test.ts
index 79ab1e34b..1169e8a26 100644
--- a/test/specs/source-specs-normalization.test.ts
+++ b/test/specs/source-specs-normalization.test.ts
@@ -2,14 +2,19 @@ import { promises as fs } from 'fs';
import path from 'p... | [
"test/specs/source-specs-normalization.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Ignore fenced examples in the requirement-count assertion.**\n\n`rawRequirementCount` is taken from the raw markdown, so a valid fenced example containing `### Requirement:` will bump the count even though `MarkdownParser` now ignores those lines. That makes ... | true | ||
Fission-AI/OpenSpec | 965 | issue_to_patch | docs: expand workspace planning explorations | ## Summary
- update the workspace architecture exploration with the current direction: hybrid Model D, linked per-repo changes, stable project identifiers, and informational cross-repo references
- add detailed user journeys for single-repo, monorepo, multi-repo, and team-shared coordination flows
- add a UX simplifica... | a18d992fa1c1f53512870a2272faebe367af0062 | 0f89dec38d8ea16fb06dcab8df8e47c9468b73ea | diff --git a/openspec/explorations/workspace-architecture.md b/openspec/explorations/workspace-architecture.md
index f9ac81821..8023ba9ef 100644
--- a/openspec/explorations/workspace-architecture.md
+++ b/openspec/explorations/workspace-architecture.md
@@ -645,23 +645,131 @@ To avoid losing this in exploration notes, c... | [
"openspec/explorations/workspace-architecture.md",
"openspec/explorations/workspace-roadmap.md",
"openspec/explorations/workspace-user-journeys.md",
"openspec/explorations/workspace-ux-simplification.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Standardize canonical project ID casing in examples.**\n\nCanonical IDs are shown with mixed case (e.g., `github.com/Fission-AI/...`), while the architecture decision defines normalized `host/org/repo`. Use one canonical lowercase form in all examples to avoi... | true | ||
Fission-AI/OpenSpec | 960 | issue_to_patch | ora spinner output mixes with --json, breaking AI agent JSON parsing
## Problem
When using `--json` flag, `ora` spinner shows `- Loading...` in combined output, breaking JSON parsing in AI agent tools.
**Example:**
\`\`\`bash
$ openspec status --change "my-change" --json 2>&1
- Loading change status...
{
"changeName... | fix: suppress ora spinner when --json is used | ## Summary
- Conditionally skip `ora` spinner creation when `--json` flag is passed in `status`, `instructions`, `instructions apply`, and `templates` commands
- Prevents spinner text from leaking to stderr, which broke JSON parsing for AI agents that combine stdout+stderr (Claude Code, Cursor, Windsurf, Copilot)
- Add... | 4df6a4889bc5a0a7f06a0796e8d447f708173c19 | c4829c5bf3e928be371107f5629508c7db7e911f | diff --git a/src/commands/workflow/instructions.ts b/src/commands/workflow/instructions.ts
index 0d501afec..c90ff6a3d 100644
--- a/src/commands/workflow/instructions.ts
+++ b/src/commands/workflow/instructions.ts
@@ -45,7 +45,7 @@ export async function instructionsCommand(
artifactId: string | undefined,
options:... | [
"src/commands/workflow/instructions.ts",
"src/commands/workflow/status.ts",
"src/commands/workflow/templates.ts",
"test/cli-e2e/basic.test.ts",
"test/commands/artifact-workflow.test.ts"
] | [] | diff --git a/test/cli-e2e/basic.test.ts b/test/cli-e2e/basic.test.ts
index 33d045a5b..0d7e46de0 100644
--- a/test/cli-e2e/basic.test.ts
+++ b/test/cli-e2e/basic.test.ts
@@ -26,6 +26,12 @@ async function prepareFixture(fixtureName: string): Promise<string> {
return projectDir;
}
+function expectJsonOnlyOutput(resu... | true |
Fission-AI/OpenSpec | 959 | issue_to_patch | Error while flushing PostHog PostHogFetchNetworkError: Network error while fetching PostHog
Error while flushing PostHog PostHogFetchNetworkError: Network error while fetching PostHog
at retriable (file:///C:/Users/l00011440/AppData/Roaming/... | fix: silence telemetry network errors in firewalled environments | ## Summary
- Wraps PostHog's fetch with `safeTelemetryFetch` that catches all network errors and non-2xx responses, returning a synthetic 204 — PostHog never throws `PostHogFetchNetworkError`
- Disables retries (`fetchRetryCount: 0`), remote config, surveys, and feature flag preloading to eliminate extra network calls;... | 9b5007dbc344335244090574925de3634642adeb | 2872dbf02d10bea1ad8e2a6b9bb275dc4ec1d9e2 | diff --git a/docs/cli.md b/docs/cli.md
index ebbb847eb..ddcdaa0a4 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -920,6 +920,8 @@ openspec completion uninstall
| Variable | Description |
|----------|-------------|
+| `OPENSPEC_TELEMETRY` | Set to `0` to disable telemetry |
+| `DO_NOT_TRACK` | Set to `1` to disable t... | [
"docs/cli.md",
"src/telemetry/index.ts",
"test/telemetry/index.test.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add telemetry vars to the Environment Variables table.**\n\nYou introduced env-based telemetry control here, but the Environment Variables section doesn’t list `OPENSPEC_TELEMETRY` / `DO_NOT_TRACK`. \n\n<details>\n<summary>Suggested docs patch</summary>\n\n`... | diff --git a/test/telemetry/index.test.ts b/test/telemetry/index.test.ts
index ab41dab22..73b050a28 100644
--- a/test/telemetry/index.test.ts
+++ b/test/telemetry/index.test.ts
@@ -22,6 +22,7 @@ describe('telemetry/index', () => {
let tempDir: string;
let originalEnv: NodeJS.ProcessEnv;
let consoleLogSpy: Retu... | true |
Fission-AI/OpenSpec | 959 | comment_to_fix | fix: silence telemetry network errors in firewalled environments | _⚠️ Potential issue_ | _🟡 Minor_
**Add telemetry vars to the Environment Variables table.**
You introduced env-based telemetry control here, but the Environment Variables section doesn’t list `OPENSPEC_TELEMETRY` / `DO_NOT_TRACK`.
<details>
<summary>Suggested docs patch</summary>
```diff
| Variable | Descriptio... | 9b5007dbc344335244090574925de3634642adeb | 2872dbf02d10bea1ad8e2a6b9bb275dc4ec1d9e2 | diff --git a/docs/cli.md b/docs/cli.md
index ebbb847eb..ddcdaa0a4 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -920,6 +920,8 @@ openspec completion uninstall
| Variable | Description |
|----------|-------------|
+| `OPENSPEC_TELEMETRY` | Set to `0` to disable telemetry |
+| `DO_NOT_TRACK` | Set to `1` to disable t... | [
"docs/cli.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add telemetry vars to the Environment Variables table.**\n\nYou introduced env-based telemetry control here, but the Environment Variables section doesn’t list `OPENSPEC_TELEMETRY` / `DO_NOT_TRACK`. \n\n<details>\n<summary>Suggested docs patch</summary>\n\n`... | true | ||
Fission-AI/OpenSpec | 864 | issue_to_patch | feat: add Lingma IDE support to configuration | feat: add Lingma IDE support to configuration
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Introduced Lingma tool integration for command generation and management with automatic formatting, metadata organization, and structured file stora... | afdca0d5dab1aa109cfd8848b2512333ccad60c3 | d24247d82b8615c55c2e128bb1e2a25250129864 | diff --git a/src/core/command-generation/adapters/index.ts b/src/core/command-generation/adapters/index.ts
index 06f7a7ae7..f9094cf5f 100644
--- a/src/core/command-generation/adapters/index.ts
+++ b/src/core/command-generation/adapters/index.ts
@@ -24,6 +24,7 @@ export { kiroAdapter } from './kiro.js';
export { openco... | [
"src/core/command-generation/adapters/index.ts",
"src/core/command-generation/adapters/lingma.ts",
"src/core/command-generation/registry.ts",
"src/core/config.ts",
"src/core/legacy-cleanup.ts"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,528 | issue_to_patch | Bump Microsoft.Windows.CsWin32 from 0.3.275 to 0.3.287 | Updated [Microsoft.Windows.CsWin32](https://github.com/microsoft/CsWin32) from 0.3.275 to 0.3.287.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Windows.CsWin32's releases](https://github.com/microsoft/CsWin32/releases)._
## 0.3.287
## Changes:
### Fixes:
* #1703: CsWin32-generated COM s... | 5400502809386e828457a1224661993884bf7a6d | 656da4de5b3c10570c1d68caef69fb5bfb1663a4 | diff --git a/Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj b/Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj
index 746e10c3de9..48dc79872d2 100644
--- a/Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj
+++ b/Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.cs... | [
"Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj",
"Flow.Launcher.Infrastructure/packages.lock.json",
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"Flow.Launcher.Plugin/packages.lock.json",
"Plugins/Flow.Launcher.Plugin.ProcessKiller/Flow.Launcher.Plugin.ProcessKiller.csproj",
"Plu... | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | issue_to_patch | support open ip url
**Is your feature request related to a problem? Please describe.**
no
**Describe the solution you'd like**
Supporting IP URLs as first-class clickable targets (just like normal domain URLs) seems useful for development and internal network use cases. It may be worth requesting this as an official... | Fixing matching issues in URL plugin | Fixes #4184. A rework of #4185 as it's very tricky to solve all IPv6 related problems so I just leave it.
What's done:
- Private addresses are no longer ignored.
- Test and matching logic refactored.
- IPv6 support ~~(though some edge cases in comment of #4185 are not handled)~~. | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs",
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The OneTimeSetUp uses reflection to set the static Settings field directly, which is a workaround because the Main.Init() method is not called. This approach bypasses the normal initialization flow and creates a testing pattern that doesn't reflect how the plugin actually works. Consider refactori... | true | |
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The OneTimeSetUp uses reflection to set the static Settings field directly, which is a workaround because the Main.Init() method is not called. This approach bypasses the normal initialization flow and creates a testing pattern that doesn't reflect how the plugin actually works. Consider refactoring the Main class to m... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The OneTimeSetUp uses reflection to set the static Settings field directly, which is a workaround because the Main.Init() method is not called. This approach bypasses the normal initialization flow and creates a testing pattern that doesn't reflect how the plugin actually works. Consider refactori... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The code uses `UrlSchemes.Any(scheme => raw.StartsWith(scheme, StringComparison.OrdinalIgnoreCase))` which iterates through the array and performs string comparisons for each scheme. Given that this array only contains 3 elements, the performance impact is minimal. However, for consistency with the original approach an... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The code uses `UrlSchemes.Any(scheme => raw.StartsWith(scheme, StringComparison.OrdinalIgnoreCase))` which iterates through the array and performs string comparisons for each scheme. Given that this array only contains 3 elements, the performance impact is minimal. However, for consistency with th... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The port pattern `:\d{1,5}` allows ports from 1 to 99999, but valid port numbers range from 1 to 65535. This will incorrectly match invalid ports like ":99999" or ":70000". While the original code had the same issue with high ports, changing from `\d{2,5}` to `\d{1,5}` now also allows single-digit ports (which are vali... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The port pattern `:\\d{1,5}` allows ports from 1 to 99999, but valid port numbers range from 1 to 65535. This will incorrectly match invalid ports like \":99999\" or \":70000\". While the original code had the same issue with high ports, changing from `\\d{2,5}` to `\\d{1,5}` now also allows singl... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The negative lookahead `(?!:[0-9])` only applies to the "::1" pattern on line 34, not to the other unbracketed IPv6 patterns (lines 29-33). This means addresses like "2001:db8::1" could be followed by ":8080" and the pattern would try to interpret ":8080" as part of the IPv6 address rather than as a port number, leadin... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The negative lookahead `(?!:[0-9])` only applies to the \"::1\" pattern on line 34, not to the other unbracketed IPv6 patterns (lines 29-33). This means addresses like \"2001:db8::1\" could be followed by \":8080\" and the pattern would try to interpret \":8080\" as part of the IPv6 address rather... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The condition has been inverted from checking if the input IS a URL to checking if it is NOT a URL. While the logic remains correct after the refactoring (early return on non-URL, then return result for URL), the inverted condition combined with the structural change makes the code flow less intuitive. The original str... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The condition has been inverted from checking if the input IS a URL to checking if it is NOT a URL. While the logic remains correct after the refactoring (early return on non-URL, then return result for URL), the inverted condition combined with the structural change makes the code flow less intui... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The UrlSchemes array includes "ftp://" but the protocol check on line 79 uses case-insensitive comparison with these schemes. However, when a URL lacks a recognized scheme, the code on line 81 only adds "http" or "https" based on settings, never "ftp". This creates an inconsistency: FTP URLs without the scheme prefix (... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The UrlSchemes array includes \"ftp://\" but the protocol check on line 79 uses case-insensitive comparison with these schemes. However, when a URL lacks a recognized scheme, the code on line 81 only adds \"http\" or \"https\" based on settings, never \"ftp\". This creates an inconsistency: FTP UR... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The test case expects "fe80:1:2::3:4" to be recognized as a valid URL. However, this is an IPv6 address without brackets, and according to the comment on line 28 of Main.cs, unbracketed IPv6 should only be valid when no port follows. The issue is that "fe80:1:2::3:4" could be ambiguous - the final ":4" could be interpr... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The test case expects \"fe80:1:2::3:4\" to be recognized as a valid URL. However, this is an IPv6 address without brackets, and according to the comment on line 28 of Main.cs, unbracketed IPv6 should only be valid when no port follows. The issue is that \"fe80:1:2::3:4\" could be ambiguous - the f... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | @VictoriousRaptor instead of a massive regex string, would `Uri.TryCreate` work for our scenarios? (Also `IPAddress.TryParse` for IPs) | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "@VictoriousRaptor instead of a massive regex string, would `Uri.TryCreate` work for our scenarios? (Also `IPAddress.TryParse` for IPs)",
"path": "Plugins/Flow.Launcher.Plugin.Url/Main.cs",
"hunk": "@@ -15,19 +16,28 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | _⚠️ Potential issue_ | _🟠 Major_
**`decimal.TryParse` is culture-sensitive — may fail to filter plain numbers in non-dot-decimal locales.**
`decimal.TryParse(input, out _)` uses `CultureInfo.CurrentCulture`. In locales where the decimal separator is a comma (e.g., `de-DE`), an input like `"1.2345"` won't parse as a ... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**`decimal.TryParse` is culture-sensitive — may fail to filter plain numbers in non-dot-decimal locales.**\n\n`decimal.TryParse(input, out _)` uses `CultureInfo.CurrentCulture`. In locales where the decimal separator is a comma (e.g., `de-DE`), an input like `\... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | _⚠️ Potential issue_ | _🟡 Minor_
**IPv6 "any" address (`::`) is not excluded, unlike IPv4 `0.0.0.0`.**
Line 88 only checks `IPAddress.Any` (i.e., `0.0.0.0`). The IPv6 equivalent `IPAddress.IPv6Any` (`::`) is not excluded, so typing `::` would be recognized as a valid URL. The same gap exists on line 111. Consider ad... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**IPv6 \"any\" address (`::`) is not excluded, unlike IPv4 `0.0.0.0`.**\n\nLine 88 only checks `IPAddress.Any` (i.e., `0.0.0.0`). The IPv6 equivalent `IPAddress.IPv6Any` (`::`) is not excluded, so typing `::` would be recognized as a valid URL. The same gap exi... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The removal of the NUnit.Framework.Legacy import and the switch from ClassicAssert to Assert.That deviates from the established testing conventions in this codebase. Other test files in the repository consistently use ClassicAssert (e.g., CalculatorTest.cs, FuzzyMatcherTest.cs, ExplorerTest.cs). Please restore the NUni... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The removal of the NUnit.Framework.Legacy import and the switch from ClassicAssert to Assert.That deviates from the established testing conventions in this codebase. Other test files in the repository consistently use ClassicAssert (e.g., CalculatorTest.cs, FuzzyMatcherTest.cs, ExplorerTest.cs). P... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The Split('/')[0] approach to extract the IP part before path is insufficient for URLs with ports. For example, "192.168.1.1:8080/path" would extract "192.168.1.1:8080", which IPEndPoint.TryParse can handle, but "192.168.1.1/path" would extract "192.168.1.1" correctly. However, the issue is with query parameters or fra... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The Split('/')[0] approach to extract the IP part before path is insufficient for URLs with ports. For example, \"192.168.1.1:8080/path\" would extract \"192.168.1.1:8080\", which IPEndPoint.TryParse can handle, but \"192.168.1.1/path\" would extract \"192.168.1.1\" correctly. However, the issue i... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The test cases should include scenarios with query parameters and fragments to ensure the URL validation handles them correctly. For example, add test cases like "192.168.1.1?query=value", "localhost:8080?test=123", "example.com#fragment", etc. These are common URL patterns that should be supported. | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The test cases should include scenarios with query parameters and fragments to ensure the URL validation handles them correctly. For example, add test cases like \"192.168.1.1?query=value\", \"localhost:8080?test=123\", \"example.com#fragment\", etc. These are common URL patterns that should be su... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | While the comment states "Pattern excludes 0.0.0.0", it would be more accurate to say "Implementation excludes 0.0.0.0" since the validation is no longer pattern-based (regex) but rather uses IPAddress.Any comparison.
```suggestion
[TestCase("0.0.0.0")] // Implementation excludes 0.0.0.0 via IPAddress.Any
``` | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "While the comment states \"Pattern excludes 0.0.0.0\", it would be more accurate to say \"Implementation excludes 0.0.0.0\" since the validation is no longer pattern-based (regex) but rather uses IPAddress.Any comparison.\n```suggestion\n [TestCase(\"0.0.0.0\")] // Implementation excludes 0... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The decimal.TryParse check at line 83 is intended to exclude numbers like "1.2345", but this check has unintended side effects. For example, "192.168.1.1" would successfully parse as a decimal in many cultures that use different decimal separators, potentially causing valid IP addresses to be rejected. Additionally, th... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The decimal.TryParse check at line 83 is intended to exclude numbers like \"1.2345\", but this check has unintended side effects. For example, \"192.168.1.1\" would successfully parse as a decimal in many cultures that use different decimal separators, potentially causing valid IP addresses to be ... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | Missing test coverage for URLs with paths. The current test cases don't include scenarios like "example.com/path", "192.168.1.1/path/to/resource", or "localhost:8080/api/endpoint". These are common patterns that should be validated to ensure the path handling works correctly in both the validation logic and the Action ... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "Missing test coverage for URLs with paths. The current test cases don't include scenarios like \"example.com/path\", \"192.168.1.1/path/to/resource\", or \"localhost:8080/api/endpoint\". These are common patterns that should be validated to ensure the path handling works correctly in both the vali... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The test cases include uppercase variants (HTTP://EXAMPLE.COM, HTTPS://EXAMPLE.COM, EXAMPLE.COM, LOCALHOST) which is good. However, it would be beneficial to also test mixed case scenarios and ensure that the validation and URL opening work correctly regardless of case. The code uses StringComparison.OrdinalIgnoreCase ... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The test cases include uppercase variants (HTTP://EXAMPLE.COM, HTTPS://EXAMPLE.COM, EXAMPLE.COM, LOCALHOST) which is good. However, it would be beneficial to also test mixed case scenarios and ensure that the validation and URL opening work correctly regardless of case. The code uses StringCompari... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The TLD validation logic requires that the TLD contains only letters and is at least 2 characters long. However, this will incorrectly reject valid domains with numeric TLDs or newer generic TLDs. While pure numeric TLDs are rare, some valid domains might have alphanumeric characters in their TLD, and this validation i... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "The TLD validation logic requires that the TLD contains only letters and is at least 2 characters long. However, this will incorrectly reject valid domains with numeric TLDs or newer generic TLDs. While pure numeric TLDs are rare, some valid domains might have alphanumeric characters in their TLD,... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The test cases for bare IPv6 addresses (lines 45-47) test that these inputs are validated as URLs, but there's no test to verify that these URLs can actually be opened correctly. Given the bug in the Action method where bare IPv6 addresses are not wrapped in brackets when the protocol is prepended, these test cases wil... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The test cases for bare IPv6 addresses (lines 45-47) test that these inputs are validated as URLs, but there's no test to verify that these URLs can actually be opened correctly. Given the bug in the Action method where bare IPv6 addresses are not wrapped in brackets when the protocol is prepended... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | The test cases for invalid URLs should include more edge cases to ensure robustness. Consider adding tests for: URLs with spaces (e.g., "example .com"), URLs with invalid characters, extremely long TLDs, domains starting with dots (e.g., "..example.com"), multiple consecutive dots (e.g., "example..com"), and malformed ... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
index 0dd1fe4895a..e17070b1284 100644
--- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
+++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs
@@ -1,33 +1,95 @@
using NUnit.Framework;
-using NUnit.Framework.Legacy;
usin... | [
"Flow.Launcher.Test/Plugins/UrlPluginTest.cs"
] | [
{
"comment": "The test cases for invalid URLs should include more edge cases to ensure robustness. Consider adding tests for: URLs with spaces (e.g., \"example .com\"), URLs with invalid characters, extremely long TLDs, domains starting with dots (e.g., \"..example.com\"), multiple consecutive dots (e.g., \"exa... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | <!-- metadata:{"confidence":9,"steps":[]} -->
P1: `decimal.TryParse` is culture-sensitive and uses `CultureInfo.CurrentCulture` by default. In locales where the decimal separator is a comma (e.g., `de-DE`), an input like `"1.2345"` won't parse as a decimal, will fall through to `IPEndPoint.TryParse`, and .NET will inte... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9,\"steps\":[]} -->\nP1: `decimal.TryParse` is culture-sensitive and uses `CultureInfo.CurrentCulture` by default. In locales where the decimal separator is a comma (e.g., `de-DE`), an input like `\"1.2345\"` won't parse as a decimal, will fall through to `IPEndPoint.... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | <!-- metadata:{"confidence":8,"steps":[]} -->
P2: Same issue as the `IPEndPoint` check above: the IPv6 "any" address (`::`) is not excluded here either. `IPAddress.IPv6Any` should also be rejected to maintain symmetry with the `0.0.0.0` exclusion.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if thi... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8,\"steps\":[]} -->\nP2: Same issue as the `IPEndPoint` check above: the IPv6 \"any\" address (`::`) is not excluded here either. `IPAddress.IPv6Any` should also be rejected to maintain symmetry with the `0.0.0.0` exclusion.\n\n<details>\n<summary>Prompt for AI agents... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | <!-- metadata:{"confidence":8,"steps":[]} -->
P2: IPv6 "any" address (`::`) is not excluded, unlike its IPv4 counterpart `0.0.0.0`. Typing `::` would be incorrectly recognized as a valid URL. Add a check for `IPAddress.IPv6Any` for consistency.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this i... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8,\"steps\":[]} -->\nP2: IPv6 \"any\" address (`::`) is not excluded, unlike its IPv4 counterpart `0.0.0.0`. Typing `::` would be incorrectly recognized as a valid URL. Add a check for `IPAddress.IPv6Any` for consistency.\n\n<details>\n<summary>Prompt for AI agents</s... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | <!-- metadata:{"confidence":6,"steps":[]} -->
P2: Using InvariantCulture here ignores locale-specific decimal separators, so numeric inputs in comma-based cultures can slip through as URLs. Use the current culture to keep the numeric exclusion consistent with user input.
<details>
<summary>Prompt for AI agents</summar... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":6,\"steps\":[]} -->\nP2: Using InvariantCulture here ignores locale-specific decimal separators, so numeric inputs in comma-based cultures can slip through as URLs. Use the current culture to keep the numeric exclusion consistent with user input.\n\n<details>\n<summar... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | <!-- metadata:{"confidence":7,"steps":[]} -->
P2: IPv6 hosts with a path/query are not bracketed, so inputs that pass IsURL (e.g., `2001:db8::1/path`) still produce invalid URLs like `http://2001:db8::1/path`. Bracket the IPv6 host portion even when a path/query is present.
<details>
<summary>Prompt for AI agents</sum... | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":7,\"steps\":[]} -->\nP2: IPv6 hosts with a path/query are not bracketed, so inputs that pass IsURL (e.g., `2001:db8::1/path`) still produce invalid URLs like `http://2001:db8::1/path`. Bracket the IPv6 host portion even when a path/query is present.\n\n<details>\n<sum... | true | ||
Flow-Launcher/Flow.Launcher | 4,191 | comment_to_fix | Fixing matching issues in URL plugin | Ideally this should be based on UrlSchemes instead of repeating it here | 5400502809386e828457a1224661993884bf7a6d | 80d4e30af6a1eb92ae8106ebac620f312274fab6 | diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
index c40b278e596..60a6eec92f1 100644
--- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs
@@ -1,6 +1,7 @@
-using System;
+using System;
using System.Collections.Generic;
-using Sy... | [
"Plugins/Flow.Launcher.Plugin.Url/Main.cs"
] | [
{
"comment": "Ideally this should be based on UrlSchemes instead of repeating it here",
"path": "Plugins/Flow.Launcher.Plugin.Url/Main.cs",
"hunk": "@@ -104,19 +83,68 @@ private static string GetHttpPreference()\n \n public bool IsURL(string raw)\n {\n- raw = raw.ToLower();\n+... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | issue_to_patch | [Feature Request] Keyword assignment to multiple plugins.
**Is your feature request related to a problem? Please describe.**
Allow multi plugin keywords. Pretty much allow a keyword to be assigned to more than one plugin rather than just to 1 plugin.
**Describe the solution you'd like**
Example use is. Favorites + ... | Support Assignment of One Action Keyword with Multiple Plugins | # CHANGES
* Allows multiple plugins to share the same action keyword, removing the one-to-one limitation and improving plugin flexibility.
* Updated `IPublicAPI` documentation and implementation to clarify that `ActionKeywordAssigned` is now only for compatibility with old plugins, and suppressed obsolete warnings in... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs",
"Flow.Launcher.Core/Plugin/QueryBuilder.cs",
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs",
"Flow.Launcher.Test/QueryBuilderTest.cs",
"Flow.Launcher/PublicAPIInstance.cs",
"Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":7,\"steps\":[]} -->\nP2: `plugins` is a mutable List<PluginPair> that is modified under locks elsewhere, but here it’s enumerated without synchronization. Concurrent updates can throw during query execution. Take a snapshot of the list under the same lock before filte... | true | |
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | <!-- metadata:{"confidence":7,"steps":[]} -->
P2: `plugins` is a mutable List<PluginPair> that is modified under locks elsewhere, but here it’s enumerated without synchronization. Concurrent updates can throw during query execution. Take a snapshot of the list under the same lock before filtering.
<details>
<summary>P... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":7,\"steps\":[]} -->\nP2: `plugins` is a mutable List<PluginPair> that is modified under locks elsewhere, but here it’s enumerated without synchronization. Concurrent updates can throw during query execution. Take a snapshot of the list under the same lock before filte... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | `GetNonGlobalPlugins` returns `_nonGlobalPlugins.ToDictionary()` but the values are mutable `List<PluginPair>` instances shared with the internal dictionary. This exposes internal state to callers and makes concurrent enumeration/modification issues more likely. Prefer returning a deep-copied snapshot (e.g., `ToList()`... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "`GetNonGlobalPlugins` returns `_nonGlobalPlugins.ToDictionary()` but the values are mutable `List<PluginPair>` instances shared with the internal dictionary. This exposes internal state to callers and makes concurrent enumeration/modification issues more likely. Prefer returning a deep-copied snap... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | After removing a plugin ID from the per-keyword list, the keyword entry is left in `_nonGlobalPlugins` even when the list becomes empty. Over time (uninstalls/keyword changes) this can leave lots of empty lists and unnecessary keys. Consider removing the dictionary key when the list becomes empty (ideally while still h... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "After removing a plugin ID from the per-keyword list, the keyword entry is left in `_nonGlobalPlugins` even when the list becomes empty. Over time (uninstalls/keyword changes) this can leave lots of empty lists and unnecessary keys. Consider removing the dictionary key when the list becomes empty ... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | Uninstall removes the plugin from each keyword’s `List<PluginPair>` but never removes keyword entries that become empty. This can accumulate stale keys and (depending on call paths) may keep treating an action keyword as “present” even though it resolves to no plugins. Consider `TryRemove`-ing keys whose lists become e... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "Uninstall removes the plugin from each keyword’s `List<PluginPair>` but never removes keyword entries that become empty. This can accumulate stale keys and (depending on call paths) may keep treating an action keyword as “present” even though it resolves to no plugins. Consider `TryRemove`-ing key... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | The new `<remarks>` text has grammatical issues (e.g., “supports to one action keyword to multiple plugins”) and the surrounding docs still describe this as a true assignment check, but the implementation now always returns false for compatibility. Please reword the remarks and adjust the summary/returns text so plugin... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
index 62ed58930e5..304f4d5c00e 100644
--- a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
+++ b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
@@ -302,6 +302,11 @@ public interface IPublicAPI
/// </summary... | [
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs"
] | [
{
"comment": "The new `<remarks>` text has grammatical issues (e.g., “supports to one action keyword to multiple plugins”) and the surrounding docs still describe this as a true assignment check, but the implementation now always returns false for compatibility. Please reword the remarks and adjust the summary/... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | `Build` now takes `Dictionary<string, List<PluginPair>>`, but the NUnit tests still construct `Dictionary<string, PluginPair>` (e.g., `Flow.Launcher.Test/QueryBuilderTest.cs`), which will fail to compile. Either update the tests to the new type (wrapping the `PluginPair` in a list) or add an overload that accepts the o... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/QueryBuilder.cs b/Flow.Launcher.Core/Plugin/QueryBuilder.cs
index aac620cce64..c9b8b134134 100644
--- a/Flow.Launcher.Core/Plugin/QueryBuilder.cs
+++ b/Flow.Launcher.Core/Plugin/QueryBuilder.cs
@@ -1,12 +1,13 @@
using System;
using System.Collections.Generic;
+using System.Linq... | [
"Flow.Launcher.Core/Plugin/QueryBuilder.cs"
] | [
{
"comment": "`Build` now takes `Dictionary<string, List<PluginPair>>`, but the NUnit tests still construct `Dictionary<string, PluginPair>` (e.g., `Flow.Launcher.Test/QueryBuilderTest.cs`), which will fail to compile. Either update the tests to the new type (wrapping the `PluginPair` in a list) or add an overl... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | `pluginPairs.Any(...)` enumerates a mutable `List<PluginPair>` coming from `_nonGlobalPlugins`. Since that list can be modified concurrently (e.g., via Add/RemoveActionKeyword or uninstall), this can throw during enumeration. Consider taking a snapshot under lock (or switching values to an immutable/thread-safe collect... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/QueryBuilder.cs b/Flow.Launcher.Core/Plugin/QueryBuilder.cs
index aac620cce64..c9b8b134134 100644
--- a/Flow.Launcher.Core/Plugin/QueryBuilder.cs
+++ b/Flow.Launcher.Core/Plugin/QueryBuilder.cs
@@ -1,12 +1,13 @@
using System;
using System.Collections.Generic;
+using System.Linq... | [
"Flow.Launcher.Core/Plugin/QueryBuilder.cs"
] | [
{
"comment": "`pluginPairs.Any(...)` enumerates a mutable `List<PluginPair>` coming from `_nonGlobalPlugins`. Since that list can be modified concurrently (e.g., via Add/RemoveActionKeyword or uninstall), this can throw during enumeration. Consider taking a snapshot under lock (or switching values to an immutab... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | `plugins.Where(...)` enumerates a shared `List<PluginPair>` without synchronization. Because the list is mutated under `lock(plugins)` elsewhere, enumerating without holding the same lock can still throw `InvalidOperationException` (collection modified). Snapshot the list under the lock (or use an immutable/thread-safe... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "`plugins.Where(...)` enumerates a shared `List<PluginPair>` without synchronization. Because the list is mutated under `lock(plugins)` elsewhere, enumerating without holding the same lock can still throw `InvalidOperationException` (collection modified). Snapshot the list under the lock (or use an... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | _⚠️ Potential issue_ | _🟠 Major_
**Filter disabled plugins before returning keyword matches.**
With shared keywords, this now returns disabled plugins too. If one plugin under the keyword is enabled, disabled siblings can still be queried.
<details>
<summary>🐛 Proposed fix</summary>
```diff
- var valid... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Filter disabled plugins before returning keyword matches.**\n\nWith shared keywords, this now returns disabled plugins too. If one plugin under the keyword is enabled, disabled siblings can still be queried.\n\n<details>\n<summary>🐛 Proposed fix</summary>\n\... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Verify read/write paths for non-global keyword lists and lock coverage.
rg -n -C2 "_nonGlobalPlugins|pluginPairs\.Any|plugins\.Where|ToDictionary\(\)|lock \(existing\)|lock \(plugins\)|RemoveAl... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify read/write paths for non-global keyword lists and lock coverage.\nrg -n -C2 \"_nonGlobalPlugins|pluginPairs\\.Any|plugins\\.Where|ToDictionary\\(\\)|lock \... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | _⚠️ Potential issue_ | _🟠 Major_
**Prevent metadata keyword duplication drift.**
The dictionary list avoids duplicate plugin entries, but metadata still appends duplicate keywords. Repeated adds can leave stale metadata state after remove.
<details>
<summary>🛠️ Proposed fix</summary>
```diff
- plugin.M... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Prevent metadata keyword duplication drift.**\n\nThe dictionary list avoids duplicate plugin entries, but metadata still appends duplicate keywords. Repeated adds can leave stale metadata state after remove.\n\n<details>\n<summary>🛠️ Proposed fix</summary>\n... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | _⚠️ Potential issue_ | _🟡 Minor_
**Clarify the compatibility remark text.**
The current remark text is grammatically incorrect and still unclear. Please explicitly state legacy-only intent in polished wording.
<details>
<summary>✍️ Suggested doc wording</summary>
```diff
- /// Flow now supports to one actio... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
index 62ed58930e5..304f4d5c00e 100644
--- a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
+++ b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
@@ -302,6 +302,11 @@ public interface IPublicAPI
/// </summary... | [
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Clarify the compatibility remark text.**\n\nThe current remark text is grammatically incorrect and still unclear. Please explicitly state legacy-only intent in polished wording.\n\n<details>\n<summary>✍️ Suggested doc wording</summary>\n\n```diff\n- //... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Description: Find all call sites of QueryBuilder.Build to verify how nonGlobalPlugins is obtained
echo "=== Searching for QueryBuilder.Build call sites ==="
rg -n -A 3 'QueryBuilder\.Build\s*\... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/QueryBuilder.cs b/Flow.Launcher.Core/Plugin/QueryBuilder.cs
index aac620cce64..c9b8b134134 100644
--- a/Flow.Launcher.Core/Plugin/QueryBuilder.cs
+++ b/Flow.Launcher.Core/Plugin/QueryBuilder.cs
@@ -1,12 +1,13 @@
using System;
using System.Collections.Generic;
+using System.Linq... | [
"Flow.Launcher.Core/Plugin/QueryBuilder.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Find all call sites of QueryBuilder.Build to verify how nonGlobalPlugins is obtained\n\necho \"=== Searching for QueryBuilder.Build call sites ===\"\... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | The test `ExclusivePluginQueryIgnoreDisabledTest` is supposed to verify that disabled plugins are ignored during query building. However, the `Disabled` property is not set to `true` in the plugin metadata. In the previous version of this test, the plugin was created with `Disabled = true`, but this property assignment... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Test/QueryBuilderTest.cs b/Flow.Launcher.Test/QueryBuilderTest.cs
index 0ede781f8ab..3a708ea5690 100644
--- a/Flow.Launcher.Test/QueryBuilderTest.cs
+++ b/Flow.Launcher.Test/QueryBuilderTest.cs
@@ -11,9 +11,9 @@ public class QueryBuilderTest
[Test]
public void ExclusivePlugi... | [
"Flow.Launcher.Test/QueryBuilderTest.cs"
] | [
{
"comment": "The test `ExclusivePluginQueryIgnoreDisabledTest` is supposed to verify that disabled plugins are ignored during query building. However, the `Disabled` property is not set to `true` in the plugin metadata. In the previous version of this test, the plugin was created with `Disabled = true`, but th... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | There's a potential race condition in the uninstall logic. The code uses `TryRemove(entry.Key, out var __)` which removes the entry based only on the key. Between the time when the list is emptied (line 1088) and removed from the dictionary (line 1092), another thread could execute `AddActionKeyword` and create a new l... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "There's a potential race condition in the uninstall logic. The code uses `TryRemove(entry.Key, out var __)` which removes the entry based only on the key. Between the time when the list is emptied (line 1088) and removed from the dictionary (line 1092), another thread could execute `AddActionKeywo... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | The `ActionKeywordAssigned` method in the `IPublicAPI` interface should be marked with the `[Obsolete]` attribute to match the implementation in `PluginManager.ActionKeywordRegistered` (line 742) and to provide compile-time warnings to plugin developers. The remarks already document that the method is for legacy compat... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
index 62ed58930e5..304f4d5c00e 100644
--- a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
+++ b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
@@ -302,6 +302,11 @@ public interface IPublicAPI
/// </summary... | [
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs"
] | [
{
"comment": "The `ActionKeywordAssigned` method in the `IPublicAPI` interface should be marked with the `[Obsolete]` attribute to match the implementation in `PluginManager.ActionKeywordRegistered` (line 742) and to provide compile-time warnings to plugin developers. The remarks already document that the metho... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | <!-- metadata:{"confidence":8,"steps":[{"text":"","toolCalls":[{"toolName":"bash","input":{"command":"rg -n ActionKeywordRegistered --glob '!node_modules/**' /mnt/workspace"}},{"toolName":"bash","input":{"command":"rg -n GetNonGlobalPlugins --glob '!node_modules/**' /mnt/workspace"}}]},{"text":"","toolCalls":[{"toolNam... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8,\"steps\":[{\"text\":\"\",\"toolCalls\":[{\"toolName\":\"bash\",\"input\":{\"command\":\"rg -n ActionKeywordRegistered --glob '!node_modules/**' /mnt/workspace\"}},{\"toolName\":\"bash\",\"input\":{\"command\":\"rg -n GetNonGlobalPlugins --glob '!node_modules/**' /m... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | <!-- metadata:{"confidence":9,"steps":[{"text":"","toolCalls":[{"toolName":"readFile","input":{"filePath":"Flow.Launcher.Core/Plugin/PluginManager.cs"}}]},{"text":"","toolCalls":[{"toolName":"bash","input":{"command":"rg -n \"GetNonGlobalPlugins|TryGetNonGlobalPlugins\" --glob '!node_modules/**'"}}]},{"text":"","toolCa... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Core/Plugin/PluginManager.cs b/Flow.Launcher.Core/Plugin/PluginManager.cs
index 78464ddc9ba..56abfb251e1 100644
--- a/Flow.Launcher.Core/Plugin/PluginManager.cs
+++ b/Flow.Launcher.Core/Plugin/PluginManager.cs
@@ -30,7 +30,7 @@ public static class PluginManager
private static readonl... | [
"Flow.Launcher.Core/Plugin/PluginManager.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9,\"steps\":[{\"text\":\"\",\"toolCalls\":[{\"toolName\":\"readFile\",\"input\":{\"filePath\":\"Flow.Launcher.Core/Plugin/PluginManager.cs\"}}]},{\"text\":\"\",\"toolCalls\":[{\"toolName\":\"bash\",\"input\":{\"command\":\"rg -n \\\"GetNonGlobalPlugins|TryGetNonGlobal... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | It would be nice if a test was added here that used multiple plugins with the same keyword
For example one is disabled and the other is enabled | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Flow.Launcher.Test/QueryBuilderTest.cs b/Flow.Launcher.Test/QueryBuilderTest.cs
index 0ede781f8ab..3a708ea5690 100644
--- a/Flow.Launcher.Test/QueryBuilderTest.cs
+++ b/Flow.Launcher.Test/QueryBuilderTest.cs
@@ -11,9 +11,9 @@ public class QueryBuilderTest
[Test]
public void ExclusivePlugi... | [
"Flow.Launcher.Test/QueryBuilderTest.cs"
] | [
{
"comment": "It would be nice if a test was added here that used multiple plugins with the same keyword\nFor example one is disabled and the other is enabled",
"path": "Flow.Launcher.Test/QueryBuilderTest.cs",
"hunk": "",
"resolving_sha": "0865fa6a34a9b5cc5762f4b42f158a8f5520a675",
"resolving_d... | true | ||
Flow-Launcher/Flow.Launcher | 4,295 | comment_to_fix | Support Assignment of One Action Keyword with Multiple Plugins | <!-- cubic:v=b87cf62c-e8c7-4b02-bc44-93c49e00e562 -->
<!-- cubic:review-run=a94f7cc5-b63d-4649-9bf9-54d829050988 -->
<!-- metadata:{"confidence":6} -->
P2: Adding plugins to each keyword list without deduplication can create duplicate results when a plugin contains repeated action keywords.
<details>
<summary>Prompt f... | 60a8cba25d1adbb51abaeccbd33a70ed3ac829b9 | 0865fa6a34a9b5cc5762f4b42f158a8f5520a675 | diff --git a/Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs b/Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs
index 503d82cc30a..631d3daee49 100644
--- a/Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs
@@ -24,7 +24,8 @@ private static List<Resul... | [
"Plugins/Flow.Launcher.Plugin.PluginIndicator/Main.cs"
] | [
{
"comment": "<!-- cubic:v=b87cf62c-e8c7-4b02-bc44-93c49e00e562 -->\n<!-- cubic:review-run=a94f7cc5-b63d-4649-9bf9-54d829050988 -->\n<!-- metadata:{\"confidence\":6} -->\nP2: Adding plugins to each keyword list without deduplication can create duplicate results when a plugin contains repeated action keywords.\n... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.