repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Flow-Launcher/Flow.Launcher | 4,525 | issue_to_patch | Bump Microsoft.Data.Sqlite from 10.0.8 to 10.0.9 | Updated [Microsoft.Data.Sqlite](https://github.com/dotnet/dotnet) from 10.0.8 to 10.0.9.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Data.Sqlite's releases](https://github.com/dotnet/dotnet/releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://... | 06459c03fb840e75ec0c3f8cb57995962da0292a | 85b791501a8ed504668c462988fe7ddadb9a60fb | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index cac59e4fee4..336fde569a3 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,520 | issue_to_patch | BUG: NullReferenceException in Win32Helper.IsForegroundWindowFullscreen
### Checks
- [ ] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
Flow Launcher version: 2.1... | Fix possible null issues in Win32Helper.IsForegroundWindowFullscreen function | Fix #4494
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Hardened Win32Helper.IsForegroundWindowFullscreen with null checks and stricter desktop hierarchy checks to avoid crashes and false fullscreen detections. Returns false when monitor info is missing; only treats the desktop as ac... | eb3da1edb942983c14b7c78a4d50dee368c23002 | 82a37427603af7ec1b268e0c7a84d8284e553a3a | diff --git a/Flow.Launcher.Infrastructure/Win32Helper.cs b/Flow.Launcher.Infrastructure/Win32Helper.cs
index feafcfcdaa0..8993caf5266 100644
--- a/Flow.Launcher.Infrastructure/Win32Helper.cs
+++ b/Flow.Launcher.Infrastructure/Win32Helper.cs
@@ -292,18 +292,27 @@ public static unsafe bool IsForegroundWindowFullscreen()
... | [
"Flow.Launcher.Infrastructure/Win32Helper.cs"
] | [
{
"comment": "The added `hWndDesktop == HWND.Null` early return likely changes behavior: failing to find `SHELLDLL_DefView` doesn’t necessarily mean the foreground WorkerW/Progman window isn’t fullscreen; it can also mean it isn’t the desktop icon host. Consider only applying the FolderView check when the inter... | true | |
Flow-Launcher/Flow.Launcher | 4,520 | comment_to_fix | Fix possible null issues in Win32Helper.IsForegroundWindowFullscreen function | The added `hWndDesktop == HWND.Null` early return likely changes behavior: failing to find `SHELLDLL_DefView` doesn’t necessarily mean the foreground WorkerW/Progman window isn’t fullscreen; it can also mean it isn’t the desktop icon host. Consider only applying the FolderView check when the intermediate handle is foun... | eb3da1edb942983c14b7c78a4d50dee368c23002 | 82a37427603af7ec1b268e0c7a84d8284e553a3a | diff --git a/Flow.Launcher.Infrastructure/Win32Helper.cs b/Flow.Launcher.Infrastructure/Win32Helper.cs
index feafcfcdaa0..8993caf5266 100644
--- a/Flow.Launcher.Infrastructure/Win32Helper.cs
+++ b/Flow.Launcher.Infrastructure/Win32Helper.cs
@@ -292,18 +292,27 @@ public static unsafe bool IsForegroundWindowFullscreen()
... | [
"Flow.Launcher.Infrastructure/Win32Helper.cs"
] | [
{
"comment": "The added `hWndDesktop == HWND.Null` early return likely changes behavior: failing to find `SHELLDLL_DefView` doesn’t necessarily mean the foreground WorkerW/Progman window isn’t fullscreen; it can also mean it isn’t the desktop icon host. Consider only applying the FolderView check when the inter... | true | ||
Flow-Launcher/Flow.Launcher | 4,520 | comment_to_fix | Fix possible null issues in Win32Helper.IsForegroundWindowFullscreen function | If `GetNearestDisplayMonitor` can return null (as its XML doc suggests), returning `false` here may cause fullscreen apps to be misdetected and hotkeys to fire unexpectedly. Consider falling back to `GetPrimaryDisplayMonitor()` (or another reasonable default) before giving up. | eb3da1edb942983c14b7c78a4d50dee368c23002 | 82a37427603af7ec1b268e0c7a84d8284e553a3a | diff --git a/Flow.Launcher.Infrastructure/Win32Helper.cs b/Flow.Launcher.Infrastructure/Win32Helper.cs
index feafcfcdaa0..8993caf5266 100644
--- a/Flow.Launcher.Infrastructure/Win32Helper.cs
+++ b/Flow.Launcher.Infrastructure/Win32Helper.cs
@@ -292,18 +292,27 @@ public static unsafe bool IsForegroundWindowFullscreen()
... | [
"Flow.Launcher.Infrastructure/Win32Helper.cs"
] | [
{
"comment": "If `GetNearestDisplayMonitor` can return null (as its XML doc suggests), returning `false` here may cause fullscreen apps to be misdetected and hotkeys to fire unexpectedly. Consider falling back to `GetPrimaryDisplayMonitor()` (or another reasonable default) before giving up.",
"path": "Flow.... | true | ||
Flow-Launcher/Flow.Launcher | 4,520 | comment_to_fix | Fix possible null issues in Win32Helper.IsForegroundWindowFullscreen function | <!-- cubic:v=24d599b5-824b-44e3-80eb-41dddad57d68 -->
<!-- cubic:review-run=abdb0233-073f-4b11-9e2c-2d3ca9af3c19 -->
<!-- metadata:{"confidence":8} -->
P1: Returning `false` here when `SHELLDLL_DefView` is not found changes the previous fall-through behavior. A Progman/WorkerW window that lacks `SHELLDLL_DefView` (e.g.... | eb3da1edb942983c14b7c78a4d50dee368c23002 | 82a37427603af7ec1b268e0c7a84d8284e553a3a | diff --git a/Flow.Launcher.Infrastructure/Win32Helper.cs b/Flow.Launcher.Infrastructure/Win32Helper.cs
index feafcfcdaa0..8993caf5266 100644
--- a/Flow.Launcher.Infrastructure/Win32Helper.cs
+++ b/Flow.Launcher.Infrastructure/Win32Helper.cs
@@ -292,18 +292,27 @@ public static unsafe bool IsForegroundWindowFullscreen()
... | [
"Flow.Launcher.Infrastructure/Win32Helper.cs"
] | [
{
"comment": "<!-- cubic:v=24d599b5-824b-44e3-80eb-41dddad57d68 -->\n<!-- cubic:review-run=abdb0233-073f-4b11-9e2c-2d3ca9af3c19 -->\n<!-- metadata:{\"confidence\":8} -->\nP1: Returning `false` here when `SHELLDLL_DefView` is not found changes the previous fall-through behavior. A Progman/WorkerW window that lac... | true | ||
Flow-Launcher/Flow.Launcher | 4,519 | issue_to_patch | BUG: Incorrect language on startup when using system
### Checks
- [x] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
In [Internationalization.InitSystemLanguageCo... | Fix incorrect system language | Fix #4518
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Ensure system language detection stops on the first match to prevent overwriting and select the correct language. Fixes incorrect language selection in some cases (issue #4518).
- **Summary of changes**
- Changed: Added an ea... | 447fbea4882b7d1df9bf6c510752dc236a30a115 | 97218046a1d7ad214534173fa3ec2740c396f0d6 | diff --git a/Flow.Launcher.Core/Resource/Internationalization.cs b/Flow.Launcher.Core/Resource/Internationalization.cs
index c13fb5c0be7..48543c9c6f2 100644
--- a/Flow.Launcher.Core/Resource/Internationalization.cs
+++ b/Flow.Launcher.Core/Resource/Internationalization.cs
@@ -59,6 +59,7 @@ public static void InitSystem... | [
"Flow.Launcher.Core/Resource/Internationalization.cs"
] | [
{
"comment": "<!-- cubic:v=b35d286e-7b71-45f3-a690-55bfb2ad0440 -->\n<!-- cubic:review-run=5258aae5-34f4-429e-afd4-440dfcbf3262 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Early return on first partial culture match can select a generic language code before a later exact locale match (e.g., `sr` before `sr-C... | true | |
Flow-Launcher/Flow.Launcher | 4,519 | comment_to_fix | Fix incorrect system language | <!-- cubic:v=b35d286e-7b71-45f3-a690-55bfb2ad0440 -->
<!-- cubic:review-run=5258aae5-34f4-429e-afd4-440dfcbf3262 -->
<!-- metadata:{"confidence":8} -->
P2: Early return on first partial culture match can select a generic language code before a later exact locale match (e.g., `sr` before `sr-Cyrl-RS`).
<details>
<summa... | 447fbea4882b7d1df9bf6c510752dc236a30a115 | 97218046a1d7ad214534173fa3ec2740c396f0d6 | diff --git a/Flow.Launcher.Core/Resource/Internationalization.cs b/Flow.Launcher.Core/Resource/Internationalization.cs
index c13fb5c0be7..48543c9c6f2 100644
--- a/Flow.Launcher.Core/Resource/Internationalization.cs
+++ b/Flow.Launcher.Core/Resource/Internationalization.cs
@@ -59,6 +59,7 @@ public static void InitSystem... | [
"Flow.Launcher.Core/Resource/Internationalization.cs"
] | [
{
"comment": "<!-- cubic:v=b35d286e-7b71-45f3-a690-55bfb2ad0440 -->\n<!-- cubic:review-run=5258aae5-34f4-429e-afd4-440dfcbf3262 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Early return on first partial culture match can select a generic language code before a later exact locale match (e.g., `sr` before `sr-C... | true | ||
Flow-Launcher/Flow.Launcher | 4,501 | issue_to_patch | Move window titlebar logic and ui to new CustomWindowTitleBar | ## Summary
- Replaces the duplicated titlebar xaml ui and button logic with a simple configurable drop in user control.
- This means related changes such as the alt-tab bug fix can be applied cleanly to all windows.
- Replicates all existing behavior by allowing button handling overrides or extensions (using e.han... | ef15d7a94a808125eabb516668aef7ef4ac1ccb2 | 65aee3c02ac7c29c0fdd34c433aa833b439541ed | diff --git a/Flow.Launcher/ActionKeywords.xaml b/Flow.Launcher/ActionKeywords.xaml
index 5af76f37f39..b575b3859df 100644
--- a/Flow.Launcher/ActionKeywords.xaml
+++ b/Flow.Launcher/ActionKeywords.xaml
@@ -2,6 +2,7 @@
x:Class="Flow.Launcher.ActionKeywords"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/pr... | [
"Flow.Launcher/ActionKeywords.xaml",
"Flow.Launcher/ActionKeywords.xaml.cs",
"Flow.Launcher/CustomQueryHotkeySetting.xaml",
"Flow.Launcher/CustomQueryHotkeySetting.xaml.cs",
"Flow.Launcher/CustomShortcutSetting.xaml",
"Flow.Launcher/CustomShortcutSetting.xaml.cs",
"Flow.Launcher/MessageBoxEx.xaml",
"F... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nfd 'PluginSettingsWindow.xaml.cs' --exec rg -n -C3 'OnLoaded|Window_StateChanged|Window_Activated|LastNonMinimizedWindowState|TitleBar'\n```\n\nRepo... | true | ||
Flow-Launcher/Flow.Launcher | 4,501 | comment_to_fix | Move window titlebar logic and ui to new CustomWindowTitleBar | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
fd 'PluginSettingsWindow.xaml.cs' --exec rg -n -C3 'OnLoaded|Window_StateChanged|Window_Activated|LastNonMinimizedWindowState|TitleBar'
```
Repository: Flow-Launcher/Flow.Launche... | ef15d7a94a808125eabb516668aef7ef4ac1ccb2 | 65aee3c02ac7c29c0fdd34c433aa833b439541ed | diff --git a/Flow.Launcher/PluginSettingsWindow.xaml b/Flow.Launcher/PluginSettingsWindow.xaml
index ac1abd9e2c8..a14a2ea77e0 100644
--- a/Flow.Launcher/PluginSettingsWindow.xaml
+++ b/Flow.Launcher/PluginSettingsWindow.xaml
@@ -2,16 +2,14 @@
x:Class="Flow.Launcher.PluginSettingsWindow"
xmlns="http://schemas.... | [
"Flow.Launcher/PluginSettingsWindow.xaml"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nfd 'PluginSettingsWindow.xaml.cs' --exec rg -n -C3 'OnLoaded|Window_StateChanged|Window_Activated|LastNonMinimizedWindowState|TitleBar'\n```\n\nRepo... | true | ||
Flow-Launcher/Flow.Launcher | 4,501 | comment_to_fix | Move window titlebar logic and ui to new CustomWindowTitleBar | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Use Collapsed instead of Hidden to remove reserved layout space.**
The `RestoreButton` uses `Visibility="Hidden"`, which reserves space in the layout. The PR description explicitly states "Replace Hidden with Collapse to remove layout gaps." Additionally, the C# cod... | ef15d7a94a808125eabb516668aef7ef4ac1ccb2 | 65aee3c02ac7c29c0fdd34c433aa833b439541ed | diff --git a/Flow.Launcher/Resources/Controls/CustomWindowTitleBar.xaml b/Flow.Launcher/Resources/Controls/CustomWindowTitleBar.xaml
new file mode 100644
index 00000000000..fe4e0b338a7
--- /dev/null
+++ b/Flow.Launcher/Resources/Controls/CustomWindowTitleBar.xaml
@@ -0,0 +1,78 @@
+<UserControl
+ x:Class="Flow.Launch... | [
"Flow.Launcher/Resources/Controls/CustomWindowTitleBar.xaml"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use Collapsed instead of Hidden to remove reserved layout space.**\n\nThe `RestoreButton` uses `Visibility=\"Hidden\"`, which reserves space in the layout. The PR description explicitly states \"Replace Hidden with Collapse to remove layout ga... | true | ||
Flow-Launcher/Flow.Launcher | 4,517 | issue_to_patch | Merge v2.1.3 back to dev | Merge v2.1.3 back to dev
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Back-merges v2.1.3 into dev. Updates `Flow.Launcher.Plugin` to 5.3.1, bumps build version to 2.1.3, and cleans a stray BOM in a source file.
**Summary of changes**
- Changed: Packaging versions updated (`Flow.Lau... | b1452b9cd6cea45f344a620617f48622455d62ea | 37861725215380e6e0f2dd94f866c77e55b22bb5 | diff --git a/Flow.Launcher.Infrastructure/Constant.cs b/Flow.Launcher.Infrastructure/Constant.cs
index 1335609001f..7e3499ac520 100644
--- a/Flow.Launcher.Infrastructure/Constant.cs
+++ b/Flow.Launcher.Infrastructure/Constant.cs
@@ -1,4 +1,4 @@
-using System.Diagnostics;
+using System.Diagnostics;
using System.IO;
u... | [
"Flow.Launcher.Infrastructure/Constant.cs",
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"appveyor.yml"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,516 | issue_to_patch | Release 2.1.3 | Plugin 5.3.1 | # Release notes
## Bug fixes
- Fix blur theme backdrop, corners, margin issues & simplify AutoDropShadow #4513
- Fix canceled Program queries caching empty results #4502
- Refactor InitProgressbarAnimation & avoid style cast issue #4499
- Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll #... | f7bb0ca673b389422ae6fb045ccfaa314259b2fa | 5e856f8384d4ee577857fe6e5675531b841058ce | diff --git a/.github/workflows/default_plugins.yml b/.github/workflows/default_plugins.yml
index a7bf114b716..040db7157c1 100644
--- a/.github/workflows/default_plugins.yml
+++ b/.github/workflows/default_plugins.yml
@@ -53,8 +53,7 @@ jobs:
files: "Flow.Launcher.Plugin.BrowserBookmark.zip"
tag_nam... | [
".github/workflows/default_plugins.yml",
"Flow.Launcher.Core/Resource/Theme.cs",
"Flow.Launcher.Infrastructure/Constant.cs",
"Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs",
"Flow.Launcher.Infrastructure/Image/ImageLoader.cs",
"Flow.Launcher.Infrastructure/NativeMethods.txt",
"Flow.Launcher.I... | [] | diff --git a/Flow.Launcher.Test/Flow.Launcher.Test.csproj b/Flow.Launcher.Test/Flow.Launcher.Test.csproj
index 11ccff05b05..546d8fd3feb 100644
--- a/Flow.Launcher.Test/Flow.Launcher.Test.csproj
+++ b/Flow.Launcher.Test/Flow.Launcher.Test.csproj
@@ -39,6 +39,7 @@
</ItemGroup>
<ItemGroup>
+ <ProjectReference... | true | |
Flow-Launcher/Flow.Launcher | 4,453 | issue_to_patch | BUG: Plugins icons missing
### Checks
- [x] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [x] I am using the prerelease version of Flow Launcher.
### Problem Description
some days ago i opened flow launcher and all the plugin icons appeared ... | Improve ImageLoader thumbnail fallbacks and refactor GetThumbnailResult | Will resolve #4450, maybe also #4403
## Summary
- Refactored GetThumbnailResult by splitting it into per-type helper methods (GetDirectoryThumbnailResult, GetImageFileThumbnailResult, GetSvgFileThumbnailResult, GetFileThumbnailResult)
- Consistently use MissingImage as the final fallback for all but folders. Remov... | 793b66c2ff7068b26b2e639ca422146736c11cca | ccda60af809ac7873db839ffd595e79112f47e6a | diff --git a/Flow.Launcher.Infrastructure/Constant.cs b/Flow.Launcher.Infrastructure/Constant.cs
index 94aa42fea6a..1335609001f 100644
--- a/Flow.Launcher.Infrastructure/Constant.cs
+++ b/Flow.Launcher.Infrastructure/Constant.cs
@@ -32,9 +32,9 @@ public static class Constant
public static readonly string Error... | [
"Flow.Launcher.Infrastructure/Constant.cs",
"Flow.Launcher.Infrastructure/Image/ImageLoader.cs",
"Flow.Launcher.Test/Flow.Launcher.Test.csproj",
"Flow.Launcher.Test/ImageLoaderTests.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Propagate `loadFullImage` through the directory branch.**\n\nLine 203 drops the preview-size flag, and Line 243 then calls `GetThumbnail(..., IconOnly)` with the default 64px size. Folder previews will now always upscale a thumbnail-sized icon... | diff --git a/Flow.Launcher.Test/Flow.Launcher.Test.csproj b/Flow.Launcher.Test/Flow.Launcher.Test.csproj
index 11ccff05b05..2c831bf8304 100644
--- a/Flow.Launcher.Test/Flow.Launcher.Test.csproj
+++ b/Flow.Launcher.Test/Flow.Launcher.Test.csproj
@@ -58,4 +58,10 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" ... | true |
Flow-Launcher/Flow.Launcher | 4,453 | comment_to_fix | Improve ImageLoader thumbnail fallbacks and refactor GetThumbnailResult | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Propagate `loadFullImage` through the directory branch.**
Line 203 drops the preview-size flag, and Line 243 then calls `GetThumbnail(..., IconOnly)` with the default 64px size. Folder previews will now always upscale a thumbnail-sized icon instead of requesting `Fu... | 793b66c2ff7068b26b2e639ca422146736c11cca | ccda60af809ac7873db839ffd595e79112f47e6a | diff --git a/Flow.Launcher.Infrastructure/Image/ImageLoader.cs b/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
index 598347fd21f..83501b16fe2 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
@@ -5,6 +5,8 @@
using System.Linq;
using System.Threa... | [
"Flow.Launcher.Infrastructure/Image/ImageLoader.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Propagate `loadFullImage` through the directory branch.**\n\nLine 203 drops the preview-size flag, and Line 243 then calls `GetThumbnail(..., IconOnly)` with the default 64px size. Folder previews will now always upscale a thumbnail-sized icon... | true | ||
Flow-Launcher/Flow.Launcher | 4,453 | comment_to_fix | Improve ImageLoader thumbnail fallbacks and refactor GetThumbnailResult | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`In WPF, when BitmapImage is initialized with BitmapCacheOption.OnLoad and no DecodePixelWidth/DecodePixelHeight, does EndInit decode the full source image? What is the recommended way to read pixel dimensi... | 793b66c2ff7068b26b2e639ca422146736c11cca | ccda60af809ac7873db839ffd595e79112f47e6a | diff --git a/Flow.Launcher.Infrastructure/Image/ImageLoader.cs b/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
index 598347fd21f..83501b16fe2 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
@@ -5,6 +5,8 @@
using System.Linq;
using System.Threa... | [
"Flow.Launcher.Infrastructure/Image/ImageLoader.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In WPF, when BitmapImage is initialized with BitmapCacheOption.OnLoad and no DecodePixelWidth/DecodePixelHeight, does EndInit decode the full source image? What is the recommen... | true | ||
Flow-Launcher/Flow.Launcher | 4,453 | comment_to_fix | Improve ImageLoader thumbnail fallbacks and refactor GetThumbnailResult | <!-- metadata:{"confidence":10} -->
P2: The second retry warning logs the wrong exception (`e.Message` instead of `e2.Message`), which misreports the actual second-failure cause.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it. At Fl... | 793b66c2ff7068b26b2e639ca422146736c11cca | ccda60af809ac7873db839ffd595e79112f47e6a | diff --git a/Flow.Launcher.Infrastructure/Image/ImageLoader.cs b/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
index 598347fd21f..83501b16fe2 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageLoader.cs
@@ -5,6 +5,8 @@
using System.Linq;
using System.Threa... | [
"Flow.Launcher.Infrastructure/Image/ImageLoader.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":10} -->\nP2: The second retry warning logs the wrong exception (`e.Message` instead of `e2.Message`), which misreports the actual second-failure cause.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand t... | true | ||
Flow-Launcher/Flow.Launcher | 4,449 | issue_to_patch | New Crowdin updates |
<!-- This is an auto-generated description by cubic. -->
## Summary by cubic
Updated translations for Spanish, Simplified Chinese, and Turkish, added resources for 21 locales, and removed obsolete `.resx` files. No functional changes.
**Summary of changes**
- Changed: Spanish and Simplified Chinese phrasing for “ign... | ecf42cf054c0bb7e6555d1a441668a4b4c8261d9 | d40fae034b265d3d4d0d1c1e841c40f6abf20ce8 | diff --git a/Flow.Launcher/Languages/es.xaml b/Flow.Launcher/Languages/es.xaml
index 8acde56606e..c054181aa0a 100644
--- a/Flow.Launcher/Languages/es.xaml
+++ b/Flow.Launcher/Languages/es.xaml
@@ -123,9 +123,9 @@
<system:String x:Key="hideOnStartupToolTip">La ventana de búsqueda de Flow Launcher se oculta en la ba... | [
"Flow.Launcher/Languages/es.xaml",
"Flow.Launcher/Languages/tr.xaml",
"Flow.Launcher/Languages/zh-cn.xaml"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,513 | issue_to_patch | BUG: Recent Update Broke Some Acrylic/Blur Themes
### Checks
- [x] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
### Problem Description
I've been using the OnsetGlaze (Acrylic/Glassmorphism) theme for a couple of months now, and after a recent... | Fix blur theme backdrop, corners, margin issues & simplify AutoDropShadow | Closes #4457 and #4512
Potentially also closes #3624
## Bug Fixes
- Fixes the double corners issue by removing the call to `RemoveDropShadowEffectFromCurrentTheme` for blur themes as they both made conflicting modifications to the style - instead just clear all window border styles in the `SetBlurForWindow` method... | 5f9d116708276c1b616edc56c4f95a868f118d4d | 7cf0b9772ba59f9316ede96adaec4ec7928f79c2 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index ed9677cff2c..45758a0042b 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -554,6 +554,11 @@ public void RemoveDropShadowEffectFromCurrentTheme()
ThemeHelper.CopyStyl... | [
"Flow.Launcher.Core/Resource/Theme.cs",
"Flow.Launcher.Infrastructure/NativeMethods.txt",
"Flow.Launcher.Infrastructure/Win32Helper.cs"
] | [
{
"comment": "<!-- cubic:v=3ed305cf-88de-4c1e-b51a-82d48dbf308d -->\n<!-- cubic:review-run=009882be-c587-415f-a070-b5e039d2e0c2 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: Frame extension is never reset when backdrop is turned off, so a prior full-window DWM extension can persist after switching to `Backdrop... | true | |
Flow-Launcher/Flow.Launcher | 4,513 | comment_to_fix | Fix blur theme backdrop, corners, margin issues & simplify AutoDropShadow | <!-- cubic:v=3ed305cf-88de-4c1e-b51a-82d48dbf308d -->
<!-- cubic:review-run=009882be-c587-415f-a070-b5e039d2e0c2 -->
<!-- metadata:{"confidence":9} -->
P1: Frame extension is never reset when backdrop is turned off, so a prior full-window DWM extension can persist after switching to `BackdropTypes.None`.
<details>
<su... | 5f9d116708276c1b616edc56c4f95a868f118d4d | 7cf0b9772ba59f9316ede96adaec4ec7928f79c2 | diff --git a/Flow.Launcher.Infrastructure/Win32Helper.cs b/Flow.Launcher.Infrastructure/Win32Helper.cs
index 67d0edb7888..feafcfcdaa0 100644
--- a/Flow.Launcher.Infrastructure/Win32Helper.cs
+++ b/Flow.Launcher.Infrastructure/Win32Helper.cs
@@ -21,6 +21,7 @@
using Windows.Win32.Graphics.Dwm;
using Windows.Win32.Syste... | [
"Flow.Launcher.Infrastructure/Win32Helper.cs"
] | [
{
"comment": "<!-- cubic:v=3ed305cf-88de-4c1e-b51a-82d48dbf308d -->\n<!-- cubic:review-run=009882be-c587-415f-a070-b5e039d2e0c2 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: Frame extension is never reset when backdrop is turned off, so a prior full-window DWM extension can persist after switching to `Backdrop... | true | ||
Flow-Launcher/Flow.Launcher | 4,513 | comment_to_fix | Fix blur theme backdrop, corners, margin issues & simplify AutoDropShadow | <!-- cubic:v=ae9ae429-454f-4d84-b75a-ba58e74c6a29 -->
<!-- cubic:review-run=009882be-c587-415f-a070-b5e039d2e0c2 -->
<!-- metadata:{"confidence":8} -->
P2: Blur branch no longer resets resize border thickness after removing shadow style override, leaving stale shadow-expanded resize hit area.
<details>
<summary>Prompt... | 5f9d116708276c1b616edc56c4f95a868f118d4d | 7cf0b9772ba59f9316ede96adaec4ec7928f79c2 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index ed9677cff2c..45758a0042b 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -554,6 +554,11 @@ public void RemoveDropShadowEffectFromCurrentTheme()
ThemeHelper.CopyStyl... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "<!-- cubic:v=ae9ae429-454f-4d84-b75a-ba58e74c6a29 -->\n<!-- cubic:review-run=009882be-c587-415f-a070-b5e039d2e0c2 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Blur branch no longer resets resize border thickness after removing shadow style override, leaving stale shadow-expanded resize hit area.... | true | ||
Flow-Launcher/Flow.Launcher | 4,513 | comment_to_fix | Fix blur theme backdrop, corners, margin issues & simplify AutoDropShadow | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Restore the resize border when blur themes skip shadow removal.**
This branch removes the `WindowBorderStyle` override, but it no longer performs the `SetResizeBoarderThickness(null)` cleanup that used to happen through `RemoveDropShadowEffectFromCurrentTheme()`. If... | 5f9d116708276c1b616edc56c4f95a868f118d4d | 7cf0b9772ba59f9316ede96adaec4ec7928f79c2 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index ed9677cff2c..45758a0042b 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -554,6 +554,11 @@ public void RemoveDropShadowEffectFromCurrentTheme()
ThemeHelper.CopyStyl... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Restore the resize border when blur themes skip shadow removal.**\n\nThis branch removes the `WindowBorderStyle` override, but it no longer performs the `SetResizeBoarderThickness(null)` cleanup that used to happen through `RemoveDropShadowEff... | true | ||
Flow-Launcher/Flow.Launcher | 4,502 | issue_to_patch | Fix canceled Program queries caching empty results |
<!-- This is an auto-generated description by cubic. -->
## Summary by cubic
Stops caching empty results when Program queries are canceled, ensuring follow-up searches show the right apps. Adds a unit test and simplifies cancellation/lock handling.
- **Summary of changes**
- Changed: Centralized cancellation handl... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | bce09b0cad61f2bb3ac891e92bbebf75c9405660 | diff --git a/Flow.Launcher.Test/Plugins/ProgramPluginTest.cs b/Flow.Launcher.Test/Plugins/ProgramPluginTest.cs
new file mode 100644
index 00000000000..015380a152d
--- /dev/null
+++ b/Flow.Launcher.Test/Plugins/ProgramPluginTest.cs
@@ -0,0 +1,134 @@
+using System;
+using System.Collections.Generic;
+using System.Reflect... | [
"Flow.Launcher.Test/Plugins/ProgramPluginTest.cs",
"Plugins/Flow.Launcher.Plugin.Program/Main.cs"
] | [
{
"comment": "`uwpsDirectories` is computed from the mutable static `_uwps` list after releasing `_uwpsLock`. This can race with indexing/updating `_uwps` and can throw during enumeration (\"Collection was modified\") or make the duplicate-filter directories inconsistent with the `uwps` snapshot used for the qu... | true | ||
Flow-Launcher/Flow.Launcher | 4,502 | comment_to_fix | Fix canceled Program queries caching empty results | `uwpsDirectories` is computed from the mutable static `_uwps` list after releasing `_uwpsLock`. This can race with indexing/updating `_uwps` and can throw during enumeration ("Collection was modified") or make the duplicate-filter directories inconsistent with the `uwps` snapshot used for the query. Use the local `uwps... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | bce09b0cad61f2bb3ac891e92bbebf75c9405660 | diff --git a/Plugins/Flow.Launcher.Plugin.Program/Main.cs b/Plugins/Flow.Launcher.Plugin.Program/Main.cs
index aeec9f702d7..28eeab6fc65 100644
--- a/Plugins/Flow.Launcher.Plugin.Program/Main.cs
+++ b/Plugins/Flow.Launcher.Plugin.Program/Main.cs
@@ -80,51 +80,43 @@ public class Main : ISettingProvider, IAsyncPlugin, IPl... | [
"Plugins/Flow.Launcher.Plugin.Program/Main.cs"
] | [
{
"comment": "`uwpsDirectories` is computed from the mutable static `_uwps` list after releasing `_uwpsLock`. This can race with indexing/updating `_uwps` and can throw during enumeration (\"Collection was modified\") or make the duplicate-filter directories inconsistent with the `uwps` snapshot used for the qu... | true | ||
Flow-Launcher/Flow.Launcher | 4,499 | issue_to_patch | BUG: Unable to cast object of type 'System.Windows.Media.Color' to type 'System.Windows.Expression'
### Checks
- [ ] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description... | Refactor InitProgressbarAnimation & avoid style cast issue | Should close #4348
## Bug Fix
Avoids the creation of a new style based on PendingLineStyle as there seems to be a WPF bug in handling cloning of styles containing SystemAccentColors - seemingly the trigger for #4348 and other related issues.
That new style was created to add a trigger to play an animation if the p... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | 238162a365afc2add330c1d214aff95d79b8f3cc | diff --git a/Flow.Launcher/MainWindow.xaml b/Flow.Launcher/MainWindow.xaml
index 9d6b51dccd8..2950d2f6555 100644
--- a/Flow.Launcher/MainWindow.xaml
+++ b/Flow.Launcher/MainWindow.xaml
@@ -337,6 +337,7 @@
</Border>
<Line
x:Name="ProgressBar"
+ St... | [
"Flow.Launcher/MainWindow.xaml",
"Flow.Launcher/MainWindow.xaml.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Use `IsVisible` (or `e.NewValue`) in the `IsVisibleChanged` handler; checking `Visibility` can start the storyboard when the control is effectively hidden by an ancestor/window state.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck ... | true | |
Flow-Launcher/Flow.Launcher | 4,499 | comment_to_fix | Refactor InitProgressbarAnimation & avoid style cast issue | <!-- metadata:{"confidence":8} -->
P2: Use `IsVisible` (or `e.NewValue`) in the `IsVisibleChanged` handler; checking `Visibility` can start the storyboard when the control is effectively hidden by an ancestor/window state.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so,... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | 238162a365afc2add330c1d214aff95d79b8f3cc | diff --git a/Flow.Launcher/MainWindow.xaml.cs b/Flow.Launcher/MainWindow.xaml.cs
index 70273d616c3..4866c0deae6 100644
--- a/Flow.Launcher/MainWindow.xaml.cs
+++ b/Flow.Launcher/MainWindow.xaml.cs
@@ -75,6 +75,7 @@ public partial class MainWindow : IDisposable
// Window Animation
private const double ... | [
"Flow.Launcher/MainWindow.xaml.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Use `IsVisible` (or `e.NewValue`) in the `IsVisibleChanged` handler; checking `Visibility` can start the storyboard when the control is effectively hidden by an ancestor/window state.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck ... | true | ||
Flow-Launcher/Flow.Launcher | 4,497 | issue_to_patch | BUG: System.OverflowException: TimeSpan overflowed in ScrollViewerEx.AnimateScroll
### Checks
- [ ] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
Flow Launcher c... | Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll | This PR fixes the OverflowException reported in [#4481](https://github.com/Flow-Launcher/Flow.Launcher/issues/4481#issuecomment-4538555477), which occurs when the user scrolls on a ScrollViewer that has not been fully rendered yet or whose ActualHeight is 0.
**Root Cause**
The issue originates from the following ... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | a372971bcd799bcefd320ae2fcec46dbf4ef14c3 | diff --git a/Flow.Launcher.Test/MouseWheelTest.cs b/Flow.Launcher.Test/MouseWheelTest.cs
new file mode 100644
index 00000000000..eb827293bb6
--- /dev/null
+++ b/Flow.Launcher.Test/MouseWheelTest.cs
@@ -0,0 +1,36 @@
+using System;
+using System.Reflection;
+using System.Windows;
+using System.Windows.Input;
+using Syst... | [
"Flow.Launcher.Test/Flow.Launcher.Test.csproj",
"Flow.Launcher.Test/MouseWheelTest.cs",
"Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Assert reflected method lookup before invocation.**\n\nAdd an explicit null assertion for `onMouseWheelMethod` so failures are diagnostic (method not found) instead of a generic null-reference during invoke.\n\n \n\n<details>\n<summary>Suggest... | diff --git a/Flow.Launcher.Test/Flow.Launcher.Test.csproj b/Flow.Launcher.Test/Flow.Launcher.Test.csproj
index 11ccff05b05..9ade234c79f 100644
--- a/Flow.Launcher.Test/Flow.Launcher.Test.csproj
+++ b/Flow.Launcher.Test/Flow.Launcher.Test.csproj
@@ -39,6 +39,7 @@
</ItemGroup>
<ItemGroup>
+ <ProjectReference... | true |
Flow-Launcher/Flow.Launcher | 4,497 | comment_to_fix | Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Assert reflected method lookup before invocation.**
Add an explicit null assertion for `onMouseWheelMethod` so failures are diagnostic (method not found) instead of a generic null-reference during invoke.
<details>
<summary>Suggested fix</summary>
```diff
... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | a372971bcd799bcefd320ae2fcec46dbf4ef14c3 | diff --git a/Flow.Launcher.Test/MouseWheelTest.cs b/Flow.Launcher.Test/MouseWheelTest.cs
new file mode 100644
index 00000000000..eb827293bb6
--- /dev/null
+++ b/Flow.Launcher.Test/MouseWheelTest.cs
@@ -0,0 +1,36 @@
+using System;
+using System.Reflection;
+using System.Windows;
+using System.Windows.Input;
+using Syst... | [
"Flow.Launcher.Test/MouseWheelTest.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Assert reflected method lookup before invocation.**\n\nAdd an explicit null assertion for `onMouseWheelMethod` so failures are diagnostic (method not found) instead of a generic null-reference during invoke.\n\n \n\n<details>\n<summary>Suggest... | true | ||
Flow-Launcher/Flow.Launcher | 4,497 | comment_to_fix | Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Fix horizontal guard to validate `ActualWidth`, not `ActualHeight`.**
Line 136 divides by `ActualWidth`, but Line 133 guards `ActualHeight`. This still permits `ActualWidth == 0`, reintroducing the infinite offset path in horizontal scrolling.
<details>
<summ... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | a372971bcd799bcefd320ae2fcec46dbf4ef14c3 | diff --git a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
index 78985108ce2..fbc85e223cb 100644
--- a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
+++ b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
@@ -44,8 +44,7 @@ public Or... | [
"Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Fix horizontal guard to validate `ActualWidth`, not `ActualHeight`.**\n\nLine 136 divides by `ActualWidth`, but Line 133 guards `ActualHeight`. This still permits `ActualWidth == 0`, reintroducing the infinite offset path in horizontal scro... | true | ||
Flow-Launcher/Flow.Launcher | 4,497 | comment_to_fix | Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll | <!-- metadata:{"confidence":10} -->
P1: Horizontal scroll branch guards ActualHeight instead of ActualWidth, leaving the overflow bug intact for horizontal scrolling
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it. At Flow.Launcher/R... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | a372971bcd799bcefd320ae2fcec46dbf4ef14c3 | diff --git a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
index 78985108ce2..fbc85e223cb 100644
--- a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
+++ b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
@@ -44,8 +44,7 @@ public Or... | [
"Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":10} -->\nP1: Horizontal scroll branch guards ActualHeight instead of ActualWidth, leaving the overflow bug intact for horizontal scrolling\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root cause... | true | ||
Flow-Launcher/Flow.Launcher | 4,497 | comment_to_fix | Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Reset animation state before guard returns.**
`OnMouseWheel` sets animating `true` at Line 91, but this new early return exits without resetting it. That can leave `IsAnimating` stuck and block `OnScrollChanged` from syncing offsets.
<details>
<summary>Proposed ... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | a372971bcd799bcefd320ae2fcec46dbf4ef14c3 | diff --git a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
index 78985108ce2..fbc85e223cb 100644
--- a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
+++ b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
@@ -44,8 +44,7 @@ public Or... | [
"Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Reset animation state before guard returns.**\n\n`OnMouseWheel` sets animating `true` at Line 91, but this new early return exits without resetting it. That can leave `IsAnimating` stuck and block `OnScrollChanged` from syncing offsets.\n\n \n... | true | ||
Flow-Launcher/Flow.Launcher | 4,497 | comment_to_fix | Fix System.OverflowException in CustomScrollViewerEx during Mouse Wheel scroll | <!-- metadata:{"confidence":8} -->
P1: Animation state `IsAnimating` is set to `true` before dimension guard-clauses, so an early return when `ActualWidth <= 0` or `ActualHeight <= 0` leaves the flag permanently stuck. `ScrollToValue` is the only place in the file that resets it to `false`, and it is never reached on t... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | a372971bcd799bcefd320ae2fcec46dbf4ef14c3 | diff --git a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
index 78985108ce2..fbc85e223cb 100644
--- a/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
+++ b/Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs
@@ -44,8 +44,7 @@ public Or... | [
"Flow.Launcher/Resources/Controls/CustomScrollViewerEx.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP1: Animation state `IsAnimating` is set to `true` before dimension guard-clauses, so an early return when `ActualWidth <= 0` or `ActualHeight <= 0` leaves the flag permanently stuck. `ScrollToValue` is the only place in the file that resets it to `false`, and... | true | ||
Flow-Launcher/Flow.Launcher | 4,490 | issue_to_patch | BUG: Program Plugin - MAX_PATH too small for IShellLinkW.GetDescription and .GetArguments buffers
### Checks
- [x] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [x] I am using the prerelease version of Flow Launcher.
### Problem Description
... | Program Plugin: Refactor ShellLinkReader and fix argument/description retrieval | Closes #4486
## Bug Fixes
- Uses a seperate buffer for description with the correct constant INFOTIPSIZE for its size
- Use IPropertyStore to retrieve arguments as is recommended, instead of outdated IShellLinkW .GetArguments
## Rework
- Rename ShellLinkHelper to ShellLinkReader, to properly reflect its narrow... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | 1de6d751e681421b4f7617a3fb84932bfc04110e | diff --git a/Plugins/Flow.Launcher.Plugin.Program/NativeMethods.txt b/Plugins/Flow.Launcher.Plugin.Program/NativeMethods.txt
index a8fe178c7a2..d85cb81493c 100644
--- a/Plugins/Flow.Launcher.Plugin.Program/NativeMethods.txt
+++ b/Plugins/Flow.Launcher.Plugin.Program/NativeMethods.txt
@@ -10,4 +10,13 @@ SLR_FLAGS
IShel... | [
"Plugins/Flow.Launcher.Plugin.Program/NativeMethods.txt",
"Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkHelper.cs",
"Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkReadResult.cs",
"Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkReader.cs",
"Plugins/Flow.Launcher.Plugin.Program/Prog... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In Microsoft.Windows.CsWin32 0.3.275, are COM methods on IShellLinkW and IPropertyStore (e.g., Resolve, GetPath, GetDescription, GetValue) generated as HRESULT-returning Preser... | true | |
Flow-Launcher/Flow.Launcher | 4,490 | comment_to_fix | Program Plugin: Refactor ShellLinkReader and fix argument/description retrieval | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`In Microsoft.Windows.CsWin32 0.3.275, are COM methods on IShellLinkW and IPropertyStore (e.g., Resolve, GetPath, GetDescription, GetValue) generated as HRESULT-returning PreserveSig methods that require ex... | ef7d89d292e49bf6b6810b5c6821863f9bb8ae19 | 1de6d751e681421b4f7617a3fb84932bfc04110e | diff --git a/Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkReader.cs b/Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkReader.cs
new file mode 100644
index 00000000000..2680e6ea918
--- /dev/null
+++ b/Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkReader.cs
@@ -0,0 +1,131 @@
+using System;
+usi... | [
"Plugins/Flow.Launcher.Plugin.Program/Programs/ShellLinkReader.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In Microsoft.Windows.CsWin32 0.3.275, are COM methods on IShellLinkW and IPropertyStore (e.g., Resolve, GetPath, GetDescription, GetValue) generated as HRESULT-returning Preser... | true | ||
Flow-Launcher/Flow.Launcher | 4,489 | issue_to_patch | Add official channels section to readme | In light of discussions regarding flow-launcher.com
Adds a list of official channels and a warning to be careful of similar looking domains and only use official installation methods
<img width="2078" height="582" alt="image" src="https://github.com/user-attachments/assets/e95ac06a-3e00-434b-b355-faaadf41b9a9" />... | 793b66c2ff7068b26b2e639ca422146736c11cca | 3c09e767522af55b4e69757e5e82e69bdc2f626a | diff --git a/README.md b/README.md
index 2dbeb8b426e..a1a5107412c 100644
--- a/README.md
+++ b/README.md
@@ -25,7 +25,8 @@ Dedicated to making your workflow more seamless. Search everything from applicat
<img src="https://user-images.githubusercontent.com/6903107/144858082-8b654daf-60fb-4ee6-89b2-6183b73510d1.png" w... | [
"README.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add alt text to the separator image on Line 53.**\n\nThis trips MD045 (`no-alt-text`) and reduces accessibility in rendered docs.\n \n\n<details>\n<summary>Proposed fix</summary>\n\n```diff\n-<img src=\"https://user-images.githubusercontent.co... | true | ||
Flow-Launcher/Flow.Launcher | 4,488 | issue_to_patch | Renew secure token in AppVeyor |
<!-- This is an auto-generated description by cubic. -->
## Summary by cubic
Rotated the encrypted AppVeyor GitHub auth token used for release deployments to restore/maintain deploy access. No changes to build or release behavior.
**Summary of changes**
- Changed: Updated `auth_token.secure` for both AppVeyor deploy... | 4a06af8238eae2d4f18675d140b44d7146cadeac | 18bfb0eb74a58de3172159da7fabc7de59dcf44d | diff --git a/appveyor.yml b/appveyor.yml
index 787b3cdd6db..dd19eac879b 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -81,7 +81,7 @@ deploy:
Please report any bugs or issues over at the [main repository](https://github.com/Flow-Launcher/Flow.Launcher/issues)'
auth_token:
- secure: ij4UeXUYQBD... | [
"appveyor.yml"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,466 | issue_to_patch | BUG: Default Browser not detected - windows changed registry location
### Checks
- [x] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [x] I am using the prerelease version of Flow Launcher.
### Problem Description
To detect your default brows... | Fix default browser detection by adding support for newer registry key | This pull request updates the logic for detecting the default web browser on Windows by adding support for newer registry keys used in recent Windows versions, while maintaining compatibility with older versions.
**Default browser detection improvements:**
* Updated `GetDefaultBrowserPath` in `SearchWeb.cs` to fi... | 4616950b2d3531d86e3d0396118abcfef3089b1e | 48c9d85b3b6d6dbfdfe1793d0ebce3deb4c15d65 | diff --git a/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs b/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs
index 1b4f780a372..944b6f5b56f 100644
--- a/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs
+++ b/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs
@@ -17,8 +17,16 @@ private static string GetDefaultBrowserP... | [
"Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add null-conditional operator for safer registry access.**\n\nIf the `UserChoice` registry key doesn't exist, `OpenSubKey` returns `null`, and line 28 will throw a `NullReferenceException`. While the outer try-catch will handle this, using the... | true | |
Flow-Launcher/Flow.Launcher | 4,466 | comment_to_fix | Fix default browser detection by adding support for newer registry key | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Add null-conditional operator for safer registry access.**
If the `UserChoice` registry key doesn't exist, `OpenSubKey` returns `null`, and line 28 will throw a `NullReferenceException`. While the outer try-catch will handle this, using the null-conditional operator... | 4616950b2d3531d86e3d0396118abcfef3089b1e | 48c9d85b3b6d6dbfdfe1793d0ebce3deb4c15d65 | diff --git a/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs b/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs
index 1b4f780a372..944b6f5b56f 100644
--- a/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs
+++ b/Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs
@@ -17,8 +17,16 @@ private static string GetDefaultBrowserP... | [
"Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add null-conditional operator for safer registry access.**\n\nIf the `UserChoice` registry key doesn't exist, `OpenSubKey` returns `null`, and line 28 will throw a `NullReferenceException`. While the outer try-catch will handle this, using the... | true | ||
Flow-Launcher/Flow.Launcher | 4,452 | issue_to_patch | Fix Publish Default Plugin workflow token declaration | Recent change of softprops/action-gh-release GitHub action from v2 to v3 seems to require token be explicitly declared instead of via env variable.
Tested:
- v2.1.2 default plugins are published
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Fix the default plugins publish workfl... | 667fcb9640071738c9379d69405bde685cc7d268 | c81176e6a846ce3caf5a81a621123836dc981d02 | diff --git a/.github/workflows/default_plugins.yml b/.github/workflows/default_plugins.yml
index a7bf114b716..040db7157c1 100644
--- a/.github/workflows/default_plugins.yml
+++ b/.github/workflows/default_plugins.yml
@@ -53,8 +53,7 @@ jobs:
files: "Flow.Launcher.Plugin.BrowserBookmark.zip"
tag_nam... | [
".github/workflows/default_plugins.yml"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,461 | issue_to_patch | Bump Microsoft.SourceLink.GitHub from 10.0.203 to 10.0.300 | Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/dotnet) from 10.0.203 to 10.0.300.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/dotnet/releases)._
## 10.0.300
You can build .NET 10.0 from the repository by cloning the rel... | 5779818aefa17126e5cc6fbb82b27fd382876b5e | dc75e9b2842a01f2fc9de21097a7d94227fc1d50 | diff --git a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
index c230ab26748..d6946279f1f 100644
--- a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
+++ b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
@@ -72,7 +72,7 @@
<PrivateAssets>all</PrivateAssets>... | [
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"Flow.Launcher.Plugin/packages.lock.json"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,460 | issue_to_patch | Bump Microsoft.Data.Sqlite from 10.0.7 to 10.0.8 | Updated [Microsoft.Data.Sqlite](https://github.com/dotnet/dotnet) from 10.0.7 to 10.0.8.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Data.Sqlite's releases](https://github.com/dotnet/dotnet/releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://... | 5779818aefa17126e5cc6fbb82b27fd382876b5e | fa7fd7ed44bf463e44c266c2b4679a2b228fc3fc | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index b0e4019bdc5..cac59e4fee4 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,432 | issue_to_patch | BUG: Flow.Launcher.Infrastructure.Image.ImageLoader hash collisions
### Checks
- [ ] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
### Diagnosis details
- Code p... | Make image hashing deterministic and format/DPI-agnostic | Closes #4116
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Makes image hashing deterministic and format/DPI-agnostic by normalizing to `Pbgra32` and hashing raw pixels. Prevents collisions across formats/metadata and reduces allocations.
- **Summary of changes**
- Changed: Hash ra... | a16e4591619050286ad8078712dae933b20e11f0 | e436287492da51b8b575f332de53dd80d6ea08a9 | diff --git a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
index 2611e99e865..d0fb592f4d3 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
@@ -1,5 +1,5 @@
using Sys... | [
"Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Confirm caller thread context for GetHashFromImage / LoadAsync.\nrg -nP -C5 '\\bGetHashFromImage\\s*\\(' --type=cs\necho '---'\nrg -nP -C8 '_hashGenerator|LoadAsy... | true | |
Flow-Launcher/Flow.Launcher | 4,432 | comment_to_fix | Make image hashing deterministic and format/DPI-agnostic | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Confirm caller thread context for GetHashFromImage / LoadAsync.
rg -nP -C5 '\bGetHashFromImage\s*\(' --type=cs
echo '---'
rg -nP -C8 '_hashGenerator|LoadAsync|LoadInternalAsync|InitializeAsync'... | a16e4591619050286ad8078712dae933b20e11f0 | e436287492da51b8b575f332de53dd80d6ea08a9 | diff --git a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
index 2611e99e865..d0fb592f4d3 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
@@ -1,5 +1,5 @@
using Sys... | [
"Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Confirm caller thread context for GetHashFromImage / LoadAsync.\nrg -nP -C5 '\\bGetHashFromImage\\s*\\(' --type=cs\necho '---'\nrg -nP -C8 '_hashGenerator|LoadAsy... | true | ||
Flow-Launcher/Flow.Launcher | 4,432 | comment_to_fix | Make image hashing deterministic and format/DPI-agnostic | _⚠️ Potential issue_ | _🟠 Major_
**`HashSize` is unused — the promised 64×64 normalization is missing.**
The PR description and the comment on Line 15 / Line 40 state the image is rendered/resized to a deterministic 64×64 buffer at 96 DPI to avoid DPI and size variability, but the implementation never references `Ha... | a16e4591619050286ad8078712dae933b20e11f0 | e436287492da51b8b575f332de53dd80d6ea08a9 | diff --git a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
index 2611e99e865..d0fb592f4d3 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
@@ -1,5 +1,5 @@
using Sys... | [
"Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**`HashSize` is unused — the promised 64×64 normalization is missing.**\n\nThe PR description and the comment on Line 15 / Line 40 state the image is rendered/resized to a deterministic 64×64 buffer at 96 DPI to avoid DPI and size variability, but the implement... | true | ||
Flow-Launcher/Flow.Launcher | 4,432 | comment_to_fix | Make image hashing deterministic and format/DPI-agnostic | <!-- metadata:{"confidence":9} -->
P1: Image hash generation no longer normalizes to fixed dimensions, making hashes source-size dependent and increasing allocation with input size.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it. At... | a16e4591619050286ad8078712dae933b20e11f0 | e436287492da51b8b575f332de53dd80d6ea08a9 | diff --git a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
index 2611e99e865..d0fb592f4d3 100644
--- a/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
+++ b/Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs
@@ -1,5 +1,5 @@
using Sys... | [
"Flow.Launcher.Infrastructure/Image/ImageHashGenerator.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9} -->\nP1: Image hash generation no longer normalizes to fixed dimensions, making hashes source-size dependent and increasing allocation with input size.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understan... | true | ||
Flow-Launcher/Flow.Launcher | 4,375 | issue_to_patch | Dev: Last history result not showing for 'Empty Last Query' query style
### Checks
- [x] I have checked that this issue has not already been reported.
- [ ] I am using the latest version of Flow Launcher.
- [x] I am using the prerelease version of Flow Launcher.
### Problem Description
This is an issue with the ... | Fix last opened result not showing in 'Empty Last Query' mode | From https://github.com/Flow-Launcher/Flow.Launcher/pull/4042
Fix last opened result not showing in 'Empty Last Query' query style mode after result is selected, and would only show when re-queried or clearing of a new query.
The cause is the Hide() call after result is actioned triggers a `QueryResultsAsync` whi... | de36eaf07495ca59e62a1c42410577beac6bfeb1 | 654026e66308bf833b0a152abc0ebe3527f963c7 | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index 333ac3652f4..6a4d54f27ab 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -515,8 +515,11 @@ private async Task OpenResultAsync(string index)
retu... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Typo in comment: \"reconstuct\" should be \"reconstruct\".\n```suggestion\n // the QueryAsync call will reconstruct the result list without the new item.\n```",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -531,26 +534,30 @@ private async Task OpenResultAsync(... | true | |
Flow-Launcher/Flow.Launcher | 4,375 | comment_to_fix | Fix last opened result not showing in 'Empty Last Query' mode | Typo in comment: "reconstuct" should be "reconstruct".
```suggestion
// the QueryAsync call will reconstruct the result list without the new item.
``` | de36eaf07495ca59e62a1c42410577beac6bfeb1 | 654026e66308bf833b0a152abc0ebe3527f963c7 | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index 333ac3652f4..6a4d54f27ab 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -515,8 +515,11 @@ private async Task OpenResultAsync(string index)
retu... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Typo in comment: \"reconstuct\" should be \"reconstruct\".\n```suggestion\n // the QueryAsync call will reconstruct the result list without the new item.\n```",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -531,26 +534,30 @@ private async Task OpenResultAsync(... | true | ||
Flow-Launcher/Flow.Launcher | 4,375 | comment_to_fix | Fix last opened result not showing in 'Empty Last Query' mode | The comment "Only hide for query results (not Dialog Jump)" doesn't match the condition below: the code only excludes Dialog Jump *left-click* mode (right-click mode can still reach this block). Please update the comment to accurately reflect the behavior being gated here.
```suggestion
// Only hide when no... | de36eaf07495ca59e62a1c42410577beac6bfeb1 | 654026e66308bf833b0a152abc0ebe3527f963c7 | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index 333ac3652f4..6a4d54f27ab 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -515,8 +515,11 @@ private async Task OpenResultAsync(string index)
retu... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "The comment \"Only hide for query results (not Dialog Jump)\" doesn't match the condition below: the code only excludes Dialog Jump *left-click* mode (right-click mode can still reach this block). Please update the comment to accurately reflect the behavior being gated here.\n```suggestion\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,375 | comment_to_fix | Fix last opened result not showing in 'Empty Last Query' mode | _⚠️ Potential issue_ | _🟡 Minor_
**Move `_userSelectedRecord.Add(result)` before `Hide()`.**
`Hide()` can re-query immediately in `LastQueryMode.Empty` and `LastQueryMode.ActionKeyword*`, and it is fire-and-forget here. `UpdateResultView()` then uses `_userSelectedRecord` to score rebuilt results on Lines 2302-2311,... | de36eaf07495ca59e62a1c42410577beac6bfeb1 | 654026e66308bf833b0a152abc0ebe3527f963c7 | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index 333ac3652f4..6a4d54f27ab 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -515,8 +515,11 @@ private async Task OpenResultAsync(string index)
retu... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Move `_userSelectedRecord.Add(result)` before `Hide()`.**\n\n`Hide()` can re-query immediately in `LastQueryMode.Empty` and `LastQueryMode.ActionKeyword*`, and it is fire-and-forget here. `UpdateResultView()` then uses `_userSelectedRecord` to score rebuilt r... | true | ||
Flow-Launcher/Flow.Launcher | 4,451 | issue_to_patch | Merge v2.1.2 back to dev | Merge release v2.1.2 back to dev from master
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Back-merges the v2.1.2 release into dev to keep versions aligned. Bumps `Flow.Launcher.Plugin` to 5.3.0 and AppVeyor build to 2.1.2.
**Summary of changes**
- Existing logic/behaviour changed: ... | ecf42cf054c0bb7e6555d1a441668a4b4c8261d9 | 6b191b13f72d3039ccdcc3a97e08d5449af63bd2 | diff --git a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
index d94709d9f91..c230ab26748 100644
--- a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
+++ b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
@@ -15,10 +15,10 @@
</PropertyGroup>
<PropertyGroup... | [
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"appveyor.yml"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,448 | issue_to_patch | Release 2.1.2 | Plugin 5.3.0 | # Release notes
## Bug fixes
- Improve sound handling and show title in volume mixer #4447
- Fix Pinyin search's default to false #4444
- Bump Svg.Skia from 4.5.0 to 4.6.0 #4439
- Bump Svg.Skia from 4.3.0 to 4.5.0 #4436
- Bump toshimaru/auto-author-assign from 3.0.1 to 3.0.2 #4435
- Bump Microsoft.SourceLink.GitHub fr... | 0d9cc7ef831eb95520f3e6168adb513c1c4a2bb0 | 66b4042d3db042f390c03b23b2b0492a2c72307d | diff --git a/.cm/gitstream.cm b/.cm/gitstream.cm
deleted file mode 100644
index 767982e3bcc..00000000000
--- a/.cm/gitstream.cm
+++ /dev/null
@@ -1,80 +0,0 @@
-# -*- mode: yaml -*-
-# This example configuration for provides basic automations to get started with gitStream.
-# View the gitStream quickstart for more examp... | [
".cm/gitstream.cm",
".github/actions/spelling/README.md",
".github/actions/spelling/advice.md",
".github/actions/spelling/allow.txt",
".github/actions/spelling/candidate.patterns",
".github/actions/spelling/excludes.txt",
".github/actions/spelling/expect.txt",
".github/actions/spelling/line_forbidden.... | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,382 | issue_to_patch | Fix highlight data 0 length | Follow #4196
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Fixes missing title highlights when an empty highlight data list is passed by falling back to fuzzy search match data. Applies to both folder and file results to keep highlighting consistent.
- **Summary of changes**
- Cha... | 0a1fc567cf73c8fe5b71814f1ac65ed62cf7465c | d03b6981c741f3e0a8bee62cc06b9d59f1d5c512 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
index 6c33f5ffb63..b73a59bcdc1 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
@@ -145... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,405 | issue_to_patch | Fix icon binding in Plugin Store Settings Pane | ## Change
Use IcoPath instead of non-existent IcoPathAbsolute
(This seems to be an issue only on the current dev branch, not the latest release)
## UI
### Before
<img width="2403" height="1032" alt="image" src="https://github.com/user-attachments/assets/d1c91aea-3dc5-43de-a13a-cee1d8b9ec50" />
### After
... | 3e320d559b1cfbaea6ee55558121f7dd66ed59ba | f949b1c1793b73cd22acc4bf7a87f2844ac753d4 | diff --git a/Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml b/Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml
index 4d37dc93acc..aa027e19ec4 100644
--- a/Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml
+++ b/Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml
@@ -333... | [
"Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | issue_to_patch | History results display actual result icon for Last Opened history style via IcoPath persistence | **Context:**
Display icon on last history results
Follows on with #4042
**Changes:**
- Fixed result highlighting and scrolling when switched to history mode
- Changed the property flow uses to display icons, from IcoPath to new IcoPathAbsolute. This helps IcoPath be serializable while flow uses the constructed... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs
index 2c9b8d4fdbc..9404d110705 100644
--- a/Flow.Launcher.Plugin/Result.cs
+++ b/Flow.Launcher.Plugin/Result.cs
@@ -4,11 +4,13 @@
using System.Threading.Tasks;
using System.Windows.Controls;
using System.Windows.Media;
+using System.Text.Js... | [
"Flow.Launcher.Plugin/Result.cs",
"Flow.Launcher/App.xaml.cs",
"Flow.Launcher/Helper/ResultHelper.cs",
"Flow.Launcher/SettingPages/Views/SettingsPanePluginStore.xaml",
"Flow.Launcher/Storage/HistoryItem.cs",
"Flow.Launcher/Storage/LastOpenedHistoryItem.cs",
"Flow.Launcher/Storage/LastOpenedHistoryResult... | [
{
"comment": "Please check if `h.IcoPath` exists to prevent possible blank icon",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1349,7 +1349,9 @@ private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyI\n Localize.executeQuery(h.Quer... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Please check if `h.IcoPath` exists to prevent possible blank icon | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Please check if `h.IcoPath` exists to prevent possible blank icon",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1349,7 +1349,9 @@ private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyI\n Localize.executeQuery(h.Quer... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | `result.IcoPath` should be absolute path which depends on Flow installed place, plugin version, Flow portable mode, etc. I think here we should use the relative path:
If this icon is inside the directory of the preinstalled plugins, let us store a relative path based on preinstalled plugin directory.
Else if the icon... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "`result.IcoPath` should be absolute path which depends on Flow installed place, plugin version, Flow portable mode, etc. I think here we should use the relative path:\n\nIf this icon is inside the directory of the preinstalled plugins, let us store a relative path based on preinstalled plugin dire... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | >It’s not really a bug. The equality comparison also uses the query, so in scenarios where I type “Ter” and open Terminal, and then type “Term” and open Terminal again, I end up with two history items “Ter” and “Term” both referring to the same application (Terminal), which causes duplicate results.
>As 01Dri said, it... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": ">It’s not really a bug. The equality comparison also uses the query, so in scenarios where I type “Ter” and open Terminal, and then type “Term” and open Terminal again, I end up with two history items “Ter” and “Term” both referring to the same application (Terminal), which causes duplicate result... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Could we mark it as obsolete? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Could we mark it as obsolete?",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1318,68 +1320,78 @@ private void QueryHistory()\n }\n }\n \n- private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems)\n+ private ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**Fix typo: "classses" → "classes".**
Static analysis flagged this spelling error in the documentation.
<details>
<summary>🔎 Proposed fix</summary>
```diff
/// <summary>
- /// Describes a result of a <see cref="Query"/> executed by a plugin.
- /// This or its child cl... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs
index 2c9b8d4fdbc..9404d110705 100644
--- a/Flow.Launcher.Plugin/Result.cs
+++ b/Flow.Launcher.Plugin/Result.cs
@@ -4,11 +4,13 @@
using System.Threading.Tasks;
using System.Windows.Controls;
using System.Windows.Media;
+using System.Text.Js... | [
"Flow.Launcher.Plugin/Result.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Fix typo: \"classses\" → \"classes\".**\n\nStatic analysis flagged this spelling error in the documentation.\n\n\n\n<details>\n<summary>🔎 Proposed fix</summary>\n\n```diff\n /// <summary>\n- /// Describes a result of a <see cref=\"Query\"/> executed b... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**DateTime.Now vs DateTime.UtcNow mismatch.**
The XML doc states "UTC date and time" but the constructor at line 50 uses `DateTime.Now` (local time). Consider using `DateTime.UtcNow` for consistency with the documentation, or update the doc to reflect local time.
<details>
<summary>... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**DateTime.Now vs DateTime.UtcNow mismatch.**\n\nThe XML doc states \"UTC date and time\" but the constructor at line 50 uses `DateTime.Now` (local time). Consider using `DateTime.UtcNow` for consistency with the documentation, or update the doc to reflect loca... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# First, let's find and examine the LastOpenedHistoryResult class definition
fd -t f "LastOpenedHistoryResult.cs" --type=file -x cat -n {}
```
Repository: Flow-Launcher/Flow.Launcher
Length of ... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# First, let's find and examine the LastOpenedHistoryResult class definition\nfd -t f \"LastOpenedHistoryResult.cs\" --type=file -x cat -n {}\n```\n\nRepository: Fl... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟠 Major_
**Potential NullReferenceException if `r.OriginQuery` is null.**
The `Equals` method accesses `r.OriginQuery.TrimmedQuery` without null-checking `OriginQuery`. If a `Result` is passed with a null `OriginQuery`, this will throw.
<details>
<summary>🔎 Proposed fix</summary>
```diff... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Potential NullReferenceException if `r.OriginQuery` is null.**\n\nThe `Equals` method accesses `r.OriginQuery.TrimmedQuery` without null-checking `OriginQuery`. If a `Result` is passed with a null `OriginQuery`, this will throw.\n\n\n\n<details>\n<summary>🔎 ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**Typo in obsolete message.**
"comaptibility" should be "compatibility".
<details>
<summary>🔎 Proposed fix</summary>
```diff
- [Obsolete("For backwards comaptibility. Remove after release v2.3.0")]
+ [Obsolete("For backwards compatibility. Remove after release v2.3... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Typo in obsolete message.**\n\n\"comaptibility\" should be \"compatibility\".\n\n\n\n<details>\n<summary>🔎 Proposed fix</summary>\n\n```diff\n- [Obsolete(\"For backwards comaptibility. Remove after release v2.3.0\")]\n+ [Obsolete(\"For backward... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟠 Major_
**Potential IndexOutOfRangeException if History results are empty.**
When `LoadHistory` is called and `History.Results` is empty, accessing `Results[0]` will throw. Consider adding a bounds check.
<details>
<summary>🔎 Proposed fix</summary>
```diff
SelectedResults =... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Potential IndexOutOfRangeException if History results are empty.**\n\nWhen `LoadHistory` is called and `History.Results` is empty, accessing `Results[0]` will throw. Consider adding a bounds check.\n\n\n\n<details>\n<summary>🔎 Proposed fix</summary>\n\n```di... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Search for non-generic collection types from System.Collections in MainViewModel.cs
# These would be: ArrayList, Hashtable, Queue, Stack, non-generic IEnumerable, ICollection, IList, IDictionar... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for non-generic collection types from System.Collections in MainViewModel.cs\n# These would be: ArrayList, Hashtable, Queue, Stack, non-generic IEnumerable... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _🛠️ Refactor suggestion_ | _🟠 Major_
**Consider ordering by ExecutedDateTime before deduplication.**
For Last Opened style, the current grouping takes the first occurrence of each unique result, but the most recent execution (highest `ExecutedDateTime`) should be preferred. According to the PR discussion, contribut... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "_🛠️ Refactor suggestion_ | _🟠 Major_\n\n**Consider ordering by ExecutedDateTime before deduplication.**\n\nFor Last Opened style, the current grouping takes the first occurrence of each unique result, but the most recent execution (highest `ExecutedDateTime`) should be preferred. According to th... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🔴 Critical_
**Glyph deep copy references wrong object.**
The null check uses `glyphValue` (correctly capturing the source), but the `new GlyphInfo(...)` constructor uses `Glyph.FontFamily` and `Glyph.Glyph`, which reference the property being assigned (not yet initialized), not the captured `... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n**Glyph deep copy references wrong object.**\n\nThe null check uses `glyphValue` (correctly capturing the source), but the `new GlyphInfo(...)` constructor uses `Glyph.FontFamily` and `Glyph.Glyph`, which reference the property being assigned (not yet initia... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Why do we call `RefreshLastOpenedHistoryResults` in `App.xaml.cs`? Can we call it in the constructor of the `MainViewModel` in the original position? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/App.xaml.cs b/Flow.Launcher/App.xaml.cs
index b45bbc5494a..da11380b861 100644
--- a/Flow.Launcher/App.xaml.cs
+++ b/Flow.Launcher/App.xaml.cs
@@ -259,6 +259,9 @@ await API.StopwatchLogInfoAsync(ClassName, "Startup cost", async () =>
await PluginManager.InitializePlugins... | [
"Flow.Launcher/App.xaml.cs"
] | [
{
"comment": "Why do we call `RefreshLastOpenedHistoryResults` in `App.xaml.cs`? Can we call it in the constructor of the `MainViewModel` in the original position?",
"path": "Flow.Launcher/App.xaml.cs",
"hunk": "@@ -259,6 +259,8 @@ await API.StopwatchLogInfoAsync(ClassName, \"Startup cost\", async () =>... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Why do we call `RefreshLastOpenedHistoryResults` in `App.xaml.cs`? Can we call it in this position? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Why do we call `RefreshLastOpenedHistoryResults` in `App.xaml.cs`? Can we call it in this position?",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -152,11 +153,10 @@ public MainViewModel()\n };\n \n _historyItemsStorage = new FlowLauncherJsonStora... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Why do you use the first item instead of the last item as origin? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Why do you use the first item instead of the last item as origin?",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -355,7 +355,11 @@ private void LoadHistory()\n if (QueryResultsSelected())\n {\n SelectedResults = History;\n- ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Do you think we need to consider ordering by ExecutedDateTime before deduplication?
For Last Opened style, the current grouping takes the first occurrence of each unique result, but the most recent execution (highest ExecutedDateTime) should be preferred. According to the PR discussion, contributor 01Dri suggested ord... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Do you think we need to consider ordering by ExecutedDateTime before deduplication?\n\nFor Last Opened style, the current grouping takes the first occurrence of each unique result, but the most recent execution (highest ExecutedDateTime) should be preferred. According to the PR discussion, contrib... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Will the old migrated history items have no title here if query history style is LastOpened? (You can check the previous version) | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Will the old migrated history items have no title here if query history style is LastOpened? (You can check the previous version)",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1318,68 +1322,82 @@ private void QueryHistory()\n }\n }\n \n- priv... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | @Jack251970 you changed the following from SelectedResults
History.SelectedIndex = 0;
History.SelectedItem = History.Results[0];
While functionally no difference but I think we should be adjusting the SelectedResults' index (the target) not the original object Hisotry (source) right? Reads better at least. Ok for ... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "@Jack251970 you changed the following from SelectedResults\r\nHistory.SelectedIndex = 0;\r\nHistory.SelectedItem = History.Results[0];\r\n\r\nWhile functionally no difference but I think we should be adjusting the SelectedResults' index (the target) not the original object Hisotry (source) right? ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟠 Major_
**Add null check for result.OriginQuery parameter.**
The constructor assumes `result.OriginQuery` is not `null` at lines 40-41, but there's no validation. If a `Result` with a null `OriginQuery` is passed, this will throw a `NullReferenceException`. Consider adding a guard clause or ... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Add null check for result.OriginQuery parameter.**\n\nThe constructor assumes `result.OriginQuery` is not `null` at lines 40-41, but there's no validation. If a `Result` with a null `OriginQuery` is passed, this will throw a `NullReferenceException`. Consider... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**Add null check for parameter `r`.**
While the author intentionally allows `r.OriginQuery` to throw if null (per past review discussion), the method should still validate that `r` itself is not null before accessing its properties. Line 103 will throw `NullReferenceException` if `r`... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add null check for parameter `r`.**\n\nWhile the author intentionally allows `r.OriginQuery` to throw if null (per past review discussion), the method should still validate that `r` itself is not null before accessing its properties. Line 103 will throw `Null... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Do you think we should also copy Glyph here? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "Do you think we should also copy Glyph here?",
"path": "Flow.Launcher/Storage/QueryHistory.cs",
"hunk": "@@ -44,23 +88,50 @@ public void Add(Result result)\n LastOpenedHistoryItems.RemoveAt(0);\n }\n \n- // If the last item is the same as the current ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | I think we should also copy Glyph here. | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "I think we should also copy Glyph here.",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1352,6 +1352,18 @@ private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryResult> histor\n if (Settings.HistoryStyle == HistoryStyle.Query)\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Find QueryForPluginAsync implementation in PluginManager
rg -n 'QueryForPluginAsync' --type=cs -B 2 -A 20
```
Repository: Flow-Launcher/Flow.Launcher
Length of output: 5931
---
🏁 Script... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Helper/ResultHelper.cs b/Flow.Launcher/Helper/ResultHelper.cs
index b8b7ff98ec5..017651fdf93 100644
--- a/Flow.Launcher/Helper/ResultHelper.cs
+++ b/Flow.Launcher/Helper/ResultHelper.cs
@@ -11,7 +11,7 @@ namespace Flow.Launcher.Helper;
public static class ResultHelper
{
- public static... | [
"Flow.Launcher/Helper/ResultHelper.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Find QueryForPluginAsync implementation in PluginManager\nrg -n 'QueryForPluginAsync' --type=cs -B 2 -A 20\n```\n\nRepository: Flow-Launcher/Flow.Launcher\n\nL... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Do you think we should also copy Glyph here? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "Do you think we should also copy Glyph here?",
"path": "Flow.Launcher/Storage/QueryHistory.cs",
"hunk": "@@ -44,23 +70,72 @@ public void Add(Result result)\n LastOpenedHistoryItems.RemoveAt(0);\n }\n \n- // If the last item is the same as the current ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | IcoPath shouldn't be null, this should not be necessary. If you just add the default IcoPath and Glyph as history icon when calling the PopulateHistoryFromLegacyHistory then you don't need to assign them here. Why are you setting the default IcoPath in PopulateHistoryFromLegacyHistory as null? | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "IcoPath shouldn't be null, this should not be necessary. If you just add the default IcoPath and Glyph as history icon when calling the PopulateHistoryFromLegacyHistory then you don't need to assign them here. Why are you setting the default IcoPath in PopulateHistoryFromLegacyHistory as null?",
... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | What scenario do we need this for? This is pretty much the same as the add method. | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "What scenario do we need this for? This is pretty much the same as the add method.",
"path": "Flow.Launcher/Storage/QueryHistory.cs",
"hunk": "@@ -44,23 +70,73 @@ public void Add(Result result)\n LastOpenedHistoryItems.RemoveAt(0);\n }\n \n- // If the... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**Missing Glyph update when updating existing history item.**
While the code updates `IcoPath` when different (lines 78-81), it doesn't update `Glyph`. Based on past review comments, `Glyph` should also be reassigned when it differs from the result's Glyph.
<details>
<summary>🔎 P... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Missing Glyph update when updating existing history item.**\n\nWhile the code updates `IcoPath` when different (lines 78-81), it doesn't update `Glyph`. Based on past review comments, `Glyph` should also be reassigned when it differs from the result's Glyph.\... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Set it to null and parse it during runtime | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "Set it to null and parse it during runtime",
"path": "Flow.Launcher/Storage/QueryHistory.cs",
"hunk": "@@ -14,28 +16,52 @@ public class History\n #pragma warning restore CS0618 // Type or member is obsolete\n \n [JsonInclude]\n- public List<LastOpenedHistoryItem> LastOpenedH... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Do not show context menu for history items since their PluginID is empty which can cause issues | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Do not show context menu for history items since their PluginID is empty which can cause issues",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -431,14 +435,17 @@ private void LoadContextMenu()\n {\n // When switch to ContextMenu from QueryResu... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Fix preview panel blank issue | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Fix preview panel blank issue",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -431,14 +435,17 @@ private void LoadContextMenu()\n {\n // When switch to ContextMenu from QueryResults, but no item being chosen, should do nothing\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Fix preview panel blank issue | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Fix preview panel blank issue",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -642,6 +649,8 @@ private void Esc()\n if (!QueryResultsSelected())\n {\n SelectedResults = Results;\n+ PreviewSelectedItem = Results.Select... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Check item plugin ID | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Check item plugin ID",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1252,22 +1261,12 @@ private void QueryContextMenu()\n \n var selected = Results.SelectedItem?.Result;\n \n- if (selected != null) // SelectedItem returns null if selection is empt... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Add selectLast parameter for querying history results in home page | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Add selectLast parameter for querying history results in home page",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1318,68 +1317,100 @@ private void QueryHistory()\n }\n }\n \n- private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistory... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Use history icon under Query History Mode | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Use history icon under Query History Mode",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1318,68 +1317,100 @@ private void QueryHistory()\n }\n }\n \n- private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> historyItems)\n+ ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Use actual icon + history icon badge icon under Last Opened Mode | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Use actual icon + history icon badge icon under Last Opened Mode",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1318,68 +1317,100 @@ private void QueryHistory()\n }\n }\n \n- private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryIt... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Do not record the user selected record for result ranking | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Do not record the user selected record for result ranking",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1318,68 +1317,100 @@ private void QueryHistory()\n }\n }\n \n- private List<Result> GetHistoryItems(IEnumerable<LastOpenedHistoryItem> his... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | Combine get history item for home page logic into `GetHistoryItems` | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "Combine get history item for home page logic into `GetHistoryItems`",
"path": "Flow.Launcher/ViewModel/MainViewModel.cs",
"hunk": "@@ -1617,10 +1648,8 @@ await PluginManager.QueryHomeForPluginAsync(plugin, query, token) :\n \n void QueryHistoryTask(CancellationToken token)\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**Potential NullReferenceException when `r.OriginQuery` is null.**
The method accesses `r.OriginQuery.TrimmedQuery` (lines 137, 143) without verifying `OriginQuery` is not null. If a `Result` with a null `OriginQuery` is passed, this will throw.
While fail-fast is preferred per main... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/LastOpenedHistoryResult.cs b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
new file mode 100644
index 00000000000..7f571b76862
--- /dev/null
+++ b/Flow.Launcher/Storage/LastOpenedHistoryResult.cs
@@ -0,0 +1,146 @@
+using System;
+using Flow.Launcher.Infrastructure;
+using Flow.Lau... | [
"Flow.Launcher/Storage/LastOpenedHistoryResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Potential NullReferenceException when `r.OriginQuery` is null.**\n\nThe method accesses `r.OriginQuery.TrimmedQuery` (lines 137, 143) without verifying `OriginQuery` is not null. If a `Result` with a null `OriginQuery` is passed, this will throw.\n\nWhile fai... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟠 Major_
**Null reference risk when comparing `Glyph` properties.**
Both `existingHistoryItem.Glyph` and `result.Glyph` can be null (the property has no default value in `Result`). Accessing `.Glyph` or `.FontFamily` on a null `GlyphInfo` will throw a `NullReferenceException`.
<details>
<su... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/Storage/QueryHistory.cs b/Flow.Launcher/Storage/QueryHistory.cs
index 6998a4ae3f0..7bf94839925 100644
--- a/Flow.Launcher/Storage/QueryHistory.cs
+++ b/Flow.Launcher/Storage/QueryHistory.cs
@@ -2,6 +2,7 @@
using System.Collections.Generic;
using System.Linq;
using System.Text.Json.Serializ... | [
"Flow.Launcher/Storage/QueryHistory.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Null reference risk when comparing `Glyph` properties.**\n\nBoth `existingHistoryItem.Glyph` and `result.Glyph` can be null (the property has no default value in `Result`). Accessing `.Glyph` or `.FontFamily` on a null `GlyphInfo` will throw a `NullReferenceE... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
# Find the MainViewModel.cs file and check its content around lines 432-449
fd -t f "MainViewModel.cs" --path "*/Flow.Launcher/*" | head -5
```
Repository: Flow-Launcher/Flow.Launcher
Length of output: 304... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher/ViewModel/MainViewModel.cs b/Flow.Launcher/ViewModel/MainViewModel.cs
index a28b2b33e93..ba170feb0be 100644
--- a/Flow.Launcher/ViewModel/MainViewModel.cs
+++ b/Flow.Launcher/ViewModel/MainViewModel.cs
@@ -43,10 +43,10 @@ public partial class MainViewModel : BaseModel, ISavable, IDisposable, ... | [
"Flow.Launcher/ViewModel/MainViewModel.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# Find the MainViewModel.cs file and check its content around lines 432-449\nfd -t f \"MainViewModel.cs\" --path \"*/Flow.Launcher/*\" | head -5\n```\n\nRepository: Flow-Launche... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | This change breaks combability with `Glyph` setters. Take Clipboard+ plugin for example, after upgrade to this version, it cannot work.
<img width="1210" height="659" alt="Image" src="https://github.com/user-attachments/assets/901ff4a9-0a8e-43d8-add3-8c6020cb897e" /> | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs
index 2c9b8d4fdbc..9404d110705 100644
--- a/Flow.Launcher.Plugin/Result.cs
+++ b/Flow.Launcher.Plugin/Result.cs
@@ -4,11 +4,13 @@
using System.Threading.Tasks;
using System.Windows.Controls;
using System.Windows.Media;
+using System.Text.Js... | [
"Flow.Launcher.Plugin/Result.cs"
] | [
{
"comment": "This change breaks combability with `Glyph` setters. Take Clipboard+ plugin for example, after upgrade to this version, it cannot work.\n\n<img width=\"1210\" height=\"659\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/901ff4a9-0a8e-43d8-add3-8c6020cb897e\" />",
"path": "Flow... | true | ||
Flow-Launcher/Flow.Launcher | 4,057 | comment_to_fix | History results display actual result icon for Last Opened history style via IcoPath persistence | _⚠️ Potential issue_ | _🟡 Minor_
**Fix XML doc reference syntax.**
`<IcoPathAbsolute/>` is not valid XML documentation syntax and won't create a proper reference link. Use `<see cref="IcoPathAbsolute"/>` instead.
<details>
<summary>📝 Proposed fix</summary>
```diff
/// <summary>
/// Path or URI... | 8e80c3bde60a903a05ec970a3147680ccac79af6 | 248da93d05120dbe8b99db9afca35eff893f3d9b | diff --git a/Flow.Launcher.Plugin/Result.cs b/Flow.Launcher.Plugin/Result.cs
index 2c9b8d4fdbc..9404d110705 100644
--- a/Flow.Launcher.Plugin/Result.cs
+++ b/Flow.Launcher.Plugin/Result.cs
@@ -4,11 +4,13 @@
using System.Threading.Tasks;
using System.Windows.Controls;
using System.Windows.Media;
+using System.Text.Js... | [
"Flow.Launcher.Plugin/Result.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Fix XML doc reference syntax.**\n\n`<IcoPathAbsolute/>` is not valid XML documentation syntax and won't create a proper reference link. Use `<see cref=\"IcoPathAbsolute\"/>` instead.\n\n\n\n<details>\n<summary>📝 Proposed fix</summary>\n\n```diff\n //... | true | ||
Flow-Launcher/Flow.Launcher | 4,427 | issue_to_patch | Bump Microsoft.Data.Sqlite from 10.0.6 to 10.0.7 | Updated [Microsoft.Data.Sqlite](https://github.com/dotnet/dotnet) from 10.0.6 to 10.0.7.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Data.Sqlite's releases](https://github.com/dotnet/dotnet/releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://... | d0d41c65fc0fae7366ded6b538d5c0129c6523ba | 2159a03064e7d92c1f41fcc7dc833d5d9bb29b4b | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index a5ec839ba74..bb0f57d5616 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,428 | issue_to_patch | Bump Microsoft.SourceLink.GitHub from 10.0.202 to 10.0.203 | Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/dotnet) from 10.0.202 to 10.0.203.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/dotnet/releases)._
## 10.0.203
You can build .NET 10.0 from the repository by cloning the rel... | d0d41c65fc0fae7366ded6b538d5c0129c6523ba | 50b05b3703aaa9c89a689bef49199c53e64f4afb | diff --git a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
index 6893b3fc383..d94709d9f91 100644
--- a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
+++ b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
@@ -72,7 +72,7 @@
<PrivateAssets>all</PrivateAssets>... | [
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"Flow.Launcher.Plugin/packages.lock.json"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,439 | issue_to_patch | Bump Svg.Skia from 4.5.0 to 4.6.0 | Updated [Svg.Skia](https://github.com/wieslawsoltes/Svg.Skia) from 4.5.0 to 4.6.0.
<details>
<summary>Release notes</summary>
_Sourced from [Svg.Skia's releases](https://github.com/wieslawsoltes/Svg.Skia/releases)._
## 4.6.0
## What's Changed
* Add reusable SVG JavaScript runtime by @wieslawsoltes in https://githu... | 4e947273914eadfe9f4861fe1ca7218e8f86f59c | 9df2e73dcf781d48897adce8a76fb1f6ac8a259d | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index a7302215ff9..b0e4019bdc5 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,230 | issue_to_patch | Support for Relative Path for Portable Version
## **Is your feature request related to a problem? Please describe.**
Flow Launcher currently requires **absolute paths** to execute binaries such as Python and Node.js. This creates issues when using the **portable version**, since paths change depending on where Flow L... | Fix relative paths support for Python/Node.js executables | Flow Launcher required absolute paths for Python and Node.js executables, breaking portability when the application is moved. Embedded runtimes within the portable directory structure were not supported.
## CHANGES
- `ResolveAbsolutePath()`: Resolves relative paths to absolute at runtime, based on `ProgramDirecto... | 8c296c19196d617e28a562ec8e8d26eb345c47b6 | 8b6f9f4367d059a1758bfbf3f6607b1bb86156be | diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
index 1a324a9930a..91f3c09c4ee 100644
--- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
+++ b/Flow.Launcher.Core/Exter... | [
"Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs",
"Flow.Launcher.Plugin/SharedCommands/FilesFolders.cs"
] | [
{
"comment": "The ResolveAbsolutePath method doesn't handle exceptions that can be thrown by Path.GetFullPath, such as ArgumentException for invalid path characters, NotSupportedException for invalid path formats, or PathTooLongException. If a user configures an invalid relative path, this could crash the appli... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.