repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Flow-Launcher/Flow.Launcher | 4,230 | comment_to_fix | Fix relative paths support for Python/Node.js executables | <!-- metadata:{"confidence":9,"steps":[{"text":"","toolCalls":[{"toolName":"bash","input":{"command":"rg -n \"ExecutablePath\" \"Flow.Launcher.Core/ExternalPlugins/Environments\""}}]},{"text":"","toolCalls":[{"toolName":"bash","input":{"command":"rg -n \"ResolveAbsolutePath\""}}]},{"text":"","toolCalls":[{"toolName":"b... | 8c296c19196d617e28a562ec8e8d26eb345c47b6 | 8b6f9f4367d059a1758bfbf3f6607b1bb86156be | diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
index 1a324a9930a..91f3c09c4ee 100644
--- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
+++ b/Flow.Launcher.Core/Exter... | [
"Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9,\"steps\":[{\"text\":\"\",\"toolCalls\":[{\"toolName\":\"bash\",\"input\":{\"command\":\"rg -n \\\"ExecutablePath\\\" \\\"Flow.Launcher.Core/ExternalPlugins/Environments\\\"\"}}]},{\"text\":\"\",\"toolCalls\":[{\"toolName\":\"bash\",\"input\":{\"command\":\"rg -n \\... | true | ||
Flow-Launcher/Flow.Launcher | 4,230 | comment_to_fix | Fix relative paths support for Python/Node.js executables | This new property’s summary says “plugin settings file path”, but `PluginsSettingsFilePath` is actually the configured runtime executable path (PythonExecutablePath/NodeExecutablePath in derived classes). Please correct the XML doc to avoid misleading future readers.
```suggestion
/// Resolves the configured ru... | 8c296c19196d617e28a562ec8e8d26eb345c47b6 | 8b6f9f4367d059a1758bfbf3f6607b1bb86156be | diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
index 1a324a9930a..91f3c09c4ee 100644
--- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
+++ b/Flow.Launcher.Core/Exter... | [
"Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs"
] | [
{
"comment": "This new property’s summary says “plugin settings file path”, but `PluginsSettingsFilePath` is actually the configured runtime executable path (PythonExecutablePath/NodeExecutablePath in derived classes). Please correct the XML doc to avoid misleading future readers.\n```suggestion\n /// Re... | true | ||
Flow-Launcher/Flow.Launcher | 4,230 | comment_to_fix | Fix relative paths support for Python/Node.js executables | The inline comment says the path is “updated in settings”, but the code only re-resolves `PluginsSettingsFilePath` to an absolute path and does not persist any update back to settings. Please reword the comment (or actually update the stored setting if that’s intended).
```suggestion
// Re-resolve the p... | 8c296c19196d617e28a562ec8e8d26eb345c47b6 | 8b6f9f4367d059a1758bfbf3f6607b1bb86156be | diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
index 1a324a9930a..91f3c09c4ee 100644
--- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
+++ b/Flow.Launcher.Core/Exter... | [
"Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs"
] | [
{
"comment": "The inline comment says the path is “updated in settings”, but the code only re-resolves `PluginsSettingsFilePath` to an absolute path and does not persist any update back to settings. Please reword the comment (or actually update the stored setting if that’s intended).\n```suggestion\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,230 | comment_to_fix | Fix relative paths support for Python/Node.js executables | PR description says “File picker selections within ProgramDirectory are automatically stored as relative paths”, but this change only resolves relative paths at runtime; it does not add any logic to convert selected absolute paths into relative ones before persisting. If that feature is intended, add a counterpart (e.g... | 8c296c19196d617e28a562ec8e8d26eb345c47b6 | 8b6f9f4367d059a1758bfbf3f6607b1bb86156be | diff --git a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs b/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
index 1a324a9930a..91f3c09c4ee 100644
--- a/Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs
+++ b/Flow.Launcher.Core/Exter... | [
"Flow.Launcher.Core/ExternalPlugins/Environments/AbstractPluginEnvironment.cs"
] | [
{
"comment": "PR description says “File picker selections within ProgramDirectory are automatically stored as relative paths”, but this change only resolves relative paths at runtime; it does not add any logic to convert selected absolute paths into relative ones before persisting. If that feature is intended, ... | true | ||
Flow-Launcher/Flow.Launcher | 4,312 | issue_to_patch | Improve theme class code quality | # CHANGES
* No logical change
* Improved code style, readability, and comments
* Replaced static IsBlurTheme() with IsThemeBlurEnabled(dict) for per-theme blur detection
Separated from #4302
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Refactors theme blur and dark mode hand... | 7a46fac41a31fae6a2905111909f40c52fd56acc | dad8f3e6951f21f1387274b1bb4adf0c9bfcb6c4 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index 4d15857e6fa..fb463b4d4c0 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -124,8 +124,8 @@ public void UpdateFonts()
try
{
// Load a Re... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Fix typo in the inline comment.**\n\nLine 673 uses `windowborderstyle`; use `WindowBorderStyle` for consistency/readability.\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 GitHub Check: Check Spelling</summary>\n\n[warning] 673-673: \n`wi... | true | ||
Flow-Launcher/Flow.Launcher | 4,312 | comment_to_fix | Improve theme class code quality | _⚠️ Potential issue_ | _🟡 Minor_
**Fix typo in the inline comment.**
Line 673 uses `windowborderstyle`; use `WindowBorderStyle` for consistency/readability.
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 GitHub Check: Check Spelling</summary>
[warning] 673-673:
`windowborderstyle` is not a recognize... | 7a46fac41a31fae6a2905111909f40c52fd56acc | dad8f3e6951f21f1387274b1bb4adf0c9bfcb6c4 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index 4d15857e6fa..fb463b4d4c0 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -124,8 +124,8 @@ public void UpdateFonts()
try
{
// Load a Re... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Fix typo in the inline comment.**\n\nLine 673 uses `windowborderstyle`; use `WindowBorderStyle` for consistency/readability.\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 GitHub Check: Check Spelling</summary>\n\n[warning] 673-673: \n`wi... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | issue_to_patch | Refactor drop shadow handling for window border style | # CHANGES
Refactor drop shadow effect logic to create a new Style instance instead of modifying the existing one in-place.
Separated from #4302.
# TEST
* Query window shadow effect still works.
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Refactored drop shadow handli... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs",
"Flow.Launcher.Core/Resource/ThemeHelper.cs"
] | [
{
"comment": "Same issue as in Add: `CopyStyle` already clones setters, but this loop adds the original `setterBase` instances again (and also adds a new Margin setter when a Margin exists). This will create duplicate setters for the same properties and may throw when the style is applied. Prefer `new Style(win... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | Same issue as in Add: `CopyStyle` already clones setters, but this loop adds the original `setterBase` instances again (and also adds a new Margin setter when a Margin exists). This will create duplicate setters for the same properties and may throw when the style is applied. Prefer `new Style(windowBorderStyle.TargetT... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "Same issue as in Add: `CopyStyle` already clones setters, but this loop adds the original `setterBase` instances again (and also adds a new Margin setter when a Margin exists). This will create duplicate setters for the same properties and may throw when the style is applied. Prefer `new Style(win... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | Assigning `Application.Current.Resources["WindowBorderStyle"]` creates a top-level resource that takes precedence over the theme merged dictionary. In `RefreshFrameAsync`, when `BlurEnabled` is true, `AutoDropShadow()` runs before `SetBlurForWindow()`, so this override can prevent `SetBlurForWindow` from updating `Wind... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "Assigning `Application.Current.Resources[\"WindowBorderStyle\"]` creates a top-level resource that takes precedence over the theme merged dictionary. In `RefreshFrameAsync`, when `BlurEnabled` is true, `AutoDropShadow()` runs before `SetBlurForWindow()`, so this override can prevent `SetBlurForWin... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | Same resource-precedence problem as in Add: setting `Application.Current.Resources["WindowBorderStyle"]` here can mask updates that happen later via `UpdateResourceDictionary(dict)` (e.g., blur/backdrop adjustments in `SetBlurForWindow`). If this method is intended to restore the theme-defined style, consider removing ... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "Same resource-precedence problem as in Add: setting `Application.Current.Resources[\"WindowBorderStyle\"]` here can mask updates that happen later via `UpdateResourceDictionary(dict)` (e.g., blur/backdrop adjustments in `SetBlurForWindow`). If this method is intended to restore the theme-defined s... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | `CopyStyle(windowBorderStyle, newWindowBorderStyle)` already copies all setters (including from `BasedOn`), but this method then iterates `windowBorderStyle.Setters` and adds most of them again. That will duplicate setters for the same properties (e.g. Background/BorderThickness), which can throw when the style is seal... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "`CopyStyle(windowBorderStyle, newWindowBorderStyle)` already copies all setters (including from `BasedOn`), but this method then iterates `windowBorderStyle.Setters` and adds most of them again. That will duplicate setters for the same properties (e.g. Background/BorderThickness), which can throw ... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | <!-- metadata:{"confidence":8,"steps":[{"text":"","toolCalls":[{"toolName":"batch","input":{"tool_calls":[{"tool":"bash","parameters":{"command":"rg -n \"GetThemeResourceDictionary|UpdateResourceDictionary|CopyStyle|GetCurrentResourceDictionary|WindowBorderStyle|SetResizeBoarderThickness\" Flow.Launcher.Core/Resource/T... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8,\"steps\":[{\"text\":\"\",\"toolCalls\":[{\"toolName\":\"batch\",\"input\":{\"tool_calls\":[{\"tool\":\"bash\",\"parameters\":{\"command\":\"rg -n \\\"GetThemeResourceDictionary|UpdateResourceDictionary|CopyStyle|GetCurrentResourceDictionary|WindowBorderStyle|SetRes... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | _⚠️ Potential issue_ | _🟠 Major_
**Don’t subtract shadow margin from the baseline theme margin.**
At Lines 573-576, `ShadowExtraMargin` is subtracted from the margin loaded from `GetThemeResourceDictionary(theme)` (baseline style). If a theme already defines a margin, disabling shadow shrinks it (and can go negative... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Don’t subtract shadow margin from the baseline theme margin.**\n\nAt Lines 573-576, `ShadowExtraMargin` is subtracted from the margin loaded from `GetThemeResourceDictionary(theme)` (baseline style). If a theme already defines a margin, disabling shadow shrin... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | _⚠️ Potential issue_ | _🔴 Critical_
**Critical: Setters are added twice, causing duplicates.**
`ThemeHelper.CopyStyle` at line 488 already copies all setters from `windowBorderStyle` to `newWindowBorderStyle`. The subsequent loop (lines 492-509) then adds the same setters again (excluding Margin and Effect), resulti... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n**Critical: Setters are added twice, causing duplicates.**\n\n`ThemeHelper.CopyStyle` at line 488 already copies all setters from `windowBorderStyle` to `newWindowBorderStyle`. The subsequent loop (lines 492-509) then adds the same setters again (excluding M... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | <!-- metadata:{"confidence":8} -->
P2: `CopyStyle` already clones the setters, so this second setter-copy pass leaves duplicate setters and does not truly replace/remove `Margin` or `Effect`.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and ... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP2: `CopyStyle` already clones the setters, so this second setter-copy pass leaves duplicate setters and does not truly replace/remove `Margin` or `Effect`.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so,... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | <!-- metadata:{"confidence":9} -->
P2: Remove the shadow from the active `WindowBorderStyle`, not a freshly reloaded theme style. As written, a theme-defined border margin is restored 32px too small after a shadow toggle.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, ... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9} -->\nP2: Remove the shadow from the active `WindowBorderStyle`, not a freshly reloaded theme style. As written, a theme-defined border margin is restored 32px too small after a shadow toggle.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck i... | true | ||
Flow-Launcher/Flow.Launcher | 4,318 | comment_to_fix | Refactor drop shadow handling for window border style | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
rg -n -C3 'Application\.Current\.Resources\["WindowBorderStyle"\]|UpdateResourceDictionary\(dict\)|Style="\{DynamicResource WindowBorderStyle\}"' \
Flow.Launcher.Core/Resource/Theme.cs \
Flow... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3c8266126268f4e0aa6144cbcb6f331d6412bfb8 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..a32a59b486e 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -477,76 +477,114 @@ public bool ChangeTheme(string theme = null)
public void AddDropShadowEff... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nrg -n -C3 'Application\\.Current\\.Resources\\[\"WindowBorderStyle\"\\]|UpdateResourceDictionary\\(dict\\)|Style=\"\\{DynamicResource WindowBorderStyle\\}\"' \\\n ... | true | ||
Flow-Launcher/Flow.Launcher | 4,319 | issue_to_patch | Freeze SolidColorBrush to improve performance | Refactor background brush creation to assign, freeze, and reuse SolidColorBrush instances for better WPF performance.
Separated from #4302
Test: All types of themes work as expected.
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Freezes SolidColorBrush instances, switches ... | dda900041acb1a7632daa68544f5c9e20b09a18d | 7766d7053da399ec1dabeb752566dd6a86066592 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index c3bb6190f01..4d15857e6fa 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -673,13 +673,13 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType)
... | [
"Flow.Launcher.Core/Resource/Theme.cs",
"Flow.Launcher.Core/Resource/ThemeHelper.cs"
] | [
{
"comment": "The style being modified targets `Border` (see `BaseWindowBorderStyle` in XAML), but this removal looks for `Control.BackgroundProperty`. That will not match an existing `Border.Background` setter, so `FirstOrDefault` returns null and `Setters.Remove(null)` can throw `ArgumentNullException`, and/o... | true | ||
Flow-Launcher/Flow.Launcher | 4,319 | comment_to_fix | Freeze SolidColorBrush to improve performance | The style being modified targets `Border` (see `BaseWindowBorderStyle` in XAML), but this removal looks for `Control.BackgroundProperty`. That will not match an existing `Border.Background` setter, so `FirstOrDefault` returns null and `Setters.Remove(null)` can throw `ArgumentNullException`, and/or leave duplicate back... | dda900041acb1a7632daa68544f5c9e20b09a18d | 7766d7053da399ec1dabeb752566dd6a86066592 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index c3bb6190f01..4d15857e6fa 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -673,13 +673,13 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType)
... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "The style being modified targets `Border` (see `BaseWindowBorderStyle` in XAML), but this removal looks for `Control.BackgroundProperty`. That will not match an existing `Border.Background` setter, so `FirstOrDefault` returns null and `Setters.Remove(null)` can throw `ArgumentNullException`, and/o... | true | ||
Flow-Launcher/Flow.Launcher | 4,319 | comment_to_fix | Freeze SolidColorBrush to improve performance | Same issue as above: this searches for `Control.BackgroundProperty` in a `Border` style, so the existing `Border.Background` setter likely won't be found. This can cause `Setters.Remove(null)` to throw and/or result in multiple background setters. Prefer `Border.BackgroundProperty` and only call `Remove` when a matchin... | dda900041acb1a7632daa68544f5c9e20b09a18d | 7766d7053da399ec1dabeb752566dd6a86066592 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index c3bb6190f01..4d15857e6fa 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -673,13 +673,13 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType)
... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "Same issue as above: this searches for `Control.BackgroundProperty` in a `Border` style, so the existing `Border.Background` setter likely won't be found. This can cause `Setters.Remove(null)` to throw and/or result in multiple background setters. Prefer `Border.BackgroundProperty` and only call `... | true | ||
Flow-Launcher/Flow.Launcher | 4,319 | comment_to_fix | Freeze SolidColorBrush to improve performance | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
echo "Inspect WindowBorderStyle target types and background setters in theme XAML:"
rg -n -C2 --glob 'Flow.Launcher/Themes/*.xaml' \
'x:Key="WindowBorderStyle"|TargetType="\{... | dda900041acb1a7632daa68544f5c9e20b09a18d | 7766d7053da399ec1dabeb752566dd6a86066592 | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index c3bb6190f01..4d15857e6fa 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -673,13 +673,13 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType)
... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"Inspect WindowBorderStyle target types and background setters in theme XAML:\"\nrg -n -C2 --glob 'Flow.Launcher/Themes/*.xaml' \\\n 'x:... | true | ||
Flow-Launcher/Flow.Launcher | 4,330 | issue_to_patch | Refactor AutoDropShadow logic for clarity and correctness | Separated from #4302.
# TEST
* Query window shadow effect still works.
<!-- This is an auto-generated description by cubic. -->
## Summary by cubic
**Summary of changes**
Refactors AutoDropShadow to remove redundant calls and make the blur/backdrop vs. shadow behavior explicit and correct. Improves readability ... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | b5d372ed4b9369019674551330920e71ab92ff8b | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..bcb7f268515 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -706,30 +706,27 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType)
pr... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "`AutoDropShadow` no longer clears any existing drop shadow before calling `AddDropShadowEffectToCurrentTheme()` in the non-blur path. Since `AddDropShadowEffectToCurrentTheme()` unconditionally appends a new `UIElement.Effect` setter and also increases the margin, repeated calls to `AutoDropShadow... | true | ||
Flow-Launcher/Flow.Launcher | 4,330 | comment_to_fix | Refactor AutoDropShadow logic for clarity and correctness | `AutoDropShadow` no longer clears any existing drop shadow before calling `AddDropShadowEffectToCurrentTheme()` in the non-blur path. Since `AddDropShadowEffectToCurrentTheme()` unconditionally appends a new `UIElement.Effect` setter and also increases the margin, repeated calls to `AutoDropShadow(true)` can accumulate... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | b5d372ed4b9369019674551330920e71ab92ff8b | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..bcb7f268515 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -706,30 +706,27 @@ private void SetBlurForWindow(string theme, BackdropTypes backdropType)
pr... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "`AutoDropShadow` no longer clears any existing drop shadow before calling `AddDropShadowEffectToCurrentTheme()` in the non-blur path. Since `AddDropShadowEffectToCurrentTheme()` unconditionally appends a new `UIElement.Effect` setter and also increases the margin, repeated calls to `AutoDropShadow... | true | ||
Flow-Launcher/Flow.Launcher | 4,331 | issue_to_patch | Refactor theme resource dictionary retrieval logic | # CHANGES
No need to update the resource dictionary in this place. Since it will be updated later in this function.
Separated from #4302.
# TEST
* Changing themes still works.
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Refactors theme resource dictionary handling ... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | c0134d56921f994f3578edaf03dfc10c9437d47a | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..dd5762a08fe 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -418,11 +418,6 @@ public bool ChangeTheme(string theme = null)
if (string.IsNullOrEmpty... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "`ChangeTheme` no longer applies/validates the full theme dictionary (via `GetResourceDictionary` + `UpdateResourceDictionary`) inside its try/catch. Because resource application now effectively happens later in `RefreshFrameAsync`/`SetBlurForWindow`, any exceptions from `GetResourceDictionary` (e.... | true | ||
Flow-Launcher/Flow.Launcher | 4,331 | comment_to_fix | Refactor theme resource dictionary retrieval logic | `ChangeTheme` no longer applies/validates the full theme dictionary (via `GetResourceDictionary` + `UpdateResourceDictionary`) inside its try/catch. Because resource application now effectively happens later in `RefreshFrameAsync`/`SetBlurForWindow`, any exceptions from `GetResourceDictionary` (e.g., missing required k... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | c0134d56921f994f3578edaf03dfc10c9437d47a | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..dd5762a08fe 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -418,11 +418,6 @@ public bool ChangeTheme(string theme = null)
if (string.IsNullOrEmpty... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "`ChangeTheme` no longer applies/validates the full theme dictionary (via `GetResourceDictionary` + `UpdateResourceDictionary`) inside its try/catch. Because resource application now effectively happens later in `RefreshFrameAsync`/`SetBlurForWindow`, any exceptions from `GetResourceDictionary` (e.... | true | ||
Flow-Launcher/Flow.Launcher | 4,331 | comment_to_fix | Refactor theme resource dictionary retrieval logic | _⚠️ Potential issue_ | _🟠 Major_
**Restore synchronous theme dictionary application here.**
Lines 430-434 now only compute `BlurEnabled`; the actual `MergedDictionaries` swap is deferred to `RefreshFrameAsync()` via `SetBlurForWindow()`. That changes `ChangeTheme()` from “theme applied on return” to “theme scheduled... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | c0134d56921f994f3578edaf03dfc10c9437d47a | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..dd5762a08fe 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -418,11 +418,6 @@ public bool ChangeTheme(string theme = null)
if (string.IsNullOrEmpty... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Restore synchronous theme dictionary application here.**\n\nLines 430-434 now only compute `BlurEnabled`; the actual `MergedDictionaries` swap is deferred to `RefreshFrameAsync()` via `SetBlurForWindow()`. That changes `ChangeTheme()` from “theme applied on r... | true | ||
Flow-Launcher/Flow.Launcher | 4,331 | comment_to_fix | Refactor theme resource dictionary retrieval logic | <!-- metadata:{"confidence":8} -->
P2: `ChangeTheme` now returns success before the theme resource is actually applied, so async apply failures can be missed and leave state inconsistent.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix ... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | c0134d56921f994f3578edaf03dfc10c9437d47a | diff --git a/Flow.Launcher.Core/Resource/Theme.cs b/Flow.Launcher.Core/Resource/Theme.cs
index fb463b4d4c0..dd5762a08fe 100644
--- a/Flow.Launcher.Core/Resource/Theme.cs
+++ b/Flow.Launcher.Core/Resource/Theme.cs
@@ -418,11 +418,6 @@ public bool ChangeTheme(string theme = null)
if (string.IsNullOrEmpty... | [
"Flow.Launcher.Core/Resource/Theme.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP2: `ChangeTheme` now returns success before the theme resource is actually applied, so async apply failures can be missed and leave state inconsistent.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, und... | true | ||
Flow-Launcher/Flow.Launcher | 4,333 | issue_to_patch | Bump Svg.Skia from 3.4.1 to 3.5.0 | Updated [Svg.Skia](https://github.com/wieslawsoltes/Svg.Skia) from 3.4.1 to 3.5.0.
<details>
<summary>Release notes</summary>
_Sourced from [Svg.Skia's releases](https://github.com/wieslawsoltes/Svg.Skia/releases)._
## 3.5.0
## What's Changed
* Add Android VectorDrawable import support by @wieslawsoltes in https:/... | 916b4ff09136b4cb6ab5258248486639b7b631f1 | 3e493263c3b377330239546c72f922fd4739c93f | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index aff73ea7780..b8d5d89bd7e 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | issue_to_patch | Use Highlight matches from Everything | To solve inaccurate highlight in some cases.
<img width="924" height="193" alt="Clip_20260322_162229" src="https://github.com/user-attachments/assets/1b1c5d40-9eda-4297-8357-c7e1ab08e6ba" />
Our FuzzySearch() doesn't match the same highlight as Everything so sometimes the highlight looks weird. | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
index a4e959dd9c4..a786284699b 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explore... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs",
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs",
"Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs",
"Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# Find the file and verify the method exists with the typo\nfind . -type f -name \"EverythingAPI.cs\" | head -5\n```\n\nRepository: Flow-Launcher/Flow.Launcher\n\nLength of outp... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
# Find the file and verify the method exists with the typo
find . -type f -name "EverythingAPI.cs" | head -5
```
Repository: Flow-Launcher/Flow.Launcher
Length of output: 145
---
🏁 Script executed:
```... | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
index a4e959dd9c4..a786284699b 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explore... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# Find the file and verify the method exists with the typo\nfind . -type f -name \"EverythingAPI.cs\" | head -5\n```\n\nRepository: Flow-Launcher/Flow.Launcher\n\nLength of outp... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | The documentation comment should specify the return type. Add a description after the returns tag to indicate that this method returns a list of zero-based character indices that should be highlighted.
```suggestion
/// <returns>A list of zero-based character indices that should be highlighted.</returns>
``` | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
index a4e959dd9c4..a786284699b 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explore... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs"
] | [
{
"comment": "The documentation comment should specify the return type. Add a description after the returns tag to indicate that this method returns a list of zero-based character indices that should be highlighted.\n```suggestion\n /// <returns>A list of zero-based character indices that should be highl... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | The explicit parameterless constructor is unnecessary. Record structs with init-only properties automatically provide a parameterless constructor. This empty constructor adds no functionality and can be removed.
```suggestion
``` | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs
index 3cd97df8277..e2ff216cafd 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs
@@ -1,11 +1... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs"
] | [
{
"comment": "The explicit parameterless constructor is unnecessary. Record structs with init-only properties automatically provide a parameterless constructor. This empty constructor adds no functionality and can be removed.\n```suggestion\n\n```",
"path": "Plugins/Flow.Launcher.Plugin.Explorer/Search/Sear... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | The new public method `EverythingHighlightStringToHighlightList` lacks test coverage. Given the complexity of parsing highlight strings with special characters (consecutive asterisks for literal asterisks, toggle behavior for single asterisks), this method should have comprehensive unit tests to verify correct behavior... | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
index a4e959dd9c4..a786284699b 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explore... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs"
] | [
{
"comment": "The new public method `EverythingHighlightStringToHighlightList` lacks test coverage. Given the complexity of parsing highlight strings with special characters (consecutive asterisks for literal asterisks, toggle behavior for single asterisks), this method should have comprehensive unit tests to v... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | The parameter name 'HighlightData' should follow C# naming conventions and be in camelCase. It should be 'highlightData' instead of 'HighlightData'. | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
index 7bfe30a287a..6c33f5ffb63 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
@@ -106... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs"
] | [
{
"comment": "The parameter name 'HighlightData' should follow C# naming conventions and be in camelCase. It should be 'highlightData' instead of 'HighlightData'.",
"path": "Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs",
"hunk": "@@ -92,15 +93,15 @@ internal static void ShowNativeContex... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | The parameter name 'HighlightData' should follow C# naming conventions and be in camelCase. It should be 'highlightData' instead of 'HighlightData'.
```suggestion
internal static Result CreateFileResult(string filePath, Query query, int score = 0, bool windowsIndexed = false, List<int> highlightData = null)
``` | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
index 7bfe30a287a..6c33f5ffb63 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
@@ -106... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs"
] | [
{
"comment": "The parameter name 'HighlightData' should follow C# naming conventions and be in camelCase. It should be 'highlightData' instead of 'HighlightData'.\n```suggestion\n internal static Result CreateFileResult(string filePath, Query query, int score = 0, bool windowsIndexed = false, List<int> h... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | The initialization '= null' is redundant. Reference types in C# are already null by default, and explicitly assigning null doesn't add clarity here since the nullable annotation isn't used.
```suggestion
public List<int> HighlightData { get; init; }
``` | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs
index 3cd97df8277..e2ff216cafd 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs
@@ -1,11 +1... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchResult.cs"
] | [
{
"comment": "The initialization '= null' is redundant. Reference types in C# are already null by default, and explicitly assigning null doesn't add clarity here since the nullable annotation isn't used.\n```suggestion\n public List<int> HighlightData { get; init; }\n```",
"path": "Plugins/Flow.Launc... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | Replace this call with a call to managed code if possible.
```suggestion
Score = Convert.ToInt32(EverythingApiDllImport.Everything_GetResultRunCount((uint)idx)),
``` | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
index a4e959dd9c4..a786284699b 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explore... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs"
] | [
{
"comment": "Replace this call with a call to managed code if possible.\n```suggestion\n Score = Convert.ToInt32(EverythingApiDllImport.Everything_GetResultRunCount((uint)idx)),\n```",
"path": "Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs",
"hunk": "@@... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | Replace this call with a call to managed code if possible. | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
index a4e959dd9c4..a786284699b 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explore... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs"
] | [
{
"comment": "Replace this call with a call to managed code if possible.",
"path": "Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingAPI.cs",
"hunk": "@@ -157,7 +157,8 @@ public static async IAsyncEnumerable<SearchResult> SearchAsync(EverythingSearchO\n Type = Ev... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | Minimise the use of unmanaged code.
```suggestion
private static extern IntPtr Everything_GetResultHighlightedFileNameNative(uint nIndex);
public static string Everything_GetResultHighlightedFileName(uint nIndex)
{
IntPtr ptr = Everything_GetResultHighlightedFileNameNative(nIndex);
... | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs
index 70c02cd87aa..344c1a42c16 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs
+++ b/Plugins/F... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingApiDllImport.cs"
] | [
{
"comment": "Minimise the use of unmanaged code.\n```suggestion\n private static extern IntPtr Everything_GetResultHighlightedFileNameNative(uint nIndex);\n\n public static string Everything_GetResultHighlightedFileName(uint nIndex)\n {\n IntPtr ptr = Everything_GetResultHighlig... | true | ||
Flow-Launcher/Flow.Launcher | 4,196 | comment_to_fix | Use Highlight matches from Everything | Is it a simple change to have the other search engine pass highlightData instead of calling it here? I think when FuzzySearch is used it will also contain the MatchData which, you can the assign to the SearchResult object. | f8cf6b08b3b49ac5b6f584f34d724bfcb9466d8e | 205f433f5359e67375d2a6a0a9e6124477908254 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
index 7bfe30a287a..6c33f5ffb63 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs
@@ -106... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs"
] | [
{
"comment": "Is it a simple change to have the other search engine pass highlightData instead of calling it here? I think when FuzzySearch is used it will also contain the MatchData which, you can the assign to the SearchResult object.",
"path": "Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.c... | true | ||
Flow-Launcher/Flow.Launcher | 4,339 | issue_to_patch | BUG: Exception when setting Folder Search action in Explorer plugin
### Checks
- [x] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
Exception when setting Folder ... | Fix ArgumentException when editing a disabled Explorer action keyword | Resolve #4289
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
**Summary of changes**
Fixes an ArgumentException when editing a disabled action keyword in `Flow.Launcher.Plugin.Explorer` and prevents a potential NullReferenceException. The Action Keyword dialog now updates as you type ... | 24f6c90f727e28ad1ab7fb26754fc004bea378b6 | 531b45210ae2c5d8b68db3e0770b0fa8d00f14df | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs
index e65c03e9be1..08e0015d4e1 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs
@@ -230,7 +230,7 @@ internal enum ActionKeyword
... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Settings.cs",
"Plugins/Flow.Launcher.Plugin.Explorer/ViewModels/SettingsViewModel.cs",
"Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml",
"Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Updating the binding source on every keystroke can unintentionally enable a disabled keyword even when the final text is unchanged.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root ... | true | |
Flow-Launcher/Flow.Launcher | 4,339 | comment_to_fix | Fix ArgumentException when editing a disabled Explorer action keyword | <!-- metadata:{"confidence":8} -->
P2: Updating the binding source on every keystroke can unintentionally enable a disabled keyword even when the final text is unchanged.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it. At Plugins/Fl... | 24f6c90f727e28ad1ab7fb26754fc004bea378b6 | 531b45210ae2c5d8b68db3e0770b0fa8d00f14df | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml b/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml
index ae0f91d93a8..10a701061d5 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml
+++ b/Plugins/Flow.Launcher.Plugin.Explorer/Views/A... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Views/ActionKeywordSetting.xaml"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP2: Updating the binding source on every keystroke can unintentionally enable a disabled keyword even when the final text is unchanged.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root ... | true | ||
Flow-Launcher/Flow.Launcher | 4,338 | issue_to_patch | BUG: Error on constructing ReportWindow
### Checks
- [ ] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
Flow Launcher version: 2.1.0
OS Version: 26200.7840
IntPtr... | Fix ReportWindow crash when log directory is empty or missing | Resolve #4326
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
**Summary of changes**
Fixes a crash in ReportWindow when the log directory is missing, empty, or unreadable by safely handling IO errors and absent log files. The UI only prompts to upload a log when a log file exists.
**B... | 24f6c90f727e28ad1ab7fb26754fc004bea378b6 | b1d98f60dd1d4c60bc848a8131e787244a8e0cfc | diff --git a/Flow.Launcher/ReportWindow.xaml.cs b/Flow.Launcher/ReportWindow.xaml.cs
index bb0ce0073cf..b2c95cbe2e8 100644
--- a/Flow.Launcher/ReportWindow.xaml.cs
+++ b/Flow.Launcher/ReportWindow.xaml.cs
@@ -38,9 +38,20 @@ private static string GetIssuesUrl(string website)
private void SetException(Exceptio... | [
"Flow.Launcher/ReportWindow.xaml.cs"
] | [
{
"comment": "The `catch (Exception)` intentionally swallows all errors here, but the inline comment says \"Ignore IO errors\". Either narrow the catch to expected filesystem-related exceptions, or update the comment to reflect that all exceptions are being swallowed to avoid secondary crashes in the report win... | true | |
Flow-Launcher/Flow.Launcher | 4,338 | comment_to_fix | Fix ReportWindow crash when log directory is empty or missing | The `catch (Exception)` intentionally swallows all errors here, but the inline comment says "Ignore IO errors". Either narrow the catch to expected filesystem-related exceptions, or update the comment to reflect that all exceptions are being swallowed to avoid secondary crashes in the report window.
```suggestion
... | 24f6c90f727e28ad1ab7fb26754fc004bea378b6 | b1d98f60dd1d4c60bc848a8131e787244a8e0cfc | diff --git a/Flow.Launcher/ReportWindow.xaml.cs b/Flow.Launcher/ReportWindow.xaml.cs
index bb0ce0073cf..b2c95cbe2e8 100644
--- a/Flow.Launcher/ReportWindow.xaml.cs
+++ b/Flow.Launcher/ReportWindow.xaml.cs
@@ -38,9 +38,20 @@ private static string GetIssuesUrl(string website)
private void SetException(Exceptio... | [
"Flow.Launcher/ReportWindow.xaml.cs"
] | [
{
"comment": "The `catch (Exception)` intentionally swallows all errors here, but the inline comment says \"Ignore IO errors\". Either narrow the catch to expected filesystem-related exceptions, or update the comment to reflect that all exceptions are being swallowed to avoid secondary crashes in the report win... | true | ||
Flow-Launcher/Flow.Launcher | 4,341 | issue_to_patch | Fix settings window is minimized when re-opened. | Currently if settings window is closed when minimized, it stays minimized the next time you open it. It's a bad UX design.
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Prevents the Settings window from reopening minimized. We stop saving the minimized state and normalize it to Norma... | a406eb83e1618c7f95510b27b55e87d3731d6d0c | 121084f4c1db0d4346a307a308fbb9760c297774 | diff --git a/Flow.Launcher/SettingWindow.xaml.cs b/Flow.Launcher/SettingWindow.xaml.cs
index a318592a6bd..054c60c8a7e 100644
--- a/Flow.Launcher/SettingWindow.xaml.cs
+++ b/Flow.Launcher/SettingWindow.xaml.cs
@@ -96,7 +96,7 @@ private void OnCloseExecuted(object sender, ExecutedRoutedEventArgs e)
private void Wind... | [
"Flow.Launcher/SettingWindow.xaml.cs"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,343 | issue_to_patch | Bump Microsoft.Data.Sqlite from 10.0.3 to 10.0.4 | Updated [Microsoft.Data.Sqlite](https://github.com/dotnet/dotnet) from 10.0.3 to 10.0.4.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Data.Sqlite's releases](https://github.com/dotnet/dotnet/releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://... | e8353f7648a9257a90aa4218b16f48282893f02b | 90bd7d336e92a6b11db72323937ed4750c294f67 | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index b8d5d89bd7e..966a9362367 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,354 | issue_to_patch | dev: renamed file type Quick Access Links do not display the new names
### Checks
- [ ] I have checked that this issue has not already been reported.
- [ ] I am using the latest version of Flow Launcher.
- [x] I am using the prerelease version of Flow Launcher.
### Problem Description
Dev branch, renamed Quick A... | Fix Quick Access Links of type File ignoring custom name in search results | Fixes #3772
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Summary of changes
Fixes file-type Quick Access Links ignoring custom names by passing the saved link name into `ResultManager.CreateFileResult`, so search results display the custom title.
- Changed: `QuickAccess.AccessLink... | 86d7c1e06f742afda12e83808b25b104e9b2214c | d0c30dfcb5721f62cc3e8a1ea19b591acd3bb7b7 | diff --git a/Plugins/Flow.Launcher.Plugin.Explorer/Search/QuickAccessLinks/QuickAccess.cs b/Plugins/Flow.Launcher.Plugin.Explorer/Search/QuickAccessLinks/QuickAccess.cs
index 32651ecb8a7..fcf07a46b8d 100644
--- a/Plugins/Flow.Launcher.Plugin.Explorer/Search/QuickAccessLinks/QuickAccess.cs
+++ b/Plugins/Flow.Launcher.Pl... | [
"Plugins/Flow.Launcher.Plugin.Explorer/Search/QuickAccessLinks/QuickAccess.cs",
"Plugins/Flow.Launcher.Plugin.Explorer/Search/ResultManager.cs"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Handle empty custom names in fallback logic.**\n\nOn Line 288, an empty/whitespace `name` is treated as a valid title, which can render blank file result titles. Fallback should apply for null *and* empty/whitespace values.\n\n<details>\n<summary>Suggested fi... | true | |
Flow-Launcher/Flow.Launcher | 4,351 | issue_to_patch | Bump Microsoft.SourceLink.GitHub from 10.0.200 to 10.0.201 | Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/dotnet) from 10.0.200 to 10.0.201.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/dotnet/releases)._
## 10.0.201
You can build .NET 10.0 from the repository by cloning the rel... | 2d1579d4d9dfa70b4f1e3a1b45c30f5359dff7f2 | 54075f2de8c3e623c21eba1f5148330bc02dfb3c | diff --git a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
index 1a632dd0290..95094898dc9 100644
--- a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
+++ b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
@@ -72,7 +72,7 @@
<PrivateAssets>all</PrivateAssets>... | [
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"Flow.Launcher.Plugin/packages.lock.json"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,350 | issue_to_patch | Bump Microsoft.Data.Sqlite from 10.0.4 to 10.0.5 | Updated [Microsoft.Data.Sqlite](https://github.com/dotnet/dotnet) from 10.0.4 to 10.0.5.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Data.Sqlite's releases](https://github.com/dotnet/dotnet/releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://... | 2d1579d4d9dfa70b4f1e3a1b45c30f5359dff7f2 | 81c227618a82d961be29a5e6582d5979d3a1f184 | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index 5c58c7013e1..61a56669824 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,346 | issue_to_patch | Bump Svg.Skia from 3.5.0 to 3.6.0 | Updated [Svg.Skia](https://github.com/wieslawsoltes/Svg.Skia) from 3.5.0 to 3.6.0.
<details>
<summary>Release notes</summary>
_Sourced from [Svg.Skia's releases](https://github.com/wieslawsoltes/Svg.Skia/releases)._
## 3.6.0
Commits viewable in [compare view](https://github.com/wieslawsoltes/Svg.Skia/compare/v3.5... | e6f8f182c59e4c58232fc3d0a0c79dac4808c6ac | 35926d59aacfafcb62748d205323326d6431bf8e | diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj
index 966a9362367..5c58c7013e1 100644
--- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.c... | [
"Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,344 | issue_to_patch | Bump Microsoft.SourceLink.GitHub from 10.0.103 to 10.0.200 | Updated [Microsoft.SourceLink.GitHub](https://github.com/dotnet/dotnet) from 10.0.103 to 10.0.200.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.SourceLink.GitHub's releases](https://github.com/dotnet/dotnet/releases)._
## 10.0.200
You can build .NET 10.0 from the repository by cloning the rel... | e8353f7648a9257a90aa4218b16f48282893f02b | 84dbb779c8d85547c94efab26504b0fa53eb5671 | diff --git a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
index 378d4306afe..1a632dd0290 100644
--- a/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
+++ b/Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
@@ -72,7 +72,7 @@
<PrivateAssets>all</PrivateAssets>... | [
"Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj",
"Flow.Launcher.Plugin/packages.lock.json"
] | [] | true | ||
Flow-Launcher/Flow.Launcher | 4,355 | issue_to_patch | BUG: cannot install PluginManager
### Checks
- [ ] I have checked that this issue has not already been reported.
- [x] I am using the latest version of Flow Launcher.
- [ ] I am using the prerelease version of Flow Launcher.
### Problem Description
Hello,
I freshly installed the Flowmanager with chosolatey and t... | Ensure plugin manifest is non-nullable | Resolve #4251
<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Ensures `GetPluginManifest` always returns a non-null list. Simplifies callers, clarifies docs/comments, and removes null checks in the plugin store view.
- **Summary of changes**
- Changed: `IPublicAPI.GetPluginManifest`... | 86d7c1e06f742afda12e83808b25b104e9b2214c | 015c32ed9c113b714307a72a36ca0a9b7df3506b | diff --git a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
index 93844159f75..0af37d9d59b 100644
--- a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
+++ b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
@@ -533,12 +533,12 @@ public interface IPublicAPI
public Task<... | [
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs",
"Flow.Launcher/PublicAPIInstance.cs",
"Flow.Launcher/SettingPages/ViewModels/SettingsPanePluginStoreViewModel.cs"
] | [
{
"comment": "The XML docs for `GetPluginManifest()` were updated by removing the old remark about returning null, but they don’t state the new contract (non-null return). Since `PublicAPIInstance.GetPluginManifest()` now returns an empty list when the manifest hasn’t been loaded/updated, please document that b... | true | |
Flow-Launcher/Flow.Launcher | 4,355 | comment_to_fix | Ensure plugin manifest is non-nullable | The XML docs for `GetPluginManifest()` were updated by removing the old remark about returning null, but they don’t state the new contract (non-null return). Since `PublicAPIInstance.GetPluginManifest()` now returns an empty list when the manifest hasn’t been loaded/updated, please document that behavior here (e.g., th... | 86d7c1e06f742afda12e83808b25b104e9b2214c | 015c32ed9c113b714307a72a36ca0a9b7df3506b | diff --git a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
index 93844159f75..0af37d9d59b 100644
--- a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
+++ b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
@@ -533,12 +533,12 @@ public interface IPublicAPI
public Task<... | [
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs"
] | [
{
"comment": "The XML docs for `GetPluginManifest()` were updated by removing the old remark about returning null, but they don’t state the new contract (non-null return). Since `PublicAPIInstance.GetPluginManifest()` now returns an empty list when the manifest hasn’t been loaded/updated, please document that b... | true | ||
Flow-Launcher/Flow.Launcher | 4,355 | comment_to_fix | Ensure plugin manifest is non-nullable | <!-- metadata:{"confidence":9} -->
P3: The new return docs incorrectly say a failed manifest refresh can make this API return an empty list; in practice it keeps returning the last successful manifest. That can mislead plugin authors into using `Count == 0` as a failure signal.
<details>
<summary>Prompt for AI agents<... | 86d7c1e06f742afda12e83808b25b104e9b2214c | 015c32ed9c113b714307a72a36ca0a9b7df3506b | diff --git a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
index 93844159f75..0af37d9d59b 100644
--- a/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
+++ b/Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
@@ -533,12 +533,12 @@ public interface IPublicAPI
public Task<... | [
"Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9} -->\nP3: The new return docs incorrectly say a failed manifest refresh can make this API return an empty list; in practice it keeps returning the last successful manifest. That can mislead plugin authors into using `Count == 0` as a failure signal.\n\n<details>\n<s... | true | ||
FluentValidation/FluentValidation | 2,358 | issue_to_patch | feat(PropertyChain): add GetParentChain() to PropertyChain.cs | …to resolve parent property path
Add GetParentChain() to PropertyChain, which returns a new chain containing all members except the last one. This enables identifying all validation errors belonging to a parent property by comparing error property names against the parent chain path. | 058865db479cc5389e00273f1afdbe22ed450bfb | 994cb10695173d1dbfe2d08aabe8980623f87c94 | diff --git a/src/FluentValidation.Tests/PropertyChainTests.cs b/src/FluentValidation.Tests/PropertyChainTests.cs
index 2c3422047..65d0a2be5 100644
--- a/src/FluentValidation.Tests/PropertyChainTests.cs
+++ b/src/FluentValidation.Tests/PropertyChainTests.cs
@@ -91,6 +91,34 @@ public void Should_ignore_blanks() {
chai... | [
"src/FluentValidation.Tests/PropertyChainTests.cs",
"src/FluentValidation/Internal/PropertyChain.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,356 | issue_to_patch | Add Belarusian language | Adds Belarusian language | 4984ff538e26b03c296f1fbc41085e9d6d687206 | bbe4984e468ee41aa3dee2eb3d25bb091a8c200b | diff --git a/src/FluentValidation/Resources/LanguageManager.cs b/src/FluentValidation/Resources/LanguageManager.cs
index 585d07e92..541ba94d8 100644
--- a/src/FluentValidation/Resources/LanguageManager.cs
+++ b/src/FluentValidation/Resources/LanguageManager.cs
@@ -44,6 +44,7 @@ private static string GetTranslation(stri... | [
"src/FluentValidation/Resources/LanguageManager.cs",
"src/FluentValidation/Resources/Languages/BelarusianLanguage.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,352 | issue_to_patch | Use ArgumentNullException.ThrowIfNull | 1e6eee2711b53e4f4b8411207fc6ba63b77ea8f2 | 4b39b77540c055295539d840c5d69aa88282f027 | diff --git a/src/FluentValidation/DefaultValidatorExtensions.cs b/src/FluentValidation/DefaultValidatorExtensions.cs
index 0e3135a59..526ce5c51 100644
--- a/src/FluentValidation/DefaultValidatorExtensions.cs
+++ b/src/FluentValidation/DefaultValidatorExtensions.cs
@@ -1128,7 +1128,8 @@ public static IRuleBuilderOptions... | [
"src/FluentValidation/DefaultValidatorExtensions.cs",
"src/FluentValidation/DefaultValidatorOptions.cs",
"src/FluentValidation/IValidationContext.cs",
"src/FluentValidation/Internal/RuleBase.cs",
"src/FluentValidation/Internal/RuleBuilder.cs",
"src/FluentValidation/Internal/ValidationStrategy.cs",
"src/... | [] | true | |||
FluentValidation/FluentValidation | 2,342 | issue_to_patch | Use CDATA toe improve readabllity of code examples | While checking something in the repo, I spotted some places where you put in `<code>` examples. Due to all the generics and lambdas, the XML escaping makes them harder to read. By using `<![CDATA[...]]>` both reading and writing these code examples would be easier.
(If preferred, I can update all code examples) | b960f42b6065d1aeecddb0c747e532b1842a96ef | 83a1071dace8f5b17fcd6dc5ddbe321949cee182 | diff --git a/src/FluentValidation/InlineValidator.cs b/src/FluentValidation/InlineValidator.cs
index 5881851d6..878753d59 100644
--- a/src/FluentValidation/InlineValidator.cs
+++ b/src/FluentValidation/InlineValidator.cs
@@ -25,15 +25,17 @@ namespace FluentValidation;
/// </summary>
/// <example>
/// <code>
+/// ... | [
"src/FluentValidation/InlineValidator.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,350 | issue_to_patch | Add Lithuanian language. | Hi @JeremySkinner ,
I'm submitting this PR to add Lithuanian language support.
Lithuanian is the offical language in Lithuania. There are about 2.96 million native Lithuanian speakers in Lithuania and about 200,000 abroad according to https://en.wikipedia.org/wiki/Lithuania#Lithuanian_language.
I hope this con... | d06e3f0d733468b25e031f3d7a99d66ec275e973 | cda8e901475c8c0789dccdfaca087b8795e60ee2 | diff --git a/src/FluentValidation/Resources/LanguageManager.cs b/src/FluentValidation/Resources/LanguageManager.cs
index 3c5966feb..585d07e92 100644
--- a/src/FluentValidation/Resources/LanguageManager.cs
+++ b/src/FluentValidation/Resources/LanguageManager.cs
@@ -70,6 +70,7 @@ private static string GetTranslation(stri... | [
"src/FluentValidation/Resources/LanguageManager.cs",
"src/FluentValidation/Resources/Languages/LithuanianLanguage.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,348 | issue_to_patch | Add Tenekon.FluentValidation.Extensions.AspNetCore.Components link to Blazor docs | Hey, the library is now pretty stable and I would like to make it available to a broader audience. By accident I saw the neat Blazor page and I thought it would be nice to let you and the others now that this library exists. 🙂 | cc9917c3688d790f7a414b17d1e03ce337a4151c | cc7992799abe1af114d22f8d47fe968ff4b48034 | diff --git a/docs/blazor.md b/docs/blazor.md
index d40e1f7b2..1ecb29e00 100644
--- a/docs/blazor.md
+++ b/docs/blazor.md
@@ -7,3 +7,4 @@ FluentValidation does not provide integration with Blazor out of the box, but th
- [Blazor-Validation](https://github.com/mrpmorris/blazor-validation)
- [Accelist.FluentValidation.B... | [
"docs/blazor.md"
] | [] | true | ||
FluentValidation/FluentValidation | 2,346 | issue_to_patch | Update blazor.md | Add Blazilla project | a712e36fdb3b5fc92559c0d19367bf3b046d4e8d | 91778c7a24be57a6b2223e8b81e49b26e7cd9a9e | diff --git a/docs/blazor.md b/docs/blazor.md
index 73c54880d..d40e1f7b2 100644
--- a/docs/blazor.md
+++ b/docs/blazor.md
@@ -2,7 +2,8 @@
FluentValidation does not provide integration with Blazor out of the box, but there are several third party libraries you can use to do this:
-- [Blazored.FluentValidation](https... | [
"docs/blazor.md"
] | [] | true | ||
FluentValidation/FluentValidation | 2,347 | issue_to_patch | Update .NET SDK to 10.0 and update tests to additionally run against .NET 10 | Upgraded all projects and CI to target .NET 10.0 (preview), updated global.json SDK version, and removed references to previous .NET versions. Increased version prefix to 13.0.0 to mark a new major release. Prepares codebase for latest .NET features. | a712e36fdb3b5fc92559c0d19367bf3b046d4e8d | c93d2009287c303fa725289d125613c995f730d9 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 114977eab..3c9346040 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -30,6 +30,7 @@ jobs:
uses: actions/setup-dotnet@v2
with:
dotnet-version: |
+ 10.0.x
9.0.x
8.0.x
... | [
".github/workflows/ci.yml",
"global.json",
"src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj",
"src/FluentValidation.Tests/FluentValidation.Tests.csproj"
] | [
{
"comment": "This is the *minimum supported* version and should remain as `net8.0`. Please revert.",
"path": "src/FluentValidation.DependencyInjectionExtensions/FluentValidation.DependencyInjectionExtensions.csproj",
"hunk": "@@ -1,6 +1,6 @@\n <Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\... | true | ||
FluentValidation/FluentValidation | 2,347 | comment_to_fix | Update .NET SDK to 10.0 and update tests to additionally run against .NET 10 | This one is ok, the benchmark application can run on net10 provided all other packages are compatible | a712e36fdb3b5fc92559c0d19367bf3b046d4e8d | c93d2009287c303fa725289d125613c995f730d9 | diff --git a/src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj b/src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj
index e56ad720d..63fcf00ac 100644
--- a/src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj
+++ b/src/FluentValidation.T... | [
"src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj"
] | [
{
"comment": "This one is ok, the benchmark application can run on net10 provided all other packages are compatible ",
"path": "src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj",
"hunk": "@@ -2,7 +2,7 @@\n \r\n <PropertyGroup>\r\n <OutputType>Exe</OutputType>\r\n- ... | true | ||
FluentValidation/FluentValidation | 2,347 | comment_to_fix | Update .NET SDK to 10.0 and update tests to additionally run against .NET 10 | These are all the versions of .NET we want to run tests again. We should not be dropping support for net8/9. This should be `<TargetFameworks>net8.0;net9.0;net10.0</TargetFrameworks>` | a712e36fdb3b5fc92559c0d19367bf3b046d4e8d | c93d2009287c303fa725289d125613c995f730d9 | diff --git a/src/FluentValidation.Tests/FluentValidation.Tests.csproj b/src/FluentValidation.Tests/FluentValidation.Tests.csproj
index 43f9f1e8a..6ae063b82 100644
--- a/src/FluentValidation.Tests/FluentValidation.Tests.csproj
+++ b/src/FluentValidation.Tests/FluentValidation.Tests.csproj
@@ -1,6 +1,6 @@
<Project Sdk=... | [
"src/FluentValidation.Tests/FluentValidation.Tests.csproj"
] | [
{
"comment": "These are all the versions of .NET we want to run tests again. We should not be dropping support for net8/9. This should be `<TargetFameworks>net8.0;net9.0;net10.0</TargetFrameworks>`",
"path": "src/FluentValidation.Tests/FluentValidation.Tests.csproj",
"hunk": "@@ -1,6 +1,6 @@\n <Project... | true | ||
FluentValidation/FluentValidation | 2,347 | comment_to_fix | Update .NET SDK to 10.0 and update tests to additionally run against .NET 10 | This should list all runtimes necessary for building and testing and should list all 3 versions (10.0.x, 9.0.x, 8.0.x) | a712e36fdb3b5fc92559c0d19367bf3b046d4e8d | c93d2009287c303fa725289d125613c995f730d9 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 114977eab..3c9346040 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -30,6 +30,7 @@ jobs:
uses: actions/setup-dotnet@v2
with:
dotnet-version: |
+ 10.0.x
9.0.x
8.0.x
... | [
".github/workflows/ci.yml"
] | [
{
"comment": "This should list all runtimes necessary for building and testing and should list all 3 versions (10.0.x, 9.0.x, 8.0.x) ",
"path": ".github/workflows/ci.yml",
"hunk": "@@ -30,8 +30,7 @@ jobs:\n uses: actions/setup-dotnet@v2\r\n with:\r\n dotnet-version: |\r\n- 9... | true | ||
FluentValidation/FluentValidation | 2,347 | comment_to_fix | Update .NET SDK to 10.0 and update tests to additionally run against .NET 10 | This is good. We want to be building with the newest sdk. | a712e36fdb3b5fc92559c0d19367bf3b046d4e8d | c93d2009287c303fa725289d125613c995f730d9 | diff --git a/global.json b/global.json
index 43559321b..7ba72713c 100644
--- a/global.json
+++ b/global.json
@@ -1,6 +1,6 @@
{
"sdk": {
- "version": "9.0.0",
+ "version": "10.0.0",
"rollForward": "latestFeature",
"allowPrerelease": true
}
| [
"global.json"
] | [
{
"comment": "This is good. We want to be building with the newest sdk. ",
"path": "global.json",
"hunk": "@@ -1,6 +1,6 @@\n {\n \"sdk\": {\n- \"version\": \"9.0.0\",\n+ \"version\": \"10.0.0\",",
"resolving_sha": "c93d2009287c303fa725289d125613c995f730d9",
"resolving_diff": "diff ... | true | ||
FluentValidation/FluentValidation | 2,345 | issue_to_patch | Docs: Add missing 'String format args:' headers to comparison validators | Documentation were missing the "String format args:". section header before their parameter lists, creating an inconsistency with other validators.
Added the missing "String format args:" headers to:
- Less Than Or Equal Validator (line 178)
- Greater Than Validator (line 199)
- Greater Than Or Equal Val... | 71b3c60cb5a16e02cb7957e478ec3fb6b983a73c | a2279cdc8229c09a014032578bbccde05a4d3e3d | diff --git a/docs/built-in-validators.md b/docs/built-in-validators.md
index be3ce05dd..2c2dfba1d 100644
--- a/docs/built-in-validators.md
+++ b/docs/built-in-validators.md
@@ -174,6 +174,8 @@ RuleFor(customer => customer.CreditLimit).LessThanOrEqualTo(customer => customer
```
Example error: *'Credit Limit' must be l... | [
"docs/built-in-validators.md"
] | [] | true | ||
FluentValidation/FluentValidation | 2,344 | issue_to_patch | fix: incorrect casing of Microsoft.Extensions.DependencyInjection.Abstractions causing bad nuget cache | ce67635f762a43f51f73ce395a5928d428d38881 | 7ad2f7dc69302d9060d3c877cf06f8698744b1f7 | diff --git a/src/FluentValidation.DependencyInjectionExtensions/FluentValidation.DependencyInjectionExtensions.csproj b/src/FluentValidation.DependencyInjectionExtensions/FluentValidation.DependencyInjectionExtensions.csproj
index f8ad12f36..698f22b69 100644
--- a/src/FluentValidation.DependencyInjectionExtensions/Flue... | [
"src/FluentValidation.DependencyInjectionExtensions/FluentValidation.DependencyInjectionExtensions.csproj"
] | [] | true | |||
FluentValidation/FluentValidation | 2,343 | issue_to_patch | Docs: Add a section for the OverrideIndexer extension method | I have searched a lot about how to influence the PropertyName for collections and could not find anything online. After researching the source code itself I stumbled upon a undocumented feature which allows setting the indexer. In this PR i added a section for the OverrideIndexer extension method to the configuring.md. | b960f42b6065d1aeecddb0c747e532b1842a96ef | 451d87b17591ddc9d50c2bac5b97d0280e2bd504 | diff --git a/docs/configuring.md b/docs/configuring.md
index 5a659b594..82a30cd5b 100644
--- a/docs/configuring.md
+++ b/docs/configuring.md
@@ -90,3 +90,14 @@ ValidatorOptions.Global.DisplayNameResolver = (type, member, expression) =>
```
This is not a realistic example as it changes all properties to have the suf... | [
"docs/configuring.md"
] | [] | true | ||
FluentValidation/FluentValidation | 2,340 | issue_to_patch | Fix typo in Japanese translation | This pull request corrects a minor punctuation error in the Japanese translation for a validation message.
## Before
`'{PropertyName}' は '{ComparisonValue} 以上でなければなりません'.`
The closing quotation mark was incorrectly placed outside the sentence-ending punctuation.
## After
`'{PropertyName}' は '{ComparisonV... | 298069b4ef88241013d0573f38e25c936e80685f | 826db16b053c44d333f8cbd6285200f76972a2a8 | diff --git a/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs b/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs
index 9b3a8eff9..b238e7650 100644
--- a/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs
+++ b/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs
@@ -27,7 +27,7 ... | [
"src/FluentValidation/Resources/Languages/JapaneseLanguage.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,333 | issue_to_patch | Add Telugu Language | Hi @JeremySkinner,
I'm submitting this PR to add Telugu language support.
Telugu is one of the most widely spoken languages in India, with over 83 million native speakers. It ranks as the 18th most spoken native language globally, according to [Wikipedia](https://en.wikipedia.org/wiki/List_of_languages_by_total_n... | 79687a5f9d450ca634c63c3f0a980e8ec9bbac8e | 0297273204cc8f8bfda09d444b7b31aca0ecfb55 | diff --git a/src/FluentValidation.Tests/LanguageManagerTests.cs b/src/FluentValidation.Tests/LanguageManagerTests.cs
index 8c53e3736..9fc46f262 100644
--- a/src/FluentValidation.Tests/LanguageManagerTests.cs
+++ b/src/FluentValidation.Tests/LanguageManagerTests.cs
@@ -76,6 +76,22 @@ public void Gets_translation_for_cro... | [
"src/FluentValidation.Tests/LanguageManagerTests.cs",
"src/FluentValidation/Resources/LanguageManager.cs",
"src/FluentValidation/Resources/Languages/TeluguLanguage.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,334 | issue_to_patch | Add Tamil (ta) Language | ## I have been added a new language which is tamil language. So that I and others can use it in the projects.
- 75+ million Tamil speakers worldwide
- Official language in India, Sri Lanka, and Singapore
- Tamil Nadu is India’s 2nd largest IT hub, home to thousands of .NET developers
- Despite its global relevance... | 5c36e71f6b43d02758e4d04c0709cc392594d385 | 14e347c28957a0a6216eb7b907a56d537f4e2b30 | diff --git a/src/FluentValidation.Tests/LanguageManagerTests.cs b/src/FluentValidation.Tests/LanguageManagerTests.cs
index 9fc46f262..069a8a9b5 100644
--- a/src/FluentValidation.Tests/LanguageManagerTests.cs
+++ b/src/FluentValidation.Tests/LanguageManagerTests.cs
@@ -26,6 +26,15 @@ public void Gets_translation_for_bos... | [
"src/FluentValidation.Tests/LanguageManagerTests.cs",
"src/FluentValidation/Resources/LanguageManager.cs",
"src/FluentValidation/Resources/Languages/TamilLanguage.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,341 | issue_to_patch | Fix typo in Japanese translation | This backports #2340 to the 11.x branch. | c8c6400fa2f467d65669b78804613d44066c1c33 | 93e888aff8a932b5ea28f97726416e8236e10ee3 | diff --git a/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs b/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs
index 9b3a8eff9..b238e7650 100644
--- a/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs
+++ b/src/FluentValidation/Resources/Languages/JapaneseLanguage.cs
@@ -27,7 +27,7 ... | [
"src/FluentValidation/Resources/Languages/JapaneseLanguage.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,337 | issue_to_patch | docs: Document how RuleSets and SetValidator (child validators) work togeher | I also stumbled upon this and it also seems to be common for others: https://github.com/FluentValidation/FluentValidation/issues/2101 https://github.com/FluentValidation/FluentValidation/issues/2100
So I guess at least document it, so people notice their problem faster. | 4c3791228dcb2442fc985a2238f312a7eaba3a31 | fb3552e2ce58f04376ccde8236435b09278fafbe | diff --git a/docs/rulesets.md b/docs/rulesets.md
index 8389477aa..cd39af47d 100644
--- a/docs/rulesets.md
+++ b/docs/rulesets.md
@@ -65,4 +65,9 @@ validator.Validate(person, options =>
{
options.IncludeAllRuleSets();
});
-```
\ No newline at end of file
+```
+
+```eval_rst
+.. note::
+ If you include a child valid... | [
"docs/rulesets.md"
] | [] | true | ||
FluentValidation/FluentValidation | 2,336 | issue_to_patch | Fix typo in comment | `occtur` => `occur` | 5bd6b4619ab79e444752da7f21d7a730fbabfacc | bcc77b064f791636a64d0f4a4cbd236e0b3e2c03 | diff --git a/src/FluentValidation/AbstractValidator.cs b/src/FluentValidation/AbstractValidator.cs
index 630c4b481..3e0bc6275 100644
--- a/src/FluentValidation/AbstractValidator.cs
+++ b/src/FluentValidation/AbstractValidator.cs
@@ -371,7 +371,7 @@ public void Include<TValidator>(Func<T, TValidator> rulesToInclude) whe... | [
"src/FluentValidation/AbstractValidator.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,335 | issue_to_patch | remove Microsoft.SourceLink.GitHub | not required since sdk 8
https://github.com/dotnet/sourcelink?tab=readme-ov-file#using-source-link-in-net-projects | 1726f06f6bd24343b90c5c6d402fe1aee51cbe52 | 41d98b9f1045a5d2dd8249754f3914606eb2eb77 | diff --git a/src/FluentValidation/FluentValidation.csproj b/src/FluentValidation/FluentValidation.csproj
index a8d63c8bd..8634005dd 100644
--- a/src/FluentValidation/FluentValidation.csproj
+++ b/src/FluentValidation/FluentValidation.csproj
@@ -24,7 +24,6 @@ Full release notes can be found at https://github.com/FluentV... | [
"src/FluentValidation/FluentValidation.csproj"
] | [] | true | ||
FluentValidation/FluentValidation | 2,330 | issue_to_patch | Fixed typo in "Update upgrading-to-9.md" | e90dc5cb4ff2a130cb62e6a0bcd59a717c839053 | 125dbc136c3e32bd2d66bf2ac2830fc9064ab7c6 | diff --git a/docs/upgrading-to-9.md b/docs/upgrading-to-9.md
index 4201528a4..967d200cf 100644
--- a/docs/upgrading-to-9.md
+++ b/docs/upgrading-to-9.md
@@ -125,7 +125,7 @@ This syntax has been superceded by the callback syntax. To access the localized
RuleFor(x => x.Surname).NotNull().WithMessage(x => MyLocalizedMess... | [
"docs/upgrading-to-9.md"
] | [] | true | |||
FluentValidation/FluentValidation | 2,331 | issue_to_patch | Removed deprecated reference to `WithLocalizedMessage` in "Update localization.md" | e90dc5cb4ff2a130cb62e6a0bcd59a717c839053 | f57e6cbd388f3aed604d1c7e7c6e4aab59f4c689 | diff --git a/docs/localization.md b/docs/localization.md
index b97f9f641..212ca93cf 100644
--- a/docs/localization.md
+++ b/docs/localization.md
@@ -2,7 +2,7 @@
Out of the box, FluentValidation provides translations for the default validation messages in several languages. By default, the language specified in the .... | [
"docs/localization.md"
] | [] | true | |||
FluentValidation/FluentValidation | 2,324 | issue_to_patch | Update CI runner | 0b31bfa2201fbc21b97f1116f0f4dfb5fc554b9a | 8c4928ec9d92e577b0a68a8ac0a17f53c745560d | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0fa986064..114977eab 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,7 +18,7 @@ jobs:
build:
strategy:
matrix:
- os: ['windows-2019', 'ubuntu-latest']
+ os: ['windows-latest', 'ubuntu-late... | [
".github/workflows/ci.yml"
] | [] | true | |||
FluentValidation/FluentValidation | 2,302 | issue_to_patch | Use discard for unused lambda arguments | 49c0da4dcaef998446f0b844780aa9eb9ab5e10c | f00232edea40274ea556df6c403251ece1b338d1 | diff --git a/src/FluentValidation/DefaultValidatorExtensions.cs b/src/FluentValidation/DefaultValidatorExtensions.cs
index 3ab5573bc..0e3135a59 100644
--- a/src/FluentValidation/DefaultValidatorExtensions.cs
+++ b/src/FluentValidation/DefaultValidatorExtensions.cs
@@ -417,7 +417,7 @@ public static IRuleBuilderOptions<T... | [
"src/FluentValidation/DefaultValidatorExtensions.cs"
] | [] | true | |||
FluentValidation/FluentValidation | 2,297 | issue_to_patch | Align Func arguments of comparable rules | While working one some code, I noticed that some LT/GT rules had `Func<T, TProperty>` called `valueToCompare`, and other `expression`. I guess the latter was intended. This is a breaking change, but as you are working v12.x I guess it is perfectly fine to apply the change.
If you prefer to call arguments `valueToCom... | f07241c2c5c421cc19a3edb1ee3a1178fe81cf8c | e8875fb7621a5b433ade2880a5fafa60adfbd340 | diff --git a/src/FluentValidation/DefaultValidatorExtensions.cs b/src/FluentValidation/DefaultValidatorExtensions.cs
index e738e9bde..3ab5573bc 100644
--- a/src/FluentValidation/DefaultValidatorExtensions.cs
+++ b/src/FluentValidation/DefaultValidatorExtensions.cs
@@ -510,8 +510,8 @@ public static IRuleBuilderOptions<T... | [
"src/FluentValidation/DefaultValidatorExtensions.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,295 | issue_to_patch | Use decimal scale to simplify PrecisionScaleValidator | After the discussion in #2288, I decided to try to simplify the implementation of `PrecisionScaleValidator<T>.IsValid()`. By using `decimal.Scale` and getting the scale and the precision in one go (instead of two) I was able to reduce the duration by 47%. I think the code is also easier to follow (which was the goal).
... | f07241c2c5c421cc19a3edb1ee3a1178fe81cf8c | 61c4d6ecea2a1f240882d6e96451ec23407ecea6 | diff --git a/src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj b/src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj
index b3bfca81e..e56ad720d 100644
--- a/src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj
+++ b/src/FluentValidation.T... | [
"src/FluentValidation.Tests.Benchmarks/FluentValidation.Tests.Benchmarks.csproj",
"src/FluentValidation.Tests/ScalePrecisionValidatorTests.cs",
"src/FluentValidation/Validators/PrecisionScaleValidator.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 1,964 | issue_to_patch | Add ToDictionary method to ValidationResult for ease of use when working with Minimal APIs. Deprecate various methods. Updated aspnet docs. | 9dd102bc5bf506417d50248dd50db18f7ad5757c | 7f8a6cbc44fbf1d1bb9110ad093c2673ebdd4c0f | diff --git a/Changelog.txt b/Changelog.txt
index 8cbe6a98f..a0ffa502f 100644
--- a/Changelog.txt
+++ b/Changelog.txt
@@ -1,8 +1,10 @@
11.1.0 -
-InjectValidator has been deprecated (#1960)
-MVC auto validation: Implicit validation of child properties has been deprecated (#1960)
-MVC auto validation: Implicit validation... | [
"Changelog.txt",
"docs/aspnet.md",
"src/FluentValidation.AspNetCore/FluentValidationMvcConfiguration.cs",
"src/FluentValidation.AspNetCore/FluentValidationMvcExtensions.cs",
"src/FluentValidation.Tests.AspNetCore/ClientsideMessageTester.cs",
"src/FluentValidation.Tests.AspNetCore/DisableDataAnnotationsTes... | [] | true | |||
FluentValidation/FluentValidation | 1,974 | issue_to_patch | Simplify test platforms & CI | eb0ea335ce3bdeda6ddc84e6e3f98f094f5f4bd6 | 2b15f0db3ff8eb216282f729cdc71521795540ac | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 010537857..a390fabcb 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -25,19 +25,10 @@ jobs:
with:
fetch-depth: 0
- - name: Get SDKs to install
- shell: pwsh
- # Collect the SDKs we need by ... | [
".github/workflows/ci.yml",
"src/FluentValidation.Tests/FluentValidation.Tests.csproj"
] | [] | true | |||
FluentValidation/FluentValidation | 2,029 | issue_to_patch | Announcement: `ScalePrecision` methods replaced with `PrecisionScale`.
# Background
In FluentValidation versions prior to 11.4, you could define precision/scale validation for a decimal by using the `ScalePrecision` method. This method has caused some confusion because of the order of its parameters are different ... | Introduce PrecisionScale validator as replacement for ScalePrecision validator | - Deprecates `ScalePrecision` methods
- Introduces `PrecisionScale` methods as replacements
- New methods swap the parameter order from `scale, precision` to `precision, scale` for consistency with how databases define decimals
- Makes the `ignoreTrailingZeros` parameter mandatory | beb8f60a2b9fb102077b3f013e967fe7ca066a06 | 3165eabb0661c4d3c788c79359ed70937f48253f | diff --git a/Changelog.txt b/Changelog.txt
index 776031b53..e62c29800 100644
--- a/Changelog.txt
+++ b/Changelog.txt
@@ -1,3 +1,6 @@
+11.4.0 - 23 Nov 2022
+Deprecate ScalePrecision validator and introduce PrecisionScale validator as its replacement (#2030)
+
11.3.0 - 10 Nov 2022
Annotate string parameters with String... | [
"Changelog.txt",
"docs/built-in-validators.md",
"src/Directory.Build.props",
"src/FluentValidation.Tests/DefaultValidatorExtensionTester.cs",
"src/FluentValidation.Tests/ScalePrecisionValidatorTests.cs",
"src/FluentValidation/DefaultValidatorExtensions.cs",
"src/FluentValidation/Validators/ScalePrecisio... | [] | true | |
FluentValidation/FluentValidation | 2,098 | issue_to_patch | Nested RuleForEach and ChildRules don't work in RuleSets
### FluentValidation version
11.5.1
### ASP.NET version
_No response_
### Summary
We've been working on migrating a project that was previously using FluentValidation 10.3.0 to the newest version. In this project, we have a lot of rulesets that ru... | Resolve issue with ruleset propogation for multiple levels of child rules | Fixes #2097 | 56313e7a7840b57762827c4780483903bf66c0a5 | e4875058d3f706f8599cbb35b653b46e6eb0a104 | diff --git a/src/FluentValidation.Tests/ChildRulesTests.cs b/src/FluentValidation.Tests/ChildRulesTests.cs
index d96cfa712..d1f2c48c1 100644
--- a/src/FluentValidation.Tests/ChildRulesTests.cs
+++ b/src/FluentValidation.Tests/ChildRulesTests.cs
@@ -91,6 +91,36 @@ public void ChildRules_works_with_SetValidator_and_RuleS... | [
"src/FluentValidation.Tests/ChildRulesTests.cs",
"src/FluentValidation/DefaultValidatorExtensions.cs",
"src/FluentValidation/Internal/ChildRulesContainer.cs"
] | [] | true | |
FluentValidation/FluentValidation | 2,120 | issue_to_patch | Add OnFailureCreated callback | Addresses #2112 | aa61b359983e74895c69a0bd592512dea726bc30 | 87aa5f3b8bc5a0e19c0c584ce0ab711e8f390441 | diff --git a/src/FluentValidation.Tests/OnFailureHookTester.cs b/src/FluentValidation.Tests/OnFailureHookTester.cs
new file mode 100644
index 000000000..23a2846d4
--- /dev/null
+++ b/src/FluentValidation.Tests/OnFailureHookTester.cs
@@ -0,0 +1,43 @@
+#region License
+// Copyright (c) .NET Foundation and contributors.
... | [
"src/FluentValidation.Tests/OnFailureHookTester.cs",
"src/FluentValidation/Internal/RuleBase.cs",
"src/FluentValidation/ValidatorOptions.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,177 | issue_to_patch | Add support for dependent rules for custom rules | Resolve #2170 | d4c8868bc553ea6cc67ea0cb49562c082ac54584 | 1a88936c0cb820cdadaf8cb4a28f9ad18246cb0e | diff --git a/src/FluentValidation.Tests/RuleDependencyTests.cs b/src/FluentValidation.Tests/RuleDependencyTests.cs
index fc216051b..9b0acf463 100644
--- a/src/FluentValidation.Tests/RuleDependencyTests.cs
+++ b/src/FluentValidation.Tests/RuleDependencyTests.cs
@@ -38,8 +38,7 @@ public void Invokes_dependent_rule_if_par... | [
"src/FluentValidation.Tests/RuleDependencyTests.cs",
"src/FluentValidation/Internal/RuleBuilder.cs",
"src/FluentValidation/Syntax.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,241 | issue_to_patch | Add async overload for Where on RuleForEach
### Is your feature request related to a problem? Please describe.
_No response_
### Describe the solution you'd like
It would be nice if I could write something like this
```c#
RuleForEach(obj => obj.Items)
.WhereAsync(async item => await CheckSomeAsyncConditionWh... | Add WhereAsync as conterpart to Where on collection rules (#2240) | Implements #2240 | 7a85fbb4c7bf0008b0722ca9f2a6258e09216fb7 | c57ec479a5c83c86fc1d45070fa4de7b5f497f0e | diff --git a/Changelog.txt b/Changelog.txt
index b964b92d9..735b465d0 100644
--- a/Changelog.txt
+++ b/Changelog.txt
@@ -1,3 +1,6 @@
+11.10.0 -
+Add WhereAsync as conterpart to Where on collection rules (#2240)
+
11.9.2 - 10 Jun 2024
ScalePrecisionValidator error message clarification (#2211)
diff --git a/docs/col... | [
"Changelog.txt",
"docs/collections.md",
"src/FluentValidation.Tests/ForEachRuleTests.cs",
"src/FluentValidation/DefaultValidatorOptions.cs",
"src/FluentValidation/Internal/CollectionPropertyRule.cs"
] | [
{
"comment": "can use ValueTask<bool>",
"path": "src/FluentValidation/DefaultValidatorOptions.cs",
"hunk": "@@ -397,6 +397,20 @@ public static IRuleBuilderInitialCollection<T, TCollectionElement> Where<T, TCol\n \t\treturn rule;\r\n \t}\r\n \r\n+\t/// <summary>\r\n+\t/// Applies an asynchronous filter t... | true | |
FluentValidation/FluentValidation | 2,241 | comment_to_fix | Add WhereAsync as conterpart to Where on collection rules (#2240) | can use ValueTask<bool> | 7a85fbb4c7bf0008b0722ca9f2a6258e09216fb7 | c57ec479a5c83c86fc1d45070fa4de7b5f497f0e | diff --git a/src/FluentValidation/DefaultValidatorOptions.cs b/src/FluentValidation/DefaultValidatorOptions.cs
index 118b3a20e..3d185ed27 100644
--- a/src/FluentValidation/DefaultValidatorOptions.cs
+++ b/src/FluentValidation/DefaultValidatorOptions.cs
@@ -397,6 +397,20 @@ public static IRuleBuilderInitialCollection<T,... | [
"src/FluentValidation/DefaultValidatorOptions.cs"
] | [
{
"comment": "can use ValueTask<bool>",
"path": "src/FluentValidation/DefaultValidatorOptions.cs",
"hunk": "@@ -397,6 +397,20 @@ public static IRuleBuilderInitialCollection<T, TCollectionElement> Where<T, TCol\n \t\treturn rule;\r\n \t}\r\n \r\n+\t/// <summary>\r\n+\t/// Applies an asynchronous filter t... | true | ||
FluentValidation/FluentValidation | 2,009 | issue_to_patch | Updated minimum supported platform to be .net6+
We originally planned to drop netstandard2 in FluentValidation 10, but decided to hold off as .net platform convergence was delayed from .net 5 to .net 6.
We should target .net 6 as our minimum supported platform. Support for netstandard2 and netstandard2.1 should be... | 12.0 CI | Work in progress for FluentValidation 12.
- #1704
- #1975
- #2010
- [ ] Need to re-enable package validation after 12.0 is released
# Breaking changes to document
- [x] Removal of netstandard2, netstandard2.1, net5, net6 and net7 support
- [x] Removal of legacy cascade options
- [x] Add `MatchedFailures` ... | c8c6400fa2f467d65669b78804613d44066c1c33 | 53b565eb30cdcc96b6ae59d9f08098307b05f10b | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 2404e6186..c229bc71b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -30,9 +30,8 @@ jobs:
uses: actions/setup-dotnet@v2
with:
dotnet-version: |
- 8.0.100
- 7.0.100
- 6.0.... | [
".github/workflows/ci.yml",
"Changelog.txt",
"docs/cascade.md",
"docs/index.rst",
"docs/upgrading-to-11.md",
"docs/upgrading-to-12.md",
"global.json",
"src/CommonAssemblyInfo.cs",
"src/Directory.Build.props",
"src/FluentValidation.DependencyInjectionExtensions/DependencyInjectionExtensions.cs",
... | [] | true | |
FluentValidation/FluentValidation | 2,292 | issue_to_patch | Ordered and grouped overloads in DefaultValidatorExtensions.cs | Resolves #2291. | d82adcd3c2d56cc5386e8e30861f17d134c27bf6 | c73a0fc6ec6edaa932f66d3e4f6df149cb775c8e | diff --git a/src/FluentValidation/DefaultValidatorExtensions.cs b/src/FluentValidation/DefaultValidatorExtensions.cs
index 94be01bb1..e738e9bde 100644
--- a/src/FluentValidation/DefaultValidatorExtensions.cs
+++ b/src/FluentValidation/DefaultValidatorExtensions.cs
@@ -64,6 +64,21 @@ public static partial class DefaultV... | [
"src/FluentValidation/DefaultValidatorExtensions.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,136 | issue_to_patch | Improve performance by removing sync-over-async by generating sync methods using Zomp.SyncMethodGenerator | The main advantage of this approach is performance.
The performance is increased by 26%, 21%, 22%, 28%, 30% and 7% for the following benchmarks in ValidationBenchmark.
### useAsync flag
BenchmarkDotNet=v0.12.1, OS=Windows 10.0.22621
AMD Ryzen 9 5900HS with Radeon Graphics, 1 CPU, 16 logical and 8 physical cor... | ef50516decf652fd9f97090a4a4a9e114d458ce8 | 659fb1a7dfce895c98b21df64e67e6fe966f6e1b | diff --git a/Changelog.txt b/Changelog.txt
index 72c3eec25..8d928ce6a 100644
--- a/Changelog.txt
+++ b/Changelog.txt
@@ -4,6 +4,7 @@ Add support for dependent rules for custom rules (#2170)
Removes deprecated DI extensions
Removes deprecated transform methods (#2027)
Remove the ability to disable the root-model null... | [
"Changelog.txt",
"src/FluentValidation/AbstractValidator.cs",
"src/FluentValidation/FluentValidation.csproj",
"src/FluentValidation/IValidationRuleInternal.cs",
"src/FluentValidation/Internal/CollectionPropertyRule.cs",
"src/FluentValidation/Internal/IncludeRule.cs",
"src/FluentValidation/Internal/Prope... | [] | true | ||
FluentValidation/FluentValidation | 2,283 | issue_to_patch | Add Serbian cyrillic language | Hello @JeremySkinner, I'm adding Serbian cyrillic with these changes.
As you probably don't know, cyrillic version is kind of official language for us. All legal papers, documents, etc must be written on cyrillic. In that sense, I've added it here as well.
I must point potential **breaking change** here, because ... | 792ce73236dda4de85dec81676248255a7e7fde7 | a99b45d224493e101b84185228a8eb27080d4a6b | diff --git a/src/FluentValidation.Tests/LanguageManagerTests.cs b/src/FluentValidation.Tests/LanguageManagerTests.cs
index b7cb39803..8c53e3736 100644
--- a/src/FluentValidation.Tests/LanguageManagerTests.cs
+++ b/src/FluentValidation.Tests/LanguageManagerTests.cs
@@ -28,12 +28,22 @@ public void Gets_translation_for_bo... | [
"src/FluentValidation.Tests/LanguageManagerTests.cs",
"src/FluentValidation/Resources/LanguageManager.cs",
"src/FluentValidation/Resources/Languages/SerbianCyrillicLanguage.cs",
"src/FluentValidation/Resources/Languages/SerbianLatinLanguage.cs"
] | [
{
"comment": "This can introduce breaking change, because `sr` culture will now be used on cyrillic version.",
"path": "src/FluentValidation/Resources/Languages/SerbianLatinLanguage.cs",
"hunk": "@@ -22,29 +22,29 @@\n \r\n namespace FluentValidation.Resources;\r\n \r\n-internal class SerbianLanguage {\r... | true | ||
FluentValidation/FluentValidation | 2,278 | issue_to_patch | Add WithState(...) overload which allows accessing ValidationContext<T>
### Is your feature request related to a problem? Please describe.
When using custom ValidationContexts, it is currently not possible to access addional properties on these ValidationContexts when using `WithState(...)` to customize the validat... | Add WithState(...) overload with access to ValidationContext<T> | #2276 | f534dca8bee4223dbc8f30e2a1870b59a390177c | f112b6a04f7d3e855faa4ad5f125778e8d4571a9 | diff --git a/Changelog.txt b/Changelog.txt
index 9ef71ab3c..6430931c0 100644
--- a/Changelog.txt
+++ b/Changelog.txt
@@ -1,3 +1,6 @@
+11.11.0 - 16 Nov 2024
+Add additional overload of WithState that takes a context (#2276)
+
11.10.0 - 15 Sep 2024
Add WhereAsync as conterpart to Where on collection rules (#2240)
Crea... | [
"Changelog.txt",
"src/Directory.Build.props",
"src/FluentValidation.Tests/UserStateTester.cs",
"src/FluentValidation/DefaultValidatorOptions.cs"
] | [] | true | |
FluentValidation/FluentValidation | 2,184 | issue_to_patch | AddValidatorsFromAssemblyContaining would register Validators twice
### FluentValidation version
11.8.1
### ASP.NET version
(ASP).NET Core 8
### Summary
I honestly don't know if it is an issue, but it manifested as one to me when it occured.
2 (but actually any amount of) calls to `AddValidatorsFromAssemblyCon... | Register validators once per type | Fixes #2182
A few thoughts on that:
- I wrote unit tests, but had to reference `FluentValidation.DependencyInjectionExtensions.csproj` from the test project to not create a whole new project for one test class. But feel free to move it around as you like.
- Creating `ServiceCollection`s to test the behavior requi... | 51e365b6cbe5a62f98d01f3b40e4fb06e6b1f65a | e4eab7bbb5ed8ae290f9fcb18629be309676d714 | diff --git a/src/FluentValidation.DependencyInjectionExtensions/ServiceCollectionExtensions.cs b/src/FluentValidation.DependencyInjectionExtensions/ServiceCollectionExtensions.cs
index c8c62984e..bb6a4c950 100644
--- a/src/FluentValidation.DependencyInjectionExtensions/ServiceCollectionExtensions.cs
+++ b/src/FluentVal... | [
"src/FluentValidation.DependencyInjectionExtensions/ServiceCollectionExtensions.cs",
"src/FluentValidation.Tests/DependencyInjectionExtensions/ServiceCollectionExtensionsTests.cs",
"src/FluentValidation.Tests/FluentValidation.Tests.csproj"
] | [
{
"comment": "Why did you use TryAddEnumerable and not TryAdd here?",
"path": "src/FluentValidation.DependencyInjectionExtensions/ServiceCollectionExtensions.cs",
"hunk": "@@ -92,14 +93,14 @@ public static IServiceCollection AddValidatorsFromAssemblyContaining<T>(this ISe\n \t\tbool shouldRegister = fil... | true | |
FluentValidation/FluentValidation | 2,262 | issue_to_patch | move to LangVersion 12 | f322bb3d6d37e7cf9c8bccc1be0727ef75e30dce | c071787a2d01f7fa0c8090bf6d100cc20622dd14 | diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 87e55e396..efebfc2de 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -5,7 +5,7 @@
<!-- Use CI build number as version suffix (if defined) -->
<!--<VersionSuffix Condition="'$(GITHUB_RUN_NUMBER)'!=''">ci-$(GITHU... | [
"src/Directory.Build.props"
] | [] | true | |||
FluentValidation/FluentValidation | 2,263 | issue_to_patch | leverage MSBuildThisFileDirectory to simplify path resolution | f322bb3d6d37e7cf9c8bccc1be0727ef75e30dce | 549305b84bbc1c4b0f9f67089ac987c795e6094f | diff --git a/src/Directory.Build.props b/src/Directory.Build.props
index 87e55e396..a9b0c32f4 100644
--- a/src/Directory.Build.props
+++ b/src/Directory.Build.props
@@ -17,8 +17,8 @@
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
<NeutralLanguage>en</NeutralLanguage>
<SignAs... | [
"src/Directory.Build.props"
] | [] | true | |||
FluentValidation/FluentValidation | 2,258 | issue_to_patch | remove LegacyRulesetSplit | doesnt seem to be used | f322bb3d6d37e7cf9c8bccc1be0727ef75e30dce | 62f918392faaf12fe3731697eac009f1cc3d89fe | diff --git a/src/FluentValidation/Internal/RulesetValidatorSelector.cs b/src/FluentValidation/Internal/RulesetValidatorSelector.cs
index 9469ac489..a2ef1fba1 100644
--- a/src/FluentValidation/Internal/RulesetValidatorSelector.cs
+++ b/src/FluentValidation/Internal/RulesetValidatorSelector.cs
@@ -84,15 +84,4 @@ public v... | [
"src/FluentValidation/Internal/RulesetValidatorSelector.cs"
] | [] | true | ||
FluentValidation/FluentValidation | 2,149 | issue_to_patch | update tasks and Reference assemblies | i hit a minor dependency conflict pulling in different versions of these libs.
not a bug with FV
i managed to workaround it, but figured it would be safe to update these libs anyway | 4c1b8893fe9e28e6b3957e032c5b15e34a78e011 | 39f49cd4fd484ac1a4d4b54e18a3fca1736eee44 | diff --git a/src/FluentValidation/FluentValidation.csproj b/src/FluentValidation/FluentValidation.csproj
index 907f10fba..b4de37657 100644
--- a/src/FluentValidation/FluentValidation.csproj
+++ b/src/FluentValidation/FluentValidation.csproj
@@ -25,10 +25,10 @@ Full release notes can be found at https://github.com/Fluen... | [
"src/FluentValidation/FluentValidation.csproj"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.