repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
wailsapp/wails | 20 | issue_to_patch | Numerous fixes for headless mode. | Remove script dom elements for internal calls. | 4c98ce7da1ff2a778727b1fd9d0f064d1408ac2d | 1ef8ed73ab63c8ac99c3fd507ed1fc363993eb40 | diff --git a/a_wails-packr.go b/a_wails-packr.go
index 8c8b527e307..8e1df3bc12a 100644
--- a/a_wails-packr.go
+++ b/a_wails-packr.go
@@ -13,8 +13,8 @@ func init() {
packr.PackJSONBytes("./assets/default", "default.html", "\"PGRpdiBpZD0iYXBwIj48L2Rpdj4=\"")
packr.PackJSONBytes("./assets/default", "jquery.3.3.1.min.j... | [
"a_wails-packr.go",
"assets/headless/index.html",
"renderer_headless.go"
] | [] | true | ||
wailsapp/wails | 137 | issue_to_patch | 135 add debian support | 08050ec35e056b042d674ad6bb37692f216da696 | 105073e4122ce3e13392062a564d9c7da3f93d9a | diff --git a/README.md b/README.md
index ce1bc390ae4..65b7cf286e3 100644
--- a/README.md
+++ b/README.md
@@ -46,7 +46,7 @@ Make sure you have the xcode command line tools installed. This can be done by r
### Linux
-#### Ubuntu 18.04
+#### Ubuntu 18.04, Debian 9
`sudo apt install pkg-config build-essential libgt... | [
"README.md",
"cmd/linux.go",
"cmd/prerequisites.go",
"cmd/system.go",
"cmd/wails/0_setup.go"
] | [] | true | |||
wailsapp/wails | 5,357 | issue_to_patch | fix(setup): fix three Linux wizard QA issues (GOTOOLCHAIN, gcc version, defaults omitempty) | ## Summary
Fixes three issues found during Linux QA of the setup wizard on `v3/feature/setup`.
### Fix A — Go GOTOOLCHAIN detection (`wizard_linux.go`)
`checkGo()` previously reported "needs_update" for any system Go < 1.25, including systems where GOTOOLCHAIN is active and Go 1.25 is available from the module cache... | c1f857cf8e96155bc8a3ec4cce44761eb4304650 | 18228546196b0c4a402155cfeb9086995041c02f | diff --git a/v3/internal/defaults/defaults.go b/v3/internal/defaults/defaults.go
index 20fbf241d1f..53920b10dae 100644
--- a/v3/internal/defaults/defaults.go
+++ b/v3/internal/defaults/defaults.go
@@ -31,13 +31,13 @@ type AuthorDefaults struct {
// ProjectDefaults contains default project settings
type ProjectDefau... | [
"v3/internal/defaults/defaults.go",
"v3/internal/setupwizard/wizard.go",
"v3/internal/setupwizard/wizard_linux.go"
] | [
{
"comment": "`findToolchainGo()` uses `go env GOPATH` and then assumes a single path and that the module cache is always at `$GOPATH/pkg/mod`. `GOPATH` can contain multiple entries (colon-separated), and the module cache can be relocated via `GOMODCACHE`, so this logic can fail to detect an already-downloaded ... | true | ||
wailsapp/wails | 5,366 | issue_to_patch | [v3] Frameless Window Cannot Resize When Scrollbar is at the Window Edges
### Description
https://github.com/user-attachments/assets/b6fc860e-8f73-4948-862f-efe105a4c8c9
### To Reproduce
In a frameless window setup, resizing the window becomes unresponsive when the scrollbar is positioned at the window's edges. ... | fix(v3,linux): enable frameless resize edge detection on Linux (#4680) | ## Summary
Fixes #4680 — frameless window resize blocked by scrollbar at window edges on Linux.
**Root cause:** `drag.ts`'s `onMouseMove()` had a `!IsWindows()` guard that completely disabled JavaScript resize-edge detection on non-Windows platforms. On Linux, frameless windows have no WM-managed resize handles; the ... | f03be45186e843e164f124efa3a1e633ae093556 | 0822826e5f5e52ab40b7668db3500946cf4b60e8 | [] | [
{
"comment": "This change enables edge detection on Linux in principle, but the code path is still gated by `resizable`. In this module `resizable` defaults to `false` and is only updated via `window._wails.setResizable(...)`; currently the Linux window implementation does not appear to invoke that JS hook (onl... | true | ||
wailsapp/wails | 5,598 | issue_to_patch | fix(v3/ci): fix Build Examples CI failure for Go 1.25 stricter module nesting | ## Description
**CI is broken across all PRs.** Fixes the `Build Examples` step failing with:
```
main module (github.com/wailsapp/wails/v3) does not contain package github.com/wailsapp/wails/v3/examples/dev
```
Go 1.25 introduced stricter module nesting checks. Examples that have their own `go.mod` with a `replace ... | 705c1097b2b3ffb6084fdf49a78a081a75e21440 | 8dcb61cd6388eab5085ebccb8b9d14c31e6f88cc | diff --git a/v3/Taskfile.yaml b/v3/Taskfile.yaml
index 85b860ae20d..471118ffc43 100644
--- a/v3/Taskfile.yaml
+++ b/v3/Taskfile.yaml
@@ -328,9 +328,6 @@ tasks:
events-bug
file-association
frameless
- gin-example
- gin-routing
- gin-service
hide-window
ig... | [
"v3/Taskfile.yaml",
"v3/examples/dev/go.mod",
"v3/examples/dev/go.sum",
"v3/examples/file-association/go.mod",
"v3/examples/file-association/go.sum",
"v3/examples/notifications/go.mod",
"v3/examples/notifications/go.sum"
] | [] | true | ||
wailsapp/wails | 5,248 | issue_to_patch | Build fails with "file name too long" error when task label contains long ldflags
### Description
When building a Wails v3 project with wails3 build, the build fails with a "file name too long" error. This occurs because the embedded Task (forked from go-task/task) generates checksum filenames based on task labels, a... | fix(v3): remove BUILD_FLAGS from generate:bindings task label | ## Summary
- Remove the `label` from the `generate:bindings` task that included `BUILD_FLAGS` in the embedded Taskfile template
- The go-task runner generates checksum filenames from labels; long ldflags caused filenames exceeding the 255-char filesystem limit
Fixes #5216
## Test plan
- [x] `TestTaskfileLabelsDoNotIn... | 9ab0a7907763d023753429574202049537160589 | bff133e03b2caf41091b72f2d3f05cf79061ba9b | diff --git a/v3/internal/commands/build_assets/Taskfile.tmpl.yml b/v3/internal/commands/build_assets/Taskfile.tmpl.yml
index 74afac8b4d4..fefa1e1b368 100644
--- a/v3/internal/commands/build_assets/Taskfile.tmpl.yml
+++ b/v3/internal/commands/build_assets/Taskfile.tmpl.yml
@@ -174,7 +174,6 @@ tasks:
generate:bind... | [
"v3/internal/commands/build_assets/Taskfile.tmpl.yml",
"v3/internal/commands/taskfile_label_length_test.go"
] | [
{
"comment": "`TestTaskfileLabelLength` currently measures the length of the whole YAML line (including the `label:` key), not the label value itself. This makes the test stricter than intended and can fail even when the actual label string is <200 chars (e.g., a 199-char label becomes >200 once prefixed with `... | diff --git a/v3/internal/commands/taskfile_label_length_test.go b/v3/internal/commands/taskfile_label_length_test.go
new file mode 100644
index 00000000000..94031f000fb
--- /dev/null
+++ b/v3/internal/commands/taskfile_label_length_test.go
@@ -0,0 +1,40 @@
+package commands
+
+import (
+ "strings"
+ "testing"
+
+ "gith... | true |
wailsapp/wails | 5,595 | issue_to_patch | Revert "docs(v3): update README — replace 'v3 Alpha' with Beta scope statement" | Reverts wailsapp/wails#5490
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Documentation**
* Updated the v3 README to reflect an Alpha kickoff instead of a Beta release guide.
* Removed outdated beta-specific details such as stability promises, scope notes... | a5174273a809af131a86b2bec222057cc6645f8c | 28ad6f9ee9e623487f478c8f5c6b147e78d95637 | diff --git a/v3/README.md b/v3/README.md
index 99e4c0c497f..2d0c36a0b0e 100644
--- a/v3/README.md
+++ b/v3/README.md
@@ -1,33 +1,9 @@
-# Wails v3 Beta
+# v3 Alpha
-Welcome to Wails v3! This is the beta release of the next major version of Wails.
-
-## What Beta means
-
-The v3 API in `v3/pkg/application` and related ... | [
"v3/README.md"
] | [
{
"comment": "`mkdocs-website` doesn’t exist in this repo (and the only v3 docs tree appears to be `docs/` at the repo root). As written, the README sends contributors to a non-existent directory, so the “Getting Started” section is effectively broken.",
"path": "v3/README.md",
"hunk": "@@ -1,33 +1,9 @@... | true | ||
wailsapp/wails | 5,577 | issue_to_patch | [v3] [mac] drag n drop does not work as expected after resizing window
### Description
If you resize the window and then try to drag a file into the window, the file will usually get rejected
### To Reproduce
1. `git checkout v3-alpha`
2. `cd v3/examples/drag-n-drop`
3. `go run main.go`
4. `resize window`
5... | fix(v3/darwin): resize the drag-and-drop overlay with the window | # Description
On macOS, files dragged into a window after it had been resized were "usually rejected" (#3743, with video). Root cause is a one-line typo in `windowNew`:
```objc
WebviewDrag* dragView = [[WebviewDrag alloc] initWithFrame:NSMakeRect(0, 0, width-1, height-1)];
[view setAutoresizingMask:...]; // ← set o... | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | 07cbd6a1dba15d996cf84c9bc58fc4d9ee3cb618 | diff --git a/v3/pkg/application/webview_window_darwin.go b/v3/pkg/application/webview_window_darwin.go
index 725b1d36172..05f691c68c1 100644
--- a/v3/pkg/application/webview_window_darwin.go
+++ b/v3/pkg/application/webview_window_darwin.go
@@ -143,7 +143,11 @@ void* windowNew(unsigned int id, int width, int height, bo... | [
"v3/pkg/application/webview_window_darwin.go"
] | [] | true | |
wailsapp/wails | 5,576 | issue_to_patch | [v3] Windows - Custom dialog icon not working
### Description
The custom icons for windows dialogs do not work.
### To Reproduce
1. Run the `v3/examples/dialogs` example
2. Select the `Info->Info (custom icon)` menu option
### Expected behaviour
dialog to show
### Screenshots
: show dialogs with icons in dev builds and keep their buttons | # Description
Reproducing #4233 via the dialogs example: dialogs with `UseAppIcon` or a custom `Icon` call `MessageBoxIndirect` with icon resource **ID 3** and hardcoded `MB_OK|MB_USERICON`. Two distinct bugs:
1. **Dialog doesn't show / app aborts in dev**: dev binaries (`go run`, `wails3 dev`) have no embedded icon ... | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | 76b73721319e5a2dde0510d4c7c93cb162346eb1 | diff --git a/v3/pkg/application/dialogs_windows.go b/v3/pkg/application/dialogs_windows.go
index 73084d098e0..789c6278ffd 100644
--- a/v3/pkg/application/dialogs_windows.go
+++ b/v3/pkg/application/dialogs_windows.go
@@ -47,8 +47,19 @@ func (m *windowsDialog) show() {
}
if m.UseAppIcon || m.dialog.Icon != nil {
-... | [
"v3/pkg/application/dialogs_windows.go",
"v3/pkg/application/dialogs_windows_internal_test.go"
] | [
{
"comment": "`mbIconMask` is a magic value (0xF0). This is easy to misread/accidentally change and isn’t self-documenting; deriving the mask from the existing `windows.MB_ICON*`/`MB_USERICON` constants makes the intent explicit while keeping the same behavior.",
"path": "v3/pkg/application/dialogs_windows.... | diff --git a/v3/pkg/application/dialogs_windows_internal_test.go b/v3/pkg/application/dialogs_windows_internal_test.go
new file mode 100644
index 00000000000..55a73f93262
--- /dev/null
+++ b/v3/pkg/application/dialogs_windows_internal_test.go
@@ -0,0 +1,30 @@
+//go:build windows
+
+package application
+
+import (
+ "te... | true |
wailsapp/wails | 5,576 | comment_to_fix | fix(v3/windows): show dialogs with icons in dev builds and keep their buttons | `mbIconMask` is a magic value (0xF0). This is easy to misread/accidentally change and isn’t self-documenting; deriving the mask from the existing `windows.MB_ICON*`/`MB_USERICON` constants makes the intent explicit while keeping the same behavior. | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | 76b73721319e5a2dde0510d4c7c93cb162346eb1 | diff --git a/v3/pkg/application/dialogs_windows.go b/v3/pkg/application/dialogs_windows.go
index 73084d098e0..789c6278ffd 100644
--- a/v3/pkg/application/dialogs_windows.go
+++ b/v3/pkg/application/dialogs_windows.go
@@ -47,8 +47,19 @@ func (m *windowsDialog) show() {
}
if m.UseAppIcon || m.dialog.Icon != nil {
-... | [
"v3/pkg/application/dialogs_windows.go"
] | [
{
"comment": "`mbIconMask` is a magic value (0xF0). This is easy to misread/accidentally change and isn’t self-documenting; deriving the mask from the existing `windows.MB_ICON*`/`MB_USERICON` constants makes the intent explicit while keeping the same behavior.",
"path": "v3/pkg/application/dialogs_windows.... | true | ||
wailsapp/wails | 5,574 | issue_to_patch | Removing an event while handling an event leave the event handler on
### Description
in my JS code, i have something like that;
```js
let ev = runtime.EventsOn( "name", () => {
// here i call ev that will call runtime.EventsOff( )
if( some_reason ) { // the reason i do not call EventOnOnce
ev( ); ... | fix(v3/runtime): honour subscription changes made during event dispatch | # Description
The v3 event dispatcher (`dispatchWailsEvent`) filters its **pre-dispatch listener snapshot** for expired listeners and writes that snapshot back into the listener map after callbacks run. Any subscription change made *inside a handler* is therefore undone:
- a listener that unsubscribes itself during t... | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | de7f1eecbcf437bd2fd0e70af4623dc0e5ba82fe | diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts b/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts
index cf6a2581dd7..74b8ea2887a 100644
--- a/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts
+++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts
@@ -93,11 +93,30 @@... | [
"v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts",
"v3/internal/runtime/desktop/@wailsio/runtime/src/events_off_during_dispatch.test.js"
] | [
{
"comment": "The new per-expired-listener `listenerOff()` call inside the dispatch loop can degrade to O(n²) when many listeners expire on the same event (e.g., many `Once`/`OnMultiple(..., 1)` listeners), because each `listenerOff()` re-filters the full listener array. You can preserve the \"don’t clobber liv... | diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/events_off_during_dispatch.test.js b/v3/internal/runtime/desktop/@wailsio/runtime/src/events_off_during_dispatch.test.js
new file mode 100644
index 00000000000..caf25f824d8
--- /dev/null
+++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/events_off_durin... | true |
wailsapp/wails | 5,574 | comment_to_fix | fix(v3/runtime): honour subscription changes made during event dispatch | The new per-expired-listener `listenerOff()` call inside the dispatch loop can degrade to O(n²) when many listeners expire on the same event (e.g., many `Once`/`OnMultiple(..., 1)` listeners), because each `listenerOff()` re-filters the full listener array. You can preserve the "don’t clobber live map" behavior while d... | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | de7f1eecbcf437bd2fd0e70af4623dc0e5ba82fe | diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts b/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts
index cf6a2581dd7..74b8ea2887a 100644
--- a/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts
+++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts
@@ -93,11 +93,30 @@... | [
"v3/internal/runtime/desktop/@wailsio/runtime/src/events.ts"
] | [
{
"comment": "The new per-expired-listener `listenerOff()` call inside the dispatch loop can degrade to O(n²) when many listeners expire on the same event (e.g., many `Once`/`OnMultiple(..., 1)` listeners), because each `listenerOff()` re-filters the full listener array. You can preserve the \"don’t clobber liv... | true | ||
wailsapp/wails | 5,573 | issue_to_patch | [v3] Error Could not resolve "./bindings/changeme" from "main.js" sometimes occurs when running package:universal in GitHub Actions
### Description
When I run `task darwin:package:universal` in GitHub Actions, the following error occurs.
```sh
x Build failed in 38ms
error during build:
Could not resolve "./bindings/... | fix(v3/build): dedupe shared tasks racing in parallel universal builds | # Description
`darwin:build:universal` declares its amd64/arm64 builds as task `deps`, which go-task runs **in parallel**. Each arch build's chain includes `common:build:frontend` → `generate:bindings -clean=true`, so one universal build executed the entire frontend pipeline **twice concurrently**: one invocation dele... | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | 06836ef3cb219753591685c8331985f22ec7cdfc | diff --git a/v3/internal/commands/build_assets/Taskfile.tmpl.yml b/v3/internal/commands/build_assets/Taskfile.tmpl.yml
index f65d0494eb1..74afac8b4d4 100644
--- a/v3/internal/commands/build_assets/Taskfile.tmpl.yml
+++ b/v3/internal/commands/build_assets/Taskfile.tmpl.yml
@@ -4,11 +4,15 @@ tasks:
go:mod:tidy:
s... | [
"v3/internal/commands/build_assets/Taskfile.tmpl.yml"
] | [
{
"comment": "Optional: this race-condition fix relies on `run: once` staying present on shared tasks like `build:frontend`/`generate:bindings`. Since there are already Go tests that assert embedded build-asset template contents (e.g. `taskfile_obfuscation_test.go`, `taskfile_syso_arch_test.go`), consider addin... | true | |
wailsapp/wails | 5,573 | comment_to_fix | fix(v3/build): dedupe shared tasks racing in parallel universal builds | Optional: this race-condition fix relies on `run: once` staying present on shared tasks like `build:frontend`/`generate:bindings`. Since there are already Go tests that assert embedded build-asset template contents (e.g. `taskfile_obfuscation_test.go`, `taskfile_syso_arch_test.go`), consider adding a small regression t... | 38b0b3dad24f77d27dc3f3962c4f9529f95aa3de | 06836ef3cb219753591685c8331985f22ec7cdfc | diff --git a/v3/internal/commands/build_assets/Taskfile.tmpl.yml b/v3/internal/commands/build_assets/Taskfile.tmpl.yml
index f65d0494eb1..74afac8b4d4 100644
--- a/v3/internal/commands/build_assets/Taskfile.tmpl.yml
+++ b/v3/internal/commands/build_assets/Taskfile.tmpl.yml
@@ -4,11 +4,15 @@ tasks:
go:mod:tidy:
s... | [
"v3/internal/commands/build_assets/Taskfile.tmpl.yml"
] | [
{
"comment": "Optional: this race-condition fix relies on `run: once` staying present on shared tasks like `build:frontend`/`generate:bindings`. Since there are already Go tests that assert embedded build-asset template contents (e.g. `taskfile_obfuscation_test.go`, `taskfile_syso_arch_test.go`), consider addin... | true | ||
wailsapp/wails | 5,572 | issue_to_patch | [Windows] Frameless window reports incorrect innerWidth/innerHeight after minimize and restore on high-DPI displays
### Description
When using a frameless window (Frameless: true) on Windows, minimizing and restoring the application can cause the frontend viewport size to become inconsistent with the actual window si... | fix(v3/windows): resync WebView2 rasterization scale after minimise/restore | # Description
On mixed-DPI Windows systems, a frameless window's `window.devicePixelRatio` adopts the **wrong monitor's scale** after maximize → minimize → restore (e.g. stuck at 1.25 on a 200% display) until a manual resize fixes it. Confirmed by the reporter with detailed diagnostics on a 200%/125% dual-monitor setu... | 5d2483927ef1a113a866d96c01622fc211384d52 | e0f60803cb230a173185b0ef90839ec582d0c8b2 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..c4d4d88cc9d 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -5,6 +5,7 @@ package application
import (
"errors"
"fmt"
+ "math"
... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "The rasterization scale is only resynced on `SIZE_RESTORED` while `isMinimizing`. However, restoring a minimized window that was maximized before minimizing can report `w32.SIZE_MAXIMIZED` (and this code already treats that as an un-minimize path). In that case, WebView2 scale would still not be r... | true | |
wailsapp/wails | 5,572 | comment_to_fix | fix(v3/windows): resync WebView2 rasterization scale after minimise/restore | The rasterization scale is only resynced on `SIZE_RESTORED` while `isMinimizing`. However, restoring a minimized window that was maximized before minimizing can report `w32.SIZE_MAXIMIZED` (and this code already treats that as an un-minimize path). In that case, WebView2 scale would still not be resynced, potentially l... | 5d2483927ef1a113a866d96c01622fc211384d52 | e0f60803cb230a173185b0ef90839ec582d0c8b2 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..c4d4d88cc9d 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -5,6 +5,7 @@ package application
import (
"errors"
"fmt"
+ "math"
... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "The rasterization scale is only resynced on `SIZE_RESTORED` while `isMinimizing`. However, restoring a minimized window that was maximized before minimizing can report `w32.SIZE_MAXIMIZED` (and this code already treats that as an un-minimize path). In that case, WebView2 scale would still not be r... | true | ||
wailsapp/wails | 5,572 | comment_to_fix | fix(v3/windows): resync WebView2 rasterization scale after minimise/restore | `GetRasterizationScale()` returns a floating-point value; comparing with `current == scale` can fail on custom DPI values (e.g. non-25% increments) due to rounding, causing unnecessary COM calls to `PutRasterizationScale` on every resync. Using a small tolerance avoids churn while still updating when a meaningful chang... | 5d2483927ef1a113a866d96c01622fc211384d52 | e0f60803cb230a173185b0ef90839ec582d0c8b2 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..c4d4d88cc9d 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -5,6 +5,7 @@ package application
import (
"errors"
"fmt"
+ "math"
... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "`GetRasterizationScale()` returns a floating-point value; comparing with `current == scale` can fail on custom DPI values (e.g. non-25% increments) due to rounding, causing unnecessary COM calls to `PutRasterizationScale` on every resync. Using a small tolerance avoids churn while still updating w... | true | ||
wailsapp/wails | 5,571 | issue_to_patch | [v3] window is not defined (Next.js output export).
### Description
I modified the v3 example code to build a NextJS app.
Unfortunately I get an error when building the next app:
'window is not defined'
https://github.com/wailsapp/wails/blob/57d55643bc87753774d1bb77b32b403a1daabd22/v3/internal/runtime/desktop/%40w... | fix(v3/runtime): make @wailsio/runtime importable without a DOM | # Description
Importing `@wailsio/runtime` in a DOM-less environment — most commonly Next.js prerendering during `next build` — threw `ReferenceError: window is not defined`. Several modules touch `window`/`document` **at module scope**:
- `runtime.ts` computed the runtime URL from `window.location.origin` at import
... | 5d2483927ef1a113a866d96c01622fc211384d52 | 589cc0dc1af960aad7585ec0b029f51db9fcee83 | diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/calls.ts b/v3/internal/runtime/desktop/@wailsio/runtime/src/calls.ts
index c80529857b6..d6e245d8713 100644
--- a/v3/internal/runtime/desktop/@wailsio/runtime/src/calls.ts
+++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/calls.ts
@@ -13,7 +13,11 @@ impo... | [
"v3/internal/runtime/desktop/@wailsio/runtime/src/calls.ts",
"v3/internal/runtime/desktop/@wailsio/runtime/src/contextmenu.ts",
"v3/internal/runtime/desktop/@wailsio/runtime/src/dialogs.ts",
"v3/internal/runtime/desktop/@wailsio/runtime/src/drag.ts",
"v3/internal/runtime/desktop/@wailsio/runtime/src/environ... | [
{
"comment": "`System.invoke(\"wails:runtime:ready\")` still runs at module import time even when `hasDOM` is false. It’s a harmless no-op in SSR (because `System.invoke` resolves to `null` transport), but wrapping it keeps the SSR import path consistently free of runtime init side effects and matches the surro... | diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/ssr_import.test.js b/v3/internal/runtime/desktop/@wailsio/runtime/src/ssr_import.test.js
new file mode 100644
index 00000000000..5a9fb84d91d
--- /dev/null
+++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/ssr_import.test.js
@@ -0,0 +1,8 @@
+// @vitest-e... | true |
wailsapp/wails | 5,571 | comment_to_fix | fix(v3/runtime): make @wailsio/runtime importable without a DOM | `System.invoke("wails:runtime:ready")` still runs at module import time even when `hasDOM` is false. It’s a harmless no-op in SSR (because `System.invoke` resolves to `null` transport), but wrapping it keeps the SSR import path consistently free of runtime init side effects and matches the surrounding guarded setup. | 5d2483927ef1a113a866d96c01622fc211384d52 | 589cc0dc1af960aad7585ec0b029f51db9fcee83 | diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/index.ts b/v3/internal/runtime/desktop/@wailsio/runtime/src/index.ts
index 01219e029fc..f07e0cce471 100644
--- a/v3/internal/runtime/desktop/@wailsio/runtime/src/index.ts
+++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/index.ts
@@ -9,7 +9,11 @@ The el... | [
"v3/internal/runtime/desktop/@wailsio/runtime/src/index.ts"
] | [
{
"comment": "`System.invoke(\"wails:runtime:ready\")` still runs at module import time even when `hasDOM` is false. It’s a harmless no-op in SSR (because `System.invoke` resolves to `null` transport), but wrapping it keeps the SSR import path consistently free of runtime init side effects and matches the surro... | true | ||
wailsapp/wails | 5,570 | issue_to_patch | [v3] dev mode, hot update vue file, cause fatal
### Description
4:08:05 PM [vite] (client) hmr update /src/components/proxy/Proxy.vue
4:08PM ERR
******************************** FATAL *********************************
* There has been a catastrophic failure in your application. *
*************************... | fix(v3): reject the call instead of crashing when a bound method panics | # Description
A panic inside a user's bound service method is recovered by `handlePanic`, whose **default path is `globalApplication.fatal`** — the catastrophic-failure banner plus process exit. So one bug in one bound method (in #5037, a nil dereference in the reporter's `WindowGetHeight` triggered by an HMR-driven f... | 5d2483927ef1a113a866d96c01622fc211384d52 | 2ec817497cba9125cb10462c4231fe3c68746037 | diff --git a/v3/pkg/application/bindings.go b/v3/pkg/application/bindings.go
index 45660ecc98d..ae2140f9050 100644
--- a/v3/pkg/application/bindings.go
+++ b/v3/pkg/application/bindings.go
@@ -303,11 +303,40 @@ var errorType = reflect.TypeFor[error]()
// If the call succeeds, result will be either a non-error return v... | [
"v3/pkg/application/bindings.go",
"v3/pkg/application/bindings_panic_internal_test.go",
"v3/pkg/application/bindings_test.go"
] | [
{
"comment": "The stack trace is computed even when `globalApplication` is nil, but it’s only used for logging or the configured `PanicHandler`. Computing it conditionally avoids unnecessary work and keeps the panic-to-CallError conversion lightweight in contexts where `application.New()` hasn’t been called (or... | diff --git a/v3/pkg/application/bindings_panic_internal_test.go b/v3/pkg/application/bindings_panic_internal_test.go
new file mode 100644
index 00000000000..dcb2ab8da61
--- /dev/null
+++ b/v3/pkg/application/bindings_panic_internal_test.go
@@ -0,0 +1,64 @@
+package application
+
+import (
+ "context"
+ "errors"
+ "test... | true |
wailsapp/wails | 5,569 | issue_to_patch | [v3, macOS] RelativePosition() and SetRelativePosition() use inconsistent X coordinate spaces
## Description
On macOS, `RelativePosition()` and `SetRelativePosition()` disagree about what the X coordinate means:
- `RelativePosition()` returns the **absolute** X (NSScreen logical points, not screen-relative)
- `SetRe... | fix(v3/darwin): make RelativePosition mirror SetRelativePosition on both axes | # Description
On macOS, `RelativePosition()` and `SetRelativePosition()` disagreed about the coordinate space:
- **Get** returned the **absolute** X (`frame.origin.x`, no `screenFrame.origin.x` subtraction) and computed Y **without** the screen's `origin.y` term.
- **Set** treats both X and Y as screen-relative.
So ... | 5d2483927ef1a113a866d96c01622fc211384d52 | f3970ebc219717ef8687ff04de238795415dcf7b | diff --git a/v3/pkg/application/webview_window_darwin.go b/v3/pkg/application/webview_window_darwin.go
index 725b1d36172..9a9fcd43885 100644
--- a/v3/pkg/application/webview_window_darwin.go
+++ b/v3/pkg/application/webview_window_darwin.go
@@ -620,19 +620,25 @@ int windowGetHeight(void* nsWindow) {
return [(WebviewW... | [
"v3/pkg/application/webview_window_darwin.go"
] | [
{
"comment": "The new header comment is slightly inaccurate/ambiguous: this function uses the NSScreen **frame** (not the WorkArea/visibleFrame), and the previous bug didn’t necessarily cause drift on *both* axes (X was wrong when origin.x != 0; Y only when origin.y != 0). Tweaking the wording will avoid confus... | true | |
wailsapp/wails | 5,564 | issue_to_patch | [v3] purego Linux backend fails to compile
### Description
The purego (CGO-free) Linux backend does not compile in v3.0.0-alpha.98.
```
internal/assetserver/webview/responsewriter_linux_purego.go:128:
*responseWriter does not implement ResponseWriter (wrong type for method Finish)
have Finish()
want Finish(... | fix(v3/linux): repair purego assetserver backend compile errors | # Description
First layer of #5550: makes `internal/assetserver/webview` compile (and behave correctly) under `GOOS=linux CGO_ENABLED=0 -tags purego`.
## What was broken
Reproduced with `GOOS=linux CGO_ENABLED=0 go build -tags purego ./pkg/application` — the first failing package was `internal/assetserver/webview`:
... | 5d2483927ef1a113a866d96c01622fc211384d52 | 846dbd96c66a675a4a692f8911522251409088de | diff --git a/v3/internal/assetserver/webview/responsewriter_linux_purego.go b/v3/internal/assetserver/webview/responsewriter_linux_purego.go
index 80476522668..cffdc75fea8 100644
--- a/v3/internal/assetserver/webview/responsewriter_linux_purego.go
+++ b/v3/internal/assetserver/webview/responsewriter_linux_purego.go
@@ ... | [
"v3/internal/assetserver/webview/responsewriter_linux_purego.go",
"v3/internal/assetserver/webview/webkit2_purego.go"
] | [
{
"comment": "`SOUP_MESSAGE_HEADERS_RESPONSE` is declared as an exported, all-caps identifier but is only used internally in this file. Consider making it unexported (Go-style camelCase) to avoid unnecessarily expanding the package surface area and to match the naming style used elsewhere in this package (e.g.,... | true | |
wailsapp/wails | 5,564 | comment_to_fix | fix(v3/linux): repair purego assetserver backend compile errors | `SOUP_MESSAGE_HEADERS_RESPONSE` is declared as an exported, all-caps identifier but is only used internally in this file. Consider making it unexported (Go-style camelCase) to avoid unnecessarily expanding the package surface area and to match the naming style used elsewhere in this package (e.g., `HeaderContentType`, ... | 5d2483927ef1a113a866d96c01622fc211384d52 | 846dbd96c66a675a4a692f8911522251409088de | diff --git a/v3/internal/assetserver/webview/webkit2_purego.go b/v3/internal/assetserver/webview/webkit2_purego.go
index 28832c8bd95..69e7ccdacbb 100644
--- a/v3/internal/assetserver/webview/webkit2_purego.go
+++ b/v3/internal/assetserver/webview/webkit2_purego.go
@@ -1,57 +1,73 @@
-//go:build linux && purego
+//go:bui... | [
"v3/internal/assetserver/webview/webkit2_purego.go"
] | [
{
"comment": "`SOUP_MESSAGE_HEADERS_RESPONSE` is declared as an exported, all-caps identifier but is only used internally in this file. Consider making it unexported (Go-style camelCase) to avoid unnecessarily expanding the package surface area and to match the naming style used elsewhere in this package (e.g.,... | true | ||
wailsapp/wails | 5,533 | issue_to_patch | v3: convert tool has-cc to generic tool has <target> | ## Summary
- Replaces `wails3 tool has-cc` with the generic `wails3 tool has <target>`
- `cc` retains its special logic (checks for `gcc` **or** `clang`)
- Any other name is looked up directly in `PATH`, so `wails3 tool has git`, `wails3 tool has node`, etc. work out of the box without new subcommands
- Updates the Li... | 5d2483927ef1a113a866d96c01622fc211384d52 | 307db37dabf591f63668fff657a970023a6708fc | diff --git a/docs/src/content/docs/guides/cli.mdx b/docs/src/content/docs/guides/cli.mdx
index af6b2a6185a..4005f244e64 100644
--- a/docs/src/content/docs/guides/cli.mdx
+++ b/docs/src/content/docs/guides/cli.mdx
@@ -495,6 +495,70 @@ wails3 tool package [flags]
| `-config` | Config file path | ... | [
"docs/src/content/docs/guides/cli.mdx",
"v3/cmd/wails3/main.go",
"v3/internal/buildwarnings/buildwarnings.go",
"v3/internal/buildwarnings/buildwarnings_test.go",
"v3/internal/commands/build_assets/linux/Taskfile.yml",
"v3/internal/commands/task.go",
"v3/internal/commands/task_wrapper.go",
"v3/internal... | [
{
"comment": "`ToolHas` silently treats an empty tool name as \"not found\" (because `exec.LookPath(\"\")` fails) and still returns nil. That makes `wails3 tool has` (missing arg) succeed with output `false`, which can hide user/script mistakes. Consider validating the positional argument and returning a clear ... | diff --git a/v3/internal/buildwarnings/buildwarnings_test.go b/v3/internal/buildwarnings/buildwarnings_test.go
new file mode 100644
index 00000000000..ea185f3ed5d
--- /dev/null
+++ b/v3/internal/buildwarnings/buildwarnings_test.go
@@ -0,0 +1,56 @@
+package buildwarnings
+
+import (
+ "os"
+ "testing"
+)
+
+func TestAdd... | true | |
wailsapp/wails | 5,533 | comment_to_fix | v3: convert tool has-cc to generic tool has <target> | Removing the `has-cc` subcommand is a breaking CLI change for any existing scripts or Taskfiles outside the generated templates. Consider keeping `wails3 tool has-cc` as a deprecated alias that forwards to `wails3 tool has cc`, at least for one release cycle, while introducing the new generic `has` command. | 5d2483927ef1a113a866d96c01622fc211384d52 | 307db37dabf591f63668fff657a970023a6708fc | diff --git a/v3/cmd/wails3/main.go b/v3/cmd/wails3/main.go
index 53dee2965b3..bd8edb7f948 100644
--- a/v3/cmd/wails3/main.go
+++ b/v3/cmd/wails3/main.go
@@ -98,7 +98,8 @@ func main() {
tool.NewSubCommandFunction("lipo", "Create macOS universal binary from multiple architectures", commands.ToolLipo)
tool.NewSubComma... | [
"v3/cmd/wails3/main.go"
] | [
{
"comment": "Removing the `has-cc` subcommand is a breaking CLI change for any existing scripts or Taskfiles outside the generated templates. Consider keeping `wails3 tool has-cc` as a deprecated alias that forwards to `wails3 tool has cc`, at least for one release cycle, while introducing the new generic `has... | true | ||
wailsapp/wails | 5,520 | issue_to_patch | v3: replace go-git direct dependency with system git CLI | ## Summary
- Introduces `v3/internal/git`: a thin, stdlib-only wrapper around the system `git` executable with five exported functions — `HeadHash`, `Clone`, `Init`, `RemoteAdd`, `AddAll`
- Migrates all five callers off `github.com/go-git/go-git/v5`: `internal/commands/init.go`, `internal/templates/templates.go`, `int... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1f90da78f328b62ccbfc86577fa826075731c730 | diff --git a/v3/go.mod b/v3/go.mod
index 9fe9738452a..0d5fea6a4a6 100644
--- a/v3/go.mod
+++ b/v3/go.mod
@@ -13,7 +13,6 @@ require (
github.com/charmbracelet/huh v0.8.0
github.com/coder/websocket v1.8.14
github.com/ebitengine/purego v0.9.1
- github.com/go-git/go-git/v5 v5.19.1
github.com/go-json-experiment/json... | [
"v3/go.mod",
"v3/internal/commands/init.go",
"v3/internal/doctor/doctor.go",
"v3/internal/git/git.go",
"v3/internal/git/git_test.go",
"v3/internal/templates/templates.go",
"v3/pkg/application/application_debug.go",
"v3/pkg/doctor-ng/doctor.go"
] | [
{
"comment": "`HeadHash` assumes the `git rev-parse` output is always at least 8 bytes and will panic if the executable returns a shorter successful output. Since this wrapper is now the boundary to an external command, validate the output length and return an error instead of panicking.",
"path": "v3/inter... | diff --git a/v3/internal/git/git_test.go b/v3/internal/git/git_test.go
new file mode 100644
index 00000000000..0917d3772f9
--- /dev/null
+++ b/v3/internal/git/git_test.go
@@ -0,0 +1,112 @@
+package git
+
+import (
+ "errors"
+ "os"
+ "os/exec"
+ "path/filepath"
+ "testing"
+)
+
+// makeRepo creates a temp git repositor... | true | |
wailsapp/wails | 5,520 | comment_to_fix | v3: replace go-git direct dependency with system git CLI | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Redact git arguments before embedding them in errors.**
`strings.Join(args, " ")` can expose credentials/tokens when `url` contains embedded auth (e.g., `https://token@host/...`) in `Clone`/`RemoteAdd` failures. Return a sanitized command string instead.
<details>... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1f90da78f328b62ccbfc86577fa826075731c730 | diff --git a/v3/internal/git/git.go b/v3/internal/git/git.go
new file mode 100644
index 00000000000..d8cc9ab07b3
--- /dev/null
+++ b/v3/internal/git/git.go
@@ -0,0 +1,91 @@
+package git
+
+import (
+ "bytes"
+ "errors"
+ "fmt"
+ "net/url"
+ "os/exec"
+ "strings"
+)
+
+// ErrNotInstalled is returned when git is not foun... | [
"v3/internal/git/git.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Redact git arguments before embedding them in errors.**\n\n`strings.Join(args, \" \")` can expose credentials/tokens when `url` contains embedded auth (e.g., `https://token@host/...`) in `Clone`/`RemoteAdd` failures. Return a sanitized command... | true | ||
wailsapp/wails | 5,520 | comment_to_fix | v3: replace go-git direct dependency with system git CLI | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Guard short hash output before slicing.**
`hash[:8]` can panic if output is unexpectedly shorter than 8 chars. Add a length check and return an error instead.
<details>
<summary>Suggested fix</summary>
```diff
func HeadHash(dir string) (string, error) {
hash, ... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1f90da78f328b62ccbfc86577fa826075731c730 | diff --git a/v3/internal/git/git.go b/v3/internal/git/git.go
new file mode 100644
index 00000000000..d8cc9ab07b3
--- /dev/null
+++ b/v3/internal/git/git.go
@@ -0,0 +1,91 @@
+package git
+
+import (
+ "bytes"
+ "errors"
+ "fmt"
+ "net/url"
+ "os/exec"
+ "strings"
+)
+
+// ErrNotInstalled is returned when git is not foun... | [
"v3/internal/git/git.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Guard short hash output before slicing.**\n\n`hash[:8]` can panic if output is unexpectedly shorter than 8 chars. Add a length check and return an error instead.\n \n<details>\n<summary>Suggested fix</summary>\n\n```diff\n func HeadHash(dir st... | true | ||
wailsapp/wails | 5,490 | issue_to_patch | docs(v3): update README — replace 'v3 Alpha' with Beta scope statement | ## Summary
Updates `v3/README.md` from the placeholder "v3 Alpha" text to a proper Beta README that includes:
- Title: "Wails v3 Beta"
- What Beta means: stable API guarantee for `v3/pkg/application`
- Getting Started: link to docs site and install instructions
- Beta scope: deferred items (iOS/Android, GTK4, some Ap... | 5d2483927ef1a113a866d96c01622fc211384d52 | 4d5ab1ca8bc03ae8837a74a412cc78fd9f078869 | diff --git a/v3/README.md b/v3/README.md
index 2d0c36a0b0e..99e4c0c497f 100644
--- a/v3/README.md
+++ b/v3/README.md
@@ -1,9 +1,33 @@
-# v3 Alpha
+# Wails v3 Beta
-Thanks for wanting to help out with testing/developing Wails v3! This guide will help you get started.
+Welcome to Wails v3! This is the beta release of t... | [
"v3/README.md"
] | [
{
"comment": "`STABILITY.md` is referenced here, but there is no `v3/STABILITY.md` in the repository, so this link will be broken. Either add the missing `v3/STABILITY.md` file (preferred if this policy should live in-repo) or change the link to an existing stability-policy location.\n",
"path": "v3/README.... | true | ||
wailsapp/wails | 5,490 | comment_to_fix | docs(v3): update README — replace 'v3 Alpha' with Beta scope statement | For consistency with other Wails docs/READMEs that use fenced blocks with language hints (e.g., ```bash), consider adding a language identifier (like `bash`) to this code block so it renders with proper syntax highlighting.
| 5d2483927ef1a113a866d96c01622fc211384d52 | 4d5ab1ca8bc03ae8837a74a412cc78fd9f078869 | diff --git a/v3/README.md b/v3/README.md
index 2d0c36a0b0e..99e4c0c497f 100644
--- a/v3/README.md
+++ b/v3/README.md
@@ -1,9 +1,33 @@
-# v3 Alpha
+# Wails v3 Beta
-Thanks for wanting to help out with testing/developing Wails v3! This guide will help you get started.
+Welcome to Wails v3! This is the beta release of t... | [
"v3/README.md"
] | [
{
"comment": "For consistency with other Wails docs/READMEs that use fenced blocks with language hints (e.g., ```bash), consider adding a language identifier (like `bash`) to this code block so it renders with proper syntax highlighting.\n",
"path": "v3/README.md",
"hunk": "@@ -1,9 +1,33 @@\n-# v3 Alpha... | true | ||
wailsapp/wails | 5,490 | comment_to_fix | docs(v3): update README — replace 'v3 Alpha' with Beta scope statement | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Add language identifier to code block.**
The fenced code block should specify a language (e.g., `bash` or `shell`) for proper syntax highlighting and better readability.
<details>
<summary>📝 Proposed fix</summary>
```diff
-```
+```bash
go install github.com/w... | 5d2483927ef1a113a866d96c01622fc211384d52 | 4d5ab1ca8bc03ae8837a74a412cc78fd9f078869 | diff --git a/v3/README.md b/v3/README.md
index 2d0c36a0b0e..99e4c0c497f 100644
--- a/v3/README.md
+++ b/v3/README.md
@@ -1,9 +1,33 @@
-# v3 Alpha
+# Wails v3 Beta
-Thanks for wanting to help out with testing/developing Wails v3! This guide will help you get started.
+Welcome to Wails v3! This is the beta release of t... | [
"v3/README.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add language identifier to code block.**\n\nThe fenced code block should specify a language (e.g., `bash` or `shell`) for proper syntax highlighting and better readability.\n\n\n\n\n<details>\n<summary>📝 Proposed fix</summary>\n\n```diff\n-``... | true | ||
wailsapp/wails | 5,490 | comment_to_fix | docs(v3): update README — replace 'v3 Alpha' with Beta scope statement | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Description: Check if v3/STABILITY.md exists and preview its content
# Check if the file exists
if [ -f "v3/STABILITY.md" ]; then
echo "✓ v3/STABILITY.md exists"
echo ""
echo "File pr... | 5d2483927ef1a113a866d96c01622fc211384d52 | 4d5ab1ca8bc03ae8837a74a412cc78fd9f078869 | diff --git a/v3/README.md b/v3/README.md
index 2d0c36a0b0e..99e4c0c497f 100644
--- a/v3/README.md
+++ b/v3/README.md
@@ -1,9 +1,33 @@
-# v3 Alpha
+# Wails v3 Beta
-Thanks for wanting to help out with testing/developing Wails v3! This guide will help you get started.
+Welcome to Wails v3! This is the beta release of t... | [
"v3/README.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check if v3/STABILITY.md exists and preview its content\n\n# Check if the file exists\nif [ -f \"v3/STABILITY.md\" ]; then\n echo \"✓ v3/STABILIT... | true | ||
wailsapp/wails | 5,579 | issue_to_patch | test(v2/runtime): fix vitest mock API usage in events tests | # Description
Three tests in `desktop/events.test.js` have been failing on master independent of any product change: they read mock invocations via `window.WailsInvoke.calls` (the old jest/vitest spy shape), but modern vitest exposes them at `.mock.calls` — so the property is `undefined` and the assertions throw.
Thi... | 99f9b5fc31f920863e8cfb5c6155aaaa73113f8f | f88e2e6f2db376ba60b4ad315f58815dc2bea189 | [
"v2/internal/frontend/runtime/desktop/events.test.js"
] | [] | diff --git a/v2/internal/frontend/runtime/desktop/events.test.js b/v2/internal/frontend/runtime/desktop/events.test.js
index e18edf9214e..f214fe699ec 100644
--- a/v2/internal/frontend/runtime/desktop/events.test.js
+++ b/v2/internal/frontend/runtime/desktop/events.test.js
@@ -83,7 +83,7 @@ describe('EventsEmit', () => ... | true | ||
wailsapp/wails | 5,578 | issue_to_patch | Removing an event while handling an event leave the event handler on
### Description
in my JS code, i have something like that;
```js
let ev = runtime.EventsOn( "name", () => {
// here i call ev that will call runtime.EventsOff( )
if( some_reason ) { // the reason i do not call EventOnOnce
ev( ); ... | fix(v2/runtime): honour EventsOff made during event dispatch | # Description
The v2 half of #4393, mirroring the v3 fix in #5574. `notifyListeners` in `desktop/events.js` iterates a snapshot, splices expired listeners out of **the snapshot**, then writes the snapshot back into `eventListeners` — undoing any subscription change made inside a callback:
- `EventsOff` (or the `Event... | c42bf4bdc9aef293f3915fac4a41a1058bfb53df | 4ec808f300b001809eec25f4e5b2839591476459 | diff --git a/v2/internal/frontend/runtime/desktop/events.js b/v2/internal/frontend/runtime/desktop/events.js
index e665a8aff0a..1c36579efc2 100644
--- a/v2/internal/frontend/runtime/desktop/events.js
+++ b/v2/internal/frontend/runtime/desktop/events.js
@@ -90,33 +90,27 @@ function notifyListeners(eventData) {
// G... | [
"v2/internal/frontend/runtime/desktop/events.js",
"v2/internal/frontend/runtime/desktop/events.test.js",
"v2/internal/frontend/runtime/runtime_debug_desktop.js",
"v2/internal/frontend/runtime/runtime_prod_desktop.js"
] | [
{
"comment": "The \"destroy\" path duplicates the listener removal logic that already exists in `listenerOff(listener)`. Using the helper here avoids two subtly different removal implementations and reduces the chance they diverge in future changes.",
"path": "v2/internal/frontend/runtime/desktop/events.js"... | diff --git a/v2/internal/frontend/runtime/desktop/events.test.js b/v2/internal/frontend/runtime/desktop/events.test.js
index 69ece676fae..e18edf9214e 100644
--- a/v2/internal/frontend/runtime/desktop/events.test.js
+++ b/v2/internal/frontend/runtime/desktop/events.test.js
@@ -130,3 +130,42 @@ describe('EventsOffAll', (... | true |
wailsapp/wails | 5,578 | comment_to_fix | fix(v2/runtime): honour EventsOff made during event dispatch | The "destroy" path duplicates the listener removal logic that already exists in `listenerOff(listener)`. Using the helper here avoids two subtly different removal implementations and reduces the chance they diverge in future changes. | c42bf4bdc9aef293f3915fac4a41a1058bfb53df | 4ec808f300b001809eec25f4e5b2839591476459 | diff --git a/v2/internal/frontend/runtime/desktop/events.js b/v2/internal/frontend/runtime/desktop/events.js
index e665a8aff0a..1c36579efc2 100644
--- a/v2/internal/frontend/runtime/desktop/events.js
+++ b/v2/internal/frontend/runtime/desktop/events.js
@@ -90,33 +90,27 @@ function notifyListeners(eventData) {
// G... | [
"v2/internal/frontend/runtime/desktop/events.js"
] | [
{
"comment": "The \"destroy\" path duplicates the listener removal logic that already exists in `listenerOff(listener)`. Using the helper here avoids two subtly different removal implementations and reduces the chance they diverge in future changes.",
"path": "v2/internal/frontend/runtime/desktop/events.js"... | true | ||
wailsapp/wails | 5,578 | comment_to_fix | fix(v2/runtime): honour EventsOff made during event dispatch | The fix also claims to preserve listeners that are registered during dispatch (previously they were dropped when the snapshot was written back), but the new regression tests only cover self-removal. Adding a test for the "add during dispatch" case would prevent this from regressing again. | c42bf4bdc9aef293f3915fac4a41a1058bfb53df | 4ec808f300b001809eec25f4e5b2839591476459 | diff --git a/v2/internal/frontend/runtime/desktop/events.test.js b/v2/internal/frontend/runtime/desktop/events.test.js
index 69ece676fae..e18edf9214e 100644
--- a/v2/internal/frontend/runtime/desktop/events.test.js
+++ b/v2/internal/frontend/runtime/desktop/events.test.js
@@ -130,3 +130,42 @@ describe('EventsOffAll', (... | [
"v2/internal/frontend/runtime/desktop/events.test.js"
] | [
{
"comment": "The fix also claims to preserve listeners that are registered during dispatch (previously they were dropped when the snapshot was written back), but the new regression tests only cover self-removal. Adding a test for the \"add during dispatch\" case would prevent this from regressing again.",
... | true | ||
wailsapp/wails | 5,582 | issue_to_patch | [v3] Window animations disappear in frameless mode.
### Description
Window animations disappear in frameless mode.
### To Reproduce
### main.go
```go
package main
import (
"embed"
_ "embed"
"log"
"pql/pkg/service"
"github.com/wailsapp/wails/v3/pkg/application"
"github.com/wailsapp/wails/v3/pkg/events"
)
... | fix(v3/windows): keep DWM animations when SetFrameless(true) is called | # Description
Reporter-confirmed trigger for #5541: window animations are fine with `Frameless: true` at creation, but **calling `window.SetFrameless(true)` at runtime kills all of them** (minimise/restore/maximise transitions, Aero snap) — including in the repo's own frameless example.
Root cause: two different fram... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1c868903bee0d4e5856baf8910e5dde7acc871c1 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..f6fbc7e7c31 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -1257,12 +1257,30 @@ func (w *windowsWebviewWindow) getScreen() (*Screen... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "`setFrameless` currently overwrites the entire `GWL_STYLE` with a fixed `WS_VISIBLE|WS_OVERLAPPEDWINDOW` value. This can unintentionally clear state/style bits (e.g. `WS_MAXIMIZE`/`WS_MINIMIZE`) and also re-enable option-controlled styles like minimise/maximise/close button states that may have be... | true | |
wailsapp/wails | 5,582 | comment_to_fix | fix(v3/windows): keep DWM animations when SetFrameless(true) is called | `setFrameless` currently overwrites the entire `GWL_STYLE` with a fixed `WS_VISIBLE|WS_OVERLAPPEDWINDOW` value. This can unintentionally clear state/style bits (e.g. `WS_MAXIMIZE`/`WS_MINIMIZE`) and also re-enable option-controlled styles like minimise/maximise/close button states that may have been disabled earlier vi... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1c868903bee0d4e5856baf8910e5dde7acc871c1 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..f6fbc7e7c31 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -1257,12 +1257,30 @@ func (w *windowsWebviewWindow) getScreen() (*Screen... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "`setFrameless` currently overwrites the entire `GWL_STYLE` with a fixed `WS_VISIBLE|WS_OVERLAPPEDWINDOW` value. This can unintentionally clear state/style bits (e.g. `WS_MAXIMIZE`/`WS_MINIMIZE`) and also re-enable option-controlled styles like minimise/maximise/close button states that may have be... | true | ||
wailsapp/wails | 5,582 | comment_to_fix | fix(v3/windows): keep DWM animations when SetFrameless(true) is called | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Preserve `WS_DISABLED` when rewriting `GWL_STYLE`.**
Line 1274-Line 1278 currently rebuilds style without `WS_DISABLED`. If a window is disabled (`setEnabled(false)`), toggling frameless can unintentionally re-enable it.
<details>
<summary>Suggested patch</sum... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1c868903bee0d4e5856baf8910e5dde7acc871c1 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..f6fbc7e7c31 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -1257,12 +1257,30 @@ func (w *windowsWebviewWindow) getScreen() (*Screen... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Preserve `WS_DISABLED` when rewriting `GWL_STYLE`.**\n\nLine 1274-Line 1278 currently rebuilds style without `WS_DISABLED`. If a window is disabled (`setEnabled(false)`), toggling frameless can unintentionally re-enable it.\n\n \n\n<details>... | true | ||
wailsapp/wails | 5,582 | comment_to_fix | fix(v3/windows): keep DWM animations when SetFrameless(true) is called | `setFrameless` currently rebuilds `GWL_STYLE` from `WS_OVERLAPPEDWINDOW` plus a small preserved bitset. This drops `WS_DISABLED`, so calling `SetFrameless(...)` on a disabled window (e.g., a modal-disabled parent, or after `SetEnabled(false)`) will unintentionally re-enable it. | 5d2483927ef1a113a866d96c01622fc211384d52 | 1c868903bee0d4e5856baf8910e5dde7acc871c1 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..f6fbc7e7c31 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -1257,12 +1257,30 @@ func (w *windowsWebviewWindow) getScreen() (*Screen... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "`setFrameless` currently rebuilds `GWL_STYLE` from `WS_OVERLAPPEDWINDOW` plus a small preserved bitset. This drops `WS_DISABLED`, so calling `SetFrameless(...)` on a disabled window (e.g., a modal-disabled parent, or after `SetEnabled(false)`) will unintentionally re-enable it.",
"path": "v3/p... | true | ||
wailsapp/wails | 5,582 | comment_to_fix | fix(v3/windows): keep DWM animations when SetFrameless(true) is called | `setFrameless` now always forces an overlapped-window style (it clears `WS_POPUP`). If `SetFrameless(...)` is called while the window is fullscreen (which uses `WS_POPUP`), this will break fullscreen styling and can desync it from `isCurrentlyFullscreen`. Consider no-op'ing style changes while fullscreen to avoid inter... | 5d2483927ef1a113a866d96c01622fc211384d52 | 1c868903bee0d4e5856baf8910e5dde7acc871c1 | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 6cbf7bd67b7..f6fbc7e7c31 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -1257,12 +1257,30 @@ func (w *windowsWebviewWindow) getScreen() (*Screen... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "`setFrameless` now always forces an overlapped-window style (it clears `WS_POPUP`). If `SetFrameless(...)` is called while the window is fullscreen (which uses `WS_POPUP`), this will break fullscreen styling and can desync it from `isCurrentlyFullscreen`. Consider no-op'ing style changes while ful... | true | ||
wailsapp/wails | 5,593 | issue_to_patch | [v3][doc]Incorrect type mapping for service method binding
### Have you read the Documentation Contribution Guidelines?
- [x] I have read the [Documentation Contribution Guidelines](https://wails.io/community-guide#ways-of-contributing).
### Description
[related docs](https://github.com/wailsapp/wails/blob/7cc9bf03... | [v3][doc]: update type mapping docs about binding | - append test cases for type mapping
<!--
*********************************************************************
* PLEASE READ BEFORE SUBMITTING YOUR PR *
* YOUR PR MAY BE REJECTED IF IT DOES NOT FOLLOW THESE STEPS *
*********************************************************... | 36c1550134bde49d27504a7a43148a647beeee95 | 8c6f0ea7afdffc7b9c2742d87d48a420e4bd688f | diff --git a/docs/src/content/docs/features/bindings/methods.mdx b/docs/src/content/docs/features/bindings/methods.mdx
index 7d88d18ac68..986f9847dfe 100644
--- a/docs/src/content/docs/features/bindings/methods.mdx
+++ b/docs/src/content/docs/features/bindings/methods.mdx
@@ -311,30 +311,30 @@ const sum = await Calcula... | [
"docs/src/content/docs/features/bindings/methods.mdx",
"docs/src/content/docs/features/bindings/models.mdx",
"v3/internal/generator/testcases/type_mapping/bound_types.json",
"v3/internal/generator/testcases/type_mapping/main.go",
"v3/internal/generator/testdata/output/lang=JS/UseInterfaces=false/UseNames=fa... | [] | true | |
wailsapp/wails | 5,592 | issue_to_patch | docs: add Web Permissions guide and options reference (missing from #5567) | ## What's missing
PR #5567 shipped a cross-platform `Permissions` map for controlling camera, microphone, geolocation, notifications, and clipboard-read access from web content. No documentation was included.
## What this adds
### New page: [Web Permissions](/features/windows/permissions)
Full developer guide cover... | f085aa9d005120805d5571fef3ab40ddaf9ab989 | 488c361abfc91f26350ab407c08db5e8716473f4 | diff --git a/docs/astro.config.mjs b/docs/astro.config.mjs
index 3070e5c3b1c..bd888f1e1a0 100644
--- a/docs/astro.config.mjs
+++ b/docs/astro.config.mjs
@@ -188,6 +188,7 @@ export default defineConfig({
items: [
{ label: "Window Basics", link: "/features/windows/basics" },
... | [
"docs/astro.config.mjs",
"docs/src/content/docs/features/windows/options.mdx",
"docs/src/content/docs/features/windows/permissions.mdx"
] | [
{
"comment": "Unused imports: this page only uses `Aside`, but also imports `Tabs` and `TabItem`. Removing unused imports avoids build/lint warnings and keeps the MDX clean.",
"path": "docs/src/content/docs/features/windows/permissions.mdx",
"hunk": "@@ -0,0 +1,207 @@\n+---\n+title: Web Permissions\n+de... | true | ||
wailsapp/wails | 5,592 | comment_to_fix | docs: add Web Permissions guide and options reference (missing from #5567) | Unused imports: this page only uses `Aside`, but also imports `Tabs` and `TabItem`. Removing unused imports avoids build/lint warnings and keeps the MDX clean. | f085aa9d005120805d5571fef3ab40ddaf9ab989 | 488c361abfc91f26350ab407c08db5e8716473f4 | diff --git a/docs/src/content/docs/features/windows/permissions.mdx b/docs/src/content/docs/features/windows/permissions.mdx
new file mode 100644
index 00000000000..75ca152d65c
--- /dev/null
+++ b/docs/src/content/docs/features/windows/permissions.mdx
@@ -0,0 +1,210 @@
+---
+title: Permissions
+description: Control cam... | [
"docs/src/content/docs/features/windows/permissions.mdx"
] | [
{
"comment": "Unused imports: this page only uses `Aside`, but also imports `Tabs` and `TabItem`. Removing unused imports avoids build/lint warnings and keeps the MDX clean.",
"path": "docs/src/content/docs/features/windows/permissions.mdx",
"hunk": "@@ -0,0 +1,207 @@\n+---\n+title: Web Permissions\n+de... | true | ||
wailsapp/wails | 5,592 | comment_to_fix | docs: add Web Permissions guide and options reference (missing from #5567) | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Line 24 overgeneralizes prompt behavior across platforms.**
This sentence reads as universally true, but on macOS the `Permissions` map currently has no effect and TCC prompting still applies. Narrowing the statement to Linux/Windows (or adding a macOS caveat) avoid... | f085aa9d005120805d5571fef3ab40ddaf9ab989 | 488c361abfc91f26350ab407c08db5e8716473f4 | diff --git a/docs/src/content/docs/features/windows/permissions.mdx b/docs/src/content/docs/features/windows/permissions.mdx
new file mode 100644
index 00000000000..75ca152d65c
--- /dev/null
+++ b/docs/src/content/docs/features/windows/permissions.mdx
@@ -0,0 +1,210 @@
+---
+title: Permissions
+description: Control cam... | [
"docs/src/content/docs/features/windows/permissions.mdx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Line 24 overgeneralizes prompt behavior across platforms.**\n\nThis sentence reads as universally true, but on macOS the `Permissions` map currently has no effect and TCC prompting still applies. Narrowing the statement to Linux/Windows (or ad... | true | ||
wailsapp/wails | 5,567 | issue_to_patch | [v3][Linux][GTK3] getUserMedia is denied by default because WebKitGTK permission-request is not handled
### Description
On Linux with Wails v3 GTK3, frontend calls to `navigator.mediaDevices.getUserMedia()` for camera or microphone are denied by WebKitGTK by default.
The frontend receives:
```text
NotAllowedError: ... | fix(v3): handle getUserMedia via a cross-platform Permissions map (Linux + Windows) | # Description
On Linux, `navigator.mediaDevices.getUserMedia()` always rejected with `NotAllowedError`: WebKitGTK denies any permission request with no handler attached, and Wails never attached one (#5552).
Rather than hardcode a blanket grant, this adds a **declarative, cross-platform permission policy** and wires ... | 51aaf5b357a29a3950ae21492bddab8899b2e5de | 4fa5602d19f48f053ef5280253183c7ffce5adcd | diff --git a/v3/UNRELEASED_CHANGELOG.md b/v3/UNRELEASED_CHANGELOG.md
index 98a401161aa..c75eb5e92a8 100644
--- a/v3/UNRELEASED_CHANGELOG.md
+++ b/v3/UNRELEASED_CHANGELOG.md
@@ -51,6 +51,7 @@ After processing, the content will be moved to the main changelog and this file
## Fixed
<!-- Bug fixes -->
+- Fix `getUserMe... | [
"v3/UNRELEASED_CHANGELOG.md",
"v3/pkg/application/linux_cgo.c",
"v3/pkg/application/linux_cgo.go",
"v3/pkg/application/linux_cgo.h",
"v3/pkg/application/linux_cgo_gtk3.go",
"v3/pkg/application/permissions_linux.go",
"v3/pkg/application/webview_window_options.go",
"v3/pkg/application/webview_window_win... | [
{
"comment": "`handlePermissionRequest` currently unconditionally grants camera/microphone access for any page loaded in the WebView. Since `WebviewWindowOptions.URL` supports navigating to arbitrary remote origins, this effectively auto-grants user media to remote/untrusted content as well. A safer default is ... | true | |
wailsapp/wails | 5,567 | comment_to_fix | fix(v3): handle getUserMedia via a cross-platform Permissions map (Linux + Windows) | `handlePermissionRequest` currently unconditionally grants camera/microphone access for any page loaded in the WebView. Since `WebviewWindowOptions.URL` supports navigating to arbitrary remote origins, this effectively auto-grants user media to remote/untrusted content as well. A safer default is to only auto-allow whe... | 51aaf5b357a29a3950ae21492bddab8899b2e5de | 4fa5602d19f48f053ef5280253183c7ffce5adcd | diff --git a/v3/pkg/application/linux_cgo.go b/v3/pkg/application/linux_cgo.go
index 8e8e3ba9424..557282b674e 100644
--- a/v3/pkg/application/linux_cgo.go
+++ b/v3/pkg/application/linux_cgo.go
@@ -1459,6 +1459,7 @@ func (w *linuxWebviewWindow) setupSignalHandlers(emit func(e events.WindowEventT
wv := unsafe.Pointer... | [
"v3/pkg/application/linux_cgo.go"
] | [
{
"comment": "`handlePermissionRequest` currently unconditionally grants camera/microphone access for any page loaded in the WebView. Since `WebviewWindowOptions.URL` supports navigating to arbitrary remote origins, this effectively auto-grants user media to remote/untrusted content as well. A safer default is ... | true | ||
wailsapp/wails | 5,567 | comment_to_fix | fix(v3): handle getUserMedia via a cross-platform Permissions map (Linux + Windows) | This handler auto-allows camera/microphone for any origin loaded in the WebView. Because windows can navigate to arbitrary URLs (`WebviewWindowOptions.URL`), this means remote/untrusted content would also receive user-media access without any prompt. Consider restricting the default auto-allow to the internal `wails://... | 51aaf5b357a29a3950ae21492bddab8899b2e5de | 4fa5602d19f48f053ef5280253183c7ffce5adcd | diff --git a/v3/pkg/application/linux_cgo_gtk3.go b/v3/pkg/application/linux_cgo_gtk3.go
index b56563a38b8..cce332434f4 100644
--- a/v3/pkg/application/linux_cgo_gtk3.go
+++ b/v3/pkg/application/linux_cgo_gtk3.go
@@ -81,6 +81,7 @@ extern gboolean handleConfigureEvent(GtkWidget*, GdkEventConfigure*, uintptr_t);
extern ... | [
"v3/pkg/application/linux_cgo_gtk3.go"
] | [
{
"comment": "This handler auto-allows camera/microphone for any origin loaded in the WebView. Because windows can navigate to arbitrary URLs (`WebviewWindowOptions.URL`), this means remote/untrusted content would also receive user-media access without any prompt. Consider restricting the default auto-allow to ... | true | ||
wailsapp/wails | 5,567 | comment_to_fix | fix(v3): handle getUserMedia via a cross-platform Permissions map (Linux + Windows) | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`In Microsoft WebView2, if a host sets a global permission state to Allow, do permission kinds without explicit per-kind overrides bypass the normal prompt/default handling? Also, when a per-kind permission is set to De... | 51aaf5b357a29a3950ae21492bddab8899b2e5de | 4fa5602d19f48f053ef5280253183c7ffce5adcd | diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go
index 79040ce6131..6cbf7bd67b7 100644
--- a/v3/pkg/application/webview_window_windows.go
+++ b/v3/pkg/application/webview_window_windows.go
@@ -13,17 +13,17 @@ import (
"time"
"unsafe"
- "github.com/wailsapp/w... | [
"v3/pkg/application/webview_window_windows.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In Microsoft WebView2, if a host sets a global permission state to Allow, do permission kinds without explicit per-kind overrides bypass the normal prompt/default handling? Also, when a per... | true | ||
wailsapp/wails | 5,591 | issue_to_patch | feat: add go workspace for cross-module development | ## Summary
Adds `go.work` (committed to the repo) so contributors and CI can work across `v3` and `webview2` modules simultaneously without needing to publish a new `webview2` release first.
**Problem:** Any PR that modifies both `webview2/` and `v3/` (e.g. #5462) failed CI because `v3/go.mod` pinned a published `web... | 51f951bfa745f43cac0765777cc6d30285af4ce3 | 70ea81105fde7e2c6c4d59d360fb2ff69e849205 | diff --git a/.github/workflows/build-and-test-v3.yml b/.github/workflows/build-and-test-v3.yml
index a1d57ffd4df..1a0c617d724 100644
--- a/.github/workflows/build-and-test-v3.yml
+++ b/.github/workflows/build-and-test-v3.yml
@@ -7,6 +7,9 @@ on:
- master
paths:
- 'v3/**'
+ - 'webview2/**'
+ ... | [
".github/workflows/build-and-test-v3.yml",
".github/workflows/cross-compile-test-v3.yml",
".gitignore",
"go.work",
"go.work.sum",
"v3/go.mod",
"webview2/go.mod",
"webview2/go.sum"
] | [] | true | ||
wailsapp/wails | 5,590 | issue_to_patch | Link from v3 status page to changelog is broken
### Have you read the Documentation Contribution Guidelines?
- [x] I have read the [Documentation Contribution Guidelines](https://wails.io/community-guide#ways-of-contributing).
### Description
The link on https://v3.wails.io/status/ that goes to the v3 Changelog pag... | docs: fix incorrect changelog link on status page | # Description
Fixes the incorrect relative link `./changelog` on the v3 status/roadmap page (and its translated versions) which was incorrectly resolving to a 404 at `https://v3.wails.io/status/changelog` instead of pointing to the site-wide `https://v3.wails.io/changelog/` page. Changed the link from `./changelog` ... | 0236ec1dc35e31c51fc50d734210fd3adb022af0 | 331dfdc5a8f0547a116ac4130f57708c4c1d72fd | diff --git a/docs/src/content/docs/de/status.mdx b/docs/src/content/docs/de/status.mdx
index 8ba38d4151b..a3ad73ead78 100644
--- a/docs/src/content/docs/de/status.mdx
+++ b/docs/src/content/docs/de/status.mdx
@@ -5,7 +5,7 @@ description: Status des Wails v3-Projekts, geplante Funktionen und wie Sie beitr
## Aktuelle... | [
"docs/src/content/docs/de/status.mdx",
"docs/src/content/docs/fr/status.mdx",
"docs/src/content/docs/ja/status.mdx",
"docs/src/content/docs/ko/status.mdx",
"docs/src/content/docs/pt/status.mdx",
"docs/src/content/docs/ru/status.mdx",
"docs/src/content/docs/status.mdx",
"docs/src/content/docs/zh-cn/sta... | [] | true | |
wailsapp/wails | 5,497 | issue_to_patch | fix(fossa): exclude v3/examples npm targets from license scan | ## Summary
- Updates `.fossa.yml` to exclude all npm targets under `v3/examples/` from FOSSA license scanning
- Follows the same pattern as the existing `website/` exclusion
- Example app frontends are dev/demo tooling, not distributed artifacts
## Context
PR #5333 (`feat(v3:notifications): add sounds, attachments, ... | 6758ef309ae600b5e6c96fb141a1a12b80d8db1d | b16f7340f50afa98b861e7586c0e88a014226956 | diff --git a/.fossa.yml b/.fossa.yml
index 5e478a600bb..06f7656d03f 100644
--- a/.fossa.yml
+++ b/.fossa.yml
@@ -7,6 +7,10 @@ version: 3
# site locally; it is not distributed with the Wails Go module or the
# @wailsio/runtime npm package, so it is out of scope for the license
# compliance posture we want FOSSA to en... | [
".fossa.yml"
] | [] | true | ||
wailsapp/wails | 5,588 | issue_to_patch | example(mobile): default divide example divisor to 2 | Small tweak to the mobile kitchen-sink example: the Divide row's second input defaulted to `0`, so the example showed a divide-by-zero error on first tap. Default it to `2` so `10 ÷ 2 = 5` works out of the box.
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Bu... | 9d5ebed64e04d8d289a74c070d341024904596dd | 6758ef309ae600b5e6c96fb141a1a12b80d8db1d | diff --git a/v3/examples/mobile/frontend/index.html b/v3/examples/mobile/frontend/index.html
index a415dd5a91f..37bb41157e0 100644
--- a/v3/examples/mobile/frontend/index.html
+++ b/v3/examples/mobile/frontend/index.html
@@ -46,7 +46,7 @@ <h2>Service bindings</h2>
<div class="row">
<input ... | [
"v3/examples/mobile/frontend/index.html"
] | [] | true | ||
wailsapp/wails | 5,587 | issue_to_patch | chore: remove committed build artifacts (.task cache, Gradle problems-report) | Removes build artifacts that were committed by accident and gitignores them so they can't return.
### Removed (16 files)
- `examples/android/.task/checksum/*` (5) — Taskfile checksum cache
- `examples/android/build/android/build/reports/problems/problems-report.html` — Gradle build report
- `test/manual/systray/.task/... | b553ca49efc1bc47d3b301a48ad4d541caf511a3 | e1533cd80c1d41f413cec7142c4e8c70af20fe5b | diff --git a/v3/.gitignore b/v3/.gitignore
index 953237fcd9e..d85e57126de 100644
--- a/v3/.gitignore
+++ b/v3/.gitignore
@@ -7,6 +7,10 @@ cmd/wails3/wails
/examples/clipboard/clipboard
/examples/plain/plain
/cmd/wails3/ui/.task/
+# Taskfile checksum cache (any location)
+.task/
+# Gradle build problems report
+probl... | [
"v3/.gitignore",
"v3/examples/android/.task/checksum/android-common-generate-icons",
"v3/examples/android/.task/checksum/android-common-install-frontend-deps",
"v3/examples/android/.task/checksum/android-generate-android-bindings",
"v3/examples/android/.task/checksum/build-frontend--PRODUCTION--",
"v3/exa... | [] | diff --git a/v3/test/manual/systray/.task/checksum/build-custom-handlers-gtk3 b/v3/test/manual/systray/.task/checksum/build-custom-handlers-gtk3
deleted file mode 100644
index ac32ec4ce5b..00000000000
--- a/v3/test/manual/systray/.task/checksum/build-custom-handlers-gtk3
+++ /dev/null
@@ -1,1 +0,0 @@
-56e330435e9c16184... | true | |
wailsapp/wails | 5,565 | issue_to_patch | macOS: fatal error: invalid pointer found on stack in cScreenToScreen on display change (UTF8String use-after-free)
### Description
On macOS, `processScreen` (in `pkg/application/screen_darwin.go`) stores the result of `-[NSString UTF8String]` directly into the C `Screen` struct's `id` and `name` fields:
```objc
// ... | fix(v3/darwin): copy screen id/name out of autoreleased UTF8String buffers | # Description
`processScreen` stored the raw result of `-[NSString UTF8String]` in the C `Screen` struct's `id` and `name` fields. `UTF8String` returns a pointer into an **autoreleased** buffer whose lifetime ends when the enclosing autorelease pool drains — which can happen before Go reads the strings with `C.GoStrin... | 960065c819d9816ea9c26c5cc02687193b1069b1 | bf467f409eadd1cfa79d9f937bc614390fbf880f | diff --git a/v3/UNRELEASED_CHANGELOG.md b/v3/UNRELEASED_CHANGELOG.md
index 210372a1762..14622cb23a5 100644
--- a/v3/UNRELEASED_CHANGELOG.md
+++ b/v3/UNRELEASED_CHANGELOG.md
@@ -23,6 +23,7 @@ After processing, the content will be moved to the main changelog and this file
## Fixed
<!-- Bug fixes -->
+- Fix intermitte... | [
"v3/UNRELEASED_CHANGELOG.md",
"v3/pkg/application/screen_darwin.go",
"v3/pkg/application/screen_darwin_test.go"
] | [
{
"comment": "`getAllScreens` returns a malloc'd array sized from `screens.count`, but the Go side currently re-queries the count via `GetNumScreens()` in a separate call. If the display configuration changes between the two calls, Go can index past the allocated array and then `cScreenToScreen` will `free()` g... | diff --git a/v3/pkg/application/screen_darwin_test.go b/v3/pkg/application/screen_darwin_test.go
new file mode 100644
index 00000000000..8659b1cd80f
--- /dev/null
+++ b/v3/pkg/application/screen_darwin_test.go
@@ -0,0 +1,34 @@
+//go:build darwin && !ios && !server
+
+package application
+
+import (
+ "strconv"
+ "testi... | true |
wailsapp/wails | 5,565 | comment_to_fix | fix(v3/darwin): copy screen id/name out of autoreleased UTF8String buffers | `allScreens` calls `C.getAllScreens()` and then separately calls `C.GetNumScreens()` to size/slice the returned buffer. If the screen count changes between these calls, this can walk off the end of the allocated array and free invalid pointers in `cScreenToScreen`. After changing `getAllScreens` to return the count (e.... | 960065c819d9816ea9c26c5cc02687193b1069b1 | bf467f409eadd1cfa79d9f937bc614390fbf880f | diff --git a/v3/pkg/application/screen_darwin.go b/v3/pkg/application/screen_darwin.go
index 59e9e33f722..e1c36ddba21 100644
--- a/v3/pkg/application/screen_darwin.go
+++ b/v3/pkg/application/screen_darwin.go
@@ -10,6 +10,7 @@ package application
#import <Cocoa/Cocoa.h>
#import <AppKit/AppKit.h>
#include <stdlib.h>
... | [
"v3/pkg/application/screen_darwin.go"
] | [
{
"comment": "`allScreens` calls `C.getAllScreens()` and then separately calls `C.GetNumScreens()` to size/slice the returned buffer. If the screen count changes between these calls, this can walk off the end of the allocated array and free invalid pointers in `cScreenToScreen`. After changing `getAllScreens` t... | true | ||
wailsapp/wails | 5,565 | comment_to_fix | fix(v3/darwin): copy screen id/name out of autoreleased UTF8String buffers | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**Return the count from the same enumeration snapshot.**
Lines 224-228 size the Go slice with a fresh `C.GetNumScreens()` call even though `getAllScreens()` already allocated and filled `cScreens` from an earlier `NSScreen screens` snapshot. If the display count ch... | 960065c819d9816ea9c26c5cc02687193b1069b1 | bf467f409eadd1cfa79d9f937bc614390fbf880f | diff --git a/v3/pkg/application/screen_darwin.go b/v3/pkg/application/screen_darwin.go
index 59e9e33f722..e1c36ddba21 100644
--- a/v3/pkg/application/screen_darwin.go
+++ b/v3/pkg/application/screen_darwin.go
@@ -10,6 +10,7 @@ package application
#import <Cocoa/Cocoa.h>
#import <AppKit/AppKit.h>
#include <stdlib.h>
... | [
"v3/pkg/application/screen_darwin.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**Return the count from the same enumeration snapshot.**\n\nLines 224-228 size the Go slice with a fresh `C.GetNumScreens()` call even though `getAllScreens()` already allocated and filled `cScreens` from an earlier `NSScreen screens` snapsho... | true | ||
wailsapp/wails | 5,568 | issue_to_patch | [v3] (*Chromium).Focus race on production startup — #4835 fix has TOCTOU window
### Description
Hitting the same crash signature as #4835 in **alpha.90 production build** (not dev mode). The fix from #4835 (commit 464659b — \`GetController() != nil\` guards in \`webview_window_windows.go\`) is present in our build, b... | fix(webview2): guard Focus() until controller initialisation completes | # Description
Fixes the production startup crash from #5446 (successor to the partial #4835 fix).
`CreateCoreWebView2ControllerCompleted` assigns `e.controller` partway through the callback (chromium.go:338) but only flips the `inited` atomic after **all** COM setup succeeds (line 389). The Windows message pump runs ... | e094d72866eac4a436968424078e0ec41e8c9c10 | eb29a53d5688654838b39e2a1ca613c0e7dc413c | diff --git a/webview2/pkg/edge/chromium.go b/webview2/pkg/edge/chromium.go
index 2d6a9ceb10b..415f5f8d52d 100644
--- a/webview2/pkg/edge/chromium.go
+++ b/webview2/pkg/edge/chromium.go
@@ -281,7 +281,13 @@ func (e *Chromium) Eval(script string) {
err := e.webview.ExecuteScript(script, nil)
if err != nil && !error... | [
"webview2/pkg/edge/chromium.go",
"webview2/pkg/edge/chromium_focus_test.go"
] | [] | diff --git a/webview2/pkg/edge/chromium_focus_test.go b/webview2/pkg/edge/chromium_focus_test.go
new file mode 100644
index 00000000000..b8dd1022193
--- /dev/null
+++ b/webview2/pkg/edge/chromium_focus_test.go
@@ -0,0 +1,52 @@
+//go:build windows
+// +build windows
+
+package edge
+
+import (
+ "sync"
+ "testing"
+)
+
... | true |
wailsapp/wails | 5,566 | issue_to_patch | [v3][Linux][GTK3] Intermittent SIGSEGV in assetserver when closing WebKitURISchemeRequest (`g_object_unref`)
### Description
We are seeing an intermittent native crash in a long-running Wails v3 Linux GTK3 application. The app exits with code 2 and is restarted by a watchdog. This is not a Go panic; it is a SIGSEGV d... | fix(v3/linux): release WebKitURISchemeRequest on the GTK main context | # Description
`request.Close()` runs on the assetserver goroutine (`AssetServer.processWebViewRequest` → `webViewAssetRequest.Close`) and dropped what may be the **last reference** to the `WebKitURISchemeRequest` there. Finalizing a WebKit GObject off the GTK main thread violates WebKitGTK's threading rules and interm... | c87d74e730985c4d1396c65314e991ba07fa6cbf | 639645fe9dd55827f8ed3a520e30819bdc26734f | diff --git a/v3/UNRELEASED_CHANGELOG.md b/v3/UNRELEASED_CHANGELOG.md
index 2ebe4eb0b50..210372a1762 100644
--- a/v3/UNRELEASED_CHANGELOG.md
+++ b/v3/UNRELEASED_CHANGELOG.md
@@ -23,6 +23,7 @@ After processing, the content will be moved to the main changelog and this file
## Fixed
<!-- Bug fixes -->
+- Fix intermitte... | [
"v3/UNRELEASED_CHANGELOG.md",
"v3/internal/assetserver/webview/request_linux.go",
"v3/internal/assetserver/webview/request_linux_gtk3.go"
] | [
{
"comment": "`unref_request_on_main` and `releaseRequestOnMainThread` unconditionally call `g_object_unref` / schedule work even if the request pointer is NULL. GLib treats `g_object_unref(NULL)` as invalid and can emit critical warnings (and in some builds abort). Adding NULL guards makes this safer and effec... | true | |
wailsapp/wails | 5,566 | comment_to_fix | fix(v3/linux): release WebKitURISchemeRequest on the GTK main context | `unref_request_on_main` and `releaseRequestOnMainThread` unconditionally call `g_object_unref` / schedule work even if the request pointer is NULL. GLib treats `g_object_unref(NULL)` as invalid and can emit critical warnings (and in some builds abort). Adding NULL guards makes this safer and effectively free. | c87d74e730985c4d1396c65314e991ba07fa6cbf | 639645fe9dd55827f8ed3a520e30819bdc26734f | diff --git a/v3/internal/assetserver/webview/request_linux.go b/v3/internal/assetserver/webview/request_linux.go
index 22082600808..fb3399e4a6b 100644
--- a/v3/internal/assetserver/webview/request_linux.go
+++ b/v3/internal/assetserver/webview/request_linux.go
@@ -7,6 +7,24 @@ package webview
#include <gtk/gtk.h>
#... | [
"v3/internal/assetserver/webview/request_linux.go"
] | [
{
"comment": "`unref_request_on_main` and `releaseRequestOnMainThread` unconditionally call `g_object_unref` / schedule work even if the request pointer is NULL. GLib treats `g_object_unref(NULL)` as invalid and can emit critical warnings (and in some builds abort). Adding NULL guards makes this safer and effec... | true | ||
wailsapp/wails | 5,566 | comment_to_fix | fix(v3/linux): release WebKitURISchemeRequest on the GTK main context | `unref_request_on_main` and `releaseRequestOnMainThread` should defensively handle a NULL `WebKitURISchemeRequest*`/user_data to avoid GLib critical warnings (or aborts in stricter builds) from `g_object_unref(NULL)`. The check is cheap and makes the helper robust. | c87d74e730985c4d1396c65314e991ba07fa6cbf | 639645fe9dd55827f8ed3a520e30819bdc26734f | diff --git a/v3/internal/assetserver/webview/request_linux_gtk3.go b/v3/internal/assetserver/webview/request_linux_gtk3.go
index 6ddd21ae80a..0a3329cdf79 100644
--- a/v3/internal/assetserver/webview/request_linux_gtk3.go
+++ b/v3/internal/assetserver/webview/request_linux_gtk3.go
@@ -7,6 +7,24 @@ package webview
#in... | [
"v3/internal/assetserver/webview/request_linux_gtk3.go"
] | [
{
"comment": "`unref_request_on_main` and `releaseRequestOnMainThread` should defensively handle a NULL `WebKitURISchemeRequest*`/user_data to avoid GLib critical warnings (or aborts in stricter builds) from `g_object_unref(NULL)`. The check is cheap and makes the helper robust.",
"path": "v3/internal/asset... | true | ||
wailsapp/wails | 5,583 | issue_to_patch | fix(ci): validate release token before pushing, fall back to github.token | ## Problem
The 2026-06-10 nightly release ([run 27289812021](https://github.com/wailsapp/wails/actions/runs/27289812021)) half-failed:
1. The bump commit (`43309ddc9`) and the `v3.0.0-alpha.99` tag were **pushed successfully** — git auth rode on the checkout step's persisted credentials.
2. The GitHub release API cal... | 2633f8124ea742b43f1da82ec166179828c57e38 | 2c4edd606faac31e6c73d64322e6a2833ee47cfc | diff --git a/.github/workflows/nightly-release-v3.yml b/.github/workflows/nightly-release-v3.yml
index b084e49125b..8ae4b885db6 100644
--- a/.github/workflows/nightly-release-v3.yml
+++ b/.github/workflows/nightly-release-v3.yml
@@ -171,8 +171,13 @@ jobs:
steps.quick_check.outputs.should_continue == 'true' || ... | [
".github/workflows/nightly-release-v3.yml",
"v3/tasks/release/release.go"
] | [
{
"comment": "`selectAPIToken()` is invoked only after `applyChangelogUpdates()` has modified files and after the bump commit has been created. If token validation fails here, the run exits leaving the working tree/commit changed (even though nothing is pushed). Consider moving repo slug resolution + token sele... | true | ||
wailsapp/wails | 5,583 | comment_to_fix | fix(ci): validate release token before pushing, fall back to github.token | `selectAPIToken()` is invoked only after `applyChangelogUpdates()` has modified files and after the bump commit has been created. If token validation fails here, the run exits leaving the working tree/commit changed (even though nothing is pushed). Consider moving repo slug resolution + token selection/validation earli... | 2633f8124ea742b43f1da82ec166179828c57e38 | 2c4edd606faac31e6c73d64322e6a2833ee47cfc | diff --git a/v3/tasks/release/release.go b/v3/tasks/release/release.go
index d0086643ae7..28e34c2246a 100644
--- a/v3/tasks/release/release.go
+++ b/v3/tasks/release/release.go
@@ -502,6 +502,23 @@ func runRelease(opts releaseOptions) error {
return nil
}
+ // Resolve the repository and validate the token BEFORE... | [
"v3/tasks/release/release.go"
] | [
{
"comment": "`selectAPIToken()` is invoked only after `applyChangelogUpdates()` has modified files and after the bump commit has been created. If token validation fails here, the run exits leaving the working tree/commit changed (even though nothing is pushed). Consider moving repo slug resolution + token sele... | true | ||
wailsapp/wails | 5,560 | issue_to_patch | fix(updater/windows): fallback for cross-volume rename failures | On Windows, updater fails when replacing executables across different drives. When the helper attempts os.Rename, the system returns ERROR_NOT_SAME_DEVICE, causing repeated retries and eventual failure.
This patch introduces a renameOrCopy fallback:
- First try os.Rename as usual.
- If it fails with cross-volume e... | 43309ddc99e521c06946a3afe92afc65265efdc2 | 0ac4013f8048448925cd93e7e8e62a373979dec2 | diff --git a/v3/pkg/updater/helper_windows.go b/v3/pkg/updater/helper_windows.go
index a1027f1ae88..01ce1f6e963 100644
--- a/v3/pkg/updater/helper_windows.go
+++ b/v3/pkg/updater/helper_windows.go
@@ -3,7 +3,9 @@
package updater
import (
+ "errors"
"fmt"
+ "io"
"os"
"path/filepath"
"syscall"
@@ -20,6 +22,11... | [
"v3/pkg/updater/helper_windows.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check how os.Rename surfaces cross-volume errors on Windows.\n\n# Search for error handling patterns around os.Rename in the Go standard library or e... | true | ||
wailsapp/wails | 5,560 | comment_to_fix | fix(updater/windows): fallback for cross-volume rename failures | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Description: Check how os.Rename surfaces cross-volume errors on Windows.
# Search for error handling patterns around os.Rename in the Go standard library or existing Windows-specific code.
rg... | 43309ddc99e521c06946a3afe92afc65265efdc2 | 0ac4013f8048448925cd93e7e8e62a373979dec2 | diff --git a/v3/pkg/updater/helper_windows.go b/v3/pkg/updater/helper_windows.go
index a1027f1ae88..01ce1f6e963 100644
--- a/v3/pkg/updater/helper_windows.go
+++ b/v3/pkg/updater/helper_windows.go
@@ -3,7 +3,9 @@
package updater
import (
+ "errors"
"fmt"
+ "io"
"os"
"path/filepath"
"syscall"
@@ -20,6 +22,11... | [
"v3/pkg/updater/helper_windows.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check how os.Rename surfaces cross-volume errors on Windows.\n\n# Search for error handling patterns around os.Rename in the Go standard library or e... | true | ||
wailsapp/wails | 5,368 | issue_to_patch | fix(linux): enable JS resize for frameless windows; fix scrollbar edge detection (#4415, #4680) | ## Summary
- **Frameless windows on Linux could not be resized at all** (JS resize-edge logic was gated behind `!IsWindows()`)
- **Scrollbar at window edge blocked resize on all platforms** (the 5 px resize zone overlapped with the native scrollbar strip, whose `mousedown` is never seen by JavaScript)
## Root cause
... | aceac48555da937ef5492075890da885e88eb67e | 7e8aa570c09783697f4eaf3ebe229a6b120d80a0 | diff --git a/v3/internal/assetserver/bundledassets/runtime.debug.js b/v3/internal/assetserver/bundledassets/runtime.debug.js
index 5a82686635b..a4db18f98d0 100644
--- a/v3/internal/assetserver/bundledassets/runtime.debug.js
+++ b/v3/internal/assetserver/bundledassets/runtime.debug.js
@@ -1801,7 +1801,7 @@ function onMo... | [
"v3/internal/assetserver/bundledassets/runtime.debug.js",
"v3/internal/assetserver/bundledassets/runtime.js",
"v3/internal/runtime/desktop/@wailsio/runtime/src/drag.ts",
"v3/pkg/application/linux_cgo.go",
"v3/pkg/application/linux_cgo_gtk3.go",
"v3/pkg/application/webview_window_linux.go"
] | [
{
"comment": "`setResizable()` now unconditionally executes JS calling `window._wails.setResizable(...)`. During early window setup (before `/wails/runtime.js` has run) or after the window is destroyed, this can throw JS errors or evaluate against an invalid webview. Consider guarding the JS call (eg check for ... | true | ||
wailsapp/wails | 5,368 | comment_to_fix | fix(linux): enable JS resize for frameless windows; fix scrollbar edge detection (#4415, #4680) | `setResizable()` now unconditionally executes JS calling `window._wails.setResizable(...)`. During early window setup (before `/wails/runtime.js` has run) or after the window is destroyed, this can throw JS errors or evaluate against an invalid webview. Consider guarding the JS call (eg check for `window._wails?.setRes... | aceac48555da937ef5492075890da885e88eb67e | 7e8aa570c09783697f4eaf3ebe229a6b120d80a0 | diff --git a/v3/pkg/application/linux_cgo.go b/v3/pkg/application/linux_cgo.go
index d58c6a318aa..8e8e3ba9424 100644
--- a/v3/pkg/application/linux_cgo.go
+++ b/v3/pkg/application/linux_cgo.go
@@ -1260,6 +1260,7 @@ func windowSetGeometryHints(window pointer, minWidth, minHeight, maxWidth, maxHe
func (w *linuxWebview... | [
"v3/pkg/application/linux_cgo.go"
] | [
{
"comment": "`setResizable()` now unconditionally executes JS calling `window._wails.setResizable(...)`. During early window setup (before `/wails/runtime.js` has run) or after the window is destroyed, this can throw JS errors or evaluate against an invalid webview. Consider guarding the JS call (eg check for ... | true | ||
wailsapp/wails | 5,368 | comment_to_fix | fix(linux): enable JS resize for frameless windows; fix scrollbar edge detection (#4415, #4680) | `setFrameless()` now executes JS to set `window._wails.flags.frameless` without checking whether the JS runtime is loaded. If this runs before `/wails/runtime.js` has initialised `window._wails.flags` (or after destroy), it will throw and may spam the console. Please guard the JS assignment (eg `if(window._wails&&windo... | aceac48555da937ef5492075890da885e88eb67e | 7e8aa570c09783697f4eaf3ebe229a6b120d80a0 | diff --git a/v3/pkg/application/linux_cgo.go b/v3/pkg/application/linux_cgo.go
index d58c6a318aa..8e8e3ba9424 100644
--- a/v3/pkg/application/linux_cgo.go
+++ b/v3/pkg/application/linux_cgo.go
@@ -1260,6 +1260,7 @@ func windowSetGeometryHints(window pointer, minWidth, minHeight, maxWidth, maxHe
func (w *linuxWebview... | [
"v3/pkg/application/linux_cgo.go"
] | [
{
"comment": "`setFrameless()` now executes JS to set `window._wails.flags.frameless` without checking whether the JS runtime is loaded. If this runs before `/wails/runtime.js` has initialised `window._wails.flags` (or after destroy), it will throw and may spam the console. Please guard the JS assignment (eg `i... | true | ||
wailsapp/wails | 5,368 | comment_to_fix | fix(linux): enable JS resize for frameless windows; fix scrollbar edge detection (#4415, #4680) | The injected JS calls `window._wails.setResizable(...)` as part of the WindowLoadFinished hook. If a user page does not load `/wails/runtime.js` (or it fails to load), `window._wails.setResizable` will be undefined and this injection will throw. Consider guarding the call (eg `if(window._wails?.setResizable){...}`) to ... | aceac48555da937ef5492075890da885e88eb67e | 7e8aa570c09783697f4eaf3ebe229a6b120d80a0 | diff --git a/v3/pkg/application/webview_window_linux.go b/v3/pkg/application/webview_window_linux.go
index 0670bf99ef6..09903796b3d 100644
--- a/v3/pkg/application/webview_window_linux.go
+++ b/v3/pkg/application/webview_window_linux.go
@@ -384,6 +384,8 @@ func (w *linuxWebviewWindow) run() {
// Inject runtime core ... | [
"v3/pkg/application/webview_window_linux.go"
] | [
{
"comment": "The injected JS calls `window._wails.setResizable(...)` as part of the WindowLoadFinished hook. If a user page does not load `/wails/runtime.js` (or it fails to load), `window._wails.setResizable` will be undefined and this injection will throw. Consider guarding the call (eg `if(window._wails?.se... | true | ||
wailsapp/wails | 5,561 | issue_to_patch | [V3, Windows] generate bindings fails with "Access is denied" on Windows when Vite dev server is running (v3.0.0-alpha.96)
**Environment:**
- OS: Windows 10
- Wails Version: v3.0.0-alpha.96 (Regression from alpha.95)
**Description:**
In `v3.0.0-alpha.96`, running `wails3 generate bindings` outputs a temporary folder ... | [v3, windows] Fix generate bindings failing with "Access is denied" when Vite dev server is running | ## Description
Fixes #5515 — a regression introduced in v3.0.0-alpha.96 by #5367.
The atomic directory swap from #5367 (`os.RemoveAll` + `os.Rename`) fails on Windows when a file watcher such as Vite's dev server is running: the watcher holds an open handle on the watched `bindings` directory (via `ReadDirectoryChang... | 7cc9bf031cb3ac3f499b790d0303ec480c6db209 | 3a30f007deae97ac4cdd10c590fcb0796974e837 | diff --git a/v3/UNRELEASED_CHANGELOG.md b/v3/UNRELEASED_CHANGELOG.md
index 2ebe4eb0b50..9b5a673e080 100644
--- a/v3/UNRELEASED_CHANGELOG.md
+++ b/v3/UNRELEASED_CHANGELOG.md
@@ -23,6 +23,7 @@ After processing, the content will be moved to the main changelog and this file
## Fixed
<!-- Bug fixes -->
+- Fix `wails3 ge... | [
"v3/UNRELEASED_CHANGELOG.md",
"v3/internal/commands/bindings.go",
"v3/internal/commands/bindings_sync.go",
"v3/internal/commands/bindings_sync_test.go"
] | [
{
"comment": "On Windows, os.Rename cannot overwrite an existing regular file. When dst exists and is a regular file with different content, this will return \"Access is denied\" and break updates in the common \"file changed\" case. Remove the existing dst first (and still handle non-regular dst) before renami... | diff --git a/v3/internal/commands/bindings_sync_test.go b/v3/internal/commands/bindings_sync_test.go
new file mode 100644
index 00000000000..7776040ce84
--- /dev/null
+++ b/v3/internal/commands/bindings_sync_test.go
@@ -0,0 +1,179 @@
+package commands
+
+import (
+ "os"
+ "path/filepath"
+ "testing"
+ "time"
+)
+
+func... | true |
wailsapp/wails | 5,561 | comment_to_fix | [v3, windows] Fix generate bindings failing with "Access is denied" when Vite dev server is running | On Windows, os.Rename cannot overwrite an existing regular file. When dst exists and is a regular file with different content, this will return "Access is denied" and break updates in the common "file changed" case. Remove the existing dst first (and still handle non-regular dst) before renaming. | 7cc9bf031cb3ac3f499b790d0303ec480c6db209 | 3a30f007deae97ac4cdd10c590fcb0796974e837 | diff --git a/v3/internal/commands/bindings_sync.go b/v3/internal/commands/bindings_sync.go
new file mode 100644
index 00000000000..8b041ab8676
--- /dev/null
+++ b/v3/internal/commands/bindings_sync.go
@@ -0,0 +1,163 @@
+package commands
+
+import (
+ "bytes"
+ "errors"
+ "io/fs"
+ "os"
+ "path/filepath"
+ "runtime"
+ "... | [
"v3/internal/commands/bindings_sync.go"
] | [
{
"comment": "On Windows, os.Rename cannot overwrite an existing regular file. When dst exists and is a regular file with different content, this will return \"Access is denied\" and break updates in the common \"file changed\" case. Remove the existing dst first (and still handle non-regular dst) before renami... | true | ||
wailsapp/wails | 5,561 | comment_to_fix | [v3, windows] Fix generate bindings failing with "Access is denied" when Vite dev server is running | If dst already exists as a file (not a directory), os.MkdirAll(dst, ...) will fail with "not a directory". Since syncDirs is meant to make dst match src, it should remove a non-directory dst and recreate it as a directory. Also, 0o777 is more permissive than the 0755/0o755 used elsewhere in v3/internal/commands (e.g. b... | 7cc9bf031cb3ac3f499b790d0303ec480c6db209 | 3a30f007deae97ac4cdd10c590fcb0796974e837 | diff --git a/v3/internal/commands/bindings_sync.go b/v3/internal/commands/bindings_sync.go
new file mode 100644
index 00000000000..8b041ab8676
--- /dev/null
+++ b/v3/internal/commands/bindings_sync.go
@@ -0,0 +1,163 @@
+package commands
+
+import (
+ "bytes"
+ "errors"
+ "io/fs"
+ "os"
+ "path/filepath"
+ "runtime"
+ "... | [
"v3/internal/commands/bindings_sync.go"
] | [
{
"comment": "If dst already exists as a file (not a directory), os.MkdirAll(dst, ...) will fail with \"not a directory\". Since syncDirs is meant to make dst match src, it should remove a non-directory dst and recreate it as a directory. Also, 0o777 is more permissive than the 0755/0o755 used elsewhere in v3/i... | true | ||
wailsapp/wails | 5,561 | comment_to_fix | [v3, windows] Fix generate bindings failing with "Access is denied" when Vite dev server is running | Directory creation uses 0o777 here; the rest of v3/internal/commands typically uses 0o755/0755. Using 0o755 also avoids creating world-writable directories when umask is permissive. | 7cc9bf031cb3ac3f499b790d0303ec480c6db209 | 3a30f007deae97ac4cdd10c590fcb0796974e837 | diff --git a/v3/internal/commands/bindings_sync.go b/v3/internal/commands/bindings_sync.go
new file mode 100644
index 00000000000..8b041ab8676
--- /dev/null
+++ b/v3/internal/commands/bindings_sync.go
@@ -0,0 +1,163 @@
+package commands
+
+import (
+ "bytes"
+ "errors"
+ "io/fs"
+ "os"
+ "path/filepath"
+ "runtime"
+ "... | [
"v3/internal/commands/bindings_sync.go"
] | [
{
"comment": "Directory creation uses 0o777 here; the rest of v3/internal/commands typically uses 0o755/0755. Using 0o755 also avoids creating world-writable directories when umask is permissive.",
"path": "v3/internal/commands/bindings_sync.go",
"hunk": "@@ -0,0 +1,144 @@\n+package commands\n+\n+import... | true | ||
wailsapp/wails | 5,561 | comment_to_fix | [v3, windows] Fix generate bindings failing with "Access is denied" when Vite dev server is running | Cleanup of the temp generation directory can also hit transient Windows locks (AV/indexers). Since the function already retries file operations on Windows, it's worth applying the same retry to the final src removal so successful installs don't fail just because temp cleanup was briefly blocked. | 7cc9bf031cb3ac3f499b790d0303ec480c6db209 | 3a30f007deae97ac4cdd10c590fcb0796974e837 | diff --git a/v3/internal/commands/bindings_sync.go b/v3/internal/commands/bindings_sync.go
new file mode 100644
index 00000000000..8b041ab8676
--- /dev/null
+++ b/v3/internal/commands/bindings_sync.go
@@ -0,0 +1,163 @@
+package commands
+
+import (
+ "bytes"
+ "errors"
+ "io/fs"
+ "os"
+ "path/filepath"
+ "runtime"
+ "... | [
"v3/internal/commands/bindings_sync.go"
] | [
{
"comment": "Cleanup of the temp generation directory can also hit transient Windows locks (AV/indexers). Since the function already retries file operations on Windows, it's worth applying the same retry to the final src removal so successful installs don't fail just because temp cleanup was briefly blocked.",... | true | ||
wailsapp/wails | 5,549 | issue_to_patch | feat(mac/v3): extend MacWebviewPreferences with additional WKWebView config options | ## Summary
Adds v3 parity for WKWebView configuration options, including the `EnableAutoplayWithoutUserAction` feature from #5512.
New fields in `MacWebviewPreferences`:
| Field | Maps to |
|---|---|
| `EnableAutoplayWithoutUserAction` | `config.mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeNone` ... | e4a3f368e1a21c73e1cb5a0690e21b007caa10b4 | 86ab3da331aade86bf778d1d63dd268f36cf9346 | diff --git a/docs/src/content/docs/features/windows/options.mdx b/docs/src/content/docs/features/windows/options.mdx
index 9f169d20129..b58b5f78ce4 100644
--- a/docs/src/content/docs/features/windows/options.mdx
+++ b/docs/src/content/docs/features/windows/options.mdx
@@ -849,6 +849,38 @@ Mac: application.MacWindow{
}... | [
"docs/src/content/docs/features/windows/options.mdx",
"v3/pkg/application/webview_window_darwin.go",
"v3/pkg/application/webview_window_options.go"
] | [
{
"comment": "`strlen()` scans the entire C string, but here you only need to know whether it’s non-empty. A cheaper (and dependency-free) check is to look at the first byte.",
"path": "v3/pkg/application/webview_window_darwin.go",
"hunk": "@@ -82,8 +87,24 @@ void* windowNew(unsigned int id, int width, ... | true | ||
wailsapp/wails | 5,549 | comment_to_fix | feat(mac/v3): extend MacWebviewPreferences with additional WKWebView config options | `strlen()` scans the entire C string, but here you only need to know whether it’s non-empty. A cheaper (and dependency-free) check is to look at the first byte. | e4a3f368e1a21c73e1cb5a0690e21b007caa10b4 | 86ab3da331aade86bf778d1d63dd268f36cf9346 | diff --git a/v3/pkg/application/webview_window_darwin.go b/v3/pkg/application/webview_window_darwin.go
index 5e874867624..725b1d36172 100644
--- a/v3/pkg/application/webview_window_darwin.go
+++ b/v3/pkg/application/webview_window_darwin.go
@@ -19,12 +19,17 @@ struct WebviewPreferences {
bool *TextInteractionEnabl... | [
"v3/pkg/application/webview_window_darwin.go"
] | [
{
"comment": "`strlen()` scans the entire C string, but here you only need to know whether it’s non-empty. A cheaper (and dependency-free) check is to look at the first byte.",
"path": "v3/pkg/application/webview_window_darwin.go",
"hunk": "@@ -82,8 +87,24 @@ void* windowNew(unsigned int id, int width, ... | true | ||
wailsapp/wails | 5,549 | comment_to_fix | feat(mac/v3): extend MacWebviewPreferences with additional WKWebView config options | `C.CString(...)` is allocated even when `ApplicationNameForUserAgent` is empty (the common/default case), which adds an unnecessary allocation + cgo call per window creation. You can pass `NULL` when unset/empty and only allocate/free when needed. | e4a3f368e1a21c73e1cb5a0690e21b007caa10b4 | 86ab3da331aade86bf778d1d63dd268f36cf9346 | diff --git a/v3/pkg/application/webview_window_darwin.go b/v3/pkg/application/webview_window_darwin.go
index 5e874867624..725b1d36172 100644
--- a/v3/pkg/application/webview_window_darwin.go
+++ b/v3/pkg/application/webview_window_darwin.go
@@ -19,12 +19,17 @@ struct WebviewPreferences {
bool *TextInteractionEnabl... | [
"v3/pkg/application/webview_window_darwin.go"
] | [
{
"comment": "`C.CString(...)` is allocated even when `ApplicationNameForUserAgent` is empty (the common/default case), which adds an unnecessary allocation + cgo call per window creation. You can pass `NULL` when unset/empty and only allocate/free when needed.",
"path": "v3/pkg/application/webview_window_d... | true | ||
wailsapp/wails | 5,535 | issue_to_patch | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | ## Summary
Adds **wake**, a Go-native build runner embedded in the wails3 CLI that
executes `Taskfile.yml` directly. Wake is **opt-in and experimental** —
the default `wails3 build / package / sign / task` path is unchanged
and continues to run on the embedded Task runtime exactly as before.
```bash
# default — Task ... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/cmd/wails3/main.go b/v3/cmd/wails3/main.go
index 533a8a4dd0a..53dee2965b3 100644
--- a/v3/cmd/wails3/main.go
+++ b/v3/cmd/wails3/main.go
@@ -13,6 +13,7 @@ import (
"github.com/wailsapp/wails/v3/internal/commands"
"github.com/wailsapp/wails/v3/internal/flags"
"github.com/wailsapp/wails/v3/internal/... | [
"v3/cmd/wails3/main.go",
"v3/go.mod",
"v3/internal/commands/bindings.go",
"v3/internal/commands/task.go",
"v3/internal/commands/task_wrapper.go",
"v3/internal/commands/wake_report.go",
"v3/internal/report/pulse/DESIGN.md",
"v3/internal/report/pulse/ansi/ansi.go",
"v3/internal/report/pulse/color.go",... | [
{
"comment": "GoTestCmd builds the -count value via `string(rune('0'+g.Opts.Count))`, which only works for 0–9 and yields incorrect values for multi-digit counts (and non-ASCII for larger values). This will cause `go test -count` to receive the wrong argument.",
"path": "v3/internal/wake/cmds/native.go",
... | diff --git a/v3/internal/report/pulse/style_test.go b/v3/internal/report/pulse/style_test.go
new file mode 100644
index 00000000000..1949b695d63
--- /dev/null
+++ b/v3/internal/report/pulse/style_test.go
@@ -0,0 +1,97 @@
+package pulse
+
+import (
+ "strings"
+ "testing"
+
+ "github.com/wailsapp/wails/v3/internal/repor... | true | |
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | GoTestCmd builds the -count value via `string(rune('0'+g.Opts.Count))`, which only works for 0–9 and yields incorrect values for multi-digit counts (and non-ASCII for larger values). This will cause `go test -count` to receive the wrong argument. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/cmds/native.go b/v3/internal/wake/cmds/native.go
new file mode 100644
index 00000000000..cc43a13166e
--- /dev/null
+++ b/v3/internal/wake/cmds/native.go
@@ -0,0 +1,296 @@
+package cmds
+
+import (
+ "os/exec"
+ "strconv"
+)
+
+type GoBuildOptions struct {
+ Output string
+ Tags []s... | [
"v3/internal/wake/cmds/native.go"
] | [
{
"comment": "GoTestCmd builds the -count value via `string(rune('0'+g.Opts.Count))`, which only works for 0–9 and yields incorrect values for multi-digit counts (and non-ASCII for larger values). This will cause `go test -count` to receive the wrong argument.",
"path": "v3/internal/wake/cmds/native.go",
... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | This file needs strconv imported for converting numeric flags (e.g. GoTestCmd's `-count`) to strings safely. Without it, the correct fix will require adding a new import later. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/cmds/native.go b/v3/internal/wake/cmds/native.go
new file mode 100644
index 00000000000..cc43a13166e
--- /dev/null
+++ b/v3/internal/wake/cmds/native.go
@@ -0,0 +1,296 @@
+package cmds
+
+import (
+ "os/exec"
+ "strconv"
+)
+
+type GoBuildOptions struct {
+ Output string
+ Tags []s... | [
"v3/internal/wake/cmds/native.go"
] | [
{
"comment": "This file needs strconv imported for converting numeric flags (e.g. GoTestCmd's `-count`) to strings safely. Without it, the correct fix will require adding a new import later.",
"path": "v3/internal/wake/cmds/native.go",
"hunk": "@@ -0,0 +1,288 @@\n+package cmds\n+\n+import (\n+\t\"os/exe... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | GoFmtCmd is currently invoking `go fmt` and conditionally adding `-w`. The `-w` flag is not supported by `go fmt` (it’s a gofmt flag), so this will fail when Write=true. If the intent is to format files, this should call `gofmt` directly. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/cmds/native.go b/v3/internal/wake/cmds/native.go
new file mode 100644
index 00000000000..cc43a13166e
--- /dev/null
+++ b/v3/internal/wake/cmds/native.go
@@ -0,0 +1,296 @@
+package cmds
+
+import (
+ "os/exec"
+ "strconv"
+)
+
+type GoBuildOptions struct {
+ Output string
+ Tags []s... | [
"v3/internal/wake/cmds/native.go"
] | [
{
"comment": "GoFmtCmd is currently invoking `go fmt` and conditionally adding `-w`. The `-w` flag is not supported by `go fmt` (it’s a gofmt flag), so this will fail when Write=true. If the intent is to format files, this should call `gofmt` directly.",
"path": "v3/internal/wake/cmds/native.go",
"hunk"... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | isUpToDate reads cache.lastRuns without taking cache.mu. Since wake runs deps in parallel by default, RecordRun can write concurrently and this read can race (and even panic on concurrent map access). | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/runner.go b/v3/internal/wake/exec/runner.go
new file mode 100644
index 00000000000..1b2da7ea455
--- /dev/null
+++ b/v3/internal/wake/exec/runner.go
@@ -0,0 +1,98 @@
+package exec
+
+import (
+ "fmt"
+ "os"
+ "sync"
+ "time"
+
+ "github.com/wailsapp/wails/v3/internal/wake/ast"
+ "githu... | [
"v3/internal/wake/exec/runner.go"
] | [
{
"comment": "isUpToDate reads cache.lastRuns without taking cache.mu. Since wake runs deps in parallel by default, RecordRun can write concurrently and this read can race (and even panic on concurrent map access).",
"path": "v3/internal/wake/exec/runner.go",
"hunk": "@@ -0,0 +1,93 @@\n+package exec\n+\... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | globExists uses filepath.Glob directly, so Task patterns with `**` won’t work (filepath.Glob doesn’t support recursive globs). Since exec/cache.go already implements globMatches/recursiveGlob for `**`, this helper should reuse that logic to keep caching behavior consistent. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/runner.go b/v3/internal/wake/exec/runner.go
new file mode 100644
index 00000000000..1b2da7ea455
--- /dev/null
+++ b/v3/internal/wake/exec/runner.go
@@ -0,0 +1,98 @@
+package exec
+
+import (
+ "fmt"
+ "os"
+ "sync"
+ "time"
+
+ "github.com/wailsapp/wails/v3/internal/wake/ast"
+ "githu... | [
"v3/internal/wake/exec/runner.go"
] | [
{
"comment": "globExists uses filepath.Glob directly, so Task patterns with `**` won’t work (filepath.Glob doesn’t support recursive globs). Since exec/cache.go already implements globMatches/recursiveGlob for `**`, this helper should reuse that logic to keep caching behavior consistent.",
"path": "v3/inter... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | filepath.Join is required for cross-platform path handling in LoadLocal; add the import so the code compiles after switching from string concatenation. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/override/override.go b/v3/internal/wake/override/override.go
new file mode 100644
index 00000000000..34551a8d883
--- /dev/null
+++ b/v3/internal/wake/override/override.go
@@ -0,0 +1,52 @@
+package override
+
+import (
+ "os"
+ "path/filepath"
+
+ "github.com/wailsapp/wails/v3/internal/wake... | [
"v3/internal/wake/override/override.go"
] | [
{
"comment": "filepath.Join is required for cross-platform path handling in LoadLocal; add the import so the code compiles after switching from string concatenation.",
"path": "v3/internal/wake/override/override.go",
"hunk": "@@ -0,0 +1,45 @@\n+package override\n+\n+import (\n+\t\"os\"\n+\n+\t\"github.c... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | MergeTask claims “scalar fields take the override value when it is set”, but for boolean fields this implementation can’t distinguish “unset” from “explicitly false”. Using `override.Silent || base.Silent` means an override can never turn a true base value back to false, which is surprising for Taskfile.local.yml layer... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/resolve/merge.go b/v3/internal/wake/resolve/merge.go
new file mode 100644
index 00000000000..202afef42f1
--- /dev/null
+++ b/v3/internal/wake/resolve/merge.go
@@ -0,0 +1,129 @@
+package resolve
+
+import (
+ "github.com/wailsapp/wails/v3/internal/wake/ast"
+)
+
+// MergeTaskfile layers a l... | [
"v3/internal/wake/resolve/merge.go"
] | [
{
"comment": "MergeTask claims “scalar fields take the override value when it is set”, but for boolean fields this implementation can’t distinguish “unset” from “explicitly false”. Using `override.Silent || base.Silent` means an override can never turn a true base value back to false, which is surprising for Ta... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | topologicalSort only sorts the initial zero-in-degree queue. As new nodes are appended, their relative order depends on iteration order of dag.Edges (and Go’s map iteration), making DAG execution order non-deterministic between runs. If this order is used for UI/summaries, it will flicker. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/resolve/dag.go b/v3/internal/wake/resolve/dag.go
new file mode 100644
index 00000000000..30c8fc5f863
--- /dev/null
+++ b/v3/internal/wake/resolve/dag.go
@@ -0,0 +1,141 @@
+package resolve
+
+import (
+ "fmt"
+ "sort"
+
+ "github.com/wailsapp/wails/v3/internal/wake/ast"
+)
+
+type DAG struc... | [
"v3/internal/wake/resolve/dag.go"
] | [
{
"comment": "topologicalSort only sorts the initial zero-in-degree queue. As new nodes are appended, their relative order depends on iteration order of dag.Edges (and Go’s map iteration), making DAG execution order non-deterministic between runs. If this order is used for UI/summaries, it will flicker.",
"... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | The README defines `WAKE_SERIAL` earlier as the opt-out for parallel deps fanout, but this later “Environment variables” table instead documents `WAKE_PARALLEL` as opt-in. That’s contradictory and will confuse users about the actual behavior. | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/README.md b/v3/internal/wake/README.md
new file mode 100644
index 00000000000..1f8157e8fd5
--- /dev/null
+++ b/v3/internal/wake/README.md
@@ -0,0 +1,213 @@
+# Wake
+
+> ⚠️ **Experimental.** Wake is opt-in behind `WAILS_USE_WAKE=true` and is
+> not the default runtime. The default `wails3 b... | [
"v3/internal/wake/README.md"
] | [
{
"comment": "The README defines `WAKE_SERIAL` earlier as the opt-out for parallel deps fanout, but this later “Environment variables” table instead documents `WAKE_PARALLEL` as opt-in. That’s contradictory and will confuse users about the actual behavior.",
"path": "v3/internal/wake/README.md",
"hunk":... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | ResolveVarShell always runs shell vars via `sh -c ...`. On Windows, `sh` is typically not available, so enabling wake would break any Taskfile that uses `vars: {X: {sh: ...}}` (and similar patterns elsewhere). Consider selecting the shell based on platform (or delegating to the embedded Task runtime on Windows) to keep... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/parse/expr.go b/v3/internal/wake/parse/expr.go
new file mode 100644
index 00000000000..ef5ea70f817
--- /dev/null
+++ b/v3/internal/wake/parse/expr.go
@@ -0,0 +1,138 @@
+package parse
+
+import (
+ "fmt"
+ "regexp"
+ "runtime"
+ "strings"
+ "text/template"
+
+ "github.com/wailsapp/wails/v3/... | [
"v3/internal/wake/parse/expr.go"
] | [
{
"comment": "ResolveVarShell always runs shell vars via `sh -c ...`. On Windows, `sh` is typically not available, so enabling wake would break any Taskfile that uses `vars: {X: {sh: ...}}` (and similar patterns elsewhere). Consider selecting the shell based on platform (or delegating to the embedded Task runti... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Wake fast-path bypasses `--dir/--taskfile` semantics.**
Line 101 returns through wake before Line 121–128 run, so `--dir` and `--taskfile` handling from the embedded path is skipped. This can execute the task from the wrong directory or ignore entrypoint selection w... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/commands/task.go b/v3/internal/commands/task.go
index 323a8ff5813..5d681fe4943 100644
--- a/v3/internal/commands/task.go
+++ b/v3/internal/commands/task.go
@@ -9,11 +9,46 @@ import (
"time"
"github.com/wailsapp/wails/v3/internal/term"
+ "github.com/wailsapp/wails/v3/internal/wake"
"gi... | [
"v3/internal/commands/task.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Wake fast-path bypasses `--dir/--taskfile` semantics.**\n\nLine 101 returns through wake before Line 121–128 run, so `--dir` and `--taskfile` handling from the embedded path is skipped. This can execute the task from the wrong directory or ign... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Failed-step duration is computed from build start instead of step start.**
On Line 312, `StepFailed` passes `time.Since(r.buildStart)`, which overstates failed-step duration and distorts summary timing. Let `finishLocked` derive the duration from the step’s `started... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/report/pulse/pulse.go b/v3/internal/report/pulse/pulse.go
new file mode 100644
index 00000000000..e19cb03a490
--- /dev/null
+++ b/v3/internal/report/pulse/pulse.go
@@ -0,0 +1,607 @@
+package pulse
+
+import (
+ "fmt"
+ "io"
+ "os"
+ "strings"
+ "sync"
+ "time"
+
+ "github.com/wailsapp/wails/v3/... | [
"v3/internal/report/pulse/pulse.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Failed-step duration is computed from build start instead of step start.**\n\nOn Line 312, `StepFailed` passes `time.Since(r.buildStart)`, which overstates failed-step duration and distorts summary timing. Let `finishLocked` derive the duratio... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**OSC escape parsing is incorrect in `truncate`/`visibleWidth`.**
Line 176 onward treats `ESC ]` as a completed escape too early, and Line 207 treats any backslash as OSC terminator. This miscounts/truncates hyperlink-wrapped lines and can break panel layout.
<det... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/report/pulse/style.go b/v3/internal/report/pulse/style.go
new file mode 100644
index 00000000000..42a28a663c1
--- /dev/null
+++ b/v3/internal/report/pulse/style.go
@@ -0,0 +1,261 @@
+package pulse
+
+import (
+ "strings"
+
+ "github.com/wailsapp/wails/v3/internal/report/pulse/ansi"
+)
+
+// sty... | [
"v3/internal/report/pulse/style.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**OSC escape parsing is incorrect in `truncate`/`visibleWidth`.**\n\nLine 176 onward treats `ESC ]` as a completed escape too early, and Line 207 treats any backslash as OSC terminator. This miscounts/truncates hyperlink-wrapped lines and can br... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Package manager detection is nondeterministic due to map iteration order.**
When multiple lockfiles are present, selection can change between runs. Use an ordered slice to enforce precedence.
<details>
<summary>Proposed fix</summary>
```diff
func DetectPackage... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/cmds/frontend.go b/v3/internal/wake/cmds/frontend.go
new file mode 100644
index 00000000000..644a1edde0d
--- /dev/null
+++ b/v3/internal/wake/cmds/frontend.go
@@ -0,0 +1,120 @@
+package cmds
+
+import (
+ "os"
+ "os/exec"
+ "path/filepath"
+)
+
+func DetectPackageManager(dir string) string... | [
"v3/internal/wake/cmds/frontend.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Package manager detection is nondeterministic due to map iteration order.**\n\nWhen multiple lockfiles are present, selection can change between runs. Use an ordered slice to enforce precedence.\n\n \n\n<details>\n<summary>Proposed fix</summar... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**`go test -count` parsing is incorrect and unsafe.**
Line 274 reads only the first character (`"10"` becomes `1`) and can panic on malformed empty values. Use `strconv.Atoi` with validation.
<details>
<summary>Proposed fix</summary>
```diff
+import "strconv"
@@
... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/cmds/shell.go b/v3/internal/wake/cmds/shell.go
new file mode 100644
index 00000000000..aec28739159
--- /dev/null
+++ b/v3/internal/wake/cmds/shell.go
@@ -0,0 +1,379 @@
+package cmds
+
+import (
+ "io"
+ "os/exec"
+ "regexp"
+ "strconv"
+ "strings"
+)
+
+type Executor interface {
+ Run() er... | [
"v3/internal/wake/cmds/shell.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**`go test -count` parsing is incorrect and unsafe.**\n\nLine 274 reads only the first character (`\"10\"` becomes `1`) and can panic on malformed empty values. Use `strconv.Atoi` with validation.\n\n \n\n<details>\n<summary>Proposed fix</summar... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🔴 Critical_ | _🏗️ Heavy lift_
**Protect `TaskCache` reads/writes with synchronization.**
`TaskCache.Entries` and `Save()` are used from parallel task execution paths. As written, concurrent map access and overlapping cache-file writes can race and corrupt cache state.
<details>
<summary>... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/cache.go b/v3/internal/wake/exec/cache.go
new file mode 100644
index 00000000000..572c933b635
--- /dev/null
+++ b/v3/internal/wake/exec/cache.go
@@ -0,0 +1,328 @@
+package exec
+
+import (
+ "crypto/sha256"
+ "encoding/json"
+ "fmt"
+ "os"
+ "path/filepath"
+ "sort"
+ "strings"
+ "syn... | [
"v3/internal/wake/exec/cache.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _🏗️ Heavy lift_\n\n**Protect `TaskCache` reads/writes with synchronization.**\n\n`TaskCache.Entries` and `Save()` are used from parallel task execution paths. As written, concurrent map access and overlapping cache-file writes can race and corrupt cache stat... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Avoid hardcoding `sh -c` for status checks.**
This breaks status-based skipping on Windows environments where `sh` is unavailable.
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each finding against current code. Fix only still-valid issues, skip ... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/cache.go b/v3/internal/wake/exec/cache.go
new file mode 100644
index 00000000000..572c933b635
--- /dev/null
+++ b/v3/internal/wake/exec/cache.go
@@ -0,0 +1,328 @@
+package exec
+
+import (
+ "crypto/sha256"
+ "encoding/json"
+ "fmt"
+ "os"
+ "path/filepath"
+ "sort"
+ "strings"
+ "syn... | [
"v3/internal/wake/exec/cache.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Avoid hardcoding `sh -c` for status checks.**\n\nThis breaks status-based skipping on Windows environments where `sh` is unavailable.\n\n<details>\n<summary>🤖 Prompt for AI Agents</summary>\n\n```\nVerify each finding against current code. Fi... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Normalize paths before exclude glob matching.**
`filepath.Rel` may return backslashes on Windows, while Taskfile globs are typically slash-based. Excludes can silently fail there.
<details>
<summary>Patch sketch</summary>
```diff
rel, err := filepath.Rel(bas... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/cache.go b/v3/internal/wake/exec/cache.go
new file mode 100644
index 00000000000..572c933b635
--- /dev/null
+++ b/v3/internal/wake/exec/cache.go
@@ -0,0 +1,328 @@
+package exec
+
+import (
+ "crypto/sha256"
+ "encoding/json"
+ "fmt"
+ "os"
+ "path/filepath"
+ "sort"
+ "strings"
+ "syn... | [
"v3/internal/wake/exec/cache.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Normalize paths before exclude glob matching.**\n\n`filepath.Rel` may return backslashes on Windows, while Taskfile globs are typically slash-based. Excludes can silently fail there.\n\n \n\n<details>\n<summary>Patch sketch</summary>\n\n```dif... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Guard `depRuns` with a mutex in parallel execution.**
`depRuns` is a shared map mutated during dependency planning while parallel task execution is enabled, which can race/panic under concurrent access.
Also applies to: 276-286
<details>
<summary>🤖 Prompt ... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/exec.go b/v3/internal/wake/exec/exec.go
new file mode 100644
index 00000000000..13b522f9e24
--- /dev/null
+++ b/v3/internal/wake/exec/exec.go
@@ -0,0 +1,817 @@
+package exec
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "os"
+ osexec "os/exec"
+ "path/filepath"
+ "sort"
+ "strings"
+ "... | [
"v3/internal/wake/exec/exec.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Guard `depRuns` with a mutex in parallel execution.**\n\n`depRuns` is a shared map mutated during dependency planning while parallel task execution is enabled, which can race/panic under concurrent access.\n\n \n\n\nAlso applies to: 276-286... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use `filepath.IsAbs` for cross-platform absolute-path checks.**
Checking `"/"` prefix misclassifies absolute paths on Windows (e.g. `C:\...`) and can build incorrect working directories.
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each finding ... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/exec.go b/v3/internal/wake/exec/exec.go
new file mode 100644
index 00000000000..13b522f9e24
--- /dev/null
+++ b/v3/internal/wake/exec/exec.go
@@ -0,0 +1,817 @@
+package exec
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "os"
+ osexec "os/exec"
+ "path/filepath"
+ "sort"
+ "strings"
+ "... | [
"v3/internal/wake/exec/exec.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use `filepath.IsAbs` for cross-platform absolute-path checks.**\n\nChecking `\"/\"` prefix misclassifies absolute paths on Windows (e.g. `C:\\...`) and can build incorrect working directories.\n\n<details>\n<summary>🤖 Prompt for AI Agents</su... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Only report Go build artifacts on successful command execution.**
`defer e.reportGoBuildArtifact(...)` runs even when the command fails, so a stale prior binary can be incorrectly reported as a fresh artifact.
<details>
<summary>Patch sketch</summary>
```diff
-... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/exec.go b/v3/internal/wake/exec/exec.go
new file mode 100644
index 00000000000..13b522f9e24
--- /dev/null
+++ b/v3/internal/wake/exec/exec.go
@@ -0,0 +1,817 @@
+package exec
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "os"
+ osexec "os/exec"
+ "path/filepath"
+ "sort"
+ "strings"
+ "... | [
"v3/internal/wake/exec/exec.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Only report Go build artifacts on successful command execution.**\n\n`defer e.reportGoBuildArtifact(...)` runs even when the command fails, so a stale prior binary can be incorrectly reported as a fresh artifact.\n\n \n\n<details>\n<summary>Pa... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Resolve for-loop task vars in loop scope before dispatch.**
`fl.Vars` is passed directly to `runTask`, so templates that depend on per-item variables (like `ITEM`) won’t resolve as intended.
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each find... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/exec.go b/v3/internal/wake/exec/exec.go
new file mode 100644
index 00000000000..13b522f9e24
--- /dev/null
+++ b/v3/internal/wake/exec/exec.go
@@ -0,0 +1,817 @@
+package exec
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "os"
+ osexec "os/exec"
+ "path/filepath"
+ "sort"
+ "strings"
+ "... | [
"v3/internal/wake/exec/exec.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Resolve for-loop task vars in loop scope before dispatch.**\n\n`fl.Vars` is passed directly to `runTask`, so templates that depend on per-item variables (like `ITEM`) won’t resolve as intended.\n\n<details>\n<summary>🤖 Prompt for AI Agents</s... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.