repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use runtime OS detection, not `GOOS` env lookup.**
Platform filtering currently checks `os.Getenv("GOOS")`, which is usually unset at runtime and causes platform-gated tasks to be skipped incorrectly.
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/exec.go b/v3/internal/wake/exec/exec.go
new file mode 100644
index 00000000000..13b522f9e24
--- /dev/null
+++ b/v3/internal/wake/exec/exec.go
@@ -0,0 +1,817 @@
+package exec
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "os"
+ osexec "os/exec"
+ "path/filepath"
+ "sort"
+ "strings"
+ "... | [
"v3/internal/wake/exec/exec.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use runtime OS detection, not `GOOS` env lookup.**\n\nPlatform filtering currently checks `os.Getenv(\"GOOS\")`, which is usually unset at runtime and causes platform-gated tasks to be skipped incorrectly.\n\n<details>\n<summary>🤖 Prompt for ... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Handle `-o=<path>` in `parseOutputFlag`.**
`go build -o=bin/app` currently returns empty output, so cache skip may proceed without verifying binary existence.
<details>
<summary>Patch sketch</summary>
```diff
for i := 0; i < len(f); i++ {
if f[i] == "-o" &... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/gocache.go b/v3/internal/wake/exec/gocache.go
new file mode 100644
index 00000000000..5d520c2cbfb
--- /dev/null
+++ b/v3/internal/wake/exec/gocache.go
@@ -0,0 +1,196 @@
+package exec
+
+import (
+ "crypto/sha256"
+ "fmt"
+ "os"
+ "path/filepath"
+ "strings"
+ "time"
+
+ "github.com/wa... | [
"v3/internal/wake/exec/gocache.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Handle `-o=<path>` in `parseOutputFlag`.**\n\n`go build -o=bin/app` currently returns empty output, so cache skip may proceed without verifying binary existence.\n\n \n\n<details>\n<summary>Patch sketch</summary>\n\n```diff\n \tfor i := 0; i <... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Replace `sh -c` precondition/status execution with portable command handling.**
Hardcoding `sh` breaks task preconditions/status evaluation on Windows.
Also applies to: 47-48
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each finding against... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/runner.go b/v3/internal/wake/exec/runner.go
new file mode 100644
index 00000000000..1b2da7ea455
--- /dev/null
+++ b/v3/internal/wake/exec/runner.go
@@ -0,0 +1,98 @@
+package exec
+
+import (
+ "fmt"
+ "os"
+ "sync"
+ "time"
+
+ "github.com/wailsapp/wails/v3/internal/wake/ast"
+ "githu... | [
"v3/internal/wake/exec/runner.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Replace `sh -c` precondition/status execution with portable command handling.**\n\nHardcoding `sh` breaks task preconditions/status evaluation on Windows.\n\n \n\n\nAlso applies to: 47-48\n\n<details>\n<summary>🤖 Prompt for AI Agents</summary... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Synchronize reads of `cache.lastRuns`.**
`RecordRun` writes under mutex, but `isUpToDate` reads without locking. Parallel execution can trigger concurrent map read/write races.
Also applies to: 89-93
<details>
<summary>🤖 Prompt for AI Agents</summary>
```... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/exec/runner.go b/v3/internal/wake/exec/runner.go
new file mode 100644
index 00000000000..1b2da7ea455
--- /dev/null
+++ b/v3/internal/wake/exec/runner.go
@@ -0,0 +1,98 @@
+package exec
+
+import (
+ "fmt"
+ "os"
+ "sync"
+ "time"
+
+ "github.com/wailsapp/wails/v3/internal/wake/ast"
+ "githu... | [
"v3/internal/wake/exec/runner.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Synchronize reads of `cache.lastRuns`.**\n\n`RecordRun` writes under mutex, but `isUpToDate` reads without locking. Parallel execution can trigger concurrent map read/write races.\n\n \n\n\nAlso applies to: 89-93\n\n<details>\n<summary>🤖 P... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use platform-aware shell invocation for var shell commands.**
Line 119 hardcodes `sh -c`; this will fail on Windows hosts and break `vars: { sh: ... }` resolution.
<details>
<summary>Proposed fix</summary>
```diff
func ResolveVarShell(vr *ast.Var) error {
@@
... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/parse/expr.go b/v3/internal/wake/parse/expr.go
new file mode 100644
index 00000000000..ef5ea70f817
--- /dev/null
+++ b/v3/internal/wake/parse/expr.go
@@ -0,0 +1,138 @@
+package parse
+
+import (
+ "fmt"
+ "regexp"
+ "runtime"
+ "strings"
+ "text/template"
+
+ "github.com/wailsapp/wails/v3/... | [
"v3/internal/wake/parse/expr.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use platform-aware shell invocation for var shell commands.**\n\nLine 119 hardcodes `sh -c`; this will fail on Windows hosts and break `vars: { sh: ... }` resolution.\n\n \n\n<details>\n<summary>Proposed fix</summary>\n\n```diff\n func Resolv... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**`for` loop items are never parsed into `ForLoop.Items`.**
`parseFor` ignores scalar/sequence forms and never populates `Items`, so item-based loop expansion cannot work.
<details>
<summary>Proposed fix</summary>
```diff
func parseFor(node *yaml.Node) (*ast.For... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/parse/parse.go b/v3/internal/wake/parse/parse.go
new file mode 100644
index 00000000000..0153f5869ac
--- /dev/null
+++ b/v3/internal/wake/parse/parse.go
@@ -0,0 +1,618 @@
+package parse
+
+import (
+ "fmt"
+ "os"
+ "path/filepath"
+ "runtime"
+ "strings"
+
+ "github.com/wailsapp/wails/v3/i... | [
"v3/internal/wake/parse/parse.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**`for` loop items are never parsed into `ForLoop.Items`.**\n\n`parseFor` ignores scalar/sequence forms and never populates `Items`, so item-based loop expansion cannot work.\n\n \n\n<details>\n<summary>Proposed fix</summary>\n\n```diff\n func p... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Shell vars are being finalized as raw commands, not command output.**
Lines 543–545 set `vr.Value = vr.Shell`, which prevents later shell execution paths that require empty `Value`. This breaks `sh:` variable semantics.
<details>
<summary>Proposed fix</summary>
... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/parse/parse.go b/v3/internal/wake/parse/parse.go
new file mode 100644
index 00000000000..0153f5869ac
--- /dev/null
+++ b/v3/internal/wake/parse/parse.go
@@ -0,0 +1,618 @@
+package parse
+
+import (
+ "fmt"
+ "os"
+ "path/filepath"
+ "runtime"
+ "strings"
+
+ "github.com/wailsapp/wails/v3/i... | [
"v3/internal/wake/parse/parse.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Shell vars are being finalized as raw commands, not command output.**\n\nLines 543–545 set `vr.Value = vr.Shell`, which prevents later shell execution paths that require empty `Value`. This breaks `sh:` variable semantics.\n\n \n\n<details>\n<... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
python - <<'PY'
from pathlib import Path
text = Path("v3/internal/wake/wake.go").read_text().splitlines()
for i,l in enumerate(text,1):
if 'SplitN(name, ":", 2)' in l or 'len(... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/wake.go b/v3/internal/wake/wake.go
new file mode 100644
index 00000000000..3aabcd8311e
--- /dev/null
+++ b/v3/internal/wake/wake.go
@@ -0,0 +1,521 @@
+package wake
+
+import (
+ "context"
+ "errors"
+ "fmt"
+ "os"
+ "path/filepath"
+ "strings"
+ "sync"
+ "time"
+
+ "github.com/wailsapp/wai... | [
"v3/internal/wake/wake.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\npython - <<'PY'\nfrom pathlib import Path\ntext = Path(\"v3/internal/wake/wake.go\").read_text().splitlines()\nfor i,l in enumerate(text,1):\n if... | true | ||
wailsapp/wails | 5,535 | comment_to_fix | feat(wake): experimental Go-native build runner (opt-in via WAILS_USE_WAKE=true) | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Handle non-`os.IsNotExist` stat errors explicitly.**
`os.Stat` errors other than missing files are currently swallowed, which can silently ignore a valid override due to permission/I/O problems.
<details>
<summary>Suggested fix</summary>
```diff
path := fil... | afe86936681874007942a23e1ff7c368f524f7bc | caea3e214ec0e47e2a8e51ba37dd49287856d8ab | diff --git a/v3/internal/wake/override/override.go b/v3/internal/wake/override/override.go
new file mode 100644
index 00000000000..34551a8d883
--- /dev/null
+++ b/v3/internal/wake/override/override.go
@@ -0,0 +1,52 @@
+package override
+
+import (
+ "os"
+ "path/filepath"
+
+ "github.com/wailsapp/wails/v3/internal/wake... | [
"v3/internal/wake/override/override.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Handle non-`os.IsNotExist` stat errors explicitly.**\n\n`os.Stat` errors other than missing files are currently swallowed, which can silently ignore a valid override due to permission/I/O problems.\n\n\n\n\n<details>\n<summary>Suggested fix</s... | true | ||
wailsapp/wails | 5,531 | issue_to_patch | fix(buildinfo): Development should reflect local source, not vcs=git | ## Summary
`buildinfo.Info.Development` was implemented as **"the binary's BuildInfo carries a `vcs=git` build setting."** That signal is emitted by Go's toolchain for *any* binary built inside a git checkout, including release artefacts produced by CI from a tagged commit. As a result, every released `wails3` binary ... | ef782b77c892b6a7e45c3227f73fb0e20d0ed600 | 4b7b311fd09b27df2481f4e5bcffcd29845c485e | diff --git a/v3/internal/buildinfo/buildinfo.go b/v3/internal/buildinfo/buildinfo.go
index d3dee433148..7c9d7e77893 100644
--- a/v3/internal/buildinfo/buildinfo.go
+++ b/v3/internal/buildinfo/buildinfo.go
@@ -3,12 +3,32 @@ package buildinfo
import (
"fmt"
"runtime/debug"
- "slices"
+ wdebug "github.com/wailsapp/... | [
"v3/internal/buildinfo/buildinfo.go",
"v3/internal/buildinfo/buildinfo_test.go"
] | [
{
"comment": "The doc comment still contains a placeholder issue reference `#XXXX`. This should be replaced with the real issue/PR reference (or removed) before merging so the comment doesn’t ship with an unresolved placeholder.",
"path": "v3/internal/buildinfo/buildinfo.go",
"hunk": "@@ -3,12 +3,32 @@ ... | diff --git a/v3/internal/buildinfo/buildinfo_test.go b/v3/internal/buildinfo/buildinfo_test.go
index ab79f63f838..06093ceef2d 100644
--- a/v3/internal/buildinfo/buildinfo_test.go
+++ b/v3/internal/buildinfo/buildinfo_test.go
@@ -2,6 +2,8 @@ package buildinfo
import (
"testing"
+
+ wdebug "github.com/wailsapp/wails... | true | |
wailsapp/wails | 5,531 | comment_to_fix | fix(buildinfo): Development should reflect local source, not vcs=git | The doc comment still contains a placeholder issue reference `#XXXX`. This should be replaced with the real issue/PR reference (or removed) before merging so the comment doesn’t ship with an unresolved placeholder. | ef782b77c892b6a7e45c3227f73fb0e20d0ed600 | 4b7b311fd09b27df2481f4e5bcffcd29845c485e | diff --git a/v3/internal/buildinfo/buildinfo.go b/v3/internal/buildinfo/buildinfo.go
index d3dee433148..7c9d7e77893 100644
--- a/v3/internal/buildinfo/buildinfo.go
+++ b/v3/internal/buildinfo/buildinfo.go
@@ -3,12 +3,32 @@ package buildinfo
import (
"fmt"
"runtime/debug"
- "slices"
+ wdebug "github.com/wailsapp/... | [
"v3/internal/buildinfo/buildinfo.go"
] | [
{
"comment": "The doc comment still contains a placeholder issue reference `#XXXX`. This should be replaced with the real issue/PR reference (or removed) before merging so the comment doesn’t ship with an unresolved placeholder.",
"path": "v3/internal/buildinfo/buildinfo.go",
"hunk": "@@ -3,12 +3,32 @@ ... | true | ||
wailsapp/wails | 5,531 | comment_to_fix | fix(buildinfo): Development should reflect local source, not vcs=git | This comment refers to `debug.LocalModulePath`, but this file imports the stdlib package `runtime/debug` as `debug`. For clarity (and to avoid implying there’s a `LocalModulePath` symbol in `runtime/debug`), reference `[wdebug.LocalModulePath]` consistently here too. | ef782b77c892b6a7e45c3227f73fb0e20d0ed600 | 4b7b311fd09b27df2481f4e5bcffcd29845c485e | diff --git a/v3/internal/buildinfo/buildinfo.go b/v3/internal/buildinfo/buildinfo.go
index d3dee433148..7c9d7e77893 100644
--- a/v3/internal/buildinfo/buildinfo.go
+++ b/v3/internal/buildinfo/buildinfo.go
@@ -3,12 +3,32 @@ package buildinfo
import (
"fmt"
"runtime/debug"
- "slices"
+ wdebug "github.com/wailsapp/... | [
"v3/internal/buildinfo/buildinfo.go"
] | [
{
"comment": "This comment refers to `debug.LocalModulePath`, but this file imports the stdlib package `runtime/debug` as `debug`. For clarity (and to avoid implying there’s a `LocalModulePath` symbol in `runtime/debug`), reference `[wdebug.LocalModulePath]` consistently here too.",
"path": "v3/internal/bui... | true | ||
wailsapp/wails | 5,531 | comment_to_fix | fix(buildinfo): Development should reflect local source, not vcs=git | The test comment says Development tracks `debug.LocalModulePath`, but this test imports the package as `wdebug`. Using the same name as the code avoids confusion with the stdlib `runtime/debug` package mentioned elsewhere. | ef782b77c892b6a7e45c3227f73fb0e20d0ed600 | 4b7b311fd09b27df2481f4e5bcffcd29845c485e | diff --git a/v3/internal/buildinfo/buildinfo_test.go b/v3/internal/buildinfo/buildinfo_test.go
index ab79f63f838..06093ceef2d 100644
--- a/v3/internal/buildinfo/buildinfo_test.go
+++ b/v3/internal/buildinfo/buildinfo_test.go
@@ -2,6 +2,8 @@ package buildinfo
import (
"testing"
+
+ wdebug "github.com/wailsapp/wails... | [
"v3/internal/buildinfo/buildinfo_test.go"
] | [
{
"comment": "The test comment says Development tracks `debug.LocalModulePath`, but this test imports the package as `wdebug`. Using the same name as the code avoids confusion with the stdlib `runtime/debug` package mentioned elsewhere.",
"path": "v3/internal/buildinfo/buildinfo_test.go",
"hunk": "@@ -1... | true | ||
wailsapp/wails | 5,530 | issue_to_patch | [v3] Freezes with open inspector on linux.
### Description
Since alpha 97, I am observing a complete freeze of the UI (and only the UI, the backend is entirely fine and doesn't even notice something has happened to Webkit) while the inspector is open. Once this happens, the OS asks you to kill the application, nothin... | fix(linux): stop forcing SA_ONSTACK on SIGUSR1 to prevent WebKit freeze | ## Summary
Fixes #5527 — a regression introduced in **alpha.97** where the WebKit UI freezes on Linux while idle (most visibly with the inspector open). Only the UI hangs; the Go backend keeps running.
## Root cause
The freeze traces to PR #5507 (`6329e9d`), the only Linux/WebKit signal-handling change between alpha... | 37ec248c408820514d419716d43bcc39ed4c40da | 6f90572fcc599ef2813c2f247c61932e83da5090 | diff --git a/v2/internal/frontend/desktop/linux/frontend.go b/v2/internal/frontend/desktop/linux/frontend.go
index ed26b67a1d5..3751e5266ff 100644
--- a/v2/internal/frontend/desktop/linux/frontend.go
+++ b/v2/internal/frontend/desktop/linux/frontend.go
@@ -65,9 +65,12 @@ static void install_signal_handlers()
#if defin... | [
"v2/internal/frontend/desktop/linux/frontend.go",
"v3/UNRELEASED_CHANGELOG.md",
"v3/pkg/application/linux_cgo.c",
"v3/pkg/application/linux_cgo_gtk3.go"
] | [] | true | |
wailsapp/wails | 5,532 | issue_to_patch | fix(v3): regenerate go.sum after refresh v1.0.0 bump (#5526) | ## Problem
Commit ff529b75d ("Update refresh dependency to version 1.0.0", #5526) bumped `github.com/atterpac/refresh` to **v1.0.0** in `v3/go.mod` but left `v3/go.sum` carrying only the **v0.8.6** checksums.
Any module-aware build that runs with the default `-mod=readonly` therefore fails. The most visible case is t... | aa31c67149f0d534837e6ca415216303804d61ae | c22bc83c8e0b89771c1e79f0d7803429f1585f2d | diff --git a/v3/go.mod b/v3/go.mod
index d73783d2c21..9fe9738452a 100644
--- a/v3/go.mod
+++ b/v3/go.mod
@@ -57,7 +57,7 @@ require (
github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/konoui/go-qsort v0.1.0 // indirect
- github.com/lm... | [
"v3/go.mod",
"v3/go.sum"
] | [] | true | ||
wailsapp/wails | 5,524 | issue_to_patch | Bindings Fail to Generate
### Description
# Bindings Fail to Generate
## Description
When attempting to build my Wails app on Windows, the build fails during the binding generation step. The error indicates that the generated `wailsbindings.exe` is not compatible with my system, even though all other Wails doctor ch... | fix(bindings): strip debug info on Windows to avoid Go 1.25 DWARF5 PE bug | ## Summary
Fixes #4605 and #4551.
Go 1.25 switched to DWARF5 debug format by default. On Windows, the internal linker emits malformed PE section headers when DWARF5 sections are present ([golang/go#75077](https://github.com/golang/go/issues/75077), [golang/go#75121](https://github.com/golang/go/issues/75121)). The ge... | ff529b75d22766bec7a376b121dcafd792a26ac2 | c7b507063a83016c0ea9f3db18667c2d739c052a | diff --git a/v2/pkg/commands/bindings/bindings.go b/v2/pkg/commands/bindings/bindings.go
index 82ce0d58f60..59248c9528a 100644
--- a/v2/pkg/commands/bindings/bindings.go
+++ b/v2/pkg/commands/bindings/bindings.go
@@ -60,7 +60,17 @@ func GenerateBindings(options Options) (string, error) {
// So, use the default C comp... | [
"v2/pkg/commands/bindings/bindings.go"
] | [
{
"comment": "This call introduces a new frontend-dist synchronization step that is not mentioned in the PR title or description, which only describe the CGO fix for the bindings helper. Because this changes build behavior for custom `frontend:dir` projects (including deleting/recreating embed target directorie... | true | |
wailsapp/wails | 5,524 | comment_to_fix | fix(bindings): strip debug info on Windows to avoid Go 1.25 DWARF5 PE bug | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Description: Check for CGO usage in the bindings-related code
# Search for CGO imports or build tags in files tagged with "bindings"
rg -n --type=go -C3 'import "C"'
# Search... | ff529b75d22766bec7a376b121dcafd792a26ac2 | c7b507063a83016c0ea9f3db18667c2d739c052a | diff --git a/v2/pkg/commands/bindings/bindings.go b/v2/pkg/commands/bindings/bindings.go
index 82ce0d58f60..59248c9528a 100644
--- a/v2/pkg/commands/bindings/bindings.go
+++ b/v2/pkg/commands/bindings/bindings.go
@@ -60,7 +60,17 @@ func GenerateBindings(options Options) (string, error) {
// So, use the default C comp... | [
"v2/pkg/commands/bindings/bindings.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check for CGO usage in the bindings-related code\n\n# Search for CGO imports or build tags in files tagged with \"bindings\"\nrg -n -... | true | ||
walkor/workerman | 1,159 | issue_to_patch | 增加socks5代理身份验证的支持 | 5abd12421e862302f36d4cb7a5c2470fe209aad6 | 3672194567219f0f40eb55958f98e731cc4db56c | diff --git a/src/Connection/AsyncTcpConnection.php b/src/Connection/AsyncTcpConnection.php
index c4ab7bc3..97d1fb0f 100644
--- a/src/Connection/AsyncTcpConnection.php
+++ b/src/Connection/AsyncTcpConnection.php
@@ -107,6 +107,20 @@ class AsyncTcpConnection extends TcpConnection
*/
public string $proxyAuthori... | [
"src/Connection/AsyncTcpConnection.php"
] | [] | true | |||
walkor/workerman | 1,158 | issue_to_patch | Fix header extraction logic in Http class to account for buffer length | Before always return the `substr()`, even when it's the end of the buffer.
Before:
`$header = isset($buffer[$length]) ? substr($buffer, 0, $length) : $buffer;`
Now:
`$header = isset($buffer[$length + 1]) ? substr($buffer, 0, $length) : $buffer;`
| 5abd12421e862302f36d4cb7a5c2470fe209aad6 | 31c023c8c8d2021d7e003b9fda1fb1877abd113d | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 453bd8a3..828d88ea 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -128,7 +128,7 @@ public static function input(string $buffer, TcpConnection $connection): int
$connection->end(static::HTTP_431, true);
retu... | [
"src/Protocols/Http.php"
] | [] | true | ||
walkor/workerman | 1,156 | issue_to_patch | Validate Host header format in Http.php | Add validation for Host header format according to RFC 9110.
EDIT: also fix nullable deprecation in Mockery lib
```
PHP Deprecated: Mockery::formatArgs(): Implicitly marking parameter $arguments as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/workerman/workerman/ven... | 1d8694c945bc64a5bc11ad753ec7220bcba37cb1 | 2b3dc8c8f47df48669ff3c1793e1bbe5cd73fb00 | diff --git a/composer.json b/composer.json
index d7254d26..d10bc8ad 100644
--- a/composer.json
+++ b/composer.json
@@ -49,7 +49,7 @@
},
"require-dev": {
"pestphp/pest": "^2.36 || ^3 || ^4",
- "mockery/mockery": "^1.6",
+ "mockery/mockery": "^1.6.12",
"guzzlehttp/guzzle": "^7.10... | [
"composer.json",
"src/Protocols/Http.php",
"tests/Unit/Protocols/HttpTest.php"
] | [] | diff --git a/tests/Unit/Protocols/HttpTest.php b/tests/Unit/Protocols/HttpTest.php
index 5f7f4147..8390c113 100644
--- a/tests/Unit/Protocols/HttpTest.php
+++ b/tests/Unit/Protocols/HttpTest.php
@@ -139,6 +139,80 @@
});
});
+describe('Host header uri-host[:port] RFC 9110 Section 7.2', function () {
+ it('rej... | true | |
walkor/workerman | 1,155 | issue_to_patch | Fix regex for HTTP RFC 9112 §2.3 | A request using HTTP version 1.2, which does not exist but has a higher minor version than 1.1.
https://www.rfc-editor.org/rfc/rfc9112#section-2.3 | 1d8694c945bc64a5bc11ad753ec7220bcba37cb1 | 333e62c12d466c699daa0da265091b79bf91092a | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 8398c551..fa131c50 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -129,7 +129,7 @@ public static function input(string $buffer, TcpConnection $connection): int
// Validate request line: METHOD SP origin-form SP HTTP/1.x
... | [
"src/Protocols/Http.php"
] | [] | true | ||
walkor/workerman | 1,154 | issue_to_patch | Add HTTP 431 status for request header fields too large | https://datatracker.ietf.org/doc/html/rfc6585#section-5 | 1d8694c945bc64a5bc11ad753ec7220bcba37cb1 | 2b68704e07866a52781c9b3857c393c8b4bec158 | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 8398c551..eec68e82 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -77,9 +77,17 @@ class Http
*/
protected const HTTP_413 = "HTTP/1.1 413 Payload Too Large\r\nConnection: close\r\n\r\n";
+ /**
+ * Request Header F... | [
"src/Protocols/Http.php",
"tests/Unit/Protocols/HttpTest.php"
] | [] | diff --git a/tests/Unit/Protocols/HttpTest.php b/tests/Unit/Protocols/HttpTest.php
index 5f7f4147..d6436c13 100644
--- a/tests/Unit/Protocols/HttpTest.php
+++ b/tests/Unit/Protocols/HttpTest.php
@@ -22,11 +22,11 @@
});
it('tests ::input', function () {
- //test 413 payload too large
+ //test 431 Request Heade... | true | |
walkor/workerman | 1,153 | issue_to_patch | Add getMimeType($ext) function in class Response | I'm creating a static file class for Adapterman.
First I tried some code creating a `StaticPreCompressed` middleware for Webman (later I'll send it).
That check the `Accept-Encoding` to try to serve pre-compressed `.br` and `.gz` files first, and serve correct headers.
But always download the file, even with the `... | 85ca7c95d71cc6322423ae6f8a5526a62eac1943 | ef2fd8cb695ada04963e47a975c95537fb7c8dff | diff --git a/src/Protocols/Http/Response.php b/src/Protocols/Http/Response.php
index 8ee51b7e0..76c901bca 100644
--- a/src/Protocols/Http/Response.php
+++ b/src/Protocols/Http/Response.php
@@ -56,7 +56,7 @@ class Response implements Stringable
public ?array $file = null;
/**
- * Mine type map.
+ * M... | [
"src/Protocols/Http/Response.php",
"tests/Unit/Protocols/Http/ResponseTest.php"
] | [] | diff --git a/tests/Unit/Protocols/Http/ResponseTest.php b/tests/Unit/Protocols/Http/ResponseTest.php
index 1bd61fd6a..ec2a12654 100644
--- a/tests/Unit/Protocols/Http/ResponseTest.php
+++ b/tests/Unit/Protocols/Http/ResponseTest.php
@@ -54,4 +54,4 @@
expect((string)$response)
->toContain('Content-Type: i... | true | |
walkor/workerman | 1,144 | issue_to_patch | Refactor WebSocket handshake error handling | Add error 426 if websocket version is incorrect or 400 if don't exist (RFC 6455 [Section 4.4](https://www.rfc-editor.org/rfc/rfc6455#section-4.4) and [section-4.2.2](https://datatracker.ietf.org/doc/html/rfc6455#section-4.2.2) ).
Do you want than we create a test ? Because we have the test of Http11probe.
| 74324dce29d2282f4a7feeabab18c644347acc3b | 1826d962859557ed344e4b3efee2bf7d984c7641 | diff --git a/src/Protocols/Websocket.php b/src/Protocols/Websocket.php
index bde7943ee..04b710f93 100644
--- a/src/Protocols/Websocket.php
+++ b/src/Protocols/Websocket.php
@@ -373,11 +373,12 @@ protected static function deflate(TcpConnection $connection, string $buffer): fa
*/
public static function dealHan... | [
"src/Protocols/Websocket.php"
] | [] | true | ||
walkor/workerman | 1,146 | issue_to_patch | Remove Content-Length header from HTTP 400 and 413 responses | The `Content-Length` field is optional in HTTP responses when the server closes the connection immediately after sending the headers.
PD: we can also maintain it, but we send extra bytes for nothing. | 74324dce29d2282f4a7feeabab18c644347acc3b | 9702e44635f4fda40196ffc2e81cf561fb604fab | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 3d100e9e2..9de3cdc76 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -65,14 +65,14 @@ class Http
*
* @var string
*/
- protected const HTTP_400 = "HTTP/1.1 400 Bad Request\r\nConnection: close\r\nContent-Length: 0... | [
"src/Protocols/Http.php"
] | [] | true | ||
walkor/workerman | 1,145 | issue_to_patch | Missing Host header causes 400 Bad Request for HTTP/1.1 | [rfc7230 section-5.4](https://www.rfc-editor.org/rfc/rfc7230#section-5.4)
First we create the test and add the code.
Later we need to update the tests. | 74324dce29d2282f4a7feeabab18c644347acc3b | e63faef167fae85ac42cfbb236a0653380066d0d | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 3d100e9e2..b13659766 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -131,6 +131,8 @@ public static function input(string $buffer, TcpConnection $connection): int
// Use [ \t]* instead of \s* to avoid matching across l... | [
"src/Protocols/Http.php",
"tests/Unit/Protocols/HttpTest.php"
] | [] | diff --git a/tests/Unit/Protocols/HttpTest.php b/tests/Unit/Protocols/HttpTest.php
index b8d8bd3f7..b60c942d4 100644
--- a/tests/Unit/Protocols/HttpTest.php
+++ b/tests/Unit/Protocols/HttpTest.php
@@ -5,6 +5,8 @@
use Workerman\Protocols\Http\Request;
use Workerman\Protocols\Http\Response;
+const HTTP_400 = "HTTP/1.... | true | |
walkor/workerman | 1,149 | issue_to_patch | Update HTTP request validation to disallow lowercase methods and versions | Method names are case-sensitive, and all registered methods are all upper-case.
The version of an HTTP/1.x message is indicated by an HTTP-version field in the [start-line](https://www.rfc-editor.org/rfc/rfc9112#message.format). HTTP-version is case-sensitive.
https://www.rfc-editor.org/rfc/rfc7231#section-4.1
... | 74324dce29d2282f4a7feeabab18c644347acc3b | adfced98b05e552d8378c32b429ada4cfffa99b0 | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 3d100e9e2..1c432a6a5 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -140,7 +140,9 @@ public static function input(string $buffer, TcpConnection $connection): int
// Disallow duplicate Content-Length headers (adjacent or... | [
"src/Protocols/Http.php",
"tests/Unit/Protocols/HttpTest.php"
] | [] | diff --git a/tests/Unit/Protocols/HttpTest.php b/tests/Unit/Protocols/HttpTest.php
index b8d8bd3f7..dfd9b8866 100644
--- a/tests/Unit/Protocols/HttpTest.php
+++ b/tests/Unit/Protocols/HttpTest.php
@@ -100,10 +100,6 @@
"GET / HTTP/1.1\r\n\r\n",
18, // strlen("GET / HTTP/1.1\r\n\r\n")
],
- 'lowe... | true | |
walkor/workerman | 1,148 | issue_to_patch | Refactor header validation regex to use named capture for Content-Length | So we can move and add more regex validations without problems. | 74324dce29d2282f4a7feeabab18c644347acc3b | 8c20d88b0860c0f9d18c9b704a8a0c7a32c96b42 | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 3d100e9e2..0677dfb80 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -132,7 +132,7 @@ public static function input(string $buffer, TcpConnection $connection): int
// The pattern uses case-insensitive modifier (~i) for ... | [
"src/Protocols/Http.php"
] | [] | true | ||
walkor/workerman | 1,143 | issue_to_patch | Refactor cookie mapping and improve JSON content type check in Reques… | …t class | a5c792927e3651b54db002a5b12c63754223d069 | 12af9369b7e85c6b82d96e340f588473b8d05272 | diff --git a/src/Protocols/Http/Request.php b/src/Protocols/Http/Request.php
index 6ee77cf25..0ed40678a 100644
--- a/src/Protocols/Http/Request.php
+++ b/src/Protocols/Http/Request.php
@@ -214,7 +214,7 @@ public function cookie(?string $name = null, mixed $default = null): mixed
{
if (!isset($this->data['... | [
"src/Protocols/Http/Request.php"
] | [] | true | ||
walkor/workerman | 1,138 | issue_to_patch | Refactor Websocket class: simplify input, encode, decode, inflate, an… | …d deflate methods; remove redundant comments and improve readability | 6ecda94609c40ade0f1e548535d24d8e09e67409 | f957bd0b7f66ca5d2c27679bab8743e5953d86f3 | diff --git a/src/Protocols/Websocket.php b/src/Protocols/Websocket.php
index 5b8097498..c888256a6 100644
--- a/src/Protocols/Websocket.php
+++ b/src/Protocols/Websocket.php
@@ -75,17 +75,10 @@ class Websocket
*/
const BINARY_TYPE_ARRAYBUFFER_DEFLATE = "\xc2";
- /**
- * Check the integrity of the pac... | [
"src/Protocols/Websocket.php",
"src/Protocols/Ws.php"
] | [
{
"comment": "根据 HTTP 规范，Header 不区分大小写。如果开发者在回调中注入了小写的 ['server: custom-api']，str_starts_with 会判定失败，导致底层错误地再次追加一条 Server: workerman 响应头。\n\n修改建议：应改回 stripos 保持大小写不敏感的判断。",
"path": "src/Protocols/Websocket.php",
"hunk": "@@ -421,116 +373,112 @@ protected static function deflate(TcpConnection $connection,... | true | ||
walkor/workerman | 1,138 | comment_to_fix | Refactor Websocket class: simplify input, encode, decode, inflate, an… | 根据 HTTP 规范，Header 不区分大小写。如果开发者在回调中注入了小写的 ['server: custom-api']，str_starts_with 会判定失败，导致底层错误地再次追加一条 Server: workerman 响应头。
修改建议：应改回 stripos 保持大小写不敏感的判断。 | 6ecda94609c40ade0f1e548535d24d8e09e67409 | f957bd0b7f66ca5d2c27679bab8743e5953d86f3 | diff --git a/src/Protocols/Websocket.php b/src/Protocols/Websocket.php
index 5b8097498..c888256a6 100644
--- a/src/Protocols/Websocket.php
+++ b/src/Protocols/Websocket.php
@@ -75,17 +75,10 @@ class Websocket
*/
const BINARY_TYPE_ARRAYBUFFER_DEFLATE = "\xc2";
- /**
- * Check the integrity of the pac... | [
"src/Protocols/Websocket.php"
] | [
{
"comment": "根据 HTTP 规范，Header 不区分大小写。如果开发者在回调中注入了小写的 ['server: custom-api']，str_starts_with 会判定失败，导致底层错误地再次追加一条 Server: workerman 响应头。\n\n修改建议：应改回 stripos 保持大小写不敏感的判断。",
"path": "src/Protocols/Websocket.php",
"hunk": "@@ -421,116 +373,112 @@ protected static function deflate(TcpConnection $connection,... | true | ||
walkor/workerman | 1,141 | issue_to_patch | Refactor ZLIB initialization options for inflate and deflate methods | Use the same constant to avoid problems with different initialization.
First simplify the code, for easier optimize it later. | a9737d62c5f9f4e92b1fd54088cf901e9d5faa62 | a2f9317a6a9ca60cbd5b32d31e9d9b13ce18b062 | diff --git a/src/Protocols/Websocket.php b/src/Protocols/Websocket.php
index ab9d1692a..77ea414fb 100644
--- a/src/Protocols/Websocket.php
+++ b/src/Protocols/Websocket.php
@@ -75,6 +75,16 @@ class Websocket
*/
const BINARY_TYPE_ARRAYBUFFER_DEFLATE = "\xc2";
+ private const ZLIB_INIT_OPTIONS = [
+ ... | [
"src/Protocols/Websocket.php"
] | [] | true | ||
walkor/workerman | 1,140 | issue_to_patch | Update workflow dependencies | Fix warning in workflow:
`
Warning: Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, nick-fields/retry@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner... | 6ecda94609c40ade0f1e548535d24d8e09e67409 | 2986d908636f9ad1cad28de77b16837eb55f45dd | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 2217be681..7d04c284b 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -25,7 +25,7 @@ jobs:
steps:
- name: Checkout code
- uses: actions/checkout@v4
+ uses: actions/checkout@v6
... | [
".github/workflows/test.yml"
] | [] | true | ||
walkor/workerman | 1,134 | issue_to_patch | Simplify encode and decode function in WS using match expression | 5c24d7dfa907e8617fc46da13387724520e0dffe | 78eb10b5bc9a7fd93284d3e157bb07828f57ef04 | diff --git a/src/Protocols/Ws.php b/src/Protocols/Ws.php
index 3f1252ff4..37a4f53ca 100644
--- a/src/Protocols/Ws.php
+++ b/src/Protocols/Ws.php
@@ -248,13 +248,11 @@ public static function encode(string $payload, AsyncTcpConnection $connection):
$maskKey = "\x00\x00\x00\x00";
$length = strlen($payloa... | [
"src/Protocols/Ws.php"
] | [] | true | |||
walkor/workerman | 1,098 | issue_to_patch | Update phpstan and guzzle in composer | Update dependencies.
Still Mockery have deprecated messages with PHP 8.4 and 8.5, but work.
When is updated, we will change it. | 5c24d7dfa907e8617fc46da13387724520e0dffe | 48cd83aea9b8e8780178820a208597a5e5f887d0 | diff --git a/composer.json b/composer.json
index 0787975b0..d7254d26a 100644
--- a/composer.json
+++ b/composer.json
@@ -50,8 +50,8 @@
"require-dev": {
"pestphp/pest": "^2.36 || ^3 || ^4",
"mockery/mockery": "^1.6",
- "guzzlehttp/guzzle": "^7.0",
- "phpstan/phpstan": "2.1.x-dev"
+ ... | [
"composer.json",
"phpstan.neon.dist"
] | [] | true | ||
walkor/workerman | 1,135 | issue_to_patch | fix(http): sync context sid/session after sessionRegenerateId() | ## 问题
调用 `sessionRegenerateId()` 时，虽然已通过 `setSidCookie()` 写入新的会话 ID，并构造了带迁移数据的 `Session($newSid)`，但 **`$this->context['sid']` 与 `$this->context['session']` 未更新**。
由于：
- `session()` 使用 `$this->context['session'] ??= new Session($this->sessionId())`，会长期缓存首次创建的 `Session` 实例；
- `sessionId()` 在 `context['sid']` 已存在时直接返回... | 5c24d7dfa907e8617fc46da13387724520e0dffe | 38fd158cf904fc0f9849e5fc457306762551f77c | diff --git a/src/Protocols/Http/Request.php b/src/Protocols/Http/Request.php
index 73de748b9..cf1a3b078 100644
--- a/src/Protocols/Http/Request.php
+++ b/src/Protocols/Http/Request.php
@@ -388,6 +388,8 @@ public function sessionRegenerateId(bool $deleteOldSession = false): string
$cookieParams = Session::getCo... | [
"src/Protocols/Http/Request.php"
] | [] | true | ||
walkor/workerman | 1,130 | issue_to_patch | Add PHP 8.5 to CI workflow matrix | PHP 8.5 released 20 Nov 2025.
https://www.php.net/releases/8.5/es.php
~EDIT: we need to update and check the tests~
| d36d8ebd74d6c057038f252b979bbdfda84ce852 | 3af6d677262d6dcb67f62694d9eea32d9aa07cb3 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index ca86088cf..a80c080f2 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -12,13 +12,13 @@ on:
jobs:
linux_tests:
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-24.04
strategy:
fail-fast: false
... | [
".github/workflows/test.yml",
"composer.json",
"tests/Pest.php"
] | [] | diff --git a/tests/Pest.php b/tests/Pest.php
index f2a84413a..066648232 100644
--- a/tests/Pest.php
+++ b/tests/Pest.php
@@ -11,6 +11,7 @@
|
*/
+uses(\Tests\TestCase::class);
// uses(Tests\TestCase::class)->in('Feature');
/*
| true | |
walkor/workerman | 1,129 | issue_to_patch | fix: Cannot represent a stream of type phar stream as a select()able … | 修复#1128 的bug | d36d8ebd74d6c057038f252b979bbdfda84ce852 | 60f59224c0027d5e9793204206b97582271208e8 | diff --git a/src/Worker.php b/src/Worker.php
index 54db49d85..a80842a36 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -1607,7 +1607,7 @@ protected static function forkWorkersForWindows(): void
// Compatibility with the bug in Swow where the first request on Windows fails to trigger stream_select.
... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,127 | issue_to_patch | fix: eventloop | 相关问题：https://www.workerman.net/q/14571
在并发的时候执行了销毁操作后再重连eventloop可能为null。
```
#0 phar:///opt/webman.phar/vendor/workerman/workerman/src/Connection/AsyncTcpConnection.php(230): Workerman\\Connection\\AsyncTcpConnection->connect()
#1 phar:///opt/webman.phar/vendor/workerman/http-client/src/Client.php(252): Workerman\... | 1388b101a6055929922d08019fedbfe779c185d4 | e0149a6093679d16defda4138af8f7a61c9cf260 | diff --git a/src/Connection/AsyncTcpConnection.php b/src/Connection/AsyncTcpConnection.php
index ae50a27f6..adae2678f 100644
--- a/src/Connection/AsyncTcpConnection.php
+++ b/src/Connection/AsyncTcpConnection.php
@@ -242,9 +242,7 @@ public function connect(): void
return;
}
- if (!$this->... | [
"src/Connection/AsyncTcpConnection.php",
"src/Connection/AsyncUdpConnection.php"
] | [
{
"comment": "Use Null coalescing assignment operator\r\nFrom PHP/7.4\r\n\r\n`$this->eventLoop ??= Worker:getEventLoop();`",
"path": "src/Connection/AsyncTcpConnection.php",
"hunk": "@@ -243,7 +243,7 @@ public function connect(): void\n }\n \n if (!$this->eventLoop) {",
"resolving_sh... | true | ||
walkor/workerman | 1,127 | comment_to_fix | fix: eventloop | Use Null coalescing assignment operator
From PHP/7.4
`$this->eventLoop ??= Worker:getEventLoop();` | 1388b101a6055929922d08019fedbfe779c185d4 | e0149a6093679d16defda4138af8f7a61c9cf260 | diff --git a/src/Connection/AsyncTcpConnection.php b/src/Connection/AsyncTcpConnection.php
index ae50a27f6..adae2678f 100644
--- a/src/Connection/AsyncTcpConnection.php
+++ b/src/Connection/AsyncTcpConnection.php
@@ -242,9 +242,7 @@ public function connect(): void
return;
}
- if (!$this->... | [
"src/Connection/AsyncTcpConnection.php"
] | [
{
"comment": "Use Null coalescing assignment operator\r\nFrom PHP/7.4\r\n\r\n`$this->eventLoop ??= Worker:getEventLoop();`",
"path": "src/Connection/AsyncTcpConnection.php",
"hunk": "@@ -243,7 +243,7 @@ public function connect(): void\n }\n \n if (!$this->eventLoop) {",
"resolving_sh... | true | ||
walkor/workerman | 1,127 | comment_to_fix | fix: eventloop | The same here | 1388b101a6055929922d08019fedbfe779c185d4 | e0149a6093679d16defda4138af8f7a61c9cf260 | diff --git a/src/Connection/AsyncTcpConnection.php b/src/Connection/AsyncTcpConnection.php
index ae50a27f6..adae2678f 100644
--- a/src/Connection/AsyncTcpConnection.php
+++ b/src/Connection/AsyncTcpConnection.php
@@ -242,9 +242,7 @@ public function connect(): void
return;
}
- if (!$this->... | [
"src/Connection/AsyncTcpConnection.php"
] | [
{
"comment": "The same here",
"path": "src/Connection/AsyncTcpConnection.php",
"hunk": "@@ -287,6 +287,12 @@ public function connect(): void\n }\n return;\n }\n+\n+ // @phpstan-ignore-next-line\n+ if (!$this->eventLoop) {",
"resolving_sha": "e0149a609367... | true | ||
walkor/workerman | 1,127 | comment_to_fix | fix: eventloop | And here. | 1388b101a6055929922d08019fedbfe779c185d4 | e0149a6093679d16defda4138af8f7a61c9cf260 | diff --git a/src/Connection/AsyncUdpConnection.php b/src/Connection/AsyncUdpConnection.php
index d9bfa9fa3..63fd4fa77 100644
--- a/src/Connection/AsyncUdpConnection.php
+++ b/src/Connection/AsyncUdpConnection.php
@@ -182,9 +182,9 @@ public function connect(): void
if ($this->connected === true) {
... | [
"src/Connection/AsyncUdpConnection.php"
] | [
{
"comment": "And here.",
"path": "src/Connection/AsyncUdpConnection.php",
"hunk": "@@ -182,9 +182,11 @@ public function connect(): void\n if ($this->connected === true) {\n return;\n }\n+\n if (!$this->eventLoop) {",
"resolving_sha": "e0149a6093679d16defda4138af8... | true | ||
walkor/workerman | 1,121 | issue_to_patch | add igbinary serializer handler support | add igbinary serializer handler support, currently the project session serializer handler only support php serializer, add igbinary serializer support | 203c7f6651f958794ce495d42d9a57a211974949 | 098e2573afb56b8ea169bc00b6ea896947c807a8 | diff --git a/src/Protocols/Http/Session.php b/src/Protocols/Http/Session.php
index 7bdd53371..a0fc3fb37 100644
--- a/src/Protocols/Http/Session.php
+++ b/src/Protocols/Http/Session.php
@@ -25,11 +25,8 @@
use function ini_get;
use function is_array;
use function is_scalar;
-use function preg_match;
use function rand... | [
"src/Protocols/Http/Session.php"
] | [] | true | ||
walkor/workerman | 1,122 | issue_to_patch | fix custom protocols in Worker::$logFile | skip invalid directory creation and permission changes for Worker::$logFile when custom protocol handlers are used (like php://stdout) | 203c7f6651f958794ce495d42d9a57a211974949 | e2d201cb26533838b060229f6c20132c72dfc112 | diff --git a/src/Worker.php b/src/Worker.php
index 3683d7871..37971926a 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -750,7 +750,7 @@ protected static function init(): void
// Log file.
static::$logFile = static::$logFile ?: sprintf('%s/workerman.log', $startFileDir);
- if (static::$lo... | [
"src/Worker.php"
] | [
{
"comment": "Please use `str_contains()`",
"path": "src/Worker.php",
"hunk": "@@ -750,7 +750,7 @@ protected static function init(): void\n // Log file.\n static::$logFile = static::$logFile ?: sprintf('%s/workerman.log', $startFileDir);\n \n- if (static::$logFile !== '/dev/null' ... | true | ||
walkor/workerman | 1,119 | issue_to_patch | [BUG] Http 在通过 response->file() 传输 mp4 大文件时，没有走标准的 range 流
问题复现方式：
使用 webman 框架，将一个较大的视频文件（比如 50M），放到 public 目录下，然后启动服务，访问该文件的 url
问题点：
设置 network 禁用缓存，网速无限制时：可以看出是获取到全部文件后才能后续的流式播放
<img width="1563" height="268" alt="Image" src="https://github.com/user-attachments/assets/12312673-09d7-42aa-ac38-65e09fa5951b" />
... | Support request Range | fix: #1118 | bb8bccd7a1d1879d7d744ada7cd1223c2eda9d23 | 98dc7a630b3dbaf0b99fa920f9052768f8341787 | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 1c58b3379..40ebc70e2 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -163,6 +163,7 @@ public static function decode(string $buffer, TcpConnection $connection): Reques
*/
public static function encode(mixed $response, TcpCo... | [
"src/Protocols/Http.php"
] | [
{
"comment": "@krissss \r\n代码加到这里会导致不管是否是文件响应，全部都获取一遍header，这里造成性能浪费。\r\nrange获取应该放到 if (isset($response->file)) { 里",
"path": "src/Protocols/Http.php",
"hunk": "@@ -163,8 +163,17 @@ public static function decode(string $buffer, TcpConnection $connection): Reques\n */\n public static function e... | true | |
walkor/workerman | 1,119 | comment_to_fix | Support request Range | @krissss
代码加到这里会导致不管是否是文件响应，全部都获取一遍header，这里造成性能浪费。
range获取应该放到 if (isset($response->file)) { 里 | bb8bccd7a1d1879d7d744ada7cd1223c2eda9d23 | 98dc7a630b3dbaf0b99fa920f9052768f8341787 | diff --git a/src/Protocols/Http.php b/src/Protocols/Http.php
index 1c58b3379..40ebc70e2 100644
--- a/src/Protocols/Http.php
+++ b/src/Protocols/Http.php
@@ -163,6 +163,7 @@ public static function decode(string $buffer, TcpConnection $connection): Reques
*/
public static function encode(mixed $response, TcpCo... | [
"src/Protocols/Http.php"
] | [
{
"comment": "@krissss \r\n代码加到这里会导致不管是否是文件响应，全部都获取一遍header，这里造成性能浪费。\r\nrange获取应该放到 if (isset($response->file)) { 里",
"path": "src/Protocols/Http.php",
"hunk": "@@ -163,8 +163,17 @@ public static function decode(string $buffer, TcpConnection $connection): Reques\n */\n public static function e... | true | ||
walkor/workerman | 1,063 | issue_to_patch | Remove dynamic calls in Worker.php | 动态调用对IDE不友好，而且也不利于我们review代码。
这个PR对Worker.php中的动态调用部分进行了修改，以减少潜在的动态调用问题。 | 3bd75278c30a064e358b3026e69742eae2d3476f | 263471caf56587d92b7f80ba686b848d1adbab87 | diff --git a/Worker.php b/Worker.php
index 5f38b69c1..6479591f7 100644
--- a/Worker.php
+++ b/Worker.php
@@ -540,6 +540,8 @@ class Worker
*/
protected static $_outputDecorated = null;
+ protected static $liveVersionLength = null;
+
/**
* Run all worker instances.
*
@@ -689,10 +691,8 @@ ... | [
"Worker.php"
] | [] | true | ||
walkor/workerman | 1,117 | issue_to_patch | 修复 Windows 环境下 socket 绑定失败问题（Swow1.6.0） | ```
Warning: [Warning in main] stream_socket_server(): Unable to connect to tcp://0.0.0.0:8792 (Socket bind failed, reason: Operation not supported on socket)
Stack trace:
#0 E:\workerman\api-v3\vendor\workerman\workerman\src\Worker.php(2402): stream_socket_server('tcp://0.0.0.0:8...', 0, '', 12, Resource id #211)
... | 36700b89c749416d5fad384581b027a516fdff54 | 3c543a36d7e165c1fd645ba25d7640603adccaf8 | diff --git a/src/Connection/TcpConnection.php b/src/Connection/TcpConnection.php
index 3f2b901f0..9e82dfb22 100644
--- a/src/Connection/TcpConnection.php
+++ b/src/Connection/TcpConnection.php
@@ -886,19 +886,10 @@ public function doSslHandshake($socket): bool|int
*/
public function pipe(self $dest): void
... | [
"src/Connection/TcpConnection.php",
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,105 | issue_to_patch | Implemented max log file size with truncation. | Our projects use file logging and atm logs have grown to ~18GB, so implemented file max size with half way truncation. | 371f3a5decb28f1bd3464ae26d47ea1a4cf0a3c5 | 85405c6d70d82b5810bf8479064f8465324b613d | diff --git a/src/Worker.php b/src/Worker.php
index 3c694aa0f..dbef4b2c2 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -322,6 +322,13 @@ class Worker
*/
public static string $logFile = '';
+ /**
+ * Log file maximum size in bytes, default 10M.
+ *
+ * @var int
+ */
+ public stati... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,115 | issue_to_patch | [fix] worker with id 0 looses pid | found in #1114
When scale down worker count and child is killed `getId` method returns false. `$_idMap[false] = 0` is called and replaces `$_idMap[0]` value with 0 | bbc4cc36635b7aa8c2586f65b981d4bf399e6733 | 520ed2c29024998c9c45abb37417847cc9f860a5 | diff --git a/src/Worker.php b/src/Worker.php
index c8e0304f2..b8b780860 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -1884,7 +1884,9 @@ protected static function monitorWorkersForLinux(): void
// Mark id is available.
$id = static::getId($workerId, $pid);
- ... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,113 | issue_to_patch | 修复swow协程的错误 | 8dadbe74a0a563aa2506b05bc950e103dde87e75 | 55fb36ad68f9712448166cb3da01a5feb92c01c0 | diff --git a/src/Connection/TcpConnection.php b/src/Connection/TcpConnection.php
index b66f617a1..3f2b901f0 100644
--- a/src/Connection/TcpConnection.php
+++ b/src/Connection/TcpConnection.php
@@ -661,7 +661,7 @@ public function baseRead($socket, bool $checkEof = true): void
// Check connection closed.
... | [
"src/Connection/TcpConnection.php",
"src/Events/Swow.php"
] | [] | true | |||
walkor/workerman | 1,110 | issue_to_patch | Change switch() for match() | bbaa2180cd8c4ac18032324ea2b832ede4fbe085 | e452e220cad087d16c92095eb863d06df1d8b922 | diff --git a/src/Worker.php b/src/Worker.php
index e92816231..ee9df1400 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -2573,15 +2573,13 @@ public function run(): void
}
};
- switch (Worker::$eventLoopClass) {
- case Swoole::class:
- case Swow::class:
- ... | [
"src/Worker.php"
] | [] | true | |||
walkor/workerman | 1,108 | issue_to_patch | Separate mime types | Also fix non-standard font type (MIME) Description for woff fonts and add woff2.
> Since February 2017, the proper MIME type is font/woff for WOFF 1.0 and font/woff2 for WOFF 2.0.
https://en.wikipedia.org/wiki/Web_Open_Font_Format
Actual mime-types in nginx:
https://github.com/nginx/nginx/blob/master/conf/mim... | bb55453e8d4b454feddfc9a2b249f42a9d0099da | 6cb2c9aa344951787a115c8d425cb6aa16b69a04 | diff --git a/src/Protocols/Http/Response.php b/src/Protocols/Http/Response.php
index 154b7e589..e3fb10874 100644
--- a/src/Protocols/Http/Response.php
+++ b/src/Protocols/Http/Response.php
@@ -60,23 +60,22 @@ class Response implements Stringable
* @var array
*/
protected static array $mimeTypeMap = [
+... | [
"src/Protocols/Http/Response.php"
] | [] | true | ||
walkor/workerman | 1,107 | issue_to_patch | refactor: Replace dynamic MIME type loading with static array | 将 MIME 类型映射从动态文件加载改为静态数组定义，带来以下好处：
- 消除运行时文件 I/O 操作，提升启动性能
- 减少文件系统依赖，提高代码可移植性
- 简化代码维护，MIME 类型映射直接可见
- 避免文件读取失败的潜在风险
- 减少不必要的函数导入
删除了 mime.types 文件和 initMimeTypeMap() 方法，将所有 MIME 类型 映射直接定义在 $mimeTypeMap 静态数组中。
🤖 Generated with [Claude Code](https://claude.ai/code) | 371f3a5decb28f1bd3464ae26d47ea1a4cf0a3c5 | fd70b5b4e3b3e30d228abd0eefe25e6b95299a4d | diff --git a/src/Protocols/Http/Response.php b/src/Protocols/Http/Response.php
index a54c18433..b6c918feb 100644
--- a/src/Protocols/Http/Response.php
+++ b/src/Protocols/Http/Response.php
@@ -19,19 +19,13 @@
use Stringable;
use function array_merge_recursive;
-use function explode;
-use function file;
use functio... | [
"src/Protocols/Http/Response.php",
"src/Protocols/Http/mime.types"
] | [] | true | ||
walkor/workerman | 1,104 | issue_to_patch | Destroy the context in onWorkerStart | 参考：https://www.workerman.net/q/14152 | c61641d9ce14a980bce287ec014b1d17a32cb8fa | 2ed1e0bf4f36a681c527a277e440d3a984896f0e | diff --git a/src/Worker.php b/src/Worker.php
index 33ee28959..9103ed36c 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -26,6 +26,7 @@
use Workerman\Connection\TcpConnection;
use Workerman\Connection\UdpConnection;
use Workerman\Coroutine;
+use Workerman\Coroutine\Context;
use Workerman\Events\Event;
use Worke... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,103 | issue_to_patch | Fix typo change Jit for JIT [ci skip] | The correct acronim is JIT.
And it's a very good addition this information.
In the Techempower benchmark we are not using JIT in all Adapterman permutations. | e9cd1d381d633e02adedb1c2d5ee7204c089821b | f2ecd69b799560c290ccef9d247795046f255a98 | diff --git a/src/Worker.php b/src/Worker.php
index e2d5f20ba..edfea4137 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -1009,7 +1009,7 @@ protected static function getVersionLine(): string
//Show version
$jitStatus = function_exists('opcache_get_status') && (opcache_get_status()['jit']['on'] ?? f... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,102 | issue_to_patch | feature/improve_ws_attribute | 1. TcpConnection add properties websocketOrigin & websocketClientProtocol
2. Protocols/Ws::onConnect init websocketOrigin & websocketClientProtocol
3. Protocols/Websocket::input init websocketOrigin & websocketClientProtocol | 2bba50959868a3bf70c621ccfdd3539562d97bf6 | 9bc8254af7a41b5ae27ad0d991ee1d2c62f5a61a | diff --git a/src/Connection/TcpConnection.php b/src/Connection/TcpConnection.php
index aef42ac91..b66f617a1 100644
--- a/src/Connection/TcpConnection.php
+++ b/src/Connection/TcpConnection.php
@@ -61,6 +61,8 @@
/**
* TcpConnection.
* @property string $websocketType
+ * @property string|null $websocketClientProtoco... | [
"src/Connection/TcpConnection.php",
"src/Protocols/Websocket.php",
"src/Protocols/Ws.php"
] | [] | true | ||
walkor/workerman | 1,100 | issue_to_patch | Improved onWebSocketClose with response message. | WebSocket server can send back status code with message indicating why the close was done. Added new parameter to handle the case. | 72cafa19e488896abd2576ea67b3b1af1abf71c0 | d80eb0d92f34e7b51f4d9a4f32b6be34ff2064b8 | diff --git a/src/Connection/TcpConnection.php b/src/Connection/TcpConnection.php
index 8ccc869f0..aef42ac91 100644
--- a/src/Connection/TcpConnection.php
+++ b/src/Connection/TcpConnection.php
@@ -133,19 +133,26 @@ class TcpConnection extends ConnectionInterface implements JsonSerializable
public $onConnect = null... | [
"src/Connection/TcpConnection.php",
"src/Protocols/Ws.php"
] | [] | true | ||
walkor/workerman | 1,096 | issue_to_patch | Remove gc_collect_cycles() and gc_mem_caches() from writeStatisticsToStatusFile() | Title: Remove gc_collect_cycles() and gc_mem_caches() from writeStatisticsToStatusFile()
Description:
🛠️ What does this PR do?
This PR removes the calls to gc_collect_cycles() and gc_mem_caches() in the writeStatisticsToStatusFile() method.
📌 Why is this change needed?
When using pcntl_fork(), PHP reli... | 5a4e59e05bdc865a782d27ec85852dfb43a8fc38 | 43695c4b1f5980a1a5e4b46d6547d23c0993bce0 | diff --git a/src/Worker.php b/src/Worker.php
index c3e4957da..e92816231 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -2180,9 +2180,6 @@ protected static function writeStatisticsToStatusFile(): void
return;
}
- // For child processes.
- gc_collect_cycles();
- gc_mem_ca... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,092 | issue_to_patch | Add issue template | 很多时候用户创建 `issue` 并没有提供明确的上下文信息，很难帮到他们 | 5ce17bc71dfdad0e9eba8cd658342da793d2f581 | a0cd3d479629f8ef8d6b3947772c5f6ef6f1f34b | diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
new file mode 100644
index 000000000..3edede23f
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -0,0 +1,27 @@
+---
+name: Bug Report
+about: 报告一个 bug
+title: "[BUG]"
+labels: bug
+---
+
+Please answer these questions be... | [
".github/ISSUE_TEMPLATE/bug_report.md",
".github/ISSUE_TEMPLATE/config.yml"
] | [] | true | ||
walkor/workerman | 1,090 | issue_to_patch | Remove HHVM compatibility code | Since HHVM no longer supports PHP and the dependencies have been updated. | 69d3c9d3193c052872f2e2a5161d0a7b4b75e0bf | 9e625db7d11732ff78b73afd35d3256c888bbf56 | diff --git a/src/Connection/AsyncTcpConnection.php b/src/Connection/AsyncTcpConnection.php
index 787b7aea8..0b9cc89d9 100644
--- a/src/Connection/AsyncTcpConnection.php
+++ b/src/Connection/AsyncTcpConnection.php
@@ -381,10 +381,7 @@ public function checkConnection(): void
}
// Nonblocking.
... | [
"src/Connection/AsyncTcpConnection.php",
"src/Connection/TcpConnection.php"
] | [] | true | ||
walkor/workerman | 1,088 | issue_to_patch | 解析的时候可能会报错substr(): Argument #1 ($string) must be of type string, bool given | ea829e3bea1a4444edda0880e9a67af378183cad | f41eca75ab02d4df6dc8b92b66e72d4b527bac25 | diff --git a/src/Protocols/Http/Request.php b/src/Protocols/Http/Request.php
index b8c3049aa..cbb0dc358 100644
--- a/src/Protocols/Http/Request.php
+++ b/src/Protocols/Http/Request.php
@@ -419,8 +419,9 @@ protected function parseHeadFirstLine(): void
protected function parseProtocolVersion(): void
{
... | [
"src/Protocols/Http/Request.php"
] | [] | true | |||
walkor/workerman | 1,086 | issue_to_patch | 检测是否为null | 在进程结束的时候可能会出现"Call to a member function offReadable() on null"错误 | 1e7bb17395deb69fdd5e397dff761b93c29dd5b7 | 0549bd85dea1911eec7e9758a0266cd7d24b4c36 | diff --git a/src/Connection/TcpConnection.php b/src/Connection/TcpConnection.php
index e3536fd20..71def175c 100644
--- a/src/Connection/TcpConnection.php
+++ b/src/Connection/TcpConnection.php
@@ -610,7 +610,9 @@ public function getRecvBufferQueueSize(): int
*/
public function pauseRecv(): void
{
- ... | [
"src/Connection/TcpConnection.php"
] | [] | true | ||
walkor/workerman | 1,070 | issue_to_patch | Optimizations Worker.php | Use Null coalescing assignment operator (PHP 7.4)
First check if `$logFile !== '/dev/null'` and later check if `is_file()`, so we use one stat less if not necessary and it's faster.
PD: perhaps it's better if the default is` $logFile = '/dev/null'`
EDIT: I see that you changed `??=` to `empty()` in Commit 43f9... | b103862cd74ae21816c1fb442dd65db3f2c3aefe | 8c85f4da3cfadcd7f71a582105330ded5e06c67d | diff --git a/src/Worker.php b/src/Worker.php
index 9ee595440..7c542b6e5 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -713,17 +713,17 @@ protected static function init(): void
$startFilePrefix = hash('xxh64', static::$startFile);
// Pid file.
- static::$pidFile = empty(static::$pidFile)... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,069 | issue_to_patch | Update Worker.php fix nullable for PHP8.4 | In `__construct()`
Fixed !!
PD: I think that the `_construct()` need to be at the beginning of the class !! | 0d75a171538fde32ab28859710c3c37ecbc7b520 | 91c4207e14a840876b08708eebb3c9954722715b | diff --git a/src/Worker.php b/src/Worker.php
index 0485db7a0..f145d9316 100644
--- a/src/Worker.php
+++ b/src/Worker.php
@@ -2281,7 +2281,7 @@ public static function safeEcho(string $msg, bool $decorated = false): void
* @param string|null $socketName
* @param array $socketContext
*/
- public funct... | [
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,065 | issue_to_patch | Update tests version libs to fix warnings and deprecations | v1.6.x work OK with PHP 8.4 (without deprecations)
And add ansi color output to composer in the workflow.
Updated workflow actions. | c061242779b25b0d75c529f3577dc8e5d5120daa | 9d53a73aa107d07db17f3ddeb85cb1bccbe56469 | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 0ca57a9a8..ca86088cf 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -25,7 +25,7 @@ jobs:
steps:
- name: Checkout code
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
... | [
".github/workflows/test.yml",
"composer.json"
] | [] | true | ||
walkor/workerman | 1,051 | issue_to_patch | Add PHP 8.4 nightly to tests | So we can find problems with time.
PHP 8.4 Timetable
https://wiki.php.net/todo/php84
WIP | 9e4ecd97232f4b7c081321d44265d123965526d9 | 103239825920d6e5456aeeb694979e780b99dc6d | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 6a310546b..0ca57a9a8 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
- php: ["8.1", "8.2... | [
".github/workflows/test.yml",
"src/Protocols/Http/Request.php",
"src/Protocols/Http/Response.php",
"tests/Pest.php"
] | [] | diff --git a/tests/Pest.php b/tests/Pest.php
index 7db6ab1bc..f2a84413a 100644
--- a/tests/Pest.php
+++ b/tests/Pest.php
@@ -42,7 +42,7 @@ function something()
// ..
}
-function testWithConnectionClose(Closure $closure, string $dataContains = null, $connectionClass = TcpConnection::class): void
+function testWi... | true | |
walkor/workerman | 1,061 | issue_to_patch | Fixed onWebsocketConnected isn't called with SSL connection | `send` function returns null with SSL connection and callback isn't called. | 43f9aadcfc8ed42cf73ea3cf74dbbb8b3242be9e | a3bf4be3421d8deda4cd0123692b98dd0a2f2989 | diff --git a/src/Protocols/Websocket.php b/src/Protocols/Websocket.php
index bf31ad46e..89b44d47f 100644
--- a/src/Protocols/Websocket.php
+++ b/src/Protocols/Websocket.php
@@ -492,13 +492,13 @@ public static function dealHandshake(string $buffer, TcpConnection $connection):
}
$handshakeMessag... | [
"src/Protocols/Websocket.php"
] | [] | true | ||
walkor/workerman | 1,060 | issue_to_patch | Fixed cookie parsing, parse_str replaces urlencoded characters. | When cookie contains base64 string with + signs, `parse_str` replaces with spaces and value becomes invalid. | d36eed3499c03303177b8004a839e8acbd8928c1 | 9a95978f7a7f799791671adf048b0de136ab4e9e | diff --git a/src/Protocols/Http/Request.php b/src/Protocols/Http/Request.php
index fd8c41c29..7cc3ab0de 100644
--- a/src/Protocols/Http/Request.php
+++ b/src/Protocols/Http/Request.php
@@ -222,8 +222,17 @@ public function setHeaders(array $headers): Request
public function cookie(string $name = null, mixed $defaul... | [
"src/Protocols/Http/Request.php"
] | [] | true | ||
walkor/workerman | 1,059 | issue_to_patch | fix: all coroutines must be canceled before Event::exit | 在webman的协程基建插件（ https://www.workerman.net/plugin/167 ）的测试中发现，使用channel、waitGroup组件或者被hook的系统函数如sleep进行处理业务时，在退出workerman时会发生`[FATAL ERROR]: all coroutines (count: N) are asleep - deadlock!`（其中的N是退出时的协程数量）等错误；
可能的错误还有：
- WARNING Channel::~Channel() (ERRNO 10003): channel is destroyed, 1 consumers will be discarded
- ... | 965a4cad25eaccbecc827b153d290b281de8e599 | eff0fa1c8b9ec236234053bfc0bf3f6e2152d4c0 | diff --git a/src/Events/Swoole.php b/src/Events/Swoole.php
index e703d14b5..e61c9b7f4 100644
--- a/src/Events/Swoole.php
+++ b/src/Events/Swoole.php
@@ -15,6 +15,7 @@
namespace Workerman\Events;
+use Swoole\Coroutine;
use Swoole\Event;
use Swoole\Process;
use Swoole\Timer;
@@ -211,6 +212,10 @@ public function r... | [
"src/Events/Swoole.php"
] | [] | true | ||
walkor/workerman | 1,055 | issue_to_patch | Implemented WebSocket connected callback. | Implemented connected callback to be able to send custom 3000-4999 status codes to the client. | 9e4ecd97232f4b7c081321d44265d123965526d9 | 515217652a0969f1b02526df44a19b69163097f7 | diff --git a/src/Connection/TcpConnection.php b/src/Connection/TcpConnection.php
index 35654099f..c76046b0d 100644
--- a/src/Connection/TcpConnection.php
+++ b/src/Connection/TcpConnection.php
@@ -110,12 +110,19 @@ class TcpConnection extends ConnectionInterface implements JsonSerializable
public $onConnect = null... | [
"src/Connection/TcpConnection.php",
"src/Protocols/Websocket.php",
"src/Worker.php"
] | [] | true | ||
walkor/workerman | 1,049 | issue_to_patch | Property promotion | Use Constructor Property Promotion added in PHP 8.0.
Only to the most obvious classes. | dae4bc70ebaf3f75e42ea8dc3e2ac378f22fbc0f | 1297111a60547b6c5ef355be6ce04a5b83a281e2 | diff --git a/src/Connection/UdpConnection.php b/src/Connection/UdpConnection.php
index 1a25af0af..dac804107 100644
--- a/src/Connection/UdpConnection.php
+++ b/src/Connection/UdpConnection.php
@@ -45,31 +45,15 @@ class UdpConnection extends ConnectionInterface implements JsonSerializable
*/
public string $tr... | [
"src/Connection/UdpConnection.php",
"src/Protocols/Http/Chunk.php",
"src/Protocols/Http/Request.php",
"src/Protocols/Http/ServerSentEvents.php"
] | [] | true | ||
wallabag/wallabag | 8,842 | issue_to_patch | wallabag:api:client:create — create an OAuth API client for an existing user from CLI
### Context
Wallabag already supports two of the three workflows around OAuth clients:
| Workflow | Supported |
|---|---|
| List / delete clients for the logged-in user | ✅ `/developer` (web UI) |
| Create user + default client in ... | Add wallabag:api-client:create console command | ## What
Adds a `wallabag:api-client:create` console command to create an OAuth API client for an existing user, closing the gap identified in #8841.
```sh
# Human-readable output (default)
bin/console wallabag:api-client:create alice
# Machine-readable for CI / provisioning
bin/console wallabag:api-client:create ali... | 6fd3c62d2636881f43541f30b60b57f1a8e8e59f | 51c67c352c69726ea58d66fa9bcefdd8c9916db0 | diff --git a/doc/content/admin/console_commands.md b/doc/content/admin/console_commands.md
index ad5b33bb76..a2216947bc 100644
--- a/doc/content/admin/console_commands.md
+++ b/doc/content/admin/console_commands.md
@@ -30,6 +30,7 @@ From Symfony:
Custom to wallabag:
+ - `wallabag:api-client:create`: Creates an OAu... | [
"doc/content/admin/console_commands.md",
"src/Command/CreateApiClientCommand.php",
"tests/integration/Command/CreateApiClientCommandTest.php"
] | [
{
"comment": "the option being named `--grant-types`, in plural, I would expect it to take multiple values directly, like a comma separated list.\nI find it a bit confusing to have it in plural, taking a single value and being repeatable.\nTo me, either keep it plural but make it non repeatable and accepts a co... | diff --git a/tests/integration/Command/CreateApiClientCommandTest.php b/tests/integration/Command/CreateApiClientCommandTest.php
new file mode 100644
index 0000000000..6f86f0d32a
--- /dev/null
+++ b/tests/integration/Command/CreateApiClientCommandTest.php
@@ -0,0 +1,159 @@
+<?php
+
+namespace Wallabag\Tests\Integration... | true |
wallabag/wallabag | 8,842 | comment_to_fix | Add wallabag:api-client:create console command | the option being named `--grant-types`, in plural, I would expect it to take multiple values directly, like a comma separated list.
I find it a bit confusing to have it in plural, taking a single value and being repeatable.
To me, either keep it plural but make it non repeatable and accepts a comma separated list, eith... | 6fd3c62d2636881f43541f30b60b57f1a8e8e59f | 51c67c352c69726ea58d66fa9bcefdd8c9916db0 | diff --git a/doc/content/admin/console_commands.md b/doc/content/admin/console_commands.md
index ad5b33bb76..a2216947bc 100644
--- a/doc/content/admin/console_commands.md
+++ b/doc/content/admin/console_commands.md
@@ -30,6 +30,7 @@ From Symfony:
Custom to wallabag:
+ - `wallabag:api-client:create`: Creates an OAu... | [
"doc/content/admin/console_commands.md"
] | [
{
"comment": "the option being named `--grant-types`, in plural, I would expect it to take multiple values directly, like a comma separated list.\nI find it a bit confusing to have it in plural, taking a single value and being repeatable.\nTo me, either keep it plural but make it non repeatable and accepts a co... | true | ||
wallabag/wallabag | 8,842 | comment_to_fix | Add wallabag:api-client:create console command | maybe be explicit naming this `--display-name`? to avoid any confusion with `username` | 6fd3c62d2636881f43541f30b60b57f1a8e8e59f | 51c67c352c69726ea58d66fa9bcefdd8c9916db0 | diff --git a/doc/content/admin/console_commands.md b/doc/content/admin/console_commands.md
index ad5b33bb76..a2216947bc 100644
--- a/doc/content/admin/console_commands.md
+++ b/doc/content/admin/console_commands.md
@@ -30,6 +30,7 @@ From Symfony:
Custom to wallabag:
+ - `wallabag:api-client:create`: Creates an OAu... | [
"doc/content/admin/console_commands.md"
] | [
{
"comment": "maybe be explicit naming this `--display-name`? to avoid any confusion with `username`",
"path": "doc/content/admin/console_commands.md",
"hunk": "@@ -42,6 +43,46 @@ Custom to wallabag:\n - `wallabag:user:show`: Shows the details for a user.\n - `wallabag:user:list`: Lists all existing u... | true | ||
wallabag/wallabag | 8,842 | comment_to_fix | Add wallabag:api-client:create console command | I think you need to validate the grant types values to be from the 4 allowed one | 6fd3c62d2636881f43541f30b60b57f1a8e8e59f | 51c67c352c69726ea58d66fa9bcefdd8c9916db0 | diff --git a/src/Command/CreateApiClientCommand.php b/src/Command/CreateApiClientCommand.php
new file mode 100644
index 0000000000..ccd0262a29
--- /dev/null
+++ b/src/Command/CreateApiClientCommand.php
@@ -0,0 +1,124 @@
+<?php
+
+namespace Wallabag\Command;
+
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\... | [
"src/Command/CreateApiClientCommand.php"
] | [
{
"comment": "I think you need to validate the grant types values to be from the 4 allowed one",
"path": "src/Command/CreateApiClientCommand.php",
"hunk": "@@ -0,0 +1,111 @@\n+<?php\n+\n+namespace Wallabag\\Command;\n+\n+use Doctrine\\ORM\\EntityManagerInterface;\n+use Doctrine\\ORM\\NoResultException;\... | true | ||
wallabag/wallabag | 8,842 | comment_to_fix | Add wallabag:api-client:create console command | wondering if this one should have double quotes around the value to be safe? | 6fd3c62d2636881f43541f30b60b57f1a8e8e59f | 51c67c352c69726ea58d66fa9bcefdd8c9916db0 | diff --git a/src/Command/CreateApiClientCommand.php b/src/Command/CreateApiClientCommand.php
new file mode 100644
index 0000000000..ccd0262a29
--- /dev/null
+++ b/src/Command/CreateApiClientCommand.php
@@ -0,0 +1,124 @@
+<?php
+
+namespace Wallabag\Command;
+
+use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\... | [
"src/Command/CreateApiClientCommand.php"
] | [
{
"comment": "wondering if this one should have double quotes around the value to be safe?",
"path": "src/Command/CreateApiClientCommand.php",
"hunk": "@@ -0,0 +1,111 @@\n+<?php\n+\n+namespace Wallabag\\Command;\n+\n+use Doctrine\\ORM\\EntityManagerInterface;\n+use Doctrine\\ORM\\NoResultException;\n+us... | true | ||
wallabag/wallabag | 8,842 | comment_to_fix | Add wallabag:api-client:create console command | deserves to add a test for wrong grant types | 6fd3c62d2636881f43541f30b60b57f1a8e8e59f | 51c67c352c69726ea58d66fa9bcefdd8c9916db0 | diff --git a/tests/integration/Command/CreateApiClientCommandTest.php b/tests/integration/Command/CreateApiClientCommandTest.php
new file mode 100644
index 0000000000..6f86f0d32a
--- /dev/null
+++ b/tests/integration/Command/CreateApiClientCommandTest.php
@@ -0,0 +1,159 @@
+<?php
+
+namespace Wallabag\Tests\Integration... | [
"tests/integration/Command/CreateApiClientCommandTest.php"
] | [
{
"comment": "deserves to add a test for wrong grant types",
"path": "tests/integration/Command/CreateApiClientCommandTest.php",
"hunk": "@@ -0,0 +1,142 @@\n+<?php\n+\n+namespace Wallabag\\Tests\\Integration\\Command;\n+\n+use Symfony\\Component\\Console\\Exception\\RuntimeException;\n+use Symfony\\Comp... | true | ||
wallabag/wallabag | 8,878 | issue_to_patch | Hide delete public link item if not necessary | | Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Documentation | no
| Translation | no
| CHANGELOG.md | no
| License | MIT
The link "Hide public link" is only display when a public link exists. | de844d5e297bc7713aaf1a271d8447da357f35d0 | d1224b8de9979d0d55bd0e1f08d38db55d7ba625 | diff --git a/src/Wallabag/CoreBundle/Resources/views/Entry/entry.html.twig b/src/Wallabag/CoreBundle/Resources/views/Entry/entry.html.twig
index 505f60ebaa..426a18be29 100644
--- a/src/Wallabag/CoreBundle/Resources/views/Entry/entry.html.twig
+++ b/src/Wallabag/CoreBundle/Resources/views/Entry/entry.html.twig
@@ -167,1... | [
"src/Wallabag/CoreBundle/Resources/views/Entry/entry.html.twig"
] | [] | true | ||
wallabag/wallabag | 8,872 | issue_to_patch | Translations update from Hosted Weblate | Translations update from [Hosted Weblate](https://hosted.weblate.org) for [wallabag/Messages (web)](https://hosted.weblate.org/projects/wallabag/messages/).
Current translation status:
 | d80b8d019a66c42561875db4678d726220359bc3 | 783f18ef77c2a7492acc286386c8e621ab4b7707 | diff --git a/translations/validators.nb.yml b/translations/validators.nb.yml
index 35271f5992..b0821316b6 100644
--- a/translations/validators.nb.yml
+++ b/translations/validators.nb.yml
@@ -5,3 +5,5 @@ validator:
item_per_page_too_high: Dette vil drepe programmet
feed_limit_too_high: Dette vil drepe programm... | [
"translations/validators.nb.yml"
] | [] | true | ||
wallabag/wallabag | 8,876 | issue_to_patch | build(deps): bump guzzlehttp/psr7 from 2.10.4 to 2.11.0 | Bumps [guzzlehttp/psr7](https://github.com/guzzle/psr7) from 2.10.4 to 2.11.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/guzzle/psr7/releases">guzzlehttp/psr7's releases</a>.</em></p>
<blockquote>
<h2>2.11.0</h2>
<h3>Changed</h3>
<ul>
<li>Changed <code>Utils::modifyReque... | 4504e3ce70aed40166fbcfe0ffed3389efd96742 | 4881d4ab2c0675d626bf3a7a0094dd891407331f | diff --git a/composer.lock b/composer.lock
index 99df286944..a675d06411 100644
--- a/composer.lock
+++ b/composer.lock
@@ -2840,23 +2840,25 @@
},
{
"name": "guzzlehttp/psr7",
- "version": "2.10.4",
+ "version": "2.11.0",
"source": {
"typ... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,874 | issue_to_patch | build(deps): bump predis/predis from 3.4.2 to 3.5.0 | Bumps [predis/predis](https://github.com/predis/predis) from 3.4.2 to 3.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/predis/predis/releases">predis/predis's releases</a>.</em></p>
<blockquote>
<h2>v3.5.0</h2>
<h3>Added</h3>
<ul>
<li>Added support for <code>XNACK</code>... | 4504e3ce70aed40166fbcfe0ffed3389efd96742 | 3506dadebaa4c97c26112893f72092cdf3ca8c9e | diff --git a/composer.lock b/composer.lock
index 99df286944..9aa07ba71c 100644
--- a/composer.lock
+++ b/composer.lock
@@ -6920,16 +6920,16 @@
},
{
"name": "predis/predis",
- "version": "v3.4.2",
+ "version": "v3.5.0",
"source": {
"type"... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,875 | issue_to_patch | build(deps-dev): bump friendsofphp/php-cs-fixer from 3.95.3 to 3.95.4 | Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.95.3 to 3.95.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases">friendsofphp/php-cs-fixer's releases</a>.</em></p>
<blockquote>
<h2>v3.95.4 Adalbertus</h2... | 4504e3ce70aed40166fbcfe0ffed3389efd96742 | f48ce3499a90f22f589a3216a26c2b5fb13a6bb8 | diff --git a/composer.lock b/composer.lock
index 99df286944..15c16c4dd3 100644
--- a/composer.lock
+++ b/composer.lock
@@ -16037,16 +16037,16 @@
},
{
"name": "friendsofphp/php-cs-fixer",
- "version": "v3.95.3",
+ "version": "v3.95.4",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,873 | issue_to_patch | build(deps): bump codecov/codecov-action from 6 to 7 | Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6 to 7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<p>⚠️ Due to migration issues wi... | 4504e3ce70aed40166fbcfe0ffed3389efd96742 | 108170224767bc3acd50785235342192bd696967 | diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
index 89c5d9e1f4..8420022f96 100644
--- a/.github/workflows/continuous-integration.yml
+++ b/.github/workflows/continuous-integration.yml
@@ -120,7 +120,7 @@ jobs:
- name: "Upload unit coverage to Codecov"
... | [
".github/workflows/continuous-integration.yml"
] | [] | true | ||
wallabag/wallabag | 8,868 | issue_to_patch | Backport REDIS_URL support to 2.6.x (or release 2.7.0): hardcoded Redis DB 0 blocks shared-Redis deployments
### Summary
In Wallabag **2.6.14** (and all 2.6.x releases), `Predis\Client` is constructed in `app/config/services.yml` with only `scheme`, `host`, `port`, `path`, and `password` parameters. The Predis `datab... | Introduce a REDIS_URL (backport) | | Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | ~
| BC breaks? | no
| Deprecations? | no
| Tests pass? |
| Documentation | no
| Translation | no
| CHANGELOG.md | no
| License | MIT
Backports #8028
Fixes #8867 | cda1e0f069a4ebb6d9a37ea727c6005a94744869 | 43b4c90387b182bffbc0f2ed5ee3e678431fb591 | diff --git a/app/AppKernel.php b/app/AppKernel.php
index 61b734e06d..730421a6fa 100644
--- a/app/AppKernel.php
+++ b/app/AppKernel.php
@@ -97,5 +97,48 @@ public function registerContainerConfiguration(LoaderInterface $loader)
// $container->setParameter('container.dumper.inline_class_loader', true);
... | [
"app/AppKernel.php",
"app/config/parameters.yml.dist",
"app/config/services.yml",
"docker/php/config/parameters.yml",
"docker/php/env.example",
"tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php"
] | [] | diff --git a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
index cf7afd955c..6273d3d48e 100644
--- a/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
+++ b/tests/Wallabag/CoreBundle/Controller/EntryControllerTest.php
@@ -1557,7 +1... | true |
wallabag/wallabag | 8,864 | issue_to_patch | build(deps-dev): bump terser-webpack-plugin from 5.6.0 to 5.6.1 | Bumps [terser-webpack-plugin](https://github.com/webpack/minimizer-webpack-plugin) from 5.6.0 to 5.6.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/minimizer-webpack-plugin/releases">terser-webpack-plugin's releases</a>.</em></p>
<blockquote>
<h2>v5.6.1</h2>
<h3>Pa... | bc0a374c7d0ad7fc06a8415114cc362e6ae9c5fa | 9ae1f37166abdf7752deefb70a8bafaad4008ecf | diff --git a/package.json b/package.json
index e48d57cd4a..353e648853 100644
--- a/package.json
+++ b/package.json
@@ -74,7 +74,7 @@
"stylelint-config-standard": "^34.0.0",
"stylelint-config-standard-scss": "^11.1.0",
"stylelint-scss": "^5.3.2",
- "terser-webpack-plugin": "^5.6.0",
+ "terser-webpac... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,866 | issue_to_patch | build(deps): bump j0k3r/graby-site-config from 1.0.211 to 1.0.212 | Bumps [j0k3r/graby-site-config](https://github.com/j0k3r/graby-site-config) from 1.0.211 to 1.0.212.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/j0k3r/graby-site-config/commit/f14d675cbbddccb6ee21a920169db5cfa071c57d"><code>f14d675</code></a> Merge remote-tracking branch 'upstream/master'<... | 5244b5f844e62aebc6fc2912d6260a18ca0440f6 | 19e6638568115efc145d9a45ed349a5f90d5ca14 | diff --git a/composer.lock b/composer.lock
index 40bd64f6a8..08061a53a3 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4105,16 +4105,16 @@
},
{
"name": "j0k3r/graby-site-config",
- "version": "1.0.211",
+ "version": "1.0.212",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,865 | issue_to_patch | build(deps): bump guzzlehttp/psr7 from 2.10.1 to 2.10.4 | [//]: # (dependabot-start)
⚠️ **Dependabot is rebasing this PR** ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [guzzlehttp/psr7](https://github.com/... | 5244b5f844e62aebc6fc2912d6260a18ca0440f6 | f80a993370d4c243854b0283504f3bc7607e09aa | diff --git a/composer.lock b/composer.lock
index 40bd64f6a8..bf95118b9a 100644
--- a/composer.lock
+++ b/composer.lock
@@ -2840,16 +2840,16 @@
},
{
"name": "guzzlehttp/psr7",
- "version": "2.10.1",
+ "version": "2.10.4",
"source": {
"typ... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,862 | issue_to_patch | build(deps-dev): bump friendsofphp/php-cs-fixer from 3.95.2 to 3.95.3 | Bumps [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer) from 3.95.2 to 3.95.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases">friendsofphp/php-cs-fixer's releases</a>.</em></p>
<blockquote>
<h2>v3.95.3 Adalbertus</h2... | 5244b5f844e62aebc6fc2912d6260a18ca0440f6 | 85c676fbf81870893f5511345c28aa258920efe0 | diff --git a/composer.lock b/composer.lock
index 40bd64f6a8..7ad69aa488 100644
--- a/composer.lock
+++ b/composer.lock
@@ -11116,16 +11116,16 @@
},
{
"name": "symfony/polyfill-intl-grapheme",
- "version": "v1.37.0",
+ "version": "v1.38.1",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,860 | issue_to_patch | build(deps): bump twig/twig from 3.26.0 to 3.27.1 in the twig-dependencies group | Bumps the twig-dependencies group with 1 update: [twig/twig](https://github.com/twigphp/Twig).
Updates `twig/twig` from 3.26.0 to 3.27.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/twigphp/Twig/releases">twig/twig's releases</a>.</em></p>
<blockquote>
<h2>v3.27.1</h2>
<p>... | 5244b5f844e62aebc6fc2912d6260a18ca0440f6 | ac8f33d57fe1112c6ccdbfb9c36bfc8d7deaf265 | diff --git a/composer.lock b/composer.lock
index 40bd64f6a8..02c98816e6 100644
--- a/composer.lock
+++ b/composer.lock
@@ -14129,16 +14129,16 @@
},
{
"name": "twig/twig",
- "version": "v3.26.0",
+ "version": "v3.27.1",
"source": {
"type"... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,859 | issue_to_patch | build(deps): bump the symfony-dependencies group with 4 updates | Bumps the symfony-dependencies group with 4 updates: [symfony/http-client](https://github.com/symfony/http-client), [symfony/routing](https://github.com/symfony/routing), [symfony/runtime](https://github.com/symfony/runtime) and [symfony/security-http](https://github.com/symfony/security-http).
Updates `symfony/http-c... | 5244b5f844e62aebc6fc2912d6260a18ca0440f6 | 9160bf3599ce72c5c0ae87515d37ce47dcb20e2c | diff --git a/composer.lock b/composer.lock
index 40bd64f6a8..1bca880e05 100644
--- a/composer.lock
+++ b/composer.lock
@@ -10099,16 +10099,16 @@
},
{
"name": "symfony/http-client",
- "version": "v5.4.49",
+ "version": "v5.4.53",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,863 | issue_to_patch | build(deps-dev): bump webpack from 5.107.1 to 5.107.2 | Bumps [webpack](https://github.com/webpack/webpack) from 5.107.1 to 5.107.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p>
<blockquote>
<h2>v5.107.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>
<p>Reduce per-file overhead i... | 8d77dd0935d4552785a323eaeb451ffbda59737c | d2955e4deaffe1a442ca059aa12798e19f783d87 | diff --git a/package.json b/package.json
index e5d4d331c8..e48d57cd4a 100644
--- a/package.json
+++ b/package.json
@@ -76,7 +76,7 @@
"stylelint-scss": "^5.3.2",
"terser-webpack-plugin": "^5.6.0",
"url-loader": "^4.1.1",
- "webpack": "^5.107.1",
+ "webpack": "^5.107.2",
"webpack-cli": "^6.0.1",... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,861 | issue_to_patch | build(deps-dev): bump the babel-dependencies group with 3 updates | Bumps the babel-dependencies group with 3 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) and [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env).
Update... | 5244b5f844e62aebc6fc2912d6260a18ca0440f6 | a13a215e4bc78c14d3083d85d4aa8f3e25e39218 | diff --git a/package.json b/package.json
index fccb6f8b86..e5d4d331c8 100644
--- a/package.json
+++ b/package.json
@@ -47,9 +47,9 @@
"url": "https://github.com/wallabag/wallabag/issues"
},
"devDependencies": {
- "@babel/core": "^7.29.0",
- "@babel/eslint-parser": "^7.28.6",
- "@babel/preset-env": "^... | [
"package.json",
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,857 | issue_to_patch | build(deps): bump symfony/polyfill-intl-idn from 1.37.0 to 1.38.1 | Bumps [symfony/polyfill-intl-idn](https://github.com/symfony/polyfill-intl-idn) from 1.37.0 to 1.38.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/symfony/polyfill-intl-idn/releases">symfony/polyfill-intl-idn's releases</a>.</em></p>
<blockquote>
<h2>v1.38.1</h2>
<p><stron... | ddea688f9cd32011f8b4b3c8862a9e706099b884 | dd67f8196d6155cb63ab2afbe79e47a336b5d485 | diff --git a/composer.lock b/composer.lock
index 57ee661b9d..40bd64f6a8 100644
--- a/composer.lock
+++ b/composer.lock
@@ -11282,16 +11282,16 @@
},
{
"name": "symfony/polyfill-intl-idn",
- "version": "v1.37.0",
+ "version": "v1.38.1",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,853 | issue_to_patch | build(deps): bump symfony/monolog-bridge from 6.4.13 to 6.4.40 | [//]: # (dependabot-start)
⚠️ **Dependabot is rebasing this PR** ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
---
[//]: # (dependabot-end)
Bumps [symfony/monolog-bridge](https://gith... | d8174bf673c1b0d8fb68764a87962c9a8efe1cb2 | e84224f6c578f1b4116d824c7f77db1a516e2cf8 | diff --git a/composer.lock b/composer.lock
index d97c6a431d..4996aba31c 100644
--- a/composer.lock
+++ b/composer.lock
@@ -10344,16 +10344,16 @@
},
{
"name": "symfony/http-kernel",
- "version": "v5.4.52",
+ "version": "v5.4.53",
"source": {
... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,854 | issue_to_patch | build(deps): bump symfony/cache from 6.4.35 to 6.4.41 | Bumps [symfony/cache](https://github.com/symfony/cache) from 6.4.35 to 6.4.41.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/symfony/cache/releases">symfony/cache's releases</a>.</em></p>
<blockquote>
<h2>v6.4.41</h2>
<p><strong>Changelog</strong> (<a href="https://github.co... | d8174bf673c1b0d8fb68764a87962c9a8efe1cb2 | 0eeb25fee8c334c24d2753b06dc1f03413354d6d | diff --git a/composer.lock b/composer.lock
index d97c6a431d..7be7654ed1 100644
--- a/composer.lock
+++ b/composer.lock
@@ -8639,16 +8639,16 @@
},
{
"name": "symfony/cache",
- "version": "v6.4.35",
+ "version": "v6.4.41",
"source": {
"typ... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,855 | issue_to_patch | build(deps): bump symfony/yaml from 6.4.34 to 6.4.41 | Bumps [symfony/yaml](https://github.com/symfony/yaml) from 6.4.34 to 6.4.41.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/symfony/yaml/releases">symfony/yaml's releases</a>.</em></p>
<blockquote>
<h2>v6.4.41</h2>
<p><strong>Changelog</strong> (<a href="https://github.com/sy... | d8174bf673c1b0d8fb68764a87962c9a8efe1cb2 | a34f2959847c3a58ec305222dc0af15603e2f514 | diff --git a/composer.lock b/composer.lock
index d97c6a431d..1c80fa58dd 100644
--- a/composer.lock
+++ b/composer.lock
@@ -13688,16 +13688,16 @@
},
{
"name": "symfony/yaml",
- "version": "v6.4.34",
+ "version": "v6.4.41",
"source": {
"ty... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,856 | issue_to_patch | build(deps): bump tmp from 0.2.5 to 0.2.7 | Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.5 to 0.2.7.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/raszi/node-tmp/commit/8ea1f37d75c67569e0f151448330d52f7babf211"><code>8ea1f37</code></a> Bump up the version</li>
<li><a href="https://github.com/raszi/node-tmp/commit/8f24f788a3... | d8174bf673c1b0d8fb68764a87962c9a8efe1cb2 | 3a756e99968cc8b3c945e53eb9790ae584b83d92 | diff --git a/yarn.lock b/yarn.lock
index 9897331ac2..0b2d960e8c 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -5333,9 +5333,9 @@ tiny-emitter@^2.0.0:
integrity sha512-NB6Dk1A9xgQPMoGqC5CVXn123gWyte215ONT5Pp5a0yt4nlEoO1ZWeCwpncaekPHXO60i47ihFnZPiRPjRMq4Q==
tmp@^0.2.5:
- version "0.2.5"
- resolved "https://registry.y... | [
"yarn.lock"
] | [] | true | ||
wallabag/wallabag | 8,849 | issue_to_patch | build(deps): bump guzzlehttp/psr7 from 2.9.0 to 2.10.1 | Bumps [guzzlehttp/psr7](https://github.com/guzzle/psr7) from 2.9.0 to 2.10.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/guzzle/psr7/releases">guzzlehttp/psr7's releases</a>.</em></p>
<blockquote>
<h2>2.10.1</h2>
<h3>Fixed</h3>
<ul>
<li>Fix <code>Utils::modifyRequest()</c... | ef0a7f6f84a2bf9344b935234b13f27fb9461eac | 5ffa2648f28073758cc44fe71ad4b99883cc4660 | diff --git a/composer.lock b/composer.lock
index 273087a6c6..a1bcdca0c6 100644
--- a/composer.lock
+++ b/composer.lock
@@ -2840,16 +2840,16 @@
},
{
"name": "guzzlehttp/psr7",
- "version": "2.9.0",
+ "version": "2.10.1",
"source": {
"type... | [
"composer.lock"
] | [] | true | ||
wallabag/wallabag | 8,846 | issue_to_patch | build(deps): bump the symfony-dependencies group with 7 updates | Bumps the symfony-dependencies group with 7 updates:
| Package | From | To |
| --- | --- | --- |
| [symfony/dom-crawler](https://github.com/symfony/dom-crawler) | `5.4.48` | `5.4.52` |
| [symfony/http-kernel](https://github.com/symfony/http-kernel) | `5.4.51` | `5.4.52` |
| [symfony/mailer](https://github.com/symfony/... | ef0a7f6f84a2bf9344b935234b13f27fb9461eac | 6179a74b002de4dc8fc785fe6f6214d8748173dd | diff --git a/composer.lock b/composer.lock
index 273087a6c6..596e5ef7e3 100644
--- a/composer.lock
+++ b/composer.lock
@@ -9269,16 +9269,16 @@
},
{
"name": "symfony/dom-crawler",
- "version": "v5.4.48",
+ "version": "v5.4.52",
"source": {
... | [
"composer.lock"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.