url
stringlengths
50
53
repository_url
stringclasses
1 value
labels_url
stringlengths
64
67
comments_url
stringlengths
59
62
events_url
stringlengths
57
60
html_url
stringlengths
38
43
id
int64
597k
2.65B
node_id
stringlengths
18
32
number
int64
1
6.83k
title
stringlengths
1
296
user
dict
labels
listlengths
0
5
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
4
milestone
dict
comments
int64
0
211
created_at
stringlengths
20
20
updated_at
stringlengths
20
20
closed_at
stringlengths
20
20
author_association
stringclasses
3 values
active_lock_reason
stringclasses
4 values
body
stringlengths
0
65.6k
closed_by
dict
reactions
dict
timeline_url
stringlengths
59
62
performed_via_github_app
null
state_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
is_pull_request
bool
2 classes
issue_comments
listlengths
0
30
https://api.github.com/repos/psf/requests/issues/2230
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2230/labels{/name}
https://api.github.com/repos/psf/requests/issues/2230/comments
https://api.github.com/repos/psf/requests/issues/2230/events
https://github.com/psf/requests/issues/2230
43,096,088
MDU6SXNzdWU0MzA5NjA4OA==
2,230
requests will improperly raise errors as ConnectionError
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2014-09-18T05:36:29Z
2021-09-08T23:07:56Z
2014-10-05T18:47:30Z
CONTRIBUTOR
resolved
Let's say the server closes the request without sending any data. It's possible that the server began acting on the request (Twilio did this for several years), however requests will raise this as a ConnectionError. Deep down this gets raised as a BadStatusLine error which is caught by urllib3 and turned into a ProtocolError which is caught & re-raised as a ConnectionError. See also shazow/urllib3#470.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2230/reactions" }
https://api.github.com/repos/psf/requests/issues/2230/timeline
null
completed
null
null
false
[ "I tried to produce a test case to demonstrate this, but couldn't figure out how to do this in a nice way. Count this as another vote for https://github.com/kennethreitz/httpbin/issues/153, maybe https://github.com/kevinburke/hamms can get ported/implemented on httpbin.\n", "Sorry @kevinburke, it's not clear to m...
https://api.github.com/repos/psf/requests/issues/2229
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2229/labels{/name}
https://api.github.com/repos/psf/requests/issues/2229/comments
https://api.github.com/repos/psf/requests/issues/2229/events
https://github.com/psf/requests/issues/2229
42,945,644
MDU6SXNzdWU0Mjk0NTY0NA==
2,229
full URL sent instead of path when using https proxy
{ "avatar_url": "https://avatars.githubusercontent.com/u/1994957?v=4", "events_url": "https://api.github.com/users/newsham/events{/privacy}", "followers_url": "https://api.github.com/users/newsham/followers", "following_url": "https://api.github.com/users/newsham/following{/other_user}", "gists_url": "https://api.github.com/users/newsham/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/newsham", "id": 1994957, "login": "newsham", "node_id": "MDQ6VXNlcjE5OTQ5NTc=", "organizations_url": "https://api.github.com/users/newsham/orgs", "received_events_url": "https://api.github.com/users/newsham/received_events", "repos_url": "https://api.github.com/users/newsham/repos", "site_admin": false, "starred_url": "https://api.github.com/users/newsham/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/newsham/subscriptions", "type": "User", "url": "https://api.github.com/users/newsham", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" } ]
closed
true
null
[]
null
9
2014-09-16T23:23:44Z
2021-09-08T23:04:49Z
2015-05-03T15:12:33Z
NONE
resolved
When using the requests library through a web proxy, requests includes a full URL in the request line instead of just the path for all https requests. Http requests send just the path, as expected. Https requests send the full URL in place of the path. This can cause problems with certain proxies (for example, the BURP proxy (http://portswigger.net/burp/download.html) will not properly process these requests unless the special "transparent" proxy mode is enabled). The following script demonstrates his problem: ``` #!/usr/bin/env python """ Requests library will send full URL as the request path when sending HTTPS requests to a proxy.. WHY? Run this script through a proxy listening on the local host, such as BURP, which records all traffic. Look at the proxy logs to see the request lines. Notice that this will send a full URL in the request line. """ import requests proxies = { 'http': 'http://127.0.0.1:8080/', 'https': 'https://127.0.0.1:8080/' } # sends full URL in the request line: r = requests.get("https://www.yahoo.com/the/path/goes/here", proxies=proxies, allow_redirects=False) # sends full just the path in the request line: r = requests.get("http://www.yahoo.com/the/path/goes/here", proxies=proxies, allow_redirects=False) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2229/reactions" }
https://api.github.com/repos/psf/requests/issues/2229/timeline
null
completed
null
null
false
[ "Hmm, I'm honestly not sure. My gut is saying that this is because having a HTTPS scheme in a proxy URL just doesn't really work.\n", "So I think this might also have something to do with the `CONNECT` verb which we use when connecting to an `https` proxy. I know that for `CONNECT` you have to pass the authority ...
https://api.github.com/repos/psf/requests/issues/2228
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2228/labels{/name}
https://api.github.com/repos/psf/requests/issues/2228/comments
https://api.github.com/repos/psf/requests/issues/2228/events
https://github.com/psf/requests/issues/2228
42,893,830
MDU6SXNzdWU0Mjg5MzgzMA==
2,228
Documentation examples.
{ "avatar_url": "https://avatars.githubusercontent.com/u/72376?v=4", "events_url": "https://api.github.com/users/mountainpaul/events{/privacy}", "followers_url": "https://api.github.com/users/mountainpaul/followers", "following_url": "https://api.github.com/users/mountainpaul/following{/other_user}", "gists_url": "https://api.github.com/users/mountainpaul/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mountainpaul", "id": 72376, "login": "mountainpaul", "node_id": "MDQ6VXNlcjcyMzc2", "organizations_url": "https://api.github.com/users/mountainpaul/orgs", "received_events_url": "https://api.github.com/users/mountainpaul/received_events", "repos_url": "https://api.github.com/users/mountainpaul/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mountainpaul/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mountainpaul/subscriptions", "type": "User", "url": "https://api.github.com/users/mountainpaul", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" }, { "color": "0b02e1", "default": false, "description": null, "id": 191274, "...
closed
true
null
[]
null
15
2014-09-16T15:15:50Z
2022-02-26T04:00:40Z
2021-11-28T03:00:28Z
NONE
resolved
Thanks for an excellent package. I believe the quick start examples should include a timeout value. This is the more common case, rather than the exception. In the more advanced documentation it maybe wise to mention that sockets.getdefaulttimeout() is not used when a value is not specified.
{ "avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4", "events_url": "https://api.github.com/users/sethmlarson/events{/privacy}", "followers_url": "https://api.github.com/users/sethmlarson/followers", "following_url": "https://api.github.com/users/sethmlarson/following{/other_user}", "gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sethmlarson", "id": 18519037, "login": "sethmlarson", "node_id": "MDQ6VXNlcjE4NTE5MDM3", "organizations_url": "https://api.github.com/users/sethmlarson/orgs", "received_events_url": "https://api.github.com/users/sethmlarson/received_events", "repos_url": "https://api.github.com/users/sethmlarson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions", "type": "User", "url": "https://api.github.com/users/sethmlarson", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2228/reactions" }
https://api.github.com/repos/psf/requests/issues/2228/timeline
null
completed
null
null
false
[ "Thanks for the suggestion! However, I disagree.\n\nIn many cases, users find it valuable to add a timeout to their calls. This is entirely reasonable. However, the quickstart code is not an example of 'general use', it's intended to be illustrative and educational. We should not obscure the pedagogical point in th...
https://api.github.com/repos/psf/requests/issues/2227
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2227/labels{/name}
https://api.github.com/repos/psf/requests/issues/2227/comments
https://api.github.com/repos/psf/requests/issues/2227/events
https://github.com/psf/requests/pull/2227
42,862,246
MDExOlB1bGxSZXF1ZXN0MjEyODY1NDA=
2,227
Added example of how to send multiple files in one request.
{ "avatar_url": "https://avatars.githubusercontent.com/u/142868?v=4", "events_url": "https://api.github.com/users/mjul/events{/privacy}", "followers_url": "https://api.github.com/users/mjul/followers", "following_url": "https://api.github.com/users/mjul/following{/other_user}", "gists_url": "https://api.github.com/users/mjul/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mjul", "id": 142868, "login": "mjul", "node_id": "MDQ6VXNlcjE0Mjg2OA==", "organizations_url": "https://api.github.com/users/mjul/orgs", "received_events_url": "https://api.github.com/users/mjul/received_events", "repos_url": "https://api.github.com/users/mjul/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mjul/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mjul/subscriptions", "type": "User", "url": "https://api.github.com/users/mjul", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-09-16T09:39:48Z
2021-09-08T10:01:17Z
2014-09-18T01:06:54Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2227/reactions" }
https://api.github.com/repos/psf/requests/issues/2227/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2227.diff", "html_url": "https://github.com/psf/requests/pull/2227", "merged_at": "2014-09-18T01:06:54Z", "patch_url": "https://github.com/psf/requests/pull/2227.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2227" }
true
[ "Thanks for this! I really like it, but I think it's too niche for the QuickStart section. If you move it to the advanced docs I'll happily merge it straight away. :cake:\n", "@Lukasa I'm -0 about the reference in the quickstart guide to the advanced section. How do you feel about it?\n", ":sparkles: :cake: :sp...
https://api.github.com/repos/psf/requests/issues/2226
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2226/labels{/name}
https://api.github.com/repos/psf/requests/issues/2226/comments
https://api.github.com/repos/psf/requests/issues/2226/events
https://github.com/psf/requests/issues/2226
42,846,571
MDU6SXNzdWU0Mjg0NjU3MQ==
2,226
Can't get ETag for some resource
{ "avatar_url": "https://avatars.githubusercontent.com/u/1519701?v=4", "events_url": "https://api.github.com/users/guhehehe/events{/privacy}", "followers_url": "https://api.github.com/users/guhehehe/followers", "following_url": "https://api.github.com/users/guhehehe/following{/other_user}", "gists_url": "https://api.github.com/users/guhehehe/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/guhehehe", "id": 1519701, "login": "guhehehe", "node_id": "MDQ6VXNlcjE1MTk3MDE=", "organizations_url": "https://api.github.com/users/guhehehe/orgs", "received_events_url": "https://api.github.com/users/guhehehe/received_events", "repos_url": "https://api.github.com/users/guhehehe/repos", "site_admin": false, "starred_url": "https://api.github.com/users/guhehehe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guhehehe/subscriptions", "type": "User", "url": "https://api.github.com/users/guhehehe", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-09-16T05:48:38Z
2021-09-08T23:08:07Z
2014-09-16T06:07:29Z
NONE
resolved
I am trying to send get requests to this url: http://data.sfgov.org/resource/rqzj-sfat.json, which will return a etag in the response header, but I just couldn't get it using requests' get method. This is what I did: ``` >>> r = requests.get('http://data.sfgov.org/resource/rqzj-sfat.json') >>> print r.headers.get('etag') >>> None ``` Every other fields are in the response header, except for 'etag'. Not sure if it's a bug or I missed something.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1519701?v=4", "events_url": "https://api.github.com/users/guhehehe/events{/privacy}", "followers_url": "https://api.github.com/users/guhehehe/followers", "following_url": "https://api.github.com/users/guhehehe/following{/other_user}", "gists_url": "https://api.github.com/users/guhehehe/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/guhehehe", "id": 1519701, "login": "guhehehe", "node_id": "MDQ6VXNlcjE1MTk3MDE=", "organizations_url": "https://api.github.com/users/guhehehe/orgs", "received_events_url": "https://api.github.com/users/guhehehe/received_events", "repos_url": "https://api.github.com/users/guhehehe/repos", "site_admin": false, "starred_url": "https://api.github.com/users/guhehehe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guhehehe/subscriptions", "type": "User", "url": "https://api.github.com/users/guhehehe", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2226/reactions" }
https://api.github.com/repos/psf/requests/issues/2226/timeline
null
completed
null
null
false
[ "Just dug a little bit into the requests' source code, and found requests will set a default header if no header is specified. It's the `Accept-Encoding` header somehow make the server stop sending `ETag`, so closing.\n" ]
https://api.github.com/repos/psf/requests/issues/2225
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2225/labels{/name}
https://api.github.com/repos/psf/requests/issues/2225/comments
https://api.github.com/repos/psf/requests/issues/2225/events
https://github.com/psf/requests/issues/2225
42,764,925
MDU6SXNzdWU0Mjc2NDkyNQ==
2,225
Send delete with data
{ "avatar_url": "https://avatars.githubusercontent.com/u/3798140?v=4", "events_url": "https://api.github.com/users/temi4/events{/privacy}", "followers_url": "https://api.github.com/users/temi4/followers", "following_url": "https://api.github.com/users/temi4/following{/other_user}", "gists_url": "https://api.github.com/users/temi4/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/temi4", "id": 3798140, "login": "temi4", "node_id": "MDQ6VXNlcjM3OTgxNDA=", "organizations_url": "https://api.github.com/users/temi4/orgs", "received_events_url": "https://api.github.com/users/temi4/received_events", "repos_url": "https://api.github.com/users/temi4/repos", "site_admin": false, "starred_url": "https://api.github.com/users/temi4/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/temi4/subscriptions", "type": "User", "url": "https://api.github.com/users/temi4", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-09-15T12:00:25Z
2021-09-08T23:08:07Z
2014-09-15T19:07:26Z
NONE
resolved
Hello. How I may send delete request with data? This string don't work to send data: session.request('delete', url, data=data)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2225/reactions" }
https://api.github.com/repos/psf/requests/issues/2225/timeline
null
completed
null
null
false
[ "@temi4 the following works for me:\n\n``` python\nimport requests\n\ns = requests.Session()\nr = s.delete('https://httpbin.org/delete', data={'foo': 'bar'})\nassert {'foo': 'bar'} == r.json()['form']\nr2 = s.request('DELETE', 'https://httpbin.org/delete', data={'fiz': 'buz'})\nassert {'fiz': 'buz'} == r.json()['fo...
https://api.github.com/repos/psf/requests/issues/2224
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2224/labels{/name}
https://api.github.com/repos/psf/requests/issues/2224/comments
https://api.github.com/repos/psf/requests/issues/2224/events
https://github.com/psf/requests/pull/2224
42,640,115
MDExOlB1bGxSZXF1ZXN0MjExNTk1MDI=
2,224
Fix errors reported by frosted in tests
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-09-12T15:22:27Z
2021-09-08T10:01:18Z
2014-09-12T15:47:27Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2224/reactions" }
https://api.github.com/repos/psf/requests/issues/2224/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2224.diff", "html_url": "https://github.com/psf/requests/pull/2224", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2224.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2224" }
true
[ "@blueyed thanks but we do not follow `pep8` in requests. \n", "@sigmavirus24 \nIt's not about pep8, but comes from frosted (and maybe other type (not style) checkers).\n", "Oh right, frosted is the fork of pyflakes. Regardless, these changes are far from critical and are entirely unnecessary. `io` is not a bui...
https://api.github.com/repos/psf/requests/issues/2223
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2223/labels{/name}
https://api.github.com/repos/psf/requests/issues/2223/comments
https://api.github.com/repos/psf/requests/issues/2223/events
https://github.com/psf/requests/pull/2223
42,639,279
MDExOlB1bGxSZXF1ZXN0MjExNTg5Nzk=
2,223
Document skipping in PreparedRequest; followup to #2222
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-09-12T15:14:15Z
2021-09-08T10:01:18Z
2014-09-12T16:54:40Z
CONTRIBUTOR
resolved
I've meant to add this to #2222, which has been merged already.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2223/reactions" }
https://api.github.com/repos/psf/requests/issues/2223/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2223.diff", "html_url": "https://github.com/psf/requests/pull/2223", "merged_at": "2014-09-12T16:54:40Z", "patch_url": "https://github.com/psf/requests/pull/2223.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2223" }
true
[ "Look good to me. I'll just make sure Jenkins is happy with it and them I'll merge it. Thanks @blueyed \n", "Closed & re-opened to trigger a new build. HTTPBin is acting flakey again.\n" ]
https://api.github.com/repos/psf/requests/issues/2222
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2222/labels{/name}
https://api.github.com/repos/psf/requests/issues/2222/comments
https://api.github.com/repos/psf/requests/issues/2222/events
https://github.com/psf/requests/pull/2222
42,587,804
MDExOlB1bGxSZXF1ZXN0MjExMjgwNjk=
2,222
Add tests to test_invalid_url for `InvalidSchema`
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2014-09-12T01:15:37Z
2021-09-08T10:01:17Z
2014-09-12T14:16:11Z
CONTRIBUTOR
resolved
In b149be5d `PreparedRequest` was made to skip `parse_url` for e.g. `$HOST:$PORT`, which results in `MissingSchema` not being raised for `localhost:3128`.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2222/reactions" }
https://api.github.com/repos/psf/requests/issues/2222/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2222.diff", "html_url": "https://github.com/psf/requests/pull/2222", "merged_at": "2014-09-12T14:16:11Z", "patch_url": "https://github.com/psf/requests/pull/2222.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2222" }
true
[ "I have created https://github.com/shazow/urllib3/issues/466 to possibly handle the \"oddball schemes\" in urllib3 directly.\n\nEDIT: not their job.\n", "@jvantuyl\nCan you remember and elaborate on why you've made this change (https://github.com/kennethreitz/requests/commit/b149be5d864cc7f65ac22113db3d0e4d2ed2b4...
https://api.github.com/repos/psf/requests/issues/2221
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2221/labels{/name}
https://api.github.com/repos/psf/requests/issues/2221/comments
https://api.github.com/repos/psf/requests/issues/2221/events
https://github.com/psf/requests/pull/2221
42,581,330
MDExOlB1bGxSZXF1ZXN0MjExMjQwODI=
2,221
Fix `prepend_scheme_if_needed` for $HOST:$PORT
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2014-09-11T23:13:48Z
2021-09-08T10:01:14Z
2014-09-12T06:19:58Z
CONTRIBUTOR
resolved
`prepend_scheme_if_needed` is used for the proxy, but failed to do so properly for `host:port`. This PR addresses the first occasion in the docs I've stumbled upon, fixes the implementation and adds tests. (This is derived from https://github.com/kennethreitz/requests/pull/2219.) If this seems OK, the documentation at https://github.com/kennethreitz/requests/blame/master/docs/api.rst#L238-249 needs to get removed/addressed also.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2221/reactions" }
https://api.github.com/repos/psf/requests/issues/2221/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2221.diff", "html_url": "https://github.com/psf/requests/pull/2221", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2221.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2221" }
true
[ "So here's the thing, I can't think of any proxies that require a path or for which `hostname:port/` is normal practice. Everything about how we operate currently is perfectly fine for the 90% use case and we've had this support for over a year without a complaint. `urlparse` is far from perfect, I agree. Your docu...
https://api.github.com/repos/psf/requests/issues/2220
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2220/labels{/name}
https://api.github.com/repos/psf/requests/issues/2220/comments
https://api.github.com/repos/psf/requests/issues/2220/events
https://github.com/psf/requests/issues/2220
42,577,693
MDU6SXNzdWU0MjU3NzY5Mw==
2,220
Force specific proxy/proxies / skip looking at the environment
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-09-11T22:21:14Z
2021-09-08T23:08:09Z
2014-09-12T06:17:01Z
CONTRIBUTOR
resolved
`requests` merges the proxies from the environment unconditionally (https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L439-443). The use case would be `pip --proxy localhost:3128 install example`, which should make `requests` use the specified proxy always. I could imagine `PipSession` to override `merge_environment_settings` and discard changes from the environment, but there should be cleaner way to indicate that only the explicitly provided proxies should be used. Another idea might be to set `PipSession.trust_env = False`, but that would also affect CA bundles and seems even more dirty. And while pip could unset the environment variables (in case a proxy is provided via its options), this requires to know the implementation details about looking them up. I would have assumed that `requests` take proxy information from the environment only if no proxies are provided through the API.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2220/reactions" }
https://api.github.com/repos/psf/requests/issues/2220/timeline
null
completed
null
null
false
[ "> I would have assumed that requests take proxy information from the environment only if no proxies are provided through the API.\n\nThat's exactly what happens. You'll find this works a bit better if you read through to `merge_environment_settings`:\n\n``` python\nif self.trust_env:\n # Set environment's proxi...
https://api.github.com/repos/psf/requests/issues/2219
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2219/labels{/name}
https://api.github.com/repos/psf/requests/issues/2219/comments
https://api.github.com/repos/psf/requests/issues/2219/events
https://github.com/psf/requests/pull/2219
42,575,872
MDExOlB1bGxSZXF1ZXN0MjExMjA1MjQ=
2,219
Fix doc: scheme is not required with proxy URLs
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2014-09-11T21:58:28Z
2021-09-08T10:01:19Z
2014-09-12T01:55:48Z
CONTRIBUTOR
resolved
`prepend_scheme_if_needed` is used to add `http` if necessary.
{ "avatar_url": "https://avatars.githubusercontent.com/u/9766?v=4", "events_url": "https://api.github.com/users/blueyed/events{/privacy}", "followers_url": "https://api.github.com/users/blueyed/followers", "following_url": "https://api.github.com/users/blueyed/following{/other_user}", "gists_url": "https://api.github.com/users/blueyed/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/blueyed", "id": 9766, "login": "blueyed", "node_id": "MDQ6VXNlcjk3NjY=", "organizations_url": "https://api.github.com/users/blueyed/orgs", "received_events_url": "https://api.github.com/users/blueyed/received_events", "repos_url": "https://api.github.com/users/blueyed/repos", "site_admin": false, "starred_url": "https://api.github.com/users/blueyed/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/blueyed/subscriptions", "type": "User", "url": "https://api.github.com/users/blueyed", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2219/reactions" }
https://api.github.com/repos/psf/requests/issues/2219/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2219.diff", "html_url": "https://github.com/psf/requests/pull/2219", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2219.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2219" }
true
[ "There's also a part in the API migration docs, which would be obsolete then (or needs clarification - see comments below): https://github.com/kennethreitz/requests/blame/master/docs/api.rst#L238-249\n", "I've tested it using the following code:\n\n```\nrequests.get(\"http://example.org\", proxies={'http': 'local...
https://api.github.com/repos/psf/requests/issues/2218
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2218/labels{/name}
https://api.github.com/repos/psf/requests/issues/2218/comments
https://api.github.com/repos/psf/requests/issues/2218/events
https://github.com/psf/requests/pull/2218
42,516,983
MDExOlB1bGxSZXF1ZXN0MjEwODMyMjg=
2,218
Use `base_url` session param to construct relative URLs
{ "avatar_url": "https://avatars.githubusercontent.com/u/132355?v=4", "events_url": "https://api.github.com/users/singingwolfboy/events{/privacy}", "followers_url": "https://api.github.com/users/singingwolfboy/followers", "following_url": "https://api.github.com/users/singingwolfboy/following{/other_user}", "gists_url": "https://api.github.com/users/singingwolfboy/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/singingwolfboy", "id": 132355, "login": "singingwolfboy", "node_id": "MDQ6VXNlcjEzMjM1NQ==", "organizations_url": "https://api.github.com/users/singingwolfboy/orgs", "received_events_url": "https://api.github.com/users/singingwolfboy/received_events", "repos_url": "https://api.github.com/users/singingwolfboy/repos", "site_admin": false, "starred_url": "https://api.github.com/users/singingwolfboy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/singingwolfboy/subscriptions", "type": "User", "url": "https://api.github.com/users/singingwolfboy", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-09-11T12:12:37Z
2021-09-08T10:01:19Z
2014-09-11T12:36:57Z
NONE
resolved
This bundles the [URLObject](https://github.com/zacharyvoase/urlobject) library, and uses it for constructing relative URLs.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2218/reactions" }
https://api.github.com/repos/psf/requests/issues/2218/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2218.diff", "html_url": "https://github.com/psf/requests/pull/2218", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2218.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2218" }
true
[ ":-1: This is not appropriate for requests. This is perfectly reasonable for an extension, but not for requests core. This is also available in https://github.com/dstufft/slumber\n", "Ah. When I submitted this to https://github.com/requests/requests-oauthlib/pull/147, there was some thought that perhaps this shou...
https://api.github.com/repos/psf/requests/issues/2217
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2217/labels{/name}
https://api.github.com/repos/psf/requests/issues/2217/comments
https://api.github.com/repos/psf/requests/issues/2217/events
https://github.com/psf/requests/issues/2217
42,444,270
MDU6SXNzdWU0MjQ0NDI3MA==
2,217
Bug on upload file, file name with Latin characters: requests version 2.3.2 e 2.4.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/2965643?v=4", "events_url": "https://api.github.com/users/Bleno/events{/privacy}", "followers_url": "https://api.github.com/users/Bleno/followers", "following_url": "https://api.github.com/users/Bleno/following{/other_user}", "gists_url": "https://api.github.com/users/Bleno/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Bleno", "id": 2965643, "login": "Bleno", "node_id": "MDQ6VXNlcjI5NjU2NDM=", "organizations_url": "https://api.github.com/users/Bleno/orgs", "received_events_url": "https://api.github.com/users/Bleno/received_events", "repos_url": "https://api.github.com/users/Bleno/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Bleno/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Bleno/subscriptions", "type": "User", "url": "https://api.github.com/users/Bleno", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-09-10T18:29:33Z
2021-09-08T23:08:09Z
2014-09-10T18:38:28Z
NONE
resolved
Hello friends. I spent a few days trying to upload files using the requests, but had issues with the **version 2.4.0** and python **version 3.2.2.** I have a web application that receives a file via a html form, this application sends the received file to a web service, **but when the file name contains Latin characters**, for example: "ç, ã, á, ú" web service can not receive the file name that is not given a cgi.FieldStorage. After several attempts trying to encode utf-8 which is already the default string sent did not succeed. I managed to solve the problem only when I made a downgrade to version 1.2.3 of requests, so it worked perfectly. Does anyone know what might be happening to most current versions of requests? An important detail: must do everything in memory, then pass the file name and bytes of it. I did the following test and it still fails: ``` python #!/usr/bin/env python # -*- coding: utf-8 -*- """ Test upload file Pyramid-based application namefile = self.post['filename_0'].filename #str input_file = self.post['filename_0'].file #bytes input_file.seek(0) #cursor position 0 binary_content = input_file.read() #read bytes file r = requests.post(url = "http://webservide.net", files = {'file': (filename, content)} ) Response(r.text) """ import requests f = open("Atenção 1ª.txt", "rb") filename = f.name print(filename) content = f.read() #print(content) r = requests.post(url = "http://webservice.net", files = {'file': (filename, content)} ) print(r.text) ``` **This even works with version 1.2.3** with latest versions like 2.3.2 and 2.4.0 code does **not work.** _It will be a bug in the file upload?_
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2217/reactions" }
https://api.github.com/repos/psf/requests/issues/2217/timeline
null
completed
null
null
false
[ "Hi there, thanks for reporting this issue!\n\nWhen you say it does not work, what exactly to you mean? In what way does this fail?\n", "@Lukasa this is a duplicate of https://github.com/kennethreitz/requests/issues/2117\n", "Good spot! In that case, let's close this. =)\n" ]
https://api.github.com/repos/psf/requests/issues/2216
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2216/labels{/name}
https://api.github.com/repos/psf/requests/issues/2216/comments
https://api.github.com/repos/psf/requests/issues/2216/events
https://github.com/psf/requests/pull/2216
42,430,638
MDExOlB1bGxSZXF1ZXN0MjEwNDMzMTE=
2,216
Retries logic
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "e10c02", "default": false, "description": null...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
30
2014-09-10T16:12:40Z
2021-09-08T09:00:56Z
2014-12-01T19:45:27Z
CONTRIBUTOR
resolved
Currently our documentation tells user that by creating a custom `HTTPAdapter` they can pass `max_retries=n` and that will apply to connection and read retries. This is a lie at the moment (and has been probably since 2.4.0 was released with the new version of urllib3 that added the `Retry` class). In order to preserve backwards compatibility (and have passing tests) I remember upgrading the logic [here](https://github.com/kennethreitz/requests/blob/master/requests/adapters.py#L361) to pass `read=False` because some where we expected a plain `ReadTimeout` exception we were now getting a `MaxRetryError`. This, however, means that we have broken what we promised in the documentation (and what was likely present in even 2.3.0). At the moment we do not support passing a `Retry` instance from `urllib3`. I'd like to propose the following changes: - In `requests.adapters`, `DEFAULT_RETRIES` becomes a sentinel object, e.g., `DEFAULT_RETRIES = object()`. - In `HTTPAdatper.__init__`, we check for the sentinel object and if so set `self.max_retries` to `Retry(0, read=False)`. Otherwise, we do `self.max_retries = Retry.from_int(max_retries)` This should fix preserve the default existing behaviour that specifying `read=False` preserved but also allow users to do one of two things: 1. Import `Retry` from urllib3, construct their own `Retry` instance and then pass it as `max_retries` 2. Specify a number for both connection and read retries. Does this sound like a fair proposal? **Edit** I forgot to mention that @txtsd brought this to our attention in IRC. They get the credit for reporting this. Thank you @txtsd
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2216/reactions" }
https://api.github.com/repos/psf/requests/issues/2216/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2216.diff", "html_url": "https://github.com/psf/requests/pull/2216", "merged_at": "2014-12-01T19:45:27Z", "patch_url": "https://github.com/psf/requests/pull/2216.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2216" }
true
[ "If you do `self.max_retries = Retry.from_int(max_retries)` doesn't this mean that you can only pass an integer number of retries?\n", "I realize that using `0` will make it a magic number in this case. Perhaps on the sentinel object we set a `value`, e.g.,\n\n``` python\nDEFAULT_RETRIES = object()\nDEFAULT_RETRI...
https://api.github.com/repos/psf/requests/issues/2215
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2215/labels{/name}
https://api.github.com/repos/psf/requests/issues/2215/comments
https://api.github.com/repos/psf/requests/issues/2215/events
https://github.com/psf/requests/issues/2215
42,405,822
MDU6SXNzdWU0MjQwNTgyMg==
2,215
Using st_size on FIFO files or stdin will cause super_len to return 0 as the length
{ "avatar_url": "https://avatars.githubusercontent.com/u/3018448?v=4", "events_url": "https://api.github.com/users/cecton/events{/privacy}", "followers_url": "https://api.github.com/users/cecton/followers", "following_url": "https://api.github.com/users/cecton/following{/other_user}", "gists_url": "https://api.github.com/users/cecton/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cecton", "id": 3018448, "login": "cecton", "node_id": "MDQ6VXNlcjMwMTg0NDg=", "organizations_url": "https://api.github.com/users/cecton/orgs", "received_events_url": "https://api.github.com/users/cecton/received_events", "repos_url": "https://api.github.com/users/cecton/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cecton/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cecton/subscriptions", "type": "User", "url": "https://api.github.com/users/cecton", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "0b02e1", "default": false, "description": null...
closed
true
null
[]
null
14
2014-09-10T12:10:28Z
2021-09-08T20:01:02Z
2015-12-02T14:35:41Z
NONE
resolved
Hello, ### Use Case I run a process using `subprocess` and give the stdout as data of a POST request. Since it is a file-descriptor, it has a fileno, and `super_len()` "stat" the file descriptor and use the st_size to determine the length. The problem is: if the st_size returned is 0, it is possibly due to other reasons, in this case: the length is not determined (despite st_size is 0). But `requests` send a header specifying a `Content-Length` of 0 whilst it is actually not determined. ### Work Around Wrap the stream in a generator, so the method `fileno()` cannot be accessed anymore. ``` python request.post(url, data=(x for x in p.stdout)) ``` ### Another Use Case ``` [14:05:31] ~ > mkfifo /tmp/a [14:05:35] ~ > stat /tmp/a File: ‘/tmp/a’ Size: 0 Blocks: 0 IO Block: 4096 fifo Device: 1eh/30d Inode: 514910 Links: 1 Access: (0644/prw-r--r--) Uid: ( 1001/ openerp) Gid: ( 100/ users) Access: 2014-09-10 14:05:35.415835558 +0200 Modify: 2014-09-10 14:05:35.415835558 +0200 Change: 2014-09-10 14:05:35.415835558 +0200 Birth: - ``` The size of a named pipe is 0. ### Fix According to `man 2 stat`: > For most files under the /proc directory, stat() does not return the file size in the st_size field; instead the field is returned with the value 0. I guess `super_len()` should return st_size if st_size if bigger than 0, otherwise `None`.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2215/reactions" }
https://api.github.com/repos/psf/requests/issues/2215/timeline
null
completed
null
null
false
[ "Thanks for reporting this issue!\n\nThis is an interesting case. Here are my thoughts. First, on the positive side, the effect of this change is that we'd switch to chunked encoding for the upload. This is good, that's clearly the correct behaviour when passed a named pipe.\n\nOn the downside, how should we react ...
https://api.github.com/repos/psf/requests/issues/2214
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2214/labels{/name}
https://api.github.com/repos/psf/requests/issues/2214/comments
https://api.github.com/repos/psf/requests/issues/2214/events
https://github.com/psf/requests/issues/2214
42,318,247
MDU6SXNzdWU0MjMxODI0Nw==
2,214
verify=False and requests.packages.urllib3.disable_warnings()
{ "avatar_url": "https://avatars.githubusercontent.com/u/2525006?v=4", "events_url": "https://api.github.com/users/invisiblethreat/events{/privacy}", "followers_url": "https://api.github.com/users/invisiblethreat/followers", "following_url": "https://api.github.com/users/invisiblethreat/following{/other_user}", "gists_url": "https://api.github.com/users/invisiblethreat/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/invisiblethreat", "id": 2525006, "login": "invisiblethreat", "node_id": "MDQ6VXNlcjI1MjUwMDY=", "organizations_url": "https://api.github.com/users/invisiblethreat/orgs", "received_events_url": "https://api.github.com/users/invisiblethreat/received_events", "repos_url": "https://api.github.com/users/invisiblethreat/repos", "site_admin": false, "starred_url": "https://api.github.com/users/invisiblethreat/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/invisiblethreat/subscriptions", "type": "User", "url": "https://api.github.com/users/invisiblethreat", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "e102d8", "default": false, "description": null...
closed
true
null
[]
null
57
2014-09-09T15:23:03Z
2017-01-21T16:42:04Z
2016-01-30T02:49:22Z
NONE
null
As of 1.9 of `urllib3`, the following warning appears once per invocation: ``` /usr/local/lib/python2.7/site-packages/requests-2.4.0-py2.7.egg/requests/packages/urllib3/connectionpool.py:730: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.org/en/latest/security.html (This warning will only appear once by default.) InsecureRequestWarning) ``` When using `verify=False` would it be useful to also set `requests.packages.urllib3.disable_warnings()`? I understand that this is a design decision that not everyone might agree with. :)
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2214/reactions" }
https://api.github.com/repos/psf/requests/issues/2214/timeline
null
completed
null
null
false
[ "I think you can disable these at a global level with the `warnings` module. Further, to work with logging (if I remember correctly) you need to reach into `urllib3` (and we document that), so I'm not against documenting this for users who are not going to use certificate verification for HTTPS connections.\n", "...
https://api.github.com/repos/psf/requests/issues/2213
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2213/labels{/name}
https://api.github.com/repos/psf/requests/issues/2213/comments
https://api.github.com/repos/psf/requests/issues/2213/events
https://github.com/psf/requests/pull/2213
42,279,429
MDExOlB1bGxSZXF1ZXN0MjA5Mzg2MDA=
2,213
Request->Response.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2014-09-09T07:45:27Z
2021-09-08T10:01:20Z
2014-09-09T07:45:30Z
MEMBER
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2213/reactions" }
https://api.github.com/repos/psf/requests/issues/2213/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2213.diff", "html_url": "https://github.com/psf/requests/pull/2213", "merged_at": "2014-09-09T07:45:30Z", "patch_url": "https://github.com/psf/requests/pull/2213.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2213" }
true
[]
https://api.github.com/repos/psf/requests/issues/2212
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2212/labels{/name}
https://api.github.com/repos/psf/requests/issues/2212/comments
https://api.github.com/repos/psf/requests/issues/2212/events
https://github.com/psf/requests/issues/2212
42,265,356
MDU6SXNzdWU0MjI2NTM1Ng==
2,212
Documentation error
{ "avatar_url": "https://avatars.githubusercontent.com/u/3065290?v=4", "events_url": "https://api.github.com/users/jgaul/events{/privacy}", "followers_url": "https://api.github.com/users/jgaul/followers", "following_url": "https://api.github.com/users/jgaul/following{/other_user}", "gists_url": "https://api.github.com/users/jgaul/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jgaul", "id": 3065290, "login": "jgaul", "node_id": "MDQ6VXNlcjMwNjUyOTA=", "organizations_url": "https://api.github.com/users/jgaul/orgs", "received_events_url": "https://api.github.com/users/jgaul/received_events", "repos_url": "https://api.github.com/users/jgaul/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jgaul/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jgaul/subscriptions", "type": "User", "url": "https://api.github.com/users/jgaul", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-09-09T02:40:32Z
2021-09-08T23:08:10Z
2014-09-09T07:45:50Z
NONE
resolved
Hi there! Apologies that this probably isn't the ideal place to file this, but I think there's a documentation error at http://requests.readthedocs.org/en/latest/user/quickstart/#make-a-request. Where it reads "Now, we have a Request object called r", I think it should be "Now, we have a Response object called r", per [the code](https://github.com/kennethreitz/requests/blob/359659cf4b9dbeeef1ed832501dc1f99b0f0beac/requests/api.py#L19) and a test like this: >>> requests.get('https://api.github.com/events') <Response [200]>
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2212/reactions" }
https://api.github.com/repos/psf/requests/issues/2212/timeline
null
completed
null
null
false
[ "Great spot, thank you!\n\nIt should be fixed now. =)\n", ":thumbsup:! you're welcome--have a good one!\n" ]
https://api.github.com/repos/psf/requests/issues/2211
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2211/labels{/name}
https://api.github.com/repos/psf/requests/issues/2211/comments
https://api.github.com/repos/psf/requests/issues/2211/events
https://github.com/psf/requests/issues/2211
42,225,593
MDU6SXNzdWU0MjIyNTU5Mw==
2,211
Subdomain that ends with dash works in OSX but not Linux
{ "avatar_url": "https://avatars.githubusercontent.com/u/7129564?v=4", "events_url": "https://api.github.com/users/feus4177/events{/privacy}", "followers_url": "https://api.github.com/users/feus4177/followers", "following_url": "https://api.github.com/users/feus4177/following{/other_user}", "gists_url": "https://api.github.com/users/feus4177/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/feus4177", "id": 7129564, "login": "feus4177", "node_id": "MDQ6VXNlcjcxMjk1NjQ=", "organizations_url": "https://api.github.com/users/feus4177/orgs", "received_events_url": "https://api.github.com/users/feus4177/received_events", "repos_url": "https://api.github.com/users/feus4177/repos", "site_admin": false, "starred_url": "https://api.github.com/users/feus4177/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/feus4177/subscriptions", "type": "User", "url": "https://api.github.com/users/feus4177", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2014-09-08T18:09:45Z
2021-09-08T23:08:07Z
2014-09-12T20:13:19Z
NONE
resolved
For example the URL dev-.domain.com would work in OSX but not Linux. The URL dev-sub.domain.com works in both. The problem occurs in both requests 2.1.0 and 2.3.0.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2211/reactions" }
https://api.github.com/repos/psf/requests/issues/2211/timeline
null
completed
null
null
false
[ "Wow, this is a specific problem. When you say \"Doesn't work\", what exactly does that mean?\n", "I am pretty sure labels ending with a dash are forbidden. I'll look into the spec\n", "I get the Max retries exceeded exception.\n", "@feus4177 Can you provide the entire traceback, including the full text of th...
https://api.github.com/repos/psf/requests/issues/2210
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2210/labels{/name}
https://api.github.com/repos/psf/requests/issues/2210/comments
https://api.github.com/repos/psf/requests/issues/2210/events
https://github.com/psf/requests/pull/2210
42,146,542
MDExOlB1bGxSZXF1ZXN0MjA4NjE5NjE=
2,210
Fix #2207
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "009800", "default": false, "description": null, "id": 44501218, "name": "Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTIxOA==", "url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge" }, { "color": "207de5", "default": false, "description...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
3
2014-09-07T17:03:09Z
2021-09-08T10:01:16Z
2014-09-09T14:24:24Z
CONTRIBUTOR
resolved
@Lukasa wrote the fix in #2207 With this, the expected behaviour is restored (a `TooManyRedirects` error); ``` pycon >>> import requests >>> r = requests.get('http://www.dx.com/p/-268479') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "./requests/api.py", line 59, in get return request('get', url, **kwargs) File "./requests/api.py", line 48, in request return session.request(method=method, url=url, **kwargs) File "./requests/sessions.py", line 451, in request resp = self.send(prep, **send_kwargs) File "./requests/sessions.py", line 583, in send history = [resp for resp in gen] if allow_redirects else [] File "./requests/sessions.py", line 583, in <listcomp> history = [resp for resp in gen] if allow_redirects else [] File "./requests/sessions.py", line 111, in resolve_redirects raise TooManyRedirects('Exceeded %s redirects.' % self.max_redirects) requests.exceptions.TooManyRedirects: Exceeded 30 redirects. ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2210/reactions" }
https://api.github.com/repos/psf/requests/issues/2210/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2210.diff", "html_url": "https://github.com/psf/requests/pull/2210", "merged_at": "2014-09-09T14:24:24Z", "patch_url": "https://github.com/psf/requests/pull/2210.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2210" }
true
[ "I'm an obvious +1. :cake: :stars:\n", "should we add a test for this ? \n", "> should we add a test for this ?\n\nI'm wont to add a test that will cause our tests to slow-down and may eventually break the tests (if the domain in the original bug fixes its redirects).\n" ]
https://api.github.com/repos/psf/requests/issues/2209
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2209/labels{/name}
https://api.github.com/repos/psf/requests/issues/2209/comments
https://api.github.com/repos/psf/requests/issues/2209/events
https://github.com/psf/requests/pull/2209
42,143,236
MDExOlB1bGxSZXF1ZXN0MjA4NjA1MjM=
2,209
Download time of response body is not included in Response.elapsed
{ "avatar_url": "https://avatars.githubusercontent.com/u/54217?v=4", "events_url": "https://api.github.com/users/heyman/events{/privacy}", "followers_url": "https://api.github.com/users/heyman/followers", "following_url": "https://api.github.com/users/heyman/following{/other_user}", "gists_url": "https://api.github.com/users/heyman/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/heyman", "id": 54217, "login": "heyman", "node_id": "MDQ6VXNlcjU0MjE3", "organizations_url": "https://api.github.com/users/heyman/orgs", "received_events_url": "https://api.github.com/users/heyman/received_events", "repos_url": "https://api.github.com/users/heyman/repos", "site_admin": false, "starred_url": "https://api.github.com/users/heyman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/heyman/subscriptions", "type": "User", "url": "https://api.github.com/users/heyman", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 44501305, "name": "Not Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTMwNQ==", "url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge" }, { "color": "e11d21", "default": false, "d...
closed
true
null
[]
null
17
2014-09-07T14:25:36Z
2021-09-08T08:00:55Z
2015-04-05T16:03:15Z
CONTRIBUTOR
resolved
When doing a request with stream=False, to an endpoint that responds with a streaming/chunked response, the download time of the response body is not included in the Response.elapsed timedelta. This pull request adds a test for this that currently fails. In Requests 2.2 the behaviour was different, and this test passes. If the current behaviour is the intended, I guess one could just modify the test in this pull request to reflect the expected behaviour.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2209/reactions" }
https://api.github.com/repos/psf/requests/issues/2209/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2209.diff", "html_url": "https://github.com/psf/requests/pull/2209", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2209.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2209" }
true
[ "I don't believe the behaviour in 2.2 was intentional. In all likelihood it was entirely accidental. That aside, I'll have to do some research before I'm confident that we want to either restore that behaviour or keep the current one.\n\nWith that in mind, can you please rewrite your test to follow the style of the...
https://api.github.com/repos/psf/requests/issues/2208
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2208/labels{/name}
https://api.github.com/repos/psf/requests/issues/2208/comments
https://api.github.com/repos/psf/requests/issues/2208/events
https://github.com/psf/requests/pull/2208
42,129,526
MDExOlB1bGxSZXF1ZXN0MjA4NTQ1MTM=
2,208
Changes the fallback text encoding to cp1252
{ "avatar_url": "https://avatars.githubusercontent.com/u/236970?v=4", "events_url": "https://api.github.com/users/mlissner/events{/privacy}", "followers_url": "https://api.github.com/users/mlissner/followers", "following_url": "https://api.github.com/users/mlissner/following{/other_user}", "gists_url": "https://api.github.com/users/mlissner/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mlissner", "id": 236970, "login": "mlissner", "node_id": "MDQ6VXNlcjIzNjk3MA==", "organizations_url": "https://api.github.com/users/mlissner/orgs", "received_events_url": "https://api.github.com/users/mlissner/received_events", "repos_url": "https://api.github.com/users/mlissner/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mlissner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mlissner/subscriptions", "type": "User", "url": "https://api.github.com/users/mlissner", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2014-09-06T23:12:58Z
2021-09-08T10:01:21Z
2014-09-07T05:41:49Z
CONTRIBUTOR
resolved
In my use of Requests, [I noticed at some point](https://stackoverflow.com/questions/11588458/how-to-handle-encodings-using-python-requests-library) that text that was encoded as cp1252 was coming back as ISO-8859-1. While in many cases, that's a fine fallback encoding, cp1252 is a superset of ISO-8859-1, making it right even more often. Walking through the scenarios, just to make sure I'm not missing something: 1. Text is encoded as cp1252, but is misidentified as ISO-8859-1. Result: Characters from the cp1252 superset will be mojibake. 2. Text is encoded as cp1252 and is identified as cp1252. Result: All good. 3. Text is encoded as ISO-8859-1, but is misidentified as cp1252. Result: All good. Superset in cp1252 encoding won't cause a problem. 4. Text is encoded as ISO-8859-1 and is identified as ISO-8859-1. Result: All good. So, I think this can only do good, but encodings have never been my friend, and I'd be only slightly surprised if I missed something.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2208/reactions" }
https://api.github.com/repos/psf/requests/issues/2208/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2208.diff", "html_url": "https://github.com/psf/requests/pull/2208", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2208.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2208" }
true
[ "Thanks for this!\n\nUnfortunately you've stumbled into a thorny problem. Most of the background is in #2086. The short position here is that we used to fall back to ISO-8859-1 because the spec told us to, but that spec note got removed. For that reason we plan to remove the fallback entirely, not change it to anot...
https://api.github.com/repos/psf/requests/issues/2207
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2207/labels{/name}
https://api.github.com/repos/psf/requests/issues/2207/comments
https://api.github.com/repos/psf/requests/issues/2207/events
https://github.com/psf/requests/issues/2207
42,112,045
MDU6SXNzdWU0MjExMjA0NQ==
2,207
TooManyRedirects not working in 2.4.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/1665772?v=4", "events_url": "https://api.github.com/users/ondrejsika/events{/privacy}", "followers_url": "https://api.github.com/users/ondrejsika/followers", "following_url": "https://api.github.com/users/ondrejsika/following{/other_user}", "gists_url": "https://api.github.com/users/ondrejsika/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ondrejsika", "id": 1665772, "login": "ondrejsika", "node_id": "MDQ6VXNlcjE2NjU3NzI=", "organizations_url": "https://api.github.com/users/ondrejsika/orgs", "received_events_url": "https://api.github.com/users/ondrejsika/received_events", "repos_url": "https://api.github.com/users/ondrejsika/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ondrejsika/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ondrejsika/subscriptions", "type": "User", "url": "https://api.github.com/users/ondrejsika", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-09-06T08:30:44Z
2021-09-08T23:08:06Z
2014-09-09T14:24:24Z
NONE
resolved
hi, if i try page which has permanent redirect to it self, requests (2.4.0) cant raise TooManyRedirects exception. In 2.3.0 works fine. try: ``` import requests requests.get('http://www.dx.com/p/-268479') ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2207/reactions" }
https://api.github.com/repos/psf/requests/issues/2207/timeline
null
completed
null
null
false
[ "Hurrah! As I predicted in #2095, our redirect cache has introduced a bug.\n\nSpecifically, if a website sets a permanent redirect to itself we will spin in an infinite loop forever on line 535 of `sessions.py`, trying to find the \"real\" url.\n\nMy proposed fix would be to change the logic where we add to the red...
https://api.github.com/repos/psf/requests/issues/2206
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2206/labels{/name}
https://api.github.com/repos/psf/requests/issues/2206/comments
https://api.github.com/repos/psf/requests/issues/2206/events
https://github.com/psf/requests/issues/2206
42,086,301
MDU6SXNzdWU0MjA4NjMwMQ==
2,206
problems with get_encodings_from_content
{ "avatar_url": "https://avatars.githubusercontent.com/u/64992?v=4", "events_url": "https://api.github.com/users/jab/events{/privacy}", "followers_url": "https://api.github.com/users/jab/followers", "following_url": "https://api.github.com/users/jab/following{/other_user}", "gists_url": "https://api.github.com/users/jab/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jab", "id": 64992, "login": "jab", "node_id": "MDQ6VXNlcjY0OTky", "organizations_url": "https://api.github.com/users/jab/orgs", "received_events_url": "https://api.github.com/users/jab/received_events", "repos_url": "https://api.github.com/users/jab/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jab/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jab/subscriptions", "type": "User", "url": "https://api.github.com/users/jab", "user_view_type": "public" }
[]
closed
true
null
[]
null
16
2014-09-05T20:23:59Z
2021-09-08T05:00:42Z
2014-09-11T17:33:21Z
NONE
resolved
Here is the code for `get_encodings_from_content` in the requests.utils module: ``` python def get_encodings_from_content(content): """Returns encodings from given content string. :param content: bytestring to extract encodings from. """ charset_re = re.compile(r'<meta.*?charset=["\']*(.+?)["\'>]', flags=re.I) pragma_re = re.compile(r'<meta.*?content=["\']*;?charset=(.+?)["\'>]', flags=re.I) xml_re = re.compile(r'^<\?xml.*?encoding=["\']*(.+?)["\'>]') return (charset_re.findall(content) + pragma_re.findall(content) + xml_re.findall(content)) ``` Is there any reason to recompile the regexes on every call rather than making them module-level constants? More fundamentally, wouldn't it be more useful to have a function that just returned the first match, rather than a tuple of all matches, and therefore could often stop processing the input after a few lines, rather than always having to do three passes through the entire thing? That way, if you're fetching a large html document using `stream=True` from a server that may not have sent the charset in a Content-Type header, we can write: ``` python encoding = get_encoding_from_headers(res.headers) or \ get_encoding_from_content(raw) # just get the first encoding declared in content, if any ``` which is all we care about. (Assume `raw` has been set already with something like: ``` python bio = BytesIO() bytesread = 0 for chunk in res.iter_content(chunk_size=CHUNK_SIZE): bio.write(chunk) bytesread += len(chunk) if bytesread > RES_MAX_BYTES: return _too_big() raw = bio.getvalue() ``` )
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2206/reactions" }
https://api.github.com/repos/psf/requests/issues/2206/timeline
null
completed
null
null
false
[ "Oy, I just realized `get_encoding_from_headers()` returns a fallback value of 'ISO-8859-1' if no encoding was found in the headers, and there's no way to control this behavior:\n\n``` python\ndef get_encoding_from_headers(headers):\n \"\"\"Returns encodings from given HTTP Header Dict.\n\n :param headers: di...
https://api.github.com/repos/psf/requests/issues/2205
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2205/labels{/name}
https://api.github.com/repos/psf/requests/issues/2205/comments
https://api.github.com/repos/psf/requests/issues/2205/events
https://github.com/psf/requests/issues/2205
42,080,188
MDU6SXNzdWU0MjA4MDE4OA==
2,205
problems with get_unicode_from_response
{ "avatar_url": "https://avatars.githubusercontent.com/u/64992?v=4", "events_url": "https://api.github.com/users/jab/events{/privacy}", "followers_url": "https://api.github.com/users/jab/followers", "following_url": "https://api.github.com/users/jab/following{/other_user}", "gists_url": "https://api.github.com/users/jab/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jab", "id": 64992, "login": "jab", "node_id": "MDQ6VXNlcjY0OTky", "organizations_url": "https://api.github.com/users/jab/orgs", "received_events_url": "https://api.github.com/users/jab/received_events", "repos_url": "https://api.github.com/users/jab/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jab/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jab/subscriptions", "type": "User", "url": "https://api.github.com/users/jab", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-09-05T19:19:29Z
2021-09-08T23:06:52Z
2014-12-07T18:56:04Z
NONE
resolved
It looks like there are some problems with the `get_unicode_from_response()` function from requests.utils. The docstring says: ``` Returns the requested content back in unicode. :param r: Response object to get unicode content from. Tried: 1. charset from content-type 2. every encodings from ``<meta ... charset=XXX>`` 3. fall back and replace all unicode characters ``` but here is the code: ``` python def get_unicode_from_response(): tried_encodings = [] # Try charset from content-type encoding = get_encoding_from_headers(r.headers) if encoding: try: return str(r.content, encoding) except UnicodeError: tried_encodings.append(encoding) # Fall back: try: return str(r.content, encoding, errors='replace') except TypeError: return r.content ``` Step 1 and step 3 of the docstring are there, but it looks like step 2 is missing. It looks like the intention was to call `get_encodings_from_content` if the result of `get_encoding_from_headers` didn't pan out, but it's not actually doing that. A more minor issue is the `tried_encodings` list doesn't appear to be serving any benefit, so I'm not sure it's worth its memory / GC cost. Please advise if you'd accept a pull request or have feedback otherwise. Thanks! P.S. In researching this issue I noticed that a tag for v2.4.0 is missing: https://github.com/kennethreitz/requests/tags Here is a reference to this code in the most recent tag available: https://github.com/kennethreitz/requests/blob/v2.3.0/requests/utils.py#L346..L376
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2205/reactions" }
https://api.github.com/repos/psf/requests/issues/2205/timeline
null
completed
null
null
false
[ "> Step 1 and step 3 of the docstring are there, but it looks like step 2 is missing.\n\nGood catch.\n\n> A more minor issue is the tried_encodings list doesn't appear to be serving any benefit, so I'm not sure it's worth its memory / GC cost.\n\nYou're right that it's unnecessary, but it's not incurring any great ...
https://api.github.com/repos/psf/requests/issues/2204
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2204/labels{/name}
https://api.github.com/repos/psf/requests/issues/2204/comments
https://api.github.com/repos/psf/requests/issues/2204/events
https://github.com/psf/requests/issues/2204
41,973,348
MDU6SXNzdWU0MTk3MzM0OA==
2,204
2.4.0 request refused raises different exception (breaking change)
{ "avatar_url": "https://avatars.githubusercontent.com/u/450860?v=4", "events_url": "https://api.github.com/users/ThisGuyCodes/events{/privacy}", "followers_url": "https://api.github.com/users/ThisGuyCodes/followers", "following_url": "https://api.github.com/users/ThisGuyCodes/following{/other_user}", "gists_url": "https://api.github.com/users/ThisGuyCodes/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ThisGuyCodes", "id": 450860, "login": "ThisGuyCodes", "node_id": "MDQ6VXNlcjQ1MDg2MA==", "organizations_url": "https://api.github.com/users/ThisGuyCodes/orgs", "received_events_url": "https://api.github.com/users/ThisGuyCodes/received_events", "repos_url": "https://api.github.com/users/ThisGuyCodes/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ThisGuyCodes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ThisGuyCodes/subscriptions", "type": "User", "url": "https://api.github.com/users/ThisGuyCodes", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2014-09-04T19:04:22Z
2021-09-08T23:08:03Z
2014-09-04T19:22:52Z
NONE
resolved
(related: #2190) in 2.3.0 the following code worked: ``` python server_is_down = True while server_is_down: try: requests.get(somehost) except requests.ConnectionError: sleep(0.1) continue server_is_down = False ``` in 2.4.0 this instead raises some urllib3 error: `ProtocolError: ('Connection aborted.', error(111, 'Connection refused'))` this may just be another instance of #1572
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2204/reactions" }
https://api.github.com/repos/psf/requests/issues/2204/timeline
null
completed
null
null
false
[ "Why the hell isn't this wrapped? It looks like it should have raised a MaxRetryError which we'd have wrapped, but it just doesn't. Odd.\n", "@kevinburke Did retry logic change to not raise MaxRetryErrors when `retries=0`?\n", "@Lukasa `retries=False` does not raise `MaxRetryError`s, not sure if the same is tru...
https://api.github.com/repos/psf/requests/issues/2203
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2203/labels{/name}
https://api.github.com/repos/psf/requests/issues/2203/comments
https://api.github.com/repos/psf/requests/issues/2203/events
https://github.com/psf/requests/pull/2203
41,970,663
MDExOlB1bGxSZXF1ZXN0MjA3NjM3OTk=
2,203
Remove hard certifi dependency and document.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2014-09-04T18:41:19Z
2021-09-08T10:01:23Z
2014-09-05T15:11:57Z
MEMBER
resolved
As discussed in #2124.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2203/reactions" }
https://api.github.com/repos/psf/requests/issues/2203/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2203.diff", "html_url": "https://github.com/psf/requests/pull/2203", "merged_at": "2014-09-05T15:11:57Z", "patch_url": "https://github.com/psf/requests/pull/2203.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2203" }
true
[ "@kevinburke Done. =)\n", "Perhaps a separate extra for certifi? `pip install requests[with_certifi]`\n", "beautiful\n", "`requests[certs]`\n", "meh, let's just include it in the existing security one\n", "all 'o nothin'!\n" ]
https://api.github.com/repos/psf/requests/issues/2202
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2202/labels{/name}
https://api.github.com/repos/psf/requests/issues/2202/comments
https://api.github.com/repos/psf/requests/issues/2202/events
https://github.com/psf/requests/issues/2202
41,946,311
MDU6SXNzdWU0MTk0NjMxMQ==
2,202
HISTORY.rst contains character unprocessable by ascii library
{ "avatar_url": "https://avatars.githubusercontent.com/u/3494636?v=4", "events_url": "https://api.github.com/users/broink/events{/privacy}", "followers_url": "https://api.github.com/users/broink/followers", "following_url": "https://api.github.com/users/broink/following{/other_user}", "gists_url": "https://api.github.com/users/broink/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/broink", "id": 3494636, "login": "broink", "node_id": "MDQ6VXNlcjM0OTQ2MzY=", "organizations_url": "https://api.github.com/users/broink/orgs", "received_events_url": "https://api.github.com/users/broink/received_events", "repos_url": "https://api.github.com/users/broink/repos", "site_admin": false, "starred_url": "https://api.github.com/users/broink/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/broink/subscriptions", "type": "User", "url": "https://api.github.com/users/broink", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-09-04T14:56:16Z
2021-09-08T23:10:36Z
2014-09-04T14:59:17Z
NONE
resolved
Hi Tried to install today, and got an ascii error on illegal character in HISTORY.rst. Traceback (most recent call last): File "setup.py", line 33, in <module> history = f.read() File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 472: ordinal not in range(128) Turns out it is the line just before 'Session.merge_enfiroment_settings' under 2.4.0 (2014-08-29). It is not a normal "-" but some other kind of horizontal line. Creating an empty HISTORY.rst solves the problem.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2202/reactions" }
https://api.github.com/repos/psf/requests/issues/2202/timeline
null
completed
null
null
false
[ "Thanks for this! It's a known issue, and will be fixed by #2199.\n" ]
https://api.github.com/repos/psf/requests/issues/2201
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2201/labels{/name}
https://api.github.com/repos/psf/requests/issues/2201/comments
https://api.github.com/repos/psf/requests/issues/2201/events
https://github.com/psf/requests/issues/2201
41,875,098
MDU6SXNzdWU0MTg3NTA5OA==
2,201
WARNING - [Errno 1] _ssl.c:504: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
{ "avatar_url": "https://avatars.githubusercontent.com/u/519545?v=4", "events_url": "https://api.github.com/users/stantonk/events{/privacy}", "followers_url": "https://api.github.com/users/stantonk/followers", "following_url": "https://api.github.com/users/stantonk/following{/other_user}", "gists_url": "https://api.github.com/users/stantonk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/stantonk", "id": 519545, "login": "stantonk", "node_id": "MDQ6VXNlcjUxOTU0NQ==", "organizations_url": "https://api.github.com/users/stantonk/orgs", "received_events_url": "https://api.github.com/users/stantonk/received_events", "repos_url": "https://api.github.com/users/stantonk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/stantonk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stantonk/subscriptions", "type": "User", "url": "https://api.github.com/users/stantonk", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2014-09-03T22:22:58Z
2014-11-26T04:25:24Z
2014-09-05T18:02:44Z
NONE
null
As of August 30, 2014, seeing this error on every request. Server is Ubuntu 12.04: ``` $ cat /etc/*-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=12.04 DISTRIB_CODENAME=precise DISTRIB_DESCRIPTION="Ubuntu 12.04.5 LTS" NAME="Ubuntu" VERSION="12.04.5 LTS, Precise Pangolin" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu precise (12.04.5 LTS)" VERSION_ID="12.04" ``` Running requests 2.0.1. Tried upgrading to 2.1.0 as I saw CA Bundle was updated then, to no avail. ``` >>> import requests >>> requests.__version__ '2.1.0' ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/519545?v=4", "events_url": "https://api.github.com/users/stantonk/events{/privacy}", "followers_url": "https://api.github.com/users/stantonk/followers", "following_url": "https://api.github.com/users/stantonk/following{/other_user}", "gists_url": "https://api.github.com/users/stantonk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/stantonk", "id": 519545, "login": "stantonk", "node_id": "MDQ6VXNlcjUxOTU0NQ==", "organizations_url": "https://api.github.com/users/stantonk/orgs", "received_events_url": "https://api.github.com/users/stantonk/received_events", "repos_url": "https://api.github.com/users/stantonk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/stantonk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stantonk/subscriptions", "type": "User", "url": "https://api.github.com/users/stantonk", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2201/reactions" }
https://api.github.com/repos/psf/requests/issues/2201/timeline
null
completed
null
null
false
[ "Is it safe to assume that you're using `apt` to install requests? If so, I'm not sure they will continue to vendor the `cacert.pem` file like we do. So it could be that they force the default to be the system store. I'll fire up a virtual machine soon to check on this.\n\nFor the record, the latest version is 2.4....
https://api.github.com/repos/psf/requests/issues/2200
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2200/labels{/name}
https://api.github.com/repos/psf/requests/issues/2200/comments
https://api.github.com/repos/psf/requests/issues/2200/events
https://github.com/psf/requests/issues/2200
41,800,365
MDU6SXNzdWU0MTgwMDM2NQ==
2,200
urllib3 ProtocolError exception not caught
{ "avatar_url": "https://avatars.githubusercontent.com/u/305104?v=4", "events_url": "https://api.github.com/users/joneskoo/events{/privacy}", "followers_url": "https://api.github.com/users/joneskoo/followers", "following_url": "https://api.github.com/users/joneskoo/following{/other_user}", "gists_url": "https://api.github.com/users/joneskoo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/joneskoo", "id": 305104, "login": "joneskoo", "node_id": "MDQ6VXNlcjMwNTEwNA==", "organizations_url": "https://api.github.com/users/joneskoo/orgs", "received_events_url": "https://api.github.com/users/joneskoo/received_events", "repos_url": "https://api.github.com/users/joneskoo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/joneskoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joneskoo/subscriptions", "type": "User", "url": "https://api.github.com/users/joneskoo", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-09-03T10:06:40Z
2021-09-08T23:10:37Z
2014-09-03T10:13:14Z
NONE
resolved
On the topic of requests not mapping exceptions to its own exceptions... `requests.packages.urllib3.exceptions.ProtocolError` is not caught. Reproduction: invalid status line. Server: `$ echo | nc -l 8000` requests: ``` import requests try: requests.get('http://localhost:8000') except Exception as e: print (e.__class__) ``` Output: <class 'requests.packages.urllib3.exceptions.ProtocolError'> I would expect this to be mapped to a requests exception. Connection refused comes out also as ProtocolError. This is requests 2.4.0. Ping @Lukasa , @sigmavirus24 Also happens with connection refused. This should be covered by requests unittests in the future. ``` Traceback (most recent call last): File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 516, in urlopen body=body, headers=headers) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 308, in _make_request conn.request(method, url, **httplib_request_kw) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1090, in request self._send_request(method, url, body, headers) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1128, in _send_request self.endheaders(body) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1086, in endheaders self._send_output(message_body) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 924, in _send_output self.send(msg) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 859, in send self.connect() File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 154, in connect conn = self._new_conn() File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 133, in _new_conn (self.host, self.port), self.timeout, **extra_kw) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 87, in create_connection raise err File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 78, in create_connection sock.connect(sa) ConnectionRefusedError: [Errno 61] Connection refused During handling of the above exception, another exception occurred: Traceback (most recent call last): File "<ipython-input-14-1e96a12a07a3>", line 1, in <module> try: requests.get('http://localhost:8000') File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/api.py", line 55, in get return request('get', url, **kwargs) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/sessions.py", line 448, in request resp = self.send(prep, **send_kwargs) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/sessions.py", line 554, in send r = adapter.send(request, **kwargs) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/adapters.py", line 359, in send timeout=timeout File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 559, in urlopen _pool=self, _stacktrace=stacktrace) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 245, in increment raise six.reraise(type(error), error, _stacktrace) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/packages/six.py", line 309, in reraise raise value.with_traceback(tb) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 516, in urlopen body=body, headers=headers) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 308, in _make_request conn.request(method, url, **httplib_request_kw) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1090, in request self._send_request(method, url, body, headers) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1128, in _send_request self.endheaders(body) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1086, in endheaders self._send_output(message_body) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 924, in _send_output self.send(msg) File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 859, in send self.connect() File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 154, in connect conn = self._new_conn() File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 133, in _new_conn (self.host, self.port), self.timeout, **extra_kw) File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 87, in create_connection raise err File "/Users/joneskoo/git/requests/ve/lib/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 78, in create_connection sock.connect(sa) requests.packages.urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionRefusedError(61, 'Connection refused')) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/305104?v=4", "events_url": "https://api.github.com/users/joneskoo/events{/privacy}", "followers_url": "https://api.github.com/users/joneskoo/followers", "following_url": "https://api.github.com/users/joneskoo/following{/other_user}", "gists_url": "https://api.github.com/users/joneskoo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/joneskoo", "id": 305104, "login": "joneskoo", "node_id": "MDQ6VXNlcjMwNTEwNA==", "organizations_url": "https://api.github.com/users/joneskoo/orgs", "received_events_url": "https://api.github.com/users/joneskoo/received_events", "repos_url": "https://api.github.com/users/joneskoo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/joneskoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joneskoo/subscriptions", "type": "User", "url": "https://api.github.com/users/joneskoo", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2200/reactions" }
https://api.github.com/repos/psf/requests/issues/2200/timeline
null
completed
null
null
false
[ "Sorry, missed #2192 . Duplicate.\n" ]
https://api.github.com/repos/psf/requests/issues/2199
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2199/labels{/name}
https://api.github.com/repos/psf/requests/issues/2199/comments
https://api.github.com/repos/psf/requests/issues/2199/events
https://github.com/psf/requests/pull/2199
41,789,547
MDExOlB1bGxSZXF1ZXN0MjA2NjAyNjU=
2,199
Open README and HISTORY as utf-8 encoded files (fixes #2196)
{ "avatar_url": "https://avatars.githubusercontent.com/u/51503?v=4", "events_url": "https://api.github.com/users/mtorromeo/events{/privacy}", "followers_url": "https://api.github.com/users/mtorromeo/followers", "following_url": "https://api.github.com/users/mtorromeo/following{/other_user}", "gists_url": "https://api.github.com/users/mtorromeo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mtorromeo", "id": 51503, "login": "mtorromeo", "node_id": "MDQ6VXNlcjUxNTAz", "organizations_url": "https://api.github.com/users/mtorromeo/orgs", "received_events_url": "https://api.github.com/users/mtorromeo/received_events", "repos_url": "https://api.github.com/users/mtorromeo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mtorromeo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mtorromeo/subscriptions", "type": "User", "url": "https://api.github.com/users/mtorromeo", "user_view_type": "public" }
[ { "color": "009800", "default": false, "description": null, "id": 44501218, "name": "Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTIxOA==", "url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge" }, { "color": "207de5", "default": false, "description...
closed
true
null
[]
null
4
2014-09-03T07:42:02Z
2021-09-08T10:01:24Z
2014-09-04T18:41:46Z
CONTRIBUTOR
resolved
This is a fix for #2196 where if you tried running setup.py with some LANG it would throws an exception when reading HISTORY with non-ascii characters. Try it with ``` LANG=C python setup.py ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2199/reactions" }
https://api.github.com/repos/psf/requests/issues/2199/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2199.diff", "html_url": "https://github.com/psf/requests/pull/2199", "merged_at": "2014-09-04T18:41:46Z", "patch_url": "https://github.com/psf/requests/pull/2199.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2199" }
true
[ "The build broke but that's pypy specific and unrelated to this change\n\nLGTM! :cake:\n", "Are you sure the upload to PyPI won't fail?\n", "@sigmavirus24 Why do we think it might?\n", "Nevermind, I asked @r1chardj0n3s and he assuaged my concerns.\n" ]
https://api.github.com/repos/psf/requests/issues/2198
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2198/labels{/name}
https://api.github.com/repos/psf/requests/issues/2198/comments
https://api.github.com/repos/psf/requests/issues/2198/events
https://github.com/psf/requests/issues/2198
41,691,956
MDU6SXNzdWU0MTY5MTk1Ng==
2,198
requests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:598)
{ "avatar_url": "https://avatars.githubusercontent.com/u/8625986?v=4", "events_url": "https://api.github.com/users/gdparker/events{/privacy}", "followers_url": "https://api.github.com/users/gdparker/followers", "following_url": "https://api.github.com/users/gdparker/following{/other_user}", "gists_url": "https://api.github.com/users/gdparker/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gdparker", "id": 8625986, "login": "gdparker", "node_id": "MDQ6VXNlcjg2MjU5ODY=", "organizations_url": "https://api.github.com/users/gdparker/orgs", "received_events_url": "https://api.github.com/users/gdparker/received_events", "repos_url": "https://api.github.com/users/gdparker/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gdparker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gdparker/subscriptions", "type": "User", "url": "https://api.github.com/users/gdparker", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-09-02T09:45:52Z
2021-09-08T23:10:37Z
2014-09-02T14:08:39Z
NONE
resolved
Hi there! When i'm trying to execute the code: ``` python import requests requests.get('https://www.atarisupport.com/') ``` i get the error: ``` bash Traceback (most recent call last): File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 516, in urlopen body=body, headers=headers) File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 304, in _make_request self._validate_conn(conn) File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 722, in _validate_conn conn.connect() File "C:\Python34\lib\site-packages\requests\packages\urllib3\connection.py", line 229, in connect ssl_version=resolved_ssl_version) File "C:\Python34\lib\site-packages\requests\packages\urllib3\util\ssl_.py", line 123, in ssl_wrap_socket return context.wrap_socket(sock, server_hostname=server_hostname) File "C:\Python34\lib\ssl.py", line 364, in wrap_socket _context=self) File "C:\Python34\lib\ssl.py", line 578, in __init__ self.do_handshake() File "C:\Python34\lib\ssl.py", line 805, in do_handshake self._sslobj.do_handshake() ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:598) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\Python34\lib\site-packages\requests\adapters.py", line 359, in send timeout=timeout File "C:\Python34\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 543, in urlopen raise SSLError(e) requests.packages.urllib3.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:598) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "<stdin>", line 1, in <module> File "C:\Python34\lib\site-packages\requests\api.py", line 55, in get return request('get', url, **kwargs) File "C:\Python34\lib\site-packages\requests\api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "C:\Python34\lib\site-packages\requests\sessions.py", line 448, in request resp = self.send(prep, **send_kwargs) File "C:\Python34\lib\site-packages\requests\sessions.py", line 554, in send r = adapter.send(request, **kwargs) File "C:\Python34\lib\site-packages\requests\adapters.py", line 417, in send raise SSLError(e, request=request) requests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:598) ``` Any suggestions?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2198/reactions" }
https://api.github.com/repos/psf/requests/issues/2198/timeline
null
completed
null
null
false
[ "So if you do\n\n```\n$ openssl s_client -connect atarisupport.com:443\n```\n\nThe command will hang, I suspect this is strongly related to the SSLError.\n", "`atarisupport.com` does not respond to the SSL client hello. We emit the first portion of the SSL handshake, and in return the remote website sends us an i...
https://api.github.com/repos/psf/requests/issues/2197
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2197/labels{/name}
https://api.github.com/repos/psf/requests/issues/2197/comments
https://api.github.com/repos/psf/requests/issues/2197/events
https://github.com/psf/requests/pull/2197
41,607,725
MDExOlB1bGxSZXF1ZXN0MjA1NTUzNzQ=
2,197
Replaces offending character in HISTORY.rst with dash.
{ "avatar_url": "https://avatars.githubusercontent.com/u/3847427?v=4", "events_url": "https://api.github.com/users/whereskenneth/events{/privacy}", "followers_url": "https://api.github.com/users/whereskenneth/followers", "following_url": "https://api.github.com/users/whereskenneth/following{/other_user}", "gists_url": "https://api.github.com/users/whereskenneth/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/whereskenneth", "id": 3847427, "login": "whereskenneth", "node_id": "MDQ6VXNlcjM4NDc0Mjc=", "organizations_url": "https://api.github.com/users/whereskenneth/orgs", "received_events_url": "https://api.github.com/users/whereskenneth/received_events", "repos_url": "https://api.github.com/users/whereskenneth/repos", "site_admin": false, "starred_url": "https://api.github.com/users/whereskenneth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/whereskenneth/subscriptions", "type": "User", "url": "https://api.github.com/users/whereskenneth", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-09-01T05:30:06Z
2021-09-08T11:00:45Z
2014-09-03T09:30:05Z
NONE
resolved
Replaces em dash in HISTORY.rst with ascii dash.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2197/reactions" }
https://api.github.com/repos/psf/requests/issues/2197/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2197.diff", "html_url": "https://github.com/psf/requests/pull/2197", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2197.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2197" }
true
[ "#2199 is the preferred approach here I think. :cake:\n\nThanks for this though!\n" ]
https://api.github.com/repos/psf/requests/issues/2196
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2196/labels{/name}
https://api.github.com/repos/psf/requests/issues/2196/comments
https://api.github.com/repos/psf/requests/issues/2196/events
https://github.com/psf/requests/issues/2196
41,607,465
MDU6SXNzdWU0MTYwNzQ2NQ==
2,196
UnicodeDecodeError when reading HISTORY.rst (v2.4.0)
{ "avatar_url": "https://avatars.githubusercontent.com/u/3847427?v=4", "events_url": "https://api.github.com/users/whereskenneth/events{/privacy}", "followers_url": "https://api.github.com/users/whereskenneth/followers", "following_url": "https://api.github.com/users/whereskenneth/following{/other_user}", "gists_url": "https://api.github.com/users/whereskenneth/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/whereskenneth", "id": 3847427, "login": "whereskenneth", "node_id": "MDQ6VXNlcjM4NDc0Mjc=", "organizations_url": "https://api.github.com/users/whereskenneth/orgs", "received_events_url": "https://api.github.com/users/whereskenneth/received_events", "repos_url": "https://api.github.com/users/whereskenneth/repos", "site_admin": false, "starred_url": "https://api.github.com/users/whereskenneth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/whereskenneth/subscriptions", "type": "User", "url": "https://api.github.com/users/whereskenneth", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-09-01T05:21:31Z
2021-09-08T23:10:36Z
2014-09-04T18:41:47Z
NONE
resolved
Whe installing requests-2.4.0 using pip in python3.4, line 32-33 in setup.py ``` with open('HISTORY.rst') as f: history = f.read() ``` is throwing a UnicodeDecodeError caused by the elongated dash on line 18 of HISTORY.rst Offending line in HISTORY.rst ``` $ head -18 HISTORY.rst | tail -1 - Refactored settings loading from environment ��� new `Session.merge_environment_settings`. ``` Output from running the setup directly: ``` $ python setup.py install Traceback (most recent call last): File "setup.py", line 33, in <module> history = f.read() File "/usr/lib/python3.4/encodings/ascii.py", line 26, in decode return codecs.ascii_decode(input, self.errors)[0] UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 472: ordinal not in range(128) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2196/reactions" }
https://api.github.com/repos/psf/requests/issues/2196/timeline
null
completed
null
null
false
[ "Thanks! The fix you've proposed in #2197 will definitely work, but I briefly wonder whether we shouldn't try to fix the underlying problem instead. We may want to be able to use non-ascii characters in future.\n", "Sounds good. I'll use 2.3.0 for the time being. Feel free to close the pr if you decide to go anot...
https://api.github.com/repos/psf/requests/issues/2195
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2195/labels{/name}
https://api.github.com/repos/psf/requests/issues/2195/comments
https://api.github.com/repos/psf/requests/issues/2195/events
https://github.com/psf/requests/pull/2195
41,541,903
MDExOlB1bGxSZXF1ZXN0MjA1MjQ5MzI=
2,195
Add betterssl extra
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
15
2014-08-29T21:39:35Z
2021-09-08T10:01:23Z
2014-09-04T18:36:56Z
CONTRIBUTOR
resolved
Fixes #1995
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2195/reactions" }
https://api.github.com/repos/psf/requests/issues/2195/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2195.diff", "html_url": "https://github.com/psf/requests/pull/2195", "merged_at": "2014-09-04T18:36:56Z", "patch_url": "https://github.com/psf/requests/pull/2195.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2195" }
true
[ "+1\n", "Could we use another name which doesn't sound like it will solve all problems?\n", "So, I'm going to raise a question!\n\nI was the one who opened the original ticket, but I wonder if it makes sense to do this anymore. On Python 3.4+ and Python 2.7.9+ it's not better anymore. On Python 3.2 and 3.3 it's...
https://api.github.com/repos/psf/requests/issues/2194
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2194/labels{/name}
https://api.github.com/repos/psf/requests/issues/2194/comments
https://api.github.com/repos/psf/requests/issues/2194/events
https://github.com/psf/requests/pull/2194
41,539,656
MDExOlB1bGxSZXF1ZXN0MjA1MjM1MTQ=
2,194
Add test that an invalid domain raises a ConnectionError
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-08-29T21:08:05Z
2021-09-08T11:00:46Z
2014-08-29T21:50:47Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2194/reactions" }
https://api.github.com/repos/psf/requests/issues/2194/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2194.diff", "html_url": "https://github.com/psf/requests/pull/2194", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2194.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2194" }
true
[ "You could add another test for closed ports\n", "@kevinburke I'll take care of that as I pull this into my PR. Thanks\n" ]
https://api.github.com/repos/psf/requests/issues/2193
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2193/labels{/name}
https://api.github.com/repos/psf/requests/issues/2193/comments
https://api.github.com/repos/psf/requests/issues/2193/events
https://github.com/psf/requests/pull/2193
41,535,919
MDExOlB1bGxSZXF1ZXN0MjA1MjExMjE=
2,193
Capture and re-raise urllib3 ProtocolError
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "color": "009800", "default": false, "description": null, "id": 44501218, "name": "Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTIxOA==", "url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge" }, { "color": "207de5", "default": false, "description...
closed
true
null
[]
null
15
2014-08-29T20:16:54Z
2021-09-08T10:01:21Z
2014-09-04T18:39:41Z
CONTRIBUTOR
resolved
Fixes #2192
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2193/reactions" }
https://api.github.com/repos/psf/requests/issues/2193/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2193.diff", "html_url": "https://github.com/psf/requests/pull/2193", "merged_at": "2014-09-04T18:39:41Z", "patch_url": "https://github.com/psf/requests/pull/2193.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2193" }
true
[ "LGTM. :cake:\n", "+1, though the code block is the same as lines 403-405... could just catch both in one go?\n", "I added a failing test for this in #2194\n", "@kevinburke are you okay with me pulling #2194 in here to keep things simple?\n", "Yep\n\n## \n\nKevin Burke\nphone: 925.271.7005 | twentymilliseco...
https://api.github.com/repos/psf/requests/issues/2192
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2192/labels{/name}
https://api.github.com/repos/psf/requests/issues/2192/comments
https://api.github.com/repos/psf/requests/issues/2192/events
https://github.com/psf/requests/issues/2192
41,531,008
MDU6SXNzdWU0MTUzMTAwOA==
2,192
[regression] urllib3.exceptions.ProtocolError not wrapped
{ "avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4", "events_url": "https://api.github.com/users/t-8ch/events{/privacy}", "followers_url": "https://api.github.com/users/t-8ch/followers", "following_url": "https://api.github.com/users/t-8ch/following{/other_user}", "gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/t-8ch", "id": 717901, "login": "t-8ch", "node_id": "MDQ6VXNlcjcxNzkwMQ==", "organizations_url": "https://api.github.com/users/t-8ch/orgs", "received_events_url": "https://api.github.com/users/t-8ch/received_events", "repos_url": "https://api.github.com/users/t-8ch/repos", "site_admin": false, "starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions", "type": "User", "url": "https://api.github.com/users/t-8ch", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
10
2014-08-29T19:11:03Z
2021-09-08T23:08:02Z
2014-09-04T18:39:41Z
CONTRIBUTOR
resolved
``` py >>> requests.__version__ '2.4.0' >>> requests.get('http://localhost:1') # ... stacktrace requests.packages.urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionRefusedError(111, 'Connection refused')) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2192/reactions" }
https://api.github.com/repos/psf/requests/issues/2192/timeline
null
completed
null
null
false
[ "Yup I'm hitting this too. Is this going to be fixed quick or should I fix my code? :)\n", "Same issue here.\n", "I'll take a look at this this weekend. =) Thanks for reporting folks!\n", "Looking at it right now @Lukasa \n", "Ok, suits me. =) If you get there before me I'll happily accept not doing the wor...
https://api.github.com/repos/psf/requests/issues/2191
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2191/labels{/name}
https://api.github.com/repos/psf/requests/issues/2191/comments
https://api.github.com/repos/psf/requests/issues/2191/events
https://github.com/psf/requests/pull/2191
41,530,707
MDExOlB1bGxSZXF1ZXN0MjA1MTc3NDU=
2,191
add trailing comma
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-29T19:07:09Z
2021-09-08T10:01:25Z
2014-09-04T18:39:23Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2191/reactions" }
https://api.github.com/repos/psf/requests/issues/2191/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2191.diff", "html_url": "https://github.com/psf/requests/pull/2191", "merged_at": "2014-09-04T18:39:23Z", "patch_url": "https://github.com/psf/requests/pull/2191.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2191" }
true
[ "+0 It isn't that big of a deal\n" ]
https://api.github.com/repos/psf/requests/issues/2190
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2190/labels{/name}
https://api.github.com/repos/psf/requests/issues/2190/comments
https://api.github.com/repos/psf/requests/issues/2190/events
https://github.com/psf/requests/issues/2190
41,530,607
MDU6SXNzdWU0MTUzMDYwNw==
2,190
Git tag for 2.4.0 is missing on GitHub
{ "avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4", "events_url": "https://api.github.com/users/t-8ch/events{/privacy}", "followers_url": "https://api.github.com/users/t-8ch/followers", "following_url": "https://api.github.com/users/t-8ch/following{/other_user}", "gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/t-8ch", "id": 717901, "login": "t-8ch", "node_id": "MDQ6VXNlcjcxNzkwMQ==", "organizations_url": "https://api.github.com/users/t-8ch/orgs", "received_events_url": "https://api.github.com/users/t-8ch/received_events", "repos_url": "https://api.github.com/users/t-8ch/repos", "site_admin": false, "starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions", "type": "User", "url": "https://api.github.com/users/t-8ch", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2014-08-29T19:05:36Z
2021-09-08T23:08:10Z
2014-09-09T21:09:43Z
CONTRIBUTOR
resolved
See subject
{ "avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4", "events_url": "https://api.github.com/users/t-8ch/events{/privacy}", "followers_url": "https://api.github.com/users/t-8ch/followers", "following_url": "https://api.github.com/users/t-8ch/following{/other_user}", "gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/t-8ch", "id": 717901, "login": "t-8ch", "node_id": "MDQ6VXNlcjcxNzkwMQ==", "organizations_url": "https://api.github.com/users/t-8ch/orgs", "received_events_url": "https://api.github.com/users/t-8ch/received_events", "repos_url": "https://api.github.com/users/t-8ch/repos", "site_admin": false, "starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions", "type": "User", "url": "https://api.github.com/users/t-8ch", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2190/reactions" }
https://api.github.com/repos/psf/requests/issues/2190/timeline
null
completed
null
null
false
[]
https://api.github.com/repos/psf/requests/issues/2189
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2189/labels{/name}
https://api.github.com/repos/psf/requests/issues/2189/comments
https://api.github.com/repos/psf/requests/issues/2189/events
https://github.com/psf/requests/issues/2189
41,528,790
MDU6SXNzdWU0MTUyODc5MA==
2,189
All PyPy builds failing on ci.kennethreitz.org
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
2
2014-08-29T18:44:22Z
2021-09-08T23:10:35Z
2014-09-04T18:46:24Z
CONTRIBUTOR
resolved
Example output is: ``` Started by upstream project "requests-pr" build number 401 originally caused by: GitHub pull request #2188 of commit 6b1a30b7059859c18f1d44d58011ac405e750f26 automatically merged. Building in workspace /var/lib/jenkins/jobs/requests-pr/workspace/PYTHON/pypy-1.8 > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/kennethreitz/requests.git # timeout=10 Fetching upstream changes from https://github.com/kennethreitz/requests.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/kennethreitz/requests.git +refs/pull/*:refs/remotes/origin/pr/* Checking out Revision 69c7bb1506e5378c22bb6164451f1acc07bf138a (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 69c7bb1506e5378c22bb6164451f1acc07bf138a > git rev-list 56abf36d19e82fa27bbdf85c7c6528cf1d1a6e13 # timeout=10 [pypy-1.8] $ /usr/bin/pypy /var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenv.py /var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenvs/d41d8cd9 New pypy executable in /var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenvs/d41d8cd9/bin/pypy Installing setuptools, pip... Complete output from command /var/lib/jenkins/shi...vs/d41d8cd9/bin/pypy -c "import sys, pip; sys...d\"] + sys.argv[1:]))" setuptools pip: Ignoring indexes: https://pypi.python.org/simple/ Downloading/unpacking setuptools Downloading/unpacking pip Installing collected packages: setuptools, pip Cleaning up... Exception: Traceback (most recent call last): File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/pip-0-py2.py3-none-any.whl/pip/basecommand.py", line 122, in main status = self.run(options, args) File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/pip-0-py2.py3-none-any.whl/pip/commands/install.py", line 283, in run requirement_set.install(install_options, global_options, root=options.root_path) File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/pip-0-py2.py3-none-any.whl/pip/req.py", line 1435, in install requirement.install(install_options, global_options, *args, **kwargs) File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/pip-0-py2.py3-none-any.whl/pip/req.py", line 671, in install self.move_wheel_files(self.source_dir, root=root) File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/pip-0-py2.py3-none-any.whl/pip/req.py", line 901, in move_wheel_files pycompile=self.pycompile, File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/pip-0-py2.py3-none-any.whl/pip/wheel.py", line 162, in move_wheel_files compileall.compile_dir(source, force=True, quiet=True) File "/usr/lib/pypy/lib-python/2.7/compileall.py", line 60, in compile_dir quiet, legacy): File "/usr/lib/pypy/lib-python/2.7/compileall.py", line 52, in compile_dir if not compile_file(fullname, ddir, force, rx, quiet, legacy): File "/usr/lib/pypy/lib-python/2.7/compileall.py", line 91, in compile_file cfile = imp.cache_from_source(fullname) ValueError: Not a .py file: /var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenvs/d41d8cd9/build/setuptools/setuptools/cli-32.exe Storing debug log for failure in /var/lib/jenkins/.pip/pip.log ---------------------------------------- ...Installing setuptools, pip...done. Traceback (most recent call last): File "app_main.py", line 51, in run_toplevel File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenv.py", line 2338, in <module> main() File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenv.py", line 824, in main symlink=options.symlink) File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenv.py", line 992, in create_environment install_wheel(to_install, py_executable, search_dirs) File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenv.py", line 960, in install_wheel 'PIP_NO_INDEX': '1' File "/var/lib/jenkins/shiningpanda/jobs/038a7fc3/virtualenv.py", line 902, in call_subprocess % (cmd_desc, proc.returncode)) OSError: Command /var/lib/jenkins/shi...vs/d41d8cd9/bin/pypy -c "import sys, pip; sys...d\"] + sys.argv[1:]))" setuptools pip failed with error code 2 Build step 'Virtualenv Builder' marked build as failure Finished: FAILURE ``` Example failure: http://ci.kennethreitz.org/job/requests-pr/PYTHON=pypy-1.8/401/console
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2189/reactions" }
https://api.github.com/repos/psf/requests/issues/2189/timeline
null
completed
null
null
false
[ "The only person who can fix this is @kennethreitz \n", "Disabled pypy for now. Need to update it anyway. \n" ]
https://api.github.com/repos/psf/requests/issues/2188
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2188/labels{/name}
https://api.github.com/repos/psf/requests/issues/2188/comments
https://api.github.com/repos/psf/requests/issues/2188/events
https://github.com/psf/requests/pull/2188
41,528,659
MDExOlB1bGxSZXF1ZXN0MjA1MTY0MTI=
2,188
Dummy commit
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-29T18:42:37Z
2021-09-08T11:00:46Z
2014-08-29T18:45:34Z
CONTRIBUTOR
resolved
I think the Pypy build commands may be broken, testing with a new commit
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2188/reactions" }
https://api.github.com/repos/psf/requests/issues/2188/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2188.diff", "html_url": "https://github.com/psf/requests/pull/2188", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2188.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2188" }
true
[ "Yeah, looks like everything is failing, documented as https://github.com/kennethreitz/requests/issues/2189\n" ]
https://api.github.com/repos/psf/requests/issues/2187
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2187/labels{/name}
https://api.github.com/repos/psf/requests/issues/2187/comments
https://api.github.com/repos/psf/requests/issues/2187/events
https://github.com/psf/requests/pull/2187
41,528,151
MDExOlB1bGxSZXF1ZXN0MjA1MTYwOTA=
2,187
Document Timeout behaviour
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-08-29T18:36:44Z
2021-09-08T11:00:45Z
2014-09-04T18:39:12Z
CONTRIBUTOR
resolved
Adds better documentation of `timeout` behavior - "How long to wait for the server to send data before giving up, as a float, or a (connect timeout, read timeout) tuple." was as short as I could get to accurately describe the behavior. - Sphinx puts the description of timeouts on the line below the parameter name, but this is not true for other parameters. I'm curious why this is but I can't see any differences. - We don't use the `stream` parameter anywhere in the `adapters.send` method, so I removed the "Behavior" section that described the behavior of requests incorrectly. May also want to remove the parameter description from the documentation, or state that it's not actually used anywhere.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2187/reactions" }
https://api.github.com/repos/psf/requests/issues/2187/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2187.diff", "html_url": "https://github.com/psf/requests/pull/2187", "merged_at": "2014-09-04T18:39:12Z", "patch_url": "https://github.com/psf/requests/pull/2187.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2187" }
true
[ "Also, does requests use british/canadian or US spellings? I see \"behavior\" spelled both ways in the docs\n", "This change only affects documentation, the test failure looks to be global & related to a bad configuration, see https://github.com/kennethreitz/requests/issues/2189\n", "I think I can safely speak ...
https://api.github.com/repos/psf/requests/issues/2186
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2186/labels{/name}
https://api.github.com/repos/psf/requests/issues/2186/comments
https://api.github.com/repos/psf/requests/issues/2186/events
https://github.com/psf/requests/pull/2186
41,280,494
MDExOlB1bGxSZXF1ZXN0MjAzNzE0Mjg=
2,186
Change request to make keep alive more human
{ "avatar_url": "https://avatars.githubusercontent.com/u/407189?v=4", "events_url": "https://api.github.com/users/tychotatitscheff/events{/privacy}", "followers_url": "https://api.github.com/users/tychotatitscheff/followers", "following_url": "https://api.github.com/users/tychotatitscheff/following{/other_user}", "gists_url": "https://api.github.com/users/tychotatitscheff/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tychotatitscheff", "id": 407189, "login": "tychotatitscheff", "node_id": "MDQ6VXNlcjQwNzE4OQ==", "organizations_url": "https://api.github.com/users/tychotatitscheff/orgs", "received_events_url": "https://api.github.com/users/tychotatitscheff/received_events", "repos_url": "https://api.github.com/users/tychotatitscheff/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tychotatitscheff/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tychotatitscheff/subscriptions", "type": "User", "url": "https://api.github.com/users/tychotatitscheff", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-08-27T12:59:32Z
2021-09-08T11:00:48Z
2014-08-27T13:02:11Z
NONE
resolved
Not sure if this is the right way & design to do this: - I added a new property to request and session - I used existing merge function to assure that if something is set in request parameter, it will overides sessions´s ones. - I keep it disable by deafault as https://github.com/kennethreitz/requests/issues/2169#issuecomment-53496634 stated. More info in https://github.com/kennethreitz/requests/issues/2169 thread.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2186/reactions" }
https://api.github.com/repos/psf/requests/issues/2186/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2186.diff", "html_url": "https://github.com/psf/requests/pull/2186", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2186.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2186" }
true
[ "Thanks for this!\n\nThis is not normally the way we'd go about this. In particular, we're averse to adding more keyword arguments to the request methods. I don't think this approach is going to be the one we take: we should just be setting this appropriately in the headers and allowing users to override it.\n", ...
https://api.github.com/repos/psf/requests/issues/2185
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2185/labels{/name}
https://api.github.com/repos/psf/requests/issues/2185/comments
https://api.github.com/repos/psf/requests/issues/2185/events
https://github.com/psf/requests/issues/2185
41,277,532
MDU6SXNzdWU0MTI3NzUzMg==
2,185
socket.error raised from r.iter_content
{ "avatar_url": "https://avatars.githubusercontent.com/u/305104?v=4", "events_url": "https://api.github.com/users/joneskoo/events{/privacy}", "followers_url": "https://api.github.com/users/joneskoo/followers", "following_url": "https://api.github.com/users/joneskoo/following{/other_user}", "gists_url": "https://api.github.com/users/joneskoo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/joneskoo", "id": 305104, "login": "joneskoo", "node_id": "MDQ6VXNlcjMwNTEwNA==", "organizations_url": "https://api.github.com/users/joneskoo/orgs", "received_events_url": "https://api.github.com/users/joneskoo/received_events", "repos_url": "https://api.github.com/users/joneskoo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/joneskoo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joneskoo/subscriptions", "type": "User", "url": "https://api.github.com/users/joneskoo", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-08-27T12:22:05Z
2021-09-08T23:00:53Z
2014-08-27T13:00:57Z
NONE
resolved
My code ``` r = requests.get(url, stream=True) for chunk in r.iter_content(chunk_size=16*1024): if chunk: # filter out keep-alive new chunks f.write(chunk) f.flush() ``` raises an exception socket.error; I would expect it to be mapped to requests.exceptions instead. ``` for chunk in r.iter_content(chunk_size=16*1024): File "/usr/lib/python2.7/dist-packages/requests/models.py", line 616, in generate decode_content=True): File "/usr/lib/python2.7/dist-packages/urllib3/response.py", line 225, in stream data = self.read(amt=amt, decode_content=decode_content) File "/usr/lib/python2.7/dist-packages/urllib3/response.py", line 174, in read data = self._fp.read(amt) File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt) File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left) File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen) File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) error: [Errno 104] Connection reset by peer ``` @Lukasa, since you fixed another exception handling issue already, would you care to take a look at some point? Easy enough to work around but should be fixed to maintain a human API.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2185/reactions" }
https://api.github.com/repos/psf/requests/issues/2185/timeline
null
completed
null
null
false
[ "Agreed. Either we should catch it ourselves, or urllib3 should catch this stuff from read or stream. @shazow?\n", "Isn't there already an open issue for this?\n", "Ugh, we actually already fixed it. =( I just totally missed it in my code read. Should be fixed in the next release! =)\n", "with what exception ...
https://api.github.com/repos/psf/requests/issues/2184
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2184/labels{/name}
https://api.github.com/repos/psf/requests/issues/2184/comments
https://api.github.com/repos/psf/requests/issues/2184/events
https://github.com/psf/requests/issues/2184
41,223,455
MDU6SXNzdWU0MTIyMzQ1NQ==
2,184
Port test suite to pytest-httpbin
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
24
2014-08-26T21:18:47Z
2021-09-08T21:00:45Z
2015-11-05T15:37:22Z
CONTRIBUTOR
resolved
https://github.com/kevin1024/pytest-httpbin
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2184/reactions" }
https://api.github.com/repos/psf/requests/issues/2184/timeline
null
completed
null
null
false
[ "Just attempted, but can't figure out how to use default funcargs with class-style tests.\n", " Duplicate of https://github.com/kennethreitz/requests/issues/2093 ?\n", "Yup.\n", "@kennethreitz yeah, pytest makes this a bit awkward, so I just released a new version of pytest-httpbin to make this easier. Check...
https://api.github.com/repos/psf/requests/issues/2183
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2183/labels{/name}
https://api.github.com/repos/psf/requests/issues/2183/comments
https://api.github.com/repos/psf/requests/issues/2183/events
https://github.com/psf/requests/pull/2183
41,210,483
MDExOlB1bGxSZXF1ZXN0MjAzMzA4ODk=
2,183
Fix #2180.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-08-26T19:20:57Z
2021-09-08T10:01:15Z
2014-08-26T19:41:44Z
MEMBER
resolved
@kennethreitz?
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2183/reactions" }
https://api.github.com/repos/psf/requests/issues/2183/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2183.diff", "html_url": "https://github.com/psf/requests/pull/2183", "merged_at": "2014-08-26T19:41:44Z", "patch_url": "https://github.com/psf/requests/pull/2183.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2183" }
true
[ ":+1: \n", "Any reason why only the first reference to `timeline.json` is fixed? Are the [other](https://github.com/kennethreitz/requests/blame/7e24176ca137cfc1c134343d991163d5f8779333/docs/user/quickstart.rst#L84) references to it valid?\n", "@myint No, I just missed them. This should be fixed in master now. T...
https://api.github.com/repos/psf/requests/issues/2182
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2182/labels{/name}
https://api.github.com/repos/psf/requests/issues/2182/comments
https://api.github.com/repos/psf/requests/issues/2182/events
https://github.com/psf/requests/issues/2182
41,210,308
MDU6SXNzdWU0MTIxMDMwOA==
2,182
Add "Low-Level Internals" to documentation
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-08-26T19:19:14Z
2021-09-04T00:06:31Z
2019-07-02T03:02:39Z
CONTRIBUTOR
resolved
Feedback welcome, but I think this would be absolutely incredible to have.
{ "avatar_url": "https://avatars.githubusercontent.com/u/8712070?v=4", "events_url": "https://api.github.com/users/kobayashi/events{/privacy}", "followers_url": "https://api.github.com/users/kobayashi/followers", "following_url": "https://api.github.com/users/kobayashi/following{/other_user}", "gists_url": "https://api.github.com/users/kobayashi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kobayashi", "id": 8712070, "login": "kobayashi", "node_id": "MDQ6VXNlcjg3MTIwNzA=", "organizations_url": "https://api.github.com/users/kobayashi/orgs", "received_events_url": "https://api.github.com/users/kobayashi/received_events", "repos_url": "https://api.github.com/users/kobayashi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kobayashi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kobayashi/subscriptions", "type": "User", "url": "https://api.github.com/users/kobayashi", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2182/reactions" }
https://api.github.com/repos/psf/requests/issues/2182/timeline
null
completed
null
null
false
[ ":+1:\n", ":+1: \n", "This is described at [lower level classes](https://2.python-requests.org/en/master/api/#lower-level-classes) ." ]
https://api.github.com/repos/psf/requests/issues/2181
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2181/labels{/name}
https://api.github.com/repos/psf/requests/issues/2181/comments
https://api.github.com/repos/psf/requests/issues/2181/events
https://github.com/psf/requests/issues/2181
41,200,903
MDU6SXNzdWU0MTIwMDkwMw==
2,181
Requests is slow to upload large files
{ "avatar_url": "https://avatars.githubusercontent.com/u/446219?v=4", "events_url": "https://api.github.com/users/Tech356/events{/privacy}", "followers_url": "https://api.github.com/users/Tech356/followers", "following_url": "https://api.github.com/users/Tech356/following{/other_user}", "gists_url": "https://api.github.com/users/Tech356/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Tech356", "id": 446219, "login": "Tech356", "node_id": "MDQ6VXNlcjQ0NjIxOQ==", "organizations_url": "https://api.github.com/users/Tech356/orgs", "received_events_url": "https://api.github.com/users/Tech356/received_events", "repos_url": "https://api.github.com/users/Tech356/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Tech356/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Tech356/subscriptions", "type": "User", "url": "https://api.github.com/users/Tech356", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
21
2014-08-26T17:46:30Z
2021-08-29T00:06:38Z
2015-01-19T09:20:41Z
NONE
resolved
I am using requests to POST data to a server. In testing with a 14.4 MB file, `requests` took 16.5 seconds and `cURL` took 3.3 seconds. The following image shows the 3 tests I ran. The first bump is using `requests` with `MultipartEncoder` from `requests-toolbelt`. The second bump is just using `requests`. The last bump is `cURL`. ![request_speed](https://cloud.githubusercontent.com/assets/446219/4048836/621e85ea-2d47-11e4-8fbc-1bc5f07e50c3.PNG) I am using Python 3.4.0, requests 2.3.0, and requests-toolbelt 0.3.1 on Windows 7 x64. Are there any settings I can tune to speed up `requests`?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2181/reactions" }
https://api.github.com/repos/psf/requests/issues/2181/timeline
null
completed
null
null
false
[ "That's very interesting: can I see the code?\n", "So if you're using the `MultipartEncoder` then what happens is that the object is passed down to `httplib` which has a fixed read size of `8192` bytes. So it takes 1,844 reads to upload the file. If you're passing a file-like object to requests the same thing hap...
https://api.github.com/repos/psf/requests/issues/2180
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2180/labels{/name}
https://api.github.com/repos/psf/requests/issues/2180/comments
https://api.github.com/repos/psf/requests/issues/2180/events
https://github.com/psf/requests/issues/2180
41,126,980
MDU6SXNzdWU0MTEyNjk4MA==
2,180
Github timeline no longer available - makes poor example
{ "avatar_url": "https://avatars.githubusercontent.com/u/640535?v=4", "events_url": "https://api.github.com/users/Rosuav/events{/privacy}", "followers_url": "https://api.github.com/users/Rosuav/followers", "following_url": "https://api.github.com/users/Rosuav/following{/other_user}", "gists_url": "https://api.github.com/users/Rosuav/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Rosuav", "id": 640535, "login": "Rosuav", "node_id": "MDQ6VXNlcjY0MDUzNQ==", "organizations_url": "https://api.github.com/users/Rosuav/orgs", "received_events_url": "https://api.github.com/users/Rosuav/received_events", "repos_url": "https://api.github.com/users/Rosuav/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Rosuav/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rosuav/subscriptions", "type": "User", "url": "https://api.github.com/users/Rosuav", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2014-08-26T01:02:41Z
2021-09-08T23:10:40Z
2014-08-26T19:41:45Z
NONE
resolved
The quickstart tutorial recommends fetching https://github.com/timeline.json, which does technically work, and it does return a block of JSON text. But it's an unideal example, because all it tells you is "this service isn't available, go use the Events API". Could do with replacement, I think.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2180/reactions" }
https://api.github.com/repos/psf/requests/issues/2180/timeline
null
completed
null
null
false
[ "Good catch! @sigmavirus24, you know the GitHub API best, what endpoint should we hit?\n", "It wasn't actually me who caught it, but a student I'm mentoring. He sent me his non-working code, I tried it on my system (it worked - he had a completely unrelated issue), and that's where I saw this. :)\n", "So that u...
https://api.github.com/repos/psf/requests/issues/2179
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2179/labels{/name}
https://api.github.com/repos/psf/requests/issues/2179/comments
https://api.github.com/repos/psf/requests/issues/2179/events
https://github.com/psf/requests/pull/2179
41,104,327
MDExOlB1bGxSZXF1ZXN0MjAyNzEwMDY=
2,179
Updates urllib3 to 528ad3c
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-25T20:47:33Z
2021-09-08T11:00:48Z
2014-08-26T19:10:51Z
CONTRIBUTOR
resolved
This includes fixes for openssl running with Pypy, so SSL connections can be made if ndg-httpsclient, pyopenssl and pyasn1 are installed. see also: - https://github.com/shazow/urllib3/issues/449 - https://github.com/pypa/pip/issues/1988
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2179/reactions" }
https://api.github.com/repos/psf/requests/issues/2179/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2179.diff", "html_url": "https://github.com/psf/requests/pull/2179", "merged_at": "2014-08-26T19:10:51Z", "patch_url": "https://github.com/psf/requests/pull/2179.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2179" }
true
[ "many thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/2178
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2178/labels{/name}
https://api.github.com/repos/psf/requests/issues/2178/comments
https://api.github.com/repos/psf/requests/issues/2178/events
https://github.com/psf/requests/pull/2178
40,984,512
MDExOlB1bGxSZXF1ZXN0MjAyMTM2Nzc=
2,178
Add Session method to merge environment settings with per-request settings
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
5
2014-08-23T20:52:48Z
2021-09-08T11:00:49Z
2014-08-26T19:44:51Z
CONTRIBUTOR
resolved
See also #2129
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2178/reactions" }
https://api.github.com/repos/psf/requests/issues/2178/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2178.diff", "html_url": "https://github.com/psf/requests/pull/2178", "merged_at": "2014-08-26T19:44:51Z", "patch_url": "https://github.com/psf/requests/pull/2178.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2178" }
true
[ "One minor note, otherwise LGTM.\n", "Tests fail. \n", "Tests were passing locally so I rebased and pushed hoping that solves the issue.\n", "Looks like httpbin is having intermittent failures? The same tests aren't failing on the same Python versions, and there is a lot of this\n\nProtocolError: ('Connection...
https://api.github.com/repos/psf/requests/issues/2177
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2177/labels{/name}
https://api.github.com/repos/psf/requests/issues/2177/comments
https://api.github.com/repos/psf/requests/issues/2177/events
https://github.com/psf/requests/issues/2177
40,983,426
MDU6SXNzdWU0MDk4MzQyNg==
2,177
Update PyPy version on ci.kennethreitz.org
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
4
2014-08-23T19:57:18Z
2021-09-08T23:10:38Z
2014-08-29T14:25:57Z
CONTRIBUTOR
resolved
The latest version of PyPy is 2.3.1 (Python 2.7.6), but the Jenkins boxes are running pypy 1.8 The pypy docs mention something about a sandboxed version shipping with 1.8, is that why it's so old on those machines?
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2177/reactions" }
https://api.github.com/repos/psf/requests/issues/2177/timeline
null
completed
null
null
false
[ "@kennethreitz, we're going to need your input on this one.\n", "Relatedly, we should be adding Python 3.4 to the test matrix.\n", "I'll have to do the dirty work soon :)\n", "Python 3.4 added. PyPy isn't a big deal.\n" ]
https://api.github.com/repos/psf/requests/issues/2176
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2176/labels{/name}
https://api.github.com/repos/psf/requests/issues/2176/comments
https://api.github.com/repos/psf/requests/issues/2176/events
https://github.com/psf/requests/pull/2176
40,983,105
MDExOlB1bGxSZXF1ZXN0MjAyMTMwMzU=
2,176
Add support for connect timeouts
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[]
closed
true
null
[]
null
11
2014-08-23T19:39:43Z
2021-09-08T11:00:47Z
2014-08-26T19:13:30Z
CONTRIBUTOR
resolved
Modifies the timeout interface to also accept a tuple (connect, read) which would be used to set individual connect and read timeouts for Requests. Adds Advanced documentation explaining the interface and providing guidance for timeout values.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2176/reactions" }
https://api.github.com/repos/psf/requests/issues/2176/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2176.diff", "html_url": "https://github.com/psf/requests/pull/2176", "merged_at": "2014-08-26T19:13:30Z", "patch_url": "https://github.com/psf/requests/pull/2176.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2176" }
true
[ "For perspective, this is basically a rebase/rewrite of #1801.\n\nI have always been in favour of this change, at least in principle, and I'm happy with the implementation as well. =)\n", "okay I killed the extra format try/catch & rebased\n", "So there is a latent issue here.\n\nIn the event that Requests supp...
https://api.github.com/repos/psf/requests/issues/2175
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2175/labels{/name}
https://api.github.com/repos/psf/requests/issues/2175/comments
https://api.github.com/repos/psf/requests/issues/2175/events
https://github.com/psf/requests/pull/2175
40,982,781
MDExOlB1bGxSZXF1ZXN0MjAyMTI4OTE=
2,175
add bad host test
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 78002701, "name": "Do Not Merge", "node_id": "MDU6TGFiZWw3ODAwMjcwMQ==", "url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge" } ]
closed
true
null
[]
null
0
2014-08-23T19:23:01Z
2021-09-08T11:00:53Z
2014-08-23T21:19:04Z
CONTRIBUTOR
resolved
Please don't merge this, I'm trying to track down behavior issues in CPython + Pypy
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2175/reactions" }
https://api.github.com/repos/psf/requests/issues/2175/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2175.diff", "html_url": "https://github.com/psf/requests/pull/2175", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2175.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2175" }
true
[]
https://api.github.com/repos/psf/requests/issues/2174
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2174/labels{/name}
https://api.github.com/repos/psf/requests/issues/2174/comments
https://api.github.com/repos/psf/requests/issues/2174/events
https://github.com/psf/requests/pull/2174
40,979,992
MDExOlB1bGxSZXF1ZXN0MjAyMTE2NDU=
2,174
Clarify which tests to run in the Makefile
{ "avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4", "events_url": "https://api.github.com/users/kevinburke/events{/privacy}", "followers_url": "https://api.github.com/users/kevinburke/followers", "following_url": "https://api.github.com/users/kevinburke/following{/other_user}", "gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kevinburke", "id": 234019, "login": "kevinburke", "node_id": "MDQ6VXNlcjIzNDAxOQ==", "organizations_url": "https://api.github.com/users/kevinburke/orgs", "received_events_url": "https://api.github.com/users/kevinburke/received_events", "repos_url": "https://api.github.com/users/kevinburke/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions", "type": "User", "url": "https://api.github.com/users/kevinburke", "user_view_type": "public" }
[ { "color": "009800", "default": false, "description": null, "id": 44501218, "name": "Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTIxOA==", "url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge" }, { "color": "207de5", "default": false, "description...
closed
true
null
[]
null
1
2014-08-23T17:06:15Z
2021-09-08T11:00:49Z
2014-08-26T19:15:28Z
CONTRIBUTOR
resolved
If you put your Virtualenv in the same folder as Requests (as I usually do), py.test will pick up any test_\* files inside the virtualenv and attempt to run them too, leading to the following error: https://gist.github.com/kevinburke/1aa2b07e01de3a7daa15 Instead specify the test file we would like to run in the Makefile.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2174/reactions" }
https://api.github.com/repos/psf/requests/issues/2174/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2174.diff", "html_url": "https://github.com/psf/requests/pull/2174", "merged_at": "2014-08-26T19:15:28Z", "patch_url": "https://github.com/psf/requests/pull/2174.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2174" }
true
[ ":+1: :cake:\n\nThis is a PITA. Let's do it.\n" ]
https://api.github.com/repos/psf/requests/issues/2173
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2173/labels{/name}
https://api.github.com/repos/psf/requests/issues/2173/comments
https://api.github.com/repos/psf/requests/issues/2173/events
https://github.com/psf/requests/pull/2173
40,889,586
MDExOlB1bGxSZXF1ZXN0MjAxNTkyNzY=
2,173
Documentation update : connection keep alive
{ "avatar_url": "https://avatars.githubusercontent.com/u/407189?v=4", "events_url": "https://api.github.com/users/tychotatitscheff/events{/privacy}", "followers_url": "https://api.github.com/users/tychotatitscheff/followers", "following_url": "https://api.github.com/users/tychotatitscheff/following{/other_user}", "gists_url": "https://api.github.com/users/tychotatitscheff/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tychotatitscheff", "id": 407189, "login": "tychotatitscheff", "node_id": "MDQ6VXNlcjQwNzE4OQ==", "organizations_url": "https://api.github.com/users/tychotatitscheff/orgs", "received_events_url": "https://api.github.com/users/tychotatitscheff/received_events", "repos_url": "https://api.github.com/users/tychotatitscheff/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tychotatitscheff/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tychotatitscheff/subscriptions", "type": "User", "url": "https://api.github.com/users/tychotatitscheff", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-08-22T08:45:23Z
2021-09-08T11:00:47Z
2014-08-22T10:47:35Z
NONE
resolved
Concerning #2169, i get a problem with automatic keep alive. @sigmavirus24 has commented this saying that was in documentation but can have been lost.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2173/reactions" }
https://api.github.com/repos/psf/requests/issues/2173/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2173.diff", "html_url": "https://github.com/psf/requests/pull/2173", "merged_at": "2014-08-22T10:47:35Z", "patch_url": "https://github.com/psf/requests/pull/2173.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2173" }
true
[ "Thanks for this! :cake: :star:\n", "Thank you @tychotatitscheff!! :sparkles: :cake: :sparkles: \n", "The documentation was right, the code was wrong. \n" ]
https://api.github.com/repos/psf/requests/issues/2172
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2172/labels{/name}
https://api.github.com/repos/psf/requests/issues/2172/comments
https://api.github.com/repos/psf/requests/issues/2172/events
https://github.com/psf/requests/pull/2172
40,833,628
MDExOlB1bGxSZXF1ZXN0MjAxMjc5OTk=
2,172
Add to authors and fix case
{ "avatar_url": "https://avatars.githubusercontent.com/u/7707694?v=4", "events_url": "https://api.github.com/users/ContinuousFunction/events{/privacy}", "followers_url": "https://api.github.com/users/ContinuousFunction/followers", "following_url": "https://api.github.com/users/ContinuousFunction/following{/other_user}", "gists_url": "https://api.github.com/users/ContinuousFunction/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ContinuousFunction", "id": 7707694, "login": "ContinuousFunction", "node_id": "MDQ6VXNlcjc3MDc2OTQ=", "organizations_url": "https://api.github.com/users/ContinuousFunction/orgs", "received_events_url": "https://api.github.com/users/ContinuousFunction/received_events", "repos_url": "https://api.github.com/users/ContinuousFunction/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ContinuousFunction/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ContinuousFunction/subscriptions", "type": "User", "url": "https://api.github.com/users/ContinuousFunction", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-21T18:27:35Z
2021-09-08T11:00:55Z
2014-08-22T13:04:50Z
CONTRIBUTOR
resolved
Fix sentence case requests by sigmavirus24 here: https://github.com/kennethreitz/requests/pull/2168 Added myself to authors.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2172/reactions" }
https://api.github.com/repos/psf/requests/issues/2172/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2172.diff", "html_url": "https://github.com/psf/requests/pull/2172", "merged_at": "2014-08-22T13:04:50Z", "patch_url": "https://github.com/psf/requests/pull/2172.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2172" }
true
[ "Many thank yous :)\n" ]
https://api.github.com/repos/psf/requests/issues/2171
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2171/labels{/name}
https://api.github.com/repos/psf/requests/issues/2171/comments
https://api.github.com/repos/psf/requests/issues/2171/events
https://github.com/psf/requests/issues/2171
40,784,032
MDU6SXNzdWU0MDc4NDAzMg==
2,171
https requests error
{ "avatar_url": "https://avatars.githubusercontent.com/u/3103577?v=4", "events_url": "https://api.github.com/users/crouse/events{/privacy}", "followers_url": "https://api.github.com/users/crouse/followers", "following_url": "https://api.github.com/users/crouse/following{/other_user}", "gists_url": "https://api.github.com/users/crouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/crouse", "id": 3103577, "login": "crouse", "node_id": "MDQ6VXNlcjMxMDM1Nzc=", "organizations_url": "https://api.github.com/users/crouse/orgs", "received_events_url": "https://api.github.com/users/crouse/received_events", "repos_url": "https://api.github.com/users/crouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/crouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/crouse/subscriptions", "type": "User", "url": "https://api.github.com/users/crouse", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-21T08:45:57Z
2021-09-08T23:10:39Z
2014-08-27T19:35:24Z
NONE
resolved
Just see my example: it works with curl [root@localhost ~]# curl -X GET https://openapi/face/ --cacert /export/server.pem {"datetime": "2014-08-21 08:30:30.896918", "face": "a smiling face"}[root@localhost ~]# But requests did not work, see > > > r = requests.get('https://openapi/face/', cert='/export/server.pem') > > > Traceback (most recent call last): > > > File "<stdin>", line 1, in <module> > > > File "/usr/lib/python2.6/site-packages/requests/api.py", line 55, in get > > > return request('get', url, *_kwargs) > > > File "/usr/lib/python2.6/site-packages/requests/api.py", line 44, in request > > > return session.request(method=method, url=url, *_kwargs) > > > File "/usr/lib/python2.6/site-packages/requests/sessions.py", line 456, in request > > > resp = self.send(prep, *_send_kwargs) > > > File "/usr/lib/python2.6/site-packages/requests/sessions.py", line 559, in send > > > r = adapter.send(request, *_kwargs) > > > File "/usr/lib/python2.6/site-packages/requests/adapters.py", line 382, in send > > > raise SSLError(e, request=request) > > > requests.exceptions.SSLError: [Errno 336265225] _ssl.c:339: error:140B0009:SSL routines:SSL_CTX_use_PrivateKey_file:PEM lib Can anybody help me
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2171/reactions" }
https://api.github.com/repos/psf/requests/issues/2171/timeline
null
completed
null
null
false
[ "You're using the wrong argument. The `cert` command line argument provides a _client_ certificate, you want to provide the server certificate. Try this:\n\n``` python\nr = requests.get('https://openapi/face/', verify='/export/server.pem')\n```\n" ]
https://api.github.com/repos/psf/requests/issues/2170
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2170/labels{/name}
https://api.github.com/repos/psf/requests/issues/2170/comments
https://api.github.com/repos/psf/requests/issues/2170/events
https://github.com/psf/requests/issues/2170
40,750,463
MDU6SXNzdWU0MDc1MDQ2Mw==
2,170
SSL verification failing for a valid GeoTrust Global CA certificate
{ "avatar_url": "https://avatars.githubusercontent.com/u/1622880?v=4", "events_url": "https://api.github.com/users/guardrex/events{/privacy}", "followers_url": "https://api.github.com/users/guardrex/followers", "following_url": "https://api.github.com/users/guardrex/following{/other_user}", "gists_url": "https://api.github.com/users/guardrex/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/guardrex", "id": 1622880, "login": "guardrex", "node_id": "MDQ6VXNlcjE2MjI4ODA=", "organizations_url": "https://api.github.com/users/guardrex/orgs", "received_events_url": "https://api.github.com/users/guardrex/received_events", "repos_url": "https://api.github.com/users/guardrex/repos", "site_admin": false, "starred_url": "https://api.github.com/users/guardrex/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guardrex/subscriptions", "type": "User", "url": "https://api.github.com/users/guardrex", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-08-20T22:04:27Z
2021-09-08T23:10:40Z
2014-08-20T22:24:46Z
NONE
resolved
I'm having trouble with SSL cert verification for a valid CA-signed cert ... and I can't seem to add the CA cert that I need to the cacert.pem file. Computer: Raspberry Pi connecting to a website on IIS8/WS2012 (TLS 1.0/1.1/1.2; Note: SSL3 is not supported by this server) OS: Arch Linux (3.12.26-1-ARCH) Language: Python 3.4.1 Certificate Chain: my_site_cert > RapidSSL CA (Serial #: 0236d1) > GeoTrust Global CA (Serial #: 023456) Trying to get an secure session open to some valid CA-signed endpionts (e.g,. Microsoft Azure endpoints with certificates signed by Baltimore CyberTrust Root) work fine with requests. However, attempting to open a secure connection to a website with an equally valid certificate signed by a GeoTrust Global CA fails with the invalid certificate error. It looks like requests is using the CA bundle at: ``` /usr/lib/python3.4/site-packages/requests/cacert.pem ``` ... and that bundle does contain a GeoTrust Global CA. Looking at the cert entry for the GeoTrust Global CA entry, I can see that it does not match the base64-encoded cert that I pulled down from my certificate chain. The serial numbers don't match either. I took the base64-encoded certificate block for the one I presumably need ``` -----BEGIN CERTIFICATE----- xxxxxxx -----END CERTIFICATE----- ``` ... and pasted it into the cacert.pem file that requests uses. I rebooted. This did not work. I'm still getting the exception: ``` [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:598) ``` What do I need to do to get my CA cert installed in such a way that requests will pick it up and grant my secure connection? The docs are too vague about the specific path to use for other ca bundles in Arch Linux (e.g., ca-certificates or openssl ca bundles), and there is no information about getting other CA certs in the right spot for requests to pick them up. I certainly don't want to run a production system with `verify=False`.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1622880?v=4", "events_url": "https://api.github.com/users/guardrex/events{/privacy}", "followers_url": "https://api.github.com/users/guardrex/followers", "following_url": "https://api.github.com/users/guardrex/following{/other_user}", "gists_url": "https://api.github.com/users/guardrex/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/guardrex", "id": 1622880, "login": "guardrex", "node_id": "MDQ6VXNlcjE2MjI4ODA=", "organizations_url": "https://api.github.com/users/guardrex/orgs", "received_events_url": "https://api.github.com/users/guardrex/received_events", "repos_url": "https://api.github.com/users/guardrex/repos", "site_admin": false, "starred_url": "https://api.github.com/users/guardrex/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/guardrex/subscriptions", "type": "User", "url": "https://api.github.com/users/guardrex", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2170/reactions" }
https://api.github.com/repos/psf/requests/issues/2170/timeline
null
completed
null
null
false
[ "Is your system time correct?\n", "Good grief! It's amazing how simple it was to fix this. Thank you so much for that. It turns out that I had the wrong command in my service shell script that runs on boot to move the hardware clock time to the system time (I see now that the correct command is `hwclock --hctosys...
https://api.github.com/repos/psf/requests/issues/2169
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2169/labels{/name}
https://api.github.com/repos/psf/requests/issues/2169/comments
https://api.github.com/repos/psf/requests/issues/2169/events
https://github.com/psf/requests/issues/2169
40,489,816
MDU6SXNzdWU0MDQ4OTgxNg==
2,169
Connection keep alive issue
{ "avatar_url": "https://avatars.githubusercontent.com/u/407189?v=4", "events_url": "https://api.github.com/users/tychotatitscheff/events{/privacy}", "followers_url": "https://api.github.com/users/tychotatitscheff/followers", "following_url": "https://api.github.com/users/tychotatitscheff/following{/other_user}", "gists_url": "https://api.github.com/users/tychotatitscheff/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tychotatitscheff", "id": 407189, "login": "tychotatitscheff", "node_id": "MDQ6VXNlcjQwNzE4OQ==", "organizations_url": "https://api.github.com/users/tychotatitscheff/orgs", "received_events_url": "https://api.github.com/users/tychotatitscheff/received_events", "repos_url": "https://api.github.com/users/tychotatitscheff/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tychotatitscheff/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tychotatitscheff/subscriptions", "type": "User", "url": "https://api.github.com/users/tychotatitscheff", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" }, { "color": "fef2c0", "default": false, "description": null, "id": 60669570, ...
closed
true
null
[]
null
26
2014-08-18T13:51:38Z
2021-09-08T23:10:38Z
2014-08-29T14:24:23Z
NONE
resolved
_Maybe it is not the right place to report this, its one of my first issue report_ Winows 7 Python 3.4 Request 2.3 In requests' main site it's said: > > connection keepalive should be 100% automatic. However in my case: - on a ssl connection - throught http proxy I had to add the `"connection" : "keep-alive"` header. But it took me so much time to find it because the exceeption raised was a `requests.exceptions.ProxyError` So i went into the code and find that: ``` python httplib_response = conn.getresponse() ``` in `_make_request()` function in `connection_pool.py` raise a `SocketError` wich is converted to a `ReadTimeoutError` : all correct for now since no connection then we come to a timeout. But then this error is rewrap to something incorrect in `connectionpool.py`. ``` python except (TimeoutError, HTTPException, SocketError) as e: if conn: # Discard the connection for these exceptions. It will be # be replaced during the next _get_conn() call. conn.close() conn = None if not retries: if isinstance(e, TimeoutError): # TimeoutError is exempt from MaxRetryError-wrapping. # FIXME: ... Not sure why. Add a reason here. raise # Wrap unexpected exceptions with the most appropriate # module-level exception and re-raise. if isinstance(e, SocketError) and self.proxy: raise ProxyError('Cannot connect to proxy.', e) if retries is False: raise ConnectionError('Connection failed.', e) raise MaxRetryError(self, url, e) # Keep track of the error for the retry warning. err = e ``` and since there is a proxy. Boom. proxy error. So **WRONG** advice in requests site and **bug** in urllib3. Hope it can help.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2169/reactions" }
https://api.github.com/repos/psf/requests/issues/2169/timeline
null
completed
null
null
false
[ "I could have sworn this was already documented (that in order to enable keep-alive you had to set that header yourself). It seems to have been lost. The documentation is only partially incorrect in this case. There is no bug in urllib3 as I understand it.\n", "Was no critic, but an improvement suggestion.\n\nYes...
https://api.github.com/repos/psf/requests/issues/2168
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2168/labels{/name}
https://api.github.com/repos/psf/requests/issues/2168/comments
https://api.github.com/repos/psf/requests/issues/2168/events
https://github.com/psf/requests/pull/2168
40,450,360
MDExOlB1bGxSZXF1ZXN0MTk4OTY3MzY=
2,168
Tracking Previous Requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/7707694?v=4", "events_url": "https://api.github.com/users/ContinuousFunction/events{/privacy}", "followers_url": "https://api.github.com/users/ContinuousFunction/followers", "following_url": "https://api.github.com/users/ContinuousFunction/following{/other_user}", "gists_url": "https://api.github.com/users/ContinuousFunction/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ContinuousFunction", "id": 7707694, "login": "ContinuousFunction", "node_id": "MDQ6VXNlcjc3MDc2OTQ=", "organizations_url": "https://api.github.com/users/ContinuousFunction/orgs", "received_events_url": "https://api.github.com/users/ContinuousFunction/received_events", "repos_url": "https://api.github.com/users/ContinuousFunction/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ContinuousFunction/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ContinuousFunction/subscriptions", "type": "User", "url": "https://api.github.com/users/ContinuousFunction", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 44501305, "name": "Not Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTMwNQ==", "url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge" } ]
closed
true
null
[]
null
4
2014-08-18T02:19:45Z
2021-09-08T11:00:55Z
2014-08-21T17:43:23Z
CONTRIBUTOR
resolved
Addresses the issue brought up here: https://github.com/kennethreitz/requests/issues/1929
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2168/reactions" }
https://api.github.com/repos/psf/requests/issues/2168/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2168.diff", "html_url": "https://github.com/psf/requests/pull/2168", "merged_at": "2014-08-21T17:43:23Z", "patch_url": "https://github.com/psf/requests/pull/2168.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2168" }
true
[ "This looks good to me! I've made a few notes inline. Do you mind fixing them up?\n", "@Lukasa I will try to come up with a better way to test.\n", "Shouldn't be too hard. The final response's history (`r.history`) contains the list of all responses in order. Each of those responses should have a slice of that ...
https://api.github.com/repos/psf/requests/issues/2167
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2167/labels{/name}
https://api.github.com/repos/psf/requests/issues/2167/comments
https://api.github.com/repos/psf/requests/issues/2167/events
https://github.com/psf/requests/issues/2167
40,386,154
MDU6SXNzdWU0MDM4NjE1NA==
2,167
Session dropping proxy for https redirects
{ "avatar_url": "https://avatars.githubusercontent.com/u/640318?v=4", "events_url": "https://api.github.com/users/mmessmore/events{/privacy}", "followers_url": "https://api.github.com/users/mmessmore/followers", "following_url": "https://api.github.com/users/mmessmore/following{/other_user}", "gists_url": "https://api.github.com/users/mmessmore/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mmessmore", "id": 640318, "login": "mmessmore", "node_id": "MDQ6VXNlcjY0MDMxOA==", "organizations_url": "https://api.github.com/users/mmessmore/orgs", "received_events_url": "https://api.github.com/users/mmessmore/received_events", "repos_url": "https://api.github.com/users/mmessmore/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mmessmore/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mmessmore/subscriptions", "type": "User", "url": "https://api.github.com/users/mmessmore", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-15T21:26:04Z
2021-09-08T23:10:41Z
2014-08-15T21:45:40Z
NONE
resolved
I noticed it when trying to add proxy support to python-foreman, but have reduced it down to just being an issue with requests. The cert on my destination is self-signed, but verify is set to false. The following code reproduces the problem. When I observe the traffic I see it make a request out to the proxy server, then it follows up by trying to make a request directly to the server without using the proxy and times out because it can't get there. I'm not seeing other people complain about this issue, and wonder if I'm just missing something. ``` #!/usr/bin/env python import requests s = requests.Session() s.proxies = { 'http': 'proxy.example.com:3128', 'https': 'proxy.example.com:3128' } s.get('https://uri.that.redirects.example.com', verify=False) ``` I've tried setting the environment variables HTTP_PROXY and HTTPS_PROXY, and setting explicitly on my session object, or passing it to each Session.get() request as part of the **kwargs (like verify). I've tried with http:// URI's and with just host:port for the proxy values in both the internal dict and the env variables, as the documentation seems to suggest both in different places. I can provide more specific details or a packet dump if necessary.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2167/reactions" }
https://api.github.com/repos/psf/requests/issues/2167/timeline
null
completed
null
null
false
[ "Ah, yes, this is a well known issue. It's the same as pypa/pip#1805. This should be fixed in the next release of requests. =)\n" ]
https://api.github.com/repos/psf/requests/issues/2166
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2166/labels{/name}
https://api.github.com/repos/psf/requests/issues/2166/comments
https://api.github.com/repos/psf/requests/issues/2166/events
https://github.com/psf/requests/issues/2166
40,320,474
MDU6SXNzdWU0MDMyMDQ3NA==
2,166
Requests support HTTPS proxies timeout
{ "avatar_url": "https://avatars.githubusercontent.com/u/2490900?v=4", "events_url": "https://api.github.com/users/macdonjo/events{/privacy}", "followers_url": "https://api.github.com/users/macdonjo/followers", "following_url": "https://api.github.com/users/macdonjo/following{/other_user}", "gists_url": "https://api.github.com/users/macdonjo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/macdonjo", "id": 2490900, "login": "macdonjo", "node_id": "MDQ6VXNlcjI0OTA5MDA=", "organizations_url": "https://api.github.com/users/macdonjo/orgs", "received_events_url": "https://api.github.com/users/macdonjo/received_events", "repos_url": "https://api.github.com/users/macdonjo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/macdonjo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/macdonjo/subscriptions", "type": "User", "url": "https://api.github.com/users/macdonjo", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-15T03:32:07Z
2021-09-08T23:10:41Z
2014-08-15T07:26:15Z
NONE
resolved
Is requests timeout supposed to work with HTTPS proxies? I know urllib2 does not support this: https://docs.python.org/2/howto/urllib2.html#proxies "Note: Currently urllib2 does not support fetching of https locations through a proxy. However, this can be enabled by extending urllib2 as shown in the recipe [7]."
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2166/reactions" }
https://api.github.com/repos/psf/requests/issues/2166/timeline
null
completed
null
null
false
[ "Yes. =)\n" ]
https://api.github.com/repos/psf/requests/issues/2165
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2165/labels{/name}
https://api.github.com/repos/psf/requests/issues/2165/comments
https://api.github.com/repos/psf/requests/issues/2165/events
https://github.com/psf/requests/issues/2165
40,073,532
MDU6SXNzdWU0MDA3MzUzMg==
2,165
post() hangs when data is large(-ish)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1308749?v=4", "events_url": "https://api.github.com/users/ekw/events{/privacy}", "followers_url": "https://api.github.com/users/ekw/followers", "following_url": "https://api.github.com/users/ekw/following{/other_user}", "gists_url": "https://api.github.com/users/ekw/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ekw", "id": 1308749, "login": "ekw", "node_id": "MDQ6VXNlcjEzMDg3NDk=", "organizations_url": "https://api.github.com/users/ekw/orgs", "received_events_url": "https://api.github.com/users/ekw/received_events", "repos_url": "https://api.github.com/users/ekw/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ekw/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekw/subscriptions", "type": "User", "url": "https://api.github.com/users/ekw", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-08-12T16:33:55Z
2021-09-08T23:10:42Z
2014-08-12T17:56:57Z
NONE
resolved
This is the call in question: ``` r = requests.post(url, auth=creds, data=json.dumps(post_data), headers={'content-type':'application/json'}) ``` post_data is a dictionary. post_data['x'] is a string of varying length: ``` post_data['x'] = '.' * L ``` (a) For L < 3487 and creds is correct username/password, I receive expected 200 response right away. (b) For L < 3487 and creds is incorrect username/password, I receive expected 401 response right away. (c) For L >= 3487 and creds is correct username/password, I receive expected 200 response right away. (d) For L >= 3487 and creds is incorrect username/password, the call hangs for about a minute and then I receive 401 response, but the data is empty (r.text is empty string). I expect a JSON response which I do receive properly in (b) above. On the server hosting the url, I see the response go out right away in all cases. Is there anything more I can do to further isolate this and figure out what's going on? I don't know if L=3487 is specific to my system or not; could be higher or lower for others. I am using Python 2.7 and requests 2.3.0.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2165/reactions" }
https://api.github.com/repos/psf/requests/issues/2165/timeline
null
completed
null
null
false
[ "Interesting.\n\nHere's the way the requests stack works. When we send a request in this form, we send all the headers and then immediately send the body. What we _don't_ do is attempt to read the response before sending the body: this is simply not a flow that `httplib` allows.\n\nIf the endpoint server _knows_ th...
https://api.github.com/repos/psf/requests/issues/2164
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2164/labels{/name}
https://api.github.com/repos/psf/requests/issues/2164/comments
https://api.github.com/repos/psf/requests/issues/2164/events
https://github.com/psf/requests/issues/2164
40,038,011
MDU6SXNzdWU0MDAzODAxMQ==
2,164
python requests session failed to read the response
{ "avatar_url": "https://avatars.githubusercontent.com/u/1951487?v=4", "events_url": "https://api.github.com/users/msrajan/events{/privacy}", "followers_url": "https://api.github.com/users/msrajan/followers", "following_url": "https://api.github.com/users/msrajan/following{/other_user}", "gists_url": "https://api.github.com/users/msrajan/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/msrajan", "id": 1951487, "login": "msrajan", "node_id": "MDQ6VXNlcjE5NTE0ODc=", "organizations_url": "https://api.github.com/users/msrajan/orgs", "received_events_url": "https://api.github.com/users/msrajan/received_events", "repos_url": "https://api.github.com/users/msrajan/repos", "site_admin": false, "starred_url": "https://api.github.com/users/msrajan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/msrajan/subscriptions", "type": "User", "url": "https://api.github.com/users/msrajan", "user_view_type": "public" }
[]
closed
true
null
[]
null
12
2014-08-12T09:24:23Z
2021-09-08T14:00:41Z
2014-08-27T19:35:42Z
NONE
resolved
python requests session failed to read the response after reading a large response content python version 2.7 requests 2.3.0 I am using requests.Session in a REST client to talk to REST Server. Some of my endpoints are reading file content and producing file contents as response content. So whenever the response content is more than certain size like 10240 bytes then the subsequent request in the same session is failing(First request succeeds(which response is more than 10240 bytes) and second request keeps on waiting to read the response). ``` sess = requests.Session() sess.verify = False host = "https://somehost/endpoint/" res = sess.get(url = host+'obj1/28/content', headers = headers) print res # this result received successfully with 200 response status code url = host + 'obj2/1/content' res = sess.get(url = url, headers=headers) # the execution struck here. I need to kill the process to exit. print "content ", res.content # this line never gets executed... ``` But the same set of requests works fine with out 'requests.Session' using 'requests.get'. Looks like an issue in the urllib3/requests module but I am not sure. The below are the stack trace when I exited the client manually. ``` File "/opt/lib/python2.7/site-packages/requests/sessions.py", line 556, in send r = adapter.send(request, **kwargs) File "/opt/lib/python2.7/site-packages/requests/adapters.py", line 391, in send r.content File "/opt/lib/python2.7/site-packages/requests/models.py", line 690, in content self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes() File "/opt/lib/python2.7/site-packages/requests/models.py", line 628, in generate for chunk in self.raw.stream(chunk_size, decode_content=True): File "/opt/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 240, in stream data = self.read(amt=amt, decode_content=decode_content) File "/opt/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 187, in read data = self._fp.read(amt) File "/opt/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt) File "/opt/lib/python2.7/httplib.py", line 1313, in read return s + self._file.read(amt - len(s)) File "/opt/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left) File "/opt/lib/python2.7/ssl.py", line 242, in recv return self.read(buflen) File "/opt/lib/python2.7/ssl.py", line 161, in read return self._sslobj.read(len) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2164/reactions" }
https://api.github.com/repos/psf/requests/issues/2164/timeline
null
completed
null
null
false
[ "Thanks for this!\n\nYou've cut out the actual exception raised, you're only showing the traceback. What exact exception is being thrown?\n", "Closing for inactivity.\n", "Hi,\n\nGive me some more time. I will reproduce this and will provide with more information.\n", "@msrajan when you do, we'll reopen the i...
https://api.github.com/repos/psf/requests/issues/2163
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2163/labels{/name}
https://api.github.com/repos/psf/requests/issues/2163/comments
https://api.github.com/repos/psf/requests/issues/2163/events
https://github.com/psf/requests/issues/2163
40,025,276
MDU6SXNzdWU0MDAyNTI3Ng==
2,163
Multiple consequtive requests on Session throws TunnelError on https proxies.
{ "avatar_url": "https://avatars.githubusercontent.com/u/5163640?v=4", "events_url": "https://api.github.com/users/m-novikov/events{/privacy}", "followers_url": "https://api.github.com/users/m-novikov/followers", "following_url": "https://api.github.com/users/m-novikov/following{/other_user}", "gists_url": "https://api.github.com/users/m-novikov/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/m-novikov", "id": 5163640, "login": "m-novikov", "node_id": "MDQ6VXNlcjUxNjM2NDA=", "organizations_url": "https://api.github.com/users/m-novikov/orgs", "received_events_url": "https://api.github.com/users/m-novikov/received_events", "repos_url": "https://api.github.com/users/m-novikov/repos", "site_admin": false, "starred_url": "https://api.github.com/users/m-novikov/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/m-novikov/subscriptions", "type": "User", "url": "https://api.github.com/users/m-novikov", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2014-08-12T05:18:00Z
2021-09-08T23:10:39Z
2014-08-27T17:03:56Z
NONE
resolved
If you make consecutive requests on Session with set https proxy. import requests ``` s = requests.session() s.proxies = {'https': 'https://xxx.xxx.xxx.xxx:8888'} s.get("https://www.tumblr.com/") s.post("https://www.tumblr.com/") ``` You get this error `ProxyError: Cannot connect to proxy. Socket error: Tunnel connection failed: 400 Bad Request.`
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2163/reactions" }
https://api.github.com/repos/psf/requests/issues/2163/timeline
null
completed
null
null
false
[ "@m-novikov we need more information.\n1. What kind of proxy are you using?\n2. What is the full traceback?\n3. What is the exact version of python you're using (e.g., 3.4.1)\n4. What is the version of requests you're using?\n5. Can you still reproduce this with the version of requests present in `master`?\n", "W...
https://api.github.com/repos/psf/requests/issues/2162
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2162/labels{/name}
https://api.github.com/repos/psf/requests/issues/2162/comments
https://api.github.com/repos/psf/requests/issues/2162/events
https://github.com/psf/requests/issues/2162
40,016,199
MDU6SXNzdWU0MDAxNjE5OQ==
2,162
Cookies lost on redirect
{ "avatar_url": "https://avatars.githubusercontent.com/u/2872377?v=4", "events_url": "https://api.github.com/users/fenume/events{/privacy}", "followers_url": "https://api.github.com/users/fenume/followers", "following_url": "https://api.github.com/users/fenume/following{/other_user}", "gists_url": "https://api.github.com/users/fenume/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/fenume", "id": 2872377, "login": "fenume", "node_id": "MDQ6VXNlcjI4NzIzNzc=", "organizations_url": "https://api.github.com/users/fenume/orgs", "received_events_url": "https://api.github.com/users/fenume/received_events", "repos_url": "https://api.github.com/users/fenume/repos", "site_admin": false, "starred_url": "https://api.github.com/users/fenume/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fenume/subscriptions", "type": "User", "url": "https://api.github.com/users/fenume", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-12T01:11:00Z
2021-09-08T23:10:42Z
2014-08-12T02:10:44Z
NONE
resolved
Hi, i'm using requsts 2.3.0 from PyPi and get blank cookies after 302 redirect ``` python Python 2.7.5+ (default, Sep 19 2013, 13:48:49) [GCC 4.8.1] on linux2 >>> import requests >>> requests.__version__ '2.3.0' >>> r = requests.get('http://mlgame.us/?state=register_simple_new') >>> print r.cookies <<class 'requests.cookies.RequestsCookieJar'>[]> >>> print r.history[0].cookies <<class 'requests.cookies.RequestsCookieJar'>[<Cookie PORTAL_SESSIONID=vhjyfqxwh3oh1mtvxly7lqwf1 for mlgame.us/>]> ``` In version 1.2.0 all worked fine: ``` python Python 2.7.3 (default, Sep 26 2012, 21:53:58) [GCC 4.7.2] on linux2 >>> import requests >>> requests.__version__ '1.2.0' >>> r = requests.get('http://mlgame.us/?state=register_simple_new') >>> print r.cookies <<class 'requests.cookies.RequestsCookieJar'>[<Cookie PORTAL_SESSIONID=8r6iqae7yirj1gxx7x9biwiov for mlgame.us/>]> ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2162/reactions" }
https://api.github.com/repos/psf/requests/issues/2162/timeline
null
completed
null
null
false
[ "@fenume they're not \"lost\". See @lukasa's [comment](https://github.com/kennethreitz/requests/issues/1446#issuecomment-20658864) on #1446. This was intentional because a single response's CookieJar should represent the cookies sent by the server in _that_ response. If you want what used to work in version 1.2.0, ...
https://api.github.com/repos/psf/requests/issues/2161
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2161/labels{/name}
https://api.github.com/repos/psf/requests/issues/2161/comments
https://api.github.com/repos/psf/requests/issues/2161/events
https://github.com/psf/requests/pull/2161
39,688,464
MDExOlB1bGxSZXF1ZXN0MTk0NDU1ODU=
2,161
add auto detect charset from http body when http headers not seted
{ "avatar_url": "https://avatars.githubusercontent.com/u/1175571?v=4", "events_url": "https://api.github.com/users/likexian/events{/privacy}", "followers_url": "https://api.github.com/users/likexian/followers", "following_url": "https://api.github.com/users/likexian/following{/other_user}", "gists_url": "https://api.github.com/users/likexian/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/likexian", "id": 1175571, "login": "likexian", "node_id": "MDQ6VXNlcjExNzU1NzE=", "organizations_url": "https://api.github.com/users/likexian/orgs", "received_events_url": "https://api.github.com/users/likexian/received_events", "repos_url": "https://api.github.com/users/likexian/repos", "site_admin": false, "starred_url": "https://api.github.com/users/likexian/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/likexian/subscriptions", "type": "User", "url": "https://api.github.com/users/likexian", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-08-07T03:32:45Z
2021-09-08T11:00:56Z
2014-08-07T11:15:58Z
NONE
resolved
requests detect page's charset/encoding from responsed http headers, but many servers won't set it in headers. In this case, requests will set the charset/encoding to the default 'ISO-8859-1', and result in decoded error, many Chinese developers get lose and complain. For example: ``` print requests.get('http://www.126.com/').text ``` This commit will detect charset/encoding from http headers, if no, from http body, for most situations, everything goes well now.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2161/reactions" }
https://api.github.com/repos/psf/requests/issues/2161/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2161.diff", "html_url": "https://github.com/psf/requests/pull/2161", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2161.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2161" }
true
[ "Thanks for this!\n\nThis is a change that has been discussed many, many times. A sample of issues that touch it are: #1604, #1774, #1604, #1589, #1588, #1546, and #2042. We also mention it in the documentation [here](http://docs.python-requests.org/en/latest/user/advanced/#encodings). Though it's an easy mistake t...
https://api.github.com/repos/psf/requests/issues/2160
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2160/labels{/name}
https://api.github.com/repos/psf/requests/issues/2160/comments
https://api.github.com/repos/psf/requests/issues/2160/events
https://github.com/psf/requests/issues/2160
39,579,201
MDU6SXNzdWUzOTU3OTIwMQ==
2,160
requests.codes.continue raises SyntaxError
{ "avatar_url": "https://avatars.githubusercontent.com/u/74351?v=4", "events_url": "https://api.github.com/users/maxcountryman/events{/privacy}", "followers_url": "https://api.github.com/users/maxcountryman/followers", "following_url": "https://api.github.com/users/maxcountryman/following{/other_user}", "gists_url": "https://api.github.com/users/maxcountryman/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/maxcountryman", "id": 74351, "login": "maxcountryman", "node_id": "MDQ6VXNlcjc0MzUx", "organizations_url": "https://api.github.com/users/maxcountryman/orgs", "received_events_url": "https://api.github.com/users/maxcountryman/received_events", "repos_url": "https://api.github.com/users/maxcountryman/repos", "site_admin": false, "starred_url": "https://api.github.com/users/maxcountryman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/maxcountryman/subscriptions", "type": "User", "url": "https://api.github.com/users/maxcountryman", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-08-06T00:25:52Z
2021-09-08T23:10:45Z
2014-08-06T00:36:08Z
CONTRIBUTOR
resolved
``` python >>> import requests >>> requests.codes.continue File "<stdin>", line 1 requests.codes.continue ^ SyntaxError: invalid syntax ``` We expect to see the Informational HTTP status code, 100, but instead an error is raised. `requests.codes['continue']` works as a workaround. Presumably this happens because `continue` is a keyword in Python and therefore cannot be used as an attribute name. Python 2.7.6, OS X 10.10.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2160/reactions" }
https://api.github.com/repos/psf/requests/issues/2160/timeline
null
completed
null
null
false
[ "It's not really clear what we can do about this. Continue is and always will be a keyword.\n", "The _best_ we could do is support case-insensitive attribute access but that would certainly be useful to an extremely tiny subset of users. (In other words, you would be able to get around this with requests.codes.Co...
https://api.github.com/repos/psf/requests/issues/2159
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2159/labels{/name}
https://api.github.com/repos/psf/requests/issues/2159/comments
https://api.github.com/repos/psf/requests/issues/2159/events
https://github.com/psf/requests/issues/2159
39,345,367
MDU6SXNzdWUzOTM0NTM2Nw==
2,159
readline() takes exactly 1 argument (2 given)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1780945?v=4", "events_url": "https://api.github.com/users/kiarashplusplus/events{/privacy}", "followers_url": "https://api.github.com/users/kiarashplusplus/followers", "following_url": "https://api.github.com/users/kiarashplusplus/following{/other_user}", "gists_url": "https://api.github.com/users/kiarashplusplus/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kiarashplusplus", "id": 1780945, "login": "kiarashplusplus", "node_id": "MDQ6VXNlcjE3ODA5NDU=", "organizations_url": "https://api.github.com/users/kiarashplusplus/orgs", "received_events_url": "https://api.github.com/users/kiarashplusplus/received_events", "repos_url": "https://api.github.com/users/kiarashplusplus/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kiarashplusplus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kiarashplusplus/subscriptions", "type": "User", "url": "https://api.github.com/users/kiarashplusplus", "user_view_type": "public" }
[ { "color": "f7c6c7", "default": false, "description": null, "id": 167537670, "name": "Propose Close", "node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=", "url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close" } ]
closed
true
null
[]
null
18
2014-08-02T08:53:44Z
2021-09-08T15:00:38Z
2015-01-18T20:23:10Z
NONE
resolved
I'm trying to make connections with proxies. and some of the times I get this error. I put the traceback below. The command I use is this: `requests.get(w, verify=False, timeout=4, proxies=proxy)` `w` is a url and `proxy` is a dictionary.. something I make like this: ``` python http_proxy = "http://"+ip.strip() https_proxy = http_proxy proxyDict = { "http" : http_proxy, "https" : https_proxy, } ``` ``` Traceback (most recent call last): File "explore_proxies.py", line 13, in onewebsite r= requests.get(w, verify=False, timeout=4, proxies=proxy) File "/usr/lib/python2.7/dist-packages/requests/api.py", line 55, in get return request('get', url, **kwargs) File "/usr/lib/python2.7/dist-packages/requests/api.py", line 44, in request return session.request(method=method, url=url, **kwargs) File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 383, in req uest resp = self.send(prep, **send_kwargs) File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 486, in sen d r = adapter.send(request, **kwargs) File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 330, in sen d timeout=timeout File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 537, i n urlopen conn = self._get_conn(timeout=pool_timeout) File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 299, i n _get_conn return conn or self._new_conn() File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 719, i n _new_conn return self._prepare_conn(connection) File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 686, i n _prepare_conn connection.connect() File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 124, i n connect self._tunnel() File "/usr/lib/python2.7/httplib.py", line 759, in _tunnel line = response.fp.readline(_MAXLINE + 1) TypeError: readline() takes exactly 1 argument (2 given) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2159/reactions" }
https://api.github.com/repos/psf/requests/issues/2159/timeline
null
completed
null
null
false
[ "What exact version of Python are you using? (e.g., 2.7.8)\n", "Hi, thanks for raising this issue!\n\nThis is a known bug in the Python standard library, [issue 17849](http://bugs.python.org/issue17849). I have submitted a patch for this bug upstream, but it hasn't been merged at this time (despite being submitte...
https://api.github.com/repos/psf/requests/issues/2158
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2158/labels{/name}
https://api.github.com/repos/psf/requests/issues/2158/comments
https://api.github.com/repos/psf/requests/issues/2158/events
https://github.com/psf/requests/issues/2158
39,313,898
MDU6SXNzdWUzOTMxMzg5OA==
2,158
Capture server IP address as part of a Requests object
{ "avatar_url": "https://avatars.githubusercontent.com/u/403763?v=4", "events_url": "https://api.github.com/users/zapman449/events{/privacy}", "followers_url": "https://api.github.com/users/zapman449/followers", "following_url": "https://api.github.com/users/zapman449/following{/other_user}", "gists_url": "https://api.github.com/users/zapman449/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zapman449", "id": 403763, "login": "zapman449", "node_id": "MDQ6VXNlcjQwMzc2Mw==", "organizations_url": "https://api.github.com/users/zapman449/orgs", "received_events_url": "https://api.github.com/users/zapman449/received_events", "repos_url": "https://api.github.com/users/zapman449/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zapman449/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zapman449/subscriptions", "type": "User", "url": "https://api.github.com/users/zapman449", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" } ]
closed
true
null
[]
null
14
2014-08-01T18:10:59Z
2021-06-28T11:07:38Z
2016-04-06T18:54:17Z
NONE
resolved
Please provide a way to query the request object for the IP address of the server connected to to fulfill the request. Example: >>> r = requests.get("http://www.google.com") >>> r.ip '74.125.225.242'
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2158/reactions" }
https://api.github.com/repos/psf/requests/issues/2158/timeline
null
completed
null
null
false
[ "Hey @zapman449!\n\nThanks for your suggestion! We really appreciate the fact that you took the time to file this. Unfortunately we're not adding anything new to the requests API at this time.\n\nI'll wait for @Lukasa to chime in before closing this though.\n", "Correct, we're not adding anything at this time. It...
https://api.github.com/repos/psf/requests/issues/2157
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2157/labels{/name}
https://api.github.com/repos/psf/requests/issues/2157/comments
https://api.github.com/repos/psf/requests/issues/2157/events
https://github.com/psf/requests/pull/2157
39,271,542
MDExOlB1bGxSZXF1ZXN0MTkxOTkwMDE=
2,157
Changed url in the sidebar for github stars iframe
{ "avatar_url": "https://avatars.githubusercontent.com/u/769447?v=4", "events_url": "https://api.github.com/users/atmb4u/events{/privacy}", "followers_url": "https://api.github.com/users/atmb4u/followers", "following_url": "https://api.github.com/users/atmb4u/following{/other_user}", "gists_url": "https://api.github.com/users/atmb4u/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/atmb4u", "id": 769447, "login": "atmb4u", "node_id": "MDQ6VXNlcjc2OTQ0Nw==", "organizations_url": "https://api.github.com/users/atmb4u/orgs", "received_events_url": "https://api.github.com/users/atmb4u/received_events", "repos_url": "https://api.github.com/users/atmb4u/repos", "site_admin": false, "starred_url": "https://api.github.com/users/atmb4u/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/atmb4u/subscriptions", "type": "User", "url": "https://api.github.com/users/atmb4u", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-08-01T08:45:00Z
2021-09-08T11:00:57Z
2014-08-01T11:19:35Z
NONE
resolved
This is the one which shows up first in Google search results and looks odd with broken sidebar below the logo. ![requests-docs-broken](https://cloud.githubusercontent.com/assets/769447/3776643/f362af58-1957-11e4-94ce-93806eca40b0.png)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2157/reactions" }
https://api.github.com/repos/psf/requests/issues/2157/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2157.diff", "html_url": "https://github.com/psf/requests/pull/2157", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2157.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2157" }
true
[ "As I see, this issue was fixed on the master branch on the latest version. \nIs there a way to edit the documentation here : http://docs.python-requests.org/en/v0.10.7/user/quickstart/ ?\n", "@atmb4u Sadly there isn't. That is built directly off a git tag, which is a static reference to a single commit, we can't...
https://api.github.com/repos/psf/requests/issues/2156
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2156/labels{/name}
https://api.github.com/repos/psf/requests/issues/2156/comments
https://api.github.com/repos/psf/requests/issues/2156/events
https://github.com/psf/requests/issues/2156
39,264,592
MDU6SXNzdWUzOTI2NDU5Mg==
2,156
Not supported proxy scheme socks5
{ "avatar_url": "https://avatars.githubusercontent.com/u/3938751?v=4", "events_url": "https://api.github.com/users/eromoe/events{/privacy}", "followers_url": "https://api.github.com/users/eromoe/followers", "following_url": "https://api.github.com/users/eromoe/following{/other_user}", "gists_url": "https://api.github.com/users/eromoe/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/eromoe", "id": 3938751, "login": "eromoe", "node_id": "MDQ6VXNlcjM5Mzg3NTE=", "organizations_url": "https://api.github.com/users/eromoe/orgs", "received_events_url": "https://api.github.com/users/eromoe/received_events", "repos_url": "https://api.github.com/users/eromoe/repos", "site_admin": false, "starred_url": "https://api.github.com/users/eromoe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eromoe/subscriptions", "type": "User", "url": "https://api.github.com/users/eromoe", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-08-01T06:28:48Z
2021-09-08T20:01:04Z
2014-08-01T11:21:21Z
NONE
resolved
I see https://github.com/kennethreitz/requests/pull/478 is closed, but why I can not use socks5 proxy? define as: ` PROXIES = { "http": "socks5://127.0.0.1:7070", "https": "socks5://127.0.0.1:7070", } ` I use above proxy , and requests raise error `Not supported proxy scheme socks5`
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2156/reactions" }
https://api.github.com/repos/psf/requests/issues/2156/timeline
null
completed
null
null
false
[ "The error is perfectly clear. We do not support SOCKS5 proxies at this time. If you'd read #478 more closely you'd have seen [this comment](https://github.com/kennethreitz/requests/pull/478#issuecomment-24914571) I made:\n\n> We currently do not have SOCKS proxy support, we're waiting for that code to be included ...
https://api.github.com/repos/psf/requests/issues/2155
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2155/labels{/name}
https://api.github.com/repos/psf/requests/issues/2155/comments
https://api.github.com/repos/psf/requests/issues/2155/events
https://github.com/psf/requests/issues/2155
39,202,386
MDU6SXNzdWUzOTIwMjM4Ng==
2,155
Streaming gzipped responses
{ "avatar_url": "https://avatars.githubusercontent.com/u/159414?v=4", "events_url": "https://api.github.com/users/hheimbuerger/events{/privacy}", "followers_url": "https://api.github.com/users/hheimbuerger/followers", "following_url": "https://api.github.com/users/hheimbuerger/following{/other_user}", "gists_url": "https://api.github.com/users/hheimbuerger/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hheimbuerger", "id": 159414, "login": "hheimbuerger", "node_id": "MDQ6VXNlcjE1OTQxNA==", "organizations_url": "https://api.github.com/users/hheimbuerger/orgs", "received_events_url": "https://api.github.com/users/hheimbuerger/received_events", "repos_url": "https://api.github.com/users/hheimbuerger/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hheimbuerger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hheimbuerger/subscriptions", "type": "User", "url": "https://api.github.com/users/hheimbuerger", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" }, { "color": "0b02e1", "default": false, "description": null, "id": 19127...
open
false
null
[]
null
10
2014-07-31T14:55:22Z
2018-09-24T09:33:32Z
null
NONE
null
I need to process big XML responses as a stream. The uncompressed responses can be multiple hundred megabytes in size, so loading them entirely into memory before handing them to the XML parser is not an option. I'm using lxml to parse and I just hand the `response.raw` to its `iterparse()` function, as described somewhere in the requests docs. This works fine for uncompressed responses. Unfortunately, the API I'm calling isn't particularly good. So it will sometimes return `Content-Encoding: gzip` even if I explicitly ask for uncompressed data. Also, the compression ratio on these extremely repetitive and verbose XML files is really good (10x+), so I'd really like to make use of compressed responses. Is this possible with requests? I couldn't find it in the documentation. Researching deeper into urllib3, its [HTTPResponse.read()](https://github.com/shazow/urllib3/blob/master/urllib3/response.py#L140) method seems to support a `decode_content` parameter. If not set, urllib3 falls back to what's set in the constructor. When requests calls the constructor in [requests.adapters.HTTPAdapter.send()](https://github.com/kennethreitz/requests/blob/fe693c492242ae532211e0c173324f09ca8cf227/requests/adapters.py#L343), it explicitly sets `decode_content` to False. Is there a reason why requests does that? Strangely, `iter_content()` actually sets `decode_content=True` while reading. Why here? It all appears a bit arbitrary. I don't really understand the motivation for doing it one way here and another way there. Personally, I can't really use `iter_content()` of course because I need a file-like object for lxml. I previously wrote my own file-like object that I can hook in between requests and lxml, but of course buffering is hard and I feel like smarter people than me have written this before, so I'd prefer to not have to roll my own. What's your advice how to handle this? Should requests be changed to default to setting `decode_content=True` in urllib3?
null
{ "+1": 2, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 2, "url": "https://api.github.com/repos/psf/requests/issues/2155/reactions" }
https://api.github.com/repos/psf/requests/issues/2155/timeline
null
null
null
null
false
[ "No it should not default to setting that for a wide variety of reasons. What you should do is use `functools.partial` to replace the `read` method on the response (or just wrap it another way) so that you do something like:\n\n``` python\nresponse.raw.read = functools.partial(response.raw.read, decode_content=True...
https://api.github.com/repos/psf/requests/issues/2154
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2154/labels{/name}
https://api.github.com/repos/psf/requests/issues/2154/comments
https://api.github.com/repos/psf/requests/issues/2154/events
https://github.com/psf/requests/issues/2154
39,059,024
MDU6SXNzdWUzOTA1OTAyNA==
2,154
Putting a literal encoded + in the request without it encoding.
{ "avatar_url": "https://avatars.githubusercontent.com/u/85492?v=4", "events_url": "https://api.github.com/users/encompass/events{/privacy}", "followers_url": "https://api.github.com/users/encompass/followers", "following_url": "https://api.github.com/users/encompass/following{/other_user}", "gists_url": "https://api.github.com/users/encompass/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/encompass", "id": 85492, "login": "encompass", "node_id": "MDQ6VXNlcjg1NDky", "organizations_url": "https://api.github.com/users/encompass/orgs", "received_events_url": "https://api.github.com/users/encompass/received_events", "repos_url": "https://api.github.com/users/encompass/repos", "site_admin": false, "starred_url": "https://api.github.com/users/encompass/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/encompass/subscriptions", "type": "User", "url": "https://api.github.com/users/encompass", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2014-07-30T04:17:52Z
2021-09-08T23:10:45Z
2014-07-30T10:50:00Z
NONE
resolved
I have to connect to a searching feature, amongst many other features, and I have so far been able to do it easily with one command with python requests. However, when I use the search I need to send one parameter with +'s in it. This person has this same issue... http://stackoverflow.com/questions/12527959/passing-the-character-in-a-post-request-in-python But I feel it's a bit silly considering I am using requests so heavily here. ``` python def send_message(command, payload = {}): command_version = {'offers': "2.1", 'categories': '1.0'} url = BASE_URL + "/" + command_version[command] + "/" + command headers = {"X-Apikey":API_KEY} return requests.get(url, params = payload, headers=headers) send_message('offers', payload={'searchword':search_term, 'limit':page_size+1, 'offset':offset*page_size, "deleted":0}).json()['offers'] ``` As you can see in calling the method, search_term will have text like this: "one+2+three" but the message is encoded as stated in the stackoverflow link I posted. Is there a way I can stop the encoding of the + without having to create a new messaging system just for searches?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2154/reactions" }
https://api.github.com/repos/psf/requests/issues/2154/timeline
null
completed
null
null
false
[ "There are a number of options, but the easiest thing to do is probably to use the [`PreparedRequest`](http://docs.python-requests.org/en/latest/user/advanced/#prepared-requests) flow. Building the `PreparedRequest` will let you arbitrarily mutate its encoded `r.url` property, and you can then use the tools in `url...
https://api.github.com/repos/psf/requests/issues/2153
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2153/labels{/name}
https://api.github.com/repos/psf/requests/issues/2153/comments
https://api.github.com/repos/psf/requests/issues/2153/events
https://github.com/psf/requests/pull/2153
39,057,455
MDExOlB1bGxSZXF1ZXN0MTkwNjc4ODA=
2,153
handle urllib3 api changes; closes #2045
{ "avatar_url": "https://avatars.githubusercontent.com/u/2245080?v=4", "events_url": "https://api.github.com/users/jschneier/events{/privacy}", "followers_url": "https://api.github.com/users/jschneier/followers", "following_url": "https://api.github.com/users/jschneier/following{/other_user}", "gists_url": "https://api.github.com/users/jschneier/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jschneier", "id": 2245080, "login": "jschneier", "node_id": "MDQ6VXNlcjIyNDUwODA=", "organizations_url": "https://api.github.com/users/jschneier/orgs", "received_events_url": "https://api.github.com/users/jschneier/received_events", "repos_url": "https://api.github.com/users/jschneier/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jschneier/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jschneier/subscriptions", "type": "User", "url": "https://api.github.com/users/jschneier", "user_view_type": "public" }
[ { "color": "009800", "default": false, "description": null, "id": 44501218, "name": "Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTIxOA==", "url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge" }, { "color": "207de5", "default": false, "description...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
3
2014-07-30T03:32:34Z
2021-09-08T11:00:56Z
2014-08-02T01:33:56Z
CONTRIBUTOR
resolved
urllib3 changed and now catches all of the exceptions in `iter_content` that requests was working around. This patch addresses those changes so that the proper exceptions are being caught and rethrown.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2153/reactions" }
https://api.github.com/repos/psf/requests/issues/2153/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2153.diff", "html_url": "https://github.com/psf/requests/pull/2153", "merged_at": "2014-08-02T01:33:56Z", "patch_url": "https://github.com/psf/requests/pull/2153.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2153" }
true
[ ":heart: Thanks @jschneier !\n\nLGTM! :+1: \n", ":cake: LGTM also.\n", "wonderous!\n" ]
https://api.github.com/repos/psf/requests/issues/2152
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2152/labels{/name}
https://api.github.com/repos/psf/requests/issues/2152/comments
https://api.github.com/repos/psf/requests/issues/2152/events
https://github.com/psf/requests/issues/2152
38,845,129
MDU6SXNzdWUzODg0NTEyOQ==
2,152
Raise exception if status code doesn't equal 200
{ "avatar_url": "https://avatars.githubusercontent.com/u/1218474?v=4", "events_url": "https://api.github.com/users/Matt3o12/events{/privacy}", "followers_url": "https://api.github.com/users/Matt3o12/followers", "following_url": "https://api.github.com/users/Matt3o12/following{/other_user}", "gists_url": "https://api.github.com/users/Matt3o12/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Matt3o12", "id": 1218474, "login": "Matt3o12", "node_id": "MDQ6VXNlcjEyMTg0NzQ=", "organizations_url": "https://api.github.com/users/Matt3o12/orgs", "received_events_url": "https://api.github.com/users/Matt3o12/received_events", "repos_url": "https://api.github.com/users/Matt3o12/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Matt3o12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Matt3o12/subscriptions", "type": "User", "url": "https://api.github.com/users/Matt3o12", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-07-27T16:20:08Z
2021-09-08T23:10:46Z
2014-07-27T16:30:16Z
NONE
resolved
Hello, I often expect the request to have status code 200 and if it doesn't there isn't much I can do about (seriously when the server returns with error 500, I won't be able to do something). So I need to write code like this: ``` r = requests.get(self.url(False)) if r.status_code != 200: raise requests.ConnectionError("Expected status code 200, but got {}".format(page.status_code)) ``` I think a kwarg called allowed_status_codes would be very convenient. It could be implemented like this: By default it is `None`. `None`, and an empty list or tuple means allow all status codes. It may be an integer, list, tuple, or enum. If it is an integer, only allow this specific status code. In case it is a list or tuple, only status codes that are inside of the list/tuple are allowed. The list may have integers and/or enums. Enums should be a little bit more flexible. For instance, if I wanted to allow all "successful" (2xx) requests, I could write: allowed_status_codes=requests.ALLOW_SUCCESS, which will throw an exception unless the status code is 2xx. If I only wanted to disallow server errors (and thus handle not authenticated errors), I could simply write allowed_status_codes=requests.DISALLOW_SERVER_ERROR, which will raise an exception if the server code is 5xx. Of course there should be lots of enums that cover specific cases. And one should also be able to use it combined within a list (e.g. `(200, ALLOW_REDIRECTIONS)`). If the status code isn't allowed, a `StatusCodeError(RequestException)` will be raised. --- Even though I mentioned enums, I'm not talking about Python 3.4's enumerated values. I was talking rather about constants. Enums (constants) could be implemented like this: ``` #request model. ALLOW_SUCCESS = AllowSuccessEnum() # other enums class RequestEnum(object): def is_status_code_allowed(status_code): raise NotImplementedError class AllowSuccessEnum(RequestEnum): def is_status_code_allowed(status_code): # return false unless status code is 2xx ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2152/reactions" }
https://api.github.com/repos/psf/requests/issues/2152/timeline
null
completed
null
null
false
[ "Thanks for this idea!\n\nIt's not clear why this belongs in requests itself. The code required is not complex, and I do not believe we would add much value by having this code in the library. We _would_, however, be adding another keyword argument to the API, which is something we're disinclined to do most of the ...
https://api.github.com/repos/psf/requests/issues/2151
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2151/labels{/name}
https://api.github.com/repos/psf/requests/issues/2151/comments
https://api.github.com/repos/psf/requests/issues/2151/events
https://github.com/psf/requests/issues/2151
38,817,425
MDU6SXNzdWUzODgxNzQyNQ==
2,151
HTTP Status Code always 404
{ "avatar_url": "https://avatars.githubusercontent.com/u/237062?v=4", "events_url": "https://api.github.com/users/tvrcgo/events{/privacy}", "followers_url": "https://api.github.com/users/tvrcgo/followers", "following_url": "https://api.github.com/users/tvrcgo/following{/other_user}", "gists_url": "https://api.github.com/users/tvrcgo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tvrcgo", "id": 237062, "login": "tvrcgo", "node_id": "MDQ6VXNlcjIzNzA2Mg==", "organizations_url": "https://api.github.com/users/tvrcgo/orgs", "received_events_url": "https://api.github.com/users/tvrcgo/received_events", "repos_url": "https://api.github.com/users/tvrcgo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tvrcgo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tvrcgo/subscriptions", "type": "User", "url": "https://api.github.com/users/tvrcgo", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-07-26T13:25:55Z
2021-09-08T23:10:47Z
2014-07-26T14:38:05Z
NONE
resolved
http status code always 404 even though link actually exists and can be accessed directly.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2151/reactions" }
https://api.github.com/repos/psf/requests/issues/2151/timeline
null
completed
null
null
false
[ "This bug report is seriously incomplete.\n\nCan you suggest what the link is? Can you provide some sample code that reproduces the bug?\n", "When I try to open that URL from my browser I also get a 404. Are you sure this URL is correct?\n", "sample code:\n\nimport requests\n\nif **name** == \"**main**\":\n ...
https://api.github.com/repos/psf/requests/issues/2150
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2150/labels{/name}
https://api.github.com/repos/psf/requests/issues/2150/comments
https://api.github.com/repos/psf/requests/issues/2150/events
https://github.com/psf/requests/issues/2150
38,732,431
MDU6SXNzdWUzODczMjQzMQ==
2,150
requests loosing cookies
{ "avatar_url": "https://avatars.githubusercontent.com/u/1548328?v=4", "events_url": "https://api.github.com/users/s0rg/events{/privacy}", "followers_url": "https://api.github.com/users/s0rg/followers", "following_url": "https://api.github.com/users/s0rg/following{/other_user}", "gists_url": "https://api.github.com/users/s0rg/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/s0rg", "id": 1548328, "login": "s0rg", "node_id": "MDQ6VXNlcjE1NDgzMjg=", "organizations_url": "https://api.github.com/users/s0rg/orgs", "received_events_url": "https://api.github.com/users/s0rg/received_events", "repos_url": "https://api.github.com/users/s0rg/repos", "site_admin": false, "starred_url": "https://api.github.com/users/s0rg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/s0rg/subscriptions", "type": "User", "url": "https://api.github.com/users/s0rg", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-07-25T13:52:38Z
2021-09-08T23:10:47Z
2014-07-25T14:28:18Z
NONE
resolved
Because of dict-like headers requests can loose one ore more cookies (i.e. http://www.lineage2dex.com/): Set-Cookie: __HFCTL=0; path=/ Set-Cookie: PHPSESSID=7c3129a98cc6a75e0cbf71b7a3513364; path=/ But in requests i have only one (the first). I think the solution is to take othe data structure (like http://werkzeug.pocoo.org/docs/datastructures/#werkzeug.datastructures.MultiDict from werkzeug) that will not break api, but can hadle this situation.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2150/reactions" }
https://api.github.com/repos/psf/requests/issues/2150/timeline
null
completed
null
null
false
[ "@s0rg you didn't tell us which version of requests you're using so we can't even test this to ensure that it's a problem.\n", "Besides that, this appears to be an issue with `httplib`:\n\n``` pycon\n>>> conn = httplib.HTTPConnection('www.lineage2dex.com')\n>>> conn.request('GET', 'http://www.lineage2dex.com/')\n...
https://api.github.com/repos/psf/requests/issues/2149
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2149/labels{/name}
https://api.github.com/repos/psf/requests/issues/2149/comments
https://api.github.com/repos/psf/requests/issues/2149/events
https://github.com/psf/requests/issues/2149
38,715,791
MDU6SXNzdWUzODcxNTc5MQ==
2,149
How to make spaces to encode as %20 instead of +?
{ "avatar_url": "https://avatars.githubusercontent.com/u/5586633?v=4", "events_url": "https://api.github.com/users/Greblys/events{/privacy}", "followers_url": "https://api.github.com/users/Greblys/followers", "following_url": "https://api.github.com/users/Greblys/following{/other_user}", "gists_url": "https://api.github.com/users/Greblys/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Greblys", "id": 5586633, "login": "Greblys", "node_id": "MDQ6VXNlcjU1ODY2MzM=", "organizations_url": "https://api.github.com/users/Greblys/orgs", "received_events_url": "https://api.github.com/users/Greblys/received_events", "repos_url": "https://api.github.com/users/Greblys/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Greblys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Greblys/subscriptions", "type": "User", "url": "https://api.github.com/users/Greblys", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-07-25T10:10:54Z
2021-09-08T23:10:47Z
2014-07-25T10:15:13Z
NONE
resolved
`print requests.get("http://url.com", params={"key" : "asd asd").url` I want this output: `http://url.com?key=asd%20asd`, but I get this: `http://url.com?key=asd+asd`
{ "avatar_url": "https://avatars.githubusercontent.com/u/5586633?v=4", "events_url": "https://api.github.com/users/Greblys/events{/privacy}", "followers_url": "https://api.github.com/users/Greblys/followers", "following_url": "https://api.github.com/users/Greblys/following{/other_user}", "gists_url": "https://api.github.com/users/Greblys/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Greblys", "id": 5586633, "login": "Greblys", "node_id": "MDQ6VXNlcjU1ODY2MzM=", "organizations_url": "https://api.github.com/users/Greblys/orgs", "received_events_url": "https://api.github.com/users/Greblys/received_events", "repos_url": "https://api.github.com/users/Greblys/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Greblys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Greblys/subscriptions", "type": "User", "url": "https://api.github.com/users/Greblys", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2149/reactions" }
https://api.github.com/repos/psf/requests/issues/2149/timeline
null
completed
null
null
false
[ "Requests provides no easy way to do this, because it follows the W3C standard for urlencoding that specifies that urlencoded spaces map to '+' chars, not %20.\n\nYou'll notice we map to %20 in other parts of the URL.\n" ]
https://api.github.com/repos/psf/requests/issues/2148
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2148/labels{/name}
https://api.github.com/repos/psf/requests/issues/2148/comments
https://api.github.com/repos/psf/requests/issues/2148/events
https://github.com/psf/requests/pull/2148
38,673,757
MDExOlB1bGxSZXF1ZXN0MTg4NjM4NzY=
2,148
Handle socket errors in iter_content
{ "avatar_url": "https://avatars.githubusercontent.com/u/132421?v=4", "events_url": "https://api.github.com/users/romanlevin/events{/privacy}", "followers_url": "https://api.github.com/users/romanlevin/followers", "following_url": "https://api.github.com/users/romanlevin/following{/other_user}", "gists_url": "https://api.github.com/users/romanlevin/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/romanlevin", "id": 132421, "login": "romanlevin", "node_id": "MDQ6VXNlcjEzMjQyMQ==", "organizations_url": "https://api.github.com/users/romanlevin/orgs", "received_events_url": "https://api.github.com/users/romanlevin/received_events", "repos_url": "https://api.github.com/users/romanlevin/repos", "site_admin": false, "starred_url": "https://api.github.com/users/romanlevin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/romanlevin/subscriptions", "type": "User", "url": "https://api.github.com/users/romanlevin", "user_view_type": "public" }
[ { "color": "009800", "default": false, "description": null, "id": 44501218, "name": "Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTIxOA==", "url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge" }, { "color": "207de5", "default": false, "description...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
4
2014-07-24T21:03:03Z
2021-09-08T11:00:57Z
2014-07-27T13:59:08Z
CONTRIBUTOR
resolved
My first PR for Requests, so I probably did something terribly wrong. Closes #2144.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2148/reactions" }
https://api.github.com/repos/psf/requests/issues/2148/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2148.diff", "html_url": "https://github.com/psf/requests/pull/2148", "merged_at": "2014-07-27T13:59:08Z", "patch_url": "https://github.com/psf/requests/pull/2148.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2148" }
true
[ "![:+1:](https://d16jfyletng9p5.cloudfront.net/media/bOUbNyILuU56U/giphy.gif)\n", "This looks good to me. =)\n", "@sigmavirus24 @alex Fixed. Not sure what I was thinking, there.\n", ":sparkles: :cake: :sparkles: \n" ]
https://api.github.com/repos/psf/requests/issues/2147
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2147/labels{/name}
https://api.github.com/repos/psf/requests/issues/2147/comments
https://api.github.com/repos/psf/requests/issues/2147/events
https://github.com/psf/requests/issues/2147
38,563,168
MDU6SXNzdWUzODU2MzE2OA==
2,147
requests does not use custom transport adapter settings after a redirect
{ "avatar_url": "https://avatars.githubusercontent.com/u/7874479?v=4", "events_url": "https://api.github.com/users/s-dixit/events{/privacy}", "followers_url": "https://api.github.com/users/s-dixit/followers", "following_url": "https://api.github.com/users/s-dixit/following{/other_user}", "gists_url": "https://api.github.com/users/s-dixit/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/s-dixit", "id": 7874479, "login": "s-dixit", "node_id": "MDQ6VXNlcjc4NzQ0Nzk=", "organizations_url": "https://api.github.com/users/s-dixit/orgs", "received_events_url": "https://api.github.com/users/s-dixit/received_events", "repos_url": "https://api.github.com/users/s-dixit/repos", "site_admin": false, "starred_url": "https://api.github.com/users/s-dixit/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/s-dixit/subscriptions", "type": "User", "url": "https://api.github.com/users/s-dixit", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-07-23T19:31:53Z
2021-09-08T23:10:48Z
2014-07-23T19:37:18Z
NONE
resolved
![requests-capture-1](https://cloud.githubusercontent.com/assets/7874479/3678984/e50e403e-129f-11e4-824a-6b2d88003a20.JPG) Hi I am seeing an issue where after a 302 redirect, requests does not use custom adapter attached to the session. The custom adapter is a subclass of requests HTTPAdapter and uses 'source_address' property of HTTPLib. For the first session.get, it uses the source IP address from the custom adapter. However, when a request is redirected, it uses a the default IP address on the machine. For the ifconfig below, first GET it sent out with IP 20.20.1.4 which is set in the custom transport adapter. Redirect request uses IP= 20.20.1.3. Please see attached image of PCAP. eth1 Link encap:Ethernet HWaddr 00:50:56:98:40:3c inet addr:20.20.1.3 Bcast:20.20.1.255 Mask:255.255.255.0 inet6 addr: fe80::250:56ff:fe98:403c/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:11604716 errors:0 dropped:0 overruns:0 frame:0 TX packets:5560908 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:15153507687 (15.1 GB) TX bytes:532461537 (532.4 MB) eth1:1 Link encap:Ethernet HWaddr 00:50:56:98:40:3c inet addr:20.20.1.4 Bcast:20.20.1.255 Mask:255.255.255.0 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 --- ## Here is the code in main ... HTTPHeaders = {'Connection': 'keep-alive', 'Cache-Control': 'no-cache', 'Accept-Encoding': 'gzip,deflate,sdch', 'Accept-Language': 'en-US'} srcIP = '20.20.1.4' s1 = requests.session() s1.mount('http://20.20.1.2/', customTransportAdapter(srcIP)) s1.auth = HTTPCustomNtlmAuth('systemqa\tester1', '12345678', srcIP) response1 = s1.get('http://20.20.1.2/dbx.html', headers=HTTPHeaders, timeout=1) # end of main --- ## Custom transport adapter # !/home/tester/HTTP_AUTH/bin/python import requests import requests.adapters from requests.adapters import HTTPAdapter DEFAULT_POOLBLOCK = False DEFAULT_POOLSIZE = 10 DEFAULT_RETRIES = 0 class customTransportAdapter(HTTPAdapter): def **init**(self, sourceIP): self.sourceIP = sourceIP HTTPAdapter.**init**(self, pool_connections=DEFAULT_POOLSIZE, pool_maxsize=DEFAULT_POOLSIZE, max_retries=DEFAULT_RETRIES, pool_block=DEFAULT_POOLBLOCK) ``` def init_poolmanager(self, connections, maxsize, block=DEFAULT_POOLBLOCK): # save these values for pickling self._pool_connections = connections self._pool_maxsize = maxsize self._pool_block = block self.poolmanager = requests.adapters.PoolManager(num_pools=connections, maxsize=maxsize, block=block, source_address=(self.sourceIP, 0)) ``` ---
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2147/reactions" }
https://api.github.com/repos/psf/requests/issues/2147/timeline
null
completed
null
null
false
[ "You've mounted your source address adapter to `http://20.20.1.2/`, but the redirect takes you off that host, to `http://20.20.1.1/`. We evaluate which adapter to use for each request independently.\n\nMount a source address adapter for `http://20.20.1.1/` as well and you'll be fine. Alternatively, mount it to `htt...
https://api.github.com/repos/psf/requests/issues/2146
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2146/labels{/name}
https://api.github.com/repos/psf/requests/issues/2146/comments
https://api.github.com/repos/psf/requests/issues/2146/events
https://github.com/psf/requests/issues/2146
38,499,051
MDU6SXNzdWUzODQ5OTA1MQ==
2,146
Invocation of `SSLContext.load_verify_locations` causes intermittent hanging
{ "avatar_url": "https://avatars.githubusercontent.com/u/1829591?v=4", "events_url": "https://api.github.com/users/scott-coates/events{/privacy}", "followers_url": "https://api.github.com/users/scott-coates/followers", "following_url": "https://api.github.com/users/scott-coates/following{/other_user}", "gists_url": "https://api.github.com/users/scott-coates/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/scott-coates", "id": 1829591, "login": "scott-coates", "node_id": "MDQ6VXNlcjE4Mjk1OTE=", "organizations_url": "https://api.github.com/users/scott-coates/orgs", "received_events_url": "https://api.github.com/users/scott-coates/received_events", "repos_url": "https://api.github.com/users/scott-coates/repos", "site_admin": false, "starred_url": "https://api.github.com/users/scott-coates/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/scott-coates/subscriptions", "type": "User", "url": "https://api.github.com/users/scott-coates", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 136589914, "name": "Needs Info", "node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=", "url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info" }, { "color": "f7c6c7", "default": false, "description": null, ...
closed
true
null
[]
null
2
2014-07-23T06:14:57Z
2021-09-08T23:06:07Z
2015-01-19T09:20:52Z
NONE
resolved
I have a background worker that makes many http requests to various APIs. I've found that every time my job runs, a few requests appear to just "hang" for quite a long time. I've investigated further and it appears the requests are not actually hanging, but my python code "hangs" when it invokes `OpenSSL's` `SSL_CTX_load_verify_locations` function. I forked `requests` and added some more logging. The last entry to be logged in my code is `begin: ssl_wrap_socket: load verify locations` and that corresponds to [this line](https://github.com/WiFL-co/requests/blob/master/requests/packages/urllib3/util/ssl_.py#L118). One possible conclusion is that SSL_CTX_load_verify_locations is hanging because of parallel file access or the version of OpenSSL on my Heroku dyno has a bug. FYI the `requests` library is calling python's `load_verify_locations` which is what then calls `OpenSSL`. I am not invoking these functions manually. [I've created a question on StackOverflow](http://stackoverflow.com/questions/24628866/why-does-my-program-hang-after-urllib3-logs-starting-new-https-connection) that provides extensive information. I am using the following dependencies: ``` python 3.4 requests==2.3.0. Rabbit 3.1.3 celery:3.1.11 (Cipater w/ Prefork) kombu:3.0.16 billiard:3.3.0.17 py-amqp:1.4.5 ``` @Lukasa has been really helpful thus far, and I've been able to narrow it down. I figured i'd throw this issue up and see if anyone else has some insight.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2146/reactions" }
https://api.github.com/repos/psf/requests/issues/2146/timeline
null
completed
null
null
false
[ "I'm really interested to see what people can come up with here. I cannot see any good reason for `SSL_CTX_load_verify_locations` to hang.\n", "Closed for inactivity.\n" ]
https://api.github.com/repos/psf/requests/issues/2145
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2145/labels{/name}
https://api.github.com/repos/psf/requests/issues/2145/comments
https://api.github.com/repos/psf/requests/issues/2145/events
https://github.com/psf/requests/pull/2145
38,418,399
MDExOlB1bGxSZXF1ZXN0MTg3MjU0ODI=
2,145
Update faq.rst
{ "avatar_url": "https://avatars.githubusercontent.com/u/72590?v=4", "events_url": "https://api.github.com/users/TkTech/events{/privacy}", "followers_url": "https://api.github.com/users/TkTech/followers", "following_url": "https://api.github.com/users/TkTech/following{/other_user}", "gists_url": "https://api.github.com/users/TkTech/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/TkTech", "id": 72590, "login": "TkTech", "node_id": "MDQ6VXNlcjcyNTkw", "organizations_url": "https://api.github.com/users/TkTech/orgs", "received_events_url": "https://api.github.com/users/TkTech/received_events", "repos_url": "https://api.github.com/users/TkTech/repos", "site_admin": false, "starred_url": "https://api.github.com/users/TkTech/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TkTech/subscriptions", "type": "User", "url": "https://api.github.com/users/TkTech", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-07-22T16:38:13Z
2021-09-08T11:00:58Z
2014-07-22T20:20:37Z
CONTRIBUTOR
resolved
Removed an unnecessary "to" in the "What are "hostname doesn't match" errors?" section.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2145/reactions" }
https://api.github.com/repos/psf/requests/issues/2145/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2145.diff", "html_url": "https://github.com/psf/requests/pull/2145", "merged_at": "2014-07-22T20:20:37Z", "patch_url": "https://github.com/psf/requests/pull/2145.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2145" }
true
[ "Why don't we just rewrite that entire sentence? Something like:\n\n\"This is important when servers are using Virtual Hosting (include link). When these servers are hosting several SSL sites they need to be able to return the appropriate certificate based on the hostname the client is connecting to.\"\n", "@sigm...
https://api.github.com/repos/psf/requests/issues/2144
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2144/labels{/name}
https://api.github.com/repos/psf/requests/issues/2144/comments
https://api.github.com/repos/psf/requests/issues/2144/events
https://github.com/psf/requests/issues/2144
38,386,919
MDU6SXNzdWUzODM4NjkxOQ==
2,144
socket.error exception not caught/wrapped in a requests exception (ConnectionError perhaps?)
{ "avatar_url": "https://avatars.githubusercontent.com/u/5319942?v=4", "events_url": "https://api.github.com/users/rtdean/events{/privacy}", "followers_url": "https://api.github.com/users/rtdean/followers", "following_url": "https://api.github.com/users/rtdean/following{/other_user}", "gists_url": "https://api.github.com/users/rtdean/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rtdean", "id": 5319942, "login": "rtdean", "node_id": "MDQ6VXNlcjUzMTk5NDI=", "organizations_url": "https://api.github.com/users/rtdean/orgs", "received_events_url": "https://api.github.com/users/rtdean/received_events", "repos_url": "https://api.github.com/users/rtdean/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rtdean/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rtdean/subscriptions", "type": "User", "url": "https://api.github.com/users/rtdean", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" }, { "color": "0b02e1", "default": false, "description": null, "id": 191274, "...
closed
true
null
[]
null
1
2014-07-22T10:23:48Z
2021-09-08T23:10:46Z
2014-07-27T13:59:08Z
NONE
resolved
I just noticed a case where I had a socket reset on me, and was raised to me as a raw socket error as opposed to something like a requests.exceptions.ConnectionError: ``` File "/home/rtdean/***/***/***/***/***/***.py", line 67, in dir_parse root = ElementTree.fromstring(response.text) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/site-packages/requests-2.3.0-py2.7.egg/requests/models.py", line 721, in text if not self.content: File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/site-packages/requests-2.3.0-py2.7.egg/requests/models.py", line 694, in content self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes() File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/site-packages/requests-2.3.0-py2.7.egg/requests/models.py", line 627, in generate for chunk in self.raw.stream(chunk_size, decode_content=True): File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/site-packages/requests-2.3.0-py2.7.egg/requests/packages/urllib3/response.py", line 240, in stream data = self.read(amt=amt, decode_content=decode_content) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/site-packages/requests-2.3.0-py2.7.egg/requests/packages/urllib3/response.py", line 187, in read data = self._fp.read(amt) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/httplib.py", line 543, in read return self._read_chunked(amt) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/httplib.py", line 612, in _read_chunked value.append(self._safe_read(chunk_left)) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/httplib.py", line 658, in _safe_read chunk = self.fp.read(min(amt, MAXAMOUNT)) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left) File "/home/rtdean/.pyenv/versions/2.7.6/lib/python2.7/site-packages/gevent-1.0.1-py2.7-linux-x86_64.egg/gevent/socket.py", line 385, in recv return sock.recv(*args) socket.error: [Errno 104] Connection reset by peer ``` Not sure if this is by accident or design... in general, I guess I'd expect a requests exception when using requests, but I can start looking for socket errors and the like as well.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2144/reactions" }
https://api.github.com/repos/psf/requests/issues/2144/timeline
null
completed
null
null
false
[ "No, this looks like an error.\n\n`iter_content` doesn't seem to expect any socket errors, but it should. We need to fix this.\n" ]
https://api.github.com/repos/psf/requests/issues/2143
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2143/labels{/name}
https://api.github.com/repos/psf/requests/issues/2143/comments
https://api.github.com/repos/psf/requests/issues/2143/events
https://github.com/psf/requests/issues/2143
38,339,059
MDU6SXNzdWUzODMzOTA1OQ==
2,143
Incomplete support for OPTIONS method
{ "avatar_url": "https://avatars.githubusercontent.com/u/8227993?v=4", "events_url": "https://api.github.com/users/jeffg-vsn/events{/privacy}", "followers_url": "https://api.github.com/users/jeffg-vsn/followers", "following_url": "https://api.github.com/users/jeffg-vsn/following{/other_user}", "gists_url": "https://api.github.com/users/jeffg-vsn/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jeffg-vsn", "id": 8227993, "login": "jeffg-vsn", "node_id": "MDQ6VXNlcjgyMjc5OTM=", "organizations_url": "https://api.github.com/users/jeffg-vsn/orgs", "received_events_url": "https://api.github.com/users/jeffg-vsn/received_events", "repos_url": "https://api.github.com/users/jeffg-vsn/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jeffg-vsn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jeffg-vsn/subscriptions", "type": "User", "url": "https://api.github.com/users/jeffg-vsn", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" } ]
closed
true
null
[]
null
10
2014-07-21T20:01:38Z
2021-09-08T23:08:08Z
2014-09-12T15:58:06Z
NONE
resolved
The specification for the OPTIONS method in [RFC 2616, section 9.2](http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.2) includes the following: > If the Request-URI is an asterisk ("*"), the OPTIONS request is intended to apply to the server in general rather than to a specific resource. Since a server's communication options typically depend on the resource, the "*" request is only useful as a "ping" or "no-op" type of method; it does nothing beyond allowing the client to test the capabilities of the server. For example, this can be used to test a proxy for HTTP/1.1 compliance (or lack thereof). Because the Requests API only uses full URLs, it is currently impossible to make an `OPTIONS *` request as described above.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2143/reactions" }
https://api.github.com/repos/psf/requests/issues/2143/timeline
null
completed
null
null
false
[ "You're quite right.\n\nI'm not sure that's so big a problem though. As discussed, it's not a hugely useful request in and of itself, and it's deeply unclear how we'd structure the API to make such a request useful. What's your use case?\n", "My particular use case for such a request is that I'm using it as a lig...
https://api.github.com/repos/psf/requests/issues/2142
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2142/labels{/name}
https://api.github.com/repos/psf/requests/issues/2142/comments
https://api.github.com/repos/psf/requests/issues/2142/events
https://github.com/psf/requests/pull/2142
38,332,012
MDExOlB1bGxSZXF1ZXN0MTg2NzE4MTI=
2,142
Upgrade urllib3 to 1.9.x
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2014-07-21T18:46:08Z
2021-09-08T11:00:57Z
2014-07-22T20:21:05Z
CONTRIBUTOR
resolved
It seems urllib3 changed the timeout logic such that, we now have a failing test (`test_stream_timeout`). We now receive a `MaxRetryError` instead of a `TimeoutError` from urllib3. Either we have to adjust or this is a bug that needs to be fixed in urllib3. Thoughts @shazow @lukasa?
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2142/reactions" }
https://api.github.com/repos/psf/requests/issues/2142/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2142.diff", "html_url": "https://github.com/psf/requests/pull/2142", "merged_at": "2014-07-22T20:21:05Z", "patch_url": "https://github.com/psf/requests/pull/2142.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2142" }
true
[ "Don't think it's strictly a urllib3 bug: I seem to recall @shazow had a comment in his urllib3 code wondering why `Timeout`s weren't wrapped in `MaxRetryError`s.\n\nAs for what to do, I'm not sure. Check what the wrapped exception is, maybe?\n", "I'm not convinced that `ReadTimeoutError`s are the same as a `MaxR...
https://api.github.com/repos/psf/requests/issues/2141
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2141/labels{/name}
https://api.github.com/repos/psf/requests/issues/2141/comments
https://api.github.com/repos/psf/requests/issues/2141/events
https://github.com/psf/requests/pull/2141
38,193,066
MDExOlB1bGxSZXF1ZXN0MTg1OTYzODk=
2,141
Docs: Using print() function instead print command on advanced & quickstart
{ "avatar_url": "https://avatars.githubusercontent.com/u/1037088?v=4", "events_url": "https://api.github.com/users/esparta/events{/privacy}", "followers_url": "https://api.github.com/users/esparta/followers", "following_url": "https://api.github.com/users/esparta/following{/other_user}", "gists_url": "https://api.github.com/users/esparta/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/esparta", "id": 1037088, "login": "esparta", "node_id": "MDQ6VXNlcjEwMzcwODg=", "organizations_url": "https://api.github.com/users/esparta/orgs", "received_events_url": "https://api.github.com/users/esparta/received_events", "repos_url": "https://api.github.com/users/esparta/repos", "site_admin": false, "starred_url": "https://api.github.com/users/esparta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/esparta/subscriptions", "type": "User", "url": "https://api.github.com/users/esparta", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2014-07-18T16:51:21Z
2021-09-08T22:01:17Z
2014-07-18T20:17:43Z
CONTRIBUTOR
resolved
Half of documentation use print() & half the print command.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2141/reactions" }
https://api.github.com/repos/psf/requests/issues/2141/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2141.diff", "html_url": "https://github.com/psf/requests/pull/2141", "merged_at": "2014-07-18T20:17:43Z", "patch_url": "https://github.com/psf/requests/pull/2141.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2141" }
true
[ "This looks good to me. We're already using the print function in several places on the advanced.rst page. Any objections @Lukasa ?\n", "None at all. =) Let's do it.\n", ":cake:\n", "nice :) \n" ]
https://api.github.com/repos/psf/requests/issues/2140
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2140/labels{/name}
https://api.github.com/repos/psf/requests/issues/2140/comments
https://api.github.com/repos/psf/requests/issues/2140/events
https://github.com/psf/requests/pull/2140
38,155,587
MDExOlB1bGxSZXF1ZXN0MTg1NzI0MzY=
2,140
Linkify Github usernames in authors list
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[ { "color": "e11d21", "default": false, "description": null, "id": 44501305, "name": "Not Ready To Merge", "node_id": "MDU6TGFiZWw0NDUwMTMwNQ==", "url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge" } ]
closed
true
null
[]
null
3
2014-07-18T08:01:47Z
2021-09-08T11:00:56Z
2014-07-22T06:57:25Z
CONTRIBUTOR
resolved
- Linkify github usernames - Remove usernames that do not exist Change-Id: Ib88b70a3010e915b3570ae5062c8cb416c9a6462
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2140/reactions" }
https://api.github.com/repos/psf/requests/issues/2140/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2140.diff", "html_url": "https://github.com/psf/requests/pull/2140", "merged_at": "2014-07-22T06:57:25Z", "patch_url": "https://github.com/psf/requests/pull/2140.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2140" }
true
[ "Fixup those who used Twitter and we're good to go. =)\n", "Added a commit to linkify the Twitter accounts.\n", "LGTM, thanks for this! :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2139
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2139/labels{/name}
https://api.github.com/repos/psf/requests/issues/2139/comments
https://api.github.com/repos/psf/requests/issues/2139/events
https://github.com/psf/requests/pull/2139
38,155,546
MDExOlB1bGxSZXF1ZXN0MTg1NzI0MDk=
2,139
More line wrapping
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-07-18T08:01:16Z
2021-09-08T22:01:19Z
2014-07-18T09:59:48Z
CONTRIBUTOR
resolved
Wrapping lines at around 80 chars.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2139/reactions" }
https://api.github.com/repos/psf/requests/issues/2139/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2139.diff", "html_url": "https://github.com/psf/requests/pull/2139", "merged_at": "2014-07-18T09:59:48Z", "patch_url": "https://github.com/psf/requests/pull/2139.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2139" }
true
[ ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2138
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2138/labels{/name}
https://api.github.com/repos/psf/requests/issues/2138/comments
https://api.github.com/repos/psf/requests/issues/2138/events
https://github.com/psf/requests/pull/2138
38,151,009
MDExOlB1bGxSZXF1ZXN0MTg1Njk3NzU=
2,138
More doc updates
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2014-07-18T06:23:02Z
2021-09-08T22:01:20Z
2014-07-18T07:24:27Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2138/reactions" }
https://api.github.com/repos/psf/requests/issues/2138/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2138.diff", "html_url": "https://github.com/psf/requests/pull/2138", "merged_at": "2014-07-18T07:24:27Z", "patch_url": "https://github.com/psf/requests/pull/2138.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2138" }
true
[ "One note here, otherwise it's good to go.\n", ":cake: :star:\n" ]
https://api.github.com/repos/psf/requests/issues/2137
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2137/labels{/name}
https://api.github.com/repos/psf/requests/issues/2137/comments
https://api.github.com/repos/psf/requests/issues/2137/events
https://github.com/psf/requests/issues/2137
38,094,498
MDU6SXNzdWUzODA5NDQ5OA==
2,137
proxy not used for second connect
{ "avatar_url": "https://avatars.githubusercontent.com/u/3251523?v=4", "events_url": "https://api.github.com/users/emdete/events{/privacy}", "followers_url": "https://api.github.com/users/emdete/followers", "following_url": "https://api.github.com/users/emdete/following{/other_user}", "gists_url": "https://api.github.com/users/emdete/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/emdete", "id": 3251523, "login": "emdete", "node_id": "MDQ6VXNlcjMyNTE1MjM=", "organizations_url": "https://api.github.com/users/emdete/orgs", "received_events_url": "https://api.github.com/users/emdete/received_events", "repos_url": "https://api.github.com/users/emdete/repos", "site_admin": false, "starred_url": "https://api.github.com/users/emdete/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/emdete/subscriptions", "type": "User", "url": "https://api.github.com/users/emdete", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2014-07-17T15:38:26Z
2021-09-08T23:10:49Z
2014-07-17T17:59:55Z
NONE
resolved
Hi, we encountered a strange problem where requests stops using the proxy. if a http(s) connection to a server is not using keep-alive a new connection to that server is made per request. while the first connection uses the proxy well the second connection times out because it does not use the proxy anymore. i figured out a fast-fix by re-evaluating the proxy object always. i just removed the line 209 in requests/adapters.py to always call proxy_from_url. this works for us. if needed i could dive deeper into it to help to get more information if wanted. regards, michael
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2137/reactions" }
https://api.github.com/repos/psf/requests/issues/2137/timeline
null
completed
null
null
false
[ "This seems like it is related to https://github.com/pypa/pip/issues/1805. \n", "Agreed.\n", "That means this will be fixed by the next release of requests, when we pull in a new urllib3.\n" ]
https://api.github.com/repos/psf/requests/issues/2136
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2136/labels{/name}
https://api.github.com/repos/psf/requests/issues/2136/comments
https://api.github.com/repos/psf/requests/issues/2136/events
https://github.com/psf/requests/pull/2136
37,952,323
MDExOlB1bGxSZXF1ZXN0MTg0NTEzNDA=
2,136
Fix name misspelling
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-07-16T06:22:04Z
2021-09-08T23:01:01Z
2014-07-16T12:14:36Z
CONTRIBUTOR
resolved
See http://pydanny.com/
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2136/reactions" }
https://api.github.com/repos/psf/requests/issues/2136/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2136.diff", "html_url": "https://github.com/psf/requests/pull/2136", "merged_at": "2014-07-16T12:14:36Z", "patch_url": "https://github.com/psf/requests/pull/2136.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2136" }
true
[ "That's embarrassing. Thanks @dpursehouse !\n" ]
https://api.github.com/repos/psf/requests/issues/2135
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2135/labels{/name}
https://api.github.com/repos/psf/requests/issues/2135/comments
https://api.github.com/repos/psf/requests/issues/2135/events
https://github.com/psf/requests/pull/2135
37,942,951
MDExOlB1bGxSZXF1ZXN0MTg0NDYwMTc=
2,135
Docs: Fix :class: and :meth: directives
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-07-16T01:54:35Z
2021-09-08T23:01:04Z
2014-07-16T05:36:40Z
CONTRIBUTOR
resolved
A few instances of the directives were malformed and did not result in hyperlinks in the generated HTML. Change-Id: I94d93de928ee4ff24a48797baf2ac77598a20704
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2135/reactions" }
https://api.github.com/repos/psf/requests/issues/2135/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2135.diff", "html_url": "https://github.com/psf/requests/pull/2135", "merged_at": "2014-07-16T05:36:40Z", "patch_url": "https://github.com/psf/requests/pull/2135.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2135" }
true
[ ":cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2134
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2134/labels{/name}
https://api.github.com/repos/psf/requests/issues/2134/comments
https://api.github.com/repos/psf/requests/issues/2134/events
https://github.com/psf/requests/pull/2134
37,903,812
MDExOlB1bGxSZXF1ZXN0MTg0MjA1MjE=
2,134
removed unneeded parentheses from if clause
{ "avatar_url": "https://avatars.githubusercontent.com/u/66484?v=4", "events_url": "https://api.github.com/users/nonZero/events{/privacy}", "followers_url": "https://api.github.com/users/nonZero/followers", "following_url": "https://api.github.com/users/nonZero/following{/other_user}", "gists_url": "https://api.github.com/users/nonZero/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/nonZero", "id": 66484, "login": "nonZero", "node_id": "MDQ6VXNlcjY2NDg0", "organizations_url": "https://api.github.com/users/nonZero/orgs", "received_events_url": "https://api.github.com/users/nonZero/received_events", "repos_url": "https://api.github.com/users/nonZero/repos", "site_admin": false, "starred_url": "https://api.github.com/users/nonZero/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nonZero/subscriptions", "type": "User", "url": "https://api.github.com/users/nonZero", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-07-15T16:56:56Z
2021-09-08T23:01:05Z
2014-07-15T17:13:09Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2134/reactions" }
https://api.github.com/repos/psf/requests/issues/2134/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2134.diff", "html_url": "https://github.com/psf/requests/pull/2134", "merged_at": "2014-07-15T17:13:09Z", "patch_url": "https://github.com/psf/requests/pull/2134.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2134" }
true
[ "Thanks @nonZero !\n" ]
https://api.github.com/repos/psf/requests/issues/2133
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2133/labels{/name}
https://api.github.com/repos/psf/requests/issues/2133/comments
https://api.github.com/repos/psf/requests/issues/2133/events
https://github.com/psf/requests/pull/2133
37,903,012
MDExOlB1bGxSZXF1ZXN0MTg0MjAwMzM=
2,133
Update link to pip site on docs/user/install.rst
{ "avatar_url": "https://avatars.githubusercontent.com/u/1037088?v=4", "events_url": "https://api.github.com/users/esparta/events{/privacy}", "followers_url": "https://api.github.com/users/esparta/followers", "following_url": "https://api.github.com/users/esparta/following{/other_user}", "gists_url": "https://api.github.com/users/esparta/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/esparta", "id": 1037088, "login": "esparta", "node_id": "MDQ6VXNlcjEwMzcwODg=", "organizations_url": "https://api.github.com/users/esparta/orgs", "received_events_url": "https://api.github.com/users/esparta/received_events", "repos_url": "https://api.github.com/users/esparta/repos", "site_admin": false, "starred_url": "https://api.github.com/users/esparta/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/esparta/subscriptions", "type": "User", "url": "https://api.github.com/users/esparta", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2014-07-15T16:48:30Z
2021-09-08T23:01:06Z
2014-07-15T17:12:49Z
CONTRIBUTOR
resolved
The PIP is in https://pip.pypa.io now.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2133/reactions" }
https://api.github.com/repos/psf/requests/issues/2133/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2133.diff", "html_url": "https://github.com/psf/requests/pull/2133", "merged_at": "2014-07-15T17:12:49Z", "patch_url": "https://github.com/psf/requests/pull/2133.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2133" }
true
[ "Thanks @esparta !\n" ]
https://api.github.com/repos/psf/requests/issues/2132
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2132/labels{/name}
https://api.github.com/repos/psf/requests/issues/2132/comments
https://api.github.com/repos/psf/requests/issues/2132/events
https://github.com/psf/requests/issues/2132
37,882,516
MDU6SXNzdWUzNzg4MjUxNg==
2,132
Add a CI build for the documentation
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "fbca04", "default": false, "description": null...
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}...
null
0
2014-07-15T13:30:21Z
2021-09-08T01:21:15Z
2018-07-04T18:11:42Z
CONTRIBUTOR
resolved
There are builds for the various python version on ci.kennethreitz.org It would be useful to also have one for the documentation build.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2132/reactions" }
https://api.github.com/repos/psf/requests/issues/2132/timeline
null
completed
null
null
false
[]
https://api.github.com/repos/psf/requests/issues/2131
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2131/labels{/name}
https://api.github.com/repos/psf/requests/issues/2131/comments
https://api.github.com/repos/psf/requests/issues/2131/events
https://github.com/psf/requests/pull/2131
37,865,537
MDExOlB1bGxSZXF1ZXN0MTgzOTcxMjM=
2,131
Quickstart doc updates
{ "avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4", "events_url": "https://api.github.com/users/dpursehouse/events{/privacy}", "followers_url": "https://api.github.com/users/dpursehouse/followers", "following_url": "https://api.github.com/users/dpursehouse/following{/other_user}", "gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dpursehouse", "id": 836426, "login": "dpursehouse", "node_id": "MDQ6VXNlcjgzNjQyNg==", "organizations_url": "https://api.github.com/users/dpursehouse/orgs", "received_events_url": "https://api.github.com/users/dpursehouse/received_events", "repos_url": "https://api.github.com/users/dpursehouse/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions", "type": "User", "url": "https://api.github.com/users/dpursehouse", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2014-07-15T09:31:05Z
2021-09-08T23:01:04Z
2014-07-15T10:40:28Z
CONTRIBUTOR
resolved
- Add the Timeout exception in API doc so it gets hyperlinked properly from quickstart - Restructure the redirection and history section so it's a bit easier to read - Couple of other minor tidy-ups Note: the documentation build does not work on my machine, so I have not tested this fully.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2131/reactions" }
https://api.github.com/repos/psf/requests/issues/2131/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2131.diff", "html_url": "https://github.com/psf/requests/pull/2131", "merged_at": "2014-07-15T10:40:28Z", "patch_url": "https://github.com/psf/requests/pull/2131.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2131" }
true
[ "LGTM.\n\nWhile we're here, can we change the `history` section to stop referring to `Response.history` as a method? It's a property. =) Might be ok to leave the `:meth:` reStructuredText directive for it though.\n", "I actually changed it to `:meth:` from `:class:`.\n\nIs there a directive specially for properti...