url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/2130 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2130/labels{/name} | https://api.github.com/repos/psf/requests/issues/2130/comments | https://api.github.com/repos/psf/requests/issues/2130/events | https://github.com/psf/requests/pull/2130 | 37,863,010 | MDExOlB1bGxSZXF1ZXN0MTgzOTU1MzA= | 2,130 | Doc index updates | {
"avatar_url": "https://avatars.githubusercontent.com/u/836426?v=4",
"events_url": "https://api.github.com/users/dpursehouse/events{/privacy}",
"followers_url": "https://api.github.com/users/dpursehouse/followers",
"following_url": "https://api.github.com/users/dpursehouse/following{/other_user}",
"gists_url": "https://api.github.com/users/dpursehouse/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dpursehouse",
"id": 836426,
"login": "dpursehouse",
"node_id": "MDQ6VXNlcjgzNjQyNg==",
"organizations_url": "https://api.github.com/users/dpursehouse/orgs",
"received_events_url": "https://api.github.com/users/dpursehouse/received_events",
"repos_url": "https://api.github.com/users/dpursehouse/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dpursehouse/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dpursehouse/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dpursehouse",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-07-15T08:54:42Z | 2021-09-08T23:01:06Z | 2014-07-15T08:57:47Z | CONTRIBUTOR | resolved | - Wrap lines at around 80 characters in the doc index
- Add Sony to the list of users
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2130/reactions"
} | https://api.github.com/repos/psf/requests/issues/2130/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2130.diff",
"html_url": "https://github.com/psf/requests/pull/2130",
"merged_at": "2014-07-15T08:57:47Z",
"patch_url": "https://github.com/psf/requests/pull/2130.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2130"
} | true | [
"LGTM. Thanks! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2129 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2129/labels{/name} | https://api.github.com/repos/psf/requests/issues/2129/comments | https://api.github.com/repos/psf/requests/issues/2129/events | https://github.com/psf/requests/pull/2129 | 37,845,249 | MDExOlB1bGxSZXF1ZXN0MTgzODUyMzk= | 2,129 | Apply environment features to prepared requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/416057?v=4",
"events_url": "https://api.github.com/users/jamielennox/events{/privacy}",
"followers_url": "https://api.github.com/users/jamielennox/followers",
"following_url": "https://api.github.com/users/jamielennox/following{/other_user}",
"gists_url": "https://api.github.com/users/jamielennox/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jamielennox",
"id": 416057,
"login": "jamielennox",
"node_id": "MDQ6VXNlcjQxNjA1Nw==",
"organizations_url": "https://api.github.com/users/jamielennox/orgs",
"received_events_url": "https://api.github.com/users/jamielennox/received_events",
"repos_url": "https://api.github.com/users/jamielennox/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jamielennox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jamielennox/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jamielennox",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
},
{
"color": "fef2c0",
"default": false,
"d... | closed | true | null | [] | null | 21 | 2014-07-15T01:59:33Z | 2021-09-08T11:00:54Z | 2014-08-22T13:12:08Z | NONE | resolved | By having trust environment lookup in request() applications using
prepared requests don't get access to this functionality. Having this in
send() is a more logical place as we are dealing with default
communication parameters.
Closes #1436
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2129/reactions"
} | https://api.github.com/repos/psf/requests/issues/2129/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2129.diff",
"html_url": "https://github.com/psf/requests/pull/2129",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2129.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2129"
} | true | [
"Hi @jamielennox I haven't looked at this yet because the tests are failing. Please check the failures and fix them. Thank you\n",
"@sigmavirus24 fixed, thanks.\n",
"There are some nice changes in here. Looking forward to hearing what @sigmavirus24 and @Lukasa have to say :)\n",
"This seems in principle to be... |
https://api.github.com/repos/psf/requests/issues/2128 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2128/labels{/name} | https://api.github.com/repos/psf/requests/issues/2128/comments | https://api.github.com/repos/psf/requests/issues/2128/events | https://github.com/psf/requests/pull/2128 | 37,789,805 | MDExOlB1bGxSZXF1ZXN0MTgzNTAzODc= | 2,128 | Fix broken link | {
"avatar_url": "https://avatars.githubusercontent.com/u/588486?v=4",
"events_url": "https://api.github.com/users/tshepang/events{/privacy}",
"followers_url": "https://api.github.com/users/tshepang/followers",
"following_url": "https://api.github.com/users/tshepang/following{/other_user}",
"gists_url": "https://api.github.com/users/tshepang/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tshepang",
"id": 588486,
"login": "tshepang",
"node_id": "MDQ6VXNlcjU4ODQ4Ng==",
"organizations_url": "https://api.github.com/users/tshepang/orgs",
"received_events_url": "https://api.github.com/users/tshepang/received_events",
"repos_url": "https://api.github.com/users/tshepang/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tshepang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tshepang/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tshepang",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-07-14T14:13:35Z | 2021-09-08T23:01:07Z | 2014-07-14T14:39:19Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2128/reactions"
} | https://api.github.com/repos/psf/requests/issues/2128/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2128.diff",
"html_url": "https://github.com/psf/requests/pull/2128",
"merged_at": "2014-07-14T14:39:19Z",
"patch_url": "https://github.com/psf/requests/pull/2128.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2128"
} | true | [
"Thanks @tshepang !\n"
] | |
https://api.github.com/repos/psf/requests/issues/2127 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2127/labels{/name} | https://api.github.com/repos/psf/requests/issues/2127/comments | https://api.github.com/repos/psf/requests/issues/2127/events | https://github.com/psf/requests/issues/2127 | 37,733,422 | MDU6SXNzdWUzNzczMzQyMg== | 2,127 | verify=False,but still requests.exceptions.SSLError | {
"avatar_url": "https://avatars.githubusercontent.com/u/2603552?v=4",
"events_url": "https://api.github.com/users/khalidhsu/events{/privacy}",
"followers_url": "https://api.github.com/users/khalidhsu/followers",
"following_url": "https://api.github.com/users/khalidhsu/following{/other_user}",
"gists_url": "https://api.github.com/users/khalidhsu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/khalidhsu",
"id": 2603552,
"login": "khalidhsu",
"node_id": "MDQ6VXNlcjI2MDM1NTI=",
"organizations_url": "https://api.github.com/users/khalidhsu/orgs",
"received_events_url": "https://api.github.com/users/khalidhsu/received_events",
"repos_url": "https://api.github.com/users/khalidhsu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/khalidhsu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khalidhsu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/khalidhsu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-07-13T02:57:16Z | 2021-09-08T23:08:10Z | 2014-09-09T22:25:55Z | NONE | resolved | I have set the ssl verify=False, and I used a proxy(charles) with a Fake SSL cert,works fine with some website ,but some still raise SSLError,such as
https://pcs.baidu.com/rest/2.0/pcs/file?method=rapidupload&content-length=1643802624&content-md5=a655883b853e766e0cdf961bda894df9&slice-md5=fc7812dbdce256902d9277cef2c9b0da&path=/tmp2/a/ak.iso&app_id=250528&ondup=newcopy&filename=asas.iso
---
Traceback (most recent call last):
File "/home/khalid/py/py-mime/py20140710/baidupan.py", line 260, in <module>
main(sys.argv[1:])
File "/home/khalid/py/py-mime/py20140710/baidupan.py", line 238, in main
upload_rapid('/media/khalid/数据盘/迅雷下载/VS2012_ULT_chs.iso')
File "/home/khalid/py/py-mime/py20140710/baidupan.py", line 136, in upload_rapid
ls.get(url, proxies=proxies, verify=False)
File "/home/khalid/py/py-mime/py20140710/lsession3.py", line 73, in get
self._r = self._rqs.get(url, *_kw)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 395, in get
return self.request('GET', url, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, *_send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 385, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2127/reactions"
} | https://api.github.com/repos/psf/requests/issues/2127/timeline | null | completed | null | null | false | [
"Setting `verify=False` does not mean you will never get an `SSLError`, it just means we won't validate the certificate. In this case we tried to perform the TLS handshake and encountered an internal error. We can't ignore this kind of error, we have to raise it.\n",
"I am having a similar error. I am trying to r... |
https://api.github.com/repos/psf/requests/issues/2126 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2126/labels{/name} | https://api.github.com/repos/psf/requests/issues/2126/comments | https://api.github.com/repos/psf/requests/issues/2126/events | https://github.com/psf/requests/issues/2126 | 37,727,228 | MDU6SXNzdWUzNzcyNzIyOA== | 2,126 | SOCK4/5 Proxies | {
"avatar_url": "https://avatars.githubusercontent.com/u/2049730?v=4",
"events_url": "https://api.github.com/users/Segflow/events{/privacy}",
"followers_url": "https://api.github.com/users/Segflow/followers",
"following_url": "https://api.github.com/users/Segflow/following{/other_user}",
"gists_url": "https://api.github.com/users/Segflow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Segflow",
"id": 2049730,
"login": "Segflow",
"node_id": "MDQ6VXNlcjIwNDk3MzA=",
"organizations_url": "https://api.github.com/users/Segflow/orgs",
"received_events_url": "https://api.github.com/users/Segflow/received_events",
"repos_url": "https://api.github.com/users/Segflow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Segflow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Segflow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Segflow",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-07-12T19:46:47Z | 2021-09-08T23:10:49Z | 2014-07-12T19:50:47Z | NONE | resolved | Hello, is there any built-in sock4/5 support?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2126/reactions"
} | https://api.github.com/repos/psf/requests/issues/2126/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2125 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2125/labels{/name} | https://api.github.com/repos/psf/requests/issues/2125/comments | https://api.github.com/repos/psf/requests/issues/2125/events | https://github.com/psf/requests/issues/2125 | 37,725,349 | MDU6SXNzdWUzNzcyNTM0OQ== | 2,125 | SOCK4/5 Proxies | {
"avatar_url": "https://avatars.githubusercontent.com/u/2049730?v=4",
"events_url": "https://api.github.com/users/Segflow/events{/privacy}",
"followers_url": "https://api.github.com/users/Segflow/followers",
"following_url": "https://api.github.com/users/Segflow/following{/other_user}",
"gists_url": "https://api.github.com/users/Segflow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Segflow",
"id": 2049730,
"login": "Segflow",
"node_id": "MDQ6VXNlcjIwNDk3MzA=",
"organizations_url": "https://api.github.com/users/Segflow/orgs",
"received_events_url": "https://api.github.com/users/Segflow/received_events",
"repos_url": "https://api.github.com/users/Segflow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Segflow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Segflow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Segflow",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-07-12T18:24:32Z | 2021-09-08T23:10:50Z | 2014-07-12T18:30:15Z | NONE | resolved | Hello, is there any built-in support for socks4 and socks5 proxies?
i'am running a tor process at port 7575 and i would like to use it in fetching data.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2125/reactions"
} | https://api.github.com/repos/psf/requests/issues/2125/timeline | null | completed | null | null | false | [
"Currently no. We need to work on getting shazow/urllib3#284 up to scratch and merged to get that support. \n",
"Also if you have questions, the proper place to ask them is on [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests). Also, had you performed a search you would have found your an... |
https://api.github.com/repos/psf/requests/issues/2124 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2124/labels{/name} | https://api.github.com/repos/psf/requests/issues/2124/comments | https://api.github.com/repos/psf/requests/issues/2124/events | https://github.com/psf/requests/pull/2124 | 37,603,833 | MDExOlB1bGxSZXF1ZXN0MTgyNDU1OTg= | 2,124 | Depend on certifi | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-07-10T20:51:52Z | 2021-09-08T10:01:20Z | 2014-07-11T17:30:07Z | MEMBER | resolved | Resolves #2123.
This represents one possible approach to certifi: always take it if it's present. This is probably not the most secure approach, however. If we wanted to be more intelligent we could embed the version number of certifi that requests contains and use the most up-to-date version. If you're interested in doing that let me know and I'll add it as an enhancement.
Note also that this adds certifi as a hard dependency. I'd be equally happy to not install it in the install process but take it if it's there.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2124/reactions"
} | https://api.github.com/repos/psf/requests/issues/2124/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2124.diff",
"html_url": "https://github.com/psf/requests/pull/2124",
"merged_at": "2014-07-11T17:30:07Z",
"patch_url": "https://github.com/psf/requests/pull/2124.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2124"
} | true | [
"Lets do it!\n\n:sparkles:\n",
"I don't think making certifi a hard-dependency is a good idea. There are reasons to prefer the distribution-wide ca-bundle.\n",
"Sure there are, but that's orthogonal to certifi being a dependency. All we've done is change our logic from preferring our own bundled certs to certif... |
https://api.github.com/repos/psf/requests/issues/2123 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2123/labels{/name} | https://api.github.com/repos/psf/requests/issues/2123/comments | https://api.github.com/repos/psf/requests/issues/2123/events | https://github.com/psf/requests/issues/2123 | 37,600,291 | MDU6SXNzdWUzNzYwMDI5MQ== | 2,123 | Consider soft-depending on certifi package | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-07-10T20:12:40Z | 2021-09-08T23:10:50Z | 2014-07-11T17:30:07Z | CONTRIBUTOR | resolved | Install it during installation, but still have a packaged version to fall back on.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2123/reactions"
} | https://api.github.com/repos/psf/requests/issues/2123/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2122 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2122/labels{/name} | https://api.github.com/repos/psf/requests/issues/2122/comments | https://api.github.com/repos/psf/requests/issues/2122/events | https://github.com/psf/requests/issues/2122 | 37,447,446 | MDU6SXNzdWUzNzQ0NzQ0Ng== | 2,122 | Response encoding detect | {
"avatar_url": "https://avatars.githubusercontent.com/u/2986070?v=4",
"events_url": "https://api.github.com/users/fengsp/events{/privacy}",
"followers_url": "https://api.github.com/users/fengsp/followers",
"following_url": "https://api.github.com/users/fengsp/following{/other_user}",
"gists_url": "https://api.github.com/users/fengsp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fengsp",
"id": 2986070,
"login": "fengsp",
"node_id": "MDQ6VXNlcjI5ODYwNzA=",
"organizations_url": "https://api.github.com/users/fengsp/orgs",
"received_events_url": "https://api.github.com/users/fengsp/received_events",
"repos_url": "https://api.github.com/users/fengsp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fengsp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fengsp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fengsp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-07-09T09:27:39Z | 2021-09-08T23:10:51Z | 2014-07-09T09:34:49Z | NONE | resolved | Take one link for example: http://baike.baidu.com/view/115789.htm
This HTTP response has header `Content-Type:text/html`, no encoding, however, the
returned html content has `<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />`, actually using requests, I got encoding `'ISO-8859-1'`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2122/reactions"
} | https://api.github.com/repos/psf/requests/issues/2122/timeline | null | completed | null | null | false | [
"Thanks for this issue!\n\nThis is a well known requests behaviour that is very clearly documented. You can see the documentation section [here](http://docs.python-requests.org/en/latest/user/advanced/#encodings). It has been raised in prior issues as well: #1604 and #2042 for some of the most recent discussions of... |
https://api.github.com/repos/psf/requests/issues/2121 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2121/labels{/name} | https://api.github.com/repos/psf/requests/issues/2121/comments | https://api.github.com/repos/psf/requests/issues/2121/events | https://github.com/psf/requests/issues/2121 | 37,331,171 | MDU6SXNzdWUzNzMzMTE3MQ== | 2,121 | python-requests does not support rfc6874 URLs with link-local addresses and zone identifiers | {
"avatar_url": "https://avatars.githubusercontent.com/u/151255?v=4",
"events_url": "https://api.github.com/users/sagarun/events{/privacy}",
"followers_url": "https://api.github.com/users/sagarun/followers",
"following_url": "https://api.github.com/users/sagarun/following{/other_user}",
"gists_url": "https://api.github.com/users/sagarun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sagarun",
"id": 151255,
"login": "sagarun",
"node_id": "MDQ6VXNlcjE1MTI1NQ==",
"organizations_url": "https://api.github.com/users/sagarun/orgs",
"received_events_url": "https://api.github.com/users/sagarun/received_events",
"repos_url": "https://api.github.com/users/sagarun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sagarun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sagarun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sagarun",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-07-08T03:45:27Z | 2021-09-08T23:10:51Z | 2014-07-08T05:45:55Z | NONE | resolved | Description of problem:
Version-Release number of selected component (if applicable):
How reproducible:
always
Steps to Reproduce:
1.ip addr add fe80::1 dev p14p14
2. nc -6 -l 1234
3. python -c "import requests; requests.get('http://[fe80::1%25p14p1]:1234')"
3. nc -v6 'fe80::1%p14p1' 1234
Ncat: Version 6.40 ( http://nmap.org/ncat )
Ncat: Connected to fe80::1:1234.
Actual results:
The python script shows a traceback:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, *_kwargs)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, *_kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 335, in request
resp = self.send(prep, *_send_kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 438, in send
r = adapter.send(request, *_kwargs)
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 327, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='fe80::1%25p14p1', port=1234): Max retries exceeded with url: / (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)
Expected results:
python requests should connect to netcat.
Additional info:
https://tools.ietf.org/html/rfc6874
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2121/reactions"
} | https://api.github.com/repos/psf/requests/issues/2121/timeline | null | completed | null | null | false | [
"Please see https://bugzilla.redhat.com/show_bug.cgi?id=1076822 for more information\n",
"This is a duplicate of #1985. I'm going to close this to centralise discussion there.\n"
] |
https://api.github.com/repos/psf/requests/issues/2120 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2120/labels{/name} | https://api.github.com/repos/psf/requests/issues/2120/comments | https://api.github.com/repos/psf/requests/issues/2120/events | https://github.com/psf/requests/issues/2120 | 37,179,438 | MDU6SXNzdWUzNzE3OTQzOA== | 2,120 | Unexpected keyword argument in packages/urllib3/connectionpool.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/8069918?v=4",
"events_url": "https://api.github.com/users/jmandreoli/events{/privacy}",
"followers_url": "https://api.github.com/users/jmandreoli/followers",
"following_url": "https://api.github.com/users/jmandreoli/following{/other_user}",
"gists_url": "https://api.github.com/users/jmandreoli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jmandreoli",
"id": 8069918,
"login": "jmandreoli",
"node_id": "MDQ6VXNlcjgwNjk5MTg=",
"organizations_url": "https://api.github.com/users/jmandreoli/orgs",
"received_events_url": "https://api.github.com/users/jmandreoli/received_events",
"repos_url": "https://api.github.com/users/jmandreoli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jmandreoli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jmandreoli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jmandreoli",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-07-04T16:59:50Z | 2021-09-08T06:00:38Z | 2014-07-07T10:50:36Z | NONE | resolved | This is what I get during a requests session under python 3.3:
Traceback (most recent call last):
File "/.../python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 319, in _make_request
httplib_response = conn.getresponse(buffering=True)
TypeError: getresponse() got an unexpected keyword argument 'buffering'
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2120/reactions"
} | https://api.github.com/repos/psf/requests/issues/2120/timeline | null | completed | null | null | false | [
"@jmandreoli I'm certain that is not the entire of your traceback and it is likely related to #1915 and #1289. Your issue is not that, because we were handling that exception when a different one occurred (with certainty). You need to give us the version of requests and what the _entire_ traceback is.\n",
"On 04/... |
https://api.github.com/repos/psf/requests/issues/2119 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2119/labels{/name} | https://api.github.com/repos/psf/requests/issues/2119/comments | https://api.github.com/repos/psf/requests/issues/2119/events | https://github.com/psf/requests/issues/2119 | 37,134,319 | MDU6SXNzdWUzNzEzNDMxOQ== | 2,119 | Get parameters are being double encoded | {
"avatar_url": "https://avatars.githubusercontent.com/u/4297003?v=4",
"events_url": "https://api.github.com/users/einchance/events{/privacy}",
"followers_url": "https://api.github.com/users/einchance/followers",
"following_url": "https://api.github.com/users/einchance/following{/other_user}",
"gists_url": "https://api.github.com/users/einchance/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/einchance",
"id": 4297003,
"login": "einchance",
"node_id": "MDQ6VXNlcjQyOTcwMDM=",
"organizations_url": "https://api.github.com/users/einchance/orgs",
"received_events_url": "https://api.github.com/users/einchance/received_events",
"repos_url": "https://api.github.com/users/einchance/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/einchance/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/einchance/subscriptions",
"type": "User",
"url": "https://api.github.com/users/einchance",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-07-04T00:23:40Z | 2021-09-08T23:10:50Z | 2014-07-11T04:30:36Z | NONE | resolved | parameters are being double encoded. I have the following code:
url = 'http://example.com'
queryParameters = {"MenuRequest": '{"language":"en-us","storeName":"R10501","datetime":"00:00:00","tenant":"store1"}'}
and I pass it in like such:
response = requests.get(url, params = queryParameters, verify=False)
the result is this:
http://example.com/?MenuRequest=%257B%2522language%2522%253A%2522en-us%2522%252C%2522storeName%2522%253A%2522R10501%2522%252C%2522datetime%2522%253A%252200%253A00%253A00%2522%252C%2522tenant%2522%253A%2522store1%2522%257D
it should be this:
http://example.com/?MenuRequest=%7B%22language%22%3A%22en-us%22%2C%22storeName%22%3A%22R10501%22%2C%22datetime%22%3A%2200%3A00%3A00%22%2C%22tenant%22%3A%22store1%22%7D
The problem is that that the parameters are being double encoded.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/2119/reactions"
} | https://api.github.com/repos/psf/requests/issues/2119/timeline | null | completed | null | null | false | [
"``` pycon\n~ python\nPython 2.7.7 (default, Jun 2 2014, 18:55:26)\n[GCC 4.2.1 Compatible Apple LLVM 5.1 (clang-503.0.40)] on darwin\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n>>> queryParameters = {\"MenuRequest\": '{\"language\":\"en-us\",\"storeName\":\"R10501\",\"datetime\... |
https://api.github.com/repos/psf/requests/issues/2118 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2118/labels{/name} | https://api.github.com/repos/psf/requests/issues/2118/comments | https://api.github.com/repos/psf/requests/issues/2118/events | https://github.com/psf/requests/issues/2118 | 36,996,814 | MDU6SXNzdWUzNjk5NjgxNA== | 2,118 | Let the user provide an SSLContext object | {
"avatar_url": "https://avatars.githubusercontent.com/u/166162?v=4",
"events_url": "https://api.github.com/users/brandon-rhodes/events{/privacy}",
"followers_url": "https://api.github.com/users/brandon-rhodes/followers",
"following_url": "https://api.github.com/users/brandon-rhodes/following{/other_user}",
"gists_url": "https://api.github.com/users/brandon-rhodes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brandon-rhodes",
"id": 166162,
"login": "brandon-rhodes",
"node_id": "MDQ6VXNlcjE2NjE2Mg==",
"organizations_url": "https://api.github.com/users/brandon-rhodes/orgs",
"received_events_url": "https://api.github.com/users/brandon-rhodes/received_events",
"repos_url": "https://api.github.com/users/brandon-rhodes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brandon-rhodes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brandon-rhodes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brandon-rhodes",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 31 | 2014-07-02T16:02:03Z | 2021-09-08T13:05:29Z | 2017-01-13T07:22:06Z | NONE | resolved | The requests library seems to grow more and more keyword arguments to try to provide all of the flexibility that SSL users need. As of Python 3.2, the Standard Library now offers a different approach: an `SSLContext` that can accept settings for TLS protocol version, CA certificate list, identity certificate, secret key, allowable cipher list, Diffie-Hellman parameters, server-name callback function, whether to verify server hostnames, and so forth. It has a `wrap_socket()` method that starts up TLS on a socket using precisely the settings it has been configured with.
This lets protocol libraries in the Python 3 Standard Library opt out of needing keyword arguments for any of the above settings. They can simply accept a `context=` keyword argument, use the context to wrap their encrypted sockets, and stay out of the business of understanding SSL and all of its different settings.
If the requests library under Python 3 started supporting a `context=` parameter like the Standard Library protocols, then users could fine-tune their encryption settings without requests having to become more complicated.
A use-case: many users today are concerned about Perfect Forward Security (PFS) and want to only make connections with ciphers that at least make it possible to build connections that cannot be decrypted later if a secret key is captured. But the current requests library, so far as I can see, makes no provision for this. Nor do I want it to: adding a new `ciphers=` keyword would be only the first of a dozen other keywords that SSL users will need added over the coming years. But if requests accepted a `context=` parameter, then I can create an `SSLContext` and tell it which protocols I am willing to use and have requests (and urllib3) use that context for building their SSL connections.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 5,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 5,
"url": "https://api.github.com/repos/psf/requests/issues/2118/reactions"
} | https://api.github.com/repos/psf/requests/issues/2118/timeline | null | completed | null | null | false | [
"> The requests library seems to grow more and more keyword arguments to try to provide all of the flexibility that SSL users need.\n\nI'm not sure if you mean the fundamental `get/post/put/delete/head/options/request` methods/functions, but if that is what you're referring to, those haven't changed since before 1.... |
https://api.github.com/repos/psf/requests/issues/2117 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2117/labels{/name} | https://api.github.com/repos/psf/requests/issues/2117/comments | https://api.github.com/repos/psf/requests/issues/2117/events | https://github.com/psf/requests/issues/2117 | 36,995,922 | MDU6SXNzdWUzNjk5NTkyMg== | 2,117 | Multipart files unicode filename | {
"avatar_url": "https://avatars.githubusercontent.com/u/128982?v=4",
"events_url": "https://api.github.com/users/homm/events{/privacy}",
"followers_url": "https://api.github.com/users/homm/followers",
"following_url": "https://api.github.com/users/homm/following{/other_user}",
"gists_url": "https://api.github.com/users/homm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/homm",
"id": 128982,
"login": "homm",
"node_id": "MDQ6VXNlcjEyODk4Mg==",
"organizations_url": "https://api.github.com/users/homm/orgs",
"received_events_url": "https://api.github.com/users/homm/received_events",
"repos_url": "https://api.github.com/users/homm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/homm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/homm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/homm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 32 | 2014-07-02T15:53:05Z | 2014-09-10T18:37:56Z | 2014-07-02T20:34:47Z | CONTRIBUTOR | null | Starting from 2.0 requests does not send `filename` attribute of `Content-Disposition` header for multipart files with unicode names. Instead of this attribute with name `filename*` is sent.
```
# requests 1.2.3
>>> requests.post('http://ya.ru', files={'file': (u'файл', '123')}).request.body
'--db7a9522a6344e26a4ca2933aecad887\r\nContent-Disposition: form-data; name="file"; filename="\xd1\x84\xd0\xb0\xd0\xb9\xd0\xbb"\r\nContent-Type: application/octet-stream\r\n\r\n123\r\n--db7a9522a6344e26a4ca2933aecad887--\r\n'
# requests 2.0
>>> requests.post('http://ya.ru', files={'file': (u'файл', '123')}).request.body
'--a9f0de2871da46df86140bc5b72fc722\r\nContent-Disposition: form-data; name="file"; filename*=utf-8\'\'%D1%84%D0%B0%D0%B9%D0%BB\r\n\r\n123\r\n--a9f0de2871da46df86140bc5b72fc722--\r\n'
```
And this is a big problem, because looks like some systems does not recognize such fields as files. At least we encountered a problem with Django. Django places entire file's content in `request.POST` instead of `request.FILES`. It is clear from sources:
https://github.com/django/django/blob/1.7c1/django/http/multipartparser.py#L599-L601
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2117/reactions"
} | https://api.github.com/repos/psf/requests/issues/2117/timeline | null | completed | null | null | false | [
"This is actually a bug in Django then. Using this syntax is what we're supposed to be using. We have to indicate to the server that we're sending a field whose content is not ASCII or Latin-1 (ISO-8859-1). The proper way to do so is the syntax you see there. It is defined in [Section 3.2.1 of RFC 5987](http://tool... |
https://api.github.com/repos/psf/requests/issues/2116 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2116/labels{/name} | https://api.github.com/repos/psf/requests/issues/2116/comments | https://api.github.com/repos/psf/requests/issues/2116/events | https://github.com/psf/requests/pull/2116 | 36,994,624 | MDExOlB1bGxSZXF1ZXN0MTc4OTM3MDc= | 2,116 | Replace dead link with StackOverflow answer | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 1 | 2014-07-02T15:39:46Z | 2021-09-08T23:05:22Z | 2014-07-02T15:41:14Z | CONTRIBUTOR | resolved | Fix #2107
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2116/reactions"
} | https://api.github.com/repos/psf/requests/issues/2116/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2116.diff",
"html_url": "https://github.com/psf/requests/pull/2116",
"merged_at": "2014-07-02T15:41:14Z",
"patch_url": "https://github.com/psf/requests/pull/2116.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2116"
} | true | [
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2115 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2115/labels{/name} | https://api.github.com/repos/psf/requests/issues/2115/comments | https://api.github.com/repos/psf/requests/issues/2115/events | https://github.com/psf/requests/pull/2115 | 36,993,298 | MDExOlB1bGxSZXF1ZXN0MTc4OTI4MzE= | 2,115 | Update how we check verify when inspecting env variables | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 6 | 2014-07-02T15:26:36Z | 2021-09-08T23:05:18Z | 2014-07-03T13:35:55Z | CONTRIBUTOR | resolved | Closes #2092
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2115/reactions"
} | https://api.github.com/repos/psf/requests/issues/2115/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2115.diff",
"html_url": "https://github.com/psf/requests/pull/2115",
"merged_at": "2014-07-03T13:35:55Z",
"patch_url": "https://github.com/psf/requests/pull/2115.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2115"
} | true | [
"Assigned to @Lukasa for review\n",
"Notes inline. =)\n",
"LGTM. :star: :cake:\n",
"We should do `if verify`, not `if verify is True`.\n",
"@kennethreitz Disagree: verify may be set to a string (path to the cert bundle) and we shouldn't overwrite it.\n",
"Ah, gotcha. Good catch :)\n"
] |
https://api.github.com/repos/psf/requests/issues/2114 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2114/labels{/name} | https://api.github.com/repos/psf/requests/issues/2114/comments | https://api.github.com/repos/psf/requests/issues/2114/events | https://github.com/psf/requests/pull/2114 | 36,926,170 | MDExOlB1bGxSZXF1ZXN0MTc4NTEzOTU= | 2,114 | Update sessions.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/2058626?v=4",
"events_url": "https://api.github.com/users/manizzle/events{/privacy}",
"followers_url": "https://api.github.com/users/manizzle/followers",
"following_url": "https://api.github.com/users/manizzle/following{/other_user}",
"gists_url": "https://api.github.com/users/manizzle/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/manizzle",
"id": 2058626,
"login": "manizzle",
"node_id": "MDQ6VXNlcjIwNTg2MjY=",
"organizations_url": "https://api.github.com/users/manizzle/orgs",
"received_events_url": "https://api.github.com/users/manizzle/received_events",
"repos_url": "https://api.github.com/users/manizzle/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/manizzle/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/manizzle/subscriptions",
"type": "User",
"url": "https://api.github.com/users/manizzle",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-07-01T19:54:49Z | 2021-09-08T23:05:24Z | 2014-07-01T19:56:29Z | NONE | resolved | allow Session to set a timeout for requests
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2114/reactions"
} | https://api.github.com/repos/psf/requests/issues/2114/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2114.diff",
"html_url": "https://github.com/psf/requests/pull/2114",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2114.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2114"
} | true | [
"Thanks for this!\n\nUnfortunately, this is a feature request that comes up often but that we don't have any real interest in. See #2011 for a longer form justification. For this reason, I'm afraid that we can't accept this pull request. Thanks so much for the work though, and please do keep contributing! :cake:\n"... |
https://api.github.com/repos/psf/requests/issues/2113 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2113/labels{/name} | https://api.github.com/repos/psf/requests/issues/2113/comments | https://api.github.com/repos/psf/requests/issues/2113/events | https://github.com/psf/requests/issues/2113 | 36,921,130 | MDU6SXNzdWUzNjkyMTEzMA== | 2,113 | TypeError with pyOpenSSL, unicode headers, and python 2.x | {
"avatar_url": "https://avatars.githubusercontent.com/u/39916?v=4",
"events_url": "https://api.github.com/users/joeshaw/events{/privacy}",
"followers_url": "https://api.github.com/users/joeshaw/followers",
"following_url": "https://api.github.com/users/joeshaw/following{/other_user}",
"gists_url": "https://api.github.com/users/joeshaw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joeshaw",
"id": 39916,
"login": "joeshaw",
"node_id": "MDQ6VXNlcjM5OTE2",
"organizations_url": "https://api.github.com/users/joeshaw/orgs",
"received_events_url": "https://api.github.com/users/joeshaw/received_events",
"repos_url": "https://api.github.com/users/joeshaw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joeshaw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joeshaw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joeshaw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-07-01T18:51:54Z | 2021-09-08T23:10:53Z | 2014-07-01T19:25:27Z | NONE | resolved | ```
>>> requests.get("https://google.com", headers={"X-Foo": u"foo"})
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/sessions.py", line 456, in request
resp = self.send(prep, **send_kwargs)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/sessions.py", line 559, in send
r = adapter.send(request, **kwargs)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/adapters.py", line 327, in send
timeout=timeout
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/packages/urllib3/connectionpool.py", line 493, in urlopen
body=body, headers=headers)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/packages/urllib3/connectionpool.py", line 291, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib/python2.6/httplib.py", line 910, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.6/httplib.py", line 947, in _send_request
self.endheaders()
File "/usr/lib/python2.6/httplib.py", line 904, in endheaders
self._send_output()
File "/usr/lib/python2.6/httplib.py", line 776, in _send_output
self.send(msg)
File "/usr/lib/python2.6/httplib.py", line 755, in send
self.sock.sendall(str)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 353, in sendall
return self.connection.sendall(data)
File "/home/buildbot/joe-wip/virtualenv/lib/python2.6/site-packages/OpenSSL/SSL.py", line 969, in sendall
raise TypeError("buf must be a byte string")
TypeError: buf must be a byte string
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2113/reactions"
} | https://api.github.com/repos/psf/requests/issues/2113/timeline | null | completed | null | null | false | [
"By comparison, both `requests.get(\"http://google.com\", headers={\"X-Foo\": u\"foo\"})` and `requests.get(\"https://google.com\", headers={\"X-Foo\": \"foo\"})` work.\n",
"We don't expect you to set unicode headers on Python 2. It's generally a bad idea anyway because the text encoding to use is really unclear:... |
https://api.github.com/repos/psf/requests/issues/2112 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2112/labels{/name} | https://api.github.com/repos/psf/requests/issues/2112/comments | https://api.github.com/repos/psf/requests/issues/2112/events | https://github.com/psf/requests/pull/2112 | 36,745,605 | MDExOlB1bGxSZXF1ZXN0MTc3NDY4NjY= | 2,112 | Update quickstart.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/7949405?v=4",
"events_url": "https://api.github.com/users/np-csu/events{/privacy}",
"followers_url": "https://api.github.com/users/np-csu/followers",
"following_url": "https://api.github.com/users/np-csu/following{/other_user}",
"gists_url": "https://api.github.com/users/np-csu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/np-csu",
"id": 7949405,
"login": "np-csu",
"node_id": "MDQ6VXNlcjc5NDk0MDU=",
"organizations_url": "https://api.github.com/users/np-csu/orgs",
"received_events_url": "https://api.github.com/users/np-csu/received_events",
"repos_url": "https://api.github.com/users/np-csu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/np-csu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/np-csu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/np-csu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-06-29T13:08:07Z | 2021-09-08T23:06:05Z | 2014-06-29T13:31:23Z | CONTRIBUTOR | resolved | line 394: correct an input error.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2112/reactions"
} | https://api.github.com/repos/psf/requests/issues/2112/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2112.diff",
"html_url": "https://github.com/psf/requests/pull/2112",
"merged_at": "2014-06-29T13:31:23Z",
"patch_url": "https://github.com/psf/requests/pull/2112.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2112"
} | true | [
"Looks good to me! Thanks! :cake: \n"
] |
https://api.github.com/repos/psf/requests/issues/2111 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2111/labels{/name} | https://api.github.com/repos/psf/requests/issues/2111/comments | https://api.github.com/repos/psf/requests/issues/2111/events | https://github.com/psf/requests/issues/2111 | 36,588,596 | MDU6SXNzdWUzNjU4ODU5Ng== | 2,111 | Unhelpful Error for large timeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/1186124?v=4",
"events_url": "https://api.github.com/users/saulshanabrook/events{/privacy}",
"followers_url": "https://api.github.com/users/saulshanabrook/followers",
"following_url": "https://api.github.com/users/saulshanabrook/following{/other_user}",
"gists_url": "https://api.github.com/users/saulshanabrook/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/saulshanabrook",
"id": 1186124,
"login": "saulshanabrook",
"node_id": "MDQ6VXNlcjExODYxMjQ=",
"organizations_url": "https://api.github.com/users/saulshanabrook/orgs",
"received_events_url": "https://api.github.com/users/saulshanabrook/received_events",
"repos_url": "https://api.github.com/users/saulshanabrook/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/saulshanabrook/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/saulshanabrook/subscriptions",
"type": "User",
"url": "https://api.github.com/users/saulshanabrook",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | closed | true | null | [] | null | 8 | 2014-06-26T15:47:17Z | 2021-09-08T23:10:53Z | 2014-06-26T18:41:01Z | NONE | resolved | Requests should give a better error than `requests.exceptions.ConnectionError: HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /get (Caused by <class 'OSError'>: [Errno 22] Invalid argument)` for inputting a timeout that is too large. Right now it doesn't specify that timeout caused the error, even though it does mention that there is an `Invalid argument` somewhere...
``` python
import requests
r = requests.get('http://httpbin.org/get', timeout=99**99)
```
```
Traceback (most recent call last):
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 493, in urlopen
body=body, headers=headers)
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 291, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1066, in request
self._send_request(method, url, body, headers)
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1104, in _send_request
self.endheaders(body)
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 1062, in endheaders
self._send_output(message_body)
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 907, in _send_output
self.send(msg)
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/http/client.py", line 842, in send
self.connect()
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 106, in connect
conn = self._new_conn()
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/packages/urllib3/connection.py", line 90, in _new_conn
(self.host, self.port), self.timeout, *extra_args)
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/socket.py", line 509, in create_connection
raise err
File "/usr/local/Cellar/python3/3.4.0/Frameworks/Python.framework/Versions/3.4/lib/python3.4/socket.py", line 500, in create_connection
sock.connect(sa)
OSError: [Errno 22] Invalid argument
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/adapters.py", line 327, in send
timeout=timeout
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 543, in urlopen
raise MaxRetryError(self, url, e)
requests.packages.urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /get (Caused by <class 'OSError'>: [Errno 22] Invalid argument)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "test_error.py", line 4, in <module>
r = requests.get('http://httpbin.org/get', timeout=99**99)
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/sessions.py", line 456, in request
resp = self.send(prep, **send_kwargs)
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/sessions.py", line 559, in send
r = adapter.send(request, **kwargs)
File "/Users/saul/.virtualenvs/finance-scraper3/lib/python3.4/site-packages/requests/adapters.py", line 375, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='httpbin.org', port=80): Max retries exceeded with url: /get (Caused by <class 'OSError'>: [Errno 22] Invalid argument)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1186124?v=4",
"events_url": "https://api.github.com/users/saulshanabrook/events{/privacy}",
"followers_url": "https://api.github.com/users/saulshanabrook/followers",
"following_url": "https://api.github.com/users/saulshanabrook/following{/other_user}",
"gists_url": "https://api.github.com/users/saulshanabrook/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/saulshanabrook",
"id": 1186124,
"login": "saulshanabrook",
"node_id": "MDQ6VXNlcjExODYxMjQ=",
"organizations_url": "https://api.github.com/users/saulshanabrook/orgs",
"received_events_url": "https://api.github.com/users/saulshanabrook/received_events",
"repos_url": "https://api.github.com/users/saulshanabrook/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/saulshanabrook/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/saulshanabrook/subscriptions",
"type": "User",
"url": "https://api.github.com/users/saulshanabrook",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2111/reactions"
} | https://api.github.com/repos/psf/requests/issues/2111/timeline | null | completed | null | null | false | [
"Here's the thing, we don't ever see that `OSError` ourselves. It isn't that we're choosing to raise an unhelpful error, we're raising the error we should be handling. If the socket raises an error, urllib3 catches that and raises a different error (as it should) which we then catch and then use to raise `Connectio... |
https://api.github.com/repos/psf/requests/issues/2110 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2110/labels{/name} | https://api.github.com/repos/psf/requests/issues/2110/comments | https://api.github.com/repos/psf/requests/issues/2110/events | https://github.com/psf/requests/issues/2110 | 36,403,819 | MDU6SXNzdWUzNjQwMzgxOQ== | 2,110 | Requests stops respecting configured proxies | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2014-06-24T16:58:32Z | 2021-06-30T23:43:06Z | 2014-06-24T17:30:24Z | CONTRIBUTOR | resolved | There is an open bug report on pip (pypa/pip#1805) after some back and forth this appears to be a legit requests (or maybe urllib3) bug.
Using requests 2.3.0 I had one of the people run a script like this:
``` python
import requests
session = requests.Session()
for i in range(100):
print(i)
session.get("https://pypi.python.org/simple/").content
```
They said they had both `http_proxy` and `https_proxy` environment variables set up, and when they ran it they got this output: https://dpaste.de/doVg/raw
On the pip ticket people have said they got this while configuring the proxy via `--proxy` which translates to ``session.proxies ={"https": "<value>", "http": "<value>"}.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2110/reactions"
} | https://api.github.com/repos/psf/requests/issues/2110/timeline | null | completed | null | null | false | [
"I wonder if this has anything to do with Connection Pooling. @shazow?\n",
"In fact, the weird increments this is happening at suggest it. Your ticket has it happening at ~16, this one is coming at 51. Very suspicious.\n",
"That said, we use a pool size of 10 by default, which isn't really close to either of th... |
https://api.github.com/repos/psf/requests/issues/2109 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2109/labels{/name} | https://api.github.com/repos/psf/requests/issues/2109/comments | https://api.github.com/repos/psf/requests/issues/2109/events | https://github.com/psf/requests/issues/2109 | 36,326,374 | MDU6SXNzdWUzNjMyNjM3NA== | 2,109 | [idea] Change how we merge request and session settings | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "eb6420",
"default": false,
"description": null,
"id": 44501256,
"name": "Breaking API Change",
"node_id": "MDU6TGFiZWw0NDUwMTI1Ng==",
"url": "https://api.github.com/repos/psf/requests/labels/Breaking%20API%20Change"
}
] | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 0 | 2014-06-23T20:09:09Z | 2014-10-05T17:15:42Z | null | CONTRIBUTOR | null | # Problem
Currently, tools (e.g., [openstack/python-swiftclient](https://github.com/openstack/python-swiftclient/blob/3d0de79e26e2aa6285742c60aca3c164e9c2fbb9/swiftclient/client.py#L942..L945)) fight how requests sets the `Content-Type` header for a request. Notice that if the user of swiftclient doesn't provide their own `content_type` then the library sets the header's value to `''`. Ideally, setting `None` in a situation like this (where the Session has no default `Content-Type`) would prevent the request preparation from setting its own `Content-Type` header. This doesn't work because the per-session and per-request settings are [merged at the session level](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L361).
# Potential solutions
## Split the responsibility of merging settings
The merge at the session level could just take care of ensuring that the per-request settings have priority while waiting for the request preparation to remove `None`s. The downside of this behaviour is that it breaks backwards compatibility. Why? Consider the following:
``` python
import requests
s = requests.Session()
s.headers['Content-Type'] = 'application/json'
s.post(url, data={'some': 'formdata'}, headers={'Content-Type': None})
```
This allows for requests to detect that it is in fact `application/x-www-form-urlencoded` by removing the default set by the session. Keeping backwards compatibility would mean that we would have to do extra work while merging settings on the session-level. We would have to check if the header was set on the session level, and then we would delete headers with value `None`, otherwise, persist the `None` value. This is clearly a lot of extra logic.
## Create a constant/singleton to mean "Do not autogenerate any of this for me"
We could potentially expose a new constant or singleton in requests to allow users to specify when they want to prevent requests from handling it for them. I dislike this idea a lot, but it's potentially easier to implement and a bit more explicit than overloading the already overloaded meaning of `None` in this context.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2109/reactions"
} | https://api.github.com/repos/psf/requests/issues/2109/timeline | null | null | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2108 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2108/labels{/name} | https://api.github.com/repos/psf/requests/issues/2108/comments | https://api.github.com/repos/psf/requests/issues/2108/events | https://github.com/psf/requests/issues/2108 | 36,270,981 | MDU6SXNzdWUzNjI3MDk4MQ== | 2,108 | gevent ssl and WantWrite error | {
"avatar_url": "https://avatars.githubusercontent.com/u/489439?v=4",
"events_url": "https://api.github.com/users/vitek/events{/privacy}",
"followers_url": "https://api.github.com/users/vitek/followers",
"following_url": "https://api.github.com/users/vitek/following{/other_user}",
"gists_url": "https://api.github.com/users/vitek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vitek",
"id": 489439,
"login": "vitek",
"node_id": "MDQ6VXNlcjQ4OTQzOQ==",
"organizations_url": "https://api.github.com/users/vitek/orgs",
"received_events_url": "https://api.github.com/users/vitek/received_events",
"repos_url": "https://api.github.com/users/vitek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vitek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vitek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vitek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-06-23T08:29:40Z | 2021-09-08T23:10:54Z | 2014-06-23T09:34:55Z | NONE | resolved | Hi!
Using `gevent` with `pyOpenSSL 0.14` I got `OpenSSL.SSL.WantWriteError` error. Here is simple script to reproduce the issue:
```
from gevent import monkey
monkey.patch_all()
import requests
payload = 'x' * 1024 * 1000
requests.get('https://example.org/', data=payload, verify=False)
```
As a workaround you can use `pyOpenSSL 0.13`. BTW it seems to me that SSL's `WrappedSocket.sendall()` method should do the same thing it does for SSL handshake. But it seems to be a problem since pyOpenSSL doesn't report number of bytes already sent. I got `OpenSSL.SSL.Error: [('SSL routines', 'SSL3_WRITE_PENDING', 'bad write retry')]` on retry.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2108/reactions"
} | https://api.github.com/repos/psf/requests/issues/2108/timeline | null | completed | null | null | false | [
"Here is possible fix:\n\n```\nclass WrappedSocket(object):\n...\n...\n def send_until_done(self, data):\n while True:\n try:\n return self.connection.send(data)\n except OpenSSL.SSL.WantWriteError:\n # TODO: implement timeouts\n select.se... |
https://api.github.com/repos/psf/requests/issues/2107 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2107/labels{/name} | https://api.github.com/repos/psf/requests/issues/2107/comments | https://api.github.com/repos/psf/requests/issues/2107/events | https://github.com/psf/requests/issues/2107 | 36,269,358 | MDU6SXNzdWUzNjI2OTM1OA== | 2,107 | Obsolete link address in docs/user/install.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/731266?v=4",
"events_url": "https://api.github.com/users/piglei/events{/privacy}",
"followers_url": "https://api.github.com/users/piglei/followers",
"following_url": "https://api.github.com/users/piglei/following{/other_user}",
"gists_url": "https://api.github.com/users/piglei/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/piglei",
"id": 731266,
"login": "piglei",
"node_id": "MDQ6VXNlcjczMTI2Ng==",
"organizations_url": "https://api.github.com/users/piglei/orgs",
"received_events_url": "https://api.github.com/users/piglei/received_events",
"repos_url": "https://api.github.com/users/piglei/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/piglei/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/piglei/subscriptions",
"type": "User",
"url": "https://api.github.com/users/piglei",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-06-23T08:04:02Z | 2021-09-08T23:10:53Z | 2014-07-02T15:41:14Z | NONE | resolved | Hi, the link which describes pip and easy_install's difference in `docs/user/install.rst` are obsolete.
```
But, you really `shouldn't do that <http://www.pip-installer.org/en/latest/other-tools.html#pip-compared-to-easy-install>`_.
```
But I found that this page is not available in pip's document any more, maybe we should point this link to some place else instead?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2107/reactions"
} | https://api.github.com/repos/psf/requests/issues/2107/timeline | null | completed | null | null | false | [
"Good spot, we should fix that up. Maybe [this StackOverflow answer](http://stackoverflow.com/questions/3220404/why-use-pip-over-easy-install)?\n",
"I think that StackOverflow answer is good. :smile:\n"
] |
https://api.github.com/repos/psf/requests/issues/2106 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2106/labels{/name} | https://api.github.com/repos/psf/requests/issues/2106/comments | https://api.github.com/repos/psf/requests/issues/2106/events | https://github.com/psf/requests/pull/2106 | 36,260,330 | MDExOlB1bGxSZXF1ZXN0MTc0NTU4ODg= | 2,106 | Update test_expires_valid_str in test_request.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/936479?v=4",
"events_url": "https://api.github.com/users/xiongxoy/events{/privacy}",
"followers_url": "https://api.github.com/users/xiongxoy/followers",
"following_url": "https://api.github.com/users/xiongxoy/following{/other_user}",
"gists_url": "https://api.github.com/users/xiongxoy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xiongxoy",
"id": 936479,
"login": "xiongxoy",
"node_id": "MDQ6VXNlcjkzNjQ3OQ==",
"organizations_url": "https://api.github.com/users/xiongxoy/orgs",
"received_events_url": "https://api.github.com/users/xiongxoy/received_events",
"repos_url": "https://api.github.com/users/xiongxoy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xiongxoy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xiongxoy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xiongxoy",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-06-23T03:40:50Z | 2021-09-08T23:07:15Z | 2014-06-23T07:24:46Z | NONE | resolved | "assert cookie.expires == 1" is changed to "assert cookie.expires is not None" at line 1166.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2106/reactions"
} | https://api.github.com/repos/psf/requests/issues/2106/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2106.diff",
"html_url": "https://github.com/psf/requests/pull/2106",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2106.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2106"
} | true | [
"What's the purpose of this change?\n",
"When running on my system, the previous test failed, I think it should be\ntested against None, not 1\n2014年6月23日 下午1:02于 \"Cory Benfield\" notifications@github.com写道：\n\n> What's the purpose of this change?\n> \n> —\n> Reply to this email directly or view it on GitHub\n> ... |
https://api.github.com/repos/psf/requests/issues/2105 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2105/labels{/name} | https://api.github.com/repos/psf/requests/issues/2105/comments | https://api.github.com/repos/psf/requests/issues/2105/events | https://github.com/psf/requests/issues/2105 | 36,212,659 | MDU6SXNzdWUzNjIxMjY1OQ== | 2,105 | setup.py says requests does not support python3.4 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1018674?v=4",
"events_url": "https://api.github.com/users/robvdl/events{/privacy}",
"followers_url": "https://api.github.com/users/robvdl/followers",
"following_url": "https://api.github.com/users/robvdl/following{/other_user}",
"gists_url": "https://api.github.com/users/robvdl/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/robvdl",
"id": 1018674,
"login": "robvdl",
"node_id": "MDQ6VXNlcjEwMTg2NzQ=",
"organizations_url": "https://api.github.com/users/robvdl/orgs",
"received_events_url": "https://api.github.com/users/robvdl/received_events",
"repos_url": "https://api.github.com/users/robvdl/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/robvdl/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/robvdl/subscriptions",
"type": "User",
"url": "https://api.github.com/users/robvdl",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-06-21T00:39:36Z | 2021-09-08T23:10:38Z | 2014-07-02T07:25:57Z | NONE | resolved | Since Ubuntu 14.04 LTS comes with python 3.4, this is quite a big deal.
I haven't tested it yet with python 3.4 myself
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2105/reactions"
} | https://api.github.com/repos/psf/requests/issues/2105/timeline | null | completed | null | null | false | [
"@robvdl it does not say that it \"does not support Python 3.4\" it is merely an omission that we do in fact support 3.4. I'd like to wait for @kennethreitz to add a Python 3.4 builder to the Jenkins server before adding it however.\n",
"Requests works fine with Python 3.4, I get some test coverage of it from hyp... |
https://api.github.com/repos/psf/requests/issues/2104 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2104/labels{/name} | https://api.github.com/repos/psf/requests/issues/2104/comments | https://api.github.com/repos/psf/requests/issues/2104/events | https://github.com/psf/requests/pull/2104 | 36,212,504 | MDExOlB1bGxSZXF1ZXN0MTc0MzQyNDA= | 2,104 | make requests.request('HEAD',...) behave the same as requests.head(...) | {
"avatar_url": "https://avatars.githubusercontent.com/u/5319942?v=4",
"events_url": "https://api.github.com/users/rtdean/events{/privacy}",
"followers_url": "https://api.github.com/users/rtdean/followers",
"following_url": "https://api.github.com/users/rtdean/following{/other_user}",
"gists_url": "https://api.github.com/users/rtdean/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rtdean",
"id": 5319942,
"login": "rtdean",
"node_id": "MDQ6VXNlcjUzMTk5NDI=",
"organizations_url": "https://api.github.com/users/rtdean/orgs",
"received_events_url": "https://api.github.com/users/rtdean/received_events",
"repos_url": "https://api.github.com/users/rtdean/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rtdean/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rtdean/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rtdean",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
},
{
"color": "e11d21",
"default": false,
"d... | closed | true | null | [] | null | 4 | 2014-06-21T00:33:50Z | 2021-09-08T23:07:14Z | 2014-06-23T19:10:42Z | NONE | resolved | Currently requests.head() behaves differently (doesn't follow redirects) than requests.request('HEAD', ...)
This is, I believe, undesirable behaviour, and also disagrees with the documentation (http://docs.python-requests.org/en/latest/user/quickstart/#redirection-and-history).
This also addresses the problem described in kennethreitz/grequests#45
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2104/reactions"
} | https://api.github.com/repos/psf/requests/issues/2104/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2104.diff",
"html_url": "https://github.com/psf/requests/pull/2104",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2104.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2104"
} | true | [
"I disagree. If you're using `requests.request` with the verb explicitly you should know that you should be setting `allow_redirects=False`. Note the bug you reference in grequests was never actually acknowledged by Kenneth as a bug.\n\nThere is a bug in the documentation, but the bug is that it doesn't say \"when ... |
https://api.github.com/repos/psf/requests/issues/2103 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2103/labels{/name} | https://api.github.com/repos/psf/requests/issues/2103/comments | https://api.github.com/repos/psf/requests/issues/2103/events | https://github.com/psf/requests/issues/2103 | 36,147,541 | MDU6SXNzdWUzNjE0NzU0MQ== | 2,103 | How to set requests logging level? | {
"avatar_url": "https://avatars.githubusercontent.com/u/615755?v=4",
"events_url": "https://api.github.com/users/zhangyuting/events{/privacy}",
"followers_url": "https://api.github.com/users/zhangyuting/followers",
"following_url": "https://api.github.com/users/zhangyuting/following{/other_user}",
"gists_url": "https://api.github.com/users/zhangyuting/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zhangyuting",
"id": 615755,
"login": "zhangyuting",
"node_id": "MDQ6VXNlcjYxNTc1NQ==",
"organizations_url": "https://api.github.com/users/zhangyuting/orgs",
"received_events_url": "https://api.github.com/users/zhangyuting/received_events",
"repos_url": "https://api.github.com/users/zhangyuting/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zhangyuting/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhangyuting/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zhangyuting",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-06-20T07:56:01Z | 2021-09-08T23:10:56Z | 2014-06-20T08:37:58Z | NONE | resolved | I just want to set requests logging level up to warning cause I'm not interested in that information. But I don't wish to impact my logging leveling with root logger I set, please help me?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2103/reactions"
} | https://api.github.com/repos/psf/requests/issues/2103/timeline | null | completed | null | null | false | [
"Setting logging levels for a module is very easy:\n\n``` python\nimport logging\nlog = logging.getLogger('requests')\nlog.setLevel(logging.WARNING)\n```\n",
"In the future, please ask your question on [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests)\n",
"Ok, thank you so much.—\nSent... |
https://api.github.com/repos/psf/requests/issues/2102 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2102/labels{/name} | https://api.github.com/repos/psf/requests/issues/2102/comments | https://api.github.com/repos/psf/requests/issues/2102/events | https://github.com/psf/requests/issues/2102 | 36,044,887 | MDU6SXNzdWUzNjA0NDg4Nw== | 2,102 | Is there any methods to get the source TCP port of the requests? | {
"avatar_url": "https://avatars.githubusercontent.com/u/7300843?v=4",
"events_url": "https://api.github.com/users/bofortitude/events{/privacy}",
"followers_url": "https://api.github.com/users/bofortitude/followers",
"following_url": "https://api.github.com/users/bofortitude/following{/other_user}",
"gists_url": "https://api.github.com/users/bofortitude/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bofortitude",
"id": 7300843,
"login": "bofortitude",
"node_id": "MDQ6VXNlcjczMDA4NDM=",
"organizations_url": "https://api.github.com/users/bofortitude/orgs",
"received_events_url": "https://api.github.com/users/bofortitude/received_events",
"repos_url": "https://api.github.com/users/bofortitude/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bofortitude/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bofortitude/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bofortitude",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-06-19T02:26:41Z | 2021-09-08T23:10:57Z | 2014-06-19T02:31:05Z | NONE | resolved | I want to get the source TCP port of the socket in requests I send.
Any answers will be appreciated.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2102/reactions"
} | https://api.github.com/repos/psf/requests/issues/2102/timeline | null | completed | null | null | false | [
"As the documentation indicates, there is no builtin method for that. If you can grab the connection from urllib3 there might be a way to do it there. In the future, please ask your _questions_ on [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests)\n"
] |
https://api.github.com/repos/psf/requests/issues/2101 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2101/labels{/name} | https://api.github.com/repos/psf/requests/issues/2101/comments | https://api.github.com/repos/psf/requests/issues/2101/events | https://github.com/psf/requests/issues/2101 | 36,043,588 | MDU6SXNzdWUzNjA0MzU4OA== | 2,101 | can you guys help me out with json, et al? It's for a good cause. | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-06-19T01:51:38Z | 2021-09-08T23:10:57Z | 2014-06-19T02:22:57Z | NONE | resolved | I need a super easy way to send and receive json.
Nothing fancy.
We want to send/receive json very similar to google geocode api.
I will put kudos on wikispeedia.org
thanks for consideration.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2101/reactions"
} | https://api.github.com/repos/psf/requests/issues/2101/timeline | null | completed | null | null | false | [
"The proper place to ask questions is [StackOverflow](https://stackoverflow.com/questions/tagged/python-requests).\n",
"no thanks\n\nOn Wed, Jun 18, 2014 at 9:23 PM, Ian Cordasco notifications@github.com\nwrote:\n\n> The proper place to ask questions is StackOverflow\n> https://stackoverflow.com/questions/tagged/... |
https://api.github.com/repos/psf/requests/issues/2100 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2100/labels{/name} | https://api.github.com/repos/psf/requests/issues/2100/comments | https://api.github.com/repos/psf/requests/issues/2100/events | https://github.com/psf/requests/issues/2100 | 36,043,524 | MDU6SXNzdWUzNjA0MzUyNA== | 2,100 | can you guys help me out with json, et al? I | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-06-19T01:49:59Z | 2021-09-08T23:10:57Z | 2014-06-19T02:21:27Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2100/reactions"
} | https://api.github.com/repos/psf/requests/issues/2100/timeline | null | completed | null | null | false | [] | |
https://api.github.com/repos/psf/requests/issues/2099 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2099/labels{/name} | https://api.github.com/repos/psf/requests/issues/2099/comments | https://api.github.com/repos/psf/requests/issues/2099/events | https://github.com/psf/requests/pull/2099 | 35,955,921 | MDExOlB1bGxSZXF1ZXN0MTcyNzYxNTE= | 2,099 | hahahah | {
"avatar_url": "https://avatars.githubusercontent.com/u/3658006?v=4",
"events_url": "https://api.github.com/users/q4478842/events{/privacy}",
"followers_url": "https://api.github.com/users/q4478842/followers",
"following_url": "https://api.github.com/users/q4478842/following{/other_user}",
"gists_url": "https://api.github.com/users/q4478842/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/q4478842",
"id": 3658006,
"login": "q4478842",
"node_id": "MDQ6VXNlcjM2NTgwMDY=",
"organizations_url": "https://api.github.com/users/q4478842/orgs",
"received_events_url": "https://api.github.com/users/q4478842/received_events",
"repos_url": "https://api.github.com/users/q4478842/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/q4478842/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/q4478842/subscriptions",
"type": "User",
"url": "https://api.github.com/users/q4478842",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-06-18T05:35:20Z | 2021-09-08T23:08:14Z | 2014-06-18T15:30:26Z | NONE | resolved | sorry. this is for testing
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2099/reactions"
} | https://api.github.com/repos/psf/requests/issues/2099/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2099.diff",
"html_url": "https://github.com/psf/requests/pull/2099",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2099.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2099"
} | true | [
"@q4478842 Do not test whatever you're doing against this repository.\n"
] |
https://api.github.com/repos/psf/requests/issues/2098 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2098/labels{/name} | https://api.github.com/repos/psf/requests/issues/2098/comments | https://api.github.com/repos/psf/requests/issues/2098/events | https://github.com/psf/requests/pull/2098 | 35,954,163 | MDExOlB1bGxSZXF1ZXN0MTcyNzUxNzM= | 2,098 | hahahah | {
"avatar_url": "https://avatars.githubusercontent.com/u/3658006?v=4",
"events_url": "https://api.github.com/users/q4478842/events{/privacy}",
"followers_url": "https://api.github.com/users/q4478842/followers",
"following_url": "https://api.github.com/users/q4478842/following{/other_user}",
"gists_url": "https://api.github.com/users/q4478842/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/q4478842",
"id": 3658006,
"login": "q4478842",
"node_id": "MDQ6VXNlcjM2NTgwMDY=",
"organizations_url": "https://api.github.com/users/q4478842/orgs",
"received_events_url": "https://api.github.com/users/q4478842/received_events",
"repos_url": "https://api.github.com/users/q4478842/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/q4478842/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/q4478842/subscriptions",
"type": "User",
"url": "https://api.github.com/users/q4478842",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-06-18T04:42:44Z | 2021-09-08T23:08:19Z | 2014-06-18T04:42:56Z | NONE | resolved | I‘m sorry...
This is just for testing.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/3658006?v=4",
"events_url": "https://api.github.com/users/q4478842/events{/privacy}",
"followers_url": "https://api.github.com/users/q4478842/followers",
"following_url": "https://api.github.com/users/q4478842/following{/other_user}",
"gists_url": "https://api.github.com/users/q4478842/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/q4478842",
"id": 3658006,
"login": "q4478842",
"node_id": "MDQ6VXNlcjM2NTgwMDY=",
"organizations_url": "https://api.github.com/users/q4478842/orgs",
"received_events_url": "https://api.github.com/users/q4478842/received_events",
"repos_url": "https://api.github.com/users/q4478842/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/q4478842/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/q4478842/subscriptions",
"type": "User",
"url": "https://api.github.com/users/q4478842",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2098/reactions"
} | https://api.github.com/repos/psf/requests/issues/2098/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2098.diff",
"html_url": "https://github.com/psf/requests/pull/2098",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2098.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2098"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/2097 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2097/labels{/name} | https://api.github.com/repos/psf/requests/issues/2097/comments | https://api.github.com/repos/psf/requests/issues/2097/events | https://github.com/psf/requests/pull/2097 | 35,744,066 | MDExOlB1bGxSZXF1ZXN0MTcxNTAzOTc= | 2,097 | Update out-there.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-06-15T07:10:14Z | 2021-09-08T23:10:56Z | 2014-06-15T08:19:34Z | NONE | resolved | Remove french blog post which is now a deadlink.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2097/reactions"
} | https://api.github.com/repos/psf/requests/issues/2097/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2097.diff",
"html_url": "https://github.com/psf/requests/pull/2097",
"merged_at": "2014-06-15T08:19:34Z",
"patch_url": "https://github.com/psf/requests/pull/2097.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2097"
} | true | [
"Thanks so much for this! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2096 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2096/labels{/name} | https://api.github.com/repos/psf/requests/issues/2096/comments | https://api.github.com/repos/psf/requests/issues/2096/events | https://github.com/psf/requests/issues/2096 | 35,729,374 | MDU6SXNzdWUzNTcyOTM3NA== | 2,096 | Fix Event Hooks Documentation or the Hook Handling Code | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] | closed | true | null | [] | null | 2 | 2014-06-14T14:29:06Z | 2021-09-08T23:10:58Z | 2014-06-14T16:05:16Z | CONTRIBUTOR | resolved | After looking at [this StackOverflow question](http://stackoverflow.com/a/24214101/1953283), I realized that our documentation about [Event Hooks](http://docs.python-requests.org/en/latest/user/advanced/?highlight=hook#event-hooks) is wrong. Specifically,
```
If the function doesn’t return anything, nothing else is effected.
```
It makes sense to me that a callback would not be required to return anything for it to be a successful hook. There's two avenues to fix this:
1. Make the behaviour match the documentation
2. Make the documentation match the behaviour
Both are easy, but it depends on what we want the behaviour to actually be.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2096/reactions"
} | https://api.github.com/repos/psf/requests/issues/2096/timeline | null | completed | null | null | false | [
"Wait, is this wrong? If a function doesn't return anything it returns `None`, and our code seems to handle that appropriately. What have I missed?\n",
"This is my brain on very little (if any) sleep. Sorry all\n"
] |
https://api.github.com/repos/psf/requests/issues/2095 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2095/labels{/name} | https://api.github.com/repos/psf/requests/issues/2095/comments | https://api.github.com/repos/psf/requests/issues/2095/events | https://github.com/psf/requests/pull/2095 | 35,579,446 | MDExOlB1bGxSZXF1ZXN0MTcwNTIwODM= | 2,095 | Redirect cache | {
"avatar_url": "https://avatars.githubusercontent.com/u/1167238?v=4",
"events_url": "https://api.github.com/users/ericfrederich/events{/privacy}",
"followers_url": "https://api.github.com/users/ericfrederich/followers",
"following_url": "https://api.github.com/users/ericfrederich/following{/other_user}",
"gists_url": "https://api.github.com/users/ericfrederich/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ericfrederich",
"id": 1167238,
"login": "ericfrederich",
"node_id": "MDQ6VXNlcjExNjcyMzg=",
"organizations_url": "https://api.github.com/users/ericfrederich/orgs",
"received_events_url": "https://api.github.com/users/ericfrederich/received_events",
"repos_url": "https://api.github.com/users/ericfrederich/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ericfrederich/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericfrederich/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ericfrederich",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 22 | 2014-06-12T12:34:08Z | 2021-09-08T10:01:22Z | 2014-06-12T18:42:42Z | CONTRIBUTOR | resolved | When web clients like Firefox get a redirect they will not go after the old version any more even if you type it into the address bar.
This patch makes the requests framework work in the same way.
This helps performance when creating a request proxy that delegates to other servers based on URL.
This patch has me going from 245 requests per second to 470 requests per second against a server returning 308 response codes.
-- example server
https://gist.github.com/ericfrederich/a004862e1da1fb6916ef
-- example client
https://gist.github.com/ericfrederich/e1225e2d07e3ee923b27
-- example server output of 301 vs 302 redireects
https://gist.github.com/ericfrederich/b77bd4852a3cf9b968f0
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2095/reactions"
} | https://api.github.com/repos/psf/requests/issues/2095/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2095.diff",
"html_url": "https://github.com/psf/requests/pull/2095",
"merged_at": "2014-06-12T18:42:42Z",
"patch_url": "https://github.com/psf/requests/pull/2095.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2095"
} | true | [
"Thanks for this!\n\nI have mixed feelings. In general, this seems really helpful, but it also seems like it could introduce difficult-to-trace bugs when working with unhelpful upstream websites. Altogether I'm tempted to err in favour of the change though.\n\nIt'll need a unit test though: mind writing one?\n\nIn ... |
https://api.github.com/repos/psf/requests/issues/2094 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2094/labels{/name} | https://api.github.com/repos/psf/requests/issues/2094/comments | https://api.github.com/repos/psf/requests/issues/2094/events | https://github.com/psf/requests/pull/2094 | 35,519,358 | MDExOlB1bGxSZXF1ZXN0MTcwMTkwODY= | 2,094 | Default timeout for requests.Session object | {
"avatar_url": "https://avatars.githubusercontent.com/u/620035?v=4",
"events_url": "https://api.github.com/users/moliware/events{/privacy}",
"followers_url": "https://api.github.com/users/moliware/followers",
"following_url": "https://api.github.com/users/moliware/following{/other_user}",
"gists_url": "https://api.github.com/users/moliware/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/moliware",
"id": 620035,
"login": "moliware",
"node_id": "MDQ6VXNlcjYyMDAzNQ==",
"organizations_url": "https://api.github.com/users/moliware/orgs",
"received_events_url": "https://api.github.com/users/moliware/received_events",
"repos_url": "https://api.github.com/users/moliware/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/moliware/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/moliware/subscriptions",
"type": "User",
"url": "https://api.github.com/users/moliware",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-06-11T19:46:51Z | 2021-09-08T10:01:12Z | 2014-06-11T19:51:57Z | NONE | resolved | The idea is to have a default timeout for each request you make with a session object.
Example:
``` python
>>> import requests
>>> s = requests.Session()
>>> s.timeout = 1
>>> s.get('https://httpbin.org/delay/10')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/sessions.py", line 473, in get
return self.request('GET', url, **kwargs)
File "requests/sessions.py", line 461, in request
resp = self.send(prep, **send_kwargs)
File "requests/sessions.py", line 564, in send
r = adapter.send(request, **kwargs)
File "requests/adapters.py", line 384, in send
raise Timeout(e, request=request)
requests.exceptions.Timeout: HTTPSConnectionPool(host='httpbin.org', port=443): Read timed out.
```
I came up with this PR to meet a need of a project based on requests => https://github.com/RedTuna/mysolr/issues/40
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2094/reactions"
} | https://api.github.com/repos/psf/requests/issues/2094/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2094.diff",
"html_url": "https://github.com/psf/requests/pull/2094",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2094.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2094"
} | true | [
"Thanks for this!\n\nUnfortunately, this is a feature request that comes up often but that we don't have any real interest in. See #2011 for a longer form justification. For this reason, I'm afraid that we can't accept this pull request. Thanks so much for the work though, and please do keep contributing! :cake:\n"... |
https://api.github.com/repos/psf/requests/issues/2093 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2093/labels{/name} | https://api.github.com/repos/psf/requests/issues/2093/comments | https://api.github.com/repos/psf/requests/issues/2093/events | https://github.com/psf/requests/issues/2093 | 35,511,527 | MDU6SXNzdWUzNTUxMTUyNw== | 2,093 | Review new httpbin package and pytest-httpbin for testing | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-06-11T18:21:05Z | 2021-09-08T23:08:08Z | 2014-09-12T20:14:15Z | CONTRIBUTOR | resolved | https://github.com/kevin1024/pytest-httpbin
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2093/reactions"
} | https://api.github.com/repos/psf/requests/issues/2093/timeline | null | completed | null | null | false | [
"That's still rather slow. [Betamax](/sigmavirus24/betamax) can cover our needs and still be faster than using that. If you're concerned about the speed of our tests, I'll be happy to add betamax to the mix.\n",
"This is still making actual HTTP requests, though. How much can we trust a Betamax-style test suite? ... |
https://api.github.com/repos/psf/requests/issues/2092 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2092/labels{/name} | https://api.github.com/repos/psf/requests/issues/2092/comments | https://api.github.com/repos/psf/requests/issues/2092/events | https://github.com/psf/requests/issues/2092 | 35,468,866 | MDU6SXNzdWUzNTQ2ODg2Ng== | 2,092 | REQUESTS_CA_BUNDLE is not correctly check in ‘requests/sessions.py’ | {
"avatar_url": "https://avatars.githubusercontent.com/u/7838259?v=4",
"events_url": "https://api.github.com/users/H0neyBadger/events{/privacy}",
"followers_url": "https://api.github.com/users/H0neyBadger/followers",
"following_url": "https://api.github.com/users/H0neyBadger/following{/other_user}",
"gists_url": "https://api.github.com/users/H0neyBadger/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/H0neyBadger",
"id": 7838259,
"login": "H0neyBadger",
"node_id": "MDQ6VXNlcjc4MzgyNTk=",
"organizations_url": "https://api.github.com/users/H0neyBadger/orgs",
"received_events_url": "https://api.github.com/users/H0neyBadger/received_events",
"repos_url": "https://api.github.com/users/H0neyBadger/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/H0neyBadger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/H0neyBadger/subscriptions",
"type": "User",
"url": "https://api.github.com/users/H0neyBadger",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-06-11T10:07:50Z | 2021-09-08T23:10:52Z | 2014-07-03T13:35:55Z | NONE | resolved | When ‘verify’ is explicitly set to ‘True‘, CA_BUNDLE ENV variables are not checked:
'REQUESTS_CA_BUNDLE' and 'CURL_CA_BUNDLE'
**requests.get('https://my.trusted.server:8080', verify=True)**
requests/sessions.py line 434
# Look for configuration.
**if not verify** and verify is not False:
verify = os.environ.get('REQUESTS_CA_BUNDLE')
# Curl compatibility.
**if not verify** and verify is not False:
verify = os.environ.get('CURL_CA_BUNDLE')
You should probably use:
**if verify is True or (not verify and verify is not False):**
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2092/reactions"
} | https://api.github.com/repos/psf/requests/issues/2092/timeline | null | completed | null | null | false | [
"Thanks for this, it's a good spot!\n\nI feel like the correct logic is probably: `if verify is True or verify is None`. I don't believe the other falsy values (empty string, empty list etc.) should cause us to accidentally turn verification on.\n",
"I second @Lukasa's far more explicit check for `None`.\n",
"I... |
https://api.github.com/repos/psf/requests/issues/2091 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2091/labels{/name} | https://api.github.com/repos/psf/requests/issues/2091/comments | https://api.github.com/repos/psf/requests/issues/2091/events | https://github.com/psf/requests/pull/2091 | 35,442,931 | MDExOlB1bGxSZXF1ZXN0MTY5NzU2OTU= | 2,091 | Update README.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/5325221?v=4",
"events_url": "https://api.github.com/users/Mtax/events{/privacy}",
"followers_url": "https://api.github.com/users/Mtax/followers",
"following_url": "https://api.github.com/users/Mtax/following{/other_user}",
"gists_url": "https://api.github.com/users/Mtax/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Mtax",
"id": 5325221,
"login": "Mtax",
"node_id": "MDQ6VXNlcjUzMjUyMjE=",
"organizations_url": "https://api.github.com/users/Mtax/orgs",
"received_events_url": "https://api.github.com/users/Mtax/received_events",
"repos_url": "https://api.github.com/users/Mtax/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Mtax/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mtax/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Mtax",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-06-11T01:41:21Z | 2021-09-09T00:01:15Z | 2014-06-11T02:03:47Z | NONE | resolved | Translated some important message to Chinese.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2091/reactions"
} | https://api.github.com/repos/psf/requests/issues/2091/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2091.diff",
"html_url": "https://github.com/psf/requests/pull/2091",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2091.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2091"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/2090 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2090/labels{/name} | https://api.github.com/repos/psf/requests/issues/2090/comments | https://api.github.com/repos/psf/requests/issues/2090/events | https://github.com/psf/requests/pull/2090 | 35,422,288 | MDExOlB1bGxSZXF1ZXN0MTY5NjM3MzQ= | 2,090 | handle 308 redirection the same as 301 and 302 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1167238?v=4",
"events_url": "https://api.github.com/users/ericfrederich/events{/privacy}",
"followers_url": "https://api.github.com/users/ericfrederich/followers",
"following_url": "https://api.github.com/users/ericfrederich/following{/other_user}",
"gists_url": "https://api.github.com/users/ericfrederich/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ericfrederich",
"id": 1167238,
"login": "ericfrederich",
"node_id": "MDQ6VXNlcjExNjcyMzg=",
"organizations_url": "https://api.github.com/users/ericfrederich/orgs",
"received_events_url": "https://api.github.com/users/ericfrederich/received_events",
"repos_url": "https://api.github.com/users/ericfrederich/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ericfrederich/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ericfrederich/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ericfrederich",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 8 | 2014-06-10T20:33:18Z | 2021-09-09T00:01:24Z | 2014-06-12T04:19:45Z | CONTRIBUTOR | resolved | 308 is also a redirect. It is the permanent version of 307
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2090/reactions"
} | https://api.github.com/repos/psf/requests/issues/2090/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2090.diff",
"html_url": "https://github.com/psf/requests/pull/2090",
"merged_at": "2014-06-12T04:19:44Z",
"patch_url": "https://github.com/psf/requests/pull/2090.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2090"
} | true | [
"Thanks for this!\n\nWe should go the whole hog though. HTTP 308 is not 'Resume' anymore, it's 'Permanent Redirect', as defined in [RFC 7238](http://tools.ietf.org/html/rfc7238). Mind making the relevant updates in `status_codes.py`?\n",
"Alright, went ahead and made changes to status_codes and everywhere else re... |
https://api.github.com/repos/psf/requests/issues/2089 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2089/labels{/name} | https://api.github.com/repos/psf/requests/issues/2089/comments | https://api.github.com/repos/psf/requests/issues/2089/events | https://github.com/psf/requests/pull/2089 | 35,393,249 | MDExOlB1bGxSZXF1ZXN0MTY5NDYzNTM= | 2,089 | Update README.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/5325221?v=4",
"events_url": "https://api.github.com/users/Mtax/events{/privacy}",
"followers_url": "https://api.github.com/users/Mtax/followers",
"following_url": "https://api.github.com/users/Mtax/following{/other_user}",
"gists_url": "https://api.github.com/users/Mtax/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Mtax",
"id": 5325221,
"login": "Mtax",
"node_id": "MDQ6VXNlcjUzMjUyMjE=",
"organizations_url": "https://api.github.com/users/Mtax/orgs",
"received_events_url": "https://api.github.com/users/Mtax/received_events",
"repos_url": "https://api.github.com/users/Mtax/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Mtax/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Mtax/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Mtax",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-06-10T15:22:32Z | 2021-09-08T23:08:29Z | 2014-06-10T16:25:08Z | NONE | resolved | Translated some important message to Chinese.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2089/reactions"
} | https://api.github.com/repos/psf/requests/issues/2089/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2089.diff",
"html_url": "https://github.com/psf/requests/pull/2089",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2089.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2089"
} | true | [
"You likely meant to submit this [here](https://github.com/requests/requests-docs-cn).\n",
"Thanks a lot\n\nOn Wed, Jun 11, 2014 at 12:25 AM, Ian Cordasco notifications@github.com\nwrote:\n\n> You likely meant to submit this here\n> https://github.com/requests/requests-docs-cn.\n> \n> —\n> Reply to this email dir... |
https://api.github.com/repos/psf/requests/issues/2088 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2088/labels{/name} | https://api.github.com/repos/psf/requests/issues/2088/comments | https://api.github.com/repos/psf/requests/issues/2088/events | https://github.com/psf/requests/pull/2088 | 35,379,929 | MDExOlB1bGxSZXF1ZXN0MTY5Mzg2NjQ= | 2,088 | various pep-8 cleanups; remove unsused imports; remove unused variables | {
"avatar_url": "https://avatars.githubusercontent.com/u/1280137?v=4",
"events_url": "https://api.github.com/users/jeffknupp/events{/privacy}",
"followers_url": "https://api.github.com/users/jeffknupp/followers",
"following_url": "https://api.github.com/users/jeffknupp/following{/other_user}",
"gists_url": "https://api.github.com/users/jeffknupp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jeffknupp",
"id": 1280137,
"login": "jeffknupp",
"node_id": "MDQ6VXNlcjEyODAxMzc=",
"organizations_url": "https://api.github.com/users/jeffknupp/orgs",
"received_events_url": "https://api.github.com/users/jeffknupp/received_events",
"repos_url": "https://api.github.com/users/jeffknupp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jeffknupp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jeffknupp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jeffknupp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-06-10T13:11:22Z | 2021-09-08T23:11:07Z | 2014-06-10T16:02:21Z | NONE | resolved | A number of PEP-8 related cleanups. Also removing unused imports and unused variables.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2088/reactions"
} | https://api.github.com/repos/psf/requests/issues/2088/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2088.diff",
"html_url": "https://github.com/psf/requests/pull/2088",
"merged_at": "2014-06-10T16:02:21Z",
"patch_url": "https://github.com/psf/requests/pull/2088.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2088"
} | true | [
"@jeffknupp In general this is great and I'm sure we'll be happy to have it. However, please note that we view PEP8 more as guidelines than actual rules (see #1899), and there's some things that Kenneth actively dislikes, so don't get too invested by changing other parts of the code. =)\n",
":sparkles: :cake: :sp... |
https://api.github.com/repos/psf/requests/issues/2087 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2087/labels{/name} | https://api.github.com/repos/psf/requests/issues/2087/comments | https://api.github.com/repos/psf/requests/issues/2087/events | https://github.com/psf/requests/pull/2087 | 35,204,244 | MDExOlB1bGxSZXF1ZXN0MTY4NTI3NjM= | 2,087 | Update trivial mentions to RFC 2616. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-06-07T08:56:07Z | 2021-09-09T00:01:21Z | 2014-06-08T14:44:26Z | MEMBER | resolved | As a companion to #2086, this updates all the other references to RFC 2616 in our codebase and documentation to their new locations. Gonna let @sigmavirus24 review this rather than merge it myself (which I'd normally do) just so he can sanity-check.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2087/reactions"
} | https://api.github.com/repos/psf/requests/issues/2087/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2087.diff",
"html_url": "https://github.com/psf/requests/pull/2087",
"merged_at": "2014-06-08T14:44:26Z",
"patch_url": "https://github.com/psf/requests/pull/2087.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2087"
} | true | [
"LGTM. :cake: \n"
] |
https://api.github.com/repos/psf/requests/issues/2086 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2086/labels{/name} | https://api.github.com/repos/psf/requests/issues/2086/comments | https://api.github.com/repos/psf/requests/issues/2086/events | https://github.com/psf/requests/issues/2086 | 35,202,262 | MDU6SXNzdWUzNTIwMjI2Mg== | 2,086 | Remove ISO-8859-1 charset fallback | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"... | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 37 | 2014-06-07T06:54:12Z | 2018-02-07T16:04:07Z | null | MEMBER | null | For a long time we've had a fallback value in `response.encoding` of `ISO-8859-1`, because RFC 2616 told us to. RFC 2616 is now obsolete, replaced by RFCs 7230, 7231, 7232, 7233, 7234, and 7235. The authoritative RFC on this issue is RFC 7231, which has this to say:
> The default charset of ISO-8859-1 for text media types has been removed; the default is now whatever the media type definition says.
The media type definitions for `text/*` are most recently affected by RFC 6657, which has this to say:
> In accordance with option (a) above, registrations for "text/*" media types that can transport charset information inside the corresponding payloads (such as "text/html" and "text/xml") SHOULD NOT specify the use of a "charset" parameter, nor any default value, in order to avoid conflicting interpretations should the "charset" parameter value and the value specified in the payload disagree.
I checked the registration for `text/html` [here](https://www.iana.org/assignments/media-types/media-types.xhtml#text). Unsurprisingly, it provides no default values. It does allow a charset parameter which overrides anything in the content itself.
I propose the following changes:
1. Remove the ISO-8859-1 fallback, as it's no longer valid (being only enforced by RFC 2616). We should _definitely_ do this.
2. Consider writing a module that has the appropriate fallback encodings for other `text/*` content and use them where appropriate. This isn't vital, just is a "might be nice".
3. Begin checking HTML content for meta tags again, in order to appropriately fall back. This is controversial, and we'll want @kennethreitz to consider it carefully.
| null | {
"+1": 5,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 5,
"url": "https://api.github.com/repos/psf/requests/issues/2086/reactions"
} | https://api.github.com/repos/psf/requests/issues/2086/timeline | null | null | null | null | false | [
"> Remove the ISO-8859-1 fallback, as it's no longer valid (being only enforced by RFC 2616). We should definitely do this.\n\nI agree that we should remove the fallback. I do wonder how we should handle `Response#text` in the event that the server does not specify a charset (in anyway, including the meta tags of t... |
https://api.github.com/repos/psf/requests/issues/2085 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2085/labels{/name} | https://api.github.com/repos/psf/requests/issues/2085/comments | https://api.github.com/repos/psf/requests/issues/2085/events | https://github.com/psf/requests/issues/2085 | 35,133,134 | MDU6SXNzdWUzNTEzMzEzNA== | 2,085 | NTLM auth broken in 2.3.0? | {
"avatar_url": "https://avatars.githubusercontent.com/u/7807926?v=4",
"events_url": "https://api.github.com/users/rekcahpassyla/events{/privacy}",
"followers_url": "https://api.github.com/users/rekcahpassyla/followers",
"following_url": "https://api.github.com/users/rekcahpassyla/following{/other_user}",
"gists_url": "https://api.github.com/users/rekcahpassyla/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rekcahpassyla",
"id": 7807926,
"login": "rekcahpassyla",
"node_id": "MDQ6VXNlcjc4MDc5MjY=",
"organizations_url": "https://api.github.com/users/rekcahpassyla/orgs",
"received_events_url": "https://api.github.com/users/rekcahpassyla/received_events",
"repos_url": "https://api.github.com/users/rekcahpassyla/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rekcahpassyla/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rekcahpassyla/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rekcahpassyla",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-06-06T09:59:28Z | 2021-09-08T23:11:02Z | 2014-06-06T10:00:58Z | NONE | resolved | Hi,
I am not sure exactly where this should go (here or https://github.com/requests/requests-ntlm/) so I will post it in both places.
I have been using `requests-ntlm` (post-version 0.0.2.2) in conjunction with `requests 2.2.1`. Recently I upgraded to `requests 2.3.0` and found that NTLM authentication no longer worked; every request was rejected with 401 Unauthorized.
Side-by-side debugging of 2.2.1 vs 2.3.0 yielded the result that [this deletion](https://github.com/kennethreitz/requests/compare/v2.2.1...v2.3.0#diff-31f6e77c031977d33226530924b4337aL393) causes a connection not to be put into the pool. I can fix this by patching `requests-ntlm` but I am not familiar with either library, so while I know that this will solve my problem I wanted to mention this here in case it might be related to any other problems to do with `requests`.
I'm happy to provide debug logs or further details.
Many thanks
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2085/reactions"
} | https://api.github.com/repos/psf/requests/issues/2085/timeline | null | completed | null | null | false | [
"This should be posted only on requests-ntlm. =)\n",
"Thanks, am going to repost now. \n"
] |
https://api.github.com/repos/psf/requests/issues/2084 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2084/labels{/name} | https://api.github.com/repos/psf/requests/issues/2084/comments | https://api.github.com/repos/psf/requests/issues/2084/events | https://github.com/psf/requests/issues/2084 | 34,999,129 | MDU6SXNzdWUzNDk5OTEyOQ== | 2,084 | Verify https, without exception | {
"avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4",
"events_url": "https://api.github.com/users/RuudBurger/events{/privacy}",
"followers_url": "https://api.github.com/users/RuudBurger/followers",
"following_url": "https://api.github.com/users/RuudBurger/following{/other_user}",
"gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RuudBurger",
"id": 38136,
"login": "RuudBurger",
"node_id": "MDQ6VXNlcjM4MTM2",
"organizations_url": "https://api.github.com/users/RuudBurger/orgs",
"received_events_url": "https://api.github.com/users/RuudBurger/received_events",
"repos_url": "https://api.github.com/users/RuudBurger/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RuudBurger",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2014-06-04T20:21:54Z | 2021-09-08T23:11:03Z | 2014-06-04T20:33:07Z | NONE | resolved | I'm looking for a way to do a verify, but still continue with the actual request.
This way I can create a message, notifying the user, but returning the content.
See:
https://github.com/RuudBurger/CouchPotatoServer/issues/3357 or https://github.com/RuudBurger/CouchPotatoServer/issues/3369
If I check both
http://www.sslshopper.com/ssl-checker.html#hostname=torrentshack.net
http://www.sslshopper.com/ssl-checker.html#hostname=nzbs.in
They seem fine to me, but they fail using requests
There are also a lot of users using selfsigned urls, giving just a warning would be good enough here also.
I've tried creating my own adapter, extending the httpadapter, but then I have to do a requests and if that fails on SSLError, remove verify=true and do the request again. Seems a bit overkill to me.
Hope you can help me out.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4",
"events_url": "https://api.github.com/users/RuudBurger/events{/privacy}",
"followers_url": "https://api.github.com/users/RuudBurger/followers",
"following_url": "https://api.github.com/users/RuudBurger/following{/other_user}",
"gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RuudBurger",
"id": 38136,
"login": "RuudBurger",
"node_id": "MDQ6VXNlcjM4MTM2",
"organizations_url": "https://api.github.com/users/RuudBurger/orgs",
"received_events_url": "https://api.github.com/users/RuudBurger/received_events",
"repos_url": "https://api.github.com/users/RuudBurger/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RuudBurger",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2084/reactions"
} | https://api.github.com/repos/psf/requests/issues/2084/timeline | null | completed | null | null | false | [
"It's not entirely clear what you want here. You want to verify the certificate, but then continue even if the certificate is invalid?\n",
"Yeah, I just need to catch the error. Like a browser does, saying \"maybe not safe, do you want to continue\".\n",
"In the cases you're talking about they're clearly using ... |
https://api.github.com/repos/psf/requests/issues/2083 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2083/labels{/name} | https://api.github.com/repos/psf/requests/issues/2083/comments | https://api.github.com/repos/psf/requests/issues/2083/events | https://github.com/psf/requests/issues/2083 | 34,827,947 | MDU6SXNzdWUzNDgyNzk0Nw== | 2,083 | Sending cookies even though I specify None | {
"avatar_url": "https://avatars.githubusercontent.com/u/1095574?v=4",
"events_url": "https://api.github.com/users/JakeAustwick/events{/privacy}",
"followers_url": "https://api.github.com/users/JakeAustwick/followers",
"following_url": "https://api.github.com/users/JakeAustwick/following{/other_user}",
"gists_url": "https://api.github.com/users/JakeAustwick/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JakeAustwick",
"id": 1095574,
"login": "JakeAustwick",
"node_id": "MDQ6VXNlcjEwOTU1NzQ=",
"organizations_url": "https://api.github.com/users/JakeAustwick/orgs",
"received_events_url": "https://api.github.com/users/JakeAustwick/received_events",
"repos_url": "https://api.github.com/users/JakeAustwick/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JakeAustwick/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JakeAustwick/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JakeAustwick",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-06-03T02:43:17Z | 2021-09-08T23:11:04Z | 2014-06-03T14:25:33Z | NONE | resolved | Sorry if this is a stupid question, but I _think_ it could be a bug. Is there any reason requests is sending cookies with this request?
``````
>>> headers = {'Cookie': None}
>>> r = requests.get('http://www.linkedin.com/in/xxx/', headers=headers)
>>> print r.request.headers
CaseInsensitiveDict({'Accept-Language': 'en-US,en;q=0.8', 'Cookie': 'bcookie="v=2&49d15313-08b9-45e7-894f-8f5c76614c04"; lidc="b=VB61:g=66:u=1:i=1401763223:t=1401849623:s=1820628467"; moflow_session_id=1465875475464192', 'Accept-Encoding': 'gzip, deflate, compress', 'Accept': '*/*', 'User-Agent': 'Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit/537.51.2 (KHTML, like Gecko) Version/7.0 Mobile/11D167 Safari/9537.53'})```
``````
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1095574?v=4",
"events_url": "https://api.github.com/users/JakeAustwick/events{/privacy}",
"followers_url": "https://api.github.com/users/JakeAustwick/followers",
"following_url": "https://api.github.com/users/JakeAustwick/following{/other_user}",
"gists_url": "https://api.github.com/users/JakeAustwick/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JakeAustwick",
"id": 1095574,
"login": "JakeAustwick",
"node_id": "MDQ6VXNlcjEwOTU1NzQ=",
"organizations_url": "https://api.github.com/users/JakeAustwick/orgs",
"received_events_url": "https://api.github.com/users/JakeAustwick/received_events",
"repos_url": "https://api.github.com/users/JakeAustwick/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JakeAustwick/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JakeAustwick/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JakeAustwick",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2083/reactions"
} | https://api.github.com/repos/psf/requests/issues/2083/timeline | null | completed | null | null | false | [
"The change in UA is to do with some other unrelated code, unrelated to cookies; just to be sure:\n\n```\nclass Session(requests.sessions.Session):\n def __init__(self, *args, **kwargs):\n super(Session, self).__init__(*args, **kwargs)\n self.headers['Accept-Language'] = 'en-US,en;q=0.8'\n\n ... |
https://api.github.com/repos/psf/requests/issues/2082 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2082/labels{/name} | https://api.github.com/repos/psf/requests/issues/2082/comments | https://api.github.com/repos/psf/requests/issues/2082/events | https://github.com/psf/requests/issues/2082 | 34,795,583 | MDU6SXNzdWUzNDc5NTU4Mw== | 2,082 | Add HTTP 2.0 support | {
"avatar_url": "https://avatars.githubusercontent.com/u/772?v=4",
"events_url": "https://api.github.com/users/alex/events{/privacy}",
"followers_url": "https://api.github.com/users/alex/followers",
"following_url": "https://api.github.com/users/alex/following{/other_user}",
"gists_url": "https://api.github.com/users/alex/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alex",
"id": 772,
"login": "alex",
"node_id": "MDQ6VXNlcjc3Mg==",
"organizations_url": "https://api.github.com/users/alex/orgs",
"received_events_url": "https://api.github.com/users/alex/received_events",
"repos_url": "https://api.github.com/users/alex/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alex/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alex/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alex",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "e102d8",
"default": false,
"description": null... | closed | true | null | [] | null | 3 | 2014-06-02T17:50:17Z | 2021-09-08T23:10:52Z | 2014-07-07T16:13:33Z | MEMBER | resolved | It would be great if requests could make HTTP 2.0 requests.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2082/reactions"
} | https://api.github.com/repos/psf/requests/issues/2082/timeline | null | completed | null | null | false | [
"It can: http://hyper.readthedocs.org/en/development/quickstart.html#requests-integration\n",
"As a follow-on, I want hyper to be added to urllib3, which is being tracked in Lukasa/hyper#18. This'll give requests transparent HTTP/2 support.\n",
"Awesome, thanks.\n\nOn Mon, Jun 2, 2014 at 10:54 AM, Cory Benfield... |
https://api.github.com/repos/psf/requests/issues/2081 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2081/labels{/name} | https://api.github.com/repos/psf/requests/issues/2081/comments | https://api.github.com/repos/psf/requests/issues/2081/events | https://github.com/psf/requests/issues/2081 | 34,770,233 | MDU6SXNzdWUzNDc3MDIzMw== | 2,081 | Sometimes Requests doesn't handle properly domains encoded in Cyrillic | {
"avatar_url": "https://avatars.githubusercontent.com/u/312759?v=4",
"events_url": "https://api.github.com/users/ntoshev/events{/privacy}",
"followers_url": "https://api.github.com/users/ntoshev/followers",
"following_url": "https://api.github.com/users/ntoshev/following{/other_user}",
"gists_url": "https://api.github.com/users/ntoshev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ntoshev",
"id": 312759,
"login": "ntoshev",
"node_id": "MDQ6VXNlcjMxMjc1OQ==",
"organizations_url": "https://api.github.com/users/ntoshev/orgs",
"received_events_url": "https://api.github.com/users/ntoshev/received_events",
"repos_url": "https://api.github.com/users/ntoshev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ntoshev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ntoshev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ntoshev",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-06-02T13:02:04Z | 2021-09-08T23:11:03Z | 2014-06-03T14:57:40Z | NONE | resolved | The domain gets URL-encoded:
``` python
>>> r=requests.get(u'http://www.тв-програма.bg')
>>> r.status_code
200
>>> requests.get(u'http://www.тв-програма.bg/predavane/%D0%95%D0%BA%D1%81%D0%BF%D0%B5%D0%B4%D0%B8%D1%86%D0%B8%D0%B8%D1%82%D0%B5-%D0%BD%D0%B0-%D0%94%D0%B6%D0%B5%D1%84-%D0%9A%D0%BE%D1%80%D1%83%D0%B8%D0%BD,1771305311//')
Traceback (most recent call last):
File "<pyshell#20>", line 1, in <module>
requests.get(u'http://www.тв-програма.bg/predavane/%D0%95%D0%BA%D1%81%D0%BF%D0%B5%D0%B4%D0%B8%D1%86%D0%B8%D0%B8%D1%82%D0%B5-%D0%BD%D0%B0-%D0%94%D0%B6%D0%B5%D1%84-%D0%9A%D0%BE%D1%80%D1%83%D0%B8%D0%BD,1771305311//')
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 456, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 585, in send
history = [resp for resp in gen] if allow_redirects else []
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 179, in resolve_redirects
allow_redirects=False,
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 559, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 375, in send
raise ConnectionError(e, request=request)
ConnectionError: HTTPConnectionPool(host='www.%D1%82%D0%B2-%D0%BF%D1%80%D0%BE%D0%B3%D1%80%D0%B0%D0%BC%D0%B0.bg', port=80): Max retries exceeded with url: /predavane/%D0%95%D0%BA%D1%81%D0%BF%D0%B5%D0%B4%D0%B8%D1%86%D0%B8%D0%B8%D1%82%D0%B5-%D0%BD%D0%B0-%D0%94%D0%B6%D0%B5%D1%84-%D0%9A%D0%BE%D1%80%D1%83%D0%B8%D0%BD,1771305311/ (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)
```
That URL appears in a webpage when crawling, and it works when pasted in a browser.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2081/reactions"
} | https://api.github.com/repos/psf/requests/issues/2081/timeline | null | completed | null | null | false | [
"I think you've misidentified the problem. Judging by your first request, we're treating the domain name just fine (and by debugging into the request logic, both requests domains are treated exactly the same). I visited the URL that causes the connection error and my browser tells me that it cannot find the server.... |
https://api.github.com/repos/psf/requests/issues/2080 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2080/labels{/name} | https://api.github.com/repos/psf/requests/issues/2080/comments | https://api.github.com/repos/psf/requests/issues/2080/events | https://github.com/psf/requests/issues/2080 | 34,768,482 | MDU6SXNzdWUzNDc2ODQ4Mg== | 2,080 | Cookie deletion test missing | {
"avatar_url": "https://avatars.githubusercontent.com/u/410452?v=4",
"events_url": "https://api.github.com/users/sylvinus/events{/privacy}",
"followers_url": "https://api.github.com/users/sylvinus/followers",
"following_url": "https://api.github.com/users/sylvinus/following{/other_user}",
"gists_url": "https://api.github.com/users/sylvinus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sylvinus",
"id": 410452,
"login": "sylvinus",
"node_id": "MDQ6VXNlcjQxMDQ1Mg==",
"organizations_url": "https://api.github.com/users/sylvinus/orgs",
"received_events_url": "https://api.github.com/users/sylvinus/received_events",
"repos_url": "https://api.github.com/users/sylvinus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sylvinus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sylvinus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sylvinus",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-06-02T12:37:12Z | 2021-09-08T23:11:04Z | 2014-06-03T14:56:52Z | NONE | resolved | Hello!
I _think_ Cookie deletion (servers sending "Set-Cookie: name=;") is not working in requests. I don't see any tests using "/cookies/delete?name" from httpbin so it may not be tested yet?
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2080/reactions"
} | https://api.github.com/repos/psf/requests/issues/2080/timeline | null | completed | null | null | false | [
"@sylvinus 100% of that level of cookie handling is handled by the standard library (cookielib). We simply implement a few extra methods on top of the standard Cookie Jar.\n\nA quick test shows that this does work as expected:\n\n``` pycon\n>>> import requests\n>>> s = requests.Session()\n>>> s.get('https://httpbin... |
https://api.github.com/repos/psf/requests/issues/2079 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2079/labels{/name} | https://api.github.com/repos/psf/requests/issues/2079/comments | https://api.github.com/repos/psf/requests/issues/2079/events | https://github.com/psf/requests/issues/2079 | 34,734,790 | MDU6SXNzdWUzNDczNDc5MA== | 2,079 | requests.Session should send "Referer" headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/1210845?v=4",
"events_url": "https://api.github.com/users/za-creature/events{/privacy}",
"followers_url": "https://api.github.com/users/za-creature/followers",
"following_url": "https://api.github.com/users/za-creature/following{/other_user}",
"gists_url": "https://api.github.com/users/za-creature/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/za-creature",
"id": 1210845,
"login": "za-creature",
"node_id": "MDQ6VXNlcjEyMTA4NDU=",
"organizations_url": "https://api.github.com/users/za-creature/orgs",
"received_events_url": "https://api.github.com/users/za-creature/received_events",
"repos_url": "https://api.github.com/users/za-creature/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/za-creature/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/za-creature/subscriptions",
"type": "User",
"url": "https://api.github.com/users/za-creature",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-06-01T19:22:13Z | 2021-09-08T23:11:05Z | 2014-06-01T20:28:49Z | NONE | resolved | From my understanding, the point of requests.Session is that it emulates what a dumb\* browser does when asked to render a webpage. This means keeping cookies, following redirects and in my opinion, setting the HTTP "Referer" header.
The Session class doesn't seem to touch neither the referer header nor it's properly spelled variant. I consider this to be non-pythonic because both the documentation as well as the "Session" class name suggest that all requests in a session are performed sequentially, and each individual request may update the state of the session by setting cookies, or by returning 3xx responses which in turn forward the session to a different URL.
As such, I propose setting a default value for the "referer" header (perhaps setting the properly spelled "referrer" header as well for future-proofing) to the final form of the most recently executed request. This seems to be consistent with the way cookies are handled in that performing a request will automatically parse and update any cookies in the jar. Since this will break backwards compatibility (for a few servers, an undefined referrer is better than a wrong one), this should probably be implemented pending a check to Session.follow_referrer which should default to False.
I can create a patch for this if the package maintainer agrees that this is a bug.
- By dumb I mean a browser incapable of rendering images, executing scripts or handling stylesheets and limited to just parsing and rendering HTML, which is arguably what most robots do.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1210845?v=4",
"events_url": "https://api.github.com/users/za-creature/events{/privacy}",
"followers_url": "https://api.github.com/users/za-creature/followers",
"following_url": "https://api.github.com/users/za-creature/following{/other_user}",
"gists_url": "https://api.github.com/users/za-creature/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/za-creature",
"id": 1210845,
"login": "za-creature",
"node_id": "MDQ6VXNlcjEyMTA4NDU=",
"organizations_url": "https://api.github.com/users/za-creature/orgs",
"received_events_url": "https://api.github.com/users/za-creature/received_events",
"repos_url": "https://api.github.com/users/za-creature/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/za-creature/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/za-creature/subscriptions",
"type": "User",
"url": "https://api.github.com/users/za-creature",
"user_view_type": "public"
} | {
"+1": 5,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 3,
"laugh": 0,
"rocket": 0,
"total_count": 8,
"url": "https://api.github.com/repos/psf/requests/issues/2079/reactions"
} | https://api.github.com/repos/psf/requests/issues/2079/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nThis is an interesting idea. The key problem is that it's difficult for requests to correctly fill out the Referer header. From RFC 2616:\n\n> The Referer[sic] request-header field allows the client to specify, for the server's benefit, the address (URI) of the resource from which... |
https://api.github.com/repos/psf/requests/issues/2078 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2078/labels{/name} | https://api.github.com/repos/psf/requests/issues/2078/comments | https://api.github.com/repos/psf/requests/issues/2078/events | https://github.com/psf/requests/pull/2078 | 34,663,803 | MDExOlB1bGxSZXF1ZXN0MTY1NDM5NzM= | 2,078 | Allow copying of PreparedRequests without headers/cookies | {
"avatar_url": "https://avatars.githubusercontent.com/u/55577?v=4",
"events_url": "https://api.github.com/users/dgouldin/events{/privacy}",
"followers_url": "https://api.github.com/users/dgouldin/followers",
"following_url": "https://api.github.com/users/dgouldin/following{/other_user}",
"gists_url": "https://api.github.com/users/dgouldin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dgouldin",
"id": 55577,
"login": "dgouldin",
"node_id": "MDQ6VXNlcjU1NTc3",
"organizations_url": "https://api.github.com/users/dgouldin/orgs",
"received_events_url": "https://api.github.com/users/dgouldin/received_events",
"repos_url": "https://api.github.com/users/dgouldin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dgouldin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dgouldin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dgouldin",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-30T17:13:51Z | 2021-09-09T00:01:16Z | 2014-05-30T17:33:29Z | NONE | resolved | Fixes #2077.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2078/reactions"
} | https://api.github.com/repos/psf/requests/issues/2078/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2078.diff",
"html_url": "https://github.com/psf/requests/pull/2078",
"merged_at": "2014-05-30T17:33:29Z",
"patch_url": "https://github.com/psf/requests/pull/2078.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2078"
} | true | [
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2077 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2077/labels{/name} | https://api.github.com/repos/psf/requests/issues/2077/comments | https://api.github.com/repos/psf/requests/issues/2077/events | https://github.com/psf/requests/issues/2077 | 34,661,962 | MDU6SXNzdWUzNDY2MTk2Mg== | 2,077 | PreparedRequest.copy fails if headers or _cookies are None | {
"avatar_url": "https://avatars.githubusercontent.com/u/55577?v=4",
"events_url": "https://api.github.com/users/dgouldin/events{/privacy}",
"followers_url": "https://api.github.com/users/dgouldin/followers",
"following_url": "https://api.github.com/users/dgouldin/following{/other_user}",
"gists_url": "https://api.github.com/users/dgouldin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dgouldin",
"id": 55577,
"login": "dgouldin",
"node_id": "MDQ6VXNlcjU1NTc3",
"organizations_url": "https://api.github.com/users/dgouldin/orgs",
"received_events_url": "https://api.github.com/users/dgouldin/received_events",
"repos_url": "https://api.github.com/users/dgouldin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dgouldin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dgouldin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dgouldin",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-05-30T16:48:40Z | 2021-09-08T23:11:05Z | 2014-05-30T17:33:29Z | NONE | resolved | Try the following:
```
from requests import PreparedRequest
PreparedRequest().copy()
```
It will raise `AttributeError: 'NoneType' object has no attribute 'copy'` because `self.headers` is `None`. The same will happen on `_cookies` if `headers` isn't `None`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2077/reactions"
} | https://api.github.com/repos/psf/requests/issues/2077/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/2076 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2076/labels{/name} | https://api.github.com/repos/psf/requests/issues/2076/comments | https://api.github.com/repos/psf/requests/issues/2076/events | https://github.com/psf/requests/pull/2076 | 34,595,954 | MDExOlB1bGxSZXF1ZXN0MTY4NjE2NjQ= | 2,076 | Basic Auth handler sets unicode header value on Python 2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-05-29T21:36:59Z | 2021-09-09T00:01:17Z | 2014-06-09T14:53:23Z | MEMBER | resolved | Observe:
``` python
>>> import requests
>>> requests.__version__
'2.3.0'
>>> r = requests.Request('GET', 'http://www.google.com/', auth=('user', 'pass'))
>>> p = r.prepare()
>>> p.headers['Authorization']
u'Basic dXNlcjpwYXNz'
```
This is wrong: all header keys and values should be native strings. Easily fixed though. =)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2076/reactions"
} | https://api.github.com/repos/psf/requests/issues/2076/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2076.diff",
"html_url": "https://github.com/psf/requests/pull/2076",
"merged_at": "2014-06-09T14:53:23Z",
"patch_url": "https://github.com/psf/requests/pull/2076.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2076"
} | true | [
"Interesting...\n",
"Alright, fix is now attached.\n",
":cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2075 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2075/labels{/name} | https://api.github.com/repos/psf/requests/issues/2075/comments | https://api.github.com/repos/psf/requests/issues/2075/events | https://github.com/psf/requests/issues/2075 | 34,595,020 | MDU6SXNzdWUzNDU5NTAyMA== | 2,075 | How to run app on Windows? | {
"avatar_url": "https://avatars.githubusercontent.com/u/105314?v=4",
"events_url": "https://api.github.com/users/hickford/events{/privacy}",
"followers_url": "https://api.github.com/users/hickford/followers",
"following_url": "https://api.github.com/users/hickford/following{/other_user}",
"gists_url": "https://api.github.com/users/hickford/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hickford",
"id": 105314,
"login": "hickford",
"node_id": "MDQ6VXNlcjEwNTMxNA==",
"organizations_url": "https://api.github.com/users/hickford/orgs",
"received_events_url": "https://api.github.com/users/hickford/received_events",
"repos_url": "https://api.github.com/users/hickford/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hickford/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hickford/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hickford",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-05-29T21:26:40Z | 2021-09-08T23:11:05Z | 2014-05-29T21:31:21Z | NONE | resolved | How to run the Flask app on Windows? (I want to test my fork)
Following the `Procfile` I first tried `gunicorn httpbin:app -w 6`, but that failed because Gunicorn doesn't run on Windows.
Next I tried `python httpbin/core.py` but that failed too
> Traceback (most recent call last):
> File "httpbin\core.py", line 24, in <module>
> from . import filters
> SystemError: Parent module '' not loaded, cannot perform relative import
Any ideas?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2075/reactions"
} | https://api.github.com/repos/psf/requests/issues/2075/timeline | null | completed | null | null | false | [
"I think you meant to open this on the httpbin repository, not this one. =)\n\nNevertheless, try `python -m httpbin.app`.\n",
"Oops, yes. Thanks, `python -m httpbin.core` worked. What does the `-m` flag do?\n",
"Stack Overflow will explain better than I could: https://stackoverflow.com/questions/7610001/what-is... |
https://api.github.com/repos/psf/requests/issues/2074 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2074/labels{/name} | https://api.github.com/repos/psf/requests/issues/2074/comments | https://api.github.com/repos/psf/requests/issues/2074/events | https://github.com/psf/requests/pull/2074 | 34,480,817 | MDExOlB1bGxSZXF1ZXN0MTY0MzU4NzI= | 2,074 | Ensure that we open files in binary mode in the docs. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-05-28T16:01:06Z | 2021-09-08T23:08:22Z | 2014-05-28T16:01:10Z | MEMBER | resolved | Go go gadget documentation!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2074/reactions"
} | https://api.github.com/repos/psf/requests/issues/2074/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2074.diff",
"html_url": "https://github.com/psf/requests/pull/2074",
"merged_at": "2014-05-28T16:01:10Z",
"patch_url": "https://github.com/psf/requests/pull/2074.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2074"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/2073 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2073/labels{/name} | https://api.github.com/repos/psf/requests/issues/2073/comments | https://api.github.com/repos/psf/requests/issues/2073/events | https://github.com/psf/requests/issues/2073 | 34,467,576 | MDU6SXNzdWUzNDQ2NzU3Ng== | 2,073 | Newline problems in Windows | {
"avatar_url": "https://avatars.githubusercontent.com/u/1845771?v=4",
"events_url": "https://api.github.com/users/edrevo/events{/privacy}",
"followers_url": "https://api.github.com/users/edrevo/followers",
"following_url": "https://api.github.com/users/edrevo/following{/other_user}",
"gists_url": "https://api.github.com/users/edrevo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/edrevo",
"id": 1845771,
"login": "edrevo",
"node_id": "MDQ6VXNlcjE4NDU3NzE=",
"organizations_url": "https://api.github.com/users/edrevo/orgs",
"received_events_url": "https://api.github.com/users/edrevo/received_events",
"repos_url": "https://api.github.com/users/edrevo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/edrevo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/edrevo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/edrevo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-05-28T13:48:55Z | 2021-09-09T00:00:55Z | 2014-05-28T16:01:42Z | NONE | resolved | Calls to `requests.put([...], data=file_obj)` send invalid requests on Windows when `file_obj` is a file object that contains Windows-style newlines (`\r\n`). This does not repro in Mac.
The problem is that the `Content-Length` header is determined through the `super_len` function, which in turn calls `os.fstat(o.fileno()).st_size`. This return value, which comes from the actual file size in the disk, does not need to match the length of the contents that get read through the file object, since Python will perform newline normalization in Windows:
``` python
>>> import os
>>> f = open('test.md') # this file contains Windows-style newlines
>>> f.fileno()
3
>>> os.fstat(3).st_size
4031L
>>> c = f.read(4031)
>>> len(c)
3983
>>> c[:50]
'# Cosmos "Little Joe" (1G) Hardware spec.\n\nThe fir'
```
In Mac, on the other hand, the content is read without newline normalization:
``` python
>>> f = open('test.md') # this file contains Windows-style newlines
>>> c = f.read(4031)
>>> c[:50]
'# Cosmos "Little Joe" (1G) Hardware spec.\r\n\r\nThe f'
```
The consequence of this mismatch is that the HTTP request will have a body which is smaller than what the Content-Length says, so the server will wait for the rest of the content and it will eventually give up.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2073/reactions"
} | https://api.github.com/repos/psf/requests/issues/2073/timeline | null | completed | null | null | false | [
"You can repro this on a Mac by forcing Python to normalize newlines through the `'U'` file mode (https://docs.python.org/2/library/functions.html#open): `open('test.md', 'rU')`\n",
"Thanks for raising this issue!\n\nThis is not entirely surprising: you've not passed Requests the file in its on-disk form. Instead... |
https://api.github.com/repos/psf/requests/issues/2072 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2072/labels{/name} | https://api.github.com/repos/psf/requests/issues/2072/comments | https://api.github.com/repos/psf/requests/issues/2072/events | https://github.com/psf/requests/pull/2072 | 34,428,077 | MDExOlB1bGxSZXF1ZXN0MTY0MDU1NjI= | 2,072 | Check for basestring, not just str | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 5 | 2014-05-28T01:31:31Z | 2021-09-08T23:10:54Z | 2014-05-29T14:39:42Z | CONTRIBUTOR | resolved | Fixes #2071
This provides consistent behaviour across Python 2 & 3.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2072/reactions"
} | https://api.github.com/repos/psf/requests/issues/2072/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2072.diff",
"html_url": "https://github.com/psf/requests/pull/2072",
"merged_at": "2014-05-29T14:39:42Z",
"patch_url": "https://github.com/psf/requests/pull/2072.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2072"
} | true | [
"Nice.\n\nWith this change we shouldn't need the `builtin_str` clause anymore, so we may as well remove it while we're here. =)\n",
"@Lukasa fixed in 5ab79e2\n",
"Hurrah! LGTM. :shipit:\n",
":cake:\n",
":sparkles: \n"
] |
https://api.github.com/repos/psf/requests/issues/2071 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2071/labels{/name} | https://api.github.com/repos/psf/requests/issues/2071/comments | https://api.github.com/repos/psf/requests/issues/2071/events | https://github.com/psf/requests/issues/2071 | 34,417,663 | MDU6SXNzdWUzNDQxNzY2Mw== | 2,071 | On Python 3, sending bytes automatically choses 'x-www-form-urlencoded' as the content_type | {
"avatar_url": "https://avatars.githubusercontent.com/u/13807?v=4",
"events_url": "https://api.github.com/users/miracle2k/events{/privacy}",
"followers_url": "https://api.github.com/users/miracle2k/followers",
"following_url": "https://api.github.com/users/miracle2k/following{/other_user}",
"gists_url": "https://api.github.com/users/miracle2k/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/miracle2k",
"id": 13807,
"login": "miracle2k",
"node_id": "MDQ6VXNlcjEzODA3",
"organizations_url": "https://api.github.com/users/miracle2k/orgs",
"received_events_url": "https://api.github.com/users/miracle2k/received_events",
"repos_url": "https://api.github.com/users/miracle2k/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/miracle2k/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miracle2k/subscriptions",
"type": "User",
"url": "https://api.github.com/users/miracle2k",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-27T22:05:54Z | 2021-09-09T00:00:54Z | 2014-05-29T14:39:42Z | NONE | resolved | Is this on purpose. I would have assumed bytes to mean "send this unknown chunk of data as-is".
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2071/reactions"
} | https://api.github.com/repos/psf/requests/issues/2071/timeline | null | completed | null | null | false | [
"@Lukasa this is the actual behaviour. I tested on Python 2 and 3 and this only happens on Python 3 due to [these lines](https://github.com/kennethreitz/requests/blob/6c72509f5bb0e9cd8fad64a44ba99687ed044771/requests/models.py#L434..L439) I'm pretty sure we don't want this behaviour by default. I'm going to work on... |
https://api.github.com/repos/psf/requests/issues/2070 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2070/labels{/name} | https://api.github.com/repos/psf/requests/issues/2070/comments | https://api.github.com/repos/psf/requests/issues/2070/events | https://github.com/psf/requests/issues/2070 | 34,402,903 | MDU6SXNzdWUzNDQwMjkwMw== | 2,070 | Surface socket connection time | {
"avatar_url": "https://avatars.githubusercontent.com/u/455202?v=4",
"events_url": "https://api.github.com/users/vjyanand/events{/privacy}",
"followers_url": "https://api.github.com/users/vjyanand/followers",
"following_url": "https://api.github.com/users/vjyanand/following{/other_user}",
"gists_url": "https://api.github.com/users/vjyanand/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vjyanand",
"id": 455202,
"login": "vjyanand",
"node_id": "MDQ6VXNlcjQ1NTIwMg==",
"organizations_url": "https://api.github.com/users/vjyanand/orgs",
"received_events_url": "https://api.github.com/users/vjyanand/received_events",
"repos_url": "https://api.github.com/users/vjyanand/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vjyanand/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vjyanand/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vjyanand",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-27T19:06:22Z | 2021-09-09T00:00:56Z | 2014-05-27T19:07:41Z | NONE | resolved | Is there a way to get actual time taken for socket.create_connection https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/connection.py#L89-L92 in requests object
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2070/reactions"
} | https://api.github.com/repos/psf/requests/issues/2070/timeline | null | completed | null | null | false | [
"Nope. =) You can try to get those diagnostics either by profiling a single run of the code using cprofile or monkeypatching. =)\n"
] |
https://api.github.com/repos/psf/requests/issues/2069 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2069/labels{/name} | https://api.github.com/repos/psf/requests/issues/2069/comments | https://api.github.com/repos/psf/requests/issues/2069/events | https://github.com/psf/requests/pull/2069 | 34,315,762 | MDExOlB1bGxSZXF1ZXN0MTYzNDEwNzA= | 2,069 | Document and initialise Response.request | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 3 | 2014-05-26T15:41:47Z | 2021-09-08T23:05:08Z | 2014-05-27T15:11:21Z | MEMBER | resolved | In response to #2066. Weirdly, we weren't initialising the `.request` property in the constructor. Nothing terrible there, but we need to do it to get it documented, so let's do it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2069/reactions"
} | https://api.github.com/repos/psf/requests/issues/2069/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2069.diff",
"html_url": "https://github.com/psf/requests/pull/2069",
"merged_at": "2014-05-27T15:11:21Z",
"patch_url": "https://github.com/psf/requests/pull/2069.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2069"
} | true | [
":clap: \n",
"If this were only a documentation change I'd be pressing \"Merge\" right now. :+1: :shipit: \n",
"Haha! I can't believe we haven't done this before :)\n\n:cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2068 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2068/labels{/name} | https://api.github.com/repos/psf/requests/issues/2068/comments | https://api.github.com/repos/psf/requests/issues/2068/events | https://github.com/psf/requests/issues/2068 | 34,306,339 | MDU6SXNzdWUzNDMwNjMzOQ== | 2,068 | Define DNS used to resolve domain in request (suggestion) | {
"avatar_url": "https://avatars.githubusercontent.com/u/2188047?v=4",
"events_url": "https://api.github.com/users/SigmundTannhauser/events{/privacy}",
"followers_url": "https://api.github.com/users/SigmundTannhauser/followers",
"following_url": "https://api.github.com/users/SigmundTannhauser/following{/other_user}",
"gists_url": "https://api.github.com/users/SigmundTannhauser/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/SigmundTannhauser",
"id": 2188047,
"login": "SigmundTannhauser",
"node_id": "MDQ6VXNlcjIxODgwNDc=",
"organizations_url": "https://api.github.com/users/SigmundTannhauser/orgs",
"received_events_url": "https://api.github.com/users/SigmundTannhauser/received_events",
"repos_url": "https://api.github.com/users/SigmundTannhauser/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/SigmundTannhauser/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/SigmundTannhauser/subscriptions",
"type": "User",
"url": "https://api.github.com/users/SigmundTannhauser",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-05-26T13:08:44Z | 2021-09-09T00:00:55Z | 2014-05-26T13:45:00Z | NONE | resolved | For example:
```
req = requests.post('https://'+self.server+'/'+method,
data=json.dumps(kwargs),
cert=self.certs,
verify=self.verify,
headers={'content-type': 'application/json' },
dns=85.86.87.88
)
```
This could be practical if requests are used (for example) in test suite which connects to more than one test environment, and each environment has its own DNS (code cannot rely on the DNS defined in the connection properities, /etc/hosts and so on.
At the moment connection must be patched at a lower level to achieve this, and in the end it takes less code when I use socket + ssl instead of requests (in the whole project).
I am aware that this use is not very, but it may be useful in the future.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2068/reactions"
} | https://api.github.com/repos/psf/requests/issues/2068/timeline | null | completed | null | null | false | [
"Thanks for the suggestion!\n\nUnfortunately, this is not something we're going to accept. We've got the requests API in feature freeze, as we believe that the 90% use-case is covered. We won't accept extensions to the API unless we think it's going to be generally useful, and I don't believe that this will be.\n\n... |
https://api.github.com/repos/psf/requests/issues/2067 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2067/labels{/name} | https://api.github.com/repos/psf/requests/issues/2067/comments | https://api.github.com/repos/psf/requests/issues/2067/events | https://github.com/psf/requests/pull/2067 | 34,299,094 | MDExOlB1bGxSZXF1ZXN0MTYzMzEyOTE= | 2,067 | Add a data param to the delete request | {
"avatar_url": "https://avatars.githubusercontent.com/u/1322166?v=4",
"events_url": "https://api.github.com/users/khamaileon/events{/privacy}",
"followers_url": "https://api.github.com/users/khamaileon/followers",
"following_url": "https://api.github.com/users/khamaileon/following{/other_user}",
"gists_url": "https://api.github.com/users/khamaileon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/khamaileon",
"id": 1322166,
"login": "khamaileon",
"node_id": "MDQ6VXNlcjEzMjIxNjY=",
"organizations_url": "https://api.github.com/users/khamaileon/orgs",
"received_events_url": "https://api.github.com/users/khamaileon/received_events",
"repos_url": "https://api.github.com/users/khamaileon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/khamaileon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/khamaileon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/khamaileon",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-26T10:50:31Z | 2021-09-08T23:05:19Z | 2014-05-26T12:37:07Z | NONE | resolved | In the case of a bulk delete operation, it would be useful to have a "data" parameter to send the ids of objects to delete.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2067/reactions"
} | https://api.github.com/repos/psf/requests/issues/2067/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2067.diff",
"html_url": "https://github.com/psf/requests/pull/2067",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2067.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2067"
} | true | [
"Thanks for this!\n\nHowever, there's no need for it. All requests _can_ take a `data` parameter, regardless of their verb. `post` is the only one that mandates it.\n"
] |
https://api.github.com/repos/psf/requests/issues/2066 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2066/labels{/name} | https://api.github.com/repos/psf/requests/issues/2066/comments | https://api.github.com/repos/psf/requests/issues/2066/events | https://github.com/psf/requests/issues/2066 | 34,276,429 | MDU6SXNzdWUzNDI3NjQyOQ== | 2,066 | Allow override of Authorization header in request | {
"avatar_url": "https://avatars.githubusercontent.com/u/58730?v=4",
"events_url": "https://api.github.com/users/migurski/events{/privacy}",
"followers_url": "https://api.github.com/users/migurski/followers",
"following_url": "https://api.github.com/users/migurski/following{/other_user}",
"gists_url": "https://api.github.com/users/migurski/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/migurski",
"id": 58730,
"login": "migurski",
"node_id": "MDQ6VXNlcjU4NzMw",
"organizations_url": "https://api.github.com/users/migurski/orgs",
"received_events_url": "https://api.github.com/users/migurski/received_events",
"repos_url": "https://api.github.com/users/migurski/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/migurski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/migurski/subscriptions",
"type": "User",
"url": "https://api.github.com/users/migurski",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-05-26T00:46:29Z | 2021-09-09T00:00:56Z | 2014-05-26T14:24:24Z | NONE | resolved | I have encountered a situation similar to #927.
I am creating a new request with an explicit `Authorization` header, e.g.
```
posted = post('…', headers={'Authorization': '…'}, data=…)
```
Requests is finding and using an entry from a `.netrc` file I didn’t know existed; it appears to have been generated by the Heroku toolbelt. This overrides the Authorization header supplied in the `headers` dictionary.
Can the default behavior instead allow environmental factors to be overridden?
Also, can requests make this behavior in some way easier to discover? I am unable to find a way to retrieve the request headers actually sent; they would have provided a valuable clue about the mystery username & password.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2066/reactions"
} | https://api.github.com/repos/psf/requests/issues/2066/timeline | null | completed | null | null | false | [
"Both of these problems in this case have solutions. To avoid using `.netrc`, use a `Session` and set `Session.trust_env` to `False`. To see what headers were sent _by requests_ (noting that the lower layers may add more), check `response.request.headers`.\n",
"This is a duplicate of #2062 and as such, I'm closin... |
https://api.github.com/repos/psf/requests/issues/2065 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2065/labels{/name} | https://api.github.com/repos/psf/requests/issues/2065/comments | https://api.github.com/repos/psf/requests/issues/2065/events | https://github.com/psf/requests/pull/2065 | 34,274,819 | MDExOlB1bGxSZXF1ZXN0MTYzMTgyNTk= | 2,065 | Fix Python 3.2 compatibility in tests | {
"avatar_url": "https://avatars.githubusercontent.com/u/89623?v=4",
"events_url": "https://api.github.com/users/mgeisler/events{/privacy}",
"followers_url": "https://api.github.com/users/mgeisler/followers",
"following_url": "https://api.github.com/users/mgeisler/following{/other_user}",
"gists_url": "https://api.github.com/users/mgeisler/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mgeisler",
"id": 89623,
"login": "mgeisler",
"node_id": "MDQ6VXNlcjg5NjIz",
"organizations_url": "https://api.github.com/users/mgeisler/orgs",
"received_events_url": "https://api.github.com/users/mgeisler/received_events",
"repos_url": "https://api.github.com/users/mgeisler/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mgeisler/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mgeisler/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mgeisler",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 4 | 2014-05-25T23:00:11Z | 2021-09-08T23:10:56Z | 2014-05-27T15:24:47Z | CONTRIBUTOR | resolved | The FAQ says that requests is compatible with Python 3.2. However, I could not execute the tests using that Python version. This PR fixes this and updated the FAQ to match.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2065/reactions"
} | https://api.github.com/repos/psf/requests/issues/2065/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2065.diff",
"html_url": "https://github.com/psf/requests/pull/2065",
"merged_at": "2014-05-27T15:24:47Z",
"patch_url": "https://github.com/psf/requests/pull/2065.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2065"
} | true | [
"I should have mentioned this above: I noticed that `tox.ini` was added to `.gitignore` in 7e825acd9b730632623984f14cd0f3f2c0cbf45f. I guess the author of that commit used `tox` himself to run the test suite when he decided to remove Python 3.1 and 3.2 from the trove classifiers.\n\nIf `tox` itself is unwanted, the... |
https://api.github.com/repos/psf/requests/issues/2064 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2064/labels{/name} | https://api.github.com/repos/psf/requests/issues/2064/comments | https://api.github.com/repos/psf/requests/issues/2064/events | https://github.com/psf/requests/pull/2064 | 34,274,778 | MDExOlB1bGxSZXF1ZXN0MTYzMTgyNDE= | 2,064 | compat: handle SyntaxError when importing simplejson | {
"avatar_url": "https://avatars.githubusercontent.com/u/89623?v=4",
"events_url": "https://api.github.com/users/mgeisler/events{/privacy}",
"followers_url": "https://api.github.com/users/mgeisler/followers",
"following_url": "https://api.github.com/users/mgeisler/following{/other_user}",
"gists_url": "https://api.github.com/users/mgeisler/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mgeisler",
"id": 89623,
"login": "mgeisler",
"node_id": "MDQ6VXNlcjg5NjIz",
"organizations_url": "https://api.github.com/users/mgeisler/orgs",
"received_events_url": "https://api.github.com/users/mgeisler/received_events",
"repos_url": "https://api.github.com/users/mgeisler/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mgeisler/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mgeisler/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mgeisler",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 10 | 2014-05-25T22:57:50Z | 2021-09-08T23:07:21Z | 2014-05-27T15:25:54Z | CONTRIBUTOR | resolved | We officially support Python 2.6 to 3.3, but simplejson does not
support Python 3.1 or 3.2:
https://github.com/simplejson/simplejson/issues/66
Importing simplejson on Python 3.2 results in a SyntaxError because
simplejson uses the u'...' syntax (the syntax was not supported in
Python 3.0 to 3.2).
Support for loading simplejson instead of the stdlib json module was
added by #710:
https://github.com/kennethreitz/requests/pull/710
No mention was made of the lack of support for Python 3.2, but it was
mentioned that simplejson can be faster than the stdlib json module.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2064/reactions"
} | https://api.github.com/repos/psf/requests/issues/2064/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2064.diff",
"html_url": "https://github.com/psf/requests/pull/2064",
"merged_at": "2014-05-27T15:25:54Z",
"patch_url": "https://github.com/psf/requests/pull/2064.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2064"
} | true | [
"Thanks, this looks good to me! :cake: I'm not 100% sure it'll get merged, we may drop support for 3.2 soon, but if we don't we'll merge it. \n",
"I ran into this for a project of mine where we try to support Python 3.2. However, it also affects much more significant projects, in particular `pip`. I didn't realiz... |
https://api.github.com/repos/psf/requests/issues/2063 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2063/labels{/name} | https://api.github.com/repos/psf/requests/issues/2063/comments | https://api.github.com/repos/psf/requests/issues/2063/events | https://github.com/psf/requests/issues/2063 | 34,271,303 | MDU6SXNzdWUzNDI3MTMwMw== | 2,063 | Mutating Session.proxies does not work | {
"avatar_url": "https://avatars.githubusercontent.com/u/71486?v=4",
"events_url": "https://api.github.com/users/asmeurer/events{/privacy}",
"followers_url": "https://api.github.com/users/asmeurer/followers",
"following_url": "https://api.github.com/users/asmeurer/following{/other_user}",
"gists_url": "https://api.github.com/users/asmeurer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asmeurer",
"id": 71486,
"login": "asmeurer",
"node_id": "MDQ6VXNlcjcxNDg2",
"organizations_url": "https://api.github.com/users/asmeurer/orgs",
"received_events_url": "https://api.github.com/users/asmeurer/received_events",
"repos_url": "https://api.github.com/users/asmeurer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asmeurer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asmeurer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asmeurer",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 22 | 2014-05-25T19:42:09Z | 2021-09-09T00:00:55Z | 2014-05-28T08:06:33Z | NONE | resolved | This was originally brought up at https://github.com/kennethreitz/requests/issues/2061. If you change `session.proxies` after calling `session.get` and call `session.get` again, it does not use the updated value. You have to do `session.get(proxies=session.proxies)`.
Assumedly this is not difficult to fix, since setting the keyword argument does work. I didn't read the code, though.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2063/reactions"
} | https://api.github.com/repos/psf/requests/issues/2063/timeline | null | completed | null | null | false | [
"OK, I can't reproduce this locally. I made three requests through `mitmproxy`:\n\n``` python\n>>> import requests\n>>> s = requests.Session()\n>>> r = s.get('http://www.google.co.uk/', proxies={'http': 'http://localhost:8080'})\n>>> s.proxies['http'] = 'http://localhost:8080'\n>>> r = s.get('http://www.google.co.u... |
https://api.github.com/repos/psf/requests/issues/2062 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2062/labels{/name} | https://api.github.com/repos/psf/requests/issues/2062/comments | https://api.github.com/repos/psf/requests/issues/2062/events | https://github.com/psf/requests/issues/2062 | 34,239,807 | MDU6SXNzdWUzNDIzOTgwNw== | 2,062 | Default Authentication Overwrites Authentication Header | {
"avatar_url": "https://avatars.githubusercontent.com/u/328806?v=4",
"events_url": "https://api.github.com/users/joe42/events{/privacy}",
"followers_url": "https://api.github.com/users/joe42/followers",
"following_url": "https://api.github.com/users/joe42/following{/other_user}",
"gists_url": "https://api.github.com/users/joe42/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joe42",
"id": 328806,
"login": "joe42",
"node_id": "MDQ6VXNlcjMyODgwNg==",
"organizations_url": "https://api.github.com/users/joe42/orgs",
"received_events_url": "https://api.github.com/users/joe42/received_events",
"repos_url": "https://api.github.com/users/joe42/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joe42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joe42/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joe42",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 19127... | closed | true | null | [] | null | 28 | 2014-05-24T18:34:24Z | 2021-09-08T20:00:53Z | 2015-12-21T18:49:52Z | NONE | resolved | Hi,
And thanks for maintaining requests. When I set an Authorization header in a request, I do not expect it to be overwritten. I set up default credentials in my .netrc file (for automatizing the cadaver command line tool), and suddenly I could not authenticate to my service any longer.
Please check if an Authorization header does already exist in your default authorization handler, instead of overwriting it. I see that you documented this behaviour in the authentication section, but since I never used this form of authentication it took quite some time to find the problem. Also, overwriting a header that the user set does not seem to be a sensible implementation.
Thanks,
Joe
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2062/reactions"
} | https://api.github.com/repos/psf/requests/issues/2062/timeline | null | completed | null | null | false | [
"Hey @joe42 There are several headers we don't expect users to set on their own because they really shouldn't be. If you want to prevent us from overwriting the header you should use the `auth=` parameter to your request. By default it takes a two-tuple (username, and password) or any other Authentication Handler.\... |
https://api.github.com/repos/psf/requests/issues/2061 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2061/labels{/name} | https://api.github.com/repos/psf/requests/issues/2061/comments | https://api.github.com/repos/psf/requests/issues/2061/events | https://github.com/psf/requests/issues/2061 | 34,191,133 | MDU6SXNzdWUzNDE5MTEzMw== | 2,061 | Making https proxies easier to deal with | {
"avatar_url": "https://avatars.githubusercontent.com/u/71486?v=4",
"events_url": "https://api.github.com/users/asmeurer/events{/privacy}",
"followers_url": "https://api.github.com/users/asmeurer/followers",
"following_url": "https://api.github.com/users/asmeurer/following{/other_user}",
"gists_url": "https://api.github.com/users/asmeurer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/asmeurer",
"id": 71486,
"login": "asmeurer",
"node_id": "MDQ6VXNlcjcxNDg2",
"organizations_url": "https://api.github.com/users/asmeurer/orgs",
"received_events_url": "https://api.github.com/users/asmeurer/received_events",
"repos_url": "https://api.github.com/users/asmeurer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/asmeurer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/asmeurer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/asmeurer",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 19 | 2014-05-23T16:35:02Z | 2021-02-28T04:03:09Z | null | NONE | null | I'm trying to add support for proxies to conda, in particular, automatically prompting for a username and password on a 407. For http proxies, it's all fine. I can detect the 407 error code on `HTTPError` from `raise_for_status` and inject `HTTPProxyAuth` and try again.
But for https, it raises `ConnectionError` on `get`. Adding `HTTPProxyAuth` does not work. I have to parse the URL and add it in as `https://username:password@proxy:port`. `urlparse` does not make this particularly easy.
Furthermore, the only way I can tell to actually detect the the `ConnectionError` is a 407 is to do
``` py
try:
# do request
except ConnectionError as e:
if "407" in str(e):
# get username and password
```
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2061/reactions"
} | https://api.github.com/repos/psf/requests/issues/2061/timeline | null | null | null | null | false | [
"This was briefly discussed in IRC, [as seen here](https://botbot.me/freenode/python-requests/2014-05-23/?msg=15109663&page=1). This GitHub issue encompasses a number of problems. Let's enumerate them.\n1. `HTTPProxyAuth` doesn't work for tunneling proxies. Yes, that's true, and that's because tunneling proxies are... |
https://api.github.com/repos/psf/requests/issues/2060 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2060/labels{/name} | https://api.github.com/repos/psf/requests/issues/2060/comments | https://api.github.com/repos/psf/requests/issues/2060/events | https://github.com/psf/requests/issues/2060 | 34,190,639 | MDU6SXNzdWUzNDE5MDYzOQ== | 2,060 | request headers are incomplete | {
"avatar_url": "https://avatars.githubusercontent.com/u/1619869?v=4",
"events_url": "https://api.github.com/users/jacksontj/events{/privacy}",
"followers_url": "https://api.github.com/users/jacksontj/followers",
"following_url": "https://api.github.com/users/jacksontj/following{/other_user}",
"gists_url": "https://api.github.com/users/jacksontj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jacksontj",
"id": 1619869,
"login": "jacksontj",
"node_id": "MDQ6VXNlcjE2MTk4Njk=",
"organizations_url": "https://api.github.com/users/jacksontj/orgs",
"received_events_url": "https://api.github.com/users/jacksontj/received_events",
"repos_url": "https://api.github.com/users/jacksontj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jacksontj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jacksontj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jacksontj",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-23T16:28:32Z | 2021-09-08T23:11:01Z | 2014-06-08T09:49:56Z | NONE | resolved | Requests automatically adds a host header if the user didn't specify one. That header is not set in the request object. Example:
```
>>> import requests
>>> ret = requests.get('http://www.google.com')
>>> ret.request.headers['host']
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python2.7/site-packages/requests/structures.py", line 77, in __getitem__
return self._store[key.lower()][1]
KeyError: 'host'
```
This means that the headers in this object do not actually match what was sent on the wire, which is magic. Inside of poolmanager in _set_proxy_headers the accept and host headers are set, is there some way to make them set in that request object as well?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2060/reactions"
} | https://api.github.com/repos/psf/requests/issues/2060/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nActually, `_set_proxy_headers` is only used when routing via a proxy, and implements custom logic for that case. The section of the code that normally sets these headers is actually down in `httplib`, way down in the standard library.\n\nWe've never guaranteed that the request obj... |
https://api.github.com/repos/psf/requests/issues/2059 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2059/labels{/name} | https://api.github.com/repos/psf/requests/issues/2059/comments | https://api.github.com/repos/psf/requests/issues/2059/events | https://github.com/psf/requests/pull/2059 | 34,187,952 | MDExOlB1bGxSZXF1ZXN0MTYyODA4NDQ= | 2,059 | remove unused IteratorProxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/2245080?v=4",
"events_url": "https://api.github.com/users/jschneier/events{/privacy}",
"followers_url": "https://api.github.com/users/jschneier/followers",
"following_url": "https://api.github.com/users/jschneier/following{/other_user}",
"gists_url": "https://api.github.com/users/jschneier/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jschneier",
"id": 2245080,
"login": "jschneier",
"node_id": "MDQ6VXNlcjIyNDUwODA=",
"organizations_url": "https://api.github.com/users/jschneier/orgs",
"received_events_url": "https://api.github.com/users/jschneier/received_events",
"repos_url": "https://api.github.com/users/jschneier/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jschneier/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jschneier/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jschneier",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-05-23T15:54:58Z | 2021-09-08T23:07:20Z | 2014-05-27T15:28:11Z | CONTRIBUTOR | resolved | It's undocumented, unused and basically uninteresting. It looks like it was added in error in this commit https://github.com/kennethreitz/requests/commit/ef8563ab36c6b52834ee9c35f6f75a424cd9ceef. Or at least the interesting bit was factored out into `super_len`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2059/reactions"
} | https://api.github.com/repos/psf/requests/issues/2059/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2059.diff",
"html_url": "https://github.com/psf/requests/pull/2059",
"merged_at": "2014-05-27T15:28:11Z",
"patch_url": "https://github.com/psf/requests/pull/2059.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2059"
} | true | [
"Yup, that looks unneeded to me. Thanks! :cake:\n",
":+1: \n",
":camel: \n\nNot a cake. I'm sure why.\n"
] |
https://api.github.com/repos/psf/requests/issues/2058 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2058/labels{/name} | https://api.github.com/repos/psf/requests/issues/2058/comments | https://api.github.com/repos/psf/requests/issues/2058/events | https://github.com/psf/requests/pull/2058 | 34,080,256 | MDExOlB1bGxSZXF1ZXN0MTYyMTgzMDE= | 2,058 | Return an instance of dict_class from merge_setting | {
"avatar_url": "https://avatars.githubusercontent.com/u/223831?v=4",
"events_url": "https://api.github.com/users/robgolding/events{/privacy}",
"followers_url": "https://api.github.com/users/robgolding/followers",
"following_url": "https://api.github.com/users/robgolding/following{/other_user}",
"gists_url": "https://api.github.com/users/robgolding/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/robgolding",
"id": 223831,
"login": "robgolding",
"node_id": "MDQ6VXNlcjIyMzgzMQ==",
"organizations_url": "https://api.github.com/users/robgolding/orgs",
"received_events_url": "https://api.github.com/users/robgolding/received_events",
"repos_url": "https://api.github.com/users/robgolding/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/robgolding/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/robgolding/subscriptions",
"type": "User",
"url": "https://api.github.com/users/robgolding",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-22T13:17:43Z | 2021-09-08T23:07:16Z | 2014-05-27T17:09:43Z | NONE | resolved | Proposed solution to #2057
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2058/reactions"
} | https://api.github.com/repos/psf/requests/issues/2058/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2058.diff",
"html_url": "https://github.com/psf/requests/pull/2058",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2058.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2058"
} | true | [
"As discussed in #2057 I'm :-1: on this change.\n",
"I am as well, unfortunately. \n"
] |
https://api.github.com/repos/psf/requests/issues/2057 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2057/labels{/name} | https://api.github.com/repos/psf/requests/issues/2057/comments | https://api.github.com/repos/psf/requests/issues/2057/events | https://github.com/psf/requests/issues/2057 | 34,079,391 | MDU6SXNzdWUzNDA3OTM5MQ== | 2,057 | merge_setting always returns a dict, even if dict_class is set to something else | {
"avatar_url": "https://avatars.githubusercontent.com/u/223831?v=4",
"events_url": "https://api.github.com/users/robgolding/events{/privacy}",
"followers_url": "https://api.github.com/users/robgolding/followers",
"following_url": "https://api.github.com/users/robgolding/following{/other_user}",
"gists_url": "https://api.github.com/users/robgolding/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/robgolding",
"id": 223831,
"login": "robgolding",
"node_id": "MDQ6VXNlcjIyMzgzMQ==",
"organizations_url": "https://api.github.com/users/robgolding/orgs",
"received_events_url": "https://api.github.com/users/robgolding/received_events",
"repos_url": "https://api.github.com/users/robgolding/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/robgolding/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/robgolding/subscriptions",
"type": "User",
"url": "https://api.github.com/users/robgolding",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-05-22T13:06:54Z | 2021-09-08T23:10:46Z | 2014-05-27T19:01:57Z | NONE | resolved | I've been using [responses](https://github.com/dropbox/responses) to test an application using matched URL parameters, which was encountering issues as the `merge_setting` function always returns an unordered `dict` (even though the `dict_class` argument defaults to `OrderedDict`). This means that I can't guarantee which order the URL parameters will be constructed in, so writing a test which responds to a particular URL is difficult.
I'm not sure that the `dict_class` argument was meant to be the class of object that is returned, but making it work that way would seem to make sense. As a workaround, I've set the session object's parameters to `None`, which causes `merge_setting` to return the request's parameters unmodified (which, in my case, are an `OrderedDict`).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2057/reactions"
} | https://api.github.com/repos/psf/requests/issues/2057/timeline | null | completed | null | null | false | [
"I see no reason why this is a use case we should support. You're essentially testing something that should never matter (the ordering of the parameters) - in other words your tests are wrong. \n\nThe best way to write a test for your URL is to parse it after it has been constructed. That sounds like more work but ... |
https://api.github.com/repos/psf/requests/issues/2056 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2056/labels{/name} | https://api.github.com/repos/psf/requests/issues/2056/comments | https://api.github.com/repos/psf/requests/issues/2056/events | https://github.com/psf/requests/issues/2056 | 34,038,555 | MDU6SXNzdWUzNDAzODU1NQ== | 2,056 | SSLError on GAE | {
"avatar_url": "https://avatars.githubusercontent.com/u/122286?v=4",
"events_url": "https://api.github.com/users/lra/events{/privacy}",
"followers_url": "https://api.github.com/users/lra/followers",
"following_url": "https://api.github.com/users/lra/following{/other_user}",
"gists_url": "https://api.github.com/users/lra/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lra",
"id": 122286,
"login": "lra",
"node_id": "MDQ6VXNlcjEyMjI4Ng==",
"organizations_url": "https://api.github.com/users/lra/orgs",
"received_events_url": "https://api.github.com/users/lra/received_events",
"repos_url": "https://api.github.com/users/lra/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lra/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lra/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lra",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] | closed | true | null | [] | null | 4 | 2014-05-21T23:44:27Z | 2021-09-08T09:00:47Z | 2014-05-22T20:21:57Z | NONE | resolved | Hi,
When I try to run this, I get an SSL error:
``` python
import requests
full_url = u'https://qascore.percolate.com/api/pull_request/'
requests.get(url=full_url)
```
```
Traceback (most recent call last):
File "test.py", line 5, in <module>
requests.get(url=full_url)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 456, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 559, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 382, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [Errno 8] _ssl.c:507: EOF occurred in violation of protocol
```
I'm using `requests==2.3.0`.
I don't have the error when using http of course.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/122286?v=4",
"events_url": "https://api.github.com/users/lra/events{/privacy}",
"followers_url": "https://api.github.com/users/lra/followers",
"following_url": "https://api.github.com/users/lra/following{/other_user}",
"gists_url": "https://api.github.com/users/lra/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lra",
"id": 122286,
"login": "lra",
"node_id": "MDQ6VXNlcjEyMjI4Ng==",
"organizations_url": "https://api.github.com/users/lra/orgs",
"received_events_url": "https://api.github.com/users/lra/received_events",
"repos_url": "https://api.github.com/users/lra/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lra/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lra/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lra",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2056/reactions"
} | https://api.github.com/repos/psf/requests/issues/2056/timeline | null | completed | null | null | false | [
"It appears this does not only happen on GAE. Investigating...\n",
"```\n~$ openssl s_client -connect qascore.percolate.com:443\nCONNECTED(00000003)\n12470:error:140790E5:SSL routines:SSL23_WRITE:ssl handshake failure:/SourceCache/OpenSSL098/OpenSSL098-50/src/ssl/s23_lib.c:182:\n```\n\nOpenSSL seems to be having ... |
https://api.github.com/repos/psf/requests/issues/2055 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2055/labels{/name} | https://api.github.com/repos/psf/requests/issues/2055/comments | https://api.github.com/repos/psf/requests/issues/2055/events | https://github.com/psf/requests/issues/2055 | 34,035,325 | MDU6SXNzdWUzNDAzNTMyNQ== | 2,055 | duplicate with #1547 | {
"avatar_url": "https://avatars.githubusercontent.com/u/207571?v=4",
"events_url": "https://api.github.com/users/john-peterson/events{/privacy}",
"followers_url": "https://api.github.com/users/john-peterson/followers",
"following_url": "https://api.github.com/users/john-peterson/following{/other_user}",
"gists_url": "https://api.github.com/users/john-peterson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/john-peterson",
"id": 207571,
"login": "john-peterson",
"node_id": "MDQ6VXNlcjIwNzU3MQ==",
"organizations_url": "https://api.github.com/users/john-peterson/orgs",
"received_events_url": "https://api.github.com/users/john-peterson/received_events",
"repos_url": "https://api.github.com/users/john-peterson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/john-peterson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/john-peterson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/john-peterson",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-21T23:08:17Z | 2021-09-09T00:00:57Z | 2014-05-21T23:16:17Z | NONE | resolved | duplicate with https://github.com/kennethreitz/requests/issues/1547
remove this issue if possible
| {
"avatar_url": "https://avatars.githubusercontent.com/u/207571?v=4",
"events_url": "https://api.github.com/users/john-peterson/events{/privacy}",
"followers_url": "https://api.github.com/users/john-peterson/followers",
"following_url": "https://api.github.com/users/john-peterson/following{/other_user}",
"gists_url": "https://api.github.com/users/john-peterson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/john-peterson",
"id": 207571,
"login": "john-peterson",
"node_id": "MDQ6VXNlcjIwNzU3MQ==",
"organizations_url": "https://api.github.com/users/john-peterson/orgs",
"received_events_url": "https://api.github.com/users/john-peterson/received_events",
"repos_url": "https://api.github.com/users/john-peterson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/john-peterson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/john-peterson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/john-peterson",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2055/reactions"
} | https://api.github.com/repos/psf/requests/issues/2055/timeline | null | completed | null | null | false | [
"Why aren't you using `pip` to install `requests`? Also, if you're not seeing output from `python setup.py install` what relates it to that StackOverflow question?\n"
] |
https://api.github.com/repos/psf/requests/issues/2054 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2054/labels{/name} | https://api.github.com/repos/psf/requests/issues/2054/comments | https://api.github.com/repos/psf/requests/issues/2054/events | https://github.com/psf/requests/issues/2054 | 33,935,618 | MDU6SXNzdWUzMzkzNTYxOA== | 2,054 | Exceptions have other exceptions as messages. | {
"avatar_url": "https://avatars.githubusercontent.com/u/127497?v=4",
"events_url": "https://api.github.com/users/fletom/events{/privacy}",
"followers_url": "https://api.github.com/users/fletom/followers",
"following_url": "https://api.github.com/users/fletom/following{/other_user}",
"gists_url": "https://api.github.com/users/fletom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fletom",
"id": 127497,
"login": "fletom",
"node_id": "MDQ6VXNlcjEyNzQ5Nw==",
"organizations_url": "https://api.github.com/users/fletom/orgs",
"received_events_url": "https://api.github.com/users/fletom/received_events",
"repos_url": "https://api.github.com/users/fletom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fletom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fletom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fletom",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-20T22:21:06Z | 2021-09-09T00:00:58Z | 2014-05-21T00:15:48Z | NONE | resolved | I could be wrong but this seems very strange behaviour to me. I'm referring to the end of `adapters.py` that passes `urllib3` exceptions to `requests` exceptions as the first argument.
This gets very confusing since `exception.message` is another exception. In my case it broke error reporting tools that were expecting a string.
```
ipdb> exception
ConnectionError(MaxRetryError("HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: /users/authentication (Caused by <class 'socket.error'>: [Errno 61] Connection refused)",),)
ipdb> exception.message
MaxRetryError("HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: /users/authentication (Caused by <class 'socket.error'>: [Errno 61] Connection refused)",)
ipdb> type(exception.message)
<class 'requests.packages.urllib3.exceptions.MaxRetryError'>
```
It would seem much more appropriate to me to replace `raise ConnectionError(e)` with `raise ConnectionError(e.message)`. This provides all the same information while still conforming to the Python convention of `raise Exception("string message")`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2054/reactions"
} | https://api.github.com/repos/psf/requests/issues/2054/timeline | null | completed | null | null | false | [
"It is not the most common behaviour ever but it is in fact a very deliberate design decision. We wrap all errors provided to us by urllib3 (and even some that bubble up from underneath urllib3) and present them to the user in a predictable way. However, for the more advanced user, being able to inspect those lower... |
https://api.github.com/repos/psf/requests/issues/2053 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2053/labels{/name} | https://api.github.com/repos/psf/requests/issues/2053/comments | https://api.github.com/repos/psf/requests/issues/2053/events | https://github.com/psf/requests/issues/2053 | 33,887,182 | MDU6SXNzdWUzMzg4NzE4Mg== | 2,053 | gevent adapter | {
"avatar_url": "https://avatars.githubusercontent.com/u/229945?v=4",
"events_url": "https://api.github.com/users/HoverHell/events{/privacy}",
"followers_url": "https://api.github.com/users/HoverHell/followers",
"following_url": "https://api.github.com/users/HoverHell/following{/other_user}",
"gists_url": "https://api.github.com/users/HoverHell/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/HoverHell",
"id": 229945,
"login": "HoverHell",
"node_id": "MDQ6VXNlcjIyOTk0NQ==",
"organizations_url": "https://api.github.com/users/HoverHell/orgs",
"received_events_url": "https://api.github.com/users/HoverHell/received_events",
"repos_url": "https://api.github.com/users/HoverHell/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/HoverHell/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/HoverHell/subscriptions",
"type": "User",
"url": "https://api.github.com/users/HoverHell",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2014-05-20T13:22:07Z | 2021-09-08T23:10:42Z | 2014-08-13T03:08:22Z | NONE | resolved | Hello.
As a matter of feature request, it would be useful to have a gevent-compatible adapter for requests which would not require any dangerous monkey-patching.
By now, I've tried combining `requests` with `geventhttpclient`; that works, but it is a large hack if it is done in a separate module ( https://gist.github.com/anonymous/699cf4beba490024e52c
) (and I don't want to break external compatbility with requests by trying to use completely different pool and response classes).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2053/reactions"
} | https://api.github.com/repos/psf/requests/issues/2053/timeline | null | completed | null | null | false | [
"I presume that you've seen [grequests](https://github.com/kennethreitz/grequests) and that it's not suitable for your needs?\n",
"@Lukasa as you might see in its source code, it applies gevent.monkeys.patch_all, which is known to break various things and is a generally dangerous thing to do. (worse, it does tha... |
https://api.github.com/repos/psf/requests/issues/2052 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2052/labels{/name} | https://api.github.com/repos/psf/requests/issues/2052/comments | https://api.github.com/repos/psf/requests/issues/2052/events | https://github.com/psf/requests/issues/2052 | 33,802,209 | MDU6SXNzdWUzMzgwMjIwOQ== | 2,052 | Python 3 - TypeError: decoding str is not supported | {
"avatar_url": "https://avatars.githubusercontent.com/u/186643?v=4",
"events_url": "https://api.github.com/users/cam-stitt/events{/privacy}",
"followers_url": "https://api.github.com/users/cam-stitt/followers",
"following_url": "https://api.github.com/users/cam-stitt/following{/other_user}",
"gists_url": "https://api.github.com/users/cam-stitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cam-stitt",
"id": 186643,
"login": "cam-stitt",
"node_id": "MDQ6VXNlcjE4NjY0Mw==",
"organizations_url": "https://api.github.com/users/cam-stitt/orgs",
"received_events_url": "https://api.github.com/users/cam-stitt/received_events",
"repos_url": "https://api.github.com/users/cam-stitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cam-stitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cam-stitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cam-stitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-05-19T14:04:32Z | 2021-09-09T00:00:58Z | 2014-05-20T10:12:05Z | NONE | resolved | I am getting the above error thrown when I attempt to get the request text when the content is a dict-string (ie. '{}'). I've found that it is this line, but I am not sure how to fix it at this point:
https://github.com/kennethreitz/requests/blob/master/requests/models.py#L738
If you were to remove the `errors` keyword, it works fine. I believe it's because the content is not returning as bytes, as `str` expects.
https://docs.python.org/3.3/library/stdtypes.html#str
Not sure how to fix this yet.
Note: if you want to replicate this, use Python 3 and set content to '{}' and try to return `text`
| {
"avatar_url": "https://avatars.githubusercontent.com/u/186643?v=4",
"events_url": "https://api.github.com/users/cam-stitt/events{/privacy}",
"followers_url": "https://api.github.com/users/cam-stitt/followers",
"following_url": "https://api.github.com/users/cam-stitt/following{/other_user}",
"gists_url": "https://api.github.com/users/cam-stitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cam-stitt",
"id": 186643,
"login": "cam-stitt",
"node_id": "MDQ6VXNlcjE4NjY0Mw==",
"organizations_url": "https://api.github.com/users/cam-stitt/orgs",
"received_events_url": "https://api.github.com/users/cam-stitt/received_events",
"repos_url": "https://api.github.com/users/cam-stitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cam-stitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cam-stitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cam-stitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2052/reactions"
} | https://api.github.com/repos/psf/requests/issues/2052/timeline | null | completed | null | null | false | [
"Thanks for raising this!\n\nContent must be bytes, always. If you're writing Transport Adapters or generally tweaking requests, you must ensure that content will always be bytes.\n",
"I'm seeing this when using requests-oauthlib with facebook. Is this\nsomething that will be fixed in requests? Might even look in... |
https://api.github.com/repos/psf/requests/issues/2051 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2051/labels{/name} | https://api.github.com/repos/psf/requests/issues/2051/comments | https://api.github.com/repos/psf/requests/issues/2051/events | https://github.com/psf/requests/issues/2051 | 33,784,685 | MDU6SXNzdWUzMzc4NDY4NQ== | 2,051 | Content length value is written as unicode rather than bytes | {
"avatar_url": "https://avatars.githubusercontent.com/u/769982?v=4",
"events_url": "https://api.github.com/users/Lawouach/events{/privacy}",
"followers_url": "https://api.github.com/users/Lawouach/followers",
"following_url": "https://api.github.com/users/Lawouach/following{/other_user}",
"gists_url": "https://api.github.com/users/Lawouach/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lawouach",
"id": 769982,
"login": "Lawouach",
"node_id": "MDQ6VXNlcjc2OTk4Mg==",
"organizations_url": "https://api.github.com/users/Lawouach/orgs",
"received_events_url": "https://api.github.com/users/Lawouach/received_events",
"repos_url": "https://api.github.com/users/Lawouach/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lawouach/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lawouach/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lawouach",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-05-19T09:52:51Z | 2021-09-09T00:00:58Z | 2014-05-19T09:57:00Z | NONE | resolved | Using the simple following snippet:
```
>>> files = {'myfile': ('filename.zip', file('some.zip', 'rb'), 'application/octet-stream')}
>>> r = requests.Request('POST', URL, files=files).prepare()
>>> r.headers
{'Content-Length': u'395', 'Content-Type': 'multipart/form-data; boundary=ec38bda3760c46aea548602228efdd47'}
```
This is an issue because httplib will consider it must decode the body as well before sending it (at least in Python 2.7.1, I assume with 3.x it's all bytes anyway). This fails when content is binary.
Massaging the Content-Length to revert it to a byte string does work well.
This was with requests 1.1.0.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2051/reactions"
} | https://api.github.com/repos/psf/requests/issues/2051/timeline | null | completed | null | null | false | [
"This is long-since fixed, with the fix originally in version 2.1.0. This is mentioned in [the release notes](https://github.com/kennethreitz/requests/blob/master/HISTORY.rst#210-2013-12-05), was tracked under issue #1688 and was fixed in issue #1699. =)\n",
"My bad.\n",
"No worries @Lawouach ! We appreciate th... |
https://api.github.com/repos/psf/requests/issues/2050 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2050/labels{/name} | https://api.github.com/repos/psf/requests/issues/2050/comments | https://api.github.com/repos/psf/requests/issues/2050/events | https://github.com/psf/requests/pull/2050 | 33,743,358 | MDExOlB1bGxSZXF1ZXN0MTYwMjU1MDQ= | 2,050 | Added instructions and sample code for using requests over Tor | {
"avatar_url": "https://avatars.githubusercontent.com/u/2611615?v=4",
"events_url": "https://api.github.com/users/Hasimir/events{/privacy}",
"followers_url": "https://api.github.com/users/Hasimir/followers",
"following_url": "https://api.github.com/users/Hasimir/following{/other_user}",
"gists_url": "https://api.github.com/users/Hasimir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Hasimir",
"id": 2611615,
"login": "Hasimir",
"node_id": "MDQ6VXNlcjI2MTE2MTU=",
"organizations_url": "https://api.github.com/users/Hasimir/orgs",
"received_events_url": "https://api.github.com/users/Hasimir/received_events",
"repos_url": "https://api.github.com/users/Hasimir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Hasimir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Hasimir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Hasimir",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-05-18T01:32:07Z | 2021-09-08T23:06:18Z | 2014-05-18T09:23:58Z | CONTRIBUTOR | resolved | Added instructions and sample code for using requests over the Tor network.
Sample code shows how to verify a successful connection and how to connect to a hidden service. Example sites are https://check.torproject.org/ and http://ic6au7wa3f6naxjq.onion/ (www.gnupg.org).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/2611615?v=4",
"events_url": "https://api.github.com/users/Hasimir/events{/privacy}",
"followers_url": "https://api.github.com/users/Hasimir/followers",
"following_url": "https://api.github.com/users/Hasimir/following{/other_user}",
"gists_url": "https://api.github.com/users/Hasimir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Hasimir",
"id": 2611615,
"login": "Hasimir",
"node_id": "MDQ6VXNlcjI2MTE2MTU=",
"organizations_url": "https://api.github.com/users/Hasimir/orgs",
"received_events_url": "https://api.github.com/users/Hasimir/received_events",
"repos_url": "https://api.github.com/users/Hasimir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Hasimir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Hasimir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Hasimir",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2050/reactions"
} | https://api.github.com/repos/psf/requests/issues/2050/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2050.diff",
"html_url": "https://github.com/psf/requests/pull/2050",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2050.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2050"
} | true | [
"This is great work @Hasimir! I really appreciate your effort in putting this together.\n\nPersonally, I think this is better suited to a blog post and not the documentation. I'll leave this open, though, until @Lukasa wakes up. :)\n",
"No reason why it can't be both. ;)\n\nBesides, it's merely a conversion (wel... |
https://api.github.com/repos/psf/requests/issues/2049 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2049/labels{/name} | https://api.github.com/repos/psf/requests/issues/2049/comments | https://api.github.com/repos/psf/requests/issues/2049/events | https://github.com/psf/requests/pull/2049 | 33,741,244 | MDExOlB1bGxSZXF1ZXN0MTYwMjQ1OTA= | 2,049 | Separated out proxy_manager_for to fix #2048 | {
"avatar_url": "https://avatars.githubusercontent.com/u/477909?v=4",
"events_url": "https://api.github.com/users/codedstructure/events{/privacy}",
"followers_url": "https://api.github.com/users/codedstructure/followers",
"following_url": "https://api.github.com/users/codedstructure/following{/other_user}",
"gists_url": "https://api.github.com/users/codedstructure/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/codedstructure",
"id": 477909,
"login": "codedstructure",
"node_id": "MDQ6VXNlcjQ3NzkwOQ==",
"organizations_url": "https://api.github.com/users/codedstructure/orgs",
"received_events_url": "https://api.github.com/users/codedstructure/received_events",
"repos_url": "https://api.github.com/users/codedstructure/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/codedstructure/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/codedstructure/subscriptions",
"type": "User",
"url": "https://api.github.com/users/codedstructure",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501... | closed | true | null | [] | null | 14 | 2014-05-17T22:42:52Z | 2021-09-08T23:07:11Z | 2014-06-23T19:11:13Z | CONTRIBUTOR | resolved | Basically identical to @sigmavirus24's suggested code - thanks for that pointer. Just added docstring.
There aren't tests for particular Adapter implementations, and I've not added any at this stage.
I have tested it with the following (which achieves what I want):
```
class SourceAddressAdapter(requests.adapters.HTTPAdapter):
"""
A Requests HTTP adapter to add source address specification for proxies
"""
def __init__(self, *o, **k):
self.source_address = k.pop('source_address', None)
super(SourceAddressAdapter, self).__init__(*o, **k)
def proxy_manager_for(self, proxy):
conn_params = {}
if self.source_address is not None:
conn_params['source_address'] = (self.source_address, 0)
if not proxy in self.proxy_manager:
proxy_headers = self.proxy_headers(proxy)
self.proxy_manager[proxy] = requests.adapters.proxy_from_url(
proxy,
proxy_headers=proxy_headers,
num_pools=self._pool_connections,
maxsize=self._pool_maxsize,
block=self._pool_block,
**conn_params)
return self.proxy_manager[proxy]
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2049/reactions"
} | https://api.github.com/repos/psf/requests/issues/2049/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2049.diff",
"html_url": "https://github.com/psf/requests/pull/2049",
"merged_at": "2014-06-23T19:11:13Z",
"patch_url": "https://github.com/psf/requests/pull/2049.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2049"
} | true | [
"LGTM. @codedstructure you should checkout [the toolbelt](https://gitlab.com/sigmavirus24/toolbelt). We just moved the `SourceAddressAdapter` there so people can use it without having to maintain their own version.\n",
"This looks great @codedstructure, but I want to bikeshed here for a moment. I'm wondering whet... |
https://api.github.com/repos/psf/requests/issues/2048 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2048/labels{/name} | https://api.github.com/repos/psf/requests/issues/2048/comments | https://api.github.com/repos/psf/requests/issues/2048/events | https://github.com/psf/requests/issues/2048 | 33,739,343 | MDU6SXNzdWUzMzczOTM0Mw== | 2,048 | add equivalent to adapter 'init_poolmanager' method for proxy-based connections | {
"avatar_url": "https://avatars.githubusercontent.com/u/477909?v=4",
"events_url": "https://api.github.com/users/codedstructure/events{/privacy}",
"followers_url": "https://api.github.com/users/codedstructure/followers",
"following_url": "https://api.github.com/users/codedstructure/following{/other_user}",
"gists_url": "https://api.github.com/users/codedstructure/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/codedstructure",
"id": 477909,
"login": "codedstructure",
"node_id": "MDQ6VXNlcjQ3NzkwOQ==",
"organizations_url": "https://api.github.com/users/codedstructure/orgs",
"received_events_url": "https://api.github.com/users/codedstructure/received_events",
"repos_url": "https://api.github.com/users/codedstructure/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/codedstructure/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/codedstructure/subscriptions",
"type": "User",
"url": "https://api.github.com/users/codedstructure",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-05-17T20:40:02Z | 2021-09-08T23:10:54Z | 2014-06-23T19:11:13Z | CONTRIBUTOR | resolved | I'm trying to make a HTTPAdapter which injects `source_address` - and after doing my own found https://github.com/kennethreitz/requests/issues/2008#issuecomment-40793099 which it is virtually identical to.
However this fails when proxy configuration is in use as `self.poolmanager` is not used. I suspect overriding `get_connection` is required to accomplish this now; it would be nice if https://github.com/kennethreitz/requests/blob/59c8d81/requests/adapters.py#L210-L215 could become another method similar to `init_poolmanager`, so proxy-based connections could be more easily 'adapted'.
Happy to attempt a PR if this idea has merit / is considered 'in-scope' :-)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2048/reactions"
} | https://api.github.com/repos/psf/requests/issues/2048/timeline | null | completed | null | null | false | [
"I think there's no good reason not to do this, and it would definitely make this easier. @sigmavirus24?\n",
"I would go one step further than the lines you highlighted. That code in `get_connection` could read:\n\n``` python\n if proxy:\n proxy = prepend_scheme_if_needed(proxy, 'http')\n ... |
https://api.github.com/repos/psf/requests/issues/2047 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2047/labels{/name} | https://api.github.com/repos/psf/requests/issues/2047/comments | https://api.github.com/repos/psf/requests/issues/2047/events | https://github.com/psf/requests/pull/2047 | 33,732,865 | MDExOlB1bGxSZXF1ZXN0MTYwMjEzMjg= | 2,047 | Fixed paragraph formatting in Urllib3/MIT License. | {
"avatar_url": "https://avatars.githubusercontent.com/u/2611615?v=4",
"events_url": "https://api.github.com/users/Hasimir/events{/privacy}",
"followers_url": "https://api.github.com/users/Hasimir/followers",
"following_url": "https://api.github.com/users/Hasimir/following{/other_user}",
"gists_url": "https://api.github.com/users/Hasimir/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Hasimir",
"id": 2611615,
"login": "Hasimir",
"node_id": "MDQ6VXNlcjI2MTE2MTU=",
"organizations_url": "https://api.github.com/users/Hasimir/orgs",
"received_events_url": "https://api.github.com/users/Hasimir/received_events",
"repos_url": "https://api.github.com/users/Hasimir/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Hasimir/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Hasimir/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Hasimir",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-17T15:36:44Z | 2021-09-08T23:07:21Z | 2014-05-17T15:37:31Z | CONTRIBUTOR | resolved | No change in content, but the longer lines flowed badly in a terminal or editor.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2047/reactions"
} | https://api.github.com/repos/psf/requests/issues/2047/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2047.diff",
"html_url": "https://github.com/psf/requests/pull/2047",
"merged_at": "2014-05-17T15:37:31Z",
"patch_url": "https://github.com/psf/requests/pull/2047.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2047"
} | true | [
"Thanks! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/2046 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2046/labels{/name} | https://api.github.com/repos/psf/requests/issues/2046/comments | https://api.github.com/repos/psf/requests/issues/2046/events | https://github.com/psf/requests/pull/2046 | 33,697,047 | MDExOlB1bGxSZXF1ZXN0MTYwMDA3MzE= | 2,046 | Fixed a typo | {
"avatar_url": "https://avatars.githubusercontent.com/u/772?v=4",
"events_url": "https://api.github.com/users/alex/events{/privacy}",
"followers_url": "https://api.github.com/users/alex/followers",
"following_url": "https://api.github.com/users/alex/following{/other_user}",
"gists_url": "https://api.github.com/users/alex/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alex",
"id": 772,
"login": "alex",
"node_id": "MDQ6VXNlcjc3Mg==",
"organizations_url": "https://api.github.com/users/alex/orgs",
"received_events_url": "https://api.github.com/users/alex/received_events",
"repos_url": "https://api.github.com/users/alex/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alex/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alex/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alex",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-16T18:11:06Z | 2021-09-08T23:07:12Z | 2014-05-16T21:05:41Z | MEMBER | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2046/reactions"
} | https://api.github.com/repos/psf/requests/issues/2046/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2046.diff",
"html_url": "https://github.com/psf/requests/pull/2046",
"merged_at": "2014-05-16T21:05:41Z",
"patch_url": "https://github.com/psf/requests/pull/2046.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2046"
} | true | [
"Thanks @alex \n"
] | |
https://api.github.com/repos/psf/requests/issues/2045 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2045/labels{/name} | https://api.github.com/repos/psf/requests/issues/2045/comments | https://api.github.com/repos/psf/requests/issues/2045/events | https://github.com/psf/requests/issues/2045 | 33,675,293 | MDU6SXNzdWUzMzY3NTI5Mw== | 2,045 | Uncaught socket.timeout during post | {
"avatar_url": "https://avatars.githubusercontent.com/u/1611076?v=4",
"events_url": "https://api.github.com/users/KennethNielsen/events{/privacy}",
"followers_url": "https://api.github.com/users/KennethNielsen/followers",
"following_url": "https://api.github.com/users/KennethNielsen/following{/other_user}",
"gists_url": "https://api.github.com/users/KennethNielsen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/KennethNielsen",
"id": 1611076,
"login": "KennethNielsen",
"node_id": "MDQ6VXNlcjE2MTEwNzY=",
"organizations_url": "https://api.github.com/users/KennethNielsen/orgs",
"received_events_url": "https://api.github.com/users/KennethNielsen/received_events",
"repos_url": "https://api.github.com/users/KennethNielsen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/KennethNielsen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KennethNielsen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/KennethNielsen",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-05-16T13:40:29Z | 2021-09-08T23:10:40Z | 2014-08-02T01:33:56Z | NONE | resolved | Hallo requests devs (and thanks for an awesome lib)
During a specific `requests.post` I most of the time get a `requests.exceptions.Timeout` (on timeouts) but I also sometimes get a `socket.timeout` exception. Since there is a requests exception for it, I assume that the socket exception was supposed to be caught and the requests one raise instead. The full stack trace is:
``` python
Traceback (most recent call last):
File "test.py", line 132, in <module>
test_stuff()
File "test.py", line 113, in test_stuff
browse_recursively()
File "test.py", line 106, in browse_recursively
browse_recursively(new_item, level + 1)
File "test.py", line 106, in browse_recursively
browse_recursively(new_item, level + 1)
File "test.py", line 106, in browse_recursively
browse_recursively(new_item, level + 1)
File "test.py", line 106, in browse_recursively
browse_recursively(new_item, level + 1)
File "test.py", line 101, in browse_recursively
for new_item in wimp.browse(item):
File "/home/kenneth/code/soco/SoCo/soco/plugins/wimp.py", line 207, in browse
response = post(self._url, headers, body)
File "/home/kenneth/code/soco/SoCo/soco/plugins/wimp.py", line 40, in post
out = requests.post(url, headers=headers, data=body, timeout=1.0)
File "/usr/lib/python2.7/dist-packages/requests/api.py", line 87, in post
return request('post', url, data=data, **kwargs)
File "/usr/lib/python2.7/dist-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 222, in send
r.content
File "/usr/lib/python2.7/dist-packages/requests/models.py", line 550, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/usr/lib/python2.7/dist-packages/requests/utils.py", line 363, in stream_decompress
for chunk in iterator:
File "/usr/lib/python2.7/dist-packages/requests/models.py", line 496, in generate
chunk = self.raw.read(chunk_size)
File "/usr/lib/python2.7/dist-packages/urllib3/response.py", line 146, in read
return self._fp.read(amt)
File "/usr/lib/python2.7/httplib.py", line 567, in read
s = self.fp.read(amt)
File "/usr/lib/python2.7/socket.py", line 380, in read
data = self._sock.recv(left)
socket.timeout: timed out
```
The development is for a plugin for the music service Wimp for the [SoCo](https://github.com/SoCo/SoCo) project, which means that I could post code to reproduce, but you will not be able to run it without a Sonos speaker and a Wimp subscription. I understand if this difficulty to reproduce may mean that you cannot work with this issue.
Thanks in advance Kenneth
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2045/reactions"
} | https://api.github.com/repos/psf/requests/issues/2045/timeline | null | completed | null | null | false | [
"Thanks so much for this! :cake:\n\nThis looks like a good catch. I think the generator created in `Response.iter_content` should probably be looking for Timeout errors, both from urllib3 and from the socket module, and should catch and wrap them. @sigmavirus24?\n",
"Sounds like a good idea to me\n",
"i think t... |
https://api.github.com/repos/psf/requests/issues/2044 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2044/labels{/name} | https://api.github.com/repos/psf/requests/issues/2044/comments | https://api.github.com/repos/psf/requests/issues/2044/events | https://github.com/psf/requests/issues/2044 | 33,572,995 | MDU6SXNzdWUzMzU3Mjk5NQ== | 2,044 | UnicodeDecodeError when using POST with files AND Authentication | {
"avatar_url": "https://avatars.githubusercontent.com/u/7556471?v=4",
"events_url": "https://api.github.com/users/p-clem/events{/privacy}",
"followers_url": "https://api.github.com/users/p-clem/followers",
"following_url": "https://api.github.com/users/p-clem/following{/other_user}",
"gists_url": "https://api.github.com/users/p-clem/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/p-clem",
"id": 7556471,
"login": "p-clem",
"node_id": "MDQ6VXNlcjc1NTY0NzE=",
"organizations_url": "https://api.github.com/users/p-clem/orgs",
"received_events_url": "https://api.github.com/users/p-clem/received_events",
"repos_url": "https://api.github.com/users/p-clem/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/p-clem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/p-clem/subscriptions",
"type": "User",
"url": "https://api.github.com/users/p-clem",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 19 | 2014-05-15T10:25:26Z | 2021-09-08T23:10:43Z | 2014-05-19T07:31:43Z | NONE | resolved | Whenever I try to do a Post with an image as file and use Authentification:
```
r = requests.post(
url,
data=data,
auth=('auth','pass'),
files={'image': object.image},
)
```
I get this error:
UnicodeDecodeError
'ascii' codec can't decode byte 0xff in position 1141: ordinal not in range(128)
If I remove the authentication it works.
The full Traceback:
```
Environment:
Request Method: POST
Request URL: http://127.0.0.1:8000/admin/magazines/magazine/71/
Django Version: 1.6.2
Python Version: 2.7.0
Installed Applications:
('django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.sessions',
'django.contrib.sites',
'django.contrib.messages',
'django.contrib.staticfiles',
'django.contrib.admin',
'south',
'ajax_select',
'shops',
'feeds',
'magazines')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware')
Traceback:
File "C:\Python27\lib\site-packages\django\core\handlers\base.py" in get_response
114. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "C:\Python27\lib\site-packages\django\contrib\admin\options.py" in wrapper
432. return self.admin_site.admin_view(view)(*args, **kwargs)
File "C:\Python27\lib\site-packages\django\utils\decorators.py" in _wrapped_view
99. response = view_func(request, *args, **kwargs)
File "C:\Python27\lib\site-packages\django\views\decorators\cache.py" in _wrapped_view_func
52. response = view_func(request, *args, **kwargs)
File "C:\Python27\lib\site-packages\django\contrib\admin\sites.py" in inner
198. return view(request, *args, **kwargs)
File "C:\Python27\lib\site-packages\django\utils\decorators.py" in _wrapper
29. return bound_func(*args, **kwargs)
File "C:\Python27\lib\site-packages\django\utils\decorators.py" in _wrapped_view
99. response = view_func(request, *args, **kwargs)
File "C:\Python27\lib\site-packages\django\utils\decorators.py" in bound_func
25. return func(self, *args2, **kwargs2)
File "C:\Python27\lib\site-packages\django\db\transaction.py" in inner
339. return func(*args, **kwargs)
File "C:\Python27\lib\site-packages\django\contrib\admin\options.py" in change_view
1230. self.save_model(request, new_object, form, True)
File "C:\Python27\lib\site-packages\django\contrib\admin\options.py" in save_model
860. obj.save()
File "C:\DEV\projects\stylr\stylr\apps\magazines\models.py" in save
48. files={'logo': self.logo, 'image': self.cover},
File "C:\Python27\lib\site-packages\requests\api.py" in post
88. return request('post', url, data=data, **kwargs)
File "C:\Python27\lib\site-packages\requests\api.py" in request
44. return session.request(method=method, url=url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py" in request
383. resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py" in send
486. r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py" in send
330. timeout=timeout
File "C:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py" in urlopen
480. body=body, headers=headers)
File "C:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py" in _make_request
285. conn.request(method, url, **httplib_request_kw)
File "C:\Python27\lib\httplib.py" in request
946. self._send_request(method, url, body, headers)
File "C:\Python27\lib\httplib.py" in _send_request
987. self.endheaders(body)
File "C:\Python27\lib\httplib.py" in endheaders
940. self._send_output(message_body)
File "C:\Python27\lib\httplib.py" in _send_output
801. msg += message_body
Exception Type: UnicodeDecodeError at /admin/magazines/magazine/71/
Exception Value: 'ascii' codec can't decode byte 0xff in position 1141: ordinal not in range(128)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/7556471?v=4",
"events_url": "https://api.github.com/users/p-clem/events{/privacy}",
"followers_url": "https://api.github.com/users/p-clem/followers",
"following_url": "https://api.github.com/users/p-clem/following{/other_user}",
"gists_url": "https://api.github.com/users/p-clem/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/p-clem",
"id": 7556471,
"login": "p-clem",
"node_id": "MDQ6VXNlcjc1NTY0NzE=",
"organizations_url": "https://api.github.com/users/p-clem/orgs",
"received_events_url": "https://api.github.com/users/p-clem/received_events",
"repos_url": "https://api.github.com/users/p-clem/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/p-clem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/p-clem/subscriptions",
"type": "User",
"url": "https://api.github.com/users/p-clem",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2044/reactions"
} | https://api.github.com/repos/psf/requests/issues/2044/timeline | null | completed | null | null | false | [
"What version of requests are you using? (`requests.__version __`)\n",
"Oh sorry forgot to mention that: I'm using version 2.2.1\n",
"Can you tell me the types of `url`, `data` and `object.image`?\n",
"url -> str\ndata -> dict\nobject:image -> django.db.models.fields.files.ImageFieldFile\n",
"What's in `da... |
https://api.github.com/repos/psf/requests/issues/2043 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2043/labels{/name} | https://api.github.com/repos/psf/requests/issues/2043/comments | https://api.github.com/repos/psf/requests/issues/2043/events | https://github.com/psf/requests/issues/2043 | 33,465,134 | MDU6SXNzdWUzMzQ2NTEzNA== | 2,043 | [resolved] incomplete file download ? file received capped at 1024MB then stopped. | {
"avatar_url": "https://avatars.githubusercontent.com/u/2757572?v=4",
"events_url": "https://api.github.com/users/oglops/events{/privacy}",
"followers_url": "https://api.github.com/users/oglops/followers",
"following_url": "https://api.github.com/users/oglops/following{/other_user}",
"gists_url": "https://api.github.com/users/oglops/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oglops",
"id": 2757572,
"login": "oglops",
"node_id": "MDQ6VXNlcjI3NTc1NzI=",
"organizations_url": "https://api.github.com/users/oglops/orgs",
"received_events_url": "https://api.github.com/users/oglops/received_events",
"repos_url": "https://api.github.com/users/oglops/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oglops/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oglops/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oglops",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-05-14T06:38:52Z | 2021-09-07T00:06:18Z | 2014-06-08T09:57:30Z | NONE | resolved | the link to the questions is here [requests response.iter_content() gets incomplete file ( 1024MB instead of 1.5GB )?](http://stackoverflow.com/questions/23645212/requests-response-iter-content-gets-incomplete-file-1024mb-instead-of-1-5gb)
pasted from stackoverflow:
i have been using this code snippet to download files from a website, so far files smaller than 1GB are all good. but i noticed a 1.5GB file is incomplete
```
# s is requests session object
r = s.get(fileUrl, headers=headers, stream=True)
start_time = time.time()
with open(local_filename, 'wb') as f:
count = 1
block_size = 512
try:
total_size = int(r.headers.get('content-length'))
print 'file total size :',total_size
except TypeError:
print 'using dummy length !!!'
total_size = 10000000
for chunk in r.iter_content(chunk_size=block_size):
if chunk: # filter out keep-alive new chunks
duration = time.time() - start_time
progress_size = int(count * block_size)
if duration == 0:
duration = 0.1
speed = int(progress_size / (1024 * duration))
percent = int(count * block_size * 100 / total_size)
sys.stdout.write("\r...%d%%, %d MB, %d KB/s, %d seconds passed" %
(percent, progress_size / (1024 * 1024), speed, duration))
f.write(chunk)
f.flush()
count += 1
```
using latest requests 2.2.1 python 2.6.6, centos 6.4
the file download always stops at 66.7% 1024MB, what am i missing ?
the output:
```
file total size : 1581244542
...67%, 1024 MB, 5687 KB/s, 184 seconds passed
```
it seems the generator returned by iter_content() thinks all chunks are retrieved and there is no error. btw the exception part did not run, because the server did return the content-length in response header.
edit: after chaning my post url to something like
```
https://xxx.com/yyyfiles.php?userid=xxx&tutid=yyy&sessionid=zzz
```
the files downloads fine.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2043/reactions"
} | https://api.github.com/repos/psf/requests/issues/2043/timeline | null | completed | null | null | false | [
"Can you print out the headers on the response? I'm particularly interested in `r.headers['Content-Encoding']`.\n",
"didn't see `Content-Encoding` in response headers\n`r.encoding` is None\n\n request header:\ni tried posting `\"Range\"`, still not working. ( of course because there is no `content-range` in the r... |
https://api.github.com/repos/psf/requests/issues/2042 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2042/labels{/name} | https://api.github.com/repos/psf/requests/issues/2042/comments | https://api.github.com/repos/psf/requests/issues/2042/events | https://github.com/psf/requests/issues/2042 | 33,409,728 | MDU6SXNzdWUzMzQwOTcyOA== | 2,042 | Incorrect encoding detected when no encoding is given | {
"avatar_url": "https://avatars.githubusercontent.com/u/837573?v=4",
"events_url": "https://api.github.com/users/untitaker/events{/privacy}",
"followers_url": "https://api.github.com/users/untitaker/followers",
"following_url": "https://api.github.com/users/untitaker/following{/other_user}",
"gists_url": "https://api.github.com/users/untitaker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/untitaker",
"id": 837573,
"login": "untitaker",
"node_id": "MDQ6VXNlcjgzNzU3Mw==",
"organizations_url": "https://api.github.com/users/untitaker/orgs",
"received_events_url": "https://api.github.com/users/untitaker/received_events",
"repos_url": "https://api.github.com/users/untitaker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/untitaker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/untitaker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/untitaker",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-05-13T15:32:41Z | 2021-09-08T23:10:44Z | 2014-05-13T17:07:57Z | CONTRIBUTOR | resolved | On https://mozorg.cdn.mozilla.net/media/caldata/FrenchHolidays.ics, the encoding is set to `ISO-8859-1`, although no encoding was given in the headers, which is why i think it should be `None` instead.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/837573?v=4",
"events_url": "https://api.github.com/users/untitaker/events{/privacy}",
"followers_url": "https://api.github.com/users/untitaker/followers",
"following_url": "https://api.github.com/users/untitaker/following{/other_user}",
"gists_url": "https://api.github.com/users/untitaker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/untitaker",
"id": 837573,
"login": "untitaker",
"node_id": "MDQ6VXNlcjgzNzU3Mw==",
"organizations_url": "https://api.github.com/users/untitaker/orgs",
"received_events_url": "https://api.github.com/users/untitaker/received_events",
"repos_url": "https://api.github.com/users/untitaker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/untitaker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/untitaker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/untitaker",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2042/reactions"
} | https://api.github.com/repos/psf/requests/issues/2042/timeline | null | completed | null | null | false | [
"This is well-known behaviour in requests, and comes right out of RFC-2616. We go into it [here](http://docs.python-requests.org/en/latest/user/advanced/#encodings) in the documentation, but in short: RFC 2616 says that if a Content-Type is received that is of type `text/*` (any text content type) but no charset is... |
https://api.github.com/repos/psf/requests/issues/2041 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2041/labels{/name} | https://api.github.com/repos/psf/requests/issues/2041/comments | https://api.github.com/repos/psf/requests/issues/2041/events | https://github.com/psf/requests/pull/2041 | 33,376,815 | MDExOlB1bGxSZXF1ZXN0MTU4MDkwMDY= | 2,041 | Fix typo in advanced.rst docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/914977?v=4",
"events_url": "https://api.github.com/users/pawroman/events{/privacy}",
"followers_url": "https://api.github.com/users/pawroman/followers",
"following_url": "https://api.github.com/users/pawroman/following{/other_user}",
"gists_url": "https://api.github.com/users/pawroman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pawroman",
"id": 914977,
"login": "pawroman",
"node_id": "MDQ6VXNlcjkxNDk3Nw==",
"organizations_url": "https://api.github.com/users/pawroman/orgs",
"received_events_url": "https://api.github.com/users/pawroman/received_events",
"repos_url": "https://api.github.com/users/pawroman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pawroman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pawroman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pawroman",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-13T08:12:37Z | 2021-09-08T22:01:16Z | 2014-05-13T10:31:24Z | CONTRIBUTOR | resolved | "Sesssion" -> "Session"
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2041/reactions"
} | https://api.github.com/repos/psf/requests/issues/2041/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2041.diff",
"html_url": "https://github.com/psf/requests/pull/2041",
"merged_at": "2014-05-13T10:31:24Z",
"patch_url": "https://github.com/psf/requests/pull/2041.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2041"
} | true | [
":cake: :star: Thanks so much!\n"
] |
https://api.github.com/repos/psf/requests/issues/2040 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2040/labels{/name} | https://api.github.com/repos/psf/requests/issues/2040/comments | https://api.github.com/repos/psf/requests/issues/2040/events | https://github.com/psf/requests/pull/2040 | 33,338,624 | MDExOlB1bGxSZXF1ZXN0MTU3ODU2ODU= | 2,040 | Initial 2.3.0 changelog. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-05-12T19:27:53Z | 2021-09-08T23:08:20Z | 2014-05-16T14:37:32Z | MEMBER | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2040/reactions"
} | https://api.github.com/repos/psf/requests/issues/2040/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2040.diff",
"html_url": "https://github.com/psf/requests/pull/2040",
"merged_at": "2014-05-16T14:37:32Z",
"patch_url": "https://github.com/psf/requests/pull/2040.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2040"
} | true | [
":100: \n"
] | |
https://api.github.com/repos/psf/requests/issues/2039 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2039/labels{/name} | https://api.github.com/repos/psf/requests/issues/2039/comments | https://api.github.com/repos/psf/requests/issues/2039/events | https://github.com/psf/requests/issues/2039 | 33,337,872 | MDU6SXNzdWUzMzMzNzg3Mg== | 2,039 | incomplete file upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/7561576?v=4",
"events_url": "https://api.github.com/users/clem2/events{/privacy}",
"followers_url": "https://api.github.com/users/clem2/followers",
"following_url": "https://api.github.com/users/clem2/following{/other_user}",
"gists_url": "https://api.github.com/users/clem2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/clem2",
"id": 7561576,
"login": "clem2",
"node_id": "MDQ6VXNlcjc1NjE1NzY=",
"organizations_url": "https://api.github.com/users/clem2/orgs",
"received_events_url": "https://api.github.com/users/clem2/received_events",
"repos_url": "https://api.github.com/users/clem2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/clem2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/clem2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/clem2",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 37 | 2014-05-12T19:18:35Z | 2019-03-20T20:34:05Z | 2014-05-14T13:01:56Z | NONE | resolved | On Windows 7 64bit, uploading a file using requests via python-onedrive does not complete, to be more precise, only the first few bytes/kilobytes are uploaded.
Modified models.py for debugging as follows:
```
def prepare(self, method=None, url=None, headers=None, files=None,
data=None, params=None, auth=None, cookies=None, hooks=None):
"""Prepares the entire request with the given parameters."""
### ADDED FOR DEBUGGING
with open(r'C:\Python\requests_debug.log', 'ab') as log:
for k, file_tuple in files.viewitems():
log.write('BEFORE: Key: {}, File tuple: {}, position: {}\n'.format(k, file_tuple, file_tuple[1].tell()))
### END
self.prepare_method(method)
self.prepare_url(url, params)
self.prepare_headers(headers)
self.prepare_cookies(cookies)
self.prepare_body(data, files)
self.prepare_auth(auth, url)
# Note that prepare_auth must be last to enable authentication schemes
# such as OAuth to work on a fully prepared request.
# This MUST go after prepare_auth. Authenticators could add a hook
self.prepare_hooks(hooks)
### ADDED FOR DEBUGGING
with open(r'C:\Python\requests_debug.log', 'ab') as log:
for k, file_tuple in files.viewitems():
pos = file_tuple[1].tell()
file_tuple[1].seek(0, os.SEEK_END)
log.write('AFTER: Key: {}, position: {}, size: {}\n'.format(k, pos, file_tuple[1].tell()))
log.write('Body size: {}\n'.format(len(self.body)))
### END
```
Here's an example log:
BEFORE: Key: file, File tuple: (u'nv2-pc.zip', <open file u'nv2-pc.zip', mode 'r' at 0x028B4EE8>, u'application/octet-stream'), position: 0
AFTER: Key: file, position: 4784128, size: 4787658
Body size: 522
As you can see, the body size is much smaller than the size indicated in AFTER.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2039/reactions"
} | https://api.github.com/repos/psf/requests/issues/2039/timeline | null | completed | null | null | false | [
"Out of interest, once you've sent the request what's the value of `len(r.request.body)`?\n",
"I should note, it was python-onedrive's dev who determined that the cause of the issue was likely in requests and provided the debugging code. So, how would I go about getting that value?\n",
"It can be printed out [h... |
https://api.github.com/repos/psf/requests/issues/2038 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2038/labels{/name} | https://api.github.com/repos/psf/requests/issues/2038/comments | https://api.github.com/repos/psf/requests/issues/2038/events | https://github.com/psf/requests/pull/2038 | 33,334,991 | MDExOlB1bGxSZXF1ZXN0MTU3ODM0MTk= | 2,038 | Update urllib3 to 4fb351cd2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-05-12T18:45:03Z | 2021-09-08T23:05:09Z | 2014-05-12T18:50:36Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2038/reactions"
} | https://api.github.com/repos/psf/requests/issues/2038/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2038.diff",
"html_url": "https://github.com/psf/requests/pull/2038",
"merged_at": "2014-05-12T18:50:36Z",
"patch_url": "https://github.com/psf/requests/pull/2038.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2038"
} | true | [
":+1: :cake:\n\n@kennethreitz Just so you're aware, the reason this has been opened is because of shazow/urllib3#385, which is a nastly TLS-related bug on Python 3.4.1. This will be a big problem for `pip` in addition to our users, so we'll want to think hard about pushing a new release. Let me know if you decide t... | |
https://api.github.com/repos/psf/requests/issues/2037 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2037/labels{/name} | https://api.github.com/repos/psf/requests/issues/2037/comments | https://api.github.com/repos/psf/requests/issues/2037/events | https://github.com/psf/requests/issues/2037 | 33,295,616 | MDU6SXNzdWUzMzI5NTYxNg== | 2,037 | content is different: r.json() and r.text | {
"avatar_url": "https://avatars.githubusercontent.com/u/2773781?v=4",
"events_url": "https://api.github.com/users/albinsun/events{/privacy}",
"followers_url": "https://api.github.com/users/albinsun/followers",
"following_url": "https://api.github.com/users/albinsun/following{/other_user}",
"gists_url": "https://api.github.com/users/albinsun/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/albinsun",
"id": 2773781,
"login": "albinsun",
"node_id": "MDQ6VXNlcjI3NzM3ODE=",
"organizations_url": "https://api.github.com/users/albinsun/orgs",
"received_events_url": "https://api.github.com/users/albinsun/received_events",
"repos_url": "https://api.github.com/users/albinsun/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/albinsun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/albinsun/subscriptions",
"type": "User",
"url": "https://api.github.com/users/albinsun",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-12T10:20:17Z | 2021-09-09T00:00:59Z | 2014-05-12T10:47:35Z | NONE | resolved | Hi,
a question shows in following, content of r.json() is not the same with r.text (only the last element compared to r.text in this example).
I thought that it may comes from streaming, but it still the same even I set stream=False.
Do I have any misunderstanding to this method?
``` python
>>> r.text
u'{"responseHeader":{"status":0,"QTime":646},"success":{"127.0.1.1:8983_solr":{"responseHeader":{"status":0,"QTime":87}},"127.0.1.1:8983_solr":{"responseHeader":{"status":0,"QTime":42}},"127.0.1.1:8983_solr":{"responseHeader":{"status":0,"QTime":36}},"127.0.1.1:8983_solr":{"responseHeader":{"status":0,"QTime":128}},"127.0.1.1:8983_solr":{"responseHeader":{"status":0,"QTime":123}}}}\n'
>>> r.json()
{u'responseHeader': {u'status': 0, u'QTime': 646}, u'success': {u'127.0.1.1:8983_solr': {u'responseHeader': {u'status': 0, u'QTime': 123}}}}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2037/reactions"
} | https://api.github.com/repos/psf/requests/issues/2037/timeline | null | completed | null | null | false | [
"No, you've just been sent some awkward JSON. =)\n\nLet me format the JSON to show you what I mean:\n\n```\n{\n \"responseHeader\": {\"status\":0,\"QTime\":646},\n \"success\":\n {\n \"127.0.1.1:8983_solr\": \n {\n \"responseHeader\": {\"status\":0,\"QTime\":87}\n },\n \"127.0.1.1:8983_solr\":\n... |
https://api.github.com/repos/psf/requests/issues/2036 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2036/labels{/name} | https://api.github.com/repos/psf/requests/issues/2036/comments | https://api.github.com/repos/psf/requests/issues/2036/events | https://github.com/psf/requests/issues/2036 | 33,064,087 | MDU6SXNzdWUzMzA2NDA4Nw== | 2,036 | Does not work with Microsoft ISA Firewall Client for ISA Server | {
"avatar_url": "https://avatars.githubusercontent.com/u/1299189?v=4",
"events_url": "https://api.github.com/users/espdev/events{/privacy}",
"followers_url": "https://api.github.com/users/espdev/followers",
"following_url": "https://api.github.com/users/espdev/following{/other_user}",
"gists_url": "https://api.github.com/users/espdev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/espdev",
"id": 1299189,
"login": "espdev",
"node_id": "MDQ6VXNlcjEyOTkxODk=",
"organizations_url": "https://api.github.com/users/espdev/orgs",
"received_events_url": "https://api.github.com/users/espdev/received_events",
"repos_url": "https://api.github.com/users/espdev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/espdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/espdev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/espdev",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-05-08T08:40:19Z | 2021-09-08T21:00:54Z | 2014-05-08T09:42:23Z | NONE | resolved | `Requests` does not work if I try to use it in a corporate network with Microsoft ISA Server when I use ISA Firewal Clent. I do not set any proxy settings, but `requests` despite it have looked proxy. This behavior has been defined by default for `trust_env` in the module `sessions` in the line range 423-427 (https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L423).
``` python
proxies = proxies or {}
# Gather clues from the surrounding environment.
if self.trust_env:
# Set environment's proxies.
env_proxies = get_environ_proxies(url) or {}
for (k, v) in env_proxies.items():
proxies.setdefault(k, v)
```
In my network function `get_environ_proxies` returns a list of proxy servers, and it does not work for me. For correct work via ISA Firewal Clent, dict of proxies must be empty always.
For example, this behavior prevents to use `pip` (see https://github.com/pypa/pip/issues/1182#issuecomment-41282819).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2036/reactions"
} | https://api.github.com/repos/psf/requests/issues/2036/timeline | null | completed | null | null | false | [
"Let me try to understand what your problem is. You want requests not to explicitly consult a proxy (presumably because the ISA server proxy is transparent).\n\nThe environment proxies are gathered in two ways: firstly, by consulting environment variables (`HTTP_PROXY` and `HTTPS_PROXY`), and then by consulting the... |
https://api.github.com/repos/psf/requests/issues/2035 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2035/labels{/name} | https://api.github.com/repos/psf/requests/issues/2035/comments | https://api.github.com/repos/psf/requests/issues/2035/events | https://github.com/psf/requests/issues/2035 | 32,798,104 | MDU6SXNzdWUzMjc5ODEwNA== | 2,035 | redirect will not keep the Cookie field in headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/1174269?v=4",
"events_url": "https://api.github.com/users/paramiao/events{/privacy}",
"followers_url": "https://api.github.com/users/paramiao/followers",
"following_url": "https://api.github.com/users/paramiao/following{/other_user}",
"gists_url": "https://api.github.com/users/paramiao/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/paramiao",
"id": 1174269,
"login": "paramiao",
"node_id": "MDQ6VXNlcjExNzQyNjk=",
"organizations_url": "https://api.github.com/users/paramiao/orgs",
"received_events_url": "https://api.github.com/users/paramiao/received_events",
"repos_url": "https://api.github.com/users/paramiao/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/paramiao/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/paramiao/subscriptions",
"type": "User",
"url": "https://api.github.com/users/paramiao",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-05-05T09:57:27Z | 2021-09-09T00:01:01Z | 2014-05-06T01:44:59Z | NONE | resolved | i set cookie in headers, and pass the headers argument to requests.get, but when it happens redirect, the Cookie in headers will be deleted(i found it in the source code)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1174269?v=4",
"events_url": "https://api.github.com/users/paramiao/events{/privacy}",
"followers_url": "https://api.github.com/users/paramiao/followers",
"following_url": "https://api.github.com/users/paramiao/following{/other_user}",
"gists_url": "https://api.github.com/users/paramiao/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/paramiao",
"id": 1174269,
"login": "paramiao",
"node_id": "MDQ6VXNlcjExNzQyNjk=",
"organizations_url": "https://api.github.com/users/paramiao/orgs",
"received_events_url": "https://api.github.com/users/paramiao/received_events",
"repos_url": "https://api.github.com/users/paramiao/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/paramiao/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/paramiao/subscriptions",
"type": "User",
"url": "https://api.github.com/users/paramiao",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2035/reactions"
} | https://api.github.com/repos/psf/requests/issues/2035/timeline | null | completed | null | null | false | [
"We don't expect cookies to be set that way, we expect you to use the `cookies` argument to the request or to use the `Session.cookies` property. =)\n",
"got it, i know this usage, but want one more choice~\n",
"There should be one obvious way to do it, and preferably only one way to do it. In other words, I'm ... |
https://api.github.com/repos/psf/requests/issues/2034 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2034/labels{/name} | https://api.github.com/repos/psf/requests/issues/2034/comments | https://api.github.com/repos/psf/requests/issues/2034/events | https://github.com/psf/requests/issues/2034 | 32,743,925 | MDU6SXNzdWUzMjc0MzkyNQ== | 2,034 | Requests 2.3 not available on pypi. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1592927?v=4",
"events_url": "https://api.github.com/users/Damgaard/events{/privacy}",
"followers_url": "https://api.github.com/users/Damgaard/followers",
"following_url": "https://api.github.com/users/Damgaard/following{/other_user}",
"gists_url": "https://api.github.com/users/Damgaard/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Damgaard",
"id": 1592927,
"login": "Damgaard",
"node_id": "MDQ6VXNlcjE1OTI5Mjc=",
"organizations_url": "https://api.github.com/users/Damgaard/orgs",
"received_events_url": "https://api.github.com/users/Damgaard/received_events",
"repos_url": "https://api.github.com/users/Damgaard/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Damgaard/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Damgaard/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Damgaard",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-05-03T09:52:37Z | 2021-09-09T00:01:02Z | 2014-05-03T10:02:24Z | CONTRIBUTOR | resolved | Hi.
It looks like requests 2.3 is done. The [RTD](http://docs.python-requests.org/en/latest/) page refers to 2.3 and the __init__ file has been on version 2.3 for the last 3 months. Maybe 2.3 is not done and the version increment was wrong? Either way it'd be good to have clarity on this.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2034/reactions"
} | https://api.github.com/repos/psf/requests/issues/2034/timeline | null | completed | null | null | false | [
"The version increment was wrong, and slipped through in an over-keen pull request. We initially elected to let that go believing that we were going to release soon, but it's been more than a month now so I'll change that back.\n\nFor future reference, we will never 'ship' a release that doesn't go out on PyPI. Wha... |
https://api.github.com/repos/psf/requests/issues/2033 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2033/labels{/name} | https://api.github.com/repos/psf/requests/issues/2033/comments | https://api.github.com/repos/psf/requests/issues/2033/events | https://github.com/psf/requests/issues/2033 | 32,737,944 | MDU6SXNzdWUzMjczNzk0NA== | 2,033 | Unable to Post the Json Object | {
"avatar_url": "https://avatars.githubusercontent.com/u/3498225?v=4",
"events_url": "https://api.github.com/users/pavanreddy/events{/privacy}",
"followers_url": "https://api.github.com/users/pavanreddy/followers",
"following_url": "https://api.github.com/users/pavanreddy/following{/other_user}",
"gists_url": "https://api.github.com/users/pavanreddy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pavanreddy",
"id": 3498225,
"login": "pavanreddy",
"node_id": "MDQ6VXNlcjM0OTgyMjU=",
"organizations_url": "https://api.github.com/users/pavanreddy/orgs",
"received_events_url": "https://api.github.com/users/pavanreddy/received_events",
"repos_url": "https://api.github.com/users/pavanreddy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pavanreddy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pavanreddy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pavanreddy",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-03T02:11:10Z | 2021-09-09T00:01:02Z | 2014-05-05T07:21:31Z | NONE | resolved | Hi I am trying to post the request using python. I would like to what is wrong with my code. Can you let know what is correct way of doing it
Python Code :(Does not work)
data ={'object':{'login':{'username':'nsroot','password':'nsroot'}}}
headers = {'Content-Type': 'application/x-www-form-urlencoded'}
response =requests.post(url,data=json.dumps(data))
Response :+1:
Invalid POST request
Rest Call : (Works)
POST /nitro/v1/config/ HTTP/1.1
Host: 192.168.1.11
Cache-Control: no-cache
Content-Type: application/x-www-form-urlencoded
object = {'login':{'username':'nsroot','password':'nsroot'}}
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2033/reactions"
} | https://api.github.com/repos/psf/requests/issues/2033/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nYou're not POSTing quite the same thing as your example. Your example is actually a x-www-form-urlencoded body which happens to have a JSON value in one of the values, but you're posting a wholly-JSON encoded body. Try this:\n\n``` python\ndata = {'object': json.dumps({'login':{'u... |
https://api.github.com/repos/psf/requests/issues/2032 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2032/labels{/name} | https://api.github.com/repos/psf/requests/issues/2032/comments | https://api.github.com/repos/psf/requests/issues/2032/events | https://github.com/psf/requests/pull/2032 | 32,707,109 | MDExOlB1bGxSZXF1ZXN0MTU0Mzk3OTg= | 2,032 | Remove the easy_install section | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-05-02T16:52:03Z | 2021-09-08T23:08:30Z | 2014-05-02T19:09:21Z | CONTRIBUTOR | resolved | There's not a lot of good reason to actually call out easy_install at all. Anyone who prefers it already knows it exists and everyone else should be directed unambiguously towards pip.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2032/reactions"
} | https://api.github.com/repos/psf/requests/issues/2032/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2032.diff",
"html_url": "https://github.com/psf/requests/pull/2032",
"merged_at": "2014-05-02T19:09:21Z",
"patch_url": "https://github.com/psf/requests/pull/2032.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2032"
} | true | [
"Three years ago, things were a bit different.\n",
":cake: \n",
"Sure :) Just saying there's no good reason to do it anymore! Thanks for the merge :]\n"
] |
https://api.github.com/repos/psf/requests/issues/2031 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2031/labels{/name} | https://api.github.com/repos/psf/requests/issues/2031/comments | https://api.github.com/repos/psf/requests/issues/2031/events | https://github.com/psf/requests/pull/2031 | 32,671,030 | MDExOlB1bGxSZXF1ZXN0MTU0MjA4MTc= | 2,031 | Fix typo | {
"avatar_url": "https://avatars.githubusercontent.com/u/904189?v=4",
"events_url": "https://api.github.com/users/yamaneko1212/events{/privacy}",
"followers_url": "https://api.github.com/users/yamaneko1212/followers",
"following_url": "https://api.github.com/users/yamaneko1212/following{/other_user}",
"gists_url": "https://api.github.com/users/yamaneko1212/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yamaneko1212",
"id": 904189,
"login": "yamaneko1212",
"node_id": "MDQ6VXNlcjkwNDE4OQ==",
"organizations_url": "https://api.github.com/users/yamaneko1212/orgs",
"received_events_url": "https://api.github.com/users/yamaneko1212/received_events",
"repos_url": "https://api.github.com/users/yamaneko1212/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yamaneko1212/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yamaneko1212/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yamaneko1212",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-05-02T06:28:24Z | 2021-09-08T23:05:12Z | 2014-05-02T06:29:38Z | NONE | resolved | Fix typo
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2031/reactions"
} | https://api.github.com/repos/psf/requests/issues/2031/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2031.diff",
"html_url": "https://github.com/psf/requests/pull/2031",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2031.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2031"
} | true | [
"Thanks for this!\n\nHowever, that typo is actually in our included copy of [urllib3](https://github.com/shazow/urllib3). You should raise this pull request on that repository: we'll then get the fix when we update our copy.\n",
"OK. I will.\n"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.