patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1979,6 +1979,10 @@ class ModelAverage(Optimizer):
@signature_safe_contextmanager
def apply(self, executor, need_restore=True):
"""Apply average values to parameters of current model.
+
+ Args:
+ executor(fluid.Executor): current executor.
+ need_restore(bool): If you ... | [AdamaxOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_finish_update->[_get_accumulator],_create_accumulators->[_add_accumulator]],MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],Optimizer->[apply_gradients->[_create_optimizati... | Apply average values to current model. | Please say the default value of `need_restore ` in this doc. |
@@ -2456,7 +2456,6 @@ public class KafkaIndexTaskTest
null,
null,
null,
- null,
true,
reportParseExceptions,
handoffConditionTimeout,
| [KafkaIndexTaskTest->[readSegmentColumn->[getSegmentDirectory],setupTest->[getTopicName,generateRecords],testIncrementalHandOffReadsThroughEndOffsets->[generateSinglePartitionRecords],createTask->[createTask],testRestoreAfterPersistingSequences->[generateSinglePartitionRecords]]] | create a new task with the given parameters. | Change is unrelated to the PR. |
@@ -38,6 +38,7 @@ import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import javax.annotation.Nullable;
+import org.apache.beam.sdk.coders.CannotProvideCoderException;
import org.apache.beam.sdk.coders.Coder;
import org.apache.beam.sdk.io.BoundedS... | [SourceTestUtils->[assertSplitAtFractionFails->[assertSplitAtFractionBehavior],assertSplitAtFractionBehaviorImpl->[readRemainingFromReader,readNItemsFromUnstartedReader],assertListsEqualInOrder->[equals],assertSplitAtFractionBehavior->[readFromSource],assertSplitAtFractionExhaustive->[readFromSource,assertSplitAtFracti... | This method imports all the necessary packages for the given object. This is a helper method that allows for testing a large number of test coverage with few code. | Source.getDefaultOutputCoder is also called from a bunch of other methods in SourceTestUtils. Those methods need to have new overloads where the user provides a Coder explicitly, for the same reason as above. |
@@ -563,3 +563,9 @@ func getVaultSecretGroup(linuxProfile *api.LinuxProfile) []compute.VaultSecretGr
}
return vaultSecretGroups
}
+
+func addCustomTagsToVM(cs *api.ContainerService, vm *compute.VirtualMachine) {
+ for key, value := range cs.Properties.MasterProfile.CustomVMTags {
+ vm.Tags[key] = &value
+ }
+}
| [HasSecrets,StringPtr,VirtualMachineSizeTypes,GetKubernetesWindowsNodeCustomDataJSONObject,Atoi,GetKubernetesLinuxNodeCustomDataJSONObject,BoolPtr,IsStorageAccount,GetMasterCustomDataJSONObject,IsWindows,HasAvailabilityZones,TrimSpace,PrivateJumpboxProvision,HasCustomImage,Sprintf,Unmarshal,Int32Ptr,GetEnableWindowsUpd... | Get the vault secret groups. | where does the equivalent happen for agentpool VMs? |
@@ -197,7 +197,12 @@ async def run_python_test(
env=env,
)
result = await Get[FallibleExecuteProcessResult](ExecuteProcessRequest, request)
- return TestResult.from_fallible_execute_process_result(result)
+ return TestResult.from_fallible_execute_process_result(
+ result,
+ covera... | [setup_pytest_for_target->[get_coveragerc_input,get_packages_to_cover,calculate_timeout_seconds,TestTargetSetup]] | Runs pytest for one target. | Ew. I think you can get prettier output if you wrap this in parantheses like `(PytestCov(...) if foo else None)`. Then Black should clean it up. |
@@ -565,3 +565,9 @@ func (r *AddressCollection) Scan(value interface{}) error {
*r = collection
return nil
}
+
+// Configuration stores key value pairs for overriding global configuration
+type Configuration struct {
+ Name string `gorm:"not null;unique;index"`
+ Value string `gorm:"not null"`
+}
| [UnmarshalText->[UnmarshalText],Scan->[setString],Hex->[ToInt],MarshalText->[MarshalText],ToStrings->[Hex],Value->[ToStrings,String],Delete->[Delete],CanStart->[Unstarted,Pending],Add->[Merge],Pending->[PendingBridge,PendingSleep,PendingConfirmations,PendingConnection],MarshalJSON->[MarshalJSON,MarshalText],Merge->[Val... | Scan scans the AddressCollection from the given value. | For simplicity's sake, do we want this to have an integer primary key? If not, shall we just make `name` the primary key? I feel uneasy about a table with no primary key. As you know, embedding `gorm.Model` gives us an ID PK, and createdAt for little cost. |
@@ -220,7 +220,7 @@ class TestPretrainedTransformerEmbedder(AllenNlpTestCase):
assert (unfolded_embeddings_out == unfolded_embeddings).all()
def test_encoder_decoder_model(self):
- token_embedder = PretrainedTransformerEmbedder("facebook/bart-large", sub_module="encoder")
+ token_embedder ... | [TestPretrainedTransformerEmbedder->[test_end_to_end->[PretrainedTransformerIndexer,Vocabulary,PretrainedTransformerTokenizer,from_params,tokens,Batch,index_instances,get_padding_lengths,max,token_embedder,tokenize,size,len,as_tensor_dict,Instance,Params,TextField],test_fold_long_sequences->[LongTensor,,PretrainedTrans... | Test encoder decoder model. | Did they rename this back? I'm so confused because I think I had to add the `facebook/` part a few weeks ago. |
@@ -84,7 +84,6 @@ public class OrganizationMembershipTest {
@Test
public void new_user_should_not_become_member_of_default_organization() throws Exception {
String login = createUser();
-
verifyMembership(login, "default-organization", false);
}
| [OrganizationMembershipTest->[createUser->[createUser]]] | Add and remove member of default organization. | Out of curiosity: What does `bis` (in the commit message) mean? |
@@ -118,5 +118,12 @@ module Engine
@index += 1
setup_phase!
end
+
+ private
+
+ def train_limit_increase(entity)
+ ability = entity.abilities(:train_limit)
+ ability.any? ? ability.first.increase : 0
+ end
end
end
| [Phase->[close_companies_on_train!->[closed?,corporation,close!,each,name,abilities],available?->[find_index],setup_phase!->[trigger_events!,join,dig],buying_train!->[close_companies_on_train!,send,next!,each,rust_trains!,sym,clear],next!->[setup_phase!],rust_trains!->[rusted,new,owner,obsolete,sym,include?,rusts_on,ru... | Sets the next sequence element to a . | entity.abilities(:train_limit) { |ability| return ability.increase } 0 |
@@ -76,6 +76,10 @@ public class LogicalPlanner {
public OutputNode buildPlan() {
PlanNode currentNode = buildSourceNode();
+ if (!analysis.getTableFunctions().isEmpty()) {
+ currentNode = buildFlatMapNode(currentNode, functionRegistry);
+ }
+
if (analysis.getWhereExpression().isPresent()) {
... | [LogicalPlanner->[buildNonJoinNode->[getAlias,size,IllegalStateException,get,DataSourceNode,getDataSource,PlanNodeId],buildOutputKeyField->[getPartitionBy,isMetaColumn,isPresent,getSchema,get,isKeyColumn,withName,empty,name,getKeyField],buildPlan->[isPresent,buildAggregateNode,get,buildSourceNode,buildProjectNode,build... | Builds the plan. | nit: no need to pass field to non-static method. |
@@ -209,14 +209,14 @@ public abstract class AbstractCIBase extends Node implements ItemGroup<TopLevelI
return computers.get(n);
}
- protected void updateNewComputer(final Node n, boolean automaticSlaveLaunch) {
+ protected void updateNewComputer(final Node n, boolean automaticAgentLaunch) {
... | [AbstractCIBase->[interruptReloadThread->[interruptReloadThread],updateNewComputer->[createNewComputerForNode,getComputerMap,getNodeName],removeComputer->[run->[getComputerMap]],updateComputerList->[run->[updateComputer,getNodes,getNodeName],getComputerMap,killComputer],updateComputer->[getNodeName],createNewComputerFo... | Checks if a computer is available for a given node. If it is available it will be. | Strictly speaking also a production code change: IDE assisted variable rename. |
@@ -568,7 +568,9 @@ public class MapPanel extends ImageScrollerLargeView {
g2d.drawImage(mouseShadowImage, t, this);
}
if (routeDescription != null) {
- routeDrawer.drawRoute(g2d, routeDescription, movementLeftForCurrentUnits);
+ routeDrawer.drawRoute(g2d, routeDescription, movementLeftForCur... | [MapPanel->[setTopLeft->[setTopLeft],setRoute->[setRoute],setTerritoryOverlayForBorder->[setTerritoryOverlayForBorder],getTerritory->[getTerritory],paint->[normalizeX,paint,normalizeY],notifyMouseMoved->[mouseMoved],getErrorImage->[getErrorImage],BackgroundDrawer->[run->[getData]],attachmentChanged->[updateCountries],g... | Override paint to draw the missing tile in the background. private int alpha ; draw the tiles nearest us first missing missing tiles. | It would be nice if drawRoute would continue to only accept 3 arguments, the third one being a wrapper object to wrap the last 3 objects. This would keep the related stuff together and the parameter declarations relatively clean. |
@@ -1554,8 +1554,10 @@ namespace DotNetNuke.Entities.Urls
//check ssl enforced
if (portalSettings.SSLEnforced)
{
+ var isSecureConnectionOnUnsecurePage = !portalSettings.ActiveTab.IsSecure && result.IsSecureConnection;
+ ... | [AdvancedUrlRewriter->[IgnoreRequest->[IgnoreRequestForWebServer,IgnoreRequestForInstall],RewriteAsChildAliasRoot->[RewriteUrl],IdentifyPortalAlias->[RedirectPortalAlias,ConfigurePortalAliasRedirect,IsPortalAliasIncorrect],Handle404OrException->[ShowDebugData],ConfigurePortalAliasRedirect->[CheckIfAliasIsCustomTabAlias... | Checks if a request is a secure redirect. function to handle redirect and redirectSecure requests. | Is there any other way to prevent this check from being added to all requests? A higher level change possibly? |
@@ -138,7 +138,13 @@ public class YeOldePlumberSchool implements PlumberSchool
IndexMerger.mergeMMapped(indexes, schema.getAggregators(), fileToUpload);
}
- final DataSegment segmentToUpload = theSink.getSegment().withVersion(version);
+ // Map merged segment so we can extrac... | [YeOldePlumberSchool->[findPlumber->[spillIfSwappable->[persist]]]] | Returns a plumber that can be used to upload a single segment. Spill the index if it is swappable. | mapDir() is deprecated with the newest code. Switch it to a QueryableIndex and loadIndex() instead. Everything else should work. |
@@ -44,6 +44,7 @@ import {startsWith} from '../string';
* @typedef {{
* attr: (string|undefined),
* type: (string|undefined),
+ * attrPrefix: (string|undefined),
* attrs: (!Array<string>|undefined),
* parseAttrs: ((function(!Element):*)|undefined),
* default: *,
| [No CFG could be retrieved] | Package containing functions for importing and importing a single component. Initializes the object of the type . | Please also add to the docs few lines above that explain the "one of" nature of `attr`, `attrs` and now `attrPrefix`. |
@@ -94,3 +94,15 @@ function urlIsSameOrigin(requestUrl) {
return (parsed.protocol === originUrl.protocol &&
parsed.host === originUrl.host);
}
+
+ /**
+ * Parse a request URL & determine if its file protocol to avoid $$cookieReader of XSRF token in case of file.
+ *
+ * @param {string|object} request... | [No CFG could be retrieved] | Check if the origin URL is the same protocol and host as the origin URL. | This line is incorrect. |
@@ -776,5 +776,7 @@ def multi_box_head(inputs,
box = tensor.concat(reshaped_boxes)
var = tensor.concat(reshaped_vars)
+ mbox_locs_concat = tensor.concat(mbox_locs, axis=1)
+ mbox_confs_concat = tensor.concat(mbox_confs, axis=1)
- return mbox_locs, mbox_confs, box, var
+ return ... | [multi_box_head->[_is_list_or_tuple_and_equal->[_is_list_or_tuple_],_is_list_or_tuple_and_equal,_is_list_or_tuple_,_prior_box_,_reshape_with_axis_],ssd_loss->[target_assign,bipartite_match,__reshape_to_2d]] | This function is a wrapper for the SSD MultiBox Detector. Parameters for the prior box layer. Network parameters for the prior_box and prior_var functions. Computes the n - layer base - size and n - ratio of the data. | Please update the doc. |
@@ -131,8 +131,8 @@ public abstract class AbstractCIBase extends Node implements ItemGroup<TopLevelI
}
}
}
+ used.add(c);
}
- used.add(c);
}
/*package*/ void removeComputer(final Computer computer) {
| [AbstractCIBase->[interruptReloadThread->[interruptReloadThread],removeComputer->[run->[getComputerMap]],updateComputerList->[run->[updateComputer,getNodes,getNodeName],getComputerMap,killComputer],updateComputer->[getComputerMap,getNodeName],getComputer->[getComputerMap]]] | Updates the Computer for a given node. | there's a chance `c` is going to be `null` here right? Granted a node with no executor should be quite rare I guess but well :). Or maybe the passed `used` container accepts null values? |
@@ -77,7 +77,7 @@ describe InfoRequest::State::Calculator do
"waiting_response" => "I'm still <strong>waiting</strong> for my information <small>(maybe you got an acknowledgement)</small>",
"waiting_clarification" => "I've been asked to <strong>clarify</strong> my request",
"... | [create,days,new,let,describe,time_travel_to,date_response_required_by,date_very_overdue_after,it,to,before,shared_examples_for,require,it_behaves_like,transitions,shared_examples,each,set_described_state,awaiting_description,context,eq,save,and_return] | requires admin_states to be set nanoopime - related functions. | Line is too long. [96/80] |
@@ -195,7 +195,9 @@ def get_rc_urls():
return rc['channels']
def is_url(url):
- return url and urlparse.urlparse(url).scheme != ""
+ if url:
+ p = urlparse.urlparse(url)
+ return p.netloc != "" or p.scheme == "file"
def binstar_channel_alias(channel_alias):
if channel_alias.startswit... | [url_channel->[canonical_channel_name],get_allowed_channels->[normalize_urls],_pathsep_env->[_default_envs_dirs],normalize_urls->[get_local_urls,get_default_urls,is_url,binstar_channel_alias,get_rc_urls],canonical_channel_name->[get_local_urls,get_default_urls,canonical_channel_name,remove_binstar_tokens],get_channel_u... | Check if a URL is a known NCBI URL. | @mingwandroid @kalefranz @msarahan I'm a bit concerned about the fragility here. This successfully passes `file:///` URLs and rejects Unix and Windows paths. But are there other URL types we need to be concerned about with the three-slash model; e.g., `netloc == ""`? |
@@ -172,7 +172,6 @@ namespace System.Runtime.InteropServices
public string Value { get { throw null; } }
}
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
- [System.ObsoleteAttribute("ComAwareEventInfo may be unavailable in future releases.")]
... | [TypeLibFuncAttribute->[Method],ComEventsHelper->[Never],ErrorWrapper->[Never],CONNECTDATA->[Never,Sequential],ComAwareEventInfo->[Never],IDispatchConstantAttribute->[Field,Parameter],ClassInterfaceAttribute->[Class,Assembly],IUnknownConstantAttribute->[Field,Parameter],DispIdAttribute->[Event,Property,Field,Method],Ma... | A class that is used to create a class that implements the standard System. Attribute interface. This is a hack to allow the caller to override the base class s methods. | Were these only in the refs rather than also being in the implementation? |
@@ -81,8 +81,9 @@ if (zen_not_null($action)) {
}
//set products_status
- if ($products_status == '') continue;
-
+ if ($products_status == '')
+ continue;
+
//only execute if a change was selected
$sql = "SELECT products_id
... | [Execute,display_count,get_allow_add_to_cart,get_handler,infoBox,add_session,notify,display_links,RecordCount,add] | Dodaje nazwy kategorii Link to category product listing page. | Suggest including braces here, for clarity. |
@@ -205,6 +205,7 @@ public class AsynchronousUntilSuccessfulProcessingStrategy extends AbstractUntil
try {
mutableEvent.setMessage(MuleMessage.builder(mutableEvent.getMessage())
.exceptionPayload(new DefaultExceptionPayload(buildRetryPolicyExhaustedException(lastException))).build());
+ muta... | [AsynchronousUntilSuccessfulProcessingStrategy->[retrieveAndProcessEvent->[removeFromStore],incrementProcessAttemptCountAndRescheduleOrRemoveFromStore->[scheduleForProcessing],storeEvent->[storeEvent]]] | abandonRetries - Abandon retries. | Is there a JIRA created to remove exceptionPayload? |
@@ -6,7 +6,8 @@
* into the [googlemaps http://...] shortcode format
*/
function jetpack_googlemaps_embed_to_short_code( $content ) {
- if ( false === strpos( $content, 'maps.google.' ) && 1 !== preg_match( '@google\.[^/]+/maps@', $content ) )
+
+ if ( false === strpos( $content, 'maps.google.' ) && 1 !== preg_matc... | [No CFG could be retrieved] | This function is used to embed google maps to a short code. Embeds to a Google Maps short code map in a larger map. Parse the content of a tag that is not a link to a Google Maps embed to a. | Could this be changed to `preg_match( '@google\.[^/]+/maps?@', $content )` instead? Or is `(maps|map)` more efficient/optimized? |
@@ -127,7 +127,7 @@ class SecretClient(_AsyncKeyVaultClientBase):
:type tags: dict(str, str)
:returns: The created secret
:rtype: ~azure.keyvault.secrets._models.SecretAttributes
- :raises: ~azure.core.exceptions.ClientRequestError if the client failed to create the secret
+ :ra... | [SecretClient->[recover_deleted_secret->[recover_deleted_secret],restore_secret->[restore_secret],set_secret->[set_secret],purge_deleted_secret->[purge_deleted_secret],delete_secret->[delete_secret],get_secret->[get_secret],get_deleted_secret->[get_deleted_secret],update_secret->[update_secret],backup_secret->[backup_s... | Updates the attributes associated with a specified secret in the key vault. Get the missing secret attributes. | Does this render correctly? I wonder whether the comma is problematic. |
@@ -6,8 +6,7 @@ import java.util.List;
class AbstractMoveExtendedDelegateState implements Serializable {
private static final long serialVersionUID = -4072966724295569322L;
Serializable superState;
- // add other variables here:
- public boolean m_nonCombat;
+ // add other variables here
public List<Undoab... | [No CFG could be retrieved] | The base class for all the state of an extended delegate. | So, if this field is removed, and a new save game is generated and sent to an older client, the old client will always end up with a value of `false` for this field. That may be ok. However, if an older client happens to use this field and stores a `true` value, then round-tripping the save game between this client and... |
@@ -48,6 +48,12 @@ def get_current_tracker():
return None
+def for_test():
+ from apache_beam.utils.counters import CounterFactory
+ set_current_tracker(StateSampler('test', CounterFactory()))
+ return get_current_tracker()
+
+
StateSamplerInfo = namedtuple(
'StateSamplerInfo',
['state_name',
| [StateSampler->[start->[set_current_tracker],stop->[set_current_tracker],stop_if_still_running->[stop]]] | Creates a state sampler class that can be used to sample the current state of a pipeline. A property that indicates the name of the last known node in the sequence. | Can we move this to the top? There don't seem to be any circular dependency issues. |
@@ -73,6 +73,14 @@ class RawBrainVision(BaseRaw):
verbose : bool, str, int, or None
If not None, override default verbose level (see :func:`mne.verbose`
and :ref:`Logging documentation <tut_logging>` for more).
+ trig_shift_by_type: dict | None
+ The names of marker types to which an of... | [read_raw_brainvision->[RawBrainVision],_get_vhdr_info->[_check_hdr_version]] | Initialize a new object. Reads the from the given Montage file. | rewording, it took me long time to understand it. (I'll propose something) |
@@ -26,6 +26,8 @@ import {installGlobalSubmitListenerForDoc} from '../document-submit';
import {installHiddenObserverForDoc} from './hidden-observer-impl';
import {installHistoryServiceForDoc} from './history-impl';
import {installImg} from '../../builtins/amp-img';
+import {installInaboxCidService} from '../inabox/... | [No CFG could be retrieved] | Package that imports all components of a single unit of work. Installs built - ins. | Are these pure imports? I'm worried this will bring in a bunch of inabox files into the v0.js runtime. |
@@ -241,7 +241,6 @@ public class ReferenceConfig<T> extends ReferenceConfigBase<T> {
ModuleServiceRepository repository = getScopeModel().getServiceRepository();
repository.unregisterConsumer(consumerModel);
}
- getScopeModel().getConfigManager().removeConfig(this);
}
... | [ReferenceConfig->[destroy->[destroy],postProcessRefresh->[postProcessRefresh,checkAndUpdateSubConfigs],getSubscribedServices->[getServices],postProcessAfterScopeModelChanged->[postProcessAfterScopeModelChanged],createInvokerForRemote->[get],checkInvokerAvailable->[destroy],createProxy->[get],completeCompoundConfigs->[... | Destroy the ReferenceConfig. | pls desc why remove this |
@@ -695,7 +695,6 @@ func (s *Service) GetExplorerAddress(w http.ResponseWriter, r *http.Request) {
balance, err := s.GetAccountBalance(address)
if err == nil {
balanceAddr = balance
- data.Address.Balance = balance
}
}
| [ReadBlocksFromDB->[Msg,Error,DecodeBytes,Get,Exit,Logger],GetExplorerAddress->[Warn,Encode,Info,Set,Atoi,WithCallerSkip,NewEncoder,Cmp,GetLogInstance,FormValue,Logger,GetAccountBalance,Get,Err,Str,Header,Msg,GetDB,DecodeBytes,NewInt,ParseAddr,WriteHeader],GetExplorerShard->[Header,Msg,WriteHeader,GetNodeIDs,Warn,IDB58... | GetExplorerAddress returns the address of an explorer getAccountBalance returns the account balance of the node. | why remove this line? |
@@ -106,7 +106,7 @@ public abstract class TestStreamProcessor {
long lowWatermark = processor.getLowWatermark();
log.info("low: " + lowWatermark + " dist: " + (targetWatermark - lowWatermark));
}
- double elapsed = (double) (System.currentTimeMillis() - start) /... | [TestStreamProcessor->[testComputationPolicy->[getLogManager,getSameLogManager],testSimpleTopo->[getLogManager],testInvalidProcessorWithMultipleInputCodec->[getLogManager],testComplexTopoFewRecordsOneThreadOnePartition->[testComplexTopo],testComplexTopo->[getLogManager],testSimpleTopoOneRecordOneThreadAvroJsonCodec->[t... | testSimpleTopo - test simple topology with n records read the results of a single chunk of data from the stream manager and check if it matches. | Not sure why you backport cleanups, this doesn't help reading the code. |
@@ -5040,6 +5040,15 @@ ParseNode * Parser::ParseFncDecl(ushort flags, LPCOLESTR pNameHint, const bool n
}
}
+ if (buildAST && fDeclaration)
+ {
+ Symbol* funcSym = pnodeFnc->GetFuncSymbol();
+ if (funcSym->GetIsFormal())
+ {
+ GetCurrentFunctionNode()->SetHasAnyWrit... | [No CFG could be retrieved] | Check if a function is found in the array of functions. Determines if a sequence of tokens can be parsed by a function or generator. | it is interesting to see not all the places (where we do SetHasAnyWriteToFormals) we check for buildAST (which we should). |
@@ -202,8 +202,8 @@ public class SequenceIdGenerator {
}
try {
- sequenceIdTable.putWithBatch(transactionBuffer
- .getCurrentBatchOperation(), sequenceIdName, newLastId);
+ transactionBuffer
+ .addToBuffer(sequenceIdTable, sequenceIdName, newLastId);
} catch (I... | [SequenceIdGenerator->[getNextId->[Batch],StateManagerHAImpl->[Builder->[build->[StateManagerHAImpl]]]]] | Allocate a batch for the given sequenceIdName. | You need also remove `Preconditions.checkNotNull(ratisServer);` in line 248 |
@@ -207,11 +207,14 @@ func (executer *UpkeepExecuter) execute(upkeep UpkeepRegistration, headNumber in
runErrors = pipeline.RunErrors{null.StringFrom(errors.Wrap(err, "UpkeepExecuter: failed to construct upkeep txdata").Error())}
}
- var etx bulletprooftxmanager.EthTx
- ctxQuery, cancel := postgres.DefaultQueryC... | [processActiveUpkeeps->[Done,Wait,Debugw,DefaultQueryCtx,Errorf,EligibleUpkeepsForRegistry,Info,KeeperMaximumGracePeriod,Add,Retrieve,execute],Start->[Deliver,StartOnce,Done,Add,run,Subscribe],Close->[StopOnce,Wait],OnNewLongestChain->[Deliver],run->[Notify,processActiveUpkeeps,Done],constructCheckUpkeepCallMsg->[Keepe... | execute executes an upkeep transaction UpkeepExecuter is a helper function to create a new transaction for the given upkeep finished run - finished run - finished run - finished run - finished run - finished run -. | could we just knock that out in this PR too? |
@@ -676,7 +676,15 @@ int WorldSocket::ProcessIncoming(WorldPacket* new_pct)
switch (opcode)
{
case CMSG_PING:
- return HandlePing (*new_pct);
+ {
+ try
+ {
+ return HandlePing(*new_pct);
+ }
+ ... | [No CFG could be retrieved] | The main entry point for the world socket. This function is called when a packet is received from the client. | shouldn't we add the`outError` inside the `catch` block ? |
@@ -2721,11 +2721,13 @@ def batch_gather(params, indices, name=None):
raise ValueError("batch_gather does not allow indices with unknown "
"shape.")
batch_indices = indices
+ dtype = indices.dtype
accum_dim_value = 1
for dim in range(ndims-1, 0, -1):
dim_value = p... | [identity->[identity],reverse_sequence->[reverse_sequence],zeros->[_constant_if_small],boolean_mask->[_apply_mask_1d,shape,concat],rank_internal->[size,rank],_SliceHelperVar->[_slice_helper],sparse_placeholder->[_normalize_sparse_shape,placeholder],quantize->[quantize_v2],transpose->[rank],_get_dtype_from_nested_lists-... | Gather slices from params according to indices with leading batch dims. Compute the nanoseconds for the given batch. | Initialize it to dtype(1) as well? |
@@ -2,4 +2,4 @@
idv_gpo_path,
method: 'put',
class: 'usa-button usa-button--big usa-button--wide',
- form_class: 'inline-block margin-right-2' %>
+ form_class: 'margin-right-2' %>
| [No CFG could be retrieved] | IDV GPO path. | I removed the `inline-block` since it was preventing the button from being full width on mobile. |
@@ -669,6 +669,16 @@ def main(cli_args=sys.argv[1:]):
sys.excepthook = functools.partial(_handle_exception, config=config)
+ # Avoid conflicting args
+ conficting_args = ["quiet", "noninteractive_mode", "text_mode"]
+ if config.dialog_mode:
+ for arg in conficting_args:
+ if getattr(... | [revoke->[revoke,_determine_account],setup_logging->[setup_log_file_handler],_treat_as_renewal->[_handle_identical_cert_request,_handle_subset_cert_request],install->[_init_le_client,_find_domains],run->[_init_le_client,_auth_from_domains,_find_domains,_suggest_donation_if_appropriate],main->[setup_logging],_csr_obtain... | Entry point for the certbot - index script. Provide a function to display a . | Sorry I didn't catch this last night, but this code is really just part of command line parsing. We should probably move it to `parse_args` (or a function/method called by `parse_args`) in `cli.py` instead of `main.py`. This allows you to move your test back in to `cli.py`, mitigating your code duplication problem. |
@@ -378,6 +378,7 @@ if (empty($reshook))
$action = '';
setEventMessages($langs->trans("RecordSaved"), null, 'mesgs');
$db->commit();
+ $object->updatePriceFromExpression();
} else {
$action = 'edit_price';
$db->rollback();
| [fetch,log_price_delete,create,fetch_all_log,list_price_expression,fetch_object,jdate,lasterrno,isVariant,getNomUrl,rollback,fetch_all,begin,initHooks,load,selectPriceBaseType,transnoentities,executeHooks,getRights,loadLangs,update,load_tva,min_recommended_price,close,showFilterAndCheckAddButtons,delete,textwithpicto,f... | Updates an object s price with the given parameters. Activates or disables price by quantity. | This is outside the transaction ? After the commit ? Why ? Must be before the test if (empty($error)) { |
@@ -566,6 +566,7 @@ var forbiddenTermsSrcInclusive = {
// Functions
'\\.changeHeight\\(': bannedTermsHelpString,
'\\.changeSize\\(': bannedTermsHelpString,
+ '\\.attemptChangeHeight\\(0\\)': 'please consider using `attemptCollapse()`',
'\\.collapse\\(': bannedTermsHelpString,
'\\.focus\\(': bannedTermsH... | [No CFG could be retrieved] | A list of possible expectations for a message. JS extensions. | Why not use a `dev().assert`? We could catch both `height = 0` and `width = 0` changes then. |
@@ -615,8 +615,9 @@ def fetch_langpack(url, xpi, **kw):
sign_file(file_, settings.SIGNING_SERVER)
# Finally, set the addon summary if one wasn't provided in the xpi.
- addon.update(status=amo.STATUS_PUBLIC,
- summary=(addon.summary if addon.summary else addon.name))
+ ... | [notify_compatibility->[completed_version_authors,updated_versions],bulk_validate_file->[tally_job_results]] | Fetches a language pack from the given url and xpi. Add a new language pack if it doesn t already exist. This function creates a new language pack object and adds it to the database. | I'm scratching my head why this does something different than the `.update` statement but I believe you |
@@ -56,13 +56,7 @@ public final class WriteBufferWaterMark {
*/
WriteBufferWaterMark(int low, int high, boolean validate) {
if (validate) {
- checkPositiveOrZero(low, "low");
- if (high < low) {
- throw new IllegalArgumentException(
- "writ... | [WriteBufferWaterMark->[toString->[toString],WriteBufferWaterMark]] | Creates a new instance of the class which can be used to write a buffer s . | This produces a worse error message. |
@@ -17,14 +17,16 @@ install_requires = [
'zope.interface',
]
-if not os.environ.get('EXCLUDE_CERTBOT_DEPS'):
+if not os.environ.get('SNAP_BUILD'):
install_requires.extend([
'acme>=0.29.0',
'certbot>=1.1.0',
])
elif 'bdist_wheel' in sys.argv[1:]:
- raise RuntimeError('Unset EXCLUD... | [PyTest->[initialize_options->[initialize_options]]] | Creates a test class that runs the given command. This is a hack to work around the problem with the C - like code in the C. | this is just the first name that came to mind. happy to change it. |
@@ -181,6 +181,10 @@ function profile_content(&$a, $update = 0) {
$commpage = (($a->profile['page-flags'] == PAGE_COMMUNITY) ? true : false);
$commvisitor = (($commpage && $remote_contact == true) ? true : false);
+ if(feature_enabled($a->profile['profile_uid'],'photos_widget')) {
+ require_once('include/pho... | [profile_content->[set_pager_itemspage,get_baseurl,set_pager_total],profile_init->[get_baseurl,get_hostname]] | profile_content - Profile content The main entry point for the contact visitor. Renders the block - level menu Get permissions SQL - if remote user has not been preverified and we have fetched his or check if there are any tags that are blocked on the user check if the user has a limit on the number of items that can b... | I would prefer to have `require_once()` always on top of the page, not in the code |
@@ -126,13 +126,6 @@ func (k *kubeScheduler) Deploy(ctx context.Context) error {
service = k.emptyService()
deployment = k.emptyDeployment()
- labels = map[string]string{
- v1beta1constants.LabelApp: v1beta1constants.LabelKubernetes,
- v1beta1constants.LabelRole: labelRole,
- }
- labelsWithControlPla... | [reconcileShootResources->[emptyManagedResource,emptyManagedResourceSecret]] | Deploy deploys the Kubernetes cluster The list of ports that can be managed by the control - plane This function returns a JSON object with all of the properties of the object that are passed to The object that will create a resource in the cluster. | Can you also adapt it for the `clusterautoscaler` pkg? |
@@ -219,6 +219,18 @@ def _NotNone(v):
return v
+def _FilterTuple(v):
+ if not isinstance(v, (list, tuple)):
+ return v
+ if isinstance(v, tuple):
+ if not True in [isinstance(x, (list, tuple)) for x in v]:
+ return None
+ if isinstance(v, list):
+ if not True in [isinstance(x, (list,... | [constant_value_as_shape->[constant_value_as_shape,constant_value],_NotNone->[_Message],_FilterBool->[_FirstNotNone,_FilterBool,_NotNone],make_tensor_proto->[_GetDenseDimensions,_AssertCompatible,_FlattenToStrings,GetNumpyAppendFn],_FlattenToStrings->[_FlattenToStrings],_FilterFloat->[_FirstNotNone,_NotNone,_FilterFloa... | Filters out integers. | this creates a python list each time. use the function `any(isinstance(x, (list, tuple)) for x in v)` |
@@ -46,6 +46,14 @@ class Bzip2(Package):
filter_file('-Wall -Winline', '-Minform=inform', 'Makefile')
filter_file('-Wall -Winline', '-Minform=inform', 'Makefile-libbz2_so') # noqa
+ # The Makefiles use GCC flags that are incompatible with XL and nvcc
+ if self.compiler.name ==... | [Bzip2->[install->[install,join_path,symlink,working_dir,up_to,format,force_remove,make],patch->['$,filter,up_to,filter_file,format,FileFilter],libs->[find_libraries],variant,depends_on,version]] | Patch bzip2 to use a specific version of C - C. Remove any missing segments in the v2 and v3 directories. | ~~Isn't the XL equivalent flag `-fPIC`?~~ Since XL supports at least `-fPIC`, why not use that one? Otherwise we will have a compiler-dependent "split" of the binary artifact in terms of usability in shared objects further downstream. |
@@ -11,7 +11,7 @@ class ServiceProviderRequestProxy
cattr_accessor :redis_last_uuid
def self.from_uuid(uuid)
- find_by(uuid: uuid) || NullServiceProviderRequest.new
+ find_by(uuid: uuid.to_s) || NullServiceProviderRequest.new
rescue ArgumentError # a null byte in the uuid will raise this
NullServi... | [ServiceProviderRequestProxy->[last->[find_by],create!->[create],write->[write],find_or_create_by->[find_by],delete->[delete]]] | Returns a object for the given uuid. If no such object exists a new one is. | Thanks for the fix and even more, the tests to ensure we don't regress! |
@@ -34,6 +34,10 @@ const (
// CompactorRingKey is the key under which we store the compactors ring in the KVStore.
CompactorRingKey = "compactor"
+
+ // GetBufferSize is the suggested size of buffers passed to Ring.Get(). It's based on
+ // a typical replication factor 3, plus extra room for a JOINING + LEAVING i... | [RegisterFlagsWithPrefix->[RegisterFlagsWithPrefix]] | Reads a single key from the ring. Get a replication set for the given operation. | Nit: it makes sense for caller to pass buffer for ingesters, because `Get` returns it back. Hosts/zones buffers are only optimizations, and using a ring-specific pool (shared with subrings) may be a good alternative, without a need to change `Get` call. |
@@ -877,10 +877,12 @@ class ConanAPIV1(object):
if remote_ref.ordered_packages:
for package_id, properties in remote_ref.ordered_packages.items():
package_recipe_hash = properties.get("recipe_hash", None)
+ # Artifactory uses field 'requires', conan_... | [_get_conanfile_path->[_make_abs_path],ConanApp->[load_remotes->[load_remotes]],get_graph_info->[info],ConanAPIV1->[export_alias->[export_alias],remote_list->[load_remotes],export->[_get_conanfile_path,_make_abs_path,load_remotes,info],info->[info,load_remotes,ProfileData,_info_args,_make_abs_path],install->[ProfileDat... | Search for packages in a remote repository. Get the info of a node. | Ok, but knowing that ``requires`` is the ``zlib/1.X.Y`` converted version, used for the package_id hash. This probably requires normalization in the server side too? |
@@ -186,10 +186,8 @@ class PostCreator
@post.link_post_uploads
update_uploads_secure_status
ensure_in_allowed_users if guardian.is_staff?
- unarchive_message
- if !@opts[:import_mode]
- DraftSequence.next!(@user, draft_key)
- end
+ unarchive_message if !@o... | [PostCreator->[save_post->[skip_validations?],draft_key->[draft_key],build_post_stats->[track_post_stats],update_uploads_secure_status->[update_uploads_secure_status],store_unique_post_key->[store_unique_post_key],create!->[create!],create->[create,valid?],handle_spam->[skip_validations?,create],ensure_in_allowed_users... | Creates a new unique key in the system. | Is this fixing a bug? Might be worth extracting into another (and much smaller) PR. |
@@ -281,10 +281,9 @@ int ssl_parse_serverhello_use_srtp_ext(SSL *s, PACKET *pkt, int *al)
SRTP_PROTECTION_PROFILE *prof;
if (!PACKET_get_net_2(pkt, &ct)
- || ct != 2
- || !PACKET_get_net_2(pkt, &id)
- || !PACKET_get_1(pkt, &mki)
- || PACKET_remaining(pkt) != 0) {
... | [ssl_parse_serverhello_use_srtp_ext->[SSL_get_srtp_profiles],ssl_add_clienthello_use_srtp_ext->[SSL_get_srtp_profiles],ssl_parse_clienthello_use_srtp_ext->[SSL_get_srtp_profiles]] | Internal function for parsing serverHELLO_USE_SRTP_EXT. return 1 if error. | This concatenation of two expressions makes the condition harder to read... |
@@ -1656,9 +1656,8 @@ SECURE_HSTS_SECONDS = config('SECURE_HSTS_SECONDS', default=0, cast=int)
SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTO', 'https')
# Auth and permissions related constants
-LOGIN_URL = reverse_lazy('account_login')
-LOGOUT_URL = reverse_lazy('account_logout')
-LOGIN_REDIRECT_URL = reverse_... | [pipeline_one_scss->[pipeline_scss],_get_locales->[path],path,_get_locales,pipeline_scss] | Config for the given user object. Provides a list of all the configuration options for the AccountAdapter. | Nice to get rid of the `reverse_lazy`. |
@@ -257,7 +257,6 @@ class TestPackaged(TestCase):
'SHA256-Digest: 3Wjjho1pKD/9VaK+FszzvZFN/2crBmaWbdisLovwo6g=\n\n'
)
- @responses.activate
def test_call_signing_too_long_guid_bug_1203365(self):
long_guid = 'x' * 65
hashed = hashlib.sha256(long_guid).hexdigest()
| [TestTasks->[test_dont_sign_dont_bump_sign_error->[assert_no_backup],test_dont_bump_not_signed->[assert_no_backup],assert_backup->[get_backup_file_path],test_dont_resign_dont_bump_version_in_model->[assert_no_backup],test_resign_bump_version_in_model_if_force->[assert_backup],test_sign_bump_old_versions_default_compat-... | Test call signing. | Out of interest, what did `@responses.activate` do why don't we need it any more? |
@@ -55,7 +55,7 @@ public abstract class AbstractProcessingStrategy implements ProcessingStrategy {
};
}
- protected ExecutorService decorateScheduler(Scheduler scheduler) {
+ protected ScheduledExecutorService decorateScheduler(ScheduledExecutorService scheduler) {
return scheduler;
}
| [AbstractProcessingStrategy->[DefaultReactorSink->[dispose->[dispose],accept->[intoSink,accept],emit->[intoSink,accept]]]] | Create on event consumer. | can the param and return type be `ExecutorService` (not `Scheduled*`)? Or does that change break something? |
@@ -178,6 +178,10 @@ func getHarmonyConfig(cmd *cobra.Command) (harmonyConfig, error) {
return harmonyConfig{}, err
}
+ if config.General.IsOffline {
+ config.P2P.IP = nodeconfig.DefaultLocalListenIP
+ }
+
return config, nil
}
| [Warn,LastCommitBitmap,SerializeToHexStr,Info,RunServices,Itoa,Rollback,SupportSyncing,ReadFile,SetParseErrorHandle,GetBoolFlagValue,New,Maximum,SetViewIDs,Fprint,SetBeaconGroupID,FindAccount,IsFlagChanged,Split,Seed,UpdateConsensusInformation,Println,FatalErrMsg,AddLogFile,ReshardingEpoch,BootstrapConsensus,SetMode,La... | getHarmonyConfig returns the config object for the given command. applyLogFlags applies the log flags for the node and the devnet log if the. | From my point of view, this piece of code are not supposed to be here. Can we move this piece of code to `applyGeneralFlags`, and then in `validateHarmonyConfig`, return an error when the p2p IP and offline settings is not consistent? |
@@ -91,8 +91,13 @@ FINGERPRINTS = {
CAR.CIVIC: [{
57: 3, 148: 8, 228: 5, 304: 8, 330: 8, 344: 8, 380: 8, 399: 7, 401: 8, 420: 8, 427: 3, 428: 8, 432: 7, 450: 8, 464: 8, 470: 2, 476: 7, 487: 4, 490: 8, 493: 5, 506: 8, 512: 6, 513: 6, 545: 6, 597: 8, 662: 4, 773: 7, 777: 8, 780: 8, 795: 8, 800: 8, 804: 8, 806: 8,... | [dbc_dict] | CIVIC - > CAR. A list of all possible values of the neccessary CARs. CRV_5G - CRV_5G. | `399:7`, missing space |
@@ -35,9 +35,7 @@ namespace System.Text.Json.Serialization
Type type = typeof(T);
Debug.Assert(!type.IsAbstract);
- // If ctor is non-public, we've verified upstream that it has the [JsonConstructorAttribute].
- Debug.Assert(type.GetConstructors(BindingFlags.Public | Bi... | [ReflectionMemberAccessor->[CreateAddMethodDelegate->[Invoke,GetMethod],CreateImmutableEnumerableCreateRangeDelegate->[GetImmutableEnumerableCreateRangeMethod,CreateDelegate],CreateImmutableDictionaryCreateRangeDelegate->[CreateDelegate,GetImmutableDictionaryCreateRangeMethod],CreatePropertyGetter->[Invoke,GetMethod],C... | Creates a parameterized constructor that can be called with the given arguments. | Are we missing tests here for the `BindingFlags.NonPublic` that we removed? |
@@ -307,6 +307,11 @@ namespace Content.Server.Buckle.Components
if (!force)
{
+ // Send message to entity to which mob is buckled to
+ var unbuckleAttemptMsg = new UnbuckleAttemptEvent(user, Owner);
+ Owner.EntityManager.EventBus.RaiseLocalEvent(B... | [BuckleComponent->[TryBuckle->[CanBuckle,ReAttach,UpdateBuckleStatus],TryUnbuckle->[UpdateBuckleStatus],OnRemove->[OnRemove,TryUnbuckle,UpdateBuckleStatus],Update->[TryUnbuckle],ToggleBuckle->[TryBuckle,TryUnbuckle],BuckleVerb->[Activate->[TryUnbuckle]],Startup->[UpdateBuckleStatus,Startup]]] | Try to unbuckle the component. | Move this below the timer check please. |
@@ -74,14 +74,15 @@ def get_product_discounts(
product: "Product",
collections: Iterable["Collection"],
discounts: Iterable[DiscountInfo],
- channel: "Channel"
+ channel: "Channel",
+ variant_id: Optional[int] = None
) -> Money:
"""Return discount values for all discounts applicable to a p... | [calculate_discounted_price->[get_product_discounts],fetch_discounts->[fetch_products,fetch_collections,fetch_categories,fetch_sale_channel_listings],fetch_active_discounts->[fetch_discounts],get_product_discounts->[get_product_discount_on_sale]] | Return discount values for all discounts applicable to a product. | Why `variant_id` is optional here and `product` is required? |
@@ -222,6 +222,7 @@ GenericAgentConfig *CheckOpts(int argc, char **argv)
GenericAgentWriteVersion(w);
FileWriterDetach(w);
}
+// TODO re-use SafeExit() here for windows
exit(EXIT_SUCCESS);
case 'h':
| [No CFG could be retrieved] | Reads the list of class names and returns a list of the names of the class that should Reads the configuration file and generates the avahi configuration file if it doesn t exist. | So why don't we do this here? Is there any reason why we shouldn't? |
@@ -58,11 +58,13 @@ public class ImmutableExecutableStageTest {
.setDoFn(RunnerApi.SdkFunctionSpec.newBuilder().setEnvironmentId("foo"))
.putSideInputs("side_input", RunnerApi.SideInput.getDefaultInstance())
.putStateSpecs("user_stat... | [ImmutableExecutableStageTest->[ofFullComponentsOnlyHasStagePTransforms->[parseFrom,pTransform,pCollection,allOf,of,containsTransforms,getInputsMap,getOutputsCount,getInputsCount,toPTransform,fromPayload,getOutputsMap,equalTo,getPayload,is,build,singleton,contains,assertThat,getTransformsList,ofFullComponents,hasValue]... | This test method creates a node which contains all of the basic components of a pipeline and only Private method for testing. | It is confusing to reference the single timer collection as "timer.out" when it is used for both input and output. |
@@ -161,7 +161,9 @@ IMPLEMENT_LHASH_DOALL_ARG(ENGINE_PILE, ENGINE);
void engine_table_unregister(ENGINE_TABLE **table, ENGINE *e)
{
- CRYPTO_THREAD_write_lock(global_engine_lock);
+ if (!CRYPTO_THREAD_write_lock(global_engine_lock))
+ /* Can't return a value. :( */
+ return;
if (int_table_c... | [int->[lh_ENGINE_PILE_new],engine_table_select_int->[int_table_check,CRYPTO_THREAD_unlock,OSSL_TRACE3,lh_ENGINE_PILE_retrieve,OSSL_TRACE4,sk_ENGINE_value,ERR_pop_to_mark,engine_unlocked_init,ERR_set_mark,engine_unlocked_finish,OPENSSL_init_crypto,CRYPTO_THREAD_write_lock],engine_table_unregister->[int_table_check,CRYPT... | Unregister given table from list of engine. | This is very unfortunate.. Same with the next one. |
@@ -85,6 +85,14 @@ const files = {
templates: [
{ file: 'content/images/hipster.png', method: 'copy' },
{ file: 'content/images/hipster2x.png', method: 'copy' },
+ { file: 'content/images/hipster-man-1.png', method: 'copy' },
+ { file: 'conten... | [No CFG could be retrieved] | The main entry point for the Hipster task. Config - Config for all packages. | can we use SVG instead of png? so that we dont have to copy 2 versions, it was done that way in react |
@@ -149,7 +149,7 @@ class _BaseEpochs(ProjMixin, ContainsMixin, PickDropChannelsMixin,
'result in a sampling frequency of %g Hz, which can '
'cause aliasing artifacts.'
% (lowpass, decim, new_sfreq)) # 50% over nyquist limit
- warni... | [EpochsArray->[__init__->[_is_good_epoch,_reject_setup]],combine_event_ids->[copy],equalize_epoch_counts->[drop_epochs,drop_bad_epochs],read_epochs->[_check_delayed,Epochs],_BaseEpochs->[__next__->[next]],Epochs->[equalize_event_counts->[drop_epochs,copy,_key_match,drop_bad_epochs],plot_drop_log->[plot_drop_log],_get_d... | Initialize a new object with a sequence of picks. Private method for handling missing - free objects. Add a missing entry to the measurement. | Fixed a little bug here. If `lowpass == None` a warning should have been generated, but was not. This was never covered by the tests. |
@@ -67,8 +67,16 @@ namespace :deploy do
end
end
+ desc 'Modify permissions on /srv/idp'
+ task :mod_perms do
+ on roles(:web), in: :parallel do
+ execute :sudo, :chown, '-R', 'ubuntu:nogroup', deploy_to
+ end
+ end
+
before 'assets:precompile', :browserify
after 'deploy:updated', 'newrelic... | [fetch,desc,upload!,ask,namespace,within,new,on,roles,to_json,before,task,set,require,after,match,execute] | end of function _browserify_. | should we make this a string `'deploy'` for consistency? |
@@ -387,7 +387,7 @@ func convert1_8Op(op *admin.Op1_8) (*admin.Op1_9, error) {
},
}, nil
default:
- return nil, fmt.Errorf("Unrecognized 1.7 op type:\n%+v", op)
+ return nil, fmt.Errorf("unrecognized 1.7 op type:\n%+v", op)
}
return nil, fmt.Errorf("internal error: convert1_8Op() didn't return a 1.9 op f... | [Errorf,MatchString] | returns a 1. 7 op. | unrelated, but I think this is a copy-paste error and `1.7` should be `1.8` here? |
@@ -0,0 +1,8 @@
+const { contextBridge } = require('electron');
+
+contextBridge.exposeInMainWorld('versions',
+{
+ 'chrome': process.versions.chrome,
+ 'electron': process.versions.electron,
+ 'node': process.versions.node,
+});
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | If exposing these APIs through `contextBridge` is unnecessary for this demo, maybe we should omit the preload entirely? |
@@ -620,7 +620,8 @@ void GenericAnisotropic3DLaw::CalculateCauchyGreenStrain(
// Compute total deformation gradient
const BoundedMatrixType& F = rValues.GetDeformationGradientF();
- BoundedMatrixType E_tensor = prod(trans(F), F);
+ BoundedMatrixType E_tensor = ZeroMatrix(F.size1());
+ E_tensor = pr... | [No CFG could be retrieved] | This function calculates the total deformation gradient of an element and the tangent tensor of the Returns a new instance of the class with the given name. | this is the important part. I just realized I also deleted some whitespaces ... |
@@ -105,7 +105,6 @@ public class AuthyConfiguration {
* The Authy multifactor trust configuration.
*/
@ConditionalOnClass(value = MultifactorAuthnTrustConfiguration.class)
- @ConditionalOnMultifactorTrustedDevicesEnabled(prefix = "cas.authn.mfa.authy")
@Configuration("authyMultifactorTrustConfi... | [AuthyConfiguration->[authyCasWebflowExecutionPlanConfigurer->[authyMultifactorWebflowConfigurer],authyAuthenticationWebflowAction->[authyAuthenticationWebflowEventResolver],AuthyMultifactorTrustConfiguration->[authyMultifactorTrustWebflowConfigurer->[authyAuthenticatorFlowRegistry],authyMultifactorTrustCasWebflowExecu... | Authy multifactor trust webflow configurer. | This should be restored. |
@@ -20,6 +20,7 @@ import { Injectable, SecurityContext, NgZone } from '@angular/core';
import { DomSanitizer } from '@angular/platform-browser';
<%_ if (enableTranslation) { _%>
import { TranslateService } from '@ngx-translate/core';
+
import { translationNotFoundMessage } from 'app/config/translation.config';
<%_... | [No CFG could be retrieved] | Create an alert service that can be used to alert a user or alert a user or alert Constructor for Alert object. | Intentional blank line. |
@@ -597,7 +597,7 @@ define([
*/
pickPositionSupported : {
get : function() {
- return this._context.depthTexture;
+ return defined(this._context.depthTexture) && defined(this._globeDepth);
}
},
| [No CFG could be retrieved] | Property for the Scene class. Property for storing the object that holds the globe associated with the object. | Are you sure about this change? `context.depthTexture` should return a boolean and `_globeDepth` should be defined if `context.depthTexture` is true. See the `Scene` constructor and implementation for `context.depthTexture`. |
@@ -274,6 +274,10 @@ func (a *AddVolumeOptions) Validate(isAddOp bool) error {
if len(a.SecretName) == 0 {
return errors.New("must provide --secret-name for --type=secret")
}
+ case "configmap":
+ if len(a.ConfigMapName) == 0 {
+ return errors.New("must provide --configmap-name for --type=confi... | [addVolumeToSpec->[setVolumeSource,setVolumeMount,getVolumeName],removeVolumeFromSpec->[removeSpecificVolume],Validate->[Validate]] | Validate validates AddVolumeOptions object This function is used to check if the volume options are valid. | I have a feeling you'll prefer to defer this for a follow-up, but this validation logic is _really_ hard to make sense of. |
@@ -10,6 +10,16 @@ using System.Text;
namespace Internal.Cryptography
{
+ internal struct PolicyData
+ {
+ public byte[] ApplicationCertPolicies;
+ public byte[] CertPolicies;
+ public byte[] CertPolicyMappings;
+ public byte[] CertPolicyConstraints;
+ public byte[] Enhanced... | [No CFG could be retrieved] | Creates an instance of the class. | Please change all of these to say `internal` (They're effectively internal because the type is, but any time I see `public` my immediate feeling is "really?!". |
@@ -308,6 +308,7 @@ func DeleteRepoIssueIndexer(repo *models.Repository) {
}
// SearchIssuesByKeyword search issue ids by keywords and repo id
+// WARNNING: You have to ensure user have permission to visit repoIDs' issues
func SearchIssuesByKeyword(repoIDs []int64, keyword string) ([]int64, error) {
var issueIDs... | [cancel->[Broadcast,Lock,Unlock],set->[Broadcast,Lock,Unlock],get->[RUnlock,Wait,RLock],Warn,Index,Now,Close,Delete,cancel,Info,Search,Done,IsShutdown,NewCond,CreateQueue,Error,Init,RunAtTerminate,set,Errorf,LoadDiscussComments,Trace,After,Since,Terminate,RLocker,IssueList,Debug,SearchRepositoryByName,IsChild,RunWithSh... | SearchIssuesByKeyword searches issues by keyword and returns issue ids. | This messes up with our paging, but I don't see much way around it. |
@@ -280,8 +280,7 @@ class DataflowRunnerTest(unittest.TestCase):
{'type': 'INTEGER', 'namespace': nspace+'SpecialDoFn',
'value': 42, 'key': 'dofn_value'}]
expected_data = sorted(expected_data, key=lambda x: x['namespace']+x['key'])
- self.assertEqual(len(disp_data), ... | [DataflowRunnerTest->[test_remote_runner_display_data->[SpecialParDo,SpecialDoFn],test_cancel->[MockDataflowRunner],test_wait_until_finish->[MockDataflowRunner]]] | Test if a remote runner supports display data. Test that GroupByKey operation is called after BigQuery. | Is this invocation of sorted still necessary, since you've removed the other one? |
@@ -416,7 +416,7 @@ func (e *LoginProvision) ppStream(ctx *Context) (*libkb.PassphraseStream, error)
}
return cached.PassphraseStream(), nil
}
- return e.G().LoginState().GetPassphraseStream(ctx.SecretUI)
+ return e.G().LoginState().GetPassphraseStreamForUser(ctx.SecretUI, e.arg.Username)
}
// deviceName ge... | [ensurePaperKey->[paperKey],checkUserByPGPFingerprint->[loadUser],runMethod->[paper,device,passphrase,gpg],selectGPGKey->[gpgPrivateIndex],chooseMethod->[hasGPGPrivate],chooseAndUnlockGPGKey->[gpgClient]] | ppStream returns a passphrase stream for the current user. | Does this call have the side effect of actually logging in? |
@@ -85,7 +85,7 @@ public class MessageContext {
* @throws TransformerException if there is an error during transformation
*/
public Object payloadAs(DataType dataType) throws TransformerException {
- eventBuilder.message(muleContext.getTransformationService().transform(event.getMessage(), dataType));
+ ... | [MessageContext->[getAttributes->[getAttributes],getDataType->[getDataType],getCorrelationId->[getCorrelationId],getAttributesDataType->[getDataType],getPayload->[getPayload],toString->[toString]]] | This method transforms the event message to the specified data type and sets the payload. | starting to think you should look for uses of this method..... |
@@ -206,6 +206,7 @@ public interface TimerInternals {
}
ComparisonChain chain =
ComparisonChain.start()
+ .compare(this.getOutputTimestamp(), that.getOutputTimestamp())
.compare(this.getTimestamp(), that.getTimestamp())
.compare(this.getDomain(), that.... | [TimerDataCoder->[decode->[of,decode],verifyDeterministic->[verifyDeterministic],of->[TimerDataCoder],encode->[getTimestamp,getTimerId,encode],of],TimerData->[of->[of],compareTo->[getTimerId,getNamespace]]] | Compares two timer data. | timestamp needs to be first |
@@ -1,5 +1,5 @@
class Collection < ApplicationRecord
- has_many :articles
+ has_many :articles, dependent: :nullify
belongs_to :user
belongs_to :organization, optional: true
| [Collection->[find_series->[find_or_create_by],touch_articles->[touch_all],validates,after_touch,belongs_to,has_many]] | The collection of ApplicationRecords that are associated with a user. | Destroying a collection simply means removing the articles from the collection, not destroying the articles |
@@ -926,7 +926,7 @@ def _col_norm_pinv(x):
def _sq(x):
- """Helper to square"""
+ """Square quickly."""
return x * x
| [_trans_sss_basis->[_sss_basis],_get_grad_point_coilsets->[_prep_mf_coils],_bases_real_to_complex->[_sh_real_to_complex,_sh_negate,_deg_order_idx],_deg_order_idx->[_sq],_regularize_out->[_get_n_moments],_sss_basis_basic->[_get_mag_mask,_concatenate_sph_coils,_sph_harm,_sph_harm_norm],_regularize_in->[_get_degrees_order... | Helper function to compute the square of x. | This is weird. Is this used somewhere? |
@@ -843,7 +843,7 @@ class Resolve(object):
libs = [fkey for fkey in tgroup if spec.match(fkey)]
if len(libs) == len(tgroup):
if spec.optional:
- m = True
+ m = TRUE
elif not simple:
ms2 = MatchSpec(track_features=tf) if tf el... | [Resolve->[generate_removal_count->[push_MatchSpec],install->[restore_bad,install_specs],push_MatchSpec->[to_sat_name,push_MatchSpec],dependency_sort->[ms_depends],remove->[restore_bad,remove_specs],generate_feature_count->[push_MatchSpec],generate_install_count->[push_MatchSpec],invalid_chains->[chains_->[valid,chains... | Push a onto the clauses stack. | ..... and this kids is how you waste more than an hour of time... (Meaning: It was "real fun" when I realized the changes to `logic.py` were erroneous just because I forgot to check the input here.) |
@@ -286,7 +286,14 @@ static uint64_t get_timer_bits(void)
return TWO32TO64(tv.tv_sec, tv.tv_usec);
}
# endif
- return time(NULL);
+ {
+ time_t t;
+
+ t = time(NULL);
+ if (t == (time_t)-1)
+ return 0;
+ return t;
+ }
#endif
}
| [RAND_POOL_add_end->[RAND_POOL_entropy_available],RAND_POOL_bytes_needed->[RAND_POOL_entropy_needed],RAND_set_rand_engine->[RAND_set_rand_method],RAND_POOL_add->[RAND_POOL_entropy_available]] | Get the next high and low bits of time. | nit: `t` could be initialized immediately in the definition `time_t t = time(NULL);` |
@@ -66,10 +66,15 @@ public class AbstractMessageTransformerTestCase extends AbstractMuleContextTestC
@Override
protected Map<String, Object> getStartUpRegistryObjects() {
+ Map<String, Object> map = new HashMap<>();
+
final GlobalErrorHandler errorHandler = new GlobalErrorHandler();
errorHandler.se... | [AbstractMessageTransformerTestCase->[transfromationWithDefaultErrorHandler->[transform],transform->[transform]]] | This method is called by the MuleContext when it is started. | did you actually change this or this is a rebase thing? |
@@ -163,6 +163,7 @@ class CategoriesController < ApplicationController
end
end
+ DiscourseEvent.trigger(:category_updated, result)
result
end
end
| [CategoriesController->[destroy->[destroy],update->[update],update_slug->[update],fetch_category->[find_by_slug],categories_and_topics->[topics_per_page]]] | Updates a non - nil object. | The value of `result` is just `true` or `false` right? I feel like the event would probably want a reference to the category itself and should only happen in the `if result = ` block. Does that make sense? |
@@ -69,7 +69,7 @@ def generate_argv(
file_list_path: str,
python_version: Optional[str],
) -> Tuple[str, ...]:
- args = [f"--python-executable={venv_python}", *mypy.args]
+ args = [f"--python-executable={venv_python}", "--no-error-summary", *mypy.args]
if mypy.config:
args.append(f"--conf... | [rules->[rules],mypy_typecheck_partition->[generate_argv,determine_python_files],mypy_typecheck->[MyPyPartition]] | Generate command line arguments for missing nanomorphs. | This just silences the "Success: ..." or "Found 1 error in 1 file (checked 2 source files)" messages, not the specific error information in the event of errors. |
@@ -1722,6 +1722,7 @@ def _merge_info(infos, force_update_to_first=False, verbose=None):
for k in other_fields:
info[k] = _merge_info_values(infos, k)
+ info['meas_date'] = infos[0]['meas_date'] # XXX nasty fix
info._check_consistency()
return info
| [write_info->[write_meas_info],write_meas_info->[_check_consistency],create_info->[_update_redundant,_check_consistency],_empty_info->[Info,_update_redundant,_check_consistency],Info->[copy->[Info],__repr__->[_stamp_to_dt,_summarize_str]],_simplify_info->[Info,_update_redundant],read_meas_info->[_read_dig_fif,read_bad_... | Merges multiple info objects into one info object. info is a dictionary with the key trans_name from the measurement infos and the value Return info for unknown field. | I've the feeling that this should not be done like this. But I could not think of a better way. RFC: which should be the strategy regarding `meas_date` when combining several info objects? |
@@ -837,6 +837,8 @@ class CheckoutComplete(BaseMutation):
tracking_code=tracking_code,
redirect_url=data.get("redirect_url"),
)
+ if info.context.site.settings.automatically_confirm_all_new_orders and order:
+ order_confirmed(order, info.context)
... | [CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save]],CheckoutCreate->[process_checkout_lines->[check_lines_quantity,validate_variants_available_for_purchase],clean_input->[retrieve_billing_address,retrieve_shipping_address,process_checkout_lines],Arguments->[CheckoutCreateInput],perfor... | Perform a single mutation of a node. | there is an action `order_created` which is called when the order is created. IMO this part should be there |
@@ -31,7 +31,7 @@ Condition::Pointer AugmentedLagrangianMethodFrictionalMortarContactCondition<TDi
NodesArrayType const& rThisNodes,
PropertiesPointerType pProperties ) const
{
- return boost::make_shared< AugmentedLagrangianMethodFrictionalMortarContactCondition<TDim,TNumNodes,TNormalVariation> >( NewId,... | [No CFG could be retrieved] | Creates a new AugmentedLagrangianMortarContactCondition object from a. | can i ask why you switched back to the Pointer construction? the make_shared should be better |
@@ -124,6 +124,15 @@ class UserRole extends ApiEntity
*/
public function setRole(RoleInterface $role)
{
+ if ($role->getAnonymous()) {
+ throw new \LogicException(
+ \sprintf(
+ 'It is not allowed to add an anonymous role to a user. Tried to add role "... | [No CFG could be retrieved] | setRole - set the role. | Two questions here: 1. If it is not allowed to add an anonymous role to a user, does that mean there will be no anonymous user? I.e. that in the code where we need to check for anonymous, we are going to just load the anonymous role instead of getting the roles from a user object? 2. Shouldn't we introduce a more speci... |
@@ -290,7 +290,10 @@ class MTurkManager():
elif not agent.state.is_final():
# Update the assignment state
agent.some_agent_disconnected = True
- agent.state.status = AssignState.STATUS_PARTNER_DISCONNECT
+ if len(agent.state.messages) < self.minimum_messages:
+ ... | [MTurkManager->[get_assignment->[get_assignment],force_expire_hit->[_get_agent],create_additional_hits->[get_qualification_list],setup_server->[setup_server],send_command->[_get_agent],_set_worker_status_to_onboard->[_get_agent_from_pkt],_on_socket_dead->[_handle_worker_disconnect],_change_worker_to_conv->[_get_agent_f... | Send a message to a worker notifying them that a partner hasno longer connected and we. | Technicality here - messages will include both messages sent by the worker and their partner. You should parse messages and only count the messages that have `message_data.id == agent.id` before making this. Admittedly this seems confusing, as `message_data.id` is actually storing the sender id of the message, but that... |
@@ -11,7 +11,7 @@ let lastTimeTriedToPay = 0;
/// ///////////////////////////////////////////////////////////////////////
// this code has no use in RN, it gets copypasted in webview injected code
//
-let bluewalletResponses = {};
+const bluewalletResponses = {};
// eslint-disable-next-line
var webln = {
enable... | [No CFG could be retrieved] | This is a hack to avoid the issues with the webview injected code. This is a private API. It is not implemented in the future. It is not implemented. | `this code has no use in RN, it gets copypasted in webview injected code` |
@@ -62,6 +62,16 @@ RSpec.describe "UserShow", type: :request do
)
end
# rubocop:enable RSpec/ExampleLength
+
+ it "does not render a key if no value is given" do
+ incomplete_user = create(:user)
+ get incomplete_user.path
+ text = Nokogiri::HTML(response.body).at('script[type="applic... | [email,create,text,twitter_username,let,describe,behance_url,currently_learning,summary,it,employment_title,name,to,linkedin_url,dribbble_url,body,let_it_be,before,facebook_url,gitlab_url,github_username,mastodon_url,website_url,require,education,employer_name,include,parse,have_http_status,user,instagram_url,medium_ur... | The user object is a hash of all the user s information. when user not signed in but internal nav triggered. | Does anyone have an opinion on adding/not adding `:aggregate_failures` here? |
@@ -44,7 +44,11 @@ import org.slf4j.LoggerFactory;
*/
public class JdbcResourceReleaser implements ResourceReleaser {
+ private static final String avoidThreadDisposal = getProperty("avoid.dispose.oracle.threads");
+
public static final String DIAGNOSABILITY_BEAN_NAME = "diagnosability";
+ public static final... | [JdbcResourceReleaser->[shutdownMySqlConnectionCleanupThreads->[getMethod,invoke],isDerbyEmbeddedDriver->[isDriver],deregisterOracleDiagnosabilityMBean->[unregisterMBean,debug,getName,isDebugEnabled,format,warn,getPlatformMBeanServer,toLowerCase,ObjectName,getClassLoader,put],isDriver->[getClass,isAssignableFrom],shutd... | Release a . | use Boolean.getBoolean which verifies if there exists a system property, otherwise it assigns a default. Use a constant for the string and rename this as jdb.resource.releaser.avoid.dispose.oracle.threads |
@@ -561,7 +561,11 @@ angular.module('zeppelinWebApp')
if (isNaN(timeMs) || timeMs < 0) {
return ' ';
}
- return 'Took ' + (timeMs/1000) + ' seconds';
+ var desc = 'Took ' + (timeMs/1000) + ' seconds.';
+ if (pdata.textSaved !==undefined && Date.parse(pdata.textSaved) > Date.parse(pdata.da... | [No CFG could be retrieved] | Adds key bindings to the command scope. on show . | in this flow, should it show the (outdated) text even if it has never been run (ie. timeMs NaN or 0)? because it is returning above at line 567 |
@@ -911,6 +911,7 @@ io_obj_cache_test(void **state)
rc = vos_pool_destroy(po_name, pool_uuid);
assert_int_equal(rc, 0);
vos_obj_cache_destroy(occ);
+ free(po_name);
}
static void
| [test_args_reset->[test_args_init],void->[gen_rand_epoch,test_args_reset,gen_oid,set_iov,inc_cntr,io_test_obj_fetch,vts_key_gen],test_args_init->[gen_oid],int->[gen_rand_epoch,test_args_reset,gen_oid,set_iov,inc_cntr,io_test_obj_fetch,io_test_obj_update,vts_key_gen],setup_io->[test_args_init]] | vos_obj_cache_test - virtual os_obj_cache_test vos_obj_hold vos_obj_release vos_obj_hold private static final int init_num_keys = 0 ;. | Is this the leak that the suppression is remove for? |
@@ -0,0 +1,13 @@
+module TopicTagsMixin
+ def self.included(klass)
+ klass.attributes :tags
+ end
+
+ def include_tags?
+ SiteSetting.tagging_enabled && (!object.private_message? || scope.can_tag_pms?)
+ end
+
+ def tags
+ object.tags.pluck(:name)
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I would move this into a `concerns` folder under `serializers` so that it is clear this is a mixin. |
@@ -188,7 +188,12 @@ public class RedisQueueMessageDrivenEndpoint extends MessageProducerSupport impl
byte[] value = null;
try {
- value = this.boundListOperations.rightPop(this.receiveTimeout, TimeUnit.MILLISECONDS);
+ if (readFromLeft) {
+ value = this.boundListOperations.leftPop(this.receiveTimeout, T... | [RedisQueueMessageDrivenEndpoint->[onInit->[onInit],setErrorChannel->[setErrorChannel],doStop->[doStop],ListenerTask->[run->[popMessageAndSend,restart,run]]]] | Pop a message from the queue and send it to the sender. | Guys, pay attention to this `if...else`. I think name the option like `rightPop = true/false` (`right-pop` as an XML attr) will make everything clear. Default to `true` to achiever the current behavior. Let's collect "+1" and go ahead with other stuff in this PR! |
@@ -339,7 +339,7 @@ namespace System.Xml
}
else if (_column.ColumnMapping == MappingType.Attribute || _fOnValue)
{
- DataRow row = Row;
+ DataRow row = Row!;
DataRowVersion rowVersion = (row.RowState == DataRow... | [XPathNodePointer->[MoveToFirst->[MoveTo,IsFoliated,IsValidChild],MoveToParent->[MoveTo],DuplicateNS->[GetNamespace],MoveToFirstNamespace->[RealFoliate,MoveToNextNamespace,MoveTo],IsFoliated->[IsFoliated],MoveToAttribute->[MoveTo,IsFoliated],GetNamespace->[RealFoliate,IsFoliated,GetNamespace],MoveToNamespace->[RealFoli... | The name table entry point. XML - node - region - base - uri. | This is a possible NRE. `Row` currently could return a `null!` and the next line will fail. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.