patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -24,6 +24,8 @@ describe 'NIST Encryption Model' do
allow(FeatureManagement).to receive(:use_kms?).and_return(true)
end
+ let(:kms_prefix) { '{}cH' } # XOR of 'KMSx' and '0000'
+
describe 'password hashing' do
it 'creates two substrings Z1 and Z2 via scrypt of password and salt' do
# Generat... | [open_envelope->[strict_decode64,map],hex_to_bin->[pack],open_envelope,create,new,to_not,describe,decrypt,xor,z2,it,random_bytes,to,before,random_key,fingerprint,require,hexdigest,make,match,be_a,not_to,eq,encrypt,strict_decode64,encryption_key,and_return] | Generate random key and store it in the user s access key. Creates encrypted key D and hash E. | My first question when skimming this "XOR with what?". Should we specify it's `'KMSx' XOR '0000'` |
@@ -35,8 +35,9 @@ class Vim(AutotoolsPackage):
"""
homepage = "http://www.vim.org"
- url = "https://github.com/vim/vim/archive/v8.0.0134.tar.gz"
+ url = "https://github.com/vim/vim/archive/v8.0.1376.tar.gz"
+ version('8.0.1376', '62855881a2d96d48956859d74cfb8a3b')
version('8.0.0503... | [Vim->[install->[make],configure_args->[append,InstallError],variant,depends_on,version]] | Creates a object with all of the fields that are part of the IDE. - - - - - - - - - - - - - - - - - -. | Not opposed to this, but wanted to point out that ,in general, there's no need to update `url` at every version change. |
@@ -95,11 +95,16 @@ public class KeyedWindowedTableLookupOperator
keyIterator = nextLocation.getKeys().get().iterator();
}
nextKey = keyIterator.next();
+ if (!keyConstraintsByKey.containsKey(nextKey)
+ || !keyConstraintsByKey.get(nextKey).getWindowBounds().isPresent()) {
+ t... | [KeyedWindowedTableLookupOperator->[next->[next]]] | Returns the next object in the table. | Ditto here. My concern is that when throwing this exception, we cannot tell which of the two conditions triggers it, and from debugging purposes they may point to very different directions to explore. |
@@ -132,6 +132,9 @@ public abstract class ResteasyReactiveRequestContext
*/
private List<UriMatch> matchedURIs;
+ private Map<String, String> responseHeaders;
+ private Integer responseStatus;
+
private AsyncResponseImpl asyncResponse;
private SseEventSinkImpl sseEventSink;
private Lis... | [ResteasyReactiveRequestContext->[getResourceLocatorPathParam->[getResourceLocatorPathParam,getPath,doGetPathParam],setRequestUri->[getScheme,getPath],getMatchedURIs->[saveUriMatchState],initPathSegments->[getPath],getMatrixParameter->[getPathSegments],restart->[restart],saveUriMatchState->[getPathWithoutPrefix],getRes... | The method that is used to handle the request. | I am not to fond of adding new fields here to be honest... |
@@ -18,9 +18,9 @@
data-preload-image="<%= cloud_cover_url(article.main_image) %>"
id="collection-link-inbetween"
data-no-instant
- title="View more">
- <span class="series-switcher__num">...</span>
- <span class="series-switcher__title"... | [No CFG could be retrieved] | Renders a single - page crayons_card showing the series of a n - item Navigates to the element. | I'm not sure this key name is intent-revealing but I also can't come up with a better one |
@@ -128,10 +128,9 @@ public final class OAuthUtils {
* @param type
* @return the provider for the given type or null if no provider was found
*/
- public static OAuthProvider getProviderByType(final OAuthProviders providers, final String type) {
- List<OAuthProvider> listProviders = provider... | [OAuthUtils->[redirectToError->[addParameter,isBlank,redirectTo],writeText->[print,getWriter,setStatus,error],writeTextError->[writeText],redirectTo->[RedirectView,ModelAndView],getProviderByType->[getProviders,getType,equals],addParameter->[append,indexOf,toString,StringBuilder,encode],getLogger]] | Get provider by type. | Do we ever expect these params to be `null`? If yes, wouldn't it be more suitable to throw exceptions in advance? `IllegalArgumentException`, etc? |
@@ -340,7 +340,7 @@ def _time_frequency(X, Ws, use_fft, decim):
"""Aux of time_frequency for parallel computing over channels
"""
n_epochs, n_times = X.shape
- n_times = n_times // decim + bool(n_times % decim)
+ n_times = int(np.ceil(float(n_times) / decim))
n_frequencies = len(Ws)
psd =... | [_cwt->[_centered],AverageTFR->[plot->[_preproc_tfr],__iadd__->[_check_compat],__isub__->[_check_compat],__add__->[_check_compat],__sub__->[_check_compat],plot_topo->[_preproc_tfr]],_induced_power_cwt->[morlet],_time_frequency->[_cwt],tfr_morlet->[AverageTFR,_induced_power_cwt,_get_data],tfr_multitaper->[_prepare_picks... | Aux of time_frequency for parallel computing over channels . | How is this different from what was here previously? |
@@ -2663,7 +2663,7 @@ function PMA_getHtmlForFunctionOption($column, $column_name_appendix)
. '<td '
. ($longDoubleTextArea
&& mb_strstr($column['True_Type'], 'longtext')
- ? 'rowspan="2"'
+ ? 'rowspan="1"'
: ''
)
. 'class="center">'
| [PMA_analyzeWhereClauses->[fetchAssoc,query],PMA_getValueColumn->[getTypeClass],PMA_getValueColumnForOtherDatatypes->[getTypeClass],PMA_transformEditedValues->[applyTransformation],PMA_getQueryValuesForInsertAndUpdateInMultipleEdit->[escapeString],PMA_setSessionForEditNext->[query,getFieldsMeta,fetchRow],PMA_verifyWhet... | PMA_getHtmlForFunctionOption - return HTML for a node in a function. | Why not drop the rowspan attribute? |
@@ -59,10 +59,11 @@ void GcodeSuite::M201() {
const int8_t target_extruder = get_target_extruder_from_command();
if (target_extruder < 0) return;
+ static constexpr uint32_t max_accel[] = DEFAULT_MAX_ACCELERATION;
LOOP_XYZE(i) {
if (parser.seen(axis_codes[i])) {
const uint8_t a = (i == E_AXIS ? ... | [No CFG could be retrieved] | D<linear > - Diameter of the filament. Use D0 to switch back M203 - Set Accelerations in units in units in units in units in units. | I'm not sure about adding this implicit upper limit, where `DEFAULT_MAX_ACCELERATION` is no longer just the default setting value, but also determines the upper limit for `M201`. Some users may want to set the default really low (since it's just the _default_ applied on `M502` and a new firmware flash, after all). The ... |
@@ -22,8 +22,11 @@ bool WorldSession::CanOpenMailBox(uint64 guid)
{
if (guid == _player->GetGUID())
{
- sLog->outError("%s attempt open mailbox in cheating way.", _player->GetName().c_str());
- return false;
+ return true;
+ }
+ else if (IS_ITEM_GUID(guid))
+ {
+ return t... | [HandleMailReturnToSender->[CanOpenMailBox],HandleGetMailList->[CanOpenMailBox],HandleMailMarkAsRead->[CanOpenMailBox],HandleMailCreateTextItem->[CanOpenMailBox],HandleSendMail->[CanOpenMailBox],HandleMailTakeMoney->[CanOpenMailBox],HandleMailTakeItem->[CanOpenMailBox],HandleMailDelete->[CanOpenMailBox]] | Checks if a mailbox can be opened by the player. | why changing this return? |
@@ -172,7 +172,7 @@ namespace System.ComponentModel.Composition.ReflectionModel
private static bool TryGetCastFunction(Type genericType, bool isOpenGeneric, Type[] arguments, [NotNullWhen(true)] out Func<Export, object>? castFunction)
{
- castFunction = null;
+ castFunction = n... | [ImportType->[IsDescendentOf->[IsGenericDescendentOf],IsGenericDescendentOf->[IsGenericDescendentOf],TryGetCastFunction->[IsDescendentOf]]] | Try to get the cast function. | :memo: the `[NotNullWhen(...)]` annotation on method seems incorrect #Resolved |
@@ -309,6 +309,14 @@ class Scheduler(object):
self._native.lib.nodes_destroy(raw_roots)
return roots
+ def capture_snapshot(self, root_path, path_globs):
+ result = self._native.lib.capture_snapshot(self._scheduler, root_path, self._to_value(path_globs))
+ value = self._from_value(result.value)
+ ... | [Scheduler->[rule_graph_visualization->[visualize_rule_graph_to_file],graph_len->[graph_len],_register_singleton->[_to_value],visualize_rule_graph_to_file->[_root_type_ids],add_root_selection->[_to_key,_to_constraint,_from_value],_metrics->[_from_value],_to_constraint->[_to_key],lease_files_in_graph->[lease_files_in_gr... | Runs the scheduler and returns the list of nodes that have a state of Return Throw or lease. | Worth lifting out a little `_from_pyresult` helper? |
@@ -22,8 +22,6 @@
#include "../../../../inc/MarlinConfigPre.h"
-#if ENABLED(TFT_LVGL_UI_SPI)
-
#include "SPI_TFT.h"
#include "pic_manager.h"
#include "tft_lvgl_configuration.h"
| [LCD_init->[LCD_WR_REG,LCD_WR_DATA],LCD_Draw_Logo->[SetWindows],LCD_clear->[SetWindows],SetWindows->[LCD_WR_REG,LCD_WR_DATA]] | region Description eturns a list of all possible objects in the system region Window Management. | Even though the new PlatformIO scripts remove the need to wrap CPP files, we should still retain these wrappers for the benefit of other potential build systems. |
@@ -1369,11 +1369,12 @@ def create_sendexpiredlock(
channel_identifier: ChannelID,
recipient: Address,
) -> Tuple[Optional[SendLockExpired], Optional[MerkleTreeState]]:
- nonce = get_next_nonce(sender_end_state)
locked_amount = get_amount_locked(sender_end_state)
balance_proof = sender_end_state... | [get_current_balanceproof->[get_amount_locked],register_secret_endstate->[is_lock_locked],handle_block->[is_deposit_confirmed,get_status],send_refundtransfer->[get_status,create_sendlockedtransfer],lock_exists_in_either_channel_side->[get_lock],get_batch_unlock_gain->[UnlockGain],is_valid_refund->[valid_lockedtransfer_... | Creates a new lock that is a send lock expired or a merkle tree state. | I suspect we should also store the new `nonce` in `sender_end_state` here? |
@@ -60,6 +60,13 @@ class MultiPhaseTuner(Recoverable):
"""
_logger.info('Customized trial job %s ignored by tuner', parameter_id)
+ def trial_end(self, parameter_id, success, trial_job_id):
+ """Invoked when a trial is completed or terminated. Do nothing by default.
+ parameter_id: ... | [MultiPhaseTuner->[generate_multiple_parameters->[generate_parameters]]] | Called when a trial is added by Web UI reports its final result. | update the docstring about "trial_job_id"? |
@@ -168,6 +168,8 @@ public class DruidOperatorTable implements SqlOperatorTable
.add(new LTrimOperatorConversion())
.add(new RTrimOperatorConversion())
.add(new AliasedOperatorConversion(new TruncateOperatorConversion(), "TRUNC"))
+ .add(new LikeOperatorConversion())
+ ... | [DruidOperatorTable->[OperatorKey->[of->[OperatorKey],equals->[equals],normalizeSyntax]]] | This method is used to create a DruidOperatorTable instance. Put an aggregator into the cache. | Put Like with the other string conversions please. It would get lonely by itself. |
@@ -19,6 +19,7 @@ use Friendica\Database\DBA;
use Friendica\Model\Contact;
use Friendica\Model\PermissionSet;
use Friendica\Model\ItemURI;
+use Friendica\Model\Profile;
use Friendica\Object\Image;
use Friendica\Protocol\Diaspora;
use Friendica\Protocol\OStatus;
| [Item->[isRemoteSelf->[get_hostname],newURI->[get_hostname],addLanguageToItemArray->[setNameMode,detect],guid->[get_hostname],fixPrivatePhotos->[getType,asString,isValid,scaleDown]]] | Create a base object from a sequence of base objects. Field list that is used to create a new object. | It isn't in use in this file. |
@@ -1,6 +1,11 @@
# rubocop:disable Metrics/BlockLength
Rails.application.routes.draw do
+ # Health Check Endpoints
+ get "/health_check" => "health_check#ping"
+ get "/search_health_check" => "health_check#search_ping"
+ get "/database_health_check" => "health_check#database_ping"
+
use_doorkeeper do
co... | [new,authenticate,authenticated,redirect,devise_scope,mount,draw,freeze,has_role?,resources,member,root,use,scope,post,set,controllers,require,secrets,class_eval,use_doorkeeper,resource,patch,devise_for,each,production?,delete,namespace,collection,get,session_options,tech_admin?,app] | The main route for the middleware. Resource definition for a specific resource. | What about a /redis_health_check too? |
@@ -175,6 +175,14 @@ public class JDBCInterpreter extends Interpreter {
for (String propertyKey : basePropretiesMap.keySet()) {
propertyKeySqlCompleterMap.put(propertyKey, createSqlCompleter(null));
}
+ setMaxLineResults();
+ }
+
+ private void setMaxLineResults() {
+ if (basePropretiesMap.cont... | [JDBCInterpreter->[setUserProperty->[setUserProperty,getJDBCConfiguration,getUsernamePassword,existAccountInBaseProperty,closeDBPool,getEntityName],completion->[getPropertyKey],getUsernamePassword->[getUsernamePassword],initStatementMap->[initStatementMap],executeSql->[isDDLCommand,getResults,getConnection,close,closeD... | This method is called when the configuration is opened. Creates a SQL completer that can be used to complete the SQL keywords. | I don't want to make this too complication, just to check, do we need to handle when someone set non-integer value in this config property? that might be a separate, bigger issue though |
@@ -171,6 +171,11 @@ class Controls:
if self.sm['thermal'].memUsedPercent > 90:
self.events.add(EventName.lowMemory)
+ if self.hw_type in [HwType.uno, HwType.dos]:
+ if self.sm['health'].fanSpeedRpm == 0 and self.last_desired_fan_speed > 50:
+ self.events.add(EventName.fanMalfunction)
+ ... | [Controls->[controlsd_thread->[step],step->[state_transition,update_events,publish_logs,state_control,data_sample]],main->[Controls,controlsd_thread],main] | Compute carEvents from carState and events from the state machine. events for all lane change states Add event if any carcage has an error. | Why store last_desired fan speed? Controlsd runs at 100 Hz, so that wouldn't be enough time for the fan to spin up + the health packet being received (500 ms). You probably want to make sure that fan speed is above 50% for at least 5 seconds. That should be plenty of time. |
@@ -80,10 +80,10 @@ class StatelessCheckbox extends React.Component<PropsT, StatelessStateT> {
Input: InputOverride,
} = overrides;
- const Root = getComponent(RootOverride, StyledRoot);
- const Checkmark = getComponent(CheckmarkOverride, StyledCheckmark);
- const Label = getComponent(LabelOverri... | [No CFG could be retrieved] | Displays a component that renders the menu item. A component that renders a . | Renamed getComponent to getOverride, removing the defaultComponent arg. The return type of `getComponent` was `?React.ComponentType<T>`, meaning that it could return a component or `null`/`undefined`. So even if we _know_ that `null`/`undefined` can't be returned because we've passed a valid default, flow will still co... |
@@ -476,6 +476,9 @@ public class DagManager extends AbstractIdleService {
for (DagNode<JobExecutionPlan> dagNodeToCancel : dagNodesToCancel) {
cancelDagNode(dagNodeToCancel);
}
+
+ this.dags.get(dagToCancel).setFlowEvent(TimingEvent.FlowTimings.FLOW_CANCELLED);
+ this.dags.get... | [DagManager->[DagManagerThread->[killJobIfOrphaned->[cancelDagNode],slaKillIfNeeded->[cancelDagNode],cleanUp->[hasRunningJobs,deleteJobState],onJobFinish->[submitNext],getRunningJobsCounter->[toString],cleanUpDag->[cleanUp]],setActive->[createDagStateStore,addDag],createJobStatusMonitor->[createJobStatusMonitor],handle... | Cancels a Dag. | Should we setFlowEvent() inside cancelDagNode() ? |
@@ -88,7 +88,9 @@ class Gdal(AutotoolsPackage):
variant('cryptopp', default=False, description='Include cryptopp support')
variant('crypto', default=False, description='Include crypto (from openssl) support')
- extends('perl', when='+perl')
+ # FIXME: Allow packages to extend multiple packages
+ ... | [Gdal->[darwin_fix->[fix_darwin_install_name],setup_environment->[set],import_module_test->[working_dir,python,format],configure_args->[join_path,satisfies,append,extend,format],depends_on,extends,conflicts,version,on_package_attributes,variant,run_after]] | Returns a list of all possible package identifiers. - - - - - - - - - - - - - - - - - -. | Without this, the module file generated by Spack doesn't set `PYTHONPATH`. I doubt anyone needs the Perl bindings anyway. |
@@ -132,9 +132,14 @@ public abstract class AbstractHoodieClient implements Serializable, AutoCloseabl
}
protected HoodieTableMetaClient createMetaClient(boolean loadActiveTimelineOnLoad) {
- return HoodieTableMetaClient.builder().setConf(hadoopConf).setBasePath(config.getBasePath())
- .setLoadActiveTi... | [AbstractHoodieClient->[startEmbeddedServerView->[stopEmbeddedServerView]]] | Creates a HoodieTableMetaClient with the given configuration. | could we please avoid non-essential style fixes in the PR. Makes it harder to review. |
@@ -297,6 +297,9 @@ export class AmpStory extends AMP.BaseElement {
/** @private {?UIType} */
this.uiState_ = null;
+
+ /** @private {boolean} whether the styles were rewritten */
+ this.rewroteStyles_ = false;
}
/** @override */
| [No CFG could be retrieved] | Replies the current language of the story. Register all the strings that are not registered with the NI. | super nitty but it always get harder to read/write conjugated verbs, how about `didRewriteStyles_` that's a more widespread pattern? |
@@ -304,7 +304,7 @@ namespace Dynamo.Core
/// Does not instantiate the nodes.
/// </summary>
/// <returns>False if SearchPath is not a valid directory, otherwise true</returns>
- private IEnumerable<CustomNodeInfo> ScanNodeHeadersInDirectory(string dir, bool isTestMode)
+ pr... | [CustomNodeManager->[GetAllDependenciesGuids->[Contains],RegisterCustomNodeWorkspace->[RegisterCustomNodeWorkspace,SetNodeInfo,Uninitialize,SetFunctionDefinition,OnInfoUpdated,OnDefinitionUpdated],IsInitialized->[IsInitialized],WorkspaceModel->[RegisterCustomNodeWorkspace],CustomNodeWorkspaceModel->[RegisterCustomNodeW... | Scan node headers in directory. | Please remove this `bool isPackageMember` and set the `info.IsPackageMember = isPackageMember` in the `AddUninitializedCustomNodesInPath` above. |
@@ -34,7 +34,7 @@ define([
});
widget.placeAt('cesiumContainer');
widget.startup();
- widget.fullscreen.viewModel.fullscreenElement(document.body);
+ widget.fullscreen.getViewModel().fullscreenElement(document.body);
domClass.remove(win.body(), 'loading');
});
| [No CFG could be retrieved] | Load the fullscreen widget. | missed a spot, `fullscreenElement` is now `setFullscreenElement` |
@@ -143,6 +143,10 @@ func runServ(c *cli.Context) error {
username := strings.ToLower(rr[0])
reponame := strings.ToLower(strings.TrimSuffix(rr[1], ".git"))
+ if setting.EnablePprof {
+ defer pprofDumpMemProfileForUsername(username)
+ }
+
isWiki := false
unitType := models.UnitTypeCode
if strings.HasSuffix(... | [GetPublicKeyByID,NewWithClaims,GetUserByKeyID,NewXORMLogService,SetEngine,Now,Close,Setenv,UpdatePublicKeyUpdated,Encode,IsSet,Exit,IsErrRepoNotExist,HasDeployKey,Add,ShowSubcommandHelp,Args,NewEncoder,MustInt64,TimeStampNow,NewGitLogger,Run,Chdir,SplitN,TrimSpace,HasSuffix,GetDeployKeyByRepo,Join,Fprintln,Unix,Update... | Check if the user has access to the n - term term and if so return the n if - get repository by name. | I think it should be also allowed to specify from cli so that it would be possible to profile only single key by editing authorized_keys file |
@@ -3717,6 +3717,18 @@ describe('input', function() {
expect(inputElm).toBeInvalid();
expect(scope.form.alias.$error.required).toBeTruthy();
});
+
+ it('should not invalidate number if ng-required=false and model is undefined', function() {
+ compileInput('<input type="number" ng-mo... | [No CFG could be retrieved] | Private functions - Input validation - Input validation - Input validation - Input validation - Input validation - Check standard minlength attribute and register a validator on the model. | this assertion does fail without this change |
@@ -1091,7 +1091,10 @@ def setup_volume_source_space(subject, fname=None, pos=5.0, mri=None,
logger.info('')
# Explicit list of points
- if not isinstance(pos, float):
+ if volume_label is not None:
+ # Make a volume source restricted to label
+ sp = _make_volume_from_label(pos, volume_l... | [read_source_spaces->[read_source_spaces_from_tree],setup_volume_source_space->[SourceSpaces,write_source_spaces],read_source_spaces_from_tree->[SourceSpaces],write_source_spaces->[_write_source_spaces_to_fid],setup_source_space->[SourceSpaces,write_source_spaces],_read_one_source_space->[_add_patch_info],add_source_sp... | Setup a volume source space with grid spacing or discrete source space. Returns a list of objects representing a single non - empty a . Get a from the surface file. Load a single node in the system as a source space. | e.g. I think it's possible to get to this point in the code with `isinstance(pos, dict) is True`, which is not good. Just double-check all the necessary type checks are there. I'd do it by actually writing the test lines with `assert_raises` that we think should fail. |
@@ -38,7 +38,8 @@ enum {
TCX_READY,
};
-int gc, oid_cnt;
+int gc, oid_cnt;
+extern char vos_path[STORAGE_PATH_LEN];
bool
vts_file_exists(const char *filename)
| [vts_pool_fallocate->[vts_alloc_gen_fname],vts_ctx_init->[vts_file_exists,vts_alloc_gen_fname]] | Checks if a file exists in the system and if it does not exist it does not exist. | (style) externs should be avoided in .c files |
@@ -205,4 +205,11 @@ public interface RpcManager {
* Returns the address associated with this RpcManager or null if not part of the cluster.
*/
Address getAddress();
+
+ /**
+ * Returns the current topology id. As opposed to the viewId which is updated whenever the cluster changes,
+ * the topolog... | [No CFG could be retrieved] | Returns the address of the current node. | The topology id is actually updated when rebalance starts and when rebalance ends. There can be more than one node joining/leaving before rebalance ends, and most of the time there is no joiner/leaver between rebalance start and rebalance end. |
@@ -103,6 +103,11 @@ public abstract class AbstractPathFinder implements PathFinder {
this.destNodes.add(destNode);
}
+ // All dest nodes should be the same class
+ if (this.destNodes != null && this.destNodes.stream().map(Object::getClass).collect(Collectors.toSet()).size() > 1) {
+ throw new ... | [AbstractPathFinder->[getMergedConfig->[withFallback,atPath],findPath->[addPath,findPathUnicast,FlowGraphPath],constructPath->[add,get,equals],getNextEdges->[isActive,getMergedConfig,tryResolving,toString,warn,getEdges,getFormatConfig,getStringList,isEmpty,makeOutputDescriptorSpecific,getExecutors,getDest,getNode,getLe... | This class is used to initialize the FlowGraph object Check if the given source and destination dataset descriptors are not empty and add retention config. | Can our path finding algorithm return dest nodes with different types? just curious. |
@@ -598,7 +598,7 @@ public abstract class AbstractJobLauncher implements JobLauncher {
}
});
- if (jobState.getState() == JobState.RunningState.FAILED) {
+ if (jobState.getState() == JobState.RunningState.FAILED || jobState.getState() == JobState.RunningState.CANCELLE... | [AbstractJobLauncher->[unlockJob->[close],getJobLock->[getJobLock],postProcessJobState->[postProcessTaskStates],MultiWorkUnitForEach->[apply->[forWorkUnit]],cleanLeftoverStagingData->[close],startCancellationExecutor->[run->[executeCancellation]],tryLockJob->[onLost->[executeCancellation],getJobLock],runWorkUnitStream-... | Launch a job. region AbstractJob Implementation This method is called when a job is starting. It will clean the remaining staging data and This method is called when a work unit is added to the job. It is called by This method is called when the job is being terminated. | Is there another bug in "else" branch below? It creates a "JOB_SUCCEEDED" event, but the listener is calling "onJobFailure" event. Also the same logic is a coupe of blocks above. |
@@ -103,7 +103,7 @@ namespace DotNetNuke.Modules.Admin.Modules
{
var strVersion = xmlDoc.DocumentElement.GetAttribute("version");
// DNN26810 if rootnode = "content", import only content(the old way)
- ... | [Import->[ImportModule->[ImportModule],OnInit->[OnInit],OnLoad->[OnLoad],OnImportClick->[ImportModule]]] | ImportModule - Import Module. | Please use `String#Equals(String, StringComparison)` |
@@ -352,15 +352,17 @@ class SideInputData(object):
self.view_fn = view_fn
self.coder = coder
- def to_runner_api(self, unused_context):
+ def to_runner_api(self, context):
return beam_runner_api_pb2.SideInput(
access_pattern=beam_runner_api_pb2.FunctionSpec(
urn=self.access_patt... | [PCollection->[to_runner_api->[PCollection],from_runner_api->[PCollection]],AsMultiMap->[_side_input_data->[_input_element_coder,SideInputData]],AsSideInput->[_side_input_data->[_view_options],to_runner_api->[_side_input_data],from_runner_api->[from_runner_api]],AsIter->[_side_input_data->[_input_element_coder,SideInpu... | Initialize the object. | Should we do context null check here? |
@@ -277,7 +277,7 @@ func (u *Uint64Param) UnmarshalPipelineParam(val interface{}) error {
}
*u = Uint64Param(n)
default:
- return ErrBadInput
+ return errors.Wrap(ErrBadInput, fmt.Sprintf("expected unsiend integer, got %T", val))
}
return nil
}
| [Decimal->[Decimal],String->[String],UnmarshalPipelineParam->[UnmarshalPipelineParam]] | UnmarshalPipelineParam unmarshals a pipeline parameter from the wire format. | Let's use `errors.Wrapf` here |
@@ -71,4 +71,10 @@ public interface GameSetting<T> {
* Unregisters {@code listener} to no longer receive a notification whenever the setting value has changed.
*/
void removeListener(Consumer<GameSetting<T>> listener);
+
+
+
+ default String getDisplayValue() {
+ return Objects.toString(getValue().orElse... | [getValueOrThrow->[get]] | Remove a listener from the list of listeners. | :+1: This is definitely a step in the right direction. However, it would be better if it could be pushed out to the associated UI binding. I'm not sure if that's even possible given the current architecture. Let me play around with it a bit and see what can be done. I'd be okay leaving it like this for now since it sol... |
@@ -52,6 +52,12 @@ class ThreadingOptions(options.OptionsBase):
"The value 0 can be used to indicate that the threadpool size should be "
"determined at runtime based on the number of available CPU cores.")
+ def _has_non_default_values(self):
+ for attr in filter(lambda opt: not opt.startswith("_")... | [ThreadingOptions->[_to_proto->[ThreadingOptions]]] | Convert this object to a protocol buffer. | remove as this is not used anywhere anymore |
@@ -70,7 +70,7 @@ class AGP_Pruner(Pruner):
https://arxiv.org/pdf/1710.01878.pdf
"""
- def __init__(self, model, config_list, optimizer):
+ def __init__(self, model, config_list, optimizer=None):
"""
Parameters
----------
| [LotteryTicketPruner->[_calc_mask->[_calc_sparsity],prune_iteration_start->[_calc_mask]]] | Initialize the object with the given parameters. | optimizer cannot be None in AGP pruner because it is an iterative pruner |
@@ -1107,9 +1107,6 @@ zio_read(zio_t *pio, spa_t *spa, const blkptr_t *bp,
{
zio_t *zio;
- (void) zfs_blkptr_verify(spa, bp, flags & ZIO_FLAG_CONFIG_WRITER,
- BLK_VERIFY_HALT);
-
zio = zio_create(pio, spa, BP_PHYSICAL_BIRTH(bp), bp,
data, size, size, done, private,
ZIO_TYPE_READ, priority, flags,... | [No CFG could be retrieved] | Reads and writes the specified node - device - specific header. zio_write - write - io interface. | The arc is not the only caller of zio_read(). Is it appropriate for all other callers that we no longer verify the blkptr? Related: the existing semantics (calling zfs_panic_recover on error) seem a bit over-the-top. Although I suppose that the logic here is that a blkptr in this context should be coming from a checksu... |
@@ -54,6 +54,8 @@ static int ui_read(UI *ui, UI_STRING *uis)
reader = UI_method_get_reader(ui_fallback_method);
if (reader)
return reader(ui, uis);
+ /* Default to the empty password if we've got nothing better */
+ UI_set_result(ui, uis, "");
return 1;
}
| [setup_ui_method->[UI_method_set_writer,UI_null,UI_method_set_closer,UI_OpenSSL,UI_method_set_reader,UI_create_method,UI_method_set_opener],int->[UI_method_get_reader,UI_method_get_writer,reader,opener,UI_get_string_type,UI_method_get_opener,UI_get0_user_data,writer,UI_method_get_closer,closer,UI_set_result,UI_get_inpu... | UI_read - UI_read method. | I'm not an expert on the password UI but according to the explanation you gave this looks good. |
@@ -970,8 +970,8 @@ class Database(object):
counts = {}
for key, rec in self._data.items():
counts.setdefault(key, 0)
- for dep in rec.spec.dependencies(_tracked_deps):
- dep_key = dep.dag_hash()
+ for dep in rec.spec.dependencies(self.tracked_deps):
+... | [InstallRecord->[install_type_matches->[canonicalize],from_dict->[InstallRecord],__init__->[_now]],ForbiddenLock->[__getattribute__->[ForbiddenLockError]],InstallStatuses->[InstallStatus],Database->[_read_from_file->[from_dict,invalid_record,check,_read_spec_from_dict,_assign_dependencies,to_dict],query_one->[query],_w... | Ensure consistency of reference counts in the DB. | `getattr(dep, self.key_hash_type.name)()` might work instead of exposing the internal method |
@@ -274,8 +274,8 @@ func makeByHostAnyIPJob(
resolveStart := time.Now()
ip, err := net.ResolveIPAddr(network, host)
if err != nil {
- resolveErr(event, host, err)
- return nil, nil
+ resolveErr(event, host)
+ return nil, err
}
resolveEnd := time.Now()
| [Unpack->[Errorf],WithFields->[AddFields],Status,Now,Put,To16,New,Errorf,Sub,Since,To4,Reason,Name,DeepUpdate,RTT,ParseIP,Network,ResolveIPAddr,String,LookupIP,Run] | MakeByHostJob creates a new Job based on the given settings. finds the job that can be scheduled for the given host. | I think that during the refactor my thought was that we'd add the error fields in `resolveErr` directly, which was obviously incorrect. |
@@ -473,6 +473,7 @@ public class SideInputContainerTest {
* windowing strategy is invoked, start a thread that will invoke the callback after the returned
* {@link CountDownLatch} is counted down once.
*/
+ @SuppressWarnings({"FutureReturnValueIgnored", "CheckReturnValue"})
private CountDownLatch invoke... | [SideInputContainerTest->[withViewsForViewNotInContainerFails->[toString],isReadyInEmptyReaderThrows->[toString],getOnReaderForViewNotInReaderFails->[toString]]] | Invoke a callback that will be invoked when the latch is available. | is this suppression relevant for this PR? |
@@ -57,6 +57,8 @@ def parse_test_cases(
fnam = '__builtin__.py'
files.append((os.path.join(base_path, fnam), f.read()))
f.close()
+ elif p[i].id in ('expectStale', 'expectstale'):
+ stale_modules.update({item.strip() fo... | [DataDrivenTestCase->[add_dirs->[add_dirs]],parse_test_data->[TestItem]] | Parse a file with test case descriptions. if p i is an error in p p i is not an error in p i is. | How about picking one case and sticking to it? Maybe even shorten to 'stale' (after all, we use `[out]`, not `[expectedOutput]` :-) |
@@ -417,6 +417,9 @@ def create_legacy_graph_tasks(symbol_table):
"""Create tasks to recursively parse the legacy graph."""
symbol_table_constraint = symbol_table.constraint()
+ partial_find_owners = functools.partial(find_owners, symbol_table)
+ partial_find_owners.__name__ = find_owners.__name__
+
return ... | [transitive_hydrated_target->[TransitiveHydratedTarget],hydrate_target->[HydratedTarget],transitive_hydrated_targets->[TransitiveHydratedTargets],hydrated_targets->[HydratedTargets],hydrate_sources->[HydratedField,_eager_fileset_with_spec],hydrate_bundles->[HydratedField,_eager_fileset_with_spec],LegacyBuildGraph->[_in... | Create tasks to recursively parse the legacy graph. | Maybe extract a helper for this? |
@@ -174,9 +174,9 @@ public final class LagReportingAgent implements HostStatusListener {
final HostInfo host, final QueryStateStoreId queryStateStoreId, final int partition) {
final Set<HostInfo> aliveHosts = aliveHostsRef.get();
final LagInfoEntity lagInfo = receivedLagInfo
- .getOrDefault(host... | [LagReportingAgent->[listAllLags->[builder],HostLagInfo->[toString->[toString]],receiveHostLag->[builder],Builder->[build->[LagReportingAgent]]]] | Returns the lag info for the given host and partition. | why not more `EMPTY_STATE_STORE_LAGS` into `getStateStoreLags`? |
@@ -475,7 +475,8 @@ export class AmpA4A extends AMP.BaseElement {
try {
// Among other things, the signature might not be proper base64.
return verifySignature(
- response.creative, response.signature, publicKeyInfos);
+ new Uint8Array(respons... | [AmpA4A->[renderViaIframe_->[assert,setAttribute,xhrFor],isLayoutSupported->[isLayoutSizeDefined],formatCSSBlock_->[cssReplacementRanges,cssUtf16CharOffsets,substring,join,length,push],unlayoutCallback->[removeChildren],onLayoutMeasure->[resolve,viewerFor,cancellation,verifySignatureIsAvailable,warn,assert,reject,isPos... | Validate the AdResponse. | Do we have a test to capture this? |
@@ -11,11 +11,12 @@ using Robust.Shared.IoC;
using Robust.Shared.Localization;
using Robust.Shared.Physics;
using Robust.Shared.Timing;
+using Robust.Shared.ViewVariables;
namespace Content.Server.GameObjects.Components.Power.PowerNetComponents
{
[RegisterComponent]
- public class RadiationCollectorCompo... | [RadiationCollectorComponent->[RadiationAct->[RadsPerSecond],EnableCollection->[Activating,SetAppearance],SetAppearance->[Owner,VisualState,SetData],DisableCollection->[Deactivating,SetAppearance],OnAnchoredChanged->[Static,BodyType,SnapToGrid],InteractHand->[EnableCollection,User,FromSeconds,PopupMessage,GetString,Dis... | Implementation of a component that implements the RadiationCollector interface. This is a base class for the IRadiationCollectorVisualState class. It is used. | maybe an `if(_enabled == value) return; ` check to prevent unneeded dirty-calls? |
@@ -1204,6 +1204,12 @@ cont_child_destroy_one(void *vin)
if (cont->sc_dtx_resyncing)
ABT_cond_wait(cont->sc_dtx_resync_cond, cont->sc_mutex);
ABT_mutex_unlock(cont->sc_mutex);
+
+ /* Make sure checksum scrubbing has stopped */
+ ABT_mutex_lock(cont->sc_mutex);
+ if (cont->sc_scrubbing)
+ ABT_cond_wait(co... | [No CFG could be retrieved] | Destroy one of the children of the specified node. Destroy the specified container. | If scrubbing ULT is sleeping while holding ds_cont_child, you need to wakeup it. |
@@ -76,15 +76,11 @@ public class FunctionInvoker {
return inputType != null;
}
- public Class getInputType() {
+ public Type getInputType() {
return inputType;
}
- public Type getInputGenericType() {
- return inputGenericType;
- }
-
- public Class getOutputType() {
... | [FunctionInvoker->[invoke->[size,isAsync,construct,setOutput,failure,getCause,invoke,extract,item,InternalError,transform,ApplicationException],hasOutput->[equals],FunctionConstructor,IllegalArgumentException,createInjector,getParameterCount,getGenericReturnType,getParameterAnnotations,getParameterTypes,getReturnType,a... | Returns true if the node has a non - null input and non - null output. | @patriot1burke I think that having both: `inputType` and `inputGenericType` is redundant. You can get `inputType` from `inputGenericType` by `getRawType()`. |
@@ -178,16 +178,13 @@ def test_load_cached_data_for_updating(mocker) -> None:
# timeframe starts earlier than the cached data
# should fully update data
timerange = TimeRange('date', None, test_data[0][0] / 1000 - 1, 0)
- data, start_ts = load_cached_data_for_updating(test_filename,
- ... | [test_load_data_1min_ticker->[_backup_file,_clean_test_file],test_load_data_with_new_pair_1min->[_backup_file,_clean_test_file],test_download_pair_history->[_backup_file,_clean_test_file],test_file_dump_json_tofile->[_clean_test_file],test_download_backtesting_data_exception->[_backup_file,_clean_test_file]] | Load the cached data for updating. This function checks that the data for a given node in the file is in the cache and missing timeframe data is empty and None . | most of these tests make no sense ... apparently timerange in `load_cached_data_for_updating()` was broken (and tests did not check that at all). This line is the best example - we pass in `-29` ... and assert that we get all apart from the last item back. I'll rethink how `load_cached_data_for_updating()` should reall... |
@@ -36,7 +36,12 @@ import spack.url
import spack.stage
import spack.error
import spack.util.crypto
+
from spack.util.compression import ALLOWED_ARCHIVE_TYPES
+from spack.util.s3 import create_s3_session
+from spack.util.url import join as urljoin, parse as urlparse
+
+from spack.s3_handler import open as s3_open
... | [_spider_wrapper->[_spider],read_from_url->[_read_from_url],LinkParser->[__init__->[__init__]],_spider->[LinkParser,NonDaemonPool,_read_from_url],find_versions_of_archive->[spider],spider->[_spider],NonDaemonPool->[__init__->[NonDaemonContext]]] | Create a new object that represents a single unique identifier. A class constructor for the NonDaemonProcess object. | We should rethink the module breakdown here, as there are a lot of circular imports. In general we want to avoid any circular dependencies between module in Spack (I know there are already quite a few) |
@@ -41,7 +41,7 @@ func TestNamespaceEdgeMatching(t *testing.T) {
fn("other", g)
AddAllDeploymentConfigsDeploymentEdges(g)
- if len(g.Edges()) != 4 {
+ if len(g.Edges()) != 6 {
t.Fatal(g)
}
for _, edge := range g.Edges() {
| [Object,EnsureReplicationControllerNode,EnsureDeploymentConfigNode,From,New,Edges,To,Fatal,Errorf,Accessor,GetNamespace] | TestNamespaceEdgeMatching tests that the given object is in the graph. getNamespace returns the namespace of the node or an error if the node is not a Kubernetes. | Previously, two edges between the same nodes with opposite orientation were returned as one edge (even though this is a directed graph). Looks like this a result of an upstream fix. |
@@ -3618,7 +3618,7 @@ obj_comp_cb(tse_task_t *task, void *data)
DAOS_FAIL_CHECK(DAOS_DTX_NO_RETRY))
obj_auxi->io_retry = 0;
- if (pm_stale || obj_auxi->io_retry)
+ if (!obj_auxi->no_retry && (pm_stale || obj_auxi->io_retry))
obj_retry_cb(task, obj, obj_auxi, pm_stale);
if (!obj_auxi->io_retry) {
| [No CFG could be retrieved] | This function will attempt to fetch the data from the specified target. If the target is not This function is called from the DAO thread to check if the task is in the queue. | I don't quite see why we need a special flag here, I suppose for both client and server stack, it should retry only for recoverable errors, for server shutdown, a non-recoverable error should be returned? With current change, the rebuild will fail when pool leader changed? Is it acceptable? |
@@ -186,10 +186,12 @@ public final class ProMoveUtils {
for (final Unit transport : amphibAttackMap.keySet()) {
int movesLeft = TripleAUnit.get(transport).getMovementLeft().intValue();
Territory transportTerritory = ProData.unitTerritoryMap.get(transport);
+ moves.newSequence();
... | [ProMoveUtils->[calculateMoveRoutes->[equals,getUnits,test,addAll,warn,getRouteForUnit,unitIsSea,containsKey,unitIsAir,territoryCanMoveLandUnitsThrough,getSecond,of,unitIsLand,carrierMustMoveWith,isEmpty,toSet,allMatch,getRound,anyMatch,getData,territoryCanMoveSeaUnitsThrough,getName,getFirst,get,contains,collect,terri... | Calculate the move routes and move routes for a given player. Add a unit to the list of remaining units to move. find the next node in the network and add it to the routing table. | nit, is diamond notation available here, eg: `new ArrayList<>`, or does that throw off the type-inference of `var`? |
@@ -30,8 +30,8 @@ func (r *Runtime) makeInfraContainer(ctx context.Context, p *Pod, imgName, imgID
return nil, err
}
- // Set Pod hostname as Pod name
- g.Config.Hostname = p.config.Name
+ // Set Pod hostname
+ g.Config.Hostname = p.config.Hostname
isRootless := rootless.IsRootless()
| [createInfraContainer->[makeInfraContainer,New,Names,ImageRuntime,Inspect],makeInfraContainer->[ID,SetRootReadonly,IsRootless,WithPod,New,newContainer,Errorf,RemoveMount,SetProcessArgs,Split,AddMount,AddProcessEnv,Debugf]] | makeInfraContainer creates a new container with the given name and image ID. This is a helper function to create a new container with the specified options. | If pod hostname isn't configured, what does the hostname become? If it ends up empty (or the name of the infra container) we may wanna fallback on pod name |
@@ -6,4 +6,12 @@ module SearchHelper
end
experiments.uniq
end
+
+ def sub_results(el)
+ elements = []
+ el.each do |m|
+ elements << m
+ end
+ elements.uniq
+ end
end
| [experiments_results->[each,experiment,uniq]] | Returns an array of all the experiments that have been performed on the given tag. | Trailing whitespace detected. |
@@ -526,8 +526,7 @@ class DockerAgent(Agent):
# In the future we don't want the agent to set logging config on a flow
# run unless explicitly asked. We do this early on so later config
# sources can override
- if run_config is None:
- env.update({"PREFECT__LOGGING__LEVEL": ... | [DockerAgent->[_is_named_volume_win32->[_is_named_volume_unix],_parse_volume_spec_unix->[_is_named_volume_unix],_parse_volume_spec_win32->[_is_named_volume_win32]],DockerAgent] | Populate the environment variables for a specific object in the environment. return false if environment not found. | So my only point of concern is this still > In the future we don't want the agent to set logging config on a flow run unless explicitly asked. We do this early on so later config sources can override we are in direct violation of this idea here `env.update({"PREFECT__LOGGING__LEVEL": config.logging.level})` where the l... |
@@ -36,6 +36,8 @@ namespace Content.Server.GameObjects.Components.Projectiles
private string _soundHit;
private string _soundHitSpecies;
+ private bool _damagedEntity;
+
public override void ExposeData(ObjectSerializer serializer)
{
base.ExposeData(serializer);
| [ProjectileComponent->[CollideWith->[Deleted,Kick,Hard,ChangeDamage,entity,TryGetEntity,Normalized,PlayAtCoords,TryGetComponent,GridPosition],PostCollide->[Delete],IgnoreEntity->[Uid,Dirty],ExposeData->[ExposeData,DataField],ComponentState->[Value],Invalid]] | Override this method to expose the data of the DamageManager. | Looks like you mixed this with your other PR. |
@@ -57,10 +57,12 @@ public class CodeGenRunner {
public static final List<String> CODEGEN_IMPORTS = ImmutableList.of(
"org.apache.kafka.connect.data.Struct",
+ "io.confluent.ksql.function.udf.caseexpression.SearchedCaseFunction",
"java.util.HashMap",
"java.util.Map",
"java.util.Lis... | [CodeGenRunner->[Visitor->[visitQualifiedNameReference->[addParameter],visitDereferenceExpression->[addParameter],visitSubscriptExpression->[addParameter]],compileExpressions->[CodeGenRunner],ParameterType->[equals->[equals]],buildCodeGenFromParseTree->[getParameterInfo]]] | Method to compile a list of expressions. Creates a CodeGenRunner from a parse tree. | Feels strange that these needed to be added to a static in this class, considering this class doesn't use these new methods - they are used in `SqlToJavaVisitor`. Maybe this `CODEGEN_IMPORTS` should actually be a static field on that class. What do you think? |
@@ -1,12 +1,12 @@
/**
* Copyright (C) 2017 Red Hat, Inc.
- *
+ * <p>
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
+ * ... | [DayTradeGetComponent->[setBeforeProducer,setHeader,removeHeaders,getName]] | Component which returns a DayTradeGetComponent which is a subclass of DayTradeGetComponent. | these `<p>`'s look wrong |
@@ -1483,7 +1483,7 @@ class RandomGrayscale(torch.nn.Module):
class RandomErasing(torch.nn.Module):
- """ Randomly selects a rectangle region in an image and erases its pixels.
+ """ Randomly selects a rectangle region in an torch Tensor image and erases its pixels.
'Random Erasing Data Augmentation' by... | [RandomAffine->[forward->[get_params]],_setup_angle->[_check_sequence_input],RandomPerspective->[forward->[get_params]],RandomCrop->[forward->[get_params]],GaussianBlur->[forward->[get_params]],RandomResizedCrop->[forward->[get_params]],ColorJitter->[forward->[get_params]],RandomRotation->[forward->[get_params]],Random... | Grayscale version of the input image with probability p unchanged. A base class for random - erasing random numbers. | Good catch. Perhaps be even more specific and mention that it does not support PIL? |
@@ -32,6 +32,7 @@ def require_active_plugin(fn):
class BraintreeGatewayPlugin(BasePlugin):
+ PLUGIN_ID = "mirumee.gateway.braintree"
PLUGIN_NAME = GATEWAY_NAME
DEFAULT_CONFIGURATION = [
{"name": "Public API key", "value": None},
| [BraintreeGatewayPlugin->[refund_payment->[_get_gateway_config],capture_payment->[_get_gateway_config],get_client_token->[get_client_token,_get_gateway_config],get_payment_config->[get_client_token,_get_gateway_config],list_payment_sources->[_get_gateway_config],authorize_payment->[_get_gateway_config],void_payment->[_... | Decorator to wrap a Braintree gateway plugin. Missing parameters in order to provide a more detailed description of the configuration that Saleor should. | A gateway can be many things, maybe "mirumee.payments.braintree" (and similarly for other payment plugins)? |
@@ -314,10 +314,15 @@ public class DagManager extends AbstractIdleService {
@Override
public void run() {
try {
- Object nextItem = queue.poll();
+ String nextDagToCancel = cancelQueue.poll();
+ //Poll the cancelQueue for a new Dag to cancel.
+ if (nextDagToCancel != null) {... | [DagManager->[DagManagerThread->[cleanUp->[hasRunningJobs,deleteJobState],onJobFinish->[submitNext],getRunningJobsCounter->[toString],cleanUpDag->[cleanUp],submitJob->[toString]],offer->[offer],setActive->[offer],shutDown->[shutDown]]] | This method is called when the job is scheduled to run. It polls the queue for. | Can the cancellation loginc in lines 340-355 be moved to a separate method? |
@@ -57,6 +57,14 @@ namespace Dynamo.Wpf.Extensions
get { return dynamoViewModel.PackageManagerClientViewModel; }
}
+ /// <summary>
+ /// A reference to package loader to query for certain packages info
+ /// </summary>
+ public IPackageLoader PackageLoader
+ {
... | [ViewLoadedParams->[AddMenuItem->[AddItemToMenu],AddItemToMenu->[Insert,Count,Add,SearchForMenuItem],OnSelectionCollectionChanged->[SelectionCollectionChanged],AddSeparator->[AddItemToMenu],MenuItem->[ToDisplayString,ToString,Items,First],AddToExtensionsSideBar->[ExtensionAlreadyPresent,AddTabItem,ExtensionAdded,Log],B... | Creates a new view object that can be used to create a new view object. Extension object that is being added to the extensions side bar. | This property is being obtained from a specific extension, namely, the PM extension in this case, still `PackageLoader` is being made generically available to all extensions. It seems a little counter-intuitive, no? |
@@ -664,10 +664,14 @@ public class NettyConnector extends AbstractConnector {
pipeline.addLast("http-upgrade", new HttpUpgradeHandler(pipeline, httpClientCodec));
}
- protocolManager.addChannelHandlers(pipeline);
+ if (protocolManager != null) {
+ proto... | [NettyConnector->[HttpUpgradeHandler->[exceptionCaught->[close],channelRead0->[close]],finalize->[finalize,close],createConnection->[createConnection],HttpHandler->[channelRead->[run],channelInactive->[close,channelInactive],channelActive->[channelActive],write->[write],toString],Listener->[connectionException->[run->[... | Initializes the event loop group. This method is used to initialize the channel group and register the necessary components. Initializes the channel. Adds a proxy handler to the pipeline. Add a new channel to the pipeline. | There is a log message below this which looks like it should be inside the if (indicating that it added the ActiveMQClientChannelHandler, when it presumably may not have now) |
@@ -1,5 +1,3 @@
class AuditLog < ApplicationRecord
belongs_to :user
-
- validates :user_id, presence: true
end
| [AuditLog->[belongs_to,validates]] | AuditLog is a log of all the application records that have been validated by the user. | Do we view these anywhere in the app? I tried searching for views but couldn't find any. Will not having a user break any assumptions we might have made? |
@@ -284,7 +284,8 @@ public abstract class BaseTopNAlgorithm<DimValSelector, DimValAggregateStore, Pa
keepOnlyN = n;
}
- protected Pair<Integer, Integer> computeStartEnd(int cardinality)
+ @VisibleForTesting
+ public Pair<Integer, Integer> computeStartEnd(int cardinality)
{
int startIn... | [BaseTopNAlgorithm->[makeResultBuilder->[getThreshold,getAggregatorSpecs,getTime,getComparator,getDimensionSpec,getResultBuilder,getPostAggregatorSpecs],AggregatorArrayProvider->[build->[fill,computeStartEnd]],makeAggregators->[getColumnSelectorFactory,factorize,size],BaseArrayProvider->[computeStartEnd->[getThreshold,... | Compute the start and end index of a missing node in the list. | this isn't used in any tests, does it need the expanded scope? |
@@ -84,6 +84,10 @@ def parse_args():
parser_updater_trialnum.add_argument('--id', '-i', dest='id', help='the id of experiment')
parser_updater_trialnum.add_argument('--value', '-v', required=True)
parser_updater_trialnum.set_defaults(func=update_trialnum)
+ parser_updater_feed_tuning_data = parser_upd... | [parse_args->[add_argument,ArgumentParser,parse_args,set_defaults,add_subparsers,add_parser,func],nni_info->[print,get_distribution,print_error],process_startup,parse_args,get] | Parse command line arguments and return a object. Update the last known number of times and update the last number of times of the last experiment get trial job id Adds the subparsers to the command line interface. | It's too long, can it be a little shorter or use shorthand? |
@@ -562,7 +562,13 @@ class IRCBot
private function _version($params)
{
- return $this->respond($this->config['project_name_version'].', PHP: '.PHP_VERSION);
+ $versions = version_info(false);
+ $schema_version = $versions['db_schema'];
+ $version = `git rev-parse --s... | [IRCBot->[_help->[respond],_device->[respond],_down->[respond],getData->[read],_port->[respond],connect->[connect],init->[init],_version->[respond],_log->[respond],_status->[respond],_reload->[respond,__construct],chkdb->[log],alertData->[read],getAuthdUser->[getUser],_join->[joinChan,respond],_quit->[respond],_auth->[... | check if there is a version or a log in the database. | We already have: local_sha You'll just need to cut it down to a shorter version. Better than doing another exec call. |
@@ -180,7 +180,9 @@ void VoxelManipulator::addArea(const VoxelArea &area)
dstream<<std::endl;*/
// Allocate and clear new data
- MapNode *new_data = new MapNode[new_size];
+ // FIXME: UGLY KLUDGE because MapNode default constructor is FUBAR; it
+ // initialises data that is going to be overwritten anyway
+... | [addArea->[addArea],spreadLight->[addArea,spreadLight],unspreadLight->[addArea,unspreadLight]] | This method is called by VoxelManipulator when a new area is added to the V This function is used to replace area data and flags with new area data and flags. | - It would be much better if you fixed this by adding a proper empty constructor. - AFAIK `char`'s size isn't necessarily a byte, you should use `u8`. - `sizeof(MapNode)` would be much clearer. - Since you aren't using any of `new`'s features you might as well use `malloc()`. |
@@ -340,6 +340,7 @@ var forbiddenTerms = {
'extensions/amp-access/0.1/amp-access.js',
'extensions/amp-experiment/0.1/variant.js',
'extensions/amp-user-notification/0.1/amp-user-notification.js',
+ 'src/log.js',
],
},
'getBaseCid': {
| [No CFG could be retrieved] | Provides a list of possible expectations for a message. RequiresReviewPrivacy - > add a warning message to the user if the user has not. | should be the `dist.3p/current/integration.js` |
@@ -355,6 +355,8 @@ func TestLoggerJSON(t *testing.T) {
Duration: assertFloat64NotZero(),
Overhead: assertFloat64NotZero(),
RetryAttempts: assertFloat64(float64(testRetryAttempts)),
+ "TLSVersion": assertString("TLS13"),
+ "TLSCipher": ... | [RemoveAll,WriteHeader,NewRequest,HandlerFunc,TempFile,Now,Duration,Close,TempDir,Set,Error,Stat,ReadFile,UserPassword,ServeHTTP,UTC,NewRecorder,Errorf,NotEqual,MustCompile,After,NotContains,Zero,TrimSpace,Join,Equal,Cleanup,Local,Contains,Name,Regexp,Parallel,NoError,Log,Fatalf,Split,NotZero,Write,Sprintf,Rotate,Unmar... | Config for the field. Expected returns a map of expected values. | Could you directly use `TLSVersion` and `TLSCipher` constants here? |
@@ -202,9 +202,12 @@ void TargetedMovementGeneratorMedium<T, D>::_setTargetLocation(T* owner, bool in
init.Launch();
return;
}
- }
-
- // if failed to generate, just use normal MoveTo
+ } else {
+ // evade first
+ if (owner->GetTypeId() == TYPEID_U... | [DoFinalize->[_updateSpeed],DoReset->[DoInitialize],DoInitialize->[_setTargetLocation,_updateSpeed],DoUpdate->[_setTargetLocation]] | Checks if the target is in a known state and if so sets the location of the target if i_target is not in the chain and owner is not the same place as i Checks if a node is on a collision with another node. | same as above (codestyle consistency) |
@@ -19,10 +19,8 @@ import sys
import random
import paddle
import paddle.fluid as fluid
-import argparse
import functools
import contextlib
-import paddle.fluid.profiler as profiler
from paddle.dataset.common import download
from PIL import Image, ImageEnhance
import math
| [process_image->[resize_short,crop_image],val->[_reader_creator],TestCalibrationForResnet50->[download_data->[cache_unzipping],download_resnet50_model->[download_data],run_program->[val],test_calibration->[download_resnet50_model,run_program]],TestCalibrationForMobilenetv1->[download_mobilenetv1_model->[download_data],... | - - - - - - - - - - - - - - - - - - Function to crop and process an image. | please update line 44 '# TODO(guomingz): Remove duplicated code from line 45 ~ line 114'-> '# TODO(guomingz): Remove duplicated code from resize_short, crop_image, process_image, _reader_creator'. The reason is that the line number changes in this PR. |
@@ -48,7 +48,9 @@ master_doc = 'index'
# General information about the project.
project = u'Pulp Project'
-copyright = u'2012-2014, Pulp Team'
+
+# Set copyright to current year
+copyright = u'2012-' + str(date.today().year).decode("utf-8") + u', Pulp Team'
# The version info for the project you're documenting, ... | [get_html_theme_path,insert,abspath] | This function is used to add directories to the sys. path and to add any necessary directories Match files and directories to ignore when looking for source files. | Since this isn't Python 3 compatible anyway, it might be better to be explicit and cast `date.today().year` to unicode directly: `unicode(date.today().year)` |
@@ -644,8 +644,11 @@ public class CoreMessage extends RefCountMessage implements ICoreMessage {
@Override
public int getEncodeSize() {
+ if (buffer == null) {
+ return -1;
+ }
checkEncode();
- return buffer == null ? -1 : buffer.writerIndex();
+ return buffer.writerIndex();
... | [CoreMessage->[getDoubleProperty->[checkProperties,messageChanged,getDoubleProperty],getObjectProperty->[checkProperties,getObjectProperty],getPropertyKeysPool->[getPropertyKeysPool],putCharProperty->[checkProperties,messageChanged,putCharProperty],getPropertyNames->[checkProperties,getPropertyNames],getShortProperty->... | Returns the size of the encoded message. | checkEncode is using buffer therefore it is good to do null check before |
@@ -61,6 +61,18 @@ public final class KsqlAuthorizationValidatorFactory {
return Optional.empty();
}
+ private static KsqlAuthorizationValidator createAuthorizationValidator(KsqlConfig ksqlConfig) {
+ KsqlAccessValidator accessValidator = new KsqlAccessValidatorProvider();
+
+ // The cache expiry time ... | [KsqlAuthorizationValidatorFactory->[create->[KsqlAuthorizationValidatorImpl,of,isKafkaAuthorizerEnabled,equals,getAdminClient,getString,empty,isAuthorizedOperationsSupported,warn,info],isKafkaAuthorizerEnabled->[getCause,get,isEmpty,value],getLogger]] | Creates an instance of KsqlAuthorizationValidator based on the given configuration. | to self: Guess it's fine to just check the expiryTime and not the max.entries config, since our main goal here is to refresh every so often.. |
@@ -72,7 +72,12 @@ final class Router implements RouterInterface, UrlGeneratorInterface
$pathInfo = str_replace($baseContext->getBaseUrl(), '', $pathInfo);
$request = Request::create($pathInfo, 'GET', [], [], [], ['HTTP_HOST' => $baseContext->getHost()]);
- $context = (new RequestContext())->... | [Router->[getContext->[getContext],generate->[generate],getRouteCollection->[getRouteCollection],match->[match,getContext,setContext],setContext->[setContext]]] | Match a path info. | Throwing a `RouteNotFoundException` is weird. According to the PHPDoc, it should be `ResourceNotFoundException` in your case. |
@@ -64,7 +64,8 @@ class GradeEntryFormsController < ApplicationController
# For students
def student_interface
@grade_entry_form = GradeEntryForm.find(params[:id])
- if @grade_entry_form.is_hidden
+ @section_hidden = SectionDueDate.find_by(assignment: params[:id], section: current_user.section)&.is_hid... | [GradeEntryFormsController->[update_grade->[update],new->[new],create->[create],update->[update]]] | This action shows the user s reserved node in the data array. | Make this a regular variable (not an instance variable) unless you intend to use this in a view later on. |
@@ -747,6 +747,15 @@ bool from_param_list(const ParameterList& param_list,
// OpenDDS::DCPS::DiscoveredWriterData
+void add_DataRepresentationQos(ParameterList& param_list, const DDS::DataRepresentationIdSeq& ids, bool reader)
+{
+ DDS::DataRepresentationQosPolicy dr_qos;
+ dr_qos.value = DCPS::get_effective_dat... | [No CFG could be retrieved] | This method converts a ParameterList to a ParameterList. region DDsPublicationData methods. | As with most other parameters, if the value is the "network message default" then the parameter should be omitted. In this case we have the added complexity that the "network message default" is different from the default QoS (empty sequence) and also different from the interpretation of the empty sequence. But that sh... |
@@ -194,7 +194,8 @@ class TaskBase(SubsystemClientMixin, Optionable, AbstractClass):
return self.context.options.for_scope(self.options_scope)
def get_passthru_args(self):
- """
+ """Returns the passthru args for this task, if it supports them.
+
:API: public
"""
if not self.supports_pass... | [TaskBase->[get_passthru_args->[supports_passthru_args,stable_name],invalidate->[_build_invalidator],implementation_version_str->[implementation_version],_options_fingerprint->[supports_passthru_args],invoke_prepare->[_scoped_options],_should_cache_target_dir->[artifact_cache_writes_enabled],get_alternate_target_roots-... | Returns the passthru arguments for this task. | Should probably explicitly reference the mixins and discourage custom overrides. |
@@ -302,7 +302,7 @@ class MSRAInitializer(Initializer):
(https://arxiv.org/abs/1502.01852)
"""
- def __init__(self, uniform=True, fan_in=None, seed=0):
+ def __init__(self, uniform=True, fan_in=None, seed=set_random_seed(0)):
"""Constructor for MSRAInitializer
Args:
| [XavierInitializer->[__call__->[_compute_fans]],MSRAInitializer->[__call__->[_compute_fans]]] | Constructor for MSRAInitializer. | Could the user set the seed globally instead of setting the seed at each parameter initializer? |
@@ -89,6 +89,7 @@ public class MapPanel extends ImageScrollerLargeView {
private final TileManager tileManager;
private BufferedImage mouseShadowImage = null;
private String movementLeftForCurrentUnits = "";
+ private ResourceCollection movementFuelCost;
private final UiContext uiContext;
private final ... | [MapPanel->[setTopLeft->[setTopLeft],setRoute->[setRoute],setTerritoryOverlayForBorder->[setTerritoryOverlayForBorder],getTerritory->[getTerritory],paint->[normalizeX,paint,normalizeY],notifyMouseMoved->[mouseMoved],getErrorImage->[getErrorImage],BackgroundDrawer->[run->[getData]],attachmentChanged->[updateCountries],g... | Creates a new instance of MapPanel. Creates a daemon thread that runs the backgroun. | This field is not initialized in the constructor, and only appears to be initialized via `setMouseShadowUnits()`. Should it be initialized to an empty `ResourceCollection` just in case `paint()` gets called before `setMouseShadowUnits()` and triggers an NPE? |
@@ -0,0 +1,10 @@
+class AddAllowPromptToServiceProviders < ActiveRecord::Migration[5.1]
+ def up
+ add_column :service_providers, :allow_prompt, :boolean
+ change_column_default :service_providers, :allow_prompt, false
+ end
+
+ def down
+ remove_column :service_providers, :allow_prompt
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | How would you feel about renaming this `allow_prompt_login` or something like that since there are multiple values for the `prompt` param. |
@@ -76,7 +76,9 @@ abstract class KernelTestCase extends \PHPUnit\Framework\TestCase
'sulu_context' => 'admin',
], $this->getKernelConfiguration(), $options);
- $kernel = new \AppKernel(
+ $kernelClass = getenv('KERNEL_CLASS') ?: '\AppKernel';
+
+ $kernel = new $kernelClass(
... | [KernelTestCase->[createClient->[getKernel],getContainer->[getContainer]]] | Get a kernel instance. | Is the `KERNEL_CLASS` also what Symfony is doing now? Resp. is that required for the symfony bridge? |
@@ -25,3 +25,5 @@ export const convertDateTimeFromServer = date =>
export const convertDateTimeToServer = date =>
(date ? moment(date, APP_LOCAL_DATETIME_FORMAT_Z).toDate() : null);
+
+export const defaultDateTime = () => moment().startOf('day').format(APP_LOCAL_DATETIME_FORMAT);
| [No CFG could be retrieved] | Export Date converter to Server - Local Date format. | it's a function, please use a verb to mark the action (like convertXXX, whatever). |
@@ -30,7 +30,10 @@ import {dict} from '../src/utils/object';
*/
export function masterSelection(win, type) {
// The master has a special name.
- const masterName = 'frame_' + type + '_master';
+ const allowedTypes = (masterFrameAccessibleTypes[type] || []).slice();
+ allowedTypes.push(type);
+ // Sort to ensu... | [No CFG could be retrieved] | Exports a window object to the master frame of a given type. Checks if the window is the master window of the selected embed. | You can use `concat` here. |
@@ -17,6 +17,7 @@ import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import io.prestosql.testing.AbstractTestDistributedQueries;
import io.prestosql.testing.MaterializedResult;
+import io.prestosql.testing.QueryRunner;
import org.intellij.lang.annotations.Language;
impor... | [TestAccumuloDistributedQueries->[testCreateTableAsSelect->[assertTrue,assertCreateTableAsSelect,tableExists,assertFalse,assertTableColumnNames,getSession,assertUpdate],testCreateTableEmptyColumns->[assertQuery,assertUpdate],testSelectNullValue->[assertQuery,assertUpdate],testShowColumns->[assertEquals,getField,compute... | Creates a new object that represents a single unique identifier. Add column and drop column. | commit message too long |
@@ -412,10 +412,14 @@ class BuildSystemGuesser:
# Most octave extensions are hosted on Octave-Forge:
# http://octave.sourceforge.net/index.html
# They all have the same base URL.
- if 'downloads.sourceforge.net/octave/' in url:
+ if url is not None and 'downloads.sourceforge... | [get_versions->[BuildSystemGuesser],PackageTemplate->[write->[write]],create->[get_repository,write,get_versions,get_url,get_name,get_build_system]] | Try to guess the type of build system used by a project based on the contents of its This method is called when the process exits and the output of the n - ary command is. | When is `stage` not provided? |
@@ -219,11 +219,13 @@ public class QueueChannel extends AbstractPollableChannel implements QueueChanne
return purgedMessages;
}
+ @ManagedAttribute(description = "Queue size")
@Override
public int getQueueSize() {
return this.queue.size();
}
+ @ManagedAttribute(description = "Queue remaining capacity"... | [QueueChannel->[registerMetricsCaptor->[registerMetricsCaptor],purge->[clear],destroy->[destroy]]] | This method purges all messages that match the given selector. | The `@ManagedResource` is missed then. Or you placed it on `QueueChannelOperations`... |
@@ -48,8 +48,10 @@ $limit = (int)elgg_extract('limit', $vars, 0);
?>
</ul>
</div>
-<script>
-require(['elgg/UserPicker'], function (UserPicker) {
- UserPicker.setup('.elgg-user-picker[data-name="<?php echo $name ?>"]');
+<script>// <![CDATA[
+elgg.defer(function () {
+ require(['elgg/UserPicker'], function (UserP... | [No CFG could be retrieved] | <div class = c - n - n - n - n - n - n. | This callback triangle is making me rethink putting requirejs at bottom... |
@@ -333,7 +333,7 @@ def unify_generic_callable(type: CallableType, target: CallableType,
return None
msg = messages.temp_message_builder()
applied = mypy.applytype.apply_generic_arguments(type, inferred_vars, msg, context=target)
- if msg.is_errors() or not isinstance(applied, CallableType):
+ ... | [is_more_precise->[is_proper_subtype],is_subtype->[is_subtype],is_subtype_ignoring_tvars->[is_subtype],restrict_subtype_away->[is_subtype],satisfies_upper_bound->[is_subtype],is_var_arg_callable_subtype_helper->[is_subtype],SubtypeVisitor->[visit_union_type->[is_subtype],visit_callable_type->[is_subtype],visit_instance... | Try to unify a generic callable type with another callable type. | Perhaps `msg.is_errors()` should be an assertion too? |
@@ -1291,8 +1291,7 @@ void MapblockMeshGenerator::drawNode()
else
light = getInteriorLight(n, 1, nodedef);
switch (f->drawtype) {
- case NDT_LIQUID: drawLiquidNode(false); break;
- case NDT_FLOWINGLIQUID: drawLiquidNode(true); break;
+ case NDT_FLOWINGLIQUID: drawLiquidNode(); break;
cas... | [blendLightColor->[blendLight,blendLightColor],drawRaillikeNode->[drawQuad,isSameRail,useTile],drawTorchlikeNode->[drawQuad,useTile],drawNode->[drawGlasslikeNode,drawNodeboxNode,drawAllfacesNode,getSmoothLightFrame,drawSignlikeNode,drawRaillikeNode,drawGlasslikeFramedNode,drawPlantlikeNode,drawMeshNode,errorUnknownDraw... | This method is called to draw a node in the scene. | How does this work if `NDT_LIQUID` is not handled? |
@@ -39,6 +39,12 @@ public class DocumentTypeImpl extends CompositeTypeImpl implements DocumentType
protected PrefetchInfo prefetchInfo;
+ protected Set<String> subtypes;
+
+ protected Set<String> forbiddenSubtypes;
+
+ protected Set<String> allowedSubtypes;
+
/**
* Constructs a document typ... | [DocumentTypeImpl->[isOrdered->[contains],isFolder->[contains],isFile->[contains],hasFacet->[contains],emptyList,emptySet]] | Construct a new DocumentType from a composite type. This is a utility method that can be overridden by subclasses to provide a prefetchInfo. | Missing `@since 8.4` |
@@ -231,6 +231,9 @@ def fetch_repodata_remote_request(session, url, etag, mod_stamp):
If the requested url is in fact a valid conda channel, please request that the
channel administrator create `noarch/repodata.json` and associated
`noarch/repodata.json.bz2... | [read_local_repodata->[read_pickled_repodata,write_pickled_repodata],fetch_repodata->[get_cache_control_max_age,process_repodata,read_local_repodata,read_mod_and_etag,fetch_repodata_remote_request,write_pickled_repodata],fetch_index->[_collect_repodatas],_collect_repodatas->[_collect_repodatas_concurrent,_collect_repod... | Fetches a single file from a remote repository. e is a URL that points to a noarch directory and a file containing a noarch create a nagios object and associated file This function is called when a user requests a and the user has provided a valid credentials. | should this be repodata.json (with a period)? |
@@ -529,6 +529,12 @@ exports.extensionBundles = [
options: {hasCss: true},
type: TYPES.MISC,
},
+ {
+ name: 'amp-fit-text',
+ version: '0.2',
+ latestVersion: '0.1',
+ type: TYPES.MISC,
+ },
{
name: 'amp-font',
version: '0.1',
| [No CFG could be retrieved] | Version of AMP header. A mofical order of the elements in the order they are defined. | I think this is supposed to be joined with the other `amp-fit-text`, just add a `version: ['0.1', '0.2']` to that one. Right? |
@@ -116,7 +116,7 @@ function buildArticleHTML(article) {
return '<div class="single-article single-article-small-pic" data-content-user-id="'+article.user_id+'">\
'+videoHTML+'\
'+orgHeadline+'\
- <div class="small-pic">\
+ <div class="small-pic" data-hover-details="users/'+article.user_id+... | [No CFG could be retrieved] | Generate HTML for a single - article block. readingTimeHTML - > reading time HTML. | shouldn't this be the API path? If you replace it with `api_user_path(article.user_id)` you don't need to construct the API path later on |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.