patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -701,7 +701,7 @@ namespace Dynamo.ViewModels
Package dynPkg;
var pmExtension = DynamoViewModel.Model.GetPackageManagerExtension();
- var firstOrDefault = pmExtension.PackageLoader.LocalPackages.FirstOrDefault(pkg => pkg.Name == packageDownloa... | [PackageManagerClientViewModel->[PublishNewPackage->[Execute],ShowNodePublishInfo->[Execute],PublishCurrentWorkspace->[Execute],PublishSelectedNodes->[Execute],DownloadAndInstallPackage->[ShowTermsOfUseDialog],PublishCustomNode->[Execute],ListAll->[ListAll],ExecutePackageDownload->[JoinPackageNames]],TermsOfUseHelper->... | DownloadAndInstall downloads a package and installs it. if any of the messages in the message array is not a valid object. | hmm, do you think this could change any existing behavior? |
@@ -273,13 +273,7 @@ class InfoDialog extends Component {
= encodeURIComponent(this.props._conferenceName);
const pathParts = window.location.pathname.split('/');
- // More than two parts implies the path consists of more than the first
- // forward slash and the meeting name. If t... | [No CFG could be retrieved] | Returns the URL for the static dial in info page. Generate the UI for the invite page. | this seems weird, we always drop a part of the path here? did something change that makes this the right thing to do? |
@@ -595,9 +595,10 @@ class InstallRequirement(object):
'Running setup.py (path:%s) egg_info for package from %s',
self.setup_py_path, self.link,
)
- base_cmd = make_setuptools_shim_args(self.setup_py_path)
- if self.isolated:
- base_cmd += ["--no-u... | [InstallRequirement->[from_path->[from_path],prepare_metadata->[_correct_build_location],_get_archive_name->[_clean_zip_name],install->[install_editable,prepend_root,move_wheel_files],uninstall->[check_if_exists],move_wheel_files->[move_wheel_files],_correct_build_location->[build_location],load_pyproject_toml->[load_p... | Run setup. py egg_info with the given . | Since we're not limited by backwards compatibility, we might as well write this out fully to have a nicer name: `no_user_config`. |
@@ -139,6 +139,11 @@ function $RouteProvider() {
*
* @description
* Adds a new route definition to the `$route` service.
+ *
+ * Note:
+ * Purpose of `templateUrl` option (as a string value) within `param` parameter when there also exists `path` parameter:
+ * - `path` allows scenarios where sa... | [No CFG could be retrieved] | This method is used to add a new route definition to the route service. region RouteProvider Methods. | I don't know if it's me, but I don't understand what you mean... |
@@ -125,14 +125,9 @@ func (ac *AccessController) Authorized(ctx context.Context, accessRecords ...reg
return nil, ac.wrapErr(err)
}
- client, err := NewUserOpenShiftClient(bearerToken)
- if err != nil {
- return nil, ac.wrapErr(err)
- }
-
// In case of docker login, hits endpoint /v2
if len(accessRecords) =... | [ServeHTTP->[Error],Error->[Error],Authorized->[wrapErr]] | Authorized checks if the user has access to the requested resources Verify that the user has access to the prune resource. | `getToken` can return an empty token... won't that escalate privileges now? |
@@ -85,7 +85,8 @@ public class UnboundedReadFromBoundedSource<T> extends PTransform<PBegin, PColle
@Override
public PCollection<T> expand(PBegin input) {
- return input.getPipeline().apply(Read.from(new BoundedToUnboundedSourceAdapter<>(source)));
+ final ArrayDeque<BoundedSource<T>> dequeue = new ArrayDe... | [UnboundedReadFromBoundedSource->[getDefaultOutputCoder->[getDefaultOutputCoder],BoundedToUnboundedSourceAdapter->[getDefaultOutputCoder->[getDefaultOutputCoder],CheckpointCoder->[decode->[decode],encode->[encode]],split->[split],ResidualSource->[getCurrentTimestamp->[getCurrentTimestamp],getCheckpointMark->[getCurrent... | Expand the source into a collection of objects. | Please revert, wouldn't make any change here. The normal use case of wrapping a single source should still be supported. |
@@ -1,8 +1,8 @@
class CheckinsController < ApplicationController
permits :comment, :shared_twitter, :shared_facebook, :spoil
- before_filter :authenticate_user!, only: [:new, :create, :create_all, :edit, :update, :destroy]
- before_filter :set_work, only: [:new, :create, :create_all, :show, :edit, :up... | [CheckinsController->[destroy->[destroy],show->[new],create->[new],create_all->[create],new->[new]]] | Controller for check - in - all - checks. Updates a checkin object. | Line is too long. [91/90] |
@@ -116,6 +116,14 @@ public final class SourceConfigurer {
} else {
context = ValueResolvingContext.builder(initialiserEvent, expressionManager).build();
Scheduler scheduler = (Scheduler) valueResolver.resolve(context);
+ if (isRestart) {
+ if (scheduler instanceof Fix... | [SourceConfigurer->[configure->[build->[build],build]]] | Configures a source with a specific configuration. | I would move this logic to another class, like a factory that given a scheduler and the boolean returns another scheduler |
@@ -126,7 +126,7 @@ func (d *Dispatcher) deleteDatastoreFiles(ds *object.Datastore, path string, for
}
m := object.NewFileManager(ds.Client())
- if d.isVSAN(ds) {
+ if d.geVC65() || d.isVSAN(ds) {
if err = d.deleteFilesIteratively(m, ds, dsPath); err != nil {
return empty, err
}
| [deleteVolumeStoreIfForced->[deleteDatastoreFiles],getSortedChildren->[getChildren]] | deleteDatastoreFiles deletes all files in the given path on the given datastore. | Can we do this (call `deleteFiles...`) all the time? Do we need to _only_ do it for 65 or vsan? |
@@ -0,0 +1,11 @@
+class CreateSuspendedUsers < ActiveRecord::Migration[6.0]
+ def change
+ create_table :suspended_users do |t|
+ t.string :username_hash, null: false
+
+ t.timestamps
+ end
+
+ add_index :suspended_users, :username_hash, unique: true
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | This may be paranoid, but on the off-chance we do get a hash collision there's a uniqueness validation.... |
@@ -1012,6 +1012,12 @@ class PMA_Util
$sql_query = '';
}
}
+
+ // Parse and analyze the query
+ $analyzed_sql_results = PMA_SQP_getParserAnalyzeMap($sql_query, $GLOBALS['db']);
+
+ // Synchronize message(query) with table
+ $sql_query = ... | [PMA_Util->[getTableList->[getTablesFull,isSystemSchema],formatSql->[substr],getMessage->[addMessage,getDisplay],asWKT->[tryQuery,fetchRow,freeResult],getImage->[getPath],getDefaultFunctionForField->[getTypeClass],mysqlDie->[isSuccess,getError,addJSON],isForeignKeySupported->[fetchValue],profilingSupported->[fetchValue... | Returns a message if the message is not defined. - Analyze the query and return a base of a missing node in the SQL table - Append limit clause to query and append limit clause to query This function is called when a user has not selected a node in the query box. | The $sql_query parameter is rendered on the UI as query message above the table. This code sets the parameter to remembered query or user executed query. |
@@ -0,0 +1,15 @@
+package com.baeldung.constructorspecification.rules;
+
+/**
+ * Created by arash on 16.12.21.
+ */
+
+class Test {
+ public Test(){
+ Test t = new Test();
+ }
+
+ public static void main(String[] args) {
+ new Test(); // java.lang.StackOverflowError
+ }
+}
\ No newline at end... | [No CFG could be retrieved] | No Summary Found. | Space between () and { |
@@ -96,6 +96,9 @@ type crdHandler struct {
masterCount int
converterFactory *conversion.CRConverterFactory
+
+ // request timeout we should delay storage teardown for
+ requestTimeout time.Duration
}
// crdInfo stores enough information to serve the storage for the custom resource
| [Convert->[Convert],GetRESTOptions->[GetRESTOptions],ConvertToVersion->[ConvertToVersion],ServeHTTP->[ServeHTTP],Decode->[Decode],ConvertFieldLabel->[ConvertFieldLabel],Recognizes->[Recognizes],Default->[Default],ObjectKinds->[ObjectKinds]] | NewCustomResourceDefinitionHandler returns a handler which serves the object in the API. | this wasn't clean |
@@ -38,4 +38,6 @@ def setup_parser(subparser):
def build(parser, args):
+ tty.warn("This command is deprecated. Use `spack install --until` to"
+ " select an end phase instead")
cfg._stop_at_phase_during_install(args, build, build_system_to_phase)
| [build->[_stop_at_phase_during_install],setup_parser->[setup_parser]] | Build a new version of the system. | Add that this will be removed in a future Spack version. |
@@ -373,6 +373,8 @@ func (d *Data) CopyNonEmpty(src *Data) error {
d.RegistryCAs = src.RegistryCAs
+ d.SyslogConfig = src.SyslogConfig
+
d.ContainerConfig.ContainerNameConvention = src.ContainerConfig.ContainerNameConvention
return nil
| [IsSet->[Empty],CopyNonEmpty->[IsSet,copyVolumeStores,copyContainerNetworks],Empty->[Empty]] | CopyNonEmpty copies all non - nil fields from the src object into the dest object. This function is used to copy all the properties of a onto the object that are not. | If --syslog-address is not set, will it be reset to empty during configure? |
@@ -193,7 +193,11 @@ function &DB($params = '', $query_builder_override = NULL)
// Load the DB driver
$driver_file = BASEPATH.'database/drivers/'.$params['dbdriver'].'/'.$params['dbdriver'].'_driver.php';
- file_exists($driver_file) OR show_error('Invalid DB driver');
+ if( ! file_exists($driver_file))
+ {
+ thr... | [DB->[get_package_paths,initialize]] | This function loads the database configuration file. This function is used to load the database configuration from a database connection string. A class that extends proper parent class based on whether we re using the query builder class or This function is used to initialize a database driver. | There needs to be a space between if and the opening parenthesis, i.e. `if (` |
@@ -0,0 +1 @@
+#include "kb.h"
| [No CFG could be retrieved] | No Summary Found. | These `kb` files should be named the same as the project - in this case, `alu84` :) |
@@ -38,18 +38,6 @@ public class BooleanVectorValueMatcher extends BaseVectorValueMatcher
return new BooleanVectorValueMatcher(selector, matches);
}
- @Override
- public int getCurrentVectorSize()
- {
- return selector.getCurrentVectorSize();
- }
-
- @Override
- public int getMaxVectorSize()
- {
- ... | [BooleanVectorValueMatcher->[getMaxVectorSize->[getCurrentVectorSize],of->[BooleanVectorValueMatcher],getCurrentVectorSize->[getCurrentVectorSize]]] | Creates a new BooleanVectorValueMatcher that matches the given boolean mask. | nit: maybe good to have unit tests for future proof. |
@@ -363,12 +363,8 @@ int common_import(void *keydata, int selection, const OSSL_PARAM params[],
*/
if ((selection & OSSL_KEYMGMT_SELECT_DOMAIN_PARAMETERS) == 0)
return 0;
- if ((selection & OSSL_KEYMGMT_SELECT_PRIVATE_KEY) != 0
- && (selection & OSSL_KEYMGMT_SELECT_PUBLIC_KEY) == 0)
- ... | [No CFG could be retrieved] | ok - If keydata is not NULL and selection is set to 1 the key is not region KeyManagement interface. | Did you notice the `include_private` further down, passed to `ec_key_fromdata()`? That has lost its importance (I'm not sure why it was even important to begin with), so I'd throw that away, including removing that last `ec_key_fromdata()` argument. |
@@ -1071,7 +1071,6 @@ public class DeckPicker extends NavigationDrawerActivity implements
startActivityForResultWithAnimation(intent, ADD_NOTE, START);
}
-
private void showStartupScreensAndDialogs(SharedPreferences preferences, int skip) {
// For Android 8/8.1 we want to use software re... | [DeckPicker->[handleDbError->[showDatabaseErrorDialog],onRequestPermissionsResult->[onRequestPermissionsResult,handleStartup],undo->[undoTaskListener],mediaCheck->[mediaCheckListener],MediaCheckListener->[actualOnPostExecute->[showMediaCheckDialog]],updateDeckList->[updateDeckListListener,updateDeckList],onDestroy->[on... | Add note to the dialog. Check if a missing version number is required. Checks if a specific lease is available. Displays new version of the application if it is not already showing. | You have altered spacing unnecessarily here, please do not mix changes in one commit - if you have a formatting commit, do it all as a separate commit, and keep related functional changes in their own commit(s). The philosophy is based on the idea that changing software is easy. We merge tens of changes a week, sometim... |
@@ -78,7 +78,7 @@ class Pkg(ConanFile):
ref = ConanFileReference.loads("pkg/0.1@lasote/stable")
conanfile = load(client2.cache.conanfile(ref))
self.assertNotIn("# Recipe revision 2", conanfile)
- data = load(os.path.join(client2.cache.export_sources(ref), "myfile.txt"))
+ data =... | [CopyPackagesTest->[test_copy_command->[packages,TestClient,assertFalse,assertEqual,len,run,exists,save,loads,listdir],test_copy_exports_sources_with_revision_command->[conanfile,export_sources,TestClient,assertIn,assertNotIn,run,join,save,loads,load,TestServer],expand]] | Test copy exports sources with revision command. | `self._cache.export_sources(ref, short_paths=False)` vs `self._cache.package_layout(ref, short_paths=None).export_sources()` |
@@ -477,8 +477,8 @@ func (s *testCoordinatorSuite) TestPeerState(c *C) {
// Transfer peer from store 4 to store 1.
c.Assert(tc.addRegionStore(1, 10), IsNil)
- c.Assert(tc.addRegionStore(2, 20), IsNil)
- c.Assert(tc.addRegionStore(3, 30), IsNil)
+ c.Assert(tc.addRegionStore(2, 10), IsNil)
+ c.Assert(tc.addRegionSt... | [TestPeerState->[addLeaderRegion,addRegionStore],TestShouldRunWithNonLeaderRegions->[LoadRegion,addLeaderStore],TestRestart->[addLeaderRegion,addRegionStore],TestPersistScheduler->[addLeaderStore],TestOperatorCount->[addLeaderRegion],TestShouldRun->[LoadRegion,addLeaderStore],TestDispatch->[addLeaderRegion,addRegionSto... | TestPeerState tests state of peer handle heartbeat - related methods. | Will not appear from strore 4 to store 2? |
@@ -824,7 +824,7 @@ class TestDownloadsUnlistedAddons(TestDownloadsBase):
def test_download_for_unlisted_addon_owner(self):
"""File downloading is allowed for addon owners."""
self.assert_served_internally(self.client.get(self.file_url), False)
- self.assert_served_internally(self.client.g... | [TestDownloadsBase->[assert_served_by_mirror->[assert_served_by_host],assert_served_locally->[assert_served_by_host]],TestDisabledFileDownloads->[test_admin_disabled_ok_for_author->[assert_served_internally],test_user_disabled_ok_for_author->[assert_served_internally],test_file_disabled_ok_for_admin->[assert_served_int... | Test download for unlisted addon owners. | gah! I just spent ages fixing that test |
@@ -431,7 +431,12 @@ var forbidden3pTerms = {
// usage in babel's external helpers that is in a code path that we do
// not use.
'\\.then\\((?!callNext)': ThreePTermsMessage,
- 'Math\\.sign' : ThreePTermsMessage,
+ 'Math\\.sign': ThreePTermsMessage,
+ 'Object\\.assign': {
+ message: ThreePTermsMessage,
+... | [No CFG could be retrieved] | Provides a message for the user that a user has not requested a polyfill. In code reviews. | you mind if i switch this to a eslint check instead? |
@@ -440,9 +440,11 @@ func (s *Server) ReadV3(p *Packet) (interface{}, error) {
buf := make([]byte, req.RequiredSize)
- n, err := file.ReadAt(buf, int64(req.Offset))
- if err != nil {
- if err != io.EOF || n <= 0 {
+ // Use ReadFull as Read() of an archive io.Pipe may return much smaller chunks,
+ // such as when... | [Open->[getSession,Open,newHandle],WriteV3->[getSession],DestroySessionV4->[removeSession],ReadV3->[getSession],GetattrV2->[Stat],Close->[getSession,Close],OpenV3->[getSession,Open,newHandle]] | ReadV3 reads a single block of data from a file. | Not sure how it would play out, but should we be implementing ReadFrom/WriteTo for efficient copy in any of these objects? |
@@ -57,8 +57,10 @@ class PythonAWSLambda(Target):
alias = "python_awslambda"
core_fields = (
- *COMMON_PYTHON_FIELDS,
- PythonSources,
+ *COMMON_TARGET_FIELDS,
+ DeprecatedPythonAwsLambdaSources,
+ DeprecatedPythonInterpreterCompatibility,
+ OutputPathField,
... | [PythonAwsLambdaRuntime->[to_interpreter_version->[group,match,cast,int],compute_value->[super,cast,match,InvalidFieldException]]] | Get a list of all fields from a core object. | This was meant to have been added in 2.0.x. |
@@ -112,6 +112,14 @@ class Reporting(Subsystem):
raise ValueError(
"Flags zipkin-trace-id and zipkin-parent-id must both either be set or not set."
)
+ if trace_id and len(trace_id) != 16 and len(trace_id) != 32:
+ raise ValueError(
+ "Value of the flag zipkin-trace-id must be a 16... | [Reporting->[update_reporting->[_consume_stringio,_get_invalidation_report],initialize->[initialize]]] | Initialize with the given RunTracker. This function is called when a node is missing a node. It will create a Zipkin. | Would it be useful to check whether the string is a hex string (I'm assuming it should be `[0-9a-f]`)? Would it be useful to turn this into a regex or helper method? Checking with a regexp could be `re.match(r'[0-9a-f]{16}|[0-9a-f]{32}', trace_id)`. |
@@ -363,6 +363,9 @@ class StandardOptions(PipelineOptions):
default=False,
action='store_true',
help='Whether to enable streaming mode.')
+ parser.add_argument('--job_name',
+ default=None,
+ help... | [PipelineOptions->[__getattr__->[_visible_option_list],__dir__->[_visible_option_list],__init__->[_BeamArgumentParser],__setattr__->[_visible_option_list],display_data->[get_all_options],get_all_options->[_BeamArgumentParser,_add_argparse_args],__str__->[_visible_option_list]],_BeamArgumentParser->[add_value_provider_a... | Adds the necessary arguments to the argparse parser. | It will be good to mention that it might or might not be honored by the runner. |
@@ -180,6 +180,16 @@ func MatchBastion(label labels.Selector, field fields.Selector) storage.Selectio
}
}
+// ShootNameTriggerFunc returns spec.shootRef.name of given Bastion.
+func ShootNameTriggerFunc(obj runtime.Object) string {
+ bastion, ok := obj.(*operations.Bastion)
+ if !ok {
+ return ""
+ }
+
+ return b... | [ValidateUpdate->[ValidateBastionStatusUpdate,ValidateBastionUpdate],heartbeat->[NewTime,Add,Now],Validate->[ValidateBastion],PrepareForCreate->[heartbeat],PrepareForUpdate->[NewTime,heartbeat,Add],DeepEqual,AddObjectMetaFieldsSet,HasMetaDataAnnotation,Errorf,Set] | MatchBastion returns a generic matcher for a given bastion. | Is this used somewhere? |
@@ -135,7 +135,7 @@ namespace System.Text.RegularExpressions
CultureInfo culture = (tree.Options & RegexOptions.CultureInvariant) != 0 ? CultureInfo.InvariantCulture : CultureInfo.CurrentCulture;
RegexBoyerMoore? bmPrefix = null;
- if (prefix.Prefix.Length > 1) // if it's == 1, we... | [RegexWriter->[Dispose->[Dispose],EmitFragment->[PatchJump,Emit,MapCapnum,StringCode]]] | Produces a RegexCode object from the given RegexTree. Return a RegexCode object that can be used to match a regex code. | Why does RegexCode need an `fcPrefix` if it has a `bmPrefix` ? As far as I can see it could have one or the other. In which case, if this method decides to use Boyer Moore, it can skip calculating `fcPrefix` at all. |
@@ -36,3 +36,8 @@ def iterable():
@streams_api.route('/error', methods=['GET'])
def error():
return Response(stream_json_error(), status=400)
+
+@streams_api.route('/compressed', methods=['GET'])
+def compressed():
+ return Response(stream_compressed_header_error(), status=300, headers={"Content-Type": "gzip"... | [iterable->[StreamingBody],error->[stream_json_error],basic->[streaming_body]] | Return a 400 error response. | I believe the header passed should be "Content-Encoding" here instead of "Content-Type". @iscai-msft - can you give me a sanity check? :) |
@@ -98,7 +98,7 @@ namespace System.Net.Sockets
// 3) failed.
internal override object? PostCompletion(int numBytes)
{
- if (ErrorCode == 0 && NetEventSource.IsEnabled)
+ if (ErrorCode == 0 && NetEventSource.Log.IsEnabled())
{
LogBuffer(numBy... | [OverlappedAsyncResult->[SetUnmanagedStructures->[SetUnmanagedStructures],PostCompletion->[PostCompletion]]] | Override PostCompletion in order to log the error if it is not possible. | Similar question for all of these `&& NetEventSource` cases. |
@@ -3923,8 +3923,6 @@ def is_untyped_decorator(typ: Optional[Type]) -> bool:
def is_static(func: Union[FuncBase, Decorator]) -> bool:
if isinstance(func, Decorator):
return is_static(func.func)
- elif isinstance(func, OverloadedFuncDef):
- return any(is_static(item) for item in func.items)
- ... | [TypeChecker->[analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[check_assignment,accept],check_return_stmt->[get_generator_return_type,accept,get_... | Check if a function or a function is static. | Could you please reformat this as `assert False, "message"`? |
@@ -26,7 +26,11 @@ namespace System.Net.Http
IsSupportedSecureScheme(scheme);
internal static bool IsSupportedNonSecureScheme(string scheme) =>
- string.Equals(scheme, "http", StringComparison.OrdinalIgnoreCase) || IsNonSecureWebSocketScheme(scheme);
+ string.Equals(scheme,... | [HttpUtilities->[IsSecureWebSocketScheme->[OrdinalIgnoreCase,Equals],IsSupportedSecureScheme->[OrdinalIgnoreCase,IsSecureWebSocketScheme,Equals],Task->[Default,None,ContinueWith,ExecuteSynchronously],IsHttpUri->[IsSupportedScheme,Scheme,Assert],IsNonSecureWebSocketScheme->[OrdinalIgnoreCase,Equals],IsSupportedNonSecure... | Returns true if the given scheme is supported by this class. | Another case where I'd prefer if we moved this to two partial files, with each doing the desired checks, rather than proliferating use of TARGETS_BROWSER everywhere. We've avoided that for platforms in general. |
@@ -43,6 +43,7 @@ import org.rstudio.studio.client.server.ServerError;
import org.rstudio.studio.client.server.ServerRequestCallback;
import org.rstudio.studio.client.shiny.model.ShinyApplicationParams;
import org.rstudio.studio.client.workbench.commands.Commands;
+import org.rstudio.studio.client.workbench.events.A... | [ViewerPane->[previewRmd->[navigate],getName->[getName],previewPlumber->[navigate],refresh->[getUrl],navigate->[navigate],getUrl->[getUrl],onResize->[onResize],previewShiny->[navigate],createMainToolbar->[getTitle->[getTitle]],getTitle->[getTitle],addLoadHandler->[addLoadHandler]]] | Package private for testability. The ViewerPane class is used to show a single . | nit: update copyright year in header |
@@ -41,6 +41,12 @@ namespace Content.Server.GameObjects.Components.Access
return true;
}
}
+
+ if (_necessaryTags.Count == 0) // If the list doesn't exist, or exists and only has [""], then deny access. Otherwise door would permitt access to all.
+ ... | [AccessReader->[IsAllowed->[IsAllowed],ExposeData->[ExposeData]]] | Checks if the given access tags are allowed. | But if no access level is necessary everyone should be allowed? |
@@ -85,7 +85,7 @@ public abstract class DistcpConverter extends Converter<String, String, FileAwar
modifyExtensionAtDestination(fileAwareInputStream.getFile());
try {
InputStream newInputStream = inputStreamTransformation().apply(fileAwareInputStream.getInputStream());
- return new SingleRecordIte... | [DistcpConverter->[init->[init],modifyExtensionAtDestination->[getDestination,toArray,size,setDestination,removeExtension],convertRecord->[getInputStream,apply,FileAwareInputStream,modifyExtensionAtDestination,getFile,DataConversionException]]] | Convert a record from a FileAwareInputStream to a SingleRecordIterable. | Would transformations in DistcpConverters like the Decrypt/UnGzip converter be able to correctly transform streams with block level work units, or would these processes be dependent on file level access? |
@@ -945,9 +945,10 @@ EOT;
}
echo \WP_CLI\Utils\mustache_render( 'versions.mustache', array(
- 'wp-version' => $details['wp_version'],
- 'db-version' => $details['wp_db_version'],
- 'mce-version' => ( $human_readable_tiny_mce ?
+ 'wp-version' => $details[ 'wp_version' ],
+ 'db-version' =... | [Core_Command->[install->[_install],_extract_tarball->[extractTo,getFileName],_multisite_convert->[get_error_message,tables,get_error_code],download->[cleanup_extra_files,getMessage,get_download_url,get_download_offer,has,import],_copy_overwrite_files->[isDir,getSubPathName],update->[upgrade,cleanup_extra_files,get_dow... | Displays the version of the WordPress installation. | You could spare a `!` by reversing the two. |
@@ -86,6 +86,7 @@ public class DefaultBlockingPool<T> implements BlockingPool<T>
return wrapObject(timeoutMs > 0 ? pollObject(timeoutMs) : pollObject());
}
catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
throw new RuntimeException(e);
}
}
| [DefaultBlockingPool->[wrapObject->[offer],pollObject->[toNanos,lockInterruptibly,pop,lock,unlock,isEmpty,awaitNanos],pollObjects->[toNanos,awaitNanos,size,lockInterruptibly,pop,unlock,emptyList,add],takeObjects->[size,lockInterruptibly,pop,unlock,await,add],getPoolSize->[size],takeObject->[lockInterruptibly,pop,unlock... | Retrieves an object from the queue or blocks until it is available. | How about just propagate InterruptedException to callers? It makes more sense to me for all methods of BlockingPool. |
@@ -122,11 +122,14 @@ class BaseTestEditBasic(BaseTestEdit):
assert unicode(addon.name) == data['name']
assert addon.name.id == old_name.id
- assert unicode(addon.slug) == data['slug']
assert unicode(addon.summary) == data['summary']
if self.listed:
assert [un... | [L10nTestsMixin->[test_l10n_not_us->[get_l10n_urls],test_l10n_not_us_id_url->[get_l10n_urls],test_l10n->[get_l10n_urls]],TestEditTechnical->[formset->[dep_formset],setUp->[get_url],test_dependencies_limit->[dep_formset],test_dependencies_add_self->[check_bad_dep,dep_formset],test_dependencies_limit_with_deleted_form->[... | Test if a node has the same name and description as the node. | ??? `data['slug']` should be `'test_slug'` shouldn't it? Why would it be 20 characters long? |
@@ -195,6 +195,8 @@ def refund(
manager: "PluginsManager",
channel_slug: str,
amount: Decimal = None,
+ order_lines_to_refund: Optional[List[OrderLineData]] = None,
+ fulfillment_lines_to_refund: Optional[List[FulfillmentLineData]] = None,
) -> Transaction:
if amount is None:
amount ... | [list_payment_sources->[list_payment_sources],payment_refund_or_void->[void,refund]] | Refunds a given payment. | Instead of multiple input here, can't we create one input with a type like `LineToRefund` or something which will be built based on data from refunded `OrderLine`s and `FulfillmentLine`s? This should be more intuitive in case of using it in different way in the future. |
@@ -70,6 +70,7 @@ import {
OverflowMenuVideoQualityItem,
VideoQualityDialog
} from '../../../video-quality';
+import { toggleSharedVideo } from '../../../youtube-player/actions';
import {
setFullScreen,
setOverflowMenuVisible,
| [No CFG could be retrieved] | The base class for all components. The chat feature is currently displayed. | Please move the action to shared-video. Let's get rid off youtube-player altogether |
@@ -1089,15 +1089,16 @@ public abstract class SslContext {
* Build a {@link TrustManagerFactory} from a certificate chain file.
* @param certChainFile The certificate file to build from.
* @param trustManagerFactory The existing {@link TrustManagerFactory} that will be used if not {@code null}.
+ ... | [SslContext->[toPrivateKeyInternal->[toPrivateKey],newClientContextInternal->[defaultClientProvider,verifyNullSslContextProvider],newHandler->[newEngine,newHandler],newClientContext->[newClientContext],getPrivateKeyFromByteBuffer->[generateKeySpec],toX509CertificatesInternal->[toX509Certificates],newServerContext->[new... | Build a trust manager from a file. | we will need to keep the old method signature as well as this method is protected and so changing its signature is a API breaking change |
@@ -314,7 +314,8 @@ func (s *ScanKeys) unlockByID(m libkb.MetaContext, id uint64) openpgp.EntityList
Reason: unlockReason,
SecretUI: m.UIs().SecretUI,
}
- unlocked, err := skb.PromptAndUnlock(m, parg, nil, s.me)
+ secretStore := libkb.NewSecretStore(m.G(), s.me.GetNormalizedName())
+ unlocked, err := sk... | [KeysByIdUsage->[KeysByIdUsage],unlockByID->[KeysById],DecryptionKeys->[DecryptionKeys,Count],KeysById->[KeysById],publicByID->[KeysById]] | unlockByID returns a list of unlocked entities that match the given id. | why this instead of `m.G().SecretStore()`? |
@@ -6,11 +6,14 @@
import os.path as op
import numpy as np
+import h5py # Added to read newer Matlab files (7.3 and later)
+import sys
+from collections import Mapping, namedtuple
from ..utils import (_read_segments_file, _find_channels,
_synthesize_stim_channel)
from ..constants import FI... | [RawEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],EpochsEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],_get_info->[_to_loc]] | Check if a given sequence number is valid. Get the measurement info. | you cannot add a strong dependency like this. You need to use a nested import. also you'll need to update the continuous integration tools (travis, appveyor) |
@@ -50,4 +50,17 @@ public class GridViewerFrame extends RStudioFrame
private final native void setOptionNative(WindowEx frameContentWindow, String option, String value) /*-{
frameContentWindow.setOption(option, value);
}-*/;
+
+ private final native void setColumnDefinitionsUIVisibleNative(WindowEx ... | [GridViewerFrame->[onAttach->[onAttach],setOption->[getContentWindow,setOptionNative],setData->[getContentWindow,setDataNative]]] | set option native. | We generally try to keep code to 80 columns wide -- unfortunately there's no way to make Eclipse do this automatically, but you can make it show a print margin at 80 columns so you know where to hard-wrap. |
@@ -454,9 +454,11 @@ namespace Dynamo.ViewModels
Model.ConnectorAdded += Connectors_ConnectorAdded;
Model.ConnectorDeleted += Connectors_ConnectorDeleted;
Model.PropertyChanged += ModelPropertyChanged;
+
+ this.refreshViewHandler = (sender, e) => { RefreshVi... | [WorkspaceViewModel->[DoGraphAutoLayout->[DoGraphAutoLayout],ZoomOutInternal->[OnRequestZoomToViewportCenter],ModelPropertyChanged->[OnZoomChanged],Loaded->[OnZoomChanged],FitViewInternal->[GetSelectionMaxY,OnRequestZoomToFitView,GetSelectionMaxX,GetSelectionMinX,GetSelectionMinY],Paste->[Paste],AlignSelected->[GetSele... | Provides a ViewModel that is used by InCanvasSearch. Get the name of a node in the list of nodes. | Maybe this should be a method instead of a lambda expression for clarity/continuity? |
@@ -16,7 +16,7 @@ namespace System.Net.Security.Tests
internal static class TestConfiguration
{
public const int PassingTestTimeoutMilliseconds = 4 * 60 * 1000;
- public const int FailingTestTimeoutMiliseconds = 250;
+ public const int FailingTestTimeoutMiliseconds = 500;
pub... | [TestConfiguration->[Task->[WhenAllOrAnyFailed],CompareTo,Value,OSX,Linux,IsOSPlatform,BeginErrorReadLine,Start,ErrorDataReceived,Windows,Length]] | Creates a new object. On Windows null ciphers are supported. | In the description you stated: _"I noticed that the test failed with timeout after ~1s."_ Should we instead increase the timeout for that specific test and move to outerloop instead? |
@@ -113,13 +113,18 @@ static int self_test_init(char *dest_name, crt_context_t *crt_ctx,
return ret;
}
+ printf("before attempting attach\n");
+ D_ERROR("D_ERROR: before attempting attach\n");
while (attach_retries-- > 0) {
ret = crt_group_attach(dest_name, srv_grp);
if (ret == 0)
break;
sleep(1);... | [main->[parse_message_sizes_string,parse_endpoint_string]] | This function is used to initialize a CRT object and create a CRT object. attach a group to the system This function is called by the core to set the rank of the list. | (style) trailing whitespace |
@@ -37,7 +37,8 @@ public class DataflowSystemMetrics {
WINDMILl_STATE_BYTES_WRITTEN("WindmillStateBytesWritten"),
JAVA_HARNESS_USED_MEMORY("dataflow_java_harness_used_memory"),
JAVA_HARNESS_MAX_MEMORY("dataflow_java_harness_max_memory"),
- JAVA_HARNESS_RESTARTS("dataflow_java_harness_restarts");
+ ... | [DataflowSystemMetrics->[counterName->[checkNotNull,named,systemName],named]] | Creates a new SystemMetrics object. Total amount of time spent processing a stage aggregated across all the concurrent tasks for a given node. | It seems better to treat the global throttling signal separate from the per-stage ones, on the service-side, so I suggest a different name, perhaps: dataflow_streaming_engine_throttled_msecs? |
@@ -200,6 +200,15 @@ class DeferredSeries(frame_base.DeferredFrame):
view = frame_base.wont_implement_method('memory sharing semantics')
+ @property
+ def str(self):
+ expr = expressions.ComputedExpression(
+ 'str',
+ lambda df: df.str, [self._expr],
+ requires_partition_by=partitioning... | [_unliftable_agg->[wrapper->[groupby]],DeferredDataFrame->[sort_values->[sort_values],merge->[set_index,merge],mode->[mode],groupby->[groupby],nlargest->[nlargest],dropna->[dropna],__setitem__->[__setitem__],nunique->[nunique],fillna->[fillna],join->[_cols_as_temporary_index,join,fill_placeholders,reindex,revert],unsta... | Create a DataFrame that contains unique values in the DataFrame. DeferredDataFrame - like class for deferred - series. | Doesn't it preserve all partitionings? |
@@ -626,7 +626,7 @@ namespace System.Net.Security
//
// Acquire Server Side Certificate information and set it on the class.
//
- private bool AcquireServerCredentials(ref byte[] thumbPrint, byte[] clientHello)
+ private bool AcquireServerCredentials(ref byte[] thumbPrint, byte[... | [SecureChannel->[AcquireClientCredentials->[GetRequestCertificateAuthorities],GetRequestCertificateAuthorities->[GetRequestCertificateAuthorities],SecurityStatusPal->[AcquireClientCredentials,AcquireServerCredentials],ProtocolToken->[ToString->[],SetRefreshCredentialNeeded]],ProtocolToken->[ToString->[ToString]]] | Acquire server credentials. Returns a safe ref possibly cloned from the user passed cert. | Can this be changed to just take spans instead, or does it need to take the array/offset/count? |
@@ -448,7 +448,7 @@ type Contexitifier interface {
}
func (g *GlobalContext) GetConfiguredAccounts() ([]keybase1.ConfiguredAccount, error) {
- return GetConfiguredAccounts(g)
+ return GetConfiguredAccounts(g, g.SecretStoreAll)
}
func (g *GlobalContext) GetAllUserNames() (NormalizedUsername, []NormalizedUsername... | [ResetLoginState->[createLoginStateLocked],GetStoredSecretServiceName->[GetStoredSecretServiceName],GetStoredSecretAccessGroup->[GetStoredSecretAccessGroup],GetCacheDir->[GetCacheDir],ConfigureUsage->[ConfigureKeyring,ConfigureAPI,ConfigureCaches,UseKeyring,ConfigureMerkleClient,ConfigureTimers,ConfigureExportedStreams... | GetConfiguredAccounts returns all configured accounts and all usernames. | Do we need this? Can `GetConfiguredAccounts()` be on `SecretStore`? So then it would be `e.G().SecretStore.GetConfiguredAccounts()`. |
@@ -71,6 +71,10 @@ public class ProPurchaseOption {
final Resource pus = data.getResourceList().getResource(Constants.PUS);
cost = productionRule.getCosts().getInt(pus);
costs = productionRule.getCosts();
+ isConstruction = unitAttachment.getIsConstruction();
+ constructionType = unitAttachment.get... | [ProPurchaseOption->[calculateEfficiency->[calculateEfficiency]]] | The number of supported cards and the number of supported cards. Compute the cost per hit point. | These 4 data members seem very related. Have you considered creating a type around it? |
@@ -553,6 +553,16 @@ func (i *Ingester) v2Query(ctx context.Context, req *client.QueryRequest) (*clie
return nil, ss.Err()
}
+ backfillSSs, err := db.backfillSelect(ctx, int64(from), int64(through), matchers)
+ if err != nil {
+ return nil, err
+ }
+ if len(backfillSSs) > 0 {
+ // TODO(codesome): If any TSDB i... | [shipBlocks->[getTSDB],runConcurrentUserWorkers->[getTSDBUsers],v2Push->[setLastUpdate],getOrCreateTSDB->[getTSDB],compactBlocks->[isIdle,getTSDB],v2LifecyclerFlush->[shipBlocks,compactBlocks],createTSDB->[setLastUpdate],openExistingTSDB->[createTSDB]] | v2Query is a v2 query. | When doing a merging of series sets, they must both be sorted. `ss` is not sorted (due to `q.Select(false,...)`. |
@@ -5032,8 +5032,12 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
forVpc = false;
}
- final NetworkOffering offering = createNetworkOffering(name, displayText, trafficType, tags, specifyVlan, availability, networkRate, serviceProviderMap, false, guest... | [ConfigurationManagerImpl->[updateConfiguration->[start,updateConfiguration],commitVlan->[doInTransaction->[createVlanAndPublicIpRange]],deletePod->[checkIfPodIsDeletable],checkPodCidrSubnets->[getCidrAddress,getCidrSize],createPod->[createPod,checkPodAttributes],editPod->[editPod,podHasAllocatedPrivateIPs,checkPodAttr... | create a network offering Determines if a network is supported in the current release. find the best match for the service check if service is supported by the network offering check if the service is available in the network region Network offering methods Creates a NetworkOffering object with the specified details. | Instead of updating the offeringVO again, pass the value of "enable" to createNetworkOffering() method and use offeringFinal.setState() method to set it while creating the initial VO entry itself. |
@@ -64,10 +64,14 @@ type typeDetails struct {
// Title converts the input string to a title case
// where only the initial letter is upper-cased.
+// It also removes $-prefix if any.
func Title(s string) string {
if s == "" {
return ""
}
+ if s[0] == '$' {
+ return Title(s[1:])
+ }
runes := []rune(s)
r... | [genResource->[getConstValue,plainType,outputType,getDefaultValue,inputType],genType->[genInputTypes,genOutputTypes,details,genPlainType,tokenToType],plainType->[tokenToType,plainType],genFunction->[genPlainType],outputType->[tokenToType,outputType],getTypeImports->[getTypeImports,add],genConfig->[genHeader,getDefaultV... | type returns a stringSet that contains all the non - empty non - empty non - type returns the name of the type that is passed to the typeDetails function. | It would be good to add a note that this doesn't attempt to depuplicate the result (e.g. this will generate bad code for a type with `$ref` and `ref`). |
@@ -191,9 +191,9 @@ func (r *Registry) CheckConfig(olds, news resource.PropertyMap) (resource.Proper
}
// DiffConfig checks what impacts a hypothetical change to this provider's configuration will have on the provider.
-func (r *Registry) DiffConfig(olds, news resource.PropertyMap) (plugin.DiffResult, error) {
+fun... | [Check->[label,CheckConfig,setProvider,Configure],Create->[label,setProvider,Configure,GetProvider],Delete->[deleteProvider],Update->[label,setProvider,Configure,GetProvider],Diff->[label,setProvider,DiffConfig,GetProvider]] | DiffConfig is a plugin. PluginFunc that implements plugin. Plugin. DiffConfig. | this is an actual error (as per the contract.Fail above). |
@@ -2210,7 +2210,7 @@ namespace Microsoft.WebAssembly.Diagnostics
}
return array;
}
- public async Task<bool> EnableExceptions(SessionId sessionId, string state, CancellationToken token)
+ public async Task<bool> EnableExceptions(SessionId sessionId, PauseOnExceptionsKin... | [MonoBinaryReader->[ReadDouble->[PutBytesBE],ReadInt32->[PutBytesBE],ReadSByte->[PutBytesBE],ReadLong->[PutBytesBE],ReadUShort->[PutBytesBE],ReadUInt32->[PutBytesBE],ReadUByte->[PutBytesBE]],MonoBinaryWriter->[WriteJsonValue->[WriteObj,Write],WriteObj->[Write],Write->[Write],WriteConst->[Write]],MonoSDBHelper->[GetClas... | Get array values. | nit: might be useful to add a check for `Unset` here anyway, to guard against accidentally calling this with `Unset`, and log a debug message? |
@@ -6,6 +6,8 @@ const ELECTRON_DIR = path.resolve(__dirname, '..', '..');
const SRC_DIR = path.resolve(ELECTRON_DIR, '..');
const RELEASE_BRANCH_PATTERN = /(\d)+-(?:(?:[0-9]+-x$)|(?:x+-y$))/;
+const MAIN_BRANCH_PATTERN = /^(main|master)$/;
+const ORIGIN_MAIN_BRANCH_PATTERN = /^origin\/(main|master)$/;
require('c... | [No CFG could be retrieved] | Get the path to the output directory for the electron process. Get the build type from the environment. | For a list of two things, I'd prefer if this was literally an array and we did a `.includes`. Can we also go about this strategically and map any change we make to support with with a `// TODO(main-migration): Remove once main branch is renamed` so that we can really easily _undo_ these once we're ready |
@@ -33,7 +33,7 @@ namespace Microsoft.DotNet.CoreSetup.Test.HostActivation.NativeHosting
CommandResult result = Command.Create(sharedState.ComSxsPath, args)
.EnableTracingAndCaptureOutputs()
- .DotNetRoot(sharedState.ComLibraryFixture.BuiltDotnet.BinPath)
+ ... | [ComhostSideBySide->[ActivateClass->[Windows,Execute,ClsidString,HaveStdOutContaining],LocateEmbeddedTlb->[Windows,TypeLibId,Execute,HaveStdOutContaining],SharedTestState->[CreateManifestFromClsidmap,AssemblyName,GetFileName,GetExeFileNameForCurrentPlatform,ToString,AppDll,Copy,Artifacts,RuntimeConfigJson,GetDirectoryN... | COM activation is only supported on Windows. | This change should not be necessary - it should work without setting the architecture specific one. Unless this is intentionally testing that case as a side effect of another test. |
@@ -344,6 +344,10 @@ class NotificationsManager extends BaseObject
break;
case ACTIVITY_FRIEND:
+ if (!isset($it['object'])) {
+ logger('Incomplete data: ' . json_encode($it) . ' - ' . System::callstack(20), LOGGER_DEBUG);
+ }
+
$xmlhead = "<" . "?xml version='1.0' encoding='UTF-8'... | [NotificationsManager->[networkNotifs->[formatNotifs],getByID->[_set_extra],homeNotifs->[formatNotifs],getAll->[_set_extra],personalNotifs->[formatNotifs],systemNotifs->[formatNotifs]]] | Format the notifs Transform the notification in an array This function create a list of all the tags that are not part of the list. This function return a list of all the events that are not attending or not. | Could it be related to the fact that the base item table doesn't use `object` field anymore? |
@@ -548,6 +548,12 @@ namespace System.Net.Http
catch (Exception e)
{
response?.Dispose();
+
+ if (e is OperationCanceledException operationException && TimeoutFired(callerToken, timeoutTime))
+ {
+ throw CreateTimeoutException(o... | [HttpClient->[GetByteArrayAsync->[GetByteArrayAsync],GetAsync->[GetAsync],Dispose->[Dispose],GetStringAsync->[GetStringAsync],PatchAsync->[PatchAsync],SendAsync->[SendAsync],PostAsync->[PostAsync],GetStreamAsync->[GetStreamAsync],DeleteAsync->[DeleteAsync],PutAsync->[PutAsync]]] | Finish the send asynchronously with buffered content. | HandleFinishSendAsyncError was doing some logging. Do we need to do any in this path, too? |
@@ -48,6 +48,11 @@ class PythonRepl(ReplTaskMixin, PythonExecutionTaskBase):
entry_point = 'code:interact'
pex_info = PexInfo.default()
pex_info.entry_point = entry_point
+ python_setup = PythonSetup.global_instance()
+ if python_setup.get_options().is_flagged('interpreter_constraints'):
+ s... | [PythonRepl->[launch_repl->[signal_handler_as,pop,run],select_targets->[isinstance],setup_repl_session->[get_options,create_pex,default],register_options->[register,super],extra_requirements->[get_options]]] | Setup a repl session for the given targets. | Consider moving the call to `is_flagged` into a helper on `PythonSetup`... something like: `interpreter_contraints_if_flagged`, which returns None if not flagged? |
@@ -398,7 +398,8 @@ class Command(object):
build=args.build, profile_names=args.profile,
update=args.update, generators=args.generator,
no_imports=args.no_imports,
- ... | [Command->[export->[export],info->[info],install->[install],editable->[info],source->[source],remove->[remove,info],new->[new],imports->[imports],upload->[upload],copy->[copy],download->[download],run->[_commands,_warn_python2,_show_help],export_pkg->[export_pkg],test->[test],inspect->[inspect],package->[package],_show... | Installs the specified requirements specified in a recipe or a conanfile. py or con Installs a single object from the specified path or reference. | There is something funny with the `conan install <ref>`, the install folder argument is apparently useless, even in develop, I cannot manage to output any file not either the lockfile. What should we do? |
@@ -49,14 +49,14 @@ public class Chat {
private final ChatIgnoreList ignoreList = new ChatIgnoreList();
private final HashMap<INode, LinkedHashSet<String>> notesMap = new HashMap<>();
private static final String TAG_MODERATOR = "[Mod]";
- private final CHAT_SOUND_PROFILE chatSoundProfile;
+ private final Cha... | [Chat->[speakerTagUpdated->[addToNotesMap,updateConnections],assertMessageFromServer->[getServerNode],assignNodeTags->[addToNotesMap],slapOccured->[isIgnored,getLocalNode],addChatListener->[updateConnections],getServerNode->[getServerNode],speakerRemoved->[speakerRemoved,assertMessageFromServer,updateConnections],meMes... | private static final int MAX_NUMBER_OF_NODES = 8 ; run all queued messages. | Just a suggestion... It seems unnecessary to prefix the enum type with `Chat` since it is embedded within the `Chat` class. Would `Chat.SoundProfile` read better than `Chat.ChatSoundProfile`? |
@@ -477,4 +477,14 @@ public class TableSchemaResolver {
}
return null;
}
+
+ public boolean hasOperationField() {
+ try {
+ Schema tableAvroSchema = getTableAvroSchemaFromDataFile();
+ return tableAvroSchema.getField(HoodieRecord.OPERATION_METADATA_FIELD) != null;
+ } catch (Exception e) {... | [TableSchemaResolver->[getLatestSchema->[getTableAvroSchemaWithoutMetadataFields,isSchemaCompatible],getTableAvroSchema->[getTableAvroSchema,getTableAvroSchemaFromDataFile],readSchemaFromLastCompaction->[readSchemaFromBaseFile],readSchemaFromLogFile->[readSchemaFromLogFile],getTableParquetSchema->[getTableParquetSchema... | Reads the schema from the log file. | since this is called every time to retrieve the info, any performance concern on reading the timeline and the data files? can you help make a rough estimation on this aspect please? e.g. what kinds of scenarios may invoke this and how often it would happen |
@@ -0,0 +1,12 @@
+package org.jboss.weld.environment.se.example.numberguess;
+
+import org.jboss.weld.environment.se.Weld;
+
+public class Main {
+
+ public static void main(String[] args) {
+ Weld weld = new Weld().beanClasses(Game.class, Generator.class, MessageGenerator.class, NumberGuessFrame.class).disab... | [No CFG could be retrieved] | No Summary Found. | Why not `new Weld().beanClasses(Game.class, Generator.class, MessageGenerator.class, NumberGuessFrame.class).disableDiscovery().initialize();`? |
@@ -119,7 +119,8 @@ public class GlobalTrafficShapingHandler extends AbstractTrafficShapingHandler {
}
/**
- * Create a new instance
+ * Create a new instance using default Check Interval value of 1000 ms and
+ * default max time as delay allowed value of 15000 ms
*
* @param executor... | [GlobalTrafficShapingHandler->[handlerRemoved->[handlerRemoved,release],submitWrite->[ToSend],handlerAdded->[handlerAdded],createGlobalTrafficCounter]] | This method is used to create a TrafficCounter object for the TrafficCounter object. This is the main entry point for the GlobalTrafficShapingHandler class. It creates the. | missing '.' at end of line. |
@@ -439,12 +439,12 @@ Allocation* Heap<TAlloc, TPreReservedAlloc>::AllocLargeObject(size_t bytes, usho
size_t resultBytes = VirtualQueryEx(this->processHandle, address, &memBasicInfo, sizeof(memBasicInfo));
if (resultBytes == 0)
{
- if (this->processHandle != GetCurrentProcess())
- {
- ... | [No CFG could be retrieved] | Fill the memory allocation for a given segment. region CodePageAllocation Implementation. | >if (this->processHandle != GetCurrentProcess()) [](start = 8, length = 47) any idea, why this check was there in the first place? #Resolved |
@@ -221,6 +221,9 @@ function createBaseCustomElementClass(win) {
/** @private {!./size-list.SizeList|null|undefined} */
this.heightsList_ = undefined;
+ /** @public {boolean} */
+ this.has3pOverflow = false;
+
/**
* This element can be assigned by the {@link applyStaticLayout} t... | [No CFG could be retrieved] | Replies the properties of a specific child element. Private methods for the class. | How about overriding `getOverflowElement()` in the A4A custom element... (continued below) |
@@ -713,6 +713,14 @@ describe('jqLite', function() {
expect(jqLite(b).hasClass('abc')).toEqual(true);
});
+ it('should allow adding of class in IE9', function() {
+ if (msie !== 9) return; // IE9 doesn't support node.setAttribute
+ var selector = jqLite([a, b]);
+ expect(sele... | [No CFG could be retrieved] | Tests that the data property of a node is set to a specified value. expects that the element has data property. | I thought the issue was reported as only affecting nodes that had both `ng:class` and `ng:click` directives in that xml style, or maybe some combination of similar circumstances. Does this patch fix that? If so, that's probably what should be tested. |
@@ -1176,6 +1176,8 @@ define([
processPacketData(Number, model, 'scale', modelData.scale, interval, sourceUri, entityCollection);
processPacketData(Number, model, 'minimumPixelSize', modelData.minimumPixelSize, interval, sourceUri, entityCollection);
processPacketData(Boolean, model, 'increme... | [No CFG could be retrieved] | Process the model data for the given entity. missing nanoseconds - can be used to determine if a time interval is not in the combined. | Did you update the CZML reference doc and czml-writer project? If not, put it on the roadmap, and let's do it soon. |
@@ -807,16 +807,11 @@ public class BytecodeEGWalker {
}
private boolean isUncheckedExceptionCatchBlock(BytecodeCFG.Block b) {
- String exceptionTypeName = b.getExceptionType();
- if (exceptionTypeName == null) {
- return false;
- }
- Type exceptionType = semanticModel.getClassType(exceptionType... | [No CFG could be retrieved] | Enqueue uncaught exceptions. - - - - - - - - - - - - - - - - - -. | I would try to spare two consecutive calls to `b.getExceptionType(semanticModel)`. Dedicated small method? |
@@ -248,6 +248,17 @@ class ProductVariantChannelListing(CountableDjangoObjectType):
def resolve_margin(root: models.ProductVariantChannelListing, *_args):
return get_margin_for_variant_channel_listing(root)
+ @staticmethod
+ def resolve_preorder_threshold(
+ root: models.ProductVariantChann... | [ProductChannelListing->[resolve_margin->[calculate_margin_with_variants->[calculate_margin_with_channel->[calculate_margin_with_channel_listings->[Margin]]]]]] | Resolve margin for a ProductVariantChannelListing. | Is there a way to query it from a different resolver, where this annotation is not available? If so, we should make sure that this resolver will returns None and doesn't fail trying to access a field that is not present. |
@@ -331,6 +331,7 @@ namespace Content.Server.GameObjects.Components.Buckle
{
Owner.Transform.AttachParentToContainerOrGrid();
Owner.Transform.WorldRotation = oldBuckledTo.Owner.Transform.WorldRotation;
+ Owner.Transform.WorldPosition += oldBuckledTo.Unbuckle... | [BuckleComponent->[TryBuckle->[CanBuckle,ReAttach,UpdateBuckleStatus],TryUnbuckle->[UpdateBuckleStatus],OnRemove->[OnRemove,TryUnbuckle,UpdateBuckleStatus],Update->[TryUnbuckle],ToggleBuckle->[TryBuckle,TryUnbuckle],BuckleVerb->[Activate->[TryUnbuckle]],Startup->[UpdateBuckleStatus,Startup]]] | Try to unbuckle the given user. | Could check if UnbuckleOffset is Vector2.Zero and early out given WorldPosition is also expensive to calculate. |
@@ -99,13 +99,13 @@ class Graphviz(AutotoolsPackage):
# These language bindings have not yet been tested. They
# likely need additional dependencies to get working.
untested_bindings = (
- '+swig', '+sharp', '+go', '+guile', '+io',
+ '+sharp', '+go', '+guile', '+io',
... | [Graphviz->[configure_args->[append,copyfile,SpackException],variant,depends_on,version]] | Configure the options for the command line. | since you override `need_swig`, is not it better to move this loop outside and use `conflicts` statement to say that each `+var` among `tested_bindings` conflicts with `~swig`? |
@@ -316,7 +316,8 @@ namespace System.Net.Http.HPack
// Create traverse path for all 0..256 octets, 256 is EOS, see: http://httpwg.org/specs/rfc7541.html#rfc.section.5.2
for (int octet = 0; octet <= 256; octet++)
{
- (uint code, int bitLength) = Encode(octet);
+ ... | [Huffman->[GenerateDecodingLookupTree->[Encode],Decode->[Resize,net_http_hpack_huffman_decode_failed,Assert,MaxValue,Length],GenerateDecodingLookupTree]] | GenerateDecodingLookupTree - Generate a decoding lookup tree if there is no error. This function is used to determine if a Huffman - encoded string literal contains a reserved word This method checks if there are any bits left in huffman code which are not used in. | Can you store both the array and the span into locals outside the loop, and then use those locals here? |
@@ -103,8 +103,6 @@ public class BeamFnMapTaskExecutorTest {
@Test(timeout = ReadOperation.DEFAULT_PROGRESS_UPDATE_PERIOD_MS * 10)
public void testTentativeUserMetrics() throws Exception {
- Supplier<String> idGenerator = makeIdGeneratorStartingFrom(777L);
-
final String stepName = "fakeStepNameWithUser... | [BeamFnMapTaskExecutorTest->[makeIdGeneratorStartingFrom->[AtomicLong,toString,getAndIncrement],testFinalUserMetrics->[handle->[getRequestCase,build,countDown,await,supplyAsync,completedFuture],size,InstructionRequestHandler,CountDownLatch,countDown,of,runAsync,CounterUpdateIntegerValueMatcher,await,RegisterAndProcessB... | This test method is used to test if there are tentative user metrics. This method creates a new register and process bundle operation. | Ditto in this test because we would expect that the starting id value and how the ids are generated matter. |
@@ -30,7 +30,7 @@ import org.apache.beam.sdk.transforms.GroupByKey;
import org.joda.time.Instant;
/**
- * {@link Trigger Triggers} control when the elements for a specific key and window are output. As
+ * Triggers control when the elements for a specific key and window are output. As
* elements arrive, they are ... | [Trigger->[isCompatible->[isCompatible],OnceTrigger->[getContinuationTrigger->[getContinuationTrigger]],getContinuationTrigger->[getContinuationTrigger],equals->[equals]]] | Imports a single key - value window. This method is used to find the first element in a pane. | You just don't like the self-link? My default is to link the heck out of things - you never know when someone might want to click or copy link destination, etc. |
@@ -16,7 +16,7 @@ from ..io import _BaseRaw
from ..io.pick import _pick_data_channels
from ..utils import logger
from ..externals.six import iteritems, itervalues
-
+from ..stats.regression import _prepare_rerp_data, _prepare_rerp_preds, _solver
def _construct_signal_from_epochs(epochs, events, sfreq, tmin):
... | [_least_square_evoked->[_construct_signal_from_epochs],_XdawnTransformer->[fit->[_fit_xdawn]],_fit_xdawn->[_least_square_evoked],Xdawn->[fit->[_fit_xdawn]]] | Reconstruct pseudo continuous signal from epochs. | XDawn on master uses a pinv solver, this is a cholesky solver. |
@@ -28,12 +28,14 @@ class Indexable_Post_Type_Presentation extends Indexable_Presentation {
/**
* Indexable_Post_Type_Presentation constructor.
*
- * @param Post_Type_Helper $post_type The post type helper.
- * @param User_Helper $user The user helper.
+ * @param Post_Type_Helper $post_type ... | [Indexable_Post_Type_Presentation->[generate_twitter_creator->[get],generate_og_description->[strip_shortcodes,get_the_excerpt],generate_robots->[get_base_values,after_generate,is_indexable],generate_title->[get],generate_og_article_author->[get_the_author_meta],generate_meta_description->[get],generate_twitter_descrip... | Constructor for the object. | In the other files in this PR you use `$date_helper` rather than `$date`. |
@@ -31,7 +31,6 @@ define([
* @param {JulianDate} [options.epoch=Iso8601.MINIMUM_VALUE] The simulation time that marks the start of the video.
* @param {Number} [options.tolerance=1.0] The maximum amount of time, in seconds, that the clock and video can diverge.
*
- * @demo {@link http://cesiumjs.o... | [No CFG could be retrieved] | Constructs a new video synchronizer object. Magic number of the last non - zero value. | This link can stay |
@@ -243,12 +243,10 @@ public class GroupByQueryHelper
for (AggregatorFactory aggregatorFactory : query.getAggregatorSpecs()) {
final String typeName = aggregatorFactory.getTypeName();
- final ValueType valueType;
- if (typeName != null) {
- valueType = Enums.getIfPresent(ValueType.class, ... | [GroupByQueryHelper->[makeIncrementalIndex->[createIndexAccumulatorPair,accumulate]]] | Returns a map of row signature for the given query. | Suggested to make `GuavaUtils.getEnumIfPresent()` to not accept `null` value, and here, move the check out of `GuavaUtils.getEnumIfPresent()` call. |
@@ -120,11 +120,11 @@ final class SearchFactoryHandler {
return searchFactory.getIndexBindings().get(c) != null;
}
- private void handleClusterRegistryRegistration(final Class<?> clazz) {
+ private CompletionStage<Void> handleClusterRegistryRegistration(final Class<?> clazz) {
if (hasIndex(clazz... | [SearchFactoryHandler->[CacheListener->[modified->[handleClusterRegistryRegistration],created->[handleClusterRegistryRegistration]],enableClasses->[handleOnDemandRegistration],handleClusterRegistryRegistration->[updateSearchFactory,hasIndex]]] | Checks if a class has an index binding. | return a completion stage that contains null value instead of null ? |
@@ -1831,15 +1831,12 @@ void MarlinSettings::postprocess() {
// Heated Chamber PID
//
{
- PID_t pid;
+ Serialization::PIDSS pid;
EEPROM_READ(pid);
#if ENABLED(PIDTEMPCHAMBER)
- if (!validating && !isnan(pid.Kp)) {
+ if (!validating && pid.Kp != 0)
... | [No CFG could be retrieved] | region Mesh EEPROM Read functions 8. 1. 2. 2. 4. 1. | I'm discomfited seeing double-colons creeping into the codebase. I'm not fond of them because it makes your code look like VisualBASIC, and it's me who will end up having to type them out all day. Philosophically and stylistically speaking, will it really be better if Marlin code is modified so that everything is defin... |
@@ -1574,6 +1574,11 @@ class Products extends DolibarrApi
$prodc2vp = new ProductCombination2ValuePair($this->db);
$combinations[$key]->attributes = $prodc2vp->fetchByFkCombination((int) $combination->id);
$combinations[$key] = $this->_cleanObjectDatas($combinations[$key]);
+
+ $productModel = new Product... | [Products->[deleteAttributeValueByRef->[delete],deleteVariant->[delete],deleteAttributes->[delete],deleteAttributeValueById->[delete],put->[get],delete->[delete],_fetch->[_cleanObjectDatas]]] | Get all variants for a product. | Because we want API to be a low level and this method may generate a high level of subrequest, it is better to add an option to do this. For example, other api have a parameter call $includestockdata set to 0 by default. And load of stock is done only if this param is set to 1. Can you add this ? |
@@ -278,12 +278,12 @@ func (node *Node) tryBroadcastStaking(stakingTx *staking.StakingTransaction) {
}
// Add new transactions to the pending transaction list.
-func (node *Node) addPendingTransactions(newTxs types.Transactions) {
+func (node *Node) addPendingTransactions(newTxs types.Transactions) []error {
pool... | [AddPendingTransaction->[tryBroadcast,addPendingTransactions],StartServer->[startRxPipeline],ShutDown->[Blockchain,Beaconchain],InitConsensusWithValidators->[Blockchain],countNumTransactionsInBlockchain->[Blockchain],AddPendingReceipts->[Blockchain],addPendingStakingTransactions->[Blockchain],AddPendingStakingTransacti... | addPendingTransactions adds new transactions to the pending list of transactions in the pool of the node. | why aren't we not broadcasting txns here? |
@@ -109,6 +109,14 @@ class NodeStripVisitor(TraverserVisitor):
assert isinstance(lvalue, NameExpr)
assert self.type is not None # Because self.is_class_body is True
del self.type.names[lvalue.name]
+ if self.type and not self.is_class_body:
+ # TODO: Handle mult... | [strip_target->[accept,strip_file_top_level,isinstance,NodeStripVisitor],NodeStripVisitor->[strip_file_top_level->[accept],visit_name_expr->[strip_ref_expr],visit_import->[split],visit_member_expr->[strip_ref_expr,super,is_duplicate_attribute_def],visit_decorator->[accept],is_duplicate_attribute_def->[any,get],visit_ov... | Add missing missing entries to the symbol table. | Indicate that `is_new_def` implies that this must be a self assignment? |
@@ -90,6 +90,12 @@ def generate_order_lines_payload(lines: Iterable[OrderLine]):
extra_dict_data={
"total_price_net_amount": (lambda l: l.total_price.net.amount),
"total_price_gross_amount": (lambda l: l.total_price.gross.amount),
+ "allocations": list(
+ lin... | [generate_sample_payload->[generate_product_payload,_generate_sample_order_payload,_get_sample_object,generate_fulfillment_payload,generate_customer_payload,generate_page_payload,generate_checkout_payload],generate_fulfillment_payload->[generate_fulfillment_lines_payload,generate_order_payload],_generate_sample_order_p... | Generate order lines payload. Get order data for a single order in order_order_orders. | Webhook payload should use GraphQL IDs. |
@@ -2135,6 +2135,10 @@ define([
var uv = gltfUniformFunctions[parameter.type](instanceParameters[parameterName], model);
uniformMap[name] = uv.func;
uniformValues[parameterName] = uv;
+ } else if (defined(param... | [No CFG could be retrieved] | The functions that define the count of the components in the node and the uniform values that are function to modify the parameter. | @tfili this is an old TODO of mine. Can we remove it? |
@@ -140,6 +140,9 @@ func TestSoftSnooze(t *testing.T) {
if pe := libkb.ImportProofError(result.ProofResult); pe == nil {
t.Fatal("expected a Rooter error result")
}
+ if !idUI.BrokenTracking {
+ t.Fatal("expected broken tracking!")
+ }
assertTracking(tc, username)
}
| [GetHTML->[GetHTML],Get->[Get],Post->[Post],PostHTML->[PostHTML],GetText->[GetText]] | Check if the user has an ecton error. | We expect the bool to be set. I tested that this check breaks before the bugfix below. |
@@ -358,8 +358,7 @@ namespace System.Linq
// In the event of an empty array, generate the same exception
// that the linq extension method would.
- return immutableArray.Length > 0
- ? immutableArray[0]
+ return !immutableArray.IsEmpty ? immutableArray[0]... | [ImmutableArrayExtensions->[ToDictionary->[ToDictionary],T->[Any],SelectMany->[SelectMany],Where->[Where],Select->[Select]]] | Gets the first element of the array if it is immutable. | Did the fixer make this change? It appears to be getting the whitespace "wrong"; we should validate that trivia is being handled correctly. |
@@ -977,11 +977,12 @@ void Sedp::rekey_volatile(const Security::SPDPdiscoveredParticipantData& pdata)
#endif // OPENDDS_SECURITY
-void Sedp::disassociate_helper(const BuiltinEndpointSet_t& avail, const CORBA::ULong flags,
+void Sedp::disassociate_helper(BuiltinEndpointSet_t& avail, const CORBA::ULong flags,
... | [No CFG could be retrieved] | DDS - related methods DDS Topic Key Subcription Key. | This is incorrect. |
@@ -560,6 +560,12 @@ module Engine
end
end
+ reservations = Hash.new { |k, v| k[v] = [] }
+ corporations.each do |corp|
+ reservations[corp.coordinates].unshift(corp)
+ corp.abilities(:token).flat_map(&:hexes).each { |h| reservations[h] << corp }
+ end
+
... | [Base->[end_game!->[format_currency],current_entity->[current_entity],trains->[trains],initialize->[title],process_action->[process_action],next_round!->[end_game!],init_company_abilities->[shares],inspect->[title]]] | Initializes the hex object with the given companies and corporations. | why are we unshifting here? |
@@ -160,6 +160,10 @@ export function getElement(selector, el, selectionMethod) {
return closestByTag(el, selector);
} else if (selectionMethod == 'scope') {
return el.parentElement.querySelector(selector);
+ } else if (selectionMethod == 'host') {
+ const elWin = el.ownerDocument.defaultView;
+ cons... | [No CFG could be retrieved] | Gets the element that matches the given selector. A class that exports a single resource id which can be used to determine if a window should. | Do we need to test that this is a friendly iframe? |
@@ -122,7 +122,9 @@ public class MongoDBAuditBackend extends AbstractAuditBackend implements AuditBa
MongoDBConnectionService mongoService = Framework.getService(MongoDBConnectionService.class);
MongoDatabase database = mongoService.getDatabase(AUDIT_DATABASE_ID);
collection = database.getCol... | [MongoDBAuditBackend->[MongoDBLogEntryProvider->[addLogEntry->[addLogEntries]],syncLogCreationEntries->[syncLogCreationEntries],expandQueryVariables->[expandQueryVariables],getApplicationStartedOrder->[getApplicationStartedOrder]]] | This method is called when the application starts. | Question @efge please: why not `LOG_PRINCIPAL_NAME` or `LOG_DOC_LIFE_CYCLE` too for instance? |
@@ -17,7 +17,7 @@ dma_free_chunk(struct bio_dma_chunk *chunk)
D_ASSERT(chunk->bdc_ref == 0);
D_ASSERT(d_list_empty(&chunk->bdc_link));
- if (bio_nvme_configured())
+ if (bio_spdk_inited > 0)
spdk_dma_free(chunk->bdc_ptr);
else
free(chunk->bdc_ptr);
| [No CFG could be retrieved] | Allocate a chunk of data from a bio_dma_chunk private static int bio_chk_cnt_max = 0 ;. | Minor: The coding style of checking a bool is 'if (bio_spdk_inited)', 'bio_spdk_inited > 0' is used for checking integer. |
@@ -234,12 +234,14 @@ public final class TestHelper {
// wait for the pipeline to get destroyed in the datanodes
for (Pipeline pipeline : pipelineList) {
+ HddsProtos.PipelineID pipelineId = pipeline.getId().getProtobuf();
for (DatanodeDetails dn : pipeline.getNodes()) {
XceiverServerSp... | [TestHelper->[createKey->[createKey],getStateMachine->[getStateMachine],waitForPipelineClose->[isContainerPresent,isContainerClosed,waitForPipelineClose],waitForContainerClose->[waitForContainerClose,isContainerPresent,isContainerClosed],waitForReplicaCount->[countReplicas]]] | Waits for all the pipelines to be closed. | Thanx @adoroszlai for the fix, I am able to repro this, changes seems fair enough. Does it makes sense to `removeGroup` explicitly in case `server.isExist(pipelineId)` is true, rather than waiting? Might speed up test? We can ignore the exception from `removeGroup` in the wait and retry to counter the race condition |
@@ -37,6 +37,8 @@ const files = {
'tsconfig.json',
'tsconfig-aot.json',
'tslint.json',
+ '.eslintrc.json',
+ '.eslintignore',
'angular.json',
'webpack/utils.js',
'webpack/webpack.common.js... | [No CFG could be retrieved] | This function creates a file path string for a specific object. Jhipster family member icons. | Why are you keeping `tslint.json`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.