patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -66,6 +66,18 @@ func NewShootLogger(logger *logrus.Logger, shoot, project, operationID string) *
return logger.WithFields(fields)
}
+// NewBackupInfrastructureLogger extends an existing logrus logger and adds an additional field containing the BackupInfrastructure name
+// and the project in the Garden cluster ... | [Sprintf,WithFields] | NewShootLogger extends an existing logrus logger and adds the project in the Garden cluster. | See above, no need for dedicated function. |
@@ -167,6 +167,8 @@ class Acts(CMakePackage, CudaPackage):
conflicts('+hepmc3', when='-examples')
conflicts('+pythia8', when='@:0.22')
conflicts('+pythia8', when='-examples')
+ conflicts('+python', when='@:13.0.0')
+ conflicts('+python', when='-examples')
conflicts('+tgeo', when='-identificati... | [Acts->[cmake_args->[plugin_cmake_variant->[cmake_variant,plugin_label],example_cmake_variant,cmake_variant,plugin_cmake_variant]]] | Return command line arguments for CMake. Returns a list of arguments for the missing - cmake - specific magic number. | Please use `@:13` instead, this way the conflicts statement will still behave as expected if we need to tag a v13.0.y bugfix later on. |
@@ -588,7 +588,6 @@ class Compiler(object):
def setup_custom_environment(self, pkg, env):
"""Set any environment variables necessary to use the compiler."""
- pass
def __repr__(self):
"""Return a string representation of the compiler toolchain."""
| [Compiler->[cxx_version->[default_version],f77_version->[default_version],fc_version->[default_version],__init__->[tokenize_flags],verify_executables->[accessible_exe],_get_compiler_link_paths->[_parse_non_system_link_dirs],default_version->[get_compiler_version_output],cc_version->[default_version]],get_compiler_versi... | Setup the custom environment for the compiler toolchain. | This seems unrelated to the platform checks? |
@@ -121,6 +121,11 @@ class Help_Command extends WP_CLI_Command {
$binding['synopsis'] = wordwrap( "$name " . $command->get_synopsis(), 79 );
+ $alias = $command->get_alias();
+ if ( $alias ) {
+ $binding['has-alias']['alias'] = $alias;
+ }
+
if ( $command->can_have_subcommands() ) {
$binding['has-sub... | [Help_Command->[find_subcommand->[find_subcommand]]] | Returns the initial markdown for a command. | This can be `$binding['alias']` |
@@ -17,7 +17,7 @@ if (isset($_POST['edit']) && $_POST['edit'] == 'edit') {
if (isset($_GET['pID'])) {
$products_id = zen_db_prepare_input($_GET['pID']);
}
- $products_date_available = zen_db_prepare_input($_POST['products_date_available']);
+ $products_date_available = !empty($_POST['products_date_availabl... | [RecordCount,Execute] | <?php = > Shows the list of metatags for a given node function to update the meta tags of the products. | I see this PR started with just fixing an undefined array index. But, is this `$products_date_available` variable actually even used anywhere in this workflow? Can't this line (and the one below it) be safely removed? |
@@ -331,6 +331,14 @@ func (a *ACME) CreateLocalConfig(tlsConfig *tls.Config, checkOnDemandDomain func
func (a *ACME) getCertificate(clientHello *tls.ClientHelloInfo) (*tls.Certificate, error) {
domain := types.CanonicalDomain(clientHello.ServerName)
account := a.store.Get().(*Account)
+ //use regex to test for wil... | [LoadCertificateForDomains->[Get],CreateClusterConfig->[init],getCertificate->[getCertificate,Get],retrieveCertificates->[Get],CreateLocalConfig->[init],renewCertificates->[renewCertificates,Get],loadCertificateOnDemand->[Get]] | getCertificate returns the certificate for the given clientHelloInfo. | @dtomcej Will this properly **not** match subdomains of a wildcard? E,g, If I have a certificate for `*.mysite.com`, then `foo.mysite.com` should match but `bar.foo.mysite.com` should not match. Should it be `strings.Replace(k, "*.", "[^.]*\\.?", -1)` instead? |
@@ -211,6 +211,13 @@ public abstract class AbstractStoragePoolAllocator extends AdapterBase implement
return false;
}
+ if (diskProvisioningTypeStrictness){
+ StoragePoolDetailVO hardwareAcceleration = storagePoolDetailsDao.findDetail(pool.getId(), "hardwareAccelerationSupporte... | [AbstractStoragePoolAllocator->[allocateToPool->[allocateToPool,select],reorderPools->[reorderPoolsByNumberOfVolumes,reorderPoolsByCapacity],configure->[configure]]] | Filter storage pools based on the given exclude list. Checks if the storage pool has enough Iops and Space in the plan. | as mentioned above, please use direct configkey object with valueIn() method |
@@ -34,7 +34,7 @@ public class CompatibleKryo extends Kryo {
throw new IllegalArgumentException("type cannot be null.");
}
- if (!type.isArray() && !type.isEnum() && !ReflectionUtils.checkZeroArgConstructor(type)) {
+ if (!type.isArray() && !type.isEnum() && !type.equals(LocalDate.... | [CompatibleKryo->[getDefaultSerializer->[getDefaultSerializer]]] | Returns a serializer for the given type. | Simply check types will not solve the problem. |
@@ -502,7 +502,7 @@ class DistributeTranspiler:
def _get_splited_name_and_shape(varname):
for idx, splited_param in enumerate(params):
pname = splited_param.name
- if pname.startswith(varname) and varname != pname:
+ if same_or_split_var(pname, varnam... | [DistributeTranspiler->[_append_pserver_ops->[_get_optimizer_input_shape,_create_var_for_trainers],get_startup_program->[_get_splited_name_and_shape],transpile->[split_dense_variable],get_pserver_program->[_clone_var,_is_op_on_pserver,_append_pserver_ops,_append_pserver_non_opt_ops],_append_split_op->[_create_vars_from... | Get startup program for current parameter server. Get the last node in the graph that has a . | The bug happened because "emb" is matched with "embedding_1.w_0" at this line. |
@@ -32,6 +32,12 @@ describe Admin::ScreenedIpAddressesController do
expect(response.status).to eq(200)
result = response.parsed_body
expect(result.length).to eq(1)
+
+ get "/admin/logs/screened_ip_addresses.json", params: { filter: "5.0.0.1" }
+
+ expect(response.status).to eq(200)
+ ... | [to,parsed_body,describe,fab!,before,get,min_ban_entries_for_roll_up,by,eq,sign_in,first,it,require] | It provides a description of the admin interface for the ScreenedIpAddressesController class. rolls up 1. 2. 3. 4 4. 2. 6 6. 2. | Minor suggestion but testing for length is not sufficient in my opinion since a wrong result can be returned and this test will still pass. I noted that the existing assertions above are doing so but I would recommend changing them too. |
@@ -169,11 +169,11 @@ public class GroupByMergingQueryRunnerV2 implements QueryRunner<Row>
// This will potentially block if there are no merge buffers left in the pool.
final long timeout = timeoutAt - System.currentTimeMillis();
if (timeout <= 0 || (mergeBufferHolder... | [GroupByMergingQueryRunnerV2->[run->[cleanup->[close],make->[close->[close],close],run]]] | Runs a GroupByQuery and returns the result if it finds a . Creates a sequence of CloseableGrouperIterator that can be used to iterate over the specified key This method is called when a new segment is unmapped. | why this change? i think this is used to propagate issues properly from historicals to brokers |
@@ -54,7 +54,7 @@ class SignUpCompletionsShow
def title
if requested_ial == 'ial2'
- I18n.t('titles.sign_up.verified')
+ I18n.t('titles.sign_up.verified', app: APP_NAME)
else
I18n.t(
'titles.sign_up.completion_html',
| [SignUpCompletionsShow->[requested_ial->[user_verified?]]] | title - returns the title missing in the sign - up page or the title missing in. | ~I think this is supposed to be `service_provider.friendly_name` instead of `APP_NAME`~ **EDIT**: nevermind |
@@ -47,8 +47,10 @@ __all__ = (
#-----------------------------------------------------------------------------
# Dev API
#-----------------------------------------------------------------------------
+Theme = Union[Theme, FromCurdoc, None]
+
-def notebook_content(model, notebook_comms_target=None, theme=FromCurdoc)... | [notebook_content->[encode_utf8,render,standalone_docs_json_and_render_items,to_json,serialize_json,div_for_render_item,OutputDocumentFor,ValueError,isinstance],getLogger] | Return script and div that will display a Bokeh node with a specific tag. | I think `ThemeSource` might be a better name here, in any case I don't think it can be `Theme` since that shadows the `Theme` import above. |
@@ -33,7 +33,6 @@ namespace Content.Client.GameObjects.Components.Suspicion
IEyeManager eyeManager)
: base(nameof(TraitorOverlay))
{
- _entityManager = entityManager;
_eyeManager = eyeManager;
_font = new VectorFont(resourceCache.GetResource<Font... | [TraitorOverlay->[AddAlly->[Add],RemoveAlly->[Remove],Draw->[ScreenSpace,DrawScreen],DrawScreen->[MapPosition,TopLeft,OrangeRed,WorldAABB,IsEmpty,TryGetEntity,IsMapTransform,Transform,CurrentMap,GetWorldViewport,MapID,WorldToScreen,TryGetComponent,DrawString,Intersects,InRangeUnOccluded],DrawString->[Y,DrawChar,GetAsce... | TraitorOverlay is a base class for all Traits that are overlayed. DrawScreen - Draws the screen on the specified screen. | Why did you remove this? The game will crash when the overlay is applied. |
@@ -434,12 +434,15 @@ class VariablesManager:
self.coupling_dem_vars += [Kratos.REYNOLDS_NUMBER]
if self.do_backward_coupling:
- if parameters["coupling"]["backward_coupling"]["apply_time_filter_to_fluid_fraction_option"].GetBool():
- self.time_filtered_vars += [Kratos.... | [VariablesManager->[ConstructListsOfResultsToPrint->[EliminateRepeatedValuesFromList,GetGlobalVariableByName],AddExtraProcessInfoVariablesToDispersePhaseModelPart->[AddFrameOfReferenceRelatedVariables],AddExtraProcessInfoVariablesToFluidModelPart->[AddFrameOfReferenceRelatedVariables]]] | Constructs a list of variables that are used in the coupling case. Gets the list of coupling variables filtered by the user. This function returns a list of all coupling - related variables. This method is called to add coupling - related variables to the coupling_dem_ This method is called to add the values of the Nod... | This looks like a leftover from debugging |
@@ -170,6 +170,7 @@ func executeContainerTemplate(info *containerInfo, options entities.GenerateSyst
info.EnvVariable = EnvVariable
info.ExecStart = "{{.Executable}} start {{.ContainerNameOrID}}"
info.ExecStop = "{{.Executable}} stop {{if (ge .StopTimeout 0)}}-t {{.StopTimeout}}{{end}} {{.ContainerNameOrID}}"
+ i... | [Executable,Warnf,Now,WriteByte,Wrap,WriteFile,Strings,Format,New,Errorf,Bytes,ID,Join,Execute,Name,Config,StopTimeout,Sprintf,String,Parse,Getwd] | executeContainerTemplate executes the specified container template on the specified containerInfo and returns the name of startCommand returns the command to run the start command. | should it be `-{{.Executable}} stop {{if (ge .StopTimeout 0)}}-t {{.StopTimeout}}{{end}} {{.ContainerNameOrID}}` (extra - at the beginning) to ignore failures? |
@@ -116,7 +116,7 @@ inline void launchQuery(const std::string& name, const ScheduledQuery& query) {
return;
}
- VLOG(1) << "Found results for query (" << name << ") for host: " << ident;
+ VLOG(1) << "Found results for query: " << name;
item.results = diff_results;
if (query.options.count("removed") &... | [No CFG could be retrieved] | Create a database - backed set of named queries. The main function for the cache. | Any reason why this one is `VLOG(1)` whereas above it's `LOG(INFO)`? |
@@ -196,8 +196,7 @@ def collection_detail(request, user_id, slug):
request, collection, require_owner=False),
}
- tags = Tag.objects.filter(
- id__in=collection.top_tags) if collection.top_tags else []
+ tags = []
return render_cat(request, 'bandwagon/collection_detail.html',
... | [owner_required->[decorator->[wrapper->[get_collection]],decorator],user_listing->[render_cat],ajax_collection_alter->[change_addon],edit->[initial_data_from_request,render_cat,get_notes,collection_message],edit_addons->[collection_message],collection_detail->[get_collection,CollectionAddonFilter,render_cat],mine->[use... | Display a list of all the tags and addons for a given collection. | Let's go one step further remove all that and remove the tags from `bandwagon/templates/bandwagon/collection_detail.html` (line 118 `{% if tags %}` to line 130 `{% endif %}`) given all that is unused now anyway. |
@@ -0,0 +1,10 @@
+#include QMK_KEYBOARD_H
+
+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
+ [0] = LAYOUT_ortho_4x10(
+ KC_A, KC_B, KC_C, KC_D, KC_E, KC_F, KC_G, KC_H, KC_I, KC_J,
+ KC_A, KC_B, KC_C, KC_D, KC_E, KC_F, KC_G, KC_H, KC_I, KC_J,
+ KC_A, KC_B, KC_C, KC_D, KC_E, KC_F... | [No CFG could be retrieved] | No Summary Found. | Sorry that I didn't notice this before, but these should go in /layouts/default/ actually. |
@@ -729,9 +729,9 @@ public class IcebergMetadataWriter implements MetadataWriter {
private int isLate(String datepartition, long previousWatermark) {
ZonedDateTime partitionDateTime = ZonedDateTime.parse(datepartition, HOURLY_DATEPARTITION_FORMAT);
long partitionEpochTime = partitionDateTime.toInstant().to... | [IcebergMetadataWriter->[mergeOffsets->[getLastOffset],createTable->[createTable],write->[getIcebergTable],writeEnvelope->[write,getAndPersistCurrentWatermark],computeCandidateSchema->[getIcebergTable],addLatePartitionValueToIcebergTable->[addPartitionToIcebergTable],close->[close],getAndPersistCurrentWatermark->[getIc... | Check if a given datepartition is late. | Why do we change this part? If current watermark is 09am, does that mean data for 09 has completed? And then if we see dat for 09am, is that a late data? |
@@ -759,8 +759,10 @@ namespace System.Net.Http.Headers
}
// At this point all values are either in info.ParsedValue, info.InvalidValue, or were removed since they
- // contain invalid newline chars. Reset RawValue.
+ // contain invalid ne... | [HttpHeaders->[PrepareHeaderInfoForAdd->[TryGetAndParseHeaderInfo,IsAllowedHeaderName],AddHeaders->[Remove,Add],ReadStoreValues->[ToString],RemoveParsedValue->[Remove],TryAddWithoutValidation->[Add,TryAddWithoutValidation],ToString->[ToString],ParseAndAddValue->[Add,AddValue],AddValue->[ToString],ParseRawHeaderValues->... | Parse the raw header values. If the header is empty it will be removed. | Why is this retrieving `info.OriginalRawValue` and then just setting it back to the same value? |
@@ -838,7 +838,7 @@ class TestSearchParameterFilter(FilterTestsBase):
filter_ = qs['query']['bool']['filter']
assert len(filter_) == 1
should = filter_[0]['bool']['should']
- assert {'terms': {'listed_authors.id': ['123', '456']}} in should
+ assert {'terms': {'listed_authors.id... | [TestQueryFilter->[test_fuzzy_multi_word->[_filter],test_q->[_filter,_test_q],test_no_rescore_if_not_sorting_by_relevance->[_filter,_test_q],test_q_exact->[_filter],test_q_too_long->[_filter],test_no_fuzzy_if_query_too_long->[do_test->[_filter],do_test],test_fuzzy_single_word->[_filter]],TestSortingFilter->[test_sort_r... | Test search by author. | I note this change in the ES query but using the integers seems more "correct" anyway? |
@@ -338,7 +338,14 @@ class BaseTree:
hash_info.size = dir_info.size
return hash_info
- def upload(self, from_info, to_info, name=None, no_progress_bar=False):
+ def upload(
+ self,
+ from_info,
+ to_info,
+ name=None,
+ no_progress_bar=False,
+ file_mo... | [BaseTree->[_check_requires->[get_missing_deps,RemoteMissingDepsError],copy->[RemoteActionNotImplemented],move->[remove],upload->[RemoteActionNotImplemented],_download_dir->[walk_files],_download_file->[move,makedirs],get_hash->[exists,isdir],get_dir_hash->[_collect_dir],_collect_dir->[_calculate_hashes,walk_files],dow... | Get a hash of a node in the system. | `file_mode` is already supported in `BaseTree.download()`, so I think specifying mode here fits into the existing tree API |
@@ -145,6 +145,11 @@ public class ServiceConfig<T> extends AbstractServiceConfig {
*/
private ProviderConfig provider;
+ /**
+ * The metrics configuration
+ */
+ private MetricsConfig metrics;
+
/**
* The providerIds
*/
| [ServiceConfig->[export->[checkAndUpdateSubConfigs],convertProtocolToProvider->[convertProtocolToProvider],unexport->[unexport],convertProviderToProtocol->[convertProviderToProtocol],findConfigedPorts->[getRandomPort,putRandomPort],exportLocal->[export],setProviders->[convertProviderToProtocol],getProviders->[convertPr... | Creates a new service config object. ProtocolToProvider - returns provider for given protocols. | Both ServiceConfig and ReferenceConfig have this property, how about moving it to one shared superclass. |
@@ -230,7 +230,8 @@ class SimpleCodegenTask(Task):
with self.context.new_workunit(name='execute', labels=[WorkUnitLabel.MULTITOOL]):
vts_to_sources = OrderedDict()
for vt in invalidation_check.all_vts:
- synthetic_target_dir = self.synthetic_target_dir(vt.target, vt.results_dir)
+
+ ... | [SimpleCodegenTask->[execute->[codegen_targets,get_fingerprint_strategy,_validate_sources_globs,_do_validate_sources_present],_inject_synthetic_target->[synthetic_target_type,_get_synthetic_address,synthetic_target_extra_dependencies,synthetic_target_extra_exports],_handle_duplicate_sources->[record_duplicates->[ignore... | Executes the codegen. | What's the difference between results_dir and current_results_dir? Why is this changing? |
@@ -55,7 +55,7 @@ class UsersController < ApplicationController
ExportContentWorker.perform_async(@user.id)
end
cookies.permanent[:user_experience_level] = @user.experience_level.to_s if @user.experience_level.present?
- follow_hiring_tag(@user)
+ follow_hiring_tag(@user) if SiteConfig.... | [UsersController->[update->[update],remove_identity->[update],add_org_admin->[update],update_twitch_username->[update],remove_org_admin->[update]]] | Updates a user s nag and returns it if it succeeds. | This method was recently added to `SiteConfig` to allow for special-casing behavior to DEV. |
@@ -205,8 +205,8 @@ func (ss *SecretSyncer) IsDeviceNameTaken(name string) bool {
// HasActiveDevice returns true if there is an active desktop or
// mobile device available.
-func (ss *SecretSyncer) HasActiveDevice() bool {
- devs, err := ss.ActiveDevices()
+func (ss *SecretSyncer) HasActiveDevice(includeTypesSet ... | [HasActiveDevice->[ActiveDevices],dumpDevices->[Warning,G],FindActiveKey->[KIDFromString,ToSKB,FindActiveKey,GetKeyRole],IsDeviceNameTaken->[ActiveDevices],FindDevice->[Errorf],ActiveDevicesPlusWeb->[Errorf],DumpPrivateKeys->[Info,G],ToSKB->[Errorf],syncFromServer->[UnmarshalAgain,G,Get,Add,Debug],store->[PutObj,dbKey,... | HasActiveDevice returns true if there is an active device. | so all these function parameters with pointers to maps don't need to be pointers. can still pass in nil. |
@@ -110,6 +110,9 @@ class ConfigCache implements IConfigCache, IPConfigCache
} else {
if (isset($this->config[$cat][$key])) {
unset($this->config[$cat][$key]);
+ if (count($this->config[$cat]) == 0) {
+ unset($this->config[$cat]);
+ }
}
}
}
| [ConfigCache->[loadConfigArray->[setDefault,set],setDefault->[set]]] | Delete a value from a config array. | We now unset the parent category too if it is empty |
@@ -565,9 +565,12 @@ namespace System.IO
Assert.True(fileInfo.Exists);
tempRootDir.CreatedSubfiles.Add(fileInfo);
- var actualFileInfo = new FileInfo(path);
- FileSecurity actualSecurity = actualFileInfo.GetAccessControl(AccessControlSections.Access);
- Verif... | [FileSystemAclExtensionsTests->[Verify_FileSecurity_CreateFile->[Verify_FileSecurity_CreateFile]]] | Private method for FileSecurity and DirectorySecurity. | What does this return when you create the file with a null FileSecurity? I assume it doesn't return null. |
@@ -370,10 +370,17 @@ def load_models(args):
for config_path in sorted(_common.MODEL_ROOT.glob('**/model.yml')):
subdirectory = config_path.parent.relative_to(_common.MODEL_ROOT)
+ composite_model_config = config_path.parents[1] / 'composite-model.yml'
+ composite_model_name = None
+ ... | [PostprocRegexReplace->[deserialize->[validate_string,validate_nonnegative_int,validate_relative_path]],FileSourceGoogleDrive->[start_download->[http_range_headers,handle_http_response],deserialize->[validate_string]],FileSourceHttp->[start_download->[http_range_headers,handle_http_response],deserialize->[validate_stri... | Load models from config. | Seems like this will recheck the composite model directory for every component of the composite model, which is not ideal. I would suggest that you first find all `composite-model.yml` files, validate them, remember where they were, and then, for each model, determine whether it belongs to one of the composite models. |
@@ -247,6 +247,10 @@ namespace System.Drawing
public static Color PowderBlue => new Color(KnownColor.PowderBlue);
public static Color Purple => new Color(KnownColor.Purple);
+
+ public static Color RebeccaPurple => new Color(KnownColor.RebeccaPurple);
+
+ public static Color Re... | [Color->[GetHashCode->[GetHashCode],GetBrightness->[GetRgbValues],GetSaturation->[GetRgbValues],Equals->[Equals],ToString->[ToString],GetHue->[GetRgbValues]]] | Get all Color objects of a certain type. Color registry lookup methods. | This is duplicated, missed to remove the previous one. |
@@ -486,7 +486,8 @@ module Engine
end
def init_stock_market
- StockMarket.new(self.class::MARKET, self.class::CERT_LIMIT_COLORS)
+ StockMarket.new(self.class::MARKET, self.class::CERT_LIMIT_COLORS,
+ multiple_buy_colors: self.class::MULTIPLE_BUY_COLORS)
end
... | [Base->[end_game!->[format_currency],current_entity->[current_entity],trains->[trains],initialize->[title],process_action->[process_action],next_round!->[end_game!],init_company_abilities->[shares],inspect->[title]]] | Initializes the stock market and company objects for this player. | every arg new line |
@@ -293,7 +293,7 @@ def search_learning_rate(trainer: Trainer,
logger.info(f'Loss ({loss}) exceeds stopping_factor * lowest recorded loss.')
break
- trainer.rescale_gradients()
+ rescale_gradients(trainer.model, trainer._grad_norm) # pylint: disable=protected-access
tr... | [search_learning_rate->[train,step,tqdm,append,isnan,detach,backward,batch_loss,iterator,rescale_gradients,info,enumerate,ConfigurationError,zero_grad],find_learning_rate_model->[any,datasets_from_params,check_for_gpu,join,info,ConfigurationError,index_with,from_params,set,prepare_environment,makedirs,_smooth,pop,_save... | Runs training loop on the model and calculates learning rates and losses. Learning rates and losses are stored in a list. | Could you elaborate on why the previous implementation isn't acceptable here? Seems cleaner that way. |
@@ -25,10 +25,8 @@ class AdminPool
/**
* Adds a new admin.
- *
- * @param $admin
*/
- public function addAdmin($admin)
+ public function addAdmin(Admin $admin)
{
$this->pool[] = $admin;
}
| [AdminPool->[getSecurityContexts->[getSecurityContexts],getSecurityContextsWithPlaceholder->[getSecurityContextsWithPlaceholder]]] | Adds an admin to the pool. | i think we cannot add typehints here because of backwards compatibility. if somebody extended this class and overwrote this method, his application will break because the method signature does not match anymore |
@@ -43,6 +43,7 @@ public class JdbcModule
newOptionalBinder(binder, ConnectorAccessControl.class);
newSetBinder(binder, Procedure.class);
newSetBinder(binder, SessionPropertiesProvider.class).addBinding().to(BaseJdbcPropertiesProvider.class);
+ newSetBinder(binder, TablePropertiesProvi... | [JdbcModule->[configure->[install,to,JdbcDiagnosticModule,newSetBinder,bindConfig,get,newOptionalBinder,in],requireNonNull]] | Configure the missing key. | Since I originally did this work someone recently added a `BaseJdbcPropertiesProvider` class (that only works for session properties not table properties). I can do the same if we want to do that. |
@@ -1,13 +1,12 @@
package org.ray.streaming.api.stream;
import java.io.Serializable;
+import org.ray.streaming.api.Language;
import org.ray.streaming.api.context.StreamingContext;
import org.ray.streaming.api.partition.Partition;
import org.ray.streaming.api.partition.impl.RoundRobinPartition;
import org.ray.st... | [Stream->[getParallelism,getStreamingContext,generateId,selectPartition]] | Abstract base class of all stream types. This method is used to set the operator for the stream. | Shall these fields except `partition` and `parallelism` as final? |
@@ -1341,9 +1341,9 @@ resource "aws_s3_bucket_object" "object" {
tags = {
Key2 = "BBB"
- Key3 = "XXX"
+ Key3 = "X X"
Key4 = "DDD"
- Key5 = "EEE"
+ Key5 = "E:/"
}
}
`, randInt, key, content)
| [ParallelTest,GetObject,TempFile,Now,DeepEqual,Close,HasPrefix,WriteFile,Strings,Format,AddDate,RandInt,UTC,RootModule,ComposeTestCheckFunc,Errorf,MustCompile,ListBuckets,HeadObject,Name,ReadAll,Remove,AddTestSweepers,Printf,StringValue,Meta,Sprintf,TestCheckResourceAttr,Print,String,Fatal,EncodeToString,GetObjectAcl] | testAccAWSS3BucketObjectConfig_withTags - returns a string that can be testAccAWSS3BucketObjectConfig_withMetadata - test if object lock is legal. | Test with some characters that need to be URL encoded. |
@@ -452,7 +452,7 @@ public abstract class AbstractPipeline extends AbstractFlowConstruct implements
(processingStrategyFactory instanceof DefaultFlowProcessingStrategyFactory
|| processingStrategyFactory instanceof LegacyDefaultFlowProcessingStrategyFactory
|| processingStrategyFactor... | [AbstractPipeline->[configureMessageProcessors->[getMessageProcessors],validateConstruct->[validateConstruct,evaluate,getProcessingStrategyFactory],addMessageProcessorPathElements->[addMessageProcessorPathElements],doStop->[doStop],isSynchronous->[isSynchronous],doDispose->[doDispose],doInitialise->[process->[process],... | Returns true if the current transaction is in a blocking state. | .equals instead of == |
@@ -11,6 +11,17 @@ function display_init(App $a) {
$nick = (($a->argc > 1) ? $a->argv[1] : '');
$profiledata = array();
+ if ($a->argc == 3) {
+ if (substr($a->argv[2], -5) == '.atom') {
+ require_once('include/dfrn.php');
+ $item_id = substr($a->argv[2], 0, -5);
+ $xml = dfrn::itemFeed($item_id);
+ head... | [display_content->[remove_baseurl]] | Display the user s network items Check if the user is a user who has a reserved word and if it is not copy This function is used to store all post - related data in a contact. Load a network network. | I would move this to the top of the file.. |
@@ -563,7 +563,7 @@ def check_xpi_info(xpi_info, addon=None):
_("Add-on ID must be 64 characters or less."))
if not guid_optional and addon and addon.guid != guid:
raise forms.ValidationError(_("Add-on ID doesn't match add-on."))
- if (not addon and
+ if (not addon and guid and
... | [parse_addon->[parse_xpi,parse_search],PackageJSONExtractor->[apps->[get_simple_version,get,get_appversions],parse->[apps,get],find_appversion->[get_simple_version,get]],extract_xpi->[extract_zip,copy_over],RDFExtractor->[apps->[find,get,get_appversions,uri],find_type->[get],find->[uri],__init__->[apps]],SafeUnzip->[cl... | Check that the X - PIN is valid. | We validate that `guid` exists (and raise an error depending on wether or not that's allowed) above so we can safely skip here if it doesn't |
@@ -430,3 +430,16 @@ def test_io_set_raw_2021():
assert "EEG" not in io.loadmat(raw_fname_2021)
_test_raw_reader(reader=read_raw_eeglab, input_fname=raw_fname_2021,
test_preloading=False, preload=True)
+
+
+@testing.requires_testing_data
+def test_read_single_epoch():
+ """Test readin... | [test_position_information->[_assert_array_allclose_nan]] | Test reading new default file format. | why are you using read_epochs_eeglab to read a raw continuous file? |
@@ -247,6 +247,7 @@ def generate_defualt_params():
if __name__ == '__main__':
+ """@nni.next_parameter"""
try:
main(generate_defualt_params())
except Exception as exception:
| [max_pool->[max_pool],avg_pool->[avg_pool],conv2d->[conv2d],main->[build_network,MnistNetwork],generate_defualt_params,main] | This function is the entry point for the main function. It is the entry point. | is this line correct? """@nni.get_next_parameter()"""? |
@@ -1184,7 +1184,15 @@ public class TailFile extends AbstractProcessor {
// This is the same file that we were reading when we shutdown. Start reading from this point on.
rolledOffFiles.remove(0);
FlowFile flowFile = session.create()... | [TailFile->[consumeFileFully->[cleanup,persistState,getState],customValidate->[customValidate],persistState->[persistState,getStateScope],processTailFile->[cleanup],getRolledOffFiles->[compare->[compare]],recoverRolledFiles->[cleanup,recoverRolledFiles,persistState,getRolledOffFiles],onTrigger->[initStates,lookup,recov... | Recover the list of files that have been rolled off. Checks if a file that matches our Rollover Pattern and has a timestamp later than the timestamp if any of the elements in the list of elements is a . | Would you extract this nested try block to a separate method? |
@@ -139,7 +139,7 @@ class PyProjectToml:
return None
- def non_pants_project_abs_path(self, path: str) -> Path | None:
+ def non_pants_project_abs_path(self, path: Any) -> Path | None:
"""Determine if the given path represents a non-Pants controlled project.
If the path points to ... | [parse_single_dependency->[parse,handle_dict_attr,parse_str_version],parse_pyproject_toml->[parse_single_dependency,parse],parse_python_constraint->[conv_and,prepend,parse_str_version],PoetryRequirements->[__call__->[parse_pyproject_toml,create]],PyProjectToml->[non_pants_project_abs_path->[_non_pants_project_abs_path]... | Returns the absolute path of a node in the build root that is not a Pants controlled. | This seems wrong. What do you expect the type to be? Note that `typing.cast()` can be helpful, along with `# type: ignore`. I remember you mentioned MyPy wasn't happy earlier. Even if you have to use either of those, that can often be better than falling back to `Any`, as `Any` gives no insight to the future reader wha... |
@@ -231,6 +231,11 @@ describe SearchController do
expect(SearchLog.where(term: 'wookie')).to be_blank
end
+ it "does not raise 500" do
+ get "/search/query.json", params: { term: "F status:public", type_filter: "topic", search_for_id: true }
+ expect(response.status).to eq(200)
+ end
+
... | [find,min_search_term_length,clear_all!,describe,rate_limit_search_anon_user,freeze_time,rate_limit_search_anon_global,global_setting,first,it,name,raw,rate_limit_search_user,to,log_search_queries,use_pg_headlines_for_excerpt,before,post,log,let!,t,username,require,tags,from_now,include,clear_debounce_cache!,parsed_bod... | should return the right result rate limits anon searches globally. | I think this should be more descriptive of what params should not result in 500 being returned. |
@@ -55,8 +55,10 @@ class CheckoutPaymentCreate(BaseMutation, I18nMixin):
@classmethod
def perform_mutation(cls, _root, info, checkout_id, **data):
- checkout = cls.get_node_or_error(
- info, checkout_id, field='checkout_id', only_type=Checkout)
+ checkout_id = cls.from_global_id_str... | [PaymentCapture->[perform_mutation->[PaymentCapture]],PaymentRefund->[perform_mutation->[PaymentRefund]],PaymentVoid->[perform_mutation->[PaymentVoid]],CheckoutPaymentCreate->[Arguments->[PaymentInput],perform_mutation->[CheckoutPaymentCreate]]] | Perform a single payment for a node. | Is there any way that we could use the optimizer here, maybe somehow with `Checkout.get_node`? I don't know if that's possible but it would be nice to be able to prefetch these fields only when they are requested in a query. |
@@ -675,9 +675,12 @@ public class JmsConnector extends AbstractConnector implements ExceptionListener
private Session createSession(boolean transacted, boolean topic) throws JMSException
{
- Session session;
- session = jmsSupport.createSession(connection, topic, transacted, acknowledgementMod... | [JmsConnector->[createOperationResource->[createSession],createSession->[createSession],doConnect->[createConnection],connect->[onNotification->[connect],connect],createConnection->[createConnection,createConnectionFactory],getSession->[getSession,createSession,getSessionFromTransaction],getOperationResourceFactory->[g... | Creates a session. | Sorry didn't see this before, but can we use a more specific exception here. Either MuleRuntimeException or a more specific java exception like IllegalStateException or something.. |
@@ -62,7 +62,7 @@ public class ConnectNodeCommand extends CLICommand {
boolean errorOccurred = false;
final Jenkins jenkins = Jenkins.getActiveInstance();
- final HashSet<String> hs = new HashSet<String>();
+ final HashSet<String> hs = new HashSet<>();
hs.addAll(nodes);
... | [ConnectNodeCommand->[run->[findNearest,getComputerNames,IllegalArgumentException,Computer_NoSuchSlaveExistsWithoutAdvice,getMessage,AbortException,Computer_NoSuchSlaveExists,size,getActiveInstance,println,format,addAll,cliConnect,getComputer],getShortDescription->[ConnectNodeCommand_ShortDescription],getLogger,getName... | Runs the necessary tasks. | Is there a reason not to update this (and other usages of `Jenkins#getActiveInstance`) to `Jenkins#get`? Seems like you might as well do it at the same time as updating `Jenkins#getInstance`. |
@@ -266,7 +266,7 @@ func CreateLoginSource(source *LoginSource) error {
// LoginSources returns a slice of all login sources found in DB.
func LoginSources() ([]*LoginSource, error) {
- auths := make([]*LoginSource, 0, 5)
+ auths := make([]*LoginSource, 0, 6)
return auths, x.Find(&auths)
}
| [BeforeSet->[ToStr],BeforeInsert->[Unix,Now],HasTLS->[IsLDAP,LDAP,IsSMTP,IsDLDAP],FromDB->[Unmarshal],AfterSet->[Unix,Local],BeforeUpdate->[Unix,Now],UseTLS->[SMTP,LDAP],SkipVerify->[SMTP,LDAP],ToDB->[Marshal],Warn,Auth,Index,Count,Find,Close,Delete,Hello,IsSliceContainsStr,AllCols,StartTLS,Error,MatchString,Dial,MustI... | CreateLoginSource returns a login source if not already present. DeleteSource deletes a login source record from DB. | Can we maybe use `len(LoginNames)` instead of a hard-coded value? |
@@ -9,6 +9,9 @@ $port_stats = snmpwalk_cache_oid($device, 'ifName', $port_stats, 'IF-MIB');
$port_stats = snmpwalk_cache_oid($device, 'ifAlias', $port_stats, 'IF-MIB');
$port_stats = snmpwalk_cache_oid($device, 'ifType', $port_stats, 'IF-MIB');
$port_stats = snmpwalk_cache_oid($device, 'ifOperStatus', $port_stats, '... | [No CFG could be retrieved] | Builds the SNMP Cache Array for a given NMS device. This function is used to rename the port - rrd file to the new name and then. | Hi It is not possible to run some xdp code here. |
@@ -91,12 +91,14 @@ func WithExcludeTombstone() GetStoreOption {
return func(op *GetStoreOp) { op.excludeTombstone = true }
}
-type tsoRequest struct {
+// TsoRequest presents the request to get tso.
+type TsoRequest struct {
start time.Time
ctx context.Context
done chan error
physical int64
... | [ScatterRegion->[ScatterRegion,leaderClient],updateLeader->[updateURLs],GetAllStores->[leaderClient,ScheduleCheckLeader,GetAllStores],GetStore->[leaderClient,ScheduleCheckLeader,GetStore],GetPrevRegion->[leaderClient,ScheduleCheckLeader,GetPrevRegion,GetRegion],UpdateGCSafePoint->[leaderClient,ScheduleCheckLeader,Updat... | Updates the given safePoint in TiKV. Create a new instance of the n - node type. | Remove the pool reference. |
@@ -106,8 +106,12 @@ public class DoubleMeanAggregatorFactory extends AggregatorFactory
}
@Override
- public boolean canVectorize()
+ public boolean canVectorize(ColumnCapabilitiesProvider columnCapabilitiesProvider)
{
+ if (fieldName != null) {
+ final ColumnCapabilities originalCapabilities = col... | [DoubleMeanAggregatorFactory->[getCombiningFactory->[DoubleMeanAggregatorFactory],finalizeComputation->[getName],getRequiredColumns->[DoubleMeanAggregatorFactory],combine->[getName]]] | Returns true if the underlying vectorizer can vectorize the given . | fieldName cannot be null for this one, there is a precondition in the constructor |
@@ -915,7 +915,16 @@ Spdp::handle_handshake_message(const DDS::Security::ParticipantStatelessMessage&
DCPS::RepoId reader = src_participant;
reader.entityId = ENTITYID_P2P_BUILTIN_PARTICIPANT_STATELESS_READER;
- if ((iter->second.auth_state_ == DCPS::AS_HANDSHAKE_REPLY || iter->second.auth_state_ == DCPS::AS_H... | [No CFG could be retrieved] | Handle a message received from a participant. if we have the same request and the same response then we should send the same response. | Minor grip: this line is really long |
@@ -225,7 +225,10 @@ def test_find(layout_and_dir, config, builtin_mock):
if pkg.name.startswith('external'):
# External package tests cannot be installed
continue
- spec = pkg.spec.concretized()
+ try:
+ spec = pkg.spec.concretized()
+ except Conflicts... | [test_yaml_directory_layout_parameters->[split,YamlDirectoryLayout,relative_path_for_spec,concretize,len,str,Spec,format,raises],test_find->[all_packages,list,create_install_directory,found_specs,dict,all_specs,concretized,startswith,items],layout_and_dir->[str,YamlDirectoryLayout],test_read_and_write_spec->[path_for_s... | Test that finding specs within an install layout works. | Why did this start getting swallowed? |
@@ -38,7 +38,11 @@ func (sc *MeshCatalog) getWeightedEndpointsPerService() (map[endpoint.ServiceNam
backendWeight := make(map[string]int)
for _, trafficSplit := range sc.meshSpec.ListTrafficSplits() {
- targetServiceName := endpoint.ServiceName(fmt.Sprintf("%s/%s", trafficSplit.Namespace, trafficSplit.Spec.Servi... | [getWeightedEndpointsPerService->[listEndpointsForService]] | getWeightedEndpointsPerService returns a map of weighted service endpoints for each service in the Constructed weighted services. | Would it be better to have a method that does this assignment and them reuse it in all places ? |
@@ -336,6 +336,12 @@ end
describe 'when getting attachment attributes' do
+ it 'should handle a UTF-7 mail' do
+ mail = get_fixture_mail('utf-7-conversion.email')
+ attributes = MailHandler.get_attachment_attributes(mail)
+ attributes.size.should == 3
+ end
+
it 'should handle a mail with a non-multi... | [should_render_from_address->[create_message_from],create_message_from,expect_content_type,expect_header_string,should_render_from_address] | when parsing HTML mail should display UTF - 8 characters in the plain text version correctly should expand a mail with text and HTML alternatives which should be UTF - 8 which should be. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -212,13 +212,13 @@ func (l *Logger) SetLogger(adapter string, config string) error {
// DelLogger removes a logger adapter instance.
func (l *Logger) DelLogger(adapter string) error {
l.lock.Lock()
- defer l.lock.Unlock()
if lg, ok := l.outputs[adapter]; ok {
lg.Destroy()
delete(l.outputs, adapter)
} e... | [Flush->[Flush],Fatal->[Close,writerMsg],Trace->[writerMsg],Info->[writerMsg],Critical->[writerMsg],Error->[writerMsg],Warn->[writerMsg],Close->[Flush],Debug->[writerMsg]] | DelLogger deletes a logger. | Is the defer responsible of a race condition ? |
@@ -6,11 +6,7 @@ module AccountReset
result = AccountReset::ValidateCancelToken.new(token).call
track_event(result)
- if result.success?
- handle_valid_token
- else
- handle_invalid_token(result)
- end
+ result.success? ? handle_valid_token : handle_invalid_token(result... | [CancelController->[create->[call,success?,redirect_to,track_event],show->[call,render,track_event,success?,handle_invalid_token],track_event->[track_event,to_h],handle_valid_token->[redirect_to],handle_success->[t],handle_invalid_token->[first,redirect_to]]] | This action shows the next non - nil token in the cancel token list. | I have feelings about this.... I really like the visual structure of the if/else and ternaries don't make everything better.... but I can't find any configs for it in the docs :[ |
@@ -88,13 +88,12 @@ func (gu *gasUpdater) OnNewLongestChain(head models.Head) {
logger.Warnf("GasUpdater: skipping gas calculation, current block height %v is lower than GAS_UPDATER_BLOCK_DELAY of %v", head.Number, gu.blockDelay)
return
}
- blockNumber := utils.Uint64ToHex(uint64(blockToFetch))
- block, err := ... | [setPercentileGasPrice->[EthMaxGasPriceWei,Sprintf,SetEthGasPriceDefault,Cmp,Debugw,NewInt,String,Errorf],percentileGasPrice->[Sprintf,WithLabelValues,Set,Slice],OnNewLongestChain->[Error,Sprintf,Warnf,Debugw,setPercentileGasPrice,GetBlockByNumber,percentileGasPrice,Uint64ToHex,WithLabelValues,Set,GasUpdaterEnabled],Co... | OnNewLongestChain is called when the chain is new and the gas price is updated skip empty block. | At some point this could probably be modified so that headtracker stores all the transactions and this reads from the table.... But its not very important. |
@@ -291,13 +291,11 @@ func (s *testClusterInfoSuite) testStoreHeartbeat(c *C, cache *clusterInfo) {
c.Assert(cache.getStoreCount(), Equals, int(i+1))
stats := store.status
- c.Assert(stats.LeaderCount, Equals, uint32(0))
c.Assert(stats.LastHeartbeatTS.IsZero(), IsTrue)
c.Assert(cache.handleStoreHeartbe... | [TestRegionMap->[Delete,Len,check,Assert,regionInfo,Get,Put],Test->[getRegion,setRegion,GetStoreId,removeRegion,getStoreLeaderCount,searchRegion,randFollowerRegion,addRegion,GetStorePeer,Assert,randLeaderRegion],Alloc->[AddUint64],testStoreHeartbeat->[loadStore,putRegion,putStore,getStoreCount,getStore,Assert,handleSto... | testStoreHeartbeat tests that a cache has a heartbeat. | can we not check the leader count now? |
@@ -13404,7 +13404,7 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
ImmutableList.of()
)
)
- .setContext(QUERY_CONTEXT_DEFAULT)
+ .setContext(withTimestampResultContext(QUE... | [CalciteQueryTest->[testMaxSubqueryRows->[expectMessage,testQuery,expect,of],testGroupByLimitPushdownExtraction->[testQuery,cannotVectorize,build,of],testOrderByAnyFloat->[testQuery,replaceWithDefault,build,of],testCountStarWithTimeAndDimFilter->[testQuery,build,of],testTimeseriesWithLimitAndOffset->[testQuery,build,of... | This test tests that grouping sets are supported. - - - - - - - - - - - - - - - - - -. | Please fix here and other places too. |
@@ -309,7 +309,9 @@ from bokeh.util.string import nice_join, format_docstring
from bokeh.server.tornado import DEFAULT_WEBSOCKET_MAX_MESSAGE_SIZE_BYTES
from bokeh.settings import settings
-from os import getpid
+import tornado.autoreload as tar
+import os
+from fnmatch import fnmatch
from ..subcommand import Sub... | [Serve->[invoke->[show_callback->[show,keys],die,add_callback,upper,sign_sessions,keys,getattr,basicConfig,len,sorted,secret_key_bytes,Server,getpid,run_until_shutdown,report_server_init_errors,RuntimeError,info,Application,build_single_handler_applications],dict,nice_join],dict,getLogger,nice_join,format_docstring,rep... | The value is specified in milliseconds. The default lifetime interval is 15 seconds. Create a list of available network interfaces for a given network network object. | `from tornado.autoreload import watch` would would be more consistent with the rest of the codebase |
@@ -28,8 +28,17 @@ module T::Private::Methods
ARG_NOT_PROVIDED, # on_failure
nil, # override_allow_incompatible
ARG_NOT_PROVIDED, # type_parameters
- raw
+ raw,
+ false, # final
)
+ @inside_sig_block = false
+ end
+
+ def run!(&block)
+ @inside_sig_... | [DeclBuilder->[finalize!->[checked,check_live!,on_failure,type_parameters,params,bind],checked->[checked,check_live!],void->[returns,check_live!],on_failure->[on_failure,checked,check_live!],abstract->[abstract,check_live!],type_parameters->[type_parameters,check_live!],params->[params,check_live!],overridable->[overri... | Initializes a new object. | Can you make this use `ARG_NOT_PROVIDED` so that you can `sig.final.final` fail the same way that the other builder methods will fail when provided twice? |
@@ -241,6 +241,7 @@ public abstract class CompactionJobConfigurator {
* a directory containing one or more files.
*
*/
+
protected boolean configureInputAndOutputPaths(Job job, FileSystemDataset dataset) throws IOException {
boolean emptyDirectoryFlag = false;
| [CompactionJobConfigurator->[instantiateConfigurator->[createConfigurator],getGoodFiles->[isFailedPath,getUnsuccessfulTaskCompletionEvent]]] | Configures the input and output paths for the MR compaction. | Can we remove this blank line ? |
@@ -28,4 +28,5 @@ export function installCoreServices(window) {
installViewerService(window);
installViewportService(window);
installHistoryService(window);
+ installVsyncService(window);
}
| [No CFG could be retrieved] | Install the viewer service. | Seems like vsync should be one of the first to be installed, or maybe right after viewer. |
@@ -129,13 +129,11 @@ public class BatchAppenderatorDriver extends BaseAppenderatorDriver
long pushAndClearTimeoutMs
) throws InterruptedException, ExecutionException, TimeoutException
{
- final List<SegmentIdentifier> segmentIdentifierList = getSegmentWithStates(sequenceNames)
- .filter(segmentW... | [BatchAppenderatorDriver->[publishAll->[toList,copyOf,SegmentsAndMetadata,publishInBackground,collect],pushAllAndClear->[copyOf,keySet,pushAndClear],pushAndClear->[pushAndDrop,toMap,equals,toList,get,pushInBackground,transformAsync,collect,forEach,ISE,keySet],add->[append],startJob->[ISE,startJob]]] | Push and clear segments. | What is the reason for moving the creation of `requestedSegmentIdsForSequences` from after the push, to before the push? Is it fixing something? |
@@ -245,10 +245,15 @@ Status doubleStarTraversal(const boost::filesystem::path& fs_path,
*/
Status resolveLastPathComponent(const boost::filesystem::path& fs_path,
std::vector<std::string>& results,
+ unsigned int setting,
... | [listDirectoriesInDirectory->[pathExists],doubleStarTraversal->[listFilesInDirectory,doubleStarTraversal,listDirectoriesInDirectory],resolveLastPathComponent->[listFilesInDirectory,doubleStarTraversal,pathExists],resolveFilePattern->[listDirectoriesInDirectory,resolveLastPathComponent,resolveFilePattern]] | Resolves the last path component in the path tree. Checks if the last component of the path is a file or directory. | See [1] `EnumName setting` |
@@ -249,7 +249,8 @@ func (e *PassphraseRecover) loginWithPaperKey(mctx libkb.MetaContext) (err error
if err := e.changePassword(mctx); err != nil {
// Log out before returning
- if err2 := RunEngine2(mctx, NewLogout()); err2 != nil {
+ // TODO FIX ME
+ if err2 := RunEngine2(mctx, NewLogout(libkb.LogoutOptions... | [chooseDevice->[ProtExport,Sort,UIs,Ctx,suggestReset,Errorf,loginWithPaperKey,Trace,explainChange,GetAllActiveDevices,ChooseDevice,Debug],promptPassphrase->[DefaultPassphraseArg,Sprintf,GetNewKeybasePassphrase,UIs],resetPassword->[PromptResetAccount,NewResetPromptDefault,Post,G,UIs,Ctx,Info],legacyRecovery->[loginWithP... | loginWithPaperKey logs in using the paper key. | not sure...why are we logging out on errors here? seems bad |
@@ -289,10 +289,7 @@ public class BigQueryUtils {
case "DATE":
return FieldType.logicalType(SqlTypes.DATE);
case "DATETIME":
- // TODO[BEAM-10240]: map to the new logical type when ZetaSQL DATETIME type is supported
- return FieldType.logicalType(
- new PassThroughLogical... | [BigQueryUtils->[convertAvroFormat->[toBeamRow,getTruncateTimestamps],toGenericAvroSchema->[toGenericAvroSchema],ToTableRow->[apply->[apply,toTableRow]],fromTableFieldSchemaType->[getInferMaps,fromTableFieldSchemaType],toBeamValue->[toBeamRow,apply],toTableFieldSchema->[toTableFieldSchema,build],fromBeamField->[toTable... | Convert BigQuery type to Beam type. | It's possible for users of BigQueryIO to hit this code path through `BigQueryIO.readTableRowsWithSchema()` right? This will be a breaking change since the Java type for a DATETIME field changes from Instant to LocalDateTime. I think that's ok since it's experimental, but we should add a note to CHANGES.md |
@@ -231,10 +231,14 @@ public abstract class AbstractPipeline extends AbstractFlowConstruct implements
@Override
public Event process(final Event event) throws MuleException {
- if (event.isSynchronous() || isSynchronous() || isTransactionActive()) {
+ if (isTransactionActive()) {
... | [AbstractPipeline->[configureMessageProcessors->[getMessageProcessors],validateConstruct->[validateConstruct,evaluate,getProcessingStrategyFactory],addMessageProcessorPathElements->[addMessageProcessorPathElements],doStop->[doStop],isSynchronous->[isSynchronous],doDispose->[doDispose],doInitialise->[process->[isSynchro... | Initialise the MuleContext. | is there a more specific rx exception type to catch here? |
@@ -82,8 +82,8 @@ func NewResourceManagerCommand() *cobra.Command {
managerOpts.Completed().Apply(&managerOptions)
sourceClientOpts.Completed().ApplyManagerOptions(&managerOptions)
sourceClientOpts.Completed().ApplyClientSet(&healthz.DefaultAddOptions.ClientSet)
- targetClientOpts.Completed().Apply(&resou... | [Context,AddAllFlags,AddFlags,Apply,WithName,Info,Done,Add,New,NewTargetClientConfig,CompleteAll,Start,Errorf,Wait,ApplyDefaultClusterId,Get,PrintAndExitIfRequested,AddAllToManager,Completed,ApplyClassFilter,WithTimeout,Sprintf,WithCancel,ApplyManagerOptions,VisitAll,WaitForCacheSync,ApplyClientSet,Flags] | Starts the gardener resource - manager. Add resources to manager. | I just noticed, we are now spinning up two caches for the target cluster. We should remove our own client creation coding in `pkg/resourcemanager/cmd/target.go` and create only a single `Cluster` object holding clients and caches. |
@@ -152,7 +152,7 @@ class WPSEO_OpenGraph_Image {
/**
* Display an OpenGraph image tag.
*
- * @param array $attachment Attachment array.
+ * @param string|array $attachment Attachment array.
*
* @return void
*/
| [WPSEO_OpenGraph_Image->[add_content_images->[get_images],maybe_set_default_image->[has_images],set_images->[maybe_set_default_image,set_attachment_page_image,set_posts_page_image,set_front_page_image,set_singular_image,set_taxonomy_image],set_posts_page_image->[has_images],set_singular_image->[has_images],get_overridd... | Adds an image to the list of images to be uploaded. | Shouldn't this be `mixed`? |
@@ -10,7 +10,7 @@ namespace MonoGame.Framework.Utilities
public class BinaryReaderEx : BinaryReader
{
public BinaryReaderEx(Stream input) : base(input)
- {
+ {
}
public BinaryReaderEx(Stream input, Encoding encoding) : base(input, encoding)
| [BinaryReaderEx->[Read7BitEncodedInt->[Read7BitEncodedInt]]] | BinaryReaderEx - A class to read a single integer from a stream. | We have no need for the changes to BinaryReaderEx / BinaryWritterEx. |
@@ -14,7 +14,9 @@
<div class="status-block" style="background: <%= status[:color] %>">
<%= status[:name] %>
</div>
- <div class="status-comment"><%= status[:status_comment] %></div>
+ <div class="status-comment">
+ <%= status.next_status&.conditions_descriptions&.join(' ') %>
+ ... | [No CFG could be retrieved] | Renders a single . | Shouldn't be each one on a new line? |
@@ -1,9 +1,10 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
+using System.Collections.Ge... | [ToolStripItemAccessibleObjectTests->[ToolStripItemAccessibleObject_Ctor_NullOwnerItem_ThrowsArgumentNullException->[Assert],ToolStripItemAccessibleObject_Ctor_ToolStripItem->[Bounds,Role,Equal,DefaultAction,Help,KeyboardShortcut,MenuBar,Empty,Description,Name,Null,Parent,Focusable,State]]] | Creates a subclass of ToolStripItem that wraps a ToolStripItem in a sub - tool. | @vladimir-krestov - please review if this file should be renamed to follow the new naming convention? Should the test files also be moved out of the `AccessibleObjects` folder? |
@@ -280,7 +280,7 @@ namespace Dynamo.Graph.Nodes
/// to be saved to the XmlDocument. This parameter cannot be null and
/// must represent a non-empty list of node-data-list pairs.</param>
internal static void SaveTraceDataToXmlDocument(XmlDocument document,
- IEnumerable<KeyValueP... | [Utilities->[WrapText->[Clear,Add,Append,IsNullOrWhiteSpace,ToString,IsUpper,Length],ReduceRowCount->[Last,Count,Add,Remove],NormalizeAsResourceName->[Append,Empty,Where,IsNullOrWhiteSpace,ToString,IsLetterOrDigit,Length],LoadTraceDataFromXmlDocument->[SessionTraceDataXmlTag,Any,DocumentElement,GetAttribute,ToList,Elem... | Save the trace data to the specified document. | Are these methods used by DynamoRevit? If yes then we might be breaking binary compatibility. |
@@ -2170,8 +2170,7 @@ class ActionComm extends CommonObject
$error++;
}
- if (!$error)
- {
+ if (!$error) {
// Delete also very old past events (we do not keep more than 1 month record in past)
$sql = "DELETE FROM ".MAIN_DB_PREFIX."actioncomm_reminder";
$sql .= " WHERE dateremind < '".$this->db-... | [ActionComm->[setCategories->[fetch],getActions->[fetch],info->[fetch],build_exportfile->[fetch_userassigned,fetch],sendEmailsReminder->[fetch,update],createFromClone->[create]]] | Sends emails to all action comm reminders This function will send an action comm reminder email to a recipient or a template This function is called when a user is not logged in. It will check if the user This function is called when there is no actioncomm record in the database. | The variable $actionCommReminder does not seem to be defined for all execution paths leading up to this point. |
@@ -100,6 +100,7 @@ class Gcc(AutotoolsPackage):
depends_on('isl@0.15:0.18', when='@6:8.9')
depends_on('isl@0.15:0.20', when='@9:')
depends_on('zlib', when='@6:')
+ depends_on('libiconv')
depends_on('gnat', when='languages=ada')
depends_on('binutils~libiberty', when='+binutils')
depends... | [Gcc->[url_for_version->[Version,format],write_rpath_specs->[join_path,gcc,write,set_install_permissions,startswith,format,warn,open],spec_dir->[glob,format],setup_environment->[search_regexps,upper,isdir,set,join,islink,product,match,listdir],patch->[join_path,install,Version,isfile,filter_file,format,mkdirp],nvptx_in... | Create a list of all possible components of a sequence. Creates a new library with the given name url sha256 and destination. | I'm not sure if this dependency is actually required, but if it's present on the system, the build picks it up, and there doesn't appear to be a way to prevent it. |
@@ -22,7 +22,7 @@ class OtpVerificationForm
end
def pattern_matching_otp_code_format
- /\A\d{#{otp_code_length}}\Z/
+ /\A[a-z0-9]{#{otp_code_length}}\z/i
end
def otp_code_length
| [OtpVerificationForm->[valid_direct_otp_code?->[authenticate_direct_otp,match?],submit->[new,valid_direct_otp_code?],attr_reader]] | returns nil if the OTP code format matches the OTP code length. | TIL `\Z` matches before a newline, but `\z` includes it, so this will reject trailing newlines now, which is stricter but I think we want |
@@ -54,6 +54,7 @@ void set_default_settings(Settings *settings)
settings->setDefault("curl_file_download_timeout", "300000");
settings->setDefault("curl_verify_cert", "true");
settings->setDefault("enable_remote_media_server", "true");
+ settings->setDefault("max_processed_meshes_per_frame", "5");
// Keymap
... | [No CFG could be retrieved] | Settings for Client KEY_KEY_I KEY_KEY_E KEY_KEY_F9 KEY_. | this default limit is ridiculously low :( |
@@ -1,6 +1,7 @@
from __future__ import absolute_import, print_function
import os
+import sys
from bokeh.io import set_curdoc, curdoc
| [ScriptHandler->[modify_document->[_monkeypatch_io,_unmonkeypatch_io]]] | Create a script handler which runs a bokeh script which modifies a Document. Decorator to provide a way to modify the bokeh. io object. | This is a bit worrying. Didn't we test imports? Or maybe we only test for unused imports? |
@@ -3061,6 +3061,14 @@ bool marshal_generator::gen_union(AST_Union* node, UTL_ScopedName* name,
serialized_size.endArgs();
if (has_key) {
+ be_global->impl_ << " serialized_size_delimiter(encoding, size);\n";
+
+ if (may_be_parameter_list) {
+ be_global->impl_ <<
+ " size_t mutab... | [No CFG could be retrieved] | END of function _select_max_serialized_size_8_8_8_ Reads the given key - only node from the input stream and writes it to the output stream. | This has to be conditional on the type not being final. |
@@ -1,9 +1,12 @@
+from copy import deepcopy
+from typing import List, Dict
from overrides import overrides
-
+import numpy as np
from allennlp.common.util import JsonDict
from allennlp.data import Instance
from allennlp.predictors.predictor import Predictor
-
+from allennlp.data.fields import LabelField
+from allen... | [TextClassifierPredictor->[predict->[predict_json],_json_to_instance->[text_to_instance]],register] | A method to predict a single class for a given sentence. | Just `import numpy`, and fix the imports. |
@@ -225,6 +225,15 @@ class BaseModelChatWorld(CrowdTaskWorld, ABC):
for idx, agent in enumerate([self.agent, self.bot]):
if not self.chat_done:
acts[idx] = agent.act(timeout=self.max_resp_time)
+ if (
+ agent == self.bot
+ and h... | [ModelChatOnboardWorld->[check_onboarding_answers->[has_same_answer],_handle_act->[check_onboarding_answers]],make_onboarding_world->[ModelChatOnboardWorld],make_world->[get_bot_worker,ModelChatWorld],BaseModelChatWorld->[shutdown->[shutdown],parley->[__add_problem_data_to_utterance]]] | parley - parley - parley Save the data for a specific node in the chat. Add the problem data to the second - to - last utterance and add the problem data to. | Yeah I think this is preferable to what was here previously, but now the Turker sees `self.bot_agent_id` as the name of the bot, right? Orion implemented a fix in his eval task to just set the bot display name for the Turkers as `YOUR PARTNER` so that they don't see the name of the bot - we might end up using that acro... |
@@ -798,9 +798,10 @@ zfs_mknode(znode_t *dzp, vattr_t *vap, dmu_tx_t *tx, cred_t *cr,
if (S_ISDIR(vap->va_mode)) {
size = 2; /* contents ("." and "..") */
- links = (flag & (IS_ROOT_NODE | IS_XATTR)) ? 2 : 1;
+ links = 2;
} else {
- size = links = 0;
+ size = 0;
+ links = 1;
}
if (S_ISBLK(vap->va_m... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Fill in the array of attributes to be replaced on the new file. | Why were the flags dropped here? |
@@ -67,6 +67,11 @@ public final class OpenSsl {
static final Set<String> SUPPORTED_PROTOCOLS_SET;
static final String[] EXTRA_SUPPORTED_TLS_1_3_CIPHERS;
static final String EXTRA_SUPPORTED_TLS_1_3_CIPHERS_STRING;
+ static final String[] NAMED_GROUPS;
+
+ // Use default that is supported in java 11 ... | [OpenSsl->[version->[version,isAvailable],versionString->[versionString,isAvailable],supportsHostnameValidation->[isAvailable],memoryAddress->[memoryAddress]]] | A class that represents a single self - signed certificate. \ n This file is used to determine if a given file is available in a given directory -----END CERTIFICATE---- -. | That is the naming that is used by BoringSSL and OpenSSL. |
@@ -0,0 +1,13 @@
+# Level represent a level within a Rubric Criterion
+class Level < ApplicationRecord
+ belongs_to :rubric_criterion
+
+ validates :name, presence: true
+ validates :number, presence: true
+ validates :description, presence: true
+ validates :mark, presence: true
+
+ validates_numericality_of :nu... | [No CFG could be retrieved] | No Summary Found. | Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end. |
@@ -227,6 +227,12 @@ func (c *Command) RunInDirWithEnv(dir string, env []string) (string, error) {
return string(stdout), nil
}
+// RunInDirWithEnvBytes executes the command in given directory
+// and returns stdout in []byte and error (combined with stderr).
+func (c *Command) RunInDirWithEnvBytes(dir string, env... | [RunInDirWithEnv->[RunInDirTimeoutEnv],RunInDirFullPipeline->[RunInDirTimeoutFullPipeline],RunInDirTimeoutEnv->[String,RunInDirTimeoutEnvPipeline],RunInDirTimeoutPipeline->[RunInDirTimeoutEnvPipeline],Run->[RunTimeout],RunInDirTimeoutFullPipeline->[RunInDirTimeoutEnvFullPipeline],RunInDirBytes->[RunInDirTimeout],RunTim... | RunInDirWithEnv runs the command in the given directory with the given environment variables. | The wrap function seems unnecessary? |
@@ -25,7 +25,7 @@ import (
// Built from ../contrib/rootless-cni-infra.
var rootlessCNIInfraImage = map[string]string{
- "amd64": "quay.io/libpod/rootless-cni-infra@sha256:304742d5d221211df4ec672807a5842ff11e3729c50bc424ea0cea858f69d7b7", // 3-amd64
+ "amd64": "quay.io/luap99/rootless-cni-infra@sha256:4e9f1e223463a... | [Path,NewContainer,Unlock,Warn,Exec,GetContainersWithoutLock,GetNS,Append,PodID,New,GetLockfile,ErrorOrNil,Lock,ContainerState,Errorf,Namespace,SetupPrivileged,AddProcessEnv,Debugf,RemoveMount,ID,Wrapf,Join,networks,Name,ParseSlice,ImageRuntime,AddMount,SetProcessArgs,removeContainer,RemoveLinuxNamespace,initAndStart,I... | Creates a new CNI object. getCNIInfra returns the CNI infra for the given container. | Somebody needs to build the new image and upload it to the libpod repo. After that I can add it here. |
@@ -18,13 +18,15 @@
#include "common/color_picker.h"
#include "common/darktable.h"
+#include "common/colorspaces_inline_conversions.h"
#include "develop/format.h"
#include "develop/imageop.h"
#include "develop/imageop_math.h"
static void color_picker_helper_4ch_seq(const dt_iop_buffer_dsc_t *dsc, const float ... | [dt_color_picker_helper->[color_picker_helper_bayer,dt_unreachable_codepath,color_picker_helper_4ch,color_picker_helper_xtrans],void->[fmaxf,free,color_picker_helper_xtrans_seq,color_picker_helper_bayer_parallel,FCxtrans,malloc,color_picker_helper_4ch_seq,color_picker_helper_bayer_seq,dt_get_num_threads,color_picker_he... | Color picker helper for 4 - channel mode. | const dt_iop_colorspace_type_t cst_to |
@@ -75,6 +75,8 @@ func defaultConfig() config {
IgnoreMissing: true,
OverwriteKeys: false,
RestrictedFields: false,
+ HostPath: "/",
+ CgroupPrefixes: []string{"/kubepods", "/docker"},
}
}
| [getMappings->[Wrapf,Flatten,GetValue,Errorf,Put],DeepUpdate] | getMappings returns a mapping from the config to the actual field names. | @andrewkroh What's your opinion on adding a default for `MatchPIDs: []string{"process.pid", "process.ppid"}`? |
@@ -479,8 +479,7 @@ class QAT_Quantizer(Quantizer):
quant_start_step = config.get('quant_start_step', 0)
assert weight_bits >= 1, "quant bits length should be at least 1"
- # we dont update weight in evaluation stage
- if quant_start_step > self.bound_model.steps:
+ if quant_sta... | [LsqQuantizer->[__init__->[get_bits_length],quantize_input->[quantize],quantize->[round_pass,grad_scale],quantize_weight->[quantize],export_model->[_del_simulated_attr],quantize_output->[quantize]],QAT_Quantizer->[quantize_weight->[get_bits_length,_quantize,_dequantize,update_quantization_param],quantize_input->[get_bi... | quantize weight of a node. | what is the difference between `copy_` and assignment directly? |
@@ -124,10 +124,9 @@ func resourceAwsApiGatewayV2Integration() *schema.Resource {
Optional: true,
},
"timeout_milliseconds": {
- Type: schema.TypeInt,
- Optional: true,
- Default: 29000,
- ValidateFunc: validation.IntBetween(50, 29000),
+ Type: schema.TypeInt,
+ Optio... | [StringLenBetween,GetChange,GetIntegration,UpdateIntegration,BoolValue,StringInSlice,Set,GetOk,HasChange,Errorf,SetId,CreateIntegration,IntegrationType_Values,Id,Int64,Get,Split,Printf,ContentHandlingStrategy_Values,StringValue,PassthroughBehavior_Values,String,IntBetween,ConnectionType_Values,DeleteIntegration] | This is a utility function to create a resource with a specific version of the API. CreateIntegrationRequest creates an integration request from the given parameters. | Removed `ValidateFunc` as there's no way of making it dependent on the API type and the range 29000 to 30000 is invalid for WebSocket APIs. |
@@ -1056,11 +1056,10 @@ def validate_meta(meta: Optional[CacheMeta], id: str, path: Optional[str],
# TODO: Share stat() outcome with find_module()
path = os.path.abspath(path)
- # TODO: Don't use isfile() but check st.st_mode
- if not os.path.isfile(path):
+ st = manager.get_stat(path) # TODO: Err... | [find_modules_recursive->[BuildSource,find_module,find_modules_recursive],process_graph->[add_stats,trace,log],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_priority],get_stat->[maybe_swap_for_shadow_path],report_file->[is_source]],maybe_reuse_in_memory_tree->[add_stats,trace],load_plugins->[plug... | Validates the given meta object and returns the original meta if the AST is unusable. Returns a object if the file has the same size and hash as the last found object. | What about adding a `is_file` method to `BuildManager` instead and using it here? |
@@ -240,13 +240,13 @@ if ( get_option( 'page_comments' ) && $options['ignore_page_comments'] === false
</div>
<div id="security" class="wpseotab">
<?php
- echo '<p>', __( 'Advanced part of the meta box allows authors and editors to redirect posts, noindex them and do other things you might not want if you don\'... | [admin_header,media_input,textinput,toggle_switch,admin_footer,light_switch,select] | Displays a hidden part of the meta box that allows the user to verify with the different Web Show the administration area for the n - ary meta box. | I guess `These are thing` should be `These are things` |
@@ -112,6 +112,9 @@ public class AzkabanJobLauncher extends AbstractJob implements ApplicationLaunch
private static final String AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "gobblin.azkaban.SLAInSeconds";
private static final String DEFAULT_AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS = "-1"; // No SLA.
+ public static final S... | [AzkabanJobLauncher->[stop->[stop],cancelJob->[cancelJob],close->[close],start->[start],launchJob->[launchJob]]] | The launcher for Azkaban jobs. This method is called from the Azkaban site code to configure the root metric context. | The property above uses "gobblin.azkaban" prefix. Should we use the same prefix here? |
@@ -124,6 +124,18 @@ public class SdkComponentsTest {
equalTo(windowingStrategies.size()));
} else {
transforms.add(node);
+ if (PTransformTranslation.COMBINE_TRANSFORM_URN.equals(
+ PTransformTranslation.urnForTransformOrNull(node.getTransfor... | [SdkComponentsTest->[registerCoderEqualsNotSame->[registerCoder],translatePipeline->[addCoders->[addCoders],translatePipeline],registerPCollection->[registerPCollection],registerPCollectionExistingNameCollision->[registerPCollection],registerWindowingStrategyIdEqualStrategies->[registerWindowingStrategy],registerWindow... | This method is used to translate a pipeline to a pipeline that is built from a single pipeline Add a node to the list of possible collisions. | Shouldn't `CombinePayloadTranslator.translate` have the ability to get coders where they need to be? |
@@ -86,6 +86,9 @@ public class ForkingClusterInvoker<T> extends AbstractClusterInvoker<T> {
URL consumerUrl = RpcContext.getServiceContext().getConsumerUrl();
executor.execute(() -> {
try {
+ if (ref.size() > 0) {
+ ... | [ForkingClusterInvoker->[doInvoke->[getMessage,size,checkInvokers,AtomicInteger,invokeWithContextAsync,clearAttachments,setInvokers,poll,select,offer,RpcException,incrementAndGet,getConsumerUrl,getCause,getCode,execute,getParameter,contains,add],getSharedExecutor]] | Invoke the given invocation with the given load - balance. if we have no luck in the invocation we have to clear the attachments. | Very good, but the concurrency problem must be taken into account. Suppose that 10 threads execute this step and judge size=0. At this time, multiple elements will still be stored in the queue. The size judgment can use the atomic class, like the previous `final AtomicInteger count = new AtomicInteger();` |
@@ -3,12 +3,13 @@ module OpenidConnect
def index
render json: {
jwks_uri: '', # TODO
- scopes_supported: '', # TODO
+ scopes_supported: OpenidConnectAttributeScoper::VALID_SCOPES,
response_types_supported: %w(code),
grant_types_supported: %w(authorization_code),
... | [ConfigurationController->[index->[merge,render]]] | Renders the index lease configuration. | This big response block seems ripe for a refactor out into a service or presenter or view of some kind. Not necessary for this particular PR, but that much code in a controller smells odd to me. |
@@ -255,7 +255,7 @@ class ClientRequest extends EventEmitter {
const key = name.toLowerCase()
this.extraHeaders[key] = value
- this.urlRequest.setExtraHeader(name, value)
+ this.urlRequest.setExtraHeader(name, value.toString())
}
getHeader (name) {
| [No CFG could be retrieved] | Create a middleware that can be used to set HTTP headers. Writes a chunk of data to the network. | Looking at line 249, we only check against undefined, which means `null` could get through to here and the error would be a bit confusing, maybe the `value === undefined` check could be updated to `value == null` since that is the check we typically use in lots of places. What do you think? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.