patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -77,6 +77,15 @@ abstract class CommandWithMeta extends \WP_CLI_Command {
/**
* Get meta field value.
*
+ * <id>
+ * : The ID of the object.
+ *
+ * <key>
+ * : The name of the meta field to get.
+ *
+ * [--format=<format>]
+ * : Accepted values: table, json. Default: table
+ *
* @synopsis <id> <k... | [CommandWithMeta->[list_->[display_items,check_object_id,get_fields],get->[check_object_id],update->[check_object_id],add->[check_object_id],delete->[check_object_id]]] | Gets metadata from a specific object. | Can you remove `@synopsis` ? Now that we have expanded docs here, it's no longer necessary. |
@@ -2616,7 +2616,7 @@ namespace System.Tests
#pragma warning restore IDE0043 // Format string contains invalid placeholder
}
- [Theory]
+ [ConditionalTheory]
[InlineData("Hello", 'l', 0, 5, 2)]
[InlineData("Hello", 'x', 0, 5, -1)]
[InlineData("Hello", 'l', 1, 4, 2)]
| [StringTests->[PadRight->[PadRight],IndexOfAny_InvalidCount_ThrowsArgumentOutOfRangeException->[IndexOfAny],IsNullOrEmpty->[IsNullOrEmpty],LastIndexOfSequenceZeroLengthValue_Char->[Length],ToLowerInvariant->[ToLowerInvariant,Length],SameValueCompareTo_StringComparison->[Compare],IndexOfAny_NullAnyOf_ThrowsArgumentNullE... | Tests that string format is invalid. Tests that the string is formatted in the format string. Best effort to find the nix sequence of bytes in a sequence of bytes. This function returns an array of the last 16 characters in a sequence of characters that are not Tests if two characters are in the string s. | Was this change intentional? Was it needed to support `SkipTestException`? (I can't easily find docs on this.) |
@@ -552,6 +552,10 @@ app.post('/get-consent-v1/', (req, res) => {
assertCors(req, res, ['POST']);
const body = {
'promptIfUnknown': true,
+ 'sharedDataPromise': {
+ 'tfua': true,
+ 'coppa': true,
+ },
};
res.json(body);
});
| [No CFG could be retrieved] | Middleware for the AMP response AJAX - AMP - AMP - AMP - AMP - AMP -. | `sharedDataPromise`? I thought we name it `sharedData`? |
@@ -377,7 +377,7 @@ class List(MutableSequence):
def copy(self):
return _copy(self)
- def index(self, item, start=None, stop=None):
+ def index(self, item: T, start=None, stop=None):
return _index(self, item, start, stop)
def sort(self, key=None, reverse=False):
| [_make_mutable->[_make_mutable],List->[_make_mutable->[_make_mutable],__gt__->[_gt],_make_immutable->[_make_immutable],_is_mutable->[_is_mutable],remove->[_remove],extend->[_extend,_initialise_list],__ge__->[_ge],sort->[_sort],__contains__->[_contains],pop->[_pop],copy->[_copy],__le__->[_le],count->[_count],clear->[_cl... | Returns a copy of the list with the object sorted. | Type annotations for `start` and `stop`? |
@@ -151,6 +151,12 @@ public class FunctionRegistry {
"EXTRACTJSONFIELD", JsonExtractStringKudf.class);
addFunction(getStringFromJson);
+ Schema array = SchemaBuilder.array(Schema.STRING_SCHEMA).build();
+ KsqlFunction jsonArrayContainsString = new KsqlFunction(
+ Schema.BOOLEAN_SCHEMA, ... | [FunctionRegistry->[init->[SumAggFunctionDeterminer,MinAggFunctionDeterminer,MaxAggFunctionDeterminer,addAggregateFunctionDeterminer,asList,CountAggFunctionDeterminer,addFunction,KsqlFunction],isAnAggregateFunction->[get],addAggregateFunctionDeterminer->[put],getFunction->[get],getAggregateFunction->[getProperAggregate... | Initialize functions. Adds functions to the functions list. | I have an issue registering my function passing arguments to it. I'm expecting that 'evaluate' method passes json string as first argment of the array, and the second argument is search value. |
@@ -534,14 +534,14 @@ void dt_accel_connect_lua(const gchar *path, GClosure *closure)
gtk_accel_group_connect_by_path(darktable.control->accelerators, accel_path, closure);
}
-void dt_accel_connect_manual(GSList *list, const gchar *full_path, GClosure *closure)
+void dt_accel_connect_manual(GSList **list_ptr, con... | [dt_accel_rename_lua->[dt_accel_register_lua,dt_accel_deregister_lua,dt_accel_connect_lua,dt_accel_path_lua],dt_accel_deregister_lib->[dt_accel_path_lib],dt_accel_register_manual->[dt_accel_path_manual],dt_accel_connect_button_iop->[dt_accel_connect_iop],dt_accel_register_lua->[dt_accel_path_lua],dt_accel_register_view... | Connects accelerators to the lighttable accelerators. | The result is assigned to a local variable, which is never read afterwards. `list` contains the list's new head. We need to inform the caller about the new head of the singly-linked list. |
@@ -332,6 +332,7 @@ def test_handle_block():
from_channel,
pseudo_random_generator,
new_block.block_number,
+ UNIT_CHAIN_ID,
)
assert iteration.new_state
assert not iteration.events
| [test_handle_block_lower_block_number->[make_target_state],test_handle_block_equal_block_number->[make_target_state],test_handle_block->[make_target_state],test_handle_secretreveal->[make_target_state]] | Test handle block. | why are you passing the chain_id as an argument for the target state machine? it should be available through the signed balance proof |
@@ -479,8 +479,11 @@ class _Kernel(serialize.ReduceMixin):
}
tgt_ctx = cres.target_context
+ filename = cres.type_annotation.filename
+ linenum = int(cres.type_annotation.linenum)
lib, kernel = tgt_ctx.prepare_cuda_kernel(cres.library, fname, args,
... | [CUDABackend->[__init__->[__init__]],CreateLibrary->[__init__->[__init__]],DeviceFunction->[__init__->[compile_cuda]],_Kernel->[launch->[load_symbol],_prepare_args->[_prepare_args],__init__->[compile_cuda]],compile_ptx->[compile_cuda],DeviceFunctionTemplate->[inspect_llvm->[compile],compile->[compile_cuda],inspect_ptx-... | Initialize a cuda function object. | It's weird that I have to get the source file name from the type annotation at this stage, but I think the function IR is now lost (it was never saved after the pipeline finished). |
@@ -3372,7 +3372,7 @@ namespace System.Text.RegularExpressions.Generator
RegexNode.Bol => "Match if at the beginning of a line.",
RegexNode.Boundary => $"Match if at a word boundary.",
RegexNode.Capture when node.N != -1 => $"{DescribeNonNegative(node.M)} capturing gro... | [RegexGenerator->[MatchCharacterClass->[UseToLowerInvariant,ToLower],DescribeNode->[Literal],DescribeExpression->[DescribeNode,DescribeExpression],ToLowerIfNeeded->[ToLower],EmitRegexMethod->[SupportsCodeGeneration],ToLower->[UseToLowerInvariant]]] | Describe a node with its type. Match a node with a message. | This should use the `Literal(...)` helper to output the `capName`. That not only handles adding the quotes, it ensures characters in the string are rendered appropriately for C# source. We also need to do a similar rendering for the case when node.N != -1, both for the capture group and the uncapture group. |
@@ -204,8 +204,8 @@ func (nc *NatsClient) ConnectAndPublish(msg *applications.HabService) error {
// order to configure TLS, we are responsible for closing it.
func (nc *NatsClient) Close() {
natsConn := nc.conn.NatsConn()
- nc.conn.Close()
- natsConn.Close()
+ nc.conn.Close() // nolint: errcheck
+ natsConn.Close(... | [tryConnect->[Connect],Close->[Close],ConnectAndPublish->[Connect],ConnectAndSubscribe->[Connect]] | Close closes the NATS connection and returns the TLS configuration. | This is usually used in a `defer` statement so best-effort is appropriate here. Plus the reason you probably fail is if the connection is closed already. |
@@ -100,7 +100,7 @@ std::array<array_1d<double,3>,2> ForceAndTorqueUtils::ComputeEquivalentForceAndT
// Check whether nodes have the torque variable and set the lambda accordingly.
// Note: multiple node types within the model part are not supported.
// In that case, this check would have to perfor... | [No CFG could be retrieved] | Returns the force and moment of the given node. - - - - - - - - - - - - - - - - - -. | FYI @matekelemen those checks easily fail in MPI when there are partitions that don't have locals nodes |
@@ -877,6 +877,7 @@ void kill_screen(const char* lcd_msg) {
float lcd_z_offset_edit() {
lcd_goto_screen(_lcd_z_offset_edit);
+ defer_return_to_status = true;
return Mesh_Edit_Value;
}
| [No CFG could be retrieved] | The main entry point for the functions that are used to edit the Mesh and Z - Offset This function is called if the system has a known number of watch temps and the system. | I removed these `defer_return_to_status = true` lines from cases like this one, where it's already jumping straight to a screen handler that already sets `defer_return_to_status = true`. |
@@ -796,7 +796,7 @@ function ParagraphCtrl ($scope, $rootScope, $route, $window, $routeParams, $loca
name: v.name,
value: v.value,
meta: v.meta,
- caption: computeCaption(v.value, v.meta),
+ caption: computeCaption(v.name, v.meta... | [No CFG could be retrieved] | function to get completions from the key word editor on - focus on - paste on - change on - paste on - change on - live. | Is this a bug fix ? |
@@ -0,0 +1,4 @@
+<?php
+$version = snmp_get($device, '.1.3.6.1.4.1.16744.2.45.1.2.2.0', '-Ovqs', '');
+$serial = snmp_get($device, '.1.3.6.1.4.1.16744.2.45.1.2.13.0', '-Ovqs', '');
+$hardware = snmp_get($device, '.1.3.6.1.4.1.16744.2.45.1.1.1.0', '-OQv', '');
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | Please, move this to `LibreNMS/OS/Bdos.php` Take another one as example on how to discover that info. Also, instead 3 snmp_get, use `snmp_get_multi` |
@@ -3890,6 +3890,9 @@ namespace System
void System.Runtime.Serialization.ISerializable.GetObjectData(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public string ToSerializedString() { throw null; }
public override string ToStri... | [No CFG could be retrieved] | This class is used to provide a way to retrieve the offset of the time zone. | Why isn't `out string windowsId` nullable? Should it be `out string? windowsId` to match `TryConvertWindowsIdToIanaId`? It also looks like this doesn't match the src file. |
@@ -385,7 +385,7 @@ class Optimizer(object):
def _valid_dtypes(self):
"""Valid types for loss, variables and gradients.
- Defaults to `float32`. Subclasses should override to allow other types.
+ Subclasses should override to allow other types.
Returns:
Valid types for loss, variables and ... | [Optimizer->[_get_or_make_slot->[_slot_dict],_zeros_slot->[_slot_dict]]] | Valid types for loss variables and gradients. | Would it be more informative but still correct to say "types other than floats"? |
@@ -99,7 +99,9 @@ describe('iframe-helper', function() {
});
});
- it('should un-listen on next message when iframe is unattached', () => {
+ // TODO(mkhatib): Figure out why this fails. Probably have to do with removing
+ // the iframes in _init_tests (#3314).
+ it.skip('should un-listen on next message ... | [No CFG could be retrieved] | Checks that the message is listen to iframe messages and un - listen on other messages. It should set sentinel on postMessage data. | Put issue number instead of your name :) |
@@ -633,6 +633,10 @@ namespace System.Runtime.InteropServices
get
{
Debug.Assert(VariantType == VarEnum.VT_BSTR);
+ if (_typeUnion._unionTypes._bstr == IntPtr.Zero)
+ {
+ return null;
+ }
return (... | [Variant->[Clear->[VT_BYREF,VT_VARIANT,VT_DISPATCH,VariantClear,VT_UNKNOWN,VT_EMPTY,VT_BSTR,Assert,VT_RECORD,VT_ARRAY],ToObject->[VT_UI4,Value,VT_INT,VT_UINT,VT_I4,VT_DATE,VT_UI1,VT_I2,VT_ERROR,VT_UNKNOWN,VT_R8,VT_CY,VT_I1,VT_I8,VT_DECIMAL,VT_BSTR,VT_BOOL,GetObjectForNativeVariant,VT_R4,VT_DISPATCH,VT_NULL,VT_UI2,VT_UI... | Replies the values of the nanomon field. Replies the object of the type union. | Feel free to update the property to `public string? AsBstr` |
@@ -86,6 +86,7 @@ public final class FingerprintCleanupThread extends AsyncPeriodicWork {
listener.getLogger().println("Cleaned up "+numFiles+" records");
}
+
/**
* Deletes a directory if it's empty.
*/
| [FingerprintCleanupThread->[accept->[matches,length,isFile,isDirectory],getInstance->[get],invoke->[run],check->[trim,_getFingerprint,error,println,getHashString,isAlive,printStackTrace,load,delete],deleteIfEmpty->[list,delete],execute->[println,listFiles,check,File,deleteIfEmpty,getRootDir],FileFilter,compile]] | Execute the check. | nit: I would try to avoid adding newlines unless it is directly adjacent to new code. |
@@ -80,6 +80,7 @@ namespace System.Globalization
// Start by assuming the windows name will be the same as the specific name since windows knows
// about specifics on all versions. Only for downlevel Neutral locales does this have to change.
_sWindowsName = realNameBuffer;
+ ... | [CultureData->[LCIDToLocaleName->[LCIDToLocaleName]]] | Initialize the culture - specific data structures. Private methods. | >CultureInfo.GetUserDefaultLocaleName(); [](start = 52, length = 39) should we use the cached value s_userDefaultLocaleName instead? I think we shouldn't call the OS every time we create a culture. |
@@ -55,6 +55,11 @@ public abstract class TimelineLayout implements Serializable {
public Stream<HoodieInstant> filterHoodieInstants(Stream<HoodieInstant> instantStream) {
return instantStream;
}
+
+ @Override
+ public Stream<HoodieInstant> sortHoodieInstants(Stream<HoodieInstant> instantStream) {... | [TimelineLayout->[getLayout->[get],TimelineLayoutV1->[filterHoodieInstants->[get,map]],TimelineLayoutVersion,TimelineLayoutV0,put,TimelineLayoutV1]] | Filter Hoodie instants. | This could be the default implementation in TimelineLayout. |
@@ -35,6 +35,7 @@ import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.Objects;
import java.util.Properties;
+
/*[IF Sidecar19-SE]*/
import jdk.internal.vm.VMSupport;
/*[ELSE] Sidecar19-SE
| [Attachment->[doCommand->[streamReceiveBytes,getMessage,logMessage,startAgent,startLocalAgent,streamSend,parseLoadAgent,receiveProperties,bytesToString,toString,internalGetProperties,ByteArrayInputStream,startsWith,getAgentProperties,replyWithProperties],connectToAttacher->[getMessage,Socket,getPort,logMessage,getOutpu... | This class is used to handle a single availability set exception. commandStream - The command stream. | Why _two_ blank lines here? |
@@ -72,6 +72,8 @@ public class RemoteInterpreterEventPoller extends Thread {
@Override
public void run() {
Client client = null;
+ AppendOutputRunner.setListener(listener);
+ CheckAppendOutputRunner.startScheduler();
while (!shutdown) {
// wait and retry
| [RemoteInterpreterEventPoller->[getResource->[getByInterpreterGroupId,getMessage,error,getName,getResourcePool,releaseClient,resourceGet,deserializeObject,get,getParagraphId,getClient,isRunning,getResourcePoolId,getNoteId,getRemoteInterpreterProcess],sendResourcePoolResponseGetAll->[getMessage,error,toJson,Gson,resourc... | This method is run in a loop. This method is called when an angular object is received from the remote interpreter. on output update. | Having a static setter does not look good to me - it hides the state which is hard to mock and test. Would it be possible to have an instance of `AppendOutputRunner` here instead please? |
@@ -0,0 +1,3 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+# vim: tabstop=8 expandtab shiftwidth=4 softtabstop=4
| [No CFG could be retrieved] | No Summary Found. | Hi @SSE4 Please try to avoid adding this ``vim``-only line to all the files. |
@@ -255,8 +255,16 @@ def find_parent_shell(path=False):
# "To proceed, please conda install psutil")
return None
process = psutil.Process()
- while "conda" in process.parent().name():
- process = process.parent()
+ pname = process.parent().name().lower()
+ while any(proc ... | [cygwin_path_to_win->[unix_path_to_win],win_path_to_cygwin->[win_path_to_unix],can_open_all_files_in_prefix->[can_open_all],can_open_all->[can_open],yaml_dump->[get_yaml],yaml_load->[get_yaml],md5_file->[hashsum_file]] | find parent shell. Default is to return only name of process. | I added this `return None` here, right above. I'm guessing you don't want that in this function now, correct? |
@@ -42,7 +42,7 @@ import shutil
import sys
import urllib.parse
import urllib.request
-import xml.etree.ElementTree as ET
+import xml.etree.ElementTree as ET # nosec - disable B405:import-xml-etree check
from pathlib import Path
| [add_model_pages->[add_page,sort_titles],add_accuracy_checker_pages->[add_page,sort_titles],main->[add_model_pages,add_page,sort_titles,add_accuracy_checker_pages],main] | This script prepares the OMZ documentation for inclusion into the OpenVINO toolkit. Add a page to the output tree. | The recommendation here is to replace `xml.etree.ElementTree` with the equivalent `defusedxml` package. However, the `defusedxml` doesn't contain `Element` and `SubElement` classes or equivalent one, therefore this replacement would require changes in `add_page` implementation. For now the implementation with `xml.etre... |
@@ -124,8 +124,8 @@ def h2o_r2_score(y_actual, y_predicted, weights=1.):
:returns: R-squared (best is 1.0, lower is worse).
"""
ModelBase._check_targets(y_actual, y_predicted)
- numerator = (weights * (y_actual - y_predicted) ** 2).sum()
- denominator = (weights * (y_actual - _colmean(y_actual)) **... | [H2ORegressionModel->[_make_model->[H2ORegressionModel]],h2o_explained_variance_score->[_mean_var]] | H2O R2 score regression. | this score method was **always** returning `1.0` (that's how we cheat on benchmarks..) as `numerator` and `denominator` were still frames when the logic below expected numbers.. |
@@ -166,9 +166,11 @@ public class TestReconUtils {
}
});
- InputStream inputStream = new ReconUtils()
- .makeHttpCall(httpClientMock, url);
- String contents = IOUtils.toString(inputStream, Charset.defaultCharset());
+ String contents;
+ try (InputStream inputStream = new ReconUtils()
+... | [TestReconUtils->[testMakeHttpCall->[read->[read]]]] | This method will test the last known DB. This method writes the contents of the file3 to the file3 and checks if there is. | Can we modify the unit test to test the new makeHttpCall API? |
@@ -1221,11 +1221,13 @@ def create_unlock(
locksroot = merkleroot(merkletree)
token_address = channel_state.token_address
- nonce = get_next_nonce(our_state)
recipient = channel_state.partner_state.address
# the lock is still registered
locked_amount = TokenAmount(get_amount_locked(our_sta... | [get_current_balanceproof->[get_amount_locked],register_secret_endstate->[is_lock_locked],handle_block->[is_deposit_confirmed,get_status],send_refundtransfer->[get_status,create_sendlockedtransfer],lock_exists_in_either_channel_side->[get_lock],get_batch_unlock_gain->[UnlockGain],is_valid_refund->[valid_lockedtransfer_... | Create a unlock and merkle tree for a given lock. | `create` functions should not change the state of the objects, please move this to the `send_` |
@@ -467,9 +467,10 @@ module Engine
end
@nodes = @paths.flat_map(&:nodes).uniq
- @branches = @paths.flat_map(&:branches).uniq
@stops = @paths.flat_map(&:stops).uniq
@edges = @paths.flat_map(&:edges).uniq
+
+ @edges.each { |e| e.tile = self }
end
end
end
| [Tile->[compute_city_town_edges->[compute_loc],add_reservation!->[add_reservation!],from_code->[decode],paths->[rotate],restore_borders->[restore_borders],paths_are_subset_of?->[rotate]]] | Separate parts into groups of parts with a single . | did this not work previously? |
@@ -82,7 +82,12 @@ public class RealtimeManager implements QuerySegmentWalker
DataSchema schema = fireDepartment.getDataSchema();
final FireChief chief = new FireChief(fireDepartment);
- chiefs.put(schema.getDataSource(), chief);
+ List<FireChief> chiefsOfDataSource = chiefs.get(schema.getData... | [RealtimeManager->[start->[start],getMetrics->[getMetrics],FireChief->[close->[close],getQueryRunner->[getQueryRunner],getMetrics]]] | Start the lifecycle of the fire chief. | can we just call this chiefs? |
@@ -3722,12 +3722,12 @@ ds_pool_update(uuid_t pool_uuid, crt_opcode_t opc,
int rc;
char *env;
- /* Convert target address list to target id list */
rc = pool_find_all_targets_by_addr(pool_uuid, list, &target_list,
- out_list, hint);
+ out_list, hint);
if (rc)
D_GOTO(out, rc);
+ D_INFO("cal... | [No CFG could be retrieved] | This function updates the in the pool. Updates the specified target id in the pool. | DAOS coding style wants the second line aligned with the opening params. Should revert. |
@@ -24,7 +24,8 @@ class AllenNlpTestCase(TestCase): # pylint: disable=too-many-public-methods
def setUp(self):
logging.basicConfig(format='%(asctime)s - %(levelname)s - %(name)s - %(message)s',
- level=logging.DEBUG)
+ level=logging.INFO)
+ l... | [AllenNlpTestCase->[ensure_model_can_train_save_and_load->[forward,BasicIterator,data_iterator,keys,assert_allclose,model_predictions,arrays_to_variables,backward,load_state_dict,loaded_model_predictions,state_dict,save,next,load,zero_grad],get_trainer_params->[Params,items],tearDown->[rmtree],setUp->[log_pytorch_versi... | Setup logging and tear down. | Is there a good reason to do this? I find it helpful to have all the output. |
@@ -2,6 +2,7 @@
# Forked from https://github.com/fatiherikli/nginxparser (MIT Licensed)
import copy
import logging
+import six
from pyparsing import (
Literal, White, Forward, Group, Optional, OneOrMore, QuotedString, Regex, ZeroOrMore, Combine)
| [RawNginxParser->[as_list->[parse]],loads->[RawNginxParser],dumps->[RawNginxDumper],load->[loads],RawNginxDumper->[__iter__->[__iter__]],UnspacedList->[__deepcopy__->[UnspacedList],__setitem__->[__setitem__,_coerce],append->[append,_coerce],_coerce->[UnspacedList],__init__->[UnspacedList,__init__],__add__->[extend],ext... | A class that parses nginx configuration with pyparsing. Create a grammar for a list of possible blocks. | nit: According to our style guides, import should be in three groups: 1. Standard library imports 2. Third party imports 3. Application specific imports `six` falls in category two along with `pyparsing` so we should move this import down there. |
@@ -11,6 +11,10 @@ class Select extends QueryBuilder {
* {@inheritdoc}
*/
public static function fromTable($table, $alias = null) {
+ if (!$alias) {
+ $alias = 'master';
+ }
+
$connection = _elgg_services()->db->getConnection('read');
$qb = new static($connection);
| [Select->[fromTable->[getConnection,from]]] | Create a new QueryBuilder object from a table. | why not default in the function params? (eg. `$alias = 'master'`) |
@@ -6115,7 +6115,8 @@ spa_vdev_attach(spa_t *spa, uint64_t guid, nvlist_t *nvroot, int replacing)
/*
* Make sure the new device is big enough.
*/
- if (newvd->vdev_asize < vdev_get_min_asize(oldvd))
+ vdev_t *min_vdev = raidz ? oldvd->vdev_child[0] : oldvd;
+ if (newvd->vdev_asize < vdev_get_min_asize(min_vdev)... | [No CFG could be retrieved] | returns an object of type noflag if the given node has a hot spare finds the vdev in the new root and adds it to the list of vdev. | This is my ignorance about the internals here, but: is that guaranteed to be the smallest device in a raidz? It is possible to have, as an example, a raidz with four 1TB drives, and one 8TB drive. |
@@ -43,13 +43,12 @@ class ACRExchangeClient(object):
if not endpoint.startswith("https://") and not endpoint.startswith("http://"):
endpoint = "https://" + endpoint
self._endpoint = endpoint
- self.credential_scope = kwargs.get("authentication_scope", "https://management.core.windo... | [ACRExchangeClient->[close->[close],__exit__->[__exit__],__enter__->[__enter__],__init__->[ExchangeClientAuthenticationPolicy]]] | Initialize a new container registry. | should this be a private attr? |
@@ -12,6 +12,8 @@ from msrest import Serializer, Deserializer
from typing import TYPE_CHECKING
import warnings
+# FIXME: have to manually reconfigure import path for multiapi operation mixin
+from .._lro import AnalyzeBatchActionsLROPoller, AnalyzeBatchActionsLROPollingMethod
from azure.core.exceptions import Clie... | [TextAnalyticsClientOperationsMixin->[health_status->[health_status],key_phrases->[key_phrases],begin_health->[begin_health],begin_cancel_health_job->[begin_cancel_health_job],begin_analyze->[begin_analyze],sentiment->[sentiment],entities_linking->[entities_linking],entities_recognition_general->[entities_recognition_g... | Get an analysis status and results. The number of elements to skip in the response. | can ignore all of the generated files |
@@ -84,11 +84,11 @@ final class AddFormatListener
return;
}
- throw $this->getNotAcceptableHttpException($mimeType);
+ throw $this->getNotAcceptableHttpException($mimeType ?? $requestFormat);
}
// Finally, if no Accept header nor Symfony request ... | [AddFormatListener->[addRequestFormats->[setFormat],onKernelRequest->[populateMimeTypes,getMimeType,getFormat,getNotAcceptableHttpException,get,getBest,getType,has,getRequest,addRequestFormats,setRequestFormat,getRequestFormat]]] | Tries to guess the format based on the Accept header. If it is not available it will. | `$requestAcceptedFormats` right? This should be covered by a test (because the error isn't caught now) |
@@ -156,8 +156,8 @@ public class DeduceFlattenLocationsFunction
// Find all predecessor and successor locations for every flatten.
for (Node flatten : flattens) {
- AggregatedLocation predecessorLocations = AggregatedLocation.NEITHER;
- AggregatedLocation successorLocations = AggregatedLocation.NE... | [DeduceFlattenLocationsFunction->[getConnectedNodeLocations->[getConnectedNodeLocations],IsFlatten->[IsFlatten]]] | This method is called to apply a filter to a network. | Please combine these two lines with the next two lines |
@@ -972,9 +972,7 @@ def test_bvct_dig_montage_old_api(): # XXX: to remove in 0.20
test_raw_bv.info['chs']):
assert_equal(ch_raw['ch_name'], ch_test_raw['ch_name'])
assert_equal(ch_raw['coord_frame'], FIFF.FIFFV_COORD_HEAD)
- assert_allclose(ch_raw['loc'], ch... | [test_dig_dev_head_t_regression->[_read_dig_montage],test_heterogeneous_ch_type->[_make_toy_dig_montage],test_montage_when_reading_and_setting->[_fake_montage],test_set_montage_with_sub_super_set_of_ch_names->[_make_toy_dig_montage],test_set_montage_coord_frame_in_head_vs_unknown->[_make_toy_dig_montage,_make_toy_raw,_... | Test BrainVision CapTrak XML dig montage support. Test reading a captrack file and return a tuple of the last known header. Checks if a single chunk of a Brainvision file has a specific chunk of data. | I would `pop` the one from the list that we have that MNE-C does not, then still call this. It makes the test more complete and explicit about why it's not `allclose` otherwise |
@@ -393,6 +393,10 @@ public final class OzoneConfigKeys {
"ozone.s3.token.max.lifetime";
public static final String OZONE_S3_AUTHINFO_MAX_LIFETIME_KEY_DEFAULT = "3m";
+ public static final String OZONE_FS_ITERATE_BATCH_SIZE =
+ "ozone.fs.iterate.batch-size";
+ public static final int OZONE_FS_ITERATE... | [OzoneConfigKeys->[getValue,toString,name,valueOf]] | This class is used to determine the default values for the client. PRIVATE METHODS. | Will this property be used for batch rename too? |
@@ -128,7 +128,7 @@ namespace System
public static int WindowLeft
{
- get => throw new PlatformNotSupportedException();
+ get => 0;
set => throw new PlatformNotSupportedException();
}
| [ConsolePal->[Unicode],LogcatStream->[Write->[GetString,Info,AndroidLogPrint],Read->[GetReadNotSupported],Write]] | MoveBufferArea moves the buffer area to the specified position. | WindowTop can be aligned the same way. |
@@ -336,7 +336,13 @@ namespace System.Net.Http
// Don't send a RST_STREAM if we've already received one from the server.
if (_resetException == null)
{
- _connection.LogExceptions(_connection.SendRstStreamAsync(StreamId, Http2ProtocolErrorCode.Cancel... | [No CFG could be retrieved] | A blocking function that waits for a response from the server to complete. Cancels a specific token. | We definitely don't want to do this as it will result in lock re-entrancy, which is bad. That's why we generally do `Debug.Assert(!Monitor.IsEntered(SyncObject));` before taking the lock. Instead we should ensure callers hold the lock around calling this routine. We may need to do this anyway in order to prevent races ... |
@@ -99,6 +99,10 @@ public class NetworkOfferingResponse extends BaseResponse {
@Param(description = "true if network offering can be used by VPC networks only")
private Boolean forVpc;
+ @SerializedName(ApiConstants.FOR_TUNGSTEN)
+ @Param(description = "true if network offering can be used by tungsten... | [No CFG could be retrieved] | The list of supported services and network offerings. Replies if the domain supports public access. | Another example of "tungsten" used in end user docs vs "tungsten fabric" |
@@ -168,6 +168,7 @@ static const char *HINTS[15] =
static int CLOCK_DRIFT = 3600; /* 1hr */
static int ACTIVE_THREADS;
+static int EXITNOW = 0;
int CFD_MAXPROCESSES = 0;
int NO_FORK = false;
| [No CFG could be retrieved] | The main entry point for the system. region Item methods. | Perhaps a stupid question, but have you considered IsPendingTermination()? |
@@ -55,6 +55,12 @@ public class PaneInfoTracker {
state.access(PANE_INFO_TAG).clear();
}
+ @SuppressFBWarnings(value = "RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT",
+ justification = "prefetch side effect")
+ public void prefetchPaneInfo(ReduceFn<?, ?, ?, ?>.Context context) {
+ context.state().access(P... | [PaneInfoTracker->[getNextPaneInfo->[read->[read],readLater->[readLater]],clear->[clear]]] | Clear the state. | Curious - can this annotation be added to `readLater()` so it applies universally? That would really be nice. |
@@ -11,6 +11,7 @@ namespace System.Diagnostics.Tests
{
[Trait(XunitConstants.Category, "EventLog")] // Unreliable Win32 API call
[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/36135", TestPlatforms... | [EventLogSourceCreationTests->[LogNameWithSame8FirstChars_NetFramework->[True,CreateEventSource,nameof,NetFramework,DeleteEventSource,Category,Delete,Assert,SourceExists,Retry,IsElevatedAndSupportsEventLogs],CategoryResourceFile_Set->[SupportsEventLogs,CategoryResourceFile,Equal,nameof],ParameterResourceFile_Set->[Supp... | Check if EventLog source existence and deletion. | @Anipik was the intention for this trait to be ignored on CI and regular runs? If so we should change it to "IgnoreForCI" |
@@ -302,4 +302,8 @@ public class CuratedApplication implements Serializable, Closeable {
baseRuntimeClassLoader.close();
}
}
+
+ public AppModelResolver getAppModelResolver() {
+ return quarkusBootstrap.getAppModelResolver();
+ }
}
| [CuratedApplication->[createRuntimeClassLoader->[isHotReloadable],getAugmentClassLoader->[addCpElement,processCpElement],hasUpdatedDeps->[hasUpdatedDeps],close->[close],getBaseRuntimeClassLoader->[addCpElement,processCpElement]]] | Close the classes that are not in the hierarchy. | Is this actually used anywhere? |
@@ -216,7 +216,7 @@ public class RouteOnAttribute extends AbstractProcessor {
}
if (destinationRelationships.isEmpty()) {
- logger.info(this + " routing " + flowFile + " to unmatched");
+ logger.info("{} routing {} to unmatched", new Object[]{ this, flowFile });
fl... | [RouteOnAttribute->[onTrigger->[getValue,isDynamic,size,addAll,info,put,getProperty,getKey,isEmpty,transfer,hasNext,asBoolean,route,iterator,entrySet,next,getName,build,getLogger,get,clone,putAttribute,add,keySet],init->[add,unmodifiableList],getRelationships->[get],getSupportedDynamicPropertyDescriptor->[build],onProp... | onTrigger - This method is called when a trigger is triggered. Get all the clones for any remaining relationships and transfer them to the first one. | We should just remove the 'this' all together because the ProcessorLogger will automatically prepend it for us anyway. |
@@ -363,6 +363,13 @@ class ProductForm(MoneyModelForm, AttributesMixin):
)
return seo_description
+ def clean_is_published(self):
+ is_published = self.cleaned_data["is_published"]
+ category = self.data["category"]
+ if not category and is_published:
+ raise Valid... | [ProductForm->[save->[save_attributes],__init__->[prepare_fields_for_attributes],make_money_field,RichTextField],ProductVariantForm->[save->[save,save_attributes],__init__->[prepare_fields_for_attributes],make_money_field],ReorderProductImagesForm->[save->[save]],ReorderAttributeValuesForm->[save->[save]],VariantBulkDe... | Return the seo description of the object. | We also need to add this rule in API. Two inputs that use this fields are `ProductCreateInput` and `ProductInput` and mutations that use them should behave similarly. |
@@ -126,7 +126,7 @@ class AutoloadJsConsumer(SessionConsumer):
resources = self.resources(server_url) if resources_param != "none" else None
bundle = bundle_for_objs_and_resources(None, resources)
- render_items = [RenderItem(sessionid=session.id, elementid=element_id, use_for_title=False)]
+... | [AutoloadJsConsumer->[handle->[resources,_get_session,get_argument]],ConsumerHelper->[resources->[resources]],AsyncServerConnection->[send_patch_document->[_send_bokeh_message]],WSConsumer->[connect->[get_argument],receive->[handle]],DocConsumer->[handle->[resources,_get_session]]] | Handle the request and return a javascript file. | @philippjfr are any additional changes needed here? (for headers?) I am really not at all familiar with the django code yet |
@@ -24,12 +24,14 @@ import java.util.Collection;
import java.util.Map;
import org.apache.commons.lang3.StringUtils;
+import org.apache.gobblin.cluster.GobblinClusterUtils;
import org.apache.gobblin.util.ConfigUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileStatus;
import org.... | [YarnHelixUtils->[addFileAsLocalResource->[getName,getModificationTime,setType,getLen,getFileStatus,setResource,newRecord,setVisibility,put,setSize,setTimestamp,getYarnUrlFromPath],writeTokenToFile->[Credentials,getService,addToken,writeTokenStorageFile],readTokensFromFile->[getAllTokens],setAdditionalYarnClassPath->[g... | Imports a single object. A utility class for Gobblin on Yarn. | This looks like an unused import. |
@@ -132,6 +132,12 @@ public class QuarkusBuild extends QuarkusTask {
final AppArtifact appArtifact = extension().getAppArtifact();
final AppModelResolver modelResolver = extension().resolveAppModel();
+ try {
+ // this needs to be done otherwise the app artifact doesn't get a prope... | [QuarkusBuild->[setIgnoredEntries->[addAll],getTransformedClassesDirectory->[File,transformedClassesDirectory],buildQuarkus->[getValue,getProperties,runTask,getProperty,build,lifecycle,clearProperty,getKey,getAppArtifact,resolveAppModel,Properties,setProperty,getArtifactId,getVersion,GradleException,startsWith,entrySet... | Build the quarkus. | Ah, ok, then modelResolver.resolve(appArtifact) should be enough. Resolving the model resolves all the deps + all the deployment deps, which is a waste in this case. |
@@ -980,7 +980,7 @@ function $HttpProvider() {
function done(status, response, headersString) {
if (cache) {
if (isSuccess(status)) {
- cache.put(url, [status, response, parseHeaders(headersString)]);
+ cache.put(url, [status, copy(response), parseHeaders(headersString)]... | [No CFG could be retrieved] | The default cache is the cache that the request will be sent to if there is no response This function build a url from params and url if it exists. | all the changes in this file should be a separate commit. I like this change but it is not related to the changes to in $resource |
@@ -51,11 +51,12 @@ class SparkBeamMetric implements Metric {
}
for (MetricResult<DistributionResult> metricResult : metricQueryResults.getDistributions()) {
DistributionResult result = metricResult.getAttempted();
- metrics.put(renderName(metricResult) + ".count", result.getCount());
- metri... | [SparkBeamMetric->[renderAll->[getValue,getMin,getDistributions,getGauges,value,asAttemptedOnlyMetricResults,getAttempted,allMetrics,getCounters,getMean,renderName,getCount,put,getSum,getMax],renderName->[replaceAll,metricName,toList,endsWith,getKey,stepName,substring,addAll,collect,add,join,length]]] | Renders all metrics. | I'd personally prefer single metric, possibly with `.distribution` suffix, which could include all 5 stats (count, sum, min, max, mean), it would definitely be more readable in Spark UI |
@@ -182,9 +182,9 @@ def build(sources: List[BuildSource],
if alt_lib_path:
lib_path.insert(0, alt_lib_path)
- # TODO Reports is global to a build manager but only supports a single "main file"
- # Fix this.
- reports = Reports(sources[0].effective_path, data_dir, report_dirs)
+ reports = Rep... | [SemanticallyAnalyzedFile->[process->[switch_state,info,type_checker]],PartiallySemanticallyAnalyzedFile->[process->[switch_state,semantic_analyzer_pass3,info]],State->[is_ready->[module_state,earlier_state],fail->[errors],info->[StateInfo],module_not_found->[errors]],UnprocessedFile->[import_module->[has_module,Unproc... | Builds a single module by using a sequence of sources. This function is called by the build manager to perform the build of a single missing file. | This still perpetuates the import cycle, doesn't it? |
@@ -39,13 +39,15 @@
.elgg-icon-cell-phone {
background-position: 0 -108px;
}
-.elgg-icon-checkmark:hover {
+.elgg-icon-checkmark:hover,
+a:focus > .elgg-icon-checkmark {
background-position: 0 -126px;
}
.elgg-icon-checkmark {
background-position: 0 -144px;
}
-.elgg-icon-clip:hover {
+.elgg-icon-clip:hover,
+... | [No CFG could be retrieved] | Displays a list of icons that define a single critical number. Displays a list of icons that can be used to show a specific item in the menu. | Any reason to restrict this to anchor tags? |
@@ -76,12 +76,12 @@ class Thumbnail extends Component {
// silence (& not even comfort noise).
// 2. The audio is local. If we were to render local audio, the local
// participants would be hearing themselves.
- const audioMuted = !audioTrack || audioTrack.muted;
- const r... | [No CFG could be retrieved] | Creates a new Video Thumbnail component. Handles click on the thumbnail of a . | Side though: Is this one of those cases where too much is being passed in? It seems like _largeVideo doesn't need to be passed in. |
@@ -57,7 +57,7 @@ module ArticlesHelper
timestamp&.utc&.iso8601
end
- def active_threads(**options)
- Articles::ActiveThreadsQuery.call(**options)
+ def active_threads(...)
+ Articles::ActiveThreadsQuery.call(...)
end
end
| [image_tag_or_inline_svg_tag->[image_tag,inline_svg_tag,internal_navigation?],should_show_crossposted_on?->[crossposted_at,published,published_from_feed,canonical_url,present?,published_at],should_show_updated_on?->[next_day,edited_at,published_from_feed,published],get_host_without_www->[nil?,gsub!,delete_prefix,downca... | Returns an object that can be used to find a record in the system by UTC. | This makes use of kwargs forwarding, to minimize indirection. |
@@ -19,11 +19,9 @@ public class LocalPlayers {
}
public boolean playing(final PlayerID id) {
- return id != null
- && localPlayers.stream()
- .anyMatch(gamePlayer -> isGamePlayerWithPlayerId(gamePlayer, id));
+ return id != null && localPlayers.stream().anyMatch(gamePlayer -> isGamePlaye... | [LocalPlayers->[isGamePlayerWithPlayerId->[getClass,isAssignableFrom,equals],playing->[anyMatch,isGamePlayerWithPlayerId],getLocalPlayers->[unmodifiableSet]]] | Checks if a game player is playing with a specific player id. | There should be a line break after `localPlayers.stream()` |
@@ -13,6 +13,8 @@ import ClassicEditorData from "./analysis/classicEditorData.js";
import isGutenbergDataAvailable from "./helpers/isGutenbergDataAvailable";
import SnippetEditor from "./containers/SnippetEditor";
import { ThemeProvider } from "styled-components";
+import CornerstoneToggle from "yoast-components/com... | [No CFG could be retrieved] | Registers a store in the gutenberg editor and creates a sidebar entry for the plugin Yoast SEO - specific menu. | Styled should be lowercase: it's not a component. |
@@ -0,0 +1,12 @@
+module RecoveryCodeConcern
+ delegate :active_profile, to: :current_user
+
+ def create_new_code
+ if active_profile.present?
+ Pii::ReEncryptor.new(current_user, user_session).perform
+ active_profile.recovery_code
+ else
+ RecoveryCodeGenerator.new(current_user).create
+ en... | [No CFG could be retrieved] | No Summary Found. | WDYT about having the `Pii::ReEncryptor#perform` return the recovery code? Since the `active_profile.recovery_code` is a transient property instead of a persisted one? |
@@ -142,10 +142,11 @@ def _run_source(conanfile, conanfile_path, src_folder, hook_manager, reference,
output.info('Configuring sources in %s' % src_folder)
_run_scm(conanfile, src_folder, local_sources_path, output, cache=cache)
+ get_sources_from_exports()
+
... | [_get_sources_from_exports->[merge_directories],config_source->[remove_source],_run_scm->[_clean_source_folder,merge_directories],merge_directories->[is_excluded]] | Run the source core functionality. | I'm passing a function and calling it here to have the same execution order in the local workflow and inside the cache (keeping the execution order that was performed in the cache). I don't like it, and I think that we could run the exports-related copies before running _scm_ ones, what do you think? |
@@ -34,16 +34,7 @@ async def generate_python_from_protobuf(
)
output_dir = "_generated_files"
- # TODO(#9650): replace this with a proper intrinsic to create empty directories.
- create_output_dir_request = Get(
- ProcessResult,
- Process(
- ("/bin/mkdir", output_dir),
- ... | [rules->[collect_rules,UnionRule],generate_python_from_protobuf->[PurePath,Addresses,MergeDigests,SourceRootRequest,MultiGet,RemovePrefix,GeneratedSources,get,for_target,AddPrefix,Process,Get,get_request,SourceFilesRequest],rule] | Generate Python from a protocol buffer. Generate Python sources from a single n - node node. | Would it be useful to consider making a `Process` wrapper like `HackyLocalBinaryProcess` that uses the parent PATH to help make it easier to track these TODOs or at least help us maybe leave them until we have a process for discovering local binaries in a way we like? |
@@ -346,7 +346,8 @@ namespace Dynamo.Models
InitializePreferences(preferences);
InitializeInstrumentationLogger();
- UpdateManager.UpdateManager.Instance.CheckForProductUpdate(new UpdateRequest(new Uri(Configurations.UpdateDownloadLocation)));
+ var updateUri = new Uri(... | [DynamoModel->[Clear->[CleanWorkbench],ShutDown->[OnShutdownStarted,OnShutdownCompleted],RunCancelInternal->[RunExpression],Home->[ViewHomeWorkspace],OpenDefinition->[OpenCustomNodeAndFocus],ForceRunCancelInternal->[RunExpression,ResetEngine],RunExpression->[RunExpression],CleanWorkbench->[RemoveNodeFromMap,ResetEngine... | Initializes the virtual machine and initializes all of the components. Load the node models. | Is there a reason to have the Download location be a string not a URI? |
@@ -278,6 +278,11 @@ class MultiOptimizer(Optimizer):
" Alternatively, you can remove this optimizer from the provided `optimizers`"
" if it is not relevant to a particular parameter group."
)
+ # default optimizer is required, but may not be used
+ ... | [AdamaxOptimizer->[__init__->[make_parameter_groups]],SgdOptimizer->[__init__->[make_parameter_groups]],AveragedSgdOptimizer->[__init__->[make_parameter_groups]],HuggingfaceAdamWOptimizer->[__init__->[make_parameter_groups]],DenseSparseAdam->[step->[make_sparse],__init__->[make_parameter_groups]],AdamWOptimizer->[__ini... | Initializes the object with the given configuration. Alternative you can remove this optimizer from the provided optimizers. | "must not be used" or "using it is optional"? |
@@ -14,6 +14,7 @@
limitations under the License.
"""
+import logging as log
import time
from collections import OrderedDict
from itertools import chain, cycle
| [AsyncPipeline->[_run_sync_steps->[close,setup,end,process],close->[join],run->[start]],PipelineStep->[start->[start],_run->[setup,end,process],join->[join]]] | Creates a class which implements the logic of the class. This method initializes the object with the necessary data. | In some cases you substitute `import logging as log` with `import loggging`, but here and in some other cases you still import it as log. |
@@ -18,6 +18,7 @@ namespace System.Net.Sockets
public const bool SupportsMultipleConnectAttempts = false;
public static readonly int MaximumAddressSize = Interop.Sys.GetMaximumAddressSize();
private static readonly bool SupportsDualModeIPv4PacketInfo = GetPlatformSupportsDualModeIPv4PacketInf... | [SocketPal->[TryCompleteSendTo->[TryCompleteSendTo,SysSend],TryCompleteConnect->[SocketError],TryCompleteSendFile->[SendFile],TryCompleteReceiveFrom->[TryCompleteReceiveFrom,SysReceive],TryCompleteReceiveMessageFrom->[SysReceiveMessageFrom],TryCompleteReceive->[SysReceive],SendPacketsAsync->[SocketError],SocketError->[... | Get platformSupportsDualModeIPv4PacketInfo - Check if platform supports dual mode IPv. | This is a very safe value, it could be set higher. It matches the value used by Linux kernel for stackallocing iovs. |
@@ -619,4 +619,4 @@ describes.realWin('amp-story origin whitelist', {
story.originWhitelist_ = ['example.co'];
expect(story.isOriginWhitelisted_('https://example.co.uk')).to.be.false;
});
-});
+});
\ No newline at end of file
| [No CFG could be retrieved] | Test if the origin whitelisted is true. | Re-add newline at end of file |
@@ -77,10 +77,13 @@ static EC_PRE_COMP *ec_pre_comp_new(const EC_GROUP *group)
EC_PRE_COMP *EC_ec_pre_comp_dup(EC_PRE_COMP *pre)
{
- int i;
- if (pre != NULL)
- CRYPTO_UP_REF(&pre->references, &i, pre->lock);
- return pre;
+ int ref = 0;
+
+ if (pre != NULL) {
+ if (!CRYPTO_UP_REF(&pre-... | [ec_wNAF_mul->[ec_scalar_mul_ladder],ec_wNAF_precompute_mult->[EC_ec_pre_comp_free]] | Duplicate EC_PRE_COMP if it is NULL - free it - return it. | Why not just return pre? If you get here and pre != NULL, the up_ref call was successful, ref was updated, and so ref should actually be > 1. |
@@ -225,9 +225,14 @@ class EntityIconService {
if ($created !== true) {
// remove existing icons
$this->deleteIcon($entity, $type, true);
-
+
+ // save original image if 'original' icon_size is available for this type of entity
+ $store = $this->generateIcon($entity, $file, $type, $coords, 'original')... | [EntityIconService->[deleteIcon->[getIcon],handleServeIconRequest->[getIcon],getIconURL->[getIcon],getIcon->[getIcon,generateIcon],getIconLastChange->[getIcon]]] | Save an icon store the given entity in the database. | Check if `original` and `master` are in the size config first. Attempt to create both, if either fails, delete. |
@@ -131,11 +131,11 @@ static unsigned int psk_server_cb(SSL *ssl, const char *identity,
if (s_debug)
BIO_printf(bio_s_out, "psk_server_cb\n");
- if (SSL_version(ssl) >= TLS1_3_VERSION) {
+ if (!SSL_is_dtls(ssl) && SSL_version(ssl) >= TLS1_3_VERSION) {
/*
- * This callback is desig... | [No CFG could be retrieved] | This is the main entry point for the server. It is used to find the session ID find the client identity and the PSK key. | Shouldn't we also check the specific DTLS version in the DTLS case? |
@@ -33,7 +33,6 @@ import (
"github.com/blang/semver"
"github.com/pkg/errors"
-
"github.com/pulumi/pulumi/pkg/v3/codegen"
"github.com/pulumi/pulumi/pkg/v3/codegen/schema"
"github.com/pulumi/pulumi/sdk/v3/go/common/resource/plugin"
| [resourceType->[modNameAndName],genInit->[hasTypes,genHeader,unqualifiedImportName,submodulesExist,isEmpty,fullyQualifiedImportName],pyType->[pyType,resourceType],isEmpty->[isEmpty],walkSelfWithDescendants->[walkSelfWithDescendants],fullyQualifiedImportName->[fullyQualifiedImportName,unqualifiedImportName],objectType->... | Invite string - based tokens into constants. addObjectImport imports an object type and its sub - types. | I don't think we want to remove this. |
@@ -3211,9 +3211,14 @@ class Archiver:
are meaning different things:
This archive / deduplicated size = amount of data stored ONLY for this archive
- = unique chunks of this archive.
+ = unique chunks of this archive.
All archives / deduplicate... | [main->[get_args,run,Archiver],with_repository->[decorator->[wrapper->[argument]]],Archiver->[_export_tar->[item_to_tarinfo->[print_warning,item_content_stream],build_filter,print_warning,build_matcher,item_to_tarinfo],do_prune->[print_error,write],do_mount->[print_error],do_check->[print_error],do_extract->[build_filt... | Build a parser for a specific node. Add options to a specific topic. Option parser for Borg - specific commands. Add command line options for the Borg - Deduplicated Backups command. command line interface for handling n - node command This command is used to initialize a repository segment file. | well, this is correct, but can be misunderstood by users who do not know that content data lives outside of the archive. so maybe rather say "... archive metadata streams up to ...". |
@@ -1404,6 +1404,7 @@ class PreParforPass(object):
break
return True
if guard(replace_func):
+ self.stats['replaced_func'] += 1
break
elif (isinstan... | [simplify_parfor_body_CFG->[simplify_parfor_body_CFG],remove_dead_parfor->[list_vars],repr_arrayexpr->[repr_arrayexpr],get_parfor_array_accesses->[unwrap_parfor_blocks,wrap_parfor_blocks],get_parfor_params_inner->[get_parfor_params],prod_parallel_impl->[prod_1->[init_prange,internal_prange]],min_parallel_impl->[min_1->... | Replace functions with their parallel implementation in replace_functions_map if available. The function that creates a object. Missing type in the typemap. break break . | Is there merit in storing the actual functions replaced too? |
@@ -9,7 +9,7 @@ module Users
@verify_account_form = VerifyAccountForm.new(user: current_user)
return unless FeatureManagement.reveal_usps_code?
- @code = JSON.parse(user_session[:decrypted_pii])['otp']['raw']
+ @code = session[:last_usps_confirmation_code]
end
def create
| [VerifyAccountController->[build_verify_account_form->[new],params_otp->[permit],create->[redirect_to,t,render,submit],confirm_verification_needed->[redirect_to,pending_profile_requires_verification?],decrypted_pii->[fetch,new],index->[parse,reveal_usps_code?,new,mail_spammed?],before_action]] | if the user has a code we can show it otherwise we create a new one. | I kept OTP prefilling by sticking the OTP in the session. It's a little bit brittle, so I also considered displaying it in flash message on the come back later screen. No problem making it work that way if we think that's better. |
@@ -0,0 +1 @@
+package ocr2key_test
| [No CFG could be retrieved] | No Summary Found. | This file seems pointless |
@@ -44,7 +44,8 @@ namespace hw {
static std::string safe_hid_error(hid_device *hwdev) {
if (hwdev) {
- return std::string((char*)hid_error(hwdev));
+ const char* error_str = (const char*)hid_error(hwdev);
+ return std::string(error_str == nullptr ? "Unknown error" : error_str);
... | [No CFG could be retrieved] | This file is exported to the HID framework. Interface to device_io_hid. | The API seems to return wchar_t*, so the string conversion won't work (before your patch). The patch can still go in though. |
@@ -21,7 +21,7 @@ const versionedBuilderMap = {
*/
function wrap(buildDom) {
return function wrapper(element) {
- applyStaticLayout(element);
+ applyStaticLayout(/** @type {AmpElement} */ (element));
buildDom(element);
element.setAttribute('i-amphtml-ssr', '');
};
| [No CFG could be retrieved] | Creates a function that will wrap a buildDom function with functionality that every component needs. | @samouri This is a "new" type error. When we use the real `#core` types instead of your stubs, it comes up that this has to be an AMP element. That will obv not always be the case, ideally. Casting for now, but currently this would mask bugs with non-AMP elements. |
@@ -104,6 +104,10 @@ public class NiFiOrcUtils {
if (o instanceof Double) {
return new DoubleWritable((double) o);
}
+ // Map BigDecimal to a Double type - this should be improved to map to Hive Decimal type
+ if (o instanceof BigDecimal) {
+ ... | [NiFiOrcUtils->[convertToORCObject->[convertToORCObject],getOrcField->[getOrcField],createWriter->[createWriter],getHiveTypeFromFieldType->[getHiveTypeFromFieldType]]] | converts a primitive object to an OrcObject private int fieldCount = 0 ; convert object to ORC object if it is not null. get type name of a managed object. | There were some runtime issues with unit tests related to Orc. @mattyb149 @bbende @ijokarumawak do y'all have any insight into this ORC conversion? |
@@ -37,7 +37,7 @@ class AzureTableConfiguration(Configuration):
self.url = url
self.version = "2019-02-02"
- kwargs.setdefault('sdk_moniker', 'azuretable/{}'.format(VERSION))
+ kwargs.setdefault('sdk_moniker', 'table/{}'.format(VERSION))
self._configure(**kwargs)
def _c... | [AzureTableConfiguration->[__init__->[setdefault,super,ValueError,format,_configure],_configure->[UserAgentPolicy,ProxyPolicy,get,RetryPolicy,HeadersPolicy,RedirectPolicy,CustomHookPolicy,NetworkTraceLoggingPolicy]]] | Initialize a AzureTableConfiguration object from a base URL and optional configuration. | this too, I think this should be data-tables/ Wondering if we need to regenerate with autorest and specify namespace like, --namespace=azure.data.tables --package-name=azure-data-tables @iscai-msft |
@@ -35,7 +35,7 @@ describe
.run('amp-video', () => {
runVideoPlayerIntegrationTests((fixture) => {
const video = fixture.doc.createElement('amp-video');
- video.setAttribute('src', '/examples/av/ForBiggerJoyrides.mp4');
+ video.setAttribute('src', '/examples/av/ForBiggerJoyrides-tiny.mp4');
... | [No CFG could be retrieved] | Creates a new component with the specified attributes. Add data - videos attribute to video element if it exists. | Should this be accompanied by a change to the `timeout` value used by these tests? |
@@ -29,8 +29,8 @@ $new_tab_message = WPSEO_Admin_Utils::get_new_tab_message();
<li><strong><?php esc_html_e( 'Preview your page in Facebook and Twitter', 'wordpress-seo' ); ?></strong></li>
<li><strong><?php esc_html_e( 'Get real-time suggestions for internal links', 'wordpress-seo' ); ?></strong></li>
... | [No CFG could be retrieved] | Yoast Sidebar for the Yoast plugin Print SEO - beginningners section. | please add 'email' to the other occurrence and revert this change |
@@ -15,7 +15,14 @@ class Protobuf(CMakePackage):
url = "https://github.com/protocolbuffers/protobuf/archive/v3.10.1.tar.gz"
root_cmakelists_dir = "cmake"
+
+ version('3.11.2', sha256='e8c7601439dbd4489fe5069c33d374804990a56c2f710e00227ee5d8fd650e67')
+ version('3.11.1', sha256='4f8e805825c53bbc... | [Protobuf->[cmake_args->[int,extend],fetch_remote_versions->[dict,url_for_version,find_versions_of_archive,map],depends_on,conflicts,version,patch,variant]] | Creates a new object from a list of all possible versions of a sequence. Return version of a sequence that is known to be a sequence version 3. 5. 1 Set a single sequence number variant. | This line is gonna cause flake8 to fail |
@@ -0,0 +1,11 @@
+import dayjs from 'dayjs';
+import customParseFormat from 'dayjs/plugin/customParseFormat';
+import duration from 'dayjs/plugin/duration';
+import relativeTime from 'dayjs/plugin/relativeTime';
+
+// jhipster-needle-i18n-language-dayjs-imports - JHipster will import languages from dayjs here
+
+// DAY... | [No CFG could be retrieved] | No Summary Found. | I don't know if it's better to add semicolon at the end of the lines |
@@ -83,7 +83,7 @@ func loop() {
Prompt: "\033[31m»\033[0m ",
HistoryFile: "/tmp/readline.tmp",
InterruptPrompt: "^C",
- EOFPrompt: "exit",
+ EOFPrompt: "^D",
HistorySearchFold: true,
})
if err != nil {
| [NewEx,Printf,Exit,Stat,Println,Split,Notify,StringVarP,Start,Close,Readline,Parse,ReadAll,Getenv,BoolVarP,TrimSpace,Mode] | Reads input from stdin and processes the next n - bytes in the input. | can we still use `exit` now? |
@@ -7,6 +7,7 @@ define([
'../Core/DeveloperError',
'../Core/IndexDatatype',
'../Core/WebGLConstants',
+ '../Core/Check',
'./BufferUsage'
], function(
defaultValue,
| [No CFG could be retrieved] | Creates a buffer object that can be used to create a buffer of the specified size. Constructor for the object. | Make sure that you add the define paths in alphabetical order. Same applies to other files. |
@@ -3,7 +3,13 @@
module RepositoryDatatableHelper
include InputSanitizeHelper
+
def prepare_row_columns(repository_rows, repository, columns_mappings, team, options = {})
+
+ if options[:my_module]
+ assigned_rows = options[:my_module].repository_rows.where(repository: repository).pluck(:id)
+ end
+... | [default_snapshot_table_order_as_js_array->[to_json],default_table_order_as_js_array->[to_json],default_table_columns->[to_json],assigned_row->[positive?,assigned_experiments_count,t,assigned_my_modules_count,assigned_projects_count],can_perform_repository_actions->[can_manage_repository_rows?,can_manage_repository?,ca... | Prepares the row columns for a given repository. | Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning. |
@@ -33,7 +33,13 @@ func isGitFolder(path string) bool {
func isRepositoryFolder(path string) bool {
info, err := os.Stat(path)
- return err == nil && info.IsDir() && info.Name() == BookkeepingDir
+ if err == nil && info.IsDir() && info.Name() == BookkeepingDir {
+ // make sure it has a settings.json file in it
+ ... | [Join,Stat,IsDir,TrimSuffix,WalkUp,Name,Ext] | DetectPackage finds the closest package in the given path. IsDir - Check if the name of the missing file is expected. | Nit: Use a full sentence, capital M and end with a period. |
@@ -85,6 +85,7 @@ class Ascent(Package):
depends_on("python+shared", when="+python+shared")
extends("python", when="+python+shared")
depends_on("py-numpy", when="+python+shared", type=('build', 'run'))
+ depends_on("py-pip", when="+python+shared", type=('build', 'run'))
#######################
... | [Ascent->[install->[install],create_host_config->[cmake_cache_entry]]] | Package dependencies for all packages. requires all methods to be called on the same object. | pip is rarely needed if you follow the standard `setup.py install` method |
@@ -447,6 +447,10 @@ class Scaffold_Command extends WP_CLI_Command {
if ( isset( $assoc_args['activate'] ) ) {
WP_CLI::run_command( array( 'plugin', 'activate', $plugin_slug ) );
}
+
+ if ( isset( $assoc_args['activate-network'] ) ) {
+ WP_CLI::run_command( array( 'plugin', 'activate', $plugin_slug), array... | [Scaffold_Command->[plugin->[create_file,maybe_create_plugins_dir],plugin_tests->[chmod,copy,create_file,init_wp_filesystem,mkdir],post_type->[_scaffold],_s->[maybe_create_themes_dir,init_wp_filesystem],create_file->[put_contents,init_wp_filesystem,mkdir],package_tests->[run],child_theme->[create_file,maybe_create_them... | Plugin main function. | This should probably be `elseif` |
@@ -44,10 +44,11 @@ type Config struct {
func defaultConfig() Config {
return Config{
- Host: "unix:///var/run/docker.sock",
- MatchSource: true,
- SourceIndex: 4, // Use 4 to match the CID in /var/lib/docker/containers/<container_id>/*.log.
- MatchPIDs: []string{"process.pid", "process.ppid"},
- DeD... | [No CFG could be retrieved] | defaultConfig returns a default configuration for the container ID filter. | I think it would make sense to add `/kubepods` to the defaults |
@@ -72,4 +72,5 @@ module.exports = {
checkOwners.description = 'Checks all OWNERS files in the repo for correctness';
checkOwners.flags = {
'files': ' Checks only the specified OWNERS files',
+ 'validate': ' Validates the OWNERS files with the owners bot API',
};
| [No CFG could be retrieved] | Check all OWNERS files in the repo for correctness. | I don't see this flag being used anywhere, so it can be removed. Also, `local_changes` is missing from this list. |
@@ -176,9 +176,10 @@ final class EngineExecutor {
throw new IllegalArgumentException("Executor can only handle pull queries");
}
final SessionConfig sessionConfig = statement.getSessionConfig();
- PullSourceType sourceType = null;
- PullPhysicalPlanType planType = null;
- RoutingNodeType routi... | [EngineExecutor->[buildPullPhysicalPlan->[buildPullPhysicalPlan],executeDdl->[executeDdl],create->[EngineExecutor]]] | Executes a table pull query with the given parameters. check if the error message contains the query string and if it contains sensitive information throw a K. | pulled this up because it cannot throw an exception and doesn't depend on the plan. |
@@ -80,6 +80,7 @@ KNOWN_TASK_TYPES = {
}
KNOWN_QUANTIZED_PRECISIONS = {p + '-INT8': p for p in ['FP16', 'FP32']}
+KNOWN_COMPILABLE_PRECISIONS = {'FP16', 'FP32'}
assert KNOWN_QUANTIZED_PRECISIONS.keys() <= KNOWN_PRECISIONS
RE_MODEL_NAME = re.compile(r'[0-9a-zA-Z._-]+')
| [FileSourceHttp->[start_download->[http_range_headers,handle_http_response],deserialize->[validate_string]],Model->[deserialize->[DeserializationError,validate_string,deserialization_context,validate_string_enum,deserialize]],TaggedBase->[deserialize->[DeserializationError]],run_in_parallel->[start->[JobWithQueuedOutpu... | This module provides a mapping of frame names to their respective JobContext instances. A utility class for printing a single non - terminal number. | This variable isn't used outside the compiler script, so it can live there. Also, why only these precisions? Can quantized models not be compiled? |
@@ -8553,8 +8553,8 @@ bool simple_wallet::get_transfers(std::vector<std::string>& local_args, std::vec
}
else
{
- uint64_t current_time = static_cast<uint64_t>(time(NULL));
- uint64_t threshold = current_time + (m_wallet->use_fork_rules(2, 0) ? CRYPTONOTE_LOCKED_TX_ALLOWED_D... | [No CFG could be retrieved] | Get payments from the wallet. private private methods. | Looks like terminology confusion again, since 'adjusted_time' has been changed to mean 'median time of last 60 blocks'. Which makes the behavior here change. |
@@ -202,7 +202,13 @@ public class DubboBeanDefinitionParser implements BeanDefinitionParser {
String throwMethod = value.substring(index + 1);
reference = new RuntimeBeanReference(throwRef);
beanDefinition.get... | [DubboBeanDefinitionParser->[parseArguments->[parse],parseMethods->[parse],isPrimitive->[isPrimitive],parse->[parse],parseNested->[parse]]] | Parse the given element into a BeanDefinition. parseProperties - parse properties - parse parameters - parse methods - parse arguments - parse bean definition Checks if there is a potential duplicate of the property value. | I think the variable name `throwRef` should change to `invokeRef`. |
@@ -24,6 +24,12 @@ import io.quarkus.deployment.Capability;
*/
public final class CapabilityBuildItem extends MultiBuildItem {
+ private static volatile Logger log;
+
+ private static Logger getLog() {
+ return log == null ? log = Logger.getLogger(CapabilityBuildItem.class) : log;
+ }
+
privat... | [CapabilityBuildItem->[requireNonNull]] | Construct a new capability build item that can be used to build a technical capability. | Why do you do that? We are at deployment time, it's not that big of deal to have a static logger, or is it? |
@@ -9,6 +9,13 @@ using Dynamo.Interfaces;
namespace Dynamo.Configuration
{
+ public class Package
+ {
+ public string Name { get; set; }
+
+ public string Version { get; set; }
+ }
+
/// <summary>
/// PreferenceSettings is a class for GUI to persist certain settings.
/// Upon r... | [PreferenceSettings->[SaveInternal->[Save],GetIsBackgroundPreviewActive,SetIsBackgroundPreviewActive]] | PreferenceSettings provides a class to persist certain configuration options for the given object. - The unique identifier of the node. | does this need to be public ? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.