patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -476,6 +476,16 @@ class MicroBenchmarks(benchmarks_test_base.MicroBenchmarksBase):
func = lambda: f(m, m, transpose_b=transpose_b)
self._run(func, num_iters, execution_mode=execution_mode)
+ def _benchmark_defun_matmul_with_signature(self, m, num_iters, execution_mode=None):
+
+ def defun_matmul(... | [MicroBenchmarks->[benchmark_read_variable_op_with_tape_2_by_2_GPU->[_benchmark_read_variable_with_tape],benchmark_tf_random_uniform_2_by_2_default_setting_GPU->[_run],benchmark_forwardprop_in_defun_of_defun_matmul_256_by_2096_CPU->[_benchmark_forwardprop_in_defun_of_defun_matmul_CPU],benchmark_defun_without_signature_... | Benchmark for defun matrices multiplication. | this should be f . |
@@ -63,7 +63,7 @@ namespace Dynamo.Library
/// <summary>
/// Returns fully qualified string representation of AST node.
/// </summary>
- [JsonProperty("DefaultValue")]
+ [JsonIgnore]
public string DefaultValueString
{
get
| [TypedParameter->[Format,Empty,IsNullOrEmpty,DefaultValue,summary,ToString,ToShortString,GetDescription]] | Creates a typed parameter that can be used to create a typed parameter. Creates a description for the given . | I think this is required. @alfarok just added this. |
@@ -78,7 +78,9 @@ public class LocalDataSegmentPusher implements DataSegmentPusher
);
}
- outDir.mkdirs();
+ if (!outDir.mkdirs() && !outDir.isDirectory()) {
+ throw new IOException(String.format("Cannot create directory[%s]", outDir));
+ }
File outFile = new File(outDir, "index.zip");
... | [LocalDataSegmentPusher->[makeLoadSpec->[toString,of],getPathForHadoop->[toString],createDescriptorFile->[newInputStreamSupplier,copy,info,File,writeValueAsBytes],push->[getStorageDirectory,getIdentifier,withBinaryVersion,equals,getStorageDir,createDescriptorFile,zip,mkdirs,getVersionFromDir,toString,listFiles,info,Fil... | Push a new segment to the local filesystem. | can this check be done when first reading the config? |
@@ -766,12 +766,11 @@ class LSTMV2Test(keras_parameterized.TestCase):
model.evaluate(x, y)
model.predict(x)
- @testing_utils.run_v2_only
+ @test.disable_with_predicate(
+ pred=test.is_built_with_rocm,
+ skip_message='Skipping as ROCm MIOpen does not support padded input yet.')
+ @test_util.run_... | [LSTMV2Test->[test_time_major_and_go_backward->[build_model],test_lstm_model_save_load->[build_model]],LSTMPerformanceTest->[_time_performance_run_normal_lstm->[_measure_performance],_time_performance_run_unifed_lstm_gpu->[_measure_performance],benchmark_performance_graph->[_benchmark_performance_with_standard_cudnn_im... | Test bidirectional model. Check if sequence is missing. | error : no test_util.run_v2_only function found |
@@ -146,6 +146,11 @@ namespace Dynamo.Graph.Workspaces
/// </summary>
public bool IsLoaded { get; set; }
+ /// <summary>
+ /// State of Package Dependency
+ /// </summary>
+ public PackageDependencyState State { get; set; }
+
/// <summary>
/// Guids of n... | [PackageDependencyInfo->[ToString->[ToString],GetHashCode->[GetHashCode]],PackageInfo->[ToString->[ToString],GetHashCode->[GetHashCode]]] | PackageDependencyInfo - Class containing info about a package dependency. Adds the Guid of a dependent node. | So why does this property still exist? I don't think we're setting it correctly anymore right? here's 2 options: 1. obsolete it and have it return true if State == state.Loaded 2. remove it and cherry pick the removal to 2.3 before we release it. |
@@ -253,6 +253,18 @@ class ExamTemplate < ApplicationRecord
assignment.short_identifier, self.name
end
+ def num_cover_fields
+ self.cover_fields.split(",").length
+ end
+
+ def get_cover_field(i)
+ if self.num_cover_fields > i
+ self.cover_fields.split(",")[i]
+ else
+ " "
+ ... | [ExamTemplate->[base_path->[short_identifier,markus_exam_template_dir,name,join],set_formats_for_name_and_filename->[tr,name,filename],generate_copies->[perform_later],create_with_file->[short_identifier,nil?,create,write,basename,exists?,parse,has_key?,tr,markus_exam_template_dir,join,open,length,mkdir_p],split_pdf->[... | Returns the base path of the missing node in the Markus exam template. | Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -7,6 +7,8 @@ import (
"github.com/sirupsen/logrus"
)
+const ctrRemoveTimeout = 10
+
// Contains the public Runtime API for containers
// A CtrCreateOption is a functional option which alters the Container created
| [HasContainer->[HasContainer],LookupContainer->[LookupContainer],RemoveContainer->[RemoveContainer]] | NewContainer imports a new container from a given OCI spec. addContainer adds a new container to the container list. | I think this is fine, but am going to ask just to be 100% sure, should this be in a conf file so it could be adjusted? I don't think so, but I'm not positive. |
@@ -1151,7 +1151,7 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
{
std::vector<std::string> parts = split(element,';');
- if ((parts.size() == 5) || (parts.size() == 7) || (parts.size() == 8)) {
+ if ((parts.size() == 5) || (parts.size() == 9)) {
std::vector<std::string> v_pos ... | [parseLabel->[split],parseList->[split],parseItemImageButton->[split],parseTableColumns->[split],parseElement->[parseLabel,parseList,parseItemImageButton,parseTableColumns,parseImageButton,parseItemImage,parseImage,parsePwdField,parseBackgroundColor,parseDropDown,parseBackground,parseListColors,split,parseVertLabel,par... | Parses an image button. image_button_exit image_button_pressed image_button_image_name label. | Wouldn't that break current usage of this item? |
@@ -1266,6 +1266,7 @@ func (b TLFIdentifyBehavior) AlwaysRunIdentify() bool {
switch b {
case TLFIdentifyBehavior_CHAT_CLI,
TLFIdentifyBehavior_CHAT_GUI,
+ TLFIdentifyBehavior_FS_GUI,
TLFIdentifyBehavior_SALTPACK,
TLFIdentifyBehavior_KBFS_CHAT,
TLFIdentifyBehavior_GUI_PROFILE:
| [FindDeviceKey->[Equal],IsPublic->[IsPublic],IsStale->[Max],ToTeamID->[String],FindEncryptionKIDFromSigningKID->[FindEncryptionDeviceKeyFromSigningKID],Compare->[Compare],Match->[IsNil,String],AsUserOrBust->[AsUser],Exists->[IsNil],TeamInviteName->[PercentForm],SecureEqual->[Equal,Bytes],RootID->[ToTeamID,RootAncestorN... | AlwaysRunIdentify returns true if the TLFIdentifyBehavior is enabled. | Seems like you didn't add `FS_GUI` to the function below this one, `CanUseUntrackedFastPath()`. I'm not sure exactly what that does, but did you try it to see if it helps with the broken track reporting? |
@@ -73,8 +73,8 @@ export const savePassword = (currentPassword, newPassword) => ({
type: ACTION_TYPES.UPDATE_PASSWORD,
payload: axios.post(`${apiUrl}/change-password`, { currentPassword, newPassword }),
meta: {
- successMessage: translate('password.messages.success'),
- errorMessage: translate('password.... | [No CFG could be retrieved] | API endpoint for change password. | why the conditions, cant it work the same way as other reducers? |
@@ -516,6 +516,7 @@ class Analyzer {
} else if (selectItem instanceof SingleColumn) {
final SingleColumn column = (SingleColumn) selectItem;
addSelectItem(column.getExpression(), column.getAlias());
+ visitTableFunctions(column.getExpression());
} else {
throw... | [Analyzer->[Visitor->[getValueDelimiter->[getValueDelimiter],setSerdeOptions->[setSerdeOptions],getJoinFieldName->[checkExpressionType],addSelectItem->[addSelectItem]]]] | Visit a Select node. This method checks for a potential duplicate select node. | This looks like a much better way/place to collect UDTFs! |
@@ -111,4 +111,5 @@ class ZipExport < ApplicationRecord
file = FileUtils.touch("#{tmp_dir}/export.csv").first
File.open(file, 'wb') { |f| f.write(data) }
end
+
end
| [ZipExport->[generate_samples_zip->[first,open,write],generate_notification->[t,create,zip_exports_download_path],generate_repositories_zip->[first,open,write],respond_to_missing?->[start_with?],generate_exportable_zip->[path,new,to_i,root,generate_notification,zip_file,fill_content,zip!,join,first,open,mkdir_p],stored... | generate_repositories_zip - generates a zip file containing the list of repositories. | Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end. |
@@ -99,13 +99,13 @@ class Graphviz(AutotoolsPackage):
# These language bindings have not yet been tested. They
# likely need additional dependencies to get working.
untested_bindings = (
- '+swig', '+sharp', '+go', '+guile', '+io',
+ '+sharp', '+go', '+guile', '+io',
... | [Graphviz->[configure_args->[append,copyfile,SpackException],variant,depends_on,version]] | Configure the options for the command line. | You can just use InstallError, that's what most packages use. |
@@ -991,9 +991,14 @@ def gru_unit(input,
param_attr=None,
bias_attr=None,
activation='tanh',
- gate_activation='sigmoid'):
+ gate_activation='sigmoid',
+ origin_mode=False):
"""
- GRU unit layer. The equation of a gru step is:
+ **... | [ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initia... | This function creates a non - linear GRU unit layer. The hidden value reset - hidden value and the hidden state of the hidden state of the GR Adds a base on the base network for a . | > origin_mode Is there any other exact name? 1. ? 2. fine-tune? ?GPUcuDNN? @ @Xreki |
@@ -65,6 +65,7 @@ def as_strided1(a):
strides = (a.strides[0] // 2,) + a.strides[1:]
return np.lib.stride_tricks.as_strided(a, strides=strides)
+
def as_strided2(a):
# Rolling window example as in https://github.com/numba/numba/issues/1884
window = 3
| [expand_dims->[expand_dims],atleast_3d->[atleast_3d],TestArrayManipulation->[test_array_reshape->[check_err_size->[run],check_err_shape->[run],check_err_multiple_negative->[run],check_empty->[check_err_size,check,check_only_shape],check->[run],check_only_shape->[run],check_err_size,check_err_shape,check_err_multiple_ne... | A function to convert a sequence of 1 - D arrays into 1 - D arrays with explicit. | No new line. |
@@ -772,7 +772,17 @@ class _OverloadFunctionTemplate(AbstractTemplate):
jitter = self._get_jit_decorator()
# Get the overload implementation for the given types
- ovf_result = self._overload_func(*args, **kws)
+ try:
+ ov_sig = inspect.signature(self._overload_func)
+ ... | [_OverloadMethodTemplate->[_resolve->[MethodTemplate->[generic->[_get_signature,as_method,replace,_get_function_type]]],_init_once->[method_impl->[_get_signature,_get_function_type],_get_target_registry]],FunctionTemplate->[__str__->[get_template_info]],_OverloadFunctionTemplate->[_validate_sigs->[gen_diff,get_args_kwa... | Build and cache the implementation. Return the function to call when the function is called. | Should this be moved out of the try block as above? |
@@ -199,7 +199,10 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
this.qqid_ = null;
/** @private {?({width, height}|../../../src/layout-rect.LayoutRectDef)} */
- this.size_ = null;
+ this.initialSize_ = null;
+
+ /** @private {?{width, height}} */
+ this.returnedSize_ = null;
... | [AmpAdNetworkDoubleclickImpl->[extractSize->[height,extractAmpAnalyticsConfig,get,Number,setGoogleLifecycleVarsFromHeaders,width],getBlockParameters_->[serializeTargeting_,dev,isInManualExperiment,assign,join,googleBlockParameters,getMultiSizeDimensions,map],delayAdRequestEnabled->[experimentFeatureEnabled,DELAYED_REQU... | private private static final int AMP_AD_KEY_LENGTH = 8 ;. | Please specify types here. |
@@ -16,7 +16,11 @@ package config
import (
"context"
"fmt"
+ zaplog "github.com/pingcap/log"
+ "github.com/tikv/pd/pkg/etcdutil"
+ "go.etcd.io/etcd/clientv3"
"reflect"
+ "strconv"
"sync/atomic"
"time"
"unsafe"
| [GetReplicaScheduleLimit->[GetScheduleConfig],GetSchedulers->[GetScheduleConfig],IsUseRegionStorage->[GetPDServerConfig],SetAllStoresLimitTTL->[SetTTLData],GetMaxMergeRegionSize->[GetScheduleConfig],GetSplitMergeInterval->[GetScheduleConfig],SetPlacementRuleEnabled->[SetReplicationConfig,GetReplicationConfig],GetStoreL... | NewPersistOptions creates a new persist options object that can be used to persist the given configuration GetScheduleConfig returns the schedule configuration. | fix the goimport. |
@@ -34,6 +34,7 @@ func init() {
"arch_prctl",
"bind",
"brk",
+ "capget",
"clock_gettime",
"clone",
"close",
| [No CFG could be retrieved] | Initializes a new object. Get all the functions that are available on the system. | @andrewkroh I didn't manage to update these files with `make seccomp`, it created new include files under metricbeat. I have added this by hand here. |
@@ -3703,9 +3703,9 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
}
private UserVmVO commitUserVm(final DataCenter zone, final VirtualMachineTemplate template, final String hostName, final String displayName, final Account owner,
- final ... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],loadVmDetailsInMapForExternalDhcpIp->[V... | Commits a user VM. find a template by id and set root disk controller and data disk controller private int vm_id = 0 ; This method is called to update the resource count for the given vm in the given account. | hm, i actually liked the alignment of the parameters. good old days ;) |
@@ -57,6 +57,10 @@ export class AmpList extends AMP.BaseElement {
/** @const @private {string} */
this.initialSrc_ = element.getAttribute('src');
+
+ this.registerAction('refresh', () => {
+ this.fetchList_();
+ }, ActionTrust.LOW);
}
/** @override */
| [No CFG could be retrieved] | Create an AMP list component. This method is called when the user has requested to construct a new object. | Curious why low trust? Do you need this to trigger on scroll? |
@@ -250,7 +250,9 @@ class V00_MarkeplaceAdapter {
if (event.event === 'ListingCreated') {
ipfsHash = event.returnValues.ipfsHash
} else if (event.event === 'ListingUpdated') {
- ipfsHash = event.returnValues.ipfsHash
+ if (!offerBlockNumber || offerBlockNumber < event.blockNumber) {... | [No CFG could be retrieved] | Get the raw listing data for a given listingId. Returns a raw listing along with its associated events and offers. | @wanderingstan - this is the code that enables us to show the listing data as it was when the listing was created for "my purchases" and "my sales" |
@@ -74,6 +74,9 @@ public class DataSchema
Preconditions.checkArgument(!Strings.isNullOrEmpty(dataSource), "dataSource cannot be null or empty. Please provide a dataSource.");
Preconditions.checkArgument(!dataSource.contains("/"), "dataSource cannot contain the '/' character.");
+ Preconditions.checkArgum... | [DataSchema->[withGranularitySpec->[DataSchema],toString->[toString],withTransformSpec->[DataSchema]]] | Construct a new data schema. Get the data source. | Suggest extracting these checks into a static method on DataSchema, could call it `validateDatasourceName` |
@@ -64,7 +64,10 @@ module DiscoursePoll
end
polls[poll_name]["voters"] = previous_polls[poll_name]["voters"]
- polls[poll_name]["anonymous_voters"] = previous_polls[poll_name]["anonymous_voters"] if previous_polls[poll_name].has_key?("anonymous_voters")
+
+ if previous_polls[po... | [PollsUpdater->[extract_option_ids->[sort],private_to_public_poll?->[add,t,nil?],update->[size,extract_option_ids,custom_fields,has_key?,private_to_public_poll?,ago,publish,each_key,last_editor_id,destroy_all,t,total_votes,poll_edit_window_mins,created_at,to_i,sort,include?,polls_updated?,id,topic_id,clear_custom_field... | Updates the post with the given list of polls. if the poll has a key that is not the same as the previous polls and the. | I tested it on a relatively large poll and perf seems ok. Plus polls usually don't have alot of options |
@@ -894,7 +894,7 @@ class HgFetchStrategy(VCSFetchStrategy):
args = []
if self.revision:
args.append('at revision %s' % self.revision)
- tty.msg("Trying to clone Mercurial repository:", self.url, *args)
+ tty.msg("Cloning Mercurial repository:", self.url, *args)
a... | [args_are_for->[matches],SvnFetchStrategy->[_remove_untracked_files->[svn],fetch->[svn],reset->[svn,_remove_untracked_files],get_source_id->[svn]],for_package_version->[URLFetchStrategy,matches],from_list_url->[URLFetchStrategy],HgFetchStrategy->[fetch->[hg],reset->[hg],get_source_id->[hg]],CacheURLFetchStrategy->[fetc... | Fetch a from the Mercurial repository. | We use "Mercurial" here instead of "mercurial" or "hg", but elsewhere we use "svn" instead of "Subversion" or "subversion". I'm in favor of using "mercurial" and "subversion". |
@@ -993,9 +993,11 @@ POST_CONTENT;
$this->sender->do_sync();
$synced_post = $this->server_replica_storage->get_post( $post_id );
- $this->assertEquals( '', $synced_post->post_content_filtered );
- $this->assertEquals( '', $synced_post->post_excerpt_filtered );
+ // Clean up.
+ unregister_post_type( 'non_pub... | [WP_Test_Jetpack_Sync_Post->[test_add_post_syncs_post_data->[filter_post_content_and_add_links,post_count,assertEquals,get_post],test_add_post_syncs_request_is_auto_save->[assertTrue,create,get_most_recent_event,do_sync,assertFalse],test_filters_out_blacklisted_post_types_and_their_post_meta->[create,get_metadata,get_p... | This function is used to test if a non - public post type is filtered post content. Checks if the content of a cool video is the same as the content of a cool video the_content is NOT the same as filtered the_content. | @obenland do you mind outlining why the change to **assertSame**? assertSame -> Asserts that two objects refer to the same object |
@@ -86,7 +86,7 @@ final class IOUringSubmissionQueue {
this.ringSize = ringSize;
this.ringAddress = ringAddress;
this.ringFd = ringFd;
-
+ this.submissionCallback = submissionCallback;
timeoutMemory = Buffer.allocateDirectWithNativeOrder(KERNEL_TIMESPEC_SIZE);
timeout... | [IOUringSubmissionQueue->[addConnect->[setData,getSqe],addTimeout->[setData,getSqe],addWritev->[setData,getSqe],addWrite->[setData,getSqe],addPoll->[setData,getSqe],addPollRemove->[setData,getSqe],addAccept->[setData,getSqe],addRead->[setData,getSqe],submit->[flushSqe]]] | Returns the submission queue index. | Could we perhaps wire this up after construction, so we don't need to pass the callback through so many layers? |
@@ -293,7 +293,7 @@ class ClassMapGenerator
{
static $extraTypes = null;
if (null === $extraTypes) {
- $extraTypes = PHP_VERSION_ID < 50400 ? '' : '|trait';
+ $extraTypes = '|trait';
if (PHP_VERSION_ID >= 80100 || (defined('HHVM_VERSION') && version_compare(HHVM... | [ClassMapGenerator->[createMap->[isAbsolutePath,normalizePath,getPathname,writeError,in],filterByNamespace->[writeError],findClasses->[clean]]] | Get extra types. | You could move `trait` into the default array below together with class and interface at line 300. |
@@ -28,11 +28,6 @@ def user_config_dir(appname, roaming=True):
return _appdirs.user_config_dir(appname, appauthor=False, roaming=roaming)
-def user_data_dir(appname, roaming=False):
- # type: (str, bool) -> str
- return _appdirs.user_data_dir(appname, appauthor=False, roaming=roaming)
-
-
# for the disc... | [user_config_dir->[user_config_dir],user_data_dir->[user_data_dir],user_cache_dir->[user_cache_dir]] | Return the user data directory and site config directories. | This changes the behavior on Windows - now pip will be looking for `%APPDATA%\pip\pip\pip.ini`, since the default `appauthor=None` causes appdirs to use `appname` as `appauthor` and include it as a part of the path. |
@@ -328,7 +328,8 @@ class Gcc(AutotoolsPackage):
if sys.platform == 'darwin':
options.extend([
'--with-native-system-header-dir=/usr/include',
- '--with-sysroot={0}'.format(macos_sdk_path())
+ '--with-sysroot={0}'.format(macos_sdk_path()),
+ ... | [Gcc->[url_for_version->[Version,format],write_rpath_specs->[join_path,gcc,write,set_install_permissions,startswith,format,warn,open],spec_dir->[glob,format],setup_environment->[search_regexps,upper,isdir,set,join,islink,product,match,listdir],patch->[join_path,install,Version,isfile,filter_file,format,mkdirp],nvptx_in... | Configure options for GCC . Returns a list of options to use when running the Nvptx compiler. | Is the trailing comma here on purpose? |
@@ -136,6 +136,7 @@ func GetOpenshiftBootstrapClusterRoles() []rbac.ClusterRole {
},
Rules: []rbac.PolicyRule{
rbac.NewRule("impersonate").Groups(userGroup, legacyUserGroup).Resources(authorizationapi.SystemUserResource, authorizationapi.UserResource).Names(SystemAdminUsername).RuleOrDie(),
+ rbac.NewRu... | [Difference,ControllerRoles,NewClusterBinding,BindingOrDie,SAs,Users,ControllerRoleBindings,Resources,URLs,Has,NewRoleBindingForClusterRole,Names,NewString,NewRoleBinding,RuleOrDie,Groups,ClusterRoleBindings,ClusterRoles,Sprintf,Intersection,NewRule,List,Insert] | otherwise roles returns a list of all cluster roles that can perform any action on every resource Read rules for all resources. | @deads2k we seem to have 3 different copies of `MastersGroup`. I do not know which one we want to use, and if we want to delete some of said copies. |
@@ -141,7 +141,7 @@ namespace System.Net.Http
// If we don't have content, or we are doing Expect 100 Continue, then we can't rely on
// this and must send our headers immediately.
- await _stream.WriteAsync(_sendBuffer.ActiveMemory, requestCancellationSour... | [Http3RequestStream->[ReadNextDataFrameAsync->[CopyTrailersToResponseMessage],DisposeSyncHelper->[Dispose],OnHeader->[OnHeader],Http3ReadStream->[Read->[ReadResponseContent],Dispose->[Dispose],ReadAsync->[ValueTask,ReadResponseContentAsync],Dispose],Trace->[Trace],Http3WriteStream->[Dispose->[Dispose]],ReadFrameEnvelop... | Sends the response asynchronously. Reads a response from the client. Get the next response message that can be read or read. check if a node - level cancellation token has occurred on our stream and throw it if. | We are already check that `_expect100ContinueCompletionSource != null` on line 138. So this would never be true as far as I can tell. (unless I miss something) |
@@ -121,6 +121,7 @@ function render_player( $player_data, $attributes ) {
$player_classes_name = trim( "{$secondary_colors['class']} {$background_colors['class']}" );
$player_inline_style = trim( "{$secondary_colors['style']} ${background_colors['style']}" );
+ $player_inline_style .= get_css_vars( $attributes );... | [render_block->[get_error_message]] | Renders a block of player data. Renders a podcast - player page. is_amp - Amp. | Does phpcs warn about unaligned equal signs? |
@@ -2412,6 +2412,11 @@ attr_check_input(int n, char const *const names[], void const *const values[],
return -DER_INVAL;
}
+ if (strnlen(names[i], DAOS_ATTR_NAME_MAX + 1) > DAOS_ATTR_NAME_MAX) {
+ D_ERROR("Invalid Arguments: names[%d] size > DAOS_ATTR_NAME_MAX",
+ i);
+ return -DER_INVAL;
+ }
if (s... | [No CFG could be retrieved] | Check for valid input of n - ary header. get the attributes of a single object. | The line length has just changed from 80 to 100 characters so you might be able not wrap this now. |
@@ -35,6 +35,12 @@ namespace Content.Client.EscapeMenu.UI.Tabs
private readonly List<Action> _deferCommands = new();
+ private void HandleToggleUSQWERTYCheckbox(BaseButton.ButtonToggledEventArgs args)
+ {
+ _cfg.SetCVar(CVars.DisplayUSQWERTYHotkeys, args.Pressed);
+ _cfg... | [KeyRebindTab->[BindButton->[RebindButtonPressed],EnteredTree->[EnteredTree],OnKeyBindModified->[UpdateKeyControl],ExitedTree->[ExitedTree],FrameUpdate->[FrameUpdate]]] | Creates a control that can be used to rebind a key to a control. Adds a key control that binds to the button and adds it to the menu. | @PJB3005 vibe check on this? |
@@ -72,6 +72,8 @@ class NpmResolver(Subsystem, NodeResolverBase):
force = force if force is not None else self.get_options().force
frozen_lockfile = frozen_lockfile if frozen_lockfile is not None else self.get_options().frozen_lockfile
+ if target.is_synthetic:
+ frozen_lockfile = False
if ... | [NpmResolver->[_link_source_dependencies->[_scoped_package_name,node_path,relative_symlink,_get_target_from_package_name,join,items],_scoped_package_name->[chunk,split,debug,len,format,join],register_options->[register,register_resolver_for_type,super],_emit_package_descriptor->[dump,reference,debug,pop,isfile,node_pat... | Installs the node_package target in the results directory copying sources if necessary. Resolve a node package module locally. Checks if missing dependencies are installed in the build graph and if so installs them. | Can you add a description why this is happening? Something like a synthetic target requires a dependency on thrift, and this is needed to hydrate a proper lock file during the install phase |
@@ -203,7 +203,7 @@ namespace System.Net.Sockets
break;
case AddressFamily.Unix:
- socketAddress = new Internals.SocketAddress(_addressFamily, buffer);
+ socketAddress = new Internals.SocketAddress(_addressFamily, buffer.Slice... | [Socket->[DoBeginSendTo->[SocketError],SetIPProtectionLevel->[SetIPProtectionLevel],SetLingerOption->[SetLingerOption],DoBind->[Bind],Send->[Send],ConnectAsync->[Connect,ConnectAsync,CanUseConnectEx,CanTryAddressFamily],Shutdown->[Shutdown],UpdateStatusAfterSocketError->[SetToDisconnected,UpdateStatusAfterSocketError],... | Get the next unused end point from the buffer. check if the socket is connected and if it is connect to the right end point. | Why don't we need to slice for IPv4 or IPv6 above? |
@@ -156,4 +156,7 @@ function cleanupOldServerFiles(generator, javaDir, testDir, mainResourceDir, tes
generator.removeFile(`${testDir}web/rest/ProfileInfoResourceIntTest.java`);
generator.removeFile('gradle/mapstruct.gradle');
}
+ if (generator.isJhipsterVersionLessThan('5.2.1')) {
+ gen... | [No CFG could be retrieved] | remove all resources. | @vishal423 Is this the correct version to use? `ElasticsearchConfiguration.java` is removed in this PR and no longer needed in 5.2.2+. |
@@ -139,7 +139,7 @@ public class StreamWriteFunction<I> extends AbstractStreamWriteFunction<I> {
public void close() {
if (this.writeClient != null) {
this.writeClient.cleanHandlesGracefully();
- this.writeClient.close();
+ // this.writeClient.close();
}
}
| [StreamWriteFunction->[flushBucket->[writeBuffer,preWrite],bufferRecord->[trace,detect,reset,DataBucket,fromHoodieRecord,getBucketID,countDown],DataItem->[fromHoodieRecord->[DataItem]],flushRemaining->[writeBuffer,reset,hasData,preWrite],DataBucket->[reset->[reset]],close->[close]]] | Closes the connection if it has a reserved reserved reserved reserved reserved reserved reserved reserved reserved reserved reserved. | Why doesn't this invoke the `close` method of the write client? |
@@ -925,8 +925,11 @@ class DataflowRunner(PipelineRunner):
(transform_proto.spec.urn == common_urns.primitives.PAR_DO.urn or
use_unified_worker)):
# Patch side input ids to be unique across a given pipeline.
- if (label_renames and
- transform_proto.spec.urn == common_urns.primit... | [_DataflowIterableAsMultimapSideInput->[__init__->[_side_input_data]],_DataflowIterableSideInput->[__init__->[_side_input_data]],DataflowRunner->[_get_encoded_output_coder->[_get_typehint_based_encoding],flatten_input_visitor->[FlattenInputVisitor],_add_singleton_step->[_get_side_input_encoding],run_Flatten->[_get_enco... | This function runs the pardo transform on the node. Creates a step for the pardo labeling. Add properties to the pipeline and the pipeline. Add the typehint to the description. | It seems cleaner to simply not populate the label_renames map in this case rather than add a branch here. |
@@ -165,6 +165,11 @@ public class DeploymentServiceTestCase extends AbstractMuleTestCase {
private static final File echoTestJarFile =
new CompilerUtils.JarCompiler().compiling(getResourceFile("/org/foo/EchoTest.java")).compile("echo.jar");
+ private static final File defaulServiceSchedulerJarFile = new Co... | [DeploymentServiceTestCase->[assertUndeploymentSuccess->[describeFailure->[describeFailure]],assertDeploymentFailure->[describeFailure->[describeFailure],assertDeploymentFailure],assertStatus->[assertStatus],assertMuleContextCreated->[describeFailure->[describeFailure]],addPackedDomainFromBuilder->[addPackedDomainFromB... | This method is used to create a list of all the possible configuration files. This is a hack to avoid the need for the compiler to be refactored out. | Is reuqired that the version is the same as the mule version? If not, use 1.0 or similar |
@@ -67,8 +67,7 @@ module.exports = class binance extends Exchange {
'www': 'https://www.binance.com',
'referral': 'https://www.binance.com/?ref=10205187',
'doc': [
- 'https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.... | [No CFG could be retrieved] | Return a dictionary of all the possible values for a specific order identifier. This structure is used to provide a list of all of the API endpoints that are used in. | Hey! ) Are you sure that this is the official doc? |
@@ -39,6 +39,8 @@ def test_install_and_uninstall(install_mockery, mock_fetch, monkeypatch):
with pytest.raises(spack.repo.UnknownPackageError):
spec.package
+ module_path = spack.modules.common.get_module('tcl', spec, True)
+ assert module_path
pkg.do_uninstall()
exce... | [test_partial_install_keep_prefix->[MockStage],MockStage->[destroy->[destroy],create->[create]],test_partial_install_delete_prefix_and_stage->[RemovePrefixChecker,MockStage]] | Install and uninstall a package. | Can you factor this out into a separate test? This should be a test of the module system, not a test of the install method. |
@@ -169,10 +169,15 @@ static void default_detect_test(struct comp_dev *dev,
uint32_t sample;
uint16_t valid_bits = cd->sample_valid_bytes * 8;
const int32_t activation_threshold = cd->config.activation_threshold;
+ uint32_t cycles_per_frame; /**< Clock cycles required per frame */
/* synthetic load */
- if (c... | [No CFG could be retrieved] | The main method of the detection. Frees the given keyphrase from memory. | Typo in commit message: "Then only a fraction" or just "For a single frame, only a fraction" |
@@ -38,11 +38,11 @@ public class JobId extends BaseId implements Serializable {
return new JobId(byteBuffer2Bytes(bb));
}
- public static JobId fromInt(int value) {
+ public static JobId fromShort(short value) {
byte[] bytes = new byte[JobId.LENGTH];
ByteBuffer wbb = ByteBuffer.wrap(bytes);
w... | [JobId->[genNil->[JobId],fromInt->[JobId],fromByteBuffer->[JobId],fromHexString->[JobId]]] | This method converts a byte array to a JobId using the int value. | As discussed offline, 2 bytes is too short for job id. @edoakes will increase this length. So we can still keep the value as an integer. |
@@ -82,7 +82,7 @@ class InvertedResidual(nn.Module):
self.block = nn.Sequential(*layers)
self.out_channels = cnf.out_channels
- self.is_strided = cnf.stride > 1
+ self._is_cn = cnf.stride > 1
def forward(self, input: Tensor) -> Tensor:
result = self.block(input)
| [mobilenet_v3_small->[_mobilenet_v3,adjust_channels],InvertedResidual->[__init__->[SqueezeExcitation]],_mobilenet_v3->[MobileNetV3],MobileNetV3->[forward->[_forward_impl]],mobilenet_v3_large->[_mobilenet_v3,adjust_channels]] | Initialize a Network with a sequence of hidden - block chains. | out of curiosity, what does `cn` mean in here |
@@ -64,7 +64,7 @@ func (h *regionHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
return
}
- region, leader := cluster.GetRegionAndLeader(regionID)
+ region, leader := cluster.GetRegionAndLeaderByID(regionID)
regionInfo := ®ionInfo{
Region: region,
Leader: leader,
| [ServeHTTP->[GetRaftCluster,Vars,GetRegions,JSON,ParseUint,GetRegionAndLeader]] | ServeHTTP handles the request for a single region. | why not using GetRegion directly? |
@@ -36,7 +36,7 @@ class Intltool(AutotoolsPackage):
version('0.51.0', '12e517cac2b57a0121cda351570f1e63')
# requires XML::Parser perl module
- # depends_on('perl@5.8.1:', type='build')
+ depends_on('perl-xml-parser', type=('build', 'run'))
def check(self):
# `make check` passes but cau... | [Intltool->[setup_dependent_package->[_make_executable]]] | Check if the current node is a node type. | This probably also requires Perl. |
@@ -576,6 +576,13 @@ class FormTableCell(FormContent):
text_content=get_elements(cell, read_result) if cell.elements else None
)
+ def __repr__(self):
+ return "FormTableCell(text={}, row_index={}, column_index={}, row_span={}, column_span={}, " \
+ "bounding_box={}, con... | [TrainingDocumentInfo->[_from_generated->[_from_generated]],FormField->[_from_generated->[get_field_value,_from_generated],_from_generated_unlabeled->[_from_generated_unlabeled]],FormWord->[_from_generated->[Point]],FormLine->[_from_generated->[_from_generated,Point]],FieldText->[_from_generated->[get_elements,Point],_... | Create a new HeaderCell object from generated data. | does text_content need to be wrapped in a repr here? |
@@ -476,9 +476,9 @@ func (r *glusterfsVolumeProvisioner) Provision() (*api.PersistentVolume, error)
return nil, err
}
r.provisioningConfig = *cfg
-
glog.V(4).Infof("glusterfs: creating volume with configuration %+v", r.provisioningConfig)
- glusterfs, sizeGB, err := r.CreateVolume()
+ reqGid = gidMin + gidRand... | [TearDown->[GetPath],newMounterInternal->[getGlusterVolumeSource],Provision->[GetAccessModes],deleteEndpointService->[Delete]] | Provision creates a glusterfs volume. | What makes sure the next call to Provision doesn't pick the exact same `reqGid`? Also how is this GID ever checked against an SCC? |
@@ -153,15 +153,6 @@ class WikiDocumentType(document.DocType):
'snowball',
],
},
- 'case_sensitive': {
- 'type': 'custom',
- 'tokenizer': 'keyword'
- },
- 'case_insensitive_k... | [WikiDocumentType->[get_connection->[get_connection],bulk_delete->[get_doc_type,get_connection],get_indexable->[get_model],get_settings->[get_analysis,get_mapping],bulk_index->[get_doc_type,get_connection],search->[get_connection,get_index],reindex_all->[get_indexable]]] | Get the analysis dictionary for the Kuma search. | Any reason to remove them? |
@@ -2379,6 +2379,10 @@ print_status_config(zpool_handle_t *zhp, status_cbdata_t *cb, const char *name,
(void) printf(gettext("all children offline"));
break;
+ case VDEV_AUX_BAD_LABEL:
+ (void) printf(gettext("invalid label"));
+ break;
+
default:
(void) printf(gettext("corrupted data"));
brea... | [zpool_do_list->[print_timestamp,pool_list_get,pool_list_count,pool_list_iter,print_header,usage,printf,zprop_free_list,gettext,getopt,get_interval_count,get_timestamp_arg,zprop_get_list,pool_list_free,fsleep,fprintf],zpool_do_remove->[zpool_vdev_remove,zpool_close,zpool_wait,usage,zpool_vdev_indirect_size,zpool_open,z... | prints status config ZFS - related functions prints the list of all configuration options that are not present in the system Z - Pool - Debug - Prints the message for all unknown errors and errors in the The main function that prints out the status of the vdev and all its children. | It seems like we should add this same case to `print_import_config()` so you'll get the same result from `zpool import` when scanning for exported pools which can be imported. |
@@ -245,9 +245,10 @@ func fixupTeamGetError(ctx context.Context, g *libkb.GlobalContext, e error, tea
case keybase1.StatusCode_SCTeamReadError:
g.Log.CDebugf(ctx, "replacing error: %v", e)
e.Desc = fmt.Sprintf("You are not a member of team %q; try `keybase team request-access %s` for access", teamDescriptor,... | [Error->[Sprintf,String,Seqno,PercentForm],Sprintf,StatusCode,CDebugf] | NewExplicitTeamOperationError creates a new explicit error from a keybase1. TeamApplication or Reports an error if the team is an implicit admin and not an explicit member. | fwiw i think we should not redefine the variable in the switch scope and use a a different name, maybe `err` for the argument and `e` for the cast type |
@@ -804,6 +804,11 @@ namespace Dynamo.Graph.Workspaces
writer.WritePropertyName(nameof(WorkspaceModel.Author));
writer.WriteValue(ws.Author);
+ // Linter
+ if(!(ws.linterManager is null))
+ serializer.Serialize(writer, ws.linterManager);
+
+
... | [NodeLibraryDependencyConverter->[WriteJson->[LogWarning,WriteStartArray,WriteStartObject,Nodes,WriteEndObject,Name,WriteValue,WritePropertyName,WriteEndArray,Moderate,ToString],ReadJson->[LogWarning,Package,TryParse,Format,TryGetValue,AddDependent,Enum,referenceTypeToken,Moderate,Load],CanConvert->[IsAssignableFrom],l... | Serialize the object in the JSON format. Serialize given node - data - list pairs into JSON. Private method to write out the BingdingTag - Object that contains the key and the. | please use `{}` |
@@ -283,3 +283,16 @@ intersphinx_mapping = {
'numpy': ('https://docs.scipy.org/doc/numpy', None),
'llvmlite': ('http://llvmlite.pydata.org/en/latest/', None),
}
+
+
+# -- Custom autogeneration ------------------------------------------------
+
+def _autogenerate():
+ from numba.scripts.generate_lower_... | [insert,split,abspath,join] | Returns a list of links to the numpy and llvmlite files. | Ideally there should be a way to only run _autogenerate() when required. I suppose this is adding some latency to the docs build time. |
@@ -1244,7 +1244,14 @@ class State:
def add_ancestors(self) -> None:
# All parent packages are new ancestors.
- ancestors = []
+ ancestors = [] # type: List[str]
+ if self.path is not None:
+ _, name = os.path.split(self.path)
+ base, _ = os.path.splitext(name... | [is_meta_fresh->[get_stat,log],NodeInfo->[dumps->[dumps]],dump_graph->[dumps,NodeInfo],load_graph->[mark_interface_stale,parse_file,State,has_new_submodules,fix_suppressed_dependencies],strongly_connected_components->[dfs->[dfs],dfs],order_ascc->[order_ascc],State->[parse_file->[parse_file,read_with_python_encoding,wra... | Add all ancestors to the node. | I think it'd be clearer if this used `[]` as the value instead of `ancestors` (which at this point is just a complex way to spell `[]`). Then I'd like to reorder things so that this block comes *before* `ancestors` is initialized. It probably won't need the annotation then. |
@@ -606,6 +606,18 @@ class InstallRequirement(object):
key=lambda x: x.count(os.path.sep) +
(os.path.altsep and x.count(os.path.altsep) or 0)
)
+ logger.warning(
+ (
+ 'Multiple "*.egg-info/" in "%(base)s... | [InstallRequirement->[from_path->[from_path],prepare_metadata->[_correct_build_location],install->[install_editable,prepend_root,move_wheel_files],uninstall->[check_if_exists],move_wheel_files->[move_wheel_files],_correct_build_location->[build_location],load_pyproject_toml->[load_pyproject_toml],archive->[_clean_zip_n... | Returns the path of the egg - info file. Returns the sequence number of nodes in the distribution. | These lines of text should be broken up so they do not exceed the column width limit. |
@@ -35,6 +35,7 @@ public class StreamInsertsSubscriber extends BaseSubscriber<KsqlObject> {
private int outstandingTokens;
private boolean drainHandlerSet;
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2")
public StreamInsertsSubscriber(final Context context, final HttpClientRequest httpRequest) {
super(... | [StreamInsertsSubscriber->[httpRequestReceptive->[checkRequest]]] | This class is used to stream the contents of a single object into a stream. Full - Checks if the request is complete. | Getting mutable fields as input... Need to suppress. |
@@ -48,7 +48,7 @@ namespace Microsoft.Extensions.Logging
throw new ArgumentNullException(nameof(settings));
}
- builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<ILoggerProvider>(new EventLogLoggerProvider(settings)));
+ builder.AddProvider(new EventLogL... | [EventLoggerFactoryExtensions->[ILoggingBuilder->[AddEventLog,nameof,TryAddEnumerable,ServiceDescriptor,Configure]]] | Add an event log to the builder. | Thanks for the PR @wrzucher. We normally get to review PRs faster than this. Now that 6.0 issues are finishing up we're ramping back up with the 7.0 milestone PRs and will make sure to get this in as well. First question here, if you're adding `AddProvider` here why not also on line 28 in the other overload? |
@@ -162,7 +162,7 @@ class WPSEO_Post_Type_Sitemap_Provider implements WPSEO_Sitemap_Provider {
$url = $this->get_url( $post );
- if ( ! isset( $url['loc'] ) || in_array( $url['loc'], $stacked_urls ) ) {
+ if ( ! isset( $url['loc'] ) || isset( $stacked_urls[ $url['loc'] ] ) ) {
continue;
}
| [WPSEO_Post_Type_Sitemap_Provider->[get_post_type_count->[get_var,get_sql_where_clause],get_posts->[prepare,get_results,get_sql_where_clause],get_index_links->[get_post_type_count,prepare,get_col],save_post->[is_valid_post_type],get_url->[calculate_priority,get_images],get_sitemap_links->[get_post_type_count,get_first_... | Get the links for a given post type. Filter URL entry before it gets added to the sitemap. | This won't work now since URLs aren't used as keys in this array. |
@@ -136,7 +136,10 @@ class RPC:
'ask_strategy': config.get('ask_strategy', {}),
'bid_strategy': config.get('bid_strategy', {}),
'state': str(botstate),
- 'runmode': config['runmode'].value
+ 'runmode': config['runmode'].value,
+ 'position_adjustmen... | [RPC->[_rpc_status_table->[RPCException],_rpc_trade_status->[RPCException],_rpc_analysed_history_full->[_convert_dataframe_to_dict,RPCException],_rpc_stats->[trade_win_loss],_rpc_monthly_profit->[RPCException],_rpc_forcesell->[RPCException,_exec_forcesell],_rpc_analysed_dataframe->[_convert_dataframe_to_dict],_rpc_bala... | Return a dict of options and values from the config dict. Get the status of a single critical node. Calculate the profit ratio of a single node. | I do appreciate adding this here - please also add it to `ShowConfig` (in `api_schemas.py`) to complete this. Otherwise it'll not be available via API. |
@@ -287,7 +287,7 @@ func (rm *runManager) ResumeAllPendingConnection() error {
logger.Errorw("Error saving run", run.ForLogger("error", err)...)
}
},
- models.RunStatusPendingConnection)
+ models.RunStatusPendingConnection, models.RunStatusPendingOutgoingConfirmations)
}
// ResumePendingBridgeTask wakes ... | [Create->[Ended,Started,GetStatus,Sprintf,Runnable,Archived,Debugw,Now,PushNow,String,Errorf,Run,CreateJobRun,Wrap,FindJob,ForLogger,Unscoped],ResumeAllInProgress->[UnscopedJobRunsWithStatus],ResumePendingBridge->[GetStatus,NextTaskRun,saveAndResumeIfInProgress,FindJobRun,PendingBridge,Debugw,updateWithError,ApplyBridg... | ResumeAllPendingConnection resumes all pending connection and all pending bridge. | Does this belong in this PR? |
@@ -472,6 +472,7 @@ module.exports = class extends PrivateBase {
{ name: 'Greek', value: 'el' },
{ name: 'Hindi', value: 'hi' },
{ name: 'Hungarian', value: 'hu' },
+ { name: 'Bahasa Indonesia', value: 'id' },
{ name: 'Italian', value: 'it' },
... | [No CFG could be retrieved] | get all the languages options supported by JHipster Adds a new social configuration in the application. yml. | here it should be called Indonesian. I'll change it |
@@ -638,7 +638,17 @@ func resourceSqlDatabaseInstanceRead(d *schema.ResourceData, meta interface{}) e
}
_settingsList := d.Get("settings").([]interface{})
- _settings := _settingsList[0].(map[string]interface{})
+ var _settings map[string]interface{}
+
+ // If we're importing the settings will be nil
+ if len(_se... | [Printf,GetChange,MatchString,GetOk,UniqueId,Do,Sprintf,Partial,HasChange,List,TrimPrefix,Delete,Insert,Errorf,SetId,Get,Set,Update] | resourceSqlDatabaseInstanceRead deletes the default root User from the database. At most one backup_configuration block is allowed. | We should perform this `d.Set` in every Read instead of only during imports; this file was written as if Terraform was a non-authoritative tool, but our current standard is to make it one. |
@@ -2048,13 +2048,9 @@ class PackageBase(with_metaclass(PackageMeta, PackageViewMixin, object)):
return
for name in self.build_time_test_callbacks:
- try:
- fn = getattr(self, name)
- tty.msg('RUN-TESTS: build-time tests [{0}]'.format(name))
- ... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],setup_build_environment->[_get_legacy_environment_method],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_uninstall->[uninstall_by_spec],possible_dependencies->[p... | Private method to call all the default build - time test callbacks. | This try-except was masking a bug in my code that I didn't discover until after I removed it. Personally, I think we shouldn't be catching the exception, and raise an error if a non-existent test function is requested. For most build systems, we implement an empty test method with `pass` anyway, so it shouldn't fail. |
@@ -14,7 +14,7 @@ namespace NServiceBus.AcceptanceTests.Sagas
[TestFixture]
public class When_adding_state_to_context : NServiceBusAcceptanceTest
{
- [Test]
+ [Test, Ignore("Not sure what to do here, since the start message has no corr prop we can't generate the SagaId, perhaps custom finde... | [When_adding_state_to_context->[Task->[SomeData,AreEqual,FinderUsed,Run,True],SagaEndpoint->[TestSaga07->[Task->[FromResult]],CustomFinder->[FindBy->[ContextBag,FromResult,FinderUsed]],BehaviorWhichAddsThingsToTheContext->[Task->[Set,next]],Register]]] | Tests that context bag is available to finder context. | If I remember correctly from the time I spent in the InMemory persister, custom finders could not work there at all. |
@@ -208,12 +208,14 @@ var (
AllowedTypes []string `delim:"|"`
FileMaxSize int64
MaxFiles int
+ AutoCreate bool
}{
Enabled: true,
TempPath: "data/tmp/uploads",
AllowedTypes: []string{},
FileMaxSize: 3,
MaxFiles: 5,
+ AutoCreate: false,
},
// Repositor... | [DelLogger,KeysHash,MustCompilePOSIX,Warn,NewWithClaims,TempDir,Info,MapTo,New,Split,MustString,SetUseHTTPS,NewSection,NewXORMLogger,Getenv,Trim,IsFile,Dir,TrimRight,Now,Close,ReadFull,Append,LookPath,Create,Section,GetSection,ToLower,MkdirAll,BinVersion,MustDuration,Minutes,Decode,Keys,Fatal,HomeDir,Count,MustBool,For... | Initialization of the repository object. OrgPagingNum - Paging number of the user s repository and the user s. | `bool` is `false` by default, don't need to be set. |
@@ -782,11 +782,12 @@ export class AmpStory extends AMP.BaseElement {
page.setState(PageState.NOT_ACTIVE);
this.upgradeCtaAnchorTagsForTracking_(page, index);
});
+ this.initializeStoryNavigationPath_();
})
.then(() => this.initializeBookend_())
.... | [AmpStory->[onBookendStateUpdate_->[BOOKEND_ACTIVE],getHistoryState_->[getState],isBrowserSupported->[Boolean,CSS],isStandalone_->[STANDALONE],onUIStateUpdate_->[DESKTOP_PANELS,MOBILE,DESKTOP_FULLBLEED],closeOpacityMask_->[dev,toggle],updateBackground_->[url,computedStyle,color],layoutCallback->[resolve,isBrowserSuppor... | Private method called when story is rendered. Promise that will be resolved when the story is loaded. | this feature is still under an experiment no? If so, I would wrap this with the `isExperimentOn(this.win, 'amp-story-branching')`, in the case we rollback/promote the experiment it's easier to spot the code that needs to be changed/removed. |
@@ -27,7 +27,7 @@
.ThrowIfNull()
.ConfigureAwait(false);
}
- catch (Exception e)
+ catch (Exception e) when (!(e is OperationCanceledException))
{
e.Data["Message type"] = context.MessageMetadata.MessageType.FullN... | [InvokeHandlerTerminator->[Task->[GetType,ThrowIfCancellationRequested,UtcNow,Data,NotFound,FullName,MessageHandler,ToWireFormattedString,ConfigureAwait,SagaType,TryGet]]] | Override this method to invoke a message handler if it exists. | Since this rethrows wouldn't it be ok to catch all exception since we're enriching the exception data and that seems to make sense for handlers throwing OCE as well? |
@@ -157,7 +157,7 @@ func TestEthTxABIEncodeAdapter_Perform_ConfirmedWithJSON(t *testing.T) {
from := cltest.GetAccountAddress(t, store)
assert.NoError(t, err)
app.EthMock.EventuallyAllCalled(t)
- txs, err := store.TxFrom(from)
+ txs, _ := store.TxFrom(from)
require.Len(t, txs, 1)
assert.Len(t, txs[0].Attempts... | [Context,Value,NewHash,Perform,TxFrom,False,Encode,StartAndConnect,NewBig,GetAccountAddress,Error,Int,ChainID,EventuallyAllCalled,To,Len,HasError,DecodeEthereumTx,Join,Equal,Data,Valid,MustHash,Parallel,NoError,Get,Register,NewRunInputWithString,NewType,NewApplicationWithKey,HexToAddress,Sprintf,Unmarshal,NewInt,String... | GetAccountAddress returns the account address of the last transaction in the account store. | I mean, probably we should `require.NoError` instead, right? |
@@ -15,6 +15,12 @@ def class_extensions():
def Lambda(self, value):
self._parms["lambda"] = value
+ def _additional_used_columns(self, parms):
+ """
+ :return: Gam columns if specified.
+ """
+ return parms["gam_columns"]
+
extensions = dict(
__imports__="""import h2... | [update_param->[param],dict] | Class extensions for the sequence of functions. | I don't understand the use of addtional_used_columns. What is the term used for? |
@@ -78,9 +78,11 @@ public class ShibbolethIdPEntityIdAuthenticationServiceSelectionStrategy impleme
final List<String> params = Splitter.on("=").splitToList(p);
return Pair.of(params.get(0), params.get(1));
})
- .f... | [ShibbolethIdPEntityIdAuthenticationServiceSelectionStrategy->[resolveServiceFrom->[debug,isPresent,get,getEntityIdAsParameter,createService,getId],supports->[concat,isPresent,matches],getEntityIdAsParameter->[getValue,split,getMessage,of,error,isPresent,findFirst,getHttpServletRequestFromExternalWebflowContext,URIBuil... | Gets entityId as parameter. | Same as above, with log placeholders. |
@@ -15,15 +15,17 @@ class Gchp(CMakePackage):
maintainers = ['williamdowns']
+ version('13.0.2', git='https://github.com/geoschem/GCHP.git',
+ commit='017ad7276a801ab7b3d6945ad24602eb9927cf01', submodules=True)
version('13.0.1', git='https://github.com/geoschem/GCHP.git',
commi... | [Gchp->[install->[join_path,super,move],cmake_args->[define,define_from_variant],variant,depends_on,version,patch]] | Creates a object for the given sequence number. Create a command line argument list for the n - tuple of the n - tuple of the. | This probably needs a `git=` argument. Can you try to put a single attribute at the class level below `url`? |
@@ -76,6 +76,7 @@ class Message < ApplicationRecord
return if channel.open?
errors.add(:base, "You are not a participant of this chat channel.") unless channel.has_member?(user)
+ errors.add(:base, "Something went wrong") if channel.status == "blocked"
end
def rich_link_article(link)
| [Message->[evaluate_markdown->[evaluate_markdown]]] | Find a in the channel that the user is a member of. | Won't a more informative message be useful? |
@@ -854,7 +854,6 @@ func (pkg *pkgContext) genHeader(w io.Writer, goImports []string, importedPackag
pkgName = path.Base(pkg.mod)
}
- fmt.Fprintf(w, "// nolint: lll\n")
fmt.Fprintf(w, "package %s\n\n", pkgName)
var imports []string
| [genResource->[plainType,getDefaultValue,inputType,outputType],genType->[genInputTypes,genOutputTypes,details,genPlainType,tokenToType],plainType->[tokenToType,plainType],genFunction->[genPlainType],outputType->[tokenToType,outputType],getTypeImports->[getTypeImports,add],genConfig->[genHeader,getDefaultValue,getImport... | genHeader writes a header for the package package and imports. Returns a new object that represents the result of a call to the method. | This is mostly unrelated to other changes here - but part of overall cleaning up codegen. |
@@ -179,7 +179,7 @@ func (h *handler) admitBackupEntry(ctx context.Context, seedName string, request
return admission.Errored(http.StatusBadRequest, err)
}
- if resp := h.admit(seedName, backupEntry.Spec.SeedName); !resp.Allowed {
+ if resp := h.admit(seedName, backupEntry.Spec.SeedName, backupEntry.Status.SeedN... | [Handle->[admitLease,admitBastion,admitShootState,admitClusterRoleBinding,admitSeed,admitCertificateSigningRequest,admitSecret,Allowed,FromAuthenticationV1UserInfo,admitServiceAccount,admitBackupEntry,admitBackupBucket],allowIfManagedSeedIsNotYetBootstrapped->[admit,Allowed,Errorf,IsNotFound,Get,Errored,Key],admitLease... | admitBackupEntry admits a backup entry to the client. | I only see `update` calls for this use-case in the migration flow after having a quick look. Can you elaborate why we need to cover `BackupEntries` as well? |
@@ -13,11 +13,12 @@ namespace Content.Client.Graphics.Overlays
{
[Dependency] private readonly IPrototypeManager _prototypeManager = default!;
[Dependency] private readonly IEyeManager _eyeManager = default!;
+ [Dependency] private readonly IPlayerManager _playerManager = default!;
... | [CircleMaskOverlay->[Draw->[GetWorldViewport,White,DrawRect,UseShader],nameof,WorldSpace,InjectDependencies,Instance,CircleMaskOverlay]] | CircleMaskOverlay is a base class for all CircleMaskOverlays. | This feels hacky. |
@@ -521,7 +521,7 @@ class ConvectionDiffusionBaseSolver(PythonSolver):
self.settings["element_replace_settings"]["element_name"].SetString("EulerianConvDiff3D")
else:
self.settings["element_replace_settings"]["element_name"].SetString("EulerianConvDiff3D8N")
- ... | [ConvectionDiffusionBaseSolver->[_create_convergence_criterion->[_get_convergence_criterion_settings],_create_builder_and_solver->[get_linear_solver],_execute_after_reading->[import_materials],Initialize->[Initialize],_create_line_search_strategy->[GetComputingModelPart,get_solution_scheme,get_builder_and_solver,get_li... | Get element condition replace settings. Missing condition name in element replace settings. | I'd remove `Symbolic` keyword from the element name. We will do so in the FluidDynamicsApplication soon. |
@@ -241,14 +241,14 @@ end
# Reset the default locale, making sure that the previous default locale
# is also cleared from the fallbacks
def with_default_locale(locale)
- original_default_locale = I18n.default_locale
+ original_default_locale = AlaveteliLocalization.default_locale
original_fallbacks = I18n.fallb... | [with_hidden_and_successful_requests->[info_requests,save!,described_state,prominence],with_active_record_default_timezone->[default_timezone],with_default_locale->[fallbacks,default_locale],normalise_whitespace->[gsub],get_last_post_redirect->[first],with_duplicate_xapian_job_creation->[xapian_before_create_job_hook->... | Creates a block that yields a with the default locale. | > Update with_default_locale spec helper method to do what? :) |
@@ -45,7 +45,14 @@ namespace Microsoft.VisualBasic.IntegrationTests
public void MsgBox()
{
Process process = StartTestProcess("Interaction.MsgBox");
- TestHelpers.PressEnterOnProcess(process);
+ try
+ {
+ TestHelpers.PressEnterOnProcess(proc... | [InteractionTests->[EndProcess->[EndProcess],Shell->[Shell]]] | Tests if MsgBox or MsgBox_VbHost is a test. | will this not produce a false positive? |
@@ -1167,14 +1167,13 @@ class TestExtensionVersionFromUploadTransactional(
assert version.pk
# Only once instead of twice
- extract_mock.assert_called_once_with(
- version_id=version.pk, author_id=upload.user.pk)
+ create_entry_mock.assert_called_once_with(version=version)
... | [TestExtensionVersionFromUploadTransactional->[test_doesnt_commit_to_git_by_default->[get_upload],test_commits_to_git_async_only_if_version_created->[get_upload],test_commits_to_git_async->[create_new_version,get_upload],test_commits_to_git_waffle_enabled->[get_upload]],TestStaticThemeFromUpload->[test_new_version_with... | Tests that a version is created in the git repository asynchronously. | Should this test case be renamed? |
@@ -104,6 +104,9 @@ module.exports = async () => {
await prisma.user.findMany()
prisma.disconnect()
+
+ // flakyness :shrug:
+ await new Promise((r) => setTimeout(r, 200))
assert(requests.length === 2)
const count = await prisma.user.count()
| [No CFG could be retrieved] | INSERT INTO public. User ( email id name ) Query raw data with specific type of element. | Do you know waht's fleaky |
@@ -154,9 +154,6 @@ EOT
$composer->getEventDispatcher()->dispatchScript(ScriptEvents::POST_ROOT_PACKAGE_INSTALL, $installDevPackages);
}
- $rootPackageConfig = $composer->getConfig();
- $this->updatePreferredOptions($rootPackageConfig, $input, $preferSource, $preferDist);
-
... | [CreateProjectCommand->[createDownloadManager->[createDownloadManager]]] | Installs a project. Removes a VCS if it is not already there. Remove all packages from composer directory. | This is not equivalent. The installation of deps uses a **different** config instance, because it takes the project-level config into option once it has the code of the project. |
@@ -212,6 +212,7 @@ class SubmissionCollector < ActiveRecord::Base
grouping.save
new_submission = Submission.create_by_revision_number(grouping, rev_num)
+ apply_penalty_or_add_grace_credits(grouping, apply_late_penalty, new_submission)
#This is to help determine the progress of the method.
s... | [SubmissionCollector->[collect_next_submission->[instance,remove_grouping_from_queue],start_collection_process->[instance],manually_collect_submission->[start_collection_process,remove_grouping_from_queue]]] | This method is called by the child process when it is able to collect a specific from. | Line is too long. [84/80] |
@@ -151,6 +151,15 @@ angular.module('zeppelinWebApp').service('websocketMsgSrv', function($rootScope,
});
},
+ importNoteFromIpfs: function(hashUrl) {
+ websocketEvents.sendNewEvent({
+ op: 'IMPORT_NOTE_URL',
+ data: {
+ hash: hashUrl
+ }
+ });
+ },
+
che... | [No CFG could be retrieved] | Listens to the events of the in the WebSocket. This function returns true if the connection to the server is established. | I think this might be called more generic, somethin like `importNoteFromBackend` as it may be another NotebookRepo implementation configured that actuallys upports same backend-style import. How do you think? |
@@ -59,7 +59,7 @@ public class HoodieClusteringJob {
public HoodieClusteringJob(JavaSparkContext jsc, Config cfg) {
this.cfg = cfg;
this.jsc = jsc;
- this.props = cfg.propsFilePath == null
+ this.props = (cfg.propsFilePath == null || cfg.propsFilePath.isEmpty())
? UtilHelpers.buildProperties... | [HoodieClusteringJob->[main->[HoodieClusteringJob,Config],doCluster->[getSchemaFromLatestInstant],doScheduleAndCluster->[getSchemaFromLatestInstant,doSchedule],doSchedule->[getSchemaFromLatestInstant,doSchedule],cluster->[validateRunningMode]]] | Read the configuration from the file system. | you can use stringutils here |
@@ -44,7 +44,7 @@ public final class Deployments {
new File("target/test-libs/infinispan-commons.jar"),
new File("target/test-libs/caffeine.jar"),
new File("target/test-libs/rxjava.jar"),
- new File("target/test-libs/reactive-streams.jar"),
+ ... | [Deployments->[createBaseTestDeployment->[addPackage,getPackage],createNodeAuthTestDeployment->[File,addAsResource],createKrbLdapTestDeployment->[File,addAsWebInfResource],createLdapTestDeployment->[createBaseTestDeployment],createNodeAuthKrbTestDeployment->[File,addAsWebInfResource]]] | Creates a base test deployment. | this should be `reactive-streams.jar` |
@@ -15,6 +15,9 @@ using ProtoCore.Namespace;
namespace Dynamo.Graph.Workspaces
{
+ /// <summary>
+ /// Extension of standard WorkspaceModel. Represents workspace of CustomNode inner functionality.
+ /// </summary>
public class CustomNodeWorkspaceModel : WorkspaceModel, ICustomNodeWorkspaceModel
{... | [CustomNodeWorkspaceModel->[NodeModified->[NodeModified,RequestRun],PopulateXmlDocument->[PopulateXmlDocument],SaveAs->[SaveAs,SetInfo],RequestRun->[RequestRun]]] | Creates a new instance of the CustomNodeWorkspaceModel class. OnPropertyChanged - Registers PropertyChangedEventHandler to check if the CustomNode has Unsaved. | This class contains methods and properties that defines a customnodeworkspace. |
@@ -3245,6 +3245,18 @@ DataReaderImpl::unregister_for_writer(const RepoId& participant,
TransportClient::unregister_for_writer(participant, readerid, writerid);
}
+void
+DataReaderImpl::update_locators(const RepoId& writerId,
+ const TransportLocatorSeq& locators)
+{
+ ACE_READ_GUA... | [No CFG could be retrieved] | - > Iterator of all writers Reads the next N - tuples from the writers array. | Do you need to hold the writers_lock while calling update_locators? Compare with DataWriterImpl::update_locators where we're grabbing two locks (do we need a global lock here as well, or can we remove the global lock from the other one, or are they substantially different?) Also, as a side note, what's with all these R... |
@@ -246,6 +246,7 @@ namespace Content.Shared.Atmos
/// <summary>
/// Gases to Ids. Keep these updated with the prototypes!
/// </summary>
+ [Serializable, NetSerializable]
public enum Gas : sbyte
{
Oxygen = 0,
| [Atmospherics->[NextMultipleOf]] | All of the constants for the Gas to Ids. | why is this needed? |
@@ -427,10 +427,12 @@ int pkcs12_main(int argc, char **argv)
#endif
}
- if (key_pbe == PKCS12_DEFAULT_PBE)
+ if (key_pbe == NID_undef)
key_pbe = NID_pbe_WithSHA1And3_Key_TripleDES_CBC;
if (enc == default_enc)
enc = EVP_des_ede3_cbc();
+ if (macalg == N... | [No CFG could be retrieved] | This function is called from NID_export_check_keys. It will load the with - SHA1And3_Key_TripleDES_CBC - with - CBC. | Shouldn't this change (also in in the doc) to `"sha256"`? |
@@ -56,7 +56,10 @@ class SlicePluginTRTTest(InferencePassTest):
if core.is_compiled_with_cuda():
use_gpu.append(True)
for i in range(len(use_gpu)):
- self.check_output_with_option(use_gpu[i])
+ atol = 1e-5
+ if self.trt_parameters.precision == AnalysisConf... | [SlicePluginTRTTest->[setUp->[setUpSliceParams,setUpTensorRTParams]]] | Test if the output of the nanoseconds function is correct. | AnalysisConfig.Precision.Half: atol 1e - 3 |
@@ -399,6 +399,8 @@ static void add_file(struct vlc_source *c, struct darray *array,
new_media = create_media_from_file(path);
if (new_media) {
+ libvlc_media_add_option_(new_media, ":network-caching=100");
+
data.path = new_path.array;
data.media = new_media;
da_push_back(new_files, &data);
| [bool->[dstr_free,dstr_cmp,dstr_copy,dstr_ncopy,strchr],obs_properties_t->[obs_properties_create,dstr_cat,dstr_resize,pthread_mutex_lock,obs_properties_add_list,dstr_free,dstr_replace,dstr_copy,obs_properties_add_bool,da_end,obs_properties_add_editable_list,strrchr,dstr_cat_dstr,obs_property_list_add_string,pthread_mut... | Adds a file to the list of files. | This should really be an option. 100ms is to reduce buffering on a local network device. |
@@ -40,7 +40,7 @@ import org.apache.calcite.schema.SchemaPlus;
import org.apache.calcite.schema.TranslatableTable;
/** Adapter from {@link BeamSqlTable} to a calcite Table. */
-class BeamCalciteTable extends AbstractQueryableTable
+public class BeamCalciteTable extends AbstractQueryableTable
implements Modifia... | [BeamCalciteTable->[toModificationRel->[BeamIOSinkRel],getRowType->[getSchema,toCalciteRowType],toRel->[BeamIOSourceRel,getCluster],asQueryable->[UnsupportedOperationException]]] | create a new object in the Sequelize Model class. This method is used to create a new instance of the BeamIOSourceRel. | `BeamCalciteTable` is a private wrapper for use by `BeamCalciteSchema`, you shouldn't need to access it directly. |
@@ -121,6 +121,8 @@ def train(target,
def train_loop(main_program):
exe.run(fluid.default_startup_program())
+ if pure_bf16:
+ sgd_optimizer.amp_init(exe.place)
for pass_id in range(PASS_NUM):
for data in train_reader():
| [train->[get_place,__network__,train_loop,train],inject_test_method->[__impl__->[main]],infer->[get_place,to_infer_tensor],main->[train,infer],inject_test_method,main] | Train a network with a single n - word cross - entropy model. Train a network with a single n - word network. No - op if no node is running. | I am confused right now. There are two switches `use_bf16` and `pure_bf16`. If one set only `use_bf16` to true then `sgd_optimizer` is "decorated" with `amp.bf16` but it is not `amp_init` .. why? |
@@ -528,8 +528,6 @@ func (s *testHotReadRegionSchedulerSuite) TestWithPendingInfluence(c *C) {
testutil.CheckTransferLeader(c, op1, operator.OpLeader, 1, 3)
op2 := hb.Schedule(tc)[0]
testutil.CheckTransferPeerWithLeaderTransfer(c, op2, operator.OpHotRegion, 1, 4)
- op3 := hb.Schedule(tc)[0]
- testutil.CheckT... | [TestUpdateCache->[UpdateStorageReadBytes,NewCluster,AddLeaderRegionWithWriteInfo,NewScheduleOptions,RegionStats,Assert,AddRegionStore,AddLeaderRegionWithReadInfo,UpdateStorageWrittenBytes],TestWithPendingInfluence->[AddLeaderRegionWithWriteInfo,NewMemoryKV,NewOperatorController,NewCluster,Assert,clearPendingInfluence,... | TestWithPendingInfluence tests with pending influence AddLeaderRegionWithReadInfo - add read - info for leader regions Check if there are no pending influence operations. | Why remove it? |
@@ -391,11 +391,17 @@ public class WriteFilesTest {
timestamps.add(i + 1);
}
- SimpleSink sink = makeSimpleSink();
+ SimpleSink sink = makeSimpleSink(windowedWrites);
WriteFiles<String> write = WriteFiles.to(sink);
if (numConfiguredShards.isPresent()) {
write = write.withNumShards(n... | [WriteFilesTest->[testCustomShardedWrite->[getBaseOutputFilename,apply,makeSimpleSink],testBuildWrite->[makeSimpleSink],testDisplayData->[getBaseOutputDirectory],testShardedWrite->[getBaseOutputFilename],runShardedWrite->[apply,makeSimpleSink],LargestInt->[expand->[apply]],testEmptyWrite->[getBaseOutputFilename],testCu... | Runs a single sharded write on the specified file. | I think it will be easier to read all the tests if, instead of passing the parameters such as `numConfiguredShards`, `windowedWrites` etc., you make `runShardedWrite` take a `WriteFiles` instance directly. It's easier to read `WriteFiles.to(makeSimpleSink(true) /* windowedWrites */).withMaxNumWritersPerBundle(42)` than... |
@@ -127,6 +127,11 @@ func resourceAwsEcsService() *schema.Resource {
Elem: &schema.Schema{Type: schema.TypeString},
Set: schema.HashString,
},
+ "assign_public_ip": &schema.Schema{
+ Type: schema.TypeBool,
+ Optional: true,
+ Default: false,
+ },
},... | [GetChange,NewSet,UniqueId,Message,DescribeServices,HasPrefix,NonRetryableError,Code,Set,GetOk,HasChange,Errorf,SetId,MustCompile,RetryableError,UpdateService,FindAllStringSubmatch,CreateService,DeleteService,ToLower,Id,Int64,Get,Split,Printf,Sprintf,List,WaitForState,String,WriteString,Retry] | A list of all the resources that are required to have a resource with a specific resource type returns a schema. ResourceData for the host - instance - id - field - field. | You can remove `&schema.Schema` from this line here. |
@@ -136,10 +136,16 @@ class Jetpack_React_Page extends Jetpack_Admin_Page {
return; // No need for scripts on a fallback page
}
+ $script_deps_path = JETPACK__PLUGIN_DIR . '_inc/build/admin.deps.json';
+ $script_dependencies = file_exists( $script_deps_path )
+ ? json_decode( file_get_contents( $script_... | [Jetpack_React_Page->[get_initial_state->[get_dismissed_jetpack_notices],add_noscript_head_meta->[add_fallback_head_meta]]] | Enqueue admin scripts. | Do you know why `wp-i18n` was a dependency here? Looks like admin panel is using `import { translate as __ } from 'i18n-calypso';` instead. |
@@ -611,7 +611,7 @@ bool GUIChatConsole::OnEvent(const SEvent& event)
prompt.nickCompletion(names, backwards);
return true;
}
- else if(event.KeyInput.Char != 0 && !event.KeyInput.Control)
+ else if(isprint(event.KeyInput.Char) && !event.KeyInput.Control)
{
#if (defined(linux) || defined(__linux))
... | [drawPrompt->[draw],OnEvent->[closeConsole,closeConsoleAtOnce,OnEvent],closeConsoleAtOnce->[closeConsole],setVisible->[recalculateConsolePosition],animate->[recalculateConsolePosition],drawText->[draw]] | This method is called when a keyboard event is received from the chat window. Handles key input events Check if the user presses any key presses. This method handles keyboard operations on the prompt and the keyboard input. | I wonder which header is already including `<ctype.h>` Anyhow, I don't really understand what this and the following lines with the casts are actually doing (not what you added, what's already there). 'KeyInput.Char' is of type 'wchar_t' isn't it? So, a) I don't know if isprint() is really meant to be used with somethi... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.