patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -564,8 +564,8 @@ public class TestOracleTypeMapping @Test public void testSpecialNumberFormats() { - oracleServer.execute("CREATE TABLE test (num1 number)"); - oracleServer.execute("INSERT INTO test VALUES (12345678901234567890.12345678901234567890123456789012345678)"); + getOracl...
[TestOracleTypeMapping->[testTimestamp->[prestoCreateAsSelect],numberConvertToVarchar->[number],testLegacyDateMapping->[prestoCreateAsSelect],testTypeReadMapping->[oracleCreateAndInsert],testBooleanType->[prestoCreateAsSelect],oracleTable->[getSqlExecutor],testTypeMapping->[prestoCreateAsSelect],number->[number],testTi...
Special number formats for boolean types.
> Do not use oracleServer explicitly This is err prone. maybe we create explicit superclass which does not have `oracleServer` field, where the test live
@@ -91,7 +91,7 @@ public class DeckSpinnerSelection { } - public void initializeNoteEditorDeckSpinner(@NonNull Card currentEditedCard, boolean addNote) { + public void initializeNoteEditorDeckSpinner(@Nullable Card currentEditedCard, boolean addNote) { Collection col = mCollection; mDro...
[DeckSpinnerSelection->[notifyDataSetChanged->[notifyDataSetChanged],initializeNoteEditorDeckSpinner->[getDropDownView->[getDropDownView]]]]
Initializes the spinner which allows to select deck from the list of selected decks. This method cast the drop down items as text view and return the modified view if it is.
verified variable is null-checked internally in method :heavy_check_mark:
@@ -505,7 +505,8 @@ public class PTransformMatchersTest implements Serializable { public void writeWithRunnerDeterminedSharding() { ResourceId outputDirectory = LocalResources.fromString("/foo/bar", true /* isDirectory */); FilenamePolicy policy = DefaultFilenamePolicy.constructUsingStandardParameters( - ...
[PTransformMatchersTest->[createViewWithViewFn->[createViewWithViewFn,getAppliedTransform],createViewWithViewFnDifferentViewFn->[createViewWithViewFn,getAppliedTransform],parDoSingleWithState->[getAppliedTransform],createViewWithViewFnNotCreatePCollectionView->[createViewWithViewFn,apply,getAppliedTransform],classEqual...
This test method applies a write with runner - determined sharding.
Formatting is crazy here
@@ -67,3 +67,11 @@ func InitDiag(opts diag.FormatOptions) { contract.Assertf(snk == nil, "Cannot initialize diagnostics sink more than once") snk = diag.DefaultSink(os.Stdout, os.Stderr, opts) } + +// Plural uses a dumb pluralization scheme, simply appending an "s", to the given string s if c is not 1. +func Plura...
[DefaultSink,Assertf,Fd,IsTerminal,LookupEnv]
Initialize diagnostics sink.
lol. is tehre no Humanize Pluralize library already for go?
@@ -738,6 +738,11 @@ INPUT_PORTS_END static INPUT_PORTS_START( spaceat2 ) PORT_INCLUDE( sicv ) + PORT_MODIFY("IN0") + PORT_DIPNAME( 0x04, 0x00, DEF_STR( Difficulty ) ) /* [code: 0x18ca-d1] */ + PORT_DIPSETTING( 0x00, DEF_STR( Easy ) ) + PORT_DIPSETTING( 0x04, DEF_STR( Hard ) ) + PORT_MODIFY("IN2") PORT...
[No CFG could be retrieved]
- - - - - - - - - - - - - - - - - - - DIP_DIPNAME - DIPSETTING - 0x00 - 0.
Same for this one - does this bank of DIP switches have locations?
@@ -38,6 +38,7 @@ const files = { '.eslintrc.json', 'angular.json', 'ngsw-config.json', + 'README.md.jhi.client.angular', 'webpack/environment.js', 'webpack/proxy.conf.js', 'webpack/webpack.custom.js',
[No CFG could be retrieved]
This file is part of the JHipster project. It is part of the J includes all the files that are needed for the .
`README.md.jhi.client.angular` must be merged into `README.md.jhi.client`.
@@ -163,7 +163,7 @@ class CoCoInstanceSegmentationRepresentation(SegmentationRepresentation): masks = self.mask areas = [] for mask in masks: - areas.append(pycocotools.mask.area(mask)) + areas.append(maskUtils.area(mask)) return areas
[CoCoInstanceSegmentationRepresentation->[mask->[_load_mask]]]
Returns a list of all areas in the image.
Hmm, does this actually fix the problem? I think `maskUtils` is still undefined in this scope.
@@ -52,6 +52,7 @@ module GobiertoAdmin click_button "Create" assert has_message?("Page created successfully") + assert has_link?("View the page", href: "/s/participacion/new-page-with-section?preview_token=nick-preview-token") assert has_field?("page_slug", wi...
[CreateSectionItemTest->[collection->[gobierto_common_collections],section->[gobierto_cms_sections],site->[sites],cms_page->[gobierto_cms_pages],test_create_section_item->[visit,select_option,trigger,assert_equal,click_button,with_javascript,click_link,set,last,with_signed_in_admin,has_message?,title,with_current_site,...
Checks if the page has a missing page_item in the collection and creates a new page.
Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Line is too long. [128/80]
@@ -1329,6 +1329,7 @@ class PackageBase(six.with_metaclass(PackageMeta, PackageViewMixin, object)): checksum = spack.config.get('config:checksum') fetch = self.stage.managed_by_spack + if checksum and fetch and self.version not in self.versions: tty.warn("There is no checksum o...
[PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],setup_build_environment->[_get_legacy_environment_method],cache_extra_test_sources->[copy],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_uninstall->[uninstall_b...
Creates a stage directory and downloads the tarball for this package. Fetch a non - deprecated version of the object.
not needed for this PR
@@ -1,6 +1,6 @@ require 'rails_helper' -describe ClientApi::Users::InvitationsController, type: :controller do +describe ClientApi::Users::InvitationsController, type: :controller, broken: true do login_user let(:user_one) { User.first } let(:team_one) { create :team }
[email,create,to,new,let,have_http_status,describe,to_not,render_template,post,eq,first,it,require,id]
requires rails_helper.
Block has too many lines. [33/25]<br>Line is too long. [84/80]
@@ -755,6 +755,7 @@ func RegisterRoutes(m *macaron.Macaron) { m.Post("/lock", reqRepoIssueWriter, bindIgnErr(auth.IssueLockForm{}), repo.LockIssue) m.Post("/unlock", reqRepoIssueWriter, repo.UnlockIssue) m.Get("/attachments", repo.GetIssueAttachments) + m.Get("/attachments/:uuid", repo.GetAttachment) ...
[Status,StatusText,NewWithLogger,CORS,Redirect,Put,RequireRepoReaderOr,Post,New,Locale,ServerError,Any,Middleware,RequireRepoWriter,ColoredTime,Register,ColoredStatus,RepoAssignment,Csrfer,Cacher,RepoRefByType,Contexter,UnitGlobalDisabled,ColoredMethod,GetLevel,GetCommitsCount,RegisterRoutes,Dir,Now,RequireRepoReader,R...
API endpoint for issue update IssueAssignee adds all necessary routes to the issue assignee.
You should be able to download attachments for archived repositories
@@ -50,5 +50,8 @@ public class KafkaIndexTaskModule implements DruidModule @Override public void configure(Binder binder) { + binder.bind(new TypeLiteral<IndexTaskClientFactory<KafkaIndexTaskClient>>(){}) + .to(KafkaIndexTaskClientFactory.class) + .in(LazySingleton.class); } }
[KafkaIndexTaskModule->[getJacksonModules->[registerSubtypes,NamedType,of]]]
Configures the .
will this get new-line'ed on a code reformat?
@@ -30,10 +30,13 @@ public class CouchDbTicketRegistryConfiguration { @Autowired private CasConfigurationProperties casProperties; + @Autowired + private ObjectMapperFactory objectMapperFactory; + @RefreshScope @Bean public CouchDbConnectorFactory ticketRegistryCouchDbFactory() { - ...
[CouchDbTicketRegistryConfiguration->[ticketRegistry->[ticketRegistryCouchDbRepository]]]
TicketRegistryCouchDbRepository bean.
Probably should use a qualifier here to make overrides easier.
@@ -258,7 +258,7 @@ class TestPretrainedTransformerTokenizer(AllenNlpTestCase): ".", "</s>", "</s>", - "It", + "ĠIt", "Ġwas", "Ġa", "Ġsh",
[TestPretrainedTransformerTokenizer->[test_intra_word_tokenize->[intra_word_tokenize_sentence_pair,intra_word_tokenize,PretrainedTransformerTokenizer,split],test_token_idx_bert_uncased->[PretrainedTransformerTokenizer,tokenize],test_from_params_kwargs->[from_params,Params],test_token_idx_roberta->[PretrainedTransformer...
Test if a sequence of tokens is not empty.
Do you know why it's adding spaces to the first token? Is that expected?
@@ -29,7 +29,7 @@ public class DistributionResponseGenerator implements ResponseGenerator { public Response getResponse(CacheRpcCommand command, Object returnValue) { if (command.getCommandId() == ClusteredGetCommand.COMMAND_ID) { ClusteredGetCommand clusteredGet = (ClusteredGetCommand) co...
[DistributionResponseGenerator->[getResponse->[isReturnValueExpected,create,getCommand,getKey,handleWriteCommand,isAffectedByRehash,getCommandId],handleWriteCommand->[isReturnValueExpected,create]]]
This method is called to get the appropriate response based on the command and the return value.
I think checking `distributionManager.isAffectedByRehash(clusteredGet.getKey()))` is still not ok, we should check if the topology id changed instead. What if the joiner receives the ClusteredGetCommand before it applied the value, gets a null from `GetKeyValueCommand.perform()`, then applies the value and finishes the...
@@ -11,7 +11,7 @@ internal static partial class Interop internal static partial class User32 { [DllImport(Libraries.User32, ExactSpelling = true)] - public static extern BOOL GetWindowRect(IntPtr hWnd, ref RECT rect); + public unsafe static extern BOOL GetWindowRect(IntPtr hWnd, ref REC...
[Interop->[User32->[BOOL->[GetWindowRect,Handle,Wrapper,User32,KeepAlive]]]]
Get the window rectangle.
Why is `unsafe` needed?
@@ -91,7 +91,11 @@ func newChain(dbchain types.Chain, opts ChainSetOpts) (*chain, error) { if cfg.EthereumDisabled() { headTracker = &headtracker.NullTracker{} } else if opts.GenHeadTracker == nil { - headTrackerLogger, err2 := l.NamedLevel(logger.HeadTracker, headTrackerLL) + var ll zapcore.Level + if err2 :...
[Start->[Start],Close->[Close],Ready->[Ready],Healthy->[Healthy]]
newChainID creates a new chain ID. Allocate a new from the head of the chain.
I think we should remove this configurable head tracker logging. AFAIK nobody is using it and it complicates things a lot.
@@ -93,6 +93,13 @@ class RequestPasswordReset(BaseMutation): required=True, description="Email of the user that will be used for password recovery.", ) + redirect_url = graphene.String( + required=True, + description=( + "Url of storefront v...
[BaseAddressUpdate->[clean_input->[can_edit_address]],SetPassword->[save->[save],Arguments->[SetPasswordInput]],BaseAddressDelete->[clean_instance->[can_edit_address],perform_mutation->[clean_instance]],RequestPasswordReset->[perform_mutation->[send_user_password_reset_email,RequestPasswordReset]],BaseCustomerCreate->[...
Constructor for user - related methods that can be used to set password from a token sent by Create an AddressInput object for an .
I would reword this a little bit. We could also provide an example here of expected format using the example.com domain. "URL of a view where users should be redirected to reset the password. URL in RFC 1808 format e.g. <example>" Ideally, we should have our own `URL` scalar that we could use across the entire API that...
@@ -684,6 +684,11 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu labels := node.Metadata.Labels Expect(labels).To(HaveKeyWithValue("kubernetes.io/role", role)) Expect(labels).To(HaveKey(fmt.Sprintf("node-role.kubernetes.io/%s", role))) + if role == "master" && comm...
[ValidateOmsAgentLogs,ParseInput,CreatePVCFromFileDeleteIfExist,HasPrefix,Should,WaitOnReadyMin,GetAll,WaitForIngress,GetAllRunningByPrefixWithRetry,New,CreateServiceFromFileDeleteIfExist,IsWindows,IsLargeVMSKU,RunLinuxDeployDeleteIfExists,Bool,RequiresDocker,ValidateResources,CreateIfNotExist,PrintCommand,ReadString,S...
Check that all nodes in the cluster are in the same order as the nodes in the cluster running checks that the coredns componentry is running.
Is this >= 1.17.1 correct? Shouldn't it be 1.18.0-alpha.1?
@@ -848,7 +848,6 @@ python_tests( self.assertEqual([1, 2, 5, 6], all_statements) self.assertEqual([2], not_run_statements) - @ensure_cached(PytestRun, expected_num_artifacts=1) def test_sharding(self): shard0_failed_targets = self.try_run_tests(targets=[self.red, self.green], test_shard='0/2') ...
[PytestTestEmpty->[test_empty->[run_tests]],PytestTest->[test_sharding->[try_run_tests],test_red->[run_failing_tests],test_issue_7749->[run_with_junit_xml_dir],test_error->[run_failing_tests],test_error_outside_function->[run_failing_tests],test_coverage_auto_option_green->[run_coverage_auto],test_caches_greens_fast->[...
Test coverage issues for all source roots.
I removed this because `@ensure_cached` is hardcoded to check that there is only one `cache_subdir`. With sharding, we have two subdirs. Rewriting `TaskTestBase` to allow for multiple `cache_subdir`s would be a lot of work for this legacy code.
@@ -569,7 +569,7 @@ namespace DotNetNuke.Modules.Admin.Users if (_IsValid) { - var name = User.Username; + var name = User.Username ?? User.Email; var cleanUsername = PortalSecurity.Instance.InputFilter(name, ...
[Register->[OnInit->[OnInit,Register],registerButton_Click->[CreateUser],CreateUser->[CreateUser],UpdateDisplayName->[UpdateDisplayName],UserAuthenticated->[CreateUser],OnLoad->[OnLoad],OnPreRender->[OnPreRender]]]
Private method to validate the user object Private methods - Private methods - Private methods - Private methods - Private methods - Private methods - This method is used to find the appropriate user in the system.
Due to option (Use Email as Username) is enabled
@@ -74,7 +74,7 @@ import ( api "code.gitea.io/sdk/gitea" "github.com/go-macaron/binding" - macaron "gopkg.in/macaron.v1" + "gopkg.in/macaron.v1" ) func sudo() macaron.Handler {
[RequireCSRF,IsOrganizationOwner,Patch,Status,CanWrite,APIContexter,IsErrOrgNotExist,Delete,RepoRef,GetRepositoryByName,IsAdmin,CanEnablePulls,IsErrRepoNotExist,Put,IsErrRepoRedirectNotExist,Error,GetTeamByID,Post,GetUserRepoPermission,CanRead,JSON,Trace,IsOrganizationMember,RedirectToRepo,LookupRepoRedirect,Any,Params...
Macro to provide a token and access_token repoAssignment returns a handler that will assign a user to a repository.
This must have happened automatically via GoLand. Let me know if you want me to revert it, but it must work without it.
@@ -326,11 +326,6 @@ class TrainLoop: """TrainLoop contains the core training loop logic.""" def __init__(self, opt): - # if python is called from a non-interactive shell, like a bash script, - # it will by-default ignore SIGINTs, and KeyboardInterrupt exceptions are - # not produced. T...
[TrainLoop->[train->[_maybe_load_eval_worlds,save_model,validate,log,run_eval],_average_dicts->[_average_dicts],validate->[_maybe_load_eval_worlds,_save_best_valid,save_model,run_eval],_sync_training_metrics->[_average_dicts],_nice_format->[_nice_format],log->[_nice_format,_compute_eta,_cleanup_inaccurate_metrics,_sync...
Initialize the train loop with a specific . This function is called from the base class method. It sets the parameters of the object based This method is called when a node has no node in the system. It is called by.
hmm so there's one small question around how this works with SLURM.
@@ -12,7 +12,7 @@ class GradersController < ApplicationController # Administrator # - - before_filter :authorize_only_for_admin + before_action :authorize_only_for_admin layout 'assignment_content'
[GradersController->[criteria_with_assoc->[get_criteria,select,id,include?],csv_upload_grader_groups_mapping->[find,new,group_name,flash_message,delete_all,map,nil?,assign_graders_to_criteria,import,t,empty?,update_permissions_after,parse,read,each,id,redirect_to,user_name,update_criteria_coverage_counts,raise,find_eac...
Displays a group coverage dialog with an assignment and a grouping.
Layout/ExtraSpacing: Unnecessary spacing detected.<br>Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.
@@ -57,11 +57,14 @@ module Dashboard end def load_project - @project = current_team.projects.find_by(id: params.dig(:project, :id)) + @project = current_team.projects.managable_by_user(current_user).find_by(id: params.dig(:project, :id)) end def load_experiment - @experiment = @pr...
[QuickStartController->[create_experiment_params->[permit],project_filter->[id,render,exclude?,escape_input,select,present?,name,map],create_project_params->[permit],create_task->[call,render,empty?,protocols_my_module_path,name,errors],check_task_create_permissions->[can_create_projects?,can_manage_experiment?,can_cre...
load_project load_nak_nodenode load_nak_nodenode.
Will it work without experiment?
@@ -316,6 +316,9 @@ export default { this.roomName = options.roomName; JitsiMeetJS.setLogLevel(JitsiMeetJS.logLevels.TRACE); + // attaches global error handler + window.onerror = JitsiMeetJS.getGlobalOnErrorHandler; + return JitsiMeetJS.init(config).then(() => { r...
[No CFG could be retrieved]
Initialize a new connection and join to the specified room. Check if id is id of the local user.
Maybe it's good to check here if "JitsiMeetJS.getGlobalOnErrorHandler" exists. Also I think it will be good to store the current window.onerror function and call it.
@@ -167,7 +167,7 @@ class User < ActiveRecord::Base def get_large_avatar_image(provider, image_url) url = case provider when 'twitter' then image_url.sub('_normal', '') - when 'facebook' then "#{image_url}?type=large" + when 'facebook' then "#{image_url.sub("http://", "https://")}?...
[User->[hide_checkin_comment?->[hide_checkin_comment?]]]
get large avatar image.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.<br>Prefer single-quoted strings inside interpolations.
@@ -405,7 +405,9 @@ export class ChildLayoutManager { return; } + this.underlyingAmpElementParent_ = {}; for (let i = 0; i < this.children_.length; i++) { + this.children_[i].setAttribute(SLIDE_ID, `${i}`); this.owners_.setOwner(this.children_[i], this.ampElement_.element); }
[No CFG could be retrieved]
Updates the children that should have their layout managed. Recursive method to trigger layout and visibility events for children.
When does `updateChildren` get called? Will the nearingViewportObserver_ callbacks still function properly after a carousel has its children updated?
@@ -304,6 +304,9 @@ func (r *RegionInfo) GetID() uint64 { // GetMeta returns the meta information of the region. func (r *RegionInfo) GetMeta() *metapb.Region { + if r == nil { + return nil + } return r.meta }
[RandomRegion->[length,RandomRegion],AddRegion->[GetRegion,update,GetLearners,GetID,Put,GetVoters],GetStoreLeaderCount->[length],remove->[remove],SetRegion->[Get,GetID],GetStoreLearnerCount->[length],GetPeers->[GetPeers],GetAdjacentRegions->[GetID,GetStartKey,GetEndKey,GetRegion],Length->[Len],update->[update],GetMetaR...
GetMeta returns the metapb. Region or the approximate size of the region.
why need this?
@@ -466,10 +466,14 @@ public final class CacheScheduler * created * @param version version, associated with the cache */ - public VersionedCache createVersionedCache(@Nullable EntryImpl<? extends ExtractionNamespace> entryId, String version) + public VersionedCache createVersionedCache( + ...
[CacheScheduler->[createVersionedCache->[VersionedCache],scheduleAndWait->[close,schedule],VersionedCache->[close->[close],getCache->[getCache]],EntryImpl->[doClose->[close],schedule->[schedule],tryUpdateCache->[close],updateCache->[close],toString],Entry->[close->[close],toString->[toString],getCache->[getCacheState,g...
createVersionedCache - creates a new cache with the given entryId and version.
Add `@param` explaining `cacheHandler`
@@ -62,7 +62,7 @@ void ImposeRigidMovementProcess::ExecuteInitialize() ModelPart& root_model_part = mrThisModelPart.GetRootModelPart(); ModelPart& model_part = root_model_part.GetSubModelPart(mThisParameters["model_part_name"].GetString()); const std::string& new_model_part_name = mThisParameters["new_mo...
[No CFG could be retrieved]
The main entry point for the . Missing Variable Component.
puh that is a lot of ternary operators Not easy to follow
@@ -65,6 +65,7 @@ class Attribute(CountableDjangoObjectType): name = graphene.String(description=AttributeDescriptions.NAME) slug = graphene.String(description=AttributeDescriptions.SLUG) + type = AttributeTypeEnum(description=AttributeDescriptions.TYPE) values = graphene.List(AttributeValue, desc...
[AttributeValue->[resolve_type->[resolve_attribute_value_type]],Attribute->[resolve_meta->[resolve_meta],resolve_private_meta->[resolve_private_meta]]]
Use the inputType field to determine the type of attribute s value. A Meta class for a product type.
Can we add descriptions here on this occasion?
@@ -190,7 +190,10 @@ public class MessageHandlerChain extends AbstractMessageHandler implements Messa } } if (targetHandler instanceof IntegrationObjectSupport) { - ((IntegrationObjectSupport) targetHandler).setComponentName(componentName + ".handler#" + i); + IntegrationObjectSupport ios =...
[MessageHandlerChain->[doStop->[stop],handleMessageInternal->[onInit],stop->[stop],configureChain->[send->[send],setOutputChannel],doStart->[start],setComponentName->[setComponentName],ReplyForwardingMessageChannel->[send->[send]]]]
Set the component name.
If we do my suggestion above we can remove this naming code altogether.
@@ -120,6 +120,12 @@ export class AmpIframe extends AMP.BaseElement { * @private {?string} */ this.targetOrigin_ = null; + + /** + * @return {!../../../src/service/url-impl.Url} + * @private + */ + this.getUrlService_ = once(() => Services.urlForDoc(this.element)); } /** @over...
[No CFG could be retrieved]
Replies the source of the iframe. Check if the origin of the element is not equal to container s origin.
This `once` stuff isn't necessary, neither access is in the fast path.
@@ -652,7 +652,9 @@ public class SplittableParDo<InputT, OutputT, RestrictionT, WatermarkEstimatorSt * <p>TODO(BEAM-10670): Remove the primitive Read and make the splittable DoFn the only option. */ public static void convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(Pipeline pipeline) { - if (Ex...
[SplittableParDo->[PrimitiveUnboundedRead->[getSource],forAppliedParDo->[SplittableParDo],PairWithRestrictionFn->[processElement->[element->[element],timestamp->[timestamp],outputReceiver->[output->[]]]],SplitRestrictionFn->[processElement->[element->[],timestamp->[timestamp],outputReceiver->[output->[output]]]],Proces...
This method checks if we need to do a read - based splittable DoFns conversion if.
@xinyuiscool is this issue something that affects you or that you have noticed?
@@ -102,6 +102,10 @@ class SectionIDFilter(html5lib_Filter): self.known_ids.add(id) return id + def slugify(self, text): + """Turn the text content of a header into a slug for use in an ID""" + return (text.replace(' ', '_')) + def __iter__(self): input...
[SectionEditLinkFilter->[__iter__->[__iter__],__init__->[__init__]],ContentSectionTool->[serialize->[serialize],__unicode__->[serialize],__init__->[parse]],SectionIDFilter->[__iter__->[__iter__,gen_id],__init__->[__init__]],DekiscriptMacroFilter->[__iter__->[__iter__]],CodeSyntaxFilter->[__iter__->[__iter__]],SectionFi...
Generate a unique ID for the section.
Is there any chance these IDs ever end up as part of a URL (not just a fragment identifier)? Looks like they do further down and if so, that's a potential Unicode issue -- we might want to do something like Django's own built-in slugify template filter, which has a little Unicode-normalization song-and-dance to produce...
@@ -6128,6 +6128,7 @@ def lod_reset(x, y=None, target_lod=None): from :attr:`y`. target_lod (list|tuple|None): One level LoD which should be considered as target LoD when :attr:`y` not provided. + append (bool): A flag indicating whether...
[ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initia...
reset the lood of a 1 - level LoDTensor x to a new one specified Output variable with a 2 - level LoD which should be considered by this layer. Single node of the sequence.
It is confusing that adding `append` for `lod_reset`. In my mind that `lod_reset` is just used to reset the lod info with `target_lod`, but not have other function.
@@ -159,6 +159,8 @@ if __name__ == '__main__': exit(1) check_version(args) try: + if is_multi_phase(): + fetch_parameter_file(args) main_loop(args) except SystemExit as se: nni_log(LogType.Info, 'NNI trial keeper exit with code {}'.format(se.code))
[trial_keeper_help_info->[print],check_version->[get_distribution,rest_post,search,gen_send_version_url,nni_log,format,_exit,dumps],main_loop->[,copyDirectoryToHdfs,nni_log,HdfsClient,poll,copyHdfsDirectoryToLocal,makedirs,getcwd,sleep,get_pipelog_reader,format,exists,open,split,set_process_exit,str,Popen,RemoteLogger,...
Main entry point for the trial keeper.
we can keep this logic for now, but it is not efficient. A possible alternative is to check hdfs only when received get_next_parameter.
@@ -165,6 +165,12 @@ def main(): output_dir = args.download_dir if args.output_dir is None else args.output_dir + def get_model_dir(model): + model_root = (Path(__file__).resolve().parent / '../../models').resolve() + model_dir = model_root / model.subdirectory + return model_dir + + ...
[convert_to_onnx->[printf,subprocess],JobWithQueuedOutput->[cancel->[cancel]],main->[start->[JobWithQueuedOutput,QueuedOutputContext],convert->[convert_to_onnx,printf,subprocess],complete,DirectOutputContext,cancel,convert],main]
Main function of the model conversion script. Check if a object is present in the system. Convert a object to IR.
This duplicates the logic from `common.py`. I would suggest you add a `MODEL_ROOT` constant in `common.py` and reuse it here.
@@ -55,6 +55,11 @@ public class JvmVerification { assertEquals(v11, getByteCodeVersion(JvmVerification.class)); } + @Test + public void verifyTestCodeIsCompiledWithJava17() throws IOException { + assertEquals(v17, getByteCodeVersion(JvmVerification.class)); + } + // jvm @Test public void verify...
[JvmVerification->[getByteCodeVersion->[toByteArray,get,getResourceAsStream,replace,encodeHexString],verifyTestCodeIsCompiledWithJava8->[getByteCodeVersion,assertEquals],verifyCodeIsCompiledWithJava8->[getByteCodeVersion,assertEquals],getJavaSpecification->[getProperty],verifyRunningJVMVersionIs11->[assertEquals,getJav...
Test code is compiled with Java 11.
Need to add an entry to `versionMapping`, right?
@@ -113,6 +113,14 @@ class AuthHandler(object): cont_resp = self.cont_auth.perform(self.cont_c) if self.dv_c: dv_resp = self.dv_auth.perform(self.dv_c) + for achall, response in zip(self.dv_c, dv_resp): + if not self._s...
[_report_failed_challs->[dict,getUtility,add_message,setdefault,_generate_failed_chall_msg,itervalues],_find_smart_path->[AuthorizationError,enumerate,fatal,get],_find_dumb_path->[append,len,set,isinstance,add,enumerate,is_preferred],_generate_failed_chall_msg->[dict,append,sorted,setdefault,format,join],gen_challenge_...
Get Responses for challenges from authenticators.
Please make the line wrapping optimally compact by: - putting more arguments on the same line, e.g. `achall.domain, achall.uri` instead of `achall.domain,\nachall.uri` - you can try to put a newline after `logger.warning(` and then continue with 4 space indent.
@@ -17,11 +17,7 @@ class DependencyREPO(DependencyLOCAL): PARAM_REV = "rev" PARAM_REV_LOCK = "rev_lock" - REPO_SCHEMA = { - Optional(PARAM_URL): str, - Optional(PARAM_REV): str, - Optional(PARAM_REV_LOCK): str, - } + REPO_SCHEMA = {PARAM_URL: str, PARAM_REV: str, PARAM_REV_LOCK...
[DependencyREPO->[fetch->[_make_repo],status->[_make_repo],download->[fetch],update->[_make_repo]]]
Initialize a DependencyRepo with a default branch.
So how does it differentiate required field from an optional one?
@@ -247,7 +247,7 @@ class Assignment < ActiveRecord::Base # condition += " and memberships.status != 'rejected'" # add non-pending status clause to condition # condition += " and memberships.status != 'pending'" unless pending - # groupings.first(:include => :memberships, :conditions => [condition, ui...
[Assignment->[get_detailed_csv_report_rubric->[total_mark],group_by->[group_assignment?],grade_distribution_as_percentage->[total_mark],get_simple_csv_report->[total_mark],get_detailed_csv_report_flexible->[total_mark],section_past_due_date?->[past_due_date?],reset_collection_time->[reset_collection_time],set_results_s...
Returns the user with the given uid if it is a group by or nil if it is.
Line is too long. [102/80]
@@ -122,9 +122,6 @@ public class BehaviorCache { @CheckForNull private MethodBehavior get(String signature, @Nullable Symbol.MethodSymbol symbol) { - if (isknownSignature(BLACKLIST, signature)) { - return null; - } MethodBehavior mb = behaviors.get(signature); if(mb != null) { return...
[BehaviorCache->[get->[methodCanNotBeOverriden,get,completeSignature,getMethodBehavior,declaration,containsKey,isknownSignature,execute],cleanup->[clear],methodBehaviorForSymbol->[completeSignature,MethodBehavior,computeIfAbsent,isVarArgs],isknownSignature->[anyMatch],of]]
Returns a MethodBehavior for the given signature.
Removing this should probably lead to simplification of the isKnownSignature method
@@ -16,6 +16,9 @@ package core import ( "sync" + "github.com/pingcap/log" + "go.uber.org/zap" + "github.com/pingcap/kvproto/pkg/metapb" "github.com/pingcap/pd/pkg/slice" )
[GetStoreLeaderCount->[GetStoreLeaderCount],GetRegionStores->[GetStore],GetMetaStores->[GetMetaStores],BlockStore->[BlockStore],GetStoreCount->[GetStoreCount],GetAdjacentRegions->[GetAdjacentRegions],Length->[Length],GetMetaRegions->[GetMetaRegions],PreCheckPutRegion->[GetRegion],AttachAvailableFunc->[AttachAvailableFu...
NewBasicCluster returns a new BasicCluster object. GetRegionInfo gets all RegionInfo from regionMap.
remove this line.
@@ -144,6 +144,10 @@ class TopicViewDetailsSerializer < ApplicationSerializer scope.can_archive_topic?(object.topic) end + def include_can_edit_staff_notes? + @can_edit_staff_notes ||= scope.can_edit_staff_notes?(object.topic) + end + def include_can_publish_page? scope.can_publish_page?(object.t...
[TopicViewDetailsSerializer->[notification_level->[notification_level],allowed_groups->[allowed_groups],last_poster->[last_poster],participants->[participants],notifications_reason_id->[notifications_reason_id]]]
Includes can_archive_topic? can_publish_page? can_archive_page.
I think we need to update `include_can_archive_topic?` and `include_can_close_topic?` to call `include_can_edit_staff_notes?` instead.
@@ -1661,9 +1661,9 @@ func TeamProfileAddList(ctx context.Context, g *libkb.GlobalContext, username st } disabledReason := "" if !entry.CallerAdmin { - disabledReason = fmt.Sprintf("%v is already a member.", uname.String()) - } else if entry.ThemMember { disabledReason = fmt.Sprintf("Only admins can add...
[Nanoseconds,MapUIDsToUsernamePackages,GetProofSet,GetMeUV,UploadImage,SeitanIKeyV2,RunEngine2,CTimeTracer,myRole,WithUID,IsOpen,ChangeMembership,Post,New,InviteMember,deleteSubteam,AsTeam,Time,NewMetaContext,ImplicitAdmins,OpenTeamJoinAs,IsSubteam,TeamInviteTypeFromString,Stage,Generation,Split,WithPublicKeyOptional,F...
TeamProfileAddList returns a list of team profiles that can be added to the user. LoadTeamLoad takes a team ID and a filename and loads it into the team s Merkle.
This was a bug in the CORE implementation
@@ -1837,11 +1837,13 @@ public: totalPlayerTime = target->GetTotalPlayedTime(); level = target->getLevel(); latency = target->GetSession()->GetLatency(); - race = target->getRace(); - Class = target->getClass()...
[misc_commandscript->[bool->[getLiquidStatus,GetMotionMaster,GetHeight,HasLowerSecurity,isPossessing,learnSpell,extractGuidFromLink,IsInFlight,strtol,GetObjectSize,GetZoneAndAreaId,SendWorldText,end,getLevel,begin,CreateBaseAtCreature,SendGlobalMessage,GetGroup,fields,atof,SavePetToDB,SendToBattleground,GetGUIDLow,GetS...
Handle a command that is sent to a user to get info about a specific target. get additional information from DB get the last IP last login and latency c_c_c_c_c_c_c_c_c_ night - > night Checks if the guild has a lease.
Fix these spaces
@@ -19,10 +19,11 @@ var ( DefaultKernelNamespaces = "cgroup,ipc,net,uts" ) -var podCreateDescription = "Creates a new empty pod. The pod ID is then" + - " printed to stdout. You can then start it at any time with the" + - " podman pod start <pod_id> command. The pod will be created with the" + - " initial state 'c...
[IsRootless,WithInfraContainerPorts,StringSlice,NewPod,Close,BoolT,GetNamespaceOptions,IsSet,CreatePortBindings,Error,WithPodLabels,IsExist,GetRuntime,Errorf,ID,Wrapf,OpenExclusiveFile,Geteuid,WithInfraContainer,Shutdown,WithPodCgroups,Split,Printf,Sync,String,WithPodCgroupParent,WriteString,WithPodName]
Imports the given object and imports it into the container Commands for the command.
I'd vote on holding this PR until @baude is able to get his cobra #2274 in
@@ -16,5 +16,6 @@ void Start(); void SendResponse(Response response, string sessionId); void ExecuteMessageFromSocket(string message, string sessionId); + void ExecuteFileFromSocket(byte[] file, string sessionId); } }
[No CFG could be retrieved]
Send a response to the client.
webserver can receive a file as byte array
@@ -3503,7 +3503,12 @@ class IrGraph(object): wrapped_adj_list[IrNode(k)] = {IrNode(n) for n in v} return wrapped_adj_list - def draw(self, save_path, name, marked_nodes=None, remove_ctr_var=True): + def draw(self, + save_path, + name, + marked_nodes=Non...
[cuda_places->[is_compiled_with_cuda,_cuda_ids],_varbase_creator->[convert_np_dtype_to_dtype_],Program->[_construct_from_desc->[Program,_sync_with_cpp,Block],__repr__->[__str__],parse_from_string->[Program,_sync_with_cpp,Block],to_string->[_debug_string_,to_string],_version->[_version],_prune_with_input->[Program,_sync...
Build an adjacency list of operations for the graph. Missing node in graph.
IMO the previous approach could be preserved here. The .pdf files could be generated automatically, without the `--pdf` option.
@@ -22,14 +22,14 @@ import org.infinispan.util.logging.Log; import org.infinispan.util.logging.LogFactory; /** - * This component handles the control hooks to handle migrating from one version of Infinispan to - * another. + * RollingUpgradeManager handles the synchronization of data between Infinispan + * clusters...
[RollingUpgradeManager->[disconnectSource->[disconnectSource],synchronizeData->[synchronizeData]]]
This class is used to handle the migration of data from one version of Infinispan to another Synchronize data from cache to cache.
You can migrate to same version as well
@@ -41,6 +41,11 @@ public class ChildFieldPath extends RecordPathSegment { return new StandardFieldValue(null, field, parent); } + private FieldValue missingChild(final FieldValue parent, final RecordField childField) { + final RecordField field = new RecordField(childName, childField.getDataT...
[ChildFieldPath->[evaluate->[getChild],getChild->[missingChild]]]
Returns a child field value.
If you like functional style - I like that it's more compact - this can be replaced by: `childFieldOptional.map(recordField -> missingChild(fieldValue, recordField)).orElseGet(() -> missingChild(fieldValue));`
@@ -546,6 +546,11 @@ class EpollEventLoop extends SingleThreadEventLoop { logger.warn("Failed to close the epoll fd.", e); } try { + // Ensure any inflight wakeup writes have been performed prior to closing eventFd. + // Cap number of iterations t...
[EpollEventLoop->[epollWaitNow->[epollWait],newTaskQueue->[newTaskQueue],run->[processPendingChannelFlags,checkScheduleTaskQueueForNewDelay,get,runAllTasks,epollWait,epollBusyWait],processPendingChannelFlags->[get],trySetTimerFd->[get],checkScheduleTaskQueueForNewDelay->[setTimerFd,get],remove->[remove],closeAll->[epol...
This method cleans up the native memory.
I thought spinning on read here would be simpler/safer than using epoll, it should rarely ever actually happen. Polling is still an option if others think that's preferable, though we would want probably want to use timerfd as an equivalent safeguard.
@@ -286,6 +286,8 @@ public class PostgreSqlClient if (tableHandle.getColumns().isPresent()) { return tableHandle.getColumns().get(); } + checkArgument(tableHandle.isNamedRelation(), "Cannot get columns for %s", tableHandle); + SchemaTableName schemaTableName = tableHandle.ge...
[PostgreSqlClient->[createTable->[createTable],longTimestampWriteFunction->[shortTimestampWriteFunction],getColumns->[getColumns],uuidColumnMapping->[uuidWriteFunction,uuidSlice],arrayAsJsonReadFunction->[arrayReadFunction],arrayToPrestoType->[toColumnMapping]]]
Get the list of columns in the given table. Returns a list of columns that can be used to find a sequence of columns in a table.
this is the case where `.orElseThrow()` would be useful
@@ -12,9 +12,12 @@ import { initAnalytics } from './functions'; */ MiddlewareRegistry.register(store => next => action => { switch (action.type) { - case LIB_DID_INIT: { + case SET_ROOM: { + const result = next(action); + initAnalytics(store); - break; + + return result; ...
[No CFG could be retrieved]
Register middleware for the middleware.
SET_ROOM will also happen when we navigate to the welcome page, and the room will be `undefined`. Do we also want to do this in that case?
@@ -185,11 +185,11 @@ namespace Content.Server.GameObjects.Components.Movement // we may potentially need additional logic since we're forcing a player onto a climbable // there's also the cases where the user might collide with the person they are forcing onto the climbable that i hav...
[ClimbableComponent->[CanDragDropOn->[CanDragDropOn],ClimbVerb->[GetData->[CanVault],Activate->[TryClimb]],Initialize->[Initialize],ExposeData->[ExposeData]]]
Try to move an entity to another entity. Checks if a user is a climbing component and if so attempts to do it.
Why is only 1 IEntity using its Name property?
@@ -19,7 +19,7 @@ package io.confluent.ksql.schema.ksql; * The SQL types supported by KSQL. */ public enum SqlBaseType { - BOOLEAN, INTEGER, BIGINT, DOUBLE, DECIMAL, STRING, ARRAY, MAP, STRUCT; + BOOLEAN, INTEGER, BIGINT, DOUBLE, DECIMAL, STRING, ARRAY, MAP, STRUCT, ALIAS; public boolean isNumber() { /...
[canUpCast->[ordinal,isNumber]]
Checks if this type is a numeric type.
hmm, `ALIAS` can be confusing here, how about something like `CUSTOM_TYPE` that clearly says what this is!
@@ -121,7 +121,16 @@ class FakeJobService implements JobService, Serializable { for (String filename : loadConfig.getSourceUris()) { loadFiles.add(filename + ThreadLocalRandom.current().nextInt()); } - IOChannelUtils.getFactory(loadFiles.get(0)).copy(loadConfig.getSourceUris(), loadF...
[FakeJobService->[startCopyJob->[JobInfo],startQueryJob->[JobInfo],startExtractJob->[JobInfo],runCopyJob->[validateDispositions],runLoadJob->[validateDispositions],startLoadJob->[JobInfo]]]
This method creates a new job and adds it to the list of jobs to be processed.
can you skip `loadFiles` above at L125
@@ -1035,7 +1035,7 @@ module Engine city.place_token(corporation, token) end - def tile_cost(tile, hex, entity) + def tile_cost(tile, hex, entity, new_tile: nil) # rubocop:disable Lint/UnusedMethodArgument ability = entity.all_abilities.find do |a| a.type == :tile_discoun...
[Base->[end_game!->[format_currency],current_entity->[current_entity],tile_cost->[format_currency],float_corporation->[format_currency],after_par->[format_currency,all_companies_with_ability],place_home_token->[home_token_locations],initialize_actions->[filtered_actions],close_corporation->[current_entity],liquidity->[...
Place a token on a corporation if it s the first token assume it s their home token.
was new_tile really necessary? can't you just do hex.tile?
@@ -175,8 +175,10 @@ int BIO_listen(int sock, const BIO_ADDR *addr, int options) return 0; # ifndef OPENSSL_SYS_WINDOWS - /* SO_REUSEADDR has different behavior on Windows than on - * other operating systems, don't set it there. */ + /* + * SO_REUSEADDR has different behavior on Windows than o...
[BIO_listen->[BIO_ADDR_sockaddr,listen,setsockopt,BIO_ADDR_sockaddr_size,BIO_ADDR_family,bind,SYSerr,get_last_socket_error,BIO_socket_nbio,BIOerr,getsockopt],BIO_accept_ex->[closesocket,SYSerr,get_last_socket_error,BIO_socket_nbio,BIO_sock_should_retry,BIOerr,accept,BIO_ADDR_sockaddr_noconst],BIO_closesocket->[closesoc...
BIO_listen listens on a socket. check if socket is broken or not.
On *side* note one can wonder how does it affect Cygwin. I mean Cygwin has no other option by to rely on Windows sockets... So maybe condition has to cover even Cygwin...
@@ -46,6 +46,10 @@ public final class RayNativeRuntime extends AbstractRayRuntime { for (String library : libraries) { String fileName = System.mapLibraryName(library); try (FileUtil.TempFile libFile = FileUtil.getTempFileFromResource(fileName)) { + // Expose ray ABI symbols which may be depen...
[RayNativeRuntime->[resetLibraryPath->[error,getProperty,isNullOrEmpty,setAccessible,setProperty,getDeclaredField,set,join,isEmpty],setResource->[checkArgument,compare,getBytes,nativeSetResource],run->[nativeRunTaskExecutor],registerWorker->[RedisClient,getProperty,String,hmset,currentTimeMillis,getBytes,put,valueOf,ge...
Implementation of the RayNativeRuntime class. This method returns an object that can be used to find a unique object in the system.
who depends on who? Do you mean: "Expose ray ABI symbols that other shared libraries, such as libstreaming_java.so, might be dependent on" ?
@@ -119,6 +119,7 @@ limitations under the License. "protractor-jasmine2-screenshot-reporter": "0.4.1", <%_ } _%> "react-addons-test-utils": "15.6.2", + "react-infinite-scroller": "^1.1.3", "react-test-renderer": "16.2.0", "redux-mock-store": "1.5.1", "rimraf": "2.6.2",
[No CFG could be retrieved]
The webpack framework is a wrapper around the standard library. The version of the modules that are not supported by the compiler. Check for missing dependencies.
use fixed version
@@ -0,0 +1,4 @@ +// Copyright %(YEAR)s %(YOUR_NAME)s (@%(USER_NAME)s) +// SPDX-License-Identifier: GPL-2.0-or-later + +#include "%(KEYBOARD)s.h"
[No CFG could be retrieved]
No Summary Found.
I'm not sure how I feel about % and () in a filename, makes for awkward shell.
@@ -77,6 +77,9 @@ class Proposals extends DolibarrApi throw new RestException(401, 'Access not allowed for login '.DolibarrApiAccess::$user->login); } + // Add billing contacts ids + $this->propal->billing_contacts_ids = $this->propal->liste_contact(-1,'external',1,'BILLING'); + $this->propa...
[Proposals->[put->[get],delete->[delete],putLine->[get],deleteLine->[get]]]
Get a single Proposal.
Why limiting array of contacts to 'BILLING' contact. If we include contacts linked to object, why not just returning all type (it does not take more effort/time) and let the api caller keep what it needs.
@@ -0,0 +1,15 @@ +from django.conf import settings +from django.db import models + + +class BaseNote(models.Model): + user = models.ForeignKey( + settings.AUTH_USER_MODEL, blank=True, null=True, + on_delete=models.SET_NULL) + date = models.DateTimeField(db_index=True, auto_now_add=True) + content...
[No CFG could be retrieved]
No Summary Found.
Default ordering is by pk, in this case, ordering by date added does the same thing, I suppose it's not needed
@@ -39,11 +39,9 @@ def test_get_cloud_fs_validate(tmp_dir, dvc): default=False, ) - assert get_cloud_fs(dvc, name="base")[1] == {"host": "example.com"} - assert get_cloud_fs(dvc, name="first")[1] == { - "host": "example.com", - "type": ["symlink"], - } + assert get_cloud_fs(dvc...
[test_get_cloud_fs_validate->[get_cloud_fs,add_remote,raises],test_get_cloud_fs->[get_cloud_fs,add_remote,CloudURLInfo]]
Test for get_cloud_fs validation.
Excuse me, any difference between these two forms?
@@ -351,7 +351,6 @@ func getIndentationString(indent int, op deploy.StepOp, prefix bool) string { } func writeWithIndent(b *bytes.Buffer, indent int, op deploy.StepOp, prefix bool, format string, a ...interface{}) { - b.WriteString(colors.Reset) b.WriteString(op.Color()) b.WriteString(getIndentationString(inden...
[plan->[GetPwdMain,Errorf,NewEvalSource,Assert,QName,NewPlan,NewContext],Close->[Close],printPlan->[Sprintf,Walk,New,Errorf,WriteString,Success],Walk->[Next,IgnoreError,Apply,Start,Close,Assert],IsObject,Value,IsAssets,NewBlindingDecrypter,PastTense,Old,ArrayValue,NewArchiveProperty,DiffLinesToChars,Assertf,BoolValue,D...
Prints the header of a step. printResourceProperties prints the resource properties of a node.
unnecessary. always followed by WriteString(op.Color()) and op.Color() always returns a non-empty string.
@@ -20,3 +20,12 @@ class PyPy2neo(PythonPackage): version('2.0.4', sha256='19074b7b892f2e989f39eae21fc59b26a05e1a820adad8aa58bc470b70d9056d') depends_on("py-setuptools", type='build') + + def url_for_version(self, version): + if version >= Version('2.0.9'): + url = 'https://github.com/t...
[PyPy2neo->[depends_on,version]]
Returns the version number of the package.
Missing an H. Could we download this package from PyPI instead?
@@ -150,6 +150,9 @@ class Indexation_Integration implements Integration_Interface { if ( $this->is_indexation_warning_hidden() === false ) { \add_action( 'admin_notices', [ $this, 'render_indexation_warning' ], 10 ); } + elseif ( $this->term_indexation->get_total_term_permalinks_null() > $shutdown_limit ) { ...
[Indexation_Integration->[get_total_unindexed->[get_total_unindexed]]]
Enqueue scripts and styles This function is used to generate the Yoast Indexation routes.
You don't have to pass `10` as argument, this is the default in WordPress already. _It not that important to have it fixed now._
@@ -50,6 +50,7 @@ void spdk_set_thread(struct spdk_thread *thread); #define DAOS_DMA_CHUNK_MB 32 /* 32MB DMA chunks */ #define DAOS_DMA_CHUNK_CNT_INIT 2 /* Per-xstream init chunks */ #define DAOS_DMA_CHUNK_CNT_MAX 32 /* Per-xstream max chunks */ +#define DAOS_NVME_MAX_CTRLRS 1024 /* Max trids read from nvme_conf...
[No CFG could be retrieved]
The DAOS markings are not reproduced. The structure of the nvme_data structures.
(style) line over 80 characters
@@ -977,11 +977,12 @@ void Sedp::rekey_volatile(const Security::SPDPdiscoveredParticipantData& pdata) #endif // OPENDDS_SECURITY -void Sedp::disassociate_helper(const BuiltinEndpointSet_t& avail, const CORBA::ULong flags, +void Sedp::disassociate_helper(BuiltinEndpointSet_t& avail, const CORBA::ULong flags, ...
[No CFG could be retrieved]
DDS - related methods DDS Topic Key Subcription Key.
This is incorrect.
@@ -22,7 +22,8 @@ from mne.minimum_norm import (make_inverse_operator, apply_inverse, data_path = sample.data_path() raw_fname = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif' -raw = mne.io.read_raw_fif(raw_fname) +raw = mne.io.read_raw_fif(raw_fname, add_eeg_ref=False) +raw.set_eeg_reference() events =...
[show_view,linspace,make_inverse_operator,add_foci,show,dict,compute_covariance,read_forward_solution,read_raw_fif,compute_morph_matrix,ylabel,morph_precomputed,plot,find_events,data_path,write_inverse_operator,pick_types_forward,xlabel,average,get_peak,plot_topomap,plot_white,plot_cov,arange,apply_inverse,Epochs,pick_...
Compute the regularized noise covariance of a single object. Compute the covariance of the n - th epoch.
raw.set_eeg_reference() # set EEG average reference
@@ -194,7 +194,8 @@ class Pipeline(AbstractContextManager, Generic[HTTPRequestType, HTTPResponseType :return: The PipelineResponse object :rtype: ~azure.core.pipeline.PipelineResponse """ - self._prepare_multipart_mixed_request(request) + multipart_options = kwargs.pop("multipar...
[Pipeline->[run->[send,_prepare_multipart_mixed_request,_TransportRunner],__init__->[_SansIOHTTPPolicyRunner,_TransportRunner],_prepare_multipart_mixed_request->[prepare_requests->[_await_result]],__exit__->[__exit__],__enter__->[__enter__]],_SansIOHTTPPolicyRunner->[send->[_await_result,send]],_TransportRunner->[send-...
Runs the HTTP Request through the chained policies. .
Do we want this parameter to be hidden?
@@ -46,6 +46,12 @@ func (m *buildSpecMutator) Mutate(fn ImageReferenceMutateFunc) field.ErrorList { if err := fn(&s.From); err != nil { errs = append(errs, fieldErrorOrInternal(err, m.path.Child("strategy", "sourceStrategy", "from", "name"))) } + if s.RuntimeImage != nil { + if err := fn(s.RuntimeImage); e...
[Mutate->[Index,Child],NotFound,String,IsNotFound,InternalError,NewPath]
Mutate calls the provided MutateFunc for each of the images in the source.
Why aren't we removing this in 3.7?
@@ -169,7 +169,7 @@ static int DES_ede3_cbc_encrypt_loop(void *args); static int AES_cbc_128_encrypt_loop(void *args); static int AES_cbc_192_encrypt_loop(void *args); static int AES_cbc_256_encrypt_loop(void *args); -#if !OPENSSL_API_3 +#ifndef OPENSSL_NO_DEPRECATED_3_0 static int AES_ige_128_encrypt_loop(void *ar...
[No CFG could be retrieved]
loop over all of the keys in the system M - function to print message in loop.
I don't get why these changes are included in this PR - they are actually unrelated to the adjustment of the option handling IMHO.
@@ -128,11 +128,15 @@ def test_maxwell_filter_additional(): raw_sss.save(test_outname) raw_sss_loaded = Raw(test_outname, preload=True, proj=False, allow_maxshield=True) + # Some numerical imprecision since save uses 'single' fmt assert_allclose(raw_sss_loaded._data[:, :], ...
[test_maxwell_filter->[_make_coils,catch_warnings,sqrt,sum,assert_raises,_sss_basis,info,assert_allclose,assert_array_almost_equal,maxwell_filter,assert_equal,preload_data,get_num_moments,mean,_get_sss_rank,len,Raw,assert_true,ones,array],test_maxwell_filter_additional->[maxwell_filter,Raw,_TempDir,catch_warnings,data_...
Test processing of Maxwell filtered data with additional additional data.
The rank for both of these calculations is zero... Any ideas why?
@@ -155,7 +155,7 @@ def _gen_index_tuple(tyctx, shape_tuple, value, axis): return function_sig, codegen -#---------------------------------------------------------------------------- +# ---------------------------------------------------------------------------- # Basic stats and aggregates @lower_builtin(...
[_fill_diagonal->[_fill_diagonal_params],_where_inner->[where_impl->[impl],determine_dtype],my_triu->[np_triu_impl_1d->[np_triu_impl_2d,_make_square],_check_is_integer],_np_correlate->[impl->[_np_correlate_core],_assert_1d],_cross_impl->[impl->[_cross_operation]],np_interp_impl_complex_fp_inner_factory->[impl->[binary_...
Compile an array sum returning a c_void_p.
It's good to try and avoid cosmetic changes in PRs that are about functionality, this makes it easier for reviewers as the change set is smaller, it also somewhat prevents PR `X` making a change one way and PR `Y` making it another.
@@ -410,7 +410,14 @@ public class SinglePhaseSubTask extends AbstractBatchIndexTask final DynamicPartitionsSpec partitionsSpec = (DynamicPartitionsSpec) tuningConfig.getGivenOrDefaultPartitionsSpec(); final long pushTimeout = tuningConfig.getPushTimeout(); final boolean explicitIntervals = granularitySpe...
[SinglePhaseSubTask->[WrappingSegmentAllocator->[allocate->[allocate,createSegmentAllocator],createSegmentAllocator->[getSegmentGranularity]],getSegmentGranularity->[getSegmentGranularity],generateAndPushSegments->[createSegmentAllocator]]]
Generates and pushes segments for the given sequence number. This method creates a new driver and adds all the data segments in the input source. This method is called from the appenderator thread.
This should look at `partitionsSpec.getType()` otherwise if that implementation changes to return a non linear type this will break
@@ -184,7 +184,7 @@ public class MavenTest { } private void verify() throws Exception { - MavenInstallation[] l = j.get(DescriptorImpl.class).getInstallations(); + MavenInstallation[] l = j.get(MavenInstallation.DescriptorImpl.class).getInstallations(); assertEquals(1,l.length); ...
[MavenTest->[withNodeProperty->[getHome,getResult,Entry,replaceBy,getJDK,configureDefaultMaven,JDK,MavenInstallation,Maven,setJDK,substring,assertEquals,setInstallations,EnvironmentVariablesNodeProperty,getName,get,createFreeStyleProject,add,singleton],verify->[assertNotNull,MavenInstallation,getProperties,assertEqualB...
Verify that the junit is running and that the installer is available.
Not to be confused with a variety of other `DescriptorImpl`s.
@@ -41,8 +41,8 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; * @since 2.2 * */ -@RunWith(SpringJUnit4ClassRunner.class) -@ContextConfiguration +@SpringJUnitConfig +@EnabledOnJre(JRE.JAVA_8) public class EclipseLinkJpaOperationsTests extends AbstractJpaOperationsTests { @Test
[EclipseLinkJpaOperationsTests->[testMergeCollectionWithNullElement->[testMergeCollectionWithNullElement],testPersistNullCollection->[testPersistNullCollection],testGetAllStudents->[testGetAllStudents],testExecuteUpdateWithNativeQuery->[testExecuteUpdateWithNativeQuery],testExecuteSelectWithNativeQueryReturningEntityCl...
This method is overridden to catch exceptions that are expected to be caught by OpenJPA.
Maybe it's time to remove Eclipse Link tests altogether ?
@@ -217,14 +217,12 @@ public class ProcessBundleHandler { BundleProcessorCache bundleProcessorCache) { this.options = options; this.fnApiRegistry = fnApiRegistry; + this.runnerCapabilities = runnerCapabilities; this.beamFnDataClient = beamFnDataClient; this.beamFnStateGrpcClientCache = bea...
[ProcessBundleHandler->[trySplit->[trySplit],BundleProcessor->[finish->[getTimerEndpoints,getInboundDataEndpoints],shutdown->[getTearDownFunctions],reset->[reset,getResetFunctions],getBundleCache->[getProcessWideCache],setupForProcessBundleRequest->[getInstructionId]],BlockTillStateCallsFinish->[handle->[handle]],shutd...
Creates a new instance of the ProcessBundleHandler class. The bundle cache is a cache of all the bundle cache entries for a given sequence of non.
we want this to be cached and not looked up for every call
@@ -276,7 +276,7 @@ export class BlueWalletNavigationHeader extends Component { wallet.hideBalance = !wallet.hideBalance; this.setState({ wallet }); - await BlueApp.saveToDisk(); + await this.context.saveToDisk(); }; showAndroidTooltip = () => {
[No CFG could be retrieved]
UI component that displays the balance of a single unit in the wallet. handleCopyPress - CopyPress.
where is this `this.context` defined? also, can it be named better? I suspect that after this change there wont be any code completion and code navigation in my IDE
@@ -241,7 +241,11 @@ class GitDriver extends VcsDriver return false; } - // TODO try to connect to the server + $process = new ProcessExecutor($io); + if($process->execute('git ls-remote ' . $url, $output) === 0) { + return true; + } + return false...
[GitDriver->[getRootIdentifier->[splitLines,execute],getComposerInformation->[read,format,write,execute],getTags->[splitLines,execute],supports->[execute],getSource->[getUrl],getBranches->[splitLines,execute],initialize->[getMessage,write,get,runCommand,ensureDirectoryExists,getTags,getBranches,removeDirectory,execute]...
Checks if a git repository supports a specific tag.
you need to escape the URL.
@@ -206,9 +206,9 @@ func newConfigSetCmd(stack *string) *cobra.Command { // If we saved a plaintext configuration value, and --plaintext was not passed, warn the user. if !secret && !plaintext { cmdutil.Diag().Warningf( - diag.Message( + diag.Message("", /*urn*/ "saved config key '%s' value ...
[Value,NewBlindingDecrypter,Message,Fd,RemoveTralingNewline,Warningf,SaveProjectStack,Wrap,Secure,HasSecureValue,ReadConsoleNoEcho,SpecificArgs,Itoa,New,RunFunc,Diag,StringVarP,Errorf,Namespace,AddCommand,NewPanicCrypter,Contains,Name,GetStackCrypter,ReadConsole,DetectProjectStack,Sort,DetectProject,QName,ParseKey,NewS...
parseConfigKey parses the config key and value and returns a config. Key object. prettyKey returns the key if the key was written to the file.
Do you think it is worthwhile to have `diag.Message` and `diag.URNMessage`, so we can centralize the empty URN dance to a single location instead of throwing it in every call site?
@@ -12,5 +12,5 @@ lang.init(); // adding "Clients" to the window object so they can be accessed by other js inside Jekyll window.Cookie = Cookie; -window.OptimizelyClient = new OptimizelyClient(); -window.AnalyticsClient = AnalyticsClient; // because it only has static methods, AnalyticsClient is not instantiated \...
[No CFG could be retrieved]
Adds the clients to the window object so they can be accessed by other js inside Jek.
Reversed the order since `OptimizelyClient` need `AnalyticsClient` now
@@ -402,6 +402,11 @@ module ApplicationHelper lookup.html_safe if lookup end + def theme_translations_lookup + lookup = Theme.lookup_field(theme_ids, :translations, I18n.locale) + lookup.html_safe if lookup + end + def discourse_stylesheet_link_tag(name, opts = {}) if opts.key?(:theme_ids) ...
[include_crawler_content?->[crawler_layout?,mobile_view?],client_side_setup_data->[loading_admin?,script_asset_path],script_asset_path->[is_brotli_req?],normalized_safe_mode->[allow_third_party_plugins?,customization_disabled?,allow_plugins?],build_plugin_html->[allow_plugins?],theme_ids->[customization_disabled?],disc...
Returns a link tag that can be used to view a theme.
Trivial but you could use the safe navigation operator here.
@@ -15,6 +15,13 @@ import torch.nn.functional as F import torch.optim as optim from torchvision import datasets, transforms +# Temporary patch this example until the MNIST dataset download issue get resolved +# https://github.com/pytorch/vision/issues/1938 +import urllib + +opener = urllib.request.build_opener() +o...
[train->[train],main->[Net,train,test],get_params,main]
Deep MNIST classifier using convolutional layers. Train and test functions.
do we still need this fix?
@@ -142,12 +142,16 @@ public class HoodieTestTable { return String.format("%09d", sequence); } + public static String makeNewCommitTimeInHudiFormat(int sequence) { + return String.format("%014d", sequence); + } + public static String makeNewCommitTime() { return makeNewCommitTime(Instant.now()); ...
[HoodieTestTable->[of->[of,HoodieTestTable],withLogFile->[withLogFile],addInflightCompaction->[addRequestedCompaction],moveInflightCompactionToComplete->[of],deleteFilesInPartition->[listAllFilesInPartition],doSavepoint->[deleteFilesInPartition,getSavepointMetadata],addCommit->[addCommit],addRequestedCompaction->[addRe...
Make a new commit time string.
Love to not add more methods here. can we get `makeNewCommitTime` work as-is? cc @xushiyan
@@ -150,7 +150,7 @@ func resourceAwsDataSyncAgentCreate(d *schema.ResourceData, meta interface{}) er err = resource.Retry(d.Timeout(schema.TimeoutCreate), func() *resource.RetryError { _, err := conn.DescribeAgent(descAgentInput) - if isAWSErr(err, "InvalidRequestException", "not found") { + if isAWSErr(err, "...
[TagResource,GetChange,NewRequest,NonRetryableError,Set,GetOk,UntagResource,HasChange,ListTagsForResource,Location,CreateAgent,Errorf,SetId,RetryableError,Timeout,Do,DescribeAgent,UpdateAgent,Id,Get,DeleteAgent,Query,Printf,DefaultTimeout,StringValue,Sprintf,String,Retry]
Associate a single agent with a DataSync agent. asyncconn returns the object with the data from the async API.
Would it make sense to encapsulate this check in a function, rather than doing the string comparison in three places in this file and two more in the tests?
@@ -88,11 +88,11 @@ class TableEntityPropertiesPaged(AsyncPageIterator): next_row_key=row_key or None, next_partition_key=partition_key or None, table=self.table, - cls=return_context_and_deserialized, + cls=_return_context_and_deserialize...
[TableEntityPropertiesPaged->[_get_next_cb->[_command,items,process_table_error],__init__->[super],_extract_data_cb->[_convert_to_entity]],TablePropertiesPaged->[_get_next_cb->[_command,pop,process_table_error],__init__->[super],_extract_data_cb->[Table]]]
Internal method to get next iteration callback.
you can also accept customer input for cls, i.e. `cls=kwargs.pop("cls", _return_context_and_deserialized)`. I see a couple other places where you don't do this
@@ -462,6 +462,15 @@ Type "Yes I am sure" if you understand this and want to continue.\n""") stats.print_('Deleted data:', cache) return self.exit_code + def do_convert(self, args): + """convert a repository from attic to borg""" + repo = AtticRepositoryConverter(args.repository...
[Archiver->[do_change_passphrase->[open_repository],do_prune->[print_error,open_repository,print_verbose],run->[preprocess_args],do_mount->[print_error,open_repository,print_verbose],do_check->[print_error,open_repository],do_extract->[print_error,open_repository,print_verbose],_process->[print_error,_process,print_ver...
Prune repository archives according to specified rules. Delete the last missing key in the archive.
just as a reminder to change this (and other similar places) to logging.warning (or .error) after we have reasonable logging in place.
@@ -475,6 +475,9 @@ export default function initPostScraper( $, store, editorData ) { pluginReloaded: app.pluginReloaded, } ); + const reusableBlocksPlugin = new YoastReusableBlocksPlugin( app.registerPlugin, app.registerModification, blockEditorDataModule ); + reusableBlocksPlugin.register(); + if ( wpse...
[No CFG could be retrieved]
Register the YoastSEO assessment. This function is called when YoastSEO worker is running.
Lets only activate the plugin in the block editor. I quickly tried in the classic editor and you get an error when you have a reusable block in there.
@@ -683,12 +683,14 @@ def plot_raw_psds(raw, tmin=0.0, tmax=60.0, fmin=0, fmax=np.inf, for ii, (picks, title, ax) in enumerate(zip(picks_list, titles_list, ax_list)): - psds, freqs = compute_raw_psd(raw, tmin=tmin, tmax=tmax, picks=picks, - ...
[_mouse_click->[_pick_bad_channels],plot_raw->[_layout_raw],_plot_raw_onkey->[_plot_raw_time],_pick_bad_channels->[f],_plot_raw_onscroll->[_channels_changed],_plot_raw_time->[_update_raw_data],_helper_resize->[_layout_raw]]
Plot the power spectral density across channels. Plots a series of the nanoseconds in the raw data. Plots the mean and the power spectrum of the nanoseconds.
oups my bad if psds is power (not amplitude) than it should be 10 \* np.log10 please revert here and change above.
@@ -210,7 +210,7 @@ class TestLayerNormOp(unittest.TestCase): for name in ['x', 'scale', 'bias', 'y@GRAD'] }, fetch_list=fetch_list) - self.__assert_close(y, out[0], "y") + self.__assert_close(...
[TestLayerNormOp->[test_check_forward_backward_with_scale_and_bias->[check_forward_backward],check_forward_backward->[test_with_place->[_reference_layer_norm_grad,_reference_layer_norm_naive,__assert_close],test_with_place]]]
Check forward and backward of a network with a specific n - node cross - validation. Generate backward operation on the non - zero non - zero non - zero non - zero non Missing values in the network are not closed.
Why change the atol?
@@ -168,7 +168,8 @@ public class ResourceLeakDetector<T> { Collections.newSetFromMap(new ConcurrentHashMap<DefaultResourceLeak<?>, Boolean>()); private final ReferenceQueue<Object> refQueue = new ReferenceQueue<Object>(); - private final ConcurrentMap<String, Boolean> reportedLeaks = PlatformDepe...
[ResourceLeakDetector->[reportLeak->[clearRefQueue],Record->[toString->[toString],Record,toString],DefaultResourceLeak->[close->[close],toString->[toString]],parseLevel]]
Enables or disables resource leak detection. This method is deprecated.
One could also argue that newSetFromMap has additional overhead, memory and stack (all methods are delegated to the backing map of the "set").
@@ -4383,9 +4383,12 @@ def hsigmoid(input, is not set, the bias is initialized zero. Default: None. name (str|None): A name for this layer(optional). If set None, the layer will be named automatically. Default: None. + is_costum: (bool|False)using user defined binary tree ins...
[ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi...
Hierarchical Sigmoid operator. Hierarchical sigmoid layer where the last node in the network is missing.
if set, the gradient of xx and xx will be sparse.
@@ -239,7 +239,7 @@ class DeletedSecret(SecretAttributes): @property def deleted_date(self): - # type: () -> datetime + # type: () -> Optional[datetime] """ When the secret was deleted, in UTC
[SecretAttributes->[__init__->[parse_vault_id,get],_from_secret_bundle->[cls],_from_secret_item->[cls]],DeletedSecret->[_from_deleted_secret_bundle->[cls],_from_deleted_secret_item->[cls],__init__->[super]],Secret->[__init__->[super],_from_secret_bundle->[cls]]]
When the secret was deleted in UTC .
Are these properties really optional? I expect all deleted secrets to have values for them.
@@ -1379,7 +1379,7 @@ crt_group_version_set(crt_group_t *grp, uint32_t version) D_GOTO(out, rc = -DER_INVAL); } - D_RWLOCK_RDLOCK(&grp_priv->gp_rwlock); + D_RWLOCK_WRLOCK(&grp_priv->gp_rwlock); grp_priv->gp_membs_ver = version; D_RWLOCK_UNLOCK(&grp_priv->gp_rwlock);
[No CFG could be retrieved]
This function returns the enclosing private struct ptr of grp. - DENY - DEPRECATED - USE in 2. 0. 1.
@jgmoore-or this seems like the real fix here which could potentially use a compare and swap. The read lock to read one field doesn't accomplish much outside of disallowing the simultaneous modification of said field.
@@ -582,7 +582,8 @@ dss_start_one_xstream(hwloc_cpuset_t cpus, int xs_id) * that creates ULT in DSS_XS_SELF. So ABT_POOL_ACCESS_PRIV * is fine. */ - access = (i == DSS_POOL_SHARE || i == DSS_POOL_REBUILD) ? + access = (i == DSS_POOL_SHARE || i == DSS_POOL_REBUILD || + i == DSS_POOL_URGENT) ? ABT_...
[dss_srv_init->[dss_srv_fini],dss_task_run->[dss_eventual_free,dss_eventual_create,dss_eventual_wait],dss_acc_offload->[dss_ult_create_execute],int->[dss_task_collective_reduce,dss_thread_collective_reduce],dss_ult_create_execute->[dss_ult_create]]
start a single xstream dss_xstream_create - creates a new xstream with the given attributes set stacksize of the current xstream free all objects in the array.
"Urgent ult (for dtx_resync) pool should not be PRIV, since dtx_resync can not be private ULT." seems to me that the dtx_resync only created/scheduled on caller's self XS, why should it be MPSC?