patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -0,0 +1,11 @@ +# -*- encoding : utf-8 -*- +# Be sure to restart your server when you modify this file. + +# Preserve the timezone of the receiver when calling to `to_time`. +# Ruby 2.4 will change the behavior of `to_time` to preserve the timezone +# when converting to an instance of `Time` instead of the previous b...
[No CFG could be retrieved]
No Summary Found.
Final newline missing.
@@ -161,10 +161,10 @@ public class ReplicationThrottler public List<String> getCurrentlyProcessingSegmentsAndHosts(String tier) { - Map<SegmentId, String> segments = currentlyProcessingSegments.get(tier); - List<String> retVal = new ArrayList<>(); - segments.forEach((segmentId, serverId) -> r...
[ReplicationThrottler->[ReplicatorSegmentHolder->[addSegment->[isAtMaxReplicants]]]]
Get currently processing segments and hosts for the given tier.
I wonder why you didn't use `StringUtils.format`.
@@ -98,6 +98,16 @@ func resourceAwsEc2CapacityReservation() *schema.Resource { Required: true, ForceNew: true, }, + "outpost_arn": { + Type: schema.TypeString, + Optional: true, + ValidateFunc: validation.All( + validation.StringMatch( + regexp.MustCompile(`^arn:aws([a-z-]+)?:outpo...
[GetChange,ModifyCapacityReservation,IgnoreAws,StringInSlice,Ec2KeyValueTags,Set,Ec2UpdateTags,Error,Format,GetOk,New,HasChange,Errorf,SetId,Bool,Time,RemoveDefaultConfig,MergeTags,CancelCapacityReservation,IgnoreConfig,Id,TimeValue,DescribeCapacityReservations,Int64,Get,Map,Printf,StringValue,String,Parse,CreateCapaci...
This function is used to create a resource in the resource provider. Tags creates a tag set for the specified resource.
It would probably be best to just use `validateArn` here - I can't think of any other cases where we ensure that the ARN is for the correct service.
@@ -85,7 +85,7 @@ PNGCRUSH_BIN = 'pngcrush' FLIGTAR = 'amo-admins+fligtar-rip@mozilla.org' THEMES_EMAIL = 'theme-reviews@mozilla.org' ABUSE_EMAIL = 'amo-admins+ivebeenabused@mozilla.org' -NOBODY_EMAIL = 'nobody@mozilla.org' +ADDONS_EMAIL = 'nobody@mozilla.org' DRF_API_VERSIONS = ['v3', 'v4'] DRF_API_REGEX = r'^/...
[get_redis_settings->[,int,append,dict,parse_qsl,float,urlparse],path->[join],lazy_langs->[lower],read_only_mode->[list,insert,get,tuple,index,Exception],lazy,gethostname,join,db,env,dict,Env,r'^,bool,list,get_redis_settings,dirname,exists,float,read_env,Queue,path,basename,get,lower,reverse_lazy]
Creates a new object with all the necessary information. Returns a list of cors endpoints that can be overridden by the user.
`ADDONS_EMAIL` already exists elsewhere in the settings file, so you can just delete this line.
@@ -332,7 +332,7 @@ namespace System.Reflection.Metadata foreach (var chunk in GetChunks()) { - destination.Write(chunk._buffer, 0, chunk.Length); + destination!.Write(chunk._buffer, 0, chunk.Length); } }
[BlobBuilder->[Clear->[FreeChunk],WriteDouble->[WriteDouble,ReserveBytesPrimitive],WriteGuid->[WriteGuid,ReserveBytesPrimitive],ToImmutableArray->[ToImmutableArray,ToArray],Align->[WriteBytes,Align],LinkPrefix->[CheckInvariants],ReserveBytesImpl->[Expand],Free->[Clear,FreeChunk],WriteUInt16BE->[ReserveBytesPrimitive,Wr...
Writes the contents of this buffer to the given destination stream.
`Throw.ArgumentNull(nameof(destination));` method above should be annotated with `[DoesNotReturn]`, then we will not needed to bang here and below
@@ -132,6 +132,13 @@ public class BeanInfo { this.creatorConsumer = creatorConsumer; this.destroyerConsumer = destroyerConsumer; this.params = params; + // Identifier is generated and unique for a specific deployment + // TODO: I am not quite sure if a simple idx is the best id ...
[BeanInfo->[addClassLevelBindings->[addClassLevelBindings],initLifecycleInterceptors->[isInterceptor,isClassBean],hasDefaultDestroy->[isInterceptor,isClassBean],Builder->[build->[BeanInfo]],getProviderType->[getProviderType],init->[init],getType->[isSynthetic,isProducerField,isProducerMethod],initInterceptedMethods->[i...
Returns the target annotation if any.
This may cause issues with the shamrock unit test stuff I just submitted a PR for, we should discuss this on Zulip.
@@ -244,8 +244,8 @@ class ConsumerGroupBindings(JSONController): binding_config = body.get('binding_config', None) options = body.get('options', {}) notify_agent = body.get('notify_agent', True) - async_task = consumer_group.bind.apply_async((group_id, repo_id, distributor_id, - ...
[ConsumerGroupCollection->[POST->[create_consumer_group,keys,child_link_obj,created,pop,update,consumer_group_manager,InvalidValue,MissingValue,params],GET->[find,ok,append,update,get_collection,child_link_obj],auth_required],ConsumerGroupBindings->[POST->[OperationPostponed,get,params,apply_async],GET->[serialize,find...
Create a new bind model object for a specified consumer group.
Forming the tuple inside of the method call is easy to misread the tuple for a list of parameters. It would be better to form the tuple on a line above, that way the function call is clear that there is one parameter, and it is a tuple.
@@ -15,6 +15,10 @@ namespace DynamoShapeManager public static readonly string PreloaderAssembly = "LibG.AsmPreloader.Managed.dll"; public static readonly string PreloaderClassName = "Autodesk.LibG.AsmPreloader"; public static readonly string PreloaderMethodName = "PreloadAsmLibraries"; + ...
[Utilities->[GetGeometryFactoryPath->[MapLibGVersionEnumToFullVersion,GetGeometryFactoryPath2],PreloadAsmFromPath->[GetType,RemapOldLibGPathToNewVersionPath,Public,Exists,Format,GetMethod,Invoke,WriteLine,IsNullOrEmpty,Combine,Static,LoadFrom],RemapOldLibGPathToNewVersionPath->[Build,Format,MapLibGVersionEnumToFullVers...
This class is used to determine the installed ASM version on a user machine. Check if the count of the items is greater than 0.
So these product names are the same as they appear in the registry? Does the order of product names matter in terms of choosing an ASM installation to use?
@@ -388,10 +388,10 @@ vts_dtx_commit_visibility(struct io_test_args *args, bool ext, bool punch_obj) assert_int_equal(rc, 0); if (punch_obj) - rc = vos_obj_punch(args->ctx.tc_co_hdl, args->oid, ++epoch, + rc = vos_obj_punch(args->ctx.tc_co_hdl, args->oid, epoch, 1, 0, NULL, 0, NULL, dth); else - rc =...
[void->[vos_fetch_begin,vts_dtx_prep_update,set_iov,d_iov_set,vos_hdl2cont,vts_dtx_commit_visibility,vos_dtx_abort,vos_dtx_check,vts_dtx_begin,daos_fail_loc_set,io_test_obj_update,vts_dtx_cos,vts_dtx_end,dts_buf_render,vos_dtx_commit,io_test_obj_fetch,malloc,vts_dtx_abort_visibility,daos_dti_equal,vts_dtx_shares,vos_dt...
commit visibility of object in transaction This function implements the virtual transaction end of the object. - DAOS_REC_ANY - DAOS_REC_ANY Checks if the data record with punch DTX is invisible after commit.
I am wondering why it works if without the patch PR#1138 that does not change the test logic, still uses "++epoch".
@@ -166,7 +166,7 @@ func (sd *SampleDecoder) Decode(s *model.Vector) error { // ExtractSamples builds a slice of samples from the provided metric // families. If an error occurs during sample extraction, it continues to // extract from the remaining metric families. The returned error is the last -// error that has ...
[Decode->[TextToMetricFamilies,LabelValue,LabelName,GetMetric,GetLabel,Decode,IsValid,IsValidMetricName,GetName,GetValue,Errorf,ReadDelimited],GetType,LabelValue,LabelName,IsInf,GetCumulativeCount,TimeFromUnixNano,GetQuantile,Sprint,GetUpperBound,ParseMediaType,GetName,Errorf,GetValue,SampleValue,Get,Metric,GetSampleCo...
Decode extracts the samples from the provided MetricFamily into the provided model. Vector. extractCounter extracts the samples from a metric family.
This is under vendor so probably shouldn't be changed.
@@ -131,9 +131,7 @@ class ReadOnlyByteBufferBuf extends AbstractReferenceCountedByteBuf { @Override public ByteBuf getBytes(int index, byte[] dst, int dstIndex, int length) { checkDstIndex(index, length, dstIndex, dst.length); - if (dst == null) { - throw new NullPointerException("d...
[ReadOnlyByteBufferBuf->[_getInt->[getInt],copy->[alloc,order],_getUnsignedMedium->[getByte],getBytes->[getBytes],array->[array],isDirect->[isDirect],_getLong->[getLong],_getShort->[getShort],arrayOffset->[arrayOffset],hasArray->[hasArray]]]
Gets the bytes in the buffer starting at the specified index and increases the position by the.
This is not dead code... we always explicit check for null params
@@ -96,6 +96,9 @@ JSON_COMPLIANCE_ERROR = 'NAN, INF and -INF values are not JSON compliant.' MAX_RETRIES = 3 UNKNOWN_MIME_TYPE = 'application/octet-stream' +# Timeout for a BQ streaming insert RPC. Set to a maximum of 2 minutes. +BQ_SI_TIMEOUT = 120 + class FileFormat(object): CSV = 'CSV'
[AppendDestinationsFn->[_get_table_fn->[_value_provider_or_static_val]],get_avro_schema_from_table_schema->[get_dict_table_schema],RowAsDictJsonCoder->[decode->[decode]],table_schema_to_dict->[get_table_field->[get_table_field],get_table_field],BigQueryReader->[__iter__->[convert_row_to_dict,run_query],__exit__->[clean...
Creates a new object with the values of a single entry in a bucket. Returns a string representation of a sequence number that can be used to create a hashable object.
How about BQ_STREAMING_INSERT_TIMEOUT_SEC? More verbose but I think that units helps prevent silly mistakes and SI is a bit cryptic Or is it standard for timeouts to be units of seconds in python? I don't see the units specified on parameter name for bq client.
@@ -2133,6 +2133,10 @@ SpellSpecificType SpellInfo::LoadSpellSpecific() const case 8115: // Agility case 8091: // Armor return SPELL_SPECIFIC_SCROLL; + case 12880: // Enrage (Enrage) + case 57518...
[CalcPowerCost->[LookupEntry],CalcCastTime->[IsAutoRepeatRangedSpell],GetDispelMask->[GetDispelMask],GetProvidedTargetMask->[GetObjectType,GetTargetFlagMask],CheckLocation->[LookupEntry],_IsPositiveEffect->[_IsPositiveEffect],Mechanics->[Mechanics],_IsPositiveTarget->[_IsPositiveTarget],NeedsExplicitUnitTarget->[GetExp...
Load the spell - specific information from the system. Check if a specific spell has a specific value. Check if a node has a specific node in the system. The most common case of the node is the most common case.
This is a confusing change. I'm not sure this Warrior logic should be put on generic families. Maybe loading a spell correction and change it's family to SPELLFAMILY_WARRIOR would be wiser for future purposes. Another thing that's bothering me is that you only added the Rank 1 Enrage spell for **Enrage** (12880) and th...
@@ -121,6 +121,7 @@ func ValidateInitiator(i models.Initiator, j models.JobSpec, store *store.Store) func validateFluxMonitor(i models.Initiator, j models.JobSpec, store *store.Store) error { fe := models.NewJSONAPIErrors() + minimumPollingInterval := models.Duration(store.Config.DefaultHTTPTimeout()) if i.Add...
[ForEach,MinimumServiceDuration,Now,StringMatches,MaximumServiceDuration,Merge,Wrap,Add,MinimumContractPayment,NewTaskType,Error,Cmp,New,CoerceEmptyToNil,NewLink,Dev,Address,Bytes,After,FindExternalInitiatorByName,TrimSpace,NewJSONAPIErrorsWith,Until,Unix,NewJSONAPIErrors,MinimumRequestExpiration,ToLower,ParseRequestUR...
ValidateInitiator validates the Initiator. validateFeeds validates the given feeds and returns an error if the data is invalid.
Should we use the same formatting in our API and configuration for string durations? This could possibly mean using the models.Duration type in our config schema
@@ -11,13 +11,13 @@ from six.moves import http_client # pylint: disable=import-error import OpenSSL import requests import sys -import werkzeug from acme import errors from acme import jose from acme import jws from acme import messages +from email.utils import parsedate_tz logger = logging.getLogger(__n...
[ClientNetwork->[_get_nonce->[_add_nonce,head],post->[_check_response,_wrap_in_jws,_send_request,_add_nonce,_get_nonce],get->[_check_response,_send_request],head->[_send_request]],Client->[agree_to_tos->[update_registration],poll->[_authzr_from_response],request_challenges->[_authzr_from_response],check_cert->[_get_cer...
Create an ACS client for a single . This method is used to create a regr object from a nexus network response.
stdlib imports should happen in the top-most import group
@@ -187,10 +187,11 @@ public class TopicStream { return false; } - String print(ConsumerRecord<String, Bytes> record) throws IOException { - String key = record.key() != null ? record.key() : "null"; + String print(final ConsumerRecord<String, Bytes> record) throws IOException { + final St...
[TopicStream->[print->[format],getFormatter->[isFormat]]]
isFormat - method to check if a record is formatted according to the given key and value.
nit: could use String.valueOf here. It will take care of the null-check for you. It returns "null" for null values though.
@@ -45,6 +45,8 @@ class Graphviz(AutotoolsPackage): 'bindings'.format(lang)) # Feature variants + variant('doc', default=False, + description='Build and install graphviz documentation') variant('expat', default=False, description='Build with Expat support (enables...
[Graphviz->[setup_build_environment->[set],configure_args->[append,format,with_or_without],autoreconf->[exists,bash,which],patch->[filter_file],depends_on,Version,conflicts,format,version,patch,when,variant],macos_version]
This function is used to determine which versions of a specific language are required. variant - related functions.
Opinions on doc vs docs? I can't remember which is more common.
@@ -525,7 +525,14 @@ dbuf_evict_one(void) multilist_sublist_unlock(mls); (void) refcount_remove_many(&dbuf_cache_size, db->db.db_size, db); + DBUF_STAT_BUMPDOWN(cache_levels[db->db_level]); + DBUF_STAT_BUMPDOWN(cache_count); + DBUF_STAT_DECR(cache_levels_bytes[db->db_level], + db->db.db_size); d...
[No CFG could be retrieved]
evict_one - evicts the oldest eligible dbuf from the dbuf cache. This function is called when the dbuf cache is removed from the cache and the cache is.
You mean `cache_size_max` here.
@@ -102,14 +102,7 @@ denied_project[project] { has_project[[project, pol_id, statement_id]] } -# when no input is provided, this rule short-circuits checking any other allowed projects -denied_all_projects { - match[["deny", pol_id, statement_id]] - common.const_all_projects == policies[pol_id].statements[statemen...
[No CFG could be retrieved]
Short - circuits checking any other allowed projects.
I was going to say, "Wait, wait; this is needed for a special case!" But not anymore.
@@ -63,11 +63,10 @@ public class JaxRsAnnotationsDecorator extends BaseDecorator { } } - private void updateParent(AgentSpan span, final String resourceName) { + private void updateParent(final AgentSpan span, final String resourceName) { if (span == null) { return; } - span = span.getLo...
[JaxRsAnnotationsDecorator->[JaxRsAnnotationsDecorator]]
On jax - rs span.
This is going to cause some weirdness... I couldn't think of a better solution though. Ideas?
@@ -810,6 +810,8 @@ def logloss(y_true, y_pred): return K.mean(-losses, axis=-1) +@keras_export('keras.losses.huber', + 'keras.losses.huber_loss') def huber_loss(y_true, y_pred, delta=1.0): """Computes Huber loss value.
[binary_crossentropy->[binary_crossentropy],categorical_crossentropy->[categorical_crossentropy],logcosh->[_logcosh],sparse_categorical_crossentropy->[sparse_categorical_crossentropy],hinge->[_maybe_convert_labels],get->[deserialize],squared_hinge->[_maybe_convert_labels]]
Computes the Huber loss value.
Can we update the name to huber and just export `keras.losses.huber`?
@@ -6,7 +6,7 @@ Name: daos Version: 1.1.0 -Release: 27%{?relval}%{?dist} +Release: 28%{?relval}%{?dist} Summary: DAOS Storage Engine License: Apache
[No CFG could be retrieved]
DAO - specific configuration for a sequence number. Check if a node - id is present in the system.
there is now a conflict on this file so will need a refresh
@@ -10,10 +10,12 @@ import os.path as op import mne data_path = op.join(mne.datasets.sample.data_path(), 'MEG', 'sample') -raw = mne.io.read_raw_fif(op.join(data_path, 'sample_audvis_raw.fif')) +raw = mne.io.read_raw_fif(op.join(data_path, 'sample_audvis_raw.fif'), + add_eeg_ref=False) +raw...
[read_events,plot_image,plot,data_path,read_raw_fif,plot_topo_image,join,Epochs,pick_types]
_tutviz_epochs _tut_viz_functions _tut_viz How to plot the epochs at one time.
raw.set_eeg_reference() # set EEG average reference
@@ -210,16 +210,13 @@ public class VmwareHelper { dvPortConnection.setPortgroupKey(morNetwork.getValue()); dvPortBacking.setPort(dvPortConnection); nic.setBacking(dvPortBacking); - nic.setKey(30); connectInfo.setAllowGuestControl(true); - connectInfo.setConnected(conn...
[VmwareHelper->[getExceptionMessage->[getExceptionMessage],setParentBackingInfo->[setParentBackingInfo],findSnapshotInTree->[findSnapshotInTree]]]
This method prepares a VirtualDevice object for use with a DvNic.
@rhtyd I know this is not your code, but there is something that called my attention (maybe you know why this is the way it is). At first I thought it was some dusty on my laptop screen... When the method `nic.setKey` is called, the code does `-contextNumber`, converting the positive integer to a negative one. I looked...
@@ -532,12 +532,13 @@ void initializePaths() dstream << "WARNING: Could not determine bundle resource path" << std::endl; } CFRelease(resources_url); - path_user = std::string(getenv("HOME")) + "/Library/Application Support/" + PROJECT_NAME; + + path_user = std::string(getenv("HOME")) + "/Library/Application Sup...
[No CFG could be retrieved]
Find the alternative system - wide shared and the path to the resource. - > Set the XORG class hint - > Set the XORG class hint - >.
This is a perfect example of why I think the # part of the directive should be at the start of the line and the tab after the # CC. @kwolekr
@@ -34,7 +34,7 @@ class TagsController < ApplicationController # Creates a new instance of the tag. def create - tag_params = params.require(:tag).permit(:name, :description) + tag_params = params.require(:tag).permit(:name, :description, :assignment_id) new_tag = Tag.new(tag_params.merge(user: @curr...
[TagsController->[destroy->[destroy],update->[update]]]
create a new tag and return it.
You don't need to add `assignment_id` here, this attribute is set separately.
@@ -111,6 +111,11 @@ func main() { namespaceController := namespace.NewNamespaceController(kubeConfig, osmID, stop) meshSpec := smi.NewMeshSpecClient(kubeConfig, osmNamespace, namespaceController, stop) + cert, err := tresor.LoadCA(*rootCertPem, *rootKeyPem) + if err != nil { + log.Fatal().Msgf("Error loading CA...
[StringVar,RegisterExitHandlers,BuildConfigFromFlags,NewCertManagerWithCAFromFile,Msgf,NewGrpc,NewADSServer,NewMeshSpecClient,NewProvider,Info,IntVar,Int,New,Start,NewClient,Trace,InClusterConfig,SetLogLevel,NewMeshCatalog,RegisterAggregatedDiscoveryServiceServer,GrpcServe,ListenAndServe,NewNamespaceController,NewFlagS...
Creates the in - cluster config and starts the main goroutine. Register the ADS server and the Lis server.
Where is `cert` being used?
@@ -2680,11 +2680,13 @@ func flattenClusterAddonsConfig(c *containerBeta.AddonsConfig) []map[string]inte } if c.CloudRunConfig != nil { - result["cloudrun_config"] = []map[string]interface{}{ - { - "disabled": c.CloudRunConfig.Disabled, - }, + cloudRunConfig := map[string]interface{}{ + "disabled": c.C...
[Unlock,GetChange,NewSet,CIDRNetwork,SetPartial,SetNetworkPolicy,DeepEqual,RelativeLink,Delete,StringInSlice,Partial,SetResourceLabels,HasPrefix,Set,Add,Done,NonRetryableError,MatchString,GetOk,FindStringSubmatch,HasChange,All,LessThan,Lock,Errorf,SetId,MustCompile,RetryableError,HasSuffix,Create,Wrapf,Equal,Timeout,Do...
flattenClusterNodePools flatten a list of nodes and nodes in a container. flattenAuthenticatorGroupsConfig flattens authenticatorGroupsConfig into a slice of map where the keys.
Since we are hardcoding "internal" here, setting the balancer type to "INTERNAL" will result in a permanent diff. We should commit to one, or pass through the full `LOAD_BALANCER_TYPE_INTERNAL` which will allow us to get rid of the if condition.
@@ -915,7 +915,7 @@ class WPSEO_Frontend { $canonical = get_search_link(); } elseif ( is_front_page() ) { - $canonical = home_url(); + $canonical = home_url( user_trailingslashit( '' ) ); } elseif ( $this->is_posts_page() ) { $canonical = get_permalink( get_option( 'page_for_posts' ) );
[WPSEO_Frontend->[generate_title->[is_home_static_page,get_title_from_options,get_author_title,is_home_posts_page,get_default_title,is_posts_page,get_content_title,get_taxonomy_title],generate_canonical->[is_posts_page],metakeywords->[is_posts_page,is_home_static_page,is_home_posts_page],adjacent_rel_links->[is_home_st...
Generate the canonical url for the post. This function is used to generate a canonical post link for the current post type. Set the canonical URL for the page.
Let's turn this around and have `user_trailingslashit` use `home_url` as it's argument. `home_url` uses `get_home_url` which does an `ltrim` on the path, which in this case would be `/` resulting in no trailing slash on the url.
@@ -557,6 +557,8 @@ Options:\n\ Number of targets to use (use all cores by default)\n\ --xshelpernr=nhelpers, -x helpers\n\ Number of helper XS -per vos target (default 1)\n\ + --pinned_numa_node, -p (default 0)\n\ + pinned numa node\n\ --firstcore=firstcore, -f firstcore\n\ index of fi...
[int->[D_GOTO,ABT_init,ABT_cond_create,setenv,max,server_init_state_wait,dss_module_fini,strdup,dss_module_load,ds_iv_fini,daos_fini,getenv,D_ASSERT,ABT_mutex_free,atoi,crt_finalize,getopt_long,crt_init_opt,printf,daos_debug_init,daos_init,d_hhash_set_ptrtype,daos_crt_init_opt_get,daos_errno2der,strlen,abt_init,abt_max...
Print usage of the missing block header.
(style) space prohibited between function name and open parenthesis '('
@@ -103,6 +103,14 @@ public class FileCacheStoreTest extends BaseCacheStoreTest { assert fcs.load("k3") == null; } + private boolean moreThanLifespanElapsed(long start, long lifespan) { + return now() - lifespan >= start; + } + + private long now() { + return TimeUnit.NANOSECONDS.toMillis(S...
[FileCacheStoreTest->[createCacheStore->[clearTempDir],testPreload->[testPreload]]]
Test purge expired cache.
Why not use `System.currentTimeMillis()` directly?
@@ -276,6 +276,10 @@ class ReferenceCollectingClassVisitor extends ClassVisitor { private class AdviceReferenceMethodVisitor extends MethodVisitor { private int currentLineNumber = -1; + // this data structure will remember last two LDC <class> instructions before + // InstrumentationContext.get() call ...
[ReferenceCollectingClassVisitor->[computeMinimumClassAccess->[internalPackageName],AdviceReferenceMethodVisitor->[visitLineNumber->[visitLineNumber],visitLdcInsn->[visitLdcInsn,addReference,underlyingType],visitFieldInsn->[visitFieldInsn,computeMinimumFieldAccess,addReference,underlyingType],visitMethodInsn->[visitMet...
Visit a line number and check for missing missing nodes.
it might work nice to extract this to a separate "TrackingMethodVisitor", and then `new AdviceReferenceMethodVisitor(new TrackingMethodVisitor(methodVisitor))`
@@ -809,6 +809,11 @@ func (mod *modContext) getConstructorResourceInfo(resourceTypeName string) map[s case "nodejs", "go": // Intentionally left blank. case "csharp": + if mod.mod == "" { + resourceTypeName = fmt.Sprintf("Pulumi.%s.%s", title(mod.pkg.Name, lang), resourceTypeName) + break + } + ...
[genResource->[genNestedTypes,genLookupParams,genConstructors,getProperties,getConstructorResourceInfo],gen->[getModuleFileName,genResource,add],genNestedTypes->[typeString],genIndex->[getModuleFileName],genConstructorCS->[typeString],genConstructors->[genConstructorTS,genConstructorGo,genConstructorCS],genLookupParams...
getConstructorResourceInfo returns a map of the language - specific information about the given resource type.
This actually fixes a bug for _all_ providers right now. The `Provider` resource will never have a module name and as such its link is always at the package-level.
@@ -95,7 +95,8 @@ static int blake2b_mac_ctrl(EVP_MAC_IMPL *macctx, int cmd, va_list args) } blake2b_param_set_key_length(&macctx->params, (uint8_t)len); memcpy(macctx->key, p, len); - memset(macctx->key + len, 0, BLAKE2B_KEYBYTES - len); + if (len < BLAKE2B_...
[No CFG could be retrieved]
Blake2b Mac control function. Function to handle the blake2b MAC control.
I don't understand this change. The only thing this check seems to do is avoid the call memset(macctx->key + BLAKE2B_KEYBYTES, 0, 0), and I don't see anything wrong with that.
@@ -40,9 +40,9 @@ class CsProcess(object): def find_pid(self): self.pid = [] + items = len(self.search) for i in CsHelper.execute("ps aux"): - items = len(self.search) - proc = re.split(r"\s+", i)[items*-1:] + proc = re.split(r"\s+", i)[10:] ...
[CsProcess->[find->[find_pid,len],kill->[execute],start->[info,system,join],find_pid->[split,debug,append,len,execute],kill_all->[find_pid,execute],grep->[split,find,execute]]]
Find process ID in search.
given this is null based the return is now the full cli as returned by `ps aux` ; :+1:
@@ -374,12 +374,15 @@ class RaidenEventHandler: log.warning( f'Unlock not done. ' f'Failed to find state/event that match current channel locksroots. ' + f'chain_id:raiden.chain.network_id ' f'token:{to_checksum_address(token_address)} ' ...
[RaidenEventHandler->[handle_send_secretrequest->[send_async,message_from_sendevent,sign],handle_send_secretreveal->[send_async,message_from_sendevent,sign],handle_send_balanceproof->[send_async,message_from_sendevent,sign],handle_paymentsentsuccess->[set,targets_to_identifiers_to_statuses],on_raiden_event->[handle_con...
Handle a ContractSendChannelUnlock event. Get the next unlock for a given node.
@hackaugusto you forgot the `{ .. }` for the fstring here.
@@ -101,6 +101,13 @@ module Repository FileUtils.rm_rf(repo_path) end + # Given a OID of a file from a Rugged::Repository lookup, return the blob + # object of the file itself. + def get_blob(oid) + blob = @repos.lookup(oid) + return blob + end + # Exports git repo to a new fold...
[GitRevision->[initialize->[get_repos]],GitRepository->[delete_bulk_permissions->[add_user],expand_path->[expand_path],remove_user->[add_user],add_file->[path_exists_for_latest_revision?],latest_revision_number->[get_revision_number],remove_file->[commit_options,create],create->[commit_options,create],access->[open],ma...
Delete a from the repository.
Redundant `return` detected.
@@ -95,6 +95,11 @@ module Engine revenue += 20 if route.corporation.assigned?(port.id) && stops.any? { |stop| stop.hex.assigned?(port.id) } # TODO: Add bridge and tunnel private revenue modifiers + route.corporation.companies.each do |company| + abilities(company, :hex_bonus) do |abi...
[G1856->[interest_owed->[interest_owed_for_loans],can_take_loan?->[maximum_loans],all_potential_upgrades->[gray_phase?],upgrades_to?->[gray_phase?],national_share_swap->[national_issue_shares!]]]
Returns the revenue for a given route and stops.
you don't need the &
@@ -93,6 +93,9 @@ namespace Microsoft.Extensions.Logging.Generators } sm ??= _compilation.GetSemanticModel(classDec.SyntaxTree); + IMethodSymbol logMethodSymbol = sm.GetDeclaredSymbol(method, _cancellationToken) as IMethodSymbol; + ...
[LoggerMessageGenerator->[LoggerMethod->[OrdinalIgnoreCase,Empty],LoggerParameter->[Empty],LoggerClass->[Empty],Parser->[ExtractTemplates->[Add,IsNullOrEmpty,FindIndexOfAny,Substring,Length,FindBraceIndex],GetLogClasses->[ReturnsVoid,Message,StartsWith,MultipleLoggerFields,ShouldntMentionLogLevelInMessage,Array,ValueTe...
Returns a list of LoggerClasses that are available in the specified classes. Checks if a method has a missing attribute or if it s a static or partial attribute. Checks if a node in the stack is missing a node in the method or if it is Diagnostics are reported if there is no diagnostic diagnostic for this parameter.
Does this need to use a tuple anymore? Can this just be regular variables?
@@ -1162,7 +1162,8 @@ def softmax_with_cross_entropy(logits, ignore_index=kIgnoreIndex, numeric_stable_mode=True, return_softmax=False, - axis=-1): + axis=-1, + ...
[nce->[_init_by_numpy_array],mse_loss->[square_error_cost],cross_entropy2->[cross_entropy2],softmax_with_cross_entropy->[softmax_with_cross_entropy],warpctc->[warpctc],cross_entropy->[cross_entropy],npair_loss->[softmax_with_cross_entropy]]
r softmax with cross entropy loss function A tensor of unscaled log probabilities of the given . Softmax with cross entropy.
softmax_with_cross_entropyapifluidpython paddle.nn.functional.loss.pycore.ops.softmax_with_cross_entropyappend op
@@ -73,6 +73,14 @@ class ProductError(Error): code = ProductErrorCode(description="The error code.", required=True) +class ProductAttributeError(ProductError): + attributes = graphene.List( + graphene.NonNull(graphene.ID), + description="List of attributes IDs which causes the error.", + ...
[WishlistError->[WishlistErrorCode],PermissionDisplay->[PermissionEnum,String],IntRangeInput->[Int],LanguageDisplay->[LanguageCodeEnum,String],ExtensionsError->[ExtensionsErrorCode],StockError->[StockErrorCode],SeoInput->[String],Weight->[String,Float],TaxType->[String],ShippingError->[ShippingErrorCode,NonNull,List],E...
A basic error - message that can be displayed when a mutation fails. Error handler for errors that occur when the error is not a valid stock error.
I am not sure if we should create a new class or just add the `attributes` field to `ProductError`. I think it might be useful also in other mutations and checks.
@@ -296,6 +296,11 @@ class Hyperband(MsgDispatcherBase): # In this case, tuner increases self.credit to issue a trial config sometime later. self.credit = 0 + # record the latest parameter_id of the trial job trial_job_id. + # if there is no running parameter_id, self.job_id_para_id_ma...
[Bracket->[inform_trial_end->[get_n_r,create_bracket_parameter_id],_record_hyper_configs->[increase_i],get_hyperparameter_configurations->[create_bracket_parameter_id,json2parameter]],Hyperband->[_request_one_trial_job->[Bracket]],create_bracket_parameter_id->[create_parameter_id],json2parameter->[json2parameter]]
Initialize hyperband object with a random number of random variables.
load_checkpoint and save_checkpoint can be removed if they are empty.
@@ -290,8 +290,8 @@ namespace System.Windows.Forms { // We can't cache this value because different top level windows can have different DPI awareness context // for mixed mode applications. - DpiAwarenessContext dpiAwareness = CommonUnsafeNa...
[DpiHelper->[LogicalToDeviceUnitsY->[LogicalToDeviceUnits],LogicalToDeviceUnitsX->[LogicalToDeviceUnits],InitializeDpiHelperForWinforms->[Initialize],Size->[LogicalToDeviceUnits],InitializeDpiHelperQuirks->[IsDpiAwarenessValueSet],Initialize,InitializeDpiHelperForWinforms]]
Flags for whether or not to cache a single - pass object. This is a static method to enable single - pass scaling of DPI forms and high -.
In line 585ff in this file, should we add DpiUnawareGdiScaled to have parity with the DpiHelper from the runtime? Can we actually consolidate DpiHelper, maybe with #ifs and File References, so we have parity here?
@@ -136,6 +136,8 @@ class BlocklistGfx(BlocklistBase, amo.models.ModelBase): feature = models.CharField(max_length=255, blank=True, null=True) feature_status = models.CharField(max_length=255, blank=True, null=True) driver_version = models.CharField(max_length=255, blank=True, null=True) + driver_vers...
[BlocklistApp->[ForeignKey,CharField],BlocklistPlugin->[CharField,OneToOneField,SmallIntegerField,URLField],BlocklistGfx->[CharField,OneToOneField],BlocklistPref->[ForeignKey,CharField],BlocklistCA->[TextField],BlocklistBase->[save->[getattr,super,isinstance,setattr],get_url_path->[reverse]],BlocklistDetail->[CharField...
A class to hold all of the fields related to the n - th object in the model The base class for all of the blocklist objects.
--(You're not allowing `NULL` in the sql migration, why here?)-- nevermind that, they're nullable by default, forgot :smile:
@@ -1,5 +1,5 @@ -""" Demonstration of how to register event callbacks using an adaptation -of the color_scatter example from the Bokeh gallery +""" Demonstration of how to register event callbacks using an adaptation of the color_scatter example from the Bokeh gallery + """ import numpy as np
[display_event->[dict,CustomJS],js_on_event,int,display_event,show,output_file,random,Button,Div,column,scatter,row,zip,figure]
Demonstration of how to register event callbacks using an adaptation of the color_ Displays a button with no attributes and a mouse wheel event.
This just had to be changed because the line break, and then lack of blank final line, was breaking the docstring parsing.
@@ -16,7 +16,7 @@ namespace System.Windows.Forms { } - private ProgressBar OwningProgressBar => Owner as ProgressBar; + private ProgressBar? OwningProgressBar => Owner as ProgressBar; internal override bool IsIAccessibleExSupported() => true;
[ProgressBar->[ProgressBarAccessibleObject->[IsPatternSupported->[IsPatternSupported],GetPropertyValue->[GetPropertyValue]]]]
IsIAccessibleExSupported - override to check if IAccessibleEx is supported.
Could this be `null`?
@@ -47,13 +47,14 @@ async function sendInvites(referrer, recipients) { } // Send the invite code to the recipient. - // TODO: should we have an html version of the email ? + const dappUrl = process.env.DAPP_URL || 'http://localhost:3000' + const welcomeUrl = `${dappUrl}?inviteCode=${code}` con...
[No CFG could be retrieved]
Load the referrer s identity and get their name.
Currently in url pattern for invite code is: `http://{dapp-url}/#/welcome/[invite-code]` e.g. `http://localhost:3000/#/welcome/msjcfgevu2`
@@ -371,6 +371,9 @@ class Axom(CachedCMakePackage, CudaPackage): def cmake_args(self): options = [] + if '%cce' in self.spec: + options.append('-DCMAKE_Fortran_FLAGS=-ef') + if self.run_tests is False: options.append('-DENABLE_TESTS=OFF') else:
[Axom->[initconfig_package_entries->[get_spec_path],cache_name->[_get_sys_type]]]
Return a list of CMake arguments for the command.
Compiler specs are usually checked with `self.spec.satisfied()`.
@@ -54,4 +54,9 @@ public class ConditionAlwaysTrueOrFalseCheckTest { // Checks flow iterating through the correct parent JavaCheckVerifier.verify("src/test/files/se/ConditionAlwaysTrueOrFalseCheckParentLoop.java", new ConditionAlwaysTrueOrFalseCheck()); } + + @Test + public void test_transitivity() throw...
[ConditionAlwaysTrueOrFalseCheckTest->[reporting->[verify,ConditionAlwaysTrueOrFalseCheck],condition_always_true_with_optional->[verifyNoIssue,ConditionAlwaysTrueOrFalseCheck],test->[verify,ConditionAlwaysTrueOrFalseCheck],reporting_getting_wrong_parent->[verify,ConditionAlwaysTrueOrFalseCheck],whole_stack_required_for...
Checks flow iterating through the correct parent condition.
while getting inspiration from CPP plugin is great we may not want to copy even the names...
@@ -237,7 +237,7 @@ class KeypointRCNNPredictor(nn.Module): super(KeypointRCNNPredictor, self).__init__() input_features = in_channels deconv_kernel = 4 - self.kps_score_lowres = misc_nn_ops.ConvTranspose2d( + self.kps_score_lowres = nn.ConvTranspose2d( input_featur...
[KeypointRCNNPredictor->[forward->[float,kps_score_lowres,interpolate],__init__->[ConvTranspose2d,kaiming_normal_,super,constant_]],KeypointRCNN->[__init__->[type,MultiScaleRoIAlign,tuple,KeypointRCNNPredictor,super,ValueError,isinstance,range,KeypointRCNNHeads]],KeypointRCNNHeads->[__init__->[Conv2d,append,kaiming_nor...
Initialize the KeypointRCNNPredictor.
Great that we already support empty tensors in PyTorch! Thanks for the cleanup!
@@ -199,13 +199,16 @@ public class FileSystemRepository implements ContentRepository { for (final Map.Entry<String, Path> container : containers.entrySet()) { final String containerName = container.getKey(); - final long capacity = Files.getFileStore(container.getValue())....
[FileSystemRepository->[destroyExpiredArchives->[visitFile->[size,toString,getLastModTime],compare->[compare,getLastModTime],size,remove,getLastModTime,toString,deleteBasedOnTimestamp,getContainerUsableSpace],ArchiveInfo->[toString],write->[close->[close,remove],flush->[flush],write],remove->[getPath,remove],getLastMod...
Replies the maximum threshold for the containers. Initialize FileSystemRepository with alwaysSync set to true.
@PuspenduBanerjee the issue that @mosermw brought up is a valid point, I believe. The idea here was to ensure that things are backward compatible. However, this is essentially converting an IOException to a RuntimeException, which is certainly not backward compatible, because the code that calls this method would have ...
@@ -326,7 +326,7 @@ def _append_backward_ops_(block, grad_sub_block_list = [] # If the op has its own sub-block, deal with the sub-block first if op.has_attr("sub_block"): - sub_block = program.block(op.block_attr("sub_block")) + sub_block = program.block(op._block_attr(...
[_find_op_path_->[_some_in_set_],calc_gradient->[_find_op_path_,_append_backward_vars_,_create_op_desc_,_as_list,_get_stop_gradients_,_append_grad_suffix_,_rename_grad_,_append_backward_ops_],_append_backward_vars_->[_infer_var_data_type_,_append_backward_vars_],_remove_no_grad_branch_->[_op_can_be_removed_->[_all_in_s...
Create all backward ops and insert them into given block. Adds all op s corresponding grad_op_desc to the target_block and calls the.
Use a protected class method?
@@ -41,6 +41,18 @@ const FULL_SCREEN_EVENTS = [ 'fullscreenchange' ]; +/** + * The CSS class to apply to the root element of the conference so CSS can + * modify the app layout. + * + * @private + * @type {Object} + */ +const LAYOUT_CLASSES = { + HORIZONTAL_FILSTRIP: 'horizontal-filmstrip', + VERTICAL_FIL...
[No CFG could be retrieved]
The base class for all components that are not part of a conference. Constructor for the instance.
Just a typo FILSTRIP instead of FILMSTRIP.
@@ -58,6 +58,8 @@ func (p *Timeout) Next() (Message, error) { } select { + case <-p.done: + return Message{}, ErrReaderStopped case msg := <-p.ch: if msg.err != nil { p.running = false
[Next->[After,Next],New]
Next returns the next message from the input stream. If there are no more messages in the.
with error code being forwarded from `p.reader`, I wonder if we need the channel here.
@@ -168,6 +168,11 @@ public final class PullQueryExecutor { + "this feature."); } + if (!rateLimiter.tryAcquire()) { + throw new KsqlException("Host is at rate limit for pull queries. Currently set to " + + rateLimiter.getRate() + " qps."); + } + try { final Immutab...
[PullQueryExecutor->[ConfigRoutingOptions->[getLong->[getLong],getOffsetLagAllowed->[getLong],skipForwardRequest->[getForwardedFlag]],extractWhereInfo->[WhereInfo],analyze->[analyze],extractComparisons->[extractComparisons]]]
Executes a pull query and returns the result as a table rows entity.
how does this interact with host forwarding? If I forwarded to a host that is overwhelmed will I then try it's standby? It might make sense to check the error message and not forward to another host in this scenario (not sure if that's what happens or not)
@@ -15,7 +15,8 @@ frappe.tests = { } }, () => { - return frappe.tests.set_form_values(cur_frm, data); + frappe.tests.set_form_values(cur_frm, data); + return frappe.timeout(1); }, () => frappe.timeout(1), () => (frappe.quick_entry ? frappe.quick_entry.insert() : cur_frm.save())
[No CFG could be retrieved]
The main test method. tasks to set each row value.
1 second is too much timeout! try 0.2
@@ -1891,7 +1891,7 @@ bool EncoderMD::TryFold(IR::Instr *instr, IR::RegOpnd *regOpnd) { IR::Instr *instrNext = instr->GetNextRealInstrOrLabel(); - if (instrNext->IsBranchInstr() && instrNext->AsBranchInstr()->IsConditional()) + if (instrNext->IsBranchInstr() && instrNext->A...
[No CFG could be retrieved]
Check if a constant is used in the current register. Check if a branch can be found.
>instrNext->AsBranchInstr()->m_areCmpRegisterFlagsUsedLater [](start = 93, length = 58) You forgot the ! here...
@@ -473,7 +473,16 @@ class UM3OutputDevicePlugin(OutputDevicePlugin): # Set the machine's cloud flow as complete so we don't ask the user again and again for cloud connected printers active_machine = self._application.getMachineManager().activeMachine if active_machine: - active_ma...
[UM3OutputDevicePlugin->[_onMachineSwitched->[checkCloudFlowIsPossible],stop->[stop],removeManualDevice->[resetLastManualDevice],start->[start],startDiscovery->[resetLastManualDevice]]]
Callback for the Cloud Printing component.
Does this also have to match printers by IP address too?
@@ -54,6 +54,7 @@ import org.apache.hudi.table.action.commit.FlinkMergeHelper; import org.apache.hudi.table.action.commit.FlinkUpsertCommitActionExecutor; import org.apache.hudi.table.action.commit.FlinkUpsertPreppedCommitActionExecutor; import org.apache.hudi.table.action.rollback.FlinkCopyOnWriteRollbackActionExec...
[HoodieFlinkCopyOnWriteTable->[insertPrepped->[HoodieNotSupportedException,execute],cluster->[HoodieNotSupportedException],bulkInsert->[HoodieNotSupportedException],bootstrap->[HoodieNotSupportedException],scheduleCompaction->[HoodieNotSupportedException],upsertPrepped->[HoodieNotSupportedException,execute],bulkInsertP...
Imports the methods defined in the HoodieWriteConfig object. Implementation of a very heavily read - optimized Hoodie Table where all data.
revert unintended changes
@@ -229,12 +229,14 @@ public abstract class AbstractTestQueryFramework protected void assertQueryReturnsEmptyResult(@Language("SQL") String sql) { - QueryAssertions.assertQueryReturnsEmptyResult(queryRunner, getSession(), sql); + assertThat(query(sql)) + .returnsEmptyResult(); ...
[AbstractTestQueryFramework->[computeActual->[getSession,computeActual],assertQueryFails->[getSession,assertQueryFails],assertTableColumnNames->[computeActual],assertQueryOrdered->[assertQueryOrdered,getSession,assertQuery],assertUpdate->[assertUpdate,getSession,assertQuery],getQueryExplainer->[getNodeCount],assertQuer...
Assert that query returns an empty result.
don't you need to deprecate the `assertQueryReturnsEmptyResult` method?
@@ -5423,6 +5423,17 @@ void Parser::ParseFncFormals(ParseNodePtr pnodeFnc, ushort flags) { Error(ERRRestWithDefault); } + + // In defer parse mode we have to flag the function node to indicate that it has default arguments + ...
[No CFG could be retrieved]
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -.
Why not just m_currentFunctionNode? instead of getting this from GetCurrentFunctionNode()? this function will give different thing depending on which one is available. It may be possible that we may set this flag on the wrong functionNode. I know you just moved this code up - but good to verify that.
@@ -13,7 +13,8 @@ import lombok.Getter; */ @Getter @AllArgsConstructor -public class MessageHeader { +public class MessageHeader implements Serializable { + private static final long serialVersionUID = -2854966142411168305L; // to can be null if we are a broadcast @Nullable private final INode to;
[No CFG could be retrieved]
Construct a MessageHeader object.
Now this class can't be moved or renamed because this would break compatibility.
@@ -165,7 +165,7 @@ class Defaults { 'jetpack_publicize_options', 'jetpack_connection_active_plugins', 'jetpack_sync_non_blocking', // is non-blocking Jetpack Sync flow enabled. - 'ce4wp_referred_by', // Creative Mail. See pbtFPC-H5-p2 + 'ce4wp_referred_by', // Creative Mail. See pbtFPC-H5-p2 . ); /**
[Defaults->[is_multi_network->[is_multi_network]]]
Get options whitelist Filters the list of WordPress options that are manageable via the JSON API.
Unrelated change, but necessary to stay lint-free.
@@ -1833,6 +1833,16 @@ func (a *apiServer) hardStopPipeline(pachClient *client.APIClient, pipelineInfo ); err != nil && !isNotFoundErr(err) { return errors.Wrapf(err, "could not recreate original output branch") } + if pipelineInfo.EnableStats { + if err := pachClient.CreateBranch( + pipelineInfo.Pipeline.Nam...
[getLogsLoki->[authorizePipelineOp],cleanUpSpecBranch->[sudo],FlushJob->[listJob,InspectJob],GetLogs->[GetLogs,authorizePipelineOp],UpdateJobStateInTransaction->[UpdateJobState],ActivateAuth->[fixPipelineInputRepoACLs,ListPipeline,sudo],makePipelineInfoCommit->[sudo],RestartDatum->[InspectJob],RunPipeline->[InspectJob,...
hardStopPipeline stops a pipeline.
Does this logic (closing any existing open commits) need to be applied to the stats branch as well?
@@ -877,6 +877,7 @@ $ {{alias}} repo@branch -i http://host/path`, putFile.Flags().StringSliceVarP(&filePaths, "file", "f", []string{"-"}, "The file to be put, it can be a local file or a URL.") putFile.Flags().StringVarP(&inputFile, "input-file", "i", "", "Read filepaths or URLs from a file. If - is used, paths ar...
[StringVar,Pull,PrintDetailedCommitInfo,TempFile,TempDir,SubscribeCommit,Acquire,HasPrefix,CreateRepo,DeleteCommit,UintVar,Walk,RunFixedArgs,Flush,New,CreateDocsAlias,NewPutFileClient,PrintDetailedBranchInfo,StartCommit,NewWriter,GetFile,MarkFlagCustom,Split,PutFile,Println,Stdin,AddFlagSet,Finish,IntVarP,SameFlag,Push...
Flags for storing a sequence of unique identifiers. putFile registers completion functions for put file.
Would there be compat issues with turning this on by default? It seems like you'd always rather use compression.
@@ -472,7 +472,7 @@ def ImportApplications(kernel, applications_path=application_directory): wind_turbine_application = KratosMultiScaleApplication() kernel.ImportApplication(MultiScaleApplication) print("KratosMultiScaleApplication sucessfully imported") - + if(Import_ContactStructura...
[No CFG could be retrieved]
Imports all the modules that are imported by the KratosDEM. Adds the KratosMappingApplication to the kernel.
this file should be removed overall. again as a part of a different Pr
@@ -1115,7 +1115,8 @@ class AppliedPTransform(object): for part in self.parts ], inputs={ - tag: context.pcollections.get_id(pc) + _may_be_preserve_tag(tag, pc, self.input_tags_to_preserve): + context.pcollections.get_id(pc) for tag, ...
[Pipeline->[_check_replacement->[ReplacementValidator],_remove_labels_recursively->[_remove_labels_recursively],from_runner_api->[Pipeline],replace_all->[_check_replacement,_replace],_replace->[TransformUpdater->[_replace_if_needed->[_remove_labels_recursively],visit_transform->[_replace_if_needed],enter_composite_tran...
Convert a sequence of BeamRunnerAPI objects to a BeamRunnerAPI object.
While we're here, did yapf not like this on the previous line? Maybe write `(tag, pc)` (unless it tries to split that too).
@@ -108,8 +108,6 @@ import re as _re import sys as _sys import textwrap as _textwrap -from llnl.util.tty.colify import colified - from gettext import gettext as _ try:
[_AttributeHolder->[_get_kwargs->[sorted]],_CountAction->[__call__->[_ensure_value]],_ActionsContainer->[_handle_conflict_resolve->[_remove_action],_check_conflict->[_get_handler],_add_container_actions->[add_mutually_exclusive_group,add_argument_group],add_argument->[_registry_get,_callable],_pop_action_class->[_regis...
The standard standardized version of the which is the standardized version of the parser A utility function to convert a single n - node object into a n - node object.
It looks like we had slightly modified the vendored copy of argparse. Is this still needed? In general, I'm not too keen on modifying vendored packages, as it makes it more difficult to upgrade.
@@ -67,7 +67,7 @@ type CloudProfileSpec struct { // An empty list means that all seeds of the same provider type are supported. // This is useful for environments that are of the same type (like openstack) but may have different "instances"/landscapes. // +optional - SeedSelector *metav1.LabelSelector `json:"seed...
[No CFG could be retrieved]
Additional information about the given allowed value in the Shoot specification.
fyi, changing the type is not backward compatible change
@@ -1613,3 +1613,17 @@ def _find_peaks(evoked, npeaks): if len(times) == 0: times = [evoked.times[gfp.argmax()]] return times + + +def _prepare_topomap(pos, ax): + """Helper for preparing the topomap.""" + pos_x = pos[:, 0] + pos_y = pos[:, 1] + + ax.set_xticks([]) + ax.set_yticks([]) ...
[plot_ica_components->[_make_image_mask,plot_ica_components,_check_outlines,_prepare_topo_plot,plot_topomap],_plot_topomap_multi_cbar->[plot_topomap],plot_evoked_topomap->[_make_image_mask,_prepare_topo_plot,plot_topomap,_check_outlines],plot_tfr_topomap->[_prepare_topo_plot,plot_topomap],plot_topomap->[_griddata,_show...
Helper function for finding peaks from evoked data Returns npeaks biggest peaks as a.
This error is a bit vague for the user. I think it would be better if you explicitly say that the problem occurred when plotting the legend for the spatial_colors
@@ -420,12 +420,15 @@ namespace System.Net.Security if (_lastFrame.HandshakeType == TlsHandshakeType.ClientHello) { // SNI if it exist. Even if we could not parse the hello, we can fall-back to default certificate. - _sslAuthentic...
[SslStream->[SendAuthResetSignal->[SetException],ConsumeBufferedBytes->[ReturnReadBufferIfEmpty],CopyDecryptedData->[ReturnReadBufferIfEmpty]]]
Receives a blob from the given TIOAdapter. Process the last handshake message.
Is the `!` needed here? You're accessing `_sslAuthenticationOptions` above in the `if`, so I'd think compiler would know it can't be null here.
@@ -10,13 +10,17 @@ import java.util.Map; import org.triplea.http.client.HttpClient; import org.triplea.http.client.HttpInteractionException; -import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; + +import lombok.AccessLevel; +import lombok.AllArgsConstructor; /**...
[ModeratorToolboxClient->[removeBadWord->[removeBadWord],getBadWords->[createHeaders,getBadWords],addBadWord->[createHeaders,addBadWord],validateApiKey->[validateApiKey],lookupModeratorEvents->[createHeaders,lookupModeratorEvents],newClient->[ModeratorToolboxClient]]]
Wrapper around moderator toolbox feign client. Creates a client for the object.
Updates here at to account for having a password now. This class is constructed with a password that is then used with any of the http endpoints. This class also knows how to pull the API key from client settings, with those two values any users of this class need not worry about key and password.
@@ -126,14 +126,13 @@ class SettingsDialog extends Component<Props> { */ function _mapStateToProps(state) { const configuredTabs = interfaceConfig.SETTINGS_SECTIONS || []; - const jwt = state['features/base/jwt']; // The settings sections to display. const showDeviceSettings = configuredTabs.incl...
[No CFG could be retrieved]
Creates a new instance of the ConnectedSettingsDialog component which maps the state of the component Menu for the devices that are selected in the system.
Food for thought: maybe we should drop the `SETTINGS_SECTIONS` thing altogether.
@@ -473,7 +473,9 @@ public class DeltaSync implements Serializable { boolean success = writeClient.commit(instantTime, writeStatusRDD, Option.of(checkpointCommitMetadata)); if (success) { LOG.info("Commit " + instantTime + " successful!"); - + if (this.props.getBoolean(ENABLE_KAFKA_COMMIT_...
[DeltaSync->[getHoodieClientConfig->[getHoodieClientConfig],registerAvroSchemas->[registerAvroSchemas],startCommit->[startCommit],syncMeta->[getSyncClassShortName],syncHive->[syncHive],syncOnce->[refreshTimeline],close->[close]]]
Writes the records to the sink. Schedule compaction if needed.
I am trying to see how we can move such source specific logic back to the source. Ideally `DeltaSync` should be agnostic of Kafka etc. Can we add an `onCommit()` or some callback on the Source?
@@ -172,9 +172,10 @@ public class FloatFirstAggregatorFactory extends AggregatorFactory } @Override - public Object finalizeComputation(Object object) + @Nullable + public Object finalizeComputation(@Nullable Object object) { - return ((SerializablePair<Long, Float>) object).rhs; + return object == ...
[FloatFirstAggregatorFactory->[getRequiredColumns->[FloatFirstAggregatorFactory],getCombiningFactory->[FloatFirstAggregatorFactory],equals->[equals]]]
Finalize the computation of a .
Double* variant of this class uses `object == null ? null` that is better
@@ -103,6 +103,7 @@ module ApplicationHelper end def smart_annotation_parser(text, team = nil) + team = nil unless team.is_a? Team new_text = smart_annotation_filter_resources(text) new_text = smart_annotation_filter_users(new_text, team) new_text
[display_tooltip->[truncate,length,sanitize_input,strip],sample_groups_page_my_module?->[nil?],smart_annotation_filter_resources->[base62_decode,project_path,id,canvas_experiment_path,experiment,project,module_archive_experiment_path,experiment_archive_project_path,archived?,sample_path,link_to,sanitize,protocols_my_mo...
This method is used to parse the text and return the first tag found.
Why is this needed? Are there any strange cases where ``team would actually not be `Team`?
@@ -1272,7 +1272,9 @@ def plot_evoked_joint(evoked, times="peaks", title='', picks=None, ts_ax.set_title('') if title is not None: title_ax = plt.subplot(4, 3, 2) - title = ', '.join([title, old_title]) if len(title) > 0 else old_title + if title == '': + title = ', '.join([t...
[plot_evoked_joint->[plot_evoked_joint,_connection_line,_plot_evoked],plot_evoked_image->[_plot_evoked],_handle_spatial_colors->[_plot_legend],_plot_lines->[_rgb],plot_compare_evokeds->[_truncate_yaxis,_ci,plot_compare_evokeds,_setup_styles],_plot_evoked_white->[whitened_gfp],plot_evoked->[_plot_evoked]]
Plot evoked data as butterfly plot and add topomaps for time points. This function returns a plot of a object. Plots a topomap of the lease channel. Plot a 2 - D map and a colorbar for the specified object.
`if len(title) > 0` would always be false `if title == ''`
@@ -46,6 +46,12 @@ class SuluContentExtension extends Extension implements PrependExtensionInterfac ], ], ], + 'resources' => [ + 'pages_seo' => [ + 'form' => ['@SuluContentBun...
[SuluContentExtension->[processSearch->[load],load->[load]]]
Adds a node configuration which can be used to configure a page. Adds a node configuration which can be found in the system.
That's also weird... But I if I change the resource name to `page_seo`, then the URL will also be `/admin/api/page_seo`, which is suboptimal...
@@ -141,6 +141,7 @@ public class RealtimePlumberSchoolTest new TimestampSpec("timestamp", "auto", null), new DimensionsSpec(null, null, null), null, + null, null ), null
[RealtimePlumberSchoolTest->[supplierFromRunnable->[run->[run]],testPersistWithCommitMetadata->[testPersist],testPersist->[testPersist]]]
Sets up the mock. This method is called by EasyMock to mock the realtime plumber.
WOW - I didn't realize we used so many constructors! Maybe one day, I'll get around to using mockito to make this refactoring less painful in the future.
@@ -263,7 +263,8 @@ def get_supported(versions=None, noarch=False, platform=None, if not noarch: arch = platform or get_platform() - if arch.startswith('macosx'): + arch_prefix, arch_sep, arch_suffix = arch.partition('_') + if arch_prefix == 'macosx': # support macosx-1...
[get_impl_tag->[get_impl_ver,get_abbr_impl],get_abi_tag->[get_impl_ver,get_flag,get_abbr_impl,get_config_var],get_impl_ver->[get_abbr_impl,get_config_var],get_platform->[get_platform,_is_running_32bit],get_darwin_arches->[_supports_arch->[_supports_arch],_supports_arch],get_supported->[get_abi_tag,get_platform,get_darw...
Return a list of supported tags for each version specified in versions. Return a list of all possible C - versions of the system.
I'm not sure how the `macosx` platform tags are actually structured, so it would be safer to keep the `startswith` for this case.
@@ -765,8 +765,6 @@ class RaidenAPI: self.raiden.chain, token_network_address, channel.identifier, - from_block=from_block, - to_block=to_block, )) returned_events.sort(key=lambda evt: evt.get('block_number'), reverse...
[RaidenAPI->[get_payment_history_for_token->[get_payment_history],get_channel_events_blockchain->[get_channel_list],get_channel_events_raiden->[_contains_partner_address],start_health_check_for->[start_health_check_for],get_payment_history_for_token_and_target->[get_payment_history_for_token]]]
Returns a list of channel events in the blockchain. Returns a list of blocks in raiden_events_ if any of the events are.
Hmmm by doing this, we no longer are able to query events by block range from the API. Why would we want to remove this functionality?
@@ -148,7 +148,7 @@ require('react-styl')(` height: 100%; width: 100%; vertical-align: middle; - padding: 3rem; + padding: 1rem; .pl-modal-content text-align: center position: relative;
[No CFG could be retrieved]
Set timeout for modal modal CSS properties for the modal cell.
Hmm I think this change could affect all the other Modals we have dotted around the dapp...
@@ -854,6 +854,12 @@ class Command(object): self._cache.remove_locks() self._user_io.out.info("Cache locks removed") return + elif args.system_reqs: + if not ref: + raise ConanException("Please specify a valid package reference to be cleaned") + ...
[Command->[export->[export],info->[info],install->[install],source->[source],remove->[remove,info],new->[new],imports->[imports],link->[link],upload->[upload],copy->[copy],download->[download],run->[_commands,_warn_python2,_show_help],export_pkg->[export_pkg],test->[test],inspect->[inspect],package->[package],_show_hel...
Removes packages or binaries matching pattern or reference from local cache or remote. Remove a single object from the cache.
that appears to be misleading, you're ignoring errors from shutil, but always output that system requirements have been removed. what if they have failed to remove? why not output error message in that case?
@@ -165,9 +165,8 @@ class AGP_Pruner(Pruner): if epoch > 0: self.now_epoch = epoch - for k in self.if_init_list.keys(): - self.if_init_list[k] = True - + for wrapper in self.get_modules_wrapper(): + wrapper.registered_buffers['if_calculated'].c...
[LotteryTicketPruner->[_calc_mask->[_calc_sparsity],prune_iteration_start->[_calc_mask]]]
Update epoch of the model.
which one is better? `wrapper.registered_buffers['if_calculated']` or `wrapper.if_calculated`
@@ -118,6 +118,17 @@ public class ByteBufUtilTest { }); } + @Test + public void testIndexOf() { + final ByteBuf haystack = Unpooled.copiedBuffer("abc123", CharsetUtil.UTF_8); + assertEquals(0, ByteBufUtil.indexOf(Unpooled.copiedBuffer("a", Charsets.UTF_8), haystack)); + assert...
[ByteBufUtilTest->[buffer->[buffer],testWriteUtf8Composite->[buffer],notEqualsBufferSubsections->[random],testWriteUsAsciiWrapped->[buffer],testWriteUtf8CompositeWrapped->[buffer],setShortBE->[setShortBE],testWriteUsAsciiString->[buffer],testGetBytesHeapWithArrayLengthGreaterThanCapacity->[buffer],writeShortBE->[writeS...
Test if the hex dump of a buffer equals another.
Remove the `Charsets` import and use `CharsetUtil` everywhere instead.
@@ -0,0 +1,13 @@ +<%# Weird hack due to the fact that embedded links have Widget in between. +Starting from https:// we end at 24 characters at dotnetfiddle.net %> + +<iframe + src="<%= link.insert(24, "/Widget").to_s %>" + width="100%" + height="<%= height %>" + scrolling="no" + frameborder="no" + allowfullscree...
[No CFG could be retrieved]
No Summary Found.
can we keep this "hack" in the liquit tag ruby file? We should also test it :D Is there a chance the number of chars will change?
@@ -59,7 +59,7 @@ Hello, world. </body> </html>`, - signature: `ACWMjZEuSyBBmRGq7lNxah7UKttklVXU3uaSJTQA35+IX3d65H8HjWAoVGeetJYt3Y0nX28n24tB2kkIhrg4AZJJIykEm6sGCa/Pkuo0PfoIrqItkoitBLsWeNo2AGuzUKW0hrZ00olZgnHrjklz449Xp3aBmtDcNIzzVxuBl0hnAWzIrceo4JBo3j5V/MAjmxuZ7gIVKStL0WZdGFePlEE0hz4ePU0KLtJpv35u1iLHmmnQq0ssYf/O0Uo...
[No CFG could be retrieved]
Renders a sequence number. A list of all possible keys that can be used to generate a unique key.
Why did this change?
@@ -303,6 +303,17 @@ class OrderFulfill(BaseMutation): errors = prepare_insufficient_stock_order_validation_errors(exc) raise ValidationError({"stocks": errors}) + if approved: + gift_cards_create( + order, + gift_card_lines, + q...
[FulfillmentUpdateTracking->[Arguments->[FulfillmentUpdateTrackingInput],perform_mutation->[FulfillmentUpdateTracking]],FulfillmentRefundAndReturnProductBase->[clean_fulfillment_lines->[_raise_error_for_line],clean_lines->[_raise_error_for_line]],FulfillmentReturnProducts->[perform_mutation->[clean_input],Arguments->[O...
Perform a single order - level mutation.
What do you think about moving this to saleor/order/actions.py file. There is a method `saleor.order.actions.order_fulfilled` Which is triggered by this mutation. It contains actions like this one so I would consider moving this action there.
@@ -392,9 +392,9 @@ namespace Microsoft.Xna.Framework /// <returns>The squared distance between two vectors.</returns> public static float DistanceSquared(Vector3 value1, Vector3 value2) { - float result; - DistanceSquared(ref value1, ref value2, out result); - ...
[Vector3->[Max->[Max],Length->[DistanceSquared],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Transform->[Length],Hermite->[Hermite],DistanceSquared->[DistanceSquared],Lerp->[Lerp],Barycentric->[Barycentric],Clamp->[Clamp],TransformNormal->[Length],Normalize->[Distance,Normalize],Min->[Min],ToString->[ToString],Len...
DistanceSquared for Vector3 values.
We need a unit test for this as there isn't one and we need to be sure this didn't break anything.
@@ -36,6 +36,7 @@ import java.util.List; public class ScanResultValueTimestampComparatorTest { + @SuppressWarnings("SSBasedInspection") // static field(s) cannot be final because set in an initializer block private static QuerySegmentSpec intervalSpec; @BeforeClass
[ScanResultValueTimestampComparatorTest->[testComparisonDescendingList->[singletonList,ScanResultValue,build,compare,Long,put,add,assertEquals,ScanResultValueTimestampComparator],testAscendingCompactedList->[singletonList,ScanResultValue,build,compare,Long,add,assertEquals,ScanResultValueTimestampComparator],testCompar...
Setup the interval spec.
setup() can be inlined
@@ -149,6 +149,10 @@ public class ArbitraryGranularitySpec implements GranularitySpec if (!rollup.equals(that.rollup)) { return false; } + if (!timezone.equals(that.timezone)) { + return false; + } + return !(queryGranularity != null ? !queryGranularity.equals(that.queryGr...
[ArbitraryGranularitySpec->[hashCode->[hashCode],equals->[equals]]]
Checks if this object is equal to the given object.
This will have some issues if `timezone` is null.
@@ -37,7 +37,7 @@ final class AwsSdkClientTracer extends HttpClientTracer<Request<?>, Request<?>, private final boolean captureExperimentalSpanAttributes; AwsSdkClientTracer(OpenTelemetry openTelemetry, boolean captureExperimentalSpanAttributes) { - super(openTelemetry); + super(openTelemetry, new NetPeer...
[AwsSdkClientTracer->[inject->[inject],startSpan->[startSpan],onResponse->[onResponse]]]
Injects the AwsXrayServlet into the given request.
@anuraaga should it be possible to configure `peer.service` mappings for AWS SDKs?
@@ -19,9 +19,13 @@ int const INVALID_ENUM_VALUE = 999; DDS::DomainParticipantQos Marked_Default_Qos::marked_default_DomainParticipantQos() { - DDS::DomainParticipantQos qos; - DDS::DomainParticipantFactory_var factory = TheParticipantFactory; - factory->get_default_participant_qos(qos); + DDS::DomainParticipantQ...
[No CFG could be retrieved]
Protected from interface ServiceParticipant The method to get the QoS for the specified object.
The "marked" value needs to be a value that's not possible for a user to select. For DomainParticipant that would have to be autoenable_ created_entities not being true or false (i.e. treating the bool as a char).
@@ -445,9 +445,9 @@ class State: # pylint: disable=too-many-instance-attributes self._execute(f"SELECT * FROM {self.LINK_STATE_TABLE}") for row in self.cursor: - relpath, inode, mtime = row + relative_path, inode, mtime = row inode = self._from_sqlite(inode) - ...
[State->[_vacuum->[_execute],load->[_prepare_db],get_unused_links->[_from_sqlite,_execute],get_state_record_for_inode->[_execute,_fetchall,_to_sqlite],_prepare_db->[_execute,_fetchall,StateVersionTooNewError],remove_links->[_execute],_update_state_for_path_changed->[_execute,_to_sqlite],__init__->[get],_update_state_re...
Removes all saved links except the ones that are used.
Redefined with `relpath` from `dvc.utils`.
@@ -413,7 +413,8 @@ public final class OmKeyInfo extends WithObjectID { .addAllMetadata(KeyValueUtil.toProtobuf(metadata)) .addAllAcls(OzoneAclUtil.toProtobuf(acls)) .setObjectID(objectID) - .setUpdateID(updateID); + .setUpdateID(updateID) + .setParentID(parentObjectID); ...
[OmKeyInfo->[removeAcl->[removeAcl],Builder->[build->[OmKeyInfo]],copyObject->[addOmKeyLocationInfoGroup,addMetadata,getType,build,setUpdateID,addAcl],getProtobuf->[setFileEncryptionInfo,build,setUpdateID,getProtobuf],getFromProtobuf->[setObjectID,getFromProtobuf,build,setAcls,setUpdateID],equals->[equals],appendNewBlo...
Gets the protobuf of this key.
Why not add setFileName here?
@@ -346,6 +346,12 @@ func documentedFieldCheck(foundKeys common.MapStr, knownKeys map[string]interfac found = true break } + // should cover scenarios as azure.compute_vm_scaleset.*.* + key = strings.Join(splits[0:pos], ".") + ".*.*" + if _, ok := knownKeys[key]; ok { + found = true + ...
[Dir,LoadFields,Hash,HandlerFunc,Close,MarshalIndent,Delete,Encode,Set,WriteFile,Put,Error,ReadFile,Errorf,HasSuffix,SliceStable,Join,Failed,GetKeys,Contains,Fatalf,Base,Split,Trim,Query,Header,Write,NewServer,GetFields,Unmarshal,Flatten,Glob,String,Fatal,Run,WriteHeader,Helper,FailNow]
The following functions are used to check if a field is missing in the data. omitDocumentedField returns true if the field is present in the omitField.
this should not be done in all values of `pos`, `.*.*` should only replace the last 2 splits. I think this code can go outside this loop
@@ -256,6 +256,15 @@ public interface AllureConstants { } + interface VMFeature { + + String VM_EXTENSION = "VM Extension"; + + interface VMStory { + } + + } + interface IntegrationTestsFeature { String INTEGRATIONS_TESTS = "Integration Tests";
[No CFG could be retrieved]
Feature names for all features and states. Enumerate all the non - terminal elements of a sequence.
why here instead of in the VM extension?
@@ -33,10 +33,11 @@ public class FilterTest extends FunctionalTestCase LocalMuleClient client = muleContext.getClient(); MuleMessage result; -// = client.send("http://localhost:9002/bar/foo", "test", null); -// assertEquals("test test", result.getPayloadAsString()); + // ...
[FilterTest->[testUnAcceptFilter->[send,Integer,getClient,getInboundProperty,assertEquals,put],testAcceptFilter->[getClient,assertEquals,send,getPayloadAsString]]]
test accept filter.
Looks like every test is going to use something like "new DefaultMuleMessage("test", muleContext)". Can you create a method for it in AbstractMuleContextTestCase?
@@ -346,6 +346,10 @@ const EXPERIMENTS = [ name: 'Enables scroll snap on carousel on Chrome browsers', cleanupIssue: 'https://github.com/ampproject/amphtml/issues/16508', }, + { + id: 'amp-viewer-assistance-untrusted', + name: 'Enable amp-viewer-assistance in untrusted viewers', + }, { id: ...
[No CFG could be retrieved]
A list of all AMP configuration options that can be applied to a context. A list of all AMP - related components that can be enabled in AMP.
Can we remove this? It's a bit confusing for a local-testing trigger to be listed with other experiments. Or do you need this for local testing on device?
@@ -536,7 +536,8 @@ class FnApiRunner(runner.PipelineRunner): runner_execution_context, bundle_context_manager, data_input, - data_output, + data_output, {}, + expected_timer_output, cache_token_generator=cache_token_generator) bundle_manager = ParallelBun...
[FnApiRunner->[get_cache_token_generator->[DynamicGenerator->[__next__->[generate_token]],StaticGenerator->[__init__->[generate_token]],DynamicGenerator,StaticGenerator],_run_stage->[_add_residuals_and_channel_splits_to_deferred_inputs,_run_bundle_multiple_times_for_testing,_store_side_inputs_in_state,_collect_written_...
Runs an individual stage of the bundle. Merge results of a single we . Get the result of a .
Put {} on its own line. (Surprised yapf didn't complain, or maybe you haven't run it yet.)