patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -54,10 +54,13 @@ func unpackChainLink(link *SCChainLink) (*chainLinkUnpacked, error) {
inner: inner,
innerLinkID: innerLinkID,
}
-
return ret, nil
}
+func (l *chainLinkUnpacked) TeamID() (keybase1.TeamID, error) {
+ return l.inner.TeamID()
+}
+
func (l *chainLinkUnpacked) Seqno() keybase1.Seqno {... | [LinkID->[LinkID],SignatureMetadata->[SignatureMetadata,SigChainLocation],SigChainLocation->[SigChainLocation]] | Seqno implements the Link interface for chainLinkUnpacked. | I'm worried someone's going to call this and not realize it only exists if not stubbed. |
@@ -558,7 +558,7 @@ const EVP_PKEY_ASN1_METHOD dh_asn1_meth = {
0,
int_dh_free,
- 0,
+ dh_pkey_ctrl,
0, 0, 0, 0, 0,
| [DHparams_print->[do_dh_print],int->[EVP_CIPHER_CTX_type,ASN1_STRING_length,i2d_X509_ALGOR,EVP_CIPHER_type,BN_cmp,DH_security_bits,BIO_puts,DH_size,ASN1_STRING_get0_data,EVP_PKEY_CTX_set_dh_kdf_md,BN_to_ASN1_INTEGER,EVP_PKEY_derive_set_peer,EVP_CIPHER_param_to_asn1,BN_dup,BN_get_flags,i2d_DHparams,BN_num_bits,EVP_PKEY_... | - 1 - if arg1 == 1 - if arg2 == 0 - if arg1 Set a peer key. | This doesn't seem right to me. Probably this should be a different ctrl function than the one used for the X9.42 method. The set of ctrls between the X9.42 and PKCS3 DH methods are mutually exclusive so it doesn't seem appropriate to have a single ctrl function for both. |
@@ -126,8 +126,10 @@ function _setConfig(state, { config }) {
const newState = _.merge(
{},
- config,
- { error: undefined },
+ config, {
+ error: undefined,
+ locationURL: state.locationURL
+ },
// The config of _getInitialState() is meant to... | [No CFG could be retrieved] | Construct a new state of the feature base and the new config after the specified reduction of the Translates a legacy object to the new one. | The location URL was introduced there to be able to report errors to the external API. Now, with sessions, I guess it's possible we don't need it in the store? Or, alternatively, we could store the config in a `config` attribute to make it easy to add metadata around it. |
@@ -113,7 +113,9 @@ func (fb *fwdBackend) Del(conf *FirewallNetConf) error {
// Remove firewalld rules which assigned the given source IP to the given zone
firewalldObj := fb.conn.Object(firewalldName, firewalldPath)
var res string
- firewalldObj.Call(firewalldZoneInterface+"."+firewalldRemoveSourceMethod, 0,... | [Add->[Object,Store,Error,Contains,Errorf,Call],Del->[Object,Call,Store],Object,SystemBus,Store,Call] | Del removes all firewalld rules which are assigned to the given source IP to the given zone. | I am not familiar with those parts of the code but firewall sounds security relevant. To be sure: really not return the error? |
@@ -3,5 +3,7 @@
// See the LICENSE file in the project root for more information.
using Xunit;
+using Microsoft.DotNet.XUnitExtensions.Attributes;
[assembly: SkipOnCoreClr("System.Net.Tests are flaky and/or long running: https://github.com/dotnet/runtime/issues/131")]
+[assembly: SkipOnMono("System.Net.Tests are... | [No CFG could be retrieved] | Copyright 2015 the C ++ License. | These attributes are only about stress modes, right? What stress are we running on mono in ci? (I still think the attributes need to either be renamed or changed to mean what they say.) cc: @safern |
@@ -140,9 +140,9 @@ class NioBuffer extends AdaptableBuffer<NioBuffer> implements ReadableComponent,
@Override
public Buffer copy(int offset, int length) {
+ checkLength(length);
checkGet(offset, length);
- int allocSize = Math.max(length, 1); // Allocators don't support allocating ze... | [NioBuffer->[writableBuffer->[writerOffset],getUnsignedInt->[getInt],getLong->[getLong],outOfBounds->[capacity],getInt->[getInt],readUnsignedInt->[getInt],openReverseCursor->[capacity],getDouble->[getDouble],getChar->[getChar],copy->[writerOffset,NioBuffer],capacity->[capacity],getUnsignedShort->[getShort],newConstChil... | Copy a buffer from the current buffer to the given offset and length. | Is this not needed anymore? |
@@ -224,7 +224,7 @@ public class MyViewsProperty extends UserProperty implements ModifiableViewGroup
public List<Action> getViewActions() {
// Jenkins.getInstance().getViewActions() are tempting but they are in a wrong scope
- return Collections.emptyList();
+ return Collections.singletonL... | [MyViewsProperty->[getStaplerFallback->[getPrimaryView],doCreateView->[addView],getACL->[getACL],getViews->[getViews],getMyViewsTabBar->[getMyViewsTabBar],addView->[addView],getView->[getView],getUrl->[getUrl],save->[save],doViewExistsCheck->[getView],getViewsTabBar->[getViewsTabBar],DescriptorImpl->[newInstance->[MyVi... | Returns the view actions. | Does it work in such way? I see no routing logic to `ModifiableViewGroup#addView` |
@@ -68,7 +68,12 @@ public class NettyTransport implements Transport {
// Need to initialize these in constructor since they require configuration
masterGroup = buildEventLoop(1, new DefaultThreadFactory(threadNamePrefix + "-ServerMaster"));
- ioGroup = buildEventLoop(configuration.ioThreads(), new ... | [NettyTransport->[getTotalBytesRead->[getTotalBytesRead],getNumberOfLocalConnections->[getNumberOfLocalConnections],getPort->[getPort],getTotalBytesWritten->[getTotalBytesWritten],getHostName->[getHostName],getNumberOfGlobalConnections->[getNumberOfGlobalConnections]]] | Creates a NettyTransport component which manages read and write operations to and from the server. | is it possible for the cache manager to be `null`? |
@@ -211,6 +211,18 @@ class Model(torch.nn.Module, Registrable):
else:
return -1
+ def _maybe_warn_for_unseparable_batches(self):
+ """
+ This method warns once if a user implements a model which returns a dictionary with
+ values which we are unable to split back up into ... | [Model->[_load->[from_params]],remove_pretrained_embedding_params->[remove_pretrained_embedding_params]] | Returns the cuda device this model should run on for predictions. | Maybe have this take the key as an argument, and log that? Seems like you will _always_ see this for `loss`, right? You might even just never warn for `loss`. |
@@ -319,6 +319,10 @@ public class ProductsController {
s.getStatus(),
s.getChannels().stream().map(c ->
new ChannelJson(
+ ... | [ProductsController->[synchronizeSubscriptions->[ContentSyncManager,getMessage,tryGetLock,fatal,json,unlockFile,updateSubscriptions],synchronizeChannelFamilies->[IllegalArgumentException,ContentSyncManager,getMessage,tryGetLock,fatal,updateChannelFamilies,json,hasRole,unlockFile,readChannelFamilies],synchronizeProducts... | This method returns the data for the given user. This method returns a product object with all base products of the current product. | I think this is too expensive and there is a better way to get the ID. Check line 300: there is a map "channelByLabel" of all Channels. Please use that map to get the Channel and the ID. |
@@ -239,4 +239,16 @@ public class WorkerCuratorCoordinator
}
}
}
+
+ public void updateWorkerAnnouncement(Worker newWorker) throws Exception
+ {
+ synchronized (lock) {
+ if (!started) {
+ log.error("Cannot update worker! Not Started!");
+ return;
+ }
+
+ announcer.updat... | [WorkerCuratorCoordinator->[unannounceTask->[getTaskPathForId],getStatusPathForId->[getPath],stop->[stop],updateAnnouncement->[announceTastAnnouncement,getStatusPathForId],start->[start],announceTastAnnouncement->[getStatusPathForId],getTaskPathForId->[getPath]]] | Updates an announcement in the task tracker. | I think this should throw an exception, otherwise people may think they succeeded in disabling a worker when they in fact did not. |
@@ -23,12 +23,11 @@ import java.util.Map;
import org.apache.hudi.common.util.StringUtils;
public class ConfigUtils {
-
- public static final String SPARK_QUERY_TYPE_KEY = "spark.query.type.key";
-
- public static final String SPARK_QUERY_AS_RO_KEY = "spark.query.as.ro.key";
-
- public static final String SPARK_Q... | [ConfigUtils->[configToString->[getValue,append,toString,StringBuilder,length,entrySet],toMap->[IllegalArgumentException,trim,split,isNullOrEmpty,put]]] | This method returns a map of the given key - value config as a map of the given key = value. | What's the relationship between this key `IS_QUERY_AS_RO_TABLE` and `SPARK_QUERY_AS_RO_KEY ` and `SPARK_QUERY_AS_RT_KEY `. |
@@ -385,9 +385,12 @@ namespace ProtoAssociative
string symbol1 = firstNode.updateNodeRefList[0].nodeList[0].symbol.name;
string symbol2 = lastNode.updateNodeRefList[0].nodeList[0].symbol.name;
- string message = String.Format(ProtoCore.Properties.Resources.kInvalidStat... | [CodeGen->[EmitDependency->[SetEntry,EmitJumpDependency],GetFirstSymbolFromIdentList->[GetFirstSymbolFromIdentList],DFSEmitSSA_AST->[EmitSSALHS,DFSEmitSSA_AST,SSAIdentList,GetReplicationGuides,EmitSSAArrayIndex],CyclicDependencyTest->[StrongConnectComponent],DfsSSAIeentList->[DfsSSAIeentList],EmitGetterSetterForIdentLi... | CyclicDependencyTest - Test if a static dependency is cyclic. | Are you adding this `foreach` loop to show the warning on all nodes involved in the cyclic dependency? |
@@ -266,6 +266,8 @@ class UserMerger
update_user_id(:draft_sequences, conditions: "x.draft_key = y.draft_key")
update_user_id(:drafts, conditions: "x.draft_key = y.draft_key")
+ update_user_id(:dismissed_topic_users, conditions: "x.topic_id = y.topic_id")
+
EmailLog.where(user_id: @source_user.id).u... | [UserMerger->[update_username->[update_username]]] | Updates all user_ids that are related to the current user. Updates all records in database that are related to the target user. Updates all records in database that are related to the given user. Updates all user - related records in database. | Another bug, merging users should move dismissed_topic_users rows |
@@ -199,13 +199,13 @@ public class FileSystemRepository implements ContentRepository {
for (final Map.Entry<String, Path> container : containers.entrySet()) {
final String containerName = container.getKey();
- final long capacity = Files.getFileStore(container.getValue()).... | [FileSystemRepository->[destroyExpiredArchives->[visitFile->[size,toString,getLastModTime],compare->[compare,getLastModTime],size,remove,getLastModTime,toString,deleteBasedOnTimestamp,getContainerUsableSpace],ArchiveInfo->[toString],write->[close->[close,remove],flush->[flush],write],remove->[getPath,remove],getLastMod... | Replies the maximum threshold for the containers. Initialize FileSystemRepository with alwaysSync set to true. | If there is a problem, FileStore.getTotalSpace() throws IOException but File.getTotalSpace() returns 0. I think you should throw an IOException if capacity == 0, in order to maintain similar behavior here. |
@@ -16,8 +16,12 @@ class CollectionNotFoundException extends MediaException
/**
* @param string $id
*/
- public function __construct($id)
+ public function __construct($id, \Throwable $previous = null)
{
- parent::__construct('Collection with the ID ' . $id . ' was not found', self::E... | [No CFG could be retrieved] | Initialize the object with the given ID. | its also okay for me to just update the baseline for such errors in the future |
@@ -613,9 +613,12 @@ class RunNamespacedJob(Task):
- kubernetes_api_key_secret (str, optional): the name of the Prefect Secret
which stored your Kubernetes API Key; this Secret must be a string and in
BearerToken format
- - job_status_pool_interval (int, optional): The interval... | [ReadNamespacedJob->[__init__->[super],run->[read_namespaced_job,cast,ValueError,get_kubernetes_client],defaults_from_attrs],ListNamespacedJob->[__init__->[super],run->[list_namespaced_job,cast,get_kubernetes_client],defaults_from_attrs],PatchNamespacedJob->[__init__->[super],run->[patch_namespaced_job,cast,ValueError,... | Creates a new instance of the class. Set the object properties from the given object. | Just noticed the typo here (should be `job_status_poll_interval`). |
@@ -189,7 +189,7 @@ export class MultisigHDWallet extends AbstractHDElectrumWallet {
} else {
// mnemonics. lets derive fingerprint (if it wasnt provided)
if (!bip39.validateMnemonic(key)) throw new Error('Not a valid mnemonic phrase');
- fingerprint = fingerprint || MultisigHDWallet.seedToFinge... | [No CFG could be retrieved] | Construct a key object from a string. Convert a multisig xprv to a regular xpub. | MultisigHDWallet is a direct descendant of AbstractHDElectrumWallet, looks like this change is not necessary, static method should be visible (not 100% sure) |
@@ -862,8 +862,9 @@ public class Scanner {
else {goto case 0;}
case 37:
recEnd = pos; recKind = 4;
- if (ch <= '!' || ch >= '#' && ch <= '[' || ch >= ']' && ch <= 65535) {AddCh(); goto case 7;}
- else if (ch == '"') {AddCh(); goto case 8;}
+ if (ch <= '!' || ch >= '#' && ch != ';' && ch <= '[' ||... | [Scanner->[SetScannerBehindT->[NextCh],AddCh->[NextCh],NextCh->[Read,Peek],Token->[CheckLiteral,AddCh,NextCh],Read],UTF8Buffer->[Read->[Read]],Buffer->[GetString->[Read],Close->[Close],Peek->[Read],ReadNextStreamChunk->[Read],Read]] | Returns the next token in the string. Returns true if the character is a valid character or a character is a valid character. Returns true if the given character is a valid character or a character is a valid character and Returns true if the character is a valid character or if it is a valid character. | Do you modify scanner.cs directly? |
@@ -50,6 +50,17 @@ class Photo
$existing_photo = DBA::selectFirst('photo', ['id'], ['resource-id' => $rid, 'uid' => $uid, 'contact-id' => $cid, 'scale' => $scale]);
+ // Get defined storage backend.
+ // if no storage backend, we use old "data" column in photo table.
+ $data = "";
+ $backend_ref = "";
+ $ba... | [Photo->[store->[getWidth,getType,getHeight,asString],importProfilePhoto->[getBasePath,isValid,getExt,scaleDown,scaleToSquare]]] | Store an image in the database. insert a new photo in the database. | Code standards: Please wrap operators with spaces. |
@@ -454,9 +454,10 @@ public class MqttAdapterTests {
fail("Expected InvocationTargetException");
}
catch (InvocationTargetException e) {
+ e.printStackTrace();
assertThat(e.getCause()).isInstanceOf(MqttException.class);
assertThat(((MqttException) e.getCause()).getReasonCode())
- .isEqualTo((int... | [MqttAdapterTests->[testStopActionNever->[start,mock,buildAdapterIn,stop,verifyNotUnsubscribe],verifyUnsubscribe->[any,unsubscribe,connect,anyLong,disconnectForcibly,subscribe],testOutboundOptionsApplied->[any,setKeepAliveInterval,mock,setBeanFactory,start,DefaultMqttPahoClientFactory,anyString,publish,handleMessage,af... | This test is used to test if a subscription fails. This test method creates a mock adapter which can be used to connect and subscribe to a channel This test method creates a new client instance. | I think this one has to go... |
@@ -86,11 +86,11 @@ public class SparkRuntimeContext implements Serializable {
final Accumulator<NamedAggregators> accum = AccumulatorSingleton.getInstance(jsc);
final NamedAggregators initialValue = accum.value();
- if (opts.getEnableSparkSinks()) {
+ if (opts.getEnableSparkMetricSinks()) {
fi... | [SparkRuntimeContext->[getAggregatorValues->[getAggregatorValue],getPipelineOptions->[deserializePipelineOptions],SparkAggregator->[getCombineFn->[getCombineFn]]]] | Register metrics for the pipeline. | Maybe the previous implementation is more fitting now ? generally, we do allow context reuse. |
@@ -244,14 +244,14 @@ def unzip(filename, destination=".", keep_permissions=False):
if hasattr(sys.stdout, "isatty") and sys.stdout.isatty():
def print_progress(extracted_size, uncompress_size):
txt_msg = "Unzipping %.0f %%\r" % (extracted_size * 100.0 / uncompress_size)
- print(tx... | [chdir->[chdir],unzip->[human_size,print_progress],patch->[PatchLogHandler->[__init__->[__init__]],PatchLogHandler],cpu_count->[cpu_count],download->[download],check_sha1->[check_with_algorithm_sum],check_md5->[check_with_algorithm_sum],get->[unzip],run_in_windows_bash->[escape_windows_cmd,unix_path],cross_building->[g... | Unzip a file and extract it into a folder. This function extracts the file from the zip and stores it in the full_path. | Maybe the \r is redundant with the ``rewrite_line`` |
@@ -370,9 +370,6 @@ class TableServiceClient(TableServiceClientBase):
self.url,
table_name=table_name,
credential=self.credential,
- key_resolver_function=self.key_resolver_function,
- require_encryption=self.require_encryption,
- key_encryption_ke... | [TableServiceClient->[create_table_if_not_exists->[create_table],delete_table->[delete_table],create_table->[create_table]]] | Get a table client to interact with the specified table. | Discussed this out of band a few days ago, are we using the `_pipeline` we build a few lines before this. |
@@ -528,14 +528,14 @@ class Yoast_Form {
$var_esc = esc_attr( $var );
echo '<div class="switch-container">';
- echo '<fieldset id="', $var_esc, '" class="fieldset-switch-toggle" ><legend>', $label, '</legend>
- <div class="switch-toggle switch-candy switch-yoast-seo">';
+ echo '<fieldset id="', $var_esc, '" c... | [Yoast_Form->[checkbox->[label],textinput->[label],admin_footer->[get_option],textarea->[label],radio->[label],media_input->[label],file_upload->[label,hidden],select->[label]]] | Toggle switch on or off. | It's no problem to convert the `.` to `,` when you are changing things on this line :) |
@@ -13792,10 +13792,10 @@ Lowerer::GenerateBailOut(IR::Instr * instr, IR::BranchInstr * branchInstr, IR::L
return collectRuntimeStatsLabel ? collectRuntimeStatsLabel : bailOutLabel;
}
- // The bailout hasn't be generated yet.
+ // The bailout hasn't been generated yet.
Assert(!bailOutInstr->I... | [No CFG could be retrieved] | Generates an object - type - specific instruction that can be used to determine if an object is - - - - - - - - - - - - - - - - - -. | Introduced a typo here :) |
@@ -157,8 +157,7 @@ class InfoDialog extends Component {
const { defaultCountry, numbers } = nextProps.dialIn;
this.setState({
- phoneNumber:
- this._getDefaultPhoneNumber(numbers, defaultCountry)
+ phoneNumber: _getDefaultPhoneNumber(numbers,... | [No CFG could be retrieved] | Provides a reference to the DOM element backing the text area. Doppeline d un nova. | Maybe phoneNumber should now be passed in as a prop instead. |
@@ -454,12 +454,3 @@ ExceptionSink.reset_interactive_output_stream(sys.stderr.buffer)
# Setup a default signal handler.
ExceptionSink.reset_signal_handler(SignalHandler(pantsd_instance=False))
-
-# Set whether to print stacktraces on exceptions or signals during import time.
-# NB: This will be overridden by bootst... | [ExceptionSink->[ignoring_sigint->[_toggle_ignoring_sigint],log_exception->[_log_exception,_format_unhandled_exception_log],_handle_signal_gracefully->[_log_exception,_format_traceback],trapped_signals->[reset_signal_handler],_format_exception_message->[_iso_timestamp_for_now],reset_log_location->[ExceptionSinkError],_... | Setup a default signal handler and optionally print the stack trace on exceptions or signals. | If I understand correctly, do we *always* print the stacktrace if we receive an exception at import time? Or (just to make sure) does this turn *off* stacktraces for errors at import time? |
@@ -606,7 +606,7 @@ namespace System.Runtime.InteropServices
fixed (Guid* pIID = &iid)
fixed (IntPtr* p = &ppv)
{
- return ((delegate * stdcall <IntPtr, Guid*, IntPtr*, int>)(*(*(void***)pUnk + 0 /* IUnknown.QueryInterface slot */)))(pUnk, pIID, p);
+ ... | [No CFG could be retrieved] | region IUnknown interface implementation GetNativeVariantForObject - Get native variant for object. | Unrelated to this PR, and purely style, but should we standardize on `delegate*` instead of `delegate *`? The latter looks much more like multiplication, and the former is generally what we use for other pointers. |
@@ -15,10 +15,6 @@ class IdentityLinker
identity
end
- def already_linked?
- identity_relation.exists?
- end
-
private
def process_ial(extra_attrs)
| [IdentityLinker->[link_identity->[link_identity]]] | Link the identity with this AgencyIdentityLinker. | This wasn't used anywhere -- rather than figure out how it should handle soft-deletes (where the row exists, but the thing "isn't there") I just deleted it. |
@@ -269,8 +269,14 @@ public abstract class AbstractTcpTransport extends NettyTransport {
try {
final SelfSignedCertificate ssc = new SelfSignedCertificate(configuration.getString(CK_BIND_ADDRESS) + ":" + configuration.getString(CK_PORT));
certFile = ssc.certificate();
- ... | [AbstractTcpTransport->[launch->[getBootstrap],Config->[getRequestedConfiguration->[getRequestedConfiguration]]]] | Returns a callable that can be used to handle the SSL handshake. | It would be nice if we could replace the existing unencrypted key file. Leaving the old unencrypted file in the temp directory provides no security benefit |
@@ -46,7 +46,7 @@ const error = function(msg, trace) {
if (trace) {
console.log(trace);
}
- process.exit(1);
+ return; // eslint-disable-line
};
const init = function(program) {
| [No CFG could be retrieved] | Displays a single . The toString function is used to convert any object into a string. | @jamesgeorge007 I don't get the point of this, how is the process killed on error now? this was to ensure we don't have any handing process/subprocess |
@@ -612,13 +612,12 @@ class CI_Input {
* from trying to exploit keys we make sure that keys are
* only named with alpha-numeric text and a few other items.
*
- * @access private
* @param string
* @return string
*/
private function _clean_input_keys($str)
{
- if ( ! preg_match("/^[a-z0-9:_\/-]+$/i", $st... | [CI_Input->[server->[_fetch_from_array],get_request_header->[request_headers],cookie->[_fetch_from_array],is_ajax_request->[server],ip_address->[server],get_post->[post,get],get->[_fetch_from_array],post->[_fetch_from_array],request_headers->[_fetch_from_array],_clean_input_data->[_clean_input_data]]] | Clean input keys. | This should probably be changed to `protected`. |
@@ -291,10 +291,10 @@ public class PhysicalPlanBuilderTest {
assertThat(lines.length, equalTo(4));
assertThat(lines[0], equalTo(" > [ SINK ] | Schema: [ROWKEY STRING KEY, COL0 BIGINT, COL1 STRING, COL2 "
+ "DOUBLE] | Logger: InsertQuery_1.S1"));
- assertThat(lines[1],
- equalTo("\t\t > [ RE... | [PhysicalPlanBuilderTest->[shouldMakeBareQuery->[buildTransientQuery],shouldMakePersistentQuery->[buildQuery],shouldBuildTransientQueryWithCorrectSchema->[buildTransientQuery],shouldHaveKStreamDataSource->[buildQuery],executeQuery->[executeQuery],execute->[execute],shouldBuildPersistentQueryWithCorrectSchema->[buildQue... | Checks if partition by does not match result key. | Why is the schema now prefixed? |
@@ -219,9 +219,13 @@ class Products extends DolibarrApi
$i = 0;
while ($i < $min) {
$obj = $this->db->fetch_object($result);
- $product_static = new Product($this->db);
- if ($product_static->fetch($obj->rowid)) {
- $obj_ret[] = $this->_cleanObjectDatas($product_static);
+ if (!$ids_only) {
+ ... | [Products->[deleteAttributeValueByRef->[delete],deleteVariant->[delete],deleteAttributes->[delete],deleteAttributeValueById->[delete],put->[get],delete->[delete],_fetch->[_cleanObjectDatas]]] | Returns an array of objects with the ids of all products of given category and services Retrieve a list of product objects. | @c3do is it $obj->rowid instead only $obj ? |
@@ -169,9 +169,11 @@ class DraftComment(ModelBase):
This is being used by the commenting API by the code-manager.
"""
id = PositiveAutoField(primary_key=True)
- comments = models.TextField()
version = models.ForeignKey(Version, on_delete=models.CASCADE)
user = models.ForeignKey(UserProfile, ... | [ActivityLog->[to_string->[f],create->[ActivityLog,create],__str__->[to_string],SafeFormatter,ActivityLogManager],ActivityLogToken->[is_valid->[is_expired]],ActivityLogManager->[current_month_user_approve_reviews->[user_approve_reviews],monthly_reviews_user_position->[user_position,monthly_reviews],total_ratings_user_p... | Creates a model that allows us to index the activity log by user and access group. Returns a queryset of activity log entries filtered by group log values. | Will the form raise an exception if the filename does not exist in the version entries? It should, if possible. |
@@ -96,7 +96,14 @@ public class MuleProcessController
this.controller.deployDomain(domain);
}
+ public File getLog()
+ {
+ return this.controller.getLog();
+ }
-
+ public File getLog(String appName)
+ {
+ return this.controller.getLog(appName);
+ }
}
| [MuleProcessController->[installLicense->[installLicense],uninstallLicense->[uninstallLicense],addLibrary->[addLibrary],isRunning->[isRunning],restart->[restart],stop->[stop],isDeployed->[isDeployed],start->[start],status->[status],getProcessId->[getProcessId],deployDomain->[deployDomain],undeployAll->[undeployAll],dep... | deployDomain - Deploy a domain. | this. is redundant |
@@ -53,7 +53,7 @@ public class KafkaEmitterConfig
this.metricTopic = Preconditions.checkNotNull(metricTopic, "metric.topic can not be null");
this.alertTopic = Preconditions.checkNotNull(alertTopic, "alert.topic can not be null");
this.clusterName = clusterName;
- this.kafkaProducerConfig = kafkaProdu... | [KafkaEmitterConfig->[hashCode->[hashCode,getKafkaProducerConfig,getClusterName],equals->[getAlertTopic,equals,getMetricTopic,getKafkaProducerConfig,getBootstrapServers,getClusterName]]] | Gets the bootstrap servers for a given . | Please annotate kafkaProducerConfig parameter as `@Nullable` |
@@ -291,8 +291,14 @@ static int lmdump_errno_to_code(int r)
static int diagnose(const char *path)
{
+ int saved_stdout = dup(STDOUT_FILENO);
freopen("/dev/null", "w", stdout);
- return lmdump(LMDUMP_VALUES_ASCII, path);
+ int ret = lmdump(LMDUMP_VALUES_ASCII, path);
+
+ char buf[32];
+ snprintf(... | [No CFG could be retrieved] | CF_CHECK_LMDB_CORRUPT_PAGE CF_CHECK_LMDB Diagnose - checks if a file or directory is missing and returns the error code. | Are you sure `/dev/fd/` exists on all the platforms where we support `cf-check diagnose`? There's also `/dev/stdout` on GNU/Linux. |
@@ -209,11 +209,13 @@ def transform_call_expr(builder: IRBuilder, expr: CallExpr) -> Value:
callee = callee.analyzed.expr # Unwrap type application
if isinstance(callee, MemberExpr):
- return translate_method_call(builder, expr, callee)
+ return get_specialization(builder, expr, callee) o... | [translate_method_call->[translate_call],_visit_tuple_display->[_visit_list_display],transform_slice_expr->[get_arg],transform_comparison_expr->[go->[go],go],translate_super_method_call->[translate_call]] | Translate a call expression to a Python function call. | This now performs specialization for all `CallExpr` types other than `SuperExpr` which does not have a `fullname` attribute. I could use `get_specialization(builder, expr, callee, fullname=False)` for `SuperExpr` if that's the right thing to do. |
@@ -507,14 +507,16 @@ public final class KsqlRestApplication extends Application<KsqlRestConfig> imple
final PreparedStatement<?> statement = ProcessingLogServerUtils
.processingLogStreamCreateStatement(config, ksqlConfig);
+ final Supplier<ConfiguredStatement<?>> configured = () -> ConfiguredStateme... | [KsqlRestApplication->[start->[start],buildApplication->[buildApplication,KsqlRestApplication],stop->[stop],displayWelcomeMessage->[getListeners,displayWelcomeMessage]]] | Creates a processing log stream if it doesn t exist. | Can a ConfiguredStatement be initialized once here instead of using a Supplier? If I understand, the ConfiguredStatement just wraps 3 parameters into one class, and then passes it to the execute() and enqueueCommand() methods. Can one single initialization be enough? |
@@ -225,7 +225,7 @@ def test_config_with_c_argument(mutable_empty_config):
# Add the path to the config
config("add", args.config_vars[0], scope='command_line')
output = config("get", 'config')
- assert "config:\n install_root:\n - root: /path/to/config.yaml" in output
+ assert "config:\n instal... | [test_updating_multiple_scopes_at_once->[packages_yaml_v015],test_updating_config_implicitly_raises->[packages_yaml_v015],test_config_revert_raise_if_cant_write->[packages_yaml_v015],test_config_update_config->[config_yaml_v015],test_config_revert->[packages_yaml_v015],test_config_update_fail_on_permission_issue->[pack... | Test config with c argument. | @vsoch I think the test was asserting the output of a wrong implementation. `install_root` is not in the schema so I would expect it to be an 'object' by default, not an 'array'. |
@@ -131,14 +131,7 @@ const createGuest = function (embedder, url, referrer, frameName, options, postD
}
if (postData != null) {
loadOptions.postData = postData
- loadOptions.extraHeaders = 'content-type: application/x-www-form-urlencoded'
- if (postData.length > 0) {
- const postDataFr... | [No CFG could be retrieved] | Creates a new guest with the given options. getGuestWindow - get guest window. | is 'postData` guaranteed to be a buffer here? because the docs suggest it could be any of a number of different things. |
@@ -291,11 +291,10 @@ export class AmpStoryPageAttachment extends DraggableDrawer {
// amp-story-page-attachment.css). The navigation itself will take some
// time, depending on the target and network conditions.
this.win.setTimeout(() => {
- const navigationService = Services.navigationForD... | [No CFG could be retrieved] | Method to open a new attachment in the page. Closes the drawer. | 1. What if `shadowRoot` is undefined because the browser doesn't support shadow DOM 2. Re: plz never rely on tag names in either CSS or JS. Always a class or something more reliable 3. Not your doing, but can you rename the `page-attachment-host`? It's super confusing, it's not the page attachment but the opening UI |
@@ -25,7 +25,11 @@ namespace Analysis.DataTypes
/// A dictionary of results.
/// </summary>
public Dictionary<string, IList<double>> Results { get; set; }
-
+ /// <summary>
+ /// Gets result by a specified key
+ /// </summary>
+ /// <param name="key"></param>
+ ... | [PointAnalysisData->[GetResultByKey->[ContainsKey]],VectorAnalysisData->[GetResultByKey->[ContainsKey]],SurfaceAnalysisData->[CullCalculationLocations->[U,V,DistanceTo,PointAtParameter,Add],GetResultByKey->[ContainsKey],CullCalculationLocations]] | Get the result collection by key. | Gets results for the specified key from the specified surface analysis data |
@@ -377,6 +377,7 @@ class AbstractScannerResultAdminMixin(admin.ModelAdmin):
return '-'
guid.short_description = 'Add-on GUID'
+ guid.admin_order_field = 'version__addon__guid'
def channel(self, obj):
if obj.version:
| [AbstractScannerRuleAdminMixin->[matched_results_link->[get_unfiltered_changelist_params],get_fields->[has_change_permission]],AbstractScannerResultAdminMixin->[handle_true_positive->[safe_referer_redirect,has_actions_permission],handle_revert->[safe_referer_redirect],handle_false_positive->[has_actions_permission],_ex... | Get the channel display for a given object. | Can haz test? (assuming it's not horrendously complicated) |
@@ -1,6 +1,5 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
-// See the LICENSE file in the project root for more information.
using System.Collections.Generic;
using Mono.Cecil;
| [CompilerGeneratedState->[MethodDefinition->[HasRoslynCompilerGeneratedName,PopulateCacheForType],HasRoslynCompilerGeneratedName->[HasRoslynCompilerGeneratedName]]] | Creates an instance of CompilerGeneratedState that can be used to compile a state machine into a The two states are both associated with the state machine type and the state machine type. | Files under ReferenceSource are literal copies from the dotnet/linker repo. It doesn't make much sense updating them here. The change will be stomped over next time we do integration. |
@@ -71,7 +71,8 @@ namespace Microsoft.Extensions.DependencyInjection.Extensions
/// </summary>
/// <param name="collection">The <see cref="IServiceCollection"/>.</param>
/// <param name="descriptor">The <see cref="ServiceDescriptor"/> to add.</param>
- public static void TryAdd(
+ ... | [ServiceCollectionDescriptorExtensions->[TryAddSingleton->[TryAddSingleton,TryAdd],TryAdd->[TryAdd],TryAddTransient->[TryAddTransient,TryAdd],TryAddScoped->[TryAddScoped,TryAdd],TryAddEnumerable->[TryAddEnumerable]]] | TryAdd method to add a to the given collection. | Just to point it out: this is a breaking change, as the return type of the method is changed. |
@@ -73,6 +73,11 @@ public class QuartzConnector extends AbstractConnector
super(context);
}
+ public String getFullName()
+ {
+ return QUARTZ_SCHEDULER_PREFIX + muleContext.getConfiguration().getId() + "-" + getName();
+ }
+
@Override
protected void doInitialise() throws I... | [QuartzConnector->[doStart->[start,ConnectorException,failedToStart],ensureUniqueInstanceNameBetweenMuleApps->[InitialisationException,debug,format,contains,isDebugEnabled,put,initialisationFailure],doDispose->[getProperty,removeUpInstanceName,warn,shutdown,failedToStop],removeUpInstanceName->[remove,get,debug,isDebugE... | Initializes the object. | The original request to create a function was to avoid the code duplication which is still existent. If you add parameters to pass the congif ID and the name and make it static, then you can use everywhere |
@@ -84,6 +84,8 @@ func (c *publishClient) Connect() error {
}
debugf("XPack monitoring is enabled")
+ debugf("Publishing to %v cluster", c.params["_format"])
+
return nil
}
| [Connect->[Connect],Test->[Test],Close->[Close],String->[String]] | Connect - connect to the Elasticsearch server and check if XPack monitoring is enabled. | Do we know for sure `_format` is set? Want to make sure that because of log nothing is panicing. |
@@ -372,7 +372,7 @@ func (*State) FetchAppliedRulesByProjectIDs(ctx context.Context) (map[string][]*
return nil, nil
}
-func (*State) ErrIfMissingProjects(ctx context.Context, projectIDs []string) error {
+func (*State) EnsureNoProjectsMissing(ctx context.Context, projectIDs []string) error {
return nil
}
| [AddPolicyMembers->[bumpPolicyVersion],PurgeSubjectFromPolicies->[bumpPolicyVersion],Reset->[bumpPolicyVersion],CreateRole->[bumpPolicyVersion],RemovePolicyMembers->[bumpPolicyVersion],DeletePolicy->[bumpPolicyVersion,GetPolicy],DeleteRule->[bumpPolicyVersion,GetStagedOrAppliedRule],DeleteProject->[GetProject],UpdateRu... | FetchAppliedRulesByProjectIDs returns a map of applied rules for the given projects. | [nit] Could be `func (*State) EnsureNoProjectsMissing(context.Context, []string) error {` but doesn't matter |
@@ -320,7 +320,7 @@ EOT
*/
public function parseAuthorString($author)
{
- if (preg_match('/^(?P<name>[- \.,\p{L}\p{N}\'’]+) <(?P<email>.+?)>$/u', $author, $match)) {
+ if (preg_match('/^(?P<name>[- \.,\p{L}\p{N}\'’\"\(\)]+) <(?P<email>.+?)>$/u', $author, $match)) {
if ($this->... | [InitCommand->[findBestVersionForPackage->[getMinimumStability,getPool],determineRequirements->[findPackages],formatAuthors->[parseAuthorString],getPool->[getRepos]]] | Parse an author string into an array of name and email. | You are not required to escape double quote and parentheses in "character class" (characters sequence inside square brackets). The same is actual for existing dot. The results probably will be the same, but pattern will look less complicated. |
@@ -298,6 +298,9 @@ def make_projector_info(info):
----------
info : dict
Measurement info
+ idle_only : bool
+ Only include projectors that are currently idle. By default all
+ projectors are included.
Returns
-------
| [make_eeg_average_ref_proj->[Projection],make_projector_info->[make_projector],read_proj->[Projection]] | Make an SSP operator using the measurement info . | how about include_active instead of idle_only? it would default to true |
@@ -229,6 +229,10 @@ def upload_filter(generation_time, is_base=True, upload_stash=False):
with storage.open(mlbf.filter_path, 'rb') as filter_file:
attachment = ('filter.bin', filter_file, 'application/octet-stream')
server.publish_attachment(data, attachment)
+ statsd.incr('blocklist.tas... | [upload_filter->[MLBF,publish_attachment,complete_session,delete_all_records,set_config,publish_record,RemoteSettings,open],import_block_from_blocklist->[incr,sub,filter,info,dict,startswith,replace,using,target_application,time,list,get_task_user,error,block_activity_log_delete,get_replica,split_regex_to_list,append,u... | Upload a filter to the remote server. | Why is this "base" and "full"? Those names seem confusing to me. Would "base" and "update" be better? |
@@ -19,9 +19,10 @@ package io.confluent.ksql.rest.server.computation;
import java.io.Closeable;
import java.io.PrintWriter;
import java.io.StringWriter;
+import java.util.List;
+import java.util.Optional;
import java.util.concurrent.atomic.AtomicBoolean;
-import org.apache.kafka.clients.consumer.ConsumerRecord;
-im... | [CommandRunner->[processPriorCommands->[handleRestoration,getRestoreCommands],executeStatement->[error,getStatement,handleStatement,PrintWriter,printStackTrace,toString,info,StringWriter],fetchAndRunCommands->[value,executeStatement,trace,key,getNewCommands,count],run->[fetchAndRunCommands,debug,get],close->[set,close]... | Creates a CommandRunner that runs a single command in a continuous loop. This method is called by the command processor to stop the command topic. It will block until. | This blank line suggests to me that you've got old Ewen-style code style in your IDE. You should delete Ewen's 'Google-style' and import the true one. |
@@ -30,10 +30,12 @@ class DuplicateDetectorTest(TaskTest):
test_class_path = generate_path('com/twitter/Test.class')
duplicate_class_path = generate_path('com/twitter/commons/Duplicate.class')
unique_class_path = generate_path('org/apache/Unique.class')
+ unicode_class_path = generate_path('cucumber/a... | [DuplicateDetectorTest->[setUp->[jars->[generate_jar],generate_jar->[generate_path],generate_path,jars]]] | Sets up the necessary classes and jar files. | Extraneous trailing semicolon |
@@ -29,6 +29,7 @@ from itertools import islice
from operator import attrgetter
from string import Formatter
from shutil import get_terminal_size
+from posixpath import normpath
import msgpack
import msgpack.fallback
| [load_pattern_file->[parse_add_pattern],get_cache_dir->[write,get_home_dir],hostname_is_unique->[yes],Location->[to_key_filename->[get_keys_dir],parse->[get,replace_placeholders,match],_parse->[match,normpath_special],__init__->[parse]],get_security_dir->[get_home_dir],BaseFormatter->[format_item->[get_item_data]],json... | The base system module. A class method to provide a way to display a single object. | rather use import posixpath here to make it clearer below that normpath is from there and not from os.path? |
@@ -169,6 +169,13 @@ public class PutKudu extends AbstractProcessor {
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ protected static final PropertyDescriptor IGNORE_NULL = new Builder()
+ .name("Ignore NULL")
+ .description("Ignore NULL on Kudu ... | [PutKudu->[insertRecordToKudu->[getSchema,newInsert,buildPartialRow,getRow],createClient->[getLogger,getPrincipal,loginKerberosUser,buildClient,getKeytab,execute],onScheduled->[getValue,createClient,debug,asInteger,valueOf,asControllerService],onTrigger->[trigger,getLogger,get,isEmpty,execute],getSupportedPropertyDescr... | This class is used to provide a maximum number of records to process in a single Kud Returns an empty array of the properties of the object. | Before we added this property to the processor, did he default to "false"? just want to be sure we are backward compatible here. |
@@ -56,7 +56,7 @@ class InstallOutdatedPackagesTest(unittest.TestCase):
# With revisions it looks in the server a package for the changed local recipe and it
# doesn't find it, so there is no Outdated package alert, just building
- if not self.client.revisions:
+ if not self.client.rev... | [InstallOutdatedPackagesTest->[install_outdated_test->[save,assertIn,assertNotIn,run,cpp_hello_conan_files],install_outdated_and_dep_test->[packages,TestClient,save,assertIn,rmdir,run,cpp_hello_conan_files],install_outdated_dep_test->[packages,TestClient,save,assertIn,rmdir,run,cpp_hello_conan_files],setUp->[TestClient... | Test for install outdated package. This test is used to install a package from the server and build it if it is outdated Checks if the local cackagon is up to date and if so builds it. | This test has a `@unittest.skipIf`, no need to check here. |
@@ -98,6 +98,16 @@ class Gcc(AutotoolsPackage):
depends_on('gnat', when='languages=ada')
depends_on('binutils~libiberty', when='+binutils')
depends_on('zip', type='build', when='languages=java')
+ depends_on('nvptx-tools', when='+nvptx')
+ depends_on('cuda', when='+nvptx')
+
+ resource(
+ ... | [Gcc->[url_for_version->[Version,format],write_rpath_specs->[join_path,gcc,write,set_install_permissions,startswith,format,warn,open],spec_dir->[glob,format],setup_environment->[join_path,set],patch->[join_path,install,Version,isfile,filter_file,format,mkdirp],configure_args->[satisfies,append,Version,extend,format,joi... | This function is a wrapper around gcc7 s built - in function. Provides a list of valid languages for a specific release. | does anything speak against making this its own package? :) |
@@ -121,6 +121,12 @@ def test_plot_raw():
kind='release')
plt.close('all')
+ # test if meas_date has only one element
+ raw.info['meas_date'] = np.array([raw.info['meas_date'][0]],
+ dtype=np.int32)
+ raw.annotation... | [test_plot_raw->[_get_raw,_get_events],test_plot_raw_filtered->[_get_raw],test_plot_raw_psd->[_get_raw],test_plot_sensors->[_get_raw]] | Test plotting of raw data. Plot a missing key missing key Plot a bad on the axes. Returns a sequence of all plot nodes that are not in the plot hierarchy. | you should probably have a `plt.close('all')` after this to free memory |
@@ -55,6 +55,12 @@ class ReadStringsFromPubSub(PTransform):
case, deduplication of the stream will be strictly best effort.
"""
super(ReadStringsFromPubSub, self).__init__()
+ if topic and subscription:
+ raise ValueError("Only one of topic or subscription should be provided.")
+
+ if not ... | [_PubSubPayloadSink->[writer->[NotImplementedError],display_data->[DisplayDataItem]],ReadStringsFromPubSub->[__init__->[super,_PubSubPayloadSource],expand->[ParDo,Read]],_encodeUtf8String->[encode],PubSubSource->[display_data->[DisplayDataItem],__init__->[StrUtf8Coder],reader->[NotImplementedError]],_decodeUtf8String->... | Initializes the object with the specified topic subscription and id_label. | Unfortunately this'll break the direct runner PubSub, but I'll get a fix out for that. |
@@ -132,8 +132,7 @@ public class TileImageBreaker {
tracker.waitForAll();
return img;
} catch (final InterruptedException e) {
- ClientLogger.logQuietly(e);
- return loadImage();
+ Thread.currentThread().interrupt();
}
}
return null;
| [TileImageBreaker->[handleCommandLineArgs->[getValue],loadImage->[loadImage]]] | Load the image from the user. | This call was removed because it seemed wrong to recursively call into the same method after it was just interrupted. It now simply falls through to the failure case after re-interrupting the current thread. |
@@ -109,6 +109,15 @@ public class ConciseBitmapFactory implements BitmapFactory
public ImmutableBitmap union(Iterable<ImmutableBitmap> b)
throws ClassCastException
{
+ if (b instanceof List) {
+ final List<ImmutableBitmap> bitmapList = (List<ImmutableBitmap>) b;
+ if (bitmapList.isEmpty()) {
+... | [ConciseBitmapFactory->[intersection->[intersection,unwrap],unwrap->[iterator->[next->[next],hasNext->[hasNext],iterator]],complement->[complement],union->[unwrap,union]]] | Returns an immutable bitmap that contains all elements from this bitmap and all elements from b. | Can check for `Collection` here |
@@ -270,6 +270,12 @@ smd_store_open(char *fname)
if (smd_df->smd_version > SMD_DF_VERSION ||
smd_df->smd_version < SMD_DF_VER_1) {
D_ERROR("Unsupported DF version %d\n", smd_df->smd_version);
+ if (ds_notify_df_incompat != NULL) {
+ /** Send a RAS notification */
+ ds_notify_df_incompat("SMD pool", smd_... | [int->[DAOS_FAIL_CHECK,dbtree_close,umem_tx_abort,strerror,strdup,D_ASSERT,DP_RC,umem_class_init,daos_errno2der,pmemobj_errormsg,pmemobj_close,umem_tx_commit,pmemobj_open,smd_store_close,dirname,D_ASPRINTF,POBJ_LAYOUT_NAME,D_CRIT,pmemobj_tx_add_range_direct,close,smd_pop2df,open,D_ERROR,free,dbtree_open_inplace,umem_tx... | Open the specified SMD device table and the device table. Open pool or target table in dbtree in - place. | I tested the VOS part but haven't yet tested this case as I had issues with NVMe configuration |
@@ -144,15 +144,12 @@ class DisplayName extends Component {
);
}
- const suffix
- = displayName && displayNameSuffix ? ` (${displayNameSuffix})` : '';
-
return (
<span
className = 'displayname'
id = { elementID }
... | [No CFG could be retrieved] | A component that renders a single input. On change of the display name entered into the edit * field. | By the way, this logic was duplicated in ContactListPanel. If you want to fix it now go ahead otherwise I'll do it some time this week. |
@@ -1384,6 +1384,9 @@ cont_agg_eph_leader_ult(void *arg)
struct cont_ec_agg *tmp;
int rc = 0;
+ if (svc->cs_ec_leader_ephs_req == NULL)
+ goto out;
+
while (!dss_ult_exiting(svc->cs_ec_leader_ephs_req)) {
d_rank_list_t fail_ranks = { 0 };
| [No CFG could be retrieved] | finds the next node in the aggregation pool and updates the max eph value - - - - - - - - - - - - - - - - - -. | Why does this become needed ? |
@@ -70,9 +70,9 @@ author = u'Brainbot AG'
# built documents.
#
# The short X.Y version.
-version = u'0.1.0'
+version = u'0.0.6'
# The full version, including alpha/beta/rc tags.
-release = u'0.1.0'
+release = version
# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supp... | [insert,dirname,abspath] | The names of the files that contain templates relative to this directory. The static and html_extra_path for the cross - reference text. | @LefterisJP suggested versioning it like 0.1.0. I don't remember the reasoning behind it, but I am fine with 0.0.6 too. |
@@ -647,8 +647,7 @@ public class DefaultSchemaInjectorTest {
// Then:
assertThat(e.getMessage(),
- containsString("KEY_FORMAT should support schema inference when KEY_SCHEMA_ID is provided. "
- + "Current format is KAFKA."));
+ containsString("KAFKA does not support the following co... | [DefaultSchemaInjectorTest->[givenKeyButNotValueInferenceSupported->[givenKeyButNotValueInferenceSupported],givenValueButNotKeyInferenceSupported->[givenValueButNotKeyInferenceSupported]]] | Checks if key format does not support schema id inference. | I could not find where this change originates (ie, why does this error message change)? |
@@ -24,7 +24,7 @@ import (
"github.com/pulumi/pulumi/pkg/diag/colors"
)
-func discardSink() Sink {
+func discardSink() *defaultSink {
// Create a new default sink with /dev/null writers to avoid spamming the test log.
return newDefaultSink(FormatOptions{Color: colors.Never}, map[Severity]io.Writer{
Debug: ... | [Equal,Warningf,Stringify,Parallel,Errorf] | TestCounts tests that the given variable contains a non - zero number of non - zero values MISSINGs are not expected but the error message is logged. | curious why this was necessary. |
@@ -49,10 +49,10 @@ public class PopulateOrganizationUuidOfGroups extends DataChange {
massUpdate.update("update groups set organization_uuid=?, updated_at=? where id=?");
massUpdate.rowPluralName("groups");
massUpdate.execute((row, update) -> {
- long groupId = row.getLong(1);
+ int groupId = ... | [PopulateOrganizationUuidOfGroups->[execute->[execute]]] | This method is invoked when the user has not specified a default organization uuid. | this is indeed correct (group id is an integer in DB) but this should either be a separate commit of the commit title should be updated |
@@ -227,7 +227,8 @@ public class GrizzlyServerManager implements HttpServerManager
{
try
{
- final SSLEngineConfigurator serverConfig = new SSLEngineConfigurator(tlsContextFactory.createSslContext(), false, false, false);
+ boolean clientAuth = tlsContextFactory.isTrustStore... | [GrizzlyServerManager->[createSslServerFor->[startTransportIfNotStarted],createSslFilter->[handleRead->[handleRead]],createServerFor->[startTransportIfNotStarted]]] | Creates an SSL filter based on the server configuration and client configuration. | We need to define if we keep wantClientAuth=false (the last argument of the SSLEngineConstructor), or we use clientAuth. |
@@ -337,6 +337,13 @@ public class KafkaSupervisor implements Supervisor
TimeUnit.MILLISECONDS
);
+ metricEmittingExec.scheduleAtFixedRate(
+ computeAndEmitLag(taskClient),
+ ioConfig.getStartDelay().getMillis() + 10000, // wait for tasks to start up
+ moni... | [KafkaSupervisor->[createKafkaTasksForGroup->[generateSequenceName,getRandomId],discoverTasks->[apply->[TaskData,TaskGroup]],buildRunTask->[run->[RunNotice]],runInternal->[possiblyRegisterListener],GracefulShutdownNotice->[handle->[handle]],checkCurrentTaskState->[taskIds],getKafkaConsumer->[getRandomId],checkTaskDurat... | Starts a new Kafka message consumer if it is not already running. | Probably also makes sense to use `druid.monitoring.emissionPeriod` for the initial delay (since that's what the rest of Druid does I believe) and make sure it handles the case where the supervisor or tasks haven't started up |
@@ -131,7 +131,8 @@ public class ScanQueryEngine
intervals.get(0),
query.getVirtualColumns(),
Granularities.ALL,
- query.isDescending(),
+ query.getTimeOrder().equals(ScanQuery.TIME_ORDER_DESCENDING) ||
+ ... | [ScanQueryEngine->[process->[make->[next->[hasNext]]]]] | Process a single missing key segment. Returns a sequence of scan results that can be read from the specified segment. private int offset = 0 ; private static final int MAX_COUNT = 1 ;. | It looks like `descending` is ignored unless `timeOrder` is "none". This should be called out in the docs. Or, even better, as an error in the constructor ("you cannot specify both timeOrder and descending" or some such). |
@@ -47,11 +47,12 @@ export const getStoreService = win => {
/**
* Different UI experiences to display the story.
- * @const @enum {number}
+ * @const @enum {string}
*/
export const UIType = {
- MOBILE: 0,
- DESKTOP: 1,
+ MOBILE: 'mobile',
+ DESKTOP: 'desktop',
+ FULLBLEED: 'fullbleed',
};
| [No CFG could be retrieved] | Exports a function to retrieve the store service. The main function of the n - th state machine. | nit: should we call this `DESKTOP_FULLBLEED` for clarity? |
@@ -58,7 +58,7 @@ namespace Microsoft.Extensions.Configuration.UserSecrets
.GetCustomAttributes<AssemblyMetadataAttribute>()
.First(f => f.Key == "MicrosoftNETCoreAppRefPackageVersion")
.Value;
- var target = Path.Combine(_solutionRoot.FullName, "src", "Conf... | [MsBuildTargetTest->[AssertDotNet->[WaitForExit,Equal,Data,ExitCode,Empty,WriteLine,OutputDataReceived,Start,ErrorDataReceived,BeginOutputReadLine],GeneratesAssemblyAttributeFile->[Copy,Value,Exists,Equal,Contains,LastWriteTimeUtc,WriteLine,FullName,ReadAllText,False,WriteAllText,AssertDotNet,CreateDirectory,Combine,Cr... | generates an assembly metadata file in the temp directory Generates a single file in the temp directory that represents the non - existent non - empty non Checks that the target doesn t re - generate assembly file. | Rather than making the test responsible for this, I'd make sure the test project copies it as testdata. I *think* we can rely on `dotnet` on the path when our tests run, but @ViktorHofer would know better. |
@@ -328,6 +328,7 @@ class GCSFileSystem(FileSystem):
match_result = self.match([path_to_use])[0]
statuses = gcsio.GcsIO().delete_batch(
[m.path for m in match_result.metadata_list])
+ # pylint: disable=used-before-assignment
failures = [e for (_, e) in statuses if e is not None]
... | [GCSFileSystem->[delete->[_delete_path],copy->[_copy_path],create->[_path_open],open->[_path_open]]] | Deletes files or directories at the provided paths. Directories will be deleted recursively. | Is this a false-positive? I can't see what it's upset about. |
@@ -53,8 +53,8 @@ class TimerFiring(object):
class KeyedWorkItem(object):
"""A keyed item that can either be a timer firing or a list of elements."""
- def __init__(self, key, timer_firing=None, elements=None):
- self.key = key
- assert not timer_firing and elements
- self.timer_firing = timer_firing
- ... | [No CFG could be retrieved] | Initialize a key_timer object. | What does this assert do? |
@@ -7,7 +7,7 @@
* Copyright (c) 2003-2015 John Willinsky
* Distributed under the GNU GPL v2. For full terms see the file docs/COPYING.
*
- * @class CopyeditingUserForm
+ * @class FileAuditorForm
* @ingroup controllers_grid_files_signoff
*
* @brief Form to add files to the copyediting files grid
| [FileAuditorForm->[initData->[getGalleyId,setData]]] | Creates a new form which can be used to add a new file to the grid. | I don't think we still need this form right? It's used by the signoff grid only... |
@@ -1637,7 +1637,7 @@ evt_insert_or_split(struct evt_context *tcx, const struct evt_entry_in *ent_new,
* - If the current node is root, create a new root
*/
nm_save = nm_new;
- entry.ei_rect = *evt_node_mbr_get(tcx, nd_new);
+ evt_mbr_read(&entry.ei_rect, nd_new);
if (level != 0) { /* not root */
le... | [No CFG could be retrieved] | Try to split the node and insert the new node into the upper level node. Create a new node and insert it to the root. | (style) 'nd' may be misspelled - perhaps 'and'? |
@@ -35,13 +35,15 @@ class RHtmltable(RPackage):
compatible with HTML/'LaTeX'."""
homepage = "https://CRAN.R-project.org/package=htmlTable"
- url = "https://cran.rstudio.com/src/contrib/htmlTable_1.9.tar.gz"
+ url = "https://cran.rstudio.com/src/contrib/htmlTable_1.11.2.tar.gz"
list_url ... | [RHtmltable->[depends_on,version]] | Deprecated in Cran. RSTudio. | These dependencies are the same for version 1.9 as well, no need to add the `when` here. |
@@ -23,3 +23,14 @@ class PyDill(PythonPackage):
depends_on('python@2.5:2.8,3.1:')
depends_on('py-setuptools@0.6:', type='build')
+
+ def url_for_version(self, version):
+ url = self.list_url
+
+ if version >= Version('0.2.7'):
+ url += 'dill-{0}.tar.gz'
+ else:
+ ... | [PyDill->[depends_on,version]] | requires_on - returns list of packages that are available on the current environment. | No need to convert this to a string, format already does that |
@@ -183,11 +183,12 @@ public class TypoSpellChecker
// subscribe to spelling prefs changes (invalidateAll on changes)
ValueChangeHandler<Boolean> prefChangedHandler = (event) -> context_.invalidateAllWords();
+ ValueChangeHandler<Boolean> realtimeChangedHandler = (event) -> loadDictionary();
... | [TypoSpellChecker->[addIgnoredWord->[invalidateWord,writeDictionary],loadDictionary->[TypoDictionaryRequest,getLanguage,isAlive,cancel,send],addToUserDictionary->[invalidateWord],checkSpelling->[onResponseReceived],releaseOnDismiss,invalidateAllWords,readDictionary]] | The TypoSpellChecker class. SpellingPrefetcher. js. | If the app had started up with real time turned off, turning it on without restarting the app wouldn't then call `loadDictionary()` to ensure that Typo.js was loaded. |
@@ -36,7 +36,12 @@ internal static partial class Interop
private static BOOL HandleEnumWindowsNativeCallback(IntPtr hWnd, IntPtr lParam)
{
- return ((EnumWindowsCallback)GCHandle.FromIntPtr(lParam).Target)(hWnd);
+ if (GCHandle.FromIntPtr(lParam).Target is EnumWindowsCallback c... | [Interop->[User32->[BOOL->[EnumWindows,Alloc,User32,Target,ToIntPtr,Free]]]] | Get the handle for the windows native callback. | As with the other enum callbacks bang and fail fast is a better choice. |
@@ -105,14 +105,14 @@ public class SegmentMetadataHolder
long isPublished,
long isAvailable,
long isRealtime,
- long numReplicas
+ Map<String, Set<String>> segmentServerMap
)
{
this.segmentId = segmentId;
this.isPublished = isPublished;
this.isAvai... | [SegmentMetadataHolder->[Builder->[build->[SegmentMetadataHolder]]]] | Adds the row signature to the result. | This should be stored as an immutable copy, e.g. `ImmutableMap<String, ImmutableSet<String>>` I think since `SegmentMetadataHolder` is supposed to be an immutable structure. |
@@ -17,7 +17,7 @@ SEND_REAL_EMAIL = True
ENV = env('ENV')
-API_THROTTLE = False
+API_THROTTLE = True
CDN_HOST = 'https://addons.cdn.mozilla.net'
DOMAIN = env('DOMAIN', default='addons.mozilla.org')
| [email_url,env,bool,LOGGING,dict,get_db_config,join,items,cache] | Reads environment variables and sets up settings for a single node. Config for the . | This should be `API_THROTTLING` instead of `API_THROTTLE` |
@@ -81,6 +81,7 @@ public class HoodieStorageConfig extends DefaultHoodieConfig {
public Builder limitFileSize(long maxFileSize) {
props.setProperty(PARQUET_FILE_MAX_BYTES, String.valueOf(maxFileSize));
+ props.setProperty(HFILE_FILE_MAX_BYTES, String.valueOf(maxFileSize));
return this;
}
... | [HoodieStorageConfig->[Builder->[build->[HoodieStorageConfig]]]] | limitFileSize - limit file size in bytes. | not sure if its a good idea to overload two configs like this. we may need to break this builder method up separately. |
@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class GuestAccessToken
+ def writable?
+ false
+ end
+
+ def application
+ @application ||= Doorkeeper::Application.official
+ end
+
+ def owner
+ nil
+ end
+end
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | Layout/TrailingBlankLines: Final newline missing. |
@@ -21,9 +21,9 @@ import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
public final class HibernateUserTypeProcessor {
private static final String TYPE_VALUE = "type";
private static final String TYPE_CLASS_VALUE = "typeClass";
- private static final DotName TYPE = DotName.createSi... | [HibernateUserTypeProcessor->[build->[getUserTypes,toArray,value,getClassByName,produce,getIndex,getAnnotations,createSimple,ReflectiveClassBuildItem,addAll,isEmpty,add,asList,asString,asNestedArray],getUserTypes->[add,toString,value],getName,createSimple]] | Build a new reflection class based on the user - defined type annotations. | I'd move these to a single `ClassNames` class too, but maybe that's just me. |
@@ -161,7 +161,7 @@ class CompliantSysLogHandler(logging.handlers.SysLogHandler):
return len(formatted_record) - len(raw_record)
@staticmethod
- def _cut_message(message, formatter_buffer):
+ def _cut_message(message, formatter_buffer, msg_id):
"""
Return a generator of strings m... | [start_logging->[_blacklist_loggers],CompliantSysLogHandler->[emit->[emit]]] | Returns a generator of strings from message that are no longer than MAX_MSG_LENGTH -. | You need to add `:param:` and `:type:` declarations for this new parameter. |
@@ -255,6 +255,12 @@ func (ctx *Context) RegisterResource(
// Create resolvers for the resource's outputs.
res := makeResourceState(custom, props)
+ providers := mergeProviders(t, opts...)
+
+ for k, v := range providers {
+ res.providers[k] = v
+ }
+
// Kick off the resource registration. If we are actually ... | [ReadResource->[ReadResource,DryRun],getOpts->[URN],Invoke->[Invoke],resolve->[resolve],prepareResourceInputs->[DryRun],RegisterResourceOutputs->[beginRPC,RegisterResourceOutputs,DryRun,endRPC],Close->[Close],resolveProviderReference->[ID,URN],RegisterResource->[DryRun,RegisterResource]] | RegisterResource registers a resource with the context. RegisterResource registers a resource with the server. | No need to copy--might as well just slam the returned map into `res`. |
@@ -117,6 +117,11 @@ func (e *PaperProvisionEngine) Run(ctx *Context) (err error) {
if err := tx.Commit(); err != nil {
return err
}
+ if err := e.G().LoginState().Account(func(a *libkb.Account) {
+ a.SetUnlockedPaperKey(kp.sigKey, kp.encKey)
+ }, "UnlockedPaperKey"); err != nil {
+ return err
+ }
// Zero ... | [sendNotification->[HandleLogin,GetUsername,G],paper->[GetDeviceID,makeDeviceKeysWithSigner,LoginState,Warning,G,fetchLKS,SetDeviceProvisioned,LocalSession,LoginWithKey],makeDeviceKeysWithSigner->[makeDeviceKeys,GetEldestKID,makeDeviceWrapArgs],makeDeviceWrapArgs->[ensureLKSec],uidByKID->[AtPath,NewContextified,G,UIDFr... | Run executes the paper provisioner. This function is called when a user enter a paper key. | Just put this one line (121) after line 169 instead. |
@@ -0,0 +1,5 @@
+
+def _get_deserialize():
+ from ._generated.v3_1_preview_3 import TextAnalyticsClient
+ return TextAnalyticsClient("dummy", "dummy")._deserialize # pylint: disable=protected-access
+
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | I think we can move this to the response_handlers file to avoid creating a new file |
@@ -124,8 +124,8 @@ public final class TreeString implements Serializable {
public int hashCode() {
int h = parent == null ? 0 : parent.hashCode();
- for (int i = 0; i < label.length; i++) {
- h = 31 * h + label[i];
+ for (char c : label) {
+ h = 31 * h + c;
... | [TreeString->[of->[TreeString],dedup->[getLabel],equals->[getLabel,equals],split->[TreeString],hashCode->[hashCode],isBlank->[toString,isBlank],toString->[toString,depth],ConverterImpl->[unmarshal->[run->[dedup]],marshal->[toString]]]] | Returns the hash code of this node. | Can replace this with `h = 31 * h + Arrays.hashCode(label)` |
@@ -351,9 +351,8 @@ class Publisher(PublishStep):
force_full = force_full | config_force_full
delete = self.get_config().get("delete", False)
- return last_published and ((last_deleted and last_published > last_deleted) or
- not last_deleted) and not force_fu... | [RSyncPublishStep->[process_main->[rsync],make_rsync_args->[make_destination,make_authentication],make_authentication->[make_ssh_cmd],rsync->[remote_mkdir,call,make_rsync_args]]] | Checks whether or not this publish should be in fastforward mode. Query for missing records. | last_published is twice in here |
@@ -118,6 +118,9 @@ class TouchBar extends EventEmitter {
window.removeListener('closed', removeListeners)
window._touchBar = null
delete this.windowListeners[id]
+ for (const item of this.ordereredItems) {
+ item.removeListener('change', this.changeListener)
+ }
}
window... | [No CFG could be retrieved] | Creates a touch bar item that will be used to escape the touch bar. A private property that can be overwritten by a method in the object. | I _think_ this is undoing the `item.on('change', this.changeListener)` in `registerItem()`, but the next line there is to also register each of item.child.ordereredItems iff item.child is a TouchBar. Do we need to undo that here too? If we don't also need that, then I'm :+1: on this PR |
@@ -530,6 +530,18 @@ func (args MasterArgs) GetMasterAddress() (*url.URL, error) {
return url.Parse(masterAddr)
}
+func (args MasterArgs) GetDNSDomain() (string, error) {
+ if args.DNSDomain != "" {
+ dnsDomain := args.DNSDomain
+ if !strings.HasSuffix(dnsDomain, ".") {
+ dnsDomain += "."
+ }
+ return dnsDom... | [GetAssetPublicAddress->[GetMasterPublicAddress],BuildSerializeableMasterConfig->[GetPolicyFile],GetMasterPublicAddress->[GetMasterAddress],GetEtcdPeerAddress->[GetEtcdAddress],Validate->[Validate],GetEtcdAddress->[GetMasterAddress]] | GetMasterAddress returns the master address. | Internally I would prefer that we use the standard subdomain (no trailing dot) to remove the possibility of confusion about whether it is required. So if we find the suffix, we should strip it. Most humans will observe the non-trailing dot version, and only the DNS server itself probably needs the dot. |
@@ -4,8 +4,10 @@
Game Boy carts with MBC (Memory Bank Controller)
-
- TODO: RTC runs too fast while in-game, in MBC-3 games... find the problem!
+TODO:
+- The MBC3 RTC is not really a true RTC. The chip is used to track passed time even
+ when the console is off, not to keep track of the time of day. Keeping tra... | [No CFG could be retrieved] | ------------------------------------------------******************************************* Creates a list of all the objects in the system that are part of Get the names of the supported ROM types. | That's exactly what an RTC does - it keeps track of time passing when the system is off. This is exactly what `device_rtc_interface` is for. |
@@ -1002,9 +1002,11 @@ If a special exist * 10+9
// normal attributes price
if ($pre_selected->fields["price_prefix"] == '-') {
- $attributes_price_final -= $pre_selected->fields["options_values_price"];
+// $attributes_price_final -= $pre_selected->fields["options_values_price"];
+ $attribut... | [zen_get_buy_now_qty->[in_cart_mixed],zen_get_products_price_is_free->[Execute],zen_get_products_discount_price_qty->[Execute],zen_get_products_actual_price->[Execute],zen_get_products_quantity_order_min->[Execute],zen_get_products_quantity_mixed->[Execute],zen_get_products_quantity_order_max->[Execute],zen_get_attribu... | Returns the amount of attributes price for the given attribute returns true if the attributes of the object are not missing. | Brings the attribute adjustment into the attribute final price as well as to deal with things related to the price of the attribute and other sales/specials. |
@@ -0,0 +1,16 @@
+/*
+ * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com
+ * The software in this package is published under the terms of the CPAL v1.0
+ * license, a copy of which has been included with this distribution in the
+ * LICENSE.txt file.
+ */
+package org.mule.module.launcher;
+... | [No CFG could be retrieved] | No Summary Found. | LeakCleaner isn't a good name. You are cleaning something, so it can't become a leak. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.