patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -97,11 +97,6 @@ def apply_solver(solver, evoked, forward, noise_cov, loose=0.2, depth=0.8):
loose, forward = _check_loose_forward(loose, forward)
- # put the forward solution in fixed orientation if it's not already
- if loose == 0. and not is_fixed_orient(forward):
- forward = mne.convert_forw... | [apply_solver->[is_fixed_orient,_prepare_gain,convert_forward_solution,solver,_check_loose_forward,_make_sparse_stc,_reapply_source_weighting,index,dot],solver->[solve,sum,eye,norm,zeros,argsort,dot],read_evokeds,read_cov,read_forward_solution,data_path,apply_solver,crop,plot_sparse_source_estimates,pick_types] | Function to call a custom solver on a specific . Compute the non - zero state of a . | This will never be true because the previous call to `_check_loose_forward` handles this case. |
@@ -11,7 +11,8 @@ class ProfileField < ApplicationRecord
enum display_area: {
header: 0,
- left_sidebar: 1
+ left_sidebar: 1,
+ settings_only: 2
}
belongs_to :profile_field_group, optional: true
| [ProfileField->[type->[check_box?],validates,include,enum,belongs_to]] | The ProfileField class is a class that represents a single ProfileField object. | This is newly added because some fields aren't displayed at all on the profile page but are used more like settings. |
@@ -308,6 +308,7 @@ class RtEpochs(_BaseEpochs):
verbose = 'ERROR'
sfreq = self.info['sfreq']
n_samp = len(self._raw_times)
+ prev_samp = int(self._find_events_kwargs['min_samples'] - 1)
# relative start and stop positions in samples
tmin_samp = int(round(sfreq * se... | [RtEpochs->[_get_data->[append,list,array],_process_raw_buffer->[round,list,int,sort,append,_find_events,extend,len,atleast_2d,values,where,RuntimeError,zip,_append_epoch_to_queue,abs],events->[array],start->[start_receive_thread,register_receive_callback],stop->[stop_receive_thread,unregister_receive_callback],__repr_... | Process raw buffer and find missing missing events. if event_samp < = last_samp and tmax_samp < =. | you need to check that this is not negative ... and also deal with the case when it's not provided -- in which case you use the default value |
@@ -132,6 +132,8 @@ def numpy_input_fn(x,
features = dict(zip(ordered_dict_x.keys(), features))
if y is not None:
target = features.pop(unique_target_key)
+ # undo modification to dictionary
+ del x[unique_target_key]
return features, target
return features
| [numpy_input_fn->[input_fn->[_get_unique_target_key]]] | Returns input function that would feed dict of numpy arrays into the model and target based on the Input function which returns a list of tuples of features and target key if the input is not. | Do you really need this line? The modified dict is the ordered_dict_x (a shadow copy of x). Input x is not modified. |
@@ -63,7 +63,7 @@ public final class DefaultSocks5CommandRequest extends AbstractSocks5Message imp
throw new IllegalArgumentException("dstPort: " + dstPort + " (expected: 0~65535)");
}
- this.type = type;
+ this.type = ObjectUtil.checkNotNull(type, "type");
this.dstAddrTyp... | [DefaultSocks5CommandRequest->[toString->[type,dstAddr,dstAddrType,toString,dstPort]]] | Creates a new default request for a SOCKS5 command. Replies the dstPort attribute of the object. | lets move the check and assignment before the other stuff to keep the behaviour the same as before. |
@@ -280,6 +280,11 @@ func CreateRootTeam(ctx context.Context, g *libkb.GlobalContext, nameString stri
return nil, fmt.Errorf("cannot create root team with subteam name: %v", nameString)
}
+ merkleRoot, err := g.MerkleClient.FetchRootFromServerByFreshness(libkb.NewMetaContext(ctx, g), libkb.TeamMerkleFreshnessFor... | [PostJSON,MakeSigchainV2OuterSig,WithName,GetKID,SignJSON,GetLatestSeqno,ForceMerkleRootUpdate,RunEngine2,TeamInviteType,GetID,CDebugf,Append,Marshal,loadMember,SetValueAtPath,SigningKey,SigIgnoreIfUnsupported,IsRootTeam,CTraceTimed,New,loadGroup,Errorf,CTrace,NewString,Trace,GetLatestPerUserKey,GetUPAKLoader,WithNetCo... | CreateRootTeam creates a new root team with the given name. Create a subteam with the given name. | Can you put a ticket in the next sprint to retire this method and use `MerkleClient#FetchRootFromServer` instead? |
@@ -112,6 +112,10 @@ namespace Dynamo.Core.Threading
// Comparing to another UpdateGraphAsyncTask, verify
// that they are updating a similar set of nodes.
+ if ((graphSyncData.DeletedSubtrees != null && graphSyncData.DeletedSubtrees.Any()) ||
+ (theOtherTask.graph... | [UpdateGraphAsyncTask->[CanMergeWithCore->[CanMergeWithCore],GetDownstreamNodes->[GetDownstreamNodes]]] | Override this method to check if the other task can be merged with this task. | Argh, we still have that `DeletedSubtrees == null` case, should have been always non-null. Next time. |
@@ -447,3 +447,11 @@ func (w *watcher) ListenStart() bus.Listener {
func (w *watcher) ListenStop() bus.Listener {
return w.bus.Subscribe("stop")
}
+
+type clock interface {
+ Now() time.Time
+}
+
+type systemClock struct{}
+
+func (*systemClock) Now() time.Time { return time.Now() }
| [cleanupWorker->[Container],watch->[Stop,Container]] | ListenStop returns a bus. Listener that will stop watching for changes. | I would add these on top of the file for better readability :) |
@@ -98,6 +98,9 @@ public final class CollectionUtils {
* Note that (a,a,b) (a,b,b) are equal.
*/
public static <T> boolean equals(final Collection<T> c1, final Collection<T> c2) {
- return Objects.equals(c1, c2) || (c1.size() == c2.size() && c2.containsAll(c1) && c1.containsAll(c2));
+ checkNotNull(c1)... | [CollectionUtils->[difference->[toList,collect,isEmpty],equals->[containsAll,size,equals],getNMatches->[checkNotNull,toList,checkArgument,collect],intersection->[toList,collect],getMatches->[checkNotNull,toList,collect],countMatches->[checkNotNull,count]]] | Checks if two collections are equal. | I wonder if we really should just throw all elements in a guava MultiSet and compare the 2 sets for equality. I'd guess the performance will be better for larger collections, not sure if collections are using this method that are actually large enough though. But maybe it's just that I really don't like this method: I ... |
@@ -276,6 +276,6 @@ BaseElement['props'] = {
'multiple': {attr: 'multiple', type: 'boolean'},
'name': {attr: 'name'},
'role': {attr: 'role'},
- 'tabindex': {attr: 'tabindex'},
- 'keyboardSelectMode': {attr: 'keyboard-select-mode'},
+ 'tabindex': {attr: 'tabindex', media: true},
+ 'keyboardSelectMode': {att... | [No CFG could be retrieved] | XML Schema Definition for a list of elements. | I think we need to keep `tabindex` as close to the Web standard as we can. As such, I don't think we can allow media here. Also, shouldn't it be `tabIndex` (camel-case?) |
@@ -0,0 +1,17 @@
+class FormResponse
+ def initialize(success:, errors:, extra: {})
+ @success = success
+ @errors = errors
+ @extra = extra
+ end
+
+ attr_reader :errors
+
+ def success?
+ @success
+ end
+
+ def to_h
+ { success: @success, errors: @errors }.merge!(@extra)
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | should we have this warn or throw if `errors` is an array? (so we can be consistent and use hashes only) |
@@ -16,6 +16,7 @@ from pants_test.engine.util import MockConsole, run_rule
from pants_test.test_base import TestBase
+@unittest.skip(reason='Bitrot discovered during #6880: should be ported to ConsoleRuleTestBase.')
class FileDepsTest(TestBase):
def filedeps_rule_test(self, transitive_targets, expected_conso... | [FileDepsTest->[test_output_one_target_build_with_ext_no_source->[make_build_target_address,mock_hydrated_target,filedeps_rule_test],test_output_one_target_one_source->[make_build_target_address,mock_hydrated_target,filedeps_rule_test],test_output_one_target_one_source_with_dep->[make_build_target_address,mock_hydrated... | Test if the console output of the rule is the same as the output of the rule. | Awkward... Thanks for finding, I'll put together a fix when you merge. |
@@ -134,8 +134,7 @@ def get_best_routes(
# distributable amount, but to sort them based on available balance and
# let the task use as many as required to finish the transfer.
- online_nodes = list()
- unknown_nodes = list()
+ online_nodes = []
neighbors_heap = ordered_neighbors(
ch... | [get_best_routes->[ordered_neighbors,channel_to_routestate],ChannelGraph->[has_path->[has_path],__ne__->[__eq__],__init__->[make_graph]]] | Yields the two - tuples of paths channel and route states that can be used to med Get a list of all nodes that are unknown. | I thought we had agreed to have list initialization with the `list()` keyword. |
@@ -80,6 +80,9 @@ func ChefRunTransmogrify(in <-chan message.ChefRun, out chan<- message.ChefRun,
continue
}
+ // Needed for the nodemanager because the platform field is combined with the version.
+ msg.Platform = ccr.Platform()
+
message.PropagateChefRun(out, &msg)
}
close(out)
| [ToNodeAttribute,FinishProcessing,Error,Debug,ToNodeRun,Unmarshal,PropagateChefRun,ToJSONBytes,Errorf,ToNode,Err,WithFields] | on error is called when the chef run is finished. | This is the only place we have access to the raw platform. So, we set the pipeline msg platform here. |
@@ -192,7 +192,7 @@ class EventProcessor(
partition_context._last_received_event = ( # pylint: disable=protected-access
event
)
- self._handle_callback(self._event_handler, partition_context, event)
+ self._event_handler(partition_context, ev... | [EventProcessor->[_handle_callback->[_handle_callback],start->[start,_close_consumer,_handle_callback],_on_event_received->[_handle_callback],_load_balancing->[_handle_callback,_create_tasks_for_claimed_ownership,_cancel_tasks_for_partitions],_close_consumer->[_handle_callback]]] | Handle an EventData received from the EventHub. Raises exceptions if we get a duplicate_receiving error. | Should we remove method EventProcessor._handle_callback() and call those callbacks directly like in async? |
@@ -34,7 +34,8 @@ const BASE_FLAVOR_CONFIG = {
name: 'base',
rtvPrefixes: ['00', '01', '02', '03', '04', '05'],
// TODO(#28168, erwinmombay): relace with single `--module --nomodule` command.
- command: 'gulp dist --noconfig --esm && gulp dist --noconfig',
+ command:
+ 'gulp dist --noconfig --esm && gulp ... | [No CFG could be retrieved] | Creates an instance of the class. Package containing multiple static files to dist. | we want the nomodule to be the last to execute iirc |
@@ -597,7 +597,7 @@ define([
length = topNormals.length;
var extrudeNormals = new Float32Array(length * 6);
- for (i = 0; i < length; i ++) {
+ for (var i = 0; i < length; i ++) {
topNormals[i] = -topNormals[i];
}
//only get no... | [No CFG could be retrieved] | Creates a new array of vectors and indices for the specified attributes. The indices of the new elements are the indices of the new elements in the new array. | If `i` is also used below, either move `var i` above to its own statement or rename it to `j`, etc. below. |
@@ -39,7 +39,7 @@ public class ClientEventsOOMTest extends MultiHotRodServersTest {
private static final int NUM_NODES = 2;
- private static final int NUM_OWNERS = 1;
+ private static final int NUM_OWNERS = 2;
private static BufferPoolMXBean DIRECT_POOL = getDirectMemoryPool();
| [ClientEventsOOMTest->[ClientEntryListener->[handleClientCacheEntryCreatedEvent->[logDirectMemory]]]] | Example of how to use the Godzilla cache manager. Gets the configuration builder for the . | Shouldn't we make the cache replicated instead? |
@@ -119,6 +119,13 @@ public class FilePathToolbar extends Composite
CheckBoxHiddenLabel selectAllCheckBox = new CheckBoxHiddenLabel("Select all files",
ElementIds.FP_SELECT_ALL);
selectAllCheckBox.addStyleDependentName("FilesSelectAll"... | [FilePathToolbar->[setPath->[parseDir],FileSystemContextImpl->[parseDir->[parseDir]],onResize->[onResize],cd,FileSystemContextImpl]] | onValueChange - callback for SelectAll navigation observer. | Typically we don't add TODOs to our code but rather file a github issue for the improvement. |
@@ -90,3 +90,10 @@ class Wrapper
x_ # error: does not exist
# ^ completion: x_inside_class
end
+
+class B
+ def implicit_block_arg
+ blk # error: does not exist
+ # ^ completion: (nothing)
+ end
+end
| [no_locals_after_dot->[a_],no_duplicate_results->[puts],extend] | x_inside_class is not defined. | check the commits for a before/after |
@@ -127,5 +127,13 @@ func (l *chainLinkUnpacked) AssertInnerOuterMatch() (err error) {
return err
}
- return l.outerLink.AssertFields(l.inner.Body.Version, l.inner.Seqno, prev, l.innerLinkID, linkType)
+ useSeqType := l.inner.SeqType
+ if l.outerLink.SeqType == 0 {
+ // There are links where seq_type is unset o... | [LinkID->[LinkID],SignatureMetadata->[SignatureMetadata,SigChainLocation],SigChainLocation->[SigChainLocation]] | AssertInnerOuterMatch asserts that the inner link matches the outer link. | I guess that's OK. I thought the default was SEMIPRIVATE in this case? |
@@ -235,6 +235,9 @@ public class TopNQueryQueryToolChest extends QueryToolChest<Result<TopNResultVal
final TopNQuery query, final MetricManipulationFn fn
)
{
+ final ExtractionFn extractionFn = TopNQueryEngine.canApplyExtractionInPost(query)
+ ? query.getDimensionSpe... | [TopNQueryQueryToolChest->[getCacheStrategy->[prepareForCache->[extractFactoryName]],ThresholdAdjustingQueryRunner->[run->[run]],makePreComputeManipulatorFn->[prunePostAggregators,extractFactoryName],makePostComputeManipulatorFn->[extractFactoryName]]] | Makes a post - computeManipulatorFn which will be called after the query has been computed. get the timestamp of the result. | The method this is implemented in is another method that shouldn't really exist on this interface. I believe it should be possible to do the same thing in the `mergeResults()` method instead of here. Can we move this logic there and eliminate this? |
@@ -257,7 +257,7 @@ static void dt_dcraw_adobe_coeff(const char *name, float cam_xyz[1][12])
{ "Nikon D100", { 5902,-933,-782,-8983,16719,2354,-1402,1455,6464 } },
{ "Nikon D1H", { 7577,-2166,-926,-7454,15592,1934,-2377,2808,8606 } },
{ "Nikon D1X", { 7702,-2245,-975,-9114,17242,1875,-2679,3055,8521 } },... | [void->[strcmp]] | Table of ADCRAW coefficients. Find all possible canon EOS markers in a project. A list of all possible canon EOS tags. Look for canon EOS - 1400 and canon EOS - 1400. Find all possible canon EOS - 1D markers in a project. | To be honest, i see no difference on the images with old and new color matrix. |
@@ -180,7 +180,7 @@ if ($action == 'create') {
if ($backtopage) {
print '<input type="hidden" name="backtopage" value="'.$backtopage.'">';
}
- if ($backtopageforcancel) {
+ if (isset($backtopageforcancel)) {
print '<input type="hidden" name="backtopageforcancel" value="'.$backtopageforcancel.'">';
}
| [fetch_optionals,fetch_name_optionals_label,executeHooks,loadLangs,trans,formconfirm,initHooks,setProject,showLinkToObjectBlock,showLinkedObjectBlock,close,getOptionalsFromPost,showdocuments,showactions] | Creates a new item in the inventory. Generate the form for a single product item. | In top of page we may have $backtopageforcancel = GETPOST('backtopageforcancel') In such a case, the var is defined, empty bu defined. A test if (!empty()) seems better. |
@@ -69,6 +69,7 @@ namespace System.Security.Cryptography.X509Certificates.Tests
}
[Fact]
+ [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "PKCS#7 import is not available of iOS/tvOS/MacCatalyst")]
public static void ImportPkcs7DerBytes_Empty()
... | [CollectionImportTests->[ImportX509PemFile->[Equal,MsCertificatePemFile,Count,Collection,Import],ImportPkcs7DerBytes_Chain->[Equal,Pkcs7ChainDerBytes,Count,Collection,Import],InvalidStorageFlags->[AssertExtensions,Import,Empty],ImportPkcs7DerBytes_Empty->[Pkcs7EmptyDerBytes,Equal,Count,Collection,Import],ImportPkcs12By... | Check if the certificate is missing a missing key. | A lot of of to on in this file. They're not really important, since the intention is clear. |
@@ -337,6 +337,12 @@ class WPSEO_Option_Wpseo extends WPSEO_Option {
break;
+ case 'semrush_country_code':
+ if ( isset( $dirty[ $key ] ) ) {
+ $clean[ $key ] = $dirty[ $key ];
+ }
+ break;
+
/*
* Boolean (checkbox) fields.
*/
| [WPSEO_Option_Wpseo->[validate_option->[validate_verification_string],add_option_filters->[get_verify_features_option_filter_hook],verify_features_against_network->[prevent_disabled_options_update],add_default_filters->[get_verify_features_default_option_filter_hook],remove_option_filters->[get_verify_features_option_f... | Validate an option This function is used to clean the environment variables that are not in the environment array. Check if a field is marked as dirty. | Not my area of expertise but I assume this doesn't need a real validation because these are hardcoded values in the countries select that users can't change. correct? Besides that, it's worth considering to avoid duplicated code and maybe add this case to the existing `previous_version` case which uses the same code. |
@@ -40,6 +40,10 @@ class EmailLog < ActiveRecord::Base
User.where(id: user_id).update_all("last_emailed_at = CURRENT_TIMESTAMP") if user_id.present?
end
+ def topic
+ @topic ||= self.topic_id.present? ? Topic.find(self.topic_id) : self.post.topic
+ end
+
def self.unique_email_per_post(post, user)
... | [EmailLog->[reached_max_emails?->[max_emails_per_day_per_user,include?,count],unique_email_per_post->[synchronize,id,exists?],for->[find_by],count_per_day->[count],last_sent_email_address->[first],bounce_key->[delete],belongs_to,new,present?,scope,validates,after_create,has_one,where,update_all,id]] | returns a sequence of email log entries for a given post and user. | Temporary until the next PR where I will backfill this column. |
@@ -2740,7 +2740,7 @@ namespace System.Reflection.Metadata.Ecma335
}
public sealed partial class MetadataAggregator
{
- public MetadataAggregator(System.Collections.Generic.IReadOnlyList<int> baseTableRowCounts, System.Collections.Generic.IReadOnlyList<int> baseHeapSizes, System.Collections.Generi... | [ManagedPEBuilder->[ILOnly],PEReaderExtensions->[Never],PEHeaderBuilder->[TerminalServerAware,NoSeh,Unknown,Dll,DynamicBase,NxCompatible,WindowsCui],MetadataReaderProvider->[FromMetadataStream->[Default],GetMetadataReader->[Default],FromPortablePdbStream->[Default]],BlobEncoder->[MethodSignature->[Default]],MethodBodyS... | Get the handle of the given object. | Below row 2746 `object value` is nullable |
@@ -939,9 +939,15 @@ static int final_server_name(SSL *s, unsigned int context, int sent)
*/
if (s->server) {
if (!sent) {
- /* Nothing from the client this handshake; cleanup stale value */
- OPENSSL_free(s->ext.hostname);
- s->ext.hostname = NULL;
+ /*
+... | [No CFG could be retrieved] | The server name negotiation process. Integrity check for the given . | Why would there have been a "stale value" in the SSL handle in the first place? If the client did not send the extension, what does this value represent??? |
@@ -369,6 +369,11 @@ class PrintInformation(QObject):
else:
self._base_name = ""
+ # Strip the old "curaproject" extension from the name
+ OLD_CURA_PROJECT_EXT = ".curaproject"
+ if self._base_name.endswith(OLD_CURA_PROJECT_EXT):
+ self._ba... | [PrintInformation->[getFeaturePrintTimes->[_initPrintTimesPerFeature],setToZeroPrintInformation->[_onPrintDurationMessage],_updateTotalPrintTimePerFeature->[_initPrintTimesPerFeature],_onActiveBuildPlateChanged->[_initVariablesByBuildPlate],_onSceneChanged->[setToZeroPrintInformation],setBaseName->[_updateJobName],_ini... | Sets the base name of the job. | Code style: Use lower_case_underscores for variable names. |
@@ -589,14 +589,6 @@ class TestResponse(VersionCheckMixin, amo.tests.TestCase):
self.mac = amo.PLATFORM_MAC
self.win = amo.PLATFORM_WIN
- self.old_debug = settings_local.DEBUG
-
- settings_local.DEBUG = False
-
- def tearDown(self):
- settings_local.DEBUG = self.old_debug
- ... | [TestResponse->[test_low_app_version->[get],test_url->[get],test_no_platform->[get],test_no_updates_my_fx->[get],test_expires->[get],test_good_version->[get],test_bad_guid->[get],test_cache_control->[get],test_no_app_version->[get],test_content_type->[get],test_length->[get],test_appguid->[get],test_beta_version->[get]... | Set up the object. | We don't need (anymore?) `DEBUG` set to `False` here? |
@@ -93,7 +93,8 @@ def solve(parser, args):
if models < 0:
tty.die("model count must be non-negative: %d")
- specs = spack.cmd.parse_specs(args.specs)
+ merged = spack.spec_index.IndexLocation.LOCAL_AND_REMOTE()
+ specs = spack.cmd.parse_specs(args.specs, index_location=merged)
# dump gen... | [setup_parser->[add_common_arguments,join,add_argument],solve->[die,split,write,msg,min,to_json,parse_specs,solve,tree,values,ValueError,join,provides,print_cores,isatty,to_yaml]] | Solve a single . Print a single object from the input specification. | this PR should not affect every call to `parse_specs` - remove this and make the spec parser know about the index. the index can learn about what potential places there are to get hashes by looking at spack's mirror configuration. |
@@ -138,8 +138,12 @@ EOT
// Get the local composer.json, global config.json, or if the user
// passed in a file to use
$configFile = $input->getOption('global')
- ? ($this->config->get('home') . '/config.json')
- : $input->getOption('file');
+ ? ($this->config... | [ConfigCommand->[listConfiguration->[listConfiguration]]] | Initializes the configuration file and auth file if it s not there. Checks if there is a missing configuration file. | you can use the `?:` shorthand here |
@@ -610,9 +610,11 @@ namespace System.Net.Sockets
public System.Threading.Tasks.Task ConnectAsync(System.Net.IPAddress address, int port) { throw null; }
public System.Threading.Tasks.Task ConnectAsync(System.Net.IPAddress[] addresses, int port) { throw null; }
public System.Threading.Tasks.T... | [No CFG could be retrieved] | Connect to the specified host and port asynchronously. | This should be IPEndPoint, *not* EndPoint. Similarly below. |
@@ -17,6 +17,7 @@ from acme import messages
import certbot
from certbot import account
+from certbot import cert_manager
from certbot import client
from certbot import cli
from certbot import crypto_util
| [revoke->[revoke,_determine_account],setup_logging->[setup_log_file_handler,_cli_log_handler],_treat_as_renewal->[_handle_identical_cert_request,_handle_subset_cert_request],install->[_init_le_client,_find_domains],run->[_init_le_client,_auth_from_domains,_find_domains,_suggest_donation_if_appropriate],main->[register,... | Certbot main entry point. Creates a function that reports successful dry run. | In the past we used "cert manager" to refer to @jdkasten's tool including a UI for cert management tasks. I'm just wondering about C-MIP nomenclature for a library of methods that can perform such tasks vs. a UI for invoking them. |
@@ -1124,6 +1124,10 @@ namespace Dynamo.ViewModels
{
var viewModel = workspaces.First(x => x.Model == item);
if (currentWorkspaceViewModel == viewModel)
+ if(currentWorkspaceViewModel != null)
+ {
+ currentWorkspaceViewModel.Dispose();
... | [DynamoViewModel->[CanZoomOut->[CanZoomOut],SaveAs->[SaveAs,AddToRecentFiles,Save],ExportToSTL->[ExportToSTL],ShowOpenDialogAndOpenResult->[Open,CanOpen],ShowSaveDialogIfNeededAndSave->[SaveAs],ImportLibrary->[ImportLibrary],ReportABug->[ReportABug],ClearLog->[ClearLog],Escape->[CancelActiveState],ShowSaveDialogIfNeede... | This method is called when a workspace is removed from the list of workspaces. | main entry point for disposal of viewModels - if we remove a workspace from the workspace collection - dispose it, this causes dispose to get called on nodeViewModel, NoteViewModel, PortViewModel, ConnectorViewModel, etc. |
@@ -131,11 +131,7 @@ def test_xdawn_regularization():
# Test with overlapping events.
# modify events to simulate one overlap
- events = epochs.events
- sel = np.where(events[:, 2] == 2)[0][:2]
- modified_event = events[sel[0]]
- modified_event[0] += 1
- epochs.events[sel[1]] = modified_event... | [test_xdawn_regularization->[_get_data],test_xdawn_fit->[_get_data],test_XdawnTransformer->[_get_data],test_xdawn_apply_transform->[_get_data]] | Test Xdawn with regularization. | only exact same row are a problem. |
@@ -1977,6 +1977,11 @@ class CRUDTests(unittest.TestCase):
container_definition = {'id': container_id, 'indexingPolicy': indexing_policy}
created_container = self.client.CreateContainer(self.GetDatabaseLink(db, is_name_based), container_definition)
read_indexing_policy = created_container['in... | [CRUDTests->[test_offer_read_and_query->[__AssertHTTPFailureWithStatus,__ValidateOfferResponseBody],test_partitioned_collection_partition_key_value_types->[__AssertHTTPFailureWithStatus],test_partitioned_collection_conflict_crud_and_query->[__AssertHTTPFailureWithStatus],test_document_crud->[__AssertHTTPFailureWithStat... | Create a container with composite and spatial indexes. Checks if there is no index node in the indexing policy. | we need to remove the 2 disabled tests |
@@ -531,14 +531,14 @@ const serverFiles = {
],
serverMicroservice: [
{
- condition: generator => !(generator.applicationType !== 'microservice' && !(generator.applicationType === 'gateway' && (generator.authenticationType === 'uaa' || generator.authenticationType === 'oauth2'))),
+ ... | [No CFG could be retrieved] | Returns a configuration object that can be used to configure the OAuth2 authentication. The signature verifier client. | This one is super tricky, it should actually be: (generator.applicationType === 'microservice' || (generator.applicationType === 'gateway' **||** (generator.authenticationType === 'uaa' || generator.authenticationType === 'oauth2'))) Instead of : (generator.applicationType === 'microservice' || (generator.applicationTy... |
@@ -682,6 +682,8 @@ export class Resource {
let scrollPenalty = 1;
let distance = 0;
+ // TODO
+
if (this.useLayers_) {
distance += Math.max(0,
layoutBox.left - viewportBox.right,
| [No CFG could be retrieved] | Checks if a given is within the viewport. Checks if an element is allowed to render. | Elaborate or remove. |
@@ -103,18 +103,14 @@ test('BaseInput - autoFocus sets the initial focus state', () => {
});
test('BaseInput - inputRef from props', () => {
- const focus = jest.fn();
const props = {
autoFocus: true,
onFocus: jest.fn(),
onChange: jest.fn(),
- inputRef: {current: {focus}},
};
// $FlowF... | [No CFG could be retrieved] | Input - inputRef - inputRef from props. | Why not keep this test to make sure the `autoFocus` works as expected? |
@@ -278,8 +278,6 @@ class CustomModel(object):
if isinstance(impl, str):
if "\n" not in impl and impl.endswith(exts):
impl = FromFile(impl if isabs(impl) else join(self.path, impl))
- else:
- impl = CoffeeScript(impl)
if isinstance(impl, Inline... | [CustomModel->[implementation->[CoffeeScript,FromFile]],nodejs_compile->[AttrDict],_run->[_crlf_cr_2_lf],_run_npmjs->[_npmjs_path,_run],_npmjs_path->[_nodejs_path],bundle_models->[calc_cache_key],_compile_models->[CompilationError,nodejs_compile,_run_npmjs],_run_nodejs->[_nodejs_path,_run],_bundle_models->[resolve_deps... | Returns the implementation of the object. | Should this default to `TypeScript` now? |
@@ -210,6 +210,14 @@ public class ClusterManagerServer extends ClusterManager {
messagingService.registerHandler(CLUSTER_AUTH_EVENT_TOPIC,
subscribeClusterAuthEvent, MoreExecutors.directExecutor());
+ HashMap<String, Object> meta = new HashMap<String, Object>();
+ String nodeName =... | [ClusterManagerServer->[start->[start],shutdown->[shutdown],initThread->[start],getInstance->[ClusterManagerServer]]] | Initializes the Raft server thread. | We should not use old date api java.util.Date, either we use the new Date api in java 8 or joda |
@@ -146,6 +146,8 @@ var readinessCheckers = map[schema.GroupKind]func(client.Interface, runtime.Obje
deployapi.Kind("DeploymentConfig"): checkDeploymentConfigReadiness,
batch.Kind("Job"): checkJobReadiness,
apps.Kind("StatefulSet"): checkStatefulSetReadiness,
+ routeap... | [BuildConfigSelector,LegacyKind,GroupVersionKind,FormatInt,Kind,List,String,IsTerminalPhase,Builds,GroupKind] | checkReadiness maps GroupKinds to the appropriate function. | You need an additional line `routeapi.LegacyKind("Route"): checkRouteReadiness,` here. This will handle objects with apiVersion: v1, kind: Route. Your existing line only handles objects with apiVersion: route.openshift.io/v1, kind: Route. |
@@ -19,6 +19,14 @@ class Soapdenovo2(MakefilePackage):
version('242', sha256='a0043ceb41bc17a1c3fd2b8abe4f9029a60ad3edceb2b15af3c2cfabd36aa11b')
version('240', sha256='cc9e9f216072c0bbcace5efdead947e1c3f41f09baec5508c7b90f933a090909')
+ def flag_handler(self, name, flags):
+ if self.spec.satisfies... | [Soapdenovo2->[install->[install,mkdirp],version]] | Install the SOAPdenovo package. | Is there any attempt to fix this upstream :worried: ? |
@@ -31,8 +31,9 @@ type AccessLog struct {
// AccessLogFilters holds filters configuration
type AccessLogFilters struct {
- StatusCodes StatusCodes `json:"statusCodes,omitempty" description:"Keep access logs with status codes in the specified range" export:"true"`
- RetryAttempts bool `json:"retryAttempts,o... | [String->[Sprintf],Set->[FieldsFunc,SplitN,Fields]] | TraefikLog holds the configuration settings for the traefik logger. Returns the string representation of the given string. | Is it possible to use `time.Duration` as type as well? I'm not so much into the `flaeg` stuff. Maybe @ldez knows which type is best to use here. I saw `time.Duration` as example in the flaeg README, but on other places we use `flaeg.Duration` mostly. I'm not sure which one we should use. |
@@ -88,6 +88,7 @@ public class ResourceController {
try {
task.run();
} finally {
+ // TODO if AsynchronousExecution, do that later
synchronized(this) {
inProgress.remove(activity);
inUse = ResourceList.union(resourceView);
| [ResourceController->[size->[size],iterator->[iterator]]] | Executes a task in the thread pool. | You may need to revisit the locking after #1596 |
@@ -106,7 +106,7 @@ public abstract class KerberosInterpreter extends AbstractInterpreter {
private Long getTimeAsMs(String time) {
if (time == null) {
- logger.error("Cannot convert to time value.", time);
+ LOGGER.error("Cannot convert to time value.", time);
time = "1d";
}
| [KerberosInterpreter->[close->[isKerboseEnabled],startKerberosLoginThread->[call->[getKerberosRefreshInterval,kinitFailThreshold,runKerberosLogin,close]],open->[isKerboseEnabled]]] | This method converts a string time value to a time value in milliseconds. | 'time' makes no sense with this output. |
@@ -132,6 +132,13 @@ namespace Microsoft.VisualBasic.Tests
yield return new object[] { (int?)0, "Integer" };
}
+ public static IEnumerable<object[]> TypeName_ComObject_TestData()
+ {
+ yield return new object[] { "ADODB.Stream", "Stream" };
+ yield return new ... | [VersionedTests->[VbTypeName->[VbTypeName],CallByName_ArgumentException->[CallByName],IsNumeric->[IsNumeric],SystemTypeName->[SystemTypeName],CallByName_MissingMemberException->[CallByName],CallByName->[CallByName],TypeName->[TypeName]]] | TypeName_TestData method for version of Versioned that has default value. | I haven't looked at this PR/issue but note that our tests have to pass on Windows Nano. I am not sure how much of the COM infrastructure is supported on that SKU and I'm willing to bet that it may not have registrations for these types. If so you will haev to use something like `[ConditionalTheory(typeof(PlatformDetect... |
@@ -624,10 +624,9 @@ class SentenceSentiment(DictMixin):
def _from_generated(cls, sentence):
return cls(
sentiment=sentence.sentiment,
- confidence_scores=SentimentConfidenceScores._from_generated(sentence.sentence_scores), # pylint: disable=protected-access
+ confidenc... | [RecognizeEntitiesResult->[__init__->[get]],LinkedEntity->[_from_generated->[_from_generated],__init__->[get]],LinkedEntityMatch->[__init__->[get]],CategorizedEntity->[__init__->[get]],DetectedLanguage->[__init__->[get]],DocumentError->[__getattr__->[RecognizeEntitiesResult,update,DocumentError,ExtractKeyPhrasesResult,... | Create a new instance from a generated sentence. | Remove docstring, instance var, repr, for warnings here, as well. Also doesn't `SentenceSentiment` now return `text`? |
@@ -107,6 +107,9 @@ module.exports = function(grunt) {
options: {
jshintrc: true,
},
+ tests: {
+ files: { src: 'test/**/*.js' },
+ },
ng: {
files: { src: files['angularSrc'] },
},
| [No CFG could be retrieved] | The base configuration for the middleware. Config for all NgJS modules. | It is best to use `files[...]` here so that we keep all file references in a single place, no? |
@@ -746,7 +746,14 @@ public class NodeImpl extends PeerConnectionDelegate implements Node {
}
if (blockIds.isEmpty()) {
- peer.setNeedSyncFromUs(false);
+ if (CollectionUtils.isNotEmpty(summaryChainIds) && summaryChainIds.get(0).getNum() < del
+ .getHeadBlockId().getNum()) {
+ logg... | [NodeImpl->[onHandleSyncBlockChainMessage->[getMessage],processSyncBlock->[getMessage,offer],onHandleTransactionMessage->[getMessage],InvToSend->[clear->[clear]],syncNextBatchChainIds->[getMessage],startSyncWithPeer->[clear],syncFrom->[getMessage],startFetchSyncBlock->[add,clear],processAdvBlock->[offer,broadcast],onHa... | on handle sync block chain message. | when peer's number id lower than our solid block number , It's really sync fail, in this case , it maybe can sync again |
@@ -1472,6 +1472,18 @@ DataWriterImpl::enable()
return DDS::RETCODE_ERROR;
}
+ // Must be done after transport enabled.
+ set_writer_effective_data_rep_qos(qos_.representation.value, cdr_encapsulation());
+ if (!topic_servant_->check_data_representation(qos_.representation.value, true)) {
+ if (DCPS_deb... | [No CFG could be retrieved] | Initialize the object. Adds a publication to the type lookup service. | Maybe log the values that are there? |
@@ -234,7 +234,7 @@ public class QuarkusDev extends QuarkusTask {
.suspend(System.getProperty("suspend"));
if (System.getProperty(IO_QUARKUS_DEVMODE_ARGS) == null) {
builder.jvmArgs("-Dquarkus.test.basic-console=true")
- .jvmArgs("-Dio.quarkus.launched-from-ide=... | [QuarkusDev->[startDev->[getWorkingDir],newLauncher->[getCompilerArgs,getJvmArgs],addSelfWithLocalDeps->[addSelfWithLocalDeps],findQuarkusPluginDependency->[findQuarkusPluginDependency],addLocalProject->[getBuildDir],getBuildDir->[getBuildDir],setArgsString->[setArgs],addGradlePluginDeps->[findQuarkusPluginDependency]]... | Creates a new instance of QuarkusDevModeLauncher. Add a missing dependency to the Gradle builder. Returns a jvm object that can be used to build the application. | Is the duplicate `io.quarkus.io.quarkus` intentional here? :-) |
@@ -1786,16 +1786,7 @@ public class Sched {
dict.put("resched", conf.getBoolean("resched"));
return dict;
} catch (JSONException e) {
- if (!mCol.getDecks().isDyn(card.getDid()) && card.getODid() != 0) {
- // workaround, if a card's deck is a normal deck, but odid != ... | [Sched->[_resetRevCount->[_walkingCount],_revConf->[_cardConf],dueForecast->[dueForecast],_fillNew->[_resetNew,_fillNew],suspendCards->[removeLrn,remFromDyn],resetCards->[forgetCards],cardCount->[cardCount,_deckLimit],counts->[counts],_getLrnCard->[_fillLrn,getCard,_getLrnCard],_updateStats->[_updateStats],_fillRev->[_... | _lapseConf - get the configuration for a card in order to be able to run a Get the revision of the object in the order of Odd. | So this report is not needed anymore? |
@@ -43,7 +43,13 @@ USE_L10N = True
USE_TZ = True
-EMAIL_URL = os.environ.get('EMAIL_URL', 'console://')
+SENDGRID_USERNAME = os.environ.get('SENDGRID_USERNAME')
+SENDGRID_PASSWORD = os.environ.get('SENDGRID_PASSWORD')
+if SENDGRID_USERNAME and SENDGRID_PASSWORD:
+ EMAIL_URL = 'smtp://%s:%s@smtp.sendgrid.net:587... | [literal_eval,parse,dirname,get,getenv,config,join,normpath] | Site ID is the site ID of the saleor application. This function is used to generate a list of all the necessary resources for a given user. | I would still give priority to an explicitly passed `EMAIL_URL`. |
@@ -55,7 +55,7 @@ public final class RefuseRegisteredServiceProxyPolicy implements RegisteredServi
return false;
}
- return true;
+ return o instanceof RefuseRegisteredServiceProxyPolicy;
}
@Override
| [RefuseRegisteredServiceProxyPolicy->[hashCode->[toHashCode,HashCodeBuilder]]] | Checks if the object is equal to this object. | I guess this test could be "smartly" merged with the test above: `if (!(o instanceof RegisteredServiceProxyPolicy)) {` |
@@ -431,5 +431,13 @@ public class ClassUtils {
}
return map;
}
+
+ /**
+ * get classname from qualified name
+ */
+ public static String getSimpleClassName(String qualifiedName) {
+ int i = qualifiedName.lastIndexOf('.');
+ return i < 0 ? qualifiedName : qualifiedN... | [ClassUtils->[newInstance->[newInstance],isBeforeJava6->[isBeforeJava5],getGenericClass->[getGenericClass],arrayForName->[forName],toString->[toString]]] | Creates a map from an array of entries. | Better to check and have check for non empty or null string `org.apache.dubbo.common.utils.Assert.notEmptyString(qualifiedName, "Name can't be null or blank");` |
@@ -192,3 +192,4 @@ raw.plot_projs_topomap(colorbar=True)
# .. LINKS
#
# .. _spectral density: https://en.wikipedia.org/wiki/Spectral_density
+
| [plot,plot_sensors,data_path,plot_projs_topomap,plot_psd_topo,read_raw_fif,copy,crop,join,plot_psd] | Helps to show how a is. | you'll need to revert this before we can merge; it will fail flake8 |
@@ -54,11 +54,12 @@ class KeyVaultClientOperationsMixin(object):
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))
api_version = "7.1"
+ accept = "application/json"
def prepare_request(next_link=None):
... | [KeyVaultClientOperationsMixin->[get_deleted_certificates->[get_next->[prepare_request]],get_certificates->[get_next->[prepare_request]],get_certificate_versions->[get_next->[prepare_request]],get_certificate_issuers->[get_next->[prepare_request]]]] | Gets the set of certificates in a specified key vault. Get a list of key - vault items. | Looks like this is the only change to the versioned mixins, and unrelated to the functional change you're trying to make. Is it due to using a different autorest version? |
@@ -21,7 +21,7 @@ class ThriftLintError(Exception):
"""Raised on a lint failure."""
-class ThriftLinter(NailgunTask):
+class ThriftLinterBase(NailgunTask):
"""Print linter warnings for thrift files."""
@staticmethod
| [ThriftLinter->[_is_strict->[_to_bool],_lint->[ThriftLintError,_is_strict]]] | Checks if the target is a ThriftLibrary. | Should we push this docstring down to the subclasses? We currently don't look at super classes docstrings when determining the task help text, so both of the sub tasks have no description. |
@@ -1,4 +1,3 @@
-from __future__ import unicode_literals
try:
from itertools import zip_longest
except ImportError:
| [slice->[zip_longest,filter,iter],get_sort_by_url->[dict,urlencode],get_sort_by_toggle->[get,static,copy,strip,urlencode],assignment_tag,Library,simple_tag] | Template tag for a list of objects. This function returns a dictionary with the data of the field in the request. | Catching import error no longer needed |
@@ -300,6 +300,7 @@ export class MediaPerformanceMetricsService {
rebuffers: 0,
rebufferTime: 0,
watchTime: 0,
+ isActivePage: false,
},
};
}
| [No CFG could be retrieved] | Creates a new media entry object from a list of unlistened media elements. Listens for un - buffer events on a given media element. | This is not a metric and it's unnecessary, please remove |
@@ -278,5 +278,16 @@ public class HoodieIndexConfig extends DefaultHoodieConfig {
HoodieIndex.IndexType.valueOf(props.getProperty(INDEX_TYPE_PROP));
return config;
}
+
+ private String getDefaultIndexType(EngineType engineType) {
+ switch (engineType) {
+ case SPARK:
+ return ... | [HoodieIndexConfig->[Builder->[build->[HoodieIndexConfig]]]] | Builds the configuration. Sets default condition values based on given properties. Missing configuration for Hoodie Index. | Are there other configurations that are different in different engines, and if there are many, are they easy to implement in this way? |
@@ -3,16 +3,14 @@
# Licensed under the MIT License. See LICENSE.txt in the project root for
# license information.
# --------------------------------------------------------------------------
-from datetime import datetime
from typing import Any, AsyncIterable, Mapping, Optional, Dict
+from datetime import datetime... | [SecretClient->[recover_deleted_secret->[recover_deleted_secret],restore_secret->[restore_secret],set_secret->[set_secret],purge_deleted_secret->[purge_deleted_secret],delete_secret->[delete_secret],get_secret->[get_secret],get_deleted_secret->[get_deleted_secret],update_secret->[update_secret],backup_secret->[backup_s... | Gets a secret from the Key Vault. Get the from the SecretBundle. | Why reorder these? The pattern elsewhere is 1. standard library 1. external 1. internal alphabetized within each category. |
@@ -72,12 +72,8 @@ const linksToExample = (shouldContainBasepath, opt_name) =>
examplesPathRegex.test(shouldContainBasepath) &&
htmlDocRegex.test(opt_name || shouldContainBasepath);
-const ExamplesSelectModeOptional = ({basepath, selectModePrefix}) =>
- !examplesPathRegex.test(basepath + '/')
- ? ''
- : ... | [No CFG could be retrieved] | Generates a view of the AMP s state. Example of how to display a link to a file list item with a link to a link. | This is a nice fix. The files in `build-system/server` are a whole other beast, so it's good to see them being checked. |
@@ -95,7 +95,9 @@ public class BigQueryAvroUtilsTest {
record.put("birthday", 5L);
record.put("flighted", Boolean.TRUE);
record.put("sound", soundByteBuffer);
- record.put("anniversary", new Utf8("2000-01-01"));
+ record.put("anniversary_date", new Utf8("2000-01-01"));
+ record.put("... | [BigQueryAvroUtilsTest->[Bird->[SubBird],testConvertGenericRecordToTableRow->[newArrayList,setFields,convertGenericRecordToTableRow,setType,getSchema,TableSchema,setMode,set,rewind,wrap,Utf8,getBytes,assertEquals,put,Record]]] | This test converts a GenericRecord to a BigQuery TableRow using the specified TableSchema. Test row types. if (!n ) return ;. | Did you sync with BQ about the inconsistencies with the date time types you were having where input and output differed. |
@@ -136,7 +136,7 @@ public class HttpRequesterBuilder implements HttpRequestOperationConfig<HttpRequ
if (requestConfig == null)
{
- requestConfig = new DefaultHttpRequesterConfig();
+ requestConfig = (DefaultHttpRequesterConfig) new HttpRequesterConfigBuilder(mu... | [HttpRequesterBuilder->[setPort->[setPort],setPath->[setPath],setUrl->[setUrl],setHost->[setHost]]] | Builds the http request requester. | this block should be synchronized |
@@ -90,6 +90,12 @@ def generate_order_lines_payload(lines: Iterable[OrderLine]):
extra_dict_data={
"total_price_net_amount": (lambda l: l.total_price.net.amount),
"total_price_gross_amount": (lambda l: l.total_price.gross.amount),
+ "allocations": list(
+ lin... | [generate_sample_payload->[generate_product_payload,_generate_sample_order_payload,_get_sample_object,generate_fulfillment_payload,generate_customer_payload,generate_page_payload,generate_checkout_payload],generate_fulfillment_payload->[generate_fulfillment_lines_payload,generate_order_payload],_generate_sample_order_p... | Generate order lines payload. Get order data for a single order in order_order_orders. | Webhook payload should use GraphQL IDs. |
@@ -11,7 +11,7 @@ namespace Pulumi.Automation.Commands
internal interface IPulumiCmd
{
Task<CommandResult> RunAsync(
- IEnumerable<string> args,
+ IList<string> args,
string workingDir,
IDictionary<string, string?> additionalEnv,
Action<str... | [No CFG could be retrieved] | RunAsync - Async version of Run. | Hm, this was an automatically suggested change? I wonder why it did that. It seems to me IEnumerable has fewer assumptions than IList, and if RunAsync does not need random access, the change weakens it? Just curious why it decided to change this. |
@@ -118,6 +118,7 @@ namespace System.Net.Http
public System.Net.CookieContainer CookieContainer { get { throw null; } set { } }
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
public System.Net.ICredentials? Credentials { get { throw null; } set { } }
+ [System.Ru... | [No CFG could be retrieved] | This class is used to provide a list of supported DecompressionMethods. The IDictionary is not used by the object. | What about DangerousAcceptAnyServerCertificateValidator is unsupported? ServerCertificateCustomValidationCallback is unsupported, but this delegate is just a singleton that always returns true. |
@@ -1072,6 +1072,10 @@ User.reopenClass(Singleton, {
return ajax(userPath("check_email"), { data: { email } });
},
+ resetRecentSearches() {
+ return ajax(`/u/reset-recent-searches`, { type: "POST" });
+ },
+
groupStats(stats) {
const responses = UserActionStat.create({
count: 0,
| [No CFG could be retrieved] | Find a user by username. This function is a private function that can be used to create a new user account. | Minor but maybe it would be more RESTful to say `DELETE` at ` /u/recent-searches`? |
@@ -1220,6 +1220,10 @@ namespace System.Windows.Forms
Insert(retIndex, tabPage);
}
}
+ else
+ {
+ Insert(index, tabPage);
+ }
}
/// <summary>
| [TabControl->[OnFontChanged->[UpdateSize,OnFontChanged],ResizePages->[GetTabPages],UpdateSize->[BeginUpdate,EndUpdate],WmNeedText->[GetToolTipText],OnLeave->[OnLeave],PrefixAmpersands->[ToString],OnHandleDestroyed->[OnHandleDestroyed],ToString->[ToString],OnHandleCreated->[AddNativeTabPage,OnHandleCreated,ApplyItemSize... | insert a tab page into the list. | Q: Did you check the significance of "SendMessage(ComCtl32.TCM.INSERTITEMW, (IntPtr)index, tabPage)" when Handle is created? |
@@ -1215,7 +1215,7 @@ var ngModelOptionsDirective = function() {
restrict: 'A',
controller: ['$scope', '$attrs', function($scope, $attrs) {
var that = this;
- this.$options = $scope.$eval($attrs.ngModelOptions);
+ this.$options = angular.copy($scope.$eval($attrs.ngModelOptions));
// Al... | [No CFG could be retrieved] | Requires a name attribute and a controller to be attached to the controller. Adds the setValidity method to the controller. | Really minor, and a bit late, but this should just be `copy`... |
@@ -37,7 +37,8 @@ public final class MacFinder {
public static String getHashedMacAddress() {
final String mac = getMacAddress();
if (mac == null) {
- throw new IllegalArgumentException("You have an invalid MAC address or TripleA can't find your mac address");
+ throw new IllegalArgumentException... | [MacFinder->[tryToParseMacFromOutput->[isMacValid],getHashedMacAddress->[getHashedMacAddress]]] | Get the hashed MAC address. | @DanVanAtta Is your formatter set to 120 columns? There seem to be several changes in this PR that simply re-wrap lines without any actual modifications. |
@@ -46,6 +46,16 @@ namespace Dynamo.UI.Views
viewModel.RequestCloseSearchToolTip += OnRequestCloseToolTip;
}
+ private void viewModel_SearchTextChanged(object sender, EventArgs e)
+ {
+ //Get the scrollview and scroll to top on every text entered
+ var scroll ... | [LibrarySearchView->[OnRequestCloseToolTip->[CloseToolTipInternal]]] | This method is called when the library search view is loaded. | When a text is changed the underlying treeview should be scrolled to top. |
@@ -243,6 +243,14 @@ define([
* @default 7500000.0
*/
this.minimumTrackBallHeight = 7500000.0;
+ /**
+ * Keeps the camera above terrain when the camera is in a reference frame other than the world frame, i.e.
+ * the camera transform property is not the identity matri... | [No CFG could be retrieved] | Displays a keyboard event with the specified minimum height. Constructor for InertiaController. | Do we want this flag to be this specific? Why not just have a boolean that enables/disable collision detection completely? |
@@ -0,0 +1,15 @@
+# typed: strict
+# enable-packager: true
+
+class Simpsons < PackageSpec
+ # ^^^^^^^^ symbol-search: "Simpsons", name = "Simpsons", container = "(nothing)"
+ # go-to-def on a reference to Bart within the package goes here, but go-to-def on Bart in `import Bart` goes to the
+ # package.
+ i... | [No CFG could be retrieved] | No Summary Found. | So there was basically no additional work to get LSP working for packaged files? Just some small changes to how position assertions work? |
@@ -899,7 +899,7 @@ def apply_montage(info, montage):
This function will replace the EEG channel names and locations with
the values specified for the particular montage.
- Note: You have to rename your object to correclty map
+ Note: You have to rename your object to correctly map
the montage na... | [_auto_topomap_coords->[_pol_to_cart,_cart_to_sph],make_grid_layout->[Layout],read_montage->[Montage],find_layout->[read_layout,make_eeg_layout],read_layout->[_read_lout,Layout,_read_lay],make_eeg_layout->[Layout],_pair_grad_sensors->[_find_topomap_coords]] | Apply the montage to the EEG data. | not true anymore actually |
@@ -14,8 +14,8 @@
* limitations under the License.
*/
-/** typedef {{name: string, value: ?(string|number)}} */
-let QueryParameterDef;
+/** @typedef {{name: string, value: (string|number|null)}} */
+export let QueryParameterDef;
/**
* Builds a URL from query parameters, truncating to a maximum length if
| [No CFG could be retrieved] | Builds a URL from the given base URL query parameters and maximum length. Get the last param in the query string. | oh, `?(string|number)` doesn't work? how about `(?string|?number)`? |
@@ -319,6 +319,12 @@ module Engine
# modify code which includes rand() w/o breaking existing games
return if removals.empty?
+ if @optional_rules.include?(:second_ed_co)
+ until (removals & ['Boomtown', 'Little Miami', 'C&O']).empty?
+ removals = group.sort_by { ... | [Game->[preprocess_little_miami->[little_miami_action?],postprocess_little_miami->[remove_icons,little_miami_action?],num_removals->[first_edition?],track_buying_power->[potential_minor_cash],train_buying_power->[potential_minor_cash],revenue_str->[east_west_bonus],check_special_tile_lay->[special_tile_lay?]]] | Removes an entity from a group. If the group does not contain the entity it will be. | why don't you just remove them and then sort and take? |
@@ -652,7 +652,8 @@ public class SaltUtils {
else if (action.getActionType().equals(ActionFactory.TYPE_DIST_UPGRADE)) {
DistUpgradeAction dupAction = (DistUpgradeAction) action;
DistUpgradeActionDetails actionDetails = dupAction.getDetails();
- if (actionDetails.isDryRun())... | [SaltUtils->[updateSystemInfo->[updateSystemInfo],createImagePackageFromSalt->[createImagePackageFromSalt,parsePackageEvr],prerequisiteIsCompleted->[prerequisiteIsCompleted],decodeSaltErr->[decodeStdMessage],applyChangesFromStateApply->[applyChangesFromStateModule],packageToKey->[packageToKey]]] | Updates the server action with the given parameters. Add the result of the action if it is not present in the result. This method is called from the server action API to determine if the action is a result of This method is called when the JSON result is received from the API. | Uhhh I think this is wrong. There is a reason why we do not revert the channels after a failed DUP. Reason: we do not know "when" it failed. In case the migration started already and you abort becuase of "disk full" or similar error, you have no chance to fix it and continue the migration. |
@@ -6,15 +6,13 @@ extern keymap_config_t keymap_config;
#define _QWERTY 0
#define _DVORAK 1
-#define _GAME 2
-#define _LEFTY 3
-#define _RIGHTY 4
-#define _DUAL 5
+#define _LEFTY 2
+#define _RIGHTY 3
+#define _DUAL 4
enum jj40_keycodes {
QWERTY = SAFE_RANGE,
DVORAK,
- GAME,
LEFTY,
RIGHTY,
DUAL,
| [No CFG could be retrieved] | Enumerates all the keycodes of the j40 action layer. \ Function to find the keys of the color picker. \ ~english Get the key mapping for a given key. | You should turn these layer defines into an enum so you don't have to keep renumbering them :) |
@@ -286,7 +286,6 @@ class Jetpack_Landing_Page extends Jetpack_Admin_Page {
'modules' => Jetpack::get_translated_modules( array_values( Jetpack_Admin::init()->get_modules() ) ),
'currentVersion' => JETPACK__VERSION,
'ajaxurl' => admin_url( 'admin-ajax.php' ),
- 'jumpstart_module... | [Jetpack_Landing_Page->[jumpstart_list_modules->[jumpstart_module_tag],page_render->[jumpstart_module_tag,jumpstart_list_modules,jetpack_show_jumpstart],page_admin_scripts->[jumpstart_module_tag,jetpack_show_jumpstart,build_jumpstart_stats_urls,build_nux_admin_stats_urls]]] | Enqueue Jetpack JS and localize it This function builds the urls for the Jetpack stats page. | Any plans to reinstate this functionality? |
@@ -25,6 +25,7 @@ type MeshConfigSpec struct {
type SidecarSpec struct {
EnablePrivilegedInitContainer bool `json:"enablePrivilegedInitContainer,omitempty" yaml:"enablePrivilegedInitContainer,omitempty"`
LogLevel string `json:"logLevel,omitempty" yaml:"logLevel,omitempty"`
+ EnvoyImage ... | [No CFG could be retrieved] | ObjectMeta is the metadata for an OSM s configuration. This is the spec for the TracingSpec. | You will need to run `make codegen` to update the `zz_generated.deepcopy.go` file as well |
@@ -203,6 +203,16 @@ def process_options(args: List[str],
strict_flag_names.append(flag)
strict_flag_assignments.append((dest, not default))
+ def disallow_any_argument_type(raw_options: str) -> List[str]:
+ current_options = raw_options.split(',')
+ for option in current_op... | [expand_dir->[expand_dir],process_options->[add_invertible_flag->[invert_flag_name],add_invertible_flag,SplitNamespace]] | Parse command line arguments and return a tuple of build sources and options. Check special cased code for a given node. Parse command line options and return a single node ID. Parse command line options and return a object. | Nit: strongly prefer list comprehensions to map (or filter) in Python. I'm also a fan of functional programming, but list comprehensions are considered more pythonic. |
@@ -127,7 +127,7 @@ class ChatOperations(object):
start_time=None, # type: Optional[datetime.datetime]
**kwargs # type: Any
):
- # type: (...) -> Iterable["_models.ChatThreadsInfoCollection"]
+ # type: (...) -> Iterable["_models.ChatThreadsItemCollection"]
"""Gets the lis... | [ChatOperations->[list_chat_threads->[get_next->[prepare_request]]]] | Gets the list of chat threads of a user. Get a single in the list of chat threads. Get a single node in the pipeline. | I'm not sure if this is a bug in autorest or swagger spec - but I think this should be returning an `Iterable["_models.ChatThreadItem"]`. It doesn't really matter in the generated code, so long as we've confirmed that the hand-written layer over the top is doing the right thing :) |
@@ -17,7 +17,6 @@ func readLine(reader processor.LineProcessor) (time.Time, string, int, error) {
// Full line read to be returned
if l.Bytes != 0 && err == nil {
- logp.Debug("harvester", "full line read")
return l.Ts, string(l.Content), l.Bytes, err
}
| [MatchString,Next,CompilePOSIX,Err,Debug] | readLine reads a full line into buffer and returns it. | I removed this line as it generated too much debu output. |
@@ -249,12 +249,12 @@ func (ls *Source) SearchEntry(name, passwd string, directBind bool) *SearchResul
var isAttributeSSHPublicKeySet = len(strings.TrimSpace(ls.AttributeSSHPublicKey)) > 0
- attribs := []string{ls.AttributeUsername, ls.AttributeName, ls.AttributeSurname, ls.AttributeMail}
+ attribs := []string{ls... | [SearchEntry->[sanitizedUserDN,sanitizedUserQuery,findUserDN],SearchEntries->[UsePagedSearch],findUserDN->[sanitizedUserQuery]] | SearchEntry searches for a user in the LDAP server. If directBind is true the user Finds the user s attributes and connects to the user. returns nil if no match. | Sorry I missed this earlier but if `ls.UserAttributeInGroup` is empty - does ldap tolerate the empty attribute? If it's empty I would guess that you should just not add it to the attribs to get. |
@@ -43,6 +43,8 @@ import (
"github.com/vmware/vic/pkg/trace"
"github.com/vmware/vic/pkg/uid"
"github.com/vmware/vic/pkg/version"
+
+ "github.com/vmware/govmomi/vim25/types"
)
const (
| [CreateHandler->[Create,Unix,Error,Begin,GenerateKey,GetBuild,Background,New,Now,UTC,End,WithPayload,String,Errorf,NewCreateOK,MarshalPKCS1PrivateKey,NewCreateNotFound,EncodeToMemory],GetContainerStatsHandler->[Begin,NewGetContainerStatsNotFound,Unsubscribe,NewEncoder,Background,End,NewOperation,WithPayload,Container,E... | Configure assigns functions to all of the portlayer handlers. ContainerRemoveHandlerFunc - Creates a handler for container remove events. | This import should belong in the group right above this line. |
@@ -106,7 +106,8 @@ public class ListAzureBlobStorage extends AbstractListProcessor<BlobInfo> {
attributes.put("azure.etag", entity.getEtag());
attributes.put("azure.primaryUri", entity.getPrimaryUri());
attributes.put("azure.secondaryUri", entity.getSecondaryUri());
- attributes.put("... | [ListAzureBlobStorage->[performListing->[getValue,getProperties,of,getLength,build,getLogger,add,getSnapshotQualifiedStorageUri,getRootCause,createCloudBlobClient,toString,getContainerReference,IOException,getSecondaryUri,blobType,length,secondaryUri,listBlobs],getDefaultTimePrecision->[getValue],customValidate->[valid... | Creates a map of the attributes of the given blob info. | I'm a bit worried about this change. It's going to change the value of a core attribute (filename) that could break the behavior of existing workflows. I'd rather user another attribute name if we still want to have an attribute for ``entity.getName()``. Thoughts? |
@@ -408,6 +408,18 @@ namespace PlatformAgnostic
{
return true;
}
+#ifdef NTBUILD
+ else
+ {
+ // did not find winGlobCharApi
+ Js::Throw::FatalInternalError();
+ ... | [No CFG could be retrieved] | Checks if the given string is in the windows. globalization. dll or jsint. | Why NTBUILD? This could also be gated on INTL_WINGLOB, which I think is a bit more specific, but then again this entire file (except for two functions) is gated on INTL_WINGLOB, so I think it can just be free-standing. |
@@ -65,13 +65,13 @@ class UserUpdater
user_profile.website = format_url(attributes.fetch(:website) { user_profile.website })
end
- if attributes[:profile_background_upload_url] == ""
+ if attributes[:profile_background_upload_url] == "" || !user.has_trust_level?(SiteSetting.min_trust_level_to_allow_... | [UserUpdater->[update_ignored_users->[empty?,pluck,now,exec,can_ignore_users?,reject,username,id,destroy_all],update->[fetch,new,transaction,custom_fields,has_key?,sso_overrides_location,profile_background_upload_id,log_name_change,map!,dismissed_banner_key,name,card_background_upload_id,sso_overrides_website,sso_overr... | Updates the user with the given attributes. finds a node in user s group and sets it as the next node in user s find nail - out user in user list. | These should be calls to the guardian methods. We want to keep the authorization logic in one place. |
@@ -26,9 +26,10 @@ type BlockingSender struct {
globals.Contextified
utils.DebugLabeler
- boxer *Boxer
- store *attachments.Store
- getRi func() chat1.RemoteInterface
+ boxer *Boxer
+ store *attachments.Store
+ getRi func() chat1.RemoteInterface
+ prevPagination *chat1.Pagination
}
... | [failMessage->[Error],doNotRetryFailure->[disconnectedTime,IsImmediateFail],Send->[Queue,Prepare,deleteAssets,presentUIItem],Prepare->[addSenderToMessage,addPrevPointersAndCheckConvID,Prepare,checkTopicNameAndGetState,getAllDeletedEdits],deliverLoop->[Send,failMessage,doNotRetryFailure,Error]] | Package functions for importing a block of messages from a block of messages. returns a messagePlaintext that has a valid ID. | Can we call this like `prevPtrPagination`, otherwise it is just kind of ambiguous. |
@@ -23,7 +23,7 @@ class StatefulContainer extends React.Component<
ContainerStateT,
> {
static defaultProps = {
- initialState: {value: null},
+ initialState: {value: null, time: null},
stateReducer: defaultStateReducer,
onChange: () => {},
};
| [No CFG could be retrieved] | Creates a class which implements the standardized interface. | Since we don't include time here in the `value` would it make sense to rename `value` to `date`? |
@@ -118,7 +118,7 @@ public class CreateActionTest {
}
private void logInAsQualityGateAdmin() {
- userSession.logIn().addOrganizationPermission(db.getDefaultOrganization().getUuid(), QUALITY_GATE_ADMIN);
+ userSession.logIn().addPermission(ADMINISTER_QUALITY_GATES, db.getDefaultOrganization().getUuid());
... | [CreateActionTest->[executeRequest->[setParam,parseFrom,IllegalStateException,getInputStream],logInAsQualityGateAdmin->[addOrganizationPermission,getUuid],throw_ForbiddenException_if_not_gate_administrator->[expectMessage,expect,logIn,executeRequest],create_quality_gate->[isNotNull,logInAsQualityGateAdmin,executeReques... | logInAsQualityGateAdmin This method logs in as a Quality Gate admin. | could use `userSession.logIn().addPermission(ADMINISTER_QUALITY_GATES, db.getDefaultOrganization());` |
@@ -31,6 +31,8 @@ public interface ImageStoreDao extends GenericDao<ImageStoreVO, Long> {
List<ImageStoreVO> findByScope(ZoneScope scope);
+ List<ImageStoreVO> findByScopeExcludingReadOnly(ZoneScope scope);
+
List<ImageStoreVO> findRegionImageStores();
List<ImageStoreVO> findImageCacheByScope(Zo... | [No CFG could be retrieved] | find all image stores in the system by scope. | this method name is confusing: `findByScope` but than the scope is allready set to `ZoneScope`? Wouldn't `findByZone` be better? Also the method above could probably just be extended with a flag for `excludeReadOnly`. |
@@ -49,9 +49,18 @@ public class Http2ServerInitializer extends ChannelInitializer<SocketChannel> {
};
private final SslContext sslCtx;
+ private final int maxHttpContentLength;
public Http2ServerInitializer(SslContext sslCtx) {
+ this(sslCtx, 16 * 1024);
+ }
+
+ public Http2ServerInit... | [Http2ServerInitializer->[configureSsl->[addLast,Http2OrHttpHandler,newHandler,alloc],newUpgradeCodec->[Http2ServerUpgradeCodec,HelloWorldHttp2Handler,equals],UserEventLogger->[userEventTriggered->[println,fireUserEventTriggered]],configureClearText->[channelRead0->[protocolVersion,fireChannelRead,println,HelloWorldHtt... | Initialize the channel. | shouldn't this be `<=` ? |
@@ -61,7 +61,7 @@ class TestAutotoolsPackage(object):
def activate(value):
return 'something'
- l = pkg.with_or_without('foo', active_parameters=activate)
+ l = pkg.with_or_without('foo', activation=activate)
assert '--with-bar=something' in l
assert '--without-ba... | [TestAutotoolsPackage->[test_with_or_without->[enable_or_disable,concretize,get,Spec,with_or_without]],test_cmake_std_args->[Spec,get,get_std_cmake_args,concretize],usefixtures] | Test with_or_without. | I'd prefer `options` or something more explanatory vs. `l`, in part because `l` looks like `1` (the number "one") to me |
@@ -1,14 +1,14 @@
module SessionTimeoutWarningHelper
def session_timeout_frequency
- (AppConfig.env.session_check_frequency || 150).to_i
+ IdentityConfig.store.session_check_frequency
end
def session_timeout_start
- (AppConfig.env.session_check_delay || 30).to_i
+ IdentityConfig.store.session_ch... | [time_left_in_session->[t,distance_of_time_in_words],session_timeout_start->[to_i],session_timeout_frequency->[to_i],timeout_refresh_path->[html_safe],session_timeout_warning->[to_i],session_modal->[new,user_fully_authenticated?]] | timeouts for session check. | This and `session_timeout_start` had their intended defaults switched I think? `application.yml.default` has a frequency of 30 and a delay of 150, which is the inverse of what it has here. Since these configurations were set in all environments, it should be safe to remove the fallback values in the class, even though ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.