patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -28,7 +28,11 @@ public final class ServiceContextFactory {
private ServiceContextFactory() {}
public static ServiceContext create(final KsqlConfig ksqlConfig) {
+ // Default to SERVER_CONTEXT if no kafka/SR clients are provided which means they will run
+ // under the KSQL kafka/SR credentials found in... | [ServiceContextFactory->[create->[KafkaTopicClientImpl,create,getKsqlAdminClientConfigProps,DefaultServiceContext,DefaultConnectClient,getString,emptyMap,getAdmin,DefaultKafkaClientSupplier,KsqlSchemaRegistryClientFactory]]] | Create a ServiceContext that can be used to create Kafka Kafka service context. | likewise, would the code be more readable with `createServer` and `createUser`? |
@@ -1196,7 +1196,11 @@ public /*transient*/ abstract class Computer extends Actionable implements Acces
// read
checkPermission(EXTENDED_READ);
rsp.setContentType("application/xml");
- Jenkins.XSTREAM2.toXMLUTF8(getNode(), rsp.getOutputStream());
+ Node node ... | [Computer->[getActions->[getActions],getACL->[getACL],isOnline->[isOffline],relocateOldLogs->[getName,relocateOldLogs],getMonitorData->[getName],setNode->[getNumExecutors],_doScript->[getChannel,getACL,_doScript],updateByXml->[replaceBy,checkPermission],remove->[remove],waitUntilOnline->[isOnline],waitUntilOffline->[is... | This method is called to update the node configuration in dot. xml. | This line should include "throw" |
@@ -516,14 +516,10 @@ void OPENSSL_cleanup(void)
err_cleanup();
/* Free list of global locks. */
- while (global_locks != NULL) {
- GLOBAL_LOCK *next = global_locks->next;
-
- free(global_locks);
- global_locks = next;
+ for (i = 0; i < CRYPTO_NUM_GLOCKS; i++) {
+ CRYPTO_TH... | [OPENSSL_thread_stop->[ossl_init_get_thread_local,ossl_init_thread_stop],OPENSSL_fork_parent->[unlock_all],thread_local_inits_st->[CRYPTO_THREAD_get_local,OPENSSL_zalloc,OPENSSL_free,CRYPTO_THREAD_set_local],OPENSSL_atexit->[GetModuleHandleEx,DSO_dsobyaddr,ERR_set_mark,DSO_free,OPENSSL_malloc,ERR_pop_to_mark],OPENSSL_f... | Private function for cleanup of all openssl - related resources. This function is called by the cleanup code when a node is removed from the store. It free all global locks. | This means anyone who calls `fork` after `OPENSSL_cleanup` will UAF since the `pthread_atfork` is still registered. |
@@ -871,7 +871,7 @@ Generator.prototype.copyTemplate = function (source, dest, action, _this, _opt,
jhipsterUtils.copyWebResource(source, dest, regex, 'html', _this, _opt, template);
break;
case 'stripJs' :
- var regex = '[a-zA-Z]+\:(\s)?\[[ \'a-zA-Z0-9\$\,\(\)\{\}\n\.\<\%\... | [No CFG could be retrieved] | Generate a date from a Gradle script. Copy templates with all the custom logic applied according to the type. | Won't this regex remove more than `translatePartialLoader` from the resolve block? |
@@ -202,9 +202,11 @@ public class PackageUtilTest {
@Test
public void testPackageUploadWithLargeClasspathLogsWarning() throws Exception {
- File tmpFile = makeFileWithContents("file.txt", "This is a test!");
- // all files will be present and cached so no upload needed.
- when(mockGcsUtil.fileSize(any(... | [PackageUtilTest->[testPackageUploadWithLargeClasspathLogsWarning->[makeFileWithContents],testPackageNamingWithFilesHavingSameContentsButDifferentNames->[makeFileWithContents],testStagingPreservesClasspath->[makeFileWithContents],testPackageUploadIsSkippedWhenFileAlreadyExists->[makeFileWithContents],testPackageUploadW... | This test package uploads with large classpath logs warning. | why the change? |
@@ -253,7 +253,7 @@ class SplitPdfJob < ApplicationJob
student_info_file = File.join(raw_dir, "#{grouping.id}_info.jpg")
student_info.write(student_info_file)
- python_exe = Settings.scanned_exams.python
+ python_exe = File.join(Settings.scanned_exams.bin, 'python')
read_chars... | [SplitPdfJob->[perform->[base_path,create,new,from_blob,decode,join,mkdir_p,rows,name,each_index,nil?,exists?,save_pages,quality,log,crop,pages,group_name_for,load,to_i,instance,find_or_create_by,filename,update,read,density,each,length,id,match,delete,write,raise,columns,total,increment,save],match_student->[find_by],... | save_pages saves the pages of a template that have a missing page number in the group add page if page_num already exists finds a in the assignment_folder that contains the extra_pdf cover_pdf find_n_complete Find n_complete . | I think this should be `Settings.python.bin` |
@@ -9,7 +9,7 @@ import java.util.Date;<% } %><% if (relationships.length > 0) { %>
import java.util.HashSet;
import java.util.Set;<% } %>
import java.util.Objects;<% if (databaseType == 'cassandra') { %>
-import java.util.UUID;<% } %><% if (fieldsContainBlob == true) { %>
+import java.util.UUID;<% } %><% if (fieldsC... | [No CFG could be retrieved] | DTO for a single object in the database. fieldValidate - Validate field. | @andidev are you ok with removing Lob for mongo and cassandra? if so ill merge this and amend condition to add only for SQL |
@@ -53,9 +53,10 @@ void AssignPressureIdProcess::AssignPressureIdToNodes(
)
{
// Loop over nodes of that submodel to assign prressure id
- for (auto it = mr_model_part.GetSubModelPart(rSubModelPartName).NodesBegin();
- it != mr_model_part.GetSubModelPart(rSubModelPartName).NodesEnd(); ++it) {
- (*i... | [AssignPressureIdToNodes->[,GetSubModelPart],Execute->[AssignPressureIdToNodes,submodel_parts_names,GetSubModelPartNames,size]] | This function assigns the pressure id to all nodes of a given submodel. | Move mrModelPart.GetSubModelPart(rSubModelPartName).NodesBegin() outside the loop, you are accesing to a databse all the time |
@@ -801,7 +801,6 @@ public final class ClusterConnectionImpl implements ClusterConnection, AfterConn
targetLocator.setInitialConnectAttempts(0);
targetLocator.setClientFailureCheckPeriod(clientFailureCheckPeriod);
targetLocator.setConnectionTTL(connectionTTL);
- targetLocator.setInitialConnect... | [ClusterConnectionImpl->[describe->[toString,getBridge],onConnection->[getLocalMember],disconnectRecord->[disconnectBindings],StaticClusterConnector->[toString->[toString],createServerLocator->[toString]],removeRecord->[close],removeClusterTopologyListener->[removeClusterTopologyListener],createNewRecord->[getNodeID,st... | Creates a new message flow record. create a new record and add it to the records list. | what is the outcome of this? faster ? fix a failure? or just to be correct? |
@@ -169,7 +169,7 @@ func (s *scheduler) poll() (map[string]configs.View, error) {
return nil, err
}
s.latestMutex.Lock()
- s.latestConfig = cfgs.GetLatestConfigID()
+ s.latestConfig = cfgs.GetLatestConfigID(configID)
s.latestMutex.Unlock()
return cfgs.Configs, nil
}
| [nextWorkItem->[Dequeue,Infof,Debugf],Stop->[Close,Debugf],workItemDone->[Defer,addWorkItem,Format,Debugf],poll->[TimeRequestHistogram,Unlock,Background,Warnf,Lock,GetLatestConfigID,GetConfigs],Defer->[Add],addNewConfigs->[Warnf,addWorkItem,RulesFromConfig,Set,Add,Debugf],addWorkItem->[Enqueue,Debugf],loadAllConfigs->[... | poll polls the configs server for new configs and returns a map of the new configs. | I don't like introducing this coupling between caller and callee. I think it might be simpler to surround the call with `if len(cfgs.Configs) > 0` |
@@ -57,7 +57,9 @@ public class UniformGranularitySpec implements GranularitySpec
if (inputIntervals != null) {
List<Interval> granularIntervals = Lists.newArrayList();
for (Interval inputInterval : inputIntervals) {
- Iterables.addAll(granularIntervals, this.segmentGranularity.getIterable(inpu... | [UniformGranularitySpec->[bucketIntervals->[bucketIntervals],hashCode->[hashCode],bucketInterval->[bucketInterval],equals->[equals]]] | Produces an UniformGranularitySpec for the given intervals. Returns an interval that represents the specified time - series bucket. | I am just wondering we can only trim the first and last interval? I guess there are only possible overlaps in the first and the last one because intervals returned from `segmentGranularity.getIterable()` are continous and made with `inputInterval`. Correct me if I am wrong. |
@@ -16,6 +16,7 @@ logger = logging.getLogger(__name__)
name_value_re = re.compile(r"([A-Za-z_]\w*)=(.*)")
shorthand_re = re.compile(r"([A-Za-z_]\w*)")
+interpolation_re = re.compile(r"^\$\{([A-Za-z_]{1,}[A-Za-z0-9]{0,})\}$")
class CompleteEnvironment(FrozenDict):
| [CompleteEnvironment->[get_subset->[check_and_set]],environment_subset->[Environment,get_subset]] | Creates a subset of the environment variables in the current process. Adds the variable name to the list of variable names that are allowed to be set. | I find it confusing that `${VAR}` is expanded but `$VAR` is not. Also, I would expect that `"embedded $VAR here"` to expand the `VAR` in the middle of the string. With that said, I'm not too sure that this is what we want here, or need. The `Pants` way to do it, is to add the required values as options on the tool used... |
@@ -343,6 +343,10 @@ module.exports = JhipsterServerGenerator.extend({
writing: {
+ cleanupOldServerFiles: function() {
+ cleanup.cleanupOldServerFiles(this, this.javaDir, this.testDir);
+ },
+
writeGlobalFiles: function () {
this.template('_README.md', 'README.md... | [No CFG could be retrieved] | The default configuration for the database. Missing database file. | The cleanup called by app/index.js cannot be used because this.javaDir is null. |
@@ -355,13 +355,13 @@ _ch_free(struct dfuse_projection_info *fs_handle, struct dfuse_cont *dfc)
rc = dfs_umount(dfc->dfs_ns);
if (rc != 0)
- DFUSE_TRA_ERROR(dfc, "dfs_umount() failed, "DF_RC,
- DP_RC(rc));
+ DFUSE_TRA_ERROR(dfc, "dfs_umount() failed");
rc = daos_cont_close(dfc->dfs_coh, NULL);
+ i... | [No CFG could be retrieved] | dfuse_cont is the last reference to the key in the table Get a connection to a pool by label. | DF_RC was wrong here, but do we not want to print the rc at all? |
@@ -200,7 +200,7 @@ public class HoodieMergeHandle<T extends HoodieRecordPayload, I, K, O> extends H
LOG.info("MaxMemoryPerPartitionMerge => " + memoryForMerge);
this.keyToNewRecords = new ExternalSpillableMap<>(memoryForMerge, config.getSpillableMapBasePath(),
new DefaultSizeEstimator(), new H... | [HoodieMergeHandle->[close->[writeRecord,close],write->[writeUpdateRecord],init->[initializeIncomingRecordsMap,needsUpdateLocation]]] | Initializes the incoming records map. | Do you wanna make change in HoodieMergedLogRecordScanner as well ? Or thats planned for a follow up PR |
@@ -145,8 +145,9 @@ def handle_secretreveal(
):
""" Validates and handles a ReceiveSecretReveal state change. """
valid_secret = state_change.secrethash == target_state.transfer.lock.secrethash
+ should_send_secret = target_state.state == 'secret_request'
- if valid_secret:
+ if valid_secret and s... | [events_for_close->[events_for_close],state_transition->[handle_unlock,handle_secretreveal,handle_block,handle_inittarget],handle_unlock->[handle_unlock],events_for_onchain_secretreveal->[events_for_onchain_secretreveal],handle_block->[events_for_onchain_secretreveal]] | Validates and handles a ReceiveSecretReveal state change. | Why is the condition necessary here? And from my understanding `waiting_for_secret` would be a better name for the variable!? |
@@ -1704,9 +1704,13 @@ dmu_tx_fini(void)
#if defined(_KERNEL) && defined(HAVE_SPL)
EXPORT_SYMBOL(dmu_tx_create);
EXPORT_SYMBOL(dmu_tx_hold_write);
+EXPORT_SYMBOL(dmu_tx_hold_write_by_dnode);
EXPORT_SYMBOL(dmu_tx_hold_free);
+EXPORT_SYMBOL(dmu_tx_hold_free_by_dnode);
EXPORT_SYMBOL(dmu_tx_hold_zap);
+EXPORT_SYMBOL(d... | [No CFG could be retrieved] | Dmi - Dmi - Dmi - Dmi fini. | There's no matching EXPORT_SYMBOL for `dmu_tx_hold_bonus_by_dnode()` even though it was added to `dmu.h`. Let's add one here. |
@@ -6,12 +6,14 @@ from pip._internal.req import InstallRequirement
from tests.lib import make_test_finder, path_to_url
-def make_project(tmpdir, requires=[], backend=None):
+def make_project(tmpdir, requires=[], backend=None, backend_path=[]):
project_dir = tmpdir / 'project'
project_dir.mkdir()
bui... | [test_pep517_install->[make_project],test_pep517_install_with_reqs->[make_project],test_backend->[make_project],test_explicit_setuptools_backend->[make_pyproject_with_setup],test_no_build_backend_entry->[make_pyproject_with_setup],test_pep517_backend_requirements_already_satisfied->[make_project],test_no_use_pep517_wit... | Create a project in tmpdir with optional build system. | I would use `None` here to avoid having to think about possible unexpected behavior with mutable defaults. |
@@ -275,9 +275,9 @@ class OSInfo(object):
def get_solaris_version_name(version):
if not version:
return None
- elif version.minor() == "5.10":
+ elif version.minor == "10":
return "Solaris 10"
- elif version.minor() == "5.11":
+ elif version.minor == "... | [OSInfo->[get_win_os_version->[_OSVERSIONINFOEXW]],cpu_count->[CpuProperties],CpuProperties->[get_cpus->[get_cpu_period,get_cpu_quota]]] | Get the name of the version of the system. | Shouldn't we keep the major just in case the "6" comes? |
@@ -16,7 +16,7 @@ import (
)
const (
- numWorkers = 50
+ numWorkers = 25
eventsBufferSize = 100
)
| [GetEventStats->[EventsSuccessful,EventsFailed,EventsProcessed]] | New creates a new Ingester object that imports the given object and creates a Run starts the worker loop that processes the given and sends it to the datastore. | this might be correct? I noticed that running the integration tests while all of A2 was running, I ran out of database connections... probably need to make it configurable eventually. |
@@ -184,6 +184,12 @@ class Masterbar {
// Override Notification module to include RTL styles.
add_action( 'a8c_wpcom_masterbar_enqueue_rtl_notification_styles', '__return_true' );
}
+
+ // Hides and replaces the language dropdown for the current user.
+ if ( IS_PROFILE_PAGE ) {
+ add_action( 'user_edit_f... | [Masterbar->[add_my_sites_submenu->[create_menu_item_pair,create_menu_item_anchor]]] | Initializes the admin bar Add actions to the WordPress admin_enqueue_scripts and add_styles_and_scripts. | `IS_PROFILE_PAGE` looks like it should only be true when you're editing your own profile: `define( 'IS_PROFILE_PAGE', ( $user_id == $current_user->ID ) );` But I'm still seeing this change when I edit another user's profile. |
@@ -43,15 +43,13 @@ var gauges = map[string]bool{
"filebeat.harvester.open_files": true,
"beat.memstats.memory_total": true,
"beat.memstats.memory_alloc": true,
+ "beat.memstats.rss": true,
"beat.memstats.gc_next": true,
"beat.info.uptime.ms": true,
"beat.cpu.user.t... | [logSnapshot->[Infow,String,Infof],snapshotLoop->[MakeFlatSnapshot,Stop,Infof,NewTicker,logSnapshot,logTotals],logTotals->[Infow,Since,Infof],Stop->[Wait],Done,MakeFlatSnapshot,Unpack,NewLogger,CollectFlatSnapshot,snapshotLoop,Now,Namespace,Reflect,Add,Put] | This function is used to identify the metrics that should not be reported as deltas. Private functions - functions - functions - functions. | These metrics don't exist so I moved them. There are `beat.cpu.*.time.ms` metrics, but I don't see a problem with those being reported as delta (I assume the cpu times only ever increase). |
@@ -87,6 +87,7 @@ public class KafkaTuningConfig implements TuningConfig, AppenderatorConfig
? DEFAULT_RESET_OFFSET_AUTOMATICALLY
: resetOffsetAutomatically;
this.segmentWriteOutMediumFactory = segmentWriteOutMediumFactory;
+ this.interme... | [KafkaTuningConfig->[copyOf->[KafkaTuningConfig],withBasePersistDirectory->[KafkaTuningConfig],equals->[equals]]] | Creates a new KafkaTuningConfig with a copy of the given config. | Does this mean that time-based intermediate handoff is effectively disabled if it is null? What do you think about disabling it explicitly if it's null? |
@@ -254,8 +254,9 @@ func (c *seriesStore) lookupSeriesByMetricNameMatchers(ctx context.Context, from
// Just get series for metric if there are no matchers
if len(matchers) == 0 {
+ level.Debug(log).Log("msg", "lookupSeriesByMetricNameMatchers: empty matcher")
indexLookupsPerQuery.Observe(1)
- series, err :=... | [Get->[Error],calculateIndexEntries->[Get],lookupLabelNamesByChunks->[Error],LabelNamesForMetricName->[Error],GetChunkRefs->[Error]] | lookupSeriesByMetricNameMatchers returns a slice of series that match the given matchers. This function is used to filter the series by matchers. It will only return the first 10. | probably unnecessary to redeclare `lookupSeriesByMetricNameMatchers` as a spanlogger with this name is created above |
@@ -38,6 +38,7 @@
#include "rgb_matrix_animations/rainbow_pinwheels_anim.h"
#include "rgb_matrix_animations/rainbow_moving_chevron_anim.h"
#include "rgb_matrix_animations/jellybean_raindrops_anim.h"
+#include "rgb_matrix_animations/typing_headmap_anim.h"
#include "rgb_matrix_animations/digital_rain_anim.h"
#includ... | [rgb_matrix_mode->[eeconfig_update_rgb_matrix],rgb_matrix_decrease_speed->[eeconfig_update_rgb_matrix],rgb_matrix_increase_val->[eeconfig_update_rgb_matrix],rgb_matrix_step_reverse->[eeconfig_update_rgb_matrix],rgb_matrix_decrease_hue->[eeconfig_update_rgb_matrix],rgb_matrix_increase_hue->[eeconfig_update_rgb_matrix],r... | This function is used to provide a list of all possible color - related objects in the G Creates a list of functions related to solid reactive wide and splash - wide impression. | Typo in filename |
@@ -251,6 +251,7 @@ tensor_method_func = [ #noqa
'round_',
'rsqrt',
'rsqrt_',
+ 'searchsorted',
'scale',
'scale_',
'sign',
| [No CFG could be retrieved] | This function is used to import the topk module and the module to import the search module This function is a function to convert a non - negative number into a non - negative number. | Why add this? Remove it. |
@@ -90,7 +90,6 @@ module Engine
@last_share_sold_price = action.bundle.price_per_share
super
@corporations_sold << action.bundle.corporation
- @round.recalculate_order
end
def needed_cash(_entity)
| [buy_train_action->[can_buy_train?,must_buy_train?],must_buy_train?->[must_buy_train?],ebuy_president_can_contribute?->[must_issue_before_ebuy?]] | Process a single miss in the sell shares. | This needs to be left |
@@ -85,11 +85,5 @@ func (s *Server) NewListenerDiscoveryResponse(proxy *envoy.Proxy) (*xds.Discover
return nil, err
}
resp.Resources = append(resp.Resources, marshalledInbound)
-
- s.lastVersion = s.lastVersion + 1
- s.lastNonce = string(time.Now().Nanosecond())
- resp.Nonce = s.lastNonce
- resp.VersionInfo = fm... | [NewListenerDiscoveryResponse->[Error,Infof,Sprintf,MarshalAny,GetAddress,GetCommonName,GetTransportSocketForServiceDownstream,Now,V,Errorf,Nanosecond]] | NewListenerDiscoveryResponse creates a new listener discovery response Construct a response for a single protocol. | Isn't it better to still have trace logs ? |
@@ -20,6 +20,10 @@
from apitools.base.py import extra_types
+_MAXINT64 = 2 << 63
+_MININT64 = -(2 << 63)
+
+
def get_typed_value_descriptor(obj):
"""Converts a basic type into a @type/value dictionary.
| [from_json_value->[from_json_value],to_json_value->[get_typed_value_descriptor,to_json_value]] | Converts a basic type into a value dictionary. | Max int64 is (1 << 63) -1, min int64 is -(1 << 63). |
@@ -275,7 +275,17 @@ class JaxbProcessor {
proxyDefinitions
.produce(new NativeImageProxyDefinitionBuildItem("com.sun.xml.txw2.TypedXmlWriter"));
- for (JaxbFileRootBuildItem i : fileRoots) {
+ List<JaxbFileRootBuildItem> jaxbFileBuildItemFromConfig = new ArrayList<>();
+ ... | [JaxbProcessor->[addReflectiveClass->[produce,ReflectiveClassBuildItem],handleJaxbFile->[trim,addReflectiveClass,getSuperclass,getName,RuntimeException,produce,forName,replace,readAllLines,substring,isEmpty,getContextClassLoader,NativeImageResourceBuildItem,startsWith],ignoreWarnings->[produce,ReflectiveHierarchyIgnore... | Process annotations and index files. This method builds the list of all available image proxy definitions. This method builds the list of all available proxy definitions. BuildItems for NativeImageProxyDefinition. | It would be better to produce the build steps in a separate build step. This way, you won't need to change anything there (and if at some point someone else wants to consume the build items, it will work OK). |
@@ -16,7 +16,7 @@ namespace System.Net.Http.Functional.Tests
protected virtual QuicImplementationProvider UseQuicImplementationProvider => null;
- public static bool IsMsQuicSupported => QuicImplementationProviders.MsQuic.IsSupported;
+ public static bool IsMsQuicSupported => PlatformDetectio... | [VersionHttpClientHandler->[SendAsync->[SendAsync]]] | Create a new HttpClientHandler. | Should `QuicImplementationProviders.MsQuic.IsSupported` be updated to handle the browser case? That way, if an app tries to use that API, then it would return `false` for them? |
@@ -950,7 +950,7 @@ namespace System.IO.Ports.Tests
Fail("ERROR!!!: Expected to read {0} chars actually read {1}", xmitCharBuffer.Length, numRead);
}
- if (encoding.EncodingName == Encoding.UTF7.EncodingName)
+ if (encoding.WebName == utf7WebName)
... | [Read_char_int_int->[VerifyRead->[VerifyRead],ASyncRead->[Read->[Read]]]] | Verify bytes followed by chars. Check if there is a key in the xmitByteBuffer and the rcvByteBuffer. If there. | I wonder if this branch is even hit since no one passes `UTF7Encoding` to `VerifyBytesFollowedByChars`. |
@@ -409,6 +409,7 @@ public class ConcurrentGrouper<KeyType> implements Grouper<KeyType>
{
if (!closed) {
closed = true;
+ threadLocalGrouper.remove();
groupers.forEach(Grouper::close);
}
}
| [ConcurrentGrouper->[init->[init],aggregate->[aggregate]]] | Closes the grouper if it is not already closed. | Is this going to solve the problem? If I understand correctly, `close()` will get called one time (by the thread that is reading aggregated values out of the ConcurrentGrouper) but none of those threads actually own a ThreadLocal Grouper (the threads that own those Groupers are processing-pool threads). |
@@ -204,7 +204,7 @@ public class YarnServiceTestWithExpiration {
Assert.assertEquals(this.expiredYarnService.getNumRequestedContainers(), 10);
try {
- Thread.sleep(20000);
+ Thread.sleep(60000);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
| [YarnServiceTestWithExpiration->[TestExpiredYarnService->[handleContainerCompletion->[handleContainerCompletion],newContainerLaunchContext->[newContainerLaunchContext]],setUp->[setEnv]]] | Test start error. | Usually it is not a good practice to use thread.sleep in the unit test if not necessary. (and 60 seconds is really long if you considering the number of unit tests we have). why is this needed ? is there any other way to achieve the same? There's a test utilities called `AssertWithBackoff` you might want to look into, ... |
@@ -251,8 +251,9 @@ public class StatsCollector extends ManagerBase implements ComponentMethodInterc
}
private void init(Map<String, String> configs) {
- _executor = Executors.newScheduledThreadPool(4, new NamedThreadFactory("StatsCollector"));
+ _executor = Executors.newScheduledThreadPool(6,... | [StatsCollector->[HostCollector->[runInContext->[doInTransactionWithoutResult->[],toString]],VmStatsCollector->[runInContext->[doInTransactionWithoutResult->[],toString]],init->[getInstance],AutoScaleMonitor->[getPairofCounternameAndDuration->[toString],runInContext->[doInTransactionWithoutResult->[],toString],getCount... | Initialize the statistics collector. Schedule VM and VM stats. next time in the next call. | `6` seems like a magic value. How was this value determined? |
@@ -9705,12 +9705,14 @@ def test_categories_query_with_filter(
name="Category1",
slug="slug_category1",
description=dummy_editorjs("Description cat1."),
+ description_plaintext="Description cat1.",
)
Category.objects.create(
id=2,
name="Category2",
... | [test_product_create_with_collections_webhook->[assert_product_has_collections]] | Test that query_categories_with_filter returns a list of categories with a specific filter. | Search uses ilike, so we shouldn't confirm that it will find a part of the text from description_plaintext? Like search `"Description cat1."` will also work for `description_plaintext="Sumpoer important Description cat1.",` |
@@ -173,6 +173,16 @@ func (e *LoginProvisionedDevice) run(ctx *Context) error {
func (e *LoginProvisionedDevice) unlockDeviceKeys(ctx *Context, me *libkb.User) error {
+ // CORE-5876 idea that lksec will be unusable if reachablity state is NO
+ // and the user changed passphrase with a different device since it wo... | [unlockDeviceKeys->[GetSecretKeyWithPrompt,G,SecretKeyPromptArg],Run->[GetUsername,G,run,HandleLogin,CallLoginHooks,Debug],run->[GetFullSelfer,GetDeviceID,LoggedInProvisionedCheck,HasDeviceInCurrentInstall,LoginWithPrompt,GetConfigWriter,GetConfig,GetUsername,Warning,IsNil,WithSelf,LoadUser,GetName,GetUserConfig,unlock... | unlockDeviceKeys unlocks device keys. | I would expect an error out here if not reachable, no? |
@@ -42,10 +42,10 @@ public class PagedOperationMessageProcessor extends OperationMessageProcessor {
}
@Override
- protected org.mule.runtime.api.message.MuleEvent doProcess(Event event, ExecutionContextAdapter operationContext)
+ protected Mono<Event> doProcess(Event event, ExecutionContextAdapter operationCo... | [PagedOperationMessageProcessor->[doProcess->[doProcess]]] | Override doProcess to obtain a paging delegate for the event. | This throws exeption too |
@@ -70,7 +70,11 @@ class Jetpack_Plugins {
$result = $upgrader->install( $zip_url );
+ // Will use ->stat() for recording success/fails.
+ $jetpack = Jetpack::init();
+
if ( is_wp_error( $result ) ) {
+ $jetpack->stat( 'install-plugin', "fail-$slug" );
return $result;
}
| [Jetpack_Plugins->[install_plugin->[install,get_main_error_code,get_main_error_message,get_upgrade_messages]]] | Installs a plugin. | Instead of calling the Jetpack class here, would it be an option to rely on the MC Stats package directly? This may make things easier if we eventually want to put this Jetpack_Plugins lib into a package. |
@@ -42,7 +42,7 @@ func (consensus *Consensus) constructPreparedMessage() ([]byte, *bls.Sign) {
}
consensusMsg := message.GetConsensus()
- consensus.populateMessageFields(consensusMsg)
+ consensus.populateMessageFields(consensusMsg, consensus.LeaderPubKey)
// add block content in prepared message for slow valida... | [constructPreparedMessage->[NewBuffer,Write,GetConsensus,Msg,Error,ReadAllSignatures,Serialize,ConstructConsensusMessage,populateMessageFields,Err,Bytes,signAndMarshalConsensusMessage,AggregateSig,Logger],constructCommittedMessage->[NewBuffer,Write,GetConsensus,Msg,Error,ReadAllSignatures,Serialize,ConstructConsensusMe... | constructPreparedMessage creates a prepared message from the consensus message. | Why put as a separate field. Isn't populateMessageFields already have access to consensus.LeaderPubKey? |
@@ -10,3 +10,6 @@ export {
Label as StyledLabel,
Input as StyledInput,
} from './styled-components';
+
+// Types
+export * from './types';
| [No CFG could be retrieved] | A component that is a styled label. | This probably should be in another PR |
@@ -152,7 +152,7 @@ function rrdtool_graph($graph_file, $options)
function rrdtool($command, $filename, $options, $timeout = 0)
{
global $config, $debug, $rrd_pipes, $console_color;
-
+
// do not ovewrite files when creating
if ($command == 'create') {
$options .= ' -O';
| [rrdtool->[convert]] | rrdtool executes a rrd command and returns the output if successful. Get the contents of the file. | Can you remove these spaces on the empty line? |
@@ -42,7 +42,7 @@ class Dealii(CMakePackage):
version('8.3.0', 'fc6cdcb16309ef4bea338a4f014de6fa')
version('8.2.1', '71c728dbec14f371297cd405776ccf08')
version('8.1.0', 'aa8fadc2ce5eb674f44f997461bf668d')
- version('develop', git='https://github.com/dealii/dealii.git')
+ version('develop', git='htt... | [Dealii->[variants_check->[RuntimeError],setup_environment->[set],cmake_args->[join_path,variants_check,upper,satisfies,joined,extend,isdir],variant,depends_on,version]] | Package containing C ++ software providing well - documented tools to build finite element codes. Reads all possible dependencies of a package. | why did you need this change? It should (and it does as far as I know) checkout `master` branch by default. |
@@ -1206,6 +1206,7 @@ namespace Dynamo.ViewModels
this.ExecuteCommand(new DynamoModel.CreateCustomNodeCommand(Guid.NewGuid(),
args.Name, args.Category, args.Description, true));
}
+ this.ShowStartPage = false;
}
private bool CanShowNewFun... | [DynamoViewModel->[CanZoomOut->[CanZoomOut],SaveAs->[SaveAs],PublishNewPackage->[PublishNewPackage],ExportToSTL->[ExportToSTL],ShowOpenDialogAndOpenResult->[Open,CanOpen],ShowSaveDialogIfNeededAndSave->[SaveAs,Save],ImportLibrary->[ImportLibrary],CanPublishNewPackage->[CanPublishNewPackage],ClearLog->[ClearLog],Escape-... | Show new function dialog and make function. | Wrong place, it should be inside `if (args.Success)`, that's the whole idea of putting it here, if user chooses not to proceed with creating a custom node. Putting it here makes no difference at all. |
@@ -1025,7 +1025,7 @@ function baseInputType(scope, element, attr, ctrl, $sniffer, $browser) {
// command modifiers arrows
if (key === 91 || (15 < key && key < 19) || (37 <= key && key <= 40)) return;
- deferListener(event);
+ deferListener(event, this, this.val... | [No CFG could be retrieved] | On input type is password the value is never trimmed. function to check if a date is in the format yyyy - mm - dd. | Can we use this here? We are in an event handler. The unit tests do not appear call this line. |
@@ -60,6 +60,7 @@
#include <string.h>
#include <openssl/crypto.h>
+extern unsigned char cleanse_ctr;
unsigned char cleanse_ctr = 0;
void OPENSSL_cleanse(void *ptr, size_t len)
| [OPENSSL_cleanse->[memchr]] | OpenSSL cleanse. | I don't understand why would that be needed. And I can't reproduce problem with compilers I have... Which one is complaining and what about? |
@@ -781,12 +781,9 @@ def test_apply_mne_inverse_fixed_raw():
assert_array_almost_equal(stc.data, stc3.data)
-@testing.requires_testing_data
-def test_apply_mne_inverse_epochs():
- """Test MNE with precomputed inverse operator on Epochs."""
- inverse_operator = read_inverse_operator(fname_full)
- label... | [test_apply_inverse_operator->[read_forward_solution_meg],test_make_inverse_operator_loose->[_compare_inverses_approx,read_forward_solution_meg,_compare_io],_compare_io->[_compare],test_make_inverse_operator_free->[_compare_inverses_approx,read_forward_solution_meg],test_make_inverse_operator_fixed->[_compare_inverses_... | Test MNE with precomputed inverse operator on Epochs. Test if a BiHemiLabel is found. Return the data of the label_stc. | you should add scope to avoid recompute it every time. |
@@ -112,10 +112,6 @@ func (storage *Storage) Dump(block *types.Block, height uint64) {
// Store txs
for _, tx := range block.Transactions() {
- if tx.To() == nil {
- continue
- }
-
explorerTransaction := GetTransaction(tx, block)
storage.UpdateTXStorage(batch, explorerTransaction, tx)
storage.UpdateA... | [Init->[RemoveAll,Msg,Error,NewLDBDatabase,Err,Logger],UpdateAddress->[UpdateAddressStorage],Dump->[Write,Itoa,Msg,Error,Warn,EncodeToBytes,NewBatch,Uint64,Transactions,UpdateAddress,UpdateTXStorage,To,Info,Err,Logger,GetLogger,Put],DumpCommittee->[NewBatch,Write,EncodeToBytes,Put],UpdateAddressStorage->[Msg,Error,Enco... | Dump dumps a block to the database. | can you explain why remove To? |
@@ -568,7 +568,15 @@ class ASTConverter:
metaclass=dict(keywords).get('metaclass'),
keywords=keywords)
cdef.decorators = self.translate_expr_list(n.decorator_list)
- self.set_line(cdef, n)
+ if n.decorator_list and sys.version_info >= (3, 8):
+ ... | [parse_type_string->[parse_type_comment],parse_type_comment->[parse],stringify_name->[stringify_name],TypeConverter->[visit_UnaryOp->[invalid_type,visit],visit_Str->[parse_type_string],visit_Attribute->[invalid_type,visit],_extract_argument_name->[fail],visit_Subscript->[invalid_type,visit,translate_expr_list,fail],tra... | Visit ClassDef node and create ClassDef node and return it. | Is it needed for tests? I think it would be more natural to show class related errors on the line where `class` appears. |
@@ -2902,7 +2902,8 @@ function PMA_getHtmlForInsertEditRow($url_params, $table_columns,
} // end for
$o_rows++;
$html_output .= ' </tbody>'
- . '</table><br />';
+ . '</table><br />'
+ . '</div>';
return $html_output;
}
| [PMA_analyzeWhereClauses->[fetchAssoc,query],PMA_transformEditedValues->[applyTransformation],PMA_verifyWhetherValueCanBeTruncatedAndAppendExtraData->[tryQuery,fetchValue,getFieldsMeta],PMA_setSessionForEditNext->[query,getFieldsMeta,fetchRow],PMA_showEmptyResultMessageOrSetUniqueCondition->[addHtml,getFieldsMeta],PMA_... | PMA_getHtmlForInsertEditRow - returns HTML output of an insert edit row. | I think add a clear fix element <code><div class="clearfloat"></div></code> after floating elements is better than add a container. |
@@ -27,7 +27,13 @@ class BagVariant(ProductVariant, StockedProduct):
class Meta:
app_label = 'product'
+ def __str__(self):
+ return '{} {} (color {})'.format(self.product,
+ self.name,
+ self.product.color.name)
... | [ShirtVariant->[ForeignKey,pgettext_lazy,CharField],BagVariant->[ForeignKey]] | Create a base class for all product - specific variants. | This needs gettext support. Interpolation is inconsistent as other places use `%` operator. |
@@ -16,7 +16,13 @@ class ListingDetail extends Component {
return (
<div className="listing-detail">
- <div className="category">{listing.categoryStr}</div>
+ <div className="header">
+ <div className="category">{listing.categoryStr}</div>
+ <ListingBadge
+ statu... | [No CFG could be retrieved] | A component that displays a single unique identifier in a table. Displays a menu item with a single national item. | I'd prefer to abstract this `header` wrapper with the category and badge into its own component (instead of `_ListingBadge`). Is it something you'd be OK with, or are there any dragons I'm not aware of? |
@@ -353,12 +353,15 @@ public class IndexTask extends AbstractFixedIntervalTask
final FireDepartmentMetrics metrics = new FireDepartmentMetrics();
final Firehose firehose = firehoseFactory.connect(ingestionSchema.getDataSchema().getParser());
final Supplier<Committer> committerSupplier = Committers.suppli... | [IndexTask->[generateSegment->[push->[push],getPathForHadoop->[getPathForHadoop],convertTuningConfig,shouldIndex],makeId,makeDataSource,makeInterval]] | Generate a new segment. This method is called when a new segment is pushed to the partition. | this will throw an NPE if getBuildV9Directly returns null |
@@ -132,6 +132,18 @@ class PipelineTest(unittest.TestCase):
assert_that(pcoll, equal_to([[1, 2, 3]]))
pipeline.run()
+ @attr('ValidatesRunner')
+ def test_metrics_in_source(self):
+ pipeline = TestPipeline()
+ pcoll = pipeline | 'read' >> Read(FakeSource([1, 2, 3, 4, 5, 6]))
+ assert_that(pcoll, ... | [FakeSource->[reader->[_Reader]],PipelineTest->[test_reuse_custom_transform_instance->[CustomTransform],test_transform_no_super_init->[AddSuffix],test_apply_custom_transform->[CustomTransform],test_reuse_cloned_custom_transform_instance->[CustomTransform],test_read->[FakeSource],test_visit_entire_graph->[Visitor,Custom... | Create a singleton PCollection with test pipeline. | Could you remove the `read` label? I do not think we should label transforms with the transform name. |
@@ -135,7 +135,7 @@ export function parseUrl(url, opt_nocache) {
* @param {boolean=} opt_addToFront
* @return {string}
*/
-function appendParamStringToUrl(url, paramString, opt_addToFront) {
+export function appendParamStringToUrl(url, paramString, opt_addToFront) {
if (!paramString) {
return url;
}
| [No CFG could be retrieved] | Append a param string to the end of the URL. Appends the given key and value to the given url. The params objects key and value will. | I have relatively big concerns about exposing this method given potential for XSS. At the very least, if we want to do this, could you please massage the naming to something like: - append**Encoded**ParamStringToUrl - **encoded**ParamString ? |
@@ -129,6 +129,8 @@ class Analytics
ADD_EMAIL_CONFIRMATION_RESEND = 'Add Email: Email Confirmation requested due to invalid token'.freeze
ADD_EMAIL_VISIT = 'Add Email: enter email visited'.freeze
AUTHENTICATION_CONFIRMATION = 'Authentication Confirmation'.freeze
+ AUTHENTICATION_CONFIRMATION_CONTINUE = 'Authe... | [Analytics->[track_mfa_submit_event->[track_event]]] | Get a list of all the browser - specific information. Get the list of all the messages that are in the IDV. | Can we check that these events are logged somewhere in specs (e.g. feature specs for this flow)? |
@@ -739,15 +739,9 @@ static int WaitForIncoming(int sd)
{
/* skip */
}
- /* If we had data on the signal pipe but not the listening socket,
- * report no in-coming sockets. */
- if (result > 0 && (sd < 0 || !FD_ISSET(sd, &rset)))
- {
- return 0;
- }
- /* Return 0 in case o... | [No CFG could be retrieved] | Waits for an incoming . Check for changes in file changes and handle a connection if it s available. | The function doesn't return a bool. I don't see that this corresponds to the return values described above the function. |
@@ -205,8 +205,8 @@ if ($action == 'create') {
// Ref
print "<tr>";
- print '<td width="20%">' . $langs->trans("Ref") . '</td><td>';
- print $object->rowid;
+ print '<td width="25%">' . $langs->trans("Ref") . '</td><td>';
+ print $object->ref;
print '</td></tr>';
// Label
| [fetch,transnoentitiesnoconv,create,editfieldkey,rollback,getLibStatut,formconfirm,trans,update,editfieldval,begin,close,selectarray,commit,select_date,load,delete] | Dol Fiche - Form Print a list of calendar component elements. | With 4.0, it is recommended now to use hier print '<td class="titlefield" or print '<td class="titlefieldcreate" for create or edit form |
@@ -273,7 +273,7 @@ static int ssp_set_config_tplg(struct dai *dai, struct ipc_config_dai *common_co
if (ssp->state[DAI_DIR_PLAYBACK] > COMP_STATE_READY ||
ssp->state[DAI_DIR_CAPTURE] > COMP_STATE_READY) {
dai_info(dai, "ssp_set_config(): Already configured. Ignore config");
- goto out;
+ goto clk;
}
... | [void->[SSCR3_RFL_VAL,dai_base,ssp_mclk_disable_unprepare,ssp_update_bits,mn_release_bclk,wait_delay,dai_dbg,spin_lock,spin_unlock,poll_for_register_delay,dai_get_drvdata,ssp_empty_rx_fifo,dai_info,ssp_pre_start,clock_ms_to_ticks,ssp_post_stop,clock_ticks_per_sample,dai_warn,ssp_bclk_disable_unprepare,mn_release_mclk,s... | This function is used to configure the SSP using the template configuration. read - write write of network configuration set the configuration of a node read all configuration of a node in the system set the configuration of a single channel set the configuration parameters for the SSP set the configuration parameters ... | sorry, this doesn't look right to me. When the SSP is already configured, you absolutely do not want to reconfigure it *again* and specifically touch the SSE bits. Maybe I am missing something but the sequence and explanations are not quite right. |
@@ -156,10 +156,12 @@ class Social_Templates_Integration implements Integration_Interface {
$image_url_field_id = 'social-image-url-' . $identifier;
$image_id_field_id = 'social-image-id-' . $identifier;
$is_premium = YoastSEO()->helpers->product->is_premium();
+ $is_premium_16_5 = defined( '\WPSE... | [Social_Templates_Integration->[social_date_archives->[determine_for_archive,build_social_fields],build_social_fields->[hidden,render,is_premium],social_post_type->[build_social_fields,determine_for_post_type],social_author_archives->[determine_for_archive,build_social_fields],social_post_types_archive->[determine_for_... | Builds the social fields. Displays a hidden hidden section of the Yoast social settings page. Print a message for the user that is not already escaped correctly. | I think this name is a bit misleading. Not only 16.5 is fine, but everything above that as well. Suggestion: `is_premium_16_5_or_up`. (but I'm open to other suggestions. I was also thinking about something like `is_correct_premium_version`) |
@@ -98,6 +98,14 @@ def api_method(f):
old_curdir = os.getcwd()
except EnvironmentError:
old_curdir = None
+
+ if api.quiet:
+ old_stdout = sys.stdout
+ old_stderr = sys.stderr
+ devnull = open(os.devnull, 'w')
+ sys.stdout = devnull
+... | [ConanApp->[load_remotes->[load_remotes]],ConanAPIV2->[get_active_remotes->[load_remotes],get_package_ids->[get_package_ids],create_app->[ConanApp],get_recipe_revisions->[_get_revisions],get_package_revisions->[_get_revisions],search_local_recipes->[load_remotes,search_local_recipes],search_remote_recipes->[load_remote... | Useful decorator to manage Conan API methods. | Not sure if the "quiet" should be managed here or in the logger layers. |
@@ -0,0 +1,5 @@
+require 'rails_helper'
+
+RSpec.describe AssignmentProperties, type: :model do
+ pending "add some examples to (or delete) #{__FILE__}"
+end
| [No CFG could be retrieved] | No Summary Found. | Delete this file. |
@@ -479,6 +479,14 @@ public class DoFnSignatures {
return signature;
}
+ private static Class<?> getDeclaringClass(Method onTimerMethod) {
+ Class<?> declaringClass = onTimerMethod.getDeclaringClass();
+ if (declaringClass.getName().contains("$MockitoMock$")) {
+ declaringClass = declaringClass.ge... | [DoFnSignatures->[getStateSpecOrThrow->[format],analyzeProcessElementMethod->[of,addParameter,getExtraParameters,create,setParameter,getWindowType,hasRestrictionTrackerParameter],analyzeStateDeclarations->[create,of,declaredFieldsWithAnnotation,getType],analyzeExtraParameter->[of,getAnnotations,hasPipelineOptionsParamt... | Parses the signature of a DoFn. Private method to find all timers that are annotated with DoFn. This method is called to populate the signatureBuilder with the errors from the methods that do not Returns a DoFnSignature object that can be used to construct a DoFn object. | This is now needed? It seems very gross to pollute the main code with mockito stuff. Ideally we'd just fix the test to not use mockito. If this is just a recommended quick fix, that might be OK but file a Jira please to resolve it. |
@@ -44,6 +44,8 @@ https://arxiv.org/abs/1802.05365
The batch size to use.
--cuda-device CUDA_DEVICE
The cuda_device to run on.
+ --use-sentence-keys USE_SENTENCE_KEYS
+ Whether to use line numbers or sentence keys as ids.
... | [ElmoEmbedder->[embed_batch->[batch_to_embeddings,empty_embedding],embed_sentences->[embed_batch],embed_file->[embed_sentences]],elmo_command->[ElmoEmbedder,embed_file]] | \ brief \ This module provides a simple interface to the allennlp elmo command This function returns an Elmo object with the specified options and weights. | I find this "sentence keys as ids" wording confusing, I might have said something like "Normally a sentence's line number is used as the HDF5 key for its embedding. If this flag is specified, the sentence itself will be used as the key." |
@@ -544,6 +544,11 @@ func (bc *BlockChain) repair(head **types.Block) error {
Msg("Rewound blockchain to past state")
return nil
}
+ // Repair last commit sigs
+ lastSig := (*head).Header().LastCommitSignature()
+ sigAndBitMap := append(lastSig[:], (*head).Header().LastCommitBitmap()...)
+ bc.WriteLastC... | [AddPendingCrossLinks->[WritePendingCrossLinks,ReadPendingCrossLinks],updateCXReceiptsCheckpoints->[NextCXReceiptsCheckpoint],IsSameLeaderAsPreviousBlock->[GetHeaderByNumber],SuperCommitteeForNextEpoch->[ShardID,CurrentHeader,Config],ValidatorCandidates->[ReadValidatorList],ReadValidatorStats->[ReadValidatorStats],Read... | repair rewrites the head block to the previous block in the chain. | any reason of doing this? |
@@ -23,7 +23,6 @@ from pulp.server.managers import factory
from pulp.server.managers.consumer.cud import ConsumerManager
from pulp.server.managers.consumer.profile import ProfileManager
from pulp.devel import mock_plugins
-from pulp.devel import mock_agent
class ProfileManagerTests(base.PulpServerTests):
| [ProfileManagerTests->[test_multiple_types->[populate],test_delete->[populate],test_get_profile->[populate],test_consumer_unregister_cleanup->[test_create],test_fetch_by_type2->[populate],test_create->[populate],test_fetch_by_type1->[populate],test_update_with_content_type_without_profiler->[populate],test_get_profile_... | Creates a new object with the necessary setup and teardown. This is a method that is called when the application is tear down. | Gofer 1.0 porting: the changes below are the result of getting rid of the mock_agent and just using python-mock. |
@@ -81,11 +81,17 @@ public class PluginWSCommons {
public static final Comparator<PluginUpdate> NAME_KEY_PLUGIN_UPDATE_ORDERING = Ordering.from(NAME_KEY_PLUGIN_ORDERING)
.onResultOf(PluginUpdateToPlugin.INSTANCE);
- void writePluginInfo(JsonWriter json, PluginInfo pluginInfo, @Nullable String category) {
+ ... | [PluginWSCommons->[writePluginInfoList->[writePluginInfo],compatiblePluginsByKey->[compatiblePlugins],writePluginUpdate->[writePlugin]]] | Writes the plugin info to the given JSON writer. | In which case `pluginDto` is null ? That would mean that the plugin has not been registered in db. I suggest to fail-fast in the caller of this method. |
@@ -14,13 +14,7 @@ class RepoSync(View):
@auth_required(EXECUTE)
def post(self, request, repo_id):
-
- # Params
- try:
- params = json.loads(request.body)
- except ValueError:
- params = {}
- overrides = params.get('override_config', None)
+ overrides... | [RepoSync->[post->[OperationPostponed,repo_query_manager,get,resource_tag,apply_async_with_reservation,action_tag,loads],auth_required]] | Syncs the missing resource tag with the repository. | json is no longer used and can be removed from imports. |
@@ -86,9 +86,17 @@ public class SimulatorStorageProcessor implements StorageProcessor {
@Override
public Answer cloneVolumeFromBaseTemplate(CopyCommand cmd) {
+ long size = 100;
+ DataTO dataTO = cmd.getDestTO();
+ if (dataTO instanceof VolumeObjectTO) {
+ VolumeObjectTO dest... | [SimulatorStorageProcessor->[createVolumeFromSnapshot->[getSrcTO,substring,lastIndexOf,VolumeObjectTO,setPath,CopyCmdAnswer,getPath],createTemplateFromSnapshot->[getDataStore,getName,setPath,toString,setFormat,getDestTO,CopyCmdAnswer],dettachVolume->[DettachAnswer,getDisk],createVolume->[getName,getData,CreateObjectAns... | Clone a volume from base template to primary. | magic number. Can be moved to a constant. Why is size defaulted to 100? |
@@ -1,4 +1,7 @@
from ...graphql.core.enums import to_enum
-from ...shipping import ShippingMethodType
+from ...shipping import PostalCodeRuleInclusionType, ShippingMethodType
ShippingMethodTypeEnum = to_enum(ShippingMethodType, type_name="ShippingMethodTypeEnum")
+PostalCodeRuleInclusionTypeEnum = to_enum(
+ Pos... | [to_enum] | Get a list of all the elements of a node that have a type that can be used. | We want to unify existing enum names to not use the redundant word "enum" in the names. @d-wysocki How should we call this one according to new rules? |
@@ -21,6 +21,7 @@ from .dataset import *
from .data_generator import MultiSlotDataGenerator, MultiSlotStringDataGenerator
from . import metrics
from .base.topology import CommunicateTopology, HybridCommunicateGroup
+from .mpu import random, layers
__all__ = [
"DistributedStrategy", "UtilBase", "UserDefinedRo... | [Fleet,UtilBase] | Creates a new object of type n_unique. Get info about the object that is not a worker. | why import these two files? |
@@ -100,8 +100,8 @@ public class RemoveAction implements NotificationsWsAction {
" <li>Global notifications: %s</li>" +
" <li>Per project notifications: %s</li>" +
"</ul>",
- globalDispatchers.stream().sorted().collect(Collectors.joining(", ")),
- projectDispatchers.stream().s... | [RemoveAction->[getUser->[getLogin,checkFound,selectByLogin],checkPermissions->[checkIsSystemAdministrator,getLogin,checkLoggedIn],toWsRequest->[checkRequest,param,mandatoryParam,setNullable,getType,setChannel,contains,getProject],remove->[getUser,remove,getChannel,checkPermissions,orElse,getType,openSession,commit,sea... | Define the missing key action. | minor: I'd rename to `getGlobalDispatchers()` |
@@ -112,9 +112,12 @@ func (mod *modContext) tokenToModName(tok string) string {
return modName
}
-func (mod *modContext) tokenToType(tok string, input bool) string {
+func (mod *modContext) tokenToType(tok string, input, enum bool) string {
modName, name := mod.tokenToModName(tok), tokenToName(tok)
+ if enum {... | [genResource->[getConstValue,genAlias,getDefaultValue,genPlainType,typeString],genTypes->[genHeader,sdkImports,getImports],genType->[details,genPlainType],gen->[genResource,genTypes,sdkImports,genFunction,isReservedSourceFileName,getImports,genHeader,add,genConfig],genFunction->[genPlainType],getTypeImports->[getTypeIm... | tokenToModName converts a token to a module name. | Do we need to emit enums into their own namespace, or can they live in the same namespace as resources? |
@@ -338,7 +338,8 @@ def test_load_generator(fname, recwarn):
[0, 1], id='int list')])
def test_edf_stim_ch_pick_up(test_input, EXPECTED):
"""Test stim_channel."""
- TYPE_LUT = {v[0]: k for k, v in _KIND_DICT.items()}
+ # This is fragile for EEG/EEG-CSD, so just omit csd
+ TYPE_LUT = {v[... | [test_load_generator->[events_from_annotations,splitext,assert_array_equal,get_data,channel_indices_by_type,len,read_raw_bdf,read_raw_edf],test_bdf_data->[assert_array_almost_equal,,len,repr,loadmat,_test_raw_reader,pick_types],_assert_annotations_equal->[assert_array_equal],test_read_raw_edf_stim_channel_input_paramet... | Test EDF file for stim_ch pick up. | why do you need to change anything here? |
@@ -87,7 +87,7 @@ class DataflowRunner(PipelineRunner):
return 's%s' % self._unique_step_id
@staticmethod
- def poll_for_job_completion(runner, result):
+ def poll_for_job_completion(runner, result, duration):
"""Polls for the specified job to finish running (successfully or not)."""
last_message_... | [DataflowRunner->[_get_encoded_output_coder->[_get_typehint_based_encoding],flatten_input_visitor->[FlattenInputVisitor],_add_singleton_step->[_get_side_input_encoding],run_Flatten->[_get_encoded_output_coder,_add_step],run_Impulse->[_get_encoded_output_coder,_add_step],apply_GroupByKey->[_get_coder],poll_for_job_compl... | Polls for the specified job to finish running. Get all messages since the beginning of the job run or since the last message. | <!--new_thread; commit:5b7323ad9e10a5693ea41a239c8a675139b977de; resolved:0--> Can you please add argument docstrings? It is unclear from a first read what should be passed to `duration`, especially given that on line 112, there is an `if condition` branch. Do we want to make this an optional kwarg? |
@@ -83,13 +83,13 @@ func TestAll(t *testing.T) {
config.Suffix = "json"
}
- getTestdataFiles(t, config.URL, moduleName, metricSetName, config.Suffix)
+ getTestdataFiles(t, moduleName, metricSetName, config)
}
}
-func getTestdataFiles(t *testing.T, url, module, metricSet, suffix string) {
+func getTestda... | [LoadFields,Hash,HandlerFunc,ReportingFetchV2Error,Close,MarshalIndent,NewMetricSet,Encode,Set,WriteFile,Put,StandardizeEvent,ReadFile,NewReportingMetricSetV2,ReportingFetchV2,Bool,HasSuffix,SliceStable,Join,Equal,GetKeys,Fatalf,NewReportingMetricSetV2Error,Split,Query,Printf,Header,Write,NewServer,GetFields,Unmarshal,... | Get the config object for the given object. Starts a server serving the given file under the given url. | +1 on refactoring this to just pass the config. |
@@ -311,9 +311,7 @@ module Engine
check_special_tile_lay(action)
- @corporations.dup.each do |corporation|
- close_corporation(corporation) if corporation.share_price&.price&.zero?
- end
+ super
@last_action = action
end
| [G1846->[revenue_str->[east_west_bonus],event_close_companies!->[close_corporation],check_special_tile_lay->[special_tile_lay?]]] | Check if action has a and if so add it to the bank if it has. | why is this calling super |
@@ -329,7 +329,7 @@ def safe_delete(filename):
raise
-def safe_concurrent_rename(src, dst):
+def safe_concurrent_rename(src, dst, recursive=False):
"""Rename src to dst, ignoring errors due to dst already existing.
Useful when concurrent processes may attempt to create dst, and it doesn't matter who ... | [relativize_paths->[relativize_path],mergetree->[ExistingDirError,ExistingFileError,safe_mkdir,safe_walk],safe_mkdir_for_all->[safe_mkdir],relative_symlink->[safe_mkdir_for],rm_rf->[safe_delete],absolute_symlink->[safe_mkdir_for],safe_mkdir_for->[safe_mkdir],touch->[safe_open],safe_open->[safe_mkdir_for],safe_concurren... | Rename src to dst ignoring errors due to dst already existing. | Would be helpful to add docstring explaining what happens if `recursive` is true. |
@@ -228,7 +228,8 @@ public class Jar implements Closeable {
int size = (int) entry.getSize();
try (ByteBufferOutputStream bbos = new ByteBufferOutputStream((size == -1) ? BUFFER_SIZE : size + 1)) {
bbos.write(jin);
- putResource(entry.getName(), new EmbeddedResource(bbos.toByteBuffer(), lastModified... | [Jar->[putResource->[putResource],doChecksums->[Jar,getName,write],getDataURI->[getResource],getName->[getName],write->[write,getResource],remove->[getDirectory,remove],close->[close],rename->[putResource],getTimelessDigest->[write,remove,writeManifest,getManifest,check],copy->[addDirectory],setManifest->[setManifest],... | This method is used to build a jar from an input stream. | This sort of breaks the contract of this method since it ignores the lastModified argument. You would need a copy of this method which uses the zipentry last modified times. |
@@ -36,6 +36,14 @@ class Api
game.to_h
end
+ # POST '/api/game/<game_id>/user_settings'
+ r.is 'user_settings' do
+ DB.with_advisory_lock(:action_lock, game.id) do
+ game.update_player_settings(user.name, r.params)
+ game.save
+ ... | [Api->[set_game_state->[round,status,active_player_names,finished,include?,map,result,select,acting,save,name,turn],actions_h->[map],round,create,status,new,size,new_seed,remove_player,any?,ordered_players,publish,base_url,name,map,between?,not_authorized!,set_game_state,on,post,process_action,with_advisory_lock,result... | Provides a list of routes that can be used to view a game s data. create a new game object. | i don't think this lock is necessary |
@@ -384,7 +384,8 @@ out:
int
ds_mgmt_evict_pool(uuid_t pool_uuid, d_rank_list_t *svc_ranks, uuid_t *handles, size_t n_handles,
- uint32_t destroy, uint32_t force_destroy, const char *group)
+ uint32_t destroy, uint32_t force_destroy, char* machine,
+ const char *group, uint32_t *count)
{
int rc;
| [No CFG could be retrieved] | d_mgmt_rank_list_t - function to create a list of ranks based Evict active pool connections. | (style) "foo* bar" should be "foo *bar" |
@@ -105,6 +105,9 @@ func (d *DeploymentConfigDescriber) Describe(namespace, name string, settings kc
deployment = &item
}
}
+ if deployment == nil {
+ isNotDeployed = true
+ }
if isNotDeployed {
formatString(out, "Latest Deployment", "<none>")
| [Describe->[EnsureReplicationControllerNode,EnsureDeploymentConfigNode,AddTriggerEdges,ConfigSelector,DeploymentConfigs,OverlappingControllers,Events,AddDeploymentEdges,Search,Reverse,RelevantDeployments,New,ReplicationControllers,ActiveDeployment,Fprintln,LatestDeploymentNameForConfig,DeploymentConfigNameFor,Sort,Get,... | Describe returns the description of a deployment config show details if the current deployment is the latest one or the current deployment is the latest one. | Did we ever fix the issues we have in `oc describe` for deployments? |
@@ -41,6 +41,9 @@ public abstract class KafkaExtractor<S, D> extends EventBasedExtractor<S, D> {
protected Iterator<MessageAndOffset> messageIterator;
protected long nextWatermark;
+ private long totalRecordSize;
+ private int recordCount;
+ private long avgRecordSize;
public KafkaExtractor(WorkUnitStat... | [KafkaExtractor->[readRecord->[hasNext,RuntimeException,decodeRecord,offset,fetchNextMessageBuffer,next],close->[setHighWaterMark,close],build,register,create,getPropAsLong]] | This class is used to extract data from a Kafka partition. This method fetches the next message buffer from the partition. | Is it possible to use `gobblin-metrics`, or this is what @ibuenros will be working on? |
@@ -107,7 +107,7 @@ public class SamzaRunner extends PipelineRunner<SamzaPipelineResult> {
@Override
public SamzaPipelineResult run(Pipeline pipeline) {
- SplittableParDo.validateNoPrimitiveReads(pipeline);
+ SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(pipeline);
Metric... | [SamzaRunner->[getMetricsReporters->[getMetricsReporters],fromOptions->[SamzaRunner],runSamzaApp->[run]]] | Runs the SAM - ZAP pipeline. | To clarify: this change makes it so instead of rejecting primitive reads the function is a noop? |
@@ -229,13 +229,15 @@ class Filmstrip extends PureComponent<Props> {
? width / (thumbnailWidth + (2 * margin))
: height / (thumbnailHeight + (2 * margin))
);
- const participants = this._separateLocalThumbnail ? _participants : [ _localParticipantId, ..._participants ];
+ ... | [No CFG could be retrieved] | Renders a single thumbnail of a given type. Maps the state of a Filmstrip into the associated props. | I think we should keep the local thumbnail in filmstrip mode, just not render the video. This also makes re-enabling the self-view easier since the control is just there. |
@@ -320,7 +320,7 @@ class TestInvoice(FormRecognizerTest):
self.assertEqual(invoice.fields.get("CustomerName").value, "Microsoft")
self.assertEqual(invoice.fields.get("InvoiceId").value, '34278587')
self.assertEqual(invoice.fields.get("InvoiceDate").value, date(2017, 6, 18))
- self.ass... | [TestInvoice->[test_blank_page->[begin_recognize_invoices,read,result,open,assertIsNotNone],test_damaged_file_passed_as_bytes->[begin_recognize_invoices,assertRaises],test_pages_kwarg_specified->[open,begin_recognize_invoices,read,result],test_passing_enum_content_type->[begin_recognize_invoices,read,result,open,assert... | Test invoice PDF include field elements. | Sad about this regression. :( |
@@ -305,6 +305,10 @@ type BuildStrategy struct {
// CustomStrategy holds the parameters to the Custom build strategy
CustomStrategy *CustomBuildStrategy `json:"customStrategy,omitempty"`
+
+ // JenkinsPipelineStrategy holds the parameters to the Jenkins Pipeline build strategy.
+ // This strategy is experimental.... | [No CFG could be retrieved] | Services for the source control user. | @smarterclayton do we need to do anything else here to warn users not to use this? the expectation is we're going to merge this branch (thus exposing the strategy) before we have the rest of the pieces (mainly the jenkins image) in place to be able to actually run/manage these builds correctly. |
@@ -105,6 +105,10 @@ class WPCOM_REST_API_V2_Endpoint_List_Publicize_Connection_Test_Results extends
}
}
+ if ( 'linkedin' === $item['id'] && 'must_reauth' === $test_result['connectionTestPassed'] ) {
+ $item['test_success'] = 'must_reauth';
+ }
+
$response = rest_ensure_response( $items );
$respon... | [WPCOM_REST_API_V2_Endpoint_List_Publicize_Connection_Test_Results->[get_items->[get_connections,get_publicize_conns_test_results,header],get_item_schema->[get_connection_schema_properties,add_additional_fields_schema]]] | Get all connections. | @eliorivero Is this a bug? It looks like the if statement should be inside the foreach loop above it. That's how it is on WP.com. |
@@ -212,7 +212,13 @@ func VerifyAndDelegateFromMsg(
return nil, nil, nil, errNegativeAmount
}
if msg.Amount.Cmp(minimumDelegation) < 0 {
- return nil, nil, nil, errDelegationTooSmall
+ if chainConfig.IsMinDelegation100(epoch) {
+ if msg.Amount.Cmp(minimumDelegationV2) < 0 {
+ return nil, nil, nil, errDele... | [CreateValidatorFromNewMsg,UpdateValidatorFromEditMsg,Warn,Mul,WithMessage,ValidatorWrapperCopy,Set,Add,ReadValidatorList,Int,GetBalance,Cmp,New,Cause,IsNil,Bytes,Sub,Logger,Sign,Wrapf,Equal,Uint64,ReadValidatorSnapshot,Int64,NewDelegation,GT,Str,IsValidator,Msg,MustAddressToBech32,SetUint64,Undelegate,NewInt,String,Ab... | VerifyAndDelegateFromMsg verifies the given message is a valid delegate message and returns the balance Index - returns the delegation index. | I noticed that there are now functional adjustments about chains, are they all based on epoch Instead of a specific height value? This feels like it would be more convenient, an epoch I remember is 24 hours? |
@@ -72,13 +72,12 @@ import org.joda.time.Instant;
* }
* </pre>
*
- * <p>To execute this pipeline using the Dataflow service, specify pipeline configuration:
+ * <p>To change the runner, specify:
* <pre>{@code
- * --project=YOUR_PROJECT_ID
- * --tempLocation=gs://YOUR_TEMP_DIRECTORY
- * --runner=BlockingDa... | [WindowedWordCount->[main->[getSchema,getWindowSize,AddTimestampFn]]] | This function is used to read a single chunk of a n - word count file and write A DoFn that sets the data element timestamp for 10 - minute windows. | I think this should say something like "By default, the examples will run with the DirectRunner. To change the runner, specify:" |
@@ -303,7 +303,7 @@ func (n *nullui) GetLogUI() LogUI {
func (n *nullui) GetLocksmithUI() LocksmithUI {
return nil
}
-func (n *nullui) GetProvisionUI() ProvisionUI {
+func (n *nullui) GetProvisionUI(bool) ProvisionUI {
return nil
}
func (n *nullui) Prompt(string, bool, Checker) (string, error) {
| [Write->[Errorf],MoveGpgKeyringTo->[Join,Rename],Cleanup->[Shutdown,ClearAllStoredSecrets,RemoveAll,Debug],InitTest->[ConfigureConfig,NewTestLogger,TempFile,Init,Name,TempDir,Close,Fatalf,WriteString],ResetLoginState->[createLoginState],CleanTest->[Remove],Clone->[Fatal],GenerateGPGKeyring->[Create,Join,Serialize,Close... | GetLocksmithUI - get locksmith UI. | Can we make this an enum rather than a bool? |
@@ -70,6 +70,9 @@ public class ThreeDBatchUpdateWork extends AbstractWork {
public static final String THREED_CONVERSIONS_DONE_EVENT = "threeDConversionsDone";
+ // @since 11.1
+ protected static final String STATUS_DONE = "Done";
+
protected static String computeIdPrefix(String repositoryName, Stri... | [ThreeDBatchUpdateWork->[saveMainInfo->[saveNewProperties],saveNewTransmissionThreeDs->[saveNewProperties],fireThreeDConversionsDoneEvent->[computeIdPrefix],saveNewRenderViews->[saveNewProperties],computeIdPrefix]] | Computes the prefix for the given document in the given repository. | Shouldn't this be in the previous commit, related to 3D? |
@@ -28,4 +28,9 @@ public interface TestContainerManager {
String[] command);
void stopTarget();
+
+ static boolean useLinuxContainers() {
+ return "1".equals(System.getenv("USE_LINUX_CONTAINERS"))
+ || !System.getProperty("os.name").toLowerCase().contains("windows");
+ }
}
| [No CFG could be retrieved] | Stop the target. | This method's result is always reverted, should we revert the method itself instead? |
@@ -151,6 +151,11 @@ export class AmpAd3PImpl extends AMP.BaseElement {
return this.element.getResources().getResourceForElement(this.element);
}
+ /** @override */
+ getConsentPolicy() {
+ return null;
+ }
+
/** @override */
buildCallback() {
this.type_ = this.element.getAttribute('type');
| [No CFG could be retrieved] | Provides a method to determine if a full - width responsive was requested for this ad. Checks if the given tag should request full width. | Is this doing anything? |
@@ -762,6 +762,9 @@ static int file_close_stream(struct file_ctx_st *ctx)
static int file_close(void *loaderctx)
{
+ if (loaderctx == NULL)
+ assert(0);
+
struct file_ctx_st *ctx = loaderctx;
switch (ctx->type) {
| [No CFG could be retrieved] | END OF FUNCTION FILE_CLOSE_DIR FILE_CLOSE_STREAM. | I do not think we want such assert calls. Please drop this. |
@@ -24,7 +24,10 @@ var userRegistriesFile = filepath.Join(os.Getenv("HOME"), ".config/containers/re
// FIXME: This should be centralized in a global SystemContext initializer inherited throughout the code,
// not haphazardly called throughout the way it is being called now.
func SystemRegistriesConfPath() string {
-... | [Wrapf,Join,IsRootless,Stat,GetRegistries,Getenv,UnqualifiedSearchRegistries] | GetRegistriesData obtains the list of registries from sysregistries. conf. GetRegistries obtains the list of registries that are in the system registries conf. | That's a breaking change. Can we continue supporting `REGISTRIES_CONFIG_PATH` but error out if both are set? I'd sleep better. |
@@ -380,9 +380,11 @@ frappe.views.BaseList = class BaseList {
// render
this.prepare_data(r);
this.toggle_result_area();
+ this.toggle_paging && this.$paging_area.toggle(false);
this.before_render();
this.render();
this.after_render();
+ this.toggle_paging && this.$paging_area.toggle(true);
... | [No CFG could be retrieved] | get_filters_for_args - get filters for args View method for the view. | If this is supposed to be run only for list_view, then we should move this code to list_view.js. We have `before_render` and `after_render` |
@@ -2011,6 +2011,10 @@ class PackageBase(with_metaclass(PackageMeta, PackageViewMixin, object)):
if hasattr(self, 'url') and self.url:
urls.append(self.url)
+ # fetch from first entry in urls to save time
+ if hasattr(self, 'urls') and self.urls:
+ urls.append(self.urls[... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],setup_build_environment->[_get_legacy_environment_method],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_uninstall->[uninstall_by_spec],possible_dependencies->[p... | A list of all URLs in a package. | I wasn't sure if I should add all urls. Pro: - more robust - works - probably the right thing to do / least surprising Con: - can take a lot of extra time to find usually the exact same versions - version exploration is not a super-critical operation yet if failing |
@@ -113,6 +113,17 @@ public class SelectHiveQL extends AbstractHiveQLProcessor {
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.build();
+ public static final PropertyDescriptor HIVEQL_POST_QUERY = new PropertyDescriptor.Builder()
+ .name("hive-post-... | [SelectHiveQL->[setup->[isSet,ProcessException,hasIncomingConnection,error],onTrigger->[getValue,fetch,create,onTrigger,size,equals,forName,getElapsed,toString,warn,StringBuilder,info,countMatches,executeQuery,CsvOutputOptions,put,remove,yield,getLocalizedMessage,add,putAllAttributes,AtomicLong,hasIncomingConnection,se... | Relations for the FlowFile. region IExpressionLanguageProvider Implementation. | I'm clearly not a Hive expert but does it make sense to give this kind of examples for post-queries? |
@@ -222,6 +222,12 @@ export class Resources {
this.lastScrollTime_ = Date.now();
});
+ if (this.useLayers_) {
+ Services.layersForDoc(this.ampdoc).onScroll((/* elements */) => {
+ this.schedulePass();
+ });
+ }
+
// When document becomes visible, e.g. from "prerender" mode, do ... | [No CFG could be retrieved] | private private methods This function is called when the DOM is ready. It is called by AMPDocument when. | Could be a bit chatty, no? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.