patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -7,7 +7,7 @@ internal static partial class Interop
{
internal static partial class Kernel32
{
- [DllImport(Libraries.Kernel32)]
- internal static extern void GetSystemInfo(out SYSTEM_INFO lpSystemInfo);
+ [GeneratedDllImport(Libraries.Kernel32)]
+ internal static partial void G... | [Interop->[Kernel32->[GetSystemInfo->[Kernel32]]]] | Get system info. | Quick sanity check here. I assume that `SYSTEM_INFO` is blittable, so we could technically change this to `internal static extern unsafe void GetSystemInfo(SYSTEM_INFO* lpSystemInfo);` and make a fixed statement at the invocation site right? I don't know how big this generated code is but it seems like we might want to... |
@@ -195,6 +195,7 @@ class Jetpack_Twitter_Cards {
add_filter( 'jetpack_open_graph_tags', array( __CLASS__, 'twitter_cards_tags' ) );
add_filter( 'jetpack_open_graph_output', array( __CLASS__, 'twitter_cards_output' ) );
add_filter( 'jetpack_twitter_cards_site_tag', array( __CLASS__, 'site_tag' ), -... | [No CFG could be retrieved] | This method is called by the jetpack_open_graph_output and jet. | Why is this at -99 priority? Shouldn't we do it at +99, to give other things a chance to offer up an alternative? |
@@ -1091,7 +1091,8 @@ while ($i < min($num, $limit))
}
if (! empty($arrayfields['s.phone']['checked']))
{
- print "<td>".$obj->phone."</td>\n";
+ $tmpcode=getCountry($obj->fk_pays,2);
+ print "<td>".dol_print_phone($obj->phone, $tmpcode,0,$obj->rowid)."</td>\n";
if (! $i) $totalarray['nbfield']++;
... | [fetch,selectMassAction,select_country,fetch_object,jdate,order,select_salesrepresentatives,getNomUrl,getLibProspLevel,selectarray,initHooks,typent_array,load,plimit,transnoentities,executeHooks,loadCacheOfProspStatus,loadLangs,update,select_categories,escape,showCheckAddButtons,close,textwithpicto,free,query,fetch_nam... | This function returns an array of all possible states regions and types in the system. This function prints the number of fields in the array. | This create a useless SQL request at each pass in the loop. You can get $tmpcode by adding the field "code" of table country inside the previous select. |
@@ -16,6 +16,7 @@
import {user} from '../../../src/log';
import {FilterType} from './filters/filter';
+import {ANALYTICS_CONFIG} from '../../amp-analytics/0.1/vendors';
/**
* @typedef {{
| [No CFG could be retrieved] | Exports an object that exports an AMP - AMP - AMP config with a specific Checks whether the object conforms to the AmpAdExitConfig spec. | Ignore changes to this file - it was changed in #10714 and will be rebased away. |
@@ -122,7 +122,15 @@ void SetPolicyServer(EvalContext *ctx, const char *new_policy_server)
snprintf(POLICY_SERVER, CF_MAX_IP_LEN, "%s", new_policy_server);
EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "policy_hub", new_policy_server, DATA_TYPE_STRING, "source=bootstrap");
}
+ else
+ ... | [No CFG could be retrieved] | Set the policy server of the node. Get the policy server file contents. | Why not simply <code> POLICY_SERVER[0] = 0; </code> ? Saves a function call and probably some loop overhead. |
@@ -375,6 +375,15 @@ namespace Dynamo.Controls
{
nodeWasClicked = true;
BringToFront();
+ if (e.ClickCount == 2)
+ {
+ Debug.WriteLine("Name double clicked!");
+ if (ViewModel != null && ViewModel.RenameCommand.CanExecute(null))
+ ... | [NodeView->[NodeViewReady->[OnNodeViewReady],NodeView_MouseLeave->[OnMouseLeave],OnPreviewControlMouseLeave->[Condensed,TransitionToState,StaysOpen],OnNodeViewMouseEnter->[BeginInvoke,Loaded],IsMouseInsideNodeOrPreview->[HitTest,Stop],OnDataContextChanged->[NewValue,Value,Height,RenderSize,HasValue,Width],NodeModel_Con... | Mouse left button down event handler. | The part is not clear to me is that for nodes in other state, how are we handling the double click? On a different route? |
@@ -142,6 +142,12 @@ public class RemoteInterpreterServer extends Thread
private ScheduledExecutorService resultCleanService = Executors.newSingleThreadScheduledExecutor();
private boolean isTest;
+ // Whether calling System.exit to force shutdown interpreter process.
+ // In Flink K8s application mode, Remot... | [RemoteInterpreterServer->[runApplication->[run,info],InterpretJob->[jobRun->[processInterpreterHooks,info,open,interpret],processInterpreterHooks->[onPreExecute,onPostExecute]],close->[close],interpret->[getInterpreter],angularObjectAdd->[angularObjectUpdate],getFormType->[getInterpreter],main->[RemoteInterpreterServe... | The main method for the server. | Right now we have a forced shutdown, so we should change the default setting. |
@@ -341,7 +341,8 @@ def get_gnu_triplet(os_, arch, compiler=None):
# Calculate the arch
machine = {"x86": "i686" if os_ != "Linux" else "x86",
"x86_64": "x86_64",
- "armv8": "aarch64"}.get(arch, None)
+ "armv8": "aarch64",
+ "armv8_32": "aarch64"}.get(... | [get_cross_building_settings->[detected_architecture],OSInfo->[uname->[bash_path],detect_windows_subsystem->[uname],get_win_os_version->[_OSVERSIONINFOEXW]],cpu_count->[cpu_count]] | Returns the GNU triplet name for a given architecture and OS. Returns a unique name for the system. | Wasn't this a 32 bits architecture? The boost generator says so. |
@@ -76,7 +76,10 @@ def score_match(query_rep, text, length_penalty, dictionary=None, debug=False):
print("match: " + w)
used[w] = True
norm = math.sqrt(len(used))
- score = score / math.pow(norm * query_rep['norm'], length_penalty)
+ norm = math.pow(norm * query_rep['norm'], length_... | [IrBaselineAgent->[add_cmdline_args->[add_cmdline_args],load->[load],observe->[observe],save->[save],act->[act,rank_candidates]],rank_candidates->[MaxPriorityQueue,score_match,add]] | Score a query_rep with a length penalty. | or just `if norm > 1: score /= norm` |
@@ -570,7 +570,8 @@ int enc_main(int argc, char **argv)
BIO_free(bzl);
#endif
release_engine(e);
- OPENSSL_free(pass);
+ if (pass != NULL)
+ OPENSSL_clear_free(pass, strlen(pass));
return ret;
}
| [No CFG could be retrieved] | finds the neccesary key in the file set_hex - set the hex string of the doall_enc_ciphers. | It appears to me that it's also cleansed around line 627... |
@@ -310,6 +310,7 @@ copy_one(struct bio_desc *biod, struct bio_iov *biov, void *data)
ssize_t size = bio_iov2req_len(biov);
uint16_t media = bio_iov2media(biov);
+ D_ASSERT(biod->bd_type < BIO_IOD_TYPE_GETBUF);
D_ASSERT(arg->ca_sgl_idx < arg->ca_sgl_cnt);
sgl = &arg->ca_sgls[arg->ca_sgl_idx];
| [No CFG could be retrieved] | Copy a single chunk from one of the DRAM buffers to another. region IovAccess methods len of ca_i. | Why bd_type cannot be "BIO_IOD_TYPE_GETBUF"? Does it means the "biod" created via bio_buf_alloc() cannot be used by copy_one()? |
@@ -30,9 +30,10 @@ public interface OperationPolicyPointcutParametersFactory {
*
* @param operationIdentifier identifier of the message source
* @param operationParameters set of parameters that are going to be used to execute the operation.
+ * @param flowName name of the flow executing the operation.
... | [No CFG could be retrieved] | Create the policy cut parameters for the given operation. | Chang the signature to make flowName the first parameter |
@@ -537,12 +537,13 @@ int PEM_get_EVP_CIPHER_INFO(char *header, EVP_CIPHER_INFO *cipher)
*header = '\0';
cipher->cipher = enc = EVP_get_cipherbyname(dekinfostart);
*header = c;
+ header++;
if (enc == NULL) {
PEMerr(PEM_F_PEM_GET_EVP_CIPHER_INFO, PEM_R_UNSUPPORTED_ENCRYPTION);
... | [PEM_do_header->[PEM_def_callback],PEM_ASN1_write_bio->[PEM_def_callback,PEM_dek_info,PEM_proc_type]] | Returns 0 if header is not found in PEM format. return 0 if the PEM header is missing. | should be a single statement. |
@@ -0,0 +1,15 @@
+# typed: true
+class Foo
+ extend T::Sig
+
+ sig {returns(Integer)}
+ def bar
+ baz("1")
+ # ^ hover: Foo
+ end
+
+ sig {params(arg0: String).returns(Integer)}
+ def baz(arg0)
+ arg0.to_i
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I actually have no idea why this is what we want this to return, but this is what the old test was testing! |
@@ -16,7 +16,11 @@ class IncomingEmailDetailsSerializer < ApplicationSerializer
EMAIL_RECEIVER_ERROR_PREFIX = "Email::Receiver::".freeze
def error
- @error_string
+ if @error_string.blank?
+ "Unrecognized Error"
+ else
+ @error_string
+ end
end
def error_description
| [IncomingEmailDetailsSerializer->[headers->[to_s],body->[decoded,truncate_words],subject->[presence],initialize->[raw,new,error],error_description->[t,underscore],freeze,attributes]] | error_string error_description . | Can this be I18nlized? |
@@ -437,9 +437,7 @@ func (k *kubeAPIServer) computeKubeAPIServerCommand() []string {
out = append(out, "--audit-log-maxbackup=5")
out = append(out, "--authorization-mode=Node,RBAC")
- if len(k.values.APIAudiences) > 0 {
- out = append(out, "--api-audiences="+strings.Join(k.values.APIAudiences, ","))
- }
+ out = ... | [handlePodMutatorSettings->[ControlPlaneSecretDataKeyCertificatePEM,ControlPlaneSecretDataKeyPrivateKey,MustParse],handleOIDCSettings->[Sprintf,Join],handleServiceAccountSigningKeySettings->[Sprintf],probeEndpoint->[Check],computePodAnnotations->[all],handleBasicAuthenticationSettings->[Sprintf],handleSNISettings->[Spr... | computeKubeAPIServerCommand returns the command to run Kubernetes API server Print command line options for missing secrets Command line options for the k8s - mutating - inflight - request daemon. This function returns a list of command line options that can be passed to the command line. | This `if` condition should not have been removed. |
@@ -167,9 +167,14 @@ public class MockConnectorFactory
@Override
public List<SchemaTableName> listTables(ConnectorSession session, Optional<String> schemaName)
{
- return listTables.apply(session, schemaName.orElse(null)).stream()
- .filter(sc... | [MockConnectorFactory->[MockConnector->[MockConnectorMetadata->[getColumnHandles->[getName]]],Builder->[build->[MockConnectorFactory]]]] | List tables with a specific schema. | `Make table listing in MockConnector emulate Hive Connector better` Can you explain what it means because "better" is very ambiguous? |
@@ -124,8 +124,10 @@ class WSHandler(WebSocketHandler):
raise gen.Return(None)
def on_pong(self, data):
- #log.debug("received a pong: %r", data)
- pass
+ try:
+ self.latest_pong = int(codecs.decode(data, 'utf-8'))
+ except:
+ log.info("received unparsea... | [WSHandler->[send_message->[send,Return,warn],on_close->[info,client_lost],_protocol_error->[error,close],on_message->[_receive,Return,_schedule,_handle],_schedule->[send_message,Return,isinstance,_internal_error],_receive->[str,consume,Return,_protocol_error],open->[on_ack_sent->[debug,exception],send_message,Receiver... | Called when a client sends a pong message. | At minimum you should catch `Exception`, unless you want to catch `SystemExit` etc. here. However, what exactly can fail here: `int()` or `codecs.decode()` or both? I strongly recommend to catch as specific exception as possible to not hide bugs. |
@@ -175,6 +175,15 @@ namespace Microsoft.Xna.Framework
result = ContainmentType.Intersects;
}
+ #endregion
+
+ #region CreateFromBoundingBox
+
+ /// <summary>
+ /// Creates the smallest <see cref="BoundingSphere"/> that can surround a specified <see cref="Bounding... | [BoundingSphere->[GetHashCode->[GetHashCode],Transform->[Transform],Intersects->[Intersects],PlaneIntersectionType->[Intersects],Equals->[Equals],Contains->[Contains],ContainmentType->[Contains],ToString->[ToString],Equals]] | Returns the type of polygon that contains the given point. | Use `contain` and not `surround`. |
@@ -416,12 +416,7 @@ public class BeamCalcRel extends AbstractBeamCalcRel {
Expression value =
Expressions.convert_(
- Expressions.call(
- expression,
- "getBaseValue",
- Expressions.constant(index),
- Expressions.const... | [BeamCalcRel->[copy->[BeamCalcRel],WrappedList->[size->[size],get->[get,value]],CalcFn->[setup->[compile]],WrappedRow->[get->[field]],WrappedMap->[get->[get,value],entrySet->[entrySet]],InputGetterImpl->[map->[value],list->[value],value->[value],row->[value]]]] | Creates a value expression for the given index in the given list. getMillis - > value if not found - > value. | I have the same concern with this change. |
@@ -314,9 +314,9 @@ public class HadoopDruidIndexerConfig
public Optional<List<Interval>> getIntervals()
{
- Optional<SortedSet<Interval>> setOptional = schema.getDataSchema().getGranularitySpec().bucketIntervals();
- if (setOptional.isPresent()) {
- return Optional.of(JodaUtils.condenseIntervals(set... | [HadoopDruidIndexerConfig->[getIndexSpec->[getIndexSpec],fromFile->[fromMap],isLogParseExceptions->[isLogParseExceptions],makeIntermediatePath->[getDataSource,getWorkingPath],verify->[getParser,getDataSource,getGranularitySpec,getWorkingPath],isOverwriteFiles->[isOverwriteFiles],setShardSpecs->[getPathSpec],fromConfigu... | - List of intervals. | nit: can reuse bucketIntervals variable here |
@@ -446,12 +446,10 @@ class Optimizer(object):
for param_and_grad in parameters_and_grads:
if param_and_grad[1] is None:
continue
- with param_and_grad[0].block.program._optimized_guard(
- param_and_grad):
- if p... | [MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],PipelineOptimizer->[_extract_section_ops->[_is_opt_role_op],_find_input_output->[update],minimize->[minimize,_create_vars,_split_program],_split_program->[_extract_section_ops,_find_persistable_vars,u... | Create an optimization pass for the missing constraint. Get the ops that are needed to optimize the . | array append array |
@@ -260,14 +260,11 @@ namespace System.Xml
}
for (; position < length; position++)
{
- if ((local && !XmlCharType.IsNCNameCharXml4e(name[position])) ||
- (!local && !XmlCharType.IsNameCharXml4e(name[position])) ||
- (matchPos ==... | [XmlConvert->[ToXPathString->[ToString],ToXPathDouble->[ToDouble],EscapeValueForDebuggerDisplay->[ToString],VerifyNMTOKEN->[VerifyNMTOKEN],FromBinHexString->[FromBinHexString],EncodeNmToken->[EncodeName],Exception->[ToString],VerifyNCName->[VerifyNCName],EncodeName->[EncodeName],TryToTimeSpan->[TryToTimeSpan],VerifyCha... | This method is called to encode name if it is not null. if local = false then we can find a match in the name. | same about the brackets, I'm not really sure this is equivalent... |
@@ -357,7 +357,7 @@ AMP.maybeExecuteRealTimeConfig = false;
const RTC_ERROR_ENUM = {};
/** @typedef {{
- response: (?Object<string>|undefined),
+ response: (?Object|undefined),
rtcTime: number,
callout: string,
error: (RTC_ERROR_ENUM|undefined)}} */
| [tweetid,validator,AMP,widgets,AMP_TEST_IFRAME,requestedWidth,sf_,requestedHeight,PerformancePaintTiming,vg,env,events,AMP_CONFIG,init,prototype,services,AMP_CONTEXT_DATA,implementation_,maybeExecuteRealTimeConfig,onAnalyticsEvent,draw3p,AmpAdXOriginIframeHandler,AMP_TEST,inViewport,_context,gistid,numposts,orderBy,Bas... | The response variable contains information about the response. | can it be null? If not, remove ? |
@@ -245,7 +245,10 @@ public class CreateProjectMojo extends AbstractMojo {
.replace("_", ".") + ".HelloResource";
className = prompter.promptWithDefaultValue("Set the resource classname", defaultResourceName);
if (StringUtils.isBlank(path)) {
- ... | [CreateProjectMojo->[isDirectoryEmpty->[IllegalArgumentException,getAbsolutePath,list,isDirectory],sanitizeOptions->[stripExtensionFrom,replace,contains,collect,isBlank,startsWith,toSet],isTrueOrYes->[toLowerCase,equalsIgnoreCase],createMavenWrapper->[executeMojo,getRepositorySession,getParentFile,getResult,name,getMav... | Ask the user for missing values. | It's a good idea. It would be better if it was a bit more solid though (think of a class in the default package for instance). |
@@ -76,7 +76,7 @@ print("%s events passed all filters" % nentries.GetValue())
getPt_code ='''
using namespace ROOT::VecOps;
-RVec<double> getPt(const RVec<FourVector> &tracks)
+ROOT::RVecD getPt(const RVec<FourVector> &tracks)
{
auto pt = [](const FourVector &v) { return v.pt(); };
return Map(tracks, pt);
| [Declare,Define,SaveAs,Histo1D,Filter,print,RDataFrame,Draw,TCanvas,GetValue,fill_tree] | Create a RDataFrame from a list of objects. \ ~english Get the histogram of the n - th track. | to fix the CI error for this tutorial, you can change `using namespace ROOT::VecOps` to `using namespace ROOT`. Probably something similar applies for the other errors. |
@@ -653,7 +653,7 @@ namespace System.Windows.Forms
return;
}
- if (associatedControl is TreeView treeView && treeView.ShowNodeToolTips)
+ if (associatedControl is TreeView treeView)
{
treeView.SetToolTip(this, GetToolTip(associatedContr... | [ToolTip->[TimerHandler->[Hide],DestroyHandle->[DestroyHandle],RemoveAll->[HandleDestroyed,DestroyRegion,HandleCreated,ClearTopLevelControlEvents],ToString->[ToString],WmMove->[Reposition],SetTool->[Hide,GetWinTOOLINFO],Show->[ShowTooltip,IsWindowActive],WndProc->[WmWindowPosChanging,GetToolTip,WmWindowPosChanged,WmWin... | CheckNativeToolTip - This method checks if the Tooltip of the associated control is native. | Could you please say why did you remove this check here? How will it affect setting a toolTip to a TreeView? |
@@ -578,10 +578,12 @@ foreach ($ports as $port) {
if ($port_association_mode != "ifIndex") {
$port['update']['ifIndex'] = $ifIndex;
}
-
- $port['update']['poll_time'] = $polled;
- $port['update']['poll_prev'] = $port['poll_time'];
- $port['update']['poll_period'] = $p... | [addDataset] | This function is used to populate the port data array with the information from the IFO. This function extracts the stats from the AIROS. | Can this code block be deleted? |
@@ -53,8 +53,7 @@ class MSBuild(object):
def build(self, sln):
cmd = self.command(sln)
- vcvars = os.path.join(self._conanfile.generators_folder, "conanvcvars")
- self._conanfile.run(cmd, env=["conanbuildenv", vcvars])
+ self._conanfile.run(cmd)
@staticmethod
def get_ver... | [MSBuild->[build->[command],command->[msbuild_verbosity_cmd_line_arg,msbuild_max_cpu_count_cmd_line_arg],__init__->[msbuild_arch]]] | Build a sequence of sequence numbers. | I don't see who is adding ``conanvcvars`` now |
@@ -617,6 +617,16 @@ def test_datahandler_ohlcv_get_pairs(testdatadir):
pairs = HDF5DataHandler.ohlcv_get_pairs(testdatadir, '5m')
assert set(pairs) == {'UNITTEST/BTC'}
+ pairs = JsonDataHandler.ohlcv_get_pairs(testdatadir, '1h', 'mark')
+ assert set(pairs) == {'UNITTEST/USDT', 'XRP/USDT'}
+
+ # TO... | [test_file_dump_json_tofile->[_clean_test_file],test_download_pair_history->[_clean_test_file],test_download_trades_history->[_clean_test_file]] | Get the pairs of the HALCV files in the specified directory. Get available data from HDF5DataHandler. | I don't know how to make a test HDF5 or Gz file for these tests |
@@ -71,7 +71,7 @@ class LinearModel(BaseEstimator):
----------
X : array, shape (n_samples, n_features)
The training input samples to estimate the linear coefficients.
- y : array, shape (n_samples,)
+ y : array, shape (n_samples,) or (n_samples, n_targets)
The ... | [get_coef->[get_coef,_get_inverse_funcs],_fit_and_score->[fit],_get_inverse_funcs->[_get_inverse_funcs],LinearModel->[decision_function->[decision_function],score->[score],predict_proba->[predict_proba],transform->[transform],predict->[predict],fit->[fit],fit_transform->[fit]]] | Estimate the coefficients of the linear model. | more compact and consistent as `shape (n_samples,[ n_targets])` to show optional |
@@ -225,11 +225,7 @@ describe AlaveteliPro::SubscriptionsController, feature: :pro_pricing do
allow(AlaveteliConfiguration).to receive(:stripe_namespace).
and_return('alaveteli')
- post :create, 'stripeToken' => token,
- 'stripeTokenType' => 'card',
- ... | [successful_signup->[email,post],email,create,new,let,be,describe,start,create_test_helper,first,it,create_pro_account,map,to,stripe_customer_id,plan_path,before,prepare_error,post,let!,prepare_card_error,require,signin_path,dirname,stop,shared_examples,enable_actor,generate_card_token,match,id,create_plan,enabled?,cus... | requires that the user has a non - nil token and a coupon code and customer and subscription stripeTokenpost creates a new token and checks that the customer has the correct source. | Line is too long. [168/80] |
@@ -120,7 +120,6 @@ class JsonOutputProcess(KratosMultiphysics.Process):
else:
data["RESULTANT"][out.GetString() ][-1] += value
else: # It is a vector
-
if (KratosMultiphysics.KratosGlobal... | [JsonOutputProcess->[__generate_variable_list_from_input->[size,param,GetVariable,IsArray,format,range,Exception],ExecuteFinalizeSolutionStep->[GetSolutionStepValue,write_external_json,read_external_json,GetVariable,data,len,GetString,GetValue,isinstance,range,HasVariable,params],ExecuteInitialize->[__generate_variable... | Execute finalize solution step. This function writes the resultant sequence numbers to a JSON file. | @jcotela It is here |
@@ -801,6 +801,8 @@ def compute_covariance(epochs, keep_sample_mean=True, tmin=None, tmax=None,
data_mean = [1.0 / n_epoch * np.dot(mean, mean.T) for n_epoch, mean
in zip(n_epochs, data_mean)]
+ if info['comps']:
+ info['comps'] = []
info = pick_info(info, picks_meeg)
... | [_undo_scaling_array->[_apply_scaling_array,_invert_scalings],regularize->[copy],_ShrunkCovariance->[score->[get_precision],fit->[fit],get_precision->[get_precision]],compute_whitener->[_get_whitener],_undo_scaling_cov->[_apply_scaling_cov,_invert_scalings],make_ad_hoc_cov->[Covariance],Covariance->[__iadd__->[_check_c... | Estimate the covariance matrix from a list of epochs or a list of events. Parameters for the n - node if method is not None. Parameters for a - related model selection. Unstable if the number of samples is small. | this does an in-place modification of the `info`. Is this desired? `compute_covariance` should not change `epochs.info` IMO. It led me to a long debugging session with a colleague ... |
@@ -1,8 +1,12 @@
-# Copyright (c) 2019 Ultimaker B.V.
+# Copyright (c) 2021 Ultimaker B.V.
# Cura is released under the terms of the LGPLv3 or higher.
-
from .WelcomePagesModel import WelcomePagesModel
+import os
+from typing import Optional, Dict, List, Tuple
+from PyQt5.QtCore import pyqtProperty, pyqtSlot
+from ... | [WhatsNewPagesModel->[initialize->[append,i18nc,_getBuiltinWelcomePagePath,setItems]]] | Model for the WhatsNewPage action. | Shouldn't this be a static method? |
@@ -63,6 +63,10 @@ public abstract class AbstractClientStream extends AbstractStream implements Str
final CancellationContext cancellationContext = stream.getCancellationContext();
// for client cancel,send rst frame to server
cancellationContext.addListener(context -> {
+ if (LOGG... | [AbstractClientStream->[ClientStreamObserver->[onNext->[encodeRequest,createRequestMeta]],deserializeResponse->[getConsumerModel],execute->[execute],newClientStream->[unary,stream]]] | Creates a new stream for the given URL. | warn may be better? |
@@ -46,7 +46,7 @@ class Test_base_command_logging(object):
log_path = tmpdir.join('log')
cmd.main(['fake', '--log', log_path])
with open(log_path) as f:
- assert 'fake' == f.read().strip()[:4]
+ assert 'fake' == self._remove_timestamp(f.read().strip())[:4]
def tes... | [Test_base_command_logging->[test_unicode_messages->[FakeCommandWithUnicode,main],test_log_command_success->[FakeCommand,main],test_log_command_error->[FakeCommand,main],test_log_file_command_error->[FakeCommand,main]]] | Test the log command success. | I think a cleaner, more direct way to test this here and below would be to patch `time.time()`. That way you can assert the exact appearance of the string, and without needing to use regexes, etc. |
@@ -471,12 +471,14 @@ class ElasticsearchSearchResults(BaseSearchResults):
setattr(obj, self._score_field, scores.get(str(obj.pk)))
# Return results in order given by Elasticsearch
- return [results[str(pk)] for pk in pks if results[str(pk)]]
+ return ([results[str(pk)] for pk ... | [ElasticsearchIndexRebuilder->[start->[reset_index],finish->[refresh],reset_index->[reset]],ElasticsearchMapping->[get_field_mapping->[get_field_mapping,get_field_column_name],get_document->[get_field_column_name,_get_nested_document],_get_nested_document->[get_field_column_name],get_mapping->[get_field_mapping,get_doc... | Internal function to perform elasticsearch search. | Complexity of return value execution is far to high for human recognition. I would suggest decomposing it to named pre-evaluated variables simply returned at return statement. |
@@ -74,8 +74,9 @@ public abstract class AbstractElasticsearchProcessor extends AbstractProcessor {
Set<ValidationResult> results = new HashSet<>();
// Ensure that if username or password is set, then the other is too
- Map<PropertyDescriptor, String> propertyMap = validationContext.getPropert... | [AbstractElasticsearchProcessor->[setup->[createElasticsearchClient]]] | Override to check if username or password is set. | I don't see EL enabled in the PASSWORD PropertyDescriptor, but evaluateAttributeExpressions() is being called on that property. Is it intended that the PASSWORD property should allow EL? |
@@ -54,8 +54,8 @@ class SocketReadData {
sizeBuffer = ByteBuffer.allocate(4);
}
final int size = channel.read(sizeBuffer);
- if (logger.isLoggable(Level.FINEST)) {
- logger.finest("read size_buffer bytes:" + size);
+ if (log.isLoggable(Level.FINEST)) {
+ log.finest("read s... | [SocketReadData->[read->[hasRemaining,allocate,getInt,read,flip,IOException,isLoggable,finest],getData->[get,capacity,flip],AtomicInteger,getLogger,getName,incrementAndGet]] | Reads a packet from the specified channel. | This if check should be redundant IMO |
@@ -322,6 +322,10 @@ func (l *LogHandler) keepAccessLog(statusCode, retryAttempts int) bool {
return true
}
+ if l.config.Filters.Duration > 0 && (parse.Duration(duration) > l.config.Filters.Duration) {
+ return true
+ }
+
return false
}
| [Rotate->[Close],ServeHTTP->[ServeHTTP],Close->[Close]] | keepAccessLog returns true if the log should be kept based on the status code and retry. | I think we can skip the first check on the `Duration > 0`. If it's 0 the `duration` will be larger anyway. |
@@ -89,12 +89,16 @@ abstract class DispatchingLogger extends Logger {
synchronized (loggerReference) {
logger = loggerReference.get();
if (logger == null) {
- logger = resolveLogger(resolvedCtxClassLoader);
+ try {
+ logger = resolveLogger(resolvedCtxClassLoader);
+... | [DispatchingLogger->[updateConfiguration->[updateConfiguration],getContext->[getContext],exit->[exit],info->[info],getLevel->[getLevel],isDebugEnabled->[isDebugEnabled],addFilter->[addFilter],isEnabled->[isEnabled],isInfoEnabled->[isInfoEnabled],log->[log],throwing->[throwing],logMessage->[logMessage],error->[error],wa... | Returns a logger that is declared in the given context classloader. | we should use the classloader for the runtime here, not the system classloader |
@@ -762,3 +762,13 @@ func (c *ChainLink) Copy() ChainLink {
func (c ChainLink) LinkID() LinkID {
return c.id
}
+
+func (c ChainLink) NeedsSignature() bool {
+ if !c.IsStubbed() {
+ return true
+ }
+ if c.unpacked.outerLinkV2 == nil {
+ return true
+ }
+ return c.unpacked.outerLinkV2.LinkType.NeedsSignature()
+}
| [UnpackLocal->[UnpackPayloadJSON],ToEldestKID->[GetKID],VerifyPayload->[getFixedPayload],checkAgainstMerkleTree->[Eq],Store->[VerifyLink,String,Pack],IsInCurrentFamily->[ToEldestKID],VerifySigWithKeyFamily->[getFixedPayload,GetCTime],CheckNameAndID->[Eq],Pack->[String],MatchFingerprint->[Eq],Unpack->[UnpackComputedKeyI... | LinkID returns the link ID of the chain link. | This function is only called when `IsStubbed` is true, right? Do we need this check? |
@@ -40,6 +40,9 @@ public final class OAuth20CallbackAuthorizeController extends AbstractController
private static final Logger logger = LoggerFactory.getLogger(OAuth20CallbackAuthorizeController.class);
+ @SuppressWarnings({
+ "rawtypes", "unchecked"
+ })
@Override
protected Mode... | [OAuth20CallbackAuthorizeController->[handleRequestInternal->[getAttribute,debug,removeAttribute,redirectTo,getParameter,addParameter,getSession],getLogger]] | Handle the request. | Should be able to do without these. For instance, declare the map with the generic types in place? |
@@ -112,9 +112,11 @@ public class WebServiceEngine implements Startable {
return action;
}
- private void sendErrors(ServletResponse response, int status, Errors errors) {
- ServletResponse.ServletStream stream = response.stream();
- stream.reset();
+ private void sendErrors(Response response, int sta... | [WebServiceEngine->[getAction->[BadRequestException,action,substring,lastIndexOf,contains,format,controller],sendErrors->[reset,writeJson,of,beginObject,output,endObject,OutputStreamWriter,stream,close,setStatus,setMediaType,locale],controllers->[controllers],execute->[getAction,sendErrors,of,getMessage,error,httpCode,... | Get action by action key. | I find it suspicious that reset must be called here can you explain why it is required? |
@@ -382,6 +382,10 @@ func resourceAwsLambdaFunctionCreate(d *schema.ResourceData, meta interface{}) e
log.Printf("[DEBUG] Received %s, retrying CreateFunction", err)
return resource.RetryableError(err)
}
+ if isAWSErr(err, "InvalidParameterValueException", "Lambda was unable to configure access to your ... | [StringMap,Unlock,UpdateFunctionCode,SetPartial,IsNewResource,GetFunction,StringInSlice,SetNewComputed,Partial,Set,NonRetryableError,Code,DeleteFunction,ReadFile,GetOk,HasChange,New,DeleteFunctionConcurrency,Lock,Errorf,SetId,RetryableError,Bool,Id,CreateFunction,Int64,Get,PutFunctionConcurrency,UpdateFunctionConfigura... | region CreateFunction functions ParameterValueException - The function creation failure. | In a followup commit (so we can release this today), I will also add this retry condition to the `UpdateFunctionConfiguration` call as well to prevent any odd cases with updating IAM roles or KMS backed environment variables. |
@@ -270,6 +270,9 @@ export class SubscriptionService {
'Selected service not registered');
selectedPlatform.activate(renderState);
+ if (selectedPlatform.isPingbackEnabled()) {
+ selectedPlatform.pingback();
+ }
});
}
| [No CFG could be retrieved] | Provides a singleton instance of the dialog that can be used to unblock the document. Gets the SubscriptionPlatform class for the given node. | We should also always pingback the local platform. And obviously, avoid pinging it back twice. |
@@ -26,6 +26,11 @@ class PyTensorflowEstimator(Package):
extends('python')
+ depends_on('py-keras@2.7.0:2.7', type=('build', 'run'), when='@2.7.0')
+ depends_on('py-keras@2.6.0:2.6', type=('build', 'run'), when='@2.6.0')
+ depends_on('py-tensorflow@2.7.0:2.7', type=('build', 'run'), when='@2.7.0')
+ ... | [PyTensorflowEstimator->[install->[join_path,mkdtemp,working_dir,Executable,setup_py,build_pip_package,bazel,format,remove_linked_tree],depends_on,version,extends]] | A high level TensorFlow Estimator is a high level TensorFlow API that greatly Installs a single - node version of the given spec. | I don't see any deps declared other than TF |
@@ -40,11 +40,5 @@ func (s *Server) NewEndpointDiscoveryResponse(proxy *envoy.Proxy) (*v2.Discovery
Resources: protos,
TypeUrl: string(envoy.TypeEDS),
}
-
- s.lastVersion = s.lastVersion + 1
- s.lastNonce = string(time.Now().Nanosecond())
- resp.Nonce = s.lastNonce
- resp.VersionInfo = fmt.Sprintf("v%d", s.la... | [NewEndpointDiscoveryResponse->[NewClusterLoadAssignment,ListEndpoints,Infof,Sprintf,MarshalAny,Now,Errorf,Nanosecond]] | NewEndpointDiscoveryResponse creates a new discovery response for all endpoints. | We can remove the lastVersion, lastNonse field from the Server struct for EDS,RDS,CDE and LDS |
@@ -720,6 +720,9 @@ class Server:
def update_sources(self, sources: List[BuildSource]) -> None:
paths = [source.path for source in sources if source.path is not None]
+ if self.following_imports():
+ # Filter out directories (used for namespace packages).
+ paths = [path for... | [daemonize->[_daemonize_cb],Server->[find_changed->[find_changed],update_changed->[update_changed],initialize_fine_grained->[following_imports],serve->[_response_metadata]]] | Update the list of sources. | I don't follow this really? |
@@ -442,7 +442,7 @@ function $RootScopeProvider(){
}
// copy the items to oldValue and look for changes.
for (var i = 0; i < newLength; i++) {
- if (oldValue[i] !== newValue[i]) {
+ if (arrayIdentityGetter(i, oldValue[i], i) !== arrayIdentityGetter(i, new... | [No CFG could be retrieved] | Creates a function which will watch the object s properties and change events. check if there are no keys in the oldValue and if there are keys in the new. | we can cash the old id instead of recomputing it... |
@@ -90,7 +90,7 @@ angular.module('<%=angularAppName%>')
})
.state('<%= entityInstance %>-management.edit', {
parent: '<%= entityInstance %>-management',
- url: '/{id:int}/edit',
+ url: '/{id:<% if (databaseType == 'sql') { %>int<% } else if (datab... | [No CFG could be retrieved] | Management dialog controller check if the entity is not in the hierarchy. | @andidev may I suggest doing the conditional in the entity/index.js and assign to a var `this.idType` and then just assign it here? It would be more efficient and less ugly. Infact we should try to move more logic from templates to main js |
@@ -72,13 +72,8 @@ define([
*/
Matrix3.pack = function(value, array, startingIndex) {
//>>includeStart('debug', pragmas.debug);
- if (!defined(value)) {
- throw new DeveloperError('value is required');
- }
-
- if (!defined(array)) {
- throw new DeveloperErr... | [No CFG could be retrieved] | Creates a packed version of the array that is the same as the original array. Retrieves an instance from a packed array. | This would be `Check.defined(array, 'array');` Also for all other arguments below that are of type arrays. |
@@ -95,9 +95,7 @@ func ConfigureOIDCProvider(t *testing.T) error {
}
// DoOAuthExchange does the OAuth dance to log in to the mock provider, given a login URL
-func DoOAuthExchange(t testing.TB, loginURL string) {
- testClient := GetUnauthenticatedPachClient(t)
-
+func DoOAuthExchange(t testing.TB, pachClient, ente... | [SetConfiguration,Add,PostForm,Extra,Ctx,GetIdentityServerConfig,SetIdentityServerConfig,NoError,NewTestingBackOff,Get,Split,DeleteAll,Query,AuthCodeURL,Background,GetAddress,CreateIDPConnector,Exchange,EqualOrErr,String,Parse,CreateOIDCClient,Retry] | DoOAuthExchange creates an OIDC client that does not follow redirects. username password flow redirects back to the dex endpoint and pachd to complete the flow. | This used to assume dex and pachd were all at one address - extend it to support a separate enterprise server context with different ports and/or a different address. |
@@ -55,7 +55,7 @@ do {
// make sure disabled comments stay disabled
$object->enabled = $annotation->enabled;
$object->time_created = $annotation->time_created;
- $object->save();
+ $object->save(false);
$guid = $object->getGUID();
| [getGUID,save] | Create a comment object for the given object Update the data of the comment. | What is this argument supposed to do? I don't see it used internally. |
@@ -129,6 +129,8 @@ DJANGO_PERMISSIONS_MAPPING.update({
'reviewers.delete_reviewerscore': ADMIN_ADVANCED,
+ 'scanners.view_scannersresult': ADMIN_ADVANCED,
+
'users.change_userprofile': USERS_EDIT,
'users.delete_userprofile': ADMIN_ADVANCED,
| [namedtuple,update,vars,defaultdict,isinstance,AclPermission] | This method is a list of all views in the network. RATINGS_MODERATE - RATINGS_MODERATE - RATING. | I wasn't sure this was the right django permission - all of the others are `delete_`, `change_`, or `add_` |
@@ -1029,3 +1029,8 @@ func getRateLimit(i *extensionsv1beta1.Ingress) *types.RateLimit {
return rateLimit
}
+
+func getProtocol(i *extensionsv1beta1.Ingress) string {
+
+ return label.DefaultProtocol
+}
| [loadIngresses->[GetService,Warn,shouldProcessIngress,HasPrefix,GetIngresses,Sprintf,FormatInt,Warnf,JoinHostPort,updateIngressStatus,Errorf,GetEndpoints,getWeight,addGlobalBackend,Debugf],Init->[Init],loadConfig->[Error,GetConfiguration],newK8sClient->[Infof,Sprintf,Parse,Errorf,Getenv],updateIngressStatus->[GetServic... | rate limit for the current request. | This function seems unused. I suppose we can just remove it? |
@@ -8,6 +8,8 @@ module SignUp
prepend_before_action :disable_account_creation, only: [:new, :create]
def show
+ return redirect_to sign_up_email_path unless session[:sp].present?
+
analytics.track_event(Analytics::USER_REGISTRATION_INTRO_VISIT)
end
| [RegistrationsController->[new->[new],create->[new]]] | finds the user object in the system and if it is not found it creates a new. | is this going to prevent registering without an SP? |
@@ -23,13 +23,12 @@ from paddle.fluid.tests.unittests.test_conv2d_op import conv2d_forward_naive, Te
def conv2d_forward_refer(input, filter, group, conv_param):
- out, in_n, out_h, out_w, out_c = conv2d_forward_naive(input, filter, group,
- conv_param)
+ ... | [create_test_int8_class->[TestS8S8Case->[init_data_type->[init_data_type_with_fusion]],TestU8S8ResCase->[init_data_type->[init_data_type_with_fusion]],TestU8S8Case->[init_data_type->[init_data_type_with_fusion]],TestU8U8Case->[init_data_type->[init_data_type_with_fusion]],TestS8U8Case->[init_data_type->[init_data_type_... | 2 - D convolution with 2 - D reference. Compute the non - zero components of a . Compute the non - zero non - zero non - zero non - zero non - zero non. | If we don't want to be stopped by CI-Approval, you can use OpTestTool to skip these tests if int8 is not supported by place. The behavior is identical to using pure "@unittest.skipIf", but since it is a wrapper regex cannot catch that and CI-Approval does not complain about that ` @OpTestTool.skip_if(not core.supports_... |
@@ -71,6 +71,16 @@ def _butterfly_onselect(xmin, xmax, ch_types, evoked, text=None):
"""Function for drawing topomaps from the selected area."""
import matplotlib.pyplot as plt
ch_types = [type for type in ch_types if type in ('eeg', 'grad', 'mag')]
+ if ('grad' in ch_types and FIFF.FIFFV_COIL_VV_PLAN... | [plot_evoked_joint->[plot_evoked_joint,_connection_line,_plot_evoked],plot_evoked_image->[_plot_evoked],_plot_evoked_white->[whitened_gfp],plot_evoked->[_plot_evoked],_plot_evoked->[_plot_legend,_rgb]] | Function for drawing topomaps from the selected area. Show the topography of the missing key. | This looks like a code dup, can you make it DRY |
@@ -170,6 +170,7 @@ public class NiFiProperties extends ApplicationProperties {
public static final String SECURITY_GROUP_MAPPING_PATTERN_PREFIX = "nifi.security.group.mapping.pattern.";
public static final String SECURITY_GROUP_MAPPING_VALUE_PREFIX = "nifi.security.group.mapping.value.";
public static f... | [NiFiProperties->[getFlowConfigurationArchiveMaxTime->[getProperty],getClusterStateProviderId->[getProperty],createBasicNiFiProperties->[size->[size],getProperty->[getProperty],createBasicNiFiProperties,NiFiProperties],getQuestDbStatusRepositoryPath->[getProperty],getEmbeddedZooKeeperPropertiesFile->[getProperty],getHt... | This class is used to provide a list of all the names of the classes that are used Security User OIDC. | This should also be configured in `nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/resources/access-control/nifi.properties` and `nifi-assembly/pom.xml` |
@@ -56,9 +56,8 @@ public class DruidConnection
// Typically synchronized by connectionLock, except in one case: the onClose function passed
// into DruidStatements contained by the map.
- private final ConcurrentMap<Integer, DruidStatement> statements;
-
@GuardedBy("connectionLock")
+ private final Concurr... | [DruidConnection->[getStatement->[get],createStatement->[debug,size,incrementAndGet,copyOf,filterEntries,getKey,contains,remove,ISE,DruidStatement,containsKey,put,factorize],closeIfEmpty->[isEmpty,close],close->[getStatementId,debug,copyOf,warn,close,values],sync->[getAndSet,cancel],Object,newHashSet,AtomicInteger,copy... | Creates a connection object that can be used to manage a connection. Throw an exception if there are too many open statements. | There is an explicit exception stated above here, so guarded by is not correct if I'm reading it |
@@ -96,6 +96,7 @@ const WHITELISTED_KEYS = [
'disableRtx',
'disableSuspendVideo',
'displayJids',
+ 'e2eping',
'enableDisplayNameInStats',
'enableLayerSuspension',
'enableLipSync',
| [No CFG could be retrieved] | A function to create a unique identifier for a call. The functions below are available to the API. | Should the "p" in "ping" be capitalized? |
@@ -138,7 +138,17 @@ public class KsqlConfig extends AbstractConfig {
public static final String KSQL_KEY_FORMAT_ENABLED = "ksql.key.format.enabled";
public static final Boolean KSQL_KEY_FORMAT_ENABLED_DEFAULT = false;
public static final String KSQL_KEY_FORMAT_ENABLED_DOC =
- "Feature flag for non-Kafka ... | [KsqlConfig->[buildConfigDef->[defineLegacy,defineCurrent],ConfigValue->[isResolved->[isResolved]],getKsqlStreamConfigProps->[getKsqlStreamConfigProps],buildStreamingConfig->[applyStreamsConfig],getAllConfigPropsWithSecretsObfuscated->[getKsqlConfigPropsWithSecretsObfuscated],overrideBreakingConfigsWithOriginalValues->... | This method is used to provide the name of the output topics. /TABLE statements. | i've merged the other PR, so if you want to we can rename this (or just leave it as is, i'm OK with that too) |
@@ -103,6 +103,10 @@ function rrdtool_graph($graph_file, $options)
/** @var Proc $rrd_sync_process */
if (rrdtool_initialize(false)) {
+ $now_timestamp = date('Y-m-d H:i:s', time()); // timestamp
+ $watermark_font = ' --font WATERMARK:8:Times'; // Watermark size and font
+ $watermark_t... | [rrdtool_running->[isRunning],rrdtool_close->[close],rrdtool->[sendCommand],rrdtool_graph->[sendCommand],rrdtool_initialize->[setSynchronous]] | This function returns the output of the rrdtool graph command if the system is not initialized. | You don't need the second argument here. Also, this probably isn't the best place for this, since it adds it to EVERY command. It should probably be in the rrd_graph command or just graph.inc.php There should be a setting to disable this (enabled by default) |
@@ -41,7 +41,7 @@ class TarArchiver(Archiver):
"""
@classmethod
- def extract(cls, path, outdir):
+ def _extract(cls, path, outdir):
"""
:API: public
"""
| [ZipArchiver->[extract->[extract]],archiver_for_path->[archiver],ZipArchiver,TarArchiver] | Extract a file from a tar file. | Because this method is `:API: public`, an equivalent method needs to be exposed (although you can definitely add parameters that have defaults). It looks like probably the `:API: public` tag should move to the super class, and the `def _extract` methods should have it removed. Not sure how to handle the `filter_func` a... |
@@ -106,12 +106,13 @@ func (srv *Server) Create(ctx context.Context, in *jobs.Job) (*jobs.Id, error) {
return nil, status.Error(codes.InvalidArgument, "Invalid job: nodes or node selectors required.")
}
- sID, err := srv.db.AddJob(in)
+ sID, name, err := srv.db.AddJob(in)
if err != nil {
return nil, errorut... | [GetJobResultByNodeId->[GetJobResultByNodeId],ListInitiatedScans->[ListInitiatedScans]] | Create creates a new scan job. | I'm a little confused about why we need to change the signature of AddJob. `in` is a `jobs.Job` and should already have the Name assigned to it. I don't see anything in AddJob that mutates that name. I can see some value in being defensive here since AddJob mutates `Id` we should indeed maybe assume it mutates everythi... |
@@ -74,7 +74,7 @@ class XCRun(object):
def cmd_output(cmd):
return check_output_runner(cmd).strip()
- command = ['xcrun', '-find']
+ command = ['xcrun']
if self.sdk:
command.extend(['-sdk', self.sdk])
command.extend(args)
| [XCRun->[find->[_invoke],sdk_platform_path->[_invoke],strip->[find],sdk_platform_version->[_invoke],_invoke->[cmd_output],sdk_version->[_invoke],cc->[find],__init__->[apple_sdk_name],sdk_path->[_invoke],ranlib->[find],libtool->[find],ar->[find],cxx->[find]],apple_dot_clean->[apple_dot_clean]] | Invoke the nexus - check - find command. | okay, there is already `--find` in the `find` method, so it's kinda redundand |
@@ -0,0 +1,11 @@
+// @flow
+/*global module*/
+
+module.exports = {
+ rootDir: 'src',
+ setupFiles: ['<rootDir>/e2e-test.setup.js'],
+ testMatch: [/e2e.js/],
+ testEnvironment: 'node',
+ testPathIgnorePatterns: ['/node_modules/', '/dist/'],
+ snapshotSerializers: ['enzyme-to-json/serializer'],
+};
| [No CFG could be retrieved] | No Summary Found. | do we need this in e2e tests? They usually don't test some internal states\props of components. e2e cares only about result from user perspective as much as possible |
@@ -325,7 +325,7 @@ public class WSConsumer implements MessageProcessor, Initialisable, MuleContextA
}
if (!inConfigProperties.isEmpty())
{
- cxfBuilder.getInInterceptors().add(new WSS4JInInterceptor(inConfigProperties));
+ cxfBuilder.getInInterceptor... | [WSConsumer->[process->[process],createSoapHeadersPropertiesRemoverMessageProcessor->[processResponse->[processResponse],processRequest->[processRequest]],createCopyAttachmentsMessageProcessor->[processResponse->[processResponse],processNext->[processNext],processRequest->[processRequest]],dispose->[dispose],createProp... | Creates a CXF outbound message processor. Add OutputSoapHeadersInterceptor to CXF outbound message processor. | would there be some scenario where we want to keep this validation anyway? |
@@ -101,7 +101,7 @@ class DoctrineListBuilder extends AbstractListBuilder
} elseif ($numResults == 1) {
$result = array_values($result[0]);
- return $result[0];
+ return (int) $result[0];
}
return 0;
| [DoctrineListBuilder->[getEntityNamesOfFieldDescriptors->[getJoins],createQueryBuilder->[assignGroupBy],assignJoins->[getJoins],createSubQueryBuilder->[getJoins],getJoins->[getJoins]]] | Count the number of objects in the repository. | Why not `intval($result[0])`? I would prefer this! |
@@ -2963,8 +2963,8 @@ evt_sdist_split(struct evt_context *tcx, bool leaf, struct evt_node *nd_src,
done:
entry_src = evt_node_entry_at(tcx, nd_src, nr);
entry_dst = evt_node_entry_at(tcx, nd_dst, 0);
- memcpy(entry_dst, entry_src, sizeof(*entry_dst) * (nd_src->tn_nr - nr));
-
+ umem_tx_memcpy(evt_umm(tcx), entry_d... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - END of method evt_common_insert. | (style) 'nd' may be misspelled - perhaps 'and'? |
@@ -88,9 +88,10 @@
<%= sanitize_input(key['source_data']['link'].html_safe) %>
<% end %>
<% when '19'%>
+ <% step_info_string += key['source_data']['body'] %>
<br>
<strong><%= key['name']+': ' %></strong>
- <%= sanitize... | [No CFG could be retrieved] | find unique key in component loop. | Same here. Use each each_with_index. |
@@ -12,6 +12,17 @@
<p><strong><%= note.user.user_name %>: </strong></p>
<p><small><%=note.format_date%></small></p>
<p><%= note.notes_message %></p>
+ <% if allowed_to?(:modify?, note) %>
+ <%= button_to t('delete'),
+ { action: 'destroy',
+ ... | [No CFG could be retrieved] | Displays a hidden element that displays a hidden element with a message and a list of all notes Dodaje dane dane dane dane dane dane dane. | Hmm, there shouldn't be both `class` here and down below on line 24. |
@@ -586,6 +586,9 @@ public class PutFromLoadValidator {
continue;
}
long now = regionFactory.nextTimestamp();
+ if (trace) {
+ log.tracef("endInvalidatingKey(%s#%s, %s) remove invalidator from %s", cache.getName(), key, lockOwnerToString(lockOwner), pending);
+ ... | [PutFromLoadValidator->[endInvalidatingKey->[endInvalidatingKey],PendingPutMap->[size->[size],canRemove->[size,hasInvalidator],pferValueIfNeeded->[remove],removeInvalidator->[remove],invalidate->[remove,invalidate],remove->[remove],gc->[size,remove,gc],put->[put],toString->[toString],addInvalidator->[put,remove]],Inval... | This method is called from the cache invalidation thread. It will acquire a lock and add a. | Could you format the whole method with correct indentation? |
@@ -7,6 +7,10 @@ class ServiceProviderUpdater
updated_at
].to_set.freeze
+ SP_IGNORED_ATTRIBUTES = %i[
+ cert
+ ]
+
def run
dashboard_service_providers.each do |service_provider|
update_local_caches(HashWithIndifferentAccess.new(service_provider))
| [ServiceProviderUpdater->[dashboard_response->[get],sync_model->[is_a?,create!,update],update_cache->[destroy_all,create_or_update_service_provider],create_or_update_service_provider->[cleaned_service_provider,from_issuer,sync_model,native?],parse_service_providers->[parse],log_error->[error],url->[dashboard_url],dashb... | Find any missing service provider and update local caches. | **Question:** Should we also ignore this in `ServiceProviderSeeder`? |
@@ -86,15 +86,9 @@ class ProcessMetadataManager:
INFO_INTERVAL_SEC = 5
WAIT_INTERVAL_SEC = 0.1
- def __init__(self, metadata_base_dir=None):
- """
- :param str metadata_base_dir: The base directory for process metadata.
- """
+ def __init__(self, metadata_base_dir: str) -> None:
... | [FingerprintedProcessManager->[fingerprint->[read_metadata_by_name],needs_restart->[is_dead,has_current_fingerprint]],ProcessManager->[daemon_spawn->[purge_metadata],await_socket->[await_metadata_by_name],terminate->[NonResponsiveProcess,purge_metadata,_kill,_deadline_until,is_alive],get_subprocess_output->[ExecutionEr... | Initialize the object with a base directory for the process metadata. | This was always configured in production. It allows us to remove `Subprocess`, which I'm not sure even worked still. |
@@ -1,12 +1,15 @@
# frozen_string_literal: true
+
# typed: strict
module Project::Bar
class BarClass
extend T::Sig
- sig {params(value: Integer).void}
+ sig { params(value: Integer).void }
def initialize(value)
@value = T.let(value, Integer)
end
end
+
+ class UnexportedClass; end... | [BarClass->[initialize->[let],void,extend,sig]] | Initialize a new index with a value. | Adding an additional constant to ensure that un-exported constants don't get exposed by mistake. |
@@ -2499,6 +2499,14 @@ do_dc_obj_fetch(tse_task_t *task, daos_obj_fetch_t *args,
if (rc != 0)
D_GOTO(out_task, rc);
+ if (!obj_auxi->io_retry) {
+ rc = csum_obj_fetch(obj, args, obj_auxi);
+ if (rc != 0) {
+ D_ERROR("csum_obj_fetch error: %d", rc);
+ D_GOTO(out_task, rc);
+ }
+ }
+
rc = obj_rw_bulk_prep... | [No CFG could be retrieved] | read - only object find the object that the DAO needs to be updated. | minor, maybe can return if !io_retry inside csum_obj_fetch to be the same style as obj_rw_bulk_prep. same for csum_obj_update |
@@ -254,7 +254,7 @@ class Search
def execute(readonly_mode: Discourse.readonly_mode?)
if log_query?(readonly_mode)
status, search_log_id = SearchLog.log(
- term: @term,
+ term: @clean_term,
search_type: @opts[:search_type],
ip_address: @opts[:ip_address],
user_id:... | [Search->[category_search->[limit],user_search->[limit],secure_category_ids->[secure_category_ids],posts_query->[offset,limit],aggregate_search->[aggregate_post_sql],private_messages_search->[aggregate_search],tags_search->[limit],initialize->[prepare_data],all_topics_search->[aggregate_search],limit->[per_filter,per_f... | Initialize a new instance of the class. | `@term` contains the search term stripped of special keywords like `@user` or `in:title` and the like. |
@@ -631,7 +631,8 @@ namespace System.Windows.Forms.ButtonInternal
Region oldClip = graphics.Clip;
if (!layout.options.everettButtonCompat)
- { // FOR EVERETT COMPATIBILITY - DO NOT CHANGE
+ {
+ // FOR EVERETT COMPATIBILITY - DO NOT CHANGE
... | [ButtonBaseAdapter->[ColorOptions->[ColorData->[Adjust255]],DrawImageCore->[DrawImage],LayoutOptions->[LayoutTextAndImage->[Size],StringFormat,Size,TextImageRelation],DrawText->[DrawText,Color],PaintField->[DrawText,DrawFocus],PaintImage->[DrawImage]]] | DrawImageCore - Draw the image in core space. | >EVERETT [](start = 23, length = 7) At some point we were getting rid of the internal product names in favor of FX versions, missed this one I suppose. |
@@ -84,8 +84,14 @@ class DatasetReader(Registrable):
parameters you set for this DatasetReader!_
"""
- def __init__(self, lazy: bool = False, cache_directory: str = None) -> None:
+ def __init__(
+ self,
+ lazy: bool = False,
+ cache_directory: Optional[str] = None,
+ m... | [_LazyInstances->[__init__->[super],__iter__->[write,instance_generator,serialize,deserialize,isinstance,exists,open,ConfigurationError]],DatasetReader->[serialize_instance->[dumps],_get_cache_location_for_file_path->[str,flatten_filename],deserialize_instance->[loads],_instances_from_cache_file->[deserialize_instance,... | Initialize the object with a random identifier. | Can you add this to the docstring? |
@@ -77,7 +77,8 @@ const containerIdLen = 64
const podUIDPos = 5
func (f *LogPathMatcher) MetadataIndex(event common.MapStr) string {
- if value, ok := event["log"].(common.MapStr)["file"].(common.MapStr)["path"]; ok {
+ value, err := event.GetValue("log.file.path")
+ if err == nil {
source := value.(string)
l... | [MetadataIndex->[Split,Contains,HasPrefix,HasSuffix,Debug],Unpack,AddDefaultIndexerConfig,AddDefaultMatcherConfig,AddMatcher,NewConfig,Errorf,Debug] | MetadataIndex returns the container ID that should be used to index the log file in the log This function extracts the container id from the source value. | I think it's most common in Go to return early on error and reduce the level of nesting. How about `if err != nil { return "" }`? |
@@ -19,5 +19,7 @@ internal partial class Interop
BCRYPT_SHA512_ALG_HANDLE = 0x00000061,
BCRYPT_PBKDF2_ALG_HANDLE = 0x00000331,
}
+
+ internal static bool PseudoHandlesSupported { get; } = OperatingSystem.IsWindowsVersionAtLeast(10, 0, 0);
}
}
| [No CFG could be retrieved] | 0x00000061 - > 0x00000061 - > 0x00000061 - >. | @GrabYourPitchforks Does this need to be a `static readonly` field for the JIT do to its "ooh, I can fold this away" magic, or will it peek through the property like this? |
@@ -199,7 +199,7 @@ public class RocketMQFirehoseFactory implements FirehoseFactory<InputRowParser<B
return new Firehose()
{
- private Iterator<InputRow> nextIterator = Iterators.emptyIterator();
+ private Iterator<InputRow> nextIterator = EmptyIterator.instance();
@Override
public... | [RocketMQFirehoseFactory->[connect->[hasMore->[hasMessagesPending]],DruidPullMessageService->[onWaitEnd->[swapRequests],doPull->[isLongPull,getNextBeginOffset,getMessageQueue,getPullBatchSize,getTag],run->[getServiceName,doPull,swapRequests]]]] | Connects to a remote Kafka consumer. Returns the next input row in the input stream. This method is called when a thread is committed and the last offset in the windows is updated. | Why not `Collections.emptyIterator()`? |
@@ -117,7 +117,7 @@ public class TcpInboundGateway extends MessagingGatewaySupport implements
}
private boolean doOnMessage(Message<?> message) {
- Message<?> reply = this.sendAndReceiveMessage(message);
+ Message<?> reply = sendAndReceiveMessage(message);
if (reply == null) {
if (logger.isDebugEnabled()... | [TcpInboundGateway->[doStart->[doStart],isListening->[isListening],doStop->[doStop],onInit->[onInit]]] | This method is called when a message is received from the client. | Need to catch and swallow `MessageTimeoutException` to retain existing behavior when no EC or error flow returns `null`. |
@@ -301,10 +301,14 @@ func (c *amazonClient) transformError(err error, objectPath string) error {
if strings.Contains(err.Error(), "Not Found") {
return pacherr.NewNotExist(c.bucket, objectPath)
}
- var awsErr awserr.Error
- if !errors.As(err, &awsErr) {
+ awsErr, ok := err.(awserr.Error)
+ if !ok {
return er... | [Exists->[IsNotExist,transformError,String,HeadObjectWithContext,TagAnySpan],transformError->[As,Error,Message,Contains,NewNotExist,WrapTransient,Code],Put->[transformError,String,WithCancel,UploadWithContext],Delete->[transformError,String,DeleteObjectWithContext],Get->[NewRequest,GetObject,FinishAnySpan,Now,Close,New... | transformError converts an error from the AWS API to a Pach error. | pretty sure we should be using `errors.As` instead of casting as a general rule since we have wrapped errors around |
@@ -499,7 +499,7 @@ Number Keys are the only keys not having a function in BASIC Mode (hence, they o
in EXT+Shift Mode on a real Spectrum).
*/
-/* TO DO: replace PORT_CHAR('\xD7') with an 'empty' PORT_CHAR. I used \xD7 (multiplication sign) just as a placeholder. There should be no
+/* TO DO: replace PORT_CHAR(0xD7... | [No CFG could be retrieved] | Presses a key on the keyboard. NAME PORT_CODE - > PORT_CHAR. | It might be a good idea to map the alternate functions of the number row to the F-keys in natural keyboard mode. Probably better than making them all respond to multiplication sign. |
@@ -454,6 +454,7 @@ namespace System.Net.Quic.Implementations.MsQuic
{
uint status = MsQuicApi.Api.StreamShutdownDelegate(_state.Handle, flags, errorCode);
QuicExceptionHelpers.ThrowIfFailed(status, "StreamShutdown failed.");
+ _canWrite = false;
}
inter... | [MsQuicStream->[Shutdown->[StartShutdown],Dispose->[Dispose],CleanupSendState->[Dispose],ValueTask->[StartShutdown,CleanupSendState,HandleWriteFailedState],Dispose]] | Start shutdown. | Is this correct? What if we're aborting read? And aren't we setting up the `_canRead/Write` fields before we call this method? |
@@ -260,7 +260,7 @@ public abstract class Controller {
* @return the directory of the internal repository for the Mule runtime.
*/
protected File getRuntimeInternalRepository() {
- return new File(muleHome, "repository");
+ return this.internalRepository;
}
public File getLog() {
| [Controller->[installLicense->[runSync],uninstallLicense->[runSync],addLibrary->[verify],isRunning->[status],deployDomain->[verify],deploy->[verify]]] | get the runtime internal repository. | This method is now returning something that could not be an internal repository |
@@ -172,7 +172,7 @@ func (cfg *TSDBConfig) RegisterFlags(f *flag.FlagSet) {
f.DurationVar(&cfg.HeadCompactionIdleTimeout, "experimental.blocks-storage.tsdb.head-compaction-idle-timeout", 1*time.Hour, "If TSDB head is idle for this duration, it is compacted. 0 means disabled.")
f.IntVar(&cfg.StripeSize, "experimenta... | [String->[String],RegisterFlags->[RegisterFlags],Validate->[Validate]] | RegisterFlags registers flags for the TSDBConfig Validate - validates the configuration for a new block - based TSDB. | I'd remove "uploaded when finished" part -- that depends on shipper configuration. |
@@ -831,6 +831,7 @@ namespace Js
if (cse->ei.bstrDescription)
{
value = JavascriptString::NewCopySz(cse->ei.bstrDescription, scriptContext);
+ JavascriptOperators::OP_SetProperty(error, PropertyIds::description, value, scriptContext);
JavascriptOperators::OP_SetPro... | [No CFG could be retrieved] | Creates a new error of the same type as the target error. This function checks if the value is in the line and if so sets it in the error. | >description [](start = 68, length = 11) Isn't description IE specific? where ever we use description instead of message seems like a compat issue? |
@@ -37,11 +37,13 @@ public class LongSumAggregatorFactory implements AggregatorFactory
private final String fieldName;
private final String name;
+ private final int exponent;
@JsonCreator
public LongSumAggregatorFactory(
@JsonProperty("name") String name,
- @JsonProperty("fieldName") final... | [LongSumAggregatorFactory->[hashCode->[hashCode],getRequiredColumns->[LongSumAggregatorFactory],getCombiningFactory->[LongSumAggregatorFactory],equals->[equals]]] | Creates an AggregatorFactory that creates a LongSumAggregator from a given column selector factory. This method is overridden to provide a custom LongSumBufferAggregator. | needs an updated cache key for all factories. |
@@ -69,6 +69,9 @@ public class DefaultMuleEvent implements MuleEvent, ThreadSafeAccess, Deserializ
private static Log logger = LogFactory.getLog(DefaultMuleEvent.class);
+ /** EventId is concatenated with a dash character and a default clusterNodeId (a zero) .**/
+ public static final int DEFAULT_LENGTH_... | [DefaultMuleEvent->[transformMessageToString->[transformMessage],getEncoding->[getEncoding],initAfterDeserialisation->[initAfterDeserialisation],newThreadCopy->[newThreadCopy,DefaultMuleEvent],writeObject->[getFlowConstruct,writeObject],copy->[getSession,newThreadCopy,DefaultMuleEvent,resetAccessControl],equals->[equal... | The default MuleEvent class. Called when the client writes data to the stream. | you need two digits for the cluster id |
@@ -157,6 +157,13 @@ class FileEntriesSerializer(FileSerializer):
mime_type = mime.split('/')[0]
known_types = ('image', 'text')
+ if mime_type == 'text':
+ # Allow text mimetypes to be more specific for readable
+ # files. `python-magic`/`libmagic` usually just returns
... | [FileEntriesSerializer->[get_content->[git_repo,get_selected_file,_get_commit],get_selected_file->[get_entries],get_entries->[_get_commit]],AddonBrowseVersionSerializer->[FileEntriesSerializer]] | Returns the mimetype and type category of an entry. | FWIW I found this one-liner confusing to read - the inline `if` applies to the second part but that wasn't immediately obvious :) |
@@ -111,9 +111,9 @@ func schemaNodeConfig() *schema.Schema {
Type: schema.TypeMap,
Optional: true,
Computed: true,
- ForceNew: true,
+ ForceNew: false,
Elem: &schema.Schema{Type: schema.TypeString},
- Description: `The metadata key/value pairs assigned to in... | [NewSet,IntAtLeast,List,StringInSlice,Len] | Description of a node s image type. returns the canonicalized service scope of the node. | `Description` shouldn't have to change here, as the current description describes what the field is. |
@@ -491,7 +491,7 @@ class Reverter(object):
else:
logger.warning(
"File: %s - Could not be found to be deleted %s - "
- "LE probably shut down unexpectedly",
+ "Certbot probably shut down une... | [Reverter->[register_file_creation->[_read_and_append],_timestamp_progress_dir->[_checkpoint_timestamp],recovery_routine->[revert_temporary_config,_recover_checkpoint]]] | Removes all files contained within file_list. If file_list does not exist or if. | Nice catch. Looks like I missed this one during the rename. |
@@ -744,7 +744,8 @@ MlasConvTryMultithread(
const float* Filter,
const float* Bias,
float* WorkingBuffer,
- float* Output
+ float* Output,
+ const ThreadPool* ExternalThreadPool
)
/*++
| [No CFG could be retrieved] | The non - threaded GEMM routine. - - - - - - - - - - - - - - - - - -. | ExternalThreadPool is not used on Linux. It will generate a warning. |
@@ -516,7 +516,7 @@ function dfrn_request_post(&$a) {
if(! count($parms)) {
notice( t('Profile location is not valid or does not contain profile information.') . EOL );
- goaway($a->get_baseurl() . '/' . $a->cmd);
+ goaway(App::get_baseurl() . '/' . $a->cmd);
}
else {
if(! x($parms,... | [dfrn_request_post->[get_baseurl,get_hostname,get_path],dfrn_request_content->[get_baseurl]] | This function is called when a user requests a contact from a cell. It is called by This function is called to check if a contact has already been issued. This function creates a contact record on our site for the other person in the system. | Standards: Could you please add a space after the `if`? |
@@ -7278,7 +7278,7 @@ namespace System.Windows.Forms
// Cleanup any font handle wrapper...
DisposeFontHandle();
- if (IsHandleCreated && !GetStyle(ControlStyles.UserPaint))
+ if (IsHandleCreated)
{
SetWindowFont();
}
| [Control->[OnSystemColorsChanged->[OnSystemColorsChanged,Invalidate],UpdateRoot->[GetTopLevel],OnFontChanged->[GetAnyDisposingInHierarchy,Font,DisposeFontHandle,GetStyle,Invalidate],AccessibilityNotifyClients->[AccessibilityNotifyClients],OnParentFontChanged->[OnFontChanged],AutoValidate->[AutoValidate],OnParentBackCol... | called when the font of the control has changed. | Had this change been tested on all "native" controls? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.