patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -33,13 +33,13 @@ spec:
name: http
protocol: HTTP
hosts:
- - <%= app.baseName.toLowerCase() %>.<%= kubernetesNamespace %><%= ingressDomain %>
+ - <%= app.baseName.toLowerCase() %>.<%= ingressDomain %>
- port:
number: 80
name: http2
protocol: HTTP2
hosts:
- - <%... | [No CFG could be retrieved] | This function returns a description of the object that represents a single . Exception - handler for the N - HTTP - Gateway response. | I see no harm in having the host name like this (without K8s namespace). Since this will be deployed to a specific namespace, 'host' would get resolved automatically. But, as you know, in general, services (normal/headless) in k8s (without any modification) get assigned a default DNS 'A' name record of the form {servic... |
@@ -49,11 +49,11 @@ InviteRedeemer = Struct.new(:invite, :username, :name, :password) do
end
def process_invitation
+ approve_account_if_needed
add_to_private_topics_if_invited
add_user_to_invited_topics
add_user_to_groups
send_welcome_message
- approve_account_if_needed
notify_in... | [send_welcome_message->[send_welcome_message],get_invited_user->[create_user_from_invite]] | Process an individual user - group - group - group - invite - node - message - reply. | I probably do not have enough context but what is the reason we need to move this up? |
@@ -156,7 +156,7 @@ namespace System.Reflection.TypeLoading
}
if ((bindingAttr & BindingFlags.ExactBinding) != 0)
- return System.DefaultBinder.ExactPropertyBinding(candidates.ToArray(), returnType, types, modifiers);
+ return System.DefaultBinde... | [RoType->[NeedToSearchImmediateTypeOnly->[FlattenHierarchy,Static,Instance,DeclaredOnly],EventInfo->[Disambiguate],GetEvents->[ToArray],ConstructorInfo->[GetDefaultBinder,Add,Count,QualifiesBasedOnParameterCount,SelectMethod,ExactBinding,Assert,GetParametersNoCopy,ToArray,Length],GetConstructors->[ToArray],GetFields->[... | Override GetPropertyImpl to allow for a specific property. returns null if no candidates. | NIT: `returnType` and `modifiers` could be nullable for the method `System.DefaultBinder.ExactPropertyBinding( ... )` |
@@ -24,11 +24,15 @@ if ($_SESSION['userlevel'] == 11) {
$changepass_message = 'Incorrect password';
}
}
+ if ($_POST['action'] == 'changedash') {
+ if (!empty($vars['dashboard'])) {
+ dbUpdate(array('dashboard'=>$vars['dashboard']), 'users', 'user_id = ?', array($_SESSION... | [No CFG could be retrieved] | Displays the user preferences page. Displays a hidden input for the n - tuple password hash. | should use `===` |
@@ -271,8 +271,10 @@ type MasterConfig struct {
// AuditConfig holds information related to auditing capabilities.
AuditConfig AuditConfig `json:"auditConfig"`
- // EnableTemplateServiceBroker is a temporary switch which enables TemplateServiceBroker.
- EnableTemplateServiceBroker bool `json:"enableTemplateServic... | [No CFG could be retrieved] | Configuration for a single non - master node. | i'd prefer an explicit enabled/disabled field, mainly so that I don't have to erase all my configuration just to disable the broker temporarily (or re-add all my configuration to re-enable it). I'm sure there are many opinions on that, but I just wanted to voice mine... |
@@ -383,6 +383,7 @@ public class DefaultHttp2OutboundFlowController implements Http2OutboundFlowCont
private int pendingBytes;
private int priorityBytes;
private int allocatedPriorityBytes;
+ private ChannelFuture lastWrite;
private OutboundFlowState(Http2Stream stream) {
... | [DefaultHttp2OutboundFlowController->[writePendingBytes->[flush],writeAllowedBytes->[state,connectionWindow,writeAllowedBytes],state->[state],connectionState->[state],OutboundFlowState->[writeBytes->[writableWindow,hasFrame,peek],Frame->[writeError->[size],write->[size,write,incrementStreamWindow,writeData],split->[siz... | The outbound flow control state for a single stream. int - Returns the maximum number of pending bytables in the stream and connection windows. | nit: Consider renaming because of the context we are in. In the `OutboundFlowState` context this is just the last `newFrame` that was created. |
@@ -142,7 +142,8 @@ class AtisDatasetReader(DatasetReader):
'world' : world_field,
'linking_scores' : ArrayField(world.linking_scores)}
- if sql_query:
+ if sql_query_labels != None:
+ fields['example_sql_queries'] = MetadataField(sql_query_labels)
... | [AtisDatasetReader->[text_to_instance->[get_action_sequence,split,debug,ArrayField,all_possible_actions,AtisWorld,append,tokenize,ProductionRuleField,IndexField,join,enumerate,ListField,Instance,lower,TextField,MetadataField],__init__->[SingleIdTokenIndexer,super,WordTokenizer,SpacyWordSplitter],_read->[text_to_instanc... | Convert a list of strings representing a sequence of words into a single instance of a . Adds the action sequence field to the fields. | I think you gave it this name because of `example_string` in the wikitables code. That's referring to the `.examples` files that come with wikitables; I'd probably just call this `sql_queries` or `sql_query_strings`. |
@@ -319,9 +319,12 @@ public class VirtualRoutingResource {
}
public boolean configureHostParams(final Map<String, String> params) {
- if (_params.get("router.aggregation.command.each.timeout") == null) {
+ if (_params.get("router.aggregation.command.each.timeout") != null) {
Strin... | [VirtualRoutingResource->[connect->[connect],applyConfigToVR->[applyConfigToVR],execute->[generateCommandCfg,applyConfigToVR],executeQueryCommand->[execute],applyConfig->[applyConfigToVR]]] | Method to configure host parameters. | I am +1 on externalizing 600 into a constant. |
@@ -398,6 +398,7 @@ public class TestTreeIndexing {
}
@Test
+ @Deploy("org.nuxeo.elasticsearch.core.test:dummy-bulk-login-config.xml")
public void shouldReindexSubTreeInTrash() throws Exception {
buildAndIndexTree();
startTransaction();
| [TestTreeIndexing->[shouldIndexMovedSubTree->[buildAndIndexTree,waitForCompletion,assertNumberOfCommandProcessed,search,startTransaction,searchAll],shouldStoreOnlyEffectiveACEs->[buildAndIndexTree,waitForCompletion,getRestrictedSession,startTransaction],shouldIndexOnCopy->[buildAndIndexTree,waitForCompletion,startTrans... | This test method is used to test if a sub - tree should be reindexed in the. | You can use the one present in `nuxeo-core-bulk`test-jar. |
@@ -286,6 +286,7 @@ class Product(CountableDjangoObjectType):
Money,
description=dedent("""The product's base price (without any discounts
applied)."""))
+ tax_rate = TaxRateType(description='A type of tax rate.')
attributes = graphene.List(
graphene.NonNull(SelectedAttribute... | [ProductVariant->[resolve_attributes->[resolve_attribute_list]],Category->[resolve_background_image->[resolve_background_image]],Product->[resolve_availability->[ProductAvailability],resolve_attributes->[resolve_attribute_list],resolve_thumbnail->[Image],resolve_margin->[Margin]],Collection->[resolve_background_image->... | Represents an image for a given product. A list of nodes. | The `a type of...` is sounding weird to me. What do you think of: `The tax rate type.` ? |
@@ -60,9 +60,8 @@ public class DDLCommandExec {
try {
return ddlCommand.run(metaStore);
} catch (Exception e) {
- String stackTrace = ExceptionUtil.stackTraceToString(e);
LOGGER.warn(String.format("executeOnMetaStore:%s", ddlCommand), e);
- return new DDLCommandResult(false, stackTrace... | [DDLCommandExec->[executeOnMetaStore->[stackTraceToString,DDLCommandResult,format,run,warn],tryExecute->[executeOnMetaStore,KsqlException],execute->[executeOnMetaStore],getLogger]] | Execute DDLCommand on metaStore. | @hjafarpour - i think we should pass the full exception all the way back instead of just the msg. |
@@ -719,8 +719,10 @@ def migrate_legacy_dictionary_to_webextension(addon):
parsed_data = parse_addon(upload, user=user)
# Create version.
+ # WebExtension dictionaries are only compatible with Firefox Desktop
+ # Firefox for Android uses the OS spellchecking.
version = Version.from_upload(
- ... | [theme_checksum->[make_checksum],calc_checksum->[make_checksum],rereviewqueuetheme_checksum->[make_checksum],add_static_theme_from_lwt->[_get_lwt_default_author],save_theme_reupload->[rereviewqueuetheme_checksum,save_persona_image],save_theme->[create_persona_preview_images,theme_checksum,save_persona_image],migrate_lw... | Migrate a single legacy dictionary to webextension format. | nit: "Firefox" is ambiguous - "Firefox Desktop" is clearer |
@@ -672,7 +672,7 @@ public class InterpreterFactory implements InterpreterGroupFactory {
Interpreter interpreter;
for (InterpreterInfo info : interpreterInfos) {
if (option.isRemote()) {
- if (option.isConnectExistingProcess()) {
+ if (option.isExistingProcess()) {
interpreter ... | [InterpreterFactory->[getDefaultInterpreterSetting->[getDefaultInterpreterSetting,get,getInterpreterSettings],createRepl->[get],getInterpreterListFromJson->[getInterpreterListFromJson],remove->[saveToFile,remove],get->[get,remove,add],close->[add],removeRepository->[saveToFile],restart->[get],createOrGetInterpreterList... | Create interpreters for a note. create a repl. | I think `InterpreterOption.isConnectExistingProcess()` is no longer used in anywhere in the code base. To avoid confusion between `InterpreterOption.isConnectExistingProcess()` and `InterpreterOption. isExistingProcess()`, @astroshim could you remove `InterpreterOption.isConnectExistingProcess()` method? |
@@ -246,4 +246,14 @@ public class ParametersDefinitionProperty extends OptionalJobProperty<Job<?, ?>>
public String getUrlName() {
return null;
}
+
+ private class DefinitionsAbstractList extends AbstractList<String> {
+ public String get(int index) {
+ return parameterDefinition... | [ParametersDefinitionProperty->[_doBuild->[get,getJob,_doBuild],buildWithParameters->[buildWithParameters],getParameterDefinitionNames->[size->[size]],getJobActions->[getJobActions],DescriptorImpl->[newInstance->[newInstance]],readResolve->[ParametersDefinitionProperty]]] | get url name. | If we want to serialize it over the channel, maybe it's better to make the class static as well. Otherwise bits of the parent class will be serialized as well |
@@ -1105,12 +1105,11 @@ class RenewableCert(object):
logger.debug("Writing new private key to %s.", target["privkey"])
f.write(new_privkey)
# Preserve gid and (mode & 074) from previous privkey in this lineage.
- old_mode = stat.S_IMODE(os.stat(old_privkey).st_m... | [RenewableCert->[next_free_version->[newest_available_version],save_successor->[next_free_version,update_configuration,config_with_defaults],new_lineage->[_write_live_readme_to,full_archive_path,lineagename_for_filename,_full_live_path,relevant_values,write_renewal_config,_relpath_from_file],_fix_symlinks->[_previous_s... | Save a new version of a private key as a successor of a new version. Writes a new private key to the target file and updates the renewal configuration. | nit: Can we pass these booleans as keyword arguments rather than positional arguments? |
@@ -191,6 +191,16 @@ final class DocumentationNormalizer implements NormalizerInterface
$responseDefinitionKey = $this->getDefinition($definitions, $collection, false, $resourceMetadata, $resourceClass, $operationName);
$pathOperation['produces'] ?? $pathOperation['produces'] = $mimeTypes;
+ ... | [DocumentationNormalizer->[getDefinitionSchema->[normalize],getFiltersParameters->[getType],getType->[getType]]] | Updates the get operation. | Please use `!$parameters` (the call to empty is useless). |
@@ -42,7 +42,7 @@ func ValidateEtcdConnectionInfo(config api.EtcdConnectionInfo, server *api.EtcdC
// Require a client cert to connect to an etcd that requires client certs
if len(server.ServingInfo.ClientCA) > 0 {
if len(config.ClientCert.CertFile) == 0 {
- allErrs = append(allErrs, field.Required(fldPath... | [Has,Invalid,Join,Append,Index,Sprintf,AddErrors,List,Child,UseTLS,NewString,Required] | ValidateEtcdConfig validates a etcd config and returns a list of errors if any. Validate the bindNetwork and namedCertificates fields of the ServingInfo object. | Use of "to" feels wrong here since this is a server talking to itself |
@@ -11,7 +11,6 @@ namespace System.Windows.Forms.Design
/// <summary>
/// Provides access to get and set option values for a designer.
/// </summary>
- [ComVisible(true)]
public class DesignerOptions
{
private const int MinGridSize = 2;
| [DesignerOptions->[DesignerOptions_ShowGridDisplayName,DesignerOptions_SnapToGridDisplayName,DesignerOptions_EnableInSituEditingDesc,DesignerOptions_EnableInSituEditingCat,DesignerOptions_CodeGenSettings,DesignerOptions_OptimizedCodeGen,DesignerOptions_ObjectBoundSmartTagAutoShow,Width,Height,DesignerOptions_GridSizeDe... | Relations for the base designer options. Very basic property that allows or disables snaplines in the designer. | @JeremyKuhne might want to check that the new VS designer doesn't use those, but I really doubt it, given the IID is new and not explicitly specified. |
@@ -297,9 +297,6 @@ class RegionProposalNetwork(torch.nn.Module):
self.head = head
self.box_coder = det_utils.BoxCoder(weights=(1.0, 1.0, 1.0, 1.0))
- # used during training
- self.box_similarity = box_ops.box_iou
-
self.proposal_matcher = det_utils.Matcher(
fg_io... | [concat_box_prediction_layers->[permute_and_flatten],AnchorGenerator->[forward->[set_cell_anchors,cached_grid_anchors],set_cell_anchors->[generate_anchors],cached_grid_anchors->[grid_anchors]],RegionProposalNetwork->[_get_top_n_idx->[pre_nms_top_n,_onnx_get_num_anchors_and_pre_nms_top_n],forward->[concat_box_prediction... | Initialize the region proposal network from a sequence of n - tuple. | Do we need this change? Can we keep as it was before? |
@@ -0,0 +1,9 @@
+require "rails_helper"
+
+RSpec.describe BanishedUser, type: :model do
+ describe "validations" do
+ describe "builtin validations" do
+ it { is_expected.to validate_uniqueness_of(:username).case_insensitive }
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I'm generally not a big fan of specs like this, since they basically just retest Rails. But you have them on other models, so I went for consistency. |
@@ -521,7 +521,10 @@ func (s *ReadStep) Apply(preview bool) (resource.Status, StepCompleteFunc, error
}
complete := func() { s.event.Done(&ReadResult{State: s.new}) }
- return resource.StatusOK, complete, nil
+ if resourceError == nil {
+ return resourceStatus, complete, nil
+ }
+ return resourceStatus, complete... | [Apply->[URN],Prefix->[Color],Plan,Type,Provider,URN] | Apply performs the read step. | It's interesting that the semantics here are to fail a deployment if we ever `Read` a resource that's in an unhealthy state. After thinking about it I think this makes sense, but it's also a little strange since Pulumi wasn't involved in resources that get read via `ReadStep`s. |
@@ -28,6 +28,8 @@ export type HeadCellPropsT = {|
},
/** Column title. */
title: string,
+ /** Extend click enable click to sort on whitespace in a header cell. */
+ extendClick?: boolean,
|};
export type TablePropsT = {|
| [No CFG could be retrieved] | A JS component that exports a single non - standard . Callback for when the reset button is clicked. | let's call this `fillClickTarget` to convey that it fills the available negative space rather than extends to an arbitrary point. |
@@ -408,6 +408,13 @@ define([
var direction = camera.getDirectionWC();
var position = camera.getPositionWC();
+ if (scene.debugShowFrustums) {
+ scene.debugFrustumStatistics = {
+ totalCommands : 0,
+ commandsInFrustums : [0, 0, 0, 0]
+ };
+... | [No CFG could be retrieved] | Inserts a command into the binary. The culling volume is the plan that is used to create the culling volume. | I don't think the number of frustums would get past four, but this may not work if the far-to-near ratio changes. You can set the length to the `frustumCommandsList` length and initialize it to zeros in the loop below. Otherwise, you will get `NaN`s for incrementing `undefined`. |
@@ -494,6 +494,9 @@ class Pipeline(object):
for override in replacements:
self._check_replacement(override)
+ def _propagate_resource_hints(self):
+ ResourceHintsPropagator.propagate_hints_to_subtransforms(self)
+
def run(self, test_runner_api='AUTO'):
# type: (Union[bool, str]) -> PipelineRes... | [Pipeline->[_check_replacement->[ReplacementValidator],_remove_labels_recursively->[_remove_labels_recursively],from_runner_api->[Pipeline],replace_all->[_check_replacement,_replace],_replace->[TransformUpdater->[_replace_if_needed->[_remove_labels_recursively],visit_transform->[_replace_if_needed],enter_composite_tran... | Dynamically replaces all PTransforms in the currently populated hierarchy with the given PTransformOverrides. Checks if a node has a specific node id and if so invokes the runner API. If. | Nit: I'd go ahead and inline this. |
@@ -663,10 +663,6 @@ public final class ValidateDependenciesChecker
node.getInput().getOutputSymbols(),
node.getCorrelation(),
"Correlated JOIN input must provide all the necessary correlation symbols for subquery");
- checkDependencies(
- ... | [ValidateDependenciesChecker->[Visitor->[visitExcept->[visitSetOperation],visitIntersect->[visitSetOperation]],validate->[validate]]] | Visit a CorrelatedJoinNode. This method checks that the correlated join node has all. | Did you find any case where correlation list wasn't properly pruned? |
@@ -50,7 +50,7 @@ FINGERPRINTS = {
],
CAR.ALTIMA: [
{
- 2: 5, 42: 6, 346: 6, 347: 5, 348: 8, 349: 7, 386: 8, 397: 8, 398: 8, 520: 2, 523: 6, 548: 8, 634: 7, 645: 8, 658: 8, 665: 8, 666: 8, 674: 2, 682: 8, 683: 8, 689: 8, 723: 8, 758: 3, 772: 8, 773: 6, 774: 7, 775: 8, 776: 6, 777: 7, 778: 6, 783: 3, 851... | [dbc_dict] | A list of all possible values. Sequence of objects containing nissan_nissan_sequence_cars. | there's duplicate keys now |
@@ -70,7 +70,7 @@ public class LeastActiveLoadBalance extends AbstractLoadBalance {
}
if (!sameWeight && totalWeight > 0) {
// If (not every invoker has the same weight & at least one invoker's weight>0), select randomly based on totalWeight.
- int offsetWeight = ThreadLocalRan... | [LeastActiveLoadBalance->[doSelect->[getMethodParameter,size,getMethodName,getActive,get,nextInt,getWeight]]] | This method is called by the server code to select a invoker from the list of invokers Returns a new invoker based on the least active value. If there are no active invoker returns. | Why change `ThreadLocalRandom.current().nextInt(totalWeight)` to `ThreadLocalRandom.current().nextInt(totalWeight) + 1` ? |
@@ -1,12 +1,16 @@
module Idv
class SsnForm
include ActiveModel::Model
- include FormSsnValidator
-
ATTRIBUTES = [:ssn].freeze
attr_accessor :ssn
+ validates :ssn, presence: true
+ validates_format_of :ssn,
+ with: /\A\d{3}-?\d{2}-?\d{4}\z/,
+ ... | [SsnForm->[raise_invalid_ssn_parameter_error->[raise],model_name->[new],consume_params->[send,raise_invalid_ssn_parameter_error,to_sym,include?,each],submit->[messages,new,consume_params,valid?],freeze,include,attr_accessor]] | Returns the name of the node that should be used for the next sequence. | The profile step actually is not part of the doc auth flow (long story). We'll actually want the SSN unique bit in the `extra` attributes of the form response coming out of this form. |
@@ -520,6 +520,12 @@ HRESULT RunScript(const char* fileName, LPCSTR fileContents, size_t fileLength,
IfFailGo(messageQueue->ProcessAll(fileName));
} while(!messageQueue->IsEmpty());
}
+
+ // free the source for the serialized script case if it's not been handed to a managed... | [No CFG could be retrieved] | This function is called from the main thread. It will attempt to find the next available object Removes the exception object from the message queue and removes it from the message queue. | Freeing serialised script source had to be moved down below the PrintException call - as GetExceptionWithMetaData accesses the source. |
@@ -7,6 +7,8 @@ namespace NServiceBus.Logging
{
static ILoggerFactory loggerFactory = new NullLoggerFactory();
+ public static bool IsConfigured { get { return loggerFactory.GetType() != typeof(NullLoggerFactory); } }
+
public static ILoggerFactory LoggerFactory
{
g... | [LogManager->[ILog->[GetLogger]]] | The class provides a class which provides a list of loggers that can be used to. | Since this is effectively a bug in the `NServiceBus.Hosting.Windows` I would prefer that the change be isolated to that project. The reason being this change only serves to enable `NServiceBus.Hosting.Windows` in fixing the bug. If you move this code into a class inside `NServiceBus.Hosting.Windows` will merge this PR. |
@@ -141,6 +141,9 @@ function filterWhitelistedLinks(markdown) {
// Links inside a <code> block (illustrative, and not always valid)
filteredMarkdown = filteredMarkdown.replace(/<code>(.*?)<\/code>/g, '');
+
+ // Links inside a <pre> block (illustrative, and not always valid)
+ filteredMarkdown = filteredMar... | [No CFG could be retrieved] | Checks if a given file is whitelisted by PR. Check if a file is in the markdown file and if so skip it. | Change this line too. |
@@ -627,16 +627,14 @@ public class AvroIOTest {
public FilenamePolicy getFilenamePolicy(String destination) {
return DefaultFilenamePolicy.fromStandardParameters(
StaticValueProvider.of(
- baseDir.resolve("file_" + destination + ".txt", StandardResolveOptions.RESOLVE_FILE)),
+ ... | [AvroIOTest->[testAvroIONullCodecWriteAndReadASingleFile->[GenericClass,apply],assertTestOutputs->[toString,getSchema],testAvroIOWriteAndReadViaValueProvider->[GenericClass,apply],testMetadata->[GenericClass,apply],testAvroIOWriteAndReadMultipleFilepatterns->[GenericClass,apply],testWriteDisplayData->[toString],testAvr... | This method is used to test if a file is missing from the schema. Checks that the output file exists and contains all records in the expected file. | <!--new_thread; commit:bd1ae5fc000332b3113096a9d6b58194924e60cc; resolved:0--> nit: better to use an enum here instead of a magic value. Even if it hard codes the number of shards to 3. |
@@ -34,6 +34,12 @@ class VoucherType:
pgettext_lazy("Voucher: discount for", "Specific categories of products"),
),
(SHIPPING, pgettext_lazy("Voucher: discount for", "Shipping")),
+ (
+ SPECIFIC_PRODUCT,
+ pgettext_lazy(
+ "Voucher: discount for... | [DiscountValueType->[pgettext_lazy],VoucherType->[pgettext_lazy]] | A list of product - category - collection - discounted items. | `collections and categories` -> `collections or categories` ? |
@@ -317,13 +317,13 @@ Rails.application.routes.draw do
get '/doc_auth' => 'doc_auth#index'
get '/doc_auth/:step' => 'doc_auth#show', as: :doc_auth_step
put '/doc_auth/:step' => 'doc_auth#update'
- get '/doc_auth/link_sent/poll' => 'doc_auth#doc_capture_poll'
get '/capture_doc' => 'captu... | [allow_piv_cac_login?,redirect,devise_scope,join,put,draw,root,scope,constraints,post,enable_usps_verification?,patch,devise_for,each,match,delete,namespace,disallow_ial2_recovery?,get,enable_test_routes] | Get a list of all the items in the system. Navigate to the Nexus Nexus Management Management Management Management Management Management Management Management Management Management. | during the 10min of the deploy this might fail (old boxes pointing users to load a URL that is no longer supported), should we keep the old URL and have it render to the new controller? The API response is the exact same right? Otherwise, this is not a super heavily-trafficked endpoint so maybe it's fine |
@@ -230,9 +230,13 @@ class Image
}
if ($this->isImagick()) {
- /* Clean it */
- $this->image = $this->image->deconstructImages();
- return $this->image;
+ try {
+ /* Clean it */
+ $this->image = $this->image->deconstructImages();
+ return $this->image;
+ } catch (Exception $e) {
+ return f... | [Image->[orient->[rotate,flip,getType,isValid,isImagick],scaleUp->[isValid,getHeight,getWidth],toStatic->[isImagick],crop->[isValid,scaleDown,isImagick],rotate->[isValid,isImagick],asString->[isValid,isImagick,getType],getHeight->[isValid,isImagick],getExt->[isValid,getType],scaleDown->[isValid,getHeight,getWidth],getW... | Get the Image object. | I believe we should log something here. |
@@ -55,7 +55,7 @@ KratosSwimmingDEMApplication::KratosSwimmingDEMApplication():
mComputeLaplacianSimplexCondition2D(0, Element::GeometryType::Pointer(new Line2D2<Node<3> >( Element::GeometryType::PointsArrayType(2)))),
mComputeLaplacianSimplexCondition3D(0, Element::GeometryType::Pointer(new Triangle3D3<Node<3> >... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Register the KratosSwimmingDEM application with the Application. | is this necessary? |
@@ -894,7 +894,7 @@ class DygraphGeneratorLoader(DataLoaderBase):
array = core.LoDTensorArray()
for item in sample:
if not isinstance(item, core.LoDTensor):
- self._check_input_array(item)
+ item = self._check_input_arr... | [PyReader->[__iter__->[__iter__],__next__->[__next__],reset->[reset],decorate_batch_generator->[set_batch_generator],__init__->[from_generator],start->[start],decorate_sample_list_generator->[set_sample_list_generator],decorate_sample_generator->[set_sample_generator]],DygraphGeneratorLoader->[__iter__->[_init_iterable... | This loop is called from the reader thread. | Is there any efficiency difference between setting list or ndarray to a LoDTensor ? |
@@ -1697,6 +1697,8 @@ class AdamOptimizer(Optimizer):
def _finish_update(self, block, param_and_grads):
"""Update Beta1 and Beta2 Power accumulators
"""
+ pass
+ '''
assert isinstance(block, framework.Block)
main_block = block.program.global_block()
for pa... | [MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],PipelineOptimizer->[_extract_section_ops->[_is_opt_role_op],_find_input_output->[update],minimize->[minimize,_create_vars,_split_program],_split_program->[_extract_section_ops,_find_persistable_vars,u... | Finishes the update of the n - ary accumulator. | remove useless code |
@@ -5790,7 +5790,7 @@ def sum_cost(input, name=None, layer_attr=None):
:param input: The first input layer.
:type input: LayerOutput.
- :param name: The name of this layers. It is not necessary.
+ :param name: The name of this layer. It is not necessary.
:type name: None|basestring.
:param l... | [seq_concat_layer->[LayerOutput],out_prod_layer->[LayerOutput],img_pool_layer->[LayerOutput],multiplex_layer->[LayerOutput],cross_entropy->[LayerOutput,__cost_input__],multibox_loss_layer->[LayerOutput],gated_unit_layer->[fc_layer,dotmul_operator,mixed_layer],lstm_step_layer->[LayerOutput],clip_layer->[LayerOutput],Mix... | Sum cost of the last n - layer in a network. | please delete the sentence "It is not necessary." |
@@ -283,6 +283,18 @@ public class AppenderatorImpl implements Appenderator
return rowsCurrentlyInMemory.get();
}
+ @VisibleForTesting
+ long getRowSizeInMemory(SegmentIdentifier identifier)
+ {
+ final Sink sink = sinks.get(identifier);
+
+ if (sink == null) {
+ throw new ISE("No such sink: %s",... | [AppenderatorImpl->[abandonSegment->[apply->[close],pushBarrier,add],persistHydrant->[createPersistDirIfNeeded,persist],getQueryRunnerForIntervals->[getQueryRunnerForIntervals],createPersistDirIfNeeded->[computeIdentifierFile,computePersistDir],getQueryRunnerForSegments->[getQueryRunnerForSegments],push->[persist,add],... | Get or create a sink for the given identifier. | Would you rename this method to a more intuitive one? Looks like it returns a row size. |
@@ -477,8 +477,12 @@ class RoIHeads(torch.nn.Module):
pred_scores = F.softmax(class_logits, -1)
# split boxes and scores per image
- pred_boxes = pred_boxes.split(boxes_per_image, 0)
- pred_scores = pred_scores.split(boxes_per_image, 0)
+ if len(boxes_per_image) == 1):
+ ... | [paste_masks_in_image->[expand_boxes,paste_mask_in_image,expand_masks],RoIHeads->[select_training_samples->[check_targets,add_gt_proposals,assign_targets_to_proposals,subsample],forward->[fastrcnn_loss,maskrcnn_inference,postprocess_detections,maskrcnn_loss,keypointrcnn_inference,keypointrcnn_loss,select_training_sampl... | Post - processes the detections after the classifier has been trained. Returns all boxes scores and labels in a list. | Can you add a `TODO: remove this when ONNX support dynamic split sizes` so that we remember to remove this workaround in the future? |
@@ -602,6 +602,17 @@ class Openmpi(AutotoolsPackage):
env.set('ac_cv_header_gpfs_fcntl_h', 'no')
def configure_args(self):
+ if self.spec.satisfies('+legacylaunchers schedulers=slurm'):
+ # Deleting the links to orterun avoids users running their
+ # applications via mpi... | [Openmpi->[setup_dependent_build_environment->[setup_run_environment],filter_rpaths->[filter_lang_rpaths],test->[_test_examples,_test_bin_ops,_test_check_versions]]] | Configure the command line options for the object. Adds missing configuration options if missing. Add to config_args if necessary. Add flags related to the object to the config_args list. Adds missing flags to the config_args list. | I'm concerned a mere warning here isn't enough to change the behavior -- especially when installing a huge environment, and especially since the change in default could mess with existing scripts. @alalazo Is it reasonable to have a value variant with "on/off/auto", where "auto" is the default and it disables legacy la... |
@@ -100,6 +100,10 @@ class TestData(object):
def packages3(self):
return self.root.join("packages3")
+ @property
+ def packages4(self):
+ return self.root.join("packages4")
+
@property
def src(self):
return self.root.join("src")
| [_create_test_package_with_subdirectory->[run],need_mercurial->[need_executable],_change_test_package_version->[run],TestPipResult->[assert_installed->[TestFailure]],need_bzr->[need_executable],_vcs_add->[run],TestData->[find_links3->[path_to_url],find_links->[path_to_url],index_url->[path_to_url],find_links2->[path_to... | Package 3 - tuple of packages. | This feels unnecessary -- why has a simple package been added under a new, different directory; am I missing something? |
@@ -511,7 +511,6 @@ static int file_setup_decoders(struct file_ctx_st *ctx)
ok = 1;
err:
- OSSL_DECODER_free(to_obj);
return ok;
}
| [No CFG could be retrieved] | Load a single object from a file. Reads the name object from the file and returns the name object. | This is wrong. The to_obj decoder is up-refed by ossl_decoder_instance_new(). This is the cause of the sanitizer CI test failure. |
@@ -6,5 +6,7 @@ module Ahoy
belongs_to :visit
belongs_to :user, optional: true
+
+ scope :overview_link_clicks, -> { where(name: "Overview Link Clicked") }
end
end
| [Event->[belongs_to,include,table_name]] | endregion region ethernet_interface ethernet_interface. | I checked DEV and we have no events with that name, I wonder if the feature is disabled over there |
@@ -179,7 +179,16 @@ func (t *basicSupersedesTransform) Run(ctx context.Context,
// superseded by anything. Could have been deleted by a
// delete-history, retention expunge, or was an exploding
// message.
- continue
+ if newMsg.IsValid() {
+ // If we want to show the GUI that the message is ... | [Run->[transform],transform->[transformAttachment,transformEdit]] | Run takes a list of messages that are supersedes and returns a list of messages that This function is used to transform all messages in the message list into final state. | I'll ask you about this part in person to make sure I understand :) |
@@ -270,6 +270,12 @@ func (g *GlobalContext) Shutdown() error {
}
err = epick.Error()
+
+ // Set the exit code for the caller. Don't overwrite
+ // if it is set to something besides ExitCode_OK.
+ if g.ExitCode == keybase1.ExitCode_OK && err != nil {
+ g.ExitCode = keybase1.ExitCode_NOTOK
+ }
})
// ... | [ConfigureUsage->[ConfigureKeyring,ConfigureAPI,ConfigureCaches,UseKeyring,ConfigureMerkleClient,ConfigureTimers,ConfigureExportedStreams,ConfigureConfig,Configure],SetCommandLine->[SetCommandLine],Logout->[createLoginStateLocked,Logout],Configure->[SetCommandLine,ConfigureLogging],Shutdown->[LoginState,Shutdown],GetMy... | Shutdown is the main shutdown function that will be called when the application is shutting down. | These lines are hosing you. Remove. Don't reset the error code if there's an error on shutdown; this will fix your linux (and OSX) problems. |
@@ -156,7 +156,7 @@ describe NotesController do
note: {noteable_id: student.id,
notes_message: @message}}
expect(assigns :note).not_to be_nil
- expect(flash[:success]).to eq [I18n.t('notes.create.success')]
+ expect(flash[:success].map { |f| extract_text... | [create,describe,post_as,it,assignment,assert_select,to,before,t,require,count,delete_as,get_as,put_as,id,redirect_to,context,not_to,eq,render_template] | post_as expect returns an array with all the data that can be created GET on the object selector and the object selector for the groupings. | Lint/AmbiguousBlockAssociation: Parenthesize the param [I18n.t('notes.create.success')].map { |f| extract_text f } to make sure that the block will be associated with the [I18n.t('notes.create.success')].map method call.<br>Metrics/LineLength: Line is too long. [124/120] |
@@ -702,7 +702,7 @@ class EvokedArray(Evoked):
self.last = self.first + np.shape(data)[-1] - 1
self.times = np.arange(self.first, self.last + 1,
dtype=np.float) / info['sfreq']
- self.info = info
+ self.info = deepcopy(info) # do not modify original info
... | [Evoked->[__neg__->[copy],detrend->[detrend],resample->[resample]],read_evokeds->[Evoked,_get_evoked_node],_read_evoked->[_get_entries,_get_aspect],grand_average->[copy]] | Initialize a object. | You can just use `info.copy()` |
@@ -709,6 +709,8 @@ func (fm *FluxMonitor) respondToNewRoundLog(log flux_aggregator_wrapper.FluxAggr
}
return fm.logBroadcaster.MarkConsumed(tx, lb)
})
+ // Either the tx failed and we want to reprocess the log, or it succeeded and already marked it consumed
+ markConsumed = false
if err != nil {
newRoundL... | [pollIfEligible->[checkEligibilityAndAggregatorFunding],consume->[Start,IsHibernating]] | respondToNewRoundLog is called when a new round log is received from the Flux This function is called when a new round has been received from the network. It is called This function is called when a new round is requested. | hm maybe a bit more clear would be to remove this one and have MarkConsumed only in defer? You could put `markConsumed = false` inside the if |
@@ -455,6 +455,7 @@ ds_mgmt_hdlr_pool_create(crt_rpc_t *rpc_req)
struct mgmt_pool_create_out *pc_out;
int rc;
+ D_ERROR("kccain got pool create request from CaRT path - legacy dmg?\n");
pc_in = crt_req_get(rpc_req);
D_ASSERT(pc_in != NULL);
pc_out = crt_reply_get(rpc_req);
| [No CFG could be retrieved] | function to handle create or destroy of pool - 1 ) - 1 ) - 1 ) - 1 ) - 1 ) - 1 ). | (style) line over 80 characters |
@@ -249,6 +249,7 @@ namespace System.Net.Security
if (message.Size > 0)
{
await adapter.WriteAsync(message.Payload!, 0, message.Size).ConfigureAwait(false);
+ await adapter.FlushAsync().ConfigureAwait(false);
... | [SslStream->[SendAuthResetSignal->[SetException],ConsumeBufferedBytes->[ReturnReadBufferIfEmpty],CopyDecryptedData->[ReturnReadBufferIfEmpty]]] | Asynchronously sends a handshake or a handshake message to the specified adapter. Check if we have a handshake pending and if so complete the handshake. | There's another write below in a failure path. That one doesn't need to be flushed? |
@@ -1936,6 +1936,12 @@ class Societe extends CommonObject
*/
function del_commercial(User $user, $commid)
{
+ $error=0;
+ $this->commercial_modified = $commid;
+
+ $result=$this->call_trigger('COMPANY_DEL_COMMERCIAL',$user);
+ if ($result < 0) $error++;
+
if ($this->id > 0 && $commid > 0)
{... | [Societe->[setCategories->[fetch],create_from_member->[create],get_all_rib->[fetch],update->[verify,update],searchByName->[fetch],info->[fetch],generateDocument->[fetch],setSalesRep->[del_commercial,getSalesRepresentatives,add_commercial],display_rib->[fetch],create_individual->[create],contact_array_objects->[fetch],g... | Delete commercial of a user. | Can you name your trigger 'COMPANY_UNLINK_SALE_REPRESENTATIVE' to match naming rules used by other objects (this is not a CRUD deletion) |
@@ -262,7 +262,7 @@ public abstract class AbstractChannelBuffer implements ChannelBuffer {
}
}
}
-
+
@Override
public byte readByte() {
if (readerIndex == writerIndex) {
| [AbstractChannelBuffer->[getBytes->[writableBytes,getBytes,writerIndex],slice->[readableBytes,slice],equals->[equals],resetReaderIndex->[readerIndex],writeZero->[writeInt,writeLong,writeByte],hashCode->[hashCode],readUnsignedInt->[readInt],readChar->[readShort],copy->[copy,readableBytes],ensureWritableBytes->[writableB... | Sets the specified index to zero and returns the next byte in the specified range. | I have no idea what happened here! |
@@ -173,7 +173,8 @@ module Dependabot
if e.message.match?(/protected branch/i) ||
e.message.match?(/not authorized to push/i) ||
- e.message.match?(/must not contain merge commits/)
+ e.message.match?(/must not contain merge commits/) ||
+ e.message.match?(/required ... | [PullRequestUpdater->[Github->[pull_request->[pull_request],create_tree->[create_tree],create_commit->[create_commit]]]] | Updates a branch in the repository. | There are a few variations of the error message, depending on wether there is 1 required check or more enabled, it didn't seem pertinent to test every variation, but that's why the check is not case sensitive |
@@ -394,7 +394,7 @@ namespace System.Security.Principal
}
}
- private void CreateFromBinaryForm(byte[] binaryForm, int offset)
+ private void CreateFromBinaryForm(byte[]? binaryForm, int offset)
{
//
// Give us something to work with
| [No CFG could be retrieved] | Creates a SID array from the binary form. Extracts the elements of a SID from binaryForm starting at offset. | The `binaryForm` parameter is immediately checked for null and throws if that is the case so this method will never accept a null value. Doesn't that mean that the type should be non-null? I realise that a nullable array is needed later but another variable could be used for that. |
@@ -1245,10 +1245,14 @@ void gen_trezor_base::set_hard_fork(uint8_t hf)
m_top_hard_fork = hf;
if (hf < 9){
throw std::runtime_error("Minimal supported Hardfork is 9");
- } else if (hf == 9){
+ } else if (hf <= 11){
rct_config({rct::RangeProofPaddedBulletproof, 1});
- } else {
+ } else if (hf == 12){... | [No CFG could be retrieved] | get_tx_key - Get the TX key for all wallets private int m_miner_account = 0 ;. | There are HF_VERSION_* defines for those if needed. |
@@ -625,8 +625,11 @@ namespace Dynamo.DSEngine
return idx == ProtoCore.DSASM.Constants.kInvalidIndex;
}
-
#endregion
+ public bool TryParseCode(ref ParseParam parseParam)
+ {
+ return CompilerUtils.PreCompileCodeBlock(parsingCore, ref parseParam);
+ }
... | [EngineController->[ImportLibrary->[ImportLibrary],UpdateGraph->[UpdateGraph],ShowRuntimeWarnings->[GetRuntimeWarnings],ShowBuildWarnings->[GetBuildWarnings],GetRuntimeWarnings->[GetRuntimeWarnings],LibraryLoaded->[GetFunctionGroups],ConvertNodesToCode->[ConvertNodesToCode],GetBuildWarnings->[GetBuildWarnings],Dispose-... | Checks if a variable has been defined in the global scope. | Personally I'd name this as `libraryCore` instead of `parsingCore`, since it exists to serve preloaded runtime types and parsing is just an added capability. But that's just me, only rename it if you agree with me. |
@@ -5838,7 +5838,7 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
throw new InvalidParameterValueException("Unsupported Hypervisor Type for User VM migration, we support XenServer/VMware/KVM/Ovm/Hyperv/Ovm3 only");
}
- if (isVMUsingLocalStorage(vm)) {
... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],getNetworkForOvfNetworkMapping->[getDef... | This method is invoked when a VM is migrated to another host. Checks if a VM can be migrated to a different host. find the next VM in the VM table that can migrate to a destination host. | Is this debug line still valid? |
@@ -152,6 +152,11 @@ class ReadFromPubSub(PTransform):
pcoll.element_type = bytes
return pcoll
+ def to_runner_api_parameter(self, context):
+ # Required as this is identified by type in PTransformOverrides.
+ # TODO(BEAM-3812): Use an actual URN here.
+ return self.to_runner_api_pickled(context... | [_PubSubPayloadSink->[__init__->[parse_topic]],PubsubMessage->[_from_message->[PubsubMessage],_from_proto->[PubsubMessage]],ReadStringsFromPubSub->[expand->[ReadFromPubSub]],_PubSubSource->[__init__->[parse_subscription,parse_topic]]] | Expand a sequence of bytes or PubsubMessage objects into a sequence of PubsubMessage objects. | Should this be a different JIRA ? |
@@ -374,7 +374,7 @@ class BigQuerySource(dataflow_io.NativeSource):
self.use_legacy_sql = True
else:
self.query = query
- self.use_legacy_sql = use_legacy_sql
+ self.use_legacy_sql = not use_standard_sql
self.table_reference = None
self.validate = validate
| [BigQuerySink->[display_data->[format],schema_as_json->[schema_list_as_object->[schema_list_as_object],schema_list_as_object],__init__->[RowAsDictJsonCoder,validate_write,validate_create,_parse_table_reference]],BigQueryWrapper->[get_or_create_table->[_is_table_empty,_create_table,_delete_table,_get_table],insert_rows-... | Creates a new BigQuerySource object from the given arguments. Sets self. table_reference and self. query if table or query are specified. | create a JIRA issue to fix the internals later. It would make sense to use `use_standard_sql` internally as well. |
@@ -194,12 +194,12 @@ void GenericAgentDiscoverContext(EvalContext *ctx, GenericAgentConfig *config)
if (existing_policy_server)
{
Log(LOG_LEVEL_INFO, "This agent is bootstrapped to '%s'", existing_policy_server);
+ SetPolicyServer(ctx, existing_policy_server);
}
... | [No CFG could be retrieved] | Adds a policy server to the agent s policy server file if it is not already bootstrapped Check if the input file is changed since last validation. | POLICY_SERVER will still be NULL if existing_policy_server is NULL. Is that intentional? |
@@ -6,7 +6,7 @@ namespace Dynamo.Graph.Workspaces
/// <summary>
/// Class containing info about a package
/// </summary>
- internal class PackageInfo
+ public class PackageInfo
{
/// <summary>
/// Name of the package
| [PackageDependencyInfo->[ToString->[ToString],GetHashCode->[GetHashCode]],PackageInfo->[ToString->[ToString],GetHashCode->[GetHashCode]]] | PackageInfo is a base class for all of the components of a package. The type of reference this dependency is. | Good, we still end up making it public. Would you check if there is any internal available code we need to remove? |
@@ -27,8 +27,6 @@ namespace osquery {
*/
const std::set<std::string> kVerboseOptions{
"verbose",
- "verbose_debug",
- "debug",
"minloglevel",
"logger_min_status",
"stderrthreshold",
| [update->[IsObject,Status,find,GetObject,GetBool,getType,IsBool,toString,VLOG,end,empty,mergeObject,count,copyFrom,doc,IsInt,getObject,GetInt,IsString,setVerboseLevel,LOG,GetUint64,IsNumber,GetString,IsArray,add],REGISTER_INTERNAL] | A plugin that creates a new configuration object for a single key. auto. | Actually you're removing "debug" here. |
@@ -458,7 +458,10 @@ public class ProcessBundleHandler {
startFunction.run();
}
- if (!bundleProcessor.getInboundEndpointApiServiceDescriptors().isEmpty()) {
+ if (request.getProcessBundle().hasElements()) {
+ bundleProcessor.getInboundObserver().accept(request.get... | [ProcessBundleHandler->[trySplit->[trySplit],BundleProcessor->[shutdown->[getTearDownFunctions],finish->[getTimerEndpoints,getInboundDataEndpoints],reset->[setInstructionId,reset,getResetFunctions]],BlockTillStateCallsFinish->[handle->[handle]],shutdown->[shutdown],createBundleProcessor->[createRunnerAndConsumersForPTr... | Process a bundle. This method is called when the runner is waiting for the monitoring data to be sent. | This will block forever if the elements message is malformed and doesn't contain "terminal" elements so it would be better to handle this case explicitly within the BeamFnDataInboundObserver2 as a separate method. Also passing it through the queue within BeamFnDataInboundObserver2 and adding the additional synchronizat... |
@@ -46,7 +46,12 @@ public class Artemis {
String instance = System.getProperty("artemis.instance");
File fileInstance = instance != null ? new File(instance) : null;
- execute(fileHome, fileInstance, args);
+
+ Object result = execute(fileHome, fileInstance, args);
+ if (result instanceof... | [Artemis->[fixupFileURI->[substring,startsWith,length,toString],main->[File,getProperty,execute],add->[add,log,getMessage,toURL],execute->[compare->[compareTo,getName],getTargetException,size,toArray,fixupFileURI,getMethod,getProperty,endsWith,setProperty,listFiles,File,sort,loadClass,getCanonicalPath,toURL,isDirectory... | Main method of the test. | this will silently fail the CLI. shouldn't you System.out about the exception here? In what situation this will return Exception? I coudln't see it |
@@ -49,9 +49,7 @@ public class BeamAggregationRule extends RelOptRule {
final Aggregate aggregate = call.rel(0);
final Project project = call.rel(1);
RelNode x = updateWindow(call, aggregate, project);
- if (x != null) {
- call.transformTo(x);
- }
+ call.transformTo(x);
}
private st... | [BeamAggregationRule->[onMatch->[updateWindow,rel,transformTo],updateWindow->[getInput,BeamAggregationRel,getGroupSets,getGroupSet,get,empty,replace,convert,getCluster,asList,getAggCallList,getWindowFieldAt,getProjects],any,operand,BeamAggregationRule]] | This method is called when a new relation is matched. | How do we know this x is not null here? |
@@ -232,6 +232,15 @@ func getCLIVersionInfo() (semver.Version, semver.Version, error) {
return semver.Version{}, semver.Version{}, err
}
+ brewLatest, isBrew, err := getLatestBrewFormulaVersion()
+ if err != nil {
+ return semver.Version{}, semver.Version{}, err
+ }
+ if isBrew {
+ // When consulting Homebrew ... | [StringVar,RawMessage,Dir,Colorize,Executable,Warningf,Now,Encode,HasPrefix,Add,IsTruthy,IgnoreClose,Flush,Stat,ParseTolerant,NewEncoder,New,RunFunc,Diag,StringVarP,NewClient,InitLogging,Run,After,Chdir,AddCommand,LookPath,GetCachedVersionFilePath,Bytes,TrimSpace,InitProfiling,Join,Wrapf,Infof,Current,EvalSymlinks,Read... | getVersionInfo returns the latest and oldest version of the application. getCachedVersionInfo returns the newest and oldest version of the CLI that is allowed to upgrade. | Do we want to avoid calling our service if `isBrew`? Or is there a reason to always do it (e.g. for version usage telemetry)? |
@@ -92,8 +92,10 @@ public class AggregatorsModule extends SimpleModule
@JsonSubTypes.Type(name = "filtered", value = FilteredAggregatorFactory.class),
@JsonSubTypes.Type(name = "longFirst", value = LongFirstAggregatorFactory.class),
@JsonSubTypes.Type(name = "doubleFirst", value = DoubleFirstAggreg... | [AggregatorsModule->[registerSerde,HyperUniquesSerde,getDefault,getSerdeForType,setMixInAnnotation,PreComputedHyperUniquesSerde]] | A convenience method for creating AggregatorFactoryMixin objects that implement the IAggregator interface. DTO for PostAggregator. | minor nit: would be nice to keep Subtypes listing in alphabetical order. |
@@ -164,12 +164,7 @@ class GlobalOptions(Subsystem):
default_rel_distdir = f"/{default_distdir_name}/"
register(
- "-l",
- "--level",
- type=LogLevel,
- default=LogLevel.INFO,
- help="Set the logging level. The logging levels are one of: "
- ... | [OwnersNotFoundBehavior->[to_glob_match_error_behavior->[GlobMatchErrorBehavior]],FilesNotFoundBehavior->[to_glob_match_error_behavior->[GlobMatchErrorBehavior]],GlobalOptions->[register_options->[register_bootstrap_options]],ExecutionOptions] | Register the options required to create a Scheduler. Registers a single failure of a reserved block. Register a bunch of flags that can be used to provide a sequence of rules that can be Register a single - node with the system. | why did we get rid of this text? printing the exact names of the valid log level values seems like very useful help information |
@@ -0,0 +1,18 @@
+<?php
+/*
+ * LibreNMS Quanta LB6M memory information
+ *
+ * Copyright (c) 2017 Mark Guzman <segfault@hasno.info>
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either ... | [No CFG could be retrieved] | No Summary Found. | You can swap these to named OIDs here as well. |
@@ -34,7 +34,9 @@ def get_buildroot() -> str:
def get_pants_cachedir() -> str:
"""Return the pants global cache directory."""
- # Follow the unix XDB base spec: http://standards.freedesktop.org/basedir-spec/latest/index.html.
+ # TODO: Keep in alignment with rust `fs::default_cache_path`. This method
+ ... | [get_default_pants_config_file->[get_buildroot],pants_release->[pants_version]] | Return the pants global cache directory. | If this is only being used in BinaryUtil now, it would be good to move there. Ditto on `pants_configdir`. It reduces the risk of people accidentally using this. Or, maybe even better, keep these, but have them return `Native().default_cache_path()`. Move this non-Rust version into `BinaryUtil`. |
@@ -27,6 +27,7 @@ module.exports = class gateio extends Exchange {
'fetchOrderTrades': true,
'fetchOrders': true,
'fetchOrder': true,
+ 'fetchMyTrades': true,
},
'urls': {
'logo': 'https://user-images.githubuser... | [No CFG could be retrieved] | Provides a description of a gate. io exchange that can be used to retrieve a specific The base API endpoint for all of the functions that are defined in the API specification. | We can't really set it to `true` without adding an implementation for it (see how it is implemented in other exchanges). Would you want to give it try? |
@@ -140,6 +140,9 @@ class AptTool(object):
class YumTool(object):
+ def add_repository(self, repository, repo_key=None):
+ raise ConanException("YumTool::add_repository not implemented (see #3385)")
+
def update(self):
_run(self._runner, "%syum update" % self._sudo_str, accepted_returns=[0,... | [SystemPackageTool->[install->[_get_sysrequire_mode,update],_install_any->[install],update->[_get_sysrequire_mode,update]]] | Update and install the Nagios package. | Not sure about the error message with the #3385. WDYT @memsharded? Too much coupled to GH in my opinion. |
@@ -2593,14 +2593,7 @@ def process_graph(graph: Graph, manager: BuildManager) -> None:
def process_fine_grained_cache_graph(graph: Graph, manager: BuildManager) -> None:
"""Finish loading everything for use in the fine-grained incremental cache"""
-
- # If we are running in fine-grained incremental mode with... | [dump_graph->[dumps,NodeInfo],NodeInfo->[dumps->[dumps]],load_graph->[State,find_module_simple,use_fine_grained_cache],strongly_connected_components->[dfs->[dfs],dfs],order_ascc->[order_ascc],load_plugins->[plugin_error],get_cache_names->[_cache_dir_prefix],State->[parse_file->[parse_file,compute_hash,wrap_context,chec... | Process the fine - grained cache graph. Return a list of all components in the graph. | Can this be removed, since it's empty? |
@@ -269,6 +269,7 @@ class REST_Connector {
break;
case 'completed':
$response['status'] = 'completed';
+ do_action( 'jetpack_reconnection_completed' );
break;
case 'failed':
$response = new WP_Error( 'Reconnect failed' );
| [REST_Connector->[remote_authorize->[remote_authorize]]] | Reconnect to the server. | Could you add a docblock here? |
@@ -2539,10 +2539,9 @@ evt_node_debug(struct evt_context *tcx, umem_off_t nd_off,
if (leaf || cur_level == debug_level || debug_level < 0) {
struct evt_rect_df *rect;
- rect = evt_node_mbr_get(nd);
- D_PRINT("%*snode="DF_X64", lvl=%d, mbr="DF_RECT_DF
+ D_PRINT("%*snode="DF_X64", lvl=%d, mbr="DF_MBR
", rec... | [No CFG could be retrieved] | Debug output for the specified tree node. Output status of tree nodes at level \ a debug_level. | (style) 'nd' may be misspelled - perhaps 'and'? (style) 'nd' may be misspelled - perhaps 'and'? (style) 'nd' may be misspelled - perhaps 'and'? |
@@ -218,7 +218,7 @@ Rails.application.routes.draw do
resources :webhook_endpoints, only: :index
end
- scope path: :app do
+ scope path: :apps do
resources :chat_channels, only: %i[index create update destroy] do
member do
delete :remove_user
| [new,authenticate,authenticated,redirect,devise_scope,mount,put,draw,freeze,resources,member,root,use,scope,constraints,post,set,controllers,require,secrets,class_eval,use_doorkeeper,resource,url,patch,devise_for,each,production?,enabled?,delete,namespace,collection,get,session_options,tech_admin?,app] | Menu for all the actions in a group. The api scope for the missing - term resources. | Do we need to account for any existing links to `app`? |
@@ -463,6 +463,14 @@ void WorldSession::HandleBattleFieldPortOpcode(WorldPacket& recvData)
_player->SetBattlegroundId(bg->GetInstanceID(), bg->GetBgTypeID(), queueSlot, true, bgTypeId == BATTLEGROUND_RB, teamId);
+ if (sWorld->getBoolConfig(CONFIG_BATTLEGROUND_TRACK_DESERTERS))
+ ... | [HandleBattlegroundPlayerPositionsOpcode->[outDebug,uint64,GetPositionX,SendPacket,GetGUID,GetFlagPickerGUID,GetBattleground,GetPositionY],HandleBattlefieldListOpcode->[outDebug,SendPacket,BuildBattlegroundListPacket,BattlegroundTypeId,LookupEntry],HandleBattlefieldStatusOpcode->[GetBattlegroundQueue,GetEndTime,getMSTi... | This is a private method to handle a single unknown block of data from a battle if we can t join to battleground then we can t do anything if player refuses to join the BG then leave queue. | feels a bit wrong.. we are tracking who does NOT desert inside a `TRACK_DESERTERS` feature. Why not simply adding a new hook such as `OnPlayerJoinedBG` ? |
@@ -732,7 +732,8 @@ export class AmpAnalytics extends AMP.BaseElement {
'iframePing is only available on page view requests.');
sendRequestUsingIframe(this.win, request);
} else {
- sendRequest(this.win, request, this.config_['transport'] || {});
+ this.transport_.sendRequest(this.win, ... | [No CFG could be retrieved] | Creates a unique id for the given request. Config - > VendorConfig. | seems `this.transport_` might haven't been initialized? might be a bug after you remove the code in your constructor? |
@@ -93,7 +93,7 @@ class Project < ActiveRecord::Base
.joins("INNER JOIN user_organizations ON users.id = user_organizations.user_id ")
.where("user_organizations.organization_id = ?", organization)
.where.not(confirmed_at: nil)
- .where("users.id NOT IN (?)", UserProject.where(project: self).select(:i... | [Project->[assigned_modules->[user_role],space_taken->[space_taken],log->[log]]] | Find the first unassigned user in the project. | Line is too long. [93/80]<br>Use 2 (not 0) spaces for indenting an expression spanning multiple lines.<br>Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -83,7 +83,7 @@ namespace System
ref stackMark);
}
- public static object? CreateInstance(Type type, bool nonPublic) =>
+ public static object? CreateInstance([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | Dynamically... | [Activator->[CreateInstanceInternal->[CreateInstance],CreateInstance->[CreateInstance]]] | Create an object handle instance. | Wouldn't this only need DefaultConstructor? Or does DefaultConstructor imply only a public parameterless ctor rather than just implying a parameterless ctor? |
@@ -11,6 +11,8 @@ namespace System
{
public static partial class Environment
{
+ private static volatile int s_systemPageSize;
+
public static int ProcessorCount { get; } = GetProcessorCount();
/// <summary>
| [Environment->[GetFolderPath->[GetFolderPath],SetEnvironmentVariable->[SetEnvironmentVariable],GetEnvironmentVariable->[GetEnvironmentVariable]]] | Creates an Environment object that can be used to access a specific environment variable. | Nit: The current style used in this file is to always have the cache statics in front of the method that does the caching. |
@@ -227,12 +227,6 @@ namespace DSOffice
public static object WriteDataToExcelWorksheet(
object worksheet, int startRow, int startColumn, object[][] data)
{
- if (startRow < 1)
- throw new ArgumentException("Must be a positive integer.", "startRow");
-
- ... | [Excel->[WriteDataToExcelWorksheet->[ConvertToDimensionalArray],GetDataFromExcelWorksheet->[ConvertToJaggedArray]],ExcelInterop->[DynamoModelOnCleaningUp->[TryQuitAndCleanup]]] | Write data to an Excel worksheet. | Why do we want to remove these argument protections? |
@@ -81,7 +81,7 @@ class QueryStreamWriter implements StreamingOutput {
disconnectCheckInterval,
TimeUnit.MILLISECONDS
);
- if (row != null) {
+ if (row != null && (row.key() != null || row.value() != null)) {
write(out, buildRow(row));
} else {
... | [QueryStreamWriter->[drain->[buildRow,write],close->[close],write->[write],outputException->[write]]] | Writes the query results to the given output stream. | Just curious, is this required? It seems like you're just sending a null row, not null parts. |
@@ -331,7 +331,7 @@ class NlvrDecoderStep(DecoderStep[NlvrDecoderState]):
padded_actions = [common_util.pad_sequence_to_length(action_list, max_num_actions)
for action_list in actions_to_embed]
# Shape: (group_size, num_actions)
- action_tensor = Variable(state.score[... | [NlvrDecoderStep->[_get_action_query->[append,squeeze,cat,clamp,stack,zip],_get_action_embeddings->[new,max,size,len,get_mask_from_sequence_lengths,pad_sequence_to_length,Variable,index_select,view,score],take_step->[max,bmm,global_valid_actions,_get_next_state_info_without_agenda,_get_action_embeddings,_get_next_state... | Returns an embedded representation of all of the given actions in the given state. Get the action embeddings and the mask of the last action. | Can't you pass in the type to the `new_tensor` method? `dtype=torch.long` |
@@ -81,6 +81,10 @@ func NewModules(config []*common.Config, r *Register) (map[Module][]MetricSet, e
return nil, errs.Err()
}
+ if len(modToMetricSets) == 0 {
+ return nil, ErrAllModulesDisabled
+ }
+
debugf("mb.NewModules() is returning %s", modToMetricSets)
return modToMetricSets, nil
}
| [Unpack,moduleFactory,MakeDebug,Name,ToLower,Module,Errorf,metricSetFactory,Err,Config] | newBaseModulesFromConfig creates new BaseModules from a list of ModuleConfig data. newBaseModuleFromConfig creates a new BaseModule from a raw config. | That is fine for now but I think we probably have to remove it in the future. The reasoning here is that in case centralised configuration is used, it could be that metricbeat is started without any modules enabled, and then later modules are enabled from the central config. |
@@ -67,7 +67,15 @@ public interface Configuration {
* @return the value to which this configuration maps the specified key, or default value if the configuration
* contains no mapping for this key.
*/
- Object getProperty(String key, Object defaultValue);
+ default Object getProperty(String key,... | [No CFG could be retrieved] | Get a property of the object. | can be simplified with `return value!=null? value : defaultValue?` |
@@ -79,7 +79,11 @@ abstract class AbstractItemNormalizer extends AbstractObjectNormalizer
*/
public function normalize($object, $format = null, array $context = [])
{
- $resourceClass = $this->resourceClassResolver->getResourceClass($object, $context['resource_class'] ?? null, true);
+ $re... | [AbstractItemNormalizer->[denormalizeRelation->[denormalize],setValue->[setValue],getAttributeValue->[getFactoryOptions,normalize],normalizeRelation->[normalize,createRelationSerializationContext]]] | Normalize an object. | Why the change? |
@@ -29,6 +29,9 @@ namespace Pulumi
/// exiting once the set becomes empty.
/// </summary>
private readonly Dictionary<Task, List<string>> _inFlightTasks = new Dictionary<Task, List<string>>();
+ private readonly List<Exception> _exceptions = new List<Exception>();
+
+ ... | [Deployment->[Runner->[WhileRunningAsync->[LoggedErrors,Clear,TrySetCanceled,ForEach,Count,RunContinuationsAsynchronously,LogDebug,TrySetResult,Remove,Keys,TrySetException,ConfigureAwait,AddRange,Decrement],RunAsync->[stackFactory,GetService,nameof,RegisterPropertyOutputs,WhileRunningAsync,RegisterTask,FullName,HandleE... | Creates a new that is a part of the Application. There is no guarantee that the stack is called with the same arguments. | Hrm. Is this useful? This made me wonder about why we have this entire class in here, and it sounds like at a very high level it's there because "new Resource()" completes in a fire-and-forget manner and the background exceptions need to go somewhere, so presumably they go here? Is lifecycle of Runner pretty contained ... |
@@ -23,3 +23,11 @@ if AlaveteliConfiguration.enable_alaveteli_pro
else
AlaveteliFeatures.backend.disable(:alaveteli_pro) unless !AlaveteliFeatures.backend.enabled?(:alaveteli_pro)
end
+
+# Pro Pricing
+# We enable pro_pricing globally based on the ENABLE_PRO_PRICING config
+if AlaveteliConfiguration.enable_pro_pri... | [enable_annotations,enable_alaveteli_pro,enable,enabled?,disable] | Get the number of elements in the list. | Favor if over unless for negative conditions.<br>Line is too long. [106/80] |
@@ -52,6 +52,9 @@ PYBIND11_MODULE(KratosStructuralMechanicsApplication,m)
AddCrossSectionsToPython(m);
AddCustomResponseFunctionUtilitiesToPython(m);
+ // General pourpose
+ KRATOS_REGISTER_IN_PYTHON_VARIABLE(m, INTEGRATION_ORDER); // The integration order considered on the element
+
//registerin... | [No CFG could be retrieved] | Adds the given variables to the given object. This function register all the kraos generalized variables in the given MSSMatrix. | isnt there sth like this in the core? |
@@ -83,13 +83,12 @@ public class TaskState extends WorkUnitState {
private long duration;
// Needed for serialization/deserialization
- public TaskState() {
- }
+ public TaskState() {}
public TaskState(WorkUnitState workUnitState) {
// Since getWorkunit() returns an immutable WorkUnit object,
... | [TaskState->[readFields->[readFields],equals->[equals],write->[write],hashCode->[hashCode],toTaskExecutionInfo->[setEndTime,setStartTime,setJobId,setTaskId]]] | Creates a TaskState from a WorkUnitState. Gets the job ID of the task this task is for. | We should also fix that so that a `TaskState` only has a pointer to its `WorkUnitState`, rather than making a full copy of all the properties in the `WorkUnitState`. On an unrelated note, whats the difference between `TaskState` and `WorkUnitState`? I don't see any functional reason why the two can't be merged, they bo... |
@@ -196,7 +196,8 @@ public final class Native {
if (!name.startsWith("linux")) {
throw new IllegalStateException("Only supported on Linux");
}
- NativeLibraryLoader.load("netty_transport_native_epoll", PlatformDependent.getClassLoader(Native.class));
+ NativeLibraryLoader.lo... | [Native->[epollWait->[memoryAddress,newIOException,epollWait0,intValue,length],splice->[ioResult,splice0],epollCtlDel->[newIOException,epollCtlDel0],epollCtlMod->[newIOException,epollCtlMod0],sendfile->[ioResult,open,sendfile0],newEpollCreate->[epollCreate,FileDescriptor],newTimerFd->[FileDescriptor,timerFd],newEventFd... | Load the native library if it is available. | Should this be replaced with calls to PlatformDependent to get this information (duplicated with TC native)? And missing ones added there? |
@@ -92,6 +92,14 @@ class Functions {
return (object) $sanitized_post_type;
}
+ /**
+ * Return information about a synced post type.
+ *
+ * @param array $sanitized_post_type Array of args used in constructing \WP_Post_Type.
+ * @param string $post_type Post type name.
+ *
+ * @return object WP_Post_Type
+... | [Functions->[is_version_controlled->[is_vcs_checkout],get_modules->[get_modules],get_paused_themes->[get_all],get_paused_plugins->[get_all],expand_synced_post_type->[add_rewrite_rules,add_supports,register_taxonomies,add_hooks]]] | This function is used to sanitize a post type object. | Could we prefix all global classes with `\` in docs too, since that's how they're referred to in a namespace? |
@@ -0,0 +1,16 @@
+# Copyright 2013-2019 Lawrence Livermore National Security, LLC and other
+# Spack Project Developers. See the top-level COPYRIGHT file for details.
+#
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+from spack import *
+
+
+class Bitsery(CMakePackage):
+ """Header only C++ binary serialization li... | [No CFG could be retrieved] | No Summary Found. | (EDIT: I'm guessing this is unintentional and will go away when you open a new PR) Is this package necessary to support the `aocc` package? I don't see it being needed based on looking at the `depends_on` declarations. Could you remove this and other package files in `var/spack/repos/builtin/packages/` except for `aocc... |
@@ -284,10 +284,17 @@ class StorageAccountHostsMixin(object): # pylint: disable=too-many-instance-att
enforce_https=False
)
+ Pipeline._prepare_multipart_mixed_request(request) # pylint: disable=protected-access
+ body = serialize_batch_body(request.multipart_mixed_info[0], batch_... | [StorageAccountHostsMixin->[close->[close],__exit__->[__exit__],__enter__->[__enter__]],TransportWrapper->[send->[send]]] | Send a batch request to the storage service. | What is the point of this line? isn't `multipart_mixed_info` already set and we use this for `serialize_batch_body` since we can now fetch `request.multipart_mixed_info[0]`. From my understanding this enables us to serialize the body ourselves without relying on `request.prepare_multipart_body()` (which is why we set `... |
@@ -527,8 +527,6 @@ class WaitForBQJobs(beam.DoFn):
return WaitForBQJobs.FAILED
elif job.status.state == 'DONE':
continue
- else:
- return WaitForBQJobs.WAITING
return WaitForBQJobs.ALL_DONE
| [WriteRecordsToFile->[process->[_make_new_file_writer]],BigQueryBatchFileLoads->[_write_files->[_ShardDestinations,WriteGroupedRecordsToFile],expand->[_write_files,_window_fn,_generate_load_job_name,_load_data,file_prefix_generator],_load_data->[WaitForBQJobs,TriggerCopyJobs,TriggerLoadJobs,DeleteTablesFn]],WriteGroupe... | Check the status of all jobs in the list of job_references. | Why are we changing wait logic here ? Please remove if unrelated. |
@@ -25,7 +25,7 @@ module NSXDriver
def initialize(nsx_client)
super(nsx_client)
# Construct base URLs
- @url_tzs_nsxt = NSXDriver::NSXConstants::NSXT_TZS
+ @url_tzs_nsxt = NSXConstants::NSXT_TZS
end
# METHODS
| [NSXTtz->[tzs->[get],attr_reader]] | Construct a object. | may be better to just use the constant? |
@@ -0,0 +1,15 @@
+package org.infinispan.query.blackbox;
+
+import org.testng.annotations.Test;
+
+/**
+ * @since 9.0
+ */
+@Test(groups = "functional", testName = "query.blackbox.ClusteredCacheWithAffinityIndexManagerTxTest")
+public class ClusteredCacheWithAffinityIndexManagerTxTest extends ClusteredCacheWithAffinity... | [No CFG could be retrieved] | No Summary Found. | This is added in first commit then renamed in the second. I'd squash those two. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.