patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -286,6 +286,15 @@ export class AmpAdXOriginIframeHandler {
this.embedStateApi_.destroy();
this.embedStateApi_ = null;
}
+ if (this.positionObserver_) {
+ if (this.iframe) {
+ this.positionObserver_.unobserve(this.iframe);
+ }
+ }
+ if (this.positionObserverHighFidelityApi... | [No CFG could be retrieved] | Private methods for handling the size of an iframe resource. Sends a response to the window which requested a resize. | @aghassemi Added this as positionObserver should unobserve and stop calling `getBoundingClientRect` after an element is cleaned up. |
@@ -7,6 +7,14 @@ module ApplicationHelper
content_for(:card_cls) { cls }
end
+ def step_cls(step, active)
+ if active > step
+ 'complete'
+ elsif active == step
+ 'active'
+ end
+ end
+
def tooltip(text)
content_tag(
:span, \
| [title->[content_for],tooltip->[image_tag,content_tag,asset_url],decorated_session->[present?,new],card_cls->[content_for]] | Adds a card class to the template. | what do you think about just calling it `step_class` to be easier to read? |
@@ -210,7 +210,7 @@ public class IntegrationMBeanExporter extends MBeanExporter implements BeanPostP
*/
public void setDefaultDomain(String domain) {
this.domain = domain;
- this.namingStrategy.setDefaultDomain(domain);
+ this.defaultNamingStrategy.setDefaultDomain(domain);
}
public void setComponentNam... | [IntegrationMBeanExporter->[registerSources->[registerBeanInstance],destroy->[destroy],setBeanClassLoader->[setBeanClassLoader],stopActiveChannels->[stop],setBeanFactory->[setBeanFactory],stop->[stop],enhanceHandlerMonitor->[handlerInAnonymousWrapper,extractTarget],registerChannels->[registerBeanInstance],stopMessageSo... | Sets the default domain for the naming strategy. | So, if I provide `naming-strategy` and `default-domain` I end up with issue? Right? I don't see `domain` propagation to the provided `namingStrategy`. Or are these attributes mutually exclusive now? |
@@ -293,7 +293,7 @@ class Jetpack_React_Page extends Jetpack_Admin_Page {
'errorCode' => Jetpack::state( 'error' ),
'errorDescription' => Jetpack::state( 'error_description' ),
),
- 'tracksUserData' => Jetpack_Tracks_Client::get_connected_user_tracks_identity(),
+ 'tracksUserData' => Tracking::get_con... | [Jetpack_React_Page->[get_initial_state->[get_dismissed_jetpack_notices],add_noscript_head_meta->[add_fallback_head_meta]]] | Get the initial state of the API. Get all theme information about the current theme. This function is called from the Jetpack plugin. It is called by Jetpack This function is used to render a site icon. | Can we pass the connection manager in the constructor of `Jetpack_React_Page`? |
@@ -632,6 +632,9 @@ func UserSignIn(username, password string) (*User, error) {
switch user.LoginType {
case LoginNoType, LoginPlain, LoginOAuth2:
if user.ValidatePassword(password) {
+ if user.ProhibitLogin || !user.IsActive {
+ return nil, ErrUserLoginProhibited{Name: user.Email}
+ }
return u... | [HasTLS->[IsSMTP,IsLDAP,IsDLDAP],OAuth2,IsLDAP,IsOAuth2] | UserSignIn validates user name and password. ExternalUserLogin logs in via an external user. | Also should check in `ExternalUserLogin` |
@@ -48,7 +48,9 @@
</span>
</h1>
<% else %>
- <h1 class="fs-xl s:fs-3xl">Settings for <a href="/<%= @user.username %>">@<%= @user.username %></a></h1>
+ <h1 class="fs-xl s:fs-3xl">
+ Settings for <a href="<%= user_url(@user) %>">@<%= @user.username.truncate(User::USERNAM... | [No CFG could be retrieved] | Displays a list of possible organization identifiers. Return a list of all user s unique id. | This is to truncate the displaying of the username in case the user manages to send more than 30 chars (which breaks the layout) |
@@ -72,6 +72,10 @@ class Report(object):
# We synchronize on this, to support parallel execution.
self._lock = threading.Lock()
+ @property
+ def json_reporter(self):
+ return self._reporters['json']
+
def open(self):
with self._lock:
for reporter in self._reporters.values():
| [Report->[end_workunit->[end_workunit],bulk_record_workunits->[bulk_record_workunits],__init__->[EmitterThread],start_workunit->[start_workunit],close->[close,stop_thread],open->[open]]] | Initialize the report with a single sequence of workunits. | Adding knowledge of a _type_ of reporter to `Report` feels less than ideal, but seemed to be the better option for getting the path to the `JsonReporter` output (another being defining that path in the `RunTracker` - which felt more brittle, though there may be other options worth considering) |
@@ -70,7 +70,7 @@ public final class AzureStorageUtils {
"In addition, the provenance repositories may be put on encrypted disk partitions.")
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
- ... | [AzureStorageUtils->[createCloudBlobClient->[createCloudBlobClient],setProxy->[setProxy],validateProxySpec->[validateProxySpec]]] | The event provenance data. b e a konfiguraci o nfiguraci o nfig. | I'd update the description to add suggestion for using the Lookup service to make credential dynamic. |
@@ -85,6 +85,7 @@ public class ZeppelinServer extends Application {
public static Server jettyWebServer;
public static NotebookServer notebookWsServer;
public static Helium helium;
+ public static UsersRepo usersRepo;
private final InterpreterSettingManager interpreterSettingManager;
private Scheduler... | [ZeppelinServer->[setupNotebookServer->[setInitParameter,getWebsocketMaxTextMessageSize,ServletContextHandler,NotebookServer,addServlet,ServletHolder],isBinaryPackage->[isDirectory],getSslContextFactory->[getTrustStorePassword,SslContextFactory,getKeyManagerPassword,getKeyStorePassword,getKeyStoreType,setKeyStorePath,s... | Creates a new instance of ZeppelinServer. Zeppelin - web is a directory where the files are copied to zep. | I don't have a more proper name, but `UsersRepo` seems a little confusing to me when it is used to stored the recent opened notes. |
@@ -127,15 +127,15 @@ def _is_filepath(output_stream):
"""Returns True if output_stream is a file path."""
return isinstance(output_stream, str) and output_stream.startswith("file://")
-
+# todo: remove this when release tfv2
# Temporarily disable pylint g-doc-args error to allow giving more context
# about w... | [merge_all_summaries->[merge_summary],merge_summary->[_Collect,merge_summary],audio_summary->[_Collect],image_summary->[image_summary,_Collect],print_v2->[print_v2,_generate_placeholder_string,_is_filepath],scalar_summary->[_Collect,scalar_summary],get_summary_op->[merge_all_summaries],histogram_summary->[_Collect,hist... | Checks if output_stream is a file path. This function prints a sequence of 1 - 2 2 - 4 - 7 8 - 9 - Print a single C ++ . This function returns a template that can be used to display a list of strings and lists of Formats and prints a single a object. | Remove the TODO |
@@ -169,3 +169,6 @@ def _start_logging():
global logger
logs.start_logging()
logger = logging.getLogger(__name__)
+ console_handler = logging.StreamHandler()
+ console_handler.setLevel(logging.INFO)
+ logger.root.addHandler(console_handler)
| [main->[parse_args],migrate_database->[DataError],_auto_manage_db->[migrate_database],parse_args->[parse_args]] | Call into Pulp to get the logging started. | Ah, I didn't know about logger.root. Is that the absolute root logger, or is it the root of this logger? Either way, as long as the log messages from pulp.server.db.connection get printed this is fine by me. |
@@ -81,7 +81,7 @@ public class DataSourceMetadataQueryTest
"useCache",
true,
"populateCache",
- ... | [DataSourceMetadataQueryTest->[testFilterSegments->[getInterval]]] | Test context serde. | we should leave a test for strings, for backwards compatibility |
@@ -520,11 +520,11 @@ class PipelineOptionsTest(unittest.TestCase):
options = Breakfast()
self.assertEquals(
set(['from_dictionary', 'get_all_options', 'slices', 'style',
- 'view_as', 'display_data']),
+ 'view_as', 'display_data', 'next']),
set([attr for attr in dir(o... | [FakeSource->[reader->[_Reader]],DirectRunnerRetryTests->[test_no_partial_writeouts->[start_bundle,process_element,TestTransformEvaluator]],DoFnTest->[test_timestamp_param->[TestDoFn],test_side_input_tagged->[TestDoFn],test_side_input_no_tag->[TestDoFn],test_element->[TestDoFn],test_window_param->[TestDoFn]],RunnerApiT... | Checks that the directory contains all necessary attributes. | This is fine, but was there a particular reason it was added? |
@@ -965,6 +965,12 @@ func (sg *stepGenerator) providerChanged(urn resource.URN, old, new *resource.St
return false, err
}
+ if alias, ok := sg.aliased[oldRef.URN()]; ok && alias == newRef.URN() {
+ logging.V(stepExecutorLogLevel).Infof(
+ "sg.diffProvider(%s, ...): observed an aliased provider from %q to %q",... | [AnalyzeResources->[getProviderResource],GenerateSteps->[isTargetedUpdate],generateSteps->[isTargetedForUpdate,isTargetedReplace],diff->[isTargetedReplace,providerChanged],calculateDependentReplacements->[loadResourceProvider],generateStepsFromDiff->[isTargetedReplace]] | providerChanged is called when a resource s Provider field has changed. diffProvider diff the old provider and the new provider and determine if the new provider requires a proceed with resource diff. | Are there any alias cases we need to consider beyond `alias == newRef.URN()`? |
@@ -148,7 +148,7 @@ func marshalInputs(props Input) (resource.PropertyMap, map[string][]URN, []URN,
pdeps[pname] = allDeps.values()
}
- if !v.IsNull() || len(deps) > 0 {
+ if !v.IsNull() || len(allDeps) > 0 {
pmap[resource.PropertyKey(pname)] = v
}
return nil
| [Store->[Unlock,Version,Lock,Errorf,EQ],Load->[GTE,Version,RLock,RUnlock,EQ],IsObject,Index,ElementType,NewArchiveProperty,IsBool,PropertyKey,MapKeys,HasPrefix,NewNumberProperty,ParseTolerant,New,Len,IsComputed,Bool,ID,newDependencyCustomResource,TypeOf,IsPath,CanSet,Implements,AssignableTo,SecretValue,IsURI,ConstructP... | expandDependencies returns a set of all dependencies in the input. returns a non - nil error if the type of the input object is not a pointer. | Oof I could've caught that at review. |
@@ -38,6 +38,7 @@ namespace DotNetNuke.Application
}
/// <inheritdoc />
+ [CLSCompliant(false)]
public UpgradeStatus Status
{
get
| [ApplicationStatusInfo->[UpdateDatabaseVersionIncrement->[UpdateDatabaseVersionIncrement],UpdateDatabaseVersion->[UpdateDatabaseVersion],GetLastAppliedIteration->[GetLastAppliedIteration]]] | Creates an application status object. Exception message. | I think it would be better to add `[assembly: CLSCompliant(true)]` to the Abstractions project (also the Dependency Injection project probably needs it also). |
@@ -839,8 +839,6 @@ static int host_copy(struct comp_dev *dev)
tracev_host("cpy");
- if (dev->state != COMP_STATE_ACTIVE)
- return 0;
local_elem = list_first_item(&hd->config.elem_list,
struct dma_sg_elem, list);
| [No CFG could be retrieved] | copies data from source to sink buffers c - host - buffer - > local_elem - > channel - > period_bytes. | I dont see how this improve XRUN or pause release. This commit messages give no detail. |
@@ -56,7 +56,7 @@ public class PetStoreClient {
return disconnectCount;
}
- public boolean isConnected() {
+ public boolean hasActiveConnection() {
checkState(disconnectCount >= 0, "negative disconnectCount");
return disconnectCount == 0;
}
| [PetStoreClient->[isConnected->[checkState],getPets->[checkArgument,getPets,equals]]] | Returns the number of disconnects. | not against this change, but why? |
@@ -33,6 +33,7 @@ class PyBrian2(PythonPackage):
depends_on('py-sphinx@1.5:', type=('build', 'run'), when='+docs')
depends_on('py-sphinx@1.8:', type=('build', 'run'), when='@2.4:+docs')
depends_on('py-ipython@5:', type=('build', 'run'), when='@2.4:+docs')
+ depends_on('py-sphinx-tabs', type=('build', ... | [PyBrian2->[variant,depends_on,version]] | Build the command line arguments for the given spec. | I don't think this package exists in Spack, you'll need to write a package for this |
@@ -95,10 +95,15 @@ class AutotoolsPackage(PackageBase):
#: Options to be passed to autoreconf when using the default implementation
autoreconf_extra_args = []
+ @run_after('autoreconf')
def _do_patch_config_guess(self):
"""Some packages ship with an older config.guess and need to have
... | [AutotoolsPackage->[patch->[_do_patch_config_guess],with_or_without->[_activate_or_not],autoreconf->[autoreconf],enable_or_disable->[_activate_or_not],configure->[configure_args]]] | Patch config. guess to use a bunch of things that can be used in the future. Checks if a exists in the given path. | I don't think we need a return value anymore. |
@@ -75,7 +75,7 @@ class ExportDirtyTest(unittest.TestCase):
self.client.run("export . lasote/stable")
self.assertIn("Source folder is corrupted, forcing removal", self.client.out)
self.client.run("install Hello0/0.1@lasote/stable --build")
- self.assertIn("WARN: Trying to remove corrup... | [SourceDirtyTest->[test_keep_failing_source_folder->[package_layout,TestClient,assertEqual,assertIn,replace,run,join,save,loads,listdir,load]],ExportDirtyTest->[test_install_remove->[assertIn,run,close],test_export_remove->[assertIn,run,close],setUp->[package_layout,files,write,TestClient,save,assertIn,run,join,open,cp... | Test export remove and install remove. | Here, if `rmdir` fails to remove the source folder, I would expect an exception being raised from the `rmdir` function before the `clean_dirty` one... Up to here the test is ok, but what is it trying to test in the next two lines? |
@@ -18,7 +18,7 @@ ModuleInfo::ModuleInfo(ArenaAllocator * alloc) :
m_indirectFuncCount(0),
m_exportCount(0),
m_datasegCount(0),
- m_startFunc(0) // XXX
+ m_startFunc((uint32)-1)
{
m_signatures = Anew(m_alloc, WasmSignatureArray, m_alloc, 0);
m_indirectfuncs = nullptr;
| [No CFG could be retrieved] | -------------- - Section 7. 4. 1. region ModuleInfo Methods. | nit: i would prefer we use something like Js::Constants::UninitializedValue for clarity |
@@ -77,8 +77,8 @@ class AddToCartForm(forms.AddToCartForm):
return self.product
-stocked_variant = BigShipVariant(name='Big Ship')
-non_stocked_variant = ShipPhotoVariant(name='Ship Photo')
+stocked_variant = ProductVariant(name='Big Ship')
+non_stocked_variant = ProductVariant(name='Ship Photo')
def ... | [test_cart_doesnt_contain_empty_products->[BigShipVariant],test_quantity_is_correctly_saved->[AddToCartForm],test_multiple_actions_result_in_combined_quantity->[AddToCartForm],test_excessive_quantity_is_rejected->[AddToCartForm],BigShipVariant,ShipPhotoVariant] | Test cart checks quantity. | This does not make sense now. These two are identical, both of them are stocked. |
@@ -177,6 +177,7 @@ class StripeGatewayPlugin(BasePlugin):
payment_method_id = data.get("payment_method_id") if data else None
setup_future_usage = None
+ # DEPRECATED
if payment_information.reuse_source:
setup_future_usage = data.get("setup_future_usage") if data else N... | [StripeGatewayPlugin->[get_supported_currencies->[get_supported_currencies],confirm_payment->[_get_transaction_details_for_stripe_status],process_payment->[_get_transaction_details_for_stripe_status]]] | Process a single payment. Get a response object with a single response object for a single payment request. | Can you add here a note that this should be removed in Saleor 4.0? It will be easier to find this when we will going to remove all deprecated things for 4.0 |
@@ -180,14 +180,14 @@ class ParamAttr(object):
class WeightNormParamAttr(ParamAttr):
"""
Used for weight Norm. Weight Norm is a reparameterization of the weight vectors
- in a neural network that decouples the length of those weight vectors from
+ in a neural network that decouples the magnitude of tho... | [ParamAttr->[_set_default_bias_initializer->[_set_default_initializer],_to_attr->[ParamAttr,_to_attr],_set_default_param_initializer->[_set_default_initializer]]] | Returns the attributes of the given parameter. A wrapper for the above function. | Might it be the Dimension except which |
@@ -434,9 +434,8 @@ namespace System.Windows.Forms
}
}
- // Need to reset the DeviceDpi as it will have potentially changed if this was the first call to set
- // the DPI context for the process.
- s_deviceDpi = GetDeviceDPI();
+ // Need to res... | [DpiHelper->[LogicalToDeviceUnitsY->[LogicalToDeviceUnits],Padding->[LogicalToDeviceUnits],LogicalToDeviceUnitsX->[LogicalToDeviceUnits],Size->[LogicalToDeviceUnits],SetWinformsApplicationDpiAwareness->[GetDeviceDPI]]] | SetWinformsApplicationDpiAwareness - This method checks if a specific type of object This method checks if a specific node is available in DPI. | Now that we are resetting multiple things and executing decent size code underneath it, i would condition it based on 'sucess'. |
@@ -64,6 +64,18 @@ class Papi(AutotoolsPackage):
self.spec.variants)
if variants:
options.append('--with-components={0}'.format(' '.join(variants)))
+
+ # The logic above enables specific components
+ # The logic below explicitly disable variants when speci... | [Papi->[fortran_check->[RuntimeError],fix_darwin_install->[join_path,rename,fix_darwin_install_name],fix_build->[join_path,filter_file,iglob],component_configure->[Version,working_dir,Executable,configure_script],setup_build_environment->[Version,set],configure_args->[append,filter,format,join],depends_on,conflicts,run... | Configure the command line options for the MPI and PAPI. | Can you enable these in the if clause and explicitly disable them in the else clause? |
@@ -415,7 +415,8 @@ public final class FilePath implements Serializable {
zip(os,(FileFilter)null);
}
- public void zip(FilePath dst) throws IOException, InterruptedException {
+ public void zip(@Nonnull FilePath dst) throws IOException, InterruptedException {
+ assert dst != null;
... | [FilePath->[UntarFrom->[invoke->[extract]],unzip->[FilePath,unzip],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],ValidateAntFileMask->[invoke->[equals],hasMatch->[isCaseSensitive->[isCaseSensitive,Cancel]]],UnzipLocal->[invoke->[getRemote,unzip]],copyTo->[copyTo,write,act],LastModi... | Zip the contents of this file into the given output stream. | I do not think asserts are really required, static analysis should start producing issues even before the tests run (we also need to configure surefire to do the same if possible, like IDEA does) |
@@ -1776,6 +1776,14 @@ class TestVersionViewSetCreate(UploadMixin, TestCase):
assert 'Version 0.0.1 matches ' in str(response.data['non_field_errors'])
assert self.addon.reload().versions.count() == 1
+ def test_cant_update_disabled_addon(self):
+ self.addon.update(status=amo.STATUS_DISABL... | [AddonAndVersionViewSetDetailMixin->[test_get_by_slug->[_test_url,_set_tested_url],test_get_by_guid_email_short_format->[_test_url,_set_tested_url],test_get_by_id->[_test_url],test_get_by_guid->[_test_url,_set_tested_url],test_get_addon_not_found->[_set_tested_url],test_get_by_guid_email_format->[_test_url,_set_tested_... | Test that the blocklist is valid. | I notice in other tests we also assert about `response.data`. Is that worth doing here as well? |
@@ -13,11 +13,11 @@ import os
import shutil
import tempfile
-import Crypto.PublicKey.RSA
-import M2Crypto
+import OpenSSL
from acme.jose import util as jose_util
+from letsencrypt import crypto_util
from letsencrypt import errors
from letsencrypt import le_util
from letsencrypt import network
| [Cert->[get_fingerprint->[get_fingerprint],fromrow->[_get_backup],get_not_before->[get_not_before],get_not_after->[get_not_after],__str__->[get_fingerprint,get_not_before,get_san,get_pub_key,get_not_after]]] | A module to enable LE revocations on a single object. Revoke all certificates under an authorized key. | Thanks for updating... sorry for the dead code :( |
@@ -42,7 +42,8 @@ type Type interface {
String() string
equals(other Type, seen map[Type]struct{}) bool
- conversionFrom(src Type, unifying bool, seen map[Type]struct{}) (ConversionKind, hcl.Diagnostics)
+ conversionFrom(src Type, unifying bool, seen map[Type]struct{}) (ConversionKind, lazyDiagnostics)
+ //conver... | [unify,ConversionFrom,Exists,unifyTo,conversionFrom,Assertf,conversionTo,Assert,Equals] | package returns a new object with the name of the type that is represented by the returns an assignable type if possible otherwise returns a non - assignable type. | Do we need this line? |
@@ -347,7 +347,7 @@ static inline int ssp_set_config(struct dai *dai,
else
sscr0 |= SSCR0_DSIZE(data_size);
- sscr1 |= SSCR1_TFT(0x7) | SSCR1_RFT(0x7);
+ sscr1 |= SSCR1_TFT(0x8) | SSCR1_RFT(0x8);
ssp_write(dai, SSCR0, sscr0);
ssp_write(dai, SSCR1, sscr1);
| [inline->[SSCR1_RFT,SSPSP_SCMODE,SSCR0_DSIZE,trace_ssp_error,SSPSP_DMYSTOP,SSCR0_SCR,ssp_update_bits,spin_lock,spin_unlock,dai_get_drvdata,shim_update_bits,SSPSP_EDMYSTOP,SHIM_CLKCTL_SMOS,SSPSP_SFRMWDTH,SSCR1_TFT,trace_ssp,SSPSP_DMYSTRT,SHIM_CLKCTL_EN_SSP,ssp_write,SSCR0_FRDC,SSPSP_SFRMP],int->[dai_get_drvdata,ssp_cont... | private method to set the configuration of an SSP DAI - - - - - - - - - - - - - - - - - - out = - EINVAL ; out = 0 ; This function is used to set the flags for the specified node in the configuration object. | we should try to make this smarter and depend on the number of slots (for both BYT and BDW). |
@@ -606,6 +606,13 @@ public class DnsNameResolver extends InetNameResolver {
}
private final class DnsResponseHandler extends ChannelInboundHandlerAdapter {
+
+ private final Promise<Channel> channelActivePromise;
+
+ public DnsResponseHandler(Promise<Channel> channelActivePromise) {
+ ... | [DnsNameResolver->[query0->[query],doResolveAll->[doResolveAll,setSuccess,resolveHostsFileEntry],executor->[executor],doResolve->[doResolve,resolveHostsFileEntry],doResolveUncached->[finishResolve->[setSuccess]],query->[query],close->[close]]] | Check if a response has been received and if so finish the query context. | @vietj make the constructor package private |
@@ -20,6 +20,7 @@ def ImportApplication(application, application_name, application_folder, caller)
raise RuntimeError(msg)
elif application_name not in Globals.RequestedApplications: # This check is possibly redundant, as Python won't import the same module twice
print("Importing " + applicat... | [ImportApplication->[list,AddApplication,append,print,InitializeApplication,str,Initialize,join,RuntimeError,items]] | Imports an application into the system. | I assume this is due to GiD not printing the output in the progress window? I would preffer not to put it in the `application_importer.py` since you are already adding one to your script. At least not for the release, we can discuss later about this, but as I see this is something that GiD team has to solve, not us. |
@@ -45,6 +45,9 @@ def read_raw_ctf(directory, system_clock='truncate', preload=False,
verbose : bool, str, int, or None
If not None, override default verbose level (see :func:`mne.verbose`
and :ref:`Logging documentation <tut_logging>` for more).
+ clean_names : bool
+ If True main chan... | [read_raw_ctf->[RawCTF],RawCTF->[__init__->[_read_res4,TypeError,list,append,_read_eeg,_make_ctf_name,isdir,endswith,len,_compose_meas_info,_get_sample_info,super,ValueError,isinstance,_read_hc,_make_ctf_coord_trans_set,info,_read_pos],_read_segment_file->[int,_mult_cal_one,min,len,seek,fromfile,_blk_read_lims,open,ran... | Read a raw CTF file from a given directory. | Say something about what is the default. Look at a bunch of other MNE doc strings to see how it's most commonly done. |
@@ -158,6 +158,12 @@ def add_parser(subparsers, _parent_parser):
default=False,
help="Pull cache for subdirectories of the specified directory.",
)
+ pull_parser.add_argument(
+ "--drop-index",
+ action="store_true",
+ default=False,
+ help="Drop local index for the... | [CmdDataFetch->[run->[check_up_to_date]],add_parser->[add_parser,shared_parent_parser],CmdDataPush->[run->[check_up_to_date]],CmdDataPull->[run->[check_up_to_date]]] | Adds a parser to subparsers to pull and push a specified block of cache. Adds command line options for pushing a bunch of cache entries to a remote repository. Adds command line options for fetching a specific block of cache. | `remote cache` -> `remote` (we try to avoid using `cache` with remotes, just to make it less confusing with `.dvc/cache`) ? |
@@ -83,6 +83,13 @@ def test_io_evoked():
assert_equal(av1.first, av2.first)
assert_equal(av1.comment, av2.comment)
+ # test warnings on bad filenames
+ with warnings.catch_warnings(record=True) as w:
+ fname2 = op.join(tempdir, 'test-bad-name.fif')
+ write_evokeds(fname2,... | [test_evoked_proj->[apply_proj,all,deepcopy,read_evokeds,assert_allclose,del_proj,assert_true,len,assert_raises,copy,dot,add_proj],test_evoked_to_nitime->[to_nitime,assert_equal,read_evokeds],test_evoked_detrend->[read_evokeds,allclose,mean,assert_true,detrend,pick_types],test_drop_channels_mixin->[assert_equal,len,rea... | Test IO for evoked data. Test for read_evokeds and write_evokeds. Shift backward and check for missing values in evokes. | forgot the `warnings.simplefilter('always')`, and make sure there's one toward the top of the file, too |
@@ -1211,7 +1211,7 @@ func (s *testScatterRangeLeaderSuite) TestConcurrencyUpdateConfig(c *C) {
for {
select {
case <-ch:
- break
+ //break
default:
}
sche.config.BuildWithArgs(args)
| [TestBalanceSelector->[schedule],TestLeaderWeight->[schedule],TestBalanceLeaderScheduleStrategy->[schedule],TestBalanceLimit->[schedule],TestScheduleWithOpInfluence->[schedule],TestBalanceLeaderTolerantRatio->[schedule],TestBalanceFilter->[schedule]] | TestConcurrencyUpdateConfig tests concurrency update config. | change to `return`? |
@@ -1551,6 +1551,7 @@ function pdf_getlinedesc($object, $i, $outputlangs, $hideref = 0, $hidedesc = 0,
// Now we convert \n into br
if (dol_textishtml($libelleproduitservice)) {
+ $libelleproduitservice = str_replace("\n", '<br/>', $libelleproduitservice);
$libelleproduitservice = preg_replace('/__N__/', '<br... | [pdf_bank->[line,convToOutputCharset,getY,SetXY,transnoentities,getCountryCode,MultiCell,getFieldsToShow,getStringHeight,useDetailedBBAN,load,SetFont],pdf_getlineref_supplier->[executeHooks,getSpecialCode],pdf_getlineremisepercent->[executeHooks,getSpecialCode],pdf_getFormat->[fetch_object,query,escape],pdf_getlinedesc... | PDF getlinedesc function Get product product object This function is used to generate a description for a single product. Description long of product line This function checks if the description is defined and if it is output it Demonstrates how to display a specific product or service This function parses the line tha... | If your text $libelleproduitservice is a html text, the \n into it is not a new line, but something that must not appears on PDF. If $libelleproduitservice has a HTML format, and need a new line into content, the <br> must be inside the content $libelleproduitservice. You can't have some part of var that is html and so... |
@@ -23,11 +23,11 @@ const (
// FirstEpoch is the number of the first epoch.
FirstEpoch = 1
// GenesisShardNum is the number of shard at genesis
- GenesisShardNum = 4
+ GenesisShardNum = 1
// GenesisShardSize is the size of each shard at genesis
- GenesisShardSize = 100
+ GenesisShardSize = 20
// GenesisShardH... | [Reshard->[cuckooResharding,sortCommitteeBySize,assignNewNodes],assignNewNodes->[sortCommitteeBySize],Reshard] | Package containing all of the basic information about a single non - zero number of non - zero nanononononononononononononononononon. | Please revert these constants. |
@@ -650,7 +650,10 @@ namespace DotNetNuke.Entities.Portals
public int SearchMinWordlLength { get; internal set; }
/// <inheritdoc/>
- public bool SSLEnabled { get; internal set; }
+ public Abstractions.Security.SiteSslSetup SSLSetup { get; internal set; }
+
+ /// <inheritdoc/>
+... | [PortalSettings->[BuildPortalSettings->[LoadPortalSettings,Join,Current,Items,Contains,ActiveTab,LoadPortal,GetActiveTab,ToString],GetProperty->[ToLowerInvariant,LogoFile,Boolean2LocalizedYesNo,PortalName,RegisterTabId,HomeDirectoryMapPath,DefaultLanguage,ContentLocked,Empty,Description,FormatString,HTTPAlias,Debug,Nul... | - A property to provide the filter used for inclusion of tag info. | @bdukes Didn't we have an issue in a prior release with this type of change breaking code? I cannot remember, but I thought a property swap like this had caused an issue. |
@@ -0,0 +1,16 @@
+class ImageUploadPresignedUrlGenerator
+ include AwsS3Helper
+
+ def presigned_image_upload_url(image_type:, transaction_id:)
+ return nil unless Figaro.env.doc_auth_enable_presigned_s3_urls == 'true'
+
+ s3_presigned_url(
+ bucket_prefix: bucket_prefix,
+ keyname: "#{transaction_id}... | [No CFG could be retrieved] | No Summary Found. | This was just de-namespaced (formerly `DocAuth::ImageUpload...`), since it definitely belongs outside the gem |
@@ -21,7 +21,7 @@ from mypy.nodes import (
Context, Decorator, PrintStmt, LITERAL_TYPE, BreakStmt, PassStmt, ContinueStmt,
ComparisonExpr, StarExpr, EllipsisExpr, RefExpr, ImportFrom, ImportAll, ImportBase,
ARG_POS, CONTRAVARIANT, COVARIANT, ExecStmt, GlobalDecl, Import, NonlocalDecl,
- MDEF, Node
+ ... | [TypeChecker->[analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[accept,check_indexed_assignment],check_return_stmt->[get_generator_return_type,acc... | Mypy type checker. A function to handle the creation of a type object. | Add trailing comma. |
@@ -35,14 +35,6 @@ class SourcesField(PayloadField):
self._sources = self._validate_sources(sources)
self._ref_address = ref_address
- @property
- def source_root(self):
- """:returns: the source root for these sources, or None if they're not under a source root."""
- # TODO: It'... | [SourcesField->[matches->[matches],__init__->[_validate_sources]]] | Initialize a sequence of functions that are called by the source manager to determine the sequence number of. | Could we use the same code in `target.py` to deprecate this instead of outright removal? While technically not API public, a deprecation is more friendly to plugin developers. |
@@ -2381,6 +2381,9 @@ templates: ${JSON.stringify(existingTemplates, null, 2)}`;
if (options.testFrameworks) {
this.jhipsterConfig.testFrameworks = options.testFrameworks;
}
+ if (options.cypressCoverage) {
+ this.jhipsterConfig.cypressCoverage = options.cypressCoverage;
+ }
if (options... | [No CFG could be retrieved] | The main entry point for the configuration. The options for the Hipster config are the options for the Hipster config. | This is only useful when the option is declared at app generator constructor. |
@@ -144,4 +144,12 @@ public class ResourceLocatorTest {
Assertions.assertEquals("posted: hello!", response.readEntity(String.class));
}
}
+
+ @Test
+ @DisplayName("Test @BeanParam annotation in Subresources")
+ public void testBeanParamsInSubresource() {
+ given().get("/sub3/f... | [ResourceLocatorTest->[generateURL->[generateURL],testAnnotationFreeSubresource->[get],testSubresource->[get],testProxiedSubresource->[close,generateURL,get],close->[close]]] | Test annotation free subresource. | You can drop this, we haven't used them in any other tests, so lets keep things consistent |
@@ -2248,6 +2248,15 @@ namespace Dynamo.ViewModels
foreach (var file in openFileDialog.FileNames)
{
EngineController.ImportLibrary(file);
+ string path = new FileInfo(file).Directory.FullName;
+ if (this.Mod... | [DynamoViewModel->[CanZoomOut->[CanZoomOut],SaveAs->[SaveAs,AddToRecentFiles,Save],ExportToSTL->[ExportToSTL],ShowOpenDialogAndOpenResult->[Open,CanOpen],ShowSaveDialogIfNeededAndSave->[SaveAs],ImportLibrary->[ImportLibrary],ReportABug->[ReportABug],ClearLog->[ClearLog],Escape->[CancelActiveState],ShowSaveDialogIfNeede... | ImportLibrary - Import all libraries found in the system. | does `ImportLibrary` get called from anywhere else besides the UI method? |
@@ -94,6 +94,7 @@ func (r *UtmpFileReader) ReadNew() (<-chan LoginRecord, <-chan error) {
errorC := make(chan error)
go func() {
+ defer logp.Recover("recovering from a crash while collecting login information")
defer close(loginRecordC)
defer close(errorC)
| [ReadNew->[Wrap,deleteOldUtmpFiles,readNewInFile,findFiles],restoreLoginSessionsFromDisk->[NewBuffer,Decode,Wrap,NewDecoder,Load,Debugf],deleteOldUtmpFiles->[Debugf],updateSavedUtmpFile->[Seek,Wrap,Debugf],restoreFileRecordsFromDisk->[NewBuffer,Decode,Wrap,NewDecoder,Load,Debugf],findFiles->[IsNotExist,Sys,Wrapf,Size,S... | ReadNew reads a new login record from the utmp files. | The message that gets appended already states that it's recovering. So how about: `A panic occurred while collecting login information` |
@@ -302,8 +302,14 @@ func (m *Manager) Attach(op trace.Operation, disk *types.VirtualDisk) error {
}
// Detach attempts to detach a virtual disk
-func (m *Manager) Detach(op trace.Operation, d *VirtualDisk) error {
- defer trace.End(trace.Begin(d.DevicePath))
+func (m *Manager) Detach(op trace.Operation, config *Vi... | [CreateAndAttach->[Infof,Begin,Detach,setAttached,End,Attach,String,Debugf,devicePathByURI,Errorf,Trace,ErrorStack,createDiskSpec],Create->[CreateVirtualDisk,Infof,Begin,Vim25,End,String,NewVirtualDiskManager,Trace,Wait],detachAll->[detach,Errorf,Error],Detach->[Infof,Begin,detach,lock,unlock,End,Attached,String,Errorf... | Detach detaches a virtual disk. | unclear why the `d.attachedRefs--` path is returning an error - please check that it's a soft error. |
@@ -317,6 +317,18 @@ class AttributeAssign(BaseMutation):
pk = from_global_id_strict_type(
operation.id, only_type=Attribute, field="operations"
)
+
+ try:
+ models.Attribute.objects.get(pk=pk)
+ except models.Attribute.DoesNotExist:
+ ... | [AttributeUpdate->[Arguments->[AttributeUpdateInput],perform_mutation->[clean_values,AttributeUpdate,_save_m2m,clean_attribute,clean_remove_values]],AttributeValueUpdate->[Arguments->[AttributeValueCreateInput],clean_instance->[validate_value_is_unique]],AttributeReorderValues->[perform_mutation->[AttributeReorderValue... | Resolve all passed global ids into integer PKs of the Attribute type. | It's not an optimal solution - it performs a database query for each operation. You could instead do one query always if you used `Attribute.objects.filter(id__in=all_attribute_ids)` or something like that and compare the number of instances you got from DB with the number of IDs passed in the input (or compare the IDs... |
@@ -108,8 +108,10 @@ export const StateProperty = {
PAUSED_STATE: 'pausedstate',
RTL_STATE: 'rtlstate',
SHARE_MENU_STATE: 'sharemenustate',
+ SIDEBAR_STATE: 'sidebarstate',
SUPPORTED_BROWSER_STATE: 'supportedbrowserstate',
STORY_HAS_AUDIO_STATE: 'storyaudiostate',
+ STORY_HAS_SIDEBAR_STATE: 'storyhassi... | [No CFG could be retrieved] | Enumerate all App state properties. Exports the state of the system system s action. | Could you please also update it to remove the `STORY_` prefix? It makes sense for the `AUDIO` above cause we have one state for the page and one for the story, but for the sidebar we should be able to remove it. |
@@ -153,6 +153,18 @@ public class BasicOzoneClientAdapterImpl implements OzoneClientAdapter {
objectStore = ozoneClient.getObjectStore();
this.volume = objectStore.getVolume(volumeStr);
this.bucket = volume.getBucket(bucketStr);
+
+ // Check if bucket layout is valid, OFS buckets cannot be in
+ // ... | [BasicOzoneClientAdapterImpl->[deleteObjects->[incrementCounter],IteratorAdapter->[next->[next],hasNext->[hasNext]],createFile->[createFile,incrementCounter],getDelegationToken->[getDelegationToken],listStatus->[listStatus,incrementCounter],listKeys->[listKeys,incrementCounter],getFileStatus->[getFileStatus,incrementCo... | Reads the object store and bucket from the specified file. Reads the file and increments the object read counter. | I don't think we need to convert bucketLayout to string, you can directly compare like `bucketLayout.equals(BucketLayout.OBJECT_STORE)` and you can directly print or concat with string like `" " + BucketLayout.FILE_SYSTEM_OPTIMIZED` without using name() function. |
@@ -447,3 +447,18 @@ class TestCliOverride:
"test_package/conanfile.py": GenConanfile().with_test("pass")})
client.run("create . pkg/0.1@ --require-override=zlib/2.0")
assert "zlib/2.0: Already installed" in client.out
+
+
+def test_install_bintray_warning():
+ """
+ IMPORT... | [test_install_argument_order->[run,save,GenConanfile,dedent],test_install_error_never->[run,save,GenConanfile],test_install_skip_disabled_remote->[TestClient,GenConanfile,run,OrderedDict,save,TestServer],test_install_without_ref->[format,run,join,GenConanfile,save],test_install_reference_error->[run],test_install_broke... | Test create CLI override. | I tried to avoid using the real bintray remote with a test server using the same URL. However, this lead to modifications to the TestServer class and others in the requester... Anyway, I think it could be useful to have a test that tracks the availability of the remote so we can drop the message once it is no longer av... |
@@ -1552,10 +1552,10 @@ export class AmpStory extends AMP.BaseElement {
maskEl.addEventListener('click', () => {
const actions = Services.actionServiceForDoc(this.element);
if (this.sidebar_) {
+ this.closeOpacityMask_();
actions.execute(this.sidebar_, 'close', /* args */ nu... | [AmpStory->[onBookendStateUpdate_->[BOOKEND_ACTIVE],getHistoryState_->[getState],isBrowserSupported->[Boolean,CSS],isStandalone_->[STANDALONE],onUIStateUpdate_->[DESKTOP_PANELS,MOBILE,DESKTOP_FULLBLEED],closeOpacityMask_->[dev,toggle],updateBackground_->[url,computedStyle,color],layoutCallback->[resolve,isBrowserSuppor... | Open opacity mask. | The side effects of `openOpacityMask_` and `closeOpacityMask_` are asynchronous, since they are wrapped in a `mutateElement`, so changing the order of these calls shouldn't really have an effect. If you need to guarantee that the `actions.execute` line will happen after the opacity mask has opened, you will need to ret... |
@@ -504,8 +504,8 @@ export class AmpForm {
this.cleanupRenderedTemplate_();
this.setState_(FormState_.SUBMIT_ERROR);
this.renderTemplate_(responseJson || {});
- this.maybeHandleRedirect_(error.response);
- user().error(TAG, `Form submission failed: ${error}`);
+ this.maybeHandleRedir... | [No CFG could be retrieved] | Handles the submission of a variable type in the form. Checks if the form is valid and if so triggers the form submission. | Is there any way to print the error here, or something helpful to describe how the request failed? |
@@ -20,6 +20,10 @@ namespace System.Text
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public readonly struct Rune : IComparable<Rune>, IEquatable<Rune>
{
+ private const char HIGH_SURROGATE_START = '\ud800';
+ private const char LOW_SURROGATE_START = '\udc00';
+ private const int HIGH_S... | [Rune->[TryGetRuneAt->[ReadRuneFromString],IsLetterOrDigit->[IsCategoryLetterOrDecimalDigit],GetNumericValue->[GetNumericValue],IsValid->[IsValid],IsNumber->[IsCategoryNumber],TryCreate->[TryCreate],IsPunctuation->[IsCategoryPunctuation],IsLetter->[IsCategoryLetter],Equals->[Equals],IsSeparator->[IsCategorySeparator],I... | Flags for the given Unicode scalar value. - - - - - - - - - - - - - - - - - -. | Can we use PascalCase for such consts? |
@@ -151,6 +151,7 @@ class Dealii(CMakePackage, CudaPackage):
depends_on('slepc@:3.6.3', when='@:8.4.1+slepc+petsc+mpi')
depends_on('slepc~arpack', when='+slepc+petsc+mpi+int64')
depends_on('sundials@:3~pthread', when='@9.0:+sundials')
+ depends_on('trilinos gotype=int', when='+trilinos')
... | [Dealii->[setup_run_environment->[set],cmake_args->[,upper,satisfies,append,spec,joined,extend,len,format,join,InstallError],depends_on,conflicts,format,version,patch,variant]] | This function is used to add dependencies to the header of a sequence number. requires + when + nil + to be built on + threads +. | i don't think Spack can combine `depends_on`, you should probably add this to each `depends_on` below |
@@ -337,12 +337,12 @@ func (t *prometheusTargets) Expect(l labels, health, scrapeURLPattern string) er
type labels map[string]string
-func (l labels) With(name, value string) labels {
+func (l labels) With(name, Value string) labels {
n := make(labels)
for k, v := range l {
n[k] = v
}
- n[name] = value
+ ... | [Expect->[MustCompile,Errorf,MatchString],By,CoreV1,SetupProject,Expect,HaveOccurred,AdminOperatorClient,NewCLIWithoutNamespace,Delete,InOpenShiftSDNContext,It,HasPrefix,TextToMetricFamilies,Itoa,NewBufferString,Secrets,SingleObject,GetName,GetValue,AdminKubeClient,Errorf,Namespace,Watch,Services,Logf,UntilWithoutRetry... | With returns a new labels with the given name and value. | why is this `Value` change needed? |
@@ -126,7 +126,7 @@ class PackageFinder(object):
for version in req.absolute_versions:
if url_name is not None and main_index_url is not None:
locations = [
- posixpath.join(main_index_url.url, version)] + locations
+ posixpath.join(main_index... | [PackageFinder->[find_requirement->[_sort_locations,mkurl_pypi_url],_sort_locations->[sort_path],_package_versions->[_sort_links]],get_requirement_from_url->[Link,splitext],HTMLPage->[get_page->[is_archive,add_page_failure,get_page,set_is_archive,add_page,too_many_failures]],Link->[splitext->[splitext]]] | Find a requirement in the index. Returns a list of version numbers that can be used to install the given distribution. Returns a if the current installed version satisfies the requirement. | just change to: `posixpath.join(main_index_url.url, version) + "/"` @agronholm or @iElectric you want to handle this in a new pull? these are less concerning though, because often these are 404's anyway. If I don't get a response, I'll just close for now, since part of this was already handled in pull #695. |
@@ -6,6 +6,7 @@ from __future__ import (absolute_import, division, generators, nested_scopes, pr
unicode_literals, with_statement)
import threading
+from builtins import object, str
from six import StringIO
| [FileBackedRWBuf->[do_write->[write],__init__->[__init__]],InMemoryRWBuf->[do_write->[write]],_RWBuf->[read_from->[read],read->[read],close->[close],flush->[flush]]] | Creates a class which implements the read - write buffer and write methods of a single object. Writes a sequence of bytes to the end of the file. | @benjyw can you look over this file please? This override means that in line 39, during call to `_RWBuf.write()`, it will call `_RWBuf.do_write()` with `unicode`, rather than `bytes`, which might be a problem. However, `do_write()` simply raises `NotImplementedError`, so I don't know if this actually matters? |
@@ -109,13 +109,12 @@ func (c *defaultControl) deleteShoot(o *operation.Operation) *gardenv1beta1.Last
deploySecrets = f.AddTaskConditional(botanist.DeploySecrets, 0, cleanupShootResources)
refreshMachineClassSecrets = f.AddTaskConditional(hybridBotanist.RefreshMachineClassSecrets, defaultRetry... | [updateShootStatusDeleteStart->[Now,UpdateShootStatus],updateShootStatusDeleteError->[Error,Now,TimeElapsed,UpdateShootLabels,UpdateShootStatus],deleteShoot->[SetLogger,Infof,Execute,AddSyncPoint,Sprintf,New,AddTask,AddTaskConditional,ListPods,IsNotFound,SetProgressReporter,Info,GetNamespace],updateShootStatusDeleteSuc... | deleteShoot deletes a Shoot resource This function is used to create a HybridBotanist object and check whether the resource Adds tasks to the botanist which will be run when all resources are deleted. This function creates tasks that will delete all resources that are not in the shoot. | Won't we still require all above 3 steps? `kube-controller-manager` still requires the updated cloudprovider to cleanup volume related stuff. We'll also have to wait till kubeapiserver is ready . |
@@ -65,7 +65,7 @@ module.exports.mixin = parent =>
* @param {any} config - config to load config from
* @param {any} into - destination context to use default is context
*/
- loadJavaConfig(config = this.jhipsterConfig, into = this) {
+ loadJavaConfig(into = this, config = this.jhipsterConfig) {... | [No CFG could be retrieved] | Create a class that extends the base class of the given object. Load the java constants for a given context. | `config =defaults({}, this.jhipsterConfig, defaultConfig)`? |
@@ -1153,7 +1153,9 @@ class Seq(ContainerProperty):
def from_json(self, json, models=None):
if json is None:
return None
- elif isinstance(json, list):
+ elif isinstance(json, bokeh_seq_types):
+ if isinstance(self.item_type, Any):
+ return json
... | [RelativeDelta->[__init__->[Enum]],Property->[serializable_value->[__get__],set_from_json->[__set__]],UnitsSpecProperty->[__set__->[_extract_units],_extract_units->[__set__],set_from_json->[_extract_units]],Either->[from_json->[from_json,DeserializationError],validate->[is_valid],_sphinx_type->[_sphinx_type],transform-... | Deserialize a from a JSON string. | I'm confused about what's happening here; I haven't read the whole PR yet as I'm reading this, but here are the questions I have looking at these lines: * how does json have a numpy array in it now when we didn't used to handle that (shouldn't json be plain json types?) * Any.from_json is now only called for single Any... |
@@ -176,6 +176,10 @@ public class SCMBlockProtocolServer implements
auditMap.put("owner", owner);
List<AllocatedBlock> blocks = new ArrayList<>(num);
boolean auditSuccess = true;
+ LOG.info("Allocating blocks {} of size {}, with excludeList: " +
+ "datanodes = {}, pipelines = {}, containers = {... | [SCMBlockProtocolServer->[join->[join],stop->[stop],allocateBlock->[allocateBlock],start->[start,getBlockRpcAddress],close->[stop]]] | allocate a block of the specified size type factor and owner. | Allocating blocks {} -> Allocating {} blocks might be better in terms of readability. |
@@ -720,6 +720,18 @@ public class TxInterceptor<K, V> extends DDAsyncInterceptor implements JmxStatis
this.rCtx = rCtx;
}
+ @Override
+ public Publisher<K> localPublisher(IntSet segments) {
+ // TODO: need to implement this before these methods can be made non experimental
+ ... | [TxInterceptor->[visitReadOnlyKeyCommand->[enlistIfNeeded],TxEntryCacheSet->[contains->[getKey,contains],spliterator->[spliterator],remove->[remove],innerIterator->[iterator],clear->[clear],iterator->[getKey,remove,innerIterator]],TransactionAwareCloseableIterator->[close->[close],getNextFromIterator->[getKey,fromEntry... | Returns an iterator that can be used to iterate over the cache. | Is that part of this PR or future work to add Tx support? |
@@ -115,7 +115,7 @@ class CI_Config {
* @param bool $use_sections Whether configuration values should be loaded into their own section
* @param bool $fail_gracefully Whether to just return FALSE or display an error message
* @return bool TRUE if the file was loaded correctly or FALSE on failure
- * @throws R... | [CI_Config->[site_url->[item,slash_item],base_url->[slash_item],_uri_string->[item],system_url->[slash_item]]] | Load a configuration file Returns a new instance of the class that will be used to create the class. | It appears that there are two tabs before the description here ... it should be only one. |
@@ -3,9 +3,11 @@
*/
package hudson.model;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+
import java.util.Collection;
-import org.junit.Assert;
import org.junit.Test;
/**
| [AbstractItemTest->[testSearchNameIsName->[StubAbstractItem],testGetDisplayNameOrNull->[StubAbstractItem],testGetDefaultDisplayName->[StubAbstractItem],testSetDisplayName->[StubAbstractItem],testSetDisplayNameOrNull->[StubAbstractItem]]] | Package for testing. This test method sets the displayName of an item. | Or can use a star import. No strong preference. |
@@ -16,6 +16,7 @@ for both MEG and EEG data by averaging all the epochs.
import mne
from mne import io
from mne.datasets import sample
+from matplotlib import pyplot as plt
print(__doc__)
| [average,read_events,plot,dict,print,data_path,read_raw_fif,Epochs,pick_types] | Reads the epochs from a raw FIF file given a list of events. Plot the average epochs. | why do you need this? |
@@ -8069,8 +8069,15 @@ ROM_END
ROM_START( sf2rk )
ROM_REGION( CODE_SIZE, "maincpu", 0 ) /* 68000 code */
- ROM_LOAD16_BYTE( "w6.u222", 0x000000, 0x80000, CRC(49422b6f) SHA1(69fe9147c7ee3f6fa29077df16f4ef1224495be3) )
- ROM_LOAD16_BYTE( "w5.u196", 0x000001, 0x80000, CRC(7e9c8c2f) SHA1(3d34a39... | [No CFG could be retrieved] | 16k for the audio CPU and 64k for the other graphics layers Return a list of all possible capcom roms. Missing logo ROM. | Does someone over at the cheats forum want to make a cheat for this? |
@@ -159,7 +159,8 @@ describe 'user edits their account', email: true do
"<strong>#{user.reload.unconfirmed_mobile}</strong>."
)
expect(flash[:notice]).to eq t('devise.registrations.mobile_update_needs_confirmation')
- expect(user.reload.mobile).to be_nil
+
+ expect(user.reload.mobil... | [sign_in_as_a_valid_user->[email,post_via_redirect,password,patch_via_redirect,otp_code],email,password,create,let,to_not,describe,instance_double,first,it,mobile,to,unconfirmed_mobile,merge!,before,with,t,require,it_behaves_like,include,receive,shared_examples,patch_via_redirect,otp_code,match,id,get_via_redirect,post... | patch via redirect user changes both email and mobile to existing email and mobile. | I think we want to keep these expectations (several of them have been deleted from this file), but instead of checking that the mobile is nil, we need to check that it hasn't changed. The point of this expectation is to make sure that the mobile doesn't change until the new one is confirmed. |
@@ -475,6 +475,9 @@ if (empty($reshook)) {
$object->status = GETPOST('statut', 'int');
$object->status_buy = GETPOST('statut_buy', 'int');
$object->status_batch = GETPOST('status_batch', 'aZ09');
+ if ($object->status_batch !== 0) {
+ $object->batch_mask = GETPOST('batc... | [fetch,create,getLibFinished,getLabelOfUnit,liste_array,formconfirm,select_country,fetch_object,cloneCategories,addline,check,isService,check_barcode,select_all_categories,defineBuyPrice,getNextValue,select_account,isProduct,setValueFrom,getNomUrl,clone_associations,rollback,showCategories,editfieldval,setCategories,be... | Creates an object from the GET parameters Get the properties of the n - th element from the GETPOST. | Same. Just use = with no condition. Condition should appears when we will need to know if we must use or not batch_mask. |
@@ -155,9 +155,13 @@ class Rewrite
*/
public static function readableOUI($mac)
{
- $key = 'OUIDB-' . (substr($mac, 0, 6));
+ $cached = Cache::get('OUIDB-' . (substr($mac, 0, 6)), '');
+ if ($cached == 'IEEE Registration Authority') {
+ // Then we may have a shorter prefix... | [No CFG could be retrieved] | Returns the OUI name for a given MAC address. | This indicates to me that the cache key is wrong. |
@@ -267,12 +267,12 @@ public class DataSourceUtils {
}
public static JavaRDD<WriteStatus> doDeleteOperation(HoodieWriteClient client, JavaRDD<HoodieKey> hoodieKeys,
- String instantTime) {
+ String instantTime) {
return client.delete(hoodieKeys, in... | [DataSourceUtils->[createHoodieRecord->[createPayload],buildHiveSyncConfig->[checkRequiredProperties],dropDuplicates->[dropDuplicates],getTablePath->[getTablePath],createHoodieClient->[createHoodieClient],doWriteOperation->[createUserDefinedBulkInsertPartitioner]]] | This method is used to perform a delete operation on the Hoodie data source. | another general rule of thumb. we could always review our own diffs again before submitting to make sure whitespace changes are all intentional. cc @nsivabalan . |
@@ -1079,7 +1079,7 @@ export class VideoEventTracker extends EventTracker {
const isVisibleType = (type === VideoAnalyticsEvents.SESSION_VISIBLE);
const normalizedType =
isVisibleType ? VideoAnalyticsEvents.SESSION : type;
- const details = /** @type {!VideoAnalyticsDetailsDef} */ (getData... | [No CFG could be retrieved] | Adds an event listener to the video. Determines visibility events. | @aghassemi i assume `details` cannot be a `string` type here |
@@ -42,12 +42,12 @@ graphURL=https://graph.windows.net/
self.base_url = base_url
temp_auth_file = tempfile.NamedTemporaryFile(delete=False)
- temp_auth_file.write(configuration)
+ temp_auth_file.write(json.dumps(configuration).encode())
temp_auth_file.close()
... | [TestCommon->[test_get_client_from_auth_file->[get_client_from_auth_file,NamedTemporaryFile,write,assertTupleEqual,unlink,close,assertEquals]],main] | This test creates a client from an auth file. - 01aa - 8345 - 7803287dbd39 - password. | Did you mean to not specify an encoding? |
@@ -98,6 +98,8 @@ public class ElasticSearchIndexingImpl implements ElasticSearchIndexing {
private JsonESDocumentWriter jsonESDocumentWriter;
+ protected final JsonFactory jsonFactory = new JsonFactory();
+
public ElasticSearchIndexingImpl(ElasticSearchAdminImpl esa) {
this.esa = esa;
... | [ElasticSearchIndexingImpl->[refreshIfNeeded->[refreshIfNeeded],indexNonRecursive->[refreshIfNeeded,indexNonRecursive]]] | Implementation of the ElasticSearchIndexing interface. This method is called by the IndexManager to perform the actual indexing of the repository. | Should be `static` (and therefore with uppercase field name). |
@@ -28,14 +28,17 @@ import org.mule.runtime.extension.api.annotation.param.Optional;
* @since 4.0
*/
@Alias("imaps")
+@DisplayName("IMAPS Connection")
public class IMAPSProvider extends AbstractRetrieverProvider<RetrieverConnection> implements Initialisable
{
/**
- * The port number of the mail server... | [IMAPSProvider->[initialise->[initialiseIfNeeded],connect->[getPassword,getUser,getConnectionTimeout,getProperties,getWriteTimeout,getReadTimeout,RetrieverConnection,getHost]]] | Package for importing the IMAPS records. Creates a connection to the server. | TLS Context factory is not a meaningful name for this. From the user point of view this is TLS configuration, he doesn't know or care that we handle it through a factory. |
@@ -22,7 +22,7 @@ from .._helpers import _is_tag, _parse_next_link
from .._models import (
DeleteRepositoryResult,
ContentProperties,
- RegistryArtifactProperties,
+ ArtifactManifestProperties,
RepositoryProperties,
ArtifactTagProperties,
)
| [ContainerRepositoryClient->[list_registry_artifacts->[get_next->[prepare_request]],delete_tag->[delete_tag],get_registry_artifact_properties->[_get_digest_from_tag],get_tag_properties->[get_tag_properties],list_tags->[get_next->[prepare_request]],get_properties->[get_properties]]] | Creates a new instance of a ContainerRepositoryClient from an ACR endpoint a repository name and Delete a tag. | weird nit: it seems that the convention for naming async client files is more like `_container_repository_client_async.py` from my experience (even though the user won't see this). Is there a reason you did `_async_container...`? |
@@ -18,6 +18,7 @@ type Factory struct {
registrar *registrar.Registrar
beatVersion string
pipelineLoaderFactory PipelineLoaderFactory
+ updatePipelines bool
beatDone chan struct{}
}
| [Start->[LoadPipelines,Start,RegisterConnectCallback,pipelineLoaderFactory,Err],Create->[Unpack,GetInputConfigs,Hash,New,Err,GetStates],String->[InfoString],Stop->[Stop]] | Create creates a Factory for a single module. ID returns a new input runner for the given input modules. | Should you directly specify the update-pipeline flag here instead of passing through all instances? It would simplify the code I think. |
@@ -245,4 +245,10 @@ public abstract class BaseQuery<T> implements Query<T>
result = 31 * result + (duration != null ? duration.hashCode() : 0);
return result;
}
+
+ @Override
+ public Query<T> makeNonFinalizedQuery()
+ {
+ return withOverriddenContext(ImmutableMap.<String, Object>of("finalize", fals... | [BaseQuery->[getDuration->[getIntervals],getContextValue->[getContextValue],equals->[equals],parseBoolean->[parseBoolean],getId->[getContextValue],run->[run],hashCode->[hashCode],computeOverridenContext->[getContext],getIntervals->[getIntervals]]] | This method calculates the hashCode of the NestedSegment object. | can we call this withNonFinalizedQuery? |
@@ -8,6 +8,8 @@ import tensor
from tensor import *
import control_flow
from control_flow import *
+import utils
+from utils import *
__all__ = []
__all__ += nn.__all__
| [No CFG could be retrieved] | Get all elements of the n - tuple. | Maybe `device`? `utils` is too general |
@@ -68,7 +68,7 @@ class SnmpResponse
{
$this->errorMessage = '';
// not checking exitCode because I think it may lead to false negatives
- $invalid = preg_match('/(Timeout: No Response from .*|Unknown user name|Authentication failure)/', $this->stderr, $errors)
+ $invalid = preg_mat... | [SnmpResponse->[table->[values],getErrorMessage->[isValid],mapTable->[isValid],valuesByIndex->[values]]] | Checks if the SNMP response is valid or not. | shouldnt we check this first? faster than a large regex |
@@ -105,6 +105,7 @@ public class ModuleFlowProcessingPhase
@Override
public void initialise() throws InitialisationException {
final ErrorTypeRepository errorTypeRepository = muleContext.getErrorTypeRepository();
+ componentLocator = muleContext.getConfigurationComponentLocator();
sourceResponseErr... | [ModuleFlowProcessingPhase->[FlowProcessor->[apply->[emptyEvent]]]] | Initialise the error type matcher. | Have you looked for all other uses of `getConfigurationComponentLocator` to ensure they are not done as part of message processing? |
@@ -153,7 +153,7 @@ class RewriteSemanticConstants(FunctionPass):
@register_pass(mutates_CFG=True, analysis_only=False)
-class DeadBranchPrune(FunctionPass):
+class DeadBranchPrune(FunctionPass, SSACompliantMixin):
_name = "dead_branch_prune"
def __init__(self):
| [InlineClosureLikes->[__init__->[__init__]],CanonicalizeLoopEntry->[__init__->[__init__]],CanonicalizeLoopExit->[__init__->[__init__]],TranslateByteCode->[__init__->[__init__]],ReconstructSSA->[__init__->[__init__]],WithLifting->[__init__->[__init__]],SimplifyCFG->[__init__->[__init__]],InlineInlinables->[__init__->[__... | Initialize the FunctionPass. | Mixin class should go before the base class |
@@ -24,7 +24,7 @@ import {viewerForDoc} from '../../src/viewer';
import {xhrFor} from '../../src/xhr';
import * as sinon from 'sinon';
-describe('impression', () => {
+describe('test-impression', () => {
let sandbox;
let viewer;
| [No CFG could be retrieved] | Imports a single unique identifier from the AMP HTML Authors. This function checks if the user has clicked on an impression. | you can revert this change |
@@ -4,15 +4,14 @@ namespace NServiceBus
using System.Collections.Generic;
using System.Messaging;
using System.Threading.Tasks;
- using NServiceBus.Extensibility;
- using NServiceBus.Logging;
- using NServiceBus.Transports;
+ using Extensibility;
+ using Logging;
+ using Transports;
... | [ReceiveWithNoTransaction->[Task->[ExtractHeaders,FromMilliseconds,QueueName,Error,None,BodyStream,Id,Send,ConfigureAwait,Receive],LogManager]] | Receive a message from the input queue and push it to the error queue. | I thought we discussed the null check is not necessary. At least you tried to convince me about that. If that is still true why was id added here? |
@@ -485,7 +485,7 @@ var formDirectiveFactory = function(isNgForm) {
var controller = ctrls[0];
// if `action` attr is not present on the form, prevent the default action (submission)
- if (!('action' in attr)) {
+ if (!('action' in attr) && attr['method'] !== 'dialog') ... | [No CFG could be retrieved] | The name of the is the name of the form. If no name is specified on destroy event to prevent prevention of the default action. | What happens when the action attr is set and method is set to dialog? |
@@ -460,6 +460,8 @@ def _predict_time_loop(X, estimators, cv, slices, predict_mode,
elif predict_mode == 'cross-validation':
# Predict with the estimator trained on the separate training set.
for k, (train, test) in enumerate(cv):
+ if np.asarray(test).size == 0:
+ ... | [_GeneralizationAcrossTime->[score->[predict],predict->[_DecodingTime,chunk_X],fit->[f],__init__->[_DecodingTime]],_sliding_window->[find_time_idx,_DecodingTime],TimeDecoding->[score->[predict],_prep_times->[_DecodingTime]],_fit_slices->[fit]] | Aux function of GeneralizationAcrossTime Series Run classifiers predictions loop across time samples Predict with the GAT with the given n - time window. t - > t - > t - > t - > t - > t - >. | test should already be an array. Just do `test.size == 0` |
@@ -252,7 +252,7 @@ void RemoteClient::GetNextBlocks (
*/
float camera_fov = (72.0*M_PI/180) * 4./3.;
- if(isBlockInSight(p, camera_pos, camera_dir, camera_fov, 10000*BS) == false)
+ if(isBlockInSight(p, camera_pos, camera_dir, camera_fov, d_blocks_in_sight) == false)
{
continue;
}
| [event->[notifyEvent,UpdatePlayerList],UpdatePlayerList->[getClientIDs]] | This method is called by the remote client to get the next blocks. This function is used to rotate the XZ camera by the Yaw and Zaw of region IBlockQueueInterface implementation This function is called when a block is too close or when a block is too close and This function is called from the main loop of the map. | `const s16 block_in_sight_range = full_d_max * BS * MAP_BLOCKSIZE;` (or similar) at line 177. |
@@ -118,6 +118,7 @@ stc = apply_inverse(left_auditory, inv, pick_ori=None)
_, time_max = stc.get_peak(hemi='lh')
brain_fixed = stc.plot(surface='white', subjects_dir=subjects_dir,
initial_time=time_max, time_unit='s', size=(600, 400))
+mne.viz.set_3d_view(figure=fig, azimuth=180, distance=0.25... | [plot_alignment,Dipole,read_cov,create_3d_figure,make_inverse_operator,set_3d_view,convert_forward_solution,read_forward_solution,evokeds,plot,data_path,len,magnitude,plot_dipole_locations,get_peak,read_evokeds,apply_inverse,read_trans,ones] | Plot the dipole locations of the given group of dipoles. A critical is a critical when the source dipole orientations are strictly constrained. | This change looks unrelated to me, can you check? :-) |
@@ -149,6 +149,10 @@ def _cppstd_clang(clang_version, cppstd):
return "-std=%s" % flag if flag else None
+def _cppstd_android_clang(clang_version, cppstd):
+ return "-std=libc++_shared"
+
+
def _cppstd_gcc(gcc_version, cppstd):
"""https://github.com/Kitware/CMake/blob/master/Modules/Compiler/GNU-CXX.c... | [_cppstd_apple_clang->[Version,get],_gcc_cppstd_default->[Version],_cppstd_visualstudio->[str,Version,get],_cppstd_clang->[Version,get],_clang_cppstd_default->[Version],available_cppstd_versions->[cppstd_flag,append],cppstd_flag->[str,func,get],cppstd_default->[str,_gcc_cppstd_default],_cppstd_gcc->[Version,get],_visua... | Return a list of flags for a specific GCC version. - std = 20. | I do not know what default to take there |
@@ -781,7 +781,6 @@ class order extends base {
// $this->products[$i]['stock_value'] = $stock_values->fields['products_quantity'];
$db->Execute("update " . TABLE_PRODUCTS . " set products_quantity = '" . $stock_left . "' where products_id = '" . zen_get_prid($this->products[$i]['id'])... | [order->[create->[notify,insert_ID,Insert_ID],query->[MoveNext,RecordCount,notify,Execute],cart->[recordCount,Execute,attributes_price_onetime_charges,notify,get_products,get_content_type,attributes_price,get_decimal_places],create_add_products->[update_credit_account,Execute,notify,RecordCount,Insert_ID,display_price,... | Creates the add products array Private function to calculate stock values and stock value for a given product Zebra kategorii do zu Zen_db_perform_transaction do order - products - insert data Select all attributes of a product. | Here, please just remove the bracket. The alternate logic should remain. |
@@ -112,11 +112,11 @@ describe PublicBody, " when indexing requests by body they are to" do
update_xapian_index
# check we get results expected
- xapian_object = ActsAsXapian::Search.new([InfoRequestEvent], "requested_from:tgq", :limit => 100)
+ xapian_object = ActsAsXapian::Search.new([InfoRequestEve... | [all,new,size,describe,public_bodies,match_array,results,tag_string,about_me,where,it,dup,name,map,to,save!,before,info_request_events,with_duplicate_xapian_job_creation,destroy,strip_heredoc,require,user,dirname,short_name,destroy_and_rebuild_xapian_index,title,id,url_name,info_requests,eq,users,info_request,reindex_r... | checks that the URL names that are longer than 64 characters when indexing requests by user they are from. | Line is too long. [111/80] |
@@ -780,10 +780,11 @@ public class CommandSetupHelper {
final boolean add = ipAddr.getState() == IpAddress.State.Releasing ? false : true;
boolean sourceNat = ipAddr.isSourceNat();
- /* enable sourceNAT for the first ip of the public interface */
- if (f... | [CommandSetupHelper->[createApplyVpnCommands->[createApplyVpnUsersCommand],findDefaultDnsIp->[findGatewayIp],createVmDataCommandForVMs->[createVmDataCommand],createDhcpEntryCommandsForVMs->[createDhcpEntryCommand]]] | Create redundant associate ip commands. NetworkRate - Network Rate add - add ip if it is not in the list. | For additional public subnet case, sourceNat should be set to 'true' to add a source nat rule on VR for the first ip in that subnet. This changes will break that. If there is no source nat rule for the additional public subnet the traffic to this subnet from he VMs always go through the default source nat interface. |
@@ -110,6 +110,8 @@ const DEFAULT_CONFIG = jsonLiteral({
'ampdocHostname': 'AMPDOC_HOSTNAME',
'ampdocUrl': 'AMPDOC_URL',
'ampGeo': 'AMP_GEO',
+ 'ampUserLocation': 'AMP_USER_LOCATION',
+ 'ampUserLocationPoll': 'AMP_USER_LOCATION_POLL',
'ampState': 'AMP_STATE',
'ampVersion': 'AMP_VERSION',
... | [No CFG could be retrieved] | Imports a configuration object from the modules. Get all the properties of the object that are not in the global namespace. | Why are these getting added? |
@@ -288,8 +288,10 @@ class LocallyConnectedImplementationModeTest(test.TestCase,
np.random.seed(1)
tf_test_util.random_seed.set_seed(1)
- targets = np.random.randint(0, num_classes, (num_samples,))
-
+ sparse_targets = np.random.randint(0, num_classes, (num_samples,))
+ targets = np.zer... | [copy_model_weights->[copy_lc_weights_2_to_1,copy_lc_weights_2_to_3]] | Test locally connected implementation. Compare outputs after training steps. | Nit: space surround operator => sparse_targets.max() + 1 |
@@ -16,7 +16,7 @@
* limitations under the License.
*/
/**
- * Autogenerated by Thrift Compiler (0.9.2)
+ * Autogenerated by Thrift Compiler (0.9.3)
*
* DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
* @generated
| [RemoteApplicationResult->[findByThriftIdOrThrow->[findByThriftId],writeObject->[write],isSet->[isSetSuccess,isSetMsg],equals->[isSetMsg,equals],write->[write],fieldForId->[findByThriftId],compareTo->[isSetSuccess,isSetMsg,compareTo,equals],hashCode->[hashCode,isSetMsg],getFieldValue->[getMsg,isSuccess],deepCopy->[Remo... | Imports a single object. Method to import a n - tuple from a Java enumeration. | Hi @agoodm :) could you regenerate these `thrift-generated` files with `0.9.2`as the other thrift files did? |
@@ -21,12 +21,16 @@ import io.netty.buffer.ByteBufUtil;
import io.netty.util.AsciiString;
import io.netty.util.CharsetUtil;
+import static io.netty.handler.codec.http.HttpConstants.*;
+import static io.netty.handler.codec.http.HttpObjectEncoder.CRLF_SHORT;
+
final class HttpHeadersEncoder {
+ private static fin... | [HttpHeadersEncoder->[encoderHeader->[ensureWritable,setByte,writerIndex,writeAscii,length],writeAscii->[copy,length,setCharSequence]]] | Encodes the header of a message. | Do we have to account for endianness here or will the buffer implementation take care of that (not at computer atm) |
@@ -1147,13 +1147,14 @@ public class SemiTransactionalHiveMetastore
committer.executeAddTableOperations();
committer.executeAlterTableOperations();
committer.executeAlterPartitionOperations();
- committer.executeAddPartitionOperations();
- committer.executeUp... | [SemiTransactionalHiveMetastore->[dropRole->[dropRole],dropColumn->[dropColumn],generatePageSinkMetadata->[getTable],listTablePrivileges->[listTablePrivileges],finishInsertIntoExistingTable->[getTableStatistics],grantTablePrivileges->[getTableOwner,grantTablePrivileges],getAllViews->[getAllViews],rollbackShared->[getTa... | Commits all actions that are shared by this transaction. This method is called from the committer when a table or partition operation is completed. Up empty staging directories that may or may not be recursively contained. | We shouldn't log the full exception here since we throw it below. But we could do it like ```java log.warn("Rolling back due to metastore commit failure: %s", t.getMessage()); |
@@ -28,7 +28,7 @@ ul#strengthBar {
vertical-align: 2px;
}
-.point:last {
+.point:last-child {
margin: 0 !important;
}
.point {
| [No CFG could be retrieved] | Private functions - Section 12. 2. 2. 4. 4. | please update the same for the sass files as well |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.