patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1001,15 +1001,12 @@ class TestArrayMethods(MemoryLeakMixin, TestCase):
pyfunc = array_sum_axis_kws
cfunc = jit(nopython=True)(pyfunc)
all_dtypes = [np.float64, np.float32, np.int64, np.uint64, np.complex64,
- np.complex128]
- # timedelta test cannot be enabled ... | [_fixed_np_round->[_fixed_np_round,fixup_signed_zero],TestArrayComparisons->[test_identity->[check]],TestArrayMethods->[test_round_array->[check_round_array],test_np_frombuffer_allocated->[check_np_frombuffer_allocated],test_array_copy->[check_layout_dependent_func],test_array_transpose->[check_layout_dependent_func],t... | test sum with axis parameter over a whole range of dtypes. | Perhaps pull out `'timedelta64[M]` as a global and use throughout? |
@@ -2,10 +2,6 @@ class KatexTag < Liquid::Block
PARTIAL = "liquids/katex".freeze
KATEX_EXISTED = "katex_existed".freeze
- def initialize(_tag_name, markup, _parse_context)
- super
- end
-
def render(context)
block = Nokogiri::HTML(super).at("body").text
| [KatexTag->[inline?->[include?],render->[inline?,text,render,message],freeze],register_tag] | Initializes the middleware. | Empty initializers are now detected by Rubocop |
@@ -4125,6 +4125,7 @@ bool Sedp::TypeLookupRequestReader::process_get_types_request(
sedp_.type_lookup_service_->get_type_objects(type_lookup_request.data.getTypes.type_ids,
type_lookup_reply._cxx_return.getType.result.types);
type_lookup_reply._cxx_return.getType.result.complete_to_minimal.length(0);
+ //T... | [No CFG could be retrieved] | This function processes a get types request. Retrieves all dependencies of a type that are requested by the user. | Don't worry about this for the complete-to-minimal TypeIdentifier conversion. This is a part of the second subtask in the design doc that I'm working on. |
@@ -295,7 +295,7 @@ export class ImageViewer {
this.updatePanZoom_();
}).then(() => {
- this.updateSrc_();
+ return this.updateSrc_();
});
}
| [No CFG could be retrieved] | Updates the source box and the sourceset. Private method for setting the src attribute of the image. | super-optional nit: this could be a single line `.then(() => this.updateSrc_());` since the return is implied for single-expression fat-arrow functions. |
@@ -127,7 +127,8 @@ public class CommandTopic {
new QueuedCommand(
record.key(),
record.value(),
- Optional.empty()));
+ Optional.empty(),
+ (int) record.offset()));
}
records = commandConsumer.poll(duration);
... | [CommandTopic->[getEndOffset->[get],send->[getCause,RuntimeException,get,requireNonNull],getCommandTopicConsumerPosition->[position],start->[singleton,assign],close->[close],getRestoreCommands->[singletonList,QueuedCommand,newArrayList,debug,value,poll,seekToBeginning,key,empty,isEmpty,add,count],wakeup->[wakeup],getNe... | Get all restore commands. | Offset is a `long` - we shouldn't be casting it to an `int`. |
@@ -220,15 +220,8 @@ class Gloo(object):
rank, nodes = self._get_rank_nodes(Role.WORKER)
gloo = init(rank, nodes, "WORKER")
self._worker_comm = gloo
- else:
- rank, nodes = self._get_rank_nodes(Role.SERVER)
- gloo = init(rank, nodes, "SERVER")
- ... | [PaddleCloudRoleMaker->[_server_num->[_get_pserver_endpoints],_all_reduce->[all_reduce],_barrier->[barrier],__init__->[Gloo],_all_gather->[all_gather],_generate_role->[_ps_env,_collective_env,_gloo_init],_gloo_init->[_server_num,init,_server_index,_is_server,_worker_num,_is_first_worker,_role_id]],UserDefinedRoleMaker-... | Initialize HTTP server. Get the rank and nodes of the object. | should request @seiriosPlus for review. |
@@ -1,5 +1,6 @@
from __future__ import absolute_import
+import pip
from pip.wheel import WheelCache
from pip.req import InstallRequirement, RequirementSet, parse_requirements
from pip.basecommand import Command
| [UninstallCommand->[__init__->[add_option,insert_option_group,super],run->[WheelCache,InstallationError,dict,uninstall,RequirementSet,parse_requirements,add_requirement,from_line,_build_session]]] | Command line interface for uninstalling a single package. Adds all requirements specified in the command line options to the requirements set. | This should import like `from pip.index import FormatControl` or `import pip.index`. |
@@ -74,13 +74,13 @@ func Deliver(t *models.HookTask) error {
}
req.Header.Add("X-Gitea-Delivery", t.UUID)
- req.Header.Add("X-Gitea-Event", string(t.EventType))
+ req.Header.Add("X-Gitea-Event", t.EventType.Event())
req.Header.Add("X-Gitea-Signature", t.Signature)
req.Header.Add("X-Gogs-Delivery", t.UUID)
- r... | [NewRequest,Now,Duration,DialTimeout,Close,SetDeadline,Compile,Encode,Info,Set,Add,Done,FindUndeliveredHookTasks,Error,ProxyFromEnvironment,Errorf,Trace,UpdateHookTask,UpdateWebhookLastStatus,Match,Join,UnixNano,Do,Remove,Int64,GetWebhookByID,RunWithShutdownContext,Queue,Query,GetManager,FindRepoUndeliveredHookTasks,Ne... | This function returns a models. HookRequest object. Header - creates a response object from a hook task. | Should event types be downgraded for this header (and Gogs')? |
@@ -33,6 +33,9 @@ class CheckoutQueries(graphene.ObjectType):
Checkout,
description="Look up a checkout by token.",
token=graphene.Argument(UUID, description="The checkout's token."),
+ channel=graphene.Argument(
+ graphene.String, description="The checkout's channel slug."
... | [CheckoutQueries->[resolve_checkout->[resolve_checkout],resolve_checkout_lines->[resolve_checkout_lines],resolve_checkouts->[resolve_checkouts]]] | This is a class decorator for the base class. It is used to create a connection field Fields for all the Nagios related fields. | Instead of adding argument manual please use `FieldWithChannel` field. |
@@ -343,10 +343,8 @@ module Dependabot
requirements = dependency.requirements
sources = requirements.map { |r| r.fetch(:source) }.uniq.compact
return false if sources.empty?
- raise "Multiple sources! #{sources.join(', ')}" if sources.count > 1
- source_type = source... | [Base->[ChangelogFinder->[default_bitbucket_branch->[fetch_default_branch,repo],new_version->[gsub,git_source?,version],fetch_github_file_list->[repo,compact,type,is_a?,include?,each,directory,contents,name],changelog_text->[end_with?,include?,pruned_text,message,convert],github_client->[for_github_dot_com],bitbucket_c... | Checks if a given is a git source. | Can we have multiple different source types for the same dependency, e.g. npm |
@@ -139,10 +139,17 @@ class Jetpack_IDC {
)
);
+ wp_register_style(
+ 'jetpack-dops-style',
+ plugins_url( '_inc/build/admin.dops-style.css', JETPACK__PLUGIN_FILE ),
+ array(),
+ JETPACK__VERSION
+ );
+
wp_enqueue_style(
'jetpack-idc-css',
plugins_url( 'css/jetpack-idc.css', JETPACK__PLUGI... | [Jetpack_IDC->[enqueue_idc_notice_files->[should_show_idc_notice],display_idc_notice->[should_show_idc_notice]]] | Enqueue Jetpack - IDC - notice files. | @dereksmart Is this OK to do? I specifically just want the `.dops-button` style, which seems to be buried in a node module. Is there a better way to get that out? |
@@ -25,11 +25,13 @@ type Deployment struct {
// Resource is a serializable vertex within a LumiGL graph, specifically for resource snapshots.
type Resource struct {
+ External bool `json:"external"` // true if managed external to Pulumi.
ID resource.ID `json:"id"` ... | [MarshalJSON->[Keys,Must],Iter->[Keys,Must],UnmarshalJSON->[Add,Has],SetOrAdd->[Set,Add]] | Serialize a single type token in a LumiGL graph. Create a Deployment object for the given resource. | Do these concepts of `Inputs`, `Outputs` and `Defaults` make sense for Components? Those seem closely aligned with the CRUD model. Will be curious to see how these end up getting used for higher-level components. |
@@ -141,7 +141,6 @@ const WalletsImport = () => {
<BlueDoneAndDismissKeyboardInputAccessory
onClearTapped={() => {
setImportText('');
- Keyboard.dismiss();
}}
onPasteTapped={text => {
setImportText(text);
| [No CFG could be retrieved] | Displays a UI element that displays the given hidden input and non - hidden input for the given. | is this intentional? i liked how it worked before |
@@ -38,14 +38,14 @@ import timber.log.Timber;
public class CreateDeckDialog {
- private final EditText mDialogEditText;
- private final MaterialDialog.Builder mBuilder;
private final Context mContext;
private final int mTitle;
private final Long mParentId;
private String mPreviousDeckName... | [CreateDeckDialog->[createDeck->[closeDialog],onPositiveButtonClicked->[createDeck,createSubDeck,createFilteredDeck,getDeckName]]] | Creates a new DeckDialog. This method is called when the user selects a deck. It will show a filter deck dialog. | Are these extra lines added by mistake or some reason to do it? |
@@ -605,13 +605,16 @@ class Database
$param_types = '';
$values = [];
- foreach ($args as $param => $value) {
+ foreach (array_keys($args) as $param) {
if (is_int($args[$param])) {
$param_types .= 'i';
} elseif (is_float($args[$param])) {
$param_types .= 'd';
} els... | [Database->[processlist->[toArray,p],isResult->[numRows],getVariable->[fetchFirst],reconnect->[disconnect,connect],p->[p,reconnect,replaceParameters,anyValueFallback],lastInsertId->[lastInsertId],close->[close],select->[p],lock->[e],selectFirst->[fetch],toArray->[fetch],unlock->[e],update->[e,replace],count->[fetchFirs... | This function is called by the DBA driver when a query is executed. This function is called by the error logging in the function e This method is called when there is no error in the database. This function is called by the constructor of the database object. | Is this conversion needed when there is the casting from line 557? |
@@ -26,7 +26,7 @@ func (s *SimpleSuite) TestNoOrInexistentConfigShouldFail(c *check.C) {
time.Sleep(500 * time.Millisecond)
output := b.Bytes()
- c.Assert(string(output), checker.Contains, "No configuration file found")
+ c.Assert(string(output), checker.Not(checker.Contains), "No configuration file found")
cmd... | [TestInvalidConfigShouldFail->[Kill,Start,Assert,Bytes,Sleep,Command],TestWithWebConfig->[Kill,Start,Assert,Get,Sleep,Command],TestSimpleDefaultConfig->[Kill,Start,Assert,Get,Sleep,Command],TestNoOrInexistentConfigShouldFail->[Sprintf,Kill,Start,Assert,Bytes,Sleep,Command]] | TestNoOrInexistentConfigShouldFail tests that a configuration file is present and that it. | Hum so it should not print `No configuration file found` anymore. Do we still fail ? with another message ? or not ? I feel like "if not", those tests are not needed anymore :angel: |
@@ -139,7 +139,7 @@ func NewAuthServer(
public bool,
requireNoncriticalServers bool,
watchesEnabled bool,
-) (APIServer, error) {
+) (auth_server.APIServer, error) {
authConfig := col.NewEtcdCollection(
env.GetEtcdClient(),
| [SetConfiguration->[LogReq,LogResp],RestoreAuthToken->[LogResp],ModifyMembers->[LogReq,LogResp],GetRobotToken->[LogReq,LogResp],GetOIDCLogin->[LogReq,LogResp],isActive->[getClusterRoleBinding],expiredEnterpriseCheck->[getEnterpriseTokenState],deleteExpiredTokensRoutine->[DeleteExpiredAuthTokens],GetPermissionsForPrinci... | NewAuthServer returns an implementation of the AuthServer interface. returns a list of etcd collections that contain the specified . | I'm assuming we return an interface here because returning a private struct sucks. Could we just make the APIServer type public with all-private members? It's awkward to have `src/server/auth/server` reference `src/server/auth` like this. |
@@ -226,6 +226,8 @@ func (mod *modContext) typeName(t *schema.ObjectType, state, input, args bool) s
}
switch {
+ case input && args && mod.details(t).usedInFunctionOutputVersionInputs:
+ return name + "InputArgs"
case input:
return name + "Args"
case mod.details(t).plainType:
| [genResource->[propertyName,genInputType,isK8sCompatMode,genOutputType,tokenToNamespace,typeString],gen->[genResource,genType,genFunction,getImportsForResource,isTFCompatMode,isK8sCompatMode,genEnums,getImports,genHeader,details,tokenToNamespace,add,genConfig,genUtilities],genType->[genInputType,details,typeName,genOut... | typeName returns the name of the type that should be used for the given object type. | This approach to resolving the conflicting name LGTM. |
@@ -52,6 +52,8 @@ class WebhookEventType:
PAYMENT_CONFIRM = "payment_confirm"
PAYMENT_PROCESS = "payment_process"
+ SHIPPING_LIST_METHODS = "shipping_list_methods"
+
TRANSLATION_CREATED = "translation_created"
TRANSLATION_UPDATED = "translation_updated"
| [No CFG could be retrieved] | The following methods are defined in the order module. Get a list of all the events that occur in the product variant. | As we should also have a webhook for the order shipping method, I would suggest renaming this webhook to `SHIPPING_LIST_METHODS_FOR_CHECKOUT` and `SHIPPING_LIST_METHODS_FOR_ORDER`. We want to have a possibility to integrate shipping providers only for checkout or only for order OR for both. In current way we will have ... |
@@ -44,6 +44,17 @@ func main() {
reboot()
}()
+ src, err := extraconfig.GuestInfoSourceWithPrefix("init")
+ if err != nil {
+ log.Error(err)
+ return
+ }
+
+ extraconfig.Decode(src, &config)
+
+ debugLevel = config.Diagnostics.DebugLevel
+ setLogLevels()
+
logFile, err := os.OpenFile("/dev/ttyS1", os.O_WRONL... | [LinkByName,DefaultIP,LinkByAlias,Fd,Warnf,Info,Stack,IsNotExist,Error,New,Start,Errorf,HasSuffix,Infof,GuestInfoSourceWithPrefix,Register,NewToolbox,AddrList,Sync,Reboot,GuestInfoSinkWithPrefix,String,SetLevel,OpenFile,WriteString,Dup3] | requires that the license is installed and available on the system - debug option. | Is it an error that we don't care? Should not it be a warning? |
@@ -188,6 +188,11 @@ public class FlowConfigResourceLocalHandler implements FlowConfigsResourceHandle
return updateFlowConfig(flowId, flowConfig, true);
}
+ @Override
+ public UpdateResponse partialUpdateFlowConfig(FlowId flowId, PatchRequest<FlowConfig> flowConfigPatch) throws FlowConfigLoggedException {
+... | [FlowConfigResourceLocalHandler->[updateFlowConfig->[updateFlowConfig,getFlowConfig],createFlowConfig->[createFlowConfig],deleteFlowConfig->[deleteFlowConfig]]] | Update the flow configuration. | shouldn't partial update be supported in localhandler and not in gobblinhandler? |
@@ -1730,9 +1730,10 @@ MSG_PROCESS_RETURN tls_process_server_certificate(SSL *s, PACKET *pkt)
}
if (!tls_collect_extensions(s, &extensions,
SSL_EXT_TLS1_3_CERTIFICATE, &rawexts,
- &al, NULL)
+ ... | [No CFG could be retrieved] | Reads the next certificate from the input stream. This function is called by the server side to set the * flag in order to. | PACKET_remainin()'s result is not a boolean, so this check should probably be " == 0" It's also a little bit of spooky-action-at-a-distance that could break if someone adds code touching pkg between where &extensions is populated and here, but I think I can live with it. |
@@ -136,7 +136,8 @@ class MyModule < ApplicationRecord
MyModule.transaction do
archived = super
# Unassociate all samples from module.
- archived = SampleMyModule.where(my_module: self).destroy_all if archived
+ # Below line commented, (sci 2228, testing)
+ # archived = SampleMyModule.... | [MyModule->[unassigned_samples->[not],is_one_day_prior?->[is_due_in?,day,current],archive->[x,delete_all,transaction,y,raise,destroy_all,my_module_group],upstream_modules->[my_module_antecessors,empty?,shift,include?,push],uncomplete->[state,completed_on],unassigned_users->[to_s,find_by_sql],protocol->[first,count],sam... | Archive a object. | Just get rid of this statement . |
@@ -181,9 +181,11 @@ public class SegmentMetadataQueryQueryToolChest extends QueryToolChest<SegmentAn
public byte[] computeCacheKey(SegmentMetadataQuery query)
{
byte[] includerBytes = query.getToInclude().getCacheKey();
- return ByteBuffer.allocate(1 + includerBytes.length)
+ byte[... | [SegmentMetadataQueryQueryToolChest->[getCacheStrategy->[getCacheObjectClazz->[getResultTypeReference]]]] | Returns a strategy that caches the SegmentAnalysis objects. | a bit pedantic, but if there were enough analysis types that they could conceivably serialize to a valid column name, it's possible for the caching to get confused for a query with a ListColumnIncluderator. Some kind of separator should help with that. |
@@ -223,6 +223,15 @@ func (c *Container) teardownStorage() error {
}
if err := c.runtime.storageService.DeleteContainer(c.ID()); err != nil {
+ // If the container has already been removed, warn but do not
+ // error - we wanted it gone, it is already gone.
+ // Potentially another tool using containers/storag... | [cleanupNetwork->[save],prepare->[mountStorage],initAndStart->[save,init,removeConmonFiles],init->[save],cleanupStorage->[save],cleanup->[cleanupNetwork,cleanupStorage],removeConmonFiles->[bundlePath],start->[save],mountStorage->[save],generateHosts->[writeStringToRundir],isStopped->[syncContainer],reinit->[save,init,r... | teardownStorage removes all storage from the container and removes the container s root filesystem. | Shouldn't this just be a Warnf? |
@@ -511,12 +511,12 @@ namespace System.Collections.Generic
while (i <= n >> 1)
{
int child = 2 * i;
- if (child < n && (keys[lo + child - 1] == null || keys[lo + child - 1].CompareTo(keys[lo + child]) < 0))
+ if (child < n && (keys[lo + child - 1]... | [No CFG could be retrieved] | The method to sort the keys in the heap. region IndexSortHelper for paired key and value arrays. | Note that I tweaked the comparison here to match what was being done in native. |
@@ -38,7 +38,10 @@ def build_single_handler_application(path):
if os.path.isdir(path):
handler = DirectoryHandler(filename=path)
else:
- handler = ScriptHandler(filename=path)
+ if path.endswith(".ipynb"):
+ handler = NotebookHandler(filename=path)
+ else:
+ ... | [build_single_handler_applications->[build_single_handler_application]] | Build a Bokeh application using a single handler for a file or directory. | might be good to insist the script ends in ".py" |
@@ -179,6 +179,11 @@ def to_pil_image(pic, mode=None):
if pic.ndimension() not in {2, 3}:
raise ValueError('pic should be 2/3 dimensional. Got {} dimensions.'.format(pic.ndimension()))
+ elif pic.ndimension() == 3:
+ # check number of channels
+ if pic.shape[0] > 4:
... | [resized_crop->[resize,crop],adjust_brightness->[adjust_brightness],vflip->[vflip],five_crop->[_get_image_size,center_crop,crop],pad->[pad],_get_image_num_channels->[_get_image_num_channels],rgb_to_grayscale->[to_grayscale,rgb_to_grayscale],crop->[crop],convert_image_dtype->[convert_image_dtype],adjust_gamma->[adjust_g... | Convert a torch. Tensor or np. ndarray to PIL Image. - The base Reads a sequence of images from a 1D array. | Below we use unsqueeze to make pic as 3d tensor, so let's check and raise exception after the unsqueeze (which is not that expensive). Please, use also `pic.shape[-3]` instead of `pic.shape[0]` and no need to check `elif pic.ndimension() == 3`. |
@@ -35,14 +35,11 @@ class AzureCliCredential(object):
"""Authenticates by requesting a token from the Azure CLI.
This requires previously logging in to Azure via "az login", and will use the CLI's currently logged in identity.
-
- :keyword bool allow_multitenant_authentication: when True, enables the cre... | [_run_command->[sanitize_output,get_safe_working_dir]] | Initialize a class attribute. | Suggest centralizing this in `resolve_tenant` instead |
@@ -781,8 +781,11 @@ define([
var hasNormals = content._hasNormals;
var hasBatchIds = content._hasBatchIds;
var backFaceCulling = content._backFaceCulling;
+ var normalShading = content._normalShading;
var vertexArray = content._drawCommand.vertexArray;
+ var normalsE... | [No CFG could be retrieved] | Creates a Cesium3DTileBatchTable object from the given attributes. Flags that indicate whether the image is encoded 16 - bit RGB or RGBA. | I actually think this boolean may not be the right approach. We still want `backFaceCulling` to work even if `normalShading` is false. |
@@ -87,9 +87,8 @@ public class UaaConfiguration extends AuthorizationServerConfigurerAdapter {
*/
clients.inMemory()
.withClient("web_app")
- .scopes("web-app")
+ .scopes("openid")
.autoApprove(true)
- .accessTokenValiditySeconds((int) jHipst... | [No CFG could be retrieved] | Configure the application. TokenStore bean. | this change will currently make the client app fail to communicate with the server. In angular client there is a "hack" line, where the Basic Auth header is set incode, rather then using Base64. This is done because I initally wanted to avoid base64 encoding on client side. But as the basic auth header is done once for... |
@@ -28,7 +28,6 @@ const OSSL_DISPATCH ossl_##nm##kbits##sub##_functions[] = { \
{ 0, NULL } \
};
#else
-# include "prov/providercommonerr.h"
/* TODO(3.0) Figure out what flags are required */
# define AES_CBC_HMAC_SHA_FLAGS (EV... | [No CFG could be retrieved] | Creates a new OSSL_CBC_HMAC_SHA cipher. - - - - - - - - - - - - - - - - - -. | Is this needed still? |
@@ -194,11 +194,12 @@ class CategoryController extends RestController implements ClassResourceInterfac
*/
public function postAction(Request $request)
{
- return $this->saveEntity($request, null);
+ return $this->saveCategory($request);
}
/**
- * Changes an existing categor... | [CategoryController->[addParentSelector->[getManager],getCategoryListRepresentation->[getRestHelper]]] | POST action for a entity. | It doesn't really replace the category, it updates it, doesn't it? |
@@ -20,10 +20,15 @@ class AsyncBearerTokenCredentialPolicy(_BearerTokenCredentialPolicyBase, SansIOH
"""
def __init__(self, credential, *scopes, **kwargs):
+ try:
+ import asyncio
+ except ImportError:
+ raise ImportError("Please make sure asyncio library are installed")
... | [AsyncBearerTokenCredentialPolicy->[on_request->[get_token,_update_headers,_enforce_https],__init__->[super,Lock]]] | Initializes the object. | asyncio is part of the standard library, we shouldn't need this try/catch |
@@ -51,6 +51,8 @@ def json2space(in_x, name=NodeType.ROOT):
_value = json2space(in_x[NodeType.VALUE], name=name)
if _type == 'choice':
out_y = eval('hp.hp.choice')(name, _value)
+ elif _type == 'randint':
+ out_y = hp.hp.uniform(name, *_value)
... | [json2vals->[json2vals],HyperoptTuner->[get_suggestion->[receive_trial_result,json2parameter],import_data->[_add_index,receive_trial_result],receive_trial_result->[json2vals],update_search_space->[_choose_tuner,json2space]],_add_index->[_add_index],json2space->[json2space],json2parameter->[json2parameter]] | Change json to search space in hyperopt. | this is not correct. |
@@ -183,7 +183,7 @@ class WPCOM_JSON_API_Site_Settings_Endpoint extends WPCOM_JSON_API_Endpoint {
// $this->input() retrieves posted arguments whitelisted and casted to the $request_format
// specs that get passed in when this class is instantiated
- $input = $this->input();
+ $input = apply_filters( 'rest_ap... | [WPCOM_JSON_API_Site_Settings_Endpoint->[update_settings->[jetpack_relatedposts_supported],get_settings_response->[jetpack_relatedposts_supported]]] | Updates related posts settings Updates related posts settings This function is used to set the value of a option in the Jetpack library. This function will check if the user has the necessary options to report the label and show if. | Would it be possible to add a docblock before that filter? |
@@ -176,7 +176,7 @@ public final class Http2Settings extends IntObjectHashMap<Long> {
return this;
}
- Integer getIntValue(int key) {
+ public Integer getIntValue(int key) {
Long value = get(key);
if (value == null) {
return null;
| [Http2Settings->[pushEnabled->[put],keyToString->[keyToString],maxFrameSize->[put],maxHeaderListSize->[put],initialWindowSize->[put],headerTableSize->[put],put->[put],maxConcurrentStreams->[put]]] | Copy settings from another settings. | @nmittler why you changed this to public ? Was this by mistake ? |
@@ -54,9 +54,12 @@ public class NetworkOfferingJoinDaoImpl extends GenericDaoBase<NetworkOfferingJo
}
@Override
- public List<NetworkOfferingJoinVO> findByZoneId(long zoneId) {
+ public List<NetworkOfferingJoinVO> findByZoneId(long zoneId, Boolean includeAllZoneOffering) {
SearchBuilder<Netwo... | [NetworkOfferingJoinDaoImpl->[findByDomainId->[createSearchBuilder,create,done,setParameters,getDomainId,listBy,and,valueOf],newNetworkOfferingView->[create,size,get,setParameters,searchIncludingRemoved,getId],findByZoneId->[createSearchBuilder,getZoneId,create,done,setParameters,listBy,and,valueOf],newNetworkOfferingR... | Find all network offering joins in a zone. | the idea is zId in set or null? |
@@ -37,9 +37,9 @@ class EpollSocketTestPermutation extends SocketTestPermutation {
static final SocketTestPermutation INSTANCE = new EpollSocketTestPermutation();
static final EventLoopGroup EPOLL_BOSS_GROUP =
- new EpollEventLoopGroup(BOSSES, new DefaultThreadFactory("testsuite-epoll-boss", true... | [EpollSocketTestPermutation->[EpollSocketTestPermutation]] | Gets the socket list. | Should create daemon threads. |
@@ -3,11 +3,11 @@ class StudentsController < ApplicationController
before_filter :authorize_only_for_admin
def index
- @students = Student.all(:order => "user_name")
+ @students = Student.all(order: "user_name")
end
def populate
- @students_data = Student.all(:order => "user_name")
+ @stu... | [StudentsController->[upload_student_list->[redirect_to,size,upload_user_list,post?,blank?,t],create->[redirect_to,save,post?,new],edit->[find_by_id],update->[redirect_to,render,user_name,update_attributes,post?,find_by_id],bulk_modify->[hide_students,nil?,empty?,find,give_grace_credits,construct_table_rows,render,unhi... | This method is called when a user does not have a lease. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -59,6 +59,16 @@ namespace System.Text.Json.Serialization.Converters
// ensure the enumerator already is stored
// in the WriteStack for proper disposal.
moveNextTask = enumerator.MoveNextAsync();
+
+ if (!moveNextTask.IsCompleted)
+ {
+... | [IAsyncEnumerableOfTConverter->[Add->[Add],OnTryWrite->[OnTryWrite],OnTryRead->[OnTryRead]]] | Override OnWriteResume to handle the case where the value is being serialized synchronously. if enumerator is empty return false ;. | can we avoid the goto? i.e. add bool flag which causes the loop logic to be skipped? I think saving few instructions of CPU cycle is not worth having goto in the code |
@@ -1104,7 +1104,6 @@ namespace System.Net.WebSockets
Debug.Assert(lockObject != null, "'lockObject' MUST NOT be NULL.");
if (lockTaken)
{
- RuntimeHelpers.PrepareConstrainedRegions();
try
{
}
| [WebSocketBase->[OutstandingOperationHelper->[TryStartOperation->[ThrowIfDisposed],CompleteOperation->[Dispose],Dispose->[Dispose]],StartOnCloseReceived->[ThrowIfDisposed],Abort->[Abort],OnBackgroundTaskException->[Abort],OnKeepAlive->[EnsureKeepAliveOperation,ThrowIfConvertibleException,ReleaseLock,OnBackgroundTaskExc... | Release lock if it is acquired. | Another case where the empty try should be removed. |
@@ -875,7 +875,10 @@ define([
var componentName = interpolated.substring(0,interpolated.indexOf('.'));
return this.initMetricAppidMapping()
.then(function () {
- var storm = allMetrics["nimbus"];
+ var storm = [];
+ if(allMetr... | [No CFG could be retrieved] | This function returns an array of unique appids for all components or topology. Construct a list of entities for an . | We could define a method for all those similar occurrences and just use something like `var storm = getMetrics(allMetrics, "nimbus");` |
@@ -31,9 +31,7 @@ module View
on: { scroll: scroll_handler },
style: {
overflow: 'auto',
- height: '200px',
- width: '100%',
- padding: '0.5rem',
+ padding: '0 0.5rem',
'background-color': color_for(:bg2),
color: color_for(:font2),
... | [Log->[render->[call,h,scrollTop,is_a?,message,map,color_for,store,lambda,name,clientHeight,target,scrollHeight],needs,include]] | Renders a in the chatlog. | this will mess up emails |
@@ -134,6 +134,8 @@ class ResourceHint:
raise ValueError()
suffix = match.group(1)
+ if suffix not in units:
+ raise ValueError()
multiplier = units[suffix]
value = value[:-len(suffix)]
| [ResourceHint->[_parse_storage_size_str->[_parse_int]],parse_resource_hints->[parse,get_by_name],merge_resource_hints->[get_by_urn],resource_hints_from_options->[parse_resource_hints],MinRamHint->[get_merged_value->[_use_max],parse->[_parse_storage_size_str]],register_resource_hint] | Parses a human - friendly storage size string into a number of bytes. | Let's put a more informative message here (e.g. ValueError("Unknown unit: %s" % suffix). Similarly above. Also, do we want suffixes to be case sensitive. E.g. should we be rejecting "4gb"? |
@@ -547,7 +547,9 @@ class GroupIntoBatchesTest(unittest.TestCase):
.advance_watermark_to(start_time +
GroupIntoBatchesTest.NUM_ELEMENTS)
.advance_watermark_to_infinity())
- pipeline = TestPipeline()
+ options = PipelineOptions()
+ ... | [GroupIntoBatchesTest->[test_in_global_window->[_create_test_data]],BatchElementsTest->[test_target_duration->[sleep,FakeClock],test_target_overhead->[sleep,FakeClock],test_ignore_first_n_batch_size->[sleep,FakeClock],test_windowed_batches->[FakeClock],test_variance->[sleep,FakeClock],test_ignore_next_timing->[sleep,Fa... | This test is run in streaming mode. | Here you can just write `pipeline = TestPipeline(options= StandardOptions(streaming=True))` |
@@ -2005,6 +2005,9 @@ export default {
room.on(JitsiConferenceEvents.CONFERENCE_JOINED, () => {
this._onConferenceJoined();
});
+ room.on(JitsiConferenceEvents.CONFERENCE_JOIN_IN_PROGRESS, () => {
+ APP.store.dispatch(conferenceJoinInProgress(room));
+ });
... | [No CFG could be retrieved] | Displays a dialog to mute or unmute a video. muteVideo is a part of the API. | why not directly do `APP.store.dispatch(setPrejoinPageVisibility(false));` here and completely remove this new `conferenceJoinInProgress` action? |
@@ -0,0 +1,15 @@
+// Copyright 2016-2021, Pulumi Corporation
+
+using Pulumi.Automation.Serialization.Json;
+using Pulumi.Automation.Events;
+
+// NOTE: The classes in this file are intended to align with the serialized
+// JSON types defined and versioned in sdk/go/common/apitype/events.go
+namespace Pulumi.Automation... | [No CFG could be retrieved] | No Summary Found. | You don't need this model, you can just deserialize directly to `CancelEvent` if it has a parameterless constructor. These models are only necessary to get around System.Text.Json not supporting deserialization of parameterized constructors at this version |
@@ -46,7 +46,8 @@ import static io.netty.channel.unix.NativeInetAddress.ipv4MappedIpv6Address;
*/
public class Socket extends FileDescriptor {
- public static final int UDS_SUN_PATH_SIZE = udsSunPathSize();
+ @Deprecated
+ public static final int UDS_SUN_PATH_SIZE = 100;
protected final boolean ipv... | [Socket->[sendFd->[sendFd],listen->[listen],setKeepAlive->[setKeepAlive],connect->[connect,useIpv6],getSendBufferSize->[getSendBufferSize],isTcpNoDelay->[isTcpNoDelay],newSocketDgram->[Socket],isInputShutdown->[isInputShutdown],sendTo->[sendTo,useIpv6],recvFrom->[recvFrom],newSocketDomain->[Socket],sendToAddresses->[us... | Creates a socket object that implements the standard Java Socket interface. This method is used to shutdown the object. | This was only used in a test and it is problematic as we may not have registered the methods yet when we try to call this |
@@ -53,6 +53,13 @@ class DecoderState(Generic[T]):
self.action_history = action_history
self.score = score
+ def get_cost(self) -> Variable:
+ """
+ Returns cost associated with a finished ``DecoderState`` if the training algorithm used
+ calls for it.
+ """
+ r... | [TypeVar] | Initialize the state with the given sequence indices action history and score. | I'm not thrilled about adding this to the base class. There are issues with the others options for doing this, too, though. We just need to figure out a better API for this decoder stuff. But for you, you should at least throw a `RuntimeError` here, not a `NotImplementedError`, as not all subclasses will be expected to... |
@@ -92,6 +92,16 @@ class HibernateValidatorProcessor {
private static final DotName REPEATABLE = DotName.createSimple(Repeatable.class.getName());
+ private static final DotName[] JAXRS_METHOD_ANNOTATIONS = {
+ DotName.createSimple("javax.ws.rs.GET"),
+ DotName.createSimple("javax.ws.r... | [HibernateValidatorProcessor->[getClassName->[getClassName],contributeClassMarkedForCascadingValidation->[contributeClass],nativeImageConfig->[build]]] | Returns a build - step missing capability build - step. | I have another patch moving `ResteasyDotNames` to a common SPI so we will be able to use the constants there rather than have a copy. |
@@ -1897,15 +1897,8 @@ function file_tag_save_file($uid, $item, $file)
intval($uid)
);
if (DBM::is_result($r)) {
- if (! stristr($r[0]['file'],'[' . file_tag_encode($file) . ']')) {
- q("UPDATE `item` SET `file` = '%s' WHERE `id` = %d AND `uid` = %d",
- dbesc($r[0]['file'] . '[' . file_tag_encode($file) . ... | [dlogger->[save_timestamp],get_intltext_template->[save_timestamp],get_plink->[remove_baseurl],replace_macros->[save_timestamp,template_engine,getMessage,replaceMacros],text_highlight->[factory,setRenderer,highlight],load_view_file->[save_timestamp],logger->[save_timestamp],get_markup_template->[save_timestamp,template... | Save file tag. | Why did you remove the duplicate check? |
@@ -43,6 +43,9 @@ import games.strategy.engine.framework.ui.SaveGameFileChooser;
public class GameSelectorPanel extends JPanel implements Observer {
private static final long serialVersionUID = -4598107601238030020L;
+
+ private JLabel m_engineVersionLabel;
+ private JLabel m_engineVersionText;
private JLabe... | [GameSelectorPanel->[update->[setWidgetActivation,updateGameData],setupListeners->[actionPerformed->[actionPerformed]],main->[GameSelectorPanel],setWidgetActivation->[run->[setWidgetActivation]],selectGameFile->[setOriginalPropertiesMap,selectGameFile],updateGameData->[run->[updateGameData]],selectGameOptions->[selectG... | Creates a panel that can be used to select a game. This method is called when a new game is added to the game model. | Here we get to where the output labels for the engine number were added. In this class the gridbag constaints was difficult to modify. Once that was cleaned up by identifying the parameters, I modeled the existing structure to add the extra game engine label. |
@@ -852,9 +852,12 @@ class Model(object):
model = paddle.Model(net, input, label)
optim = paddle.optimizer.SGD(learning_rate=1e-3,
parameters=model.parameters())
+
+ amp_configs = {'level': 'O0'}
model.prepare(optim,
paddle.nn.CrossEntrop... | [StaticGraphAdapter->[parameters->[parameters],save->[_save->[to_numpy],_save],_run->[flatten_list,restore_flatten_list,to_list],_make_program->[_all_gather,to_list]],init_communicator->[wait_server_ready],DynamicGraphAdapter->[parameters->[parameters],predict_batch->[_all_gather,_update_input_info,to_numpy,to_list],lo... | A layer that builds a network from a list of InputSpec instances or lits of Input Initialize the object for the given object. | better to add another example for amp |
@@ -27,6 +27,10 @@ def bundler_project_dependency_file(project, filename:)
dependency_file
end
+def bundler_build_tmp_repo(project)
+ build_tmp_repo(project, path: "projects/bundler1")
+end
+
RSpec.configure do |config|
config.around do |example|
if bundler_2_available? && example.metadata[:bundler_v1_o... | [common_dir->[gem_dir],bundler_project_dependency_file->[raise,name,find],bundler_project_dependency_files->[project_dependency_files,join],require_common_spec->[require],skip,metadata,run,bundler_2_available?,around,require,configure] | Find a file in the project s dependency list that matches filename. | This is hard-coded to bundler1, it'll switch based on the suite name in #3350 |
@@ -60,6 +60,15 @@ public class PrepareTemplateCmd extends BaseCmd {
description = "template ID of the template to be prepared in primary storage(s).")
private Long templateId;
+ @ACL(accessType = AccessType.OperateEntry)
+ @Parameter(name = ApiConstants.STORAGE_ID,
+ type = Comm... | [PrepareTemplateCmd->[execute->[setResponseName,getCommandName,setResponses,prepareTemplate,createTemplateResponses,setResponseObject],getLogger,getName]] | Returns the zone id of this node. | better to use poolId or storagePoolId instead of storageId to be consistent |
@@ -155,10 +155,8 @@ namespace System.Text.Json
if (converter is JsonConverterFactory factory)
{
converter = factory.GetConverterInternal(typeToConvert, this);
- if (converter == null || converter.TypeToConvert == null)
- {
- th... | [JsonSerializerOptions->[GetAttributeThatCanHaveMultiple->[GetAttributeThatCanHaveMultiple],HasConverter->[GetConverter]]] | Get a converter for a given type. Returns a converter that can be used to convert the type of the item. | Are you sure it is fine to remove this check? The `GetConverter` method is public and now the caller might null ref if they were relying on this to check and throw to validate their converter implementation. Where is the not supported exception coming from? |
@@ -36,6 +36,8 @@ const SERVING_TYPE_PREFIX = dict({
'a': true,
// Ad
'ad': true,
+ // Actions viewer
+ 'action': true,
});
/**
| [No CFG could be retrieved] | Creates a new object with all the properties of a given n - tag. Matches amp parameters in query string. | Why is this necessary? I don't see any usages of url.js functions in amp-viewer-assistance.js. |
@@ -208,7 +208,7 @@ export default class ScanLndInvoice extends React.Component {
};
async pay() {
- if (!this.state.hasOwnProperty('decoded')) {
+ if ('decoded' in this.state) {
return null;
}
| [No CFG could be retrieved] | The state of the next . fetch invoices from the wallet. | found that `!` is lost here only after merge. will try to find more such cases and fix it in master, don't really want to unmerge |
@@ -98,4 +98,12 @@ public class SpringControllerTest {
RestAssured.when().get("/hello").then()
.body(containsString("hello"));
}
+
+ @Test
+ public void testResponseEntityWithIllegalArgumentException() {
+ RestAssured.when().get("/exception/re").then()
+ .conte... | [SpringControllerTest->[testJsonResultFromResponseEntity->[containsString,body],testExceptionHandlerVoidReturnType->[statusCode],testExceptionHandlerPojoEntityType->[statusCode],testInvalidJsonInputAndResult->[statusCode],testExceptionHandlerWithoutResponseStatusOnExceptionOrMethod->[statusCode],testJsonResult->[contai... | Test if rest controller without request mapping. | Out of curiosity, where does this status code come from? `402` seems pretty unusual, but maybe it's completely normal in that case. |
@@ -2285,7 +2285,9 @@ public abstract class SeekableStreamSupervisor<PartitionIdType, SequenceOffsetTy
}
// clear partitionGroups, so that latest sequences from db is used as start sequences not the stale ones
// if tasks did some successful incremental handoffs
- partitionGroups.get(g... | [SeekableStreamSupervisor->[possiblyRegisterListener->[statusChanged->[RunNotice]],stopTasksInGroup->[stopTask,killTask],buildRunTask->[RunNotice],tryInit->[toString,handle],generateSequenceName->[toString],getTaskLocation->[getTaskId],isHealthy->[isHealthy],addTaskGroupToActivelyReadingTaskGroup->[TaskData,TaskGroup],... | Check if the task duration has passed in. If so signal all tasks in the group to if there are no pending completion tasks in this group kill all tasks in this group and mark. | nit: I see this loop repeated a few times, maybe good to make a method |
@@ -120,10 +120,10 @@
#pragma pack(push, 1) // No padding between variables
-typedef struct { uint16_t X, Y, Z, X2, Y2, Z2, Z3, E0, E1, E2, E3, E4, E5; } tmc_stepper_current_t;
-typedef struct { uint32_t X, Y, Z, X2, Y2, Z2, Z3, E0, E1, E2, E3, E4, E5; } tmc_hybrid_threshold_t;
+typedef struct { uint16_t X, Y, Z, ... | [No CFG could be retrieved] | The main entry point for the M217 generation. The settings data structure for a specific ethernet header. | `EEPROM_VERSION` will need to be bumped with this change. |
@@ -35,7 +35,7 @@ public class LoggerMessageProcessorTestCase extends AbstractMuleTestCase {
@Before
public void before() throws RegistrationException {
- flow = builder("flow", mockContextWithServices()).build();
+ flow = builder("flow", mockContextWithServices()).messageProcessors(emptyList()).build();
... | [LoggerMessageProcessorTestCase->[buildLoggerMessageProcessorForExpressionEvaluation->[buildLoggerMessageProcessorWithLevel],verifyMuleEventByLevel->[verifyLogCall],buildLoggerMessageProcessorWithLevel->[buildMockLogger],verifyNullEventByLevel->[verifyLogCall],verifyLoggerMessageByLevel->[verifyExpressionEvaluation,ver... | Test method to log null events. | `messageProcessors` or `processors`, same with source? Why is emptyList needed? Does builder not use empty list by default? |
@@ -146,6 +146,8 @@ class Critical_CSS extends Module {
if ( $this->should_display_critical_css() ) {
Admin_Bar_Css_Compat::init();
+ add_filter( 'jetpack_boost_async_style', array( $this, 'asynchronize_stylesheets_media' ), 10, 3 );
+
add_action( 'wp_head', array( $this, 'display_critical_css' ), 0 );
... | [Critical_CSS->[display_critical_css->[get_critical_css],is_ready_filter->[get_current_request_css_keys,get_critical_css],critical_css_request_generate_handler->[get_local_critical_css_generation_info],api_get_critical_css_status->[get_critical_css_status],describe_provider_key->[find_provider_for],handle_css_proxy->[c... | Initialize the plugin This method is called by the admin - level functions to add critical CSS constants to the JS. | Is `$this` accessible from outside Jetpack Boost plugin, for example in `theme/functions.php`? |
@@ -712,9 +712,9 @@ module.exports = class bitmart extends Exchange {
// }
//
const timestamp = this.safeTimestamp2 (ticker, 'timestamp', 's_t', this.milliseconds ());
- let marketId = this.safeString2 (ticker, 'symbol', 'contract_id');
- marketId = this.safeString (ticker, ... | [No CFG could be retrieved] | Protected base. Get the base_coin_volume quote_coin_volume and base_volume_24. | In this case, a delimiter would not work for contracts, cause they don't include a delimiter, and in general have a different naming structure for contract ids, so we should remove the 3rd argument (delimiter) from the `safeMarket` call here. We will improve contract id parsing later. |
@@ -273,6 +273,10 @@ return [
// Maximum number of queue items for a single contact before subsequent messages are discarded.
'max_contact_queue' => 500,
+ // max_feed_items (Integer)
+ // Maximum number of feed items that are fetched and processed. For unlimited items set to 0.
+ 'max_feed_items' => 10,
+
... | [No CFG could be retrieved] | Configuration of the local hashtags. Get the host and port of the memcache daemon. | Will this pick up items where it left off the next time the feed is polled of there are more than 10 items? |
@@ -546,7 +546,11 @@ public abstract class VirtualFile implements Comparable<VirtualFile>, Serializab
private boolean isIllegalSymlink() {
try {
- return !this.isDescendant("");
+ String myPath = f.toPath().toRealPath().toString();
+ String rootPath =... | [VirtualFile->[CollectFiles->[collectFiles->[collectFiles,getName,isDirectory,list,isFile]],equals->[toURI,equals],run->[call],compareTo->[getName],hashCode->[hashCode],listOnlyDescendants->[list],Readable->[invoke->[canRead]],toString->[toString],FileVF->[mode->[mode],toURI->[toURI],getName->[getName],length->[length]... | Checks if this file is a illegal symlink. | Do you need to use the relaxed version here, too? |
@@ -200,12 +200,6 @@ func addClusterStateFields(idx *Index, clusterState common.MapStr) error {
return errors.Wrap(err, "failed to get shards from routing table")
}
- created, err := getIndexCreated(indexMetadata)
- if err != nil {
- return errors.Wrap(err, "failed to get index creation time")
- }
- idx.Created... | [Time,GetIndicesSettings,MapStr,GetURI,MakeXPackMonitoringIndexName,ParseInt,New,Now,Unmarshal,MakeErrorForMissingField,GetClusterState,GetValue,Module,Errorf,Event,Wrap,Err,Config] | parseAPIResponse parses the response from the API and adds the necessary fields to the index. Get the value of the metricKey in the given state. | I think we can remove the `Created` field from the struct as well? |
@@ -22,6 +22,8 @@ package org.apache.gobblin.metrics;
*/
public class MetricNames {
+ public static final String NUM_WORKUNITS = "numWorkUnits";
+
/**
* Extractor metrics.
*/
| [No CFG could be retrieved] | Creates a metric that describes the type of a given . Methode d ajout de la cultures. | Should this be grouped into SourceMetrics and have the metric name as "gobblin.source.numWorkUnits.created" to be consistent with other metric names? |
@@ -91,6 +91,17 @@ int RSA_sign(int type, const unsigned char *m, unsigned int m_len,
encoded_len = SSL_SIG_LENGTH;
encoded = m;
} else {
+ const EVP_MD *md = EVP_get_digestbynid(type);
+ if (md == NULL) {
+ RSAerr(RSA_F_RSA_SIGN, RSA_R_UNKNOWN_ALGORITHM_TYPE);
+ ... | [RSA_sign->[rsa_sign,encode_pkcs1,RSA_private_encrypt,RSA_size,OPENSSL_clear_free,RSAerr],int->[OBJ_nid2obj,i2d_X509_SIG,OBJ_length,RSAerr],int_rsa_verify->[RSA_public_decrypt,memcpy,memcmp,encode_pkcs1,EVP_MD_size,RSA_size,OPENSSL_clear_free,OPENSSL_malloc,EVP_get_digestbynid,RSAerr],RSA_verify->[rsa_verify,int_rsa_ve... | Compute the signature of a message. | This is breaking compatibility. If the type does not resolve to an md, the m_len check should be simply skipped. Also please add empty line after declaration. |
@@ -1627,8 +1627,12 @@ namespace Dynamo.Wpf.ViewModels.Watch3D
}
AddLabelPlace(baseId, p.Positions[0], rp);
- pointGeometry3D.Geometry = points;
+ if (pointGeometry3D.Geometry == null)
+ {
+ ... | [HelixWatch3DViewModel->[OnWorkspaceOpening->[containsNaN],SetSelection->[FindAllGeometryModel3DsForNode],OnSceneItemsChanged->[UpdateSceneItems,OnRequestViewRefresh],ClearPathLabel->[OnSceneItemsChanged],OnWorkspaceCleared->[OnWorkspaceCleared],RemoveGeometryForUpdatedPackages->[DeleteGeometryForIdentifier],SaveCamera... | Aggregate render packages into a single render package. Adds points and lines to the object. region HelixRenderPackage Methods if there is no baseId in the mesh. | Do we need to put this line into the if for consistency? |
@@ -34,8 +34,8 @@ type scaleCmd struct {
// user input
resourceGroupName string
- deploymentDirectory string
newDesiredAgentCount int
+ deploymentDirectory string
location string
agentPoolToScale string
masterFQDN string
| [drainNodes->[Wrapf,SafelyDrainNode,Sprintf,Duration,Errorf,HasPrefix],saveAPIModel->[LoadContainerServiceFromFile,SerializeContainerService,SaveFile],validate->[LoadTranslations,NormalizeAzureRegion,Infoln,New,Usage,Wrap],run->[PrettyPrintArmTemplate,drainNodes,Errorln,Values,Now,Front,NormalizeForK8sVMASScalingUp,IsA... | Package functions for the nagios api newScaleCmd returns a command to upgrade a Kubernetes cluster. | apiModelPath is a user input now so it should move up to this section for correctness |
@@ -2022,7 +2022,11 @@ define([
indexPrimitive(geometry);
if (geometry.primitiveType === PrimitiveType.TRIANGLES) {
- wrapLongitudeTriangles(geometry);
+ if (defined(geometry.attributes.prevPosition) || defined(geometry.attributes.nextPosition)) {
+ wrapLongitude... | [No CFG could be retrieved] | Returns a GeometryPipeline if the geometry is not in the pipeline. | This is pretty hacky, right? What if `Geometry` had an optional function to wrap longitude? If it is defined, we call it; otherwise, we call one here based on the `primitiveType` as before. |
@@ -153,7 +153,7 @@ namespace Microsoft.Extensions.Logging.Console
{
defaultFormatter.FormatterOptions = new SimpleConsoleFormatterOptions()
{
- DisableColors = deprecatedFromOptions.DisableColors,
+ ColorBehavior = deprecatedFromOptio... | [ConsoleLoggerProvider->[ILogger->[Format,TryGetValue,CurrentValue,Systemd,Simple,UpdateFormatterOptions,FormatterName,GetOrAdd],Dispose->[Dispose],SetScopeProvider->[ScopeProvider],ReloadLoggerOptions->[Format,TryGetValue,Options,Formatter,Systemd,Simple,UpdateFormatterOptions,FormatterName],DoesConsoleSupportAnsi->[I... | Update formatter options. | Should this be `LoggerColorBehavior.Enabled` or `LoggerColorBehavior.Default` in the else case? |
@@ -168,4 +168,12 @@ class ListRestHelper implements ListRestHelperInterface
return (null != $searchFields) ? explode(',', $searchFields) : [];
}
+
+ /**
+ * @return array
+ */
+ public function getFilters()
+ {
+ return $this->getRequest()->get('filter', []);
+ }
}
| [ListRestHelper->[getOffset->[getLimit],getLimit->[getIds]]] | Get the searchFields. | you are not using `filters` as plural in other places |
@@ -67,6 +67,9 @@ public class OidcIdentityProvider implements IdentityProvider<TokenAuthenticatio
.transformToUni(new Function<TenantConfigContext, Uni<? extends SecurityIdentity>>() {
@Override
public Uni<SecurityIdentity> apply(TenantConfigContext tenantConf... | [OidcIdentityProvider->[verifyCodeFlowAccessTokenUni->[get],getUserInfoUni->[get],getRolesJson->[get],tokenAutoRefreshPrepared->[get],authenticate->[apply->[get->[authenticate]]]]] | authenticate method. | @FroMage, Steph, this is the only change which is correct IMHO, I can help with the test a bit later on |
@@ -67,12 +67,14 @@ public class OpenIdServiceFactory extends AbstractServiceFactory<OpenIdService>
final String artifactId = request.getParameter(OpenIdProtocolConstants.OPENID_ASSOCHANDLE);
final ParameterList paramList = new ParameterList(request.getParameterMap());
- return new OpenIdServ... | [OpenIdServiceFactory->[createService->[hasText,getParameter,cleanupUrl,OpenIdService,ParameterList,getParameterMap]]] | Create a new OpenIdService based on the given request. | `null`: in that case, we don't have a response builder? |
@@ -36,7 +36,7 @@ type UPAKLoader interface {
PutUserToCache(ctx context.Context, user *User) error
LoadV2WithKID(ctx context.Context, uid keybase1.UID, kid keybase1.KID) (*keybase1.UserPlusKeysV2AllIncarnations, error)
CheckDeviceForUIDAndUsername(ctx context.Context, uid keybase1.UID, did keybase1.DeviceID, n N... | [ListFollowedUIDs->[Load],CheckKIDForUID->[loadWithInfo],PutUserToCache->[putUPAKToCache],getCachedUPAK->[getCachedUPAKTryMemThenDisk],putUPAKToCache->[putUPAKToDB],Load->[loadWithInfo],LookupUsernameUPAK->[loadWithInfo],LookupUID->[LookupUsername],getCachedUPAKTryMemThenDisk->[getMemCacheMaybeTryBothSlots,getCachedUPA... | LoadUserPlusKeys loads all user - specific keys. NewCachedUPAKLoader creates a CachedUPAKLoader implementation that can cache results between in. | If you think it's better I can make this take an options struct or split it out into different functions so callers aren't passing in default values. |
@@ -70,9 +70,9 @@ class TestPatchTestLargeStrain(KratosUnittest.TestCase):
#define the applied motion - the idea is that the displacement is defined as u = A*xnode + b
#so that the displcement is linear and the exact F = I + A
A = KratosMultiphysics.Matrix(3,3)
- A[0,0]... | [TestPatchTestLargeStrain->[test_TL_2D_quadrilateral->[_define_movement,_solve,_apply_material_properties,_check_outputs,_check_results,_add_variables,_apply_BCs],test_TL_2D_triangle->[_define_movement,_solve,_apply_material_properties,_check_outputs,_check_results,_add_variables,_apply_BCs],test_TL_3D_hexa->[_define_m... | Define the motion matrix and border border border border border border b. | ok with the change, but may i ask you why this decision? |
@@ -154,6 +154,18 @@ namespace System.Tests
Assert.Equal(expected, actual);
}
+ [Fact]
+ [PlatformSpecific(TestPlatforms.OSX)]
+ public void OSVersion_ValidVersion_OSX()
+ {
+ Version version = Environment.OSVersion.Version;
+
+ // verify that th... | [EnvironmentTests->[CurrentDirectory_Null_Path_Throws_ArgumentNullException->[AssertExtensions,CurrentDirectory],GetFolderPath_Unix_SpecialFolderDoesNotExist_CreatesSuccessfully->[AnyUnix,Templates,Create,GetFolderPath,Exists,ApplicationData,MyPictures,Desktop,DoNotVerify,Delete,Fonts,MyMusic,DesktopDirectory,MyVideos,... | OSVersion_ParseVersion method which gets operating system version. | It looks like we're testing the 1st, 2nd, and 4th parts. Anything we can assert about the 3rd? |
@@ -75,7 +75,7 @@ func dataSourceAwsKmsPublicKeyRead(d *schema.ResourceData, meta interface{}) err
d.Set("arn", output.KeyId)
d.Set("customer_master_key_spec", output.CustomerMasterKeySpec)
d.Set("key_usage", output.KeyUsage)
- d.Set("public_key", string(output.PublicKey))
+ d.Set("public_key", base64.StdEncoding... | [StringValue,GetOk,StringSlice,GetPublicKey,String,Errorf,SetId,Get,Set] | GetPublicKey returns the KMS public key. | Is this correct? If my understanding is correct `output.PublicKey` is already base64 encoded, so should it be returned as is? |
@@ -16,13 +16,18 @@
package org.jboss.shamrock.undertow;
+import java.util.ArrayList;
+import java.util.List;
+
import org.jboss.builder.item.MultiBuildItem;
import io.undertow.servlet.ServletExtension;
+import org.jboss.shamrock.runtime.ObjectSubstitution;
public final class ServletExtensionBuildItem exten... | [No CFG could be retrieved] | ServletExtensionBuildItem provides a simple way to build a single ServletExtension. | This should no longer be necessary |
@@ -5,6 +5,8 @@
* See: http://www.opendds.org/license.html
*/
+#include <sstream>
+
#include "DCPS/DdsDcps_pch.h" //Only the _pch include should start with DCPS/
#include "ace/Event_Handler.h"
#include "ace/Reactor.h"
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - DDS - specific methods. | Safety profile excludes the C++ standard library streams. See SafetyProfileStreams.h for helpful utility functions. |
@@ -68,6 +68,13 @@ module View
if @block_show
store(:flash_opts, 'Enter master mode to reveal other hand. Use this feature fairly.')
else
+ if @current_actions.include?('pass')
+ @step.before_process_pass = lambda do
+ store(:hidden, ... | [Auction->[render_companies->[h,visible?,auctioning,include?,bids,render_input,map],render->[round,h,compact,dig,active_step,include?,name,current_actions,current_entity],render_company_pending_par->[h,corporation],render_input->[min_bid,may_purchase?,h,new,size,value,max_bid,to_i,may_choose?,process_action,store,min_i... | Renders show button with a button. | hm i'm not sure about this. is there another way? it seems weird for the client to mutate the engine like this |
@@ -521,6 +521,9 @@ public class S3BlobStoreConfiguration extends CloudBlobStoreConfiguration {
MULTIPART_COPY_THRESHOLD_PROPERTY, MULTIPART_COPY_THRESHOLD_DEFAULT)))
.withMultipartCopyPartSize(Long.valueOf(getMultipartCopyPartSize()))
... | [S3BlobStoreConfiguration->[withNamespace->[S3BlobStoreConfiguration],parseDirectDownload->[parseDirectDownload],getAWSCredentialsProvider->[getAWSCredentialsProvider],parseDirectDownloadExpire->[parseDirectDownloadExpire]]] | Creates a TransferManager based on the current configuration. | `Executors.newFixedThreadPool((int) getLongProperty(...))` is enough. Note however that the AWS default is `TransferManagerUtils.createDefaultExecutorService()` which does ThreadFactory threadFactory = new ThreadFactory() { private int threadCount = 1; public Thread newThread(Runnable r) { Thread thread = new Thread(r)... |
@@ -38,6 +38,10 @@ class NativeDemo:
def fixed_args(self, source_dir, build_dir):
return [str(build_dir / self._name)]
+class MultichannelNativeDemo(NativeDemo):
+ def models_lst_path(self, source_dir):
+ return source_dir / 'multichannel_demo' / 'models.lst'
+
class PythonDemo:
def __in... | [combine_cases->[join_cases],NativeDemo,device_cases,single_option_cases,combine_cases,PythonDemo] | Return a list of fixed arguments for . | I don't think it makes sense for these demos to share one `models.lst` file. I don't think they even have any models in common. I think you should split it into per-demo ones. |
@@ -541,7 +541,7 @@ class TestBook(unittest.TestCase):
with program_guard(program):
input = layers.data(
name="input", shape=[3, 100, 100], dtype="float32")
- out = layers.shape(input, name="shape")
+ out = layers.shape(input)
self.assertIsNotNon... | [TestBook->[test_fit_a_line->[square_error_cost,fc,print,mean,data,str,assertIsNotNone,program_guard,Program],test_get_places->[get_places,print,str,assertIsNotNone,program_guard,Program],test_multiplex->[multiplex,print,data,str,assertIsNotNone,program_guard,Program],test_recognize_digits_conv->[cross_entropy,simple_i... | Test shape of the network. | why is this change? It should continue to support name? |
@@ -11,9 +11,6 @@ namespace System.Text.Json.Serialization.Tests
{
[Fact]
[OuterLoop]
-#if BUILDING_SOURCE_GENERATOR_TESTS
- [ActiveIssue("Needs JsonExtensionData support.")]
-#endif
public async Task MultipleThreadsLooping()
{
const int Iterations = 100;
| [ConstructorTests->[Task->[DeserializeObjectAsync,MultipleThreads,Verify,GetInstance,WhenAll,DeserializeObjectNormalAsync,DeserializeWrapper,DeserializeObjectMinimalAsync,VerifyMinimal,JsonSerializerWrapperForString,GetValue,RunTestAsync,SerializeWrapper,Checked,SerializeObject,DeserializeObjectFlippedAsync,Initialize,... | Multiple threads looping if a is encountered. | Nit: what is this test meant to be testing? If it's ensuring that the serialization infrastructure can cope with many serialization in parallel, that is generally handled by xunit's capacity to run multiple tests in parallel. If it's testing something else, it should be refelected in the test name. |
@@ -38,5 +38,5 @@ foreach ($_GET as $name => $value) {
}
foreach ($_POST as $name => $value) {
- $vars[$name] = clean($value);
+ $vars[$name] = ($value);
}
| [No CFG could be retrieved] | Get the variables from POST. | This change (along with the one made by @laf ) fixes the buggy behavior of special characters in service entries creating exponential numbers of '\'. But it also means that this function does nothing (except copy the variables... ) maybe we could use this to prevent posting array variables and let the mysql wrapper (db... |
@@ -35,7 +35,14 @@ class ApplicationController < ActionController::Base
end
def create_user_event(event_type, user = current_user)
- Event.create(user_id: user.id, event_type: event_type)
+ Event.transaction do
+ Event.create!(user_id: user.id, event_type: event_type)
+ # Keep total number of ev... | [ApplicationController->[confirm_two_factor_authenticated->[user_fully_authenticated?]]] | Creates a user event. | I kinda want to do this in the `after_save` callback on the Event model. Would that be acceptable @monfresh ? |
@@ -3277,8 +3277,7 @@ next:
* we may end up in an infinite loop retrying the same
* metaslab.
*/
- ASSERT(!metaslab_should_allocate(msp, asize));
-
+ /* ASSERT(!metaslab_should_allocate(msp, asize)); XXX */
mutex_exit(&msp->ms_lock);
}
mutex_exit(&msp->ms_lock);
| [No CFG could be retrieved] | region Private functions Internal function to handle allocation of a group without having to allocate more space. | yeah, this is where we will get confused because some space is not allocatable, but that is not reflected in all the metadata about the metaslab. |
@@ -117,8 +117,8 @@ func (c *Create) Flags() []cli.Flag {
cli.StringFlag{
Name: "image-datastore, i",
Value: "",
- Usage: "REQUIRED. Image datastore name",
- Destination: &c.ImageDatastoreName,
+ Usage: "Image datastore path",
+ Destination: &c.ImageDatastorePath,
},
cl... | [Run->[loadCertificate,checkImagesFiles,processParams],processParams->[processVolumeStores],UnmarshalText] | Flags returns a slice of flags that can be passed to the Create command Provides a description of the flags that are defined in the container network. This command is used to configure a virtual container Flags that can be set by the command line interface. | let's change this to `image-store` to be consistent with `volume-store` |
@@ -57,15 +57,15 @@ class _CreateSource(iobase.BoundedSource):
start_position = 0
if stop_position is None:
stop_position = len(self._serialized_values)
- avg_size_per_value = self._total_size / len(self._serialized_values)
+ avg_size_per_value = self._total_size // len(self._serializ... | [_CreateSource->[get_range_tracker->[OffsetRangeTracker,len],read->[try_claim,decode,set_split_points_unclaimed_callback,iter,range,next,stop_position,start_position],__init__->[map,sum],split->[int,max,SourceBundle,min,len,_create_source]]] | Splits this source into two sources of the specified size. | No need for an int call? |
@@ -315,10 +315,6 @@ public class FlowConfigurationFunctionalTestCase extends FunctionalTestCase
assertTrue(apple.isBitten());
assertTrue(banana.isBitten());
assertTrue(orange.isBitten());
-
- assertNotNull(results[0].getProperty("key", PropertyScope.INVOCATION));
- assertNotNul... | [FlowConfigurationFunctionalTestCase->[testPoll->[assertNotNull,request,assertEquals,getPayloadAsString],testSplitAggregateFlow->[assertNotNull,assertTrue,isBitten,addFruit,size,toList,Apple,request,Orange,Banana,run,getPayload,collect,contains,assertEquals,FruitBowl],testFlowRef->[getMessage,getPayloadAsString,assertE... | Test split aggregate map flow. This method checks if all the messages in the collection are in the correct order. | Should not be the invocation property still set on the event? |
@@ -1563,7 +1563,7 @@ func RunOneShotCommandPod(
}
if podHasErrored(cmdPod) {
- return true, fmt.Errorf("the pod errored trying to run the command")
+ return true, fmt.Errorf("the pod errored trying to run the command: %#v", cmdPod.Status)
}
return podHasCompleted(cmdPod), nil
})
| [AssertFailure->[DumpLogs],AssertSuccess->[DumpLogs]] | RunOneShotCommandPod runs the given command in a single pod and returns the command Check if the command pod has completed. | /lgtm cancel use spew to get full dump `Terminated:(*v1.ContainerStateTerminated)(0xc002a40230)` |
@@ -266,6 +266,14 @@ module Features
click_button t('forms.buttons.continue') if page.has_button?(t('forms.buttons.continue'))
end
+ def click_agree_and_continue(allow_missing: false)
+ if allow_missing
+ click_button t('sign_up.agree_and_continue') if page.has_button?(t('sign_up.agree_and_... | [set_up_2fa_with_authenticator_app->[select_2fa_option],sign_in_with_totp_enabled_user->[sign_in_user],confirm_email_and_password->[click_confirmation_link_in_email,submit_form_with_valid_email],sign_in_via_branded_page->[fill_in_credentials_and_submit],set_up_2fa_with_valid_phone->[select_2fa_option],set_up_2fa_with_p... | Clicks the continue button and clicks the default one. | The `click_continue` above only sometimes clicks continue...which makes refactoring a challenge I decided I wanted to mimimize the "click if it's not there behavior", so I parameterized it, and there's only one spec (signing in a second time) that used this. It seemed not quite worth the trouble to push the behavior in... |
@@ -459,7 +459,7 @@ def check_xpi_info(xpi_info, addon=None):
guid = xpi_info['guid']
if not guid:
raise forms.ValidationError(_("Could not find an add-on ID."))
- if len(guid) > 64:
+ if not waffle.switch_is_active('allow-long-addon-guid') and len(guid) > 64:
raise forms.ValidationErr... | [parse_addon->[parse_xpi,parse_search],PackageJSONExtractor->[apps->[find_appversion->[get],get,find_appversion],get->[get],parse->[apps,get]],extract_xpi->[extract_zip,copy_over],RDFExtractor->[apps->[find_appversion->[],find,get,uri],find_type->[get],find->[uri],__init__->[apps]],SafeUnzip->[close->[close],extract_fr... | Check that the X - PIN - Info field is valid. | Presumably there's still some upper limit? |
@@ -38,6 +38,7 @@ class User < ApplicationRecord
has_many :profiles, dependent: :destroy
has_many :events, dependent: :destroy
has_one :account_reset_request, dependent: :destroy
+ has_one :phone_configuration, dependent: :destroy, inverse_of: :user
validates :x509_dn_uuid, uniqueness: true, allow_nil: t... | [User->[two_factor_enabled?->[phone_enabled?,piv_cac_enabled?],send_custom_confirmation_instructions->[send_devise_notification],piv_cac_available?->[piv_cac_enabled?],piv_cac_enabled?->[piv_cac_enabled?]]] | The User class is a base class for all of the user - related classes. Check if a user has a TwoFactorAuthenticationController and if so send it to the user. | Why "Phone Configurations", and not plain "Phones"? Also, why `has_one` and not `has_many`? |
@@ -156,8 +156,16 @@ public class PermissionGrantedNotificationListener implements PostCommitFilterin
}
OperationChain chain = new OperationChain("SendMail");
- chain.add(SendMail.ID).set("from", from).set("to", to).set("HTML", true).set("subject", subject)
- .s... | [PermissionGrantedNotificationListener->[handleEvent->[handleEvent]]] | Handle an event that occurs on a new ACE. Check if there is a NuxeoPrincipal in the context and if so add it to. | No need for `final`. |
@@ -708,6 +708,11 @@ public class ConfigurationKeys {
public static final String DEFAULT_METRICS_REPORTING_FILE_ENABLED = Boolean.toString(false);
public static final String METRICS_LOG_DIR_KEY = METRICS_CONFIGURATIONS_PREFIX + "log.dir";
public static final String METRICS_FILE_SUFFIX = METRICS_CONFIGURATIONS_... | [ConfigurationKeys->[name,toString,toMillis]] | This method is used to set the default values for the metrics. This method is used to set metrics reporting for Kafka. | Since these configuration keys are dynamically set and not user provided, its better to define them inside the MRJobLauncher class. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.