patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -55,8 +55,13 @@ if (php_sapi_name() == 'cli' && isset($_SERVER['TERM'])) {
if (is_file($install_dir . '/composer.phar')) {
$exec = PHP_BINDIR . '/php ' . $install_dir . '/composer.phar';
- // self-update
- passthru("$exec self-update -q" . $extra_args);
+ // If older than 1 week, try update
+ if ... | [No CFG could be retrieved] | Download the Composer. Downloads the package and checks the signature. | Shouldn't this be inside the if statement? |
@@ -598,8 +598,8 @@ export class AmpSlideScroll extends BaseSlides {
* @private
*/
hideRestOfTheSlides_(indexArr) {
- const noOfSlides_ = this.noOfSlides_;
- for (let i = 0; i < noOfSlides_; i++) {
+ const totalNumSlides = this.slides_.length;
+ for (let i = 0; i < totalNumSlides; i++) {
i... | [AmpSlideScroll->[hideRestOfTheSlides_->[setStyle,includes],triggerAnalyticsEvent_->[dev,abs],analyticsEvent_->[triggerAnalyticsEvent],constructor->[isIos,startsWith,platformFor,isExperimentOn],onLayoutMeasure->[dev],touchEndHandler_->[timerFor],layoutCallback->[resolve],showSlideAndTriggerAction_->[createCustomEvent],... | Hide rest of the slides. | this.noOfSlides_ should always be the source of truth so we should only use that. |
@@ -27,8 +27,8 @@ import java.rmi.server.RemoteObject;
import java.rmi.server.RemoteRef;
import io.netty.util.internal.PlatformDependent;
-import io.netty.util.internal.shaded.org.jctools.util.UnsafeAccess;
import org.apache.activemq.artemis.tests.smoke.common.SmokeTestBase;
+import org.jctools.util.UnsafeAccess;
... | [JmxConnectionTest->[before->[cleanupData,disableCheckThread,forName,startServer],testJmxConnection->[assertTrue,getMessage,assumeTrue,getLiveRef,objectFieldOffset,setAccessible,setProperty,JMXServiceURL,println,getDeclaredField,printStackTrace,close,getObject,assertEquals,fail,assertNotNull,getPort,connect,get,hasUnsa... | This method is used to import a single object from the System. in The main entry point for the object. | @franz1981 what occurs post java 8 here? Same with any internal Unsafe access in the MPSC Queue used , just worried we tune for java 8 where unsafe is king, and then find on java 11 perf is lost, and we rely on a new lib that isnt needed.. It might be all good, i just want to play dumb and make sure, and i know jctools... |
@@ -209,6 +209,14 @@ public class MailServiceImpl extends DefaultComponent implements MailService {
}
protected Session newSession(Properties props) {
- return EmailHelper.newSession(props);
+ // build a key for sessions cache
+ String sessionKey = props.entrySet()
+ ... | [MailServiceImpl->[getFetcher->[getProperties],getMailBoxActions->[getConnectedStore,getMailBoxActions],sendMail->[getSession,sendMail],getProperties->[getProperties],getSession->[getSession,getProperties],getConnectedStore->[getConnectedStore],getConnectedTransport->[getConnectedTransport,getProperties],newSession->[n... | Creates a new session. | Wouldn't it be simpler to sort after the map, when you know you have a String already? |
@@ -88,7 +88,7 @@ func newPluginInstallCmd() *cobra.Command {
// Now for each kind, name, version pair, download it from the release website, and install it.
for _, install := range installs {
label := fmt.Sprintf("[%s plugin %s]", install.Kind, install)
- cmdutil.Diag().Infoerrf(
+ cmdutil.Diag().In... | [CloudURL,IsPluginKind,Message,ValueOrDefaultURL,Wrap,ParseTolerant,New,RunFunc,Diag,DownloadPlugin,PluginKind,StringVarP,Errorf,Wrapf,HasPluginGTE,Infoerrf,Sprintf,Install,Open,MaximumNArgs,PersistentFlags,HasPlugin,BoolVar] | Version - returns a version object that can be used to download a package from the release website Download the plugin if it doesn t exist. | @swgillespie None of these seem like errors, so i made them simple info events. I do not see why we would want to ever emit these to stderr. |
@@ -143,8 +143,8 @@ def _auto_config(cla55: Type[T]) -> Config[T]:
"""
typ3 = _get_config_type(cla55)
- # Don't include self
- names_to_ignore = {"self"}
+ # Don't include self, or vocab
+ names_to_ignore = {"self", "vocab"}
# Hack for RNNs
if cla55 in [torch.nn.RNN, torch.nn.LSTM, t... | [full_name->[full_name,_remove_prefix],_render->[is_configurable],_auto_config->[_get_config_type,Config,ConfigItem],configure->[_valid_choices,_auto_config],Config->[to_json->[to_json]],_valid_choices->[full_name],ConfigItem->[to_json->[full_name]],ConfigItem,Config] | Auto - config a node configuration for a node. ptimizer returns a new config with no items. | The vocab can still be configured at the top level, right? this is just to weed out all the other occurrences. |
@@ -57,7 +57,7 @@ const (
var storeCounter uint64
-const MinimumContractPayment = 100
+var MinimumContractPayment = assets.NewLink(100)
func init() {
gin.SetMode(gin.TestMode)
| [Stop->[Stop],NewAuthenticatingClient->[MustSeedUserSession],Get->[Get],Delete->[Delete],NewClientAndRenderer->[MustSeedUserSession],NewHTTPClient->[MustSeedUserSession],Post->[Post],Patch->[Patch],Post,Patch,NewHTTPClient] | missing - names - names - names - names - names - root - directory - base - NewConfigWithWSServer creates a new test config with a WSServer. | Sure, but let's make it a private since it's only used in `cltest`: `minimumContractPayment` |
@@ -131,6 +131,18 @@ public final class TcpSlaveAgentListener extends Thread {
return CLI_PORT != null ? CLI_PORT : getPort();
}
+ /**
+ * Gets the host name that we advertise protocol clients to connect to.
+ */
+ public String getAdvertisedHost() {
+ if(CLI_HOST_NAME != null) retu... | [TcpSlaveAgentListener->[shutdown->[getPort],getAdvertisedPort->[getPort],ConnectionHandler->[respondHello->[getAgentProtocolNames,getRemotingMinimumVersion],run],TcpSlaveAgentListenerRescheduler->[schedule->[schedule],getNewInstance->[TcpSlaveAgentListenerRescheduler]],getName]] | Get the advertised port number. | Not sure if it's the best approach. Why don't unrestrict CLI_HOST_NAME or Why don't just do that (read the `TcpSlaveAgentListener.class.getName()+".hostName"` system property) without having to rely on a newer version of the core. |
@@ -607,9 +607,11 @@ EVP_PKEY *load_keyparams(const char *uri, int maybe_stdin, const char *desc)
(void)load_key_certs_crls(uri, maybe_stdin, NULL, desc,
NULL, NULL, ¶ms, NULL, NULL, NULL, NULL);
- if (params == NULL) {
- BIO_printf(bio_err, "Unable to load %s\n", des... | [No CFG could be retrieved] | Loads a public key from either the specified engine or from a file. Load or extend a key from a URI. | Shouldn't this message say that it's not the expected key type? |
@@ -509,6 +509,13 @@ func (b *Beat) Setup(bt beat.Creator, template, setupDashboards, machineLearning
fmt.Println("Loaded Ingest pipelines")
}
+ if policy {
+ if err := b.loadILMPolicy(); err != nil {
+ return err
+ }
+ fmt.Println("Loaded Index Lifecycle Management (ILM) policies")
+ }
+
return ... | [launch->[InitWithSettings,createBeater],TestConfig->[createBeater,Init],Setup->[createBeater,Init],createBeater->[BeatConfig],configure->[BeatConfig],Init->[InitWithSettings]] | Setup initializes the beat and loads the template and dashboards Load the machine learning job configurations and load the ingest pipelines if they are available. | The printed message already uses plural (policies) but the command is `loadILMPolicy`. I prefer to pluralise everything as the intention is to be able to have multiple policies per beat, but at least this should be aligned. |
@@ -210,9 +210,9 @@ public class BigqueryMatcher extends TypeSafeMatcher<PipelineResult>
@Override
public void describeMismatchSafely(PipelineResult pResult, Description description) {
String info;
- if (response == null || response.getRows() == null || response.getRows().isEmpty()) {
- // invalid qu... | [BigqueryMatcher->[getDefaultCredential->[createScopedRequired,RuntimeException,newArrayList,createScoped,getApplicationDefault],queryWithRetries->[format,IOException,warn,next,execute],formatRows->[getV,size,append,getF,getRows,format,toString,StringBuilder],describeTo->[appendText],describeMismatchSafely->[formatRows... | Describes a mismatch in the response of a query. | "The query job hasn't completed" Could we also add the job id? Is response.toString() readable (why it was "Objects.toString(response)"). |
@@ -0,0 +1,11 @@
+require_dependency 'pinned_check'
+
+class WebHookTopicViewSerializer < TopicViewSerializer
+ def include_post_stream?
+ false
+ end
+
+ def include_timeline_lookup?
+ false
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | This serializer is huge, how much of the payload does it actually reduce as compared to `TopicViewSerializer`? |
@@ -28,9 +28,9 @@ from ..gateways.disk.read import (compute_md5sum, isdir, isfile, islink, read_in
read_index_json_from_tarball, read_repodata_json)
from ..gateways.disk.test import file_path_is_writable
from ..models.dist import Dist
-from ..models.index_record import PackageRecord... | [package_cache->[__contains__->[first_writable],keys->[first_writable,itervalues],__delitem__->[first_writable]],PackageCacheData->[query_all->[query],_dedupe_pkgs_dir_contents->[_process],reload->[load],values->[values],_package_cache_records->[load],clear->[clear],get_entry_to_link->[writable_caches,query_all,read_on... | A metaclass that can be used to manage a single package cache object. PackageCacheType - get the object from the cache. | Why the mixture of import types?? `conda.models.records` vs `..models.records` |
@@ -206,6 +206,7 @@ class Context(Configuration):
# ######################################################
deps_modifier = PrimitiveParameter(DepsModifier.NOT_SET)
update_modifier = PrimitiveParameter(UpdateModifier.UPDATE_SPECS)
+ sat_solver = PrimitiveParameter(None, element_type=string_types + (Non... | [Context->[default_python_default],determine_target_prefix->[locate_prefix_by_name],reset_context->[__init__],get_prefix->[determine_target_prefix],Context] | Parameters for the . Constructor for a command line interface. | If we were to make this more official, I'd probably want to turn it into an enum, following the example for `channel_priority`. It's fine for now though. |
@@ -1263,7 +1263,7 @@ func (c *ContainerBackend) containerStop(op trace.Operation, name string, second
}
operation := func() error {
- return c.containerProxy.Stop(op, vc, name, seconds, true)
+ return c.containerProxy.Stop(op, vc, name, seconds, false)
}
config := retry.NewBackoffConfig()
| [ContainerRm->[Handle],taskStartHelper->[Handle],ContainerExecStart->[taskStateWaitHelper,taskStartHelper,attachHelper],taskStateWaitHelper->[Handle],findPortBoundNetworkEndpoint->[defaultScope],ContainerExecInspect->[Handle],containerAttach->[Handle],Handle->[Handle],ContainerExecCreate->[Handle],containerStart->[Hand... | containerStop stops a container with the given name. If seconds is nil the container will be. | What is logic from true -> false here? |
@@ -1476,7 +1476,7 @@ abstract class CI_DB_driver {
*/
protected function _has_operator($str)
{
- return (bool) preg_match('/(<|>|!|=|\sIS NULL|\sIS NOT NULL|\sEXISTS|\sBETWEEN|\sLIKE|\sIN\s*\(|\s)/i', trim($str));
+ return (bool) preg_match('/(<|>|!|=|\sIS NULL|\sIS NOT NULL|\sEXISTS|\sBETWEEN|\sNOT BETWEEN|\... | [CI_DB_driver->[protect_identifiers->[protect_identifiers,escape_identifiers],list_fields->[query],db_pconnect->[db_connect],escape_identifiers->[escape_identifiers],list_tables->[query],field_data->[field_data,query],field_exists->[list_fields],insert_string->[escape_identifiers,escape],escape_str->[escape_str],simple... | Check if the string contains a condition. | No need to modify this function. If it has 'NOT BETWEEN' in `$str`, it must already has 'BETWEEN' and can be matched . |
@@ -312,7 +312,7 @@ class Evoked(ProjMixin, ContainsMixin, UpdateChannelsMixin, SetChannelsMixin,
def plot_topo(self, layout=None, layout_scale=0.945, color=None,
border='none', ylim=None, scalings=None, title=None,
proj=False, vline=[0.0], fig_background=None,
- ... | [_check_evokeds_ch_names_times->[copy],_read_evoked->[_get_entries,_get_aspect],combine_evoked->[_check_evokeds_ch_names_times],EvokedArray->[__init__->[copy]],Evoked->[__neg__->[copy],to_data_frame->[copy],detrend->[detrend]],read_evokeds->[Evoked,_get_evoked_node]] | Plot a TIFF plot of the object. | you cannot change public APIs like that. We need deprecation cycles. |
@@ -86,6 +86,18 @@ module.exports = class livecoin extends Exchange {
'CRC': 'CryCash',
'XBT': 'Bricktox',
},
+ 'exceptions': {
+ '1': ExchangeError,
+ '10/11/12/20/30/101/102': AuthenticationError,
+ '31': NotSupport... | [No CFG could be retrieved] | Get all exchange market data Get the list of possible restrictions for a single node. | I'd propose to split these into separate codes, that would help simplify the handler below somewhat. What do you think? |
@@ -303,11 +303,16 @@ def linux_fuse_shard() -> Dict:
}
-def _osx_env_with_pyenv(python_version: PythonVersion) -> List[str]:
+def _osx_env() -> List[str]:
return [
'PATH="/usr/local/opt/openssl/bin:${PATH}"',
'LDFLAGS="-L/usr/local/opt/openssl/lib"',
'CPPFLAGS="-I/usr/local/opt/openssl/include... | [linux_shard->[default_stage,_linux_before_install],Stage->[all_entries->[condition]],integration_tests_v2->[linux_shard],build_wheels_linux->[_build_wheels_env,linux_shard,docker_build_travis_ci_image,docker_run_travis_ci_image,_build_wheels_command],build_wheels_osx->[_build_wheels_command,_build_wheels_env,osx_shard... | Return a list of environment variables that can be used in the OSX environment with the given. | Nitty suggestion: we've recently been using this style more and I think it's quite nice: ```python return [ *osx_env(), "PATH=...", ] |
@@ -20,6 +20,7 @@ namespace Dynamo.Services
private static DynamoModel dynamoModel;
private static UsageReportingManager instance;
+ private static IBrandingResourceProvider resourceProvider;
#endregion
| [UsageReportingManager->[ShowUsageReportingPrompt->[Owner,ShowDialog,MainWindow,Current],CheckIsFirstRun->[IsTestMode,IsFirstRun,ShowUsageReportingPrompt],ToggleIsUsageReportingApproved->[DynamoView,ShowUsageReportingPrompt],InitializeCore->[dynamoModel],RaisePropertyChanged,Save,IsTestMode,GetSettingsFilePath,IsCrashi... | Creates a new object that can be used to manage usage of a specific object. Initialize the n - node usage tracking system. | Hang on, what's this for? Should it be `static`? |
@@ -133,6 +133,11 @@ class CurlResult
{
$this->isSuccess = ($this->returnCode >= 200 && $this->returnCode <= 299) || $this->errorNumber == 0;
+ // Everything higher than 299 is not an success
+ if ($this->returnCode > 299) {
+ $this->isSuccess = false;
+ }
+
if (!$this->isSuccess) {
Logger::log('erro... | [CurlResult->[__construct->[parseBodyHeader,checkRedirect,checkInfo,checkSuccess]]] | Check if the request was successful. | Please remove `|| $this->errorNumber == 0` from this line instead of adding the following code block. The end result is exactly the same, except there are 5 lines of code instead of one. |
@@ -191,7 +191,8 @@ public class SchedV2 extends AbstractSched {
if (!mHaveQueues) {
reset();
}
- Card card = _getCard();
+ Card card = loadNextCard(false);
+ mNextCard = null;
if (card != null) {
mCol.log(card);
mReps += 1;
| [SchedV2->[_resetRevCount->[_currentRevLimit],haveBuried->[haveBuriedSiblings,haveManuallyBuried],counts->[reset,counts],deckDueTree->[deckDueTree,deckDueList],_previewingCard->[_cardConf],_constrainedIvl->[_fuzzedIvl],_resetLrn->[_resetLrnCount,_updateLrnCutoff],eta->[getDayCutoff,eta],_newConf->[_cardConf],_updateCut... | Get the next card in the list. | This doesn't unset the parents? Intentional? |
@@ -33,6 +33,7 @@ class Trainer:
cuda_device: int = -1,
grad_norm: Optional[float] = None,
grad_clipping: Optional[float] = None,
+ learning_rate_scheduler: Optional[torch.optim.lr_scheduler._LRScheduler] = None, # pylint: disable=protected-access
... | [Trainer->[train->[train],from_params->[Trainer]]] | Initialize a new object with the given parameters. Initialize the object with a single . The number of batches to log to tensorboard. | It'd probably be a bit nicer to just do `from torch.optim.lr_scheduler import _LRScheduler as LRScheduler` at the top of the file, so this line isn't as ugly. |
@@ -260,3 +260,13 @@ class SMACTuner(Tuner):
params.append(self.convert_loguniform_categorical(challenger.get_dictionary()))
cnt += 1
return params
+
+ def feed_tuning_data(self, data):
+ assert "parameter" in data
+ _params = data["parameter"]
+ assert... | [SMACTuner->[generate_multiple_parameters->[convert_loguniform_categorical],update_search_space->[_main_cli],generate_parameters->[convert_loguniform_categorical],__init__->[OptimizeMode]]] | generate multiple instances of hyperparameters. | This one would not work, let me help you fix |
@@ -87,14 +87,14 @@ class OutputCheckWrapperDoFn(AbstractDoFnWrapper):
except TypeCheckError as e:
error_msg = ('Runtime type violation detected within ParDo(%s): '
'%s' % (self.full_label, e))
- six.raise_from(TypeCheckError(error_msg), sys.exc_info()[2])
+ raise_with_tracebac... | [TypeCheckVisitor->[visit_transform->[OutputCheckWrapperDoFn,TypeCheckWrapperDoFn],enter_composite_transform->[TypeCheckCombineFn]],TypeCheckCombineFn->[create_accumulator->[create_accumulator],extract_output->[extract_output],add_input->[add_input],merge_accumulators->[merge_accumulators]],TypeCheckWrapperDoFn->[_type... | Wrapper for methods that return a object. | We should add `bytes` to this tuple: this preserves the intended behavior in Python 3, where `str` and `unicode` here are synonyms. |
@@ -1439,7 +1439,7 @@ void BinBasedDEMFluidCoupledMapping<TDim, TBaseTypeOfSwimmingParticle>::Calculat
double elemental_volume;
GeometryUtils::CalculateGeometryData(geom, DN_DX, Ng, elemental_volume);
const double& radius = p_node->FastGetSolutionStepValue(RADIUS);
- const double particle_volu... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - n_origin_variable = null ;. | Can ` mParticlesPerDepthDistance` be changed to another name? Like `particles_per_depth_distance` to make it coherent with Kratos style |
@@ -47,6 +47,12 @@ func NewS3ObjectClient(cfg StorageConfig, schemaCfg chunk.SchemaConfig) (chunk.O
return nil, err
}
+ if cfg.S3ForceTLS {
+ if strings.Contains(cfg.S3.URL.Host, ".") {
+ s3Config = s3Config.WithEndpoint(fmt.Sprintf("https://%s", cfg.S3.URL.Host))
+ }
+ }
+
s3Config = s3Config.WithS3ForceP... | [GetChunks->[GetParallelChunks],PutChunks->[Encoded,putS3Chunk,ExternalKey],putS3Chunk->[String,CollectedRequest,PutObjectWithContext,NewReader],getChunk->[GetObjectWithContext,Decode,Close,String,CollectedRequest,ReadAll,ExternalKey],WithMaxRetries,NewHistogramCollector,New,NewHistogramVec,TrimPrefix,Errorf,Register,W... | NewS3ObjectClient creates a new object client for a given chunk. getChunk retrieves a chunk from an S3 object. | Should this check for presence of http/https in the url already? |
@@ -40,10 +40,14 @@ class WebHook < ActiveRecord::Base
end
end
- def self.enqueue_topic_hooks(event, topic, user)
+ def self.enqueue_topic_hooks(event, topic, user=nil)
WebHook.enqueue_hooks(:topic, topic_id: topic.id, user_id: user&.id, category_id: topic&.category&.id, event_name: event.to_s)
end
... | [WebHook->[enqueue_topic_hooks->[enqueue_hooks],enqueue_topic_hooks,enqueue_hooks]] | Enqueue all hooks of a given type. | `topic_id: post&.topic&.id` can be `post&.topic_id` |
@@ -1279,6 +1279,7 @@ func TestTeamCanUserPerform(t *testing.T) {
require.True(t, annPerms.DeleteChannel)
require.True(t, annPerms.RenameChannel)
require.True(t, annPerms.EditChannelDescription)
+ require.True(t, annPerms.ChangeChannelAvatar)
require.True(t, annPerms.SetTeamShowcase)
require.True(t, annPerms.... | [createTeam2->[createTeam],paperKeyID->[devices],reset->[userVersion],addPuklessUser,cleanup,addUser,loginAfterReset,removeTeamMember,reset,provisionNewDevice,loadTeamByID,leave,track,logUserNames,changeTeamMember,createTeam,delayMerkleTeam,addTeamMember,newSecretUI,lookupImplicitTeam,proveRooter,addUserWithPaper,creat... | The default behavior is to show the permissions of the user. This function is called from the administration code. | It's not a channel avatar, that is not a thing that exists. The avatar is for the team. I think the root cause here is that `EditChannelDescription` is used in the teams code for teams related stuff, beyond this avatar problem (which is I guess why you were involved with it in the first place). You should make a new fi... |
@@ -55,7 +55,9 @@ the dependencies"""
def load(parser, args):
env = ev.get_env(args, 'load')
- specs = [spack.cmd.disambiguate_spec(spec, env, first=args.load_first)
+ specs = [spack.cmd.disambiguate_spec(spec, env, first=args.load_first,
+ compatible=True,
+ ... | [load->[disambiguate_spec,prepend_path,write,read_transaction,msg,environment_modifications_for_spec,EnvironmentModifications,parse_specs,extend,dag_hash,join,get_env,traverse,shell_modifications],setup_parser->[add_common_arguments,add_mutually_exclusive_group,add_argument]] | Load a node - level object. | These options need to be somehow controlled by options. In particular, there are lots of builds that are incompatible *as builds* that are compatible at runtime (different library versions can run together even if they weren't built together. In Spack, we don't try to model that, but we don't want to preclude users fro... |
@@ -623,7 +623,10 @@ def _handle_exception(exc_type, exc_value, trace, config):
# Here we're passing a client or ACME error out to the client at the shell
# Tell the user a bit about what happened, without overwhelming
# them with a full traceback
- err = traceback.form... | [revoke->[revoke,_determine_account],setup_logging->[setup_log_file_handler],_treat_as_renewal->[_handle_identical_cert_request,_handle_subset_cert_request],install->[_init_le_client,_find_domains],run->[_init_le_client,_auth_from_domains,_find_domains,_suggest_donation_if_appropriate],main->[setup_logging],_csr_obtain... | Logs exceptions and reports them to the user. Exit with an error message if an unexpected error occurs. | Sorry I didn't catch this on my prior review, but this line has no test coverage. |
@@ -88,6 +88,10 @@ public class LocalTaskStateTracker extends AbstractTaskStateTracker {
// it has not reached the maximum number of retries
WorkUnitState.WorkingState state = task.getTaskState().getWorkingState();
if (state == WorkUnitState.WorkingState.FAILED && task.getRetryCount() < this.maxTas... | [LocalTaskStateTracker->[onTaskCommitCompletion->[error,of,info,getWorkingState,updateByteMetrics,getTaskDuration,isEnabled,getTaskId,post,format,updateRecordMetrics,getTaskState,cancel,getWorkunit,containsKey,NewTaskCompletionEvent,addTaskState],registerNewTask->[error,TaskMetricsUpdater,scheduleTaskMetricsUpdater,get... | Handle a task completion callback. | Both `Task` and `LocalTaskStateTracker` are generic. They shouldn't be affected by any source specific configuration. Rename the configuration key to be `task.shouldRetryFromBegining` |
@@ -180,10 +180,14 @@ public class CoordinatorDynamicConfig
return killAllDataSources;
}
+ /**
+ * List of dataSources for which pendingSegments are NOT cleaned up
+ * if property druid.coordinator.kill.pendingSegments.on is true.
+ */
@JsonProperty
- public Set<String> getKillPendingSegmentsSkipLi... | [CoordinatorDynamicConfig->[Builder->[build->[getMaxSegmentsToMove,isKillAllDataSources,getMaxSegmentsInNodeLoadingQueue,getKillDataSourceWhitelist,getMergeSegmentsLimit,getBalancerComputeThreads,getReplicantLifetime,emitBalancingStats,getMergeBytesLimit,getMillisToWaitBeforeDeleting,getReplicationThrottleLimit,getKill... | Check if this node is a killAllDataSources node. | Could you please reference `druid.coordinator.kill.pendingSegments.on` in source code terms? Like a boolean field in some class? |
@@ -38,7 +38,7 @@
<div class="listing-filters-categories">
<a href="<%= listings_path %>" class="<%= "selected" if params[:category].blank? %> data-no-instant=" true ">all</a>
<% categories_for_display.each do |cat| %>
- <a href="<%= listing_category_path(category: cat[:slug]) %>" class="<%= "... | [No CFG could be retrieved] | Displays a hidden list of categories and a link to create a new listing. | weird that it created a space between the tag and the quote |
@@ -107,6 +107,16 @@ func (t Time) MarshalJSON() ([]byte, error) {
return json.Marshal(t.UTC().Format(time.RFC3339))
}
+// MarshalQueryParameter converts to a URL query parameter value
+func (t Time) MarshalQueryParameter() (string, error) {
+ if t.IsZero() {
+ // Encode unset/nil objects as an empty string
+ re... | [MarshalJSON->[IsZero],Before->[Before],IsZero->[IsZero],Equal->[Equal]] | MarshalJSON - encodes a time to JSON. | Don't you need this to be a pointer? |
@@ -2002,7 +2002,10 @@ ds_obj_ec_agg_handler(crt_rpc_t *rpc)
daos_key_t *dkey;
struct daos_oclass_attr *oca;
struct bio_desc *biod;
- daos_iod_t iod = { 0 };
+ daos_iod_t *iod = &oea->ea_iod;
+ struct dcs_iod_csums *iod_csums = oea->ea_iod_csums.ca_arrays;
+
+ crt_bulk_t parity_bulk = oea->ea_bulk;
daos_... | [No CFG could be retrieved] | DP_UOID - > DP_RC - > out DOS - IO context if ioh is not found in the oea return it. | (style) trailing whitespace |
@@ -63,8 +63,8 @@ func (e *BTCEngine) Run(ctx *Context) error {
}
sigKey, _, err := e.G().Keyrings.GetSecretKeyWithPrompt(libkb.SecretKeyArg{
- DeviceKey: true,
- Me: me,
+ Me: me,
+ KeyType: libkb.DeviceKeyType,
}, ctx.SecretUI, "to register a cryptocurrency address")
if sigKey == nil {
re... | [Run->[GetSecretKeyWithPrompt,IdTable,SignJson,LoadMe,GetSigId,G,Post,GetKid,ActiveCryptocurrency,String,Errorf,BtcAddrCheck,Info,CryptocurrencySig,CheckSecretKey],NewContextified] | Run executes the engine. Cryptocurrency address is a bitcoin address. | I think this should be libkb.AllSecretKeyTypes, since legacy users might not have a device key. |
@@ -9,7 +9,7 @@ class Internal::FeedbackMessagesController < Internal::ApplicationController
includes(:reporter, :notes).
order("feedback_messages.created_at DESC").
page(params[:page] || 1).per(5)
- @email_messages = EmailMessage.find_for_reports(@feedback_messages.pluck(:id))
+ @email_messa... | [show->[find_for_reports,id,find_by],feedback_message_params->[permit],send_slack_message->[ping,generate_message],send_email->[render,deliver],save_status->[render,full_messages,find,update],index->[find_for_reports,per,pluck],get_vomits->[order,limit,blank?],create_note->[status,feedback_type,new,render,full_messages... | This action shows the nag - message message and the nag - message report. | `EmailMessage.find_for_reports` uses feedback messages IDs for a query. If we don't use `pluck` but pass the object themselves Rails is going to issue only one query using a subselect. something like: `SELECT * FROM email_messages WHERE feedback_message_id IN (SELECT id FROM feedback_messages)` instead of two separate ... |
@@ -114,6 +114,10 @@ class WorkDecorator < ApplicationDecorator
end
when :number_format_id
send(:number_format).name if send(:number_format_id).present?
+ when :season_year
+ send(:season_year).to_s
+ when :season_name
+ send(:season_name)&.text
else
send... | [WorkDecorator->[to_values->[local_name,send,text,decode,link_to,present?,each_with_object,name],db_detail_link->[edit_db_work_path,presence,link_to],local_title->[present?,locale],syobocal_link->[presence,link_to],release_season_link->[link_to,slug,blank?,season_works_path],title_link->[work_path,link_to],twitter_user... | Returns a Hash with all the values of the Nested Header as keys and links to the appropriate. | Indent when as deep as case. |
@@ -216,12 +216,9 @@ export function getPlacementsFromConfigObj(win, configObj) {
return [];
}
const placements = [];
- for (let i = 0; i < placementObjs.length; ++i) {
- const placement = getPlacementFromObject(win, placementObjs[i]);
- if (placement) {
- placements.push(placement);
- }
- }
... | [No CFG could be retrieved] | Creates an element from the given type and data attributes. Get anchor element. | We could pass `placements` into `getPlacementsFromObject` and avoid the awkward `#apply` here. |
@@ -6,9 +6,8 @@ import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
/**
- * Annotation that marks a method as a setter called through reflection by the GameParser (through the xml) and/or
- * PropertyUtil (through the
- * ChangeFactory).
+ * Annotation that marks a method as a setter ca... | [No CFG could be retrieved] | Package for debugging purposes. | Is this annotation still required? I thought it was only present to alert someone that the target may be called reflectively. |
@@ -42,10 +42,7 @@ import java.util.concurrent.atomic.AtomicInteger;
import org.eclipse.jgit.api.DiffCommand;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.errors.GitAPIException;
-import org.eclipse.jgit.lib.ObjectId;
-import org.eclipse.jgit.lib.PersonIdent;
-import org.eclipse.jgit.lib.RefDatabase;... | [GitScmProviderTest->[branchChangedLines_returns_null_on_io_errors_of_repo_builder->[mockCommand],branchChangedFiles_should_return_null_if_repo_exactref_is_null->[mockCommand],addLineToFile->[randomizedLine],newScmProvider->[mockCommand],revisionId_should_return_different_sha1_after_commit->[newGitScmProvider],branchCh... | package for testing purposes This method imports all the methods from the java. util. logging. Logger. | our formatting style doesn't allow the use of wildcards in imports. Could you please bring back import of each individual class? |
@@ -238,6 +238,7 @@ HitParams getHitParams(const ItemGroupList &armor_groups,
const ToolCapabilities *tp, float time_from_last_punch)
{
s16 damage = 0;
+ float result_wear = 0.0;
float full_punch_interval = tp->full_punch_interval;
for (const auto &damageGroup : tp->damageGroups) {
| [deserializeJson->[fromJson],getHitParams->[getHitParams],serializeJson->[toJson],getPunchDamage->[getHitParams]] | Get the hit parameters for the hit. | All floats should be stated with an 'f': `0.0f` |
@@ -1123,6 +1123,16 @@ function onMessage(global, event) {
}
postMessage({event: VideoEvents.UNMUTED});
break;
+ case 'hideControls':
+ if (!adsActive) {
+ hideControls();
+ }
+ break;
+ case 'showControls':
+ if (!adsActive) {
+ showControls();
+ }
+ ... | [No CFG could be retrieved] | Handler for events from the video player. The main function for the message processing. | If it does both `preventDefault` and `stopPropagation` (per `onProgressClick` above), won't it effectively prevent triggering ads anyway? |
@@ -37,7 +37,7 @@ public abstract class AbstractKafkaIndexingServiceTest extends AbstractStreamInd
@Override
StreamAdminClient createStreamAdminClient(IntegrationTestingConfig config)
{
- return new KafkaAdminClient(config.getKafkaHost());
+ return new KafkaAdminClient(config.getKafkaHost(), config);
... | [AbstractKafkaIndexingServiceTest->[createStreamEventWriter->[checkNotNull,KafkaEventWriter],createStreamAdminClient->[getKafkaHost,KafkaAdminClient],generateStreamQueryPropsTransform->[RuntimeException,plusMinutes,print,getSumOfEventSequence,replace,toString,plusSeconds],generateStreamIngestionPropsTransform->[getKafk... | Create a StreamAdminClient for Kafka. | Should the `KafkaAdminClient` constructor signature be adjusted to only take `IntegrationTestingConfig ` and just set `host` inside the constructor from it instead of extracting here? |
@@ -171,6 +171,7 @@ class AgendaEvents extends DolibarrApi
$obj = $db->fetch_object($result);
$actioncomm_static = new ActionComm($db);
if ($actioncomm_static->fetch($obj->rowid)) {
+ $actioncomm_static->fetch_optionals();
$obj_r... | [AgendaEvents->[get->[fetch,initAsSpecimen,fetch_optionals,_cleanObjectDatas,fetchObjectLinked],post->[create,_validate],put->[fetch,fetch_optionals,fetch_userassigned,get,update],index->[plimit,fetch,query,num_rows,_cleanObjectDatas,fetch_object,lasterror,order],delete->[fetch,fetch_optionals,fetch_userassigned,delete... | Returns all events that have been added to the agenda Retrieve all the necesitary action data from the database. Get Agenda Event list. | With code standardization, we started to include all the fetch_optionals inside the fetch(). So can you move it at end of the $actioncomm_static->fetch() ? |
@@ -1,4 +1,5 @@
Rails.application.routes.draw do
+
use_doorkeeper do
skip_controllers :applications, :authorized_applications, :token_info
end
| [draw->[instance_eval,read,join],authenticated,skip_controllers,devise_scope,put,draw,resources,member,root,constraints,post,require,use_doorkeeper,patch,devise_for,match,delete,namespace,collection,core_api_v1_enabled,get,unauthenticated] | Rails routes for the application The resource that should be used to view the user s settings. | Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. |
@@ -658,7 +658,11 @@ class AddonViewSet(RetrieveModelMixin, GenericViewSet):
AllowReviewer, AllowReviewerUnlisted),
]
serializer_class = AddonSerializer
- addon_id_pattern = re.compile(r'^(\{.*\}|.*@.*)$')
+ addon_id_pattern = re.compile(
+ # Match {uuid} or something@host.tld ("so... | [developers->[filter],home->[rand,filter],license->[filter],CollectionPromoBox->[collections->[features,filter,all],features->[all]],BaseFilter->[filter_downloads->[filter_popular],filter_name->[all]],AddonViewSet->[get_queryset->[all],feature_compatibility->[get_object],all],persona_detail->[_category_personas]] | ViewSet for a single Addon. If the value is a digit it s either a slug or guid. | The regex definition in XPIProvider.jsm ignores case. Should the same be done here? |
@@ -154,15 +154,6 @@ class Seq2seqAgent(TorchGeneratorAgent):
if self.use_cuda:
self.model.cuda()
- if self.multigpu:
- self.model = torch.nn.DataParallel(self.model)
- self.model.encoder = self.model.module.encoder
- self.model.decoder = s... | [Seq2seqAgent->[save->[save,model_version],load->[load]]] | Initialize model with optional state dictionary. Build the n - grams loss criterion. | this is so much cleaner now |
@@ -461,6 +461,8 @@ namespace Dynamo.Controls
Position = new Point3D(10, 15, 10),
LookDirection = new Vector3D(-10, -10, -10),
UpDirection = new Vector3D(0, 1, 0),
+ NearPlaneDistance = 1,
+ FarPlaneDistance = 2000000,
};
... | [Watch3DView->[ViewModel_PropertyChanged->[NotifyPropertyChanged],DrawTestMesh->[NotifyPropertyChanged],SendGraphicsToView->[NotifyPropertyChanged],NotifyPropertyChanged]] | Setup the scene. Plots the camera missing conditions. | Is it possible for us to simply not set the `FarPlaneDistance`? i.e. is there some way to disable it completely? |
@@ -87,7 +87,7 @@ void gigatron_state::gigatron(machine_config &config)
screen.set_screen_update(FUNC(gigatron_state::screen_update));
/* sound hardware */
- //SPEAKER(config, "mono").front_center();
+ SPEAKER(config, "mono").front_center();
}
ROM_START( gigatron )
| [No CFG could be retrieved] | Initialize Gigatron state. 9. 2. 2. 2. | This is still a premature addition that will fail due to a lack of input sound channels. |
@@ -79,6 +79,15 @@ describe SystemMessage do
post = SystemMessage.create(user, :welcome_invite)
expect(post.topic.allowed_groups).to eq([])
end
- end
+ it 'allows plugin to override content' do
+ SystemMessage.custom_message(:tl2_promotion_message) do
+ { title: 'override title', ra... | [create,new,describe,topic,site_contact_group_name,it,name,site_contact_username,contain_exactly,to,system_user,system_message,allow_user_locale,before,t,username,require,fab!,title,id,update!,create_from_system_user,context,eq,with_locale] | create a welcome invite. | Note for myself - I need to ensure I remove custom message after that spec :) |
@@ -66,6 +66,7 @@ def initialize(name=None, seeds=None, max_pool_size=None, replica_set=None):
"Could not connect to MongoDB at %(url)s ... Waiting %(retry_timeout)s seconds "
"and trying again.")
_LOG.error(msg % {'retry_timeout': next_delay, 'url': seeds})
+ ... | [get_collection->[PulpCollectionFailure,PulpCollection],PulpCollection->[__init__->[_retry_decorator]],_retry_decorator->[_decorator->[retry->[PulpCollectionFailure]]]] | Initialize the connection pool and top - level database for pulp. Checks if a is available in the database and if so attempts to authenticate to the database. | We don't want print statements in code that could be run in a daemon. |
@@ -37,6 +37,8 @@ from apache_beam.options.value_provider import check_accessible
DEFAULT_SHARD_NAME_TEMPLATE = '-SSSSS-of-NNNNN'
+__all__ = ['FileSink']
+
class FileSink(iobase.Sink):
"""A sink to a GCS or local files.
| [FileSink->[close->[close]],FileSinkWriter->[close->[close],write->[write_record],__init__->[open]]] | Creates a new object that represents a single non - empty . TypeError - if file_path_parameters file_path_prefix compression_type is. | Why do we have FileBasedSource but FileSink? Make an alias (if it's too late to rename) and export exactly one version. |
@@ -1,14 +1,10 @@
# frozen_string_literal: true
class Bookmark < ActiveRecord::Base
- self.ignored_columns = [
- "topic_id", # TODO (martin) (2021-12-01): remove
- "reminder_type" # TODO (martin) (2021-12-01): remove
- ]
-
belongs_to :user
belongs_to :post
has_one :topic, through: :post
+ belongs_... | [Bookmark->[auto_delete_when_reminder_sent?->[auto_delete_preferences],auto_delete_on_owner_reply?->[auto_delete_preferences]]] | Returns an Enumerator that represents the auto delete preferences. | I think it'll be helpful as well to declare the association on the `Post` and `Topic` model. |
@@ -9,12 +9,10 @@ class AutotestScriptsJob < ApplicationJob
else
markus_address = host_with_port + Rails.application.config.action_controller.relative_url_root
end
- server_host = MarkusConfigurator.autotest_server_host
server_path = MarkusConfigurator.autotest_server_dir
server_username =... | [AutotestScriptsJob->[perform->[capture3,find,start,join,nil?,exec!,autotest_server_dir,relative_url_root,generate,mktmpdir,exitstatus,short_identifier,autotest_server_username,autotest_server_command,autotest_server_host,capture2e,raise,strip,cp_r],autotest_scripts_queue,queue_as]] | Perform the automatic tests on a node. Find and return a sequence number. | Layout/SpaceBeforeComma: Space found before comma. |
@@ -124,4 +124,9 @@ public final class AsynchronousRetryTemplate extends AbstractComponent
public void dispose() {
disposeIfNeeded(delegate, LOGGER);
}
+
+ @Override
+ public boolean isAsync() {
+ return false;
+ }
}
| [AsynchronousRetryTemplate->[setMetaInfo->[setMetaInfo],setNotifier->[setNotifier],getMetaInfo->[getMetaInfo],execute->[execute],getNotifier->[getNotifier],createRetryInstance->[createRetryInstance],isEnabled->[isEnabled]]] | Disposes of a . | Shouldn't this return true? |
@@ -194,6 +194,7 @@ func listen(m http.Handler, handleRedirector bool) error {
listenAddr = net.JoinHostPort(listenAddr, setting.HTTPPort)
}
log.Info("Listen: %v://%s%s", setting.Protocol, listenAddr, setting.AppSubURL)
+ log.Info("AppURL: %s", setting.AppURL)
if setting.LFS.StartServer {
log.Info("LFS se... | [DelLogger,SetValue,NormalRoutes,Critical,HandlerFunc,Close,Getppid,JoinHostPort,Redirect,Info,IsSet,Routes,Stack,IsShutdown,Done,InitManager,CreateOrAppendToCustomConf,Bool,Key,PreloadSettings,NewLogger,Section,ListenAndServe,ClearHandler,GetManager,GlobalInit,TrimSuffix,Sprintf,Background,WithCancel,HammerContext,Str... | setPort sets the port for the server and starts listening for requests. RedirectOtherPort - redirect other port. | Wait Why here? Shouldn't this be a part of the debug statements that are always printed at the beginning? For me, "Listen: " always signified that Gitea has now started up and can be accessed. |
@@ -145,9 +145,15 @@ def deduce_helpful_msg(req):
def install_req_from_editable(
- editable_req, comes_from=None, use_pep517=None, isolated=False,
- options=None, wheel_cache=None, constraint=False
+ editable_req, # type: str
+ comes_from=None, # type: Optional[str]
+ use_pep517=None, ... | [install_req_from_editable->[parse_editable],parse_editable->[_strip_extras],install_req_from_line->[deduce_helpful_msg,_strip_extras]] | Install a requirement from an editable requirement. | An extra level of indentation is unnecessary. |
@@ -382,6 +382,8 @@ def transform_basic_comparison(builder: IRBuilder,
left: Value,
right: Value,
line: int) -> Value:
+ if is_int_rprimitive(left.type) and is_int_rprimitive(right.type) and op in ('=='):
+ return ... | [translate_method_call->[translate_call],_visit_tuple_display->[_visit_list_display],transform_slice_expr->[get_arg],transform_comparison_expr->[go->[go],go],translate_super_method_call->[translate_call]] | Transform a basic comparison between two nodes. | The latter part should be `op == '=='` or `op in ('==',)`, as now it's equivalent to `op in '=='`. |
@@ -270,7 +270,7 @@ func (s *schedulerTestSuite) TestScheduler(c *C) {
"minor-dec-ratio": 0.99,
"src-tolerance-ratio": 1.05,
"dst-tolerance-ratio": 1.05,
- "read-priorities": []interface{}{"qps", "byte"},
+ "read-priorities": []interface{}{"query", "byte"},
"... | [SetUpSuite->[Background,WithCancel],TearDownSuite->[cancel],TestScheduler->[SetScheduleConfig,MustPutStore,Now,GetConfig,MustPutRegion,GetClientURL,ExecuteCommand,GetScheduleConfig,GetServer,Assert,Destroy,GetRootCmd,UnixNano,Contains,BootstrapCluster,WaitLeader,Unmarshal,RunInitialServers,NewTestCluster,Sleep,GetLead... | TestScheduler tests that the scheduler is running check scheduler config check if the config is in the expected config check if the command is a valid scheduler config balance - hot - region - scheduler - shuffle - region - scheduler - show - roles - test hot region scheduler balance - hot - region - scheduler - config... | The `QueryPriority` is `qps` while there is `query` here. |
@@ -156,5 +156,9 @@ public abstract class AbstractRatpackHttpClientTest extends AbstractHttpClientTe
options.disableTestReusedRequest();
options.enableTestReadTimeout();
+
+ if (!Boolean.getBoolean("testLatestDeps")) {
+ options.disableTestHttps();
+ }
}
}
| [AbstractRatpackHttpClientTest->[buildHttpClient->[buildHttpClient]]] | Configures the HTTP connection options. | just confirming, https tests worked in 1.4.0 but not in 1.4.1? |
@@ -21,4 +21,14 @@ public interface MessageSource
* when a message is received or generated.
*/
void setListener(MessageProcessor listener);
+
+ default boolean isCompatibleWithAsync()
+ {
+ return true;
+ }
+
+ default String getCanonicalURI()
+ {
+ return null;
+ }
}
| [No CFG could be retrieved] | Set the message processor to be notified when a message is received. | Find alternative approach so we don't put this in the interace |
@@ -35,12 +35,7 @@ final class Configuration implements ConfigurationInterface
->scalarNode('title')->defaultValue('')->info('The title of the API.')->end()
->scalarNode('description')->defaultValue('')->info('The description of the API.')->end()
->scalarNode('version'... | [Configuration->[addFormatSection->[end],getConfigTreeBuilder->[root,addFormatSection,end]]] | Returns a TreeBuilder instance for the API configuration. Adds the tree builder configuration for a . | we need to update the doc accordingly as well |
@@ -1941,7 +1941,6 @@ func genPulumiPluginFile(pkg *schema.Package) ([]byte, error) {
plugin := &plugin.PulumiPluginJSON{
Resource: true,
Name: pkg.Name,
- Version: "${PLUGIN_VERSION}",
Server: pkg.PluginDownloadURL,
}
return plugin.JSON()
| [resourceType->[modNameAndName],genInit->[hasTypes,genHeader,unqualifiedImportName,submodulesExist,isEmpty,fullyQualifiedImportName],pyType->[pyType,resourceType],isEmpty->[isEmpty],walkSelfWithDescendants->[walkSelfWithDescendants],fullyQualifiedImportName->[fullyQualifiedImportName,unqualifiedImportName],genMethods->... | genPackageMetadata generates the package metadata for a non - code package. Package name - > InstallPluginCommand. | Nice. I like this. Now, when this codegen change is adopted by the providers we aren't forced to make a change to the `Makefile` to search/replace this value. We can do it at our leisure. And we can use `jq` to add the `version` property. I do think we'll end up wanting to update our provider `Makefiles` to do this, be... |
@@ -48,13 +48,7 @@ import org.apache.zeppelin.interpreter.InterpreterSetting;
import org.apache.zeppelin.interpreter.remote.RemoteAngularObjectRegistry;
import org.apache.zeppelin.interpreter.remote.RemoteInterpreterProcessListener;
import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion;
-import org.apa... | [NotebookServer->[pushAngularObjectToRemoteRegistry->[broadcastExcept],broadcastInterpreterBindings->[broadcast],onRemove->[broadcast,notebook],generateNotesInfo->[notebook],updateParagraph->[permissionError,getOpenNoteId,broadcastParagraph],onLoad->[broadcast],unicastNoteList->[generateNotesInfo,unicast],clearAllParag... | Imports a single object from the Zeppelin library. Imports all packages that are required by the Zeppelin scheduler. | Actually Zeppelin doesn't recommend using `*`. So if you missed `import org.apache.zeppelin.notebook.Folder` before, will be better to add it only I think :) |
@@ -80,12 +80,12 @@ var _ = g.Describe("[Feature:Platform][Smoke] Managed cluster should", func() {
// gate on all clusteroperators being ready
available := make(map[string]struct{})
- for _, group := range []string{"config.openshift.io", "operatorstatus.openshift.io"} {
+ for _, group := range []string{"conf... | [By,Resource,IsObjxMapSlice,Expect,HaveOccurred,NewForConfig,It,LoadConfig,Flush,InterSlice,JSON,Logf,PollImmediate,NewWriter,LoadClientset,Join,Failf,UnstructuredContent,Get,Map,NotTo,Namespaces,Describe,IsInterSlice,Fprintf,Sprintf,ObjxMapSlice,List,Core,GinkgoRecover,String,IsNotFound,Skipf] | Check if a cluster version is already available and if so return it. map returns a map of all cluster operators in the group. | I still think this is a reasonable change though. |
@@ -145,4 +145,14 @@ public class SetBuildDescriptionCommandTest {
assertThat(result.stderr(), containsString("ERROR: No such build #2"));
}
+ //TODO: determine if this should be pulled out into JenkinsRule or something
+ /**
+ * Create a script based builder (either Shell or BatchFile) depend... | [SetBuildDescriptionCommandTest->[setBuildDescriptionShouldFailWithoutJobReadPermission->[failedWith,invokeWithArgs,stderr,containsString,hasNoStandardOutput,createFreeStyleProject,getLog,Shell,add,assertThat],setBuildDescriptionShouldFailWithoutRunUpdatePermission1->[failedWith,invokeWithArgs,stderr,containsString,has... | This test tests whether the build description should be set to fail if the build does not exist. | The XShell plugin provides something like this. It takes a command line and attempts to map it to Windows or Linux as appropriate. |
@@ -839,6 +839,7 @@ class TestSecuredVmMigration(cloudstackTestCase):
@classmethod
def tearDownClass(cls):
+ time.sleep(120)
cls.apiclient = super(TestSecuredVmMigration, cls).getClsTestClient().getApiClient()
try:
cleanup_resources(cls.apiclient, cls._cleanup)
| [TestSecuredVmMigration->[updateConfiguration->[updateConfiguration],test_02_unsecure_vm_migration->[get_target_host,unsecure_host,deploy_vm,migrate_and_check],migrate_and_check->[check_migration_protocol],test_04_nonsecured_to_secured_vm_migration->[unsecure_host,deploy_vm,migrate_and_check],test_03_secured_to_nonsecu... | Tear down the class and cleanup resources. | I'm not a fan of implicit waits, there must be a reason to put here and there 2min wait, let's try to convert these waits to explicit style and wait for the particular condition than just some bond of time. Let me know per each individual sleep what you're after and we could define a method to chase it. |
@@ -79,7 +79,8 @@ module.exports = UpgradeGenerator.extend({
this.log(`Regenerating application with JHipster ${version}...`);
let generatorCommand = 'yo jhipster';
if (semver.gte(version, FIRST_CLI_SUPPORTED_VERSION)) {
- generatorCommand = this.clientPackageManager === 'yarn' ? '... | [No CFG could be retrieved] | This function is responsible for generating the application with JHipster Check if the node package has a version number and if so generate it. | Please change ` { silent: true }` to ` { silent: this.silent }` so that the `--verbose` flag will print the result of the command (this is how the rest of the shelljs commands in this file are set up) |
@@ -43,7 +43,11 @@ def parse(source: Union[str, bytes], fnam: str = None, errors: Errors = None,
"""
is_stub_file = bool(fnam) and fnam.endswith('.pyi')
try:
- ast = typed_ast.parse(source, fnam, 'exec')
+ if pyversion[0] == 3 or is_stub_file:
+ ast = ast35.parse(source, fnam, 'e... | [TypeConverter->[visit_Str->[parse_type_comment]],parse->[parse],ASTConverter->[visit_With->[as_block],visit_Assign->[parse_type_comment],stringify_name->[stringify_name],visit_Call->[is_star2arg,is_stararg],visit_While->[as_block],transform_args->[make_argument],visit_If->[as_block],visit_Try->[as_block],visit_Module-... | Parse a source file without doing any semantic analysis. | I'd assert that pyversion[0] == 2 here, or else use >= 3 two lines up (which is what every other pyversion test in mypy uses). |
@@ -50,6 +50,7 @@ class DBA
self::$db_name = $db;
self::$db_charset = $charset;
+ $port = false;
$serveraddr = trim($serveraddr);
$serverdata = explode(':', $serveraddr);
| [DBA->[lastInsertId->[lastInsertId],close->[close],fetch->[fetch],rollback->[rollback],columnCount->[columnCount]]] | Connect to a database using the specified parameters. This method creates a new mysqli object. | Why not initialize with `0`? |
@@ -39,6 +39,7 @@ import javax.annotation.Nonnull;
import javax.annotation.concurrent.GuardedBy;
import jenkins.model.Jenkins;
import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.DoNotUse;
import org.kohsuke.accmod.restrictions.NoExternalUse;
/**
| [AsynchronousExecution->[setExecutor->[completedAsynchronous],completed->[completedAsynchronous],Throwable]] | PUBLIC METHODS IN THE SOFTWARE This method is used to import a single object A task that is not in the queue or in a sub - queue. | unused, but not a big problem |
@@ -236,6 +236,9 @@ class HelpInfoExtracter:
scope_to_help_info = {}
name_to_goal_info = {}
for scope_info in sorted(options.known_scope_to_info.values(), key=lambda x: x.scope):
+ if scope_info.scope.startswith("_"):
+ # Exclude "private" subsystems.
+ ... | [HelpInfoExtracter->[get_option_scope_help_info->[OptionScopeHelpInfo],get_all_help_info->[HelpInfoExtracter,AllHelpInfo,create,GoalHelpInfo],get_option_help_info->[compute_choices,compute_default,OptionHelpInfo,stringify_type,compute_metavar],compute_metavar->[stringify_type]],TargetTypeHelpInfo->[create->[create]],pr... | Get help info for all the options and all the goals. AllHelpInfo for the given NestedNode. | This is to hide the `__no_goal` and `__unknown_goal` built in goals from help output. |
@@ -305,12 +305,12 @@ func (b *BulletproofTxManager) CreateEthTransaction(newTx NewTx, qs ...pg.QOpt)
return err
}
err := tx.Get(&etx, `
-INSERT INTO eth_txes (from_address, to_address, encoded_payload, value, gas_limit, state, created_at, meta, subject, evm_chain_id, min_confirmations, pipeline_task_run_id, ... | [runLoop->[Start],Start->[Start],OnNewLongestChain->[OnNewLongestChain],Close->[Close],SignTx->[SignTx],SignTx] | CreateEthTransaction creates a new Ethereum transaction. CreateEthTransaction creates a new transaction in the chain. | Ditto here on line length. |
@@ -473,7 +473,7 @@ export class AmpForm {
return this.doActionXhr_();
})
.then(response => this.handleXhrSubmitSuccess_(
- /* !../../../src/service/xhr-impl.FetchResponse */ response),
+ /* !../../../src/utils/xhr-utils.FetchResponse */ response),
... | [No CFG could be retrieved] | Handles the submit of an AJAX request. The submitting action is called when the user submit the form. | `/* @type {...} */` |
@@ -212,6 +212,9 @@ public final class HddsVolumeUtil {
} else {
// The hdds root dir should always have 2 files. One is Version file
// and other is SCM directory.
+ logger.error("The hdds root dir {} should always have 2 files. " +
+ "One is Version file and other is SCM directory... | [HddsVolumeUtil->[getProperty->[InconsistentStorageStateException,isBlank,getProperty],getVersionFile->[File],getHddsRoot->[getPath,File,endsWith],checkVolume->[error,getHddsRootDir,format,listFiles,mkdir,exists,File,getAbsolutePath,getPath],getDatanodeUUID->[InconsistentStorageStateException,getProperty,equals],genera... | Checks if the given HDDS volume is consistent with the given cluster ID and if it. | Let's add a more actionable message: "Please remove any other extra files from the directory so that DataNode startup can proceed." |
@@ -1585,6 +1585,7 @@ class ArchiveFormatter(BaseFormatter):
'archive': remove_surrogates(archive.name),
'id': bin_to_hex(archive.id),
'time': format_time(to_localtime(archive.ts)),
+ 'start': format_time(to_localtime(archive.ts)),
}
@staticmethod
| [load_pattern_file->[parse_add_pattern],get_cache_dir->[write,get_home_dir],BaseFormatter->[format_item->[get_item_data]],Location->[to_key_filename->[get_keys_dir],parse->[get,replace_placeholders,match],_parse->[match,normpath_special],__init__->[parse]],get_security_dir->[get_home_dir],json_print->[json_dump],open_i... | Return a dict of the data of a . | wondering about why it needs same value as in "time". also, if there is start, where is end? |
@@ -206,7 +206,16 @@ func (s *scheduler) addNewConfigs(now time.Time, cfgs map[string]configs.Version
hasher := fnv.New64a()
for userID, config := range cfgs {
- rulesByFilename, err := config.Config.Parse()
+ rulesByGroup := map[string][]rules.Rule{}
+ var err error
+ switch s.ruleFormatVersion {
+ case con... | [workItemDone->[addWorkItem,Defer],addNewConfigs->[computeNextEvalTime]] | addNewConfigs adds new configs to the scheduler. Unlock the lock and set the total count of all config items. | Maybe factor this switch out to a function in `config`, so we don't have to edit this file when v3 is added? (And it would help keep down the complexity of this function) |
@@ -31,10 +31,12 @@ func (p *periodic) Start() error {
WORK:
for {
+ t := time.NewTimer(p.period)
select {
case <-p.done:
+ t.Stop()
break WORK
- case <-time.After(p.period):
+ case <-t.C:
}
if err := p.work(); err != nil {
| [Start->[After,work,Debugf],work->[Invalidate,Reset,Join,Update,New,Watch,discover,Info,Debugf],New] | Start starts periodic reading of configuration. | I think using `defer t.Stop()` below the `t := time.NewTimer(p.period)` is more future proof and more golang like. That way if a new case is ever added to the select then `t.Stop()` will already be handled. |
@@ -63,11 +63,3 @@ class Draco(CMakePackage):
'-DBUILD_TESTING={0}'.format('ON' if self.run_tests else 'OFF')
])
return options
-
- @run_after('build')
- @on_package_attributes(run_tests=True)
- def check(self):
- """Run ctest after building project."""
-
- with wor... | [Draco->[url_for_version->[format],check->[working_dir,ctest],cmake_args->[format,extend],depends_on,version,on_package_attributes,variant,run_after]] | Return a list of options for ctest. | Why was the test removed? Is `make test` equivalent? |
@@ -30,6 +30,13 @@ def freeview_bem_surfaces(subject, subjects_dir, method):
"""
subjects_dir = get_subjects_dir(subjects_dir, raise_error=True)
+ if subject is None:
+ raise ValueError("subject argument is None.")
+ if not op.isdir(op.join(subjects_dir, subject)):
+ raise ValueError("Wr... | [freeview_bem_surfaces->[print,get_subjects_dir,copy,run_subprocess,join,RuntimeError],run->[parse_args,get,get_subjects_dir,get_optparser,add_option,freeview_bem_surfaces],run] | View 3 - Layer BEM model with Freeview. find - node - id - node - id - node - id - node - id -. | I would use a variable to store `op.join(subjects_dir, subject)` so to avoid duplicating the function call. thanks |
@@ -71,6 +71,7 @@ class PlotObject(HasProps):
session = Instance(".session.Session")
name = String()
+ tag = List(Any)
def __init__(self, **kwargs):
# Eventually should use our own memo instead of storing
| [PlotObject->[set_select->[select],vm_serialize->[vm_props],references->[collect_plot_objects],collect_plot_objects->[descend->[descend,descend_props],descend],dump->[references,dump]],Viewable->[get_class->[_preload_models]]] | Initialize the object with a object. | Tags are purely intended to be arbitrary queryable user-supplied metadata, so I hope you agree that the use of `Any` here is appropriate. |
@@ -380,8 +380,7 @@ class SignupView(BaseSignupView):
get_adapter().stash_verified_email(self.request,
email_address['email'])
- with transaction.commit_on_success():
- form.save(self.request)
+ form.save(self.request)
... | [my_profile_edit->[redirect],profile_view->[get_team_roles_managed_by,int,render,wiki_activity,Paginator,is_anonymous,get,len,filter,page,exclude,all_sorted,get_object_or_404],ban_user->[render,UserBan,redirect,UserBanForm,get,is_valid,save],profile_edit->[redirect,is_subscribed,join,remove,all_ns,UserProfileEditForm,r... | This view is called when the user is submitting a new confirmation form. It is called Get a from the SocialAccount model. | This makes the whole process stateful but while looking at the code in allauth that's a requirement anyways, e.g. some code checks for the existence of users. |
@@ -292,8 +292,9 @@ class ExpressionChecker(ExpressionVisitor[Type]):
def check_typeddict_call_with_kwargs(self, callee: TypedDictType,
kwargs: 'OrderedDict[str, Expression]',
context: Context) -> Type:
- if callee.items.key... | [ExpressionChecker->[visit_star_expr->[accept],analyze_ordinary_member_access->[analyze_ref_expr],visit_await_expr->[accept],erased_signature_similarity->[check_argument_count,check_argument_types],check_op->[_check_op_for_errors,check_op_local],replace_tvars_any->[replace_tvars_any],visit_enum_call_expr->[accept],chec... | Checks that a TypedDict call has the expected values. | This blank line irks me. |
@@ -100,8 +100,9 @@ func CreateBlameReader(repoPath, commitID, file string) (*BlameReader, error) {
}
func createBlameReader(dir string, command ...string) (*BlameReader, error) {
- // FIXME: graceful: This should have a timeout
- ctx, cancel := context.WithCancel(DefaultContext)
+ // This timeout was arbitrarily c... | [Close->[GetManager,Remove,Errorf,cancel,Wait],NextPart->[Scan,FindStringSubmatch,Text],GetManager,Sprintf,NewScanner,WithCancel,Close,Start,StdoutPipe,Errorf,CommandContext,MustCompile,Add] | CreateBlameReader creates a BlameReader for the given repository commit and file. | Maybe use git command timeout setting? |
@@ -340,8 +340,12 @@ class TempDirTestCase(unittest.TestCase):
def handle_rw_files(_, path, __):
"""Handle read-only files, that will fail to be removed on Windows."""
- os.chmod(path, stat.S_IWRITE)
- os.remove(path)
+ filesystem.chmod(path, stat.S_IWRITE)
+ ... | [FreezableMock->[__setattr__->[__setattr__],__getattribute__->[__getattribute__]],_create_get_utility_mock->[FreezableMock,freeze],load_cert->[_guess_loader,load_vector],make_lineage->[vector_path],load_rsa_private_key->[_guess_loader,load_vector],_create_get_utility_mock_with_stdout->[mock_method->[_write_msg],Freezab... | Execute after a test. | Can you explain why this is needed? My initial reaction is the change to use `filesystem.chmod` should just work. |
@@ -80,7 +80,9 @@ func (s *VirtualMachineConfigSpec) AddVirtualDisk(device *types.VirtualDisk) *Vi
VirtualDeviceFileBackingInfo: types.VirtualDeviceFileBackingInfo{
// XXX This needs to come from a storage helper in the future
// and should not be computed here like this.
- FileName: s.Datastore.Path(f... | [RemoveVirtualDisk->[End,ID,RemoveAndDestroyVirtualDevice,Begin],AddVirtualDisk->[Reference,ID,Path,Begin,Sprintf,NewBool,ParentImageID,End,GetVirtualDevice,AddAndCreateVirtualDevice,generateNextKey,ImageStoreName],End,GetVirtualController,Begin] | AddVirtualDisk adds a virtual disk to the VM. | Just a note - this is the hack that will be moved into Storage.Join |
@@ -72,3 +72,10 @@ Rails.application.configure do
config.action_mailer.asset_host = "http://#{app_host}"
config.action_mailer.perform_deliveries = true
end
+
+# Listen changes in I18n files and export JS file automatically
+listener = Listen.to('config/locales') do |modified, added, removed|
+ I18n::JS.export
+... | [fetch,perform_deliveries,file_watcher,check_yarn_integrity,raise_delivery_errors,headers,consider_all_requests_local,asset_host,cache_classes,deprecation,exist?,verbose_query_logs,to_i,migration_error,debug,delivery_method,eager_load,default_url_options,cache_store,perform_caching,quiet,configure,smtp_settings] | Set the action mailer asset host. | 1 trailing blank lines detected. |
@@ -84,7 +84,15 @@ public class HealthCheckAgent {
));
final boolean allHealthy = results.values().stream()
.allMatch(HealthCheckResponseDetail::getIsHealthy);
- return new HealthCheckResponse(allHealthy, results);
+ final Map<String, Set<TaskMetadata>> metadata = ksqlClient
+ .m... | [HealthCheckAgent->[checkHealth->[toMap,HealthCheckResponse,collect,check,allMatch],CommandRunnerCheck->[check->[HealthCheckResponseDetail,checkCommandRunnerStatus],requireNonNull],KafkaBrokerCheck->[check->[HealthCheckResponseDetail,error,getRootCause,get,info,commandTopic],requireNonNull],ExecuteStatementCheck->[chec... | Check health. | I am not sure if the correct thing todo was this, I could maybe make a new endpoint but that seemed even more disruptive. Also does this query the one instance or the whole cluster. If it is the later we can have the health check just hit this instead of adding it to the health check response. |
@@ -131,8 +131,9 @@ func NewRuntime(ctx context.Context, options ...RuntimeOption) (runtime *Runtime
if err != nil {
return nil, err
}
+ runtime, err = newRuntimeFromConfig(ctx, conf, options...)
conf.CheckCgroupsAndAdjustConfig()
- return newRuntimeFromConfig(ctx, conf, options...)
+ return runtime, err
}
... | [GetOCIRuntimePath->[Path],mergeDBConfig->[Join,Errorf,Debugf],configureStore->[GetStore,NewImageRuntimeFromStore,SetStore],generateName->[LookupContainer,Cause,LookupPod,GetRandomName],Shutdown->[ID,Wrapf,Unlock,AllContainers,Shutdown,Close,Lock,StopWithTimeout,Errorf],GetConfig->[RUnlock,Wrapf,RLock],Info->[info],ref... | NewRuntime creates a new container runtime based on the given configuration file. returns the object. | Is this right? We're making the runtime before we finalize the config, looks like? |
@@ -273,8 +273,9 @@ public interface ValidatorLogger extends WeldLogger {
@Message(id = 1468, value = "Method {0} defined on class {1} is not defined according to the specification. It is annotated with @{2} but it does not have a {3} return type.\n\tat {4}\n StackTrace", format = Format.MESSAGE_FORMAT)
Defi... | [log->[decoratorEnabledForApplicationAndBeanArchive,interceptorEnabledForApplicationAndBeanArchive],construct->[interceptorSpecifiedTwice,injectionIntoNonBean,alternativeStereotypeSpecifiedMultipleTimes,decoratorSpecifiedTwice,alternativeClassSpecifiedMultipleTimes,injectionIntoDisposerMethod],LogMessageCallback,getMes... | Interceptor method is not defined according to the specification. It should not throw checked exceptions. | Why did you remove the stackElement part? |
@@ -49,7 +49,12 @@ public class RollbackNode extends DagNode<Option<HoodieInstant>> {
Option<HoodieInstant> lastInstant = metaClient.getActiveTimeline().getCommitsTimeline().lastInstant();
if (lastInstant.isPresent()) {
log.info("Rolling back last instant {}", lastInstant.get());
+ log.info("Clean... | [RollbackNode->[execute->[HoodieTableMetaClient,getName,rollback,isPresent,getTimestamp,get,getCfg,lastInstant,getConfiguration,info]]] | Rollback the last transaction in the transaction history. | looks like our rollback only supports rolling back the last commit. I assume we need to fix this in some later patch. |
@@ -185,11 +185,17 @@ func (c compositeStore) Stop() {
}
}
-func (c compositeStore) forStores(from, through model.Time, callback func(from, through model.Time, store Store) error) error {
+func (c compositeStore) forStores(ctx context.Context, userID string, from, through model.Time, callback func(ctx context.Cont... | [Stop->[Stop],DeleteChunk->[DeleteChunk],Get->[Get],PutOne->[PutOne],LabelValuesForMetricName->[LabelValuesForMetricName],DeleteSeriesIDs->[DeleteSeriesIDs],LabelNamesForMetricName->[LabelNamesForMetricName],GetChunkRefs->[GetChunkRefs]] | Stop stops all stores in the compositeStore. | This will break writes if we return an error here. I don't think we want that to happen. |
@@ -4,9 +4,11 @@ import PropTypes from 'prop-types';
import React, { Component } from 'react';
import { Watermarks } from '../../base/react';
+import { TranscriptionSubtitles } from '../../transcription/';
import Labels from './Labels';
+declare var config: Object;
declare var interfaceConfig: Object;
/**
| [No CFG could be retrieved] | The large video component which is rendered by a component which is rendered by a component which is DETAILS - DETAILS - DETAILS - DETAILS. | Just noticed this. config is actually available in redux. You can find it in `APP.store.getState()['features/base/config']`. It'd be preferred to get the value of disableTranscriptionSubtitles from redux if possible, so redux acts as the single source of app state. Conference is hooked to redux so you could pass it int... |
@@ -165,7 +165,10 @@ public class ValuesAction implements SettingsWsAction {
private Map<String, String> getKeysToDisplayMap(Set<String> keys) {
return keys.stream()
- .collect(Collectors.toMap(propertyDefinitions::validKey, Function.identity()));
+ .collect(Collectors.toMap(propertyDefinitions::val... | [ValuesAction->[ValuesResponseBuilder->[setInherited->[setInherited],setValue->[setValue],build->[build]]]] | Get the keys to display map. | I find it surprising to use the merge function to throw an exception. It's smart though : ) |
@@ -83,7 +83,10 @@ $yform->admin_header( true, 'wpseo_social' );
</p>
<p class="desc">
- <?php _e( 'Add Twitter card meta data to your site\'s <code><head></code> section.', 'wordpress-seo' ); ?>
+ <?php
+ /* translators: %s expands to <code><head></code> */
+ printf( __( 'Add Twitter card m... | [admin_header,media_input,textinput,checkbox,show_form,admin_footer,select] | List of all Open Graph meta tags List of all pinterest categories. | You left `class="desc"` here while you removed it in other places. Just checking if that was intentional. |
@@ -15,7 +15,10 @@ namespace NServiceBus.Core.Tests.Timeout
[SetUp]
public void Setup()
{
- persister = new InMemoryTimeoutPersister(() => DateTime.UtcNow);
+ //TODO: Should be reviewed after InMemory move
+#pragma warning disable CS0619
+ persister = new In... | [When_fetching_timeouts_from_storage_with_inMemory->[GetNextChunk->[GetNextChunk]]] | Setup method for TimeoutManager. | We need to use a acceptance testing persister here as well |
@@ -312,11 +312,12 @@ class Coder(object):
@classmethod
@overload
- def register_urn(cls,
- urn, # type: str
- parameter_type, # type: Optional[Type[T]]
- fn # type: Callable[[T, List[Coder], PipelineContext], Any]
- ):
+ def register_u... | [FastPrimitivesCoder->[as_cloud_object->[as_cloud_object],as_deterministic_coder->[DeterministicFastPrimitivesCoder,is_deterministic],is_deterministic->[is_deterministic],_create_impl->[get_impl],__init__->[PickleCoder]],ProtoCoder->[from_type_hint->[ProtoCoder]],_pickle_from_runner_api_parameter->[deserialize_coder],T... | Registers a urn with a constructor. | Is this yapf or some other auto-formatter? |
@@ -13,7 +13,8 @@ class ServiceProviderSeeder
active: true,
native: true,
friendly_name: config['friendly_name'])
- end.update!(config.except('restrict_to_deploy_env',
+ end.update!(config.except('agency',
+ 'restrict_to_d... | [ServiceProviderSeeder->[write_service_provider?->[present?],remote_setting->[contents],run->[each,except,write_service_provider?,update!],service_providers->[fetch,error,message,raise,read,result],initialize->[env],attr_reader]] | Runs a for each of the service providers in the system. | this means there's no urgency to updating identity-idp-config to remove the string agency attribute |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.