patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -565,6 +565,9 @@ class CheckoutLinesAdd(BaseMutation):
manager, checkout_info, lines, info.context.discounts
)
manager.checkout_updated(checkout)
+
+ invalidate_checkout_prices(checkout)
+
return CheckoutLinesAdd(checkout=checkout)
| [CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save,get_checkout_by_token]],CheckoutComplete->[perform_mutation->[CheckoutComplete,get_checkout_by_token]],CheckoutCreate->[save->[save],Arguments->[CheckoutCreateInput],clean_input->[retrieve_shipping_address,retrieve_billing_address,clea... | Perform a mutation of the n - node. | (Not if I already mention this) we should call invalidate_checkout_prices first. Then we should call checkout_updated. Price expiration should be updated in checkout's payload. Also, make sure that we really need an additional `save()` action only for price_expiration. Maybe we can call .save only once for price_expira... |
@@ -30,7 +30,7 @@ class EncryptedEmail
end
def fingerprint
- Pii::Fingerprinter.fingerprint(email)
+ Pii::Fingerprinter.fingerprint(email.downcase)
end
def stale?
| [EncryptedEmail->[try_decrypt->[new_user_access_key,decrypt],fingerprint->[fingerprint]]] | Returns the next non - nil user_access_key id that can be found in the. | are we consistent about downcasing emails? also, should we be? domains are case-insensitive, but email providers are allowed to have case-insensitive usernames IIRC |
@@ -427,6 +427,7 @@ public class HttpPostRequestDecoderTest {
// Create decoder instance to test without any exception.
final HttpPostRequestDecoder decoder = new HttpPostRequestDecoder(inMemoryFactory, req);
assertFalse(decoder.getBodyHttpDatas().isEmpty());
+ req.release();
... | [HttpPostRequestDecoderTest->[testDecodeFullHttpRequestWithUrlEncodedBodyWithBrokenHexByte1->[HttpPostRequestDecoder,getMessage,DefaultFullHttpRequest,release,directBuffer,getBytes,assertEquals,writeBytes,fail],testDecodeFullHttpRequestWithUrlEncodedBodyWithBrokenHexByte0->[HttpPostRequestDecoder,getMessage,DefaultFull... | Test multipart request without content type body. Creates a new request with the specified parameters. | seems like a leak in the test that was not related to your change... correct ? |
@@ -32,15 +32,12 @@ public class DbExplorerFactory {
// private static final String VENDOR_JDBC_ORACLE = "jdbc:oracle:";
// private static final String VENDOR_JDBC_MSSQL = "jdbc:sqlserver:";
- public static DbInfo getDbInfo(String txt, JDBCClient jdbcClient, String sessionId,
- ... | [DbExplorerFactory->[getDbCache->[DbRequestCache],getDbInfo->[getDbURI,printStackTrace,getDataSource,BeakerParser,getBeaker,MysqlDbExplorer,startsWith]]] | Get the DbInfo object for the given database. | do not reformat code that you are not changing |
@@ -3888,7 +3888,7 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
// * verify that there are no duplicates
if (hostNames.contains(hostName)) {
throw new InvalidParameterValueException("The vm with hostName " + hostName + " alrea... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],getNetworkForOvfNetworkMapping->[getDef... | Check if hostName is unique in the network domain. | this might yield an NPE hiding the original problem, no? |
@@ -442,7 +442,7 @@ class TestShutil(unittest.TestCase):
self.assertEqual(getattr(file1_stat, 'st_flags'),
getattr(file2_stat, 'st_flags'))
- @unittest.skipUnless(zlib, "requires zlib")
+ @unittest.skipUnless(zlib is not None, "requires zlib")
def test_make_tarbal... | [TestMove->[test_move_dir_to_dir->[_check_move_dir],setUp->[mkdtemp],test_move_file->[_check_move_file],test_move_file_to_dir_other_fs->[test_move_file_to_dir],test_move_file_to_dir->[_check_move_file],test_move_dir_other_fs->[test_move_dir],test_move_file_other_fs->[test_move_file],test_move_dir->[_check_move_dir],tes... | Test copy2. Checks if a tarball exists and if it does creates it. | For these I think the stub for skipUnless should take object, not bool. |
@@ -71,10 +71,8 @@ class CreateToken(BaseMutation):
@classmethod
def get_user(cls, info, data):
- user = authenticate(
- request=info.context, username=data["email"], password=data["password"],
- )
- if not user:
+ user = models.User.objects.filter(email=data["email"])... | [VerifyToken->[get_user->[get_user],get_payload->[get_payload],perform_mutation->[get_user,get_payload]],RefreshToken->[clean_refresh_token->[get_refresh_token_payload],get_user->[get_user],get_refresh_token_payload->[get_payload],perform_mutation->[clean_refresh_token,get_user,clean_csrf_token,get_refresh_token]],Crea... | Get user from credentials. | Maybe we should create utils function for that? |
@@ -207,7 +207,7 @@ class CarState(CarStateBase):
("Signal6", "ES_Distance", 0),
("Counter", "ES_LKAS_State", 0),
- ("Keep_Hands_On_Wheel", "ES_LKAS_State", 0),
+ ("LKAS_Alert_Msg", "ES_LKAS_State", 0),
("Empty_Box", "ES_LKAS_State", 0),
("Signal1", "ES_LKAS_State", 0... | [CarState->[get_can_parser->[CANParser],get_cam_can_parser->[CANParser],__init__->[super,CANDefine],update->[int,any,update_blinker_from_lamp,parse_gear_shifter,get,copy,update_speed_kf,new_message,abs]]] | Returns a list of all possible Cruise signals and checks for a given CP. This method is called from the Airflow. It is called by the Airflow get - Get the object from the CARFingerprint. | this doesn't exist in the new DBC |
@@ -503,7 +503,7 @@ public abstract class Proc {
/**
* An instance of {@link Proc}, which has an internal workaround for JENKINS-23271.
* It presumes that the instance of the object is guaranteed to be used after the {@link Proc#join()} call.
- * See <a href="https://issues.jenkins-ci.org/browse/JENKI... | [Proc->[RemoteProc->[join->[isAlive,kill],kill->[isAlive]],joinWithTimeout->[run->[kill],join],LocalProc->[join->[join,isAlive],environment->[environment],kill->[join]]]] | Debug switch to have the process display the process it s waiting for. | I am fine with that, but maybe makes no sense without jenkins.io |
@@ -1275,6 +1275,7 @@ class VersionSubmitUploadMixin(object):
assert doc('.addon-submit-distribute a').attr('href') == (
distribution_url + '?channel=' + channel_text)
+ @override_switch('beta-versions', active=True)
def test_beta_field(self):
response = self.client.get(self.url... | [TestAddonSubmitDetails->[test_set_privacy_nomsg->[is_success,get_addon,get_dict],test_submit_categories_max->[post,get_dict],test_submit_categories_add->[is_success,get_addon,get_dict],test_submit_categories_addandremove->[post,get_addon,get_dict],setUp->[get_addon],test_submit_success_optional_fields->[is_success,get... | Test that the distribution link is the same as the distribution link. | Needs a test where `beta-versions` is `False`. |
@@ -624,7 +624,7 @@ public class MapPanel extends ImageScrollerLargeView {
if (tile.isDirty()) {
undrawnTiles.add(tile);
} else if (forceInMemory) {
- images.add(tile.getRawImage());
+ images.add(tile);
}
}
}
| [BackgroundDrawer->[run->[getData,getUndrawnTiles]],RouteDescription->[hashCode->[hashCode],equals->[equals]],MapPanel->[setTopLeft->[setTopLeft],getInfoImage->[getInfoImage],print->[print],getHelpImage->[getHelpImage],setScale->[recreateTiles,setScale,getData],setTerritoryOverlayForBorder->[setTerritoryOverlayForBorde... | Update the list of undrawn tiles. | Not sure exactly what this is doing but caching the tile instead of raw image might not be good. |
@@ -80,6 +80,11 @@ class JitDecorator(ABC):
class Target(ABC):
""" Implements a hardware/pseudo-hardware target """
+ @classmethod
+ def inherits_from(cls, other):
+ """Returns True if this target inherits from 'other' False otherwise"""
+ return other in cls.__mro__
+
class Generic(Targe... | [resolve_dispatcher_from_str->[resolve_target_str],get_local_target->[current_target],HardwareRegistry] | Returns the current hardware target. Register the object to be used as a target for the NPyUfunc. | replace with `issubclass()` instead |
@@ -73,6 +73,12 @@ public class FilteringArtifactClassLoader extends ClassLoader implements Artifac
this.artifactClassLoader = artifactClassLoader;
this.filter = filter;
this.exportedServices = exportedServices;
+
+ verboseLogging = LOGGER.isDebugEnabled() || isVerboseLoggingEnabled();
+ }
+
+ priva... | [FilteringArtifactClassLoader->[findLocalResource->[findLocalResource],addShutdownListener->[addShutdownListener],loadInternalClass->[loadClass],getPackage->[getPackage],findLocalClass->[findLocalClass],getClassLoaderLookupPolicy->[getClassLoaderLookupPolicy],loadClass->[loadClass],findResources->[findResources],getArt... | Creates a new FilteringArtifactClassLoader. | this breaks the feature of changing log levels at runtime |
@@ -1126,6 +1126,7 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
$scope.$on('editorSetting', function(event, data) {
if (paragraph.id === data.paragraphId) {
deferred.resolve(data);
+ $scope.editor.setReadOnly(!$scope.userHasWritePermissi... | [No CFG could be retrieved] | Adds a function to the list that will be used to display the completion message. check if the current language is the magic and if so set it. | I worry this would leave it in an inconsistent state - UI showing the changed value, but it isn't saved |
@@ -148,7 +148,9 @@ public final class IntrospectionUtils {
public static MetadataType getMethodReturnAttributesType(Method method, ClassTypeLoader typeLoader) {
Type type = null;
- ResolvableType methodType = unwrapInterceptingCallback(method);
+ ResolvableType methodType = getMethodResolvableType(meth... | [IntrospectionUtils->[isVoid->[isVoid],isRequired->[isRequired],getAliasName->[getAliasName],checkInstantiable->[checkInstantiable],getExpressionSupport->[getExpressionSupport],getAnnotation->[getAnnotation],isInstantiable->[isInstantiable,hasDefaultConstructor],getField->[getField],isParameterContainer->[isMultiLevelM... | Gets the MetadataType for the given method. | attributes is not going to have a paging delegate |
@@ -2103,7 +2103,10 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
/**
* Binds {@link AdministrativeMonitor}s to URL.
+ * @param id Monitor ID
+ * @return The requested monitor or {@code null} if it does not exist
*/
+ @CheckForNull
public Administ... | [Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],_cleanUpCloseDNSMulticast->[add],getViewActions->[getActions],getJDK->[getJDKs,get],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[getActiveInsta... | Get AdministrativeMonitor with given id. | Fine but as above you do not need this method to look up a singleton. |
@@ -15,9 +15,15 @@ https://github.com/IntelLabs/ParallelAccelerator.jl
from __future__ import print_function, division, absolute_import
import types as pytypes # avoid confusion with numba.types
import sys, math
+import os
+import linecache
+import textwrap
+import copy
+import inspect
from functools import reduce... | [simplify_parfor_body_CFG->[simplify_parfor_body_CFG],remove_dead_parfor->[list_vars],repr_arrayexpr->[repr_arrayexpr],get_parfor_array_accesses->[unwrap_parfor_blocks,wrap_parfor_blocks],get_parfor_params_inner->[get_parfor_params],prod_parallel_impl->[prod_1->[init_prange,internal_prange]],min_parallel_impl->[min_1->... | The code for a single node in a nested loop. This function is a wrapper around the basic functions that are used in the numba. analysis. | rm linecache, not used |
@@ -157,7 +157,7 @@ func createCloudWatchEvents(getMetricDataResults []cloudwatch.MetricDataResult,
}
event.RootFields.Put("service.name", metricsetName)
- event.RootFields.Put("cloud.provider", metricsetName)
+ event.RootFields.Put("cloud.provider", "aws")
event.RootFields.Put("cloud.availability_zone", *insta... | [Fetch->[Error,GetStartTimeEndTime,GetMetricDataResults,New,Errorf,GetListMetricsOutput,Event,Wrap,Info],DefaultMetricSet,Itoa,NewLogger,Sprint,MarshalValue,MustAddMetricSet,New,NewMetricSet,EventMapping,Send,DescribeInstancesRequest,Wrap,Info,Split,Put] | Construct CloudWatch Events for ECS Result returns the event ID of the last result. | This is kind of a breaking change. Should we mention it in the changelog. |
@@ -266,6 +266,18 @@ _ph_free(struct dfuse_pool *dfp)
if (daos_handle_is_valid(dfp->dfp_poh)) {
rc = daos_pool_disconnect(dfp->dfp_poh, NULL);
+ /* Hook for fault injection testing, if the disconnect fails with out of memory
+ * then simply try it again, only what might have happened is that the first
+ * c... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - region D - Hash Table Implementation. | are there cases in the client pool disconnect execution flow that, following dc_pool_hdl_unlink(), could result in rc=-DER_NOMEM being returned to the daos_pool_disconnect() caller? I'm looking at the flow and having a hard time seeing where it can happen. |
@@ -128,11 +128,13 @@ type CommonSpec struct {
}
const (
- BuildTriggerCauseManualMsg = "Manually triggered"
- BuildTriggerCauseConfigMsg = "Build configuration change"
- BuildTriggerCauseImageMsg = "Image change"
- BuildTriggerCauseGithubMsg = "GitHub WebHook"
- BuildTriggerCauseGenericMsg = "Generic WebHook"... | [NewString] | Output BuildOutput creates a list of resources that can be used to execute a build on a. | Just a nit, it's Bitbucket not BitBucket (also other places in the pr) |
@@ -32,6 +32,10 @@ export class AbstractWallet {
return this.balance;
}
+ getPreferredBalanceUnit() {
+ return this.preferredBalanceUnit || BitcoinUnit.BTC;
+ }
+
allowReceive() {
return true;
}
| [No CFG could be retrieved] | The abstract wallet class. | oh its here. then its not needed in `class/abstract-hd-wallet.js` |
@@ -42,7 +42,11 @@ public class ColorPalette {
public static final Color GREY = new Color(0xAB,0xAB,0xAB);
public static final Color DARK_GREY = new Color(0x77,0x77,0x77);
public static final Color LIGHT_GREY = new Color(0xcc,0xcc,0xcc);
-
+ public static final Color MODERN_RED = new Color(204, 0,... | [ColorPalette->[apply->[setSeriesPaint],asList,Color,unmodifiableList]] | Color palette for Hudson categories. | I don't think that it is a good idea to introduce new colors here. I think before we do that we should discuss in the UX meeting how we continue with colors in general. From my perspective it makes sense to replace all colors from core with something that actually reuses the CSS variables we have. Then those colors wou... |
@@ -78,7 +78,8 @@ public class XmlFrameDecoderTest {
public void testDecodeWithInvalidContentBeforeXml() {
XmlFrameDecoder decoder = new XmlFrameDecoder(1048576);
EmbeddedChannel ch = new EmbeddedChannel(decoder);
- ch.writeInbound(Unpooled.copiedBuffer("invalid XML<foo/>", CharsetUtil.UTF... | [XmlFrameDecoderTest->[sample->[getResource,IllegalArgumentException,toURI,readAllBytes,get,toString],testDecodeWithSampleXml->[testDecodeWithXml],testDecodeWithFrameExceedingMaxLength->[EmbeddedChannel,writeInbound,XmlFrameDecoder,copiedBuffer],testDecodeWithCDATABlockContainingNestedUnbalancedXml->[testDecodeWithXml]... | This test decode with invalid content before xml. | Could you please keep the original formatting so that the changeset contains only the relevant changes? |
@@ -152,9 +152,8 @@ public class CommandTopicBackupImpl implements CommandTopicBackup {
void writeCommandToBackup(final ConsumerRecord<CommandId, Command> record) {
if (corruptionDetected) {
- LOG.warn("Failure to write command topic data to backup. "
- + "Corruption detected in command topic.")... | [CommandTopicBackupImpl->[close->[close],writeCommandToBackup->[isRestoring,isRecordInLatestReplay]]] | Writes a command to the backup file. | Would be good to use the same message here as the one in the LOG.warn(). |
@@ -54,7 +54,10 @@ public class WeldServletExtension implements ServletExtension {
// Listener injection
for (ListenerInfo listener : deploymentInfo.getListeners()) {
UndertowLogger.LOG.installingCdiSupport(listener.getListenerClass());
- listener.setInstanceFac... | [WeldServletExtension->[handleDeployment->[setAttribute,getInstanceFactory,of,getListeners,setInstanceFactory,getServletClass,getFilterClass,getListenerClass,installingCdiSupport,values],getName]] | This method is called when a deployment is started. | @darranl so, when exactly is `ImmediateInstanceFactory` used? Looking at UT code (which I don't know so I might be wrong), it looks like it's used for any dynamic component. That would mean this change is rather aggressive and will result in leaving all such instance creation to UT instead of trying to let Weld do it. ... |
@@ -86,9 +86,6 @@ public class TriggerStateMachinesTest {
RunnerApi.Trigger.newBuilder()
.setAfterEndOfWindow(RunnerApi.Trigger.AfterEndOfWindow.getDefaultInstance())
.build();
- AfterWatermarkStateMachine.FromEndOfWindow machine =
- (AfterWatermarkStateMachine.FromEndOfWind... | [TriggerStateMachinesTest->[testAfterAllTranslation->[of,build,equalTo,assertThat,stateMachineForTrigger],testAfterEachTranslation->[build,equalTo,assertThat,inOrder,stateMachineForTrigger],testAfterWatermarkEarlyLateTranslation->[withLateFirings,build,equalTo,assertThat,stateMachineForTrigger],testRepeatedlyTranslatio... | Test state machine for after watermark. | Kind of weird that this exact logic is written twice. I don't know the origin, but I wonder if it was an automatic refactor last time! |
@@ -69,8 +69,7 @@ class AnchorGenerator(nn.Module):
base_anchors = torch.stack([-ws, -hs, ws, hs], dim=1) / 2
return base_anchors.round()
- def set_cell_anchors(self, dtype, device):
- # type: (int, Device) -> None # noqa: F821
+ def set_cell_anchors(self, dtype: torch.dtype, device: t... | [AnchorGenerator->[forward->[set_cell_anchors,cached_grid_anchors],set_cell_anchors->[generate_anchors],cached_grid_anchors->[grid_anchors]]] | Generate cell anchors. | Unclear why `dtype` is declared as `int` and `device` as `Device` instead of `torch.device`. |
@@ -2536,7 +2536,12 @@ class H2OFrame(object):
plt.xlabel(self.names[0])
plt.ylabel("Frequency")
plt.title("Histogram of %s" % self.names[0])
- plt.bar(left=lefts, width=widths, height=counts, bottom=0)
+
+ try:
+ plt.bar(left=lefts, width=widt... | [_getValidCols->[type],_binop->[_expr,moment],H2OFrame->[var->[_expr],sinpi->[_unop],relevel->[_expr],substring->[_expr],hist->[pop,show,hist,_expr],topNBottomN->[_expr],set_level->[_expr],tokenize->[_expr],moment->[type,_expr],cummax->[_expr],sum->[pop,_expr],gsub->[_expr],log2->[_unop],toupper->[_expr],atan->[_unop],... | Compute a histogram over a numeric column. Plots a histogram of the nanoseconds in the first column of the histogram. | Can we make the decision based on `matplotlib.__version__` instead? IMHO that is a bit more obvious (and future proof). |
@@ -859,13 +859,14 @@ class WorkerOptions(PipelineOptions):
'subnetwork name. For more information, see '
'https://cloud.google.com/compute/docs/vpc/'))
parser.add_argument(
+ '--sdk_container_image',
'--worker_harness_container_image',
+ dest='sdk_container_image',... | [TestOptions->[validate->[view_as]],PipelineOptions->[__getattr__->[_visible_option_list],__dir__->[_visible_option_list],__init__->[_BeamArgumentParser],__setattr__->[_visible_option_list],display_data->[get_all_options],get_all_options->[_BeamArgumentParser,_add_argparse_args],__str__->[_visible_option_list]],TypeOpt... | Adds arguments related to the given to the given argparse parser. Adds arguments related to a to the command line. Adds a warning if a node is missing in the replacement container image. | Any reason to use `sdk_container_image` not `sdk_harness_container_image`? The term `sdk_harness_container` is already used in the option `--sdk_harness_container_image_overrides` below. I think it would be better to use the same one for the both options (either `sdk_harness_container_image` here or `sdk_container_imag... |
@@ -131,6 +131,8 @@ import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
+import static org.apache.druid.sql.calcite.planner.PlannerConfig.CTX_KEY_USE_GROUPING_SET_FOR_EXACT_DISTINCT;
+
@RunWith(JUnitParamsRunner.class)
public class CalciteQueryTest extends BaseCalciteQueryTest
{
| [CalciteQueryTest->[testMaxSubqueryRows->[expectMessage,testQuery,expect,of],testGroupByLimitPushdownExtraction->[testQuery,cannotVectorize,build,of],testOrderByAnyFloat->[testQuery,replaceWithDefault,build,of],testCountStarWithTimeAndDimFilter->[testQuery,build,of],testTimeseriesWithLimitAndOffset->[testQuery,build,of... | Imports a single object from the System. This method checks if the given object is not null and if it is selected from a table. | iirc, I think we typically prefer to not use static imports, I know this is enforced in some places, but maybe not in test code because of some junit stuffs? |
@@ -866,7 +866,15 @@ Spdp::handle_auth_request(const DDS::Security::ParticipantStatelessMessage& msg)
// We're simply caching this for later, since we can't actually do much without the SPDP announcement itself
pending_remote_auth_tokens_[guid] = msg.message_data[0];
} else {
- iter->second.remote_auth_... | [No CFG could be retrieved] | DDS - specific functions If this message is a handshake message and the source participant is the same as the destination participant. | Doesn't this need to check the auth state / handshake state before sending off a handshake request? Currently, it seems like this path can circumvent calling validate_remote_identity before sending the handshake request, which seems contrary to the state machine in Figure 9 of the security spec. |
@@ -856,8 +856,13 @@ class TokenNetwork:
raise ValueError(msg)
with self.channel_operations_lock[partner]:
+ # gaslimit below must be defined
+ raise NotImplementedError('feature temporarily disabled')
+
+ gas_limit = None
transaction_hash = self.pro... | [TokenNetwork->[all_events_filter->[events_filter],update_transfer->[channel_is_settled,detail_channel],_check_for_outdated_channel->[detail_channel],_check_channel_state_for_deposit->[_get_channel_state,detail_participants],detail_participants->[ParticipantsDetails,_inspect_channel_identifier,detail_participant],unloc... | Withdraw a number of withdrawn nodes in a channel. set total withdrawal. | I'm torn about raising an unrecoverable error here: If this is to guard developers from calling this code path, I would rather raise it at the head of `withdraw(...)`. If it is really only about the missing gas_limit definition, then I would only issue a warning and not let the client crash. Generally speaking, I assum... |
@@ -1037,6 +1037,12 @@ func CompareAndPullRequestPost(ctx *context.Context) {
return
}
+ if len(form.Title) > 255 {
+ form.Content = "..." + form.Title[252:] + "\n\n" + form.Content
+ form.Title = form.Title[:252] + "..."
+ }
+ middleware.AssignForm(form, ctx.Data)
+
ctx.HTML(http.StatusOK, tplCompar... | [Status,GetIssueByIndex,IsPoster,ConstantTimeCompare,Merge,Redirect,IsErrRepoNotExist,GetOwner,IsErrIssueNotExist,ValidateCommitsWithEmails,GetRepositoryByID,GetSquashMergeCommitMessages,GetUserRepoPermission,GetAssignees,HomeLink,Len,IsErrReviewNotExist,IsErrUserDoesNotHaveAccessToRepo,NotifyPullRequestChangeTargetBra... | Determines if a user has a diff or not and if it has a pull request and if missing - label - pull - request. | same here should be changed then |
@@ -161,14 +161,14 @@ class SGD(object):
self.__parameter_updater__.update(each_param)
cost_sum = out_args.sum()
cost = cost_sum / len(data_batch)
- self.__parameter_updater__.finishBatch(cost)
- batch_evaluator.finish()
... | [SGD->[train->[__prepare_parameter__],test->[__prepare_parameter__],__prepare_parameter__->[__use_remote_sparse_updater__]]] | Train a single n - dimensional network using a reader that reads and yeilds data Batch processing of . | Just a little confusing, why we move the `batch_evaluator` to the `event_handler`? |
@@ -41,6 +41,10 @@ module Engine
@log << "#{entity.name} runs a #{train.name} train for #{revenue}: #{route.revenue_str}"
end
pass!
+
+ return unless (route = @round.routes.first)
+
+ route.abilities.each { |type| @game.abilities(action.entity, type)&.use! }
end
... | [Route->[process_run_routes->[operated,train,owner,entity,revenue,format_currency,raise,pass!,each,name,routes,revenue_str],actions->[can_run_route?,empty?,operator?],help->[name,receivership?],available_hex->[reachable_hexes],freeze],require_relative] | Process run routes and log any errors. | this doesn't look correct? why do you only use one route? |
@@ -917,6 +917,9 @@
<configuration>
<!-- Force alphabetical order to have a reproducible build -->
<runOrder>alphabetical</runOrder>
+ <!-- Fixes a bug which will be solved in next version after 2.22.1 then this can be removed -->
+ ... | [No CFG could be retrieved] | XmlElement for all of the elements of the given object. This is the main entry point for unit tests. | Does the formatting only look not correct in the diff view or are there a few more spaces required? |
@@ -68,9 +68,7 @@ setup(
author='HeikoHeiko',
author_email='heiko@brainbot.com',
url='https://github.com/raiden-network/raiden',
- packages=find_packages(
- exclude=["raiden.tests", "raiden.tests.*"]
- ),
+ packages=find_packages(),
include_package_data=True,
license='BSD',
... | [PyTest->[run_tests->[SystemExit,main],finalize_options->[finalize_options]],CompileContracts->[run->[instantiate]],find_packages,setup,list,lstrip,get,read,set,strip,open] | This function is called by the install_requires_replacements method. Missing entry point for the n - node package. | The only thing I don't feel too comfortable with is including also test packages in the release. I understand the reasoning behind it, since we want it to use in the smoke tests but still I feel a bit uncomfortable with it. |
@@ -892,7 +892,14 @@ Object.assign(frappe.utils, {
hide_seconds: docfield.hide_seconds
};
return duration_options;
- }
+ },
+
+ generate_route: generate_route,
+
+ shorten_number: shorten_number,
+
+ get_number_system: get_number_system,
+
});
// Array de duplicate
| [No CFG could be retrieved] | Creates an object that represents a duration in minutes. Private functions - functions - functions - functions - functions - functions - functions - functions. | Why not move the implementation of these generic utilities here where they belong? |
@@ -1967,11 +1967,11 @@ export class Resources {
if (resource.getState() == ResourceState.NOT_BUILT) {
resource.whenBuilt().then(() => {
this.measureAndScheduleIfAllowed_(resource, layout,
- parentResource.getPriority());
+ parentResource.getLayoutPriority());
... | [No CFG could be retrieved] | Schedules layout or preload for the specified sub - resources of the specified parent resource. Schedules a task if the given object is present. | Looks like priority is also used for preload in addition to layout. I'm okay with this change but another option is to just update the jsdoc to more clearly spell this out in custom-element.js and base-element.js. |
@@ -149,6 +149,14 @@ public class SparkInterpreter extends Interpreter {
this.sc = sc;
env = SparkEnv.get();
sparkListener = setupListeners(this.sc);
+
+ this.singleThreadedExecutorSerivce = createSingleThreadExecutorService();
+ }
+
+ private ExecutorService createSingleThreadExecutorService() {
+ ... | [SparkInterpreter->[createSparkSession->[useHiveContext,isYarnMode,hiveClassesArePresent],interpretInput->[interpret],getSQLContext_1->[useHiveContext,getSparkContext],setupListeners->[onJobStart->[onJobStart]],populateSparkWebUrl->[toString,getSparkUIUrl],setupConfForPySpark->[isYarnMode],getCompletionTargetString->[t... | Get the SparkContext instance. | Why not using `Executors.newSingleThreadExecutor()` |
@@ -1396,7 +1396,7 @@ void OpcodeTable::Initialize()
/*0x4FD*/ DEFINE_SERVER_OPCODE_HANDLER(SMSG_LOOT_SLOT_CHANGED, STATUS_NEVER);
/*0x4FE*/ DEFINE_HANDLER(UMSG_UPDATE_GROUP_INFO, STATUS_NEVER, PROCESS_INPLACE, &WorldS... | [No CFG could be retrieved] | Registers handlers for all messages in the session. Registers message handlers for all messages in the session. | What determines if it should be inplace/threadsafe/threadunsafe? |
@@ -419,8 +419,9 @@ collisionMoveResult collisionMoveSimple(Environment *env, IGameDef *gamedef,
// A fairly large value in here makes moving smoother
//f32 d = 0.15*BS;
- // This should always apply, otherwise there are glitches
- assert(d > pos_max_d); // invariant
+ f32 d = 0.0f; // Temporary fix, any nonzero ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Find nearest collision of the two boxes. | None of this applies anymore does it? If so it should be removed. |
@@ -165,13 +165,14 @@ describes.realWin('amp-video', {
}, sources)).to.be.rejectedWith(/start with/);
});
- it('should set poster and controls in prerender mode', () => {
+ it('should set poster, controls, controlsList in prerender mode', () => {
return getVideo({
src: 'video.mp4',
width:... | [No CFG could be retrieved] | Checks that a video has the correct attributes. Checks that video has appropriate src preload and poster attributes. | isn't it `noremoteplayback` ? |
@@ -403,7 +403,7 @@ RSpec.describe OpenidConnectTokenForm do
expect(submission.to_h).to include(
success: false,
errors: form.errors.messages,
- error_details: hash_including(*form.errors.keys),
+ error_details: hash_including(*form.errors.attribute_names),
cl... | [create,new,let,to_not,describe,issuer,ago,end_with,subject,delete_all,it,put,map,to,link_identity,of,save!,before,url_helpers,base64digest,oidc_public_key,let!,t,require,submit,include,to_i,except!,update,have_key,hex,read,session_uuid,delete,context,messages,hash_including,keys,uuid,urlsafe_encode64,access_token,deco... | It describe what it says and what it says. This is a basic check that the server has a public key. | This change is for ...? The deprecation warning? I hadn't noticed that previously. Should we handle that separately from these changes? I could make a pass at it, since I was the one who'd introduced them in #5048. |
@@ -39,9 +39,7 @@ public class DefaultHttpObject implements HttpObject {
@Override
public void setDecoderResult(DecoderResult decoderResult) {
- if (decoderResult == null) {
- throw new NullPointerException("decoderResult");
- }
+ ObjectUtil.checkNotNull(decoderResult, "decod... | [DefaultHttpObject->[getDecoderResult->[decoderResult],hashCode->[hashCode],equals->[decoderResult,equals]]] | Sets the decoderResult. | nit: you can merge both lines above as `checkNotNull` will return the given argument |
@@ -128,7 +128,16 @@ public class JaasAuthProvider implements AuthProvider {
// We do the actual authorization here not in the User class
final boolean authorized = validateRoles(lc, allowedRoles);
- promise.complete(new JaasUser(username, password, authorized));
+ // if the subject from the login con... | [JaasAuthProvider->[getUser->[getMessage,error,BasicCallbackHandler,validateRoles,get,login,complete,JaasUser,fail],validateRoles->[toSet,isEmpty,contains,collect],JaasUser->[principal->[UnsupportedOperationException],doIsPermitted->[succeededFuture,handle],JaasPrincipal,requireNonNull],authenticate->[getUser,failedFut... | Method to get a user from the login context. | Hey @Gerrrr @spena I notice that you added a `password` field into JaasUser in an earlier PR, but I didn't see where this is being used. Is it important that all principals passed throughout the ksql engine contain this field? If so, do you think it makes sense to add it as a requirement into the new `KsqlPrincipal` in... |
@@ -425,7 +425,14 @@ d_tm_print_timestamp(time_t *clk, char *name, FILE *stream)
* Remove the trailing newline character
*/
temp[D_TM_TIME_BUFF_LEN - 2] = 0;
- fprintf(stream, "Timestamp: %s: %s\n", name, temp);
+
+ switch (format) {
+ case D_TM_CSV:
+ fprintf(stream, "timestamp,%s", temp);
+ break;
+ default... | [d_tm_get_timestamp->[d_tm_find_metric],d_tm_get_gauge->[d_tm_find_metric,d_tm_compute_standard_dev],d_tm_get_duration->[d_tm_find_metric,d_tm_compute_standard_dev],d_tm_increment_gauge->[d_tm_compute_histogram,d_tm_compute_stats],d_tm_count_metrics->[d_tm_count_metrics],d_tm_decrement_gauge->[d_tm_compute_histogram,d_... | This function is called to print a timestamp from a given time_t object. | this switch looks a little bit out of place given you are using if/else for the same check below |
@@ -27,6 +27,8 @@ class QuestionAnsweringClient(QuestionAnsweringClientOperationsMixin):
:type endpoint: str
:param credential: Credential needed for the client to connect to Azure.
:type credential: ~azure.core.credentials.AzureKeyCredential
+ :keyword str default_language: Sets the default language ... | [QuestionAnsweringClient->[__aexit__->[__aexit__],close->[close],__aenter__->[__aenter__],send_request->[send_request]]] | Initialize the object. | Should default to "" or None, whichever is appropriate here. |
@@ -69,7 +69,7 @@ class AuthHandler(object): # pylint: disable=too-many-instance-attributes
"Multiple ACMEChallengeMessages for the same domain "
"is not supported.")
self.domains.append(domain)
- self.responses[domain] = ["null"] * len(msg.challenges)
+ self.re... | [_find_smart_path->[enumerate,fatal,get,exit],_find_dumb_path->[append,len,set,enumerate,is_preferred],gen_challenge_path->[_find_smart_path,_find_dumb_path],AuthHandler->[acme_authorization->[create,send_and_receive_expected,importKey,fatal,str,info,exit,_cleanup_challenges],_cleanup_state->[remove],_construct_dv_chal... | Add a challenge message to the AuthHandler. | Nevermind... looked up Python json serialization... |
@@ -216,14 +216,14 @@ Devise.setup do |config|
# :time = Re-enables login after a certain amount of time (see :unlock_in below)
# :both = Enables both strategies
# :none = No unlock strategy. You should handle unlocking by yourself.
- # config.unlock_strategy = :both
+ config.unlock_strategy = :both
... | [reconfirmable,remember_for,extend_remember_period,omniauth,test?,weeks,expire_all_remember_me_on_sign_out,password_length,skip_session_storage,reset_password_within,strip_whitespace_keys,stretches,case_insensitive_keys,sign_out_via,setup,hours,require,mailer_sender] | Configuration for a user session. This is a bit of a hack to allow you to use a different encryption algorithm. | This together with `config.unlock_in = 1.hour` means the account will automatically unlock after 1 hour. We can change that if people feel like it, but since our main motivation for this was deterring brute-force attacks it seemed like an ok setting. |
@@ -51,7 +51,7 @@ func (s *Server) GetPolicyfile(ctx context.Context, req *request.Policyfile) (*r
return nil, status.Error(codes.Internal, err.Error())
}
- result, err := c.GetRoleList()
+ result, err := c.SearchRoles(&request.SearchQuery{})
if err != nil {
return nil, ParseAPIError(err)
}
| [GetPolicyfiles->[List,createClient],GetPolicyfile->[createClient,GetRoleList,Error,Marshal,GetRevisionDetails]] | GetPolicyfile returns a list of all the policies in a revision. | Keeping the this extended `SearchRoles` methods as it is, as I have called coupled of places, changing it will `c.client.Search.Query()` need to update with `SeachResult` so skipping for now. |
@@ -272,7 +272,8 @@ class CI_Session_redis_driver extends CI_Session_driver implements SessionHandle
if (isset($this->_redis))
{
try {
- if ($this->_redis->ping() === '+PONG')
+ $ping = $this->_redis->ping();
+ if ($ping === '+PONG' OR $ping === TRUE)
{
$this->_release_lock();
if ($t... | [CI_Session_redis_driver->[write->[setTimeout,_fail,_get_lock,_release_lock,set],close->[getMessage,_fail,ping,_release_lock,close],_get_lock->[setTimeout,set,setex,ttl],_release_lock->[delete],read->[_get_lock,get,_fail],destroy->[_cookie_destroy,_fail,delete],open->[_fail,php5_validate_id,connect,auth,select],validat... | Closes the session. | Why would we silently accept both if we know the version? |
@@ -1349,6 +1349,15 @@ vos_reserve_recx(struct vos_io_context *ioc, uint16_t media, daos_size_t size)
}
}
+ if (size >= VOS_DEDUP_SIZE_THRESH &&
+ vos_dedup_lookup(vos_cont2pool(ioc->ic_cont), csum, csum_len,
+ &biov)) {
+ D_ASSERT(biov.bi_addr.ba_off != 0);
+ ioc->ic_umoffs[ioc->ic_umoffs_cnt] = bi... | [No CFG could be retrieved] | Reserve the nubus record header and record header. finds the next key in the list of akey and returns the index of the next. | (style) 'DEDUP' may be misspelled - perhaps 'DEDUPE'? |
@@ -109,6 +109,15 @@ for (let name of events) {
})
}
+// TODO(MarshallOfSound): Remove in 4.0
+app.makeSingleInstance = (oldStyleFn) => {
+ deprecate.warn('app.makeSingleInstance(cb)', 'app.requestSingleInstanceLock() and app.on(\'second-instance\', cb)')
+ if (oldStyleFn && typeof oldStyleFn === 'function') {
... | [No CFG could be retrieved] | Wrappers for native classes. | Needs a deprecate mesage for `app.releaseSingleInstance()` too |
@@ -109,6 +109,7 @@ ActiveRecord::Schema.define(version: 20170215175444) do
t.datetime "updated_at"
t.boolean "active", default: false, null: false
t.boolean "approved", default: false, null: false
+ t.boolean "native", ... | [string,text,add_foreign_key,datetime,integer,add_index,json,enable_extension,create_table,boolean,define] | t. string deactivation_reason Indexes the service providers on the issuer. | add `null: false`, too, to be consistent with other booleans in this table? |
@@ -245,7 +245,7 @@ def add_parser(subparsers, parent_parser):
metrics_add_parser.add_argument("path", help="Path to a metric file.")
metrics_add_parser.set_defaults(func=CmdMetricsAdd)
- METRICS_MODIFY_HELP = "Modify metric file options."
+ METRICS_MODIFY_HELP = "Modify metric file values."
metr... | [CmdMetricsShow->[run->[show_metrics]],add_parser->[add_parser],CmdMetricsDiff->[run->[_show_diff]]] | Adds a parser to subparsers to add manage and collect metrics. Command line interface for handling command - line options. Adds command line options for the command - line utility to show changes in metrics between a commit "Show output in JSON format. | it should be options. `modifying values` sounds like we actually modify metric values. it is about setting up metric file settings (type, path, etc), not modifying metric values |
@@ -15026,7 +15026,10 @@ void Player::PrepareGossipMenu(WorldObject* source, uint32 menuId /*= 0*/, bool
}
break;
}
+ }
+ break;
case GOSSIP_OPTION_LEARNDUALSPEC:
+ [[fallthrough]... | [No CFG could be retrieved] | Checks if the given object has a valid NPC option and if it has a valid N This function checks if the given creature can be sent to the client. | do we need this `[[fallthrough]];` here? I thought it's only needed when there are actually some lines of code between two cases and no `break` |
@@ -814,6 +814,12 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http
}
});
}
+ // if closeListener != null this means we have already initiated graceful closure. doGracefulShutdown will apply
+ // the gracefulShutdownTimeoutMillis on ... | [Http2ConnectionHandler->[connect->[connect],write->[write],handlerAdded->[PrefaceDecoder],close->[close,flush],decode->[decode],checkCloseConnection->[operationComplete,isGracefulShutdownComplete],onHttpServerUpgrade->[prefaceSent],onError->[flush],handlerRemoved0->[handlerRemoved],onStreamError->[onError],onConnectio... | This method is called when a response is received from the client. It will attempt to write. | @ejona86 - there is some complexity related to preserving existing functionality and `gracefulShutdownTimeoutMillis` management (which we should re-asses for 5.0). |
@@ -2162,12 +2162,12 @@ export default {
room.sendApplicationLog(JSON.stringify(logObject));
- // We only care about the delay between simulcast streams.
- // Longer delays will be caused by something else and will just
- // poison the data.
- ... | [No CFG could be retrieved] | Add listeners to the UI and the UIManager Add listeners to the UI and the UI to update the . | To confirm, the `if (delay < 2000)` was removed on purpose? The words "poison the data" are pretty strong. |
@@ -2,8 +2,18 @@
echo 'RAy Racom State';
+
// System Status (Value : na (0) unknown, ok (1) ok, warning (2) warning, alarm (3) alarm)
$state = snmp_get($device, "systemStatus.0", "-Ovqe", 'RAY-MIB');
+
+$cmd = gen_snmpget_cmd($device, '.1.3.6.1.4.1.33555.1.1.3.1', '-Oqv', 'RAY-MIB', 'ray');
+$data = trim(externa... | [No CFG could be retrieved] | This function show the RAy Racom state. - > Get Sensor To State Index - > Get Radio Link Status - > Get Radio Link. | why are you not using the built in functions? if .0 is inconsistent, just use `snmp_getnext($device, "systemStatus", "-Ovqe", 'RAY-MIB')` and it will work for both |
@@ -0,0 +1,10 @@
+class BaseComponent < ViewComponent::Base
+ class << self
+ def renders_script(script = self.name.underscore)
+ define_method 'render_in' do |view_context, &block|
+ view_context.javascript_packs_tag_once(script)
+ super(view_context, &block)
+ end
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | WDYT about removing the default script name? I think it would be kinder to our future selves to trace if we saw `app/components/accordion_component.js` in component (or even just `accordion_component.js`) |
@@ -50,12 +50,12 @@ class ScenarioRunner:
data_path: Path,
scenario_file: Path,
):
- from scenario_player.node_support import RaidenReleaseKeeper, NodeController
+ from scenario_player.node_support import NodeController
self.task_count = 0
self.running_ta... | [ScenarioRunner->[_get_node_addresses->[_spawn_and_wait],node_to_address->[_get_node_addresses]]] | Initialize a node - related object. Initialize the node with a . | Without having run the new code, I'm pretty sure the import can't be on module level due to circular dependencies |
@@ -26,7 +26,7 @@ var srcGlobs = [
'!gulpfile.js'
];
-var dedicatedCopyrightNoteSources = /(\.js|.css|\.md)$/;
+var dedicatedCopyrightNoteSources = /(\.js|\.css|\.md|\.html)$/;
// Terms that must not appear in our source files.
var forbiddenTerms = {
| [No CFG could be retrieved] | The Gulpfile structure that contains all of the files that should be checked against. Terms that must appear in a source file. | I don't think we want to require copyright in HTML files. Makes them hard to copy paste. |
@@ -1598,7 +1598,11 @@ class UsersController < ApplicationController
end
end
format.ics do
- @bookmark_reminders = Bookmark.where(user_id: user.id).where.not(reminder_at: nil).joins(:topic)
+ @bookmark_reminders = Bookmark.with_reminders
+ .where(user_id: user.id)
+ ... | [UsersController->[destroy->[destroy],feature_topic->[update],admin_login->[create],notification_level->[update],update->[update],clear_featured_topic->[update],username->[username],read_faq->[read_faq],check_username->[changing_case_of_own_username,check_username],create->[username],show_card->[show],register_second_f... | This action returns a list of bookmarks that match the given query. | Just curious, do we need to join here? I think eager loading is sufficient for the use case here. |
@@ -222,7 +222,8 @@ class CSP(TransformerMixin, BaseEstimator):
X = np.asarray([np.dot(pick_filters, epoch) for epoch in X])
# compute features (mean band power)
- X = (X ** 2).mean(axis=-1)
+ if self.transform_into == 'average_power':
+ X = (X ** 2).mean(axis=-1)
i... | [_check_deprecate->[warn],CSP->[_check_Xy->[ValueError,len],plot_filters->[arange,EvokedArray,deepcopy,plot_topomap],plot_patterns->[arange,EvokedArray,deepcopy,plot_topomap],transform->[,type,_check_deprecate,asarray,log,ValueError,isinstance,RuntimeError,dot],__init__->[ValueError,isinstance],fit->[,sqrt,asarray,sum,... | Estimate epochs sources given the CSP filters. | `log` is True by default, that will cause issue if we forget to set it to False when `transform_into` is `csp_space`. should we add another mode like `average_log_power` (that will be default) |
@@ -18,7 +18,6 @@ import bisect
import enum
import warnings
from typing import List
-
import numpy as np
from ..utils import finalize_metric_result
| [MissRate->[parameters->[update],evaluate->[per_class_detection_statistics],update->[per_class_detection_statistics]],Recall->[_calculate_recall->[per_class_detection_statistics]],YoutubeFacesAccuracy->[parameters->[update],submit_all->[evaluate]],bbox_match->[set_false_positive,evaluate],DetectionMAP->[configure->[API... | Creates a metric that defines the parameters of an object s type. Required field. | Please, update years to 2019-2000 in line 2. |
@@ -332,16 +332,15 @@ if ($object->fetch($id) >= 0)
// Si le module mailing est qualifie
if ($qualified)
{
- $var = !$var;
if ($allowaddtarget)
{
- print '<form '.$bctag[$var].' name="'.$modulename.'" action="'.$_SERVER['PHP_SELF'].'?action=add&id='.$object->id.'&module='.$modulena... | [fetch,getMessage,update_nb,getNbOfRecipients,fetch_object,countNbOfTargets,order,getNomUrl,getDesc,load,plimit,clear_target,selectDestinariesStatus,add_to_target,escape,close,formFilter,showFilterAndCheckAddButtons,textwithpicto,free,query,trans,num_rows] | Generate the HTML for a single n - ary module mailing. Print an image of a sequence target. | $bctag is "impair tagtr" or "pair tagtr" so we must replace with "oddreplace tagr" and not with "oddeven" |
@@ -165,6 +165,11 @@ export class AmpSidebar extends AMP.BaseElement {
this.vsync_.mutate(() => {
this.element.setAttribute('open', '');
this.element.setAttribute('aria-hidden', 'false');
+ try {
+ this.element./*OK*/focus();
+ } catch (e) {
+ // IE <= 7 may thro... | [No CFG could be retrieved] | private private method to manage the sidebar. private methods for mutating the mask. | This would be a great helper method, so we don't forget to wrap in try catch. |
@@ -254,11 +254,14 @@ class ServiceBusClient(object):
"To connect to the sub queue of a sessionful queue, "
"please set sub_queue only as sub_queue does not support session."
)
- if sub_queue and sub_queue in SubQueue:
+ try:
queue_name = generat... | [ServiceBusClient->[get_queue_receiver->[append,get,ServiceBusReceiver,ValueError,generate_dead_letter_entity_name],get_queue_sender->[append,ServiceBusSender],get_subscription_receiver->[append,get,ServiceBusReceiver,ValueError,generate_dead_letter_entity_name],__enter__->[_create_uamqp_connection],__exit__->[close],g... | Returns a ServiceBusReceiver for the specific queue. Creates a new ServiceBusReceiver instance which will handle a single missing message in the queue. | This works if `sub_queue` is both str and an enum instance? I think it does IIRC - but just double checking |
@@ -560,12 +560,11 @@ class Site extends BaseAdmin
'$no_regfullname' => ['no_regfullname', DI::l10n()->t('No Fullname check'), DI::config()->get('system', 'no_regfullname'), DI::l10n()->t('Allow users to register without a space between the first name and the last name in their full name.')],
'$communit... | [Site->[content->[getAvailableLanguages,getUrlPath,get,set,t,delete],post->[update_table->[redirect],getUrlPath,redirect,get,set,saveByURL,t,delete]]] | Content method for the theme list. get all users names to make a personal install of X Displays a list of all possible site objects. The default configuration for the application. The system account that is used to perform ActivityPub requests. | Shouldn't the absence of the `imap_open` function disable this setting in the disabled position with a helpful tooltip to explain why? |
@@ -283,6 +283,17 @@ class URLFetchStrategy(FetchStrategy):
"%s checksum failed for %s" % (checker.hash_name, self.archive_file),
"Expected %s but got %s" % (self.digest, checker.sum))
+
+ def search_cache(self):
+ if not self.digest:
+ return
+ ch... | [FetchStrategy->[__metaclass__->[__init__->[__init__]]],args_are_for->[matches],SvnFetchStrategy->[_remove_untracked_files->[svn],fetch->[svn],reset->[svn,_remove_untracked_files]],for_package_version->[URLFetchStrategy,matches],HgFetchStrategy->[fetch->[hg],reset->[hg]],GitFetchStrategy->[fetch->[git],reset->[git]],UR... | Checks the downloaded archive against a checksum. | If you implement the caching so that it builds a mirror, this part can be hoisted up to `Package.fetch()`, so that the cache is the first mirror it checks. I think you would only need to add the `var/spack/cache` dir to the mirror roots in `Package.fetch()` to get this to work. That would get you source repo archiving ... |
@@ -25,6 +25,17 @@ logger = logging.getLogger(__name__)
RESERVED_NAMES = {"local", "localhost"}
+DEFAULT_STARTUP_SCRIPT = """#!/bin/bash
+sudo apt-get update
+sudo apt-get install --yes python3 python3-pip
+python3 -m pip install --upgrade pip
+
+cd /etc/apt/sources.list.d
+sudo wget https://dvc.org/deb/dvc.list
+... | [MachineManager->[destroy->[destroy,get_config_and_backend],run_shell->[run_shell,get_config_and_backend],create->[create,get_config_and_backend],get_sshfs->[get_sshfs,get_config_and_backend],__init__->[MachineBackends]]] | Validate machine name. | Perhaps use `pushd`/`popd` to ensure the cwd is not changed? |
@@ -45,6 +45,13 @@ class NodeDistribution(object):
NodeDistribution.VALID_PACKAGE_MANAGER_LIST.keys()))
register('--yarnpkg-version', advanced=True, default='v0.19.1', fingerprint=True,
help='Yarnpkg version. Used for binary utils')
+ register('--eslint-setupdir', advanced=... | [NodeDistribution->[install_yarnpkg->[unpack_package],install_node->[unpack_package],__init__->[_normalize_version,validate_package_manager],_command_gen->[Command],node_command->[_command_gen],npm_command->[_command_gen],Command->[check_output->[_prepare_env,check_output],run->[_prepare_env]],Factory->[create->[create... | Register options for this NodeDistributionFactory. | This should likely be fingerprinted as well. |
@@ -34,6 +34,10 @@ define( 'YOAST_VENDOR_NS_PREFIX', 'YoastSEO_Vendor' );
define( 'YOAST_VENDOR_DEFINE_PREFIX', 'YOASTSEO_VENDOR__' );
define( 'YOAST_VENDOR_PREFIX_DIRECTORY', 'vendor_prefixed' );
+define( 'WPSEO_PHP_REQUIRED', '5.6' );
+define( 'WPSEO_WP_TESTED', '5.5' );
+define( 'WPSEO_WP_REQUIRED', '5.4' );
+
... | [_wpseo_activate->[add,activate_hooks,schedule_flush],_wpseo_deactivate->[remove],wpseo_init->[register_hooks],wpseo_init_rest_api->[register,initialize],wpseo_network_activate_deactivate->[prepare,get_col],register_hooks] | Autoloads a WordPress class file. Cycles through all classes and autoloads. | Global constants defined in the plugin should be prefixed with `YOAST_SEO` not `WPSEO` ;-) |
@@ -59,4 +59,8 @@ type Parameter struct {
// Optional: Indicates the parameter must have a value. Defaults to false.
Required bool
+
+ // Optional: Defines the presentation style a UI should use when prompting a user for a value for this parameter,
+ // eg "multiline" or "fileUpload"
+ PresentationHint string
}... | [No CFG could be retrieved] | Replies if the parameter must have a value. | Remind me again why those are mutually exclusive? Seems like I'd want to have both for some things to allow me to choose whether to copy/paste or read from file. It strikes me that this is something I'll be much happier staying out of, but I'm betting this ends up delimited. :( |
@@ -364,6 +364,7 @@ class Trainer:
"""
epoch_counter, validation_metric_per_epoch = self._restore_checkpoint()
self._enable_gradient_clipping()
+ self._enable_activation_logging()
logger.info("Beginning training.")
| [Trainer->[train->[_validation_loss,_update_learning_rate,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_validation_loss->[_get_metrics,_batch_loss],__init__->[TensorboardWriter],_metrics_to_tensorboard->[add_validation_scalar,add_train_scalar],_trai... | Trains the model with the supplied parameters. Estimate the time remaining since epoch. | See above - you could only call this if `self._histogram_interval is not None` which would clean up the variables you have dictating whether this logging is enabled or not. |
@@ -77,7 +77,7 @@ module ApplicationHelper
path = path.gsub(/\.([^.]+)$/, '.gz.\1')
end
- elsif GlobalSetting.cdn_url&.start_with?("https") && is_brotli_req?
+ elsif GlobalSetting.cdn_url&.start_with?("https") && is_brotli_req? && Rails.env != "development"
path = path.gsub("#{GlobalSetti... | [include_crawler_content?->[crawler_layout?,mobile_view?],client_side_setup_data->[loading_admin?,script_asset_path,dark_color_scheme?],script_asset_path->[is_gzip_req?,is_brotli_req?],normalized_safe_mode->[allow_third_party_plugins?,customization_disabled?,allow_plugins?],dark_scheme_id->[dark_scheme_id],build_plugin... | Returns the asset path for the given script. | Why is this change needed? |
@@ -109,7 +109,7 @@ class MainController < ApplicationController
refresh_timeout
current_user.set_api_key # set api key in DB for user if not yet set
# redirect to last visited page or to main page
- redirect_to( uri || { :action => 'index' } )
+ redirect_to( uri || { action: 'index' } )
... | [MainController->[reset_api_key->[reset_api_key]]] | check if user has a specific api key and if so redirect to main page if not set find a that can be used to find the next user in the system. | Space inside parentheses detected. |
@@ -380,12 +380,11 @@ func getSlackPullRequestApprovalPayload(p *api.PullRequestPayload, slack *SlackM
func getSlackRepositoryPayload(p *api.RepositoryPayload, slack *SlackMeta) (*SlackPayload, error) {
senderLink := SlackLinkFormatter(setting.AppURL+p.Sender.UserName, p.Sender.UserName)
- var text, title, attachm... | [JSONPayload->[MarshalIndent],Join,Error,Sprintf,Split,New,Unmarshal,RefEndName,Replace,HasPrefix] | getSlackPullRequestApprovalPayload returns a SlackPayload with the contents of the branch branch branch GetSlackPayload returns a SlackPayload object for the given event and slack meta. | In 1.11+ the reason it made sense to remove the repo link from the title is because `[%s]` was turned into a repo link (with fullname for text). If we still want to send a link to the repo in 1.10, this would require additional changes... |
@@ -160,7 +160,7 @@ func getLatestCommitStatus(e Engine, repoID int64, sha string, listOptions ListO
if len(ids) == 0 {
return statuses, nil
}
- return statuses, x.In("id", ids).Find(&statuses)
+ return statuses, e.In("id", ids).Find(&statuses)
}
// FindRepoRecentCommitStatusContexts returns repository's rec... | [loadAttributes->[Errorf],APIURL->[loadAttributes,Sprintf,FullName],Commit,Count,Find,Close,Front,PushBack,In,RepoPath,Rollback,Error,Limit,Sum,TimeStampNow,New,OrderBy,Select,Errorf,AddDuration,And,NoBetterThan,TrimSpace,Debug,Asc,Next,setSessionPagination,Where,Desc,Get,NewSession,Begin,GroupBy,Sprintf,Table,Insert,S... | GetLatestCommitStatus returns all statuses with a unique context for a given commit. NewCommitStatus creates a new commit status object from the given commit statuses. | Good catch, this could be back ported |
@@ -62,6 +62,14 @@ TEST_REDIRECT_COMMENT_BLOCK = [
['#', " } # managed by Certbot"],
]
+PREVIOUS_SSL_OPTIONS_HASHES = [
+ '0f81093a1465e3d4eaa8b0c14e77b2a2e93568b0fc1351c2b87893a95f0de87c',
+ '9a7b32c49001fed4cff8ad24353329472a50e86ade1ef9b2b9e43566a619612e',
+ 'a6d9f1c7d6b36749b52ba061fff1421f9a0a3d2c... | [NginxConfigurator->[_make_server_ssl->[_get_snakeoil_paths],perform->[restart,perform],recovery_routine->[recovery_routine],_enable_redirect->[_add_redirect_block,_has_certbot_redirect,_has_certbot_redirect_comment,choose_redirect_vhost],cleanup->[revert_challenge_config,restart],choose_redirect_vhost->[_select_best_n... | Configure a single nginx config object. Adds command line options for nginx . | I think we're missing a hash from commit a43fac3277fbadaea0311e915efa03aa15f94542. |
@@ -89,7 +89,7 @@ func NewForward(ctx context.Context, next http.Handler, config dynamic.ForwardAu
fa.authResponseHeadersRegex = re
}
- return fa, nil
+ return connectionheader.Remove(fa), nil
}
func (fa *forwardAuth) GetTracingInformation() (string, ext.SpanKindEnum) {
| [ServeHTTP->[Context,NewRequest,RequestURI,Close,Is,Set,GetLoggerCtx,LogRequest,Error,CanonicalHeaderKey,MatchString,GetSpan,ServeHTTP,Del,Location,InjectRequestHeaders,Debugf,CopyHeaders,Debug,RemoveHeaders,Do,LogResponseCode,FromContext,SetErrorWithEvent,Header,Write,Sprintf,String,ReadAll,WriteHeader],FromContext,Ge... | GetTracingInformation returns the name and kind of tracing information. | This call does not remove anything, so I think it is misleading. I'd call the method something like "Remover" instead, as it returns something that is in charge of removing. |
@@ -86,7 +86,7 @@ class CmdRemoteDefault(CmdRemote):
if self.args.name is None and not self.args.unset:
conf = self.config.read(self.args.level)
try:
- print(conf["core"]["remote"])
+ ui.write(conf["core"]["remote"])
except KeyError:
... | [CmdRemoteRename->[run->[_rename_default,_check_exists]],CmdRemoteModify->[run->[_check_exists]],add_parser->[add_parser],CmdRemoteRemove->[run->[_check_exists]]] | Checks if a missing node in remote list is present in the config. | @eggqq007, could you please describe your use case? Do you want to check if the default is set or not? |
@@ -417,11 +417,11 @@ class Yoast_Form {
*
* @since 2.0
*
- * @param string $field_name The variable within the option to create the select for.
+ * @param string $var The variable within the option to create the select for.
* @param string $label The label to show for the variable... | [Yoast_Form->[checkbox->[label],textinput->[label],index_switch->[toggle_switch],textarea->[label],radio->[label,legend],show_hide_switch->[toggle_switch],media_input->[label],file_upload->[label,hidden],select->[label]]] | Select field with options. | Please name this `$variable` instead of a shorten version for it. |
@@ -0,0 +1,16 @@
+package gobblin.data.management.copy.replication;
+
+import gobblin.data.management.copy.CopyableDataset;
+import gobblin.dataset.DatasetsFinder;
+
+public class ReplicationReplica extends AbstractReplicationData {
+
+ @Override
+ public boolean isSource() {
+ return false;
+ }
+
+ public Repli... | [No CFG could be retrieved] | No Summary Found. | This looks like tautology. How about simple "Replica". |
@@ -872,7 +872,9 @@ if (! defined('PMA_MINIMUM_COMMON')) {
if (! $auth_plugin->authCheck()) {
/* Force generating of new session on login */
- PMA_secureSession();
+ if ($token_provided) {
+ PMA_secureSession();
+ }
$auth_plugin->auth(... | [enableBc,setMinimal,storeUserCredentials,authFails,getSSLUri,authCheck,addError,isAjax,loadUserPreferences,set,isSuccess,setActiveTheme,setThemeCookie,detectHttps,disableMenuAndConsole,getLayoutFile,getScripts,addJSON,auth,authSetUser,removeCookie,checkPmaAbsoluteUri,isSuperuser,query,checkPermissions,setCookie,getNam... | Initializes the authentication plugin and runs the authentication process. Check if the user has permission to do a request. | This code modification does nothing for me, I still cannot connect to multiple servers at the same time, and I still get error: token mismatch. Using PMA version 4.6 |
@@ -39,7 +39,7 @@ class Singularity(MakefilePackage):
depends_on('shadow', type='run', when='@3.3:')
depends_on('cryptsetup', type=('build', 'run'), when='@3.4:')
- patch('singularity_v3.4.0_remove_root_check.patch', level=0, when='@3.4.0')
+ patch('singularity_v3.4.1_remove_root_check.patch', level=0... | [Singularity->[build_perms_script->[_build_script,perm_script_path],caveats->[perm_script_path],_build_script->[perm_script_tmpl],perm_script_tmpl->[perm_script],perm_script_path->[perm_script]]] | Provides a list of packages which have different install base. The base class for the single - project object. | The patch definitely needs to be run for 3.4.0, else it will fail. And I believe upstream made changes such that patching may not be necessary for the new release. Also, you've indicated a new patch filename, but that file does not exist in this PR, so I think this would be a non-op. |
@@ -120,7 +120,7 @@ public class ProxiedFileSystemWrapper {
* @return Token for proxyUserName if it exists.
* @throws IOException
*/
- private Optional<Token> getTokenFromSeqFile(String authPath, String proxyUserName) throws IOException {
+ public static Optional<Token> getTokenFromSeqFile(String authPath... | [ProxiedFileSystemWrapper->[getTokenFromSeqFile->[Path,create,Token,of,rethrow,equals,info,Configuration,register,Reader,getLocal,absent,close,getConf,next,Text],getProxiedFileSystem->[run->[get,getCurrentUser,debug],getLoginUser,create,getProp,addToken,doAs,checkArgument,isPresent,Configuration,get,createProxyUser,put... | Get the token from the sequence file. | This class has been deprecated. You can use `ProxiedFileSystemUtils.getTokenFromSeqFile` instead. |
@@ -100,6 +100,10 @@ namespace Content.Server.Database
modelBuilder.Entity<AdminLogPlayer>()
.HasKey(logPlayer => new {logPlayer.PlayerUserId, logPlayer.LogId, logPlayer.RoundId});
+
+ modelBuilder.Entity<Whitelist>()
+ .Property(w => w.UserId)
+ ... | [Round->[Identity],AdminLog->[Identity,nameof],ServerDbContext->[OnModelCreating->[HasKey,HasPrincipalKey,PlayerUserId,IsUnique,HasIndex,OnDelete,ProfileId,Id,LogId,RoundId,UserId,ValueGeneratedOnAdd,SetNull,HasFilter]]] | This method is called when the builder is creating a new entity. HasPrincipalKey - no log player with same logId roundId or playerUserId but has. | couldn't you just use the attribute? additionally i dont think this is even needed, since keys are required implicitly iirc |
@@ -54,6 +54,9 @@ public class EscapedUnicodeCharactersCheck extends IssuableSubscriptionVisitor {
return;
}
String value = LiteralUtils.trimQuotes(((LiteralTree) node).value());
+ if (node.is(Kind.TEXT_BLOCK)) {
+ value = value.replaceAll("(\r?\n|\r)\\s*+", "");
+ }
// replace \\ with ... | [EscapedUnicodeCharactersCheck->[getAllMatches->[add,group,find],isPrintableEscapedUnicode->[contains,toUpperCase,parseInt],nodesToVisit->[singletonList],visitNode->[trimQuotes,reportIssue,value,anyMatch,isEmptyString,replace,matcher,isEmpty,getAllMatches],compile,immutableSetOf]] | Checks if a node is a reserved character and if so reports an issue if it is. | Is the `+` operator necessary here? The '*' just before already covers the same case. Or is the `+` supposed o apply to the entire expression? |
@@ -332,7 +332,11 @@ public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
return;
}
+ SystemVmTemplateRegistration.parseMetadataFile();
final CloudStackVersion currentVersion = CloudStackVersion.parse(currentVersionValue);
+ ... | [DatabaseUpgradeChecker->[check->[upgrade],runScript->[runScript],upgrade->[calculateUpgradePath,runScript]]] | Check if the current version of the database is higher than the management software version. | minor nit - the standard practice is to introduce getters and setters for internal or static fields |
@@ -39,8 +39,11 @@ static int write_msblob(struct key2ms_ctx_st *ctx, OSSL_CORE_BIO *cout,
EVP_PKEY *pkey, int ispub)
{
BIO *out = ossl_bio_new_from_core_bio(ctx->provctx, cout);
- int ret =
- ispub ? i2b_PublicKey_bio(out, pkey) : i2b_PrivateKey_bio(out, pkey);
+ int ret;
+
... | [No CFG could be retrieved] | Writes a list of bytes representing a single key to an OSSL - style blob. returns the index of the first key found in the key2ms table. | you should return 0 here |
@@ -152,12 +152,12 @@ type BucketStoreConfig struct {
// RegisterFlags registers the BucketStore flags
func (cfg *BucketStoreConfig) RegisterFlags(f *flag.FlagSet) {
- f.StringVar(&cfg.SyncDir, "experimental.tsdb.bucket-store.sync-dir", "tsdb-sync", "Directory to place synced tsdb indicies.")
+ f.StringVar(&cfg.Syn... | [BlocksDir->[Join],ToMilliseconds->[Milliseconds],RegisterFlags->[StringVar,Uint64Var,RegisterFlags,DurationVar,Var,IntVar],String->[Join,String],Set->[Split,ParseDuration],New] | RegisterFlags registers flags for the bucket - store. | Can we just use `synchronized` or `fetched`? I don't remember seeing `synched` before, but apparently it's a common variant. |
@@ -174,6 +174,13 @@ General:
passphrase should be initially set when initializing an encrypted repo.
If BORG_PASSPHRASE is also set, it takes precedence.
See also BORG_NEW_PASSPHRASE.
+ BORG_PASSPHRASE_FD
+ When set, specifies a file descriptor to read a passphrase
+ from. P... | [No CFG could be retrieved] | Magic variables for Borg. This is a special case because it returns a random value that is not what we want to. | if ... or ... are ... |
@@ -564,8 +564,9 @@ public class CoderRegistry {
}
for (int i = 0; i < typeArgumentCoders.size(); i++) {
try {
+ Coder<?> c2 = typeArgumentCoders.get(i);
verifyCompatible(
- typeArgumentCoders.get(i),
+ c2,
candidateDescriptor.resolveTy... | [CoderRegistry->[createDefault->[CoderRegistry],getCoderFromFactories->[coderFor],getTypeToCoderBindings->[getTypeToCoderBindings],registerCoderForType->[registerCoderProvider],getCoderFromTypeDescriptor->[getType],getDefaultCoders->[getDefaultCoders],CommonTypes->[coderFor->[coderFor]],getCoderFromParameterizedType->[... | Verify that the coder and the candidate type are compatible. Checks if the coder arguments are compatible with the coder. | nit: `c2` -> `typeArgumentCoder` |
@@ -2,6 +2,8 @@
module View
class Company < Snabberb::Component
+ include Actionable
+
needs :company
needs :bids, default: nil
needs :selected_company, default: nil, store: true
| [Company->[render_bidders->[h,join],render->[desc,h,value,owner,revenue,format_currency,store,lambda,selected?,name],needs]] | Creates a view with a single - component component that can be used to render a single - Displays a single private with all its children. | require this to be safe |
@@ -0,0 +1,6 @@
+PhoneConfigurationDecorator = Struct.new(:phone_configuration) do
+ def default_msg
+ I18n.t('account.index.default') if
+ phone_configuration == phone_configuration.user.default_phone_configuration
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | What about `default_number_message` here? `default_msg` makes me thing this is the message you display by default somewhere. |
@@ -28,6 +28,15 @@ const Events = {
STORY_UNMUTED: 'story-audio-unmuted',
};
+/** @enum {string} */
+export const AdvancementMode = {
+ GO_TO_PAGE: 'goToPageAction',
+ AUTO_ADVANCE_TIME: 'autoAdvanceTime',
+ AUTO_ADVANCE_MEDIA: 'autoAdvanceMedia',
+ MANUAL_ADVANCE: 'manualAdvance',
+ ADVANCE_TO: 'advanceTo',... | [No CFG could be retrieved] | Intermediate handler for amp - story specific analytics. Private method for handling state changes of a . | nit: this reads like it is saying the advancement was to an ad, where you're really saying the advancement was *from* an ad with the `advance-to` attribute. Since publishers don't set the `advance-to` attribute for ads (it's set by us internally), I'm not sure the `advance-to` part is necessary to tell them here. Maybe... |
@@ -3876,7 +3876,12 @@ class NiciraNvp:
else:
cmd.transportzoneuuid = services['transportZoneUuid']
- return NiciraNvp(apiclient.addNiciraNvpDevice(cmd).__dict__)
+ if l2gatewayserviceuuid:
+ cmd.l2gatewayserviceuuid = l2gatewayserviceuuid
+ else:
+ cmd... | [PortablePublicIpRange->[create->[PortablePublicIpRange],__init__->[update]],LoadBalancerRule->[create->[LoadBalancerRule],listLoadBalancerRuleInstances->[listLoadBalancerRuleInstances],__init__->[update]],Vpn->[createVpnGateway->[createVpnGateway],createVpnConnection->[createVpnGateway],create->[Vpn],__init__->[update... | Add a NiciraNvpDevice object to the NiciraNvpDevice list. | There should be the possibility to create the device without the l2 gateway uuid. This construct forces one to exists. Please make sure you test of `services` has key `'l2gatewayserviceuuid'`before you retrieve it. |
@@ -1,4 +1,8 @@
class ProfileField < ApplicationRecord
+ before_create :generate_attribute_name
+
+ WORD_REGEX = /\w+/.freeze
+
# Key names follow the Rails form helpers
enum input_type: {
text_field: 0,
| [ProfileField->[attribute_name->[underscore],type->[check_box?],validates,scope,where,enum]] | ProfileField provides a way to add a user - defined key to an application record. | This replaces the previous `attribute_name` method with a more sensible approach and pesists the name. Note that this name will never change again even if the field's label gets updated. This is so we can avoid rewriting every single user's stored profile for a wording change. @Ridhwana this means we're **not** going t... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.