patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -940,7 +940,7 @@ define([ var showVolume = tileset.debugShowBoundingVolume || (tileset.debugShowContentBoundingVolume && !hasContentBoundingVolume); if (showVolume) { if (!defined(tile._debugBoundingVolume)) { - var color = tile._finalResolution ? (hasContentBoundingVolu...
[No CFG could be retrieved]
Create the debug bounding volumes for the tileset. Destroy the current volume.
If the tile is clipped won't its debug bounding volume not be visible?
@@ -5,8 +5,8 @@ # -------------------------------------------------------------------------- from typing import TYPE_CHECKING -from ._edm import Collection, ComplexType -from ._generated.models import SearchField +import msrest.serialization +from ._edm import Collection, ComplexType, String if TYPE_CHECKING: ...
[ComplexField->[Collection,SearchField,get],SimpleField->[SearchField,get],SearchableField->[SearchField,get]]
Creates a simple field for an Azure Search Index.
Why is this one prefaced with "is" while others are not? I'd be consistent for your language. Also, I'm not clear on what this `_attribute_map` is, since there's no `isHidden` on the model itself but, this is to be the reverse of `retrievable` that is on the model.
@@ -93,6 +93,7 @@ module ProtocolsImporter if step_json["tables"] step_json["tables"].values.each do |table_json| table = Table.create!( + name: table_json["name"], contents: Base64.decode64(table_json["contents"]), created_by: user, last_modi...
[remove_empty_inputs->[remove_empty_inputs,each,kind_of?],import_new_protocol->[invalid?,populate_protocol,new,remove_empty_inputs,save!,now,rename_record],populate_protocol->[sanitize_quill_js_input,post_process_file,new,save!,file_content_type,file,decode64,create!,file_file_name,each,reload,id,organization],import_i...
Populates the protocol with all the necessary data. if asset has a add it to the list of assets and post process it.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
@@ -717,7 +717,7 @@ public class MoveDelegate extends AbstractMoveDelegate implements IMoveDelegate * Returns a map of unit -> transport. Tries to find transports to load all * units. If it can't succeed returns an empty Map. */ - private static Map<Unit, Unit> mapTransportsToLoad(final Collection<Unit> un...
[MoveDelegate->[loadState->[loadState],saveState->[saveState],end->[end],start->[start],removeAirThatCantLand->[removeAirThatCantLand],setDelegateBridgeAndPlayer->[setDelegateBridgeAndPlayer],mapAirTransports->[mapTransports]]]
Maps the given units to the transports that can be transported and the corresponding transport. if the user has 2 infantry and selects two transports to load we should put.
Change to public so it can be called directly outside of this class as the previous method was removed.
@@ -13,11 +13,14 @@ from ...graphql.utils import get_node registry = get_global_registry() -def convert_form_fields(form_class): +def convert_form_fields(form_class, exclude): """Convert form fields to Graphene fields""" fields = OrderedDict() + if exclude is None: + exclude = [] for name,...
[ModelFormMutation->[mutate->[get_form_kwargs,convert_form_errors],__init_subclass_with_meta__->[get_output_fields,ModelFormMutationOptions,_update_mutation_arguments_and_fields,convert_form_fields,get_model_name]],ModelDeleteMutation->[__init_subclass_with_meta__->[get_output_fields,get_model_name,ModelDeleteMutationO...
Convert ModelForm fields to Graphene fields.
Shouldn't `exclude` be an optional argument here?
@@ -10,10 +10,10 @@ PACKING_SLIP_TEMPLATE = 'dashboard/order/pdf/packing_slip.html' def get_statics_absolute_url(request): - site = get_site_settings_from_request(request) + site_settings = get_site_settings_from_request(request) absolute_url = '%(protocol)s://%(domain)s%(static_url)s' % { 'pro...
[create_packing_slip_pdf->[_create_pdf],create_invoice_pdf->[_create_pdf]]
Returns the absolute URL of the static page.
In this function you need to get the domain from Site model. You can fetch the Site instance directly, without accessing it through `site_settings`.
@@ -362,6 +362,9 @@ class OpTest(unittest.TestCase): for a, b, name in itertools.izip(numeric_grads, analytic_grads, names): abs_a = np.abs(a) abs_a[abs_a < 1e-3] = 1 + print("actual", a) + print("*****") + print("expected", b) diff_mat ...
[create_op->[__create_var__],OpTest->[_calc_output->[feed_var,append_input_output],check_output->[check_output_with_place],check_grad_with_place->[__assert_is_close,get_numeric_gradient,create_op],_create_var_descs_->[create_var],check_output_customized->[calc_output],_get_gradient->[create_var,_create_var_descs_,_nump...
Checks that the values of numeric_grads and analytic_grads are close.
Please remove those debug code.
@@ -38,7 +38,17 @@ class Mpifileutils(Package): depends_on('dtcmp@1.0.3', when='@:0.7') depends_on('dtcmp@1.1.0:', when='@0.8:') + # fixes were added to libarchive somewhere between 3.1.2 and 3.5.0 + # which helps with file names that start with "._", bumping to newer + # libarchive, but in a way ...
[Mpifileutils->[install->[cmake_args,configure_args]]]
This suite provides a single - process tool to manage a single - process sequence number. This Add cmake arguments to the command line.
Are these new dependencies applicable to all versions of the software that could be installed or a subset?
@@ -152,10 +152,13 @@ def load_dygraph(model_path, config=None): Args: model_path(str) : The file prefix store the state_dict. (The path should Not contain suffix '.pdparams') - config (SaveLoadConfig, optional): :ref:`api_imperative_jit_saveLoadConfig` - object that speci...
[deprecate_keep_name_table->[wrapper->[__warn_and_build_configs__]]]
Load a dygraph for the n - ary state of a network. Load state dict by save_dygraph save format load state dict by model name and parameter file This function loads all the files in the model directory in VarBase format.
we don't recommend users to use `keep_name_table`, only keep it for debuging, so don't write its doc.
@@ -44,6 +44,11 @@ public class VersionedProcessor extends VersionedComponent private Set<String> autoTerminatedRelationships; private ScheduledState scheduledState; + private Integer retryCounts; + private Set<String> retriedRelationships; + private String backoffMechanism; + private String max...
[No CFG could be retrieved]
The scheduling period.
Should call this `retryCount` -- there is only one count :)
@@ -1,7 +1,8 @@ class DashboardsController < ApplicationController before_action :set_no_cache_header before_action :authenticate_user! - before_action :fetch_and_authorize_user, only: %i[show following followers] + before_action :fetch_and_authorize_user, only: %i[show following_tags following_users following...
[DashboardsController->[fetch_and_authorize_user->[authorize,find_by,any_admin?],show->[decorate,id,perform_later,pro?,any_admin?,find_by,admin_organizations,org_admin?],followers->[limit],pro->[authorize,member_organizations,find_by],following->[limit],before_action,after_action]]
This method is called when the user clicks on a node in the system. It returns the.
Probably easier using `except:` here :)
@@ -901,6 +901,11 @@ class Executor(object): use_program_cache=use_program_cache) program._compile(scope, self.place) + + if _has_lod_tensor_array(program._program, fetch_list): + raise ValueError("Currently, The type of item in fetch_list should be" \ + "LoD...
[Executor->[_run_impl->[global_scope,run,_run_parallel],_run_program->[_add_feed_fetch_ops,_add_program_cache,_get_program_cache,as_numpy,run,_add_ctx_cache,_get_strong_program_cache_key,_add_scope_cache,_get_scope_cache,_get_ctx_cache,_feed_data],_add_feed_fetch_ops->[has_feed_operators,has_fetch_operators],_run_from_...
Internal implementation of the run method. Runs all the tasks in parallel.
"Currently, The type of item in fetch_list should be LoDTensor the program is compiled" Did you miss "when" ? It is better to be "Currently, the type of item in fetch_list should be LoDTensor when using CompiledProgram"
@@ -261,6 +261,7 @@ public class SelectHiveQL extends AbstractHiveQLProcessor { private void onTrigger(final ProcessContext context, final ProcessSession session) throws ProcessException { FlowFile fileToProcess = (context.hasIncomingConnection() ? session.get() : null); + Attributes originalAttr...
[SelectHiveQL->[setup->[isSet,ProcessException,hasIncomingConnection,error],onTrigger->[getValue,create,onTrigger,size,equals,forName,getElapsed,toString,warn,StringBuilder,info,countMatches,executeQuery,CsvOutputOptions,put,remove,yield,getLocalizedMessage,add,modifyContent,putAllAttributes,AtomicLong,hasIncomingConne...
On trigger. This method is used to determine the type of a result set and the type of the result This method is used to perform a query and return a sequence of rows. This method is called when a query is parsed and the query is not valid.
This variable is unused.
@@ -62,12 +62,13 @@ class PasswordRequiredPrompt extends Component<Props> { */ render() { return ( - <Dialog - bodyKey = 'dialog.passwordLabel' + <InputDialog + contentKey = 'dialog.passwordLabel' onCancel = { this._onCancel } ...
[No CFG could be retrieved]
A component which can be used to display a password required in a dialogs. On submit of the check.
Is this constant used elsewhere? If not, can we inline it since we're here?
@@ -771,3 +771,16 @@ func SettingsDelete(ctx *context.Context) { ctx.HTML(200, tplSettingsDelete) } + +// SettingsOrganization render all the organization of the user +func SettingsOrganization(ctx *context.Context) { + ctx.Data["Title"] = ctx.Tr("settings") + ctx.Data["PageIsSettingsOrganization"] = true + orgs, ...
[Redirect,Info,URL,Put,RemoveAccountLink,New,Bytes,ChangeUserName,EncodePasswd,NewKeyFromURL,Secret,Image,IsFile,DeleteAccessTokenByID,IsErrTwoFactorNotEnrolled,Close,ListGPGKeys,IsErrUserHasOrgs,RenderWithErr,DeleteGPGKey,GetEmailAddresses,Validate,ListPublicKeys,UpdateUserSetting,IsErrNameReserved,IsErrEmailAlreadyUs...
200 Template Settings Delete.
Why `ctx.User.IsAdmin` ?
@@ -295,7 +295,7 @@ class Grouping < ActiveRecord::Base end if self.student_membership_number >= self.assignment.group_max errors.add(:base, I18n.t('invite_student.fail.group_max_reached', - :user_name => user.user_name)) + user_na...
[Grouping->[deletable_by?->[is_valid?],update_repository_permissions->[is_valid?],write_repo_permissions?->[repository_external_commits_only?],revoke_repository_permissions_for_membership->[write_repo_permissions?],remove_member->[membership_status],remove_rejected->[membership_status],assign_tas_by_csv->[add_tas_by_us...
Checks if the given user can invite this student. Check if the user is already part of another group and if not add an error message.
Align the parameters of a method call if they span more than one line.
@@ -240,7 +240,7 @@ class CoreferenceResolver(Model): # (1, max_antecedents), # (1, num_spans_to_keep, max_antecedents) valid_antecedent_indices, valid_antecedent_offsets, valid_antecedent_log_mask = \ - self._generate_valid_antecedents(num_spans_to_keep, max_antecedents, text_mask...
[CoreferenceResolver->[from_params->[from_params],_compute_span_representations->[_create_attended_span_representations]]]
Forward computation of the CVV algorithm. Missing link - related parameters. Get the top - level indices of the n - node node that are actually mentions. Indices of the non - zero antecedent spans in the batch.
Great thanks for this, we should have done this a while ago.
@@ -802,6 +802,15 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A { } else { size = this.getSlotSize(); } + // If this is a multi-size creative, fire delayed impression now. If it's + // fluid, wait until after resize. + if (this.isFluidRequest_ && !this.returnedSize_) { + this...
[AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dev,dict,stringify,now,userAgent],extractSize->[height,extractAmpAnalyticsConfig,get,setGoogleLifecycleVarsFromHeaders,width],getBlockParameters_->[width,height,serializeTargeting_,dev,isInManualExperiment,assign,googleBlockParameters,Number],constructor->[user,e...
Extract the size from the response headers.
Can remove X-AmpRSImps as we're never actually sending it
@@ -103,6 +103,7 @@ public class ServiceBasedAppLauncher implements ApplicationLauncher { this.services = new ArrayList<>(); // Add core Services needed for any application + addStateStoreCleaner(properties); addJobExecutionServerAndAdminUI(properties); addMetricsService(properties); addJM...
[ServiceBasedAppLauncher->[addServicesFromProperties->[addService],addJobExecutionServerAndAdminUI->[addService],addJMXReportingService->[addService],addMetricsService->[addService],start->[failure->[failure]]]]
Creates a new instance of the application based application launcher. Listener for the service manager.
Add the service only if the state store is enabled.
@@ -867,9 +867,13 @@ class Replicastore implements Replicastore_Interface { * @access public * * @param string $taxonomy Taxonomy slug. - * @return array Array of terms. + * @return array|\WP_Error Array of terms or WP_Error object on failure. */ public function get_terms( $taxonomy ) { + $t = $this->e...
[Replicastore->[ensure_taxonomy->[get_callable],checksum_all->[comments_checksum,posts_checksum],checksum_histogram->[comment_count,term_relationship_count,term_taxonomy_count,post_count,get_min_max_object_id,term_count,get_checksum_columns_for_object_type],full_sync_start->[reset],delete_object_terms->[ensure_taxonomy...
Get all terms in a taxonomy.
Or false. What's the difference in semantics between WP_Error and false, or false and an empty array?
@@ -41,8 +41,12 @@ func (n UniqueName) UniqueName() string { return string(n) } +func (n UniqueName) String() string { + return string(n) +} + type uniqueNamer interface { - UniqueName() string + UniqueName() UniqueName } type NodeFinder interface {
[Edges->[Edges],Name->[String,UniqueName],Object->[Object],ResourceName->[UniqueName],DOTAttributes->[Kinds],Subgraph->[Edges,AddNode,addEdges],EdgeSubgraph->[Edges,AddNode,addEdges],AddNode->[AddNode],SubgraphWithNodes->[Edges,AddNode,addEdges],addEdges->[Kinds],SuccessorNodesByNodeAndEdgeKind->[SuccessorNodesByEdgeKi...
UniqueName returns the unique name of the UniqueName.
This change looks good. I suspect this was the intent and it broke at some point.
@@ -72,7 +72,9 @@ func (a *PusherAppender) Commit() error { // Since a.pusher is distributor, client.ReuseSlice will be called in a.pusher.Push. // We shouldn't call client.ReuseSlice here. - _, err := a.pusher.Push(user.InjectOrgID(a.ctx, a.userID), cortexpb.ToWriteRequest(a.labels, a.samples, nil, cortexpb.RULE...
[Error->[Error],Commit->[InjectOrgID,ToWriteRequest,HTTPResponseFromError,Inc,Push],Append->[Get,IsStaleNaN,Milliseconds],AppendExemplar->[New],Appender->[EvaluationDelay],As,ObserveDuration,EvaluationDelay,NewErrorTranslateQueryableWithFn,With,Inc,Info,TranslateToPromqlAPIError,Add,NewTimer,Seconds,NewManager,WithLabe...
Commit will push the current data to the pusher.
This reinjection of the pusherappendable's context was blocking the ability to set the destination tenant context appropriately during the rule group eval
@@ -121,8 +121,10 @@ module Email style('aside.quote .avatar', 'margin-right: 5px; width:20px; height:20px; vertical-align:middle;') style('aside.quote', 'border-left: 5px solid #e9e9e9; background-color: #f8f8f8; margin: 0;') - style('blockquote', 'border-left: 5px solid #e9e9e9; background-color:...
[Styles->[format_basic->[add_styles],style->[add_styles],to_html->[to_html],to_s->[to_s]]]
CSS for OneBox - related elements. This is a hack to work around the issue where the blockquote doesn t have a tag If an iframe is relative use SSL when displaying it else remove it .
I'm obligated to ask if there's any way you can do this without `!important`?
@@ -0,0 +1,18 @@ +# Copyright 2013-2018 Lawrence Livermore National Security, LLC and other +# Spack Project Developers. See the top-level COPYRIGHT file for details. +# +# SPDX-License-Identifier: (Apache-2.0 OR MIT) + + +from spack import * + + +class PyJellyfish(PythonPackage): + """a library for doing approximat...
[No CFG could be retrieved]
No Summary Found.
Can you update the Copyright to 2013-2019 here and in the other files?
@@ -360,6 +360,15 @@ public class HivePageSource if (toType instanceof VarcharType && (fromHiveType.equals(HIVE_BYTE) || fromHiveType.equals(HIVE_SHORT) || fromHiveType.equals(HIVE_INT) || fromHiveType.equals(HIVE_LONG))) { return new IntegerNumberToVarcharCoercer<>(fromType, (VarcharType) toType)...
[HivePageSource->[getCompletedBytes->[getCompletedBytes],toString->[toString],StructCoercer->[apply->[apply],createCoercer],getReadTimeNanos->[getReadTimeNanos],ListCoercer->[apply->[apply],createCoercer],closeWithSuppression->[close],CoercionLazyBlockLoader->[load->[apply]],getSystemMemoryUsage->[getSystemMemoryUsage]...
Creates a coercer which converts from one Hive type to another. Creates a coercer that converts from type to type.
Why this one is expressed in terms of `fromType`, while others use `fromHiveType`?
@@ -106,6 +106,7 @@ func main() { // isNewNode indicates this node is a new node isNewNode := flag.Bool("is_newnode", false, "true means this node is a new node") + accountIndex := flag.Int("account_index", 0, "the index of the staking account to use") // isLeader indicates this node is a beacon chain leader ...
[RemoveAll,Root,GOMAXPROCS,GetProfiler,Now,NewHost,SetHandler,GetP2PHost,Blockchain,Info,Exit,RunServices,LoadKeyFromFile,FileHandler,Error,Int,GetID,GenKey,SupportSyncing,NewLDBDatabase,New,Notify,AddPeer,Start,RegisterPRndChannel,Nanosecond,LoadStakingKeyFromFile,Errorf,SetPortAndIP,Bool,Var,RegisterRndChannel,Termin...
The main entry point for the script. This function is called from the main function of the daemon. It sets up logging and random.
why do you need is_newnode? by default, every node is a new node if you don't specify is_beacon. this is a redundant option.
@@ -250,17 +250,8 @@ func resourceAwsCloudFormationStackSetUpdate(d *schema.ResourceData, meta interf func resourceAwsCloudFormationStackSetDelete(d *schema.ResourceData, meta interface{}) error { conn := meta.(*AWSClient).cfconn - input := &cloudformation.DeleteStackSetInput{ - StackSetName: aws.String(d.Id()), ...
[StringLenBetween,StringValueSlice,DeleteStackSet,UniqueId,IgnoreAws,UpdateStackSet,CloudformationTags,StringInSlice,Set,GetOk,New,All,CreateStackSet,Errorf,SetId,MustCompile,DescribeStackSet,Timeout,IgnoreConfig,Id,Get,Map,StringMatch,DefaultTimeout,Printf,StringValue,String,ListStackSets,CloudformationKeyValueTags]
The function to update or delete a specific CloudFormation StackSet. String returns the list of stack sets that have a non - empty next token.
Here we're creating our own `List*Pages()` from the `List*()` function the AWS API provides. This can be easily generated, since it follows a standard pattern, and could be swapped out if/when the API adds a paged function.
@@ -12,6 +12,7 @@ function getRoomName () { // eslint-disable-line no-unused-vars var path = window.location.pathname; var roomName; + var context; // determinde the room node from the url // TODO: just the roomnode or the whole bare jid?
[No CFG could be retrieved]
Gets the room name from the URL and parses the parameters into JS objects. JSON decode and parse the URL argument.
@guusdk, Is the function used at all? I see it has a `eslint-disable-line no-unused-vars` so we should probably check whether it's still used and, if not, we should remove it.
@@ -506,9 +506,11 @@ function parse_url( $url ) { /** * Check if we're running in a Windows environment (cmd.exe). + * + * $param mixed $test Testing only. */ -function is_windows() { - return strtoupper(substr(PHP_OS, 0, 3)) === 'WIN'; +function is_windows( $test = null ) { + return null !== $test ? $test : str...
[iterator_map->[add_transform],http_request->[getMessage],mustache_render->[render],format_items->[display_items]]
Checks if the current process is on Windows.
I'd prefer an environment variable over a test argument. An environment variable makes it easier for an end user to never accidentally pass an argument.
@@ -2733,7 +2733,7 @@ tgt_idx_change_retry(void **state) * rank); */ print_message("target of shard %d changed from %d to %d\n", - replica, rank, layout->ol_shards[0]->os_ranks[0]); + replica, rank, layout->ol_shards[0]->os_ids[0].ti_rank); rc = daos_obj_layout_free(layout); assert...
[insert_recxs->[insert_recxs_nowait,insert_wait],lookup_empty_single->[lookup],lookup_single->[lookup],void->[insert_test,ioreq_init,insert_wait,lookup_single,enumerate_dkey,lookup,punch_akey,lookup_single_with_rxnr,punch_dkey,insert,punch_obj,ioreq_fini,insert_single_with_rxnr,insert_nowait,insert_single,punch_rec_wit...
DSS - DTS - DTS - DTS - DTS - DTS - OS_OBJ_TGT_IDX_CHANGE - object tgt index change This function is called from DOS when a target of a replica is changed. lookup through each replica and verify data.
(style) line over 80 characters
@@ -1028,12 +1028,8 @@ static int dw_dma_copy(struct dma *dma, unsigned int channel, int bytes, return -EINVAL; } - /* do nothing on preload */ - if (flags & DMA_COPY_PRELOAD) - return 0; - - /* for one shot copy just start DMA */ - if (flags & DMA_COPY_ONE_SHOT) + /* for preload or one shot copy just start DMA...
[No CFG could be retrieved]
DMA transfer logic DMA interrupt handler.
@tlauda I see this is just revert 4549747e37e60db458ac75c93dfd5531afba37a4 Could you give more explanation about why we need this at first time and why do not need it here? It seems we try ignore the PRELOAD but try to ignore it here again? Maybe PRELOAD and ONESHOT is the same now.
@@ -137,11 +137,11 @@ class PolyencoderAgent(TorchRankerAgent): cand_rep = cand_encs else: cand_rep = cand_encs.expand(bsz, cand_encs.size(1), -1) - elif len(cand_vecs.shape) == 3: + elif len(cand_vecs.shape) == 3: # bsz x num cands x seq len _,...
[PolyEncoderModule->[score->[attend],forward->[score,encode],encode->[attend]],PolyencoderAgent->[add_cmdline_args->[add_cmdline_args]]]
Score the candidate tokens.
so this is _technically_ `bsz x seq_len`, as this is what the `cand_vecs` are when using batch cands. i think this works, but i am not sure how it affects memory usage - `repeat` copies whereas `expand` does not. perhaps @stephenroller could elaborate
@@ -1188,12 +1188,17 @@ class Form // On recherche les remises $sql = "SELECT re.rowid, re.amount_ht, re.amount_tva, re.amount_ttc,"; $sql.= " re.description, re.fk_facture_source"; + if (!empty($conf->global->MAIN_SHOW_FACNUMBER_IN_DISCOUNT_LIST)) $sql.= ", f.facnumber"; $sql...
[Form->[form_users->[select_dolusers],textwithpicto->[textwithtooltip],select_dolusers_forevent->[select_dolusers],formSelectAccount->[textwithpicto,select_comptes],formInputReason->[selectInputReason,loadCacheInputReason],form_availability->[load_cache_availability,selectAvailabilityDelay],showFilterAndCheckAddButtons...
select remises in the table Print a select tag for a node with a specific id.
I have a better solution to suggest: Because the select return always a small list, i suggest to include in previous select only the field re.fk_facture_source (always) So you don't need to have a left join and no need to clean request Then into loop, just do, if option is on, a fetch on invoice from the rowid to get t...
@@ -352,6 +352,13 @@ module Repository git_permission = self.class.__translate_to_git_perms(permissions) repo.add_permission(git_permission, '', user_id) + + # Readd the 'git' public key to the gitolite admin repo after changes + admin_key = Gitolite::SSHKey.from_file( + GIT...
[GitRevision->[initialize->[get_repos]],GitRepository->[delete_bulk_permissions->[add_user],expand_path->[expand_path],remove_user->[add_user],add_file->[path_exists_for_latest_revision?],latest_revision_number->[get_revision_number],remove_file->[commit_options,create],create->[commit_options,create],access->[open],ma...
Add user in git repository.
Indent the first parameter one step more than the previous line.
@@ -111,6 +111,7 @@ class StatementClientV1 private final ZoneId timeZone; private final Duration requestTimeoutNanos; private final String user; + private final AtomicReference<String> setAuthorizationUser = new AtomicReference<>(); private final String clientCapabilities; private final boo...
[StatementClientV1->[finalStatusInfo->[isRunning],getStats->[getStats],httpDelete->[close],cancelLeafStage->[isClientAborted],advance->[isRunning,isClientAborted],currentData->[isRunning]]]
Creates a new StatementClientV1 object.
I'd put this along with other `setXXXX` variables
@@ -42,8 +42,8 @@ class TestPrimaryHero(TestCase): def test_clean_external_requires_homepage(self): ph = PrimaryHero.objects.create( - promoted_addon=PromotedAddon.objects.create(addon=addon_factory()), - is_external=True, gradient_color='#C60184', image='foo.png') + dis...
[TestSecondaryHeroModule->[test_str->[str,create],test_icon_url->[create],test_clean_cta->[assertRaises,create,clean]],TestPrimaryHero->[test_image_url->[addon_factory,create,update],test_clean_gradient_and_image->[create,clean,update,addon_factory,assertRaises],test_gradiant->[addon_factory,create],test_clean_only_ena...
This test ensures that the primary hero is not enabled and that the external requires the homepage.
and here - the import changes at the top of the file are likely incorrect now too.
@@ -216,12 +216,14 @@ public class LivySessionController extends AbstractControllerService implements while (enabled) { try { manageSessions(); + } catch (Exception e) { + getLogger().error("Livy Session Manager Thread run into an erro...
[LivySessionController->[openSession->[getSessionInfo],setSslSocketFactory->[init],readJSONFromUrl->[getConnection],readJSONObjectFromUrlPOST->[getConnection]]]
On enabled the livy session manager.
This keeps the manageSessions() thread alive, but will there be an indication on the UI that the error is not recoverable? I'm thinking specifically about the 401 Authorization Required error where the Livy API returns HTML rather than JSON when you try to log in without Kerberos when the server has been Kerberized. Sh...
@@ -0,0 +1,18 @@ +using System.Collections.Generic; +using System.Windows.Input; +using Autodesk.DesignScript.Interfaces; +using HelixToolkit.Wpf.SharpDX; + +namespace Dynamo.Wpf.Views.Preview +{ + public interface IWatch3DView + { + Viewport3DX View { get; } + + void AddGeometryFromRenderPackages...
[No CFG could be retrieved]
No Summary Found.
I'd call this `AddGeometryForRenderPackages`, because we're creating new geometry based on the render packages, not using the geometry <strong>from</strong> the render packages.
@@ -86,5 +86,16 @@ class dbm { public static function esc_array(&$arr, $add_quotation = false) { array_walk($arr, 'self::esc_array_callback', $add_quotation); } + + /** + * Checks Converts any date string into a SQL compatible date string + * + * @param string $date a date string in any format + * @return st...
[No CFG could be retrieved]
esc_array - callback for array.
This function should return the current timestamp by default, and `$timestamp` is never used.
@@ -205,6 +205,14 @@ class FineGrainedSuite(DataSuite): result.append(('%d: %s' % (n + 2, ', '.join(filtered))).strip()) return result + def get_build_steps(self, program_text: str) -> int: + if not self.use_cache: + return 0 + m = re.search('# num_build_steps: ([0-9]...
[FineGrainedSuite->[run_case->[should_skip],build->[build]]]
Format a list of triggered build files and return a list of BuildSources. Create a list of source files to be included in the test.
Add docstring. In particular, it's worth explaining the return value.
@@ -408,7 +408,7 @@ int OSSL_PARAM_get_int64(const OSSL_PARAM *p, int64_t *val) switch (p->data_size) { case sizeof(double): d = *(const double *)p->data; - if (d >= INT64_MIN && d <= INT64_MAX && d == (int64_t)d) { + if (d >= INT64_MIN && d == (int64_t)d) { ...
[OSSL_PARAM_get_size_t->[OSSL_PARAM_get_uint32,OSSL_PARAM_get_uint64],OSSL_PARAM->[OSSL_PARAM_locate],OSSL_PARAM_get_time_t->[OSSL_PARAM_get_int64,OSSL_PARAM_get_int32],OSSL_PARAM_set_time_t->[OSSL_PARAM_set_int64,OSSL_PARAM_set_int32],OSSL_PARAM_get_octet_string_ptr->[OSSL_PARAM_get_octet_ptr],OSSL_PARAM_get_utf8_stri...
read int64_t from constant.
The check against INT64_MIN is the same thing as the check against INT64_MAX. It just happens that INT64_MIN can be represented as a double if integers are 2s complement.
@@ -74,6 +74,9 @@ public class GrizzlyServerManager implements HttpServerManager // Set filterchain as a Transport Processor transport.setProcessor(serverFilterChainBuilder.build()); transport.start(); + + idleTimeoutDelayedExecutor = new DelayedExecutor(Executors.newFixedThreadPool(1)...
[GrizzlyServerManager->[containsServerFor->[containsKey,ServerAddress],createSslFilter->[MuleRuntimeException,createSslContext,SSLFilter,setClientMode,getEnabledProtocols,setEnabledProtocols,getEnabledCipherSuites,SSLEngineConfigurator,setEnabledCipherSuites],configureServerSocketProperties->[setClientSocketSoTimeout,s...
configure server socket properties.
Why just a single thread? I'd use a cachedThreadPool. Also I'm ensure we give the thread a name which includes app name by providing a thread factory. If my assumption is correct, if this isn't done we don't know which app this thread is from.
@@ -69,7 +69,7 @@ class Section { */ public static function yield_section() { - return static::yield(static::stop()); + return static::yield_section(static::stop()); } /**
[No CFG could be retrieved]
Yields the section of the current page.
Should be yield_**content**, otherwise it gives you a nice infinite loop...
@@ -506,13 +506,15 @@ public class KsqlResourceTest { final String ksqlString = "CREATE STREAM test_explain AS SELECT * FROM test_stream;"; givenMockEngine(mockEngine -> { EasyMock.expect(mockEngine.parseStatements(EasyMock.anyString())) - .andReturn(realEngine.parseStatements(ksqlString)); - ...
[KsqlResourceTest->[givenKsqlConfigWith->[setUpKsqlResource],givenCommandStore->[setUpKsqlResource],makeSingleRequest->[makeSingleRequest],validateQueryDescription->[validateQueryDescription]]]
Checks that there is a KsqlError in the query execution plan and that there is a.
If you switch to Mockito you won't need to add this. The default would be to return 0.
@@ -13,10 +13,13 @@ class RegexStackOverflowCheckWithHighStackConsumption { Pattern.compile("(a|hello world)*"), // Noncompliant Pattern.compile("(//|#|/\\*)(.|\n)*\\w{5,}"), // Noncompliant Pattern.compile("((x|.){42})*"), // Noncompliant - Pattern.compile("(abc()()()()()|def)*"), // Noncompliant - ...
[RegexStackOverflowCheckWithHighStackConsumption->[compile]]
Pattern for reading a sequence of non - reserved characters.
As discussed, this was already reported before the fix, it should be `"(.|\n)*\\w"`
@@ -46,7 +46,7 @@ <%_ } _%> "core-js": "3.1.3", "moment": "2.24.0", - "ng-jhipster": "0.9.3", + "ng-jhipster": "0.10.0", "ngx-cookie": "4.0.2", "ngx-infinite-scroll": "7.1.0", "ngx-webstorage": "4.0.0",
[No CFG could be retrieved]
This function is exported to the client code. The version of the library that is used to support infinite scroll.
I was about to raise, but, hold my changes as I want to downgrade `ng-bootstrap` in `ng-jhipster` to fix warnings during install.
@@ -157,14 +157,16 @@ public class ColumnSelectorBitmapIndexSelector implements BitmapIndexSelector } @Override - public boolean hasMultipleValues(final String dimension) + public ColumnCapabilities.Capable hasMultipleValues(final String dimension) { if (isVirtualColumn(dimension)) { return vir...
[ColumnSelectorBitmapIndexSelector->[getDimensionValues->[close->[close],iterator->[iterator]],hasMultipleValues->[hasMultipleValues],getBitmapIndex->[getBitmap->[getNumRows],getNumRows,getBitmapIndex,getIndex,getBitmap]]]
Checks if the dimension has multiple values.
If the column holder is `null` then we should be able to safely return `Capable.TRUE`, because `getBitmapIndex` will return a bitmap index as if the column were full of nulls. This will enable optimizations in ExpressionFilter when the expression is based on a nonexistent column.
@@ -36,6 +36,14 @@ type HybridProxier struct { // when we need to delete from an existing proxier when adding to a new one. usingUserspace map[types.NamespacedName]bool usingUserspaceLock sync.Mutex + + // There are some bugs where we can call switchService() multiple times + // even though we don't actually ...
[SyncLoop->[SyncLoop],Sync->[Sync],OnServiceDelete->[OnServiceDelete],OnEndpointsAdd->[shouldEndpointsUseUserspace,OnEndpointsAdd,switchService],OnEndpointsDelete->[OnEndpointsDelete],OnServiceSynced->[OnServiceSynced],OnServiceUpdate->[OnServiceUpdate],switchService->[OnServiceDelete,OnServiceAdd],OnEndpointsUpdate->[...
NewHybridProxier creates a new HybridProxier object that delegates the given un OnServiceAdd is a callback that is called when a service is added to the chain.
switchedToUserspace? Otherwise it's unclear which switch this is tracking.
@@ -42,12 +42,13 @@ if (count($slas) > 0) { $fields = array( 'rtt' => $rtt, + 'opstatus' => $opstatus, ); // The base RRD $rrd_name = array('sla', $sla_nr); $rrd_def = RrdDefinition::make()->addDataset('rtt', 'GAUGE', 0, 300000); - $tags = ...
[addDataset]
Get the data for the given Nagios status code. This function returns an array of RrdDefinition objects for the given sla number. Add a dataset to the sequence number of nanoseconds.
Not defined for RRD (and rrd are immutable)
@@ -389,7 +389,7 @@ class Jetpack_Options { ) ); } - return $updated_num; + return (bool)$updated_num; } /**
[Jetpack_Options->[get_raw_option->[get_var,prepare],delete_raw_option->[query,prepare],update_raw_option->[query,prepare]]]
Update an option in the database.
Can you please add whitespace between the cast and the var?
@@ -154,12 +154,7 @@ func createConfigToOCISpec(config *createConfig) (*spec.Spec, error) { } /* - // Rlimits []PosixRlimit // Where does this come from - // Type string - // Hard uint64 - // Limit uint64 - OOMScoreAdj: &config.resources.oomScoreAdj, - }, + OOMScoreAdj: &config.resources.oomSco...
[GetVolumeMounts->[Split],GetContainerCreateOptions->[WithStdin,WithName,Debug],GetTmpfsMounts->[Split],CreateBlockIO->[Minor,Wrapf,Major],SetLinuxResourcesCPURealtimePeriod,GetAnnotations,SetLinuxResourcesMemoryReservation,AddLinuxSysctl,SetLinuxResourcesPidsLimit,SetProcessGID,SetLinuxResourcesCPUCpus,GetVolumeMounts...
Initialization functions for the ClassID. CreateBlockIO creates a configSpec from the given configuration.
Maybe keep this? Don't think we have OOM adjust in there yet
@@ -0,0 +1,11 @@ +# @TODO make this funtion work! +def wait_for_ajax + counter = 0 + while page.evaluate_script('axios.interceptors.response.use(function(response) { return 1 })').to_i > 0 + counter += 1 + sleep(0.1) + if (0.1 * counter) >= Capybara.default_max_wait_time + raise "AJAX request took longe...
[No CFG could be retrieved]
No Summary Found.
Line is too long. [86/80]
@@ -972,7 +972,7 @@ public: SpellCastResult CheckCast() { - if ((int32(GetCaster()->GetHealth()) > int32(GetSpellInfo()->Effects[EFFECT_0].CalcValue() + (6.3875 * GetSpellInfo()->BaseLevel) + (GetCaster()->GetStat(STAT_SPIRIT) * 1.5f) + 1.0f ))) + if ((int32(GetCaster()->GetHea...
[spell_warl_everlasting_affliction->[spell_warl_everlasting_affliction_SpellScript->[HandleScriptEffect->[CalculateAmount]]]]
CheckCast - check if the node is on a light level and if it is on a.
shall we move these magic numbers inside constants? especially the `0.9f` as it's repeated
@@ -1,15 +1,10 @@ package games.strategy.engine.lobby.server.db; -import static games.strategy.util.PredicateUtils.not; - -import java.util.Arrays; -import java.util.Collection; -import java.util.List; -import java.util.logging.Logger; -import java.util.stream.Collectors; +import java.util.Optional; import com.go...
[DbUserController->[login->[login],doesUserExist->[doesUserExist],getUserByName->[getUserByName],createUser->[createUser],updateUser->[updateUser],getPassword->[getPassword]]]
Creates a new UserController object. No - op for testing.
Static analysis: "The import com.google.common.base.Strings is never used"
@@ -1364,6 +1364,10 @@ } void fine_tune_mesh(const float &lx, const float &ly, const bool do_ubl_mesh_map) { + // do all mesh points unless R option has a value of 1 or more + repetition_cnt = code_seen('R') && code_has_value() ? code_value_byte() : GRID_MAX_POINTS_X * GRID_MAX_POINTS_Y; + if (repetiti...
[No CFG could be retrieved]
Fine - tune the mesh. Find a point in a mesh.
For safety: `(GRID_MAX_POINTS_X) * (GRID_MAX_POINTS_Y)`
@@ -0,0 +1,16 @@ +# ------------------------------------ +# Copyright (c) Microsoft Corporation. +# Licensed under the MIT License. +# ------------------------------------ + +_SUPPORTED_API_VERSIONS = [ + "2019-05-06-Preview", +] + +def get_api_version(kwargs, default): + # type: (Dict[str, Any]) -> str + api_...
[No CFG could be retrieved]
No Summary Found.
If I understand the PR correctly, it's to make sure this is "2020-06-03" everywhere.
@@ -47,10 +47,7 @@ async function main() { await startSauceConnect(FILENAME); timedExecOrDie('gulp unit --nobuild --saucelabs'); - timedExecOrDie( - 'gulp integration --nobuild --compiled --saucelabs --stable' - ); - timedExecOrDie('gulp integration --nobuild --compiled --saucelabs --beta'); +...
[No CFG could be retrieved]
Main script for the remote - tests. Yields an array of all possible non - existent tasks.
Combining beta and stable into a single invocation will break two things: 1) Test status reporting relies on stable / beta flags to report results to different statuses. 2) Stable failures should fail the CI job, while beta failures shouldn't. You'll need to make some changes to the code that does the batching. Looking...
@@ -160,6 +160,9 @@ def choose_configurator_plugins(config, plugins, verb): req_auth, req_inst = cli_plugin_requests(config) + installer_question = ("How would you like to authenticate and install " + "certificates?") + # Which plugins do we need? if verb == "run": ...
[cli_plugin_requests->[set_configurator],choose_configurator_plugins->[pick_authenticator,pick_configurator,pick_installer,record_chosen_plugins]]
Picks a configurator and a plugin that can be used to run the given plugin. Checks if installer and authenticator are missing and records the necessary information.
Is it correct to mention authentication here?
@@ -93,7 +93,7 @@ class Article < ApplicationRecord before_save :update_cached_user after_save :bust_cache, :detect_human_language - after_save :notify_slack_channel_about_publication, if: -> { published && published_at > 30.seconds.ago } + after_save :notify_slack_channel_about_publication after_update_...
[Article->[username->[username],update_notifications->[update_notifications],set_cached_object->[username],readable_edit_date->[edited?]]]
Validate the current state of the user s video. Create a new model that can be used to manage a list of objects from elasticsearch.
the check is done in the service, one place to rule them all :D
@@ -10,8 +10,7 @@ class UspsConfirmationMaker end def perform - entry = UspsConfirmationEntry.new_from_hash(attributes) - UspsConfirmation.create!(entry: entry.encrypted) + UspsConfirmation.create!(entry: attributes.to_json) UspsConfirmationCode.create!( profile: profile, otp_fingerp...
[UspsConfirmationMaker->[perform->[fingerprint,encrypted,create!,new_from_hash],generate_otp->[encode,random_number],attr_reader]]
This method will perform the necessary actions to create a new user sequence.
I think we still want this to be encrypted, right? This will result in raw PII in our database otherwise.
@@ -66,6 +66,8 @@ func newStackExportCmd() *cobra.Command { return nil }), } + cmd.PersistentFlags().StringVarP( + &stackName, "stack", "s", "", "The name of the stack to operate on. Defaults to the current stack") cmd.PersistentFlags().StringVarP( &file, "file", "", "", "A filename to write stack output...
[Create,ExportDeployment,NewEncoder,SetIndent,RunFunc,StringVarP,Wrap,Encode,MaximumNArgs,PersistentFlags]
Print the stack trace of the last node in the system.
Does it make sense to update the other commands that accept `--stack` to also use this consistent description while we are at it?
@@ -3162,6 +3162,7 @@ namespace System.Windows.Forms AddRange(value); } + /// <include file='doc\ListBox.uex' path='docs/doc[@for="ListBox.ObjectCollection.Count"]/*' /> /// <summary> /// Retrieves the number of items. /// </summary>
[ListBox->[FindString->[FindString],OnFontChanged->[OnFontChanged],WmReflectMeasureItem->[OnMeasureItem],SelectedIndexCollection->[IndexOf->[IndexOf,GetItem,GetCount,GetState],Clear->[ClearSelected],Add->[Contains,SetSelected],Contains->[IndexOf,Contains],Remove->[Contains,SetSelected],IndexOfIdentifier,GetEntryObject]...
Creates a new ObjectCollection object that contains all objects of the specified type. Relations for List and ListBox are objects with properties that are not part of the list.
We don't have a doc folder nor uex files, please remove the line.
@@ -3,8 +3,6 @@ from typing import List from funcy import first -from dvc.utils import error_link, format_link, relpath - class DvcException(Exception): """Base class for all dvc exceptions."""
[GitHookAlreadyExistsError->[__init__->[format_link,super,format]],DownloadError->[__init__->[super]],FileMissingError->[__init__->[super]],RecursiveAddingWhileUsingFilename->[__init__->[super]],CircularDependencyError->[__init__->[super,format,isinstance]],CheckoutErrorSuggestGit->[__init__->[super]],DvcException->[__...
Initialize with a message with a sequence of arguments.
`dvc.utils` imports a lot of things. Making it lazy here as `dvc.exceptions` is imported in almost all of the commands that will affect everything (even `dvc -v`)
@@ -33,11 +33,10 @@ class DocumentAccessorTest extends TestCase /** * It should throw an exception if the property does not exist. - * - * @expectedException \Sulu\Component\DocumentManager\Exception\DocumentManagerException */ public function testAccessObjectNotExist() { + $...
[DocumentAccessorTest->[testAccessObjectNotExist->[set],testAccessObject->[assertEquals,set,getPrivateProperty]]]
Test if an object is not found in the object accessor.
Generally we use class like this at the top of the file
@@ -70,6 +70,8 @@ public class DefaultTwoWayKey2StringMapper implements TwoWayKey2StringMapper { identifier = BOOLEAN_IDENTIFIER; } else if (key.getClass().equals(ByteArrayKey.class)) { return generateString(BYTEARRAYKEY_IDENTIFIER, Base64.encodeBytes(((ByteArrayKey)key).getData())); + }...
[DefaultTwoWayKey2StringMapper->[getKeyMapping->[parseByte,IllegalArgumentException,tracef,parseShort,parseDouble,charAt,parseInt,parseFloat,ByteArrayKey,parseBoolean,decode,substring,parseLong,length],getStringMapping->[IllegalArgumentException,getName,equals,generateString,encodeBytes,getData,toString],isSupportedTyp...
This method is to generate a string mapping for the given key object.
Do we still need this? Even if we do, byte[] check should probably be before it, since it's more likely to happen :)
@@ -188,9 +188,9 @@ var s = {}; s['id'] = submission.id; if (submission.name_url === '') { - s['group_name'] = <span>{submission.name}</span>; + s['group_name'] = <span dangerouslySetInnerHTML={{__html: submission.name}} />; } else { - s['group_name'] = <sp...
[No CFG could be retrieved]
The template for the tag - related section of the page. Renders the tag list.
Don't use this. Find another way to solve this problem.
@@ -50,16 +50,14 @@ describe('amp-ad-xorigin-iframe-handler', () => { }); describe('init() returned promise', () => { - let iframe; let initPromise; describe('if render-start is implemented', () => { let noContentSpy; - beforeEach(() => { + beforeEach(done => { adImp...
[No CFG could be retrieved]
Create an iframe with a message stub. expects that the iframe is visible and postMessageToParent is called before the message is.
So this `done` here is a special function that serves like a promise resolve func?
@@ -146,8 +146,9 @@ define([ var contentFactory = Cesium3DTileContentProviderFactory[type]; if (type === 'json') { + // TODO : should this be in the factory class? this.hasTilesetContent = true; - content = new Tileset3DTileContentProvider(); + ...
[No CFG could be retrieved]
XML - TILE - IMAGE The CullingVolume object that represents a single child of a parent.
> TODO : should this be in the factory class? Yes, it wasn't before because the parameters and workflow were different.
@@ -426,7 +426,8 @@ public class FirewallManagerImpl extends ManagerBase implements FirewallService, // we allow port forwarding rules with the same parameters but different protocols boolean allowPf = (rule.getPurpose() == Purpose.PortForwarding && newRule.getPurp...
[FirewallManagerImpl->[applyDefaultEgressFirewallRule->[applyRules],createRuleForAllCidrs->[createFirewallRule],revokeRule->[doInTransactionWithoutResult->[removeRule]],applyRules->[applyRules],revokeEgressFirewallRule->[revokeFirewallRule],revokeFirewallRulesForIp->[applyFirewallRules,revokeFirewallRule],revokeFirewal...
Detects a conflict in the rules. check if there is a duplicate rule in the rule set Checks if there is a duplicate rule in the rule set. If there is a duplicate rule.
Don't you think this gets a little hard to read and understand? Maybe reformat or split in understandable pieces.
@@ -1084,11 +1084,13 @@ static void _create_library_schema(dt_database_t *db) "caption VARCHAR, description VARCHAR, license VARCHAR, sha1sum CHAR(40), " "orientation INTEGER, histogram BLOB, lightmap BLOB, longitude REAL, " "latitude REAL, altitude REAL, color_matrix BLOB, colorspace INTEGER, vers...
[No CFG could be retrieved]
Create tables for all images in the system. - - - - - - - - - - - - - - - - - -.
You also have to create your index here.
@@ -50,13 +50,13 @@ spell: # NB: "third_party" only exists for automate-gateway, but no harm having it for other dirs here. semgrep: # uncomment if custom rules beyond automate-ui ever get added -# semgrep --config $(REPOROOT)/semgrep --exclude third_party --exclude *_test.go --exclude *.pb.go --exclude *.bindata.go...
[No CFG could be retrieved]
Security validation via semgrep.
Directory change (semgrep to .semgrep) per semgrep convention.
@@ -51,5 +51,6 @@ class PythonRun(PythonExecutionTaskBase): msg = '{cmdline} ... exited non-zero ({code})'.format(cmdline=cmdline, code=result) raise TaskError(msg, exit_code=result) except KeyboardInterrupt: - po.send_signal(signal.SIGINT) + # The process may still ...
[PythonRun->[register_options->[register,super],execute->[new_workunit,get_passthru_args,,release_lock,send_signal,create_pex,extend,require_single_root_target,copy,wait,TaskError,get_options,isinstance,join,run,safe_shlex_split,cmdline]]]
Executes a task.
You can leave this in this PR, but a reminder: please do not conflate independent changes in one PR like this in the future. If this line causes a bug, or if the rest of the PR contains a bug, they won't be able to be cherry-picked independently. And it also makes reviewing more challenging.
@@ -386,4 +386,14 @@ class ApplicationController < ActionController::Base client = DeviceDetector.new(request.user_agent) client.device_type != 'desktop' end + + def update_session_paths_visited_for_analytics + session[:paths_visited] ||= {} + session[:is_new_path] = !session[:paths_visited].key?(re...
[ApplicationController->[confirm_two_factor_authenticated->[user_fully_authenticated?],two_factor_enabled?->[two_factor_enabled?],after_mfa_setup_path->[after_sign_in_path_for]]]
Check if the user is a mobile device.
what if we called this `first_path_visit` instead of `is_new_path` everywhere
@@ -206,6 +206,8 @@ function getExtensionsToBuild() { extensionsToBuild = dedupe(extensionsToBuild.concat(extensionsFrom)); } + extensionsToBuild = dedupe(extensionsToBuild.concat(DEFAULT_EXTENSION_SET)); + return extensionsToBuild; }
[No CFG could be retrieved]
Parses the command line arguments for the build process and returns a list of the referenced extensions. - - - - - - - - - - - - - - - - - -.
This function will read better if you initialize `extensionsToBuild` with `DEFAULT_EXTENSION_SET` on line 196 and then change line 204 to `extensionsToBuild = dedupe(extensionsToBuild.concat(argv.extensions.split(',')))`.
@@ -95,9 +95,9 @@ function common_content(App $a) } if ($cid) { - $r = GContact::commonFriends($uid, $cid, $a->pager['start'], $a->pager['itemspage']); + $r =Model\GContact::commonFriends($uid, $cid, $a->pager['start'], $a->pager['itemspage']); } else { - $r = GContact::commonFriendsZcid($uid, $zcid, $a->pag...
[common_content->[setPagerTotal]]
common content of all contacts get all common friends and the contacts that are in common View a contact.
Code standards: Please keep the space after operators.
@@ -215,7 +215,7 @@ int main(int argc, char const *argv[]) { args_map["label"] = NDArray(Shape(batch_size), ctx); /*with data and label, executor can be generated automatically*/ - auto *exec = Net.SimpleBind(ctx, args_map); + auto exec = Net.SimpleBind(ctx, args_map); auto arg_names = Net.ListArguments();...
[main->[find,size,NDArray,SimpleBind,Xavier,MXDataIter,Backward,args_map,GetDataBatch,erase,Shape,AlexnetSymbol,Next,Forward,ListArguments,xavier,Get,Update,Reset,CopyTo,aux_dict,SetParam,MXNotifyShutdown,arg_dict],AlexnetSymbol->[Operator]]
main function of the training loop Train and validation iters find the next unused batch in the model.
Why not use unique_ptr<Executor> rather than a stack variable? That wouldn't change the interface.
@@ -2105,7 +2105,9 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas } public static boolean FAST_LOOKUP = !SystemProperties.getBoolean(PluginManager.class.getName()+".noFastLookup"); + @Deprecated public static final Permission UPLOAD_PLUGINS = new Permission(Jenki...
[PluginManager->[createDefault->[create],doPlugins->[getDisplayName],install->[start,install,getPlugin],dynamicLoad->[dynamicLoad],getPlugin->[getPlugin,getPlugins],PluginUpdateMonitor->[ifPluginOlderThenReport->[getPlugin]],addDependencies->[addDependencies],start->[run],loadDetachedPlugins->[loadPluginsFromWar],getPl...
This class is used to find the resource of a plugin. Monitor that checks if there are any plugins with cycle dependencies.
can you change the description / title of this permission so that it shows as deprecated to users?
@@ -397,10 +397,14 @@ public class Importer { } - importRecord(uuid, uuidAction, md, schema, index, - source, sourceName, sourceTranslations, - context, metadataIdMap, createDate, - changeDate, groupId, isTemplate); + ...
[Importer->[doImport->[handleMetadataFiles->[handleMetadata],doImport]]]
Method to import all metadata from a single or multi - file MEF. This method checks if there is a node in the metadata. xml and if so tries to Method to handle a missing feature category. Handle the info.
This is a pretty generic "Exception"? is there something specific you can catch?
@@ -130,9 +130,14 @@ func (p *fileProspector) Run(ctx input.Context, s loginp.StateMetadataUpdater, h break } } - hg.Start(ctx, src) + case loginp.OpTruncate: + log.Debugf("File %s has been truncated", fe.NewPath) + + s.ResetCursor(src, state{Offset: 0}) + hg.Restart(ctx, src) + ...
[Init->[UnpackCursorMeta,Name,CleanIf,UpdateIdentifiers,GetFiles,GetSource],Run->[Now,With,UpdateMetadata,Stop,Error,FindCursorMeta,Supports,Go,Start,Errorf,stopHarvesterGroup,Sub,Wait,Debugf,Debug,Name,Remove,Err,ModTime,WrapAll,Event,GetSource,Run],stopHarvesterGroup->[StopGroup,Errorf]]
Run starts the prospector and runs the state - specific tasks. This function is called when a file is removed from the file store and the state change clo Update cursor meta data.
do we need a unit test for the propector to correctly handle a truncate? Do we need a harvester unit test as well?
@@ -402,6 +402,11 @@ export const adConfig = { engageya: {}, + epeex: { + prefetch: 'https://epeex.com/related/service/widget/amp/remote.js', + renderStartImplemented: true, + }, + eplanning: { prefetch: 'https://us.img.e-planning.net/layers/epl-amp.js', },
[No CFG could be retrieved]
A list of all urls that are able to render a single resource. Provides a list of all possible tags that are supported by AMP.
I am not seeing this fire. Also we do not require this for `amp-embed` but you are welcome to add it for something like request to resize.
@@ -96,11 +96,12 @@ class _TFRecordUtil(object): value: A string content of the record. """ encoded_length = struct.pack('<Q', len(value)) - file_handle.write('{}{}{}{}'.format( + file_handle.write(b''.join([ encoded_length, struct.pack('<I', cls._masked_crc32c(encoded_length)),...
[ReadFromTFRecord->[__init__->[_TFRecordSource]],_TFRecordSink->[write_encoded_record->[write_record]],_TFRecordUtil->[write_record->[_masked_crc32c],read_record->[_masked_crc32c]],_TFRecordSource->[read_records->[encoded_num_bytes,read_record]],_create_tfrecordio_source->[_TFRecordSource],WriteToTFRecord->[__init__->[...
Writes a single record to a TFRecords file. Check if the data mask matches the expected data mask and return the nanoseconds.
I think we need to take a closer look at this IO regarding `str` vs `bytes`: - we may want to compute encoded_length after `value` is encoded to bytes. - we need to clarify in the docstring what type is returned as a result of `read_record` and what type is expected as argument to `encoded_num_bytes`. - we should also ...
@@ -0,0 +1,13 @@ +const { BrowserWindow } = require('electron').remote +const path = require('path') + +const newWindowBtn = document.getElementById('new-window') + +newWindowBtn.addEventListener('click', (event) => { + const modalPath = path.join('file://', __dirname, '../../sections/windows/modal.html') + let win =...
[No CFG could be retrieved]
No Summary Found.
This wouldn't work since the modal file is not there, I have a local branch which has all four of the manage window sections ported, but since the modal files can't be embedded to Fiddle (it throws exception), I've hold on to that for now. Also asked a question from @erickzhao on the issue itself which hasn't been answ...
@@ -57,6 +57,7 @@ type log struct { cmd string key string args []string + ipAndPort string } // NewHarvester creates a new harvester with the given connection
[Run->[Flush,Unix,Join,Values,Now,UTC,Close,Send,Errorf,Scan,Receive,Err],NewV4]
NewHarvester creates a new redis harvester object that will return a log Reads the slowlog and slowlog from redis and executes them together.
Are you sure that IP and port is not present in args? Did you check it (could you post a sample log)?
@@ -1071,8 +1071,16 @@ class ParlaiParser(argparse.ArgumentParser): kwargs['help'] = argparse.SUPPRESS return kwargs + def add_recommended_to_help(self, kwargs): + """Add recommended value to help string if recommended exists""" + if 'recommended' in kwargs: + kwa...
[ParlaiParser->[add_parlai_args->[add_parlai_data_path],_process_args_to_opts->[_infer_datapath,_load_opts],print_args->[parse_args],parse_known_args->[fix_underscores],add_model_subargs->[class2str],parse_and_process_known_args->[_process_args_to_opts],add_argument_group->[ag_add_argument->[fix_underscores,_handle_hid...
Override to add a to the command line.
Make sure you handle the case of help doesn't exist. I would also prefer recommended to be able to take any type so do a format here please
@@ -490,3 +490,13 @@ def test_bump_version_in_package_json(file_obj): utils.update_version_number(file_obj, '0.0.1.1-signed') parsed = utils.parse_xpi(file_obj.file_path) assert parsed['version'] == '0.0.1.1-signed' + + +def test_bump_version_in_manifest_json(file_obj): + create_switch('we...
[TestManifestJSONExtractor->[test_summary->[parse],test_version->[parse],test_homepage->[parse],test_invalid_app_versions_are_ignored->[parse],test_no_restart->[parse],test_name->[parse],test_is_webextension->[parse],test_apps_use_default_versions_if_none_provided->[create_appversion,parse],test_type->[parse],test_name...
Test that version_number is updated in package. json and that it is correct.
Does this belong into this PR?
@@ -261,7 +261,7 @@ class ClientBase(object): # pylint:disable=too-many-instance-attributes self._credential = credential #type: ignore self._keep_alive = kwargs.get("keep_alive", 30) self._auto_reconnect = kwargs.get("auto_reconnect", True) - self._mgmt_target = "amqps://{}/{}".f...
[EventHubSharedKeyCredential->[get_token->[_generate_sas_token]],ConsumerProducerMixin->[_do_retryable_operation->[_handle_exception,_backoff],_handle_exception->[_handle_exception],_close_connection->[_close_handler],_open->[_create_auth,_create_handler],close->[_close_handler]],EventhubAzureNamedKeyTokenCredential->[...
Initialize EventHub object.
qq: why is the format of the target changing?
@@ -1910,10 +1910,10 @@ static INPUT_PORTS_START( hanamai ) PORT_DIPNAME( 0x01, 0x01, DEF_STR( Unknown ) ) PORT_DIPSETTING( 0x01, DEF_STR( Off ) ) PORT_DIPSETTING( 0x00, DEF_STR( On ) ) - PORT_DIPNAME( 0x02, 0x02, DEF_STR( Unknown ) ) + PORT_DIPNAME( 0x02, 0x02, "Start rounds with 960 points" ) PORT_DIPSE...
[No CFG could be retrieved]
7. 1. 1 8. 1. 2 device settings Index of all MAC MAC ports on or off.
This isn't the starting score for the round it's the initial value for (higi, "secret technique") used to buy special items.
@@ -0,0 +1,12 @@ +/* + * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com + * The software in this package is published under the terms of the CPAL v1.0 + * license, a copy of which has been included with this distribution in the + * LICENSE.txt file. + */ +package org.mule.registry; + +publi...
[No CFG could be retrieved]
No Summary Found.
Can be TestDiscoverableObject and TestDiscoverableObjectImpl inner classes of SpiServiceRegistryTestCase?
@@ -78,7 +78,7 @@ module SubmissionsHelper def construct_file_manager_dir_table_row(directory_name, directory) table_row = {} table_row[:id] = directory.object_id - table_row[:filter_table_row_contents] = render_to_string :partial => 'submissions/table_row/directory_table_row', :locals => {:directory_na...
[construct_file_manager_table_rows->[construct_file_manager_table_row]]
Construct a table row for the directory manager s directory table.
Line is too long. [177/80]<br>Space inside { missing.<br>Space inside } missing.
@@ -123,10 +123,10 @@ class AutotoolsPackage(PackageBase): # Then search in all sub directories recursively. # We would like to use AC_CONFIG_AUX_DIR, but not all packages # ship with their configure.in or configure.ac. - config_path = next((os.path.join...
[AutotoolsPackage->[autoreconf->[autoreconf],enable_or_disable->[_activate_or_not],configure->[configure_args],with_or_without->[_activate_or_not]]]
Patch config files to include the necessary information. Look for a suitable config file and return it. Read the config file and return the config_file.
This change appears to do the same thing (computing the abspath on the result seems the same as computing them in the generator). Is this depending on some behavior of `abspath`? In other words: what issue does this resolve?
@@ -1,6 +1,8 @@ require 'rails_helper' describe RequestPasswordReset do + let(:analytics) { FakeAnalytics.new } + describe '#perform' do context 'when the user is not found' do it 'sends the account registration email' do
[email,create,new,let,describe,instance_double,first,it,order,perform,to,find_with_email,before,with,t,last,require,default_scopes,receive,now,around,id,update!,context,hash_including,eq,run,and_return]
It creates a new user in the system and sends a password reset email. when the user is found and confirmed and the email address is not set then send a message.
Is this doing anything? Do we not have any coverage for throttled flows in these specs?
@@ -1,7 +1,7 @@ const { tokenToNaturalUnits } = require('../src/util/token') -const septemberConfig = { +const octoberConfig = { numLevels: 3, levels: { 0: {
[No CFG could be retrieved]
September config for September Config - A list of all possible Natural Units.
oops ! my bad... thanks for cleaning this up :)
@@ -180,6 +180,10 @@ func (consensus *Consensus) onPreparedSanityChecks( } func (consensus *Consensus) viewChangeSanityCheck(msg *msg_pb.Message) bool { + if msg.GetViewchange() == nil { + consensus.getLogger().Warn().Msg("[viewChangeSanityCheck] malformed message") + return false + } consensus.getLogger().Debu...
[leaderSanityChecks->[Str,GetType,verifySenderKey,Msg,GetConsensus,Error,Uint64,getLogger,Msgf,String,Info,Err,Debug],isRightBlockNumAndViewID->[Str,Msg,Uint64,getLogger,SerializeToHexStr,Debug],validatorSanityChecks->[Str,GetType,verifySenderKey,Msg,GetConsensus,Error,Warn,Mode,Uint64,getLogger,Msgf,String,IsEqual,Inf...
viewChangeSanityCheck checks if a message is valid for a view change. It checks.
Where the early return
@@ -38,6 +38,13 @@ class OrderEventOrderLineObject(graphene.ObjectType): item_name = graphene.String(description="The variant name.") +class OrderSettings(CountableDjangoObjectType): + class Meta: + only_fields = ["automatically_confirm_all_new_orders"] + description = "Order related settings ...
[OrderEvent->[resolve_lines->[OrderEventOrderLineObject]],Fulfillment->[resolve_meta->[resolve_meta],resolve_private_meta->[resolve_private_meta]],Order->[resolve_meta->[resolve_meta],resolve_private_meta->[resolve_private_meta]]]
A base type for all the types of a single order. Missing number of an invoice related to the order.
I think it should be part of the settings module since it uses site settings model underneath.
@@ -325,6 +325,8 @@ def embedding(input, """ helper = LayerHelper('embedding', **locals()) + if remote_prefetch: + assert is_sparse is True and is_distributed is False w = helper.create_parameter( attr=helper.param_attr, shape=size, dtype=dtype, is_bias=False) tmp = helper.creat...
[ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi...
This layer is used to lookup embeddings of IDs in a network. This function adds a missing missing node to the lookup table.
remote_prefetch and is_distributed are confusing, any way to remove one?
@@ -343,12 +343,14 @@ namespace System.Windows.Forms.Tests { using var control = new PropertyGrid(); int callCount = 0; - EventHandler handler = (sender, e) => + + void handler(object sender, EventArgs e) { Assert.Same(control, sende...
[PropertyGridTests->[SubPropertyGrid->[OnSystemColorsChanged->[OnSystemColorsChanged],OnMouseUp->[OnMouseUp],GetTopLevel->[GetTopLevel],OnMouseEnter->[OnMouseEnter],OnKeyDown->[OnKeyDown],OnKeyUp->[OnKeyUp],OnMouseMove->[OnMouseMove],GetScrollState->[GetScrollState],OnMouseDown->[OnMouseDown],WndProc->[WndProc],GetStyl...
PropertyGrid_BackColor_SetWithHandler_CallsBackColorChanged - This method checks.
Is it possible to factor this helper out?
@@ -339,13 +339,13 @@ def freeze_rng_state(): class TransformsTester(unittest.TestCase): def _create_data(self, height=3, width=3, channels=3, device="cpu"): - tensor = torch.randint(0, 255, (channels, height, width), dtype=torch.uint8, device=device) + tensor = torch.randint(0, 256, (channels, he...
[map_nested_tensor_object->[MapNestedTensorObjectImpl],TestCase->[assertEqual->[assertEqual,assertTensorsEqual,is_iterable],assertExpected->[_get_expected_file],assertExportImportModule->[assertEqual,getExportImportCopy],_get_expected_file->[remove_prefix_suffix],check_jit_scriptable->[assertEqual]]]
Create a random tensor and a batch of images.
`randint` is exclusive on the upper bound, so the right value here is 256. I opted in fixing this small bug in-place to avoid doing unnecessary CI runs.
@@ -25,6 +25,7 @@ class DefaultOrderedDict(OrderedDict): def __getitem__(self, key): if key not in self.keys(): super(DefaultOrderedDict, self).__setitem__(key, self.factory()) + super(DefaultOrderedDict, self).__getitem__(key).name = key return super(DefaultOrderedDict, s...
[CppInfo->[__getattr__->[_get_cpp_info->[_CppInfo],_get_cpp_info],__init__->[Component,DefaultOrderedDict]],DepCppInfo->[defines->[_aggregated_values],__getattr__->[_get_cpp_info->[],__getattr__],_get_sorted_components->[_filter_component_requires],cflags->[_aggregated_values],system_libs->[_aggregated_values],libs->[_...
Return the object with the key or create a new object with the value of the key if.
This is done in order to mimic the same behavior as ``cpp_info.name`` and have default names in components (simplifies syntax in recipe)
@@ -143,5 +143,15 @@ namespace System.IO.Strategies } } } + + public override IAsyncResult BeginRead(byte[] buffer, int offset, int count, AsyncCallback? callback, object? state) => + TaskToApm.Begin(ReadAsyncInternal(new Memory<byte>(buffer, offset, count)).AsTa...
[AsyncWindowsFileStreamStrategy->[ReadAsync->[ReadAsyncInternal,AsTask],ReadAsyncInternal->[ThrowNotSupportedException_UnreadableStream,QueueAsyncReadFile,Version,FromResult,Slice,ValueTask,HandleIOError,Length],ValueTask->[FromException,Version,WriteAsyncInternal,CompletedTask,UpdateLengthOnChangePosition,ThrowNotSupp...
This method is used to copy a file from the current position to the destination stream in asynchronous.
Nit: Can you reorganize this so that BeginWrite/EndWrite are next to each other and up with the other writing methods, and then similarly for BeginRead/EndRead?
@@ -708,7 +708,15 @@ func (fs *KBFSOpsStandard) getMaybeCreateRootNode( } err = fs.createAndStoreTlfIDIfNeeded(ctx, h) - if err != nil { + switch { + case err == nil: + case !create && err == errTryingToResetTlfIDForNonTeamTlf{}: + // We don't have TLF ID, and it's not backed by an impl team. So this + // must ...
[SyncAll->[getOps,SyncAll],GetOrCreateRootNode->[getMaybeCreateRootNode],initSyncedTlfs->[initTLFWithoutIdentifyPopups],getOpsByNode->[getOps],GetDirChildren->[getOpsByNode,GetDirChildren],GetTLFCryptKeys->[getMDByHandle],TlfHandleChange->[changeHandle],TeamAbandoned->[TeamAbandoned,findTeamByID],ClearPrivateFolderMD->...
getMaybeCreateRootNode returns the root node for a given branch if it doesn t exist yet Get the node and entry info for a given key group. if we have a FBO for this ID and we have a FBO for this ID.
we can't or aren't?