patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -46,9 +46,9 @@ describes.endtoend(
await expect(isPaused(videoElem1)).to.be.false;
await expect(isPaused(videoElem2)).to.be.true;
- // Sleep 5 seconds for the `video-percentage-played` event trigger
+ // Sleep 1 second for the `video-percentage-played` event trigger
// and the reques... | [No CFG could be retrieved] | Checks that the video box should be manipulated and pause the video if it is paused. | @micajuine-ho is it necessary that these be synchronous? Or could we play both videos at the same time and get the same behavior with only a single call to `sleep`? |
@@ -93,6 +93,15 @@ public class OMKeyRenameResponse extends OMClientResponse {
omMetadataManager.getKeyTable().putWithBatch(batchOperation,
omMetadataManager.getOzoneKey(volumeName, bucketName, toKeyName),
newKeyInfo);
+ // At this point we can also update the KeyIdTable.
+ if (ne... | [OMKeyRenameResponse->[createToKeyAndDeleteFromKey->[equals],addToDBBatch->[deleteWithBatch,getBucketName,createToKeyAndDeleteFromKey,deleteFromKeyOnly,putWithBatch,getOzoneKey,getVolumeName],checkStatusNotOK]] | Add to DB batch. | We are putting and deleting the same key from KeyID Table. The delete operation is not required here as keyId -> fromKey will be overridden with keyId -> toKey. |
@@ -59,7 +59,7 @@ const styles = theme => {
display: 'flex',
height: 40,
fontSize: 15,
- lineHeight: 24,
+ lineHeight: '24px',
padding: '0 16px',
backgroundColor: theme.palette.field02,
| [No CFG could be retrieved] | The styles for the component. Dropdown Button for Join with Dropdown Icon. | why do we use px here but not for the height for example? |
@@ -42,7 +42,7 @@ public class AtomicHashMapPessimisticConcurrencyTest extends SingleCacheManagerT
@Override
protected EmbeddedCacheManager createCacheManager() throws Exception {
ConfigurationBuilder builder = TestCacheManagerFactory.getDefaultCacheConfiguration(true);
- builder.locking().lockAcqui... | [AtomicHashMapPessimisticConcurrencyTest->[createCacheManager->[createCacheManager]]] | Creates a cache manager that is configured to manage the test cache. | well, here it is actually reducing the timeout instead of increasing it :) |
@@ -5,6 +5,7 @@
package models
import (
+ "code.gitea.io/gitea/modules/log"
"fmt"
"github.com/go-xorm/builder"
| [LoadAttachments->[loadAttachments],loadMilestones->[getMilestoneIDs],loadLabels->[getIssueIDs],LoadAttributes->[loadAttributes],LoadDiscussComments->[loadComments],loadAttributes->[loadMilestones,loadLabels,loadTotalTrackedTimes,loadAssignees,loadPullRequests,loadRepositories,loadPosters],LoadRepositories->[loadReposi... | getRepoIDs returns a list of all repositories and issues that are in the system. loadPosters loads all poster IDs from the issue list. | Wrong import order. |
@@ -203,6 +203,15 @@ export class Viewport {
}
if (viewer.getParam('webview') === '1') {
this.globalDoc_.documentElement.classList.add('i-amphtml-webview');
+ // Pages that have a <body> height of 0 (e.g. if content is in a
+ // position:absolute wrapper) will be hidden due to `overflow-x:hid... | [No CFG could be retrieved] | Initializes the AMPHTML UI. Updates the visibility of the AMP element. | Maybe `min-height: 100vh`? Also wondering why not just add this to `.i-amphtml-webview {...}` CSS in amp.css? One note: I don't believe this will be fixed with v3 SD wrapper - wrapper is only used for iframes. |
@@ -162,8 +162,9 @@ func EnsureTeam(ctx context.Context,
if !found && !dryRun {
_, err := apiClient.TeamsClient().CreateTeam(ctx, &iam_req.CreateTeamReq{
- Id: id,
- Name: name,
+ Id: id,
+ Name: name,
+ Projects: []string{},
})
if err != nil {
return false, wrapUnexpectedError(er... | [GetTeam,Wrapf,CreateTeam,AddPolicyMembers,GetTeamMembership,UpdateUser,ListPolicyMembers,SliceContains,CreateUser,AddTeamMembers,PoliciesClient,Convert,GetUser,TeamsClient,UsersClient,Code] | Check if the team has an and if so create it if it doesn t. | Why was this `projects` necessary? I would have expected it to be fine omitted |
@@ -377,7 +377,10 @@ class ClassLoader
*
* Prevents access to $this/self from included files.
*/
-function includeFile($file)
-{
- include $file;
-}
+ if(!function_exists('includeFile')) {
+ function includeFile($file)
+ {
+ include $file;
+ }
+ }
+
| [ClassLoader->[findFile->[findFileWithExtension],loadClass->[findFile]]] | Includes a file if it doesn t exist. | this won't work. The function defined in this file is not `includeFile`. It is `Composer\Autoload\includeFile` |
@@ -1377,14 +1377,6 @@ class ProperSubtypeVisitor(TypeVisitor[bool]):
def visit_union_type(self, left: UnionType) -> bool:
return all([self._is_proper_subtype(item, self.orig_right) for item in left.items])
- def visit_type_guard_type(self, left: TypeGuardType) -> bool:
- if isinstance(self.ri... | [are_args_compatible->[is_different],is_protocol_implementation->[build_subtype_kind,pop_on_exit,is_subtype],ProperSubtypeVisitor->[visit_union_type->[_is_proper_subtype],visit_callable_type->[is_callable_compatible,_is_proper_subtype],visit_typeddict_type->[_is_proper_subtype],visit_instance->[check_argument->[_is_pro... | Check if the union type is a sub - type of the union type. | So just to clarify, what is the view on subtyping between type guard functions? Can a type guard method be overridden in a subclass? Can a type guard function be expected as a callback? |
@@ -425,10 +425,9 @@ void _internal_move_to_destination(const_feedRate_t fr_mm_s/*=0.0f*/
planner.e_factor[active_extruder] = 1.0f;
#endif
- if (TERN0(IS_KINEMATIC, is_fast))
- TERN(IS_KINEMATIC, NOOP, prepare_line_to_destination());
- else
- prepare_line_to_destination();
+ //if (TERN0(IS_KINEMATIC,... | [No CFG could be retrieved] | Internal method for moving a node to a different destination. This function is called by the move_to function in the planner buffer. It is called. | this doesn't seems right. |
@@ -4,6 +4,17 @@ class ServiceProviderSessionDecorator
DEFAULT_LOGO = 'generic.svg'.freeze
+ SP_ALERTS = {
+ 'CBP Trusted Traveler Programs' => {
+ i18n_name: 'trusted_traveler',
+ learn_more: 'https://login.gov/help/trusted-traveler-programs/sign-in-doesnt-work/',
+ },
+ 'USAJOBS' => {
+ ... | [ServiceProviderSessionDecorator->[request_url->[url],sp_name->[friendly_name,agency],cancel_link_url->[sign_up_start_url],verification_method_choice->[t],return_to_service_provider_partial->[present?],sp_logo->[logo],sp_agency->[friendly_name,agency],sp_return_url->[present?,return_to_sp_url,decline_redirect_uri,valid... | Initializes the object with the values specified. | Are we planning on creating a new help page for USA Jobs? Is that why there is no URL configured here? If so, we should wait until that page is ready before merging this, right? |
@@ -331,3 +331,15 @@ func (c *CmdStatus) sessionStatus(s *keybase1.SessionStatus) string {
return fmt.Sprintf("%s [loaded: %s, cleared: %s, expired: %s]", s.SessionFor, BoolString(s.Loaded, "yes", "no"), BoolString(s.Cleared, "yes", "no"), BoolString(s.Expired, "yes", "no"))
}
+
+// ExecToString returns the space-... | [ParseArgv->[Args,Bool],outputJSON->[MarshalIndent,G,Printf,GetDumbOutputUI],output->[outputTerminal,outputJSON],client->[Printf,G,VersionString,GetDumbOutputUI],sessionStatus->[Sprintf],outputTerminal->[Printf,Join,DeviceStatusToString,G,GetDumbOutputUI,outputClients],Run->[output,load],load->[Join,GetCurrentStatus,G,... | sessionStatus returns a string representation of a session status. | This could be private `execToString` if only used in this package |
@@ -528,6 +528,9 @@ dc_obj_shard_rw(struct dc_obj_shard *shard, enum obj_rpc_opc opc,
rw_args.shard_args = args;
/* remember the sgl to copyout the data inline for fetch */
rw_args.rwaa_sgls = (opc == DAOS_OBJ_RPC_FETCH) ? sgls : NULL;
+ rw_args.maps = args->api_args->maps;
+ if (rw_args.maps != NULL)
+ orw->orw... | [No CFG could be retrieved] | This function is called from the OIA code to populate the OIA object. Reads the object from the pool and sends it to the server. Get the version of the map. | we may define ORF_IOM_ALL and ORF_IOM_LOHI to differentiate that user may only want to know the lo/hi (need not transfer all recx in that case). but can be added later (I can make the change in my patch later) |
@@ -27,5 +27,13 @@ namespace Dynamo.Extensions
return dynamoModel.Workspaces;
}
}
+
+ public IWorkspaceModel CurrentWorkspace
+ {
+ get
+ {
+ return dynamoModel.CurrentWorkspace;
+ }
+ }
}
}
| [ReadyParams->[Workspaces]] | Get the list of workspaces. | Please rename this to `CurrentWorkspaceModel`. This will help to distinguish it from a proposed property on the same type, `CurrentWorkspaceViewModel.` |
@@ -38,6 +38,15 @@
<%= form.check_box :is_top_level_path %>
<p>(Determines if it is accessible by <code>/page-slug</code> vs <code>/page/page-slug</code>) Be careful! ⚠️</p>
</div>
+ <% unless Rails.env.production? %>
+ <div class="form-group">
+ <%= form.label :use_partial... | [No CFG could be retrieved] | Hides the hidden input field and the hidden checkboxes. | This feature doesn't work with the `top level path` option: when I turn on `WIP` and `Top level path`, visiting `/<page_name` gives me an error |
@@ -78,4 +78,4 @@ class LabelField(Field[numpy.ndarray]):
@overrides
def empty_field(self):
- return LabelField(0, self._label_namespace)
+ return LabelField(-1, self._label_namespace)
| [LabelField->[as_array->[asarray],empty_field->[LabelField],index->[get_token_index],__init__->[type,endswith,format,isinstance,warning,ConfigurationError]],getLogger] | Returns an empty label field. | Also this one? |
@@ -245,7 +245,7 @@ class JavacCompile(JvmCompile):
if f.endswith(".java")
)
- exec_process_request = ExecuteProcessRequest(
+ exec_process_request = Process(
argv=tuple(cmd),
input_files=input_snapshot.directory_digest,
output_files=output_fi... | [JavacCompile->[javac_classpath->[global_javac_classpath],prepare->[super],_create_context_jar->[safe_walk,write,open_jar,fast_relpath,join],register_options->[super],_javac_plugin_args->[append,",join,items,TaskError],select_source->[endswith],compile->[Path,any,output,safe_args,preferred_jvm_distribution,get_options,... | Execute the compile with the given command. | Consider renaming these variables to either `process` or `process_request`. Ditto on all the other call sites in this PR. (Sorry, I know this is tedious) |
@@ -1530,6 +1530,14 @@ static int tls_early_post_process_client_hello(SSL *s, int *al)
goto err;
}
+ /* TLSv1.3 defines that a ClientHello must end on a record boundary */
+ if (SSL_IS_TLS13(s) && RECORD_LAYER_processed_read_pending(&s->rlayer)) {
+ *al = SSL_AD_UNEXPECTED_MESSAGE;
+ ... | [No CFG could be retrieved] | The protocol negotiation function. finds the n - tuple of the n - tuple of the n - tuple of the. | requires or specifies or says, not defines? |
@@ -65,6 +65,7 @@ class LocalAgent(Agent):
env_vars = self.populate_env_vars(flow_run=flow_run)
if not self.no_pull:
+ self.logger.debug("Pulling image {}...".format(storage.name))
try:
self.docker_client.pull(storage.name)
... | [LocalAgent->[deploy_flows->[populate_env_vars,create_container,error,start,get,format,isinstance,pull,StorageSchema],__init__->[exception,ping,get,APIClient,super]],LocalAgent] | Deploy a list of flow runs on your local machine as Docker containers. | So this will be logged every time even if the image already exists locally. If you're cool with that we can leave it |
@@ -174,5 +174,12 @@ func (q Q) GetNamed(sql string, dest interface{}, arg interface{}) error {
}
ctx, cancel := q.Context()
defer cancel()
+ q.logSql(query, args...)
return errors.Wrap(q.GetContext(ctx, dest, query, args...), "error in get query")
}
+
+func (q Q) logSql(query string, args ...interface{}) {
+ ... | [Get->[Context],ExecQIter->[Context],ExecQ->[ExecQIter],Transaction->[Context],GetNamed->[Context],ExecQNamed->[ExecQ],Select->[Context]] | GetNamed executes a named query with the given arguments and stores the result in dest. | I think `lggr` should probably be required so that we don't miss anything by mistake. |
@@ -38,7 +38,7 @@ module.exports = {
* @param passedConfiguration the object having the keys:
* - entities: the entities to exporters,
* - forceNoFiltering: whether to filter out unchanged entities,
- * - skipEntityFilesGeneration: whether to skip file write to disk,
+ * - skipFileGene... | [No CFG could be retrieved] | Exports the passed entities to JSON in the applications. Export a file to a file system. | The function is deprecated, I'll be removing them in a PR soon. No need to update it. |
@@ -54,6 +54,9 @@ module Api
elsif param_user_type == 'testserver'
user_class = TestServer
user_type = User::TEST_SERVER
+ elsif param_user_type == 'teststudent'
+ user_class = TestStudent
+ user_type = User::TEST_STUDENT
else # Unknown user type, Invalid HTTP params.
... | [UsersController->[create->[nil?,render,new,downcase,process_attributes,type,has_missing_params?,find_by_user_name,save,delete],show->[xml,nil?,render,respond_to,to_json,json,to_xml,find_by_id],update_by_username->[nil?,render,attributes,process_attributes,has_missing_params?,find_by_user_name,save],process_attributes-... | Creates a new user based on the user_name type first_name last_name. | This can be removed. Test Students should only ever be used internally |
@@ -1122,3 +1122,10 @@ function jetpack_do_subscription_form( $instance ) {
$output = ob_get_clean();
return $output;
}
+
+jetpack_register_block( 'subscriptions', array( 'render_callback' => 'show_subscription_block' ) );
+
+function show_subscription_block( $attr, $content ) {
+ $attr['show_only_email_and_button... | [Jetpack_Subscriptions->[set_post_flags->[should_email_post_to_subscribers],get_settings->[get_default_settings]],Jetpack_Subscriptions_Widget->[form->[defaults,fetch_subscriber_count]]] | This function is used to render the Jetpack_Subscriptions_Widget in a Jet. | I would recommend that you prefix that function to avoid potential conflicts with other plugins and themes. |
@@ -467,7 +467,7 @@ define([
* @private
*/
function isInternalToParallelSide(side, cut) {
- return cut.magnitude() < side.magnitude();
+ return Cartesian2.magnitude(cut) < Cartesian2.magnitude(side);
}
/**
| [No CFG could be retrieved] | Provides next vertex in some direction and validates that it is on the parallel side. Checks to make sure that a vertex is not superfluous. | The doc says that these are `Cartesian3`s but the z component is always zero so I think this is fine. Can you change the doc? |
@@ -43,7 +43,17 @@ static int eckey_param2type(int *pptype, void **ppval, EC_KEY *ec_key)
pstr = ASN1_STRING_new();
if (pstr == NULL)
return 0;
- pstr->length = i2d_ECParameters(ec_key, &pstr->data);
+
+ /*
+ * The cast in the following line is intentional as the
+ ... | [int->[EVP_PKEY_CTX_set_ecdh_kdf_md,EVP_CIPHER_CTX_type,ASN1_STRING_length,ECPKParameters_print,i2d_X509_ALGOR,do_EC_KEY_print,ec_bits,EC_GROUP_dup,EVP_PKEY_CTX_set_ecdh_kdf_outlen,i2o_ECPublicKey,i2d_ECPrivateKey,EC_KEY_get0_group,ASN1_STRING_get0_data,EC_KEY_get_conv_form,OPENSSL_clear_free,EC_KEY_set_enc_flags,EVP_P... | EC key parameter 2 type conversion. | typo, s/consitfication/constification/ ? I am not sure of that is an english word... |
@@ -35,7 +35,7 @@ public interface TransactionParticipant {
void buffer(SinkRecord record);
- void processRecords();
+ void processRecords() throws IOException;
TopicPartition getPartition();
| [No CFG could be retrieved] | This method is called when a sink record is available. | its better if all interfaces throw a unchecked hudi exception, |
@@ -10,15 +10,15 @@
<% end %>
<h1>
- <%= t('idv.titles.session.review') %>
+ <%= t('idv.titles.session.review', app_name: APP_NAME) %>
</h1>
<p>
- <%= t('idv.messages.sessions.review_message') %>
+ <%= t('idv.messages.sessions.review_message', app_name: APP_NAME) %>
</p>
<%= new_window_link_to(
- t... | [No CFG could be retrieved] | Renders the IDV - review page. Renders a list of users with a link to start over or cancel. | Couple more in `spec/features/idv/steps/phone_otp_verification_step_spec.rb` which need interpolated argument. |
@@ -332,7 +332,7 @@ public class UserIdentityAuthenticatorTest {
@Test
public void ignore_groups_on_non_default_organizations() throws Exception {
- OrganizationDto org = db.organizations().insert(newOrganizationDto());
+ OrganizationDto org = db.organizations().insert();
UserDto user = db.users().in... | [UserIdentityAuthenticatorTest->[authenticate->[authenticate]]] | Adding a group to non - default organizations. | @julienlancelot @sns-seb do we know how this feature will support organizations ? |
@@ -2788,13 +2788,13 @@ public class SchedV2 extends AbstractSched {
public void randomizeCards(long did) {
- List<Long> cids = mCol.getDb().queryLongList("select id from cards where did = ?", did);
+ List<Long> cids = mCol.getDb().queryLongList("select id from cards where type = " + Consts.CARD_... | [SchedV2->[_resetRevCount->[_resetRevCount,_currentRevLimit,currentCardId],haveBuried->[haveBuriedSiblings,haveManuallyBuried],counts->[counts,resetCounts],deckDueTree->[deckDueTree,deckDueList],_previewingCard->[_cardConf],_constrainedIvl->[_fuzzedIvl],_resetLrn->[_resetLrnCount],eta->[getDayCutoff,eta],_newConf->[_ca... | Randomize cards. | Not important, but I want to note it for posterity. I spent hours replacing 0 by CARD_TYPE_NEW and other numbers by other constants. I'm am really really happy to see somebody else using it and getting readable code thanks to it! |
@@ -255,6 +255,12 @@ func (handler *ContainersHandlersImpl) RemoveContainerHandler(params containers.
case exec.RemovePowerError:
return containers.NewContainerRemoveConflict().WithPayload(&models.Error{Message: err.Error()})
default:
+ if f, ok := err.(types.HasFault); ok {
+ switch f.Fault().(type) {
+... | [CreateHandler->[Create,Unix,Error,Begin,GenerateKey,GetBuild,Background,New,Now,UTC,End,WithPayload,String,Errorf,NewCreateOK,MarshalPKCS1PrivateKey,NewCreateNotFound,EncodeToMemory],GetContainerStatsHandler->[Begin,NewGetContainerStatsNotFound,Unsubscribe,NewEncoder,Background,End,NewOperation,WithPayload,Container,E... | RemoveContainerHandler - remove container handler. | Why are we returning a 501 here? |
@@ -522,7 +522,7 @@ static int kpb_prepare(struct comp_dev *dev)
if (!kpb->sel_sink || !kpb->host_sink) {
comp_info(dev, "kpb_prepare(): could not find sinks: sel_sink %d host_sink %d",
- (uint32_t)kpb->sel_sink, (uint32_t)kpb->host_sink);
+ (uintptr_t)kpb->sel_sink, (uintptr_t)kpb->host_sink);
ret = ... | [No CFG could be retrieved] | Allocate memory of a history buffer. Reclaim memory of a key phrase buffer. | The tricky part with this approach is that when building for 64 bits, it will only print the lower 32 bits. But, I'm ok with the change. |
@@ -40,6 +40,8 @@ ARGS_PLOT_DATAFRAME = (ARGS_COMMON + ARGS_STRATEGY +
ARGS_PLOT_PROFIT = (ARGS_COMMON + ARGS_STRATEGY +
["pairs", "timerange", "export", "exportfilename", "db_url", "trade_source"])
+NO_CONF_REQURIED = ["start_download_data"]
+
class Arguments(object):
"""
| [Arguments->[_build_subcommands->[_build_args],get_parsed_arg->[_load_args]]] | Initialize a new object. Creates an argparse. Namespace instance for the given command line arguments. | It may be a list of RunMode's (RunMode.DownloadData, RunMode.ListPairs etc.) corresponding to subcommands and, therefore, to the start_* functions. This just a note, I'm not sure if this is better than this list... |
@@ -91,6 +91,12 @@ class Work < ActiveRecord::Base
joins("LEFT OUTER JOIN items ON items.work_id = works.id").where("items.id IS NULL")
}
+ # リリース時期が最近のものから順に並べる
+ scope :order_latest, -> {
+ joins(:season).
+ order("seasons.sort_number DESC, works.id DESC")
+ }
+
# 作品のエピソード数分の空白文字列が入った配列を返す
# ... | [Work->[comments_count->[where,pluck,count],channels->[present?,where,uniq,pluck],chart_labels->[map],broadcast_on_nicoch?->[present?],chart_values->[pluck],checkins_count->[presence],current_season?->[present?,slug],release_date->[presence],next_season?->[present?,slug],transitions,aasm,state,include,has_paper_trail,s... | Returns the labels of all episodes in the chart. | Use 2 (not 0) spaces for indenting an expression spanning multiple lines. |
@@ -83,6 +83,15 @@ MiddlewareRegistry.register(store => next => action => {
break;
}
+ case SET_PRESENTER_MUTED:
+ if (!action.muted
+ && isUserInteractionRequiredForUnmute(store.getState())) {
+ return;
+ }
+
+ _setMuted(store, action, MEDIA_TYPE.PRESEN... | [No CFG could be retrieved] | Handles the case where no data is present in the store. This function is a custom function which can be used to switch between the cameras via a. | I don't think you technically need this check, but I guess it's good to have it to be safe? But I guess if you follow Saul's suggestions this'll get merged with the video muted flows anyway somehow. |
@@ -41,6 +41,7 @@ class MedraSettingsForm extends DOIExportSettingsForm {
$this->addCheck(new FormValidatorInSet($this, 'publicationCountry', FORM_VALIDATOR_REQUIRED_VALUE, 'plugins.importexport.medra.settings.form.publicationCountry', array_keys($this->_getCountries())));
// The username is used in HTTP basic au... | [MedraSettingsForm->[display->[assign,_getCountries],_getCountries->[getCountries]]] | This class creates the MedraSettingsForm object. | Once the CSRF stuff is merged in, we'll need to add the CSRF checks to the code in this PR too -- let's talk about that later. |
@@ -501,12 +501,6 @@ void getItemMesh(Client *client, const ItemStack &item, ItemMesh *result)
const ContentFeatures &f = ndef->get(def.name);
content_t id = ndef->getId(def.name);
- if (!g_extrusion_mesh_cache) {
- g_extrusion_mesh_cache = new ExtrusionMeshCache();
- } else {
- g_extrusion_mesh_cache->grab();
... | [ISceneNode->[createCube],setExtruded->[create],setItem->[createSpecialNodeMesh,setCube,setExtruded],changeToMesh->[createCube],setCube->[createCube],getExtrudedMesh->[create],getItemMesh->[createCube,createSpecialNodeMesh]] | Get the item mesh for an item stack. This function is called from the texture_load code to load the texture. This method is called from the video framework to populate the buffer with the data from the mesh. | Could you please either add `FATAL_ERROR_IF(!g_extrusion_mesh_cache, "Extrusion mesh cache is not yet initialized");` or `assert(g_extrusion_mesh_cache)`? This function is not part of a class, which means that it could be called before the global is initialized. |
@@ -2566,9 +2566,15 @@ func (a *apiServer) deletePipeline(ctx context.Context, request *pps.DeletePipel
}
}
- // Delete PipelineInfo
+ // Delete all past PipelineInfos
if err := dbutil.WithTx(ctx, a.env.GetDBClient(), func(sqlTx *sqlx.Tx) error {
- return a.pipelines.ReadWrite(sqlTx).Delete(request.Pipeline.N... | [stopAllJobsInPipeline->[stopJob],CreatePipelineInTransaction->[initializePipelineInfo,authorizePipelineOpInTransaction,fixPipelineInputRepoACLsInTransaction],getLogsLoki->[authorizePipelineOp],SubscribeJob->[getJobDetails],GetLogs->[GetLogs,authorizePipelineOp],UpdateJobStateInTransaction->[UpdateJobState],ActivateAut... | deletePipeline deletes a pipeline stop a pipeline Wait waits for all the tasks to complete and then deletes the pipeline repository and branch if necessary Create a branch in the system repo. | So pipelines start at version 1? Will there ever be gaps between existing pipeline version numbers? |
@@ -35,10 +35,10 @@ namespace Internal.Cryptography.Pal
TimeSpan timeout,
bool disableAia)
{
- // An input value of 0 on the timeout is "take all the time you need".
+ // An input value of 0 on the timeout is treated as 15 seconds, to match Windows.
... | [ChainPal->[IChainPal->[SaveIntermediateCertificates,Certificate,FindChainViaAia,SafeHandle,CommitToChain,Pal,Assert,Zero,ProcessRevocation,ToLocalTime,IsCompleteChain,X509_V_OK,CurrentUser,ReferenceEquals,Dispose,Disallowed,MaxValue,NoCheck,Utc,Finish,FindFirstChain,Kind,ReadOnly,InitiateChain,Length],SaveIntermediate... | Builds a chain of certificates. private private final boolean status = 0 ;. | Shouldn't there also be an "if it's bigger than 15 seconds, clamp it"? (Or one minute, or whatever it is) |
@@ -268,10 +268,12 @@ vdev_file_io_start(zio_t *zio)
zio_execute(zio);
return;
} else if (zio->io_type == ZIO_TYPE_TRIM) {
- int mode;
+ int mode = 0;
ASSERT3U(zio->io_size, !=, 0);
+#ifdef __linux__
mode = FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE;
+#endif
zio->io_error = zfs_file_fallocate(vf->v... | [No CFG could be retrieved] | Reads and writes the specified number of bytes from the specified file. Declare the methods related to the vdev file. | Is the `__linux__` needed here? This file is already part of Linux platform code where we're allowed to do platform specific things. |
@@ -166,14 +166,8 @@ public abstract class Wrapper {
int len = m.getParameterTypes().length;
c3.append(" && ").append(" $3.length == ").append(len);
- boolean overload = false;
- for (Method m2 : methods) {
- if (m != m2 && m.getName()... | [Wrapper->[hasMethod->[getMethodNames],setPropertyValues->[setPropertyValue],getPropertyValues->[getPropertyValue],args->[arg],Wrapper]] | Creates a wrapper for the given class. Finds and adds a new method which does not have a signature. Creates a new instance of the class with the same name as c and adds it to dm Creates a new class with a few fields that can be used to create a new object with Returns a new object that wraps the named constructor with ... | this situation should be `overload` |
@@ -169,13 +169,14 @@ public class ContainerStateMachine extends BaseStateMachine {
int numPendingRequests = conf
.getObject(DatanodeRatisServerConfig.class)
.getLeaderNumPendingRequests();
- int pendingRequestsByteLimit = (int) conf.getStorageSize(
+ int pendingRequestsMegaBytesLimit = (in... | [ContainerStateMachine->[takeSnapshot->[persistContainerSet,isStateMachineHealthy],applyTransaction->[getContainerCommandRequestProto,submitTask],readStateMachineData->[dispatchCommand],notifyGroupRemove->[notifyGroupRemove],notifyTermIndexUpdated->[updateLastApplied],write->[getContainerCommandRequestProto,handleWrite... | Creates a new instance of the container state machine. This is a private class that can be used to create a state machine storage object that is. | Question if data.size() is in bytes, this conversion will yield to zero? And what locks we acquire for the bytes limit? |
@@ -180,12 +180,13 @@ namespace Content.Client.GameObjects.Components.Instruments
case InstrumentMidiEventMessage midiEventMessage:
// If we're the ones sending the MidiEvents, we ignore this message.
if (!IsRendererAlive || IsInputOpen || IsMidiOpen) break;
- ... | [InstrumentComponent->[CloseInput->[EndRenderer,CloseInput],HandleComponentState->[HandleComponentState,SetupRenderer,EndRenderer],HandleNetworkMessage->[HandleNetworkMessage],Initialize->[Initialize],ExposeData->[ExposeData],OpenMidi->[SetupRenderer,OpenMidi],CloseMidi->[CloseMidi,EndRenderer],Shutdown->[Shutdown,EndR... | Override to handle a message that is not part of the network message. | Make the delay a constant. |
@@ -103,6 +103,10 @@ func (node *OsdnNode) handleDeleteHostSubnet(obj interface{}) {
if hs.HostIP == node.localIP {
return
}
+ if _, exists := node.hostSubnetMap[string(hs.UID)]; !exists {
+ return
+ }
+
delete(node.hostSubnetMap, string(hs.UID))
node.DeleteHostSubnetRules(hs)
| [SubnetStartNode->[watchSubnets],updateVXLANMulticastRules->[UpdateVXLANMulticastFlows,HandleError,Errorf],handleDeleteHostSubnet->[V,updateVXLANMulticastRules,Infof,DeleteHostSubnetRules],handleAddOrUpdateHostSubnet->[Infof,updateVXLANMulticastRules,ValidateNodeIP,Warningf,DeleteHostSubnetRules,V,AddHostSubnetRules],g... | handleDeleteHostSubnet deletes a HostSubnet object from the network. | Can we still delete the rules for the subnet portion? Just skip the host part of the openflow? I am not sure if those rules are really non-existent, while we clearly do not want the host part to be deleted of course. |
@@ -14,6 +14,7 @@ class SamlIdpController < ApplicationController
before_action :validate_saml_logout_param, only: :logout
before_action :store_sp_data, only: :auth
before_action :authenticate_user!, except: [:metadata, :logout]
+ before_action :confirm_two_factor_setup, only: :auth
before_action :confirm_... | [SamlIdpController->[store_sp_data->[merge!,blank?,identifier],requested_authn_context->[info,content,length],prepare_saml_logout_response->[new],relay_state_params->[parse,fetch,unescape],store_saml_request_in_session->[original_url],disable_caching->[headers],render_template_for->[render],logout_response_builder->[re... | Renders the missing authentication context exception. | Seems like there should be some way to avoid duplicating this list. But I'm happy to land this change as is for now. |
@@ -36,6 +36,9 @@ type PodConfig struct {
// If true, all containers joined to the pod will use the pod cgroup as
// their cgroup parent, and cannot set a different cgroup parent
UsePodCgroup bool
+
+ // Time pod was created
+ CreatedTime time.Time `json:"created"`
}
// podState represents a pod's state
| [Kill->[ID],Stop->[ID],refresh->[ID,save],Status->[ID],Start->[ID]] | libpod import imports a single pod from the library PodCgroup returns whether the pod s is the default cgroup or not. | Needs a JSON tag |
@@ -127,6 +127,11 @@ func encodeDurationMs(d int64) string {
return strconv.FormatFloat(float64(d)/float64(time.Second/time.Millisecond), 'f', -1, 64)
}
+func msToTime(t int64) time.Time {
+ const msPerS = int64(time.Second / time.Millisecond)
+ return time.Unix(t/msPerS, t%msPerS)
+}
+
const statusSuccess = "suc... | [MarshalJSON->[Marshal,FromLabelAdaptersToMetric],toHTTPResponse->[StartSpanFromContext,NewBuffer,Error,Finish,Int,Marshal,NopCloser,Log,LogFields],UnmarshalJSON->[FromMetricsToLabelAdapters,Unmarshal],toHTTPRequest->[WithContext,Encode,String],StartSpanFromContext,LogFields,Strings,Error,Int,FormatFloat,Errorf,FormVal... | parseQueryRangeResponse returns the last known timestamp in milliseconds or an error if the request is UnmarshalJSON unmarshals a JSON response to a . | I used Prometheus `timestamp.Time()` for this in #1312 - we should be consistent. |
@@ -186,8 +186,9 @@ class RemoteGDrive(RemoteBASE):
}
else:
GoogleAuth.DEFAULT_SETTINGS["client_config"] = {
- "client_id": self._client_id,
- "client_secret": self._client_secret,
+ "client_id": self._client_id or self.DEFAULT_GDRIVE_CLIEN... | [RemoteGDrive->[_upload->[gdrive_upload_file,_get_remote_id],_delete_remote_file->[_location],_cache_path->[cache],gdrive_create_dir->[cache,_cache_path],_get_remote_id->[GDrivePathNotFound,_path_to_remote_ids],gdrive_list_item->[gdrive_retry],_download->[_get_remote_id,gdrive_download_file],exists->[_get_remote_id],dr... | Initialize a new GoogleDrive object. Returns a new object if the user has access to the Google Drive API. | auto formatted this way? |
@@ -22,6 +22,7 @@ from pants.option.global_options import GlobalOptionsRegistrar
from pants.util.contextutil import temporary_dir
from pants.util.dirutil import safe_mkdir, safe_open
from pants.util.memo import memoized_property
+from pants.util.strutil import ensure_text
from pants.version import PANTS_SEMVER
| [PluginResolver->[_resolve_plugins->[resolve],resolve->[_is_wheel,_activate_wheel]]] | Creates a new object that represents a single unique object in the system. Initialize a object. | This was breaking with `newstr does not support decode`, which kind of makes sense. |
@@ -53,10 +53,10 @@ func (q *chunkStoreQuerier) Select(_ bool, sp *storage.SelectHints, matchers ...
// Series in the returned set are sorted alphabetically by labels.
func partitionChunks(chunks []chunk.Chunk, mint, maxt int64, iteratorFunc chunkIteratorFunc) storage.SeriesSet {
- chunksBySeries := map[model.Finge... | [Select->[Get,ErrSeriesSet,Time,ExtractOrgID],Iterator->[chunkIteratorFunc,Time],QueryableFunc,Fingerprint,NewConcreteSeriesSet] | Select returns a set of series that match the given filters. LabelValues returns a slice of the names of the chunks in the store. | Can we make this function to some utils or "client" package where other fingerprinting functions are? |
@@ -280,13 +280,11 @@ func (b *localBackend) DoesProjectExist(ctx context.Context, projectName string)
func (b *localBackend) CreateStack(ctx context.Context, stackRef backend.StackReference,
opts interface{}) (backend.Stack, error) {
- if cmdutil.IsTruthy(os.Getenv(PulumiFilestateLockingEnvVar)) {
- err := b.Loc... | [GetHistory->[Name],CreateStack->[Name],ExportDeployment->[Name],GetStack->[Name],RenameStack->[Name,RenameStack,ParseStackReference],ListStacks->[ParseStackReference],RemoveStack->[Name],ImportDeployment->[Name],GetLogs->[Name],apply->[Name,Refresh,Update,Destroy,Import,String],Watch->[Watch],GetLogs,String] | CreateStack creates a new stack. | This is actually covered by `TestListStacksWithMultiplePassphrases` |
@@ -260,9 +260,9 @@ namespace System.Net.Security
}
}
- if (inputBuffer.Array != null && inputBuffer.Count > 0)
+ if (inputBuffer != null && inputBuffer.Length > 0)
{
- sslContext.Write(inputBuffer.Array, inputBuff... | [SslStreamPal->[GetNegotiatedApplicationProtocol->[SslGetAlpnSelected,SslContext],QueryContextConnectionInfo->[SslContext],SecurityStatusPal->[IsInvalid,BytesReadyForConnection,ContextExpired,Count,IsServer,HandshakeInternal,PerformHandshake,ServerAuthCompleted,Pin,SslHandshake,CreateExceptionForOSStatus,ReadPendingWri... | Internal method for doing the SSL handshake. | The `inputBuffer` span will never be null. The `inputBuffer != null &&` should be removed. |
@@ -169,6 +169,17 @@ void generate_fem1d_graph(size_t numLocalNodes, RCP<const Comm<int> > comm , Gra
pack.element2node[i][0] = pack.uniqueMap->getGlobalElement(i);
pack.element2node[i][1] = pack.uniqueMap->getGlobalElement(i) + 1;
}
+
+ // Kokkos version of the element2node array
+ Kokkos::resize(pack.k... | [No CFG could be retrieved] | Generate FEM1D graph for a given set of unique elements. This method checks if the given n - tuple has a valid type and if so creates a. | Do you actually need the fence here? It depends on what you do next. |
@@ -578,6 +578,9 @@ module.exports = JhipsterServerGenerator.extend({
if (this.applicationType !== 'microservice' && !(this.applicationType === 'gateway' && this.authenticationType === 'uaa')) return;
this.template(SERVER_MAIN_SRC_DIR + 'package/config/_MicroserviceSecurityConfiguration.java... | [No CFG could be retrieved] | This function renders the template files for the server main. Create the bootstrap - prod. yml files and write the server s Java app files. | space between `if (` |
@@ -1359,6 +1359,10 @@ module.exports = class Exchange {
return this.safeValue (units, decimals)
}
+ addFloat (value1, value2) {
+ return parseFloat (BigNumber (value1).plus (value2));
+ }
+
fromWei (amount, unit = 'ether', decimals = 18) {
if (amount === undefined) {
... | [No CFG could be retrieved] | 2016 - 11 - 15 Get the unit of nanoseconds. | There's a `this.sum` function for this, do we really need a new method? |
@@ -111,6 +111,7 @@ class RepositoryManager
* @param array $config repository configuration
* @param string $name repository name
* @throws \InvalidArgumentException if repository for provided type is not registered
+ * @throws \ReflectionException
... | [RepositoryManager->[findPackages->[findPackages],findPackage->[findPackage]]] | Creates a repository of the given type. | `\ReflectionException` is not thrown in this body. |
@@ -97,7 +97,7 @@ namespace System.Reflection.PortableExecutable
/// <exception cref="ArgumentException"><paramref name="pdbPath"/> contains NUL character.</exception>
/// <exception cref="ArgumentOutOfRangeException"><paramref name="age"/> is less than 1.</exception>
/// <exception cref="Arg... | [DebugDirectoryBuilder->[AddPdbChecksumEntry->[AddEntry],AddCodeViewEntry->[AddEntry,AddCodeViewEntry],AddReproducibleEntry->[AddEntry],AddEntry->[AddEntry]]] | Adds a code view entry to the directory. | Do we already have sufficient tests for this? How's code coverage? @carlossanlop how come it didn't get auto-labelled as new API needing docs? |
@@ -4327,7 +4327,8 @@ class TestReview(ReviewBase):
# ignoring the interim version because it was auto-approved and not
# manually confirmed by a human.
expected = [
- reverse('files.compare', args=[new_file.pk, first_file.pk]),
+ code_manager_url('compare', self.addon.p... | [QueueTest->[get_expected_addons_by_names->[generate_files],generate_file->[generate_files],_test_results->[get_addon_latest_version],setUp->[login_as_reviewer]],TestWhiteboard->[test_whiteboard_addition->[login_as_reviewer],test_whiteboard_addition_unlisted_addon->[login_as_reviewer],test_whiteboard_addition_content_r... | Test if link auto - approved and not ignored. Get a from the server. | would be nice to have named parameters here too |
@@ -392,6 +392,12 @@ func NewApp(client *Client) *cli.App {
},
},
},
+ {
+ Name: "hard-reset",
+ Usage: "Removes unstarted transactions, cancels pending transactions as well as deletes job runs. Use with caution, this command cannot be reverted! Only execute when the node is not started!... | [ReplaceAll,Sprintf,FeatureExternalInitiators,NewApp,Dev,MustCompile,Bool] | A list of commands that can be performed on a node s key. Commands for managing the authentication keys. | Don't need this extra space. |
@@ -0,0 +1,14 @@
+from django.contrib.auth.tokens import PasswordResetTokenGenerator
+
+
+class AccountDeleteTokenGenerator(PasswordResetTokenGenerator):
+ def _make_hash_value(self, user, timestamp):
+ # Override this method to remove the user `last_login` value from the hash.
+ # As this token is use... | [No CFG could be retrieved] | No Summary Found. | I am not sure to have explicit values in a hash is a good way. In this case only password is hashed. Is it hashed somewhere further by framework? |
@@ -10,9 +10,10 @@ class RRcppcnpy(RPackage):
"""Rcpp bindings for NumPy files."""
homepage = "https://github.com/eddelbuettel/rcppcnpy"
- url = "https://cran.r-project.org/src/contrib/RcppCNPy_0.2.9.tar.gz"
- list_url = "https://cran.rstudio.com/src/contrib/Archive/RcppCNPy"
+ url = "htt... | [RRcppcnpy->[depends_on,version]] | Rcpp bindings for NumPy files. | I don't actually see the cnpy dependency mentioned anywhere, is it something that links to a system installation if it's available and compiles a vendored copy if not? |
@@ -441,6 +441,8 @@ public class RpcClient implements ClientProtocol {
verifyVolumeName(volumeName);
verifyBucketName(bucketName);
Preconditions.checkNotNull(bucketArgs);
+ verifyCountsQuota(bucketArgs.getQuotaInCounts());
+ verifySpaceQuota(bucketArgs.getQuotaInBytes());
Boolean isVersionEn... | [RpcClient->[completeMultipartUpload->[verifyVolumeName,verifyBucketName,completeMultipartUpload],getKey->[verifyVolumeName,verifyBucketName],initiateMultipartUpload->[verifyVolumeName,verifyBucketName,initiateMultipartUpload],deleteBucket->[verifyVolumeName,verifyBucketName,deleteBucket],abortMultipartUpload->[verifyV... | Create a new bucket with the specified parameters. | `createBucket` verifies quota args, but `createVolume` does not. Is this intentional? |
@@ -62,6 +62,17 @@ public class AttributeEvaluator
}
}
+ private boolean isParseExpression(String attributeValue)
+ {
+ final int beginExpression = attributeValue.indexOf("#[");
+ if (beginExpression == -1)
+ {
+ return false;
+ }
+ String remainingStr... | [AttributeEvaluator->[resolveValue->[isParseExpression,isExpression],resolveIntegerValue->[resolveValue],resolveStringValue->[resolveValue]]] | Resolve the attribute type. | both ExpressionManager and ExpressionLanguage have methods to do this. Why a new one? |
@@ -205,6 +205,7 @@ public class ReactiveInterceptorAdapterTestCase extends AbstractMuleContextTestC
assertThat(((InternalEvent) result).getInternalParameters().entrySet(), hasSize(0));
verifyParametersResolvedAndDisposed(times(1));
+ verify(interceptor, atLeastOnce()).getClass().getClassLoader();
... | [ReactiveInterceptorAdapterTestCase->[interceptorThrowsExceptionAroundAfterProceedInCallback->[prepareInterceptor,after,before,around],firstInterceptorFailsAround->[prepareInterceptor,after,before,around],firstInterceptorThrowsExceptionAroundAfterProceed->[prepareInterceptor,after,before,around],firstInterceptorThrowsE... | interceptorApplied method. in order to verify that there is no in - order event in order to process the event. | create a different set of test cases to assert this specifically, |
@@ -155,12 +155,12 @@ public final class HmacSha512AuthenticatorTest {
final String name = "name";
final Map<String, String> properties = ImmutableMap.of(name, "NOT_A_BASE64_VALUE");
- catchException(() -> HmacSha512Authenticator.decodeOptionalProperty(properties, name));
- assertThat(caughtExceptio... | [HmacSha512AuthenticatorTest->[newResponse_ShouldNotIncludeResponseWhenChallengeDoesNotContainNonce->[newBase64String],newResponse_ShouldIncludeResponseWhenChallengeContainsNonceAndSalt->[newBase64String],newResponse_ShouldNotIncludeResponseWhenChallengeDoesNotContainSalt->[newBase64String],decodeOptionalProperty_Shoul... | Checks if the specified optional property is present and if it is present and throws exception when it. | Well, that's the third occurrence. :smile: I'll leave it up to you if you want to extract an `assertNotThrows()` utility as part of this PR. |
@@ -1048,6 +1048,9 @@ class Trainer(Registrable):
grad_clipping = params.pop_float("grad_clipping", None)
lr_scheduler_params = params.pop("learning_rate_scheduler", None)
+ if isinstance(cuda_device, int) and cuda_device >= 0:
+ model = model.cuda(cuda_device)
+
parameter... | [Trainer->[_parameter_and_gradient_statistics_to_tensorboard->[add_train_scalar,is_sparse],rescale_gradients->[sparse_clip_norm],_enable_activation_logging->[hook->[add_train_histogram]],_get_batch_size->[_get_batch_size],train->[_enable_activation_logging,_validation_loss,_should_stop_early,_metrics_to_tensorboard,_en... | Construct a Trainer from a sequence of training data and validation data. Initialize a new object with all the configuration options. | I'm not sure what the right thing to do is when you're using multiple GPUs - I'm not really familiar with how the multi-GPU code works. Anyone have any idea? |
@@ -127,6 +127,10 @@ class Api < Roda
r.halt 404 unless (game = Game[id])
render(game_data: game.to_h(include_actions: true))
end
+
+ r.on 'about' do
+ render
+ end
end
def render_with_games
| [Api->[halt->[halt],not_authorized!->[halt],notify->[notify],user->[user]]] | Renders a page with a nailble list of games. | can you instead add this to line 126 in the array? |
@@ -433,10 +433,12 @@ def tf_mixed_norm(evoked, forward, noise_cov, alpha_space, alpha_time,
Length of time window used to take care of edge artifacts in seconds.
It can be one float or float if the values are different for left
and right window length.
+ log_objective : bool
+ If T... | [tf_mixed_norm->[_reapply_source_weighting,_prepare_gain,_make_sparse_stc,_compute_residual,_window_evoked],mixed_norm->[_reapply_source_weighting,_compute_residual,_prepare_gain,_make_sparse_stc],_prepare_gain->[_prepare_gain_column],_prepare_gain_column->[_prepare_weights]] | Time - Frequency Mixed - Normalization Diagnostics are applied to the Cortical Surface and the MxNE model. Compute a single n - dip unit critical point. Get the non - zero non - negative index of the given object in the active set. | -1, this goes against how `verbose` is used and described everywhere else in the package |
@@ -364,6 +364,17 @@ func CreateJobRunViaWeb(t *testing.T, app *TestApplication, j models.JobSpec, bo
return jr
}
+// NewJobHelloWorld creates a JobSpec with the given MockServer Url
+func NewJobHelloWorld(t *testing.T, app *TestApplication, url string) models.JobSpec {
+ j, _ := NewJobWithWebInitiator()
+ t1 := N... | [SetEthereumServer->[String,Parse],Stop->[Close,Stop],RemoveAll,Off,FileMode,AllCalled,Unlock,KeysDir,HandlerFunc,Helper,NewGomegaWithT,BasicAuthGet,Now,CreateTestLogger,Close,NewStore,Eventually,Panicf,Copy,BasicAuthPost,Router,Stop,Should,ReadFile,NewBufferString,Marshal,SetDefaultEventuallyTimeout,One,NewIndexableBl... | NewStore returns a new store that stores the unique identifier in the store. Get a single unique identifier from the server. | Let's reflect that the new job is created via web in the name. Perhaps `CreateHelloWorldJobViaWeb`? |
@@ -43,4 +43,14 @@ public final class ChannelMetadata {
public boolean hasDisconnect() {
return hasDisconnect;
}
+
+ /**
+ * Checks to see if the {@link io.netty.channel.Channel} associated with this
+ * {@link io.netty.channel.ChannelMetadata} is a {@link io.netty.channel.ServerChannel}
+... | [No CFG could be retrieved] | Returns true if this connection has a disconnect. | Should I replace this with `public EndpointType getEndpointType()` , or keep it as it is? |
@@ -818,7 +818,7 @@ def _eliminate_common_key_with_none(stages, context, can_pack=lambda s: True):
# elimination, and group eligible KeyWithNone stages by parent and
# environment.
def get_stage_key(stage):
- if len(stage.transforms) == 1 and can_pack(stage.name):
+ if len(stage.transforms) == 1 and int(... | [fix_side_input_pcoll_coders->[side_inputs,length_prefix_pcoll_coders],sort_stages->[process->[process],process],_lowest_common_ancestor->[get_ancestors],union->[union],extract_impulse_stages->[Stage],annotate_downstream_side_inputs->[get_all_side_inputs->[side_inputs],compute_downstream_side_inputs->[compute_downstrea... | Runs common subexpression elimination for all stages and stages with no common input. Yields all stages of the n - node - n - node - n - node -. | `can_pack(stage.name)` is equivalent (assuming no negative values) and more clear. |
@@ -348,6 +348,8 @@ namespace Dynamo.Models
public bool StartInTestMode { get; set; }
public IUpdateManager UpdateManager { get; set; }
public ISchedulerThread SchedulerThread { get; set; }
+ public IAuthProvider AuthProvider { get; set; }
+ public string Pac... | [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],Paste->[Copy],RemoveWorkspace->[Dispose],ResetEngine->[ResetEngine],ShutDown->[OnShutdownStarted,OnShutdownCompleted],DumpLibraryToXml->[DumpLibraryToXml],ResetEngineInternal->[RegisterCustomNodeDefinitionWithEngine,Dispose],AddWork... | Creates a DynamoModel instance with the specified configuration. Construct a DynamoModel from an existing . | Does this need setting more than once? Can we make it readonly? Making this hard is important as defence in depth measure |
@@ -30,8 +30,9 @@ var (
timeSeriesPool = sync.Pool{
New: func() interface{} {
return &TimeSeries{
- Labels: make([]LabelAdapter, 0, expectedLabels),
- Samples: make([]Sample, 0, expectedSamplesPerSeries),
+ Labels: make([]LabelAdapter, 0, expectedLabels),
+ Samples: make([]Sample, 0, expected... | [MarshalTo->[Size,MarshalToSizedBuffer],Marshal->[Size,MarshalToSizedBuffer],Compare->[Compare],Unmarshal->[Errorf,Unmarshal],RegisterFlags->[IntVar],Get,Pointer,Put] | requires that the package lock is held Unmarshal unmarshals a preallocated WriteRequest from a byte slice. | Do we actually expect 1 exemplar per series? If a client has exemplars tracking enabled, do we actually expect an exemplar for each series in each remote write request? Could you share more thoughts about this? |
@@ -25,11 +25,5 @@ class DecoderTrainer(Registrable):
def decode(self,
initial_state: DecoderState,
decode_step: DecoderStep,
- targets: torch.Tensor,
- target_mask: torch.Tensor) -> Dict[str, torch.Tensor]:
+ supervision: SupervisionType) -... | [DecoderTrainer->[from_params->[by_name,list_available,pop_choice]]] | Decodes a single from the decoder. | A docstring describing at least what `supervision` is would be useful here. |
@@ -72,12 +72,12 @@ namespace System.IO.Compression
_everOpenedForWrite = false;
_outstandingWriteStream = null;
- FullName = DecodeEntryName(cd.Filename);
+ FullName = DecodeBytesToString(cd.Filename);
_lhUnknownExtraFields = null;
// the cd... | [ZipArchiveEntry->[WriteCrcAndSizesInLocalHeader->[SizesTooLarge],Stream->[ThrowIfNotOpenable],WriteLocalFileHeaderAndDataIfNeeded->[WriteLocalFileHeader],IsOpenable->[ToString],DirectToArchiveWriterStream->[Flush->[Flush,ThrowIfDisposed],WriteByte->[Write],Dispose->[WriteCrcAndSizesInLocalHeader,Dispose,WriteDataDescr... | Private methods for the ZipArchiveEntry class. Get the header of the n - tuple. | Is this still true? |
@@ -2,13 +2,14 @@
# Cura is released under the terms of the LGPLv3 or higher.
import os.path
from UM.Application import Application
+from UM.PluginRegistry import PluginRegistry
from UM.Resources import Resources
from cura.Stages.CuraStage import CuraStage
+
## Stage for preparing model (slicing).
class Pre... | [PrepareStage->[_engineCreated->[getInstance,addDisplayComponent,getPath,join],__init__->[getInstance,super]]] | Initialize the sidebar component with a parent object. | I agree in having the plugin-dependant components in the plugin, but then we should do it also for the `sidebar_component_path` above. |
@@ -1452,6 +1452,13 @@ class Jetpack {
* @return array Active Jetpack plan details
*/
public static function get_active_plan() {
+ global $active_plan_cache;
+
+ // this can be expensive to compute so we cache for the duration of a request
+ if ( $active_plan_cache ) {
+ return $active_plan_cache;
+ }
+
... | [Jetpack->[verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],wp_rest_authenti... | Get the currently active Jetpack plan. This function is used to create a business plan for the event database. | Is there any better way to do this than introducing another global? |
@@ -682,7 +682,7 @@ func NewEthTx(t *testing.T, store *strpkg.Store, fromAddress ...common.Address)
if len(fromAddress) > 0 {
address = fromAddress[0]
} else {
- address = GetDefaultFromAddress(t, store)
+ address = DefaultKeyAddress
}
return models.EthTx{
| [SignHash->[NewSignature],MustNewTaskType,Panicf,NewRunInputWithResult,NewEth,Big,Bytes,NewEthValue,EIP55Address,NoError,NewAnyTime,Unmarshal,NewID,Helper,NewContext,Value,FindEthTxWithAttempts,Now,ToHash,Add,NewBig,PutUint64,Marshal,EncodeRLP,EVMWordUint64,NewLink,NewJob,CreateJobRun,EVMWordBigInt,Gas,NewBuffer,RightP... | MustInsertUnconfirmedEthTx returns a new transaction id for the given gethHeader NewEthTxWithAttempts creates a new transaction with a nonce of 0. | This fixes a sporadic deadlock in the tests. |
@@ -66,6 +66,12 @@ DEBUG_FINE_GRAINED = False
PYTHON_EXTENSIONS = ['.pyi', '.py']
+if os.altsep:
+ SEPARATORS = frozenset([os.sep, os.altsep])
+else:
+ SEPARATORS = frozenset([os.sep])
+
+
Graph = Dict[str, 'State']
| [FindModuleCache->[find_module->[_find_module],find_modules_recursive->[BuildSource,find_module,find_modules_recursive],clear->[clear]],process_graph->[add_stats,trace,log],_build->[BuildSourceSet,BuildResult],process_fine_grained_cache_graph->[log],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_p... | Get the last modified time of a file. | """Returns the path relative to the current working directory.""" |
@@ -209,10 +209,6 @@ def install(opts):
os.system(os.path.join(os.curdir, 'server/bin/pulp-gen-ca-certificate'))
os.system(os.path.join(os.curdir, 'nodes/common/bin/pulp-gen-nodes-certificate'))
- # Update for certs
- os.system('chown -R apache:apache /etc/pki/pulp')
- os.system('chmod 644 /etc/pki... | [create_dirs->[debug],install->[create_dirs,warning,getlinks],uninstall->[getlinks,debug],_create_link->[debug],create_link->[warning,debug],install,parse_cmdline,uninstall] | Installs a pulp node and pulp - gen - ca certificate. | I'll assume you confirmed that apache does not need to write in here. |
@@ -81,6 +81,7 @@ import org.junit.Test;
* upserts, inserts. Check counts at the end.
*/
public class TestHoodieDeltaStreamer extends UtilitiesTestBase {
+
private static final String PROPS_FILENAME_TEST_SOURCE = "test-source.properties";
private static final String PROPS_FILENAME_TEST_INVALID = "test-invali... | [TestHoodieDeltaStreamer->[testBulkInsertsAndUpsertsWithSQLBasedTransformerFor2StepPipeline->[makeConfig,countsPerCommit,assertCommitMetadata,assertDistanceCountWithExactValue,assertDistanceCount,makeConfigForHudiIncrSrc,assertRecordCount],teardown->[teardown],setup->[setup],initClass->[initClass],testDatasetCreation->... | Initialize the class. This method saves the properties of the Hudi table which incrementally pulls from upstream. | Would be changed to final? |
@@ -251,7 +251,7 @@ public class DruidCoordinatorBalancerTest
}
@Test
- public void testZeroMaintenancePriority()
+ public void testZeroDecommissionPriority()
{
DruidCoordinatorRuntimeParams params = setupParamsForMaintenancePriority(0);
params = new DruidCoordinatorBalancerTester(coordinator).ru... | [DruidCoordinatorBalancerTest->[PredefinedPickOrderBalancerStrategy->[findNewSegmentHomeReplicator->[findNewSegmentHomeReplicator],emitStats->[emitStats],findNewSegmentHomeBalancer->[findNewSegmentHomeBalancer]],defaultRuntimeParamsBuilder->[defaultRuntimeParamsBuilder],setupParamsForMaintenancePriority->[mockDruidServ... | Test that the number of segments loaded in the cluster is equal to 1. | Residual "Maintenance". Please search the whole codebase for this. |
@@ -286,7 +286,7 @@ public abstract class AbstractAWSProcessor<ClientType extends AmazonWebServiceCl
final String urlstr = StringUtils.trimToEmpty(context.getProperty(ENDPOINT_OVERRIDE).evaluateAttributeExpressions().getValue());
if (!urlstr.isEmpty()) {
getLogger().info("Over... | [AbstractAWSProcessor->[onShutdown->[getClient],customValidate->[customValidate],getAvailableRegions->[createAllowableValue],onScheduled->[createConfiguration]]] | Initialize region and endpoint. | these values will always be present? We dont have to guard from them being null/undefined/different than the API being called expects? |
@@ -28,7 +28,8 @@ public class InterpreterOption {
public static final transient String SCOPED = "scoped";
public static final transient String ISOLATED = "isolated";
- boolean remote;
+ // always set it as true, keep this field just for backward compatibility
+ boolean remote = true;
String host = null;
... | [InterpreterOption->[isSession->[perNoteScoped,perUserScoped],isProcess->[perUserIsolated,perNoteIsolated],fromInterpreterOption->[InterpreterOption]]] | Creates an object that represents a single . The interpreter that is used to create a new interpreter. | why leave this variable? it won't be helpful for backward compatibility if it is removed in the constructor, and setRemote, isRemote anyway? |
@@ -4280,6 +4280,7 @@ describe('$compile', function() {
element = $compile('<div foo-dir dir-data="remoteData" ' +
'dir-str="Hello, {{whom}}!" ' +
'dir-fn="fn()"></div>')($rootScope);
+ expect(Controller.prototype.$onInit).toHaveBeenCal... | [No CFG could be retrieved] | - > - > - > - > - > - > - > - > - > Requires that the controller and the element have the required scope and the text of the element. | Isn't this redundant now ? |
@@ -102,7 +102,13 @@ def test_hms(sec, result):
def test_install_msg():
name = 'some-package'
pid = 123456
- expected = "{0}: Installing {1}".format(pid, name)
+ base_result = 'Installing {0}'.format(name)
+
+ tty._debug = tty.BASIC
+ assert inst.install_msg(name, pid) == base_result
+
+ tty._... | [test_install_uninstalled_deps->[create_installer],test_check_deps_status_write_locked->[create_installer],test_ensure_locked_new_warn->[create_installer],test_install_fail_fast_on_except->[create_installer],test_install_fail_fast_on_detect->[create_installer],test_cleanup_all_tasks->[_mktask->[create_build_task],_mkta... | Test install message. | I think this should use monkeypatch to change the tty._debug level so that it can be called from `SpackCommand` without messing with the users debug setting. |
@@ -35,9 +35,13 @@ class Meme(AutotoolsPackage):
version('4.11.4', '371f513f82fa0888205748e333003897')
+ variant('mpi', default=True, description='Enable MPI support')
+
depends_on('zlib', type=('link'))
depends_on('libxml2', type=('link'))
depends_on('libxslt', type=('link'))
depends_on... | [Meme->[depends_on,version]] | Version of the package. | Is this not a conditional dependency? It seems like `meme+mpi` and `meme~mpi` build the same thing. |
@@ -1215,17 +1215,6 @@ dbuf_read_impl(dmu_buf_impl_t *db, zio_t *zio, uint32_t flags)
return (0);
}
- DB_DNODE_EXIT(db);
-
- db->db_state = DB_READ;
- mutex_exit(&db->db_mtx);
-
- if (DBUF_IS_L2CACHEABLE(db))
- aflags |= ARC_FLAG_L2CACHE;
-
- SET_BOOKMARK(&zb, dmu_objset_id(db->db_objset),
- db->db.db_objec... | [No CFG could be retrieved] | Set the data in the DBUF. The function that handles the handling of the object. | When `zfs_recover=1` this exit path isn't fatal so you need to hand it gracefully and drop your locks. |
@@ -119,7 +119,7 @@ public final class Http2TestUtil {
public static HpackEncoder newTestEncoder(boolean ignoreMaxHeaderListSize,
long maxHeaderListSize, long maxHeaderTableSize) throws Http2Exception {
- HpackEncoder hpackEncoder = new HpackEncoder();
+ ... | [Http2TestUtil->[randomBytes->[randomBytes],FrameAdapter->[decode->[onPingRead->[onPingRead],onSettingsRead->[onSettingsRead],onUnknownFrame->[onUnknownFrame],onHeadersRead->[onHeadersRead,getOrCreateStream,closeStream],onRstStreamRead->[onRstStreamRead,getOrCreateStream,closeStream],onPingAckRead->[onPingAckRead],onSe... | Creates a new encoder with the specified max header list size and max header table size. | This change does not look right to me |
@@ -3,6 +3,7 @@ module Users
include PhoneConfirmation
before_action :confirm_two_factor_authenticated
+ before_action :redirect_if_not_phone_owner, only: :edit
def add
user_session[:phone_id] = nil
| [PhonesController->[phone_configuration->[phone_configuration],already_has_phone?->[already_has_phone?],delivery_preference->[delivery_preference]]] | add - add a to the user session. | Added a check so that if the user is trying to modify a phone configuration that doesn't belong to them, they aren't taken to the edit screen (even though they can't modify it) but instead get routed to the account page. |
@@ -231,7 +231,11 @@ abstract class AbstractTemplatePreProcessor implements TemplateStepPreProcessor
@Override
public Map<String, Object> getUriParams() {
- return Collections.emptyMap();
+ // Since Camel 3.3 we must declare explicitly the usage of templates
+ // that are stored in head... | [AbstractTemplatePreProcessor->[preProcess->[parseSymbol,append,isSymbol,isText,checkPartial],append->[append],isSymbol->[isMySymbol,isSymbol]]] | Returns the uri parameters. | This may be replaced by `Collections.singletonMap("allowTemplateFromHeader","true")` ? |
@@ -23,6 +23,9 @@ import org.mule.config.i18n.CoreMessages;
*/
public abstract class AbstractFilteringMessageProcessor extends AbstractInterceptingMessageProcessor implements NonBlockingSupported
{
+
+ public static final String FILTERS_STOP_ALL_FLOW_CALLERS = SYSTEM_PROPERTY_PREFIX + "filterOnUnacceptedStopsPa... | [AbstractFilteringMessageProcessor->[handleUnaccepted->[process]]] | Abstract filtering message processor. abstract method to handle an incoming event. | Can we update constant to match name (minor)? |
@@ -484,14 +484,12 @@ public class UnitAttachment extends DefaultAttachment {
}
getBool(s[2]);
final IntegerMap<UnitType> unitsToMake = new IntegerMap<>();
- for (int i = 3; i < s.length; i++) {
+ for (int i = 3; i < s.length; i += 2) {
final UnitType ut = getData().getUnitTypeList().getUnit... | [UnitAttachment->[getAllowedBombingTargetsIntersection->[get,getBombingTargets],getAllOfTypeAas->[getTypeAa],setIsTwoHit->[setIsTwoHit],getMaximumNumberOfThisUnitTypeToReachStackingLimit->[getPlacementLimit,getAttackingLimit,getMovementLimit,get,getIsAaForCombatOnly,getIsAaForBombingThisUnitOnly],getUnitsWhichReceivesA... | Sets the whenCapturedChangesInto map. | This is the only functional change. In the case of multiple units the error message would make no sense at all. |
@@ -512,7 +512,7 @@ type SourceBuildStrategy struct {
Scripts string
// Incremental flag forces the Source build to do incremental builds if true.
- Incremental bool
+ Incremental *bool
// ForcePull describes if the builder should pull the images from registry prior to building.
ForcePull bool
| [NewString] | Returns a builder container containing all the required environment variables and parameters for a specific . | This definitely changes behavior. Before, if I didn't specify this field in my BuildConfig all the Builds it created would be `false`. Now, if I don't specify the value it can sometimes be `true`. I don't necessarily object to the change, but if `incremental` doesn't work all the time, I'd end up with buildconfigs that... |
@@ -143,8 +143,6 @@ abstract class CommonDocGenerator
$object->state=getState($object->state_code,0);
}
- $object->load_ban();
-
$array_thirdparty = array(
'company_name'=>$object->name,
'company_email'=>$object->email,
| [CommonDocGenerator->[printRect->[line],get_substitutionarray_shipment->[list_delivery_methods,getTotalDiscount],get_substitutionarray_propal->[fetch_optionals,transnoentitiesnoconv,fetch_name_optionals_label,getTotalDiscount,fill_substitutionarray_with_extrafields],get_substitutionarray_mysoc->[transnoentitiesnoconv],... | Get third party substitution array Retrieve array of third party company options. | Please find another solution, ODT tags company_bank_account_{iban|bic} doesn't work :( We must make a new segment with bank accounts or load default bic defined into thirdparty card. |
@@ -73,7 +73,9 @@ module GobiertoPlans
starts_at: node.starts_at,
ends_at: node.ends_at,
status: node.status&.name_translations,
- options: node.options },
+ options: node.options,
+ ... | [CategoryTermDecorator->[vocabulary->[vocabulary],site->[site],nodes_data->[progress]]] | return nodes data . | Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element. |
@@ -822,6 +822,8 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
# We know the length is one because of the assertion above
# Create the Vhost object
ssl_vhost = self._create_vhost(vh_p)
+ if self.conf("handle-sites"):
+ ssl_vhost.enabled = False
... | [ApacheConfigurator->[_add_servername_alias->[_add_servernames],enhance->[choose_vhost],perform->[restart,perform],make_addrs_sni_ready->[is_name_vhost,add_name_vhost],_copy_create_ssl_vhost_skeleton->[_sift_rewrite_rule],get_virtual_hosts->[_create_vhost],_add_name_vhost_if_necessary->[is_name_vhost,add_name_vhost],cl... | Makes an SSL vhost version of a vhost that is not in ssl_vhost. This method is called when a vhost object is not yet present in the SSL configuration. It. | Is this the right logic? I think it works in the conventional case, but what if someone has a file in `sites-enabled` rather than a symlink? |
@@ -422,11 +422,7 @@ func (c *CreateConfig) GetContainerCreateOptions(runtime *libpod.Runtime, pod *l
}
options = append(options, libpod.WithNetNSFrom(connectedCtr))
} else if !c.NetMode.IsHost() && !c.NetMode.IsNone() {
- isRootless := rootless.IsRootless()
postConfigureNetNS := c.NetMode.IsSlirp4netns() |... | [GetVolumesFrom->[ID,Wrapf,Contains,GetArtifact,Unmarshal,LookupContainer,Errorf,SplitN],createExitCommand->[GetLevel,Executable,GetConfig,String],GetContainerCreateOptions->[WithNetNS,WithDNSOption,IsRootless,IsContainer,WithName,WithShmSize,CreatePortBindings,WithCgroupParent,WithLocalVolumes,ShmDir,WithStopSignal,cr... | GetContainerCreateOptions returns the list of options that can be used to create a container WithUserVolumes returns a list of options to use when creating a pod This is only supported by rootless containers NewContainer returns a new container with the specified options Options for the pod. | Should we still throw an error if slirp4netns is not available? |
@@ -203,10 +203,12 @@ class BiattentiveClassificationNetwork(Model):
def get_metrics(self, reset: bool = False) -> Dict[str, float]:
return {metric_name: metric.get_metric(reset) for metric_name, metric in self.metrics.items()}
+ # The logic here requires a custom from_params.
@classmethod
- ... | [BiattentiveClassificationNetwork->[from_params->[from_params]]] | Returns a dictionary of metric names to values. | This is the `FeedForward` vs. `Maxout` logic, right? I'd note that explicitly. It'd be nice to find a way to fix it, but that can be another PR someday if someone wants to do it. |
@@ -531,6 +531,8 @@ func (c *s3Context) Fail(err error) {
}
func (c *s3Context) done() {
+ c.mux.Lock()
+ defer c.mux.Unlock()
c.refs--
if c.refs == 0 {
c.errC <- c.err
| [Stop->[Done],Run->[Done],processMessage->[Done],run->[Err],Wait->[Stop,Wait],processor->[Wait],processorKeepAlive->[Done]] | done is called when the context is done. | `Fail()` calls `done()` and holds the lock. That will result in a deadlock. I didn't look at the rest of the file, but wanted to call this out now. I can probably look at the rest of it tomorrow if any assistance is needed. |
@@ -2774,11 +2774,10 @@ class IrGraph(object):
class Program(object):
"""
- Python Program. Beneath it is a ProgramDesc, which is used for
- create c++ Program. A program is a self-contained programing
- language like container. It has at least one Block, when the
- control flow op like conditional_... | [cuda_places->[is_compiled_with_cuda,_cuda_ids],Program->[_construct_from_desc->[Program,_sync_with_cpp,Block],__repr__->[__str__],parse_from_string->[Program,_sync_with_cpp,Block],to_string->[_debug_string_,to_string],_version->[_version],_copy_param_info_from->[global_block],__init__->[Block],_create_block->[block,Bl... | Creates a new object of type Operator for the given object. Returns the operands between start and end. | at least one Block? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.