patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -68,7 +68,7 @@ class Git(Package):
depends_on("zlib")
def install(self, spec, prefix):
- env['LDFLAGS'] = "-L%s" % spec['gettext'].prefix.lib + " -lintl"
+ env['NO_GETTEXT'] = "YesPlease"
configure_args = [
"--prefix=%s" % prefix,
"--with-curl=%s" % spec['... | [Git->[install->[join_path,filter_file,configure,which,make],depends_on,version]] | Installs a bunch of packages. | do you mind explain why you change things like that? Especially when such changes are not related to the PR title. |
@@ -0,0 +1,13 @@
+# Copyright 2013-2021 Lawrence Livermore National Security, LLC and other
+# Spack Project Developers. See the top-level COPYRIGHT file for details.
+#
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+
+
+class PyFastjsonschema(PythonPackage):
+ """Fast JSON schema validator for Python."""
+
+ h... | [No CFG could be retrieved] | No Summary Found. | Missing build dep on setuptools |
@@ -127,10 +127,7 @@ namespace Dynamo.Engine
liveRunnerServices = new LiveRunnerServices(this, geometryFactoryFileName);
- liveRunnerServices.ReloadAllLibraries(libraryServices.ImportedLibraries);
- libraryServices.SetLiveCore(LiveRunnerCore);
-
- codeCompletionServices... | [EngineController->[GetExecutedAstGuids->[GetExecutedAstGuids],ReconcileTraceDataAndNotify->[OnTraceReconciliationComplete],ImportLibrary->[ImportLibrary],GetRuntimeWarnings->[GetRuntimeWarnings],RemoveRecordedAstGuidsForSession->[RemoveRecordedAstGuidsForSession],GetBuildWarnings->[GetBuildWarnings],Dispose->[Dispose]... | Creates a new EngineController instance. region Elevation and Elevation objects. | For some reasons the hidden code part in `OnLibraryLoaded` cannot be expanded on mobile device, just want to make sure `codeCompletionServices` is not omitted by mistake. |
@@ -51,6 +51,18 @@ frappe.ui.form.on("Contact", {
frappe.model.remove_from_locals(d.link_doctype, d.link_name);
});
}
+ },
+ after_save: function() {
+ frappe.run_serially([
+ () => frappe.timeout(1),
+ () => {
+ var last_route = frappe.route_history.slice(-2, -1)[0];
+ if(frappe.dynamic_link && ... | [No CFG could be retrieved] | on link name change. | also check `last_route.length > 2` |
@@ -361,7 +361,7 @@ class PythonPackage(PackageBase):
# Testing
- def test(self):
+ def build_test(self):
"""Run unit tests after in-place build.
These tests are only run if the package actually has a 'test' command.
| [PythonPackage->[install->[setup_py],sdist->[setup_py],_setup_command_available->[setup_file,python],build_scripts->[setup_py],register->[setup_py],setup_py->[setup_file,python],upload->[setup_py],install_headers->[setup_py],build_ext->[setup_py],check->[setup_py],build_py->[setup_py],bdist->[setup_py],bdist_dumb->[set... | Run unit tests after in place build. These tests are only run if the package. | Should this now say "if the package actually has a 'build_test' command."? |
@@ -113,7 +113,7 @@ final class DefaultChannelHandlerContext
ChannelHandler handler) {
this.name = requireNonNull(name, "name");
this.pipeline = pipeline;
- this.executionMask = mask(handler.getClass());
+ this.executionMask = ChannelHandlerMask.mask(han... | [DefaultChannelHandlerContext->[invokeWrite->[write],read->[executor,invokeTasks],fireChannelActive->[executor],fireChannelRegistered->[executor],channel->[channel],callHandlerRemoved->[setRemoved],connect->[executor,connect],write->[executor,invokeWriteAndFlush,write,invokeWrite],executor->[executor],invokeRead->[read... | Returns the tasks associated with this invocation. | Could omit classname here since you have static * import |
@@ -115,7 +115,7 @@ func (e *EvacuateOptions) RunEvacuate(node *kapi.Node) error {
}
if firstPod {
- fmt.Fprint(e.Options.Writer, "\nMigrating these pods on node: ", node.ObjectMeta.Name, "\n\n")
+ fmt.Fprint(e.Options.ErrWriter, "\nMigrating these pods on node: ", node.ObjectMeta.Name, "\n\n")
firstPod... | [Run->[GetNodes,NewAggregate,RunEvacuate],RunEvacuate->[AsSelector,PrintObj,NewAggregate,Fprint,List,Matches,SelectorFromSet,ReplicationControllers,Parse,Errorf,GetPrintersByResource,makeDeleteOptions,Set,Delete,Pods,Run],AddFlags->[Int64Var,Flags,BoolVar]] | RunEvacuate runs the evacuate command deleteOptions deletes all the pods in the cluster. | would be better to plumb a stderr writer and use that |
@@ -62,6 +62,12 @@ public class HttpResponseHeaderBuilder
}
else
{
+ if (headerValue == null)
+ {
+ LOGGER.warn("The header " + headerName + " is null. Removing it from the response.");
+ return;
+ }
+
addSimpleValue(... | [HttpResponseHeaderBuilder->[addContentType->[addSimpleValue],setContentLength->[removeHeader,addSimpleValue],addSimpleValue->[logIfHeaderDoesNotSupportMultipleValues],getHeader->[get]]] | Adds a header with the specified name and value. | Where is it removed? Is the header removed if you do this? builder.addHeader("name", "not null"); builder.addHeader("name", null); |
@@ -289,10 +289,16 @@ void urashima_state::video_start()
m_layer[0] = &machine().tilemap().create(*m_gfxdecode, tilemap_get_info_delegate(FUNC(urashima_state::get_tile_info_urashima<0>),this),tilemap_mapper_delegate(FUNC(urashima_state::range0_16x16),this),16,16,256,32);
// range confirmed with title screen transit... | [No CFG could be retrieved] | region System Functions The following functions are used to populate the priority system. | This is 0x400 not 0x800 (also can be safely allocated as shared pointer I guess) |
@@ -358,7 +358,7 @@ export class Resource {
* @param {!../layout-rect.LayoutMarginsChangeDef=} opt_newMargins
*/
changeSize(newHeight, newWidth, opt_newMargins) {
- this.element./*OK*/ changeSize(newHeight, newWidth, opt_newMargins);
+ this.element./*OK*/ applySize(newHeight, newWidth, opt_newMargins);... | [No CFG could be retrieved] | Builds the given element and updates its size and transitions to the state. Sets pending change sizes to undefined. | Can /*OK*/ be removed? |
@@ -609,11 +609,8 @@ public class BlockOutputStream extends OutputStream {
}
return e;
}, responseExecutor).exceptionally(e -> {
- if (LOG.isDebugEnabled()) {
- LOG.debug(
- "writing chunk failed " + chunkInfo.getChunkName() + " blockID "
- + blockI... | [BlockOutputStream->[getTotalAckDataLength->[getTotalAckDataLength],writeOnRetry->[updateFlushLength],writeChunkToContainer->[setIoException],handleFullBuffer->[getIoException],write->[write],cleanup->[cleanup],validateResponse->[getIoException],getCommitIndex2flushedDataMap->[getCommitIndex2flushedDataMap],checkOpen->... | Writes a chunk to the container. | This is part of the I/O path where we have seen perf issue without the if (LOG.isDebugEnabled()), which slf4j claim that parameterize log will solve. So my suggestion is to keep the if (LOG.isDebugEnabled()) and ignore the Sonar warning if any here. |
@@ -278,6 +278,10 @@ zfs_holey_common(struct inode *ip, int cmd, loff_t *off)
if (error == ESRCH)
return (SET_ERROR(ENXIO));
+ /* file was dirty, so fall back to using file_sz logic */
+ if (error == EBUSY)
+ error = 0;
+
/*
* We could find a hole that begins after the logical end-of-file,
* because dmu... | [No CFG could be retrieved] | zfs_close - close file or directory Common code for reading hole - based znodes. | Rather than suppress this error I think it would be better to return immediately and allow it to percolate up to `zpl_llseek()` and then handle it there. |
@@ -337,7 +337,7 @@ public class ParquetIOTest implements Serializable {
public void testReadDisplayData() {
DisplayData displayData = DisplayData.from(ParquetIO.read(SCHEMA).from("foo.parquet"));
- Assert.assertThat(displayData, hasDisplayItem("filePattern", "foo.parquet"));
+ MatcherAssert.assertThat(... | [ParquetIOTest->[testWriteAndReadwithSplitUsingReflectDataSchemaWithDataModel->[generateGenericRecords],ParseGenericRecordAsJsonFn->[create->[ParseGenericRecordAsJsonFn]],testWriteAndReadWithSplitUsingReflectDataSchemaWithoutDataModelThrowsException->[generateGenericRecords],testWriteAndReadUsingReflectDataSchemaWithou... | Read the data from parquet and assert that it contains a valid display item. | why the hamcrest one? the other one misses something? otherwise prefer the junit one. |
@@ -86,7 +86,7 @@ public class MessageReferenceImpl extends LinkedListImpl.Node<MessageReferenceIm
// Static --------------------------------------------------------
- private static final int memoryOffset = 64;
+ private static final int memoryOffset = 72;
// Constructors ----------------------------... | [MessageReferenceImpl->[copy->[MessageReferenceImpl],equals->[getMessage,equals],getLastValueProperty->[getLastValueProperty],getMessageID->[getMessageID],hashCode->[hashCode],getPersistentSize->[getPersistentSize],isDurable->[isDurable],toString->[isDurable,getMessage,getMessageID],getMessageMemoryEstimate->[getMemory... | Construct a MessageReference. Accept an object. | Can we have some doc or something around this very magical number (its magical without any context), how do we derive 72? |
@@ -148,7 +148,7 @@ static void GetMacAddress(EvalContext *ctx, ARG_UNUSED int fd, struct ifreq *ifr
return;
}
-# if defined(SIOCGIFHWADDR) && defined(HAVE_STRUCT_IFREQ_IFR_HWADDR)
+# if defined(SIOCGIFHWADDR) && defined(HAVE_STRUCT_IFREQ_IFR_HWADDR) && !defined(__TERMUX__)
char hw_mac[CF_MAXVARSIZE]... | [No CFG could be retrieved] | Get the mac address of an interface. region Public API Methods. | would be better to hinge on whether the current user is privileged or not? |
@@ -150,7 +150,7 @@ public abstract class AbstractMethodAnnotationPostProcessor<T extends Annotation
((Advised) handler).addAdvisor(advisor);
}
else {
- ProxyFactory proxyFactory = new ProxyFactory(bean);
+ ProxyFactory proxyFactory = new ProxyFactory(handler);
proxyFactory.addAdvisor(advi... | [AbstractMethodAnnotationPostProcessor->[extractTypeIfPossible->[extractTypeIfPossible],createEndpoint->[getInputChannelAttribute]]] | This method is called after the processing of the message handler. It creates a message handler and This method creates a new endpoint using the given message handler. | Ah! Must be backported |
@@ -42,7 +42,7 @@ import java.io.File;
import java.io.IOException;
import java.nio.charset.Charset;
import java.nio.file.Files;
-import java.nio.file.Path;;
+import java.nio.file.Path;
import java.util.List;
import java.util.Optional;
import javax.xml.parsers.DocumentBuilder;
| [TestCasePlanLoader->[fromTestCase->[properties,cloneWithPropertyOverwrite,getKsqlEngine,getServiceContext,buildStatementsInTestCase],parseSpec->[RuntimeException,resolve,slurp,TestCasePlan,readValue],fromSpecific->[parseSpec],getKsqlEngine->[createKsqlEngine,MetaStoreImpl,get],getFormattedVersionFromPomFile->[replaceA... | Imports a package that contains all of the required packages. Creates a plan for a given test case. | Looks like this import is actually unused. Perhaps we can remove the line entirely? |
@@ -1980,6 +1980,7 @@ class BlobClient(StorageAccountHostsMixin): # pylint: disable=too-many-public-m
options.update(kwargs)
return options
+ @check_parameter_api_version(managed_disk_diff='2019-04-19')
@distributed_trace
def get_page_ranges( # type: ignore
self, offset=No... | [BlobClient->[get_managed_disk_page_range_diff->[_get_page_ranges_options],create_page_blob->[_create_page_blob_options],abort_copy->[_abort_copy_options],set_sequence_number->[_set_sequence_number_options],start_copy_from_url->[_start_copy_from_url_options,start_copy_from_url],resize_blob->[_resize_blob_options],uploa... | Returns a list of page ranges for a Page Blob or snapshot of a page blob. This function is used to check if a resource has been modified since a specified time or a Get page range results for a single . | >check_parameter_api_version [](start = 5, length = 27) It seems we still want to keep the version check as a policy instead of a parameter so that we can still catch the improper operation when users override the version in the pipeline? @amishra-dev Do you have any idea about the decision on removing the version chec... |
@@ -832,7 +832,11 @@ class ContentMapper implements ContentMapperInterface
$result = $query->execute();
foreach ($result->getNodes() as $node) {
- $structures[] = $this->loadByNode($node, $languageCode, $webspaceKey);
+ try {
+ $structures[] = $this->loadByNode($... | [ContentMapper->[deleteRecursively->[deleteRecursively],getStructure->[getStructure],copyOrMove->[loadByNode,move,copy,save],saveExtension->[save],getInheritedState->[getContentNode],saveStartPage->[save],adaptResourceLocator->[move,save],getRouteNode->[getRouteNode],loadTreeByNode->[loadTreeByNode],loadByParentNode->[... | Loads structures by SQL2. | I disagree with this. If a page does not have a valid template, then we have done something wrong, the system should not be in this state and an exception should be thrown. Covering up errors like this will just lead to lazy code. The above command will not be executed. We will have an inconsistent database. |
@@ -132,7 +132,10 @@ EOT
// TODO this belongs in the solver, but this will do for now to report top-level deps missing at least
foreach ($request->getJobs() as $job) {
if ('install' === $job['cmd']) {
- foreach ($installedRepo->getPackages() as $package) {
+ ... | [InstallCommand->[install->[getOption,getPackage,getJobType,getLockedPackages,solve,getTarget,getVersion,addRepository,getInstallationManager,getJobs,collectLinks,getLocalRepository,getNames,setPreferSource,lockPackages,getVendorPath,update,getComposer,writeln,whatProvides,execute,install,write,getName,getConstraint,is... | Installs packages from the composer. json file. Installs or updates packages that are missing dependencies. Writes the package lock file and generates autoload files if necessary. | you should add a use statement here |
@@ -544,7 +544,7 @@
"surrogateAuthRequired": false,
"enabled": true,
"clientAuthenticatorType": "client-secret",
- "secret": "internal",
+ "secret": "**********",
"redirectUris": [],
"webOrigins": [],
"notBefore": 0,
| [No CFG could be retrieved] | This function returns a JSON - serializable object with all of the properties of the object that are The protocol mappers for OpenID Connect. | I think it's value should be `internal` |
@@ -65,6 +65,15 @@ export class AmpAdXOriginIframeHandler {
/** @private {?Promise} */
this.adResponsePromise_ = null;
+
+ if (this.baseInstance_.emitLifecycleEvent &&
+ typeof this.baseInstance_.emitLifecycleEvent == 'function') {
+ /** @private {!function(string, Object=)} */
+ this.em... | [No CFG could be retrieved] | The AMP AMP AMP XOriginIframeHandler class. Registers the event of the embed state. | I'm not convinced this saves you anything given you already check this again below for the load listener case. Might as well just check elsewhere and save some memory allocation (event name string) |
@@ -79,10 +79,16 @@ class Scaler(TransformerMixin):
for key, this_pick in picks_list.items():
if self.with_mean:
- ch_mean = X[:, this_pick, :].mean(axis=1)[:, None, :]
+ if len(this_pick) == 0:
+ ch_mean = np.nan * np.ones((X.shape[0], 1, X.shape... | [Vectorizer->[fit_transform->[fit]],UnsupervisedSpatialFilter->[fit->[fit],fit_transform->[fit],transform->[transform]]] | Standardize data across channels. Returns the data concatenated over channels and the remaining missing data. | @kingjr I just noticed this error in `Scaler.fit`. This is bug (setting `self.ch_std_[key]` to the *mean*), right? |
@@ -594,7 +594,17 @@ Lowerer::LowerRange(IR::Instr *instrStart, IR::Instr *instrEnd, bool defaultDoFa
case Js::OpCode::CloneStr:
{
- GenerateGetImmutableOrScriptUnreferencedString(instr->GetSrc1()->AsRegOpnd(), instr, IR::HelperOp_CompoundStringCloneForAppending, false);
+ IR::... | [No CFG could be retrieved] | Checks if a string is a valid helper object. This function is called when a new object is added to the object. | I expected your change to be in the runtime side instead of the JIT'd code. If we leave it in the JIT'd code, we should only do it for JIT loop bodies, but I kind of think it's just better to put this check in the helper itself. It minimizes the amount of code the JIT has to generate, which is better throughput wise an... |
@@ -45,7 +45,7 @@ namespace Pulumi.Serialization
public void SetValue(OutputData<object?> data)
=> _taskCompletionSource.SetResult(new OutputData<T>(
- _resources.Union(data.Resources), (T)data.Value!, data.IsKnown, data.IsSecret));
+ _resources.Union(data.Resources... | [OutputCompletionSource->[TrySetException->[TrySetException]]] | Set value of a managed managed managed managed managed managed managed managed managed managed managed managed managed managed. | What exactly caused NRE in the old code? I'd guess it's `data` that would have to be `null` for NRE, which means the fix won't help? |
@@ -68,6 +68,9 @@ int main(int argc, char **argv)
if (!CMS_decrypt(cms, rkey, rcert, dcont, out, 0))
goto err;
+ printf("Successfully dencrypted contents of file smencr.pem"
+ " into file smencr.out and encrout.txt "
+ " using certificate and private key from file smrsa1.pem\n");
... | [main->[ERR_print_errors_fp,PEM_read_bio_X509,ERR_load_crypto_strings,EVP_PKEY_free,fprintf,CMS_decrypt,CMS_ContentInfo_free,BIO_reset,X509_free,OpenSSL_add_all_algorithms,BIO_free,PEM_read_bio_PrivateKey,BIO_new_file,PEM_read_bio_CMS]] | This is the entry point for the test. | there probably need to be some newline characters here. |
@@ -206,12 +206,12 @@ module AutomatedTestsHelper
markus_address = get_markus_address(host_with_port)
file_urls = group_ids.map do |id_|
param = collected ? 'collected=true' : ''
- "#{markus_address}/api/assignments/#{assignment.id}/groups/#{id_}/submission_files?#{param}"
+ "#{mark... | [update_settings->[get_markus_address],add_feedback_data->[set_headers,send_request!],fill_in_schema_data!->[extra_test_group_schema],run_tests->[get_markus_address],send_request!->[send_request]] | Run tests for the specified groupings. | Metrics/LineLength: Line is too long. [132/120] |
@@ -393,7 +393,8 @@ public class BytecodeCFGBuilder {
@Override
public void visitTryCatchBlock(Label start, Label end, Label handler, String type) {
- tryCatchBlocks.add(new TryCatchBlock(start, end, handler, type));
+ String exception = type == null ? null : Type.getObjectType(type).getClassName(... | [BytecodeCFGBuilder->[buildCFG->[buildCFG],Block->[createSuccessor->[Block]],BytecodeCFGMethodVisitor->[visitVarInsn->[addInsn],visitLookupSwitchInsn->[createSuccessor],visitLdcInsn->[addInsn],visitInsn->[addInsn],wireHandlers->[wireHandlers],visitFieldInsn->[addInsn],visitIntInsn->[addInsn],visitMultiANewArrayInsn->[a... | Visit a try catch block. | I am fixing this |
@@ -14,8 +14,12 @@
* limitations under the License.
*/
-import {user} from '../../../src/log';
+import {user, dev} from '../../../src/log';
import {FilterType} from './filters/filter';
+import {ANALYTICS_CONFIG} from '../../amp-analytics/0.1/vendors';
+import {getMode} from '../../../src/mode';
+
+const TAG = 'A... | [No CFG could be retrieved] | Exports an object that exports an AMP - AMP - AMP config with a specific Checks whether the object conforms to the AmpAdExitConfig spec. | ^^ I've not imported one extension from another before. Is it safe to do so, with the hard-coded "0.1"? |
@@ -26,6 +26,7 @@ var AllCustomResourceValidators = []string{
config.PluginName,
scheduler.PluginName,
clusterresourcequota.PluginName,
+ securitycontextconstraints.PluginName,
// this one is special because we don't work without it.
securitycontextconstraints.DefaultingPluginName,
| [Register,RegisterDefaulting] | RegisterCustomResourceValidation registers all the plugins that need to be run on the OpenShift plugin. | @deads2k is the ordering on this correct? What comes first, validation or defaulting? My guess would be the latter. And I forget how validating vs mutation are ordered. |
@@ -980,12 +980,13 @@ def _apply_inverse_epochs_gen(epochs, inverse_operator, lambda2, method='dSPM',
if is_free_ori:
# Compute solution and combine current components (non-linear)
sol = np.dot(K, e[sel]) # apply imaging kernel
- if is_free_ori:
- logger.inf... | [prepare_inverse_operator->[copy,combine_xyz,InverseOperator],estimate_snr->[_check_ch_names,prepare_inverse_operator,_check_reference,_pick_channels_inverse_operator],InverseOperator->[copy->[InverseOperator]],read_inverse_operator->[InverseOperator],apply_inverse->[prepare_inverse_operator,_check_reference,_assemble_... | Generate for apply_inverse_epochs. Yields a sequence of missing residue values. | Not for this PR, but at some point we should really refactor all of these to use a single private function. |
@@ -2491,9 +2491,12 @@ namespace System.Windows.Forms.PropertyGridInternal
Debug.WriteLineIf(s_gridViewDebugPaint.TraceVerbose, "adding gridEntry focus");
_selectedGridEntry.HasFocus = true;
InvalidateRow(_selectedRow);
- (EditTextBox.AccessibilityObject... | [PropertyGridView->[EnsurePendingChangesCommitted->[CloseDropDown],OnFontChanged->[Font,OnFontChanged],UpdateUIBasedOnFont->[SetFlag,Size,LayoutWindow],CommonEditorHide->[CloseDropDown],ReverseFocus->[SelectGridEntry],ShowInvalidMessage->[OnEscape,SelectGridEntry,SetCommitError],GetEntryLabelLength->[GetEntryLabelInden... | called when the user clicks on the focus in the grid view. | Please remove this extra line |
@@ -110,8 +110,15 @@ public class SpillableMapUtils {
* Utility method to convert bytes to HoodieRecord using schema and payload class.
*/
public static <R> R convertToHoodieRecordPayload(GenericRecord rec, String payloadClazz) {
- String recKey = rec.get(HoodieRecord.RECORD_KEY_METADATA_FIELD).toString()... | [SpillableMapUtils->[readInternal->[HoodieCorruptedDataException,readLong,FileEntry,generateChecksum,readFully,seek,readInt],generateEmptyPayload->[HoodieKey,empty,loadPayload],computePayloadSize->[sizeEstimate],spillToDisk->[spill],spill->[getValue,getSizeOfKey,write,writeInt,getTimestamp,getKey,writeLong,getCrc,getSi... | Convert a GenericRecord to a HoodieRecordPayload. | can't you pass these as default at a higher layer. So there will only be one method here, which takes 4 args. |
@@ -98,14 +98,12 @@ class Student < User
membership.membership_status = StudentMembership::STATUSES[:pending]
membership.user_id = self.id
membership.save
- # update repo permissions (for accepted memberships - includes inviter)
- # if grouping is valid
- grouping = Grouping.find(gid... | [Student->[create_group_for_working_alone_student->[destroy_all_pending_memberships],join->[pending_memberships_for],create_autogenerated_name_group->[destroy_all_pending_memberships],pending_memberships_for->[pending_groupings_for]]] | Invite a user to a group. | There shouldn't be an apostrophe here. |
@@ -27,7 +27,15 @@ package com.ibm.gpu;
* The main method can be launched from the command line, which will print
* the current level to stdout.
*/
+/*[IF Java16]*/
+public final class Version {
+
+ private Version() {
+ super();
+ }
+/*[ELSE] Java16
public class Version {
+/*[ENDIF] Java16*/
/**
* The c... | [Version->[main->[println]]] | This class is used to print the current build level of the ibm gpu library. | Same question about formatting as above. I won't repeat it here but we should do the same with all copies of the pattern |
@@ -28,6 +28,7 @@ import io.confluent.ksql.parser.tree.Sink;
import io.confluent.ksql.parser.tree.Statement;
import io.confluent.ksql.planner.LogicalPlanner;
import io.confluent.ksql.planner.plan.OutputNode;
+import io.confluent.ksql.query.id.SequentialQueryIdGenerator;
import io.confluent.ksql.serde.SerdeOption;
... | [AnalysisTestUtil->[Analyzer->[parseStatement->[buildAst,assertThat,hasSize,getStatement],getQuery,of,getSink,parseStatement,QueryAnalyzer,empty,none,analyze],buildLogicalPlan->[LogicalPlanner,buildPlan,Analyzer]]] | Creates a new instance of the AnalysisTestUtil class. Returns an analysis plan for the given query string. | nit: unused import? |
@@ -42,11 +42,14 @@ var nodeProps = `
},
"node_name": {
"type": "keyword",
- "normalizer": "case_insensitive",
"fields": {
"engram" : {
"type": "text",
"analyzer": "autocomplete"
+ },
+ "lower": {
+ "normalizer": "case_insensitive",
+ "type": "keyword"
}
}
},
| [Sprintf] | mappings import is a module that imports the mappings for the given node_name Manages the structure of the error object. | For each filterable term, a new field is created that will allow matching in the lower case. |
@@ -83,6 +83,12 @@ class Repository < RepositoryBase
end
end
+ def self.assigned_in_project(project)
+ accessible_by_teams(project.team)
+ .joins(repository_rows: { my_module_repository_rows: { my_module: { experiment: :project } } })
+ .where(repository_rows: { my_module_repository_rows: { my_m... | [Repository->[shared_with_write?->[private_shared_with_write?,team,shared_write?],shared_with_anybody?->[any?,not_shared?],shared_with?->[team,private_shared_with?,not_shared?],assigned_rows->[where,id],i_shared?->[shared_with_anybody?,team],importable_repository_fields->[id,each,t,name,importable?],private_shared_with... | This method is used to search for a specific record in a repository table. | shouldn't this be scope? |
@@ -57,7 +57,7 @@ public class Tls12SocketFactory extends SSLSocketFactory {
public static OkHttpClient.Builder enableTls12OnPreLollipop(OkHttpClient.Builder client) {
- if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP_MR1) {
+ if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP_MR1 ... | [Tls12SocketFactory->[getSupportedCipherSuites->[getSupportedCipherSuites],enableTls12OnPreLollipop->[Tls12SocketFactory],createSocket->[createSocket],getDefaultCipherSuites->[getDefaultCipherSuites]]] | Enable TLS 1. 2 on pre - Lollipop clients. | Could I have a source for this? It feels unsafe given that it was working well beforehand I intuit that there will be other manufacturers other than Samsung which we'll affect |
@@ -41,6 +41,9 @@ class PeekSubsystem(Outputting, GoalSubsystem):
"--output",
type=OutputOptions,
default=OutputOptions.JSON,
+ removal_version="2.9.0.dev0",
+ removal_hint="Output will always be JSON. If you need the raw BUILD file contents, "
+ "... | [_render_json->[getattr,items,dumps],_render_raw_build_file->[append,endswith,len,decode,join],PeekSubsystem->[output_type->[cast],register_options->[register,super],exclude_defaults->[cast]],peek->[Peek,_render_json,MultiGet,PathGlobs,AssertionError,output,tuple,_render_raw,write_stdout,Get],_PeekJsonEncoder->[default... | Register options for the command. | It would be better for this to be in a dedicated change so that it shows up in the Changelog under User API Changes |
@@ -295,6 +295,8 @@ class PublicBody < ActiveRecord::Base
has_tag?('not_apply')
end
+ scope :foi_applies, -> { without_tag('not_apply') }
+
# If tagged "foi_no", then the authority is not subject to FOI law but
# requests may still be made through the site (e.g. they may have agreed to
# respond to ... | [PublicBody->[get_request_percentages->[where_clause_for_stats],not_requestable_reason->[defunct?,has_request_email?,not_apply?],set_locale_fields_from_csv_row->[localized_csv_field_name],request_email_if_requestable->[request_email,is_requestable?],get_request_totals->[where_clause_for_stats],is_requestable?->[defunct... | not_apply? - check if a node has a not_apply tag. | Should this exclude `foi_no` too? Depends how we read it I guess. You could read it as "while the authority is not _subject_ to FOI by law (`foi_no`), we're treating them as if they should be, so FOI applies". |
@@ -118,7 +118,6 @@ bool process_ucis (uint16_t keycode, keyrecord_t *record) {
return false;
}
}
-
if (keycode == KC_ENT || keycode == KC_SPC || keycode == KC_ESC) {
bool symbol_found = false;
| [No CFG could be retrieved] | This function processes the keycode and the keyrecord_t object given by the user. This function finds the n - ary ucs symbol in the Unicode table. | Any particular reason why this blank line was removed? If not, I'd suggest readding it as it makes this block slightly more readable. |
@@ -60,6 +60,8 @@ func isNetworkError(status int) bool {
return status == http.StatusBadGateway || status == http.StatusGatewayTimeout
}
+//-------------------------------------------------------------------------------------------------
+
// ResponseRecorder is an implementation of http.ResponseWriter that
// r... | [Flush->[Flush,Write],Write->[Write],ServeHTTP->[ServeHTTP],Hijack->[Hijack],CloseNotify->[CloseNotify]] | NewRetry returns a new Retry instance. Write - writes to rw. Body if not nil. | I'd rather not have visual limiters. |
@@ -377,6 +377,7 @@ async function createKarmaServer(
.on('browsers_ready', () => karmaBrowsersReady())
.on('browser_start', browser => karmaBrowserStart(browser))
.on('browser_complete', browser => karmaBrowserComplete(browser))
+ .on('browser_error', (browser, error) => karmaBrowserError(browser, er... | [No CFG could be retrieved] | Create a new instance of the module. | Out of curiosity, why do we pass a `() => callbackFn()` instead of just `callbackFn` in this file? |
@@ -379,7 +379,7 @@ class SubmissionsController < ApplicationController
end
messages = []
- @grouping.group.access_repo do |repo|
+ @grouping.access_repo do |repo|
# Create transaction, setting the author. Timestamp is implicit.
txn = repo.get_transaction(current_user.user_n... | [SubmissionsController->[downloads->[revision_identifier,find,group_name,accepted_grouping_for,flash_message,send_file,nil?,redirect_back,get_revision,t,count,send_tree_to_zip,access_repo,open,repository_folder,short_identifier,get_latest_revision,student?,files_at_path],update_submissions->[flash_now,set_pr_release_on... | Updates a single node in the group. add_files add_folders commit_success flash_messages. | Metrics/BlockLength: Block has too many lines. [31/25] |
@@ -98,12 +98,13 @@ public class DataSourceAnalysis
this.dataSource = dataSource;
this.baseDataSource = baseDataSource;
this.baseQuery = baseQuery;
+ this.joinBaseTableFilter = joinBaseTableFilter;
this.preJoinableClauses = preJoinableClauses;
}
public static DataSourceAnalysis forDataSou... | [DataSourceAnalysis->[equals->[equals],isConcreteTableBased->[isConcreteBased],isConcreteBased->[isGlobal],isGlobal->[isGlobal],forDataSource->[DataSourceAnalysis]]] | Analyzes a DataSource and returns the baseQuerySegmentSpec if any. | this was probably an accident? |
@@ -1,7 +1,7 @@
<div id="left-menu-bar" class="menu-bar">
<ul class="nav">
<li class="<%= "active" if projects_are_selected? %>">
- <a id="projects-link" title="<%= t('left_menu_bar.projects') %>" href="<%= projects_path %>">
+ <a id="projects-link" class="toggle-sidebar-link" title="<%= t('left_menu... | [No CFG could be retrieved] | Displays the menu for the selected node. Displays a list of all the user - related items in the menu. | you can use link_to helper method here |
@@ -822,8 +822,11 @@ function discover_process_ipv6(&$valid, $ifIndex, $ipv6_address, $ipv6_prefixlen
echo 'n';
}
- $ipv6_network_id = dbFetchCell('SELECT `ipv6_network_id` FROM `ipv6_networks` WHERE `ipv6_network` = ? AND `context_name` = ?', array($ipv6_network, $context_nam... | [discover_new_device->[getMessage,inNetworks],find_device_id->[packed],discover_process_ipv6->[getNetwork,compressed],discover_device->[getMessage,getTraceAsString]] | Checks if there is a duplicate IPv6 address in the database. If there is a duplicate Add or update a IPv6 address in the database. | Hi @garysteers It seems that your change does not change anything after all. Could you check ? Copy-paste issue ? |
@@ -950,12 +950,14 @@ void kill_screen(const char* lcd_msg) {
mesh_edit_accumulator += float(ubl_encoderPosition) * 0.005 / 2.0;
mesh_edit_value = mesh_edit_accumulator;
encoderPosition = 0;
- lcdDrawUpdate = LCDVIEW_REDRAW_NOW;
+ lcdDrawUpdate = LCDVIEW_CALL_REDRAW_NEXT;
... | [No CFG could be retrieved] | Z - probe Draw edit of the mesh and offset. | This needs to be inside the "if(lcdDrawUpdate)", after "lcd_implementation_drawedit". The reason being that if it isn't, the graphics may be overwritten. |
@@ -38,5 +38,8 @@ frappe.ui.form.on("System Settings", {
// Clear cache after saving to refresh the values of boot.
frappe.ui.toolbar.clear_cache();
}
- }
+ },
+ week_starts_on(frm) {
+ frm.re_setup_moment = true;
+ },
});
| [No CFG could be retrieved] | Clear cache after saving to refresh the values of boot. | why not just setup moment when `week_starts_on` is changed here? No need to put it in refresh? |
@@ -151,6 +151,13 @@ export class AmpImageViewer extends AMP.BaseElement {
if (this.loadPromise_) {
return this.loadPromise_;
}
+ // TODO(sparhami) #19259 Tracks a more generic way to do this. Remove once
+ // we have something better.
+ const isScaled = closestAncestorElementBySelector(
+ ... | [No CFG could be retrieved] | Private methods for the class that define the position of the target element. Load end callback. | Nit: the build checks don't like `i-amp-`, should be `i-amphtml-`. |
@@ -64,7 +64,7 @@ public class DeploymentDescriptorIT {
deployment = MAPPER.readTree(DeploymentDescriptorIT.class.getResourceAsStream("/io/syndesis/dao/deployment.json"));
}
- @Test
+ @Test @Ignore //TODO Kurt
@SuppressWarnings({"PMD.JUnitTestsShouldIncludeAssert", "PMD.JUnitTestContainsTooMa... | [DeploymentDescriptorIT->[thereShouldBeNoDuplicateMavenCoordinates->[groupingBy,toMap,counting,collect,isEmpty,identity],assertActionDataShapes->[isNull,equals,connectorJSon,asText,get,readTree,isEqualTo,substring,startsWith,fail],assertConnectorProperties->[getValue,isNotNull,get,getKey,isEqualTo,removeCustomizedPrope... | Checks if the deployment descriptor take a cue from the connector descriptor. Checks that the scheme is not resolved from an unexpected artifact. | I had to Ignore this test bc it was not picking up changes from the local connectors. I think it downloads the connectors from maven instead? |
@@ -474,8 +474,10 @@ dependencies {
testCompile "com.github.differentway:couchbase-testcontainer"
<%_ } _%>
testCompile "org.hamcrest:hamcrest-library"
- <%_ if (devDatabaseType !== 'h2Disk' && devDatabaseType !== 'h2Memory') { _%>
+ <%_ if (databaseType === 'sql') { _%>
testCompile "com.h2dat... | [No CFG could be retrieved] | exclude group = android - json exclude module = android - json exclude exclude group = android - Create a dependency on the H2 database. | I don't think this is right, you have not taken into account sql database with no h2 and the same db in dev and prod. |
@@ -118,6 +118,7 @@ function cleanupOldFiles(generator) {
generator.removeFile(`${ANGULAR_DIR}shared/login/login.component.ts`);
generator.removeFile(`${ANGULAR_DIR}shared/login/login.component.html`);
generator.removeFile(`${ANGULAR_DIR}core/auth/user-route-access-service.ts`);
+... | [No CFG could be retrieved] | Removes all TSL files from the TSL directory. Removes all the files from the shared folder. | You shouldn't do this way, 2 options here: - remove when not needed - use `this.fs.delete(this.destinationPath(...));` Otherwise any change to the file will be overwritten every regeneration. |
@@ -114,6 +114,13 @@ class SimpleVersionSerializer(serializers.ModelSerializer):
'is_strict_compatibility_enabled', 'license', 'reviewed',
'url', 'version')
+ def to_representation(self, instance):
+ # Help the LicenseSerializer find the version we're currently
+ ... | [VersionSerializer->[LicenseSerializer],ESAddonSerializer->[ESPreviewSerializer],SimpleVersionSerializer->[FileSerializer,CompactLicenseSerializer],AddonSerializer->[get_icon_url->[get_icon_url],PreviewSerializer,SimpleVersionSerializer],ESAddonSerializerWithUnlistedData->[ESPreviewSerializer],AddonSerializerWithUnlist... | Get the url for a specific object. | I wonder if `instance.license` should be a `getattr` call instead? |
@@ -193,7 +193,7 @@ class User < ActiveRecord::Base
end
# Is there already a Student with this User number?
- current_user = user_class.find_or_create_by_user_name(user_attributes[:user_name])
+ current_user = user_class.find_or_create_by(user_name: user_attributes[:user_name])
current_user.attri... | [User->[generate_csv_list->[student?],revoke_repository_permissions->[student?,repo_config],maintain_repository_permissions->[student?,repo_config],grant_repository_permissions->[student?,repo_config]]] | Add a user to the user_class given a row of CSV data. This method will. | Line is too long. [87/80] |
@@ -422,7 +422,7 @@ func ImportStatusAsError(g *GlobalContext, s *keybase1.Status) error {
}
return ret
case SCSigCannotVerify:
- ret := VerificationError{}
+ ret := kbcrypto.VerificationError{}
for _, field := range s.Fields {
switch field.Key {
case "Cause":
| [exportPGPKeyV2->[Export],ExportRevokedDeviceKeys->[exportPublicKey],ExportTo->[Export],ExportAllPGPKeys->[exportPublicKey],ExportToUserPlusAllKeys->[ExportAllPGPKeys,ExportToUserPlusKeys],ExportDeviceKeys->[exportPublicKey],exportUPKV2Incarnation->[exportPGPKeyV2,exportDeviceKeyV2],ExportToUncheckedIdentity->[ExportTo... | returns a struct with all the fields populated with error messages. Private functions related to API errors. | I expect to move most of these errors to kbconst eventually |
@@ -49,12 +49,14 @@ class TestElementwisePowOp_big_shape_2(TestElementwisePowOp):
def setUp(self):
self.op_type = "elementwise_pow"
self.inputs = {
- 'X': np.random.uniform(0.1, 1, [10, 10]).astype("float64"),
- 'Y': np.random.uniform(0.1, 1, [10, 10]).astype("float64") * 20... | [TestElementwisePowOp->[test_check_output->[check_output],test_check_grad_normal->[check_grad],setUp->[power,uniform]],TestElementwisePowOp_big_shape_2->[setUp->[power,uniform]],TestElementwisePowOpInt->[test_check_output->[check_output],setUp->[power,asarray]],TestElementwisePowOp_broadcast_1->[setUp->[power,uniform,i... | Set up the object for the elementwise power operation. | 'Y': np.random.uniform(0.2, 2, [10, 10]).astype("float64") |
@@ -58,7 +58,7 @@ top_htmlhead($head, $title, $disablejs, $disablehead, $arrayofjs, $arrayofcss);
$categorie = new Categorie($db);
$categories = $categorie->get_full_arbo('product');
?>
-var categories = JSON.parse( '<?php echo json_encode($categories);?>' );
+var categories = <?php echo json_encode($categories); ?>... | [trans,loadLangs,get_full_arbo,close] | Displays a list of categories. MoreCategories - This function is used to determine if there are more pages or if there are. | json_encode return a string so if you remove JSON.parse, the var categories will be a string. And later it is used as an array with categories[] The goal of JSON.parse is to convert a json string into the array. Are you sure yo can remove this ? |
@@ -119,9 +119,9 @@ public class QuotaStatementCmd extends BaseCmd {
@Override
public long getEntityOwnerId() {
- Long accountId = _accountService.getActiveAccountByName(accountName, domainId).getAccountId();
- if (accountId == null) {
- return CallContext.current().getCallingAccoun... | [QuotaStatementCmd->[getEntityOwnerId->[getAccountId],execute->[getCommandName,setStartDate,setEndDate]]] | This method is called to retrieve the entity owner id of the managed entity. | This can be kept to know who made the API call |
@@ -22,3 +22,14 @@ class Coreutils(AutotoolsPackage, GNUMirrorPackage):
version('8.23', sha256='ec43ca5bcfc62242accb46b7f121f6b684ee21ecd7d075059bf650ff9e37b82d')
build_directory = 'spack-build'
+
+ def configure_args(self):
+ spec = self.spec
+ configure_args = []
+ if spec.satisfie... | [Coreutils->[version]] | Version of the SPACK build. | I _think_ I'm okay with this decision, but let's wait and hear from other users. |
@@ -5376,7 +5376,7 @@ namespace System.Diagnostics.Tracing
if (!channelTab.TryGetValue((int)channel, out ChannelInfo? info))
{
// If we were not given an explicit channel, allocate one.
- if (channelKeyword != 0)
+ if (channelKeyword == 0)
... | [No CFG could be retrieved] | Construct a new object. Add the error to the error collection. | Do we need to put this new keyword into `channelTab`? |
@@ -497,9 +497,13 @@ func (e *EndpointController) syncService(key string) error {
createEndpoints := len(currentEndpoints.ResourceVersion) == 0
+ // Compare the sorted subsets and labels
+ // Remove the HeadlessService label from the endpoints if it exists, as this won't be set on the service itself
+ // and will... | [addPod->[getPodServiceMemberships],updatePod->[getPodServiceMemberships],deletePod->[addPod]] | syncService syncs the service with the given key. This function is used to find all the endpoints that are not ready for a service. addEndpointSubset creates a new endpointSubset if there are no previous endpoints in the service and Create a new service. | Missing `utillabels` import and `IsHeadlessService` is not present in 1.11, so this entire line is not needed for 3.11. |
@@ -125,7 +125,10 @@ public class RubixInitializer
{
try (Closer closer = Closer.create()) {
closer.register(() -> {
- if (bookKeeperServer != null && bookKeeperServer.isServerUp()) {
+ if (bookKeeperServer != null) {
+ // This might throw NPE ... | [RubixInitializer->[startRubix->[getRubixConfiguration,setLocalBookKeeper,BookKeeperServer,info,initializationDone,MetricRegistry,startServer],getRubixConfiguration->[initializeConfiguration,getHostAndPort,setCurrentNodeAddress,setMasterAddress,get,isCoordinator,getInitialConfiguration,setCacheKey,setMaster,updateConfi... | Stop rabix server if it is up. | Maybe catch the NPE for now? |
@@ -111,7 +111,13 @@ class YamlDiscovery
$value = dynamic_discovery_get_value($name, $index, $data, $pre_cache);
if (is_null($value)) {
// built in replacements
+ // prepare the $subindexX match variable replacement
+ $subindexes = explode('.', $index);
+ ... | [YamlDiscovery->[preCache->[getDevice],discover->[preCache,isValid]]] | Replaces values of a key in a key - value pair with the values of a key -. | You didn't initialize $subindexStr, you could probably make this a little more readable. |
@@ -66,7 +66,8 @@ namespace Dynamo.Configuration
/// <summary>
/// Indicates whether Google analytics reporting is approved or not.
/// </summary>
- public bool IsAnalyticsReportingApproved { get; set; }
+ [Obsolete("Property will be deprecated in Dynamo 3.0")]
+ public b... | [PreferenceSettings->[SaveInternal->[Save],GetIsBackgroundPreviewActive,SetIsBackgroundPreviewActive]] | region Private methods for the n - ary object. - Information about the code block node line numbers and connectors. | I don't think this should be removed. |
@@ -141,7 +141,7 @@ export class GoogleCidApi {
setCookie(this.win_, cookieName, res['clientId'], this.expiresIn_(YEAR));
return res['clientId'];
} else {
- this.persistToken_(TokenStatus.ERROR, DAY);
+ this.persistToken_(TokenStatus.NOT_FOUND, DAY);
return getCookie(this.win_, cooki... | [GoogleCidApi->[persistToken_->[setCookie],constructor->[timerFor],getScopedCid->[resolve,dev,ERROR,OPT_OUT,RETRIEVING,getCookie],handleResponse_->[getCookie,setCookie,OPT_OUT,ERROR],fetchCid_->[dict,xhrFor,json]]] | Handle the response from the server. | We talked about reducing this to 1 hour. Right? |
@@ -20,6 +20,7 @@
#endregion
using System.ComponentModel.DataAnnotations;
+using DotNetNuke.Common.Utilities;
using DotNetNuke.ComponentModel.DataAnnotations;
namespace DotNetNuke.Entities.Content.Workflow.Entities
| [No CFG could be retrieved] | PUBLIC METHODS This class represents a single object that represents a workflow state in a software. - A unique identifier for a system state. | looks like this using doesn't do anything. |
@@ -89,7 +89,11 @@ Object.keys(differentRelationships).forEach(key => {
if (uniqueRel.otherEntityAngularName === 'User') {
_%>
import { I<%= uniqueRel.otherEntityAngularName %> } from 'app/shared/model/user.model';
+<%_ if (authenticationType === 'oauth2') { _%>
+import { getUsers } from 'app/shared/reducers/use... | [No CFG could be retrieved] | hasAnyRelationshipQuery - if relationship has query then add it to the list of relationships that Private helper methods. | I think there is a stray file `user-service.spec.ts.ejs` in this PR. Can you check. Other than that, this PR is ready to merge |
@@ -469,11 +469,6 @@ func (t TeamSigChainState) GetSubteamName(id keybase1.TeamID) (*keybase1.TeamNam
// Must be called with seqno's and events in correct order.
// Idempotent if called correctly.
func (t *TeamSigChainState) inform(u keybase1.UserVersion, role keybase1.TeamRole, sigMeta keybase1.SignatureMetadata) {... | [GetAllUVs->[GetAllUVs],FindActiveInvite->[ActiveInvites],GetLatestUVWithUID->[getUserRole,DeepCopy],ListSubteams->[ListSubteams],FindActiveKeybaseInvite->[ActiveInvites],DeepCopyToPtr->[DeepCopy],GetLibkbLinkIDBySeqno->[GetLinkIDBySeqno],GetAdminUserLogPoint->[GetUserLogPoint],GetUsersWithRole->[getUserRole],roleUpdat... | inform is called when a user is about to change its role and sigMeta. | rm "// Idempotent if called correctly." |
@@ -1083,9 +1083,11 @@ class HashTimeLockState(State):
raise ValueError('secrethash must be a keccak256 instance')
packed = messages.Lock(buffer_for(messages.Lock))
+ # pylint: disable=assigning-non-slot
packed.amount = amount
packed.expiration = expiration
pack... | [PaymentMappingState->[__ne__->[__eq__]],TokenNetworkState->[__ne__->[__eq__]],BalanceProofUnsignedState->[__ne__->[__eq__]],MediatorTask->[__ne__->[__eq__]],NettingChannelEndState->[__ne__->[__eq__],__init__->[make_empty_merkle_tree]],TargetTask->[__ne__->[__eq__]],UnlockPartialProofState->[__ne__->[__eq__]],Transacti... | Initialize a LockHash object from a sequence of TokenAmount TokenExpiration and SecretHash objects. | Since you removed `__slots__`, do we still need this? |
@@ -32,7 +32,11 @@ public class DbVersion64 implements DbVersion {
.add(1602, "Add RULES_PROFILES.ORGANIZATION_UUID", AddQualityProfileOrganizationUuid.class)
.add(1603, "Set RULES_PROFILES.ORGANIZATION_UUID to default", SetQualityProfileOrganizationUuidToDefault.class)
.add(1604, "Make RULES_PROFI... | [DbVersion64->[addSteps->[add]]] | Adds migration steps to the given migration registry. | don't forget to add yourself a task to merge these migrations with 1605 and 1606 |
@@ -63,12 +63,15 @@ public class SpannerIOReadTest implements Serializable {
private FakeServiceFactory serviceFactory;
private ReadOnlyTransaction mockTx;
- private Type fakeType = Type.struct(Type.StructField.of("id", Type.int64()),
+ private transient Type fakeType = Type.struct(Type.StructField.of("id", T... | [SpannerIOReadTest->[validRead->[validate,withColumns],validQuery->[validate,withQuery],emptyColumns->[expectMessage,validate,expect,withTable],runQuery->[NaiveSpannerReadFn,of,thenReturn,withServiceFactory,iterableWithSize,readOnlyTransaction,strong,executeQuery,forRows,assertThat,processBundle],runRead->[NaiveSpanner... | Sets up the mock. | You could also make these static final. |
@@ -465,7 +465,7 @@ uint8_t public_buf[512];
if (card.longFilename[0] == 0) continue;
if (card.longFilename[0] == '.') continue;
- uint8_t a = arrayFindStr(assets, COUNT(assets), card.longFilename);
+ int8_t a = arrayFindStr(assets, COUNT(assets), card.longFilename);
if (a >= ... | [No CFG could be retrieved] | This method is called from the main thread. It reads the assets file and updates the p load assets and load them. | Changed this to an `int8_t` because `a >= 0` was allowing the error value of -1 through (but `a < COUNT(fonts)` wasn't). |
@@ -98,10 +98,10 @@ class OptionsBundle(object):
parse_func=parsers.pulp_parse_optional_nonnegative_int
)
- d = _('content downloading policy ({m})'.format(
- m=' | '.join((constants.DOWNLOAD_IMMEDIATE,
- constants.DOWNLOAD_BACKGROUND,
- ... | [ImporterConfigMixin->[__init__->[OptionsBundle]]] | Initialize options for the object Add options related to a specific node - node - node - node - node - node - Validator for missing missing key. | pretty sure I've seen str.format() used in lots of other parts of sever code. why an issue here? |
@@ -83,6 +83,13 @@ MOCK_ACTIVE_QUEUES_RETURN_VALUE = {
u'auto_delete': False}]}
+def create_task_status(task_id, queue, state=None):
+ collection = TaskStatus.get_collection()
+ status = TaskStatus(task_id, state, queue=queue)
+ collection.save(status, safe=True)
+ return collection.find_one({... | [TestTaskResult->[test_serialize->[AsyncResult,get]],TestRegisterSigtermHandler->[test_error_case->[f->[FakeException]]],_reserve_resource_apply_async->[AsyncResult],TestTask->[test_apply_async_task_status->[AsyncResult],test_on_success_handler_spawned_task_status->[AsyncResult],test_on_failure_handler->[EInfo],test_ap... | Tests that a Celery queue is subscribed to any of the queues that it is subscribed Test for babysit handling of invalid tasks. | Why do we want to make this change? It seems like we're just sidestepping some test coverage on our TaskStatusManager in this test module now. |
@@ -419,15 +419,14 @@ INPUT_PORTS_END
READ8_MEMBER( ti99_4x_state::cruread )
{
- LOGMASKED(LOG_CRUREAD, "read access to CRU address %04x\n", offset << 4);
+ LOGMASKED(LOG_CRUREAD, "read access to CRU address %04x\n", offset << 1);
uint8_t value = 0;
// Let the gromport (not in the QI version) and the p-box be... | [No CFG could be retrieved] | 15. 2. 5. 2 Write to the specified memory in the specified offset. | Also here, no <<1. |
@@ -794,6 +794,13 @@ def analyze_class_attribute_access(itype: Instance,
if not mx.is_lvalue:
result = analyze_descriptor_access(mx.original_type, result, mx.builtin_type,
mx.msg, mx.context, chk=mx.chk)
+
+ # Call the class attribute hook bef... | [analyze_none_member_access->[_analyze_member_access,builtin_type],analyze_union_member_access->[_analyze_member_access,copy_modified],type_object_type->[builtin_type],analyze_var->[analyze_descriptor_access,not_ready_callback,is_instance_var],analyze_type_callable_member_access->[_analyze_member_access],MemberContext-... | Analyze access to an attribute on a class object. The type of the unknown variable. Get the type of the object. Returns the type of the node that is not bound to the class object. | I wasn't sure if the hook should be invoked for every exit point of this function. If so, I can pull the hook invocation into a wrapper function that calls into this one (or similar). I'm not familiar enough with this code to be confident where it would and would not make sense to use the hook, so advice is appreciated... |
@@ -30,6 +30,12 @@ class EmailSettingsValidator
Errno::ECONNREFUSED
]
+ def self.validate_as_user(user, protocol, **kwargs)
+ DistributedMutex.synchronize("validate_#{protocol}_#{user.id}", validity: 10) do
+ self.send("validate_#{protocol}", **kwargs)
+ end
+ end
+
def self.friendly_exception... | [EmailSettingsValidator->[log_and_raise->[message,join,raise,warn],validate_pop3->[log_and_raise,pop3_polling_ssl,new,enable_ssl,auth_only,pop3_polling_openssl_verify],validate_smtp->[log_and_raise,new,upcase,smtp_openssl_verify_mode,to_sym,smtp_authentication,default_ssl_context,smtp_force_tls,include?,enable_tls,cons... | Returns the message of the last exception with a key of the exception array. | I do not like `send` because of the risks it poses. In this case, it looks safe, but I am wondering if `public_send` would do just fine too. |
@@ -707,10 +707,11 @@ describe('$location', function() {
it('should not replace browser url if only the empty hash fragment is cleared', function() {
initService({html5Mode: true, supportHistory: true});
- mockUpBrowser({initialUrl:'http://new.com/#', baseHref: '/'});
- inject(function($browser,... | [No CFG could be retrieved] | It should decode non - component special characters in html5 mode and not replace the url with FAIL - DO NOT DIGEST. | The (non-public) docs for browser.url() say "Without any argument, this method just returns current value of location.href." Isn't this now wrong as the test shows a difference between url() and location.href? |
@@ -533,6 +533,9 @@ class Jetpack {
add_action( 'init', array( 'Jetpack_Iframe_Embed', 'init' ), 9, 0 );
require_once JETPACK__PLUGIN_DIR . '_inc/lib/class.jetpack-keyring-service-helper.php';
add_action( 'init', array( 'Jetpack_Keyring_Service_Helper', 'init' ), 9, 0 );
+
+ $this->tracking = new Tracking... | [Jetpack->[generate_secrets->[generate_secrets],verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],authenticate_jetpack->[verify_xml_rpc_signature],wp_rest_authenticate->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user],jetpack_getOptions->[get_connected_user_data... | This method is called by the constructor of the class. Remove other linked admins transient The actual XML - RPC methods. This is the main entry point for all the methods that are defined in the Jetpack This function is used to register all actions that need to be run as late as possible. | Currently, `Jetpack::init` is hooked on `init` itself. So I'd expect it is too late to hook this on the same hook? |
@@ -1348,7 +1348,12 @@ public /*transient*/ abstract class Computer extends Actionable implements Acces
if (m.matches()) {
File newLocation = new File(dir, "logs/slaves/" + m.group(1) + "/slave.log" + Util.fixNull(m.group(2)));
newLocation.getParentFile().mkdirs();
- ... | [Computer->[getActions->[getActions],getACL->[getACL],isOnline->[isOffline],relocateOldLogs->[getName,relocateOldLogs],getMonitorData->[getName],setNode->[getNumExecutors],_doScript->[getChannel,getACL,_doScript],updateByXml->[replaceBy,checkPermission],remove->[remove],waitUntilOnline->[isOnline],waitUntilOffline->[is... | relocate old logs in the given directory. | A method in `Util` for this might be useful. (At some point it could use `java.nio.file` methods to throw a specific `IOException` in case of failure.) |
@@ -6,7 +6,12 @@
*/
package org.mule.runtime.core.internal.management.stats;
+import java.io.Externalizable;
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
import java.util.Collection;
+import java.util.HashSet;
import java.util.Iterator;
import java.util.Spliterator;
i... | [PayloadStatisticsCollection->[spliterator->[spliterator,iterator],toArray->[toArray],iterator->[iterator]]] | Package for the payload statistics of a collection of objects. | would this be needed if there were a kryo serializer for this class? |
@@ -887,13 +887,9 @@ class ProductCreate(ModelMutation):
track_inventory = cleaned_input.get(
"track_inventory", site_settings.track_inventory_by_default
)
- quantity = cleaned_input.get("quantity", 0)
sku = cleaned_input.get("sku")
models.... | [CollectionCreate->[save->[save],Arguments->[CollectionCreateInput]],ProductImageDelete->[perform_mutation->[ProductImageDelete]],ProductImageReorder->[perform_mutation->[save,ProductImageReorder]],ProductImageCreate->[Arguments->[ProductImageCreateInput],perform_mutation->[ProductImageCreate]],VariantImageAssign->[per... | Save a product. | Should we take into consideration `quantity` here? |
@@ -534,6 +534,12 @@ class Runner {
$assoc_args['orderby'] = 'post__in';
$assoc_args['field'] = 'url';
break;
+ case 'term':
+ $term_ids = array_slice( $args, 3 );
+ $args = array( 'term', 'list', $args[2] );
+ $assoc_args['include'] = implode( ',', $term_ids );
+ $assoc_args['field... | [Runner->[init_config->[get_project_config_path,get_global_config_path],_run_command->[run_command],run_command->[find_command_to_run],load_wordpress->[check_wp_version,get_wp_config_code],start->[wp_exists,init_config,_run_command,do_early_invoke,find_command_to_run,cmd_starts_with,get_packages_dir_path,run_alias_grou... | Back - compatibility for the command line options. CLI command line interface This function is used to convert the post type and site to an associative array. | Do we need to make sure the returned terms are ordered by the order they were originally supplied? |
@@ -401,7 +401,11 @@ static GenericAgentConfig *CheckOpts(int argc, char **argv)
break;
case 'D':
- config->heap_soft = StringSetFromString(optarg, ',');
+ {
+ StringSet *defined_classes = StringSetFromString(optarg, ',');
+ cfruncommand = Stri... | [No CFG could be retrieved] | Initializes the system - wide configuration of the agent. Reads the version number of the n - tuple and writes it to stdout. | Should the special class name be more "magical", e.g. "`__cfruncommand__`", to avoid problems if users have some reason to use the name "cfruncommand" as a class name ? |
@@ -0,0 +1,6 @@
+from setuptools import setup
+
+setup(name='requires_Capitalized',
+ version='0.1',
+ install_requires=['simple==1.0']
+ )
| [No CFG could be retrieved] | No Summary Found. | Sorry, in hindsight my previous suggestion was not very clear. I think that this package should be named "A" (or anything else, it doesn't matter), and then it should have `requires_Capitalized` in its `install_requires` list. Then we should check that the `Requires_Capitalized` package correctly puts "A" in its "Requi... |
@@ -888,10 +888,15 @@ public class KafkaSupervisor implements Supervisor
@VisibleForTesting
String generateSequenceName(int groupId)
{
+ TaskGroup taskGroup = taskGroups.get(groupId);
+ if (taskGroup == null) {
+ log.warn("group id: %s not found in taskGroups, cannot generate sequence number", group... | [KafkaSupervisor->[updateCurrentAndLatestOffsets->[updateCurrentOffsets,updateLatestOffsetsFromKafka],emitLag->[getHighestCurrentOffsets],checkpointTaskGroup->[apply->[taskIds],taskIds],createKafkaTasksForGroup->[generateSequenceName,getRandomId],discoverTasks->[apply->[generateSequenceName,TaskGroup,TaskData]],addDisc... | Generate a random sequence name. | The log level matters. This should be ERROR or FATAL (well, we have `Logger.wtf() method instead of FATAL). |
@@ -80,6 +80,9 @@ func rmCmd(c *cliconfig.RmValues) error {
return err
}
if err != nil {
+ if errors.Cause(err) == libpod.ErrNoSuchCtr {
+ exitCode = 1
+ }
fmt.Println(err.Error())
}
}
| [RemoveContainersFromStorage,ID,GlobalIsSet,Wrapf,ParallelExecuteWorkerPool,Error,Println,Sprintf,Cause,RemoveContainer,Shutdown,GetRuntime,SetUsageTemplate,BoolVarP,Parallelize,Flags,Debugf] | rmCmd removes all containers associated with the container Run the parallel functions. | I'm just wondering if we should error out at this point and not try the deletions? If it's OK to continue on and delete what we can, then LGTM. |
@@ -5,7 +5,7 @@ class SiteSettingCommaToPipe < ActiveRecord::Migration[4.2]
execute <<SQL
UPDATE site_settings
SET value = replace(value, ',', '|')
- WHERE name = 'white_listed_spam_host_domains'
+ WHERE name = 'allowed_spam_host_domains'
;
SQL
execute <<SQL
| [SiteSettingCommaToPipe->[up->[execute],down->[execute]]] | up_nofollow_domains is a hack to avoid the problem with the SQL engine. | I do not think we should be changing migrations too. On the other hand, I doubt there is anyone with a schema that old looking to migrate. |
@@ -789,7 +789,7 @@ class TopicView
ignored_user_ids = DB.query_single(sql, current_user_id: @user.id)
if ignored_user_ids.present?
- @filtered_posts = @filtered_posts.where.not("user_id IN (?) AND posts.id <> ?", ignored_user_ids, first_post_id)
+ @filtered_posts = @filtered_posts.where.n... | [TopicView->[relative_url->[relative_url],participant_count->[participant_count],title->[title],setup_filtered_posts->[filtered_post_id,summary,has_deleted?],initialize->[preload,chunk_size,print_chunk_size],filter_posts_by_ids->[filter_post_types],image_url->[image_url],unfiltered_posts->[filter_post_types],filter_pos... | This method is called by the filter method to setup the list of post IDs that should be Filters posts that have a post number reply_to_post_number and reply_ filter posts that have not been deleted or have a non - zero number of post_number. | Also note that `first_post_id` is only called for mega topics. |
@@ -79,6 +79,7 @@ public class DelegatedClientFactoryTests {
saml.setServiceProviderMetadataPath(new File(FileUtils.getTempDirectoryPath(), "sp.xml").getCanonicalPath());
saml.setServiceProviderEntityId("test-entityid");
saml.setForceKeystoreGeneration(true);
+ saml.setMessageStoreFact... | [DelegatedClientFactoryTests->[verifyFactoryForOidcClients->[size,setPac4j,Pac4jOidcClientProperties,add,getKeycloak,getGeneric,CasConfigurationProperties,setLogoutUrl,assertEquals,configureIdentifiableClient,setDiscoveryUri,setBaseUri,DelegatedClientFactory,getAzure,getGoogle,setRealm,build,Pac4jDelegatedAuthenticatio... | Verify factory for saml clients. | `HttpSessionStoreFactory.class.getName()` Use the class itself to get its name, so if it moves or is deleted, we can catch the issue at compile-time. |
@@ -71,9 +71,14 @@ function html(strings) {
* @return {!Object<string, !Element>}
*/
export function htmlRefs(root) {
- const elements = root.querySelectorAll('[ref]');
+ let elements = root.querySelectorAll('[ref]');
const refs = map();
+ if (root.hasAttribute('ref')) {
+ elements = toArray(elements);
... | [No CFG could be retrieved] | Queries an element for all elements with a ref attribute and removes the attribute afterwards. | @jridgewell Added this as a convenience. The alternative would be to modify the result of `htmlRefs` when root + refs are meant to be referenced in the same object. |
@@ -58,6 +58,9 @@ def main(argv=None):
ret = 253
except DvcParserError:
ret = 254
+ except DvcException:
+ ret = 255
+ logger.exception("")
except Exception as exc: # pylint: disable=broad-except
if isinstance(exc, OSError) and exc.errno == errno.EMFILE:
... | [main->[format_link,exception,is_enabled,setLevel,info,parse_args,close_pools,format,isinstance,run,clean_repos,disable_other_loggers,func,collect_and_send_report],encode,getLogger] | Run dvc CLI command. | DvcException won't have `unexpected error` prepended. Other exceptions and assertion errors will still have that prefixed, which is a good compromise, I'd say. |
@@ -31,13 +31,14 @@ def run_yara(results, upload_pk):
- `upload_pk` is the FileUpload ID.
"""
log.info('Starting yara task for FileUpload %s.', upload_pk)
- upload = FileUpload.objects.get(pk=upload_pk)
if not results['metadata']['is_webextension']:
log.info('Not running yara for FileU... | [run_yara->[incr,YaraResult,timer,exception,is_dir,get,add_match,SafeZip,read,compile,close,info,save,match],getLogger] | This task applies a set of Yara rules on a FileUpload and stores the Y Get the last result of a task that failed to run. | I moved this here to avoid a query for nothing. |
@@ -497,11 +497,13 @@ namespace cryptonote
//------------------------------------------------------------------------------------------------------------------------------
bool core_rpc_server::on_get_hashes(const COMMAND_RPC_GET_HASHES_FAST::request& req, COMMAND_RPC_GET_HASHES_FAST::response& res, const connect... | [No CFG could be retrieved] | This method is called when the client is listening and the client is listening and the client is This function is called when the server is in GET_OUTS_BIN mode. | Seems wrong as `resp` is never touched. Should use `res.m_block_ids.size()` instead. |
@@ -613,6 +613,8 @@ func startControllers(oc *origin.MasterConfig, kc *kubernetes.MasterConfig) erro
kc.RunPersistentVolumeClaimRecycler(oc.ImageFor("recycler"), recyclerClient, oc.Options.PolicyConfig.OpenShiftInfrastructureNamespace)
kc.RunGCController(gcClient)
+ kc.RunServiceLoadBalancerController(serviceL... | [CreateCerts->[Validate],Validate->[Validate],DefaultsFromName] | RunReplicationController starts the controller IsWriteConfigOnly - check if config is write only. | We've been making sure new controllers run with a service account client a la `oc.GetServiceAccountClients(bootstrappolicy.InfraDaemonSetControllerServiceAccountName)`. Probably want it here too. cc @deads2k |
@@ -27,7 +27,7 @@ USAGE:
1) AZURE_FORM_RECOGNIZER_ENDPOINT - the endpoint to your Cognitive Services resource.
2) AZURE_FORM_RECOGNIZER_KEY - your Form Recognizer API key
3) CONTAINER_SAS_URL - The shared access signature (SAS) Url of your Azure Blob Storage container with your forms.
- See https:... | [train_model_without_labels,TrainModelWithoutLabelsSample] | Creates a training model from a given list of unlabeled data. Get custom model information from form training service. | train--? with double dash? |
@@ -592,8 +592,12 @@ class Jetpack_Testimonial {
<div class="testimonial-entry <?php echo esc_attr( self::get_testimonial_class( $testimonial_index_number, $atts['columns'] ) ); ?>">
<?php
// The content
- if ( false !== $atts['display_content'] ): ?>
- <div class="testimonial-entry-conte... | [jetpack_testimonial_custom_control_classes->[Jetpack_Testimonial_Textarea_Control->[render_content->[link,value]]],Jetpack_Testimonial->[maybe_register_cpt->[register_post_types,site_supports_custom_post_type],settings_api_init->[site_supports_custom_post_type],customize_register->[add_control,add_setting,add_section]... | Renders the HTML for the testimonial shortcode. This function is called when a testimonial archive is opened. It will render the. | You'll either need to add a closing php tag here, or omit the opening one in the line below |
@@ -0,0 +1,13 @@
+# Generated by Django 3.1.5 on 2021-02-12 10:37
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ("product", "0139_description_vector_search"),
+ ("product", "0140_auto_20210125_0905"),
+ ]
+
+ operations = []
| [No CFG could be retrieved] | No Summary Found. | Why is this migration needed? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.