patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -126,4 +126,16 @@ func (cfg *Config) Complete(args []string) {
// if we've explicitly called out an etcd server, don't start etcd in-process
cfg.StartEtcd = !cfg.EtcdAddr.Provided
}
+
+ // if this is an all-in-one start, be sure to add our hostname to the NodeList if it is not already present
+ isAllInOne :=... | [Validate->[New],InstallFlags,Flags,StringVar,Sprintf,Validate,Start,Fatal,Var,Complete,BoolVar] | Complete is called when the command line flags are set. | logically, this can use `cfg.StartMaster && cfg.StartNode` as well... "if we're both a master and a node, make sure we know about ourselves". not sure the all-in-one-ness matters |
@@ -68,6 +68,11 @@ def _get_list_element_type(typ: Optional[type]) -> Optional[type]:
if typ is None:
return None
+ # Annotations not specifying the element type are assumed by mypy
+ # to signify Any element type. Follow suit here.
+ if typ in {list, List, Sequence, abc.Sequence}:
+ ret... | [register_resource_module->[version,_module_key,same_version],serialize_property->[serialize_property,_get_list_element_type,isLegalProtobufValue],resolve_properties->[unwrap_rpc_secret,is_rpc_secret],wrap_rpc_secret->[is_rpc_secret],unwrap_rpc_secret->[is_rpc_secret],translate_output_properties->[is_rpc_secret,wrap_rp... | Get the type of the element of a list. | Based on the usage, and how we do similar checks for dicts, we could return `None` here. But returning `Any` also works (since all the places that use this will convert `Any` to `None`) and aligning with mypy makes sense to me. |
@@ -1395,7 +1395,7 @@ def submit_step(outer_step):
@functools.wraps(f)
def wrapper(request, *args, **kw):
step = outer_step
- max_step = 6
+ max_step = 5
# We only bounce on pages with an addon id.
if 'addon' in kw:
addon = ... | [upload->[handle_upload],upload_image->[ajax_upload_image],upload_detail->[_compat_result,json_upload_detail],_resume->[_step_url],auto_sign_version->[auto_sign_file],submit_media->[_step_url],upload_for_addon->[upload],version_add_file->[delete,auto_sign_file,check_validation_override],submit->[_step_url],submit_bump-... | A decorator that bounces to the right step. | I had hoped you would have removed this. Now I understand why you kept the ugly URL names... Can you simplify this and just make an ordered list of url names ? Then you can figure out which one to go to next by looking at the next in the list ? |
@@ -58,7 +58,8 @@ class Jetpack {
'wordads',
'eu-cookie-law-style',
'flickr-widget-style',
- 'jetpack-search-widget'
+ 'jetpack-search-widget',
+ 'simple-payments-widget-style',
);
/**
| [Jetpack->[verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],wp_rest_authenti... | Provides a list of assets that have been concatenated to minified versions. Mullet Contact Form. | we've missed the `jetpack-` prefix here. |
@@ -22,7 +22,8 @@ class Metis(Package):
#
homepage = "https://github.com/scivision/METIS/"
- url = "https://github.com/scivision/METIS/raw/master/metis-5.1.0.tar.gz"
+ #url = "https://github.com/scivision/METIS/raw/master/metis-5.1.0.tar.gz"
+ url = "https://github.com/scivision/METI... | [Metis->[install->[find,Executable,test_graph,ccompile,remove,which,join_path,extend,system,test_bin,append,_std_args,tuple,format,make,install,ls,working_dir,cmake,mkdir,mkdirp],darwin_fix->[fix_darwin_install_name],setup_build_environment->[append_flags],patch->[join_path,satisfies,filter,filter_file,format,FileFilte... | Provides a set of metis objects that are used to create a partition of an object. variant - Provides the bit width of METIS s real type to 64. | Delete this line |
@@ -123,8 +123,10 @@ def manager_thread():
ignore += ["manage_athenad", "uploader"]
if os.getenv("NOBOARD") is not None:
ignore.append("pandad")
- if os.getenv("BLOCK") is not None:
- ignore += os.getenv("BLOCK").split(",")
+ try:
+ ignore += os.environ["BLOCK"].split(",")
+ except (KeyError,Attri... | [main->[manager_cleanup,manager_thread,manager_init,manager_prepare],main] | Main thread of the manager. loop when uninstall is needed. | revert to the if |
@@ -94,12 +94,14 @@ def create_payment(
currency: str,
email: str,
customer_ip_address: str = "",
+ partial: Optional[bool] = False,
payment_token: Optional[str] = "",
extra_data: Dict = None,
checkout: Checkout = None,
order: Order = None,
return_url: str = None,
externa... | [get_already_processed_transaction_or_create_new_transaction->[get_already_processed_transaction,create_transaction]] | Create a payment instance. Get or create a payment node ID. | I am not convinced of this. The create_order flag should solve an issue, where we have two payments, and the user didn't click the CheckoutComplete mutation yet. Example1: Finalizes 1st Payment Finalizes 2nd Payment Saleor recieves a webhook notification <flag create_order is set to False, we should not create an order... |
@@ -139,9 +139,13 @@ class Client:
or cached_auth.get("api_key")
)
+ # mypy struggles with this attribute type if not created here
+ self._tenant_id: Optional[str] = None
+
# Load the tenant id
- self._tenant_id: Optional[str] = (
- tenant_id
+ # T... | [Client->[delete_task_tag_limit->[graphql],set_task_run_name->[graphql],get_latest_cached_states->[graphql],get_flow_run_info->[graphql,TaskRunInfoResult,ProjectInfo,FlowRunInfoResult],get_agent_config->[graphql],create_flow_run->[graphql],get_default_tenant_slug->[graphql,get],set_task_run_state->[graphql,get],get_tas... | Initialize a new object with the given key and token. This method is only called from the pre - existing code. It is only called from the. | how do we infer a tenant_id from an api key again? does the user have to specify a tenant? |
@@ -19,8 +19,14 @@ import subprocess
import threading
import signal
import time
-from pulp_rpm.yum_plugin import util
+
+import rpmUtils
+from pulp_rpm.yum_plugin import util, comps_util, updateinfo
from pulp.common.util import encode_unicode, decode_unicode
+from createrepo import MetaDataGenerator, MetaDataConfig... | [modify_repo->[ModifyRepoError],generate_metadata->[set_progress],create_repo->[modify_repo,_create_repo,CreateRepoAlreadyRunningError,CancelException,CreateRepoError]] | Creates a Yum - style object from a Yum object. Generate metadata for a single . | blank line here for PEP-8, and also move the "createrepo" imports up here to group with "rpmUtils". That way all 3rd-party imports are grouped together, as recommended by PEP-8. |
@@ -192,6 +192,16 @@ class URLInfo(object):
scheme=self.scheme, netloc=self.netloc, path=self._path.parent
)
+ def relative_to(self, other):
+ if isinstance(other, str):
+ other_str = other
+ other = URLInfo(other)
+ if self.scheme != other.scheme or self.n... | [PathInfo->[relpath->[relpath],with_name->[with_name],fspath->[__fspath__],__fspath__->[__str__]],URLInfo->[isin->[PathInfo],parent->[from_parts]]] | Returns the parent node of self if it is a node of self. | other_str can be undefined |
@@ -65,9 +65,9 @@ class EventHubConsumerClient(ClientBase):
The failed internal partition consumer will be closed (`on_partition_close` will be called if provided) and
new internal partition consumer will be created (`on_partition_initialize` will be called if provided) to resume
receiving.
- :keyw... | [EventHubConsumerClient->[get_eventhub_properties->[super],receive->[any,start,stop,get,pop,format,ValueError,EventProcessor,warning],__exit__->[close],get_partition_properties->[super],close->[super,stop,values],_create_consumer->[EventHubConsumer,format,get],get_partition_ids->[super],__init__->[super,Lock,pop],from_... | The default value is 60 seconds. If set to 0 no timeout will be enforced from. | "... meaning that the client will not shutdown due to inactivity unless initiated by the service." |
@@ -570,7 +570,9 @@ void msg_cb(int write_p, int version, int content_type, const void *buf,
{
BIO *bio = arg;
const char *str_write_p = write_p ? ">>>" : "<<<";
- const char *str_version = lookup(version, ssl_versions, "???");
+ char tmpbuf[128];
+ BIO_snprintf(tmpbuf, sizeof(tmpbuf)-1, "Not TLS da... | [No CFG could be retrieved] | The protocol handshakes are used to handle the message handshakes. returns string describing the error code of an unknown header. | This shouldn't be in the variable declarations, move it down please. |
@@ -87,8 +87,8 @@ namespace Microsoft.Xna.Framework.Audio
afs.ParseBytes (audiodata, false);
Size = (int)afs.DataByteCount;
- _data = new byte[afs.DataByteCount];
- Array.Copy (audiodata, afs.DataOffset, _data, 0, afs.DataByteCount);
+ buf... | [SoundEffect->[PlatformSetupInstance->[InitializeSound],PlatformShutdown->[DestroyInstance],PlatformLoadAudioStream->[DataFormat,Stereo16,Stereo8,Duration,WAVE,Copy,GetValueOrDefault,ParseBytes,Mono8,DataByteCount,Position,Dispose,FromSeconds,CanSeek,Read,FromData,NumberOfChannels,ChannelsPerFrame,DataOffset,CopyTo,Bit... | PlatformLoadAudioStream - Load the audio stream. region AVAudioPlayer Implementation. | Need to declare buffer before the using statement so it is visibleto the call to BindDataBuffer later. |
@@ -159,6 +159,9 @@ final class SafeDatasetCommit implements Callable<Void> {
} else if (canPersistStates) {
persistDatasetState(datasetUrn, datasetState);
}
+
+ submitLineageEvent(datasetState);
+
} catch (IOException | RuntimeException ioe) {
log.error(String
... | [SafeDatasetCommit->[persistDatasetState->[persistDatasetState],setTaskFailureException->[setTaskFailureException],TaskFactoryWrapper->[hashCode->[hashCode],equals->[equals]]]] | This method is called when a specific branch of the job has been committed. Commit the current state of the dataset. This method is called when a RuntimeException is thrown while committing the dataset state. | Is the event submitted even if the publishing failed? |
@@ -2458,8 +2458,8 @@ LowererMD::GenerateFastBrOrCmString(IR::Instr* instr)
!srcReg2 ||
srcReg1->IsTaggedInt() ||
srcReg2->IsTaggedInt() ||
- !srcReg1->GetValueType().IsLikelyString() ||
- !srcReg2->GetValueType().IsLikelyString())
+ !srcReg1->GetValueType().HasHadStringT... | [No CFG could be retrieved] | - > - > - > - > - > - > - > - > - > Checks if the given expression is a branch or not. | Here you use HasHadStringTag, but on arm you use HasBeenString, which is slightly stricter; is this intended? |
@@ -54,7 +54,7 @@ namespace System.Text.Json
}
}
- private static byte[] WriteCoreBytes(object value, Type type, JsonSerializerOptions options)
+ private static byte[] WriteCoreBytes(object? value, Type? type, JsonSerializerOptions? options)
{
if (options == n... | [JsonSerializer->[GetRuntimePropertyInfo->[GetType,GetOrAddPolymorphicProperty],WriteValueCore->[WriteCore,s_defaultOptions,nameof],VerifyValueAndType->[GetType,IsAssignableFrom,ThrowArgumentException_DeserializeWrongType,nameof],WriteCore->[GetType,Write,Flush,CurrentValue,WriteCore,Initialize,CurrentDepth,WriteNullVa... | Verify value and type. | Similarly here and else where (WriteCoreString/WriteValueCore/WriteCore methods). Type shouldn't need to be nullable. |
@@ -57,8 +57,7 @@ class {class_name}({base_class_name}):
"""FIXME: Put a proper description of your package here."""
# FIXME: Add a proper url for your package's homepage here.
- homepage = "http://www.example.com"
- url = "{url}"
+ homepage = "http://www.example.com"{url}
{versions}
| [get_versions->[BuildSystemGuesser],PackageTemplate->[write->[write]],create->[get_repository,write,get_versions,get_url,get_name,get_build_system]] | Create a new package file. Writes the new package file. | I assume `{url}` is appended directly here to avoid introducing an extra newline when there is no URL, IMO it's fine to add space for the sake of readability. |
@@ -334,7 +334,7 @@ namespace Microsoft.Xna.Framework
return;
var asyncResult = _coreWindow.Dispatcher.RunIdleAsync( (e) =>
- {
+ {
if (visible)
_coreWindow.PointerCursor = new CoreCursor(CoreCursorType.Arrow, 0);
else
| [UAPGameWindow->[ProcessWindowEvents->[UpdateSize,UpdateOrientation,UpdateFocus,UpdateBackButton],RunLoop->[SetCursor],Tick->[ProcessWindowEvents,Tick]]] | SetCursor - Sets the cursor of the core window. | @mrhelmut code formatting |
@@ -155,7 +155,9 @@ func (h *Harvester) Run() error {
"redis": common.MapStr{
"slowlog": subEvent,
},
- "read_timestamp": common.Time(time.Now().UTC()),
+ "event": common.MapStr{
+ "created": common.Time(time.Now().UTC()),
+ },
},
}
| [Run->[Time,Flush,Unix,Join,Values,Now,UTC,Close,Send,Errorf,NewData,Scan,Receive,Err],NewV4] | Run executes all the commands in the slowlog This function creates a new data object that can be sent to the client. | I think we don't need `common.Time` anymore. |
@@ -212,6 +212,15 @@ class ReservedWords
welcome
work
yes
+ images
+ assets
+ meta
+ guides
+ guide
+ image
+ asset
+ members
+ uploads
].freeze
class << self
| [ReservedWords->[freeze,attr_writer]] | Returns the all - words - node - id sequence number or + BASE_WORDS_NODE. | **nitpick (non-blocking):** Should we keep this list in alphabetical order? Apart from being really good for my OCD, it would also make it easier to scan the list when adding new words later. |
@@ -1,14 +1,16 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
+#nullable enable
namespace System.Xml.Serialization
{
using System;
+ using System.Diagnostics.CodeAnalysis;
using System.Xml;
public clas... | [SoapSchemaMember->[Empty]] | XML Schema Member for a given object. | Someone could pass a `null` value to the setter and now this is no longer non-nullable; isn't that a reason to make this nullable? |
@@ -129,12 +129,13 @@ public class ExpiryTest extends AbstractInfinispanTest {
public void testIdleExpiryInPutAll() throws InterruptedException {
Cache<String, String> cache = cm.getCache();
final long idleTime = EXPIRATION_TIMEOUT;
- Map<String, String> m = new HashMap();
+ Map<String, Stri... | [ExpiryTest->[testValuesAfterExpiryInTransaction->[createTransactionalCacheContainer],testKeySetAfterExpiryInTransaction->[createTransactionalCacheContainer]]] | Test that the idle expiry is in putAll. | I'd rather you used `assertEquals`, something like this: `if (!moreThanLifespanElapsed(...)) assertEquals(cache.get(...), "v"))` |
@@ -34,6 +34,7 @@ type config struct {
Headers map[string]string `config:"headers"`
Username string `config:"username"`
Password string `config:"password"`
+ ApiKey string `config:"api_key"`
ProxyURL string `config:"proxy_url... | [No CFG could be retrieved] | package elasticsearch import. | struct field ApiKey should be APIKey |
@@ -307,8 +307,9 @@ bool WbGps::refreshSensorIfNeeded() {
mMeasuredPosition[2] = altitude;
}
+ mSpeedVector = (t - mPreviousPosition);
// compute current speed [m/s]
- mMeasuredSpeed = (mPreviousPosition - t).length() * 1000.0 / mSensor->elapsedTime();
+ mMeasuredSpeed = mSpeedVector.length() * 1000.0 ... | [refreshSensorIfNeeded->[getLongitude,,getLatitude,getEast,computeNorthEast,computeLatitudeLongitude,getNorth],preFinalize->[setReferenceCoordinates],writeConfigure->[addConfigureToStream],WbSolidDevice->[init],updateReferences->[setReferenceCoordinates],writeAnswer->[refreshSensorIfNeeded]] | Checks if the sensor needs to be refreshed and if so updates the sensor accordingly. if position is in UTM coordinates and we need to do a random noise we need to. | `mSpeedVector` should be computed in meters per second. |
@@ -42,8 +42,8 @@ function pushBuildWorkflow() {
timedExecOrDie('amp check-exact-versions');
timedExecOrDie('amp check-renovate-config');
timedExecOrDie('amp server-tests');
- timedExecOrDie('amp make-extension --name=t --test --cleanup');
- timedExecOrDie('amp make-extension --name=t --test --cleanup --bent... | [No CFG could be retrieved] | Script that runs various checks during CI and PR builds. Check if the target is a valid AMP target and if so execute the appropriate command. | To further simplify things, I wonder if `--test` should automatically imply `--name=foo` and `--cleanup`. With this, callers like `pr-check/checks.js` don't have to know about the internal implementation of `amp make-extension`, and can merely call it with `--test` and `--test --bento`. WDYT? |
@@ -10,6 +10,8 @@ from ..locking import TimeoutTimer, ExclusiveLock, Lock, LockRoster, \
ID1 = "foo", 1, 1
ID2 = "bar", 2, 2
+RACE_TEST_NUM_THREADS = 40
+RACE_TEST_DURATION = 0.4 # seconds
@pytest.fixture()
| [TestExclusiveLock->[test_timeout->[raises,ExclusiveLock],test_migrate_lock->[by_me,migrate_lock,ExclusiveLock],test_acquire_break_reacquire->[break_lock,ExclusiveLock],test_kill_stale->[raises,release,ExclusiveLock,get_process_id],test_checks->[by_me,is_locked,ExclusiveLock]],TestLockRoster->[test_empty->[LockRoster,s... | Return a free PID not used by any process. | was this enough to see test fails with the original code? |
@@ -225,6 +225,11 @@ class RequestsTransport(HttpTransport):
error = None # type: Optional[Union[ServiceRequestError, ServiceResponseError]]
try:
+ timeout = kwargs.pop('connection_timeout', self.connection_config.timeout)
+ if not isinstance(timeout, tuple):
+ _... | [RequestsTransportResponse->[stream_download->[StreamDownloadGenerator]],RequestsTransport->[close->[close],send->[RequestsTransportResponse,open],open->[_init_session]]] | Sends a request object according to configuration. | I see this in logs: `[WARNING _requests_basic]: Tuple timeout setting is deprecated` |
@@ -218,6 +218,8 @@ namespace Microsoft.Xna.Framework
Sdl.Window.SetFullscreen(Handle, (_willBeFullScreen) ? fullscreenFlag : 0);
_hardwareSwitch = _game.graphicsDeviceManager.HardwareModeSwitch;
}
+ // If going to exclusive full-screen mode, force the window to... | [SdlGameWindow->[Dispose->[Dispose],SetTitle->[SetTitle]]] | EndScreenDeviceChange - This method is called when the screen device of the window has changed try to set the window position if it is wrong. | This will cause problems on multimonitor setups, especially on Linux (if I remember correctly). |
@@ -53,7 +53,7 @@ class DocumentsOperations(object):
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType[int]
- error_map = kwargs.pop('error_map', {})
+ error_map = kwargs.pop('error_map', {404: ResourceNotFoundError, 409: Resour... | [DocumentsOperations->[autocomplete_get->[get],get->[get],suggest_get->[get]]] | Queries the number of documents in the index. Runs a pipeline request and returns a object. | If possible, would it make more sense to have a method return these so you can just change the method in one place later and it return a map instead? |
@@ -359,11 +359,13 @@ func (h *SaltpackHandler) saltpackEncryptFile(ctx context.Context, arg keybase1.
}, nil
}
-func (h *SaltpackHandler) saltpackEncryptDirectory(ctx context.Context, arg keybase1.SaltpackEncryptFileArg) (keybase1.SaltpackEncryptFileResult, error) {
+func (h *SaltpackHandler) saltpackEncryptDirec... | [SaltpackVerifySuccess->[SaltpackVerifySuccess],Read->[Read],SaltpackVerifyBadSender->[SaltpackVerifyBadSender],Close->[Close],SaltpackPromptForDecrypt->[SaltpackPromptForDecrypt],Close] | saltpackEncryptFile encrypts a file using Saltpack. Encrypts a file and returns a dict of the result. No - op for saltpack encryption. | i prefer it the way it was so that we know that `res` is empty. can you change it back here and elsewhere? |
@@ -100,9 +100,9 @@ func (c *coordinator) patrolRegions() {
defer timer.Stop()
log.Info("coordinator starts patrol regions")
- start := time.Now()
var key []byte
for {
+ start := time.Now()
select {
case <-timer.C:
timer.Reset(c.cluster.GetOpts().GetPatrolRegionInterval())
| [Schedule->[Schedule],run->[drivePushOperator,patrolRegions,checkSuspectRanges]] | patrolRegions is a long running routine that checks all regions in the cluster and updates the This method is called when the check region is not found. | Should not reset the timer every time but only when it scans to the last region. |
@@ -396,7 +396,8 @@ class Repository:
try:
st = os.stat(path)
except FileNotFoundError:
- raise self.DoesNotExist(path)
+ self.close()
+ raise self.InvalidRepository(self.path)
if not stat.S_ISDIR(st.st_mode):
raise self.InvalidReposi... | [Repository->[prepare_txn->[_read_integrity,prepare_txn,open_index,check_transaction],check_can_create_repository->[AlreadyExists,is_repository,PathAlreadyExists],_update_index->[CheckNeeded],get_transaction_id->[get_index_transaction_id,check_transaction],get->[ObjectNotFound,get_transaction_id,open_index],check_trans... | Open a repository at the specified path. Read a segment from the file and raise an AtticRepository exception if it is not. | overall, you changed the "does not exist" (which is true) into a "invalid" (which is questionable) exception. what's the point? |
@@ -42,7 +42,7 @@ class AuthHandler(object):
form of :class:`letsencrypt.achallenges.AnnotatedChallenge`
"""
- def __init__(self, dv_auth, cont_auth, acme, account):
+ def __init__(self, dv_auth, cont_auth, acme, account, config=None):
self.dv_auth = dv_auth
self.cont_auth = cont... | [_report_failed_challs->[dict,getUtility,add_message,setdefault,_generate_failed_chall_msg,itervalues],_find_smart_path->[AuthorizationError,enumerate,fatal,get],_find_dumb_path->[append,len,set,isinstance,add,enumerate,is_preferred],_generate_failed_chall_msg->[dict,append,sorted,setdefault,format,join],gen_challenge_... | Initialize the object with the values of the nanoseconds. | `config=None` should be changed to just `config` (i.e. without default value) - this class won't work without valid `IConfig` - moreover, you should update the docstring for the class |
@@ -46,7 +46,9 @@ def stat_proxy(path: str) -> os.stat_result:
return st
-def main(script_path: Optional[str], args: Optional[List[str]] = None) -> None:
+def main(script_path: Optional[str], args: Optional[List[str]] = None,
+ stdout: TextIO = sys.stdout,
+ stderr: TextIO = sys.stderr) -> ... | [process_options->[add_invertible_flag->[invert_flag_name],add_invertible_flag,SplitNamespace,infer_python_executable],infer_python_executable->[_python_executable_from_version],AugmentedHelpFormatter->[_fill_text->[_fill_text]],_python_executable_from_version->[PythonExecutableInferenceError]] | Main entry point to the type checker. Delete a object if it exists. | We shouldn't use `sys.stdout` as a default argument value, because it is evaluated at module load time, not when the function is called. This means that if something *else* hijacks stdout, we will ignore that and write to the original one. In cases where it needs to have a default value, have it be an `Optional[TextIO]... |
@@ -53,6 +53,8 @@ public class DataWeaveExpressionLanguageAdaptor implements ExtendedExpressionLan
public static final String ATTRIBUTES = "attributes";
public static final String ERROR = "error";
public static final String VARIABLES = "variables";
+ public static final String PROPERTY = "property";
+ public... | [DataWeaveExpressionLanguageAdaptor->[addGlobalBindings->[addGlobalBindings],bindingContextBuilderFor->[addEventBindings],split->[split],validate->[validate],evaluate->[evaluate]]] | Package private for testing purposes. Register global bindings. | let's use parameters since we don't have any other binding without the complete name |
@@ -165,7 +165,11 @@ func (s *CachingParticipantSource) GetNonblock(ctx context.Context, uid gregor1.
func (s *CachingParticipantSource) GetWithNotifyNonblock(ctx context.Context, uid gregor1.UID,
convID chat1.ConversationID, dataSource types.InboxSourceDataSourceTyp) {
go func(ctx context.Context) {
- s.sema.Acq... | [GetWithNotifyNonblock->[GetNonblock],GetNonblock->[dbKey,Get]] | GetWithNotifyNonblock gets all participants from the cache. | Same here, just ignore the error |
@@ -60,6 +60,12 @@ public class HttpListenerConnectionManager implements Initialisable, Disposable,
}
+ private String getAppName()
+ {
+ String appName = ThreadNameHelper.getPrefix(muleContext);
+ return StringUtils.isEmpty(appName) ? UNKNOWN_APP_NAME : appName;
+ }
+
@Override
... | [HttpListenerConnectionManager->[dispose->[dispose]]] | Initialise the server manager. | This is inconsistent with org.mule.util.concurrent.ThreadNameHelper#getPrefix. This means when http is used in a domain delayedExecutor threads will have "UNKNOWN_APP_NAME" prefix which isn't great while other threads simply have no appName prefix. |
@@ -76,14 +76,6 @@ namespace System.Windows.Forms
return;
}
- var bounds = ClientBounds;
-
- // It is necessary so that when HighContrast is off, the size of the dotted borders
- // coincides with the size of the button background
- // For norm... | [PropertyGridToolStripButton->[OnPaint->[OnPaint,DrawHightContrastDashedBorer,DrawDashedBorer]]] | Override OnPaint to call the base method and call the appropriate method depending on the selected state. | Strange, but I agree that this looks like a bad copy/paste rather than `ClientBound` called for some side-effect. @SergeySmirnov-Akvelon - FYI |
@@ -1027,8 +1027,7 @@ function $HttpProvider() {
if (isDefined(cachedResp)) {
if (isPromiseLike(cachedResp)) {
// cached request has already been sent, but there is no response yet
- cachedResp.then(removePendingReq, removePendingReq);
- return cachedResp;
+ ... | [No CFG could be retrieved] | Makes the request to the server and returns a promise. Creates a promise that resolves the response if desired. | May it be that the Travis CI is failing because cachedResp is not returned any more here? |
@@ -112,9 +112,9 @@ public class MainPanel extends JPanel implements Observer, Consumer<SetupPanel>
remove(mainPanel);
remove(chatSplit);
chatPanelHolder.removeAll();
- final ChatModel chat = chatPanelSupplier.get().orElse(null);
- if (chat instanceof SetupPanel) {
- chatPanelHolder.add((Setup... | [MainPanel->[accept->[addChat],update->[setWidgetActivation]]] | Add a chat. | I just realized what is the problem here. Your change is overkill here, I opened #4788 to fix this issue |
@@ -21,12 +21,13 @@ namespace Dynamo.LibraryUI.Handlers
public string contextData { get; set; }
public string parameters { get; set; }
public string itemType { get; set; }
+ public string description { get; set; }
public string keywords { get; set; }
}
- class Loaded... | [NodeItemDataProvider->[Stream->[Flush,Serialize,Position,ToList,GetNodeItemDataStream,SearchEntries,loadedTypes],LoadedTypeItem->[HasFlag,Any,fullyQualifiedName,CustomNode,Format,FullCategoryName,Url,Empty,FullName,Aggregate,ToLower,Name,CreationName,Parameters,iconUrl,Packaged],model]] | Creates a data provider for all the loaded node types. Creates a LoadedTypeItem from a NodeSearchElement. | you might want to put a condition for T to be derived from LoadedTypeItem |
@@ -13,6 +13,7 @@ Rails.application.configure do
config.assets.js_compressor = :uglifier
config.assets.compile = false
config.assets.digest = true
+ config.assets.gzip = false
config.i18n.fallbacks = true
config.active_support.deprecation = :notify
config.active_record.dump_schema_after_migration = f... | [new,rails_mailer_previews_enabled,show_previews,compile,raise_delivery_errors,preview_path,join,domain_name,consider_all_requests_local,asset_host,cache_classes,deprecation,dump_schema_after_migration,logger,redis_url,fallbacks,log_to_stdout,delivery_method,disable_email_sending,eager_load,ignore_actions,default_url_o... | Rails configuration for the IdentityProvider. Initialize a new object with the given options. | do we need this in `development.rb` or `test.rb`? |
@@ -3396,7 +3396,7 @@ void SSL_CTX_free(SSL_CTX *a)
SSL_CTX_SRP_CTX_free(a);
#endif
#ifndef OPENSSL_NO_ENGINE
- ENGINE_finish(a->client_cert_engine);
+ ssl_engine_finish(a->client_cert_engine);
#endif
#ifndef OPENSSL_NO_EC
| [No CFG could be retrieved] | Frees all internal session cache and all of the SSL_CTX objects. Frees all resources held by an SSL context. | Is it worth folding this (and other similar) `#ifndef` into the `tls_depr.c` file too? |
@@ -229,7 +229,12 @@ millis_t next_button_update_ms;
#endif // HAS_LCD_MENU
void MarlinUI::init() {
-
+ //DrDitto
+ //BootScreen and Custom Boot screen moved
+ //Prior the LCD INIT
+ #if HAS_SPI_LCD && ENABLED(SHOW_BOOTSCREEN)
+ ui.show_bootscreen();
+ #endif
init_lcd();
#if HAS_DIGITAL_BUTTONS
| [No CFG could be retrieved] | _wrap_string _wrap_string _wrap_string _wrap_string _wrap Creates a list of all non - labelable components that are related to a single color color. | How can you display the bootscreen before the display is initialized? |
@@ -41,8 +41,13 @@ enum Adds
NPC_SMOLDERTHORN_BERSERKER = 9268
};
-const Position SummonLocation1 = { -39.355f, -513.456f, 88.472f, 4.679f };
-const Position SummonLocation2 = { -49.875f, -511.896f, 88.195f, 4.613f };
+enum Misc
+{
+ CALL_HELP = 0,
+};
+
+const Position SummonLocation1 = {-49.43f, -45... | [boss_overlord_wyrmthalak->[boss_overlordwyrmthalakAI->[JustDied->[_JustDied],UpdateAI->[DoCastVictim,SelectTarget,ExecuteEvent,ScheduleEvent,DoMeleeAttackIfReady,HasUnitState,HealthBelowPct,UpdateVictim,SummonCreature,AI,Update],Reset->[_Reset],EnterCombat->[ScheduleEvent,_EnterCombat]]]] | The boss_overlord_wyrmthalak Creature. | Just use `constexpr` for this |
@@ -31,6 +31,7 @@
<p>
<%= broadcast.processed_html %>
</p>
+ <h3>Last Active: <%= broadcast.last_active_at %></h3>
<h3>Status:</h3>
<h3>
<span class="badge badge-<%= broadcast.active? ? "success" : "warning" %>">
| [No CFG could be retrieved] | View for the n - node . | Should I format this timestamp at all? |
@@ -73,8 +73,10 @@ class Addr(common.Addr):
ssl = True
elif nextpart == 'default_server':
default = True
+ elif nextpart == "ipv6only=on":
+ ipv6only = True
- return cls(host, port, ssl, default)
+ return cls(host, port, ssl, defau... | [VirtualHost->[__repr__->[__str__]],Addr->[super_eq->[Addr],__repr__->[__str__],__eq__->[super_eq],__str__->[to_string]],_find_directive->[_find_directive]] | Initialize Addr from string. | What do we want this variable to represent? "Was ipv6only=on explicitly set" is what it currently is. That's not the same as "is ipv6only on for this address", because the default varies by Nginx version. |
@@ -414,3 +414,11 @@ CELERY_ACCEPT_CONTENT = ['json']
CELERY_TASK_SERIALIZER = 'json'
CELERY_RESULT_SERIALIZER = 'json'
CELERY_RESULT_BACKEND = 'django-db'
+
+# IMPERSONATE SETTINGS
+IMPERSONATE_URI_EXCLUSIONS = [r'^dashboard/']
+IMPERSONATE_CUSTOM_USER_QUERYSET = 'saleor.userprofile.utils.get_customers'
+IMPERSONAT... | [get_list->[strip,split],get_host->[get_current],literal_eval,parse,get_list,dirname,get,getenv,config,join,normpath] | Set the default serializers and backends for the task. | `IMPERSONATE_GET_PARAM` doesn't come from the `imperonsate` package and here it's mixed with settings that do, which is confusing. Except for that, this setting is related to showing a success message which should be rewritten in the first place. |
@@ -243,7 +243,6 @@ int main(int argc, char *argv[])
arg.size = 0;
/* Set up some of the environment. */
- default_config_file = make_config_name();
bio_in = dup_bio_in(FORMAT_TEXT);
bio_out = dup_bio_out(FORMAT_TEXT);
bio_err = dup_bio_err(FORMAT_TEXT);
| [No CFG could be retrieved] | Initialize the functions and arguments for the given trace code. Reads the command line arguments and checks if the user has specified a valid program name. | also unclear if the return value of dup_bio_xxx should be checked likewise. |
@@ -38,8 +38,10 @@ BuildRequires: libpmem-devel >= 1.8, libpmemobj-devel >= 1.8
BuildRequires: fuse3-devel >= 3.4.2
%if (0%{?suse_version} >= 1500)
BuildRequires: libprotobuf-c-devel
+BuildRequires: liblz4-devel
%else
BuildRequires: protobuf-c-devel
+BuildRequires: lz4-devel
%endif
BuildRequires: spdk-devel >= 2... | [No CFG could be retrieved] | Return a string describing the version of a sequence number. Check if a node - id is present in the system. | @brianjmurrell It sounds like the package has a different name on centos and leap. Did i insert this in the right place? I wasn't sure ... |
@@ -13,7 +13,6 @@
// System includes
// External includes
-#include <boost/python.hpp>
// Project includes
| [No CFG could be retrieved] | Create a single object. | also this is unuesed, you could remove it |
@@ -85,12 +85,14 @@ func (e *Bootstrap) Run(ctx *Context) error {
if e.G().ConnectivityMonitor.IsConnected(context.Background()) == libkb.ConnectivityMonitorYes {
e.G().Log.Debug("connected, running full tracker2 syncer")
if err := libkb.RunSyncer(ts, e.status.Uid, false, nil); err != nil {
- return err
+ e... | [signedUp->[GetUID,GetConfig,G,Exists],Run->[GetDeviceID,RunSyncerCached,GetUsername,Account,LoginState,UID,IsConnected,Result,G,Name,Background,LoggedInProvisioned,NewTracker2Syncer,String,RunSyncer,signedUp,Debug],NewContextified] | Run executes the bootstrap command. filter usums into followers and following. | Should this return an error again with the fix in play? |
@@ -338,10 +338,7 @@ func (d *driver) fsck(ctx context.Context, fix bool, cb func(*pfs.FsckResponse)
}
contains := false
for _, headProv := range headCommitInfo.Provenance {
- if provBranchInfo.Head.Branch.Repo.Name == headProv.Commit.Branch.Repo.Name &&
- provBranchInfo.Branch.Repo.Name ==... | [Error->[Sprintf,BranchKey,WriteString,String],fsck->[WhoAmI,GetDBClient,IsErrExists,Clone,GetByIndex,Error,Wrapf,Create,RepoKey,GetPachClient,IsErrNotActivated,DefaultOptions,ReadWrite,Sprintf,BranchKey,NewSQLTx,ReadOnly,List,CommitKey,ScrubGRPC],BranchKey,Join] | fsck calls fsck on all branches and commits DefaultOptions is the default options for the command. This function checks if there is a head commit in the commitInfos map and if so it This function checks that the head commit is consistent with the provenance of the other branches. | I wasn't sure if we tend to avoid `proto.Equal`, I can definitely understand not wanting to use `reflect` more than necessary |
@@ -380,7 +380,7 @@ public class DocTabLayoutPanel
event.preventDefault();
event.stopPropagation();
}
- break;
+
}
case Event.ONMOUSEMOVE:
| [DocTabLayoutPanel->[DocTab->[endDrag->[onTabMove],drag->[execute->[autoScroll]],onBrowserEvent->[onTabClose,onBrowserEvent],replaceIcon->[remove],closeTab,add],onResize->[onResize,ensureSelectedTabIsVisible],remove->[ensureSelectedTabIsVisible,remove,selectTab],selectTab->[selectTab],add->[add],replaceDocName->[replac... | Override onBrowserEvent to handle mouse events. | Looks like ONMOUSEDOWN now falls through to ONMOUSEMOVE - intentional? |
@@ -93,7 +93,8 @@ import {
import { CUSTOM_USER_SEARCH_OPTIONS } from "select-kit/components/user-chooser";
import { downloadCalendar } from "discourse/lib/download-calendar";
-// If you add any methods to the API ensure you bump up this number
+// If you add any methods to the API ensure you bump up the version nu... | [No CFG could be retrieved] | Imports a plugin and returns a function that can be used to modify a plugin s properties. Constructor for PluginApi. | I think we should be more explicit about this. I've often seen the patch version being bumped when we're adding new features in a backwards compatible manner. |
@@ -48,6 +48,13 @@ module.exports = class extends needleServer {
this.addBlockContentToFile(rewriteFileModel, errorMessage);
}
+ addLoadColumnToEntityChangeSet(filePath, content) {
+ const errorMessage = 'LoadColumn not added.';
+ const rewriteFileModel = this.generateFileModel(filePath... | [No CFG could be retrieved] | Adds column to entity changeset. | I would have designed this API differently, e.g. `addLoadColumnToEntityChangeSet(filePath, columnName, otherAttributes)` where otherAttributes whould be a map and then would have filled a template `<column name="${columnName}" attribute1="..." attribute2="..." />` in the spirit of what is done for the maven needle api.... |
@@ -183,7 +183,8 @@ func (a *ACME) leadershipListener(elected bool) error {
account := object.(*Account)
account.Init()
// Reset Account values if caServer changed, thus registration URI can be updated
- if account != nil && account.Registration != nil && !strings.HasPrefix(account.Registration.URI, a.CAServe... | [storeRenewedCertificate->[renewCertificates],getCertificate->[getCertificate],CreateClusterConfig->[init]] | leadershipListener is the listener for the leadership event. It is called when a user. | It's should be `!isAccountMatchingCaServer(account.Registration.URI, a.CAServer)` instead of `isAccountMatchingCaServer(account.Registration.URI, a.CAServer)` no ? |
@@ -81,6 +81,16 @@ func (m *MetricSet) Fetch(reporter mb.ReporterV2) error {
}
for _, family := range families {
+ if m.includeMetrics != nil {
+ if !matchMetricFamily(*family.Name, m.includeMetrics) {
+ continue
+ }
+ } else if m.ignoreMetrics != nil {
+ if matchMetricFamily(*family.Name, m.ignoreMetr... | [addUpEvent->[LabelsHash,Host],Fetch->[HasKey,addUpEvent,Update,Name,Host,Module,GetFamilies,Event,Wrap,LabelsHash,Put],Build,DefaultMetricSet,MustAddMetricSet,WithHostParser,NewPrometheusClient] | Fetch fetches all metrics from the prometheus endpoint and adds them to the metric set get a free free free free free free free free free free free free free free free free. | Not sure if this can happen, but should we check if `familiy` is nil before dereferencing it? |
@@ -276,3 +276,18 @@ class CustomerEvent(models.Model):
def __repr__(self):
return f"{self.__class__.__name__}(type={self.type!r}, user={self.user!r})"
+
+
+class StaffNotificationRecipient(models.Model):
+ user = models.OneToOneField(
+ User,
+ related_name="staff_notification",
+ ... | [UserManager->[create_superuser->[create_user]],User->[UserManager],Address->[get_copy->[as_data],PossiblePhoneNumberField],ServiceAccount->[has_perm->[_get_permissions],has_perms->[_get_permissions]]] | Return a string representation of the object. | I think that we actually don't need this relationship. I thought we will use `SiteSettings` model to store these addresses but since it's a separate model, is there any use case for that? |
@@ -616,14 +616,13 @@ namespace Pulumi.Automation
}
private async Task<CommandResult> RunCommandAsync(
- IEnumerable<string> args,
+ IList<string> args,
Action<string>? onStandardOutput,
Action<string>? onStandardError,
Action<EngineEvent>... | [WorkspaceStack->[InlineLanguageHost->[ValueTask->[Dispose],GetPortAsync->[Task]],ExportStackAsync->[ExportStackAsync],GetConfigAsync->[GetConfigAsync],GetAllConfigAsync->[GetAllConfigAsync],RefreshConfigAsync->[RefreshConfigAsync],Dispose->[Dispose]]] | Asynchronously runs the given command in the workspace. | This looked like a bug as it never passed `argsList`. |
@@ -55,3 +55,18 @@ func convertName(str string) string {
}
return string(name)
}
+
+// PrometheusPushClient pushs metrics to Prometheus Pushgateway.
+func PrometheusPushClient(job, addr string, interval time.Duration) {
+ for {
+ if err := push.FromGatherer(
+ job, push.HostnameGroupingKey(),
+ addr,
+ prom... | [GetCmdType,String] | Get the name of the node. | Shouldn't we use log here? |
@@ -504,6 +504,17 @@ namespace Dynamo.Models
protected override void ExecuteCore(DynamoModel dynamoModel)
{
dynamoModel.OpenFileImpl(this);
+
+ // Log file open action and the number of nodes in the opened workspace
+ Dynamo.Logging.Analytics.Crea... | [DynamoModel->[CreateAnnotationCommand->[SerializeCore->[SerializeCore]],AddModelToGroupCommand->[SerializeCore->[SerializeCore]],DeleteModelCommand->[SerializeCore->[SerializeCore]],MakeConnectionCommand->[SerializeCore->[SerializeCore],setProperties],UpdateModelValueCommand->[SerializeCore->[SerializeCore]],ApplyPres... | Execute the DynamoFile. | Can we track this in one event, with a new Action `Unresolved`, value as number of unresolved, Description as comma separated string? |
@@ -247,15 +247,10 @@ func getServiceUptime(processID uint32) (time.Duration, error) {
return uptime, nil
}
-func getDetailedServiceInfo(handle ServiceDatabaseHandle, serviceName string, accessRight ServiceAccessRight, service *ServiceStatus) error {
+func getAdditionalServiceInfo(serviceHandle ServiceHandle, serv... | [getServiceID->[EncodeToString,Sum256],Error->[Handle,Itoa,Errno,Error,FormatMessage,Decode],Read->[getServiceID,Put],Wrapf,Reset,Unix,Warn,Itoa,OpenKey,Duration,GetStringValue,Pointer,Wrap,String,Get,UTF16PtrFromString,Since,UTF16ToUTF8Bytes,Sizeof] | getServiceUptime returns the uptime for a given service. Close returns an error if the service handle could not be opened. | Same here. I think the caller should be responsible for closing the handle. |
@@ -1836,7 +1836,10 @@ public class CompositeByteBuf extends AbstractReferenceCountedByteBuf implements
}
// Replace the first readable component with a new slice.
- int trimmedBytes = readerIndex - c.offset;
+ int trimmedBytes = 0;
+ if (c != null) {
+ trimmedBytes =... | [CompositeByteBuf->[toByteIndex->[checkComponentIndex],resetWriterIndex->[resetWriterIndex],_setIntLE->[order,_setShortLE],setIndex->[setIndex],_setMedium->[setMedium,_setShort,_setByte,order],resetReaderIndex->[resetReaderIndex],writeZero->[writeZero],retain->[retain],component->[checkComponentIndex],_setMediumLE->[_s... | Discard all read bytes in this buffer. | This "fix" not looks valid at all... Also it would just throw an NPE under the if blog. Can you show me the NPE you are seeing ? |
@@ -945,6 +945,7 @@ int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
}
if (SSL_TREAT_AS_TLS13(s)
+ && !BIO_get_ktls_send(s->wbio)
&& s->enc_write_ctx != NULL
&& (s->statem.enc_write_state != ENC_WRITE_STATE_WRITE_PLAIN_ALERTS
... | [No CFG could be retrieved] | loops through the SSL3 records and checks if the record is valid and if so sets Add TLS1. 3 padding to the record. | Yes, that is checked on configuration stage |
@@ -78,11 +78,12 @@ public class KVMHostInfo {
}
protected static long getCpuSpeed(final NodeInfo nodeInfo) {
- try (final Reader reader = new FileReader(
- "/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq")) {
- return Long.parseLong(IOUtils.toString(reader).trim()) /... | [KVMHostInfo->[getHostInfoFromLibvirt->[getCapabilities,getCpuSpeed]]] | Get the CPU speed of the system. | _Using_ repeated in log ^^^ |
@@ -158,7 +158,7 @@ module Api
end
end
- parameters = [:last_name, :first_name, :type, :grace_credits, :email, :id_number]
+ parameters = [:last_name, :first_name, :type, :grace_credits, :email, :id_number, :hidden]
parameters.each do |key|
unless params[key].blank?
... | [UsersController->[create->[nil?,render,new,downcase,process_attributes,type,authorize,has_missing_params?,find_by_user_name,save,delete],show->[nil?,xml,render,respond_to,to_json,fields_to_render,json,to_xml,find_by_id],process_attributes->[each,find_by_name,id,blank?],update->[nil?,render,attributes,process_attribute... | Process the attributes of a record based on the given parameters. | Style/SymbolArray: Use %i or %I for an array of symbols. |
@@ -42,7 +42,10 @@ func NewLogger(bufLen int64, mode, config string) {
// DelLogger removes loggers that are for the given mode
func DelLogger(mode string) error {
for _, l := range loggers {
- if _, ok := l.outputs[mode]; ok {
+ l.lock.RLock()
+ _, ok := l.outputs[mode]
+ l.lock.RUnlock()
+ if ok {
return... | [Flush->[Flush],Fatal->[Close,writerMsg],Trace->[writerMsg],Info->[writerMsg],Critical->[writerMsg],Error->[writerMsg],Warn->[writerMsg],Close->[Flush],Debug->[writerMsg]] | NewLogger creates a logger for the given log adapter and creates a logger for the given log Trace logs a single log entry with format string and values. | Doesn't this cause a race between checking and removing? |
@@ -124,7 +124,8 @@
immediateRetriesAvailable,
delayedRetriesAvailable,
MessageRetryNotification,
- MessageFaultedNotification);
+ MessageFaultedNotification,
+ builder.Build<IDispatchMessages>());
}
Imme... | [RecoverabilityComponent->[DelayedConfig->[settings,Zero,Warn],Initialize->[ErrorQueue,MaxNumberOfRetries,None,TransactionMode,AddStartupDiagnosticsSection,ErrorQueueAddress,UnrecoverableExceptions,IsSendOnlyEndpoint,GetDelayedRetryConfig,HostInformation,WireUpLegacyNotifications,ToString,ToArray,BindSending,GetImmedia... | Creates a RecoverabilityExecutorFactory which creates a new RecoverabilityExecutor based on the Missing configuration. | it looks like the dispatcher is build several times (but a bit later since we're only passing factories), given that the builder is created here anyway, could that be reused? |
@@ -2303,7 +2303,12 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase,
// Draw tooltip
std::wstring tooltip_text = L"";
if (hovering && !m_selected_item) {
- tooltip_text = utf8_to_wide(item.getDefinition(m_client->idef()).description);
+ const std::string &desc = item.metadata.getStr... | [No CFG could be retrieved] | Draws slot box with 2D rectangle Manages the position of the tooltip. | it's a good place to use braces to prsent problems |
@@ -5,17 +5,6 @@
from spack import *
-import numbers
-
-
-def is_integral(x):
- """Any integer value"""
- try:
- return isinstance(int(x), numbers.Integral) and not isinstance(x, bool)
- except ValueError:
- return False
-
-
class NetcdfC(AutotoolsPackage):
"""NetCDF (network Common Da... | [is_integral->[int,isinstance],NetcdfC->[url_for_version->[Version,format],libs->[find_libraries],force_autoreconf->[satisfies],check->[make],patch->[join_path,TypeError,int,filter,format,FileFilter],configure_args->[append,enable_or_disable,join,satisfies],depends_on,conflicts,version,patch,variant]] | Check if x is an integer. | I think you need one more empty line here to get flake8 to pass, although I can't seem to view the Travis report. |
@@ -1209,7 +1209,7 @@ class KumaGitHubTests(UserTestCase, SocialTestMixin):
data = {
"website": "",
"username": "octocat",
- "email": "octo.cat@github-inc.com",
+ "email": "octocat-private@example.com",
"terms": True,
"is_github_url_publ... | [test_user_edit_beta->[_get_current_form_field_values],test_user_edit_websites->[_get_current_form_field_values],test_user_edit_github_is_public->[_get_current_form_field_values],KumaGitHubTests->[test_signup_private_github->[test_signup_public_github]],BanUserAndCleanupSummaryTestCase->[test_post_submits_no_revisions_... | Test if user is on GitHub. | I know this test wasn't related but it became. Now that you're not allowed to POST in an email that isn't one of your OAuth emails (from the scope), all the tests that didn't adhere needed to change too. |
@@ -1476,7 +1476,8 @@ class Diaspora
public static function fetchByURL($url, $uid = 0)
{
// Check for Diaspora (and Friendica) typical paths
- if (!preg_match("=(https?://.+)/(?:posts|display)/([a-zA-Z0-9-_@.:%]+[a-zA-Z0-9])=i", $url, $matches)) {
+ if (!preg_match("=(https?://.+)/(?:posts|display|objects)/([a... | [Diaspora->[decodeRaw->[children,attributes],sendParticipation->[set,get],validPosting->[children,getName],verifyMagicEnvelope->[children,attributes],receiveStatusMessage->[children],buildStatus->[t,set,get],message->[getName],decode->[children,attributes],dispatchPublic->[get],relayList->[get],sendAccountMigration->[g... | Fetch item by URL. | Shouldn't you add the `$url` in the logger context? |
@@ -226,3 +226,17 @@ class TestGeneralOptions(object):
options1, args1 = main(['--cert', 'path', 'fake'])
options2, args2 = main(['fake', '--cert', 'path'])
assert options1.cert == options2.cert == 'path'
+
+
+class TestOptionsConfigFiles(object):
+
+ def test_general_option_after_subcomma... | [TestOptionsInterspersed->[test_general_option_after_subcommand->[main],test_subcommand_option_before_subcommand_fails->[main],test_additive_before_after_subcommand->[main],test_option_after_subcommand_arg->[main]],TestOptionPrecedence->[test_cli_override_environment->[main],test_env_alias_override_default->[main],test... | Test that the certificate specified in the command line is the same as the one specified in the. | how about relabel this test name. "test_venv_config_file_found" |
@@ -53,6 +53,7 @@ class SuperluDist(CMakePackage, CudaPackage):
patch('xl-611.patch', when='@:6.1.1 %xl')
patch('xl-611.patch', when='@:6.1.1 %xl_r')
+ patch('superlu-cray-ftn-case.patch', when='%cce')
def cmake_args(self):
spec = self.spec
| [SuperluDist->[cache_test_sources->[cache_extra_test_sources],flag_handler->[append,list],test->[join_path,working_dir,filter_file,format,which,run_test,make],cmake_args->[append,spec,format,satisfies],depends_on,conflicts,version,patch,variant,run_after]] | Returns the arguments for the C ++ command. Get the list of arguments to set the flag if the node is not managed by the. | @xiaoyeli @pghysels - perhaps this fix can go into superlu-dist sources. And in spack - limit this patch to version 7.1.1 and lower? |
@@ -155,15 +155,13 @@ namespace System.Runtime.Loader
dll = context.GetResolvedUnmanagedDll(assembly, unmanagedDllName);
}
- #region Copied from AssemblyLoadContext.CoreCLR.cs, modified until our AssemblyBuilder implementation is functional
private static RuntimeAssembly? GetRunt... | [AssemblyLoadContext->[GetLoadedAssemblies->[InternalGetLoadedAssemblies],InternalGetLoadedAssemblies->[InternalCall],MonoResolveUsingLoad->[Resolve],MonoResolveUnmanagedDll->[GetAssemblyLoadContext,LoadUnmanagedDll],MonoResolveUsingResolvingEvent->[Zero,Target,ResolveUsingEvent],MonoResolveUnmanagedDllUsingEvent->[Get... | MonoResolveUnmanagedDllUsingEvent - This method is called from Mono. | This doesn't compile, would suggest replacing it with ifs. |
@@ -104,7 +104,7 @@ interface ResourceLocatorMapperInterface
*
* @return string
*/
- public function getUniquePath($path, $webspaceKey, $languageCode, $segmentKey = null);
+ public function getUniquePath($path, $webspaceKey, $languageCode, $segmentKey = null, $uuid = null);
/**
* Re... | [No CFG could be retrieved] | Returns a unique path. | Would not change this Interface |
@@ -35,7 +35,12 @@ class Jetpack_Gallery_Settings {
/**
* Outputs a view template which can be used with wp.media.template
- */
+ *
+ * @Since 2.5.1
+ *
+ * @param array $instance An array of gallery types.
+ *
+ */
function print_media_templates() {
$default_gallery_type = apply_filters( 'jetpack_... | [No CFG could be retrieved] | Print the media templates. | Could you make sure `since` is all lowercase? |
@@ -137,6 +137,16 @@ func (c Range) Check(event ValuesMap) bool {
}
default:
+ // If it's an Slice, apply range on number of elements
+ if reflect.TypeOf(value).Kind() == reflect.Slice {
+ count := reflect.ValueOf(value).Len()
+ if !checkValue(float64(count), rangeValue) {
+ return false
+ } e... | [Check->[Float,Int,ValueOf,Warnf,Uint,GetValue,L,Named],String->[Sprintf],Split,Errorf,TrimSuffix] | Check checks if the given event is in the range. | if block ends with a return statement, so drop this else and outdent its block |
@@ -201,6 +201,11 @@ def finalize_update() -> None:
shutil.rmtree(FINALIZED)
shutil.copytree(OVERLAY_MERGED, FINALIZED, symlinks=True)
+ # Log git repo corruption
+ fsck = run(["git", "fsck", "--no-progress"], FINALIZED).rstrip()
+ if len(fsck):
+ cloudlog.error(f"found git corruption, git fsck:\n{fsck}... | [No CFG could be retrieved] | Check if the. overlay_init file is newer than BASEDIR and if so assume that Download the update manifest from Neo and alert the user. | Won't git fsck throw a CalledProcessError if it returns with a non zero return code? |
@@ -16,7 +16,10 @@
*/
package org.apache.zeppelin.interpreter;
+import org.apache.zeppelin.tabledata.ColumnDef;
+
import java.io.Serializable;
+import java.util.List;
/**
* Interpreter result message
| [InterpreterResultMessage->[toString->[toLowerCase]]] | Construct a new object that represents a single . | I think it's better to replace `this(type, data, new ArrayList<ColumnDef.TYPE>()`. |
@@ -4601,6 +4601,8 @@ p {
$redirect = $redirect ? esc_url_raw( $redirect ) : esc_url_raw( menu_page_url( 'jetpack', false ) );
+ $gp_locale = GP_Locales::by_field( 'wp_locale', get_locale() );
+
if( isset( $_REQUEST['is_multisite'] ) ) {
$redirect = Jetpack_Network::init()->get_url( 'network_admin_pa... | [Jetpack->[admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],dashboard_widget_connect_to_wpcom->[build_connect_url],check_identity_crisis->[get_cloud_site_options],register->[generate_secrets,stat,validate_remote_r... | Build the connect url for the Jetpack API nonce function for Jetpack authorization. | `GP_Locales` is wpcom only :( |
@@ -415,7 +415,7 @@ abstract class AbstractItemNormalizer extends AbstractObjectNormalizer
*
* @return string|array
*/
- private function normalizeRelation(PropertyMetadata $propertyMetadata, $relatedObject, string $resourceClass, string $format = null, array $context)
+ protected function norma... | [AbstractItemNormalizer->[denormalizeRelation->[denormalize],setValue->[setValue],getAttributeValue->[getFactoryOptions,normalize],normalizeRelation->[normalize,createRelationSerializationContext]]] | Normalizes a relation. | Not sure that this should be protected. Other changes in this file are not needed |
@@ -1133,6 +1133,11 @@ func updateUser(e Engine, u *User) error {
// UpdateUser updates user's information.
func UpdateUser(u *User) error {
+ u.Email = strings.ToLower(u.Email)
+ _, err := mail.ParseAddress(u.Email)
+ if err != nil {
+ return ErrEmailInvalid{u.Email}
+ }
return updateUser(x, u)
}
| [RealSizedAvatarLink->[CustomAvatarPath,GenerateRandomAvatar],NewGitSig->[GetEmail],AvatarLink->[RelAvatarLink],RelAvatarLink->[SizedRelAvatarLink],GetOrganizationCount->[getOrganizationCount],GetAccessRepoIDs->[GetRepositoryIDs,GetOrgRepositoryIDs],APIFormat->[GetEmail],IsPasswordSet->[ValidatePassword],DeleteAvatar->... | updateUser updates user s owner name and email. deleteBeans deletes all given beans and updates user with the last deleted object. | could this logic be moved to `updateUser` so that all the update user logic is kept together. |
@@ -1519,6 +1519,14 @@ dnode_hold_impl(objset_t *os, uint64_t object, int flag, int slots,
return (SET_ERROR(EEXIST));
}
+ /* Don't actually hold if dry run, just return 0 */
+ if (flag & DNODE_DRY_RUN) {
+ mutex_exit(&dn->dn_mtx);
+ dnode_slots_rele(dnc, idx, slots);
+ dbuf_rele(db, FTAG);
+ return ... | [No CFG could be retrieved] | finds the object in the tree of all children of a given slot and if get the first object of the dnode that has a specific tag or - 1 if it. | I use dry run, otherwise it will set slot to interiors and cause the next hold DNODE_MUST_BE_FREE to fail. |
@@ -154,6 +154,11 @@ class ProductVariant(CountableDjangoObjectType):
def resolve_price_override(self, info):
return self.price_override
+ def resolve_quantity_ordered(self, info):
+ # This field is added through annotation when using the
+ # `resolve_top_products` resolver.
+ re... | [AttributeValue->[resolve_type->[resolve_attribute_value_type],AttributeValueType],Product->[resolve_availability->[ProductAvailability],resolve_attributes->[resolve_attribute_list],resolve_margin->[Margin]],ProductVariant->[resolve_attributes->[resolve_attribute_list]]] | Resolve the price override for a given node. | I couldn't find this one. |
@@ -774,7 +774,11 @@ class Stage(object):
env=fix_env(os.environ),
executable=executable,
)
- p.communicate()
+
+ try:
+ p.communicate()
+ except KeyboardInterrupt:
+ p.communicate()
if p.returncode != 0:
raise StageCm... | [Stage->[_run->[_warn_if_fish,_check_missing_deps,StageCmdFailedError],dumpd->[relpath],_check_stage_path->[StagePathOutsideError,StagePathNotFoundError,StagePathNotDirectoryError],_changed_md5->[changed_md5],relpath->[relpath],is_stage_file->[is_valid_filename],remove->[remove_outs],_check_file_exists->[StageFileDoesN... | Runs the specified command and checks the missing dependencies. | This doesn't seem like a right way to do this. What we should do instead is setup a signal handler that would ignore SIGINT until we are done with the process. Note that the process that we are spawning shouldn't inherit that signal handler. |
@@ -109,4 +109,5 @@ public interface ExpressionLanguage
@Deprecated
<T> T evaluate(String expression, MuleMessage message, Map<String, Object> vars);
+ TypedValue evaluateTyped(String expression, MuleMessage message);
}
| [No CFG could be retrieved] | Evaluate the given expression in the context of the given MuleMessage. | I think this should receive the event, not the message. I know that might lead to inconsistency with other similar classes and that it might even be impossible due to the contract that collaborators of this class might have. But I'd like to raise that point anyhow because MEL currently has issues because of this dualit... |
@@ -42,6 +42,8 @@ namespace ILCompiler.DependencyAnalysis.ReadyToRun
public MethodDesc Method => _method;
+ public List<ISymbolNode> TypesToPreload => _typesToPreload;
+
public bool IsEmpty => _methodCode.Data.Length == 0;
public override ObjectData GetData(NodeFactory factory, b... | [MethodWithGCInfo->[CompareToImpl->[Compare],GetName->[AppendMangledName]]] | Get the data for this object. | Some day we may want to place non-Types in this list. I'd like to see the name reflect that these are general purpose fixups, not just types. |
@@ -6,7 +6,7 @@ function withIsMobile(WrappedComponent) {
super(props)
this.onResize = this.onResize.bind(this)
this.state = {
- isMobile: false
+ isMobile: window.innerWidth < 768
}
}
| [No CFG could be retrieved] | Create a class that wraps a given component in a component that is rendered on a mobile device. | Can probably remove the call to `this.onResize` in `componentDidMount` |
@@ -24,13 +24,13 @@ try:
from google.cloud.proto.datastore.v1 import datastore_pb2
from google.cloud.proto.datastore.v1 import entity_pb2
from google.cloud.proto.datastore.v1 import query_pb2
+ from google.rpc import code_pb2
from googledatastore import PropertyFilter, CompositeFilter
from googledatasto... | [write_mutations->[commit->[commit],commit],QueryIterator->[__iter__->[_next_batch],__init__->[make_request]]] | Creates a new object. Returns 1 if k1 is the first element of k2 otherwise 0. | @sb2nov are we using `QUERY_NOT_FINISHED` in any place as a check for `gcp` extra package? |
@@ -147,7 +147,7 @@ path = ~/.conan/data
class ConanClientConfigParser(ConfigParser, object):
def __init__(self, filename):
- ConfigParser.__init__(self)
+ ConfigParser.__init__(self, allow_no_value=True)
self.read(filename)
self.filename = filename
| [ConanClientConfigParser->[default_profile->[get_item],request_timeout->[get_item],__init__->[__init__],cache_no_locks->[get_item],storage->[get_conf],proxies->[get_conf]]] | Initialize configuration from a file. | allow_no_value not used, right? |
@@ -224,6 +224,10 @@ func CreateInit(c *cobra.Command, vals entities.ContainerCreateOptions, isInfra
if c.Flags().Changed("pids-limit") {
val := c.Flag("pids-limit").Value.String()
+ // Convert -1 to 0, so that -1 maps to unlimited pids limit
+ if val == "-1" {
+ val = "0"
+ }
pidsLimit, err := st... | [StringVar,DefineCreateFlags,Pull,IsContainer,GetBool,NewPodSpecGenerator,ImageEngine,ParseNamespace,SetNormalizeFunc,StringInSlice,SetInterspersed,MarkHidden,HasPrefix,NewSpecGenerator,GetStringArray,ValidatePullPolicy,MinimumNArgs,New,ToPodSpecGen,Errorf,CreateCidFile,ParseInt,ContainerCreate,GetContext,SplitN,Define... | Check if the flags are set and return a populated object. if returns an error if any flags are not set. | Do we know if Docker does something special on 0? Do they treat it literally, and the container can't fork at all? |
@@ -407,6 +407,13 @@ public abstract class BaseLivyInterprereter extends Interpreter {
response = new ResponseEntity(e.getResponseBodyAsString(), e.getStatusCode());
LOGGER.error(String.format("Error with %s StatusCode: %s",
response.getStatusCode().value(), e.getResponseBodyAsString()));
+ ... | [BaseLivyInterprereter->[createSession->[getSessionInfo],CreateSessionRequest->[toJson->[toJson]],isSessionExpired->[getSessionInfo],LivyVersionResponse->[fromJson->[fromJson]],StatementInfo->[fromJson->[fromJson],StatementOutput->[toJson->[toJson]]],initLivySession->[getSessionKind],callRestAPI->[callRestAPI,getRestTe... | Call the REST API with the given parameters. Get the response body if it contains a . If it does return the response body. | how is `RestClientException` map to `kerberos`? |
@@ -5658,7 +5658,7 @@ def lambda_cost(input,
than the size of a list, the algorithm will sort the
entire list of get gradient.
:type max_sort_size: int
- :param name: The name of this layers. It is not necessary.
+ :param name: The name of this layer. It ... | [seq_concat_layer->[LayerOutput],out_prod_layer->[LayerOutput],img_pool_layer->[LayerOutput],multiplex_layer->[LayerOutput],cross_entropy->[LayerOutput,__cost_input__],multibox_loss_layer->[LayerOutput],gated_unit_layer->[fc_layer,dotmul_operator,mixed_layer],lstm_step_layer->[LayerOutput],clip_layer->[LayerOutput],Mix... | This function returns a lambda cost for the sequence sequence with NDCG. Returns an array of scores with the most likely score. | please change the sentence "It is not necessary." into "It is not required." The same below. |
@@ -112,6 +112,7 @@ public final class SqlServerQueryRunner
DistributedQueryRunner queryRunner = (DistributedQueryRunner) createSqlServerQueryRunner(
testingSqlServer,
+ ImmutableMap.of("http-server.http.port", "8080"),
ImmutableMap.of(),
Immu... | [SqlServerQueryRunner->[createSqlServerQueryRunner->[createSqlServerQueryRunner],main->[createSqlServerQueryRunner]]] | This method is called from the command line. | please add a commit message why it's needed |
@@ -3590,7 +3590,9 @@ public:
bool Validate(SpellInfo const* /*spell*/) override
{
- if (!sSpellMgr->GetSpellInfo(SPELL_CREATE_DEMON_BROILED_SURPRISE) || !sObjectMgr->GetCreatureTemplate(NPC_ABYSSAL_FLAMEBRINGER) || !sObjectMgr->GetQuestTemplate(QUEST_SUPER_HOT_STEW))
+ return ... | [No CFG could be retrieved] | Provides a base class for all of the types of a specific unit. Provides a check - requirements spell that can be cast to a specific type. | same here, check the code after the return |
@@ -168,12 +168,17 @@ public class VmwareStorageLayoutHelper implements Configurable {
public static String syncVolumeToVmDefaultFolder(DatacenterMO dcMo, String vmName, DatastoreMO ds, String vmdkName, String excludeFolders) throws Exception {
assert (ds != null);
+
if (!ds.folderExists(String... | [VmwareStorageLayoutHelper->[deleteVolumeVmdkFiles->[deleteVolumeVmdkFiles],findVolumeDatastoreFullPath->[findVolumeDatastoreFullPath],syncVolumeToRootFolder->[syncVolumeToRootFolder],syncVolumeToVmDefaultFolder->[getVmdkFilePairDatastorePath,syncVolumeToVmDefaultFolder]]] | Synchronize the volume to the default folder of a VM. vmdkFullCloneModePair - > vmdkLinkedCloneModePair - >. | use the constant "HypervisorHostHelper.VSPHERE_DATASTORE_BASE_FOLDER" for "_fcd_" |
@@ -75,7 +75,7 @@ namespace DotNetNuke.Services.Installer.Installers
}
catch (Exception ex)
{
- Log.AddFailure(ex);
+ Log.AddWarning(string.Format(Util.CLEANUP_ProcessComplete, ex.Message));
//DNN-9202: MUST NOT fail installation when... | [CleanupInstaller->[Install->[CleanupFile,ProcessCleanupFile],Commit->[Commit],ReadManifest->[ReadManifest]]] | ProcessCleanupFile - Cleanup file. | is this supposed to be using the `CLEANUP_ProcessError` field you defined below? |
@@ -1685,11 +1685,12 @@ exit:
if (put_needed)
iv_ops->ivo_on_put(ivns, iv_value, user_priv);
- D_ERROR("Failed to issue IV fetch; rc = %d\n", rc);
+ D_ERROR("Failed to issue IV fetch; rc = " DF_RC "\n",
+ DP_RC(rc));
if (cb_info) {
IVNS_DECREF(cb_info->ifc_ivns_internal);
- D_FREE_PTR(cb_info);
... | [No CFG could be retrieved] | This function is called when the user enters the root of the tree. This function is called by the HD - API to handle the initialization of the object. | could this be changed to this format to be consistent with most of the other changes in the patch? D_ERROR("Issue IV fetch failed, " DF_RC "\n", DP_RC(rc)); or maybe this is different because we are not reporting a specific function_name() in the output? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.